blob: ab2d5c1ddf0739fd441ef16b24e93892e5bcf758 [file] [log] [blame]
Dan Albert4ae5d4b2014-10-31 16:23:08 -07001##############################################
2## Perform configuration steps for sanitizers.
3##############################################
4
Dan Albert27ccb752015-04-16 16:21:02 -07005my_sanitize := $(strip $(LOCAL_SANITIZE))
Vishwath Mohan8dcfdce2017-01-18 17:50:29 -08006my_sanitize_diag := $(strip $(LOCAL_SANITIZE_DIAG))
Dan Albert08cca282014-12-11 18:56:26 -08007
Dan Albert4c401412015-08-19 20:13:33 -07008my_global_sanitize :=
Ivan Lozano4a363732017-06-28 09:11:26 -07009my_global_sanitize_diag :=
Dan Willemsenf0638392018-09-04 22:25:22 -070010ifdef LOCAL_IS_HOST_MODULE
11 ifneq ($($(my_prefix)OS),windows)
12 my_global_sanitize := $(strip $(SANITIZE_HOST))
Dan Albert4c401412015-08-19 20:13:33 -070013
Dan Willemsenf0638392018-09-04 22:25:22 -070014 # SANITIZE_HOST=true is a deprecated way to say SANITIZE_HOST=address.
15 my_global_sanitize := $(subst true,address,$(my_global_sanitize))
Dan Albert4c401412015-08-19 20:13:33 -070016 endif
Dan Willemsenf0638392018-09-04 22:25:22 -070017else
18 my_global_sanitize := $(strip $(SANITIZE_TARGET))
19 my_global_sanitize_diag := $(strip $(SANITIZE_TARGET_DIAG))
Dan Albert4c401412015-08-19 20:13:33 -070020endif
21
Ivan Lozanob4749cb2017-07-21 10:33:32 -070022# Disable global integer_overflow in excluded paths.
23ifneq ($(filter integer_overflow, $(my_global_sanitize)),)
24 combined_exclude_paths := $(INTEGER_OVERFLOW_EXCLUDE_PATHS) \
25 $(PRODUCT_INTEGER_OVERFLOW_EXCLUDE_PATHS)
26
27 ifneq ($(strip $(foreach dir,$(subst $(comma),$(space),$(combined_exclude_paths)),\
28 $(filter $(dir)%,$(LOCAL_PATH)))),)
29 my_global_sanitize := $(filter-out integer_overflow,$(my_global_sanitize))
30 my_global_sanitize_diag := $(filter-out integer_overflow,$(my_global_sanitize_diag))
31 endif
32endif
33
Ivan Lozano702e8bd2018-03-15 14:49:20 -070034# Global integer sanitization doesn't support static modules.
35ifeq ($(filter SHARED_LIBRARIES EXECUTABLES,$(LOCAL_MODULE_CLASS)),)
36 my_global_sanitize := $(filter-out integer_overflow,$(my_global_sanitize))
37 my_global_sanitize_diag := $(filter-out integer_overflow,$(my_global_sanitize_diag))
38endif
39ifeq ($(LOCAL_FORCE_STATIC_EXECUTABLE),true)
40 my_global_sanitize := $(filter-out integer_overflow,$(my_global_sanitize))
41 my_global_sanitize_diag := $(filter-out integer_overflow,$(my_global_sanitize_diag))
42endif
43
Vishwath Mohan23b2d2e2017-10-31 02:25:16 -070044# Disable global CFI in excluded paths
45ifneq ($(filter cfi, $(my_global_sanitize)),)
46 combined_exclude_paths := $(CFI_EXCLUDE_PATHS) \
47 $(PRODUCT_CFI_EXCLUDE_PATHS)
48
49 ifneq ($(strip $(foreach dir,$(subst $(comma),$(space),$(combined_exclude_paths)),\
50 $(filter $(dir)%,$(LOCAL_PATH)))),)
51 my_global_sanitize := $(filter-out cfi,$(my_global_sanitize))
52 my_global_sanitize_diag := $(filter-out cfi,$(my_global_sanitize_diag))
53 endif
54endif
55
Evgenii Stepanov3330b2f2021-01-13 12:14:55 -080056# Disable global memtag_heap in excluded paths
57ifneq ($(filter memtag_heap, $(my_global_sanitize)),)
58 combined_exclude_paths := $(MEMTAG_HEAP_EXCLUDE_PATHS) \
59 $(PRODUCT_MEMTAG_HEAP_EXCLUDE_PATHS)
60
61 ifneq ($(strip $(foreach dir,$(subst $(comma),$(space),$(combined_exclude_paths)),\
62 $(filter $(dir)%,$(LOCAL_PATH)))),)
63 my_global_sanitize := $(filter-out memtag_heap,$(my_global_sanitize))
64 my_global_sanitize_diag := $(filter-out memtag_heap,$(my_global_sanitize_diag))
65 endif
66endif
67
Tomislav Novakd8febc92023-08-22 10:51:36 -070068# Disable global HWASan in excluded paths
69ifneq ($(filter hwaddress, $(my_global_sanitize)),)
70 combined_exclude_paths := $(HWASAN_EXCLUDE_PATHS) \
71 $(PRODUCT_HWASAN_EXCLUDE_PATHS)
72
73 ifneq ($(strip $(foreach dir,$(subst $(comma),$(space),$(combined_exclude_paths)),\
74 $(filter $(dir)%,$(LOCAL_PATH)))),)
75 my_global_sanitize := $(filter-out hwaddress,$(my_global_sanitize))
76 my_global_sanitize_diag := $(filter-out hwaddress,$(my_global_sanitize_diag))
77 endif
78endif
79
Dan Albert4c401412015-08-19 20:13:33 -070080ifneq ($(my_global_sanitize),)
Evgenii Stepanov71faa192016-05-19 17:45:21 -070081 my_sanitize := $(my_global_sanitize) $(my_sanitize)
Dan Albert4c401412015-08-19 20:13:33 -070082endif
Ivan Lozano4a363732017-06-28 09:11:26 -070083ifneq ($(my_global_sanitize_diag),)
84 my_sanitize_diag := $(my_global_sanitize_diag) $(my_sanitize_diag)
85endif
Dan Albert4c401412015-08-19 20:13:33 -070086
Andreas Gampe6b30d772016-06-27 15:15:31 -070087# The sanitizer specified in the product configuration wins over the previous.
88ifneq ($(SANITIZER.$(TARGET_PRODUCT).$(LOCAL_MODULE).CONFIG),)
89 my_sanitize := $(SANITIZER.$(TARGET_PRODUCT).$(LOCAL_MODULE).CONFIG)
90 ifeq ($(my_sanitize),never)
91 my_sanitize :=
Ivan Lozano4a363732017-06-28 09:11:26 -070092 my_sanitize_diag :=
Andreas Gampe6b30d772016-06-27 15:15:31 -070093 endif
94endif
95
Colin Cross23618422016-11-02 15:05:21 -070096ifndef LOCAL_IS_HOST_MODULE
97 # Add a filter point for 32-bit vs 64-bit sanitization (to lighten the burden)
98 SANITIZE_TARGET_ARCH ?= $(TARGET_ARCH) $(TARGET_2ND_ARCH)
99 ifeq ($(filter $(SANITIZE_TARGET_ARCH),$(TARGET_$(LOCAL_2ND_ARCH_VAR_PREFIX)ARCH)),)
100 my_sanitize :=
Ivan Lozano4a363732017-06-28 09:11:26 -0700101 my_sanitize_diag :=
Colin Cross23618422016-11-02 15:05:21 -0700102 endif
Andreas Gampecd257402016-06-20 17:36:49 -0700103endif
104
Andreas Gampe3d3b0c92016-06-20 17:46:29 -0700105# Add a filter point based on module owner (to lighten the burden). The format is a space- or
106# colon-separated list of owner names.
107ifneq (,$(SANITIZE_NEVER_BY_OWNER))
108 ifneq (,$(LOCAL_MODULE_OWNER))
109 ifneq (,$(filter $(LOCAL_MODULE_OWNER),$(subst :, ,$(SANITIZE_NEVER_BY_OWNER))))
110 $(warning Not sanitizing $(LOCAL_MODULE) based on module owner.)
111 my_sanitize :=
Ivan Lozano4a363732017-06-28 09:11:26 -0700112 my_sanitize_diag :=
Andreas Gampe3d3b0c92016-06-20 17:46:29 -0700113 endif
114 endif
115endif
116
Dan Albert08cca282014-12-11 18:56:26 -0800117# Don't apply sanitizers to NDK code.
118ifdef LOCAL_SDK_VERSION
Dan Albert4c401412015-08-19 20:13:33 -0700119 my_sanitize :=
Dan Willemsenf761c0f2016-06-28 16:47:43 -0700120 my_global_sanitize :=
Ivan Lozano4a363732017-06-28 09:11:26 -0700121 my_sanitize_diag :=
Dan Albert27ccb752015-04-16 16:21:02 -0700122endif
123
Dan Albert4c401412015-08-19 20:13:33 -0700124# Never always wins.
125ifeq ($(LOCAL_SANITIZE),never)
Dan Albert08cca282014-12-11 18:56:26 -0800126 my_sanitize :=
Ivan Lozano4a363732017-06-28 09:11:26 -0700127 my_sanitize_diag :=
Dan Albert08cca282014-12-11 18:56:26 -0800128endif
129
Elvis Chien064d91c2021-04-14 17:02:29 +0800130# Enable CFI in included paths.
Vishwath Mohan23b2d2e2017-10-31 02:25:16 -0700131ifeq ($(filter cfi, $(my_sanitize)),)
Elvis Chien064d91c2021-04-14 17:02:29 +0800132 combined_include_paths := $(CFI_INCLUDE_PATHS) \
133 $(PRODUCT_CFI_INCLUDE_PATHS)
134 combined_exclude_paths := $(CFI_EXCLUDE_PATHS) \
135 $(PRODUCT_CFI_EXCLUDE_PATHS)
Vishwath Mohan23b2d2e2017-10-31 02:25:16 -0700136
Elvis Chien064d91c2021-04-14 17:02:29 +0800137 ifneq ($(strip $(foreach dir,$(subst $(comma),$(space),$(combined_include_paths)),\
138 $(filter $(dir)%,$(LOCAL_PATH)))),)
139 ifeq ($(strip $(foreach dir,$(subst $(comma),$(space),$(combined_exclude_paths)),\
140 $(filter $(dir)%,$(LOCAL_PATH)))),)
141 my_sanitize := cfi $(my_sanitize)
Vishwath Mohan6106a4e2018-05-24 18:04:25 -0700142 endif
Vishwath Mohan23b2d2e2017-10-31 02:25:16 -0700143 endif
144endif
145
Evgenii Stepanov3330b2f2021-01-13 12:14:55 -0800146# Enable memtag_heap in included paths (for Arm64 only).
147ifeq ($(filter memtag_heap, $(my_sanitize)),)
148 ifneq ($(filter arm64,$(TARGET_$(LOCAL_2ND_ARCH_VAR_PREFIX)ARCH)),)
149 combined_sync_include_paths := $(MEMTAG_HEAP_SYNC_INCLUDE_PATHS) \
150 $(PRODUCT_MEMTAG_HEAP_SYNC_INCLUDE_PATHS)
151 combined_async_include_paths := $(MEMTAG_HEAP_ASYNC_INCLUDE_PATHS) \
152 $(PRODUCT_MEMTAG_HEAP_ASYNC_INCLUDE_PATHS)
Evgenii Stepanov13bc2272021-04-09 14:52:33 -0700153 combined_exclude_paths := $(MEMTAG_HEAP_EXCLUDE_PATHS) \
154 $(PRODUCT_MEMTAG_HEAP_EXCLUDE_PATHS)
Evgenii Stepanov80b53b82023-06-08 15:40:39 -0700155 ifneq ($(PRODUCT_MEMTAG_HEAP_SKIP_DEFAULT_PATHS),true)
156 combined_sync_include_paths += $(PRODUCT_MEMTAG_HEAP_SYNC_DEFAULT_INCLUDE_PATHS)
157 combined_async_include_paths += $(PRODUCT_MEMTAG_HEAP_ASYNC_DEFAULT_INCLUDE_PATHS)
158 endif
Evgenii Stepanov3330b2f2021-01-13 12:14:55 -0800159
Evgenii Stepanov13bc2272021-04-09 14:52:33 -0700160 ifeq ($(strip $(foreach dir,$(subst $(comma),$(space),$(combined_exclude_paths)),\
161 $(filter $(dir)%,$(LOCAL_PATH)))),)
162 ifneq ($(strip $(foreach dir,$(subst $(comma),$(space),$(combined_sync_include_paths)),\
163 $(filter $(dir)%,$(LOCAL_PATH)))),)
164 my_sanitize := memtag_heap $(my_sanitize)
165 my_sanitize_diag := memtag_heap $(my_sanitize_diag)
166 else ifneq ($(strip $(foreach dir,$(subst $(comma),$(space),$(combined_async_include_paths)),\
167 $(filter $(dir)%,$(LOCAL_PATH)))),)
168 my_sanitize := memtag_heap $(my_sanitize)
169 endif
Evgenii Stepanov3330b2f2021-01-13 12:14:55 -0800170 endif
171 endif
172endif
173
Hang Lue235ded2022-08-29 14:42:34 +0800174# Enable HWASan in included paths.
175ifeq ($(filter hwaddress, $(my_sanitize)),)
176 combined_include_paths := $(HWASAN_INCLUDE_PATHS) \
177 $(PRODUCT_HWASAN_INCLUDE_PATHS)
178
179 ifneq ($(strip $(foreach dir,$(subst $(comma),$(space),$(combined_include_paths)),\
180 $(filter $(dir)%,$(LOCAL_PATH)))),)
181 my_sanitize := hwaddress $(my_sanitize)
182 endif
183endif
184
Vishwath Mohan8dcfdce2017-01-18 17:50:29 -0800185# If CFI is disabled globally, remove it from my_sanitize.
Vishwath Mohan45665b42017-01-24 13:20:28 -0800186ifeq ($(strip $(ENABLE_CFI)),false)
Vishwath Mohan8dcfdce2017-01-18 17:50:29 -0800187 my_sanitize := $(filter-out cfi,$(my_sanitize))
188 my_sanitize_diag := $(filter-out cfi,$(my_sanitize_diag))
189endif
190
Florian Mayer548a2ad2022-08-31 22:25:55 +0000191# Also disable CFI and MTE if ASAN is enabled.
Vishwath Mohanc026f6d2017-04-20 07:39:13 -0700192ifneq ($(filter address,$(my_sanitize)),)
193 my_sanitize := $(filter-out cfi,$(my_sanitize))
Florian Mayer548a2ad2022-08-31 22:25:55 +0000194 my_sanitize := $(filter-out memtag_stack,$(my_sanitize))
Mitch Phillips8520f4b2023-06-01 14:22:32 +0200195 my_sanitize := $(filter-out memtag_globals,$(my_sanitize))
Florian Mayer548a2ad2022-08-31 22:25:55 +0000196 my_sanitize := $(filter-out memtag_heap,$(my_sanitize))
Vishwath Mohanc026f6d2017-04-20 07:39:13 -0700197 my_sanitize_diag := $(filter-out cfi,$(my_sanitize_diag))
198endif
199
Mitch Phillipsb71a8752021-05-19 11:29:02 -0700200# Disable memtag for host targets. Host executables in AndroidMk files are
201# deprecated, but some partners still have them floating around.
202ifdef LOCAL_IS_HOST_MODULE
Mitch Phillips8520f4b2023-06-01 14:22:32 +0200203 my_sanitize := $(filter-out memtag_heap memtag_stack memtag_globals,$(my_sanitize))
204 my_sanitize_diag := $(filter-out memtag_heap memtag_stack memtag_globals,$(my_sanitize_diag))
Mitch Phillipsb71a8752021-05-19 11:29:02 -0700205endif
206
Ivan Lozano702e8bd2018-03-15 14:49:20 -0700207# Disable sanitizers which need the UBSan runtime for host targets.
Vishwath Mohan96a130b2017-11-17 11:19:36 -0800208ifdef LOCAL_IS_HOST_MODULE
209 my_sanitize := $(filter-out cfi,$(my_sanitize))
210 my_sanitize_diag := $(filter-out cfi,$(my_sanitize_diag))
Ivan Lozano702e8bd2018-03-15 14:49:20 -0700211 my_sanitize := $(filter-out signed-integer-overflow unsigned-integer-overflow integer_overflow,$(my_sanitize))
212 my_sanitize_diag := $(filter-out signed-integer-overflow unsigned-integer-overflow integer_overflow,$(my_sanitize_diag))
Vishwath Mohan96a130b2017-11-17 11:19:36 -0800213endif
214
Ivan Lozano4a363732017-06-28 09:11:26 -0700215# Support for local sanitize blacklist paths.
216ifneq ($(my_sanitize)$(my_global_sanitize),)
Pirama Arumuga Nainar56558332020-07-30 15:18:07 -0700217 ifneq ($(LOCAL_SANITIZE_BLOCKLIST),)
218 my_cflags += -fsanitize-blacklist=$(LOCAL_PATH)/$(LOCAL_SANITIZE_BLOCKLIST)
219 endif
Ivan Lozano4a363732017-06-28 09:11:26 -0700220endif
221
Ivan Lozanob4749cb2017-07-21 10:33:32 -0700222# Disable integer_overflow if LOCAL_NOSANITIZE=integer.
Ivan Lozano4a363732017-06-28 09:11:26 -0700223ifneq ($(filter integer_overflow, $(my_global_sanitize) $(my_sanitize)),)
224 ifneq ($(filter integer, $(strip $(LOCAL_NOSANITIZE))),)
225 my_sanitize := $(filter-out integer_overflow,$(my_sanitize))
226 my_sanitize_diag := $(filter-out integer_overflow,$(my_sanitize_diag))
227 endif
228endif
229
Evgenii Stepanov42823662016-05-12 13:07:17 -0700230my_nosanitize = $(strip $(LOCAL_NOSANITIZE))
231ifneq ($(my_nosanitize),)
232 my_sanitize := $(filter-out $(my_nosanitize),$(my_sanitize))
233endif
234
Evgenii Stepanov8841a7f2018-07-27 11:54:32 -0700235ifneq ($(filter arm x86 x86_64,$(TARGET_$(LOCAL_2ND_ARCH_VAR_PREFIX)ARCH)),)
236 my_sanitize := $(filter-out hwaddress,$(my_sanitize))
Evgenii Stepanov3330b2f2021-01-13 12:14:55 -0800237 my_sanitize := $(filter-out memtag_heap,$(my_sanitize))
Florian Mayer548a2ad2022-08-31 22:25:55 +0000238 my_sanitize := $(filter-out memtag_stack,$(my_sanitize))
Mitch Phillips8520f4b2023-06-01 14:22:32 +0200239 my_sanitize := $(filter-out memtag_globals,$(my_sanitize))
Evgenii Stepanov8841a7f2018-07-27 11:54:32 -0700240endif
241
242ifneq ($(filter hwaddress,$(my_sanitize)),)
243 my_sanitize := $(filter-out address,$(my_sanitize))
Florian Mayer548a2ad2022-08-31 22:25:55 +0000244 my_sanitize := $(filter-out memtag_stack,$(my_sanitize))
Mitch Phillips8520f4b2023-06-01 14:22:32 +0200245 my_sanitize := $(filter-out memtag_globals,$(my_sanitize))
Florian Mayer548a2ad2022-08-31 22:25:55 +0000246 my_sanitize := $(filter-out memtag_heap,$(my_sanitize))
Evgenii Stepanov8841a7f2018-07-27 11:54:32 -0700247 my_sanitize := $(filter-out thread,$(my_sanitize))
Evgenii Stepanov88a95a32018-12-04 17:06:45 -0800248 my_sanitize := $(filter-out cfi,$(my_sanitize))
Evgenii Stepanov8841a7f2018-07-27 11:54:32 -0700249endif
250
251ifneq ($(filter hwaddress,$(my_sanitize)),)
252 my_shared_libraries += $($(LOCAL_2ND_ARCH_VAR_PREFIX)HWADDRESS_SANITIZER_RUNTIME_LIBRARY)
Evgenii Stepanoved907462018-11-01 15:43:14 -0700253 ifneq ($(filter EXECUTABLES NATIVE_TESTS,$(LOCAL_MODULE_CLASS)),)
Evgenii Stepanov8841a7f2018-07-27 11:54:32 -0700254 ifeq ($(LOCAL_FORCE_STATIC_EXECUTABLE),true)
Ryan Prichardacf8b0f2019-10-21 20:47:53 -0700255 my_static_libraries := $(my_static_libraries) \
256 $($(LOCAL_2ND_ARCH_VAR_PREFIX)HWADDRESS_SANITIZER_STATIC_LIBRARY) \
257 libdl
Evgenii Stepanov8841a7f2018-07-27 11:54:32 -0700258 endif
259 endif
260endif
261
Mitch Phillips8520f4b2023-06-01 14:22:32 +0200262ifneq ($(filter memtag_heap memtag_stack memtag_globals,$(my_sanitize)),)
Florian Mayer548a2ad2022-08-31 22:25:55 +0000263 ifneq ($(filter memtag_heap,$(my_sanitize_diag)),)
Evgenii Stepanov8566eb02024-02-01 11:34:59 -0800264 my_ldflags += -fsanitize-memtag-mode=sync
Florian Mayer548a2ad2022-08-31 22:25:55 +0000265 my_sanitize_diag := $(filter-out memtag_heap,$(my_sanitize_diag))
266 else
Evgenii Stepanov8566eb02024-02-01 11:34:59 -0800267 my_ldflags += -fsanitize-memtag-mode=async
Florian Mayerfe3e5372022-08-31 18:37:51 +0000268 endif
Florian Mayer548a2ad2022-08-31 22:25:55 +0000269endif
270
Florian Mayer2a676262023-06-07 15:02:22 -0700271# Ignore SANITIZE_TARGET_DIAG=memtag_heap without SANITIZE_TARGET=memtag_heap
272# This can happen if a condition above filters out memtag_heap from
273# my_sanitize. It is easier to handle all of these cases here centrally.
274ifneq ($(filter memtag_heap,$(my_sanitize_diag)),)
275 my_sanitize_diag := $(filter-out memtag_heap,$(my_sanitize_diag))
276endif
277
Florian Mayer548a2ad2022-08-31 22:25:55 +0000278ifneq ($(filter memtag_heap,$(my_sanitize)),)
279 my_cflags += -fsanitize=memtag-heap
Evgenii Stepanov8566eb02024-02-01 11:34:59 -0800280 my_ldflags += -fsanitize=memtag-heap
Evgenii Stepanov3330b2f2021-01-13 12:14:55 -0800281 my_sanitize := $(filter-out memtag_heap,$(my_sanitize))
282endif
283
Florian Mayer548a2ad2022-08-31 22:25:55 +0000284ifneq ($(filter memtag_stack,$(my_sanitize)),)
285 my_cflags += -fsanitize=memtag-stack
Evgenii Stepanov8566eb02024-02-01 11:34:59 -0800286 my_ldflags += -fsanitize=memtag-stack
Florian Mayer548a2ad2022-08-31 22:25:55 +0000287 my_cflags += -march=armv8a+memtag
288 my_ldflags += -march=armv8a+memtag
289 my_asflags += -march=armv8a+memtag
290 my_sanitize := $(filter-out memtag_stack,$(my_sanitize))
291endif
Evgenii Stepanov3330b2f2021-01-13 12:14:55 -0800292
Mitch Phillips8520f4b2023-06-01 14:22:32 +0200293ifneq ($(filter memtag_globals,$(my_sanitize)),)
294 my_cflags += -fsanitize=memtag-globals
Evgenii Stepanov8566eb02024-02-01 11:34:59 -0800295 my_ldflags += -fsanitize=memtag-globals
Mitch Phillips8520f4b2023-06-01 14:22:32 +0200296 # TODO(mitchp): For now, enable memtag-heap with memtag-globals because the
297 # linker isn't new enough
298 # (https://reviews.llvm.org/differential/changeset/?ref=4243566).
299 my_sanitize := $(filter-out memtag_globals,$(my_sanitize))
300endif
301
Dan Alberta6311b72015-07-30 10:17:33 -0700302# TSAN is not supported on 32-bit architectures. For non-multilib cases, make
303# its use an error. For multilib cases, don't use it for the 32-bit case.
304ifneq ($(filter thread,$(my_sanitize)),)
305 ifeq ($(my_32_64_bit_suffix),32)
306 ifeq ($(my_module_multilib),both)
307 my_sanitize := $(filter-out thread,$(my_sanitize))
308 else
309 $(error $(LOCAL_PATH): $(LOCAL_MODULE): TSAN cannot be used for 32-bit modules.)
310 endif
Yabin Cuie77c32e2017-10-19 14:33:58 -0700311 else
312 my_shared_libraries += $(TSAN_RUNTIME_LIBRARY)
Dan Alberta6311b72015-07-30 10:17:33 -0700313 endif
314endif
315
Evgenii Stepanov7dcb8b82016-05-06 18:15:57 -0700316ifneq ($(filter safe-stack,$(my_sanitize)),)
317 ifeq ($(my_32_64_bit_suffix),32)
318 my_sanitize := $(filter-out safe-stack,$(my_sanitize))
319 endif
320endif
321
Kostya Kortchinsky2cfa9972018-06-14 11:02:15 -0700322# Disable Scudo if ASan or TSan is enabled.
Evgenii Stepanov8841a7f2018-07-27 11:54:32 -0700323ifneq ($(filter address thread hwaddress,$(my_sanitize)),)
Kostya Kortchinsky2cfa9972018-06-14 11:02:15 -0700324 my_sanitize := $(filter-out scudo,$(my_sanitize))
325endif
326
Kostya Kortchinsky02732402019-02-01 09:06:42 -0800327# Or if disabled globally.
Anton Hansson8dab0a62019-03-28 15:45:40 +0000328ifeq ($(PRODUCT_DISABLE_SCUDO),true)
Kostya Kortchinsky02732402019-02-01 09:06:42 -0800329 my_sanitize := $(filter-out scudo,$(my_sanitize))
330endif
331
Evgenii Stepanov5adfcb12015-06-25 16:38:25 -0700332# Undefined symbols can occur if a non-sanitized library links
333# sanitized static libraries. That's OK, because the executable
334# always depends on the ASan runtime library, which defines these
335# symbols.
Evgenii Stepanov912b51f2016-05-19 17:49:51 -0700336ifneq ($(filter address thread,$(strip $(SANITIZE_TARGET))),)
Evgenii Stepanov5adfcb12015-06-25 16:38:25 -0700337 ifndef LOCAL_IS_HOST_MODULE
338 ifeq ($(LOCAL_MODULE_CLASS),SHARED_LIBRARIES)
339 ifeq ($(my_sanitize),)
340 my_allow_undefined_symbols := true
341 endif
342 endif
343 endif
344endif
345
Dan Albertb5b2ffe2015-04-16 18:07:07 -0700346ifneq ($(filter default-ub,$(my_sanitize)),)
347 my_sanitize := $(CLANG_DEFAULT_UB_CHECKS)
Dan Albert08cca282014-12-11 18:56:26 -0800348endif
349
Mitch Phillipsee8f4a02019-05-01 14:37:33 -0700350ifneq ($(filter fuzzer,$(my_sanitize)),)
351 # SANITIZE_TARGET='fuzzer' actually means to create the fuzzer coverage
352 # information, not to link against the fuzzer main().
353 my_sanitize := $(filter-out fuzzer,$(my_sanitize))
354 my_sanitize += fuzzer-no-link
Mitch Phillipsd51048a2022-03-02 01:25:22 +0000355
356 # TODO(b/131771163): Disable LTO for fuzzer builds. Note that Cfi causes
357 # dependency on LTO.
358 my_sanitize := $(filter-out cfi,$(my_sanitize))
359 my_cflags += -fno-lto
360 my_ldflags += -fno-lto
Joey Jiao0e6d1c92023-11-30 07:34:18 +0530361
362 # TODO(b/142430592): Upstream linker scripts for sanitizer runtime libraries
363 # discard the sancov_lowest_stack symbol, because it's emulated TLS (and thus
364 # doesn't match the linker script due to the "__emutls_v." prefix).
365 my_cflags += -fno-sanitize-coverage=stack-depth
366 my_ldflags += -fno-sanitize-coverage=stack-depth
Ivan Krasin74b32b82015-09-18 11:54:43 -0700367endif
368
Ivan Lozano4a363732017-06-28 09:11:26 -0700369ifneq ($(filter integer_overflow,$(my_sanitize)),)
Ivan Lozano702e8bd2018-03-15 14:49:20 -0700370 # Respect LOCAL_NOSANITIZE for integer-overflow flags.
371 ifeq ($(filter signed-integer-overflow, $(strip $(LOCAL_NOSANITIZE))),)
372 my_sanitize += signed-integer-overflow
373 endif
374 ifeq ($(filter unsigned-integer-overflow, $(strip $(LOCAL_NOSANITIZE))),)
375 my_sanitize += unsigned-integer-overflow
376 endif
377 my_cflags += $(INTEGER_OVERFLOW_EXTRA_CFLAGS)
Ivan Lozano4a363732017-06-28 09:11:26 -0700378
Ivan Lozano702e8bd2018-03-15 14:49:20 -0700379 # Check for diagnostics mode.
380 ifneq ($(filter integer_overflow,$(my_sanitize_diag)),)
381 ifneq ($(filter SHARED_LIBRARIES EXECUTABLES,$(LOCAL_MODULE_CLASS)),)
382 ifneq ($(LOCAL_FORCE_STATIC_EXECUTABLE),true)
Ivan Lozano911cb992018-02-21 13:41:05 -0800383 my_sanitize_diag += signed-integer-overflow
384 my_sanitize_diag += unsigned-integer-overflow
Ivan Lozano702e8bd2018-03-15 14:49:20 -0700385 else
386 $(call pretty-error,Make cannot apply integer overflow diagnostics to static binary.)
Ivan Lozano4a363732017-06-28 09:11:26 -0700387 endif
Ivan Lozano702e8bd2018-03-15 14:49:20 -0700388 else
389 $(call pretty-error,Make cannot apply integer overflow diagnostics to static library.)
Ivan Lozano4a363732017-06-28 09:11:26 -0700390 endif
391 endif
392 my_sanitize := $(filter-out integer_overflow,$(my_sanitize))
393endif
394
395# Makes sure integer_overflow diagnostics is removed from the diagnostics list
396# even if integer_overflow is not set for some reason.
397ifneq ($(filter integer_overflow,$(my_sanitize_diag)),)
398 my_sanitize_diag := $(filter-out integer_overflow,$(my_sanitize_diag))
399endif
400
Dan Albert08cca282014-12-11 18:56:26 -0800401ifneq ($(my_sanitize),)
Stephen Hinese8119e92015-11-09 16:32:11 -0800402 fsanitize_arg := $(subst $(space),$(comma),$(my_sanitize))
Dan Albert08cca282014-12-11 18:56:26 -0800403 my_cflags += -fsanitize=$(fsanitize_arg)
Evgenii Stepanov9b82b3f2018-08-31 12:57:26 -0700404 my_asflags += -fsanitize=$(fsanitize_arg)
Dan Albert08cca282014-12-11 18:56:26 -0800405
Mitch Phillipsee8f4a02019-05-01 14:37:33 -0700406 # When fuzzing, we wish to crash with diagnostics on any bug.
407 ifneq ($(filter fuzzer-no-link,$(my_sanitize)),)
408 my_cflags += -fno-sanitize-trap=all
409 my_cflags += -fno-sanitize-recover=all
410 my_ldflags += -fsanitize=fuzzer-no-link
411 else ifdef LOCAL_IS_HOST_MODULE
Dan Albertabf4bc92015-06-16 23:27:34 -0700412 my_cflags += -fno-sanitize-recover=all
Dan Albert08cca282014-12-11 18:56:26 -0800413 my_ldflags += -fsanitize=$(fsanitize_arg)
Dan Albertabf4bc92015-06-16 23:27:34 -0700414 else
Evgenii Stepanov71faa192016-05-19 17:45:21 -0700415 my_cflags += -fsanitize-trap=all
Evgenii Stepanov55f73e62016-05-12 13:07:36 -0700416 ifneq ($(filter address thread,$(my_sanitize)),)
Evgenii Stepanov71faa192016-05-19 17:45:21 -0700417 my_cflags += -fno-sanitize-trap=address,thread
Evgenii Stepanov55f73e62016-05-12 13:07:36 -0700418 my_shared_libraries += libdl
419 endif
Dan Albert08cca282014-12-11 18:56:26 -0800420 endif
421endif
422
Evgenii Stepanov202c7a72016-07-07 10:56:39 -0700423ifneq ($(filter cfi,$(my_sanitize)),)
Evgenii Stepanov81bea1b2017-01-20 14:12:08 -0800424 # __cfi_check needs to be built as Thumb (see the code in linker_cfi.cpp).
425 # LLVM is not set up to do this on a function basis, so force Thumb on the
426 # entire module.
427 LOCAL_ARM_MODE := thumb
Vishwath Mohan5b69c062017-02-14 07:55:37 -0800428 my_cflags += $(CFI_EXTRA_CFLAGS)
Evgenii Stepanov9b82b3f2018-08-31 12:57:26 -0700429 my_asflags += $(CFI_EXTRA_ASFLAGS)
Vishwath Mohan85f72442017-11-01 09:21:20 +0000430 # Only append the default visibility flag if -fvisibility has not already been
431 # set to hidden.
432 ifeq ($(filter -fvisibility=hidden,$(LOCAL_CFLAGS)),)
433 my_cflags += -fvisibility=default
434 endif
Vishwath Mohan5b69c062017-02-14 07:55:37 -0800435 my_ldflags += $(CFI_EXTRA_LDFLAGS)
Vishwath Mohan85f72442017-11-01 09:21:20 +0000436
437 ifeq ($(LOCAL_FORCE_STATIC_EXECUTABLE),true)
438 my_ldflags := $(filter-out -fsanitize-cfi-cross-dso,$(my_ldflags))
439 my_cflags := $(filter-out -fsanitize-cfi-cross-dso,$(my_cflags))
440 else
441 # Apply the version script to non-static executables
442 my_ldflags += -Wl,--version-script,build/soong/cc/config/cfi_exports.map
443 LOCAL_ADDITIONAL_DEPENDENCIES += build/soong/cc/config/cfi_exports.map
444 endif
Evgenii Stepanov202c7a72016-07-07 10:56:39 -0700445endif
446
Chih-Hung Hsiehad741e62016-03-09 14:54:55 -0800447# If local or global modules need ASAN, add linker flags.
448ifneq ($(filter address,$(my_global_sanitize) $(my_sanitize)),)
Dan Albert4ae5d4b2014-10-31 16:23:08 -0700449 my_ldflags += $(ADDRESS_SANITIZER_CONFIG_EXTRA_LDFLAGS)
450 ifdef LOCAL_IS_HOST_MODULE
Dan Albert08cca282014-12-11 18:56:26 -0800451 # -nodefaultlibs (provided with libc++) prevents the driver from linking
452 # libraries needed with -fsanitize=address. http://b/18650275 (WAI)
Dan Albert1f0d5302015-04-28 14:55:50 -0700453 my_ldflags += -Wl,--no-as-needed
Dan Albert4ae5d4b2014-10-31 16:23:08 -0700454 else
Chih-Hung Hsiehad741e62016-03-09 14:54:55 -0800455 # Add asan libraries unless LOCAL_MODULE is the asan library.
Evgenii Stepanovf0b15e12015-04-24 16:34:47 -0700456 # ASan runtime library must be the first in the link order.
Chih-Hung Hsiehad741e62016-03-09 14:54:55 -0800457 ifeq (,$(filter $(LOCAL_MODULE),$($(LOCAL_2ND_ARCH_VAR_PREFIX)ADDRESS_SANITIZER_RUNTIME_LIBRARY)))
458 my_shared_libraries := $($(LOCAL_2ND_ARCH_VAR_PREFIX)ADDRESS_SANITIZER_RUNTIME_LIBRARY) \
459 $(my_shared_libraries)
460 endif
Chih-Hung Hsiehad741e62016-03-09 14:54:55 -0800461
462 # Do not add unnecessary dependency in shared libraries.
463 ifeq ($(LOCAL_MODULE_CLASS),SHARED_LIBRARIES)
464 my_ldflags += -Wl,--as-needed
465 endif
Ying Wanga05e2222015-08-17 16:13:24 -0700466
Mikhail Naganovaa73cef2018-12-20 15:55:08 -0800467 ifneq ($(filter EXECUTABLES NATIVE_TESTS,$(LOCAL_MODULE_CLASS)),)
Colin Crossd08699e2016-07-17 15:28:07 -0700468 ifneq ($(LOCAL_FORCE_STATIC_EXECUTABLE),true)
469 my_linker := $($(LOCAL_2ND_ARCH_VAR_PREFIX)ADDRESS_SANITIZER_LINKER)
470 # Make sure linker_asan get installed.
Logan Chienc6d2cf82019-01-31 17:07:50 +0800471 $(LOCAL_INSTALLED_MODULE) : | $(PRODUCT_OUT)$($(LOCAL_2ND_ARCH_VAR_PREFIX)ADDRESS_SANITIZER_LINKER_FILE)
Colin Crossd08699e2016-07-17 15:28:07 -0700472 endif
473 endif
Dan Albert08cca282014-12-11 18:56:26 -0800474 endif
475endif
476
Chih-Hung Hsiehad741e62016-03-09 14:54:55 -0800477# If local module needs ASAN, add compiler flags.
478ifneq ($(filter address,$(my_sanitize)),)
479 # Frame pointer based unwinder in ASan requires ARM frame setup.
480 LOCAL_ARM_MODE := arm
481 my_cflags += $(ADDRESS_SANITIZER_CONFIG_EXTRA_CFLAGS)
482 ifndef LOCAL_IS_HOST_MODULE
483 my_cflags += -mllvm -asan-globals=0
484 endif
485endif
486
Evgenii Stepanovaec1ffc2018-08-28 13:52:08 -0700487# If local module needs HWASAN, add compiler flags.
488ifneq ($(filter hwaddress,$(my_sanitize)),)
489 my_cflags += $(HWADDRESS_SANITIZER_CONFIG_EXTRA_CFLAGS)
Florian Mayer97222e12023-06-01 14:16:28 -0700490
491 ifneq ($(filter EXECUTABLES NATIVE_TESTS,$(LOCAL_MODULE_CLASS)),)
492 ifneq ($(LOCAL_FORCE_STATIC_EXECUTABLE),true)
493 my_linker := /system/bin/linker_hwasan64
494 endif
495 endif
496
Evgenii Stepanovaec1ffc2018-08-28 13:52:08 -0700497endif
498
Dan Willemsen58634e12020-03-06 18:09:06 -0800499# Use minimal diagnostics when integer overflow is enabled; never do it for HOST modules
500ifeq ($(LOCAL_IS_HOST_MODULE),)
Ivan Lozano911cb992018-02-21 13:41:05 -0800501 # Pre-emptively add UBSAN minimal runtime incase a static library dependency requires it
502 ifeq ($(filter STATIC_LIBRARIES,$(LOCAL_MODULE_CLASS)),)
503 ifndef LOCAL_SDK_VERSION
504 my_static_libraries += $($(LOCAL_2ND_ARCH_VAR_PREFIX)UBSAN_MINIMAL_RUNTIME_LIBRARY)
Ivan Lozanoe5081692018-05-11 14:09:36 -0700505 my_ldflags += -Wl,--exclude-libs,$($(LOCAL_2ND_ARCH_VAR_PREFIX)UBSAN_MINIMAL_RUNTIME_LIBRARY).a
Ivan Lozano911cb992018-02-21 13:41:05 -0800506 endif
507 endif
508 ifneq ($(filter unsigned-integer-overflow signed-integer-overflow integer,$(my_sanitize)),)
Kostya Kortchinsky47c10eb2018-10-11 08:56:12 -0700509 ifeq ($(filter unsigned-integer-overflow signed-integer-overflow integer,$(my_sanitize_diag)),)
Ivan Lozano911cb992018-02-21 13:41:05 -0800510 ifeq ($(filter cfi,$(my_sanitize_diag)),)
Mitch Phillipsee8f4a02019-05-01 14:37:33 -0700511 ifeq ($(filter address hwaddress fuzzer-no-link,$(my_sanitize)),)
Ivan Lozano911cb992018-02-21 13:41:05 -0800512 my_cflags += -fsanitize-minimal-runtime
513 my_cflags += -fno-sanitize-trap=integer
514 my_cflags += -fno-sanitize-recover=integer
515 endif
516 endif
517 endif
518 endif
519endif
520
Kostya Kortchinsky47c10eb2018-10-11 08:56:12 -0700521# For Scudo, we opt for the minimal runtime, unless some diagnostics are enabled.
522ifneq ($(filter scudo,$(my_sanitize)),)
523 ifeq ($(filter unsigned-integer-overflow signed-integer-overflow integer cfi,$(my_sanitize_diag)),)
524 my_cflags += -fsanitize-minimal-runtime
525 endif
526 ifneq ($(filter -fsanitize-minimal-runtime,$(my_cflags)),)
527 my_shared_libraries += $($(LOCAL_2ND_ARCH_VAR_PREFIX)SCUDO_MINIMAL_RUNTIME_LIBRARY)
528 else
529 my_shared_libraries += $($(LOCAL_2ND_ARCH_VAR_PREFIX)SCUDO_RUNTIME_LIBRARY)
530 endif
531endif
532
Dan Albert9f176552015-04-28 11:26:45 -0700533ifneq ($(strip $(LOCAL_SANITIZE_RECOVER)),)
534 recover_arg := $(subst $(space),$(comma),$(LOCAL_SANITIZE_RECOVER)),
Dan Albert4111d482015-04-16 18:08:44 -0700535 my_cflags += -fsanitize-recover=$(recover_arg)
536endif
Evgenii Stepanov202c7a72016-07-07 10:56:39 -0700537
Ivan Lozano5fb2de72018-12-12 10:04:34 -0800538ifneq ($(strip $(LOCAL_SANITIZE_NO_RECOVER)),)
539 no_recover_arg := $(subst $(space),$(comma),$(LOCAL_SANITIZE_NO_RECOVER)),
540 my_cflags += -fno-sanitize-recover=$(no_recover_arg)
541endif
542
Vishwath Mohan8dcfdce2017-01-18 17:50:29 -0800543ifneq ($(my_sanitize_diag),)
Vishwath Mohan85f72442017-11-01 09:21:20 +0000544 # TODO(vishwath): Add diagnostic support for static executables once
545 # we switch to clang-4393122 (which adds the static ubsan runtime
546 # that this depends on)
547 ifneq ($(LOCAL_FORCE_STATIC_EXECUTABLE),true)
548 notrap_arg := $(subst $(space),$(comma),$(my_sanitize_diag)),
549 my_cflags += -fno-sanitize-trap=$(notrap_arg)
550 # Diagnostic requires a runtime library, unless ASan or TSan are also enabled.
Evgenii Stepanov8841a7f2018-07-27 11:54:32 -0700551 ifeq ($(filter address thread scudo hwaddress,$(my_sanitize)),)
Vishwath Mohan85f72442017-11-01 09:21:20 +0000552 # Does not have to be the first DT_NEEDED unlike ASan.
553 my_shared_libraries += $($(LOCAL_2ND_ARCH_VAR_PREFIX)UBSAN_RUNTIME_LIBRARY)
554 endif
Evgenii Stepanov202c7a72016-07-07 10:56:39 -0700555 endif
556endif
Chih-Hung Hsieh18710622018-11-17 20:18:08 -0800557
558# http://b/119329758, Android core does not boot up with this sanitizer yet.
559# Previously sanitized modules might not pass new implicit-integer-sign-change check.
560# Disable this check unless it has been explicitly specified.
561ifneq ($(findstring fsanitize,$(my_cflags)),)
562 ifneq ($(findstring integer,$(my_cflags)),)
563 ifeq ($(findstring sanitize=implicit-integer-sign-change,$(my_cflags)),)
564 my_cflags += -fno-sanitize=implicit-integer-sign-change
565 endif
566 endif
567endif
Yabin Cui462c12d2021-01-14 14:05:54 -0800568
569# http://b/177566116, libc++ may crash with this sanitizer.
570# Disable this check unless it has been explicitly specified.
571ifneq ($(findstring fsanitize,$(my_cflags)),)
572 ifneq ($(findstring integer,$(my_cflags)),)
573 ifeq ($(findstring sanitize=unsigned-shift-base,$(my_cflags)),)
574 my_cflags += -fno-sanitize=unsigned-shift-base
575 endif
576 endif
577endif