Dan Albert | 4ae5d4b | 2014-10-31 16:23:08 -0700 | [diff] [blame] | 1 | ############################################## |
| 2 | ## Perform configuration steps for sanitizers. |
| 3 | ############################################## |
| 4 | |
Dan Albert | 27ccb75 | 2015-04-16 16:21:02 -0700 | [diff] [blame] | 5 | my_sanitize := $(strip $(LOCAL_SANITIZE)) |
Dan Albert | 08cca28 | 2014-12-11 18:56:26 -0800 | [diff] [blame] | 6 | |
Dan Albert | 4c40141 | 2015-08-19 20:13:33 -0700 | [diff] [blame] | 7 | # SANITIZE_HOST is only in effect if the module is already using clang (host |
| 8 | # modules that haven't set `LOCAL_CLANG := false` and device modules that |
| 9 | # have set `LOCAL_CLANG := true`. |
| 10 | my_global_sanitize := |
| 11 | ifeq ($(my_clang),true) |
| 12 | ifdef LOCAL_IS_HOST_MODULE |
| 13 | my_global_sanitize := $(strip $(SANITIZE_HOST)) |
| 14 | |
| 15 | # SANITIZE_HOST=true is a deprecated way to say SANITIZE_HOST=address. |
| 16 | my_global_sanitize := $(subst true,address,$(my_global_sanitize)) |
| 17 | else |
| 18 | my_global_sanitize := $(strip $(SANITIZE_TARGET)) |
| 19 | endif |
| 20 | endif |
| 21 | |
Dan Albert | 4c40141 | 2015-08-19 20:13:33 -0700 | [diff] [blame] | 22 | ifneq ($(my_global_sanitize),) |
Evgenii Stepanov | 71faa19 | 2016-05-19 17:45:21 -0700 | [diff] [blame^] | 23 | my_sanitize := $(my_global_sanitize) $(my_sanitize) |
Dan Albert | 4c40141 | 2015-08-19 20:13:33 -0700 | [diff] [blame] | 24 | endif |
| 25 | |
Andreas Gampe | 6b30d77 | 2016-06-27 15:15:31 -0700 | [diff] [blame] | 26 | # The sanitizer specified in the product configuration wins over the previous. |
| 27 | ifneq ($(SANITIZER.$(TARGET_PRODUCT).$(LOCAL_MODULE).CONFIG),) |
| 28 | my_sanitize := $(SANITIZER.$(TARGET_PRODUCT).$(LOCAL_MODULE).CONFIG) |
| 29 | ifeq ($(my_sanitize),never) |
| 30 | my_sanitize := |
| 31 | endif |
| 32 | endif |
| 33 | |
Andreas Gampe | cd25740 | 2016-06-20 17:36:49 -0700 | [diff] [blame] | 34 | # Add a filter point for 32-bit vs 64-bit sanitization (to lighten the burden). |
| 35 | SANITIZE_ARCH ?= 32 64 |
| 36 | ifeq ($(filter $(SANITIZE_ARCH),$(my_32_64_bit_suffix)),) |
| 37 | my_sanitize := |
| 38 | endif |
| 39 | |
Andreas Gampe | 3d3b0c9 | 2016-06-20 17:46:29 -0700 | [diff] [blame] | 40 | # Add a filter point based on module owner (to lighten the burden). The format is a space- or |
| 41 | # colon-separated list of owner names. |
| 42 | ifneq (,$(SANITIZE_NEVER_BY_OWNER)) |
| 43 | ifneq (,$(LOCAL_MODULE_OWNER)) |
| 44 | ifneq (,$(filter $(LOCAL_MODULE_OWNER),$(subst :, ,$(SANITIZE_NEVER_BY_OWNER)))) |
| 45 | $(warning Not sanitizing $(LOCAL_MODULE) based on module owner.) |
| 46 | my_sanitize := |
| 47 | endif |
| 48 | endif |
| 49 | endif |
| 50 | |
Dan Albert | 08cca28 | 2014-12-11 18:56:26 -0800 | [diff] [blame] | 51 | # Don't apply sanitizers to NDK code. |
| 52 | ifdef LOCAL_SDK_VERSION |
Dan Albert | 4c40141 | 2015-08-19 20:13:33 -0700 | [diff] [blame] | 53 | my_sanitize := |
Dan Albert | 27ccb75 | 2015-04-16 16:21:02 -0700 | [diff] [blame] | 54 | endif |
| 55 | |
Dan Albert | 4c40141 | 2015-08-19 20:13:33 -0700 | [diff] [blame] | 56 | # Never always wins. |
| 57 | ifeq ($(LOCAL_SANITIZE),never) |
Dan Albert | 08cca28 | 2014-12-11 18:56:26 -0800 | [diff] [blame] | 58 | my_sanitize := |
| 59 | endif |
| 60 | |
Evgenii Stepanov | 4282366 | 2016-05-12 13:07:17 -0700 | [diff] [blame] | 61 | my_nosanitize = $(strip $(LOCAL_NOSANITIZE)) |
| 62 | ifneq ($(my_nosanitize),) |
| 63 | my_sanitize := $(filter-out $(my_nosanitize),$(my_sanitize)) |
| 64 | endif |
| 65 | |
Dan Albert | a6311b7 | 2015-07-30 10:17:33 -0700 | [diff] [blame] | 66 | # TSAN is not supported on 32-bit architectures. For non-multilib cases, make |
| 67 | # its use an error. For multilib cases, don't use it for the 32-bit case. |
| 68 | ifneq ($(filter thread,$(my_sanitize)),) |
| 69 | ifeq ($(my_32_64_bit_suffix),32) |
| 70 | ifeq ($(my_module_multilib),both) |
| 71 | my_sanitize := $(filter-out thread,$(my_sanitize)) |
| 72 | else |
| 73 | $(error $(LOCAL_PATH): $(LOCAL_MODULE): TSAN cannot be used for 32-bit modules.) |
| 74 | endif |
| 75 | endif |
| 76 | endif |
| 77 | |
Evgenii Stepanov | 5adfcb1 | 2015-06-25 16:38:25 -0700 | [diff] [blame] | 78 | # Undefined symbols can occur if a non-sanitized library links |
| 79 | # sanitized static libraries. That's OK, because the executable |
| 80 | # always depends on the ASan runtime library, which defines these |
| 81 | # symbols. |
Evgenii Stepanov | 912b51f | 2016-05-19 17:49:51 -0700 | [diff] [blame] | 82 | ifneq ($(filter address thread,$(strip $(SANITIZE_TARGET))),) |
Evgenii Stepanov | 5adfcb1 | 2015-06-25 16:38:25 -0700 | [diff] [blame] | 83 | ifndef LOCAL_IS_HOST_MODULE |
| 84 | ifeq ($(LOCAL_MODULE_CLASS),SHARED_LIBRARIES) |
| 85 | ifeq ($(my_sanitize),) |
| 86 | my_allow_undefined_symbols := true |
| 87 | endif |
| 88 | endif |
| 89 | endif |
| 90 | endif |
| 91 | |
Dan Albert | 94b5791 | 2015-04-17 09:48:33 -0700 | [diff] [blame] | 92 | # Sanitizers can only be used with clang. |
| 93 | ifneq ($(my_clang),true) |
| 94 | ifneq ($(my_sanitize),) |
| 95 | $(error $(LOCAL_PATH): $(LOCAL_MODULE): Use of sanitizers requires LOCAL_CLANG := true) |
| 96 | endif |
| 97 | endif |
| 98 | |
Dan Albert | b5b2ffe | 2015-04-16 18:07:07 -0700 | [diff] [blame] | 99 | ifneq ($(filter default-ub,$(my_sanitize)),) |
| 100 | my_sanitize := $(CLANG_DEFAULT_UB_CHECKS) |
Dan Albert | 08cca28 | 2014-12-11 18:56:26 -0800 | [diff] [blame] | 101 | endif |
| 102 | |
Ivan Krasin | 74b32b8 | 2015-09-18 11:54:43 -0700 | [diff] [blame] | 103 | ifneq ($(filter coverage,$(my_sanitize)),) |
| 104 | ifeq ($(filter address,$(my_sanitize)),) |
| 105 | $(error $(LOCAL_PATH): $(LOCAL_MODULE): Use of 'coverage' also requires 'address') |
| 106 | endif |
| 107 | my_cflags += -fsanitize-coverage=edge,indirect-calls,8bit-counters,trace-cmp |
| 108 | my_sanitize := $(filter-out coverage,$(my_sanitize)) |
| 109 | endif |
| 110 | |
Dan Albert | 08cca28 | 2014-12-11 18:56:26 -0800 | [diff] [blame] | 111 | ifneq ($(my_sanitize),) |
Stephen Hines | e8119e9 | 2015-11-09 16:32:11 -0800 | [diff] [blame] | 112 | fsanitize_arg := $(subst $(space),$(comma),$(my_sanitize)) |
Dan Albert | 08cca28 | 2014-12-11 18:56:26 -0800 | [diff] [blame] | 113 | my_cflags += -fsanitize=$(fsanitize_arg) |
| 114 | |
| 115 | ifdef LOCAL_IS_HOST_MODULE |
Dan Albert | abf4bc9 | 2015-06-16 23:27:34 -0700 | [diff] [blame] | 116 | my_cflags += -fno-sanitize-recover=all |
Dan Albert | 08cca28 | 2014-12-11 18:56:26 -0800 | [diff] [blame] | 117 | my_ldflags += -fsanitize=$(fsanitize_arg) |
Dan Albert | 2922411 | 2015-08-13 17:25:10 -0700 | [diff] [blame] | 118 | my_ldlibs += -lrt -ldl |
Dan Albert | abf4bc9 | 2015-06-16 23:27:34 -0700 | [diff] [blame] | 119 | else |
Evgenii Stepanov | 71faa19 | 2016-05-19 17:45:21 -0700 | [diff] [blame^] | 120 | my_cflags += -fsanitize-trap=all |
| 121 | my_cflags += -ftrap-function=abort |
Evgenii Stepanov | 55f73e6 | 2016-05-12 13:07:36 -0700 | [diff] [blame] | 122 | ifneq ($(filter address thread,$(my_sanitize)),) |
Evgenii Stepanov | 71faa19 | 2016-05-19 17:45:21 -0700 | [diff] [blame^] | 123 | my_cflags += -fno-sanitize-trap=address,thread |
Evgenii Stepanov | 55f73e6 | 2016-05-12 13:07:36 -0700 | [diff] [blame] | 124 | my_shared_libraries += libdl |
| 125 | endif |
Dan Albert | 08cca28 | 2014-12-11 18:56:26 -0800 | [diff] [blame] | 126 | endif |
| 127 | endif |
| 128 | |
Chih-Hung Hsieh | ad741e6 | 2016-03-09 14:54:55 -0800 | [diff] [blame] | 129 | # If local or global modules need ASAN, add linker flags. |
| 130 | ifneq ($(filter address,$(my_global_sanitize) $(my_sanitize)),) |
Dan Albert | 4ae5d4b | 2014-10-31 16:23:08 -0700 | [diff] [blame] | 131 | my_ldflags += $(ADDRESS_SANITIZER_CONFIG_EXTRA_LDFLAGS) |
| 132 | ifdef LOCAL_IS_HOST_MODULE |
Dan Albert | 08cca28 | 2014-12-11 18:56:26 -0800 | [diff] [blame] | 133 | # -nodefaultlibs (provided with libc++) prevents the driver from linking |
| 134 | # libraries needed with -fsanitize=address. http://b/18650275 (WAI) |
Dan Albert | abf4bc9 | 2015-06-16 23:27:34 -0700 | [diff] [blame] | 135 | my_ldlibs += -lm -lpthread |
Dan Albert | 1f0d530 | 2015-04-28 14:55:50 -0700 | [diff] [blame] | 136 | my_ldflags += -Wl,--no-as-needed |
Dan Albert | 4ae5d4b | 2014-10-31 16:23:08 -0700 | [diff] [blame] | 137 | else |
Chih-Hung Hsieh | ad741e6 | 2016-03-09 14:54:55 -0800 | [diff] [blame] | 138 | # Add asan libraries unless LOCAL_MODULE is the asan library. |
Evgenii Stepanov | f0b15e1 | 2015-04-24 16:34:47 -0700 | [diff] [blame] | 139 | # ASan runtime library must be the first in the link order. |
Chih-Hung Hsieh | ad741e6 | 2016-03-09 14:54:55 -0800 | [diff] [blame] | 140 | ifeq (,$(filter $(LOCAL_MODULE),$($(LOCAL_2ND_ARCH_VAR_PREFIX)ADDRESS_SANITIZER_RUNTIME_LIBRARY))) |
| 141 | my_shared_libraries := $($(LOCAL_2ND_ARCH_VAR_PREFIX)ADDRESS_SANITIZER_RUNTIME_LIBRARY) \ |
| 142 | $(my_shared_libraries) |
| 143 | endif |
| 144 | ifeq (,$(filter $(LOCAL_MODULE),$(ADDRESS_SANITIZER_CONFIG_EXTRA_STATIC_LIBRARIES))) |
| 145 | my_static_libraries += $(ADDRESS_SANITIZER_CONFIG_EXTRA_STATIC_LIBRARIES) |
| 146 | endif |
| 147 | |
| 148 | # Do not add unnecessary dependency in shared libraries. |
| 149 | ifeq ($(LOCAL_MODULE_CLASS),SHARED_LIBRARIES) |
| 150 | my_ldflags += -Wl,--as-needed |
| 151 | endif |
Ying Wang | a05e222 | 2015-08-17 16:13:24 -0700 | [diff] [blame] | 152 | |
Evgenii Stepanov | 8f5e67a | 2015-07-10 18:06:51 -0700 | [diff] [blame] | 153 | my_linker := $($(LOCAL_2ND_ARCH_VAR_PREFIX)ADDRESS_SANITIZER_LINKER) |
Ying Wang | a05e222 | 2015-08-17 16:13:24 -0700 | [diff] [blame] | 154 | # Make sure linker_asan get installed. |
| 155 | $(LOCAL_INSTALLED_MODULE) : | $(PRODUCT_OUT)$($(LOCAL_2ND_ARCH_VAR_PREFIX)ADDRESS_SANITIZER_LINKER) |
Dan Albert | 08cca28 | 2014-12-11 18:56:26 -0800 | [diff] [blame] | 156 | endif |
| 157 | endif |
| 158 | |
Chih-Hung Hsieh | ad741e6 | 2016-03-09 14:54:55 -0800 | [diff] [blame] | 159 | # If local module needs ASAN, add compiler flags. |
| 160 | ifneq ($(filter address,$(my_sanitize)),) |
| 161 | # Frame pointer based unwinder in ASan requires ARM frame setup. |
| 162 | LOCAL_ARM_MODE := arm |
| 163 | my_cflags += $(ADDRESS_SANITIZER_CONFIG_EXTRA_CFLAGS) |
| 164 | ifndef LOCAL_IS_HOST_MODULE |
| 165 | my_cflags += -mllvm -asan-globals=0 |
| 166 | endif |
| 167 | endif |
| 168 | |
Dan Albert | 08cca28 | 2014-12-11 18:56:26 -0800 | [diff] [blame] | 169 | ifneq ($(filter undefined,$(my_sanitize)),) |
Dan Albert | abf4bc9 | 2015-06-16 23:27:34 -0700 | [diff] [blame] | 170 | ifndef LOCAL_IS_HOST_MODULE |
Dan Albert | 08cca28 | 2014-12-11 18:56:26 -0800 | [diff] [blame] | 171 | $(error ubsan is not yet supported on the target) |
Dan Albert | 4ae5d4b | 2014-10-31 16:23:08 -0700 | [diff] [blame] | 172 | endif |
| 173 | endif |
Dan Albert | 4111d48 | 2015-04-16 18:08:44 -0700 | [diff] [blame] | 174 | |
Dan Albert | 9f17655 | 2015-04-28 11:26:45 -0700 | [diff] [blame] | 175 | ifneq ($(strip $(LOCAL_SANITIZE_RECOVER)),) |
| 176 | recover_arg := $(subst $(space),$(comma),$(LOCAL_SANITIZE_RECOVER)), |
Dan Albert | 4111d48 | 2015-04-16 18:08:44 -0700 | [diff] [blame] | 177 | my_cflags += -fsanitize-recover=$(recover_arg) |
| 178 | endif |