blob: f39b84a5c76170073edbd40f289f9d0c17356180 [file] [log] [blame]
Dan Albert4ae5d4b2014-10-31 16:23:08 -07001##############################################
2## Perform configuration steps for sanitizers.
3##############################################
4
Dan Albert27ccb752015-04-16 16:21:02 -07005my_sanitize := $(strip $(LOCAL_SANITIZE))
Vishwath Mohan8dcfdce2017-01-18 17:50:29 -08006my_sanitize_diag := $(strip $(LOCAL_SANITIZE_DIAG))
Dan Albert08cca282014-12-11 18:56:26 -08007
Dan Albert4c401412015-08-19 20:13:33 -07008my_global_sanitize :=
Ivan Lozano4a363732017-06-28 09:11:26 -07009my_global_sanitize_diag :=
Dan Willemsenf0638392018-09-04 22:25:22 -070010ifdef LOCAL_IS_HOST_MODULE
11 ifneq ($($(my_prefix)OS),windows)
12 my_global_sanitize := $(strip $(SANITIZE_HOST))
Dan Albert4c401412015-08-19 20:13:33 -070013
Dan Willemsenf0638392018-09-04 22:25:22 -070014 # SANITIZE_HOST=true is a deprecated way to say SANITIZE_HOST=address.
15 my_global_sanitize := $(subst true,address,$(my_global_sanitize))
Dan Albert4c401412015-08-19 20:13:33 -070016 endif
Dan Willemsenf0638392018-09-04 22:25:22 -070017else
18 my_global_sanitize := $(strip $(SANITIZE_TARGET))
19 my_global_sanitize_diag := $(strip $(SANITIZE_TARGET_DIAG))
Dan Albert4c401412015-08-19 20:13:33 -070020endif
21
Ivan Lozanob4749cb2017-07-21 10:33:32 -070022# Disable global integer_overflow in excluded paths.
23ifneq ($(filter integer_overflow, $(my_global_sanitize)),)
24 combined_exclude_paths := $(INTEGER_OVERFLOW_EXCLUDE_PATHS) \
25 $(PRODUCT_INTEGER_OVERFLOW_EXCLUDE_PATHS)
26
27 ifneq ($(strip $(foreach dir,$(subst $(comma),$(space),$(combined_exclude_paths)),\
28 $(filter $(dir)%,$(LOCAL_PATH)))),)
29 my_global_sanitize := $(filter-out integer_overflow,$(my_global_sanitize))
30 my_global_sanitize_diag := $(filter-out integer_overflow,$(my_global_sanitize_diag))
31 endif
32endif
33
Ivan Lozano702e8bd2018-03-15 14:49:20 -070034# Global integer sanitization doesn't support static modules.
35ifeq ($(filter SHARED_LIBRARIES EXECUTABLES,$(LOCAL_MODULE_CLASS)),)
36 my_global_sanitize := $(filter-out integer_overflow,$(my_global_sanitize))
37 my_global_sanitize_diag := $(filter-out integer_overflow,$(my_global_sanitize_diag))
38endif
39ifeq ($(LOCAL_FORCE_STATIC_EXECUTABLE),true)
40 my_global_sanitize := $(filter-out integer_overflow,$(my_global_sanitize))
41 my_global_sanitize_diag := $(filter-out integer_overflow,$(my_global_sanitize_diag))
42endif
43
Vishwath Mohan23b2d2e2017-10-31 02:25:16 -070044# Disable global CFI in excluded paths
45ifneq ($(filter cfi, $(my_global_sanitize)),)
46 combined_exclude_paths := $(CFI_EXCLUDE_PATHS) \
47 $(PRODUCT_CFI_EXCLUDE_PATHS)
48
49 ifneq ($(strip $(foreach dir,$(subst $(comma),$(space),$(combined_exclude_paths)),\
50 $(filter $(dir)%,$(LOCAL_PATH)))),)
51 my_global_sanitize := $(filter-out cfi,$(my_global_sanitize))
52 my_global_sanitize_diag := $(filter-out cfi,$(my_global_sanitize_diag))
53 endif
54endif
55
Evgenii Stepanov3330b2f2021-01-13 12:14:55 -080056# Disable global memtag_heap in excluded paths
57ifneq ($(filter memtag_heap, $(my_global_sanitize)),)
58 combined_exclude_paths := $(MEMTAG_HEAP_EXCLUDE_PATHS) \
59 $(PRODUCT_MEMTAG_HEAP_EXCLUDE_PATHS)
60
61 ifneq ($(strip $(foreach dir,$(subst $(comma),$(space),$(combined_exclude_paths)),\
62 $(filter $(dir)%,$(LOCAL_PATH)))),)
63 my_global_sanitize := $(filter-out memtag_heap,$(my_global_sanitize))
64 my_global_sanitize_diag := $(filter-out memtag_heap,$(my_global_sanitize_diag))
65 endif
66endif
67
Dan Albert4c401412015-08-19 20:13:33 -070068ifneq ($(my_global_sanitize),)
Evgenii Stepanov71faa192016-05-19 17:45:21 -070069 my_sanitize := $(my_global_sanitize) $(my_sanitize)
Dan Albert4c401412015-08-19 20:13:33 -070070endif
Ivan Lozano4a363732017-06-28 09:11:26 -070071ifneq ($(my_global_sanitize_diag),)
72 my_sanitize_diag := $(my_global_sanitize_diag) $(my_sanitize_diag)
73endif
Dan Albert4c401412015-08-19 20:13:33 -070074
Andreas Gampe6b30d772016-06-27 15:15:31 -070075# The sanitizer specified in the product configuration wins over the previous.
76ifneq ($(SANITIZER.$(TARGET_PRODUCT).$(LOCAL_MODULE).CONFIG),)
77 my_sanitize := $(SANITIZER.$(TARGET_PRODUCT).$(LOCAL_MODULE).CONFIG)
78 ifeq ($(my_sanitize),never)
79 my_sanitize :=
Ivan Lozano4a363732017-06-28 09:11:26 -070080 my_sanitize_diag :=
Andreas Gampe6b30d772016-06-27 15:15:31 -070081 endif
82endif
83
Colin Cross23618422016-11-02 15:05:21 -070084ifndef LOCAL_IS_HOST_MODULE
85 # Add a filter point for 32-bit vs 64-bit sanitization (to lighten the burden)
86 SANITIZE_TARGET_ARCH ?= $(TARGET_ARCH) $(TARGET_2ND_ARCH)
87 ifeq ($(filter $(SANITIZE_TARGET_ARCH),$(TARGET_$(LOCAL_2ND_ARCH_VAR_PREFIX)ARCH)),)
88 my_sanitize :=
Ivan Lozano4a363732017-06-28 09:11:26 -070089 my_sanitize_diag :=
Colin Cross23618422016-11-02 15:05:21 -070090 endif
Andreas Gampecd257402016-06-20 17:36:49 -070091endif
92
Andreas Gampe3d3b0c92016-06-20 17:46:29 -070093# Add a filter point based on module owner (to lighten the burden). The format is a space- or
94# colon-separated list of owner names.
95ifneq (,$(SANITIZE_NEVER_BY_OWNER))
96 ifneq (,$(LOCAL_MODULE_OWNER))
97 ifneq (,$(filter $(LOCAL_MODULE_OWNER),$(subst :, ,$(SANITIZE_NEVER_BY_OWNER))))
98 $(warning Not sanitizing $(LOCAL_MODULE) based on module owner.)
99 my_sanitize :=
Ivan Lozano4a363732017-06-28 09:11:26 -0700100 my_sanitize_diag :=
Andreas Gampe3d3b0c92016-06-20 17:46:29 -0700101 endif
102 endif
103endif
104
Dan Albert08cca282014-12-11 18:56:26 -0800105# Don't apply sanitizers to NDK code.
106ifdef LOCAL_SDK_VERSION
Dan Albert4c401412015-08-19 20:13:33 -0700107 my_sanitize :=
Dan Willemsenf761c0f2016-06-28 16:47:43 -0700108 my_global_sanitize :=
Ivan Lozano4a363732017-06-28 09:11:26 -0700109 my_sanitize_diag :=
Dan Albert27ccb752015-04-16 16:21:02 -0700110endif
111
Dan Albert4c401412015-08-19 20:13:33 -0700112# Never always wins.
113ifeq ($(LOCAL_SANITIZE),never)
Dan Albert08cca282014-12-11 18:56:26 -0800114 my_sanitize :=
Ivan Lozano4a363732017-06-28 09:11:26 -0700115 my_sanitize_diag :=
Dan Albert08cca282014-12-11 18:56:26 -0800116endif
117
Vishwath Mohan6106a4e2018-05-24 18:04:25 -0700118# Enable CFI in included paths (for Arm64 only).
Vishwath Mohan23b2d2e2017-10-31 02:25:16 -0700119ifeq ($(filter cfi, $(my_sanitize)),)
Vishwath Mohan6106a4e2018-05-24 18:04:25 -0700120 ifneq ($(filter arm64,$(TARGET_$(LOCAL_2ND_ARCH_VAR_PREFIX)ARCH)),)
121 combined_include_paths := $(CFI_INCLUDE_PATHS) \
122 $(PRODUCT_CFI_INCLUDE_PATHS)
Vishwath Mohan23b2d2e2017-10-31 02:25:16 -0700123
Vishwath Mohan6106a4e2018-05-24 18:04:25 -0700124 ifneq ($(strip $(foreach dir,$(subst $(comma),$(space),$(combined_include_paths)),\
125 $(filter $(dir)%,$(LOCAL_PATH)))),)
126 my_sanitize := cfi $(my_sanitize)
Vishwath Mohan6106a4e2018-05-24 18:04:25 -0700127 endif
Vishwath Mohan23b2d2e2017-10-31 02:25:16 -0700128 endif
129endif
130
Evgenii Stepanov3330b2f2021-01-13 12:14:55 -0800131# Enable memtag_heap in included paths (for Arm64 only).
132ifeq ($(filter memtag_heap, $(my_sanitize)),)
133 ifneq ($(filter arm64,$(TARGET_$(LOCAL_2ND_ARCH_VAR_PREFIX)ARCH)),)
134 combined_sync_include_paths := $(MEMTAG_HEAP_SYNC_INCLUDE_PATHS) \
135 $(PRODUCT_MEMTAG_HEAP_SYNC_INCLUDE_PATHS)
136 combined_async_include_paths := $(MEMTAG_HEAP_ASYNC_INCLUDE_PATHS) \
137 $(PRODUCT_MEMTAG_HEAP_ASYNC_INCLUDE_PATHS)
138
139 ifneq ($(strip $(foreach dir,$(subst $(comma),$(space),$(combined_sync_include_paths)),\
140 $(filter $(dir)%,$(LOCAL_PATH)))),)
141 my_sanitize := memtag_heap $(my_sanitize)
142 my_sanitize_diag := memtag_heap $(my_sanitize)
143 else ifneq ($(strip $(foreach dir,$(subst $(comma),$(space),$(combined_async_include_paths)),\
144 $(filter $(dir)%,$(LOCAL_PATH)))),)
145 my_sanitize := memtag_heap $(my_sanitize)
146 endif
147 endif
148endif
149
Vishwath Mohan8dcfdce2017-01-18 17:50:29 -0800150# If CFI is disabled globally, remove it from my_sanitize.
Vishwath Mohan45665b42017-01-24 13:20:28 -0800151ifeq ($(strip $(ENABLE_CFI)),false)
Vishwath Mohan8dcfdce2017-01-18 17:50:29 -0800152 my_sanitize := $(filter-out cfi,$(my_sanitize))
153 my_sanitize_diag := $(filter-out cfi,$(my_sanitize_diag))
154endif
155
Vishwath Mohana2046062017-02-07 20:28:07 -0800156# Disable CFI for arm32 (b/35157333).
157ifneq ($(filter arm,$(TARGET_$(LOCAL_2ND_ARCH_VAR_PREFIX)ARCH)),)
158 my_sanitize := $(filter-out cfi,$(my_sanitize))
159 my_sanitize_diag := $(filter-out cfi,$(my_sanitize_diag))
160endif
161
Vishwath Mohanc026f6d2017-04-20 07:39:13 -0700162# Also disable CFI if ASAN is enabled.
163ifneq ($(filter address,$(my_sanitize)),)
164 my_sanitize := $(filter-out cfi,$(my_sanitize))
165 my_sanitize_diag := $(filter-out cfi,$(my_sanitize_diag))
166endif
167
Ivan Lozano702e8bd2018-03-15 14:49:20 -0700168# Disable sanitizers which need the UBSan runtime for host targets.
Vishwath Mohan96a130b2017-11-17 11:19:36 -0800169ifdef LOCAL_IS_HOST_MODULE
170 my_sanitize := $(filter-out cfi,$(my_sanitize))
171 my_sanitize_diag := $(filter-out cfi,$(my_sanitize_diag))
Ivan Lozano702e8bd2018-03-15 14:49:20 -0700172 my_sanitize := $(filter-out signed-integer-overflow unsigned-integer-overflow integer_overflow,$(my_sanitize))
173 my_sanitize_diag := $(filter-out signed-integer-overflow unsigned-integer-overflow integer_overflow,$(my_sanitize_diag))
Vishwath Mohan96a130b2017-11-17 11:19:36 -0800174endif
175
Ivan Lozano4a363732017-06-28 09:11:26 -0700176# Support for local sanitize blacklist paths.
177ifneq ($(my_sanitize)$(my_global_sanitize),)
Pirama Arumuga Nainar56558332020-07-30 15:18:07 -0700178 ifneq ($(LOCAL_SANITIZE_BLOCKLIST),)
179 my_cflags += -fsanitize-blacklist=$(LOCAL_PATH)/$(LOCAL_SANITIZE_BLOCKLIST)
180 endif
Ivan Lozano4a363732017-06-28 09:11:26 -0700181endif
182
Ivan Lozanob4749cb2017-07-21 10:33:32 -0700183# Disable integer_overflow if LOCAL_NOSANITIZE=integer.
Ivan Lozano4a363732017-06-28 09:11:26 -0700184ifneq ($(filter integer_overflow, $(my_global_sanitize) $(my_sanitize)),)
185 ifneq ($(filter integer, $(strip $(LOCAL_NOSANITIZE))),)
186 my_sanitize := $(filter-out integer_overflow,$(my_sanitize))
187 my_sanitize_diag := $(filter-out integer_overflow,$(my_sanitize_diag))
188 endif
189endif
190
Evgenii Stepanov42823662016-05-12 13:07:17 -0700191my_nosanitize = $(strip $(LOCAL_NOSANITIZE))
192ifneq ($(my_nosanitize),)
193 my_sanitize := $(filter-out $(my_nosanitize),$(my_sanitize))
194endif
195
Evgenii Stepanov8841a7f2018-07-27 11:54:32 -0700196ifneq ($(filter arm x86 x86_64,$(TARGET_$(LOCAL_2ND_ARCH_VAR_PREFIX)ARCH)),)
197 my_sanitize := $(filter-out hwaddress,$(my_sanitize))
Evgenii Stepanov3330b2f2021-01-13 12:14:55 -0800198 my_sanitize := $(filter-out memtag_heap,$(my_sanitize))
Evgenii Stepanov8841a7f2018-07-27 11:54:32 -0700199endif
200
201ifneq ($(filter hwaddress,$(my_sanitize)),)
202 my_sanitize := $(filter-out address,$(my_sanitize))
203 my_sanitize := $(filter-out thread,$(my_sanitize))
Evgenii Stepanov88a95a32018-12-04 17:06:45 -0800204 my_sanitize := $(filter-out cfi,$(my_sanitize))
Evgenii Stepanov8841a7f2018-07-27 11:54:32 -0700205endif
206
207ifneq ($(filter hwaddress,$(my_sanitize)),)
208 my_shared_libraries += $($(LOCAL_2ND_ARCH_VAR_PREFIX)HWADDRESS_SANITIZER_RUNTIME_LIBRARY)
Evgenii Stepanoved907462018-11-01 15:43:14 -0700209 ifneq ($(filter EXECUTABLES NATIVE_TESTS,$(LOCAL_MODULE_CLASS)),)
Evgenii Stepanov8841a7f2018-07-27 11:54:32 -0700210 ifeq ($(LOCAL_FORCE_STATIC_EXECUTABLE),true)
Ryan Prichardacf8b0f2019-10-21 20:47:53 -0700211 my_static_libraries := $(my_static_libraries) \
212 $($(LOCAL_2ND_ARCH_VAR_PREFIX)HWADDRESS_SANITIZER_STATIC_LIBRARY) \
213 libdl
Evgenii Stepanov8841a7f2018-07-27 11:54:32 -0700214 endif
215 endif
216endif
217
Evgenii Stepanov3330b2f2021-01-13 12:14:55 -0800218ifneq ($(filter memtag_heap,$(my_sanitize)),)
219 # Add memtag ELF note.
220 ifneq ($(filter memtag_heap,$(my_sanitize_diag)),)
221 my_whole_static_libraries += note_memtag_heap_sync
222 else
223 my_whole_static_libraries += note_memtag_heap_async
224 endif
225 # This is all that memtag_heap does - it is not an actual -fsanitize argument.
226 # Remove it from the list.
227 my_sanitize := $(filter-out memtag_heap,$(my_sanitize))
228endif
229
230my_sanitize_diag := $(filter-out memtag_heap,$(my_sanitize_diag))
231
Dan Alberta6311b72015-07-30 10:17:33 -0700232# TSAN is not supported on 32-bit architectures. For non-multilib cases, make
233# its use an error. For multilib cases, don't use it for the 32-bit case.
234ifneq ($(filter thread,$(my_sanitize)),)
235 ifeq ($(my_32_64_bit_suffix),32)
236 ifeq ($(my_module_multilib),both)
237 my_sanitize := $(filter-out thread,$(my_sanitize))
238 else
239 $(error $(LOCAL_PATH): $(LOCAL_MODULE): TSAN cannot be used for 32-bit modules.)
240 endif
Yabin Cuie77c32e2017-10-19 14:33:58 -0700241 else
242 my_shared_libraries += $(TSAN_RUNTIME_LIBRARY)
Dan Alberta6311b72015-07-30 10:17:33 -0700243 endif
244endif
245
Evgenii Stepanov7dcb8b82016-05-06 18:15:57 -0700246ifneq ($(filter safe-stack,$(my_sanitize)),)
247 ifeq ($(my_32_64_bit_suffix),32)
248 my_sanitize := $(filter-out safe-stack,$(my_sanitize))
249 endif
250endif
251
Kostya Kortchinsky2cfa9972018-06-14 11:02:15 -0700252# Disable Scudo if ASan or TSan is enabled.
Evgenii Stepanov8841a7f2018-07-27 11:54:32 -0700253ifneq ($(filter address thread hwaddress,$(my_sanitize)),)
Kostya Kortchinsky2cfa9972018-06-14 11:02:15 -0700254 my_sanitize := $(filter-out scudo,$(my_sanitize))
255endif
256
Kostya Kortchinsky02732402019-02-01 09:06:42 -0800257# Or if disabled globally.
Anton Hansson8dab0a62019-03-28 15:45:40 +0000258ifeq ($(PRODUCT_DISABLE_SCUDO),true)
Kostya Kortchinsky02732402019-02-01 09:06:42 -0800259 my_sanitize := $(filter-out scudo,$(my_sanitize))
260endif
261
Evgenii Stepanov5adfcb12015-06-25 16:38:25 -0700262# Undefined symbols can occur if a non-sanitized library links
263# sanitized static libraries. That's OK, because the executable
264# always depends on the ASan runtime library, which defines these
265# symbols.
Evgenii Stepanov912b51f2016-05-19 17:49:51 -0700266ifneq ($(filter address thread,$(strip $(SANITIZE_TARGET))),)
Evgenii Stepanov5adfcb12015-06-25 16:38:25 -0700267 ifndef LOCAL_IS_HOST_MODULE
268 ifeq ($(LOCAL_MODULE_CLASS),SHARED_LIBRARIES)
269 ifeq ($(my_sanitize),)
270 my_allow_undefined_symbols := true
271 endif
272 endif
273 endif
274endif
275
Dan Albertb5b2ffe2015-04-16 18:07:07 -0700276ifneq ($(filter default-ub,$(my_sanitize)),)
277 my_sanitize := $(CLANG_DEFAULT_UB_CHECKS)
Dan Albert08cca282014-12-11 18:56:26 -0800278endif
279
Mitch Phillipsee8f4a02019-05-01 14:37:33 -0700280ifneq ($(filter fuzzer,$(my_sanitize)),)
281 # SANITIZE_TARGET='fuzzer' actually means to create the fuzzer coverage
282 # information, not to link against the fuzzer main().
283 my_sanitize := $(filter-out fuzzer,$(my_sanitize))
284 my_sanitize += fuzzer-no-link
285
286 # TODO(b/131771163): Disable LTO for fuzzer builds. Note that Cfi causes
287 # dependency on LTO.
288 my_sanitize := $(filter-out cfi,$(my_sanitize))
289 my_cflags += -fno-lto
290 my_ldflags += -fno-lto
Mitch Phillipsee2dcac2019-06-17 10:37:55 -0700291
292 # TODO(b/133876586): Disable experimental pass manager for fuzzer builds.
293 my_cflags += -fno-experimental-new-pass-manager
Ivan Krasin74b32b82015-09-18 11:54:43 -0700294endif
295
Ivan Lozano4a363732017-06-28 09:11:26 -0700296ifneq ($(filter integer_overflow,$(my_sanitize)),)
Ivan Lozano702e8bd2018-03-15 14:49:20 -0700297 # Respect LOCAL_NOSANITIZE for integer-overflow flags.
298 ifeq ($(filter signed-integer-overflow, $(strip $(LOCAL_NOSANITIZE))),)
299 my_sanitize += signed-integer-overflow
300 endif
301 ifeq ($(filter unsigned-integer-overflow, $(strip $(LOCAL_NOSANITIZE))),)
302 my_sanitize += unsigned-integer-overflow
303 endif
304 my_cflags += $(INTEGER_OVERFLOW_EXTRA_CFLAGS)
Ivan Lozano4a363732017-06-28 09:11:26 -0700305
Ivan Lozano702e8bd2018-03-15 14:49:20 -0700306 # Check for diagnostics mode.
307 ifneq ($(filter integer_overflow,$(my_sanitize_diag)),)
308 ifneq ($(filter SHARED_LIBRARIES EXECUTABLES,$(LOCAL_MODULE_CLASS)),)
309 ifneq ($(LOCAL_FORCE_STATIC_EXECUTABLE),true)
Ivan Lozano911cb992018-02-21 13:41:05 -0800310 my_sanitize_diag += signed-integer-overflow
311 my_sanitize_diag += unsigned-integer-overflow
Ivan Lozano702e8bd2018-03-15 14:49:20 -0700312 else
313 $(call pretty-error,Make cannot apply integer overflow diagnostics to static binary.)
Ivan Lozano4a363732017-06-28 09:11:26 -0700314 endif
Ivan Lozano702e8bd2018-03-15 14:49:20 -0700315 else
316 $(call pretty-error,Make cannot apply integer overflow diagnostics to static library.)
Ivan Lozano4a363732017-06-28 09:11:26 -0700317 endif
318 endif
319 my_sanitize := $(filter-out integer_overflow,$(my_sanitize))
320endif
321
322# Makes sure integer_overflow diagnostics is removed from the diagnostics list
323# even if integer_overflow is not set for some reason.
324ifneq ($(filter integer_overflow,$(my_sanitize_diag)),)
325 my_sanitize_diag := $(filter-out integer_overflow,$(my_sanitize_diag))
326endif
327
Dan Albert08cca282014-12-11 18:56:26 -0800328ifneq ($(my_sanitize),)
Stephen Hinese8119e92015-11-09 16:32:11 -0800329 fsanitize_arg := $(subst $(space),$(comma),$(my_sanitize))
Dan Albert08cca282014-12-11 18:56:26 -0800330 my_cflags += -fsanitize=$(fsanitize_arg)
Evgenii Stepanov9b82b3f2018-08-31 12:57:26 -0700331 my_asflags += -fsanitize=$(fsanitize_arg)
Dan Albert08cca282014-12-11 18:56:26 -0800332
Mitch Phillipsee8f4a02019-05-01 14:37:33 -0700333 # When fuzzing, we wish to crash with diagnostics on any bug.
334 ifneq ($(filter fuzzer-no-link,$(my_sanitize)),)
335 my_cflags += -fno-sanitize-trap=all
336 my_cflags += -fno-sanitize-recover=all
337 my_ldflags += -fsanitize=fuzzer-no-link
338 else ifdef LOCAL_IS_HOST_MODULE
Dan Albertabf4bc92015-06-16 23:27:34 -0700339 my_cflags += -fno-sanitize-recover=all
Dan Albert08cca282014-12-11 18:56:26 -0800340 my_ldflags += -fsanitize=$(fsanitize_arg)
Dan Albertabf4bc92015-06-16 23:27:34 -0700341 else
Evgenii Stepanov71faa192016-05-19 17:45:21 -0700342 my_cflags += -fsanitize-trap=all
343 my_cflags += -ftrap-function=abort
Evgenii Stepanov55f73e62016-05-12 13:07:36 -0700344 ifneq ($(filter address thread,$(my_sanitize)),)
Evgenii Stepanov71faa192016-05-19 17:45:21 -0700345 my_cflags += -fno-sanitize-trap=address,thread
Evgenii Stepanov55f73e62016-05-12 13:07:36 -0700346 my_shared_libraries += libdl
347 endif
Dan Albert08cca282014-12-11 18:56:26 -0800348 endif
349endif
350
Evgenii Stepanov202c7a72016-07-07 10:56:39 -0700351ifneq ($(filter cfi,$(my_sanitize)),)
Evgenii Stepanov81bea1b2017-01-20 14:12:08 -0800352 # __cfi_check needs to be built as Thumb (see the code in linker_cfi.cpp).
353 # LLVM is not set up to do this on a function basis, so force Thumb on the
354 # entire module.
355 LOCAL_ARM_MODE := thumb
Vishwath Mohan5b69c062017-02-14 07:55:37 -0800356 my_cflags += $(CFI_EXTRA_CFLAGS)
Evgenii Stepanov9b82b3f2018-08-31 12:57:26 -0700357 my_asflags += $(CFI_EXTRA_ASFLAGS)
Vishwath Mohan85f72442017-11-01 09:21:20 +0000358 # Only append the default visibility flag if -fvisibility has not already been
359 # set to hidden.
360 ifeq ($(filter -fvisibility=hidden,$(LOCAL_CFLAGS)),)
361 my_cflags += -fvisibility=default
362 endif
Vishwath Mohan5b69c062017-02-14 07:55:37 -0800363 my_ldflags += $(CFI_EXTRA_LDFLAGS)
Evgenii Stepanove1b96f32017-01-23 16:57:38 -0800364 my_arflags += --plugin $(LLVM_PREBUILTS_PATH)/../lib64/LLVMgold.so
Vishwath Mohan85f72442017-11-01 09:21:20 +0000365
366 ifeq ($(LOCAL_FORCE_STATIC_EXECUTABLE),true)
367 my_ldflags := $(filter-out -fsanitize-cfi-cross-dso,$(my_ldflags))
368 my_cflags := $(filter-out -fsanitize-cfi-cross-dso,$(my_cflags))
369 else
370 # Apply the version script to non-static executables
371 my_ldflags += -Wl,--version-script,build/soong/cc/config/cfi_exports.map
372 LOCAL_ADDITIONAL_DEPENDENCIES += build/soong/cc/config/cfi_exports.map
373 endif
Evgenii Stepanov202c7a72016-07-07 10:56:39 -0700374endif
375
Chih-Hung Hsiehad741e62016-03-09 14:54:55 -0800376# If local or global modules need ASAN, add linker flags.
377ifneq ($(filter address,$(my_global_sanitize) $(my_sanitize)),)
Dan Albert4ae5d4b2014-10-31 16:23:08 -0700378 my_ldflags += $(ADDRESS_SANITIZER_CONFIG_EXTRA_LDFLAGS)
379 ifdef LOCAL_IS_HOST_MODULE
Dan Albert08cca282014-12-11 18:56:26 -0800380 # -nodefaultlibs (provided with libc++) prevents the driver from linking
381 # libraries needed with -fsanitize=address. http://b/18650275 (WAI)
Dan Albert1f0d5302015-04-28 14:55:50 -0700382 my_ldflags += -Wl,--no-as-needed
Dan Albert4ae5d4b2014-10-31 16:23:08 -0700383 else
Chih-Hung Hsiehad741e62016-03-09 14:54:55 -0800384 # Add asan libraries unless LOCAL_MODULE is the asan library.
Evgenii Stepanovf0b15e12015-04-24 16:34:47 -0700385 # ASan runtime library must be the first in the link order.
Chih-Hung Hsiehad741e62016-03-09 14:54:55 -0800386 ifeq (,$(filter $(LOCAL_MODULE),$($(LOCAL_2ND_ARCH_VAR_PREFIX)ADDRESS_SANITIZER_RUNTIME_LIBRARY)))
387 my_shared_libraries := $($(LOCAL_2ND_ARCH_VAR_PREFIX)ADDRESS_SANITIZER_RUNTIME_LIBRARY) \
388 $(my_shared_libraries)
389 endif
Chih-Hung Hsiehad741e62016-03-09 14:54:55 -0800390
391 # Do not add unnecessary dependency in shared libraries.
392 ifeq ($(LOCAL_MODULE_CLASS),SHARED_LIBRARIES)
393 my_ldflags += -Wl,--as-needed
394 endif
Ying Wanga05e2222015-08-17 16:13:24 -0700395
Mikhail Naganovaa73cef2018-12-20 15:55:08 -0800396 ifneq ($(filter EXECUTABLES NATIVE_TESTS,$(LOCAL_MODULE_CLASS)),)
Colin Crossd08699e2016-07-17 15:28:07 -0700397 ifneq ($(LOCAL_FORCE_STATIC_EXECUTABLE),true)
398 my_linker := $($(LOCAL_2ND_ARCH_VAR_PREFIX)ADDRESS_SANITIZER_LINKER)
399 # Make sure linker_asan get installed.
Logan Chienc6d2cf82019-01-31 17:07:50 +0800400 $(LOCAL_INSTALLED_MODULE) : | $(PRODUCT_OUT)$($(LOCAL_2ND_ARCH_VAR_PREFIX)ADDRESS_SANITIZER_LINKER_FILE)
Colin Crossd08699e2016-07-17 15:28:07 -0700401 endif
402 endif
Dan Albert08cca282014-12-11 18:56:26 -0800403 endif
404endif
405
Chih-Hung Hsiehad741e62016-03-09 14:54:55 -0800406# If local module needs ASAN, add compiler flags.
407ifneq ($(filter address,$(my_sanitize)),)
408 # Frame pointer based unwinder in ASan requires ARM frame setup.
409 LOCAL_ARM_MODE := arm
410 my_cflags += $(ADDRESS_SANITIZER_CONFIG_EXTRA_CFLAGS)
411 ifndef LOCAL_IS_HOST_MODULE
412 my_cflags += -mllvm -asan-globals=0
413 endif
414endif
415
Evgenii Stepanovaec1ffc2018-08-28 13:52:08 -0700416# If local module needs HWASAN, add compiler flags.
417ifneq ($(filter hwaddress,$(my_sanitize)),)
418 my_cflags += $(HWADDRESS_SANITIZER_CONFIG_EXTRA_CFLAGS)
419endif
420
Dan Willemsen58634e12020-03-06 18:09:06 -0800421# Use minimal diagnostics when integer overflow is enabled; never do it for HOST modules
422ifeq ($(LOCAL_IS_HOST_MODULE),)
Ivan Lozano911cb992018-02-21 13:41:05 -0800423 # Pre-emptively add UBSAN minimal runtime incase a static library dependency requires it
424 ifeq ($(filter STATIC_LIBRARIES,$(LOCAL_MODULE_CLASS)),)
425 ifndef LOCAL_SDK_VERSION
426 my_static_libraries += $($(LOCAL_2ND_ARCH_VAR_PREFIX)UBSAN_MINIMAL_RUNTIME_LIBRARY)
Ivan Lozanoe5081692018-05-11 14:09:36 -0700427 my_ldflags += -Wl,--exclude-libs,$($(LOCAL_2ND_ARCH_VAR_PREFIX)UBSAN_MINIMAL_RUNTIME_LIBRARY).a
Ivan Lozano911cb992018-02-21 13:41:05 -0800428 endif
429 endif
430 ifneq ($(filter unsigned-integer-overflow signed-integer-overflow integer,$(my_sanitize)),)
Kostya Kortchinsky47c10eb2018-10-11 08:56:12 -0700431 ifeq ($(filter unsigned-integer-overflow signed-integer-overflow integer,$(my_sanitize_diag)),)
Ivan Lozano911cb992018-02-21 13:41:05 -0800432 ifeq ($(filter cfi,$(my_sanitize_diag)),)
Mitch Phillipsee8f4a02019-05-01 14:37:33 -0700433 ifeq ($(filter address hwaddress fuzzer-no-link,$(my_sanitize)),)
Ivan Lozano911cb992018-02-21 13:41:05 -0800434 my_cflags += -fsanitize-minimal-runtime
435 my_cflags += -fno-sanitize-trap=integer
436 my_cflags += -fno-sanitize-recover=integer
437 endif
438 endif
439 endif
440 endif
441endif
442
Kostya Kortchinsky47c10eb2018-10-11 08:56:12 -0700443# For Scudo, we opt for the minimal runtime, unless some diagnostics are enabled.
444ifneq ($(filter scudo,$(my_sanitize)),)
445 ifeq ($(filter unsigned-integer-overflow signed-integer-overflow integer cfi,$(my_sanitize_diag)),)
446 my_cflags += -fsanitize-minimal-runtime
447 endif
448 ifneq ($(filter -fsanitize-minimal-runtime,$(my_cflags)),)
449 my_shared_libraries += $($(LOCAL_2ND_ARCH_VAR_PREFIX)SCUDO_MINIMAL_RUNTIME_LIBRARY)
450 else
451 my_shared_libraries += $($(LOCAL_2ND_ARCH_VAR_PREFIX)SCUDO_RUNTIME_LIBRARY)
452 endif
453endif
454
Dan Albert9f176552015-04-28 11:26:45 -0700455ifneq ($(strip $(LOCAL_SANITIZE_RECOVER)),)
456 recover_arg := $(subst $(space),$(comma),$(LOCAL_SANITIZE_RECOVER)),
Dan Albert4111d482015-04-16 18:08:44 -0700457 my_cflags += -fsanitize-recover=$(recover_arg)
458endif
Evgenii Stepanov202c7a72016-07-07 10:56:39 -0700459
Ivan Lozano5fb2de72018-12-12 10:04:34 -0800460ifneq ($(strip $(LOCAL_SANITIZE_NO_RECOVER)),)
461 no_recover_arg := $(subst $(space),$(comma),$(LOCAL_SANITIZE_NO_RECOVER)),
462 my_cflags += -fno-sanitize-recover=$(no_recover_arg)
463endif
464
Vishwath Mohan8dcfdce2017-01-18 17:50:29 -0800465ifneq ($(my_sanitize_diag),)
Vishwath Mohan85f72442017-11-01 09:21:20 +0000466 # TODO(vishwath): Add diagnostic support for static executables once
467 # we switch to clang-4393122 (which adds the static ubsan runtime
468 # that this depends on)
469 ifneq ($(LOCAL_FORCE_STATIC_EXECUTABLE),true)
470 notrap_arg := $(subst $(space),$(comma),$(my_sanitize_diag)),
471 my_cflags += -fno-sanitize-trap=$(notrap_arg)
472 # Diagnostic requires a runtime library, unless ASan or TSan are also enabled.
Evgenii Stepanov8841a7f2018-07-27 11:54:32 -0700473 ifeq ($(filter address thread scudo hwaddress,$(my_sanitize)),)
Vishwath Mohan85f72442017-11-01 09:21:20 +0000474 # Does not have to be the first DT_NEEDED unlike ASan.
475 my_shared_libraries += $($(LOCAL_2ND_ARCH_VAR_PREFIX)UBSAN_RUNTIME_LIBRARY)
476 endif
Evgenii Stepanov202c7a72016-07-07 10:56:39 -0700477 endif
478endif
Chih-Hung Hsieh18710622018-11-17 20:18:08 -0800479
480# http://b/119329758, Android core does not boot up with this sanitizer yet.
481# Previously sanitized modules might not pass new implicit-integer-sign-change check.
482# Disable this check unless it has been explicitly specified.
483ifneq ($(findstring fsanitize,$(my_cflags)),)
484 ifneq ($(findstring integer,$(my_cflags)),)
485 ifeq ($(findstring sanitize=implicit-integer-sign-change,$(my_cflags)),)
486 my_cflags += -fno-sanitize=implicit-integer-sign-change
487 endif
488 endif
489endif
Yabin Cui462c12d2021-01-14 14:05:54 -0800490
491# http://b/177566116, libc++ may crash with this sanitizer.
492# Disable this check unless it has been explicitly specified.
493ifneq ($(findstring fsanitize,$(my_cflags)),)
494 ifneq ($(findstring integer,$(my_cflags)),)
495 ifeq ($(findstring sanitize=unsigned-shift-base,$(my_cflags)),)
496 my_cflags += -fno-sanitize=unsigned-shift-base
497 endif
498 endif
499endif