blob: 8bd92486e0804b589aedb61c7b51f274119fd68d [file] [log] [blame]
Dan Albert4ae5d4b2014-10-31 16:23:08 -07001##############################################
2## Perform configuration steps for sanitizers.
3##############################################
4
Dan Albert27ccb752015-04-16 16:21:02 -07005my_sanitize := $(strip $(LOCAL_SANITIZE))
Vishwath Mohan8dcfdce2017-01-18 17:50:29 -08006my_sanitize_diag := $(strip $(LOCAL_SANITIZE_DIAG))
Dan Albert08cca282014-12-11 18:56:26 -08007
Dan Albert4c401412015-08-19 20:13:33 -07008# SANITIZE_HOST is only in effect if the module is already using clang (host
9# modules that haven't set `LOCAL_CLANG := false` and device modules that
10# have set `LOCAL_CLANG := true`.
11my_global_sanitize :=
Ivan Lozano4a363732017-06-28 09:11:26 -070012my_global_sanitize_diag :=
Dan Albert4c401412015-08-19 20:13:33 -070013ifeq ($(my_clang),true)
14 ifdef LOCAL_IS_HOST_MODULE
15 my_global_sanitize := $(strip $(SANITIZE_HOST))
16
17 # SANITIZE_HOST=true is a deprecated way to say SANITIZE_HOST=address.
18 my_global_sanitize := $(subst true,address,$(my_global_sanitize))
19 else
20 my_global_sanitize := $(strip $(SANITIZE_TARGET))
Ivan Lozano4a363732017-06-28 09:11:26 -070021 my_global_sanitize_diag := $(strip $(SANITIZE_TARGET_DIAG))
Dan Albert4c401412015-08-19 20:13:33 -070022 endif
23endif
24
Ivan Lozanob4749cb2017-07-21 10:33:32 -070025# Disable global integer_overflow in excluded paths.
26ifneq ($(filter integer_overflow, $(my_global_sanitize)),)
27 combined_exclude_paths := $(INTEGER_OVERFLOW_EXCLUDE_PATHS) \
28 $(PRODUCT_INTEGER_OVERFLOW_EXCLUDE_PATHS)
29
30 ifneq ($(strip $(foreach dir,$(subst $(comma),$(space),$(combined_exclude_paths)),\
31 $(filter $(dir)%,$(LOCAL_PATH)))),)
32 my_global_sanitize := $(filter-out integer_overflow,$(my_global_sanitize))
33 my_global_sanitize_diag := $(filter-out integer_overflow,$(my_global_sanitize_diag))
34 endif
35endif
36
Vishwath Mohan23b2d2e2017-10-31 02:25:16 -070037# Disable global CFI in excluded paths
38ifneq ($(filter cfi, $(my_global_sanitize)),)
39 combined_exclude_paths := $(CFI_EXCLUDE_PATHS) \
40 $(PRODUCT_CFI_EXCLUDE_PATHS)
41
42 ifneq ($(strip $(foreach dir,$(subst $(comma),$(space),$(combined_exclude_paths)),\
43 $(filter $(dir)%,$(LOCAL_PATH)))),)
44 my_global_sanitize := $(filter-out cfi,$(my_global_sanitize))
45 my_global_sanitize_diag := $(filter-out cfi,$(my_global_sanitize_diag))
46 endif
47endif
48
Dan Albert4c401412015-08-19 20:13:33 -070049ifneq ($(my_global_sanitize),)
Evgenii Stepanov71faa192016-05-19 17:45:21 -070050 my_sanitize := $(my_global_sanitize) $(my_sanitize)
Dan Albert4c401412015-08-19 20:13:33 -070051endif
Ivan Lozano4a363732017-06-28 09:11:26 -070052ifneq ($(my_global_sanitize_diag),)
53 my_sanitize_diag := $(my_global_sanitize_diag) $(my_sanitize_diag)
54endif
Dan Albert4c401412015-08-19 20:13:33 -070055
Andreas Gampe6b30d772016-06-27 15:15:31 -070056# The sanitizer specified in the product configuration wins over the previous.
57ifneq ($(SANITIZER.$(TARGET_PRODUCT).$(LOCAL_MODULE).CONFIG),)
58 my_sanitize := $(SANITIZER.$(TARGET_PRODUCT).$(LOCAL_MODULE).CONFIG)
59 ifeq ($(my_sanitize),never)
60 my_sanitize :=
Ivan Lozano4a363732017-06-28 09:11:26 -070061 my_sanitize_diag :=
Andreas Gampe6b30d772016-06-27 15:15:31 -070062 endif
63endif
64
Colin Cross23618422016-11-02 15:05:21 -070065ifndef LOCAL_IS_HOST_MODULE
66 # Add a filter point for 32-bit vs 64-bit sanitization (to lighten the burden)
67 SANITIZE_TARGET_ARCH ?= $(TARGET_ARCH) $(TARGET_2ND_ARCH)
68 ifeq ($(filter $(SANITIZE_TARGET_ARCH),$(TARGET_$(LOCAL_2ND_ARCH_VAR_PREFIX)ARCH)),)
69 my_sanitize :=
Ivan Lozano4a363732017-06-28 09:11:26 -070070 my_sanitize_diag :=
Colin Cross23618422016-11-02 15:05:21 -070071 endif
Andreas Gampecd257402016-06-20 17:36:49 -070072endif
73
Andreas Gampe3d3b0c92016-06-20 17:46:29 -070074# Add a filter point based on module owner (to lighten the burden). The format is a space- or
75# colon-separated list of owner names.
76ifneq (,$(SANITIZE_NEVER_BY_OWNER))
77 ifneq (,$(LOCAL_MODULE_OWNER))
78 ifneq (,$(filter $(LOCAL_MODULE_OWNER),$(subst :, ,$(SANITIZE_NEVER_BY_OWNER))))
79 $(warning Not sanitizing $(LOCAL_MODULE) based on module owner.)
80 my_sanitize :=
Ivan Lozano4a363732017-06-28 09:11:26 -070081 my_sanitize_diag :=
Andreas Gampe3d3b0c92016-06-20 17:46:29 -070082 endif
83 endif
84endif
85
Dan Albert08cca282014-12-11 18:56:26 -080086# Don't apply sanitizers to NDK code.
87ifdef LOCAL_SDK_VERSION
Dan Albert4c401412015-08-19 20:13:33 -070088 my_sanitize :=
Dan Willemsenf761c0f2016-06-28 16:47:43 -070089 my_global_sanitize :=
Ivan Lozano4a363732017-06-28 09:11:26 -070090 my_sanitize_diag :=
Dan Albert27ccb752015-04-16 16:21:02 -070091endif
92
Dan Albert4c401412015-08-19 20:13:33 -070093# Never always wins.
94ifeq ($(LOCAL_SANITIZE),never)
Dan Albert08cca282014-12-11 18:56:26 -080095 my_sanitize :=
Ivan Lozano4a363732017-06-28 09:11:26 -070096 my_sanitize_diag :=
Dan Albert08cca282014-12-11 18:56:26 -080097endif
98
Vishwath Mohan23b2d2e2017-10-31 02:25:16 -070099# Enable CFI in included paths.
100ifeq ($(filter cfi, $(my_sanitize)),)
101 combined_include_paths := $(CFI_INCLUDE_PATHS) \
102 $(PRODUCT_CFI_INCLUDE_PATHS)
103
104 ifneq ($(strip $(foreach dir,$(subst $(comma),$(space),$(combined_include_paths)),\
105 $(filter $(dir)%,$(LOCAL_PATH)))),)
106 my_sanitize := cfi $(my_sanitize)
107 my_sanitize_diag := cfi $(my_sanitize_diag)
108 endif
109endif
110
Vishwath Mohan8dcfdce2017-01-18 17:50:29 -0800111# If CFI is disabled globally, remove it from my_sanitize.
Vishwath Mohan45665b42017-01-24 13:20:28 -0800112ifeq ($(strip $(ENABLE_CFI)),false)
Vishwath Mohan8dcfdce2017-01-18 17:50:29 -0800113 my_sanitize := $(filter-out cfi,$(my_sanitize))
114 my_sanitize_diag := $(filter-out cfi,$(my_sanitize_diag))
115endif
116
Vishwath Mohana2046062017-02-07 20:28:07 -0800117# Disable CFI for arm32 (b/35157333).
118ifneq ($(filter arm,$(TARGET_$(LOCAL_2ND_ARCH_VAR_PREFIX)ARCH)),)
119 my_sanitize := $(filter-out cfi,$(my_sanitize))
120 my_sanitize_diag := $(filter-out cfi,$(my_sanitize_diag))
121endif
122
Vishwath Mohanc026f6d2017-04-20 07:39:13 -0700123# Also disable CFI if ASAN is enabled.
124ifneq ($(filter address,$(my_sanitize)),)
125 my_sanitize := $(filter-out cfi,$(my_sanitize))
126 my_sanitize_diag := $(filter-out cfi,$(my_sanitize_diag))
127endif
128
Evgenii Stepanov8c50e3c2017-01-31 17:08:33 -0800129# CFI needs gold linker, and mips toolchain does not have one.
130ifneq ($(filter mips mips64,$(TARGET_$(LOCAL_2ND_ARCH_VAR_PREFIX)ARCH)),)
131 my_sanitize := $(filter-out cfi,$(my_sanitize))
132 my_sanitize_diag := $(filter-out cfi,$(my_sanitize_diag))
133endif
134
Ivan Lozano4a363732017-06-28 09:11:26 -0700135# Support for local sanitize blacklist paths.
136ifneq ($(my_sanitize)$(my_global_sanitize),)
137 ifneq ($(LOCAL_SANITIZE_BLACKLIST),)
138 my_cflags += -fsanitize-blacklist=$(LOCAL_PATH)/$(LOCAL_SANITIZE_BLACKLIST)
139 endif
140endif
141
Ivan Lozanob4749cb2017-07-21 10:33:32 -0700142# Disable integer_overflow if LOCAL_NOSANITIZE=integer.
Ivan Lozano4a363732017-06-28 09:11:26 -0700143ifneq ($(filter integer_overflow, $(my_global_sanitize) $(my_sanitize)),)
144 ifneq ($(filter integer, $(strip $(LOCAL_NOSANITIZE))),)
145 my_sanitize := $(filter-out integer_overflow,$(my_sanitize))
146 my_sanitize_diag := $(filter-out integer_overflow,$(my_sanitize_diag))
147 endif
148endif
149
Evgenii Stepanov42823662016-05-12 13:07:17 -0700150my_nosanitize = $(strip $(LOCAL_NOSANITIZE))
151ifneq ($(my_nosanitize),)
152 my_sanitize := $(filter-out $(my_nosanitize),$(my_sanitize))
153endif
154
Dan Alberta6311b72015-07-30 10:17:33 -0700155# TSAN is not supported on 32-bit architectures. For non-multilib cases, make
156# its use an error. For multilib cases, don't use it for the 32-bit case.
157ifneq ($(filter thread,$(my_sanitize)),)
158 ifeq ($(my_32_64_bit_suffix),32)
159 ifeq ($(my_module_multilib),both)
160 my_sanitize := $(filter-out thread,$(my_sanitize))
161 else
162 $(error $(LOCAL_PATH): $(LOCAL_MODULE): TSAN cannot be used for 32-bit modules.)
163 endif
Yabin Cuie77c32e2017-10-19 14:33:58 -0700164 else
165 my_shared_libraries += $(TSAN_RUNTIME_LIBRARY)
Dan Alberta6311b72015-07-30 10:17:33 -0700166 endif
167endif
168
Evgenii Stepanov7dcb8b82016-05-06 18:15:57 -0700169ifneq ($(filter safe-stack,$(my_sanitize)),)
170 ifeq ($(my_32_64_bit_suffix),32)
171 my_sanitize := $(filter-out safe-stack,$(my_sanitize))
172 endif
173endif
174
Evgenii Stepanov5adfcb12015-06-25 16:38:25 -0700175# Undefined symbols can occur if a non-sanitized library links
176# sanitized static libraries. That's OK, because the executable
177# always depends on the ASan runtime library, which defines these
178# symbols.
Evgenii Stepanov912b51f2016-05-19 17:49:51 -0700179ifneq ($(filter address thread,$(strip $(SANITIZE_TARGET))),)
Evgenii Stepanov5adfcb12015-06-25 16:38:25 -0700180 ifndef LOCAL_IS_HOST_MODULE
181 ifeq ($(LOCAL_MODULE_CLASS),SHARED_LIBRARIES)
182 ifeq ($(my_sanitize),)
183 my_allow_undefined_symbols := true
184 endif
185 endif
186 endif
187endif
188
Dan Albert94b57912015-04-17 09:48:33 -0700189# Sanitizers can only be used with clang.
190ifneq ($(my_clang),true)
191 ifneq ($(my_sanitize),)
192 $(error $(LOCAL_PATH): $(LOCAL_MODULE): Use of sanitizers requires LOCAL_CLANG := true)
193 endif
194endif
195
Dan Albertb5b2ffe2015-04-16 18:07:07 -0700196ifneq ($(filter default-ub,$(my_sanitize)),)
197 my_sanitize := $(CLANG_DEFAULT_UB_CHECKS)
Dan Albert08cca282014-12-11 18:56:26 -0800198endif
199
Ivan Krasin74b32b82015-09-18 11:54:43 -0700200ifneq ($(filter coverage,$(my_sanitize)),)
201 ifeq ($(filter address,$(my_sanitize)),)
202 $(error $(LOCAL_PATH): $(LOCAL_MODULE): Use of 'coverage' also requires 'address')
203 endif
Zach Rigglebe0811f2017-08-21 17:07:42 -0400204 my_cflags += -fsanitize-coverage=trace-pc-guard,indirect-calls,trace-cmp
Ivan Krasin74b32b82015-09-18 11:54:43 -0700205 my_sanitize := $(filter-out coverage,$(my_sanitize))
206endif
207
Ivan Lozano4a363732017-06-28 09:11:26 -0700208ifneq ($(filter integer_overflow,$(my_sanitize)),)
209 ifneq ($(filter SHARED_LIBRARIES EXECUTABLES,$(LOCAL_MODULE_CLASS)),)
210 ifneq ($(LOCAL_FORCE_STATIC_EXECUTABLE),true)
211
212 # Respect LOCAL_NOSANITIZE for integer-overflow flags.
213 ifeq ($(filter signed-integer-overflow, $(strip $(LOCAL_NOSANITIZE))),)
214 my_cflags += -fsanitize=signed-integer-overflow
215 endif
216 ifeq ($(filter unsigned-integer-overflow, $(strip $(LOCAL_NOSANITIZE))),)
217 my_cflags += -fsanitize=unsigned-integer-overflow
218 endif
219 my_cflags += -fsanitize-trap=all
220 my_cflags += -ftrap-function=abort
221 my_cflags += $(INTEGER_OVERFLOW_EXTRA_CFLAGS)
222
223 # Check for diagnostics mode (on by default).
224 ifneq ($(filter integer_overflow,$(my_sanitize_diag)),)
225 my_cflags += -fno-sanitize-trap=signed-integer-overflow,unsigned-integer-overflow
226 my_shared_libraries := $($(LOCAL_2ND_ARCH_VAR_PREFIX)UBSAN_RUNTIME_LIBRARY) $(my_shared_libraries)
227 endif
228 endif
229 endif
230 my_sanitize := $(filter-out integer_overflow,$(my_sanitize))
231endif
232
233# Makes sure integer_overflow diagnostics is removed from the diagnostics list
234# even if integer_overflow is not set for some reason.
235ifneq ($(filter integer_overflow,$(my_sanitize_diag)),)
236 my_sanitize_diag := $(filter-out integer_overflow,$(my_sanitize_diag))
237endif
238
Dan Albert08cca282014-12-11 18:56:26 -0800239ifneq ($(my_sanitize),)
Stephen Hinese8119e92015-11-09 16:32:11 -0800240 fsanitize_arg := $(subst $(space),$(comma),$(my_sanitize))
Dan Albert08cca282014-12-11 18:56:26 -0800241 my_cflags += -fsanitize=$(fsanitize_arg)
242
243 ifdef LOCAL_IS_HOST_MODULE
Dan Albertabf4bc92015-06-16 23:27:34 -0700244 my_cflags += -fno-sanitize-recover=all
Dan Albert08cca282014-12-11 18:56:26 -0800245 my_ldflags += -fsanitize=$(fsanitize_arg)
Dan Albertabf4bc92015-06-16 23:27:34 -0700246 else
Evgenii Stepanov71faa192016-05-19 17:45:21 -0700247 my_cflags += -fsanitize-trap=all
248 my_cflags += -ftrap-function=abort
Evgenii Stepanov55f73e62016-05-12 13:07:36 -0700249 ifneq ($(filter address thread,$(my_sanitize)),)
Evgenii Stepanov71faa192016-05-19 17:45:21 -0700250 my_cflags += -fno-sanitize-trap=address,thread
Evgenii Stepanov55f73e62016-05-12 13:07:36 -0700251 my_shared_libraries += libdl
252 endif
Dan Albert08cca282014-12-11 18:56:26 -0800253 endif
254endif
255
Evgenii Stepanov202c7a72016-07-07 10:56:39 -0700256ifneq ($(filter cfi,$(my_sanitize)),)
Evgenii Stepanov81bea1b2017-01-20 14:12:08 -0800257 # __cfi_check needs to be built as Thumb (see the code in linker_cfi.cpp).
258 # LLVM is not set up to do this on a function basis, so force Thumb on the
259 # entire module.
260 LOCAL_ARM_MODE := thumb
Vishwath Mohan5b69c062017-02-14 07:55:37 -0800261 my_cflags += $(CFI_EXTRA_CFLAGS)
Vishwath Mohan85f72442017-11-01 09:21:20 +0000262 # Only append the default visibility flag if -fvisibility has not already been
263 # set to hidden.
264 ifeq ($(filter -fvisibility=hidden,$(LOCAL_CFLAGS)),)
265 my_cflags += -fvisibility=default
266 endif
Vishwath Mohan5b69c062017-02-14 07:55:37 -0800267 my_ldflags += $(CFI_EXTRA_LDFLAGS)
Evgenii Stepanove1b96f32017-01-23 16:57:38 -0800268 my_arflags += --plugin $(LLVM_PREBUILTS_PATH)/../lib64/LLVMgold.so
Vishwath Mohan85f72442017-11-01 09:21:20 +0000269
270 ifeq ($(LOCAL_FORCE_STATIC_EXECUTABLE),true)
271 my_ldflags := $(filter-out -fsanitize-cfi-cross-dso,$(my_ldflags))
272 my_cflags := $(filter-out -fsanitize-cfi-cross-dso,$(my_cflags))
273 else
274 # Apply the version script to non-static executables
275 my_ldflags += -Wl,--version-script,build/soong/cc/config/cfi_exports.map
276 LOCAL_ADDITIONAL_DEPENDENCIES += build/soong/cc/config/cfi_exports.map
277 endif
Evgenii Stepanov202c7a72016-07-07 10:56:39 -0700278endif
279
Chih-Hung Hsiehad741e62016-03-09 14:54:55 -0800280# If local or global modules need ASAN, add linker flags.
281ifneq ($(filter address,$(my_global_sanitize) $(my_sanitize)),)
Dan Albert4ae5d4b2014-10-31 16:23:08 -0700282 my_ldflags += $(ADDRESS_SANITIZER_CONFIG_EXTRA_LDFLAGS)
283 ifdef LOCAL_IS_HOST_MODULE
Dan Albert08cca282014-12-11 18:56:26 -0800284 # -nodefaultlibs (provided with libc++) prevents the driver from linking
285 # libraries needed with -fsanitize=address. http://b/18650275 (WAI)
Dan Albert1f0d5302015-04-28 14:55:50 -0700286 my_ldflags += -Wl,--no-as-needed
Dan Albert4ae5d4b2014-10-31 16:23:08 -0700287 else
Chih-Hung Hsiehad741e62016-03-09 14:54:55 -0800288 # Add asan libraries unless LOCAL_MODULE is the asan library.
Evgenii Stepanovf0b15e12015-04-24 16:34:47 -0700289 # ASan runtime library must be the first in the link order.
Chih-Hung Hsiehad741e62016-03-09 14:54:55 -0800290 ifeq (,$(filter $(LOCAL_MODULE),$($(LOCAL_2ND_ARCH_VAR_PREFIX)ADDRESS_SANITIZER_RUNTIME_LIBRARY)))
291 my_shared_libraries := $($(LOCAL_2ND_ARCH_VAR_PREFIX)ADDRESS_SANITIZER_RUNTIME_LIBRARY) \
292 $(my_shared_libraries)
293 endif
294 ifeq (,$(filter $(LOCAL_MODULE),$(ADDRESS_SANITIZER_CONFIG_EXTRA_STATIC_LIBRARIES)))
295 my_static_libraries += $(ADDRESS_SANITIZER_CONFIG_EXTRA_STATIC_LIBRARIES)
296 endif
297
298 # Do not add unnecessary dependency in shared libraries.
299 ifeq ($(LOCAL_MODULE_CLASS),SHARED_LIBRARIES)
300 my_ldflags += -Wl,--as-needed
301 endif
Ying Wanga05e2222015-08-17 16:13:24 -0700302
Colin Crossd08699e2016-07-17 15:28:07 -0700303 ifeq ($(LOCAL_MODULE_CLASS),EXECUTABLES)
304 ifneq ($(LOCAL_FORCE_STATIC_EXECUTABLE),true)
305 my_linker := $($(LOCAL_2ND_ARCH_VAR_PREFIX)ADDRESS_SANITIZER_LINKER)
306 # Make sure linker_asan get installed.
307 $(LOCAL_INSTALLED_MODULE) : | $(PRODUCT_OUT)$($(LOCAL_2ND_ARCH_VAR_PREFIX)ADDRESS_SANITIZER_LINKER)
308 endif
309 endif
Dan Albert08cca282014-12-11 18:56:26 -0800310 endif
311endif
312
Chih-Hung Hsiehad741e62016-03-09 14:54:55 -0800313# If local module needs ASAN, add compiler flags.
314ifneq ($(filter address,$(my_sanitize)),)
315 # Frame pointer based unwinder in ASan requires ARM frame setup.
316 LOCAL_ARM_MODE := arm
317 my_cflags += $(ADDRESS_SANITIZER_CONFIG_EXTRA_CFLAGS)
318 ifndef LOCAL_IS_HOST_MODULE
319 my_cflags += -mllvm -asan-globals=0
320 endif
321endif
322
Dan Albert9f176552015-04-28 11:26:45 -0700323ifneq ($(strip $(LOCAL_SANITIZE_RECOVER)),)
324 recover_arg := $(subst $(space),$(comma),$(LOCAL_SANITIZE_RECOVER)),
Dan Albert4111d482015-04-16 18:08:44 -0700325 my_cflags += -fsanitize-recover=$(recover_arg)
326endif
Evgenii Stepanov202c7a72016-07-07 10:56:39 -0700327
Vishwath Mohan8dcfdce2017-01-18 17:50:29 -0800328ifneq ($(my_sanitize_diag),)
Vishwath Mohan85f72442017-11-01 09:21:20 +0000329 # TODO(vishwath): Add diagnostic support for static executables once
330 # we switch to clang-4393122 (which adds the static ubsan runtime
331 # that this depends on)
332 ifneq ($(LOCAL_FORCE_STATIC_EXECUTABLE),true)
333 notrap_arg := $(subst $(space),$(comma),$(my_sanitize_diag)),
334 my_cflags += -fno-sanitize-trap=$(notrap_arg)
335 # Diagnostic requires a runtime library, unless ASan or TSan are also enabled.
336 ifeq ($(filter address thread,$(my_sanitize)),)
337 # Does not have to be the first DT_NEEDED unlike ASan.
338 my_shared_libraries += $($(LOCAL_2ND_ARCH_VAR_PREFIX)UBSAN_RUNTIME_LIBRARY)
339 endif
Evgenii Stepanov202c7a72016-07-07 10:56:39 -0700340 endif
341endif