blob: efb21e7c6a532c8dd7ce63950d187a4bf37a4ba4 [file] [log] [blame]
Dan Albert4ae5d4b2014-10-31 16:23:08 -07001##############################################
2## Perform configuration steps for sanitizers.
3##############################################
4
Dan Albert27ccb752015-04-16 16:21:02 -07005my_sanitize := $(strip $(LOCAL_SANITIZE))
Vishwath Mohan8dcfdce2017-01-18 17:50:29 -08006my_sanitize_diag := $(strip $(LOCAL_SANITIZE_DIAG))
Dan Albert08cca282014-12-11 18:56:26 -08007
Dan Albert4c401412015-08-19 20:13:33 -07008my_global_sanitize :=
Ivan Lozano4a363732017-06-28 09:11:26 -07009my_global_sanitize_diag :=
Dan Willemsenf0638392018-09-04 22:25:22 -070010ifdef LOCAL_IS_HOST_MODULE
11 ifneq ($($(my_prefix)OS),windows)
12 my_global_sanitize := $(strip $(SANITIZE_HOST))
Dan Albert4c401412015-08-19 20:13:33 -070013
Dan Willemsenf0638392018-09-04 22:25:22 -070014 # SANITIZE_HOST=true is a deprecated way to say SANITIZE_HOST=address.
15 my_global_sanitize := $(subst true,address,$(my_global_sanitize))
Dan Albert4c401412015-08-19 20:13:33 -070016 endif
Dan Willemsenf0638392018-09-04 22:25:22 -070017else
18 my_global_sanitize := $(strip $(SANITIZE_TARGET))
19 my_global_sanitize_diag := $(strip $(SANITIZE_TARGET_DIAG))
Dan Albert4c401412015-08-19 20:13:33 -070020endif
21
Ivan Lozanob4749cb2017-07-21 10:33:32 -070022# Disable global integer_overflow in excluded paths.
23ifneq ($(filter integer_overflow, $(my_global_sanitize)),)
24 combined_exclude_paths := $(INTEGER_OVERFLOW_EXCLUDE_PATHS) \
25 $(PRODUCT_INTEGER_OVERFLOW_EXCLUDE_PATHS)
26
27 ifneq ($(strip $(foreach dir,$(subst $(comma),$(space),$(combined_exclude_paths)),\
28 $(filter $(dir)%,$(LOCAL_PATH)))),)
29 my_global_sanitize := $(filter-out integer_overflow,$(my_global_sanitize))
30 my_global_sanitize_diag := $(filter-out integer_overflow,$(my_global_sanitize_diag))
31 endif
32endif
33
Ivan Lozano702e8bd2018-03-15 14:49:20 -070034# Global integer sanitization doesn't support static modules.
35ifeq ($(filter SHARED_LIBRARIES EXECUTABLES,$(LOCAL_MODULE_CLASS)),)
36 my_global_sanitize := $(filter-out integer_overflow,$(my_global_sanitize))
37 my_global_sanitize_diag := $(filter-out integer_overflow,$(my_global_sanitize_diag))
38endif
39ifeq ($(LOCAL_FORCE_STATIC_EXECUTABLE),true)
40 my_global_sanitize := $(filter-out integer_overflow,$(my_global_sanitize))
41 my_global_sanitize_diag := $(filter-out integer_overflow,$(my_global_sanitize_diag))
42endif
43
Vishwath Mohan23b2d2e2017-10-31 02:25:16 -070044# Disable global CFI in excluded paths
45ifneq ($(filter cfi, $(my_global_sanitize)),)
46 combined_exclude_paths := $(CFI_EXCLUDE_PATHS) \
47 $(PRODUCT_CFI_EXCLUDE_PATHS)
48
49 ifneq ($(strip $(foreach dir,$(subst $(comma),$(space),$(combined_exclude_paths)),\
50 $(filter $(dir)%,$(LOCAL_PATH)))),)
51 my_global_sanitize := $(filter-out cfi,$(my_global_sanitize))
52 my_global_sanitize_diag := $(filter-out cfi,$(my_global_sanitize_diag))
53 endif
54endif
55
Dan Albert4c401412015-08-19 20:13:33 -070056ifneq ($(my_global_sanitize),)
Evgenii Stepanov71faa192016-05-19 17:45:21 -070057 my_sanitize := $(my_global_sanitize) $(my_sanitize)
Dan Albert4c401412015-08-19 20:13:33 -070058endif
Ivan Lozano4a363732017-06-28 09:11:26 -070059ifneq ($(my_global_sanitize_diag),)
60 my_sanitize_diag := $(my_global_sanitize_diag) $(my_sanitize_diag)
61endif
Dan Albert4c401412015-08-19 20:13:33 -070062
Andreas Gampe6b30d772016-06-27 15:15:31 -070063# The sanitizer specified in the product configuration wins over the previous.
64ifneq ($(SANITIZER.$(TARGET_PRODUCT).$(LOCAL_MODULE).CONFIG),)
65 my_sanitize := $(SANITIZER.$(TARGET_PRODUCT).$(LOCAL_MODULE).CONFIG)
66 ifeq ($(my_sanitize),never)
67 my_sanitize :=
Ivan Lozano4a363732017-06-28 09:11:26 -070068 my_sanitize_diag :=
Andreas Gampe6b30d772016-06-27 15:15:31 -070069 endif
70endif
71
Colin Cross23618422016-11-02 15:05:21 -070072ifndef LOCAL_IS_HOST_MODULE
73 # Add a filter point for 32-bit vs 64-bit sanitization (to lighten the burden)
74 SANITIZE_TARGET_ARCH ?= $(TARGET_ARCH) $(TARGET_2ND_ARCH)
75 ifeq ($(filter $(SANITIZE_TARGET_ARCH),$(TARGET_$(LOCAL_2ND_ARCH_VAR_PREFIX)ARCH)),)
76 my_sanitize :=
Ivan Lozano4a363732017-06-28 09:11:26 -070077 my_sanitize_diag :=
Colin Cross23618422016-11-02 15:05:21 -070078 endif
Andreas Gampecd257402016-06-20 17:36:49 -070079endif
80
Andreas Gampe3d3b0c92016-06-20 17:46:29 -070081# Add a filter point based on module owner (to lighten the burden). The format is a space- or
82# colon-separated list of owner names.
83ifneq (,$(SANITIZE_NEVER_BY_OWNER))
84 ifneq (,$(LOCAL_MODULE_OWNER))
85 ifneq (,$(filter $(LOCAL_MODULE_OWNER),$(subst :, ,$(SANITIZE_NEVER_BY_OWNER))))
86 $(warning Not sanitizing $(LOCAL_MODULE) based on module owner.)
87 my_sanitize :=
Ivan Lozano4a363732017-06-28 09:11:26 -070088 my_sanitize_diag :=
Andreas Gampe3d3b0c92016-06-20 17:46:29 -070089 endif
90 endif
91endif
92
Dan Albert08cca282014-12-11 18:56:26 -080093# Don't apply sanitizers to NDK code.
94ifdef LOCAL_SDK_VERSION
Dan Albert4c401412015-08-19 20:13:33 -070095 my_sanitize :=
Dan Willemsenf761c0f2016-06-28 16:47:43 -070096 my_global_sanitize :=
Ivan Lozano4a363732017-06-28 09:11:26 -070097 my_sanitize_diag :=
Dan Albert27ccb752015-04-16 16:21:02 -070098endif
99
Dan Albert4c401412015-08-19 20:13:33 -0700100# Never always wins.
101ifeq ($(LOCAL_SANITIZE),never)
Dan Albert08cca282014-12-11 18:56:26 -0800102 my_sanitize :=
Ivan Lozano4a363732017-06-28 09:11:26 -0700103 my_sanitize_diag :=
Dan Albert08cca282014-12-11 18:56:26 -0800104endif
105
Vishwath Mohan6106a4e2018-05-24 18:04:25 -0700106# Enable CFI in included paths (for Arm64 only).
Vishwath Mohan23b2d2e2017-10-31 02:25:16 -0700107ifeq ($(filter cfi, $(my_sanitize)),)
Vishwath Mohan6106a4e2018-05-24 18:04:25 -0700108 ifneq ($(filter arm64,$(TARGET_$(LOCAL_2ND_ARCH_VAR_PREFIX)ARCH)),)
109 combined_include_paths := $(CFI_INCLUDE_PATHS) \
110 $(PRODUCT_CFI_INCLUDE_PATHS)
Vishwath Mohan23b2d2e2017-10-31 02:25:16 -0700111
Vishwath Mohan6106a4e2018-05-24 18:04:25 -0700112 ifneq ($(strip $(foreach dir,$(subst $(comma),$(space),$(combined_include_paths)),\
113 $(filter $(dir)%,$(LOCAL_PATH)))),)
114 my_sanitize := cfi $(my_sanitize)
Vishwath Mohan6106a4e2018-05-24 18:04:25 -0700115 endif
Vishwath Mohan23b2d2e2017-10-31 02:25:16 -0700116 endif
117endif
118
Vishwath Mohan8dcfdce2017-01-18 17:50:29 -0800119# If CFI is disabled globally, remove it from my_sanitize.
Vishwath Mohan45665b42017-01-24 13:20:28 -0800120ifeq ($(strip $(ENABLE_CFI)),false)
Vishwath Mohan8dcfdce2017-01-18 17:50:29 -0800121 my_sanitize := $(filter-out cfi,$(my_sanitize))
122 my_sanitize_diag := $(filter-out cfi,$(my_sanitize_diag))
123endif
124
Vishwath Mohana2046062017-02-07 20:28:07 -0800125# Disable CFI for arm32 (b/35157333).
126ifneq ($(filter arm,$(TARGET_$(LOCAL_2ND_ARCH_VAR_PREFIX)ARCH)),)
127 my_sanitize := $(filter-out cfi,$(my_sanitize))
128 my_sanitize_diag := $(filter-out cfi,$(my_sanitize_diag))
129endif
130
Vishwath Mohanc026f6d2017-04-20 07:39:13 -0700131# Also disable CFI if ASAN is enabled.
132ifneq ($(filter address,$(my_sanitize)),)
133 my_sanitize := $(filter-out cfi,$(my_sanitize))
134 my_sanitize_diag := $(filter-out cfi,$(my_sanitize_diag))
135endif
136
Evgenii Stepanov8c50e3c2017-01-31 17:08:33 -0800137# CFI needs gold linker, and mips toolchain does not have one.
138ifneq ($(filter mips mips64,$(TARGET_$(LOCAL_2ND_ARCH_VAR_PREFIX)ARCH)),)
139 my_sanitize := $(filter-out cfi,$(my_sanitize))
140 my_sanitize_diag := $(filter-out cfi,$(my_sanitize_diag))
141endif
142
Ivan Lozano702e8bd2018-03-15 14:49:20 -0700143# Disable sanitizers which need the UBSan runtime for host targets.
Vishwath Mohan96a130b2017-11-17 11:19:36 -0800144ifdef LOCAL_IS_HOST_MODULE
145 my_sanitize := $(filter-out cfi,$(my_sanitize))
146 my_sanitize_diag := $(filter-out cfi,$(my_sanitize_diag))
Ivan Lozano702e8bd2018-03-15 14:49:20 -0700147 my_sanitize := $(filter-out signed-integer-overflow unsigned-integer-overflow integer_overflow,$(my_sanitize))
148 my_sanitize_diag := $(filter-out signed-integer-overflow unsigned-integer-overflow integer_overflow,$(my_sanitize_diag))
Vishwath Mohan96a130b2017-11-17 11:19:36 -0800149endif
150
Ivan Lozano4a363732017-06-28 09:11:26 -0700151# Support for local sanitize blacklist paths.
152ifneq ($(my_sanitize)$(my_global_sanitize),)
153 ifneq ($(LOCAL_SANITIZE_BLACKLIST),)
154 my_cflags += -fsanitize-blacklist=$(LOCAL_PATH)/$(LOCAL_SANITIZE_BLACKLIST)
155 endif
156endif
157
Ivan Lozanob4749cb2017-07-21 10:33:32 -0700158# Disable integer_overflow if LOCAL_NOSANITIZE=integer.
Ivan Lozano4a363732017-06-28 09:11:26 -0700159ifneq ($(filter integer_overflow, $(my_global_sanitize) $(my_sanitize)),)
160 ifneq ($(filter integer, $(strip $(LOCAL_NOSANITIZE))),)
161 my_sanitize := $(filter-out integer_overflow,$(my_sanitize))
162 my_sanitize_diag := $(filter-out integer_overflow,$(my_sanitize_diag))
163 endif
164endif
165
Evgenii Stepanov42823662016-05-12 13:07:17 -0700166my_nosanitize = $(strip $(LOCAL_NOSANITIZE))
167ifneq ($(my_nosanitize),)
168 my_sanitize := $(filter-out $(my_nosanitize),$(my_sanitize))
169endif
170
Evgenii Stepanov8841a7f2018-07-27 11:54:32 -0700171ifneq ($(filter arm x86 x86_64,$(TARGET_$(LOCAL_2ND_ARCH_VAR_PREFIX)ARCH)),)
172 my_sanitize := $(filter-out hwaddress,$(my_sanitize))
173endif
174
175ifneq ($(filter hwaddress,$(my_sanitize)),)
176 my_sanitize := $(filter-out address,$(my_sanitize))
177 my_sanitize := $(filter-out thread,$(my_sanitize))
Evgenii Stepanov88a95a32018-12-04 17:06:45 -0800178 my_sanitize := $(filter-out cfi,$(my_sanitize))
Evgenii Stepanov8841a7f2018-07-27 11:54:32 -0700179endif
180
181ifneq ($(filter hwaddress,$(my_sanitize)),)
182 my_shared_libraries += $($(LOCAL_2ND_ARCH_VAR_PREFIX)HWADDRESS_SANITIZER_RUNTIME_LIBRARY)
Evgenii Stepanoved907462018-11-01 15:43:14 -0700183 ifneq ($(filter EXECUTABLES NATIVE_TESTS,$(LOCAL_MODULE_CLASS)),)
Evgenii Stepanov8841a7f2018-07-27 11:54:32 -0700184 ifeq ($(LOCAL_FORCE_STATIC_EXECUTABLE),true)
Ryan Prichardacf8b0f2019-10-21 20:47:53 -0700185 my_static_libraries := $(my_static_libraries) \
186 $($(LOCAL_2ND_ARCH_VAR_PREFIX)HWADDRESS_SANITIZER_STATIC_LIBRARY) \
187 libdl
Evgenii Stepanov8841a7f2018-07-27 11:54:32 -0700188 endif
189 endif
190endif
191
Dan Alberta6311b72015-07-30 10:17:33 -0700192# TSAN is not supported on 32-bit architectures. For non-multilib cases, make
193# its use an error. For multilib cases, don't use it for the 32-bit case.
194ifneq ($(filter thread,$(my_sanitize)),)
195 ifeq ($(my_32_64_bit_suffix),32)
196 ifeq ($(my_module_multilib),both)
197 my_sanitize := $(filter-out thread,$(my_sanitize))
198 else
199 $(error $(LOCAL_PATH): $(LOCAL_MODULE): TSAN cannot be used for 32-bit modules.)
200 endif
Yabin Cuie77c32e2017-10-19 14:33:58 -0700201 else
202 my_shared_libraries += $(TSAN_RUNTIME_LIBRARY)
Dan Alberta6311b72015-07-30 10:17:33 -0700203 endif
204endif
205
Evgenii Stepanov7dcb8b82016-05-06 18:15:57 -0700206ifneq ($(filter safe-stack,$(my_sanitize)),)
207 ifeq ($(my_32_64_bit_suffix),32)
208 my_sanitize := $(filter-out safe-stack,$(my_sanitize))
209 endif
210endif
211
Kostya Kortchinsky2cfa9972018-06-14 11:02:15 -0700212# Disable Scudo if ASan or TSan is enabled.
Evgenii Stepanov8841a7f2018-07-27 11:54:32 -0700213ifneq ($(filter address thread hwaddress,$(my_sanitize)),)
Kostya Kortchinsky2cfa9972018-06-14 11:02:15 -0700214 my_sanitize := $(filter-out scudo,$(my_sanitize))
215endif
216
Kostya Kortchinsky02732402019-02-01 09:06:42 -0800217# Or if disabled globally.
Anton Hansson8dab0a62019-03-28 15:45:40 +0000218ifeq ($(PRODUCT_DISABLE_SCUDO),true)
Kostya Kortchinsky02732402019-02-01 09:06:42 -0800219 my_sanitize := $(filter-out scudo,$(my_sanitize))
220endif
221
Evgenii Stepanov5adfcb12015-06-25 16:38:25 -0700222# Undefined symbols can occur if a non-sanitized library links
223# sanitized static libraries. That's OK, because the executable
224# always depends on the ASan runtime library, which defines these
225# symbols.
Evgenii Stepanov912b51f2016-05-19 17:49:51 -0700226ifneq ($(filter address thread,$(strip $(SANITIZE_TARGET))),)
Evgenii Stepanov5adfcb12015-06-25 16:38:25 -0700227 ifndef LOCAL_IS_HOST_MODULE
228 ifeq ($(LOCAL_MODULE_CLASS),SHARED_LIBRARIES)
229 ifeq ($(my_sanitize),)
230 my_allow_undefined_symbols := true
231 endif
232 endif
233 endif
234endif
235
Dan Albertb5b2ffe2015-04-16 18:07:07 -0700236ifneq ($(filter default-ub,$(my_sanitize)),)
237 my_sanitize := $(CLANG_DEFAULT_UB_CHECKS)
Dan Albert08cca282014-12-11 18:56:26 -0800238endif
239
Mitch Phillipsee8f4a02019-05-01 14:37:33 -0700240ifneq ($(filter fuzzer,$(my_sanitize)),)
241 # SANITIZE_TARGET='fuzzer' actually means to create the fuzzer coverage
242 # information, not to link against the fuzzer main().
243 my_sanitize := $(filter-out fuzzer,$(my_sanitize))
244 my_sanitize += fuzzer-no-link
245
246 # TODO(b/131771163): Disable LTO for fuzzer builds. Note that Cfi causes
247 # dependency on LTO.
248 my_sanitize := $(filter-out cfi,$(my_sanitize))
249 my_cflags += -fno-lto
250 my_ldflags += -fno-lto
Mitch Phillipsee2dcac2019-06-17 10:37:55 -0700251
252 # TODO(b/133876586): Disable experimental pass manager for fuzzer builds.
253 my_cflags += -fno-experimental-new-pass-manager
Ivan Krasin74b32b82015-09-18 11:54:43 -0700254endif
255
Ivan Lozano4a363732017-06-28 09:11:26 -0700256ifneq ($(filter integer_overflow,$(my_sanitize)),)
Ivan Lozano702e8bd2018-03-15 14:49:20 -0700257 # Respect LOCAL_NOSANITIZE for integer-overflow flags.
258 ifeq ($(filter signed-integer-overflow, $(strip $(LOCAL_NOSANITIZE))),)
259 my_sanitize += signed-integer-overflow
260 endif
261 ifeq ($(filter unsigned-integer-overflow, $(strip $(LOCAL_NOSANITIZE))),)
262 my_sanitize += unsigned-integer-overflow
263 endif
264 my_cflags += $(INTEGER_OVERFLOW_EXTRA_CFLAGS)
Ivan Lozano4a363732017-06-28 09:11:26 -0700265
Ivan Lozano702e8bd2018-03-15 14:49:20 -0700266 # Check for diagnostics mode.
267 ifneq ($(filter integer_overflow,$(my_sanitize_diag)),)
268 ifneq ($(filter SHARED_LIBRARIES EXECUTABLES,$(LOCAL_MODULE_CLASS)),)
269 ifneq ($(LOCAL_FORCE_STATIC_EXECUTABLE),true)
Ivan Lozano911cb992018-02-21 13:41:05 -0800270 my_sanitize_diag += signed-integer-overflow
271 my_sanitize_diag += unsigned-integer-overflow
Ivan Lozano702e8bd2018-03-15 14:49:20 -0700272 else
273 $(call pretty-error,Make cannot apply integer overflow diagnostics to static binary.)
Ivan Lozano4a363732017-06-28 09:11:26 -0700274 endif
Ivan Lozano702e8bd2018-03-15 14:49:20 -0700275 else
276 $(call pretty-error,Make cannot apply integer overflow diagnostics to static library.)
Ivan Lozano4a363732017-06-28 09:11:26 -0700277 endif
278 endif
279 my_sanitize := $(filter-out integer_overflow,$(my_sanitize))
280endif
281
282# Makes sure integer_overflow diagnostics is removed from the diagnostics list
283# even if integer_overflow is not set for some reason.
284ifneq ($(filter integer_overflow,$(my_sanitize_diag)),)
285 my_sanitize_diag := $(filter-out integer_overflow,$(my_sanitize_diag))
286endif
287
Dan Albert08cca282014-12-11 18:56:26 -0800288ifneq ($(my_sanitize),)
Stephen Hinese8119e92015-11-09 16:32:11 -0800289 fsanitize_arg := $(subst $(space),$(comma),$(my_sanitize))
Dan Albert08cca282014-12-11 18:56:26 -0800290 my_cflags += -fsanitize=$(fsanitize_arg)
Evgenii Stepanov9b82b3f2018-08-31 12:57:26 -0700291 my_asflags += -fsanitize=$(fsanitize_arg)
Dan Albert08cca282014-12-11 18:56:26 -0800292
Mitch Phillipsee8f4a02019-05-01 14:37:33 -0700293 # When fuzzing, we wish to crash with diagnostics on any bug.
294 ifneq ($(filter fuzzer-no-link,$(my_sanitize)),)
295 my_cflags += -fno-sanitize-trap=all
296 my_cflags += -fno-sanitize-recover=all
297 my_ldflags += -fsanitize=fuzzer-no-link
298 else ifdef LOCAL_IS_HOST_MODULE
Dan Albertabf4bc92015-06-16 23:27:34 -0700299 my_cflags += -fno-sanitize-recover=all
Dan Albert08cca282014-12-11 18:56:26 -0800300 my_ldflags += -fsanitize=$(fsanitize_arg)
Dan Albertabf4bc92015-06-16 23:27:34 -0700301 else
Evgenii Stepanov71faa192016-05-19 17:45:21 -0700302 my_cflags += -fsanitize-trap=all
303 my_cflags += -ftrap-function=abort
Evgenii Stepanov55f73e62016-05-12 13:07:36 -0700304 ifneq ($(filter address thread,$(my_sanitize)),)
Evgenii Stepanov71faa192016-05-19 17:45:21 -0700305 my_cflags += -fno-sanitize-trap=address,thread
Evgenii Stepanov55f73e62016-05-12 13:07:36 -0700306 my_shared_libraries += libdl
307 endif
Dan Albert08cca282014-12-11 18:56:26 -0800308 endif
309endif
310
Evgenii Stepanov202c7a72016-07-07 10:56:39 -0700311ifneq ($(filter cfi,$(my_sanitize)),)
Evgenii Stepanov81bea1b2017-01-20 14:12:08 -0800312 # __cfi_check needs to be built as Thumb (see the code in linker_cfi.cpp).
313 # LLVM is not set up to do this on a function basis, so force Thumb on the
314 # entire module.
315 LOCAL_ARM_MODE := thumb
Vishwath Mohan5b69c062017-02-14 07:55:37 -0800316 my_cflags += $(CFI_EXTRA_CFLAGS)
Evgenii Stepanov9b82b3f2018-08-31 12:57:26 -0700317 my_asflags += $(CFI_EXTRA_ASFLAGS)
Vishwath Mohan85f72442017-11-01 09:21:20 +0000318 # Only append the default visibility flag if -fvisibility has not already been
319 # set to hidden.
320 ifeq ($(filter -fvisibility=hidden,$(LOCAL_CFLAGS)),)
321 my_cflags += -fvisibility=default
322 endif
Vishwath Mohan5b69c062017-02-14 07:55:37 -0800323 my_ldflags += $(CFI_EXTRA_LDFLAGS)
Evgenii Stepanove1b96f32017-01-23 16:57:38 -0800324 my_arflags += --plugin $(LLVM_PREBUILTS_PATH)/../lib64/LLVMgold.so
Vishwath Mohan85f72442017-11-01 09:21:20 +0000325
326 ifeq ($(LOCAL_FORCE_STATIC_EXECUTABLE),true)
327 my_ldflags := $(filter-out -fsanitize-cfi-cross-dso,$(my_ldflags))
328 my_cflags := $(filter-out -fsanitize-cfi-cross-dso,$(my_cflags))
329 else
330 # Apply the version script to non-static executables
331 my_ldflags += -Wl,--version-script,build/soong/cc/config/cfi_exports.map
332 LOCAL_ADDITIONAL_DEPENDENCIES += build/soong/cc/config/cfi_exports.map
333 endif
Evgenii Stepanov202c7a72016-07-07 10:56:39 -0700334endif
335
Chih-Hung Hsiehad741e62016-03-09 14:54:55 -0800336# If local or global modules need ASAN, add linker flags.
337ifneq ($(filter address,$(my_global_sanitize) $(my_sanitize)),)
Dan Albert4ae5d4b2014-10-31 16:23:08 -0700338 my_ldflags += $(ADDRESS_SANITIZER_CONFIG_EXTRA_LDFLAGS)
339 ifdef LOCAL_IS_HOST_MODULE
Dan Albert08cca282014-12-11 18:56:26 -0800340 # -nodefaultlibs (provided with libc++) prevents the driver from linking
341 # libraries needed with -fsanitize=address. http://b/18650275 (WAI)
Dan Albert1f0d5302015-04-28 14:55:50 -0700342 my_ldflags += -Wl,--no-as-needed
Dan Albert4ae5d4b2014-10-31 16:23:08 -0700343 else
Chih-Hung Hsiehad741e62016-03-09 14:54:55 -0800344 # Add asan libraries unless LOCAL_MODULE is the asan library.
Evgenii Stepanovf0b15e12015-04-24 16:34:47 -0700345 # ASan runtime library must be the first in the link order.
Chih-Hung Hsiehad741e62016-03-09 14:54:55 -0800346 ifeq (,$(filter $(LOCAL_MODULE),$($(LOCAL_2ND_ARCH_VAR_PREFIX)ADDRESS_SANITIZER_RUNTIME_LIBRARY)))
347 my_shared_libraries := $($(LOCAL_2ND_ARCH_VAR_PREFIX)ADDRESS_SANITIZER_RUNTIME_LIBRARY) \
348 $(my_shared_libraries)
349 endif
Chih-Hung Hsiehad741e62016-03-09 14:54:55 -0800350
351 # Do not add unnecessary dependency in shared libraries.
352 ifeq ($(LOCAL_MODULE_CLASS),SHARED_LIBRARIES)
353 my_ldflags += -Wl,--as-needed
354 endif
Ying Wanga05e2222015-08-17 16:13:24 -0700355
Mikhail Naganovaa73cef2018-12-20 15:55:08 -0800356 ifneq ($(filter EXECUTABLES NATIVE_TESTS,$(LOCAL_MODULE_CLASS)),)
Colin Crossd08699e2016-07-17 15:28:07 -0700357 ifneq ($(LOCAL_FORCE_STATIC_EXECUTABLE),true)
358 my_linker := $($(LOCAL_2ND_ARCH_VAR_PREFIX)ADDRESS_SANITIZER_LINKER)
359 # Make sure linker_asan get installed.
Logan Chienc6d2cf82019-01-31 17:07:50 +0800360 $(LOCAL_INSTALLED_MODULE) : | $(PRODUCT_OUT)$($(LOCAL_2ND_ARCH_VAR_PREFIX)ADDRESS_SANITIZER_LINKER_FILE)
Colin Crossd08699e2016-07-17 15:28:07 -0700361 endif
362 endif
Dan Albert08cca282014-12-11 18:56:26 -0800363 endif
364endif
365
Chih-Hung Hsiehad741e62016-03-09 14:54:55 -0800366# If local module needs ASAN, add compiler flags.
367ifneq ($(filter address,$(my_sanitize)),)
368 # Frame pointer based unwinder in ASan requires ARM frame setup.
369 LOCAL_ARM_MODE := arm
370 my_cflags += $(ADDRESS_SANITIZER_CONFIG_EXTRA_CFLAGS)
371 ifndef LOCAL_IS_HOST_MODULE
372 my_cflags += -mllvm -asan-globals=0
373 endif
374endif
375
Evgenii Stepanovaec1ffc2018-08-28 13:52:08 -0700376# If local module needs HWASAN, add compiler flags.
377ifneq ($(filter hwaddress,$(my_sanitize)),)
378 my_cflags += $(HWADDRESS_SANITIZER_CONFIG_EXTRA_CFLAGS)
379endif
380
Alexey Polyudove98e5622018-03-27 15:28:12 -0700381# Use minimal diagnostics when integer overflow is enabled; never do it for HOST or AUX modules
382ifeq ($(LOCAL_IS_HOST_MODULE)$(LOCAL_IS_AUX_MODULE),)
Ivan Lozano911cb992018-02-21 13:41:05 -0800383 # Pre-emptively add UBSAN minimal runtime incase a static library dependency requires it
384 ifeq ($(filter STATIC_LIBRARIES,$(LOCAL_MODULE_CLASS)),)
385 ifndef LOCAL_SDK_VERSION
386 my_static_libraries += $($(LOCAL_2ND_ARCH_VAR_PREFIX)UBSAN_MINIMAL_RUNTIME_LIBRARY)
Ivan Lozanoe5081692018-05-11 14:09:36 -0700387 my_ldflags += -Wl,--exclude-libs,$($(LOCAL_2ND_ARCH_VAR_PREFIX)UBSAN_MINIMAL_RUNTIME_LIBRARY).a
Ivan Lozano911cb992018-02-21 13:41:05 -0800388 endif
389 endif
390 ifneq ($(filter unsigned-integer-overflow signed-integer-overflow integer,$(my_sanitize)),)
Kostya Kortchinsky47c10eb2018-10-11 08:56:12 -0700391 ifeq ($(filter unsigned-integer-overflow signed-integer-overflow integer,$(my_sanitize_diag)),)
Ivan Lozano911cb992018-02-21 13:41:05 -0800392 ifeq ($(filter cfi,$(my_sanitize_diag)),)
Mitch Phillipsee8f4a02019-05-01 14:37:33 -0700393 ifeq ($(filter address hwaddress fuzzer-no-link,$(my_sanitize)),)
Ivan Lozano911cb992018-02-21 13:41:05 -0800394 my_cflags += -fsanitize-minimal-runtime
395 my_cflags += -fno-sanitize-trap=integer
396 my_cflags += -fno-sanitize-recover=integer
397 endif
398 endif
399 endif
400 endif
401endif
402
Kostya Kortchinsky47c10eb2018-10-11 08:56:12 -0700403# For Scudo, we opt for the minimal runtime, unless some diagnostics are enabled.
404ifneq ($(filter scudo,$(my_sanitize)),)
405 ifeq ($(filter unsigned-integer-overflow signed-integer-overflow integer cfi,$(my_sanitize_diag)),)
406 my_cflags += -fsanitize-minimal-runtime
407 endif
408 ifneq ($(filter -fsanitize-minimal-runtime,$(my_cflags)),)
409 my_shared_libraries += $($(LOCAL_2ND_ARCH_VAR_PREFIX)SCUDO_MINIMAL_RUNTIME_LIBRARY)
410 else
411 my_shared_libraries += $($(LOCAL_2ND_ARCH_VAR_PREFIX)SCUDO_RUNTIME_LIBRARY)
412 endif
413endif
414
Dan Albert9f176552015-04-28 11:26:45 -0700415ifneq ($(strip $(LOCAL_SANITIZE_RECOVER)),)
416 recover_arg := $(subst $(space),$(comma),$(LOCAL_SANITIZE_RECOVER)),
Dan Albert4111d482015-04-16 18:08:44 -0700417 my_cflags += -fsanitize-recover=$(recover_arg)
418endif
Evgenii Stepanov202c7a72016-07-07 10:56:39 -0700419
Ivan Lozano5fb2de72018-12-12 10:04:34 -0800420ifneq ($(strip $(LOCAL_SANITIZE_NO_RECOVER)),)
421 no_recover_arg := $(subst $(space),$(comma),$(LOCAL_SANITIZE_NO_RECOVER)),
422 my_cflags += -fno-sanitize-recover=$(no_recover_arg)
423endif
424
Vishwath Mohan8dcfdce2017-01-18 17:50:29 -0800425ifneq ($(my_sanitize_diag),)
Vishwath Mohan85f72442017-11-01 09:21:20 +0000426 # TODO(vishwath): Add diagnostic support for static executables once
427 # we switch to clang-4393122 (which adds the static ubsan runtime
428 # that this depends on)
429 ifneq ($(LOCAL_FORCE_STATIC_EXECUTABLE),true)
430 notrap_arg := $(subst $(space),$(comma),$(my_sanitize_diag)),
431 my_cflags += -fno-sanitize-trap=$(notrap_arg)
432 # Diagnostic requires a runtime library, unless ASan or TSan are also enabled.
Evgenii Stepanov8841a7f2018-07-27 11:54:32 -0700433 ifeq ($(filter address thread scudo hwaddress,$(my_sanitize)),)
Vishwath Mohan85f72442017-11-01 09:21:20 +0000434 # Does not have to be the first DT_NEEDED unlike ASan.
435 my_shared_libraries += $($(LOCAL_2ND_ARCH_VAR_PREFIX)UBSAN_RUNTIME_LIBRARY)
436 endif
Evgenii Stepanov202c7a72016-07-07 10:56:39 -0700437 endif
438endif
Chih-Hung Hsieh18710622018-11-17 20:18:08 -0800439
440# http://b/119329758, Android core does not boot up with this sanitizer yet.
441# Previously sanitized modules might not pass new implicit-integer-sign-change check.
442# Disable this check unless it has been explicitly specified.
443ifneq ($(findstring fsanitize,$(my_cflags)),)
444 ifneq ($(findstring integer,$(my_cflags)),)
445 ifeq ($(findstring sanitize=implicit-integer-sign-change,$(my_cflags)),)
446 my_cflags += -fno-sanitize=implicit-integer-sign-change
447 endif
448 endif
449endif