blob: d837c6ebb487270733349a8b58f913d4787343ab [file] [log] [blame]
Dan Albert4ae5d4b2014-10-31 16:23:08 -07001##############################################
2## Perform configuration steps for sanitizers.
3##############################################
4
Dan Albert27ccb752015-04-16 16:21:02 -07005my_sanitize := $(strip $(LOCAL_SANITIZE))
Vishwath Mohan8dcfdce2017-01-18 17:50:29 -08006my_sanitize_diag := $(strip $(LOCAL_SANITIZE_DIAG))
Dan Albert08cca282014-12-11 18:56:26 -08007
Dan Albert4c401412015-08-19 20:13:33 -07008my_global_sanitize :=
Ivan Lozano4a363732017-06-28 09:11:26 -07009my_global_sanitize_diag :=
Dan Willemsenf0638392018-09-04 22:25:22 -070010ifdef LOCAL_IS_HOST_MODULE
11 ifneq ($($(my_prefix)OS),windows)
12 my_global_sanitize := $(strip $(SANITIZE_HOST))
Dan Albert4c401412015-08-19 20:13:33 -070013
Dan Willemsenf0638392018-09-04 22:25:22 -070014 # SANITIZE_HOST=true is a deprecated way to say SANITIZE_HOST=address.
15 my_global_sanitize := $(subst true,address,$(my_global_sanitize))
Dan Albert4c401412015-08-19 20:13:33 -070016 endif
Dan Willemsenf0638392018-09-04 22:25:22 -070017else
18 my_global_sanitize := $(strip $(SANITIZE_TARGET))
19 my_global_sanitize_diag := $(strip $(SANITIZE_TARGET_DIAG))
Dan Albert4c401412015-08-19 20:13:33 -070020endif
21
Ivan Lozanob4749cb2017-07-21 10:33:32 -070022# Disable global integer_overflow in excluded paths.
23ifneq ($(filter integer_overflow, $(my_global_sanitize)),)
24 combined_exclude_paths := $(INTEGER_OVERFLOW_EXCLUDE_PATHS) \
25 $(PRODUCT_INTEGER_OVERFLOW_EXCLUDE_PATHS)
26
27 ifneq ($(strip $(foreach dir,$(subst $(comma),$(space),$(combined_exclude_paths)),\
28 $(filter $(dir)%,$(LOCAL_PATH)))),)
29 my_global_sanitize := $(filter-out integer_overflow,$(my_global_sanitize))
30 my_global_sanitize_diag := $(filter-out integer_overflow,$(my_global_sanitize_diag))
31 endif
32endif
33
Ivan Lozano702e8bd2018-03-15 14:49:20 -070034# Global integer sanitization doesn't support static modules.
35ifeq ($(filter SHARED_LIBRARIES EXECUTABLES,$(LOCAL_MODULE_CLASS)),)
36 my_global_sanitize := $(filter-out integer_overflow,$(my_global_sanitize))
37 my_global_sanitize_diag := $(filter-out integer_overflow,$(my_global_sanitize_diag))
38endif
39ifeq ($(LOCAL_FORCE_STATIC_EXECUTABLE),true)
40 my_global_sanitize := $(filter-out integer_overflow,$(my_global_sanitize))
41 my_global_sanitize_diag := $(filter-out integer_overflow,$(my_global_sanitize_diag))
42endif
43
Vishwath Mohan23b2d2e2017-10-31 02:25:16 -070044# Disable global CFI in excluded paths
45ifneq ($(filter cfi, $(my_global_sanitize)),)
46 combined_exclude_paths := $(CFI_EXCLUDE_PATHS) \
47 $(PRODUCT_CFI_EXCLUDE_PATHS)
48
49 ifneq ($(strip $(foreach dir,$(subst $(comma),$(space),$(combined_exclude_paths)),\
50 $(filter $(dir)%,$(LOCAL_PATH)))),)
51 my_global_sanitize := $(filter-out cfi,$(my_global_sanitize))
52 my_global_sanitize_diag := $(filter-out cfi,$(my_global_sanitize_diag))
53 endif
54endif
55
Evgenii Stepanov3330b2f2021-01-13 12:14:55 -080056# Disable global memtag_heap in excluded paths
57ifneq ($(filter memtag_heap, $(my_global_sanitize)),)
58 combined_exclude_paths := $(MEMTAG_HEAP_EXCLUDE_PATHS) \
59 $(PRODUCT_MEMTAG_HEAP_EXCLUDE_PATHS)
60
61 ifneq ($(strip $(foreach dir,$(subst $(comma),$(space),$(combined_exclude_paths)),\
62 $(filter $(dir)%,$(LOCAL_PATH)))),)
63 my_global_sanitize := $(filter-out memtag_heap,$(my_global_sanitize))
64 my_global_sanitize_diag := $(filter-out memtag_heap,$(my_global_sanitize_diag))
65 endif
66endif
67
Dan Albert4c401412015-08-19 20:13:33 -070068ifneq ($(my_global_sanitize),)
Evgenii Stepanov71faa192016-05-19 17:45:21 -070069 my_sanitize := $(my_global_sanitize) $(my_sanitize)
Dan Albert4c401412015-08-19 20:13:33 -070070endif
Ivan Lozano4a363732017-06-28 09:11:26 -070071ifneq ($(my_global_sanitize_diag),)
72 my_sanitize_diag := $(my_global_sanitize_diag) $(my_sanitize_diag)
73endif
Dan Albert4c401412015-08-19 20:13:33 -070074
Andreas Gampe6b30d772016-06-27 15:15:31 -070075# The sanitizer specified in the product configuration wins over the previous.
76ifneq ($(SANITIZER.$(TARGET_PRODUCT).$(LOCAL_MODULE).CONFIG),)
77 my_sanitize := $(SANITIZER.$(TARGET_PRODUCT).$(LOCAL_MODULE).CONFIG)
78 ifeq ($(my_sanitize),never)
79 my_sanitize :=
Ivan Lozano4a363732017-06-28 09:11:26 -070080 my_sanitize_diag :=
Andreas Gampe6b30d772016-06-27 15:15:31 -070081 endif
82endif
83
Colin Cross23618422016-11-02 15:05:21 -070084ifndef LOCAL_IS_HOST_MODULE
85 # Add a filter point for 32-bit vs 64-bit sanitization (to lighten the burden)
86 SANITIZE_TARGET_ARCH ?= $(TARGET_ARCH) $(TARGET_2ND_ARCH)
87 ifeq ($(filter $(SANITIZE_TARGET_ARCH),$(TARGET_$(LOCAL_2ND_ARCH_VAR_PREFIX)ARCH)),)
88 my_sanitize :=
Ivan Lozano4a363732017-06-28 09:11:26 -070089 my_sanitize_diag :=
Colin Cross23618422016-11-02 15:05:21 -070090 endif
Andreas Gampecd257402016-06-20 17:36:49 -070091endif
92
Andreas Gampe3d3b0c92016-06-20 17:46:29 -070093# Add a filter point based on module owner (to lighten the burden). The format is a space- or
94# colon-separated list of owner names.
95ifneq (,$(SANITIZE_NEVER_BY_OWNER))
96 ifneq (,$(LOCAL_MODULE_OWNER))
97 ifneq (,$(filter $(LOCAL_MODULE_OWNER),$(subst :, ,$(SANITIZE_NEVER_BY_OWNER))))
98 $(warning Not sanitizing $(LOCAL_MODULE) based on module owner.)
99 my_sanitize :=
Ivan Lozano4a363732017-06-28 09:11:26 -0700100 my_sanitize_diag :=
Andreas Gampe3d3b0c92016-06-20 17:46:29 -0700101 endif
102 endif
103endif
104
Dan Albert08cca282014-12-11 18:56:26 -0800105# Don't apply sanitizers to NDK code.
106ifdef LOCAL_SDK_VERSION
Dan Albert4c401412015-08-19 20:13:33 -0700107 my_sanitize :=
Dan Willemsenf761c0f2016-06-28 16:47:43 -0700108 my_global_sanitize :=
Ivan Lozano4a363732017-06-28 09:11:26 -0700109 my_sanitize_diag :=
Dan Albert27ccb752015-04-16 16:21:02 -0700110endif
111
Dan Albert4c401412015-08-19 20:13:33 -0700112# Never always wins.
113ifeq ($(LOCAL_SANITIZE),never)
Dan Albert08cca282014-12-11 18:56:26 -0800114 my_sanitize :=
Ivan Lozano4a363732017-06-28 09:11:26 -0700115 my_sanitize_diag :=
Dan Albert08cca282014-12-11 18:56:26 -0800116endif
117
Elvis Chien064d91c2021-04-14 17:02:29 +0800118# Enable CFI in included paths.
Vishwath Mohan23b2d2e2017-10-31 02:25:16 -0700119ifeq ($(filter cfi, $(my_sanitize)),)
Elvis Chien064d91c2021-04-14 17:02:29 +0800120 combined_include_paths := $(CFI_INCLUDE_PATHS) \
121 $(PRODUCT_CFI_INCLUDE_PATHS)
122 combined_exclude_paths := $(CFI_EXCLUDE_PATHS) \
123 $(PRODUCT_CFI_EXCLUDE_PATHS)
Vishwath Mohan23b2d2e2017-10-31 02:25:16 -0700124
Elvis Chien064d91c2021-04-14 17:02:29 +0800125 ifneq ($(strip $(foreach dir,$(subst $(comma),$(space),$(combined_include_paths)),\
126 $(filter $(dir)%,$(LOCAL_PATH)))),)
127 ifeq ($(strip $(foreach dir,$(subst $(comma),$(space),$(combined_exclude_paths)),\
128 $(filter $(dir)%,$(LOCAL_PATH)))),)
129 my_sanitize := cfi $(my_sanitize)
Vishwath Mohan6106a4e2018-05-24 18:04:25 -0700130 endif
Vishwath Mohan23b2d2e2017-10-31 02:25:16 -0700131 endif
132endif
133
Evgenii Stepanov3330b2f2021-01-13 12:14:55 -0800134# Enable memtag_heap in included paths (for Arm64 only).
135ifeq ($(filter memtag_heap, $(my_sanitize)),)
136 ifneq ($(filter arm64,$(TARGET_$(LOCAL_2ND_ARCH_VAR_PREFIX)ARCH)),)
137 combined_sync_include_paths := $(MEMTAG_HEAP_SYNC_INCLUDE_PATHS) \
138 $(PRODUCT_MEMTAG_HEAP_SYNC_INCLUDE_PATHS)
139 combined_async_include_paths := $(MEMTAG_HEAP_ASYNC_INCLUDE_PATHS) \
140 $(PRODUCT_MEMTAG_HEAP_ASYNC_INCLUDE_PATHS)
Evgenii Stepanov13bc2272021-04-09 14:52:33 -0700141 combined_exclude_paths := $(MEMTAG_HEAP_EXCLUDE_PATHS) \
142 $(PRODUCT_MEMTAG_HEAP_EXCLUDE_PATHS)
Evgenii Stepanov3330b2f2021-01-13 12:14:55 -0800143
Evgenii Stepanov13bc2272021-04-09 14:52:33 -0700144 ifeq ($(strip $(foreach dir,$(subst $(comma),$(space),$(combined_exclude_paths)),\
145 $(filter $(dir)%,$(LOCAL_PATH)))),)
146 ifneq ($(strip $(foreach dir,$(subst $(comma),$(space),$(combined_sync_include_paths)),\
147 $(filter $(dir)%,$(LOCAL_PATH)))),)
148 my_sanitize := memtag_heap $(my_sanitize)
149 my_sanitize_diag := memtag_heap $(my_sanitize_diag)
150 else ifneq ($(strip $(foreach dir,$(subst $(comma),$(space),$(combined_async_include_paths)),\
151 $(filter $(dir)%,$(LOCAL_PATH)))),)
152 my_sanitize := memtag_heap $(my_sanitize)
153 endif
Evgenii Stepanov3330b2f2021-01-13 12:14:55 -0800154 endif
155 endif
156endif
157
Hang Lue235ded2022-08-29 14:42:34 +0800158# Enable HWASan in included paths.
159ifeq ($(filter hwaddress, $(my_sanitize)),)
160 combined_include_paths := $(HWASAN_INCLUDE_PATHS) \
161 $(PRODUCT_HWASAN_INCLUDE_PATHS)
162
163 ifneq ($(strip $(foreach dir,$(subst $(comma),$(space),$(combined_include_paths)),\
164 $(filter $(dir)%,$(LOCAL_PATH)))),)
165 my_sanitize := hwaddress $(my_sanitize)
166 endif
167endif
168
Vishwath Mohan8dcfdce2017-01-18 17:50:29 -0800169# If CFI is disabled globally, remove it from my_sanitize.
Vishwath Mohan45665b42017-01-24 13:20:28 -0800170ifeq ($(strip $(ENABLE_CFI)),false)
Vishwath Mohan8dcfdce2017-01-18 17:50:29 -0800171 my_sanitize := $(filter-out cfi,$(my_sanitize))
172 my_sanitize_diag := $(filter-out cfi,$(my_sanitize_diag))
173endif
174
Florian Mayer548a2ad2022-08-31 22:25:55 +0000175# Also disable CFI and MTE if ASAN is enabled.
Vishwath Mohanc026f6d2017-04-20 07:39:13 -0700176ifneq ($(filter address,$(my_sanitize)),)
177 my_sanitize := $(filter-out cfi,$(my_sanitize))
Florian Mayer548a2ad2022-08-31 22:25:55 +0000178 my_sanitize := $(filter-out memtag_stack,$(my_sanitize))
179 my_sanitize := $(filter-out memtag_heap,$(my_sanitize))
Vishwath Mohanc026f6d2017-04-20 07:39:13 -0700180 my_sanitize_diag := $(filter-out cfi,$(my_sanitize_diag))
181endif
182
Mitch Phillipsb71a8752021-05-19 11:29:02 -0700183# Disable memtag for host targets. Host executables in AndroidMk files are
184# deprecated, but some partners still have them floating around.
185ifdef LOCAL_IS_HOST_MODULE
Florian Mayer548a2ad2022-08-31 22:25:55 +0000186 my_sanitize := $(filter-out memtag_heap memtag_stack,$(my_sanitize))
187 my_sanitize_diag := $(filter-out memtag_heap memtag_stack,$(my_sanitize_diag))
Mitch Phillipsb71a8752021-05-19 11:29:02 -0700188endif
189
Ivan Lozano702e8bd2018-03-15 14:49:20 -0700190# Disable sanitizers which need the UBSan runtime for host targets.
Vishwath Mohan96a130b2017-11-17 11:19:36 -0800191ifdef LOCAL_IS_HOST_MODULE
192 my_sanitize := $(filter-out cfi,$(my_sanitize))
193 my_sanitize_diag := $(filter-out cfi,$(my_sanitize_diag))
Ivan Lozano702e8bd2018-03-15 14:49:20 -0700194 my_sanitize := $(filter-out signed-integer-overflow unsigned-integer-overflow integer_overflow,$(my_sanitize))
195 my_sanitize_diag := $(filter-out signed-integer-overflow unsigned-integer-overflow integer_overflow,$(my_sanitize_diag))
Vishwath Mohan96a130b2017-11-17 11:19:36 -0800196endif
197
Ivan Lozano4a363732017-06-28 09:11:26 -0700198# Support for local sanitize blacklist paths.
199ifneq ($(my_sanitize)$(my_global_sanitize),)
Pirama Arumuga Nainar56558332020-07-30 15:18:07 -0700200 ifneq ($(LOCAL_SANITIZE_BLOCKLIST),)
201 my_cflags += -fsanitize-blacklist=$(LOCAL_PATH)/$(LOCAL_SANITIZE_BLOCKLIST)
202 endif
Ivan Lozano4a363732017-06-28 09:11:26 -0700203endif
204
Ivan Lozanob4749cb2017-07-21 10:33:32 -0700205# Disable integer_overflow if LOCAL_NOSANITIZE=integer.
Ivan Lozano4a363732017-06-28 09:11:26 -0700206ifneq ($(filter integer_overflow, $(my_global_sanitize) $(my_sanitize)),)
207 ifneq ($(filter integer, $(strip $(LOCAL_NOSANITIZE))),)
208 my_sanitize := $(filter-out integer_overflow,$(my_sanitize))
209 my_sanitize_diag := $(filter-out integer_overflow,$(my_sanitize_diag))
210 endif
211endif
212
Evgenii Stepanov42823662016-05-12 13:07:17 -0700213my_nosanitize = $(strip $(LOCAL_NOSANITIZE))
214ifneq ($(my_nosanitize),)
215 my_sanitize := $(filter-out $(my_nosanitize),$(my_sanitize))
216endif
217
Evgenii Stepanov8841a7f2018-07-27 11:54:32 -0700218ifneq ($(filter arm x86 x86_64,$(TARGET_$(LOCAL_2ND_ARCH_VAR_PREFIX)ARCH)),)
219 my_sanitize := $(filter-out hwaddress,$(my_sanitize))
Evgenii Stepanov3330b2f2021-01-13 12:14:55 -0800220 my_sanitize := $(filter-out memtag_heap,$(my_sanitize))
Florian Mayer548a2ad2022-08-31 22:25:55 +0000221 my_sanitize := $(filter-out memtag_stack,$(my_sanitize))
Evgenii Stepanov8841a7f2018-07-27 11:54:32 -0700222endif
223
224ifneq ($(filter hwaddress,$(my_sanitize)),)
225 my_sanitize := $(filter-out address,$(my_sanitize))
Florian Mayer548a2ad2022-08-31 22:25:55 +0000226 my_sanitize := $(filter-out memtag_stack,$(my_sanitize))
227 my_sanitize := $(filter-out memtag_heap,$(my_sanitize))
Evgenii Stepanov8841a7f2018-07-27 11:54:32 -0700228 my_sanitize := $(filter-out thread,$(my_sanitize))
Evgenii Stepanov88a95a32018-12-04 17:06:45 -0800229 my_sanitize := $(filter-out cfi,$(my_sanitize))
Evgenii Stepanov8841a7f2018-07-27 11:54:32 -0700230endif
231
232ifneq ($(filter hwaddress,$(my_sanitize)),)
233 my_shared_libraries += $($(LOCAL_2ND_ARCH_VAR_PREFIX)HWADDRESS_SANITIZER_RUNTIME_LIBRARY)
Evgenii Stepanoved907462018-11-01 15:43:14 -0700234 ifneq ($(filter EXECUTABLES NATIVE_TESTS,$(LOCAL_MODULE_CLASS)),)
Evgenii Stepanov8841a7f2018-07-27 11:54:32 -0700235 ifeq ($(LOCAL_FORCE_STATIC_EXECUTABLE),true)
Ryan Prichardacf8b0f2019-10-21 20:47:53 -0700236 my_static_libraries := $(my_static_libraries) \
237 $($(LOCAL_2ND_ARCH_VAR_PREFIX)HWADDRESS_SANITIZER_STATIC_LIBRARY) \
238 libdl
Evgenii Stepanov8841a7f2018-07-27 11:54:32 -0700239 endif
240 endif
241endif
242
Florian Mayer548a2ad2022-08-31 22:25:55 +0000243ifneq ($(filter memtag_heap memtag_stack,$(my_sanitize)),)
244 ifneq ($(filter memtag_heap,$(my_sanitize_diag)),)
245 my_cflags += -fsanitize-memtag-mode=sync
246 my_sanitize_diag := $(filter-out memtag_heap,$(my_sanitize_diag))
247 else
248 my_cflags += -fsanitize-memtag-mode=async
Florian Mayerfe3e5372022-08-31 18:37:51 +0000249 endif
Florian Mayer548a2ad2022-08-31 22:25:55 +0000250endif
251
Florian Mayer2a676262023-06-07 15:02:22 -0700252# Ignore SANITIZE_TARGET_DIAG=memtag_heap without SANITIZE_TARGET=memtag_heap
253# This can happen if a condition above filters out memtag_heap from
254# my_sanitize. It is easier to handle all of these cases here centrally.
255ifneq ($(filter memtag_heap,$(my_sanitize_diag)),)
256 my_sanitize_diag := $(filter-out memtag_heap,$(my_sanitize_diag))
257endif
258
Florian Mayer548a2ad2022-08-31 22:25:55 +0000259ifneq ($(filter memtag_heap,$(my_sanitize)),)
260 my_cflags += -fsanitize=memtag-heap
Evgenii Stepanov3330b2f2021-01-13 12:14:55 -0800261 my_sanitize := $(filter-out memtag_heap,$(my_sanitize))
262endif
263
Florian Mayer548a2ad2022-08-31 22:25:55 +0000264ifneq ($(filter memtag_stack,$(my_sanitize)),)
265 my_cflags += -fsanitize=memtag-stack
266 my_cflags += -march=armv8a+memtag
267 my_ldflags += -march=armv8a+memtag
268 my_asflags += -march=armv8a+memtag
269 my_sanitize := $(filter-out memtag_stack,$(my_sanitize))
270endif
Evgenii Stepanov3330b2f2021-01-13 12:14:55 -0800271
Dan Alberta6311b72015-07-30 10:17:33 -0700272# TSAN is not supported on 32-bit architectures. For non-multilib cases, make
273# its use an error. For multilib cases, don't use it for the 32-bit case.
274ifneq ($(filter thread,$(my_sanitize)),)
275 ifeq ($(my_32_64_bit_suffix),32)
276 ifeq ($(my_module_multilib),both)
277 my_sanitize := $(filter-out thread,$(my_sanitize))
278 else
279 $(error $(LOCAL_PATH): $(LOCAL_MODULE): TSAN cannot be used for 32-bit modules.)
280 endif
Yabin Cuie77c32e2017-10-19 14:33:58 -0700281 else
282 my_shared_libraries += $(TSAN_RUNTIME_LIBRARY)
Dan Alberta6311b72015-07-30 10:17:33 -0700283 endif
284endif
285
Evgenii Stepanov7dcb8b82016-05-06 18:15:57 -0700286ifneq ($(filter safe-stack,$(my_sanitize)),)
287 ifeq ($(my_32_64_bit_suffix),32)
288 my_sanitize := $(filter-out safe-stack,$(my_sanitize))
289 endif
290endif
291
Kostya Kortchinsky2cfa9972018-06-14 11:02:15 -0700292# Disable Scudo if ASan or TSan is enabled.
Evgenii Stepanov8841a7f2018-07-27 11:54:32 -0700293ifneq ($(filter address thread hwaddress,$(my_sanitize)),)
Kostya Kortchinsky2cfa9972018-06-14 11:02:15 -0700294 my_sanitize := $(filter-out scudo,$(my_sanitize))
295endif
296
Kostya Kortchinsky02732402019-02-01 09:06:42 -0800297# Or if disabled globally.
Anton Hansson8dab0a62019-03-28 15:45:40 +0000298ifeq ($(PRODUCT_DISABLE_SCUDO),true)
Kostya Kortchinsky02732402019-02-01 09:06:42 -0800299 my_sanitize := $(filter-out scudo,$(my_sanitize))
300endif
301
Evgenii Stepanov5adfcb12015-06-25 16:38:25 -0700302# Undefined symbols can occur if a non-sanitized library links
303# sanitized static libraries. That's OK, because the executable
304# always depends on the ASan runtime library, which defines these
305# symbols.
Evgenii Stepanov912b51f2016-05-19 17:49:51 -0700306ifneq ($(filter address thread,$(strip $(SANITIZE_TARGET))),)
Evgenii Stepanov5adfcb12015-06-25 16:38:25 -0700307 ifndef LOCAL_IS_HOST_MODULE
308 ifeq ($(LOCAL_MODULE_CLASS),SHARED_LIBRARIES)
309 ifeq ($(my_sanitize),)
310 my_allow_undefined_symbols := true
311 endif
312 endif
313 endif
314endif
315
Dan Albertb5b2ffe2015-04-16 18:07:07 -0700316ifneq ($(filter default-ub,$(my_sanitize)),)
317 my_sanitize := $(CLANG_DEFAULT_UB_CHECKS)
Dan Albert08cca282014-12-11 18:56:26 -0800318endif
319
Mitch Phillipsee8f4a02019-05-01 14:37:33 -0700320ifneq ($(filter fuzzer,$(my_sanitize)),)
321 # SANITIZE_TARGET='fuzzer' actually means to create the fuzzer coverage
322 # information, not to link against the fuzzer main().
323 my_sanitize := $(filter-out fuzzer,$(my_sanitize))
324 my_sanitize += fuzzer-no-link
Mitch Phillipsd51048a2022-03-02 01:25:22 +0000325
326 # TODO(b/131771163): Disable LTO for fuzzer builds. Note that Cfi causes
327 # dependency on LTO.
328 my_sanitize := $(filter-out cfi,$(my_sanitize))
329 my_cflags += -fno-lto
330 my_ldflags += -fno-lto
Ivan Krasin74b32b82015-09-18 11:54:43 -0700331endif
332
Ivan Lozano4a363732017-06-28 09:11:26 -0700333ifneq ($(filter integer_overflow,$(my_sanitize)),)
Ivan Lozano702e8bd2018-03-15 14:49:20 -0700334 # Respect LOCAL_NOSANITIZE for integer-overflow flags.
335 ifeq ($(filter signed-integer-overflow, $(strip $(LOCAL_NOSANITIZE))),)
336 my_sanitize += signed-integer-overflow
337 endif
338 ifeq ($(filter unsigned-integer-overflow, $(strip $(LOCAL_NOSANITIZE))),)
339 my_sanitize += unsigned-integer-overflow
340 endif
341 my_cflags += $(INTEGER_OVERFLOW_EXTRA_CFLAGS)
Ivan Lozano4a363732017-06-28 09:11:26 -0700342
Ivan Lozano702e8bd2018-03-15 14:49:20 -0700343 # Check for diagnostics mode.
344 ifneq ($(filter integer_overflow,$(my_sanitize_diag)),)
345 ifneq ($(filter SHARED_LIBRARIES EXECUTABLES,$(LOCAL_MODULE_CLASS)),)
346 ifneq ($(LOCAL_FORCE_STATIC_EXECUTABLE),true)
Ivan Lozano911cb992018-02-21 13:41:05 -0800347 my_sanitize_diag += signed-integer-overflow
348 my_sanitize_diag += unsigned-integer-overflow
Ivan Lozano702e8bd2018-03-15 14:49:20 -0700349 else
350 $(call pretty-error,Make cannot apply integer overflow diagnostics to static binary.)
Ivan Lozano4a363732017-06-28 09:11:26 -0700351 endif
Ivan Lozano702e8bd2018-03-15 14:49:20 -0700352 else
353 $(call pretty-error,Make cannot apply integer overflow diagnostics to static library.)
Ivan Lozano4a363732017-06-28 09:11:26 -0700354 endif
355 endif
356 my_sanitize := $(filter-out integer_overflow,$(my_sanitize))
357endif
358
359# Makes sure integer_overflow diagnostics is removed from the diagnostics list
360# even if integer_overflow is not set for some reason.
361ifneq ($(filter integer_overflow,$(my_sanitize_diag)),)
362 my_sanitize_diag := $(filter-out integer_overflow,$(my_sanitize_diag))
363endif
364
Dan Albert08cca282014-12-11 18:56:26 -0800365ifneq ($(my_sanitize),)
Stephen Hinese8119e92015-11-09 16:32:11 -0800366 fsanitize_arg := $(subst $(space),$(comma),$(my_sanitize))
Dan Albert08cca282014-12-11 18:56:26 -0800367 my_cflags += -fsanitize=$(fsanitize_arg)
Evgenii Stepanov9b82b3f2018-08-31 12:57:26 -0700368 my_asflags += -fsanitize=$(fsanitize_arg)
Dan Albert08cca282014-12-11 18:56:26 -0800369
Mitch Phillipsee8f4a02019-05-01 14:37:33 -0700370 # When fuzzing, we wish to crash with diagnostics on any bug.
371 ifneq ($(filter fuzzer-no-link,$(my_sanitize)),)
372 my_cflags += -fno-sanitize-trap=all
373 my_cflags += -fno-sanitize-recover=all
374 my_ldflags += -fsanitize=fuzzer-no-link
375 else ifdef LOCAL_IS_HOST_MODULE
Dan Albertabf4bc92015-06-16 23:27:34 -0700376 my_cflags += -fno-sanitize-recover=all
Dan Albert08cca282014-12-11 18:56:26 -0800377 my_ldflags += -fsanitize=$(fsanitize_arg)
Dan Albertabf4bc92015-06-16 23:27:34 -0700378 else
Evgenii Stepanov71faa192016-05-19 17:45:21 -0700379 my_cflags += -fsanitize-trap=all
380 my_cflags += -ftrap-function=abort
Evgenii Stepanov55f73e62016-05-12 13:07:36 -0700381 ifneq ($(filter address thread,$(my_sanitize)),)
Evgenii Stepanov71faa192016-05-19 17:45:21 -0700382 my_cflags += -fno-sanitize-trap=address,thread
Evgenii Stepanov55f73e62016-05-12 13:07:36 -0700383 my_shared_libraries += libdl
384 endif
Dan Albert08cca282014-12-11 18:56:26 -0800385 endif
386endif
387
Evgenii Stepanov202c7a72016-07-07 10:56:39 -0700388ifneq ($(filter cfi,$(my_sanitize)),)
Evgenii Stepanov81bea1b2017-01-20 14:12:08 -0800389 # __cfi_check needs to be built as Thumb (see the code in linker_cfi.cpp).
390 # LLVM is not set up to do this on a function basis, so force Thumb on the
391 # entire module.
392 LOCAL_ARM_MODE := thumb
Vishwath Mohan5b69c062017-02-14 07:55:37 -0800393 my_cflags += $(CFI_EXTRA_CFLAGS)
Evgenii Stepanov9b82b3f2018-08-31 12:57:26 -0700394 my_asflags += $(CFI_EXTRA_ASFLAGS)
Vishwath Mohan85f72442017-11-01 09:21:20 +0000395 # Only append the default visibility flag if -fvisibility has not already been
396 # set to hidden.
397 ifeq ($(filter -fvisibility=hidden,$(LOCAL_CFLAGS)),)
398 my_cflags += -fvisibility=default
399 endif
Vishwath Mohan5b69c062017-02-14 07:55:37 -0800400 my_ldflags += $(CFI_EXTRA_LDFLAGS)
Evgenii Stepanove1b96f32017-01-23 16:57:38 -0800401 my_arflags += --plugin $(LLVM_PREBUILTS_PATH)/../lib64/LLVMgold.so
Vishwath Mohan85f72442017-11-01 09:21:20 +0000402
403 ifeq ($(LOCAL_FORCE_STATIC_EXECUTABLE),true)
404 my_ldflags := $(filter-out -fsanitize-cfi-cross-dso,$(my_ldflags))
405 my_cflags := $(filter-out -fsanitize-cfi-cross-dso,$(my_cflags))
406 else
407 # Apply the version script to non-static executables
408 my_ldflags += -Wl,--version-script,build/soong/cc/config/cfi_exports.map
409 LOCAL_ADDITIONAL_DEPENDENCIES += build/soong/cc/config/cfi_exports.map
410 endif
Evgenii Stepanov202c7a72016-07-07 10:56:39 -0700411endif
412
Chih-Hung Hsiehad741e62016-03-09 14:54:55 -0800413# If local or global modules need ASAN, add linker flags.
414ifneq ($(filter address,$(my_global_sanitize) $(my_sanitize)),)
Dan Albert4ae5d4b2014-10-31 16:23:08 -0700415 my_ldflags += $(ADDRESS_SANITIZER_CONFIG_EXTRA_LDFLAGS)
416 ifdef LOCAL_IS_HOST_MODULE
Dan Albert08cca282014-12-11 18:56:26 -0800417 # -nodefaultlibs (provided with libc++) prevents the driver from linking
418 # libraries needed with -fsanitize=address. http://b/18650275 (WAI)
Dan Albert1f0d5302015-04-28 14:55:50 -0700419 my_ldflags += -Wl,--no-as-needed
Dan Albert4ae5d4b2014-10-31 16:23:08 -0700420 else
Chih-Hung Hsiehad741e62016-03-09 14:54:55 -0800421 # Add asan libraries unless LOCAL_MODULE is the asan library.
Evgenii Stepanovf0b15e12015-04-24 16:34:47 -0700422 # ASan runtime library must be the first in the link order.
Chih-Hung Hsiehad741e62016-03-09 14:54:55 -0800423 ifeq (,$(filter $(LOCAL_MODULE),$($(LOCAL_2ND_ARCH_VAR_PREFIX)ADDRESS_SANITIZER_RUNTIME_LIBRARY)))
424 my_shared_libraries := $($(LOCAL_2ND_ARCH_VAR_PREFIX)ADDRESS_SANITIZER_RUNTIME_LIBRARY) \
425 $(my_shared_libraries)
426 endif
Chih-Hung Hsiehad741e62016-03-09 14:54:55 -0800427
428 # Do not add unnecessary dependency in shared libraries.
429 ifeq ($(LOCAL_MODULE_CLASS),SHARED_LIBRARIES)
430 my_ldflags += -Wl,--as-needed
431 endif
Ying Wanga05e2222015-08-17 16:13:24 -0700432
Mikhail Naganovaa73cef2018-12-20 15:55:08 -0800433 ifneq ($(filter EXECUTABLES NATIVE_TESTS,$(LOCAL_MODULE_CLASS)),)
Colin Crossd08699e2016-07-17 15:28:07 -0700434 ifneq ($(LOCAL_FORCE_STATIC_EXECUTABLE),true)
435 my_linker := $($(LOCAL_2ND_ARCH_VAR_PREFIX)ADDRESS_SANITIZER_LINKER)
436 # Make sure linker_asan get installed.
Logan Chienc6d2cf82019-01-31 17:07:50 +0800437 $(LOCAL_INSTALLED_MODULE) : | $(PRODUCT_OUT)$($(LOCAL_2ND_ARCH_VAR_PREFIX)ADDRESS_SANITIZER_LINKER_FILE)
Colin Crossd08699e2016-07-17 15:28:07 -0700438 endif
439 endif
Dan Albert08cca282014-12-11 18:56:26 -0800440 endif
441endif
442
Chih-Hung Hsiehad741e62016-03-09 14:54:55 -0800443# If local module needs ASAN, add compiler flags.
444ifneq ($(filter address,$(my_sanitize)),)
445 # Frame pointer based unwinder in ASan requires ARM frame setup.
446 LOCAL_ARM_MODE := arm
447 my_cflags += $(ADDRESS_SANITIZER_CONFIG_EXTRA_CFLAGS)
448 ifndef LOCAL_IS_HOST_MODULE
449 my_cflags += -mllvm -asan-globals=0
450 endif
451endif
452
Evgenii Stepanovaec1ffc2018-08-28 13:52:08 -0700453# If local module needs HWASAN, add compiler flags.
454ifneq ($(filter hwaddress,$(my_sanitize)),)
455 my_cflags += $(HWADDRESS_SANITIZER_CONFIG_EXTRA_CFLAGS)
Florian Mayer97222e12023-06-01 14:16:28 -0700456
457 ifneq ($(filter EXECUTABLES NATIVE_TESTS,$(LOCAL_MODULE_CLASS)),)
458 ifneq ($(LOCAL_FORCE_STATIC_EXECUTABLE),true)
459 my_linker := /system/bin/linker_hwasan64
460 endif
461 endif
462
Evgenii Stepanovaec1ffc2018-08-28 13:52:08 -0700463endif
464
Dan Willemsen58634e12020-03-06 18:09:06 -0800465# Use minimal diagnostics when integer overflow is enabled; never do it for HOST modules
466ifeq ($(LOCAL_IS_HOST_MODULE),)
Ivan Lozano911cb992018-02-21 13:41:05 -0800467 # Pre-emptively add UBSAN minimal runtime incase a static library dependency requires it
468 ifeq ($(filter STATIC_LIBRARIES,$(LOCAL_MODULE_CLASS)),)
469 ifndef LOCAL_SDK_VERSION
470 my_static_libraries += $($(LOCAL_2ND_ARCH_VAR_PREFIX)UBSAN_MINIMAL_RUNTIME_LIBRARY)
Ivan Lozanoe5081692018-05-11 14:09:36 -0700471 my_ldflags += -Wl,--exclude-libs,$($(LOCAL_2ND_ARCH_VAR_PREFIX)UBSAN_MINIMAL_RUNTIME_LIBRARY).a
Ivan Lozano911cb992018-02-21 13:41:05 -0800472 endif
473 endif
474 ifneq ($(filter unsigned-integer-overflow signed-integer-overflow integer,$(my_sanitize)),)
Kostya Kortchinsky47c10eb2018-10-11 08:56:12 -0700475 ifeq ($(filter unsigned-integer-overflow signed-integer-overflow integer,$(my_sanitize_diag)),)
Ivan Lozano911cb992018-02-21 13:41:05 -0800476 ifeq ($(filter cfi,$(my_sanitize_diag)),)
Mitch Phillipsee8f4a02019-05-01 14:37:33 -0700477 ifeq ($(filter address hwaddress fuzzer-no-link,$(my_sanitize)),)
Ivan Lozano911cb992018-02-21 13:41:05 -0800478 my_cflags += -fsanitize-minimal-runtime
479 my_cflags += -fno-sanitize-trap=integer
480 my_cflags += -fno-sanitize-recover=integer
481 endif
482 endif
483 endif
484 endif
485endif
486
Kostya Kortchinsky47c10eb2018-10-11 08:56:12 -0700487# For Scudo, we opt for the minimal runtime, unless some diagnostics are enabled.
488ifneq ($(filter scudo,$(my_sanitize)),)
489 ifeq ($(filter unsigned-integer-overflow signed-integer-overflow integer cfi,$(my_sanitize_diag)),)
490 my_cflags += -fsanitize-minimal-runtime
491 endif
492 ifneq ($(filter -fsanitize-minimal-runtime,$(my_cflags)),)
493 my_shared_libraries += $($(LOCAL_2ND_ARCH_VAR_PREFIX)SCUDO_MINIMAL_RUNTIME_LIBRARY)
494 else
495 my_shared_libraries += $($(LOCAL_2ND_ARCH_VAR_PREFIX)SCUDO_RUNTIME_LIBRARY)
496 endif
497endif
498
Dan Albert9f176552015-04-28 11:26:45 -0700499ifneq ($(strip $(LOCAL_SANITIZE_RECOVER)),)
500 recover_arg := $(subst $(space),$(comma),$(LOCAL_SANITIZE_RECOVER)),
Dan Albert4111d482015-04-16 18:08:44 -0700501 my_cflags += -fsanitize-recover=$(recover_arg)
502endif
Evgenii Stepanov202c7a72016-07-07 10:56:39 -0700503
Ivan Lozano5fb2de72018-12-12 10:04:34 -0800504ifneq ($(strip $(LOCAL_SANITIZE_NO_RECOVER)),)
505 no_recover_arg := $(subst $(space),$(comma),$(LOCAL_SANITIZE_NO_RECOVER)),
506 my_cflags += -fno-sanitize-recover=$(no_recover_arg)
507endif
508
Vishwath Mohan8dcfdce2017-01-18 17:50:29 -0800509ifneq ($(my_sanitize_diag),)
Vishwath Mohan85f72442017-11-01 09:21:20 +0000510 # TODO(vishwath): Add diagnostic support for static executables once
511 # we switch to clang-4393122 (which adds the static ubsan runtime
512 # that this depends on)
513 ifneq ($(LOCAL_FORCE_STATIC_EXECUTABLE),true)
514 notrap_arg := $(subst $(space),$(comma),$(my_sanitize_diag)),
515 my_cflags += -fno-sanitize-trap=$(notrap_arg)
516 # Diagnostic requires a runtime library, unless ASan or TSan are also enabled.
Evgenii Stepanov8841a7f2018-07-27 11:54:32 -0700517 ifeq ($(filter address thread scudo hwaddress,$(my_sanitize)),)
Vishwath Mohan85f72442017-11-01 09:21:20 +0000518 # Does not have to be the first DT_NEEDED unlike ASan.
519 my_shared_libraries += $($(LOCAL_2ND_ARCH_VAR_PREFIX)UBSAN_RUNTIME_LIBRARY)
520 endif
Evgenii Stepanov202c7a72016-07-07 10:56:39 -0700521 endif
522endif
Chih-Hung Hsieh18710622018-11-17 20:18:08 -0800523
524# http://b/119329758, Android core does not boot up with this sanitizer yet.
525# Previously sanitized modules might not pass new implicit-integer-sign-change check.
526# Disable this check unless it has been explicitly specified.
527ifneq ($(findstring fsanitize,$(my_cflags)),)
528 ifneq ($(findstring integer,$(my_cflags)),)
529 ifeq ($(findstring sanitize=implicit-integer-sign-change,$(my_cflags)),)
530 my_cflags += -fno-sanitize=implicit-integer-sign-change
531 endif
532 endif
533endif
Yabin Cui462c12d2021-01-14 14:05:54 -0800534
535# http://b/177566116, libc++ may crash with this sanitizer.
536# Disable this check unless it has been explicitly specified.
537ifneq ($(findstring fsanitize,$(my_cflags)),)
538 ifneq ($(findstring integer,$(my_cflags)),)
539 ifeq ($(findstring sanitize=unsigned-shift-base,$(my_cflags)),)
540 my_cflags += -fno-sanitize=unsigned-shift-base
541 endif
542 endif
543endif