Adithya Srinivasan | f279e04 | 2020-08-17 14:56:27 -0700 | [diff] [blame] | 1 | /* |
| 2 | * Copyright 2020 The Android Open Source Project |
| 3 | * |
| 4 | * Licensed under the Apache License, Version 2.0 (the "License"); |
| 5 | * you may not use this file except in compliance with the License. |
| 6 | * You may obtain a copy of the License at |
| 7 | * |
| 8 | * http://www.apache.org/licenses/LICENSE-2.0 |
| 9 | * |
| 10 | * Unless required by applicable law or agreed to in writing, software |
| 11 | * distributed under the License is distributed on an "AS IS" BASIS, |
| 12 | * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. |
| 13 | * See the License for the specific language governing permissions and |
| 14 | * limitations under the License. |
| 15 | */ |
| 16 | |
Ady Abraham | 3db8a3c | 2023-11-20 17:53:47 -0800 | [diff] [blame] | 17 | #include <common/test/FlagUtils.h> |
Pascal Mütschard | d56514e | 2024-05-24 17:37:13 +0200 | [diff] [blame] | 18 | #include "BackgroundExecutor.h" |
| 19 | #include "Jank/JankTracker.h" |
Sally Qi | f572125 | 2023-11-17 11:14:53 -0800 | [diff] [blame] | 20 | #include "com_android_graphics_surfaceflinger_flags.h" |
Alec Mouri | 9a29e67 | 2020-09-14 12:39:14 -0700 | [diff] [blame] | 21 | #include "gmock/gmock-spec-builders.h" |
| 22 | #include "mock/MockTimeStats.h" |
Adithya Srinivasan | f279e04 | 2020-08-17 14:56:27 -0700 | [diff] [blame] | 23 | #undef LOG_TAG |
| 24 | #define LOG_TAG "LibSurfaceFlingerUnittests" |
| 25 | |
| 26 | #include <FrameTimeline/FrameTimeline.h> |
| 27 | #include <gtest/gtest.h> |
| 28 | #include <log/log.h> |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 29 | #include <perfetto/trace/trace.pb.h> |
Adithya Srinivasan | f279e04 | 2020-08-17 14:56:27 -0700 | [diff] [blame] | 30 | #include <cinttypes> |
| 31 | |
| 32 | using namespace std::chrono_literals; |
Alec Mouri | 363faf0 | 2021-01-29 16:34:55 -0800 | [diff] [blame] | 33 | using testing::_; |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 34 | using testing::AtLeast; |
Alec Mouri | 9a29e67 | 2020-09-14 12:39:14 -0700 | [diff] [blame] | 35 | using testing::Contains; |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 36 | using FrameTimelineEvent = perfetto::protos::FrameTimelineEvent; |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 37 | using ProtoExpectedDisplayFrameStart = |
| 38 | perfetto::protos::FrameTimelineEvent_ExpectedDisplayFrameStart; |
| 39 | using ProtoExpectedSurfaceFrameStart = |
| 40 | perfetto::protos::FrameTimelineEvent_ExpectedSurfaceFrameStart; |
| 41 | using ProtoActualDisplayFrameStart = perfetto::protos::FrameTimelineEvent_ActualDisplayFrameStart; |
| 42 | using ProtoActualSurfaceFrameStart = perfetto::protos::FrameTimelineEvent_ActualSurfaceFrameStart; |
| 43 | using ProtoFrameEnd = perfetto::protos::FrameTimelineEvent_FrameEnd; |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 44 | using ProtoPresentType = perfetto::protos::FrameTimelineEvent_PresentType; |
| 45 | using ProtoJankType = perfetto::protos::FrameTimelineEvent_JankType; |
Ying Wei | 96eb535 | 2023-11-21 17:37:21 +0000 | [diff] [blame] | 46 | using ProtoJankSeverityType = perfetto::protos::FrameTimelineEvent_JankSeverityType; |
Adithya Srinivasan | 78e58af | 2021-02-25 00:08:08 +0000 | [diff] [blame] | 47 | using ProtoPredictionType = perfetto::protos::FrameTimelineEvent_PredictionType; |
Alec Mouri | 9a29e67 | 2020-09-14 12:39:14 -0700 | [diff] [blame] | 48 | |
Adithya Srinivasan | f279e04 | 2020-08-17 14:56:27 -0700 | [diff] [blame] | 49 | namespace android::frametimeline { |
| 50 | |
Ady Abraham | 57a8ab4 | 2023-01-26 15:28:19 -0800 | [diff] [blame] | 51 | static const std::string sLayerNameOne = "layer1"; |
| 52 | static const std::string sLayerNameTwo = "layer2"; |
| 53 | |
| 54 | constexpr const uid_t sUidOne = 0; |
| 55 | constexpr pid_t sPidOne = 10; |
| 56 | constexpr pid_t sPidTwo = 20; |
| 57 | constexpr int32_t sInputEventId = 5; |
| 58 | constexpr int32_t sLayerIdOne = 1; |
| 59 | constexpr int32_t sLayerIdTwo = 2; |
| 60 | constexpr GameMode sGameMode = GameMode::Unsupported; |
Pascal Muetschard | ac7bcd9 | 2023-10-03 15:05:36 +0200 | [diff] [blame] | 61 | constexpr Fps RR_11 = Fps::fromPeriodNsecs(11); |
| 62 | constexpr Fps RR_30 = Fps::fromPeriodNsecs(30); |
Ady Abraham | 57a8ab4 | 2023-01-26 15:28:19 -0800 | [diff] [blame] | 63 | |
Adithya Srinivasan | f279e04 | 2020-08-17 14:56:27 -0700 | [diff] [blame] | 64 | class FrameTimelineTest : public testing::Test { |
| 65 | public: |
| 66 | FrameTimelineTest() { |
| 67 | const ::testing::TestInfo* const test_info = |
| 68 | ::testing::UnitTest::GetInstance()->current_test_info(); |
| 69 | ALOGD("**** Setting up for %s.%s\n", test_info->test_case_name(), test_info->name()); |
| 70 | } |
| 71 | |
| 72 | ~FrameTimelineTest() { |
| 73 | const ::testing::TestInfo* const test_info = |
| 74 | ::testing::UnitTest::GetInstance()->current_test_info(); |
| 75 | ALOGD("**** Tearing down after %s.%s\n", test_info->test_case_name(), test_info->name()); |
| 76 | } |
| 77 | |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 78 | static void SetUpTestSuite() { |
| 79 | // Need to initialize tracing in process for testing, and only once per test suite. |
| 80 | perfetto::TracingInitArgs args; |
| 81 | args.backends = perfetto::kInProcessBackend; |
| 82 | perfetto::Tracing::Initialize(args); |
| 83 | } |
| 84 | |
Adithya Srinivasan | f279e04 | 2020-08-17 14:56:27 -0700 | [diff] [blame] | 85 | void SetUp() override { |
Ady Abraham | 57f8e18 | 2022-03-08 15:54:33 -0800 | [diff] [blame] | 86 | constexpr bool kUseBootTimeClock = true; |
Alec Mouri | 9a29e67 | 2020-09-14 12:39:14 -0700 | [diff] [blame] | 87 | mTimeStats = std::make_shared<mock::TimeStats>(); |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 88 | mFrameTimeline = std::make_unique<impl::FrameTimeline>(mTimeStats, kSurfaceFlingerPid, |
Ady Abraham | 57f8e18 | 2022-03-08 15:54:33 -0800 | [diff] [blame] | 89 | kTestThresholds, !kUseBootTimeClock); |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 90 | mFrameTimeline->registerDataSource(); |
Adithya Srinivasan | f279e04 | 2020-08-17 14:56:27 -0700 | [diff] [blame] | 91 | mTokenManager = &mFrameTimeline->mTokenManager; |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 92 | mTraceCookieCounter = &mFrameTimeline->mTraceCookieCounter; |
Adithya Srinivasan | 2d73632 | 2020-10-01 16:53:48 -0700 | [diff] [blame] | 93 | maxDisplayFrames = &mFrameTimeline->mMaxDisplayFrames; |
Adithya Srinivasan | bed4c4f | 2021-05-03 20:24:46 +0000 | [diff] [blame] | 94 | maxTokens = mTokenManager->kMaxTokens; |
Pascal Mütschard | d56514e | 2024-05-24 17:37:13 +0200 | [diff] [blame] | 95 | |
| 96 | JankTracker::clearAndStartCollectingAllJankDataForTesting(); |
Adithya Srinivasan | f279e04 | 2020-08-17 14:56:27 -0700 | [diff] [blame] | 97 | } |
| 98 | |
Pascal Mütschard | d56514e | 2024-05-24 17:37:13 +0200 | [diff] [blame] | 99 | void TearDown() override { JankTracker::clearAndStopCollectingAllJankDataForTesting(); } |
| 100 | |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 101 | // Each tracing session can be used for a single block of Start -> Stop. |
| 102 | static std::unique_ptr<perfetto::TracingSession> getTracingSessionForTest() { |
| 103 | perfetto::TraceConfig cfg; |
| 104 | cfg.set_duration_ms(500); |
| 105 | cfg.add_buffers()->set_size_kb(1024); |
| 106 | auto* ds_cfg = cfg.add_data_sources()->mutable_config(); |
| 107 | ds_cfg->set_name(impl::FrameTimeline::kFrameTimelineDataSource); |
| 108 | |
| 109 | auto tracingSession = perfetto::Tracing::NewTrace(perfetto::kInProcessBackend); |
| 110 | tracingSession->Setup(cfg); |
| 111 | return tracingSession; |
| 112 | } |
| 113 | |
| 114 | std::vector<perfetto::protos::TracePacket> readFrameTimelinePacketsBlocking( |
| 115 | perfetto::TracingSession* tracingSession) { |
| 116 | std::vector<char> raw_trace = tracingSession->ReadTraceBlocking(); |
| 117 | perfetto::protos::Trace trace; |
| 118 | EXPECT_TRUE(trace.ParseFromArray(raw_trace.data(), int(raw_trace.size()))); |
| 119 | |
| 120 | std::vector<perfetto::protos::TracePacket> packets; |
| 121 | for (const auto& packet : trace.packet()) { |
| 122 | if (!packet.has_frame_timeline_event()) { |
| 123 | continue; |
| 124 | } |
| 125 | packets.emplace_back(packet); |
| 126 | } |
| 127 | return packets; |
| 128 | } |
| 129 | |
Ady Abraham | 57a8ab4 | 2023-01-26 15:28:19 -0800 | [diff] [blame] | 130 | void addEmptySurfaceFrame() { |
| 131 | auto surfaceFrame = |
| 132 | mFrameTimeline->createSurfaceFrameForToken({}, sPidOne, sUidOne, sLayerIdOne, |
| 133 | sLayerNameOne, sLayerNameOne, |
| 134 | /*isBuffer*/ false, sGameMode); |
| 135 | mFrameTimeline->addSurfaceFrame(std::move(surfaceFrame)); |
| 136 | } |
| 137 | |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 138 | void addEmptyDisplayFrame() { |
| 139 | auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 140 | // Trigger a flushPresentFence by calling setSfPresent for the next frame |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 141 | mFrameTimeline->setSfPresent(2500, presentFence1); |
| 142 | } |
| 143 | |
Adithya Srinivasan | bed4c4f | 2021-05-03 20:24:46 +0000 | [diff] [blame] | 144 | void flushTokens() { |
| 145 | for (size_t i = 0; i < maxTokens; i++) { |
| 146 | mTokenManager->generateTokenForPredictions({}); |
| 147 | } |
| 148 | EXPECT_EQ(getPredictions().size(), maxTokens); |
Adithya Srinivasan | f279e04 | 2020-08-17 14:56:27 -0700 | [diff] [blame] | 149 | } |
| 150 | |
| 151 | SurfaceFrame& getSurfaceFrame(size_t displayFrameIdx, size_t surfaceFrameIdx) { |
| 152 | std::lock_guard<std::mutex> lock(mFrameTimeline->mMutex); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 153 | return *(mFrameTimeline->mDisplayFrames[displayFrameIdx] |
| 154 | ->getSurfaceFrames()[surfaceFrameIdx]); |
Adithya Srinivasan | f279e04 | 2020-08-17 14:56:27 -0700 | [diff] [blame] | 155 | } |
| 156 | |
| 157 | std::shared_ptr<impl::FrameTimeline::DisplayFrame> getDisplayFrame(size_t idx) { |
| 158 | std::lock_guard<std::mutex> lock(mFrameTimeline->mMutex); |
| 159 | return mFrameTimeline->mDisplayFrames[idx]; |
| 160 | } |
| 161 | |
| 162 | static bool compareTimelineItems(const TimelineItem& a, const TimelineItem& b) { |
| 163 | return a.startTime == b.startTime && a.endTime == b.endTime && |
| 164 | a.presentTime == b.presentTime; |
| 165 | } |
| 166 | |
Adithya Srinivasan | bed4c4f | 2021-05-03 20:24:46 +0000 | [diff] [blame] | 167 | const std::map<int64_t, TimelineItem>& getPredictions() const { |
Adithya Srinivasan | f279e04 | 2020-08-17 14:56:27 -0700 | [diff] [blame] | 168 | return mTokenManager->mPredictions; |
| 169 | } |
| 170 | |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 171 | uint32_t getNumberOfDisplayFrames() const { |
Adithya Srinivasan | 2d73632 | 2020-10-01 16:53:48 -0700 | [diff] [blame] | 172 | std::lock_guard<std::mutex> lock(mFrameTimeline->mMutex); |
| 173 | return static_cast<uint32_t>(mFrameTimeline->mDisplayFrames.size()); |
| 174 | } |
| 175 | |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 176 | int64_t snoopCurrentTraceCookie() const { return mTraceCookieCounter->mTraceCookie; } |
| 177 | |
| 178 | void flushTrace() { |
| 179 | using FrameTimelineDataSource = impl::FrameTimeline::FrameTimelineDataSource; |
| 180 | FrameTimelineDataSource::Trace( |
| 181 | [&](FrameTimelineDataSource::TraceContext ctx) { ctx.Flush(); }); |
| 182 | } |
| 183 | |
Pascal Mütschard | d56514e | 2024-05-24 17:37:13 +0200 | [diff] [blame] | 184 | std::vector<gui::JankData> getLayerOneJankData() { |
| 185 | BackgroundExecutor::getLowPriorityInstance().flushQueue(); |
| 186 | return JankTracker::getCollectedJankDataForTesting(sLayerIdOne); |
| 187 | } |
| 188 | |
| 189 | std::vector<gui::JankData> getLayerTwoJankData() { |
| 190 | BackgroundExecutor::getLowPriorityInstance().flushQueue(); |
| 191 | return JankTracker::getCollectedJankDataForTesting(sLayerIdTwo); |
| 192 | } |
| 193 | |
Alec Mouri | 9a29e67 | 2020-09-14 12:39:14 -0700 | [diff] [blame] | 194 | std::shared_ptr<mock::TimeStats> mTimeStats; |
Adithya Srinivasan | f279e04 | 2020-08-17 14:56:27 -0700 | [diff] [blame] | 195 | std::unique_ptr<impl::FrameTimeline> mFrameTimeline; |
| 196 | impl::TokenManager* mTokenManager; |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 197 | TraceCookieCounter* mTraceCookieCounter; |
Adithya Srinivasan | f279e04 | 2020-08-17 14:56:27 -0700 | [diff] [blame] | 198 | FenceToFenceTimeMap fenceFactory; |
Adithya Srinivasan | 2d73632 | 2020-10-01 16:53:48 -0700 | [diff] [blame] | 199 | uint32_t* maxDisplayFrames; |
Adithya Srinivasan | bed4c4f | 2021-05-03 20:24:46 +0000 | [diff] [blame] | 200 | size_t maxTokens; |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 201 | static constexpr pid_t kSurfaceFlingerPid = 666; |
Adithya Srinivasan | ead1716 | 2021-02-18 02:17:37 +0000 | [diff] [blame] | 202 | static constexpr nsecs_t kPresentThreshold = std::chrono::nanoseconds(2ns).count(); |
Adithya Srinivasan | 54996e2 | 2021-06-25 22:26:45 +0000 | [diff] [blame] | 203 | static constexpr nsecs_t kDeadlineThreshold = std::chrono::nanoseconds(0ns).count(); |
Adithya Srinivasan | ead1716 | 2021-02-18 02:17:37 +0000 | [diff] [blame] | 204 | static constexpr nsecs_t kStartThreshold = std::chrono::nanoseconds(2ns).count(); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 205 | static constexpr JankClassificationThresholds kTestThresholds{kPresentThreshold, |
| 206 | kDeadlineThreshold, |
| 207 | kStartThreshold}; |
Adithya Srinivasan | f279e04 | 2020-08-17 14:56:27 -0700 | [diff] [blame] | 208 | }; |
| 209 | |
| 210 | TEST_F(FrameTimelineTest, tokenManagerRemovesStalePredictions) { |
| 211 | int64_t token1 = mTokenManager->generateTokenForPredictions({0, 0, 0}); |
Siarhei Vishniakou | fc434ac | 2021-01-13 10:28:00 -1000 | [diff] [blame] | 212 | EXPECT_EQ(getPredictions().size(), 1u); |
Adithya Srinivasan | bed4c4f | 2021-05-03 20:24:46 +0000 | [diff] [blame] | 213 | flushTokens(); |
Adithya Srinivasan | f279e04 | 2020-08-17 14:56:27 -0700 | [diff] [blame] | 214 | int64_t token2 = mTokenManager->generateTokenForPredictions({10, 20, 30}); |
| 215 | std::optional<TimelineItem> predictions = mTokenManager->getPredictionsForToken(token1); |
| 216 | |
| 217 | // token1 should have expired |
Adithya Srinivasan | f279e04 | 2020-08-17 14:56:27 -0700 | [diff] [blame] | 218 | EXPECT_EQ(predictions.has_value(), false); |
| 219 | |
| 220 | predictions = mTokenManager->getPredictionsForToken(token2); |
| 221 | EXPECT_EQ(compareTimelineItems(*predictions, TimelineItem(10, 20, 30)), true); |
| 222 | } |
| 223 | |
Adithya Srinivasan | 9febda8 | 2020-10-19 10:49:41 -0700 | [diff] [blame] | 224 | TEST_F(FrameTimelineTest, createSurfaceFrameForToken_getOwnerPidReturnsCorrectPid) { |
Alec Mouri | adebf5c | 2021-01-05 12:57:36 -0800 | [diff] [blame] | 225 | auto surfaceFrame1 = |
| 226 | mFrameTimeline->createSurfaceFrameForToken({}, sPidOne, sUidOne, sLayerIdOne, |
Adithya Srinivasan | 785addd | 2021-03-09 00:38:00 +0000 | [diff] [blame] | 227 | sLayerNameOne, sLayerNameOne, |
Adithya Srinivasan | 58069dc | 2021-06-04 20:37:02 +0000 | [diff] [blame] | 228 | /*isBuffer*/ true, sGameMode); |
Alec Mouri | adebf5c | 2021-01-05 12:57:36 -0800 | [diff] [blame] | 229 | auto surfaceFrame2 = |
| 230 | mFrameTimeline->createSurfaceFrameForToken({}, sPidTwo, sUidOne, sLayerIdOne, |
Adithya Srinivasan | 785addd | 2021-03-09 00:38:00 +0000 | [diff] [blame] | 231 | sLayerNameOne, sLayerNameOne, |
Adithya Srinivasan | 58069dc | 2021-06-04 20:37:02 +0000 | [diff] [blame] | 232 | /*isBuffer*/ true, sGameMode); |
Adithya Srinivasan | 9febda8 | 2020-10-19 10:49:41 -0700 | [diff] [blame] | 233 | EXPECT_EQ(surfaceFrame1->getOwnerPid(), sPidOne); |
| 234 | EXPECT_EQ(surfaceFrame2->getOwnerPid(), sPidTwo); |
| 235 | } |
| 236 | |
Adithya Srinivasan | f279e04 | 2020-08-17 14:56:27 -0700 | [diff] [blame] | 237 | TEST_F(FrameTimelineTest, createSurfaceFrameForToken_noToken) { |
Alec Mouri | adebf5c | 2021-01-05 12:57:36 -0800 | [diff] [blame] | 238 | auto surfaceFrame = |
| 239 | mFrameTimeline->createSurfaceFrameForToken({}, sPidOne, sUidOne, sLayerIdOne, |
Adithya Srinivasan | 785addd | 2021-03-09 00:38:00 +0000 | [diff] [blame] | 240 | sLayerNameOne, sLayerNameOne, |
Adithya Srinivasan | 58069dc | 2021-06-04 20:37:02 +0000 | [diff] [blame] | 241 | /*isBuffer*/ true, sGameMode); |
Adithya Srinivasan | f279e04 | 2020-08-17 14:56:27 -0700 | [diff] [blame] | 242 | EXPECT_EQ(surfaceFrame->getPredictionState(), PredictionState::None); |
| 243 | } |
| 244 | |
| 245 | TEST_F(FrameTimelineTest, createSurfaceFrameForToken_expiredToken) { |
| 246 | int64_t token1 = mTokenManager->generateTokenForPredictions({0, 0, 0}); |
Adithya Srinivasan | bed4c4f | 2021-05-03 20:24:46 +0000 | [diff] [blame] | 247 | flushTokens(); |
Huihong Luo | 3bdef86 | 2022-03-03 11:57:19 -0800 | [diff] [blame] | 248 | FrameTimelineInfo ftInfo; |
| 249 | ftInfo.vsyncId = token1; |
| 250 | ftInfo.inputEventId = sInputEventId; |
Siarhei Vishniakou | fc434ac | 2021-01-13 10:28:00 -1000 | [diff] [blame] | 251 | auto surfaceFrame = |
Huihong Luo | 3bdef86 | 2022-03-03 11:57:19 -0800 | [diff] [blame] | 252 | mFrameTimeline->createSurfaceFrameForToken(ftInfo, sPidOne, sUidOne, sLayerIdOne, |
| 253 | sLayerNameOne, sLayerNameOne, |
Adithya Srinivasan | 58069dc | 2021-06-04 20:37:02 +0000 | [diff] [blame] | 254 | /*isBuffer*/ true, sGameMode); |
Adithya Srinivasan | f279e04 | 2020-08-17 14:56:27 -0700 | [diff] [blame] | 255 | |
| 256 | EXPECT_EQ(surfaceFrame->getPredictionState(), PredictionState::Expired); |
| 257 | } |
| 258 | |
| 259 | TEST_F(FrameTimelineTest, createSurfaceFrameForToken_validToken) { |
| 260 | int64_t token1 = mTokenManager->generateTokenForPredictions({10, 20, 30}); |
Huihong Luo | 3bdef86 | 2022-03-03 11:57:19 -0800 | [diff] [blame] | 261 | FrameTimelineInfo ftInfo; |
| 262 | ftInfo.vsyncId = token1; |
| 263 | ftInfo.inputEventId = sInputEventId; |
Siarhei Vishniakou | fc434ac | 2021-01-13 10:28:00 -1000 | [diff] [blame] | 264 | auto surfaceFrame = |
Huihong Luo | 3bdef86 | 2022-03-03 11:57:19 -0800 | [diff] [blame] | 265 | mFrameTimeline->createSurfaceFrameForToken(ftInfo, sPidOne, sUidOne, sLayerIdOne, |
| 266 | sLayerNameOne, sLayerNameOne, |
Adithya Srinivasan | 58069dc | 2021-06-04 20:37:02 +0000 | [diff] [blame] | 267 | /*isBuffer*/ true, sGameMode); |
Adithya Srinivasan | f279e04 | 2020-08-17 14:56:27 -0700 | [diff] [blame] | 268 | |
| 269 | EXPECT_EQ(surfaceFrame->getPredictionState(), PredictionState::Valid); |
| 270 | EXPECT_EQ(compareTimelineItems(surfaceFrame->getPredictions(), TimelineItem(10, 20, 30)), true); |
| 271 | } |
| 272 | |
Siarhei Vishniakou | fc434ac | 2021-01-13 10:28:00 -1000 | [diff] [blame] | 273 | TEST_F(FrameTimelineTest, createSurfaceFrameForToken_validInputEventId) { |
| 274 | int64_t token1 = mTokenManager->generateTokenForPredictions({10, 20, 30}); |
| 275 | constexpr int32_t inputEventId = 1; |
Huihong Luo | 3bdef86 | 2022-03-03 11:57:19 -0800 | [diff] [blame] | 276 | FrameTimelineInfo ftInfo; |
| 277 | ftInfo.vsyncId = token1; |
| 278 | ftInfo.inputEventId = inputEventId; |
Siarhei Vishniakou | fc434ac | 2021-01-13 10:28:00 -1000 | [diff] [blame] | 279 | auto surfaceFrame = |
Huihong Luo | 3bdef86 | 2022-03-03 11:57:19 -0800 | [diff] [blame] | 280 | mFrameTimeline->createSurfaceFrameForToken(ftInfo, sPidOne, sUidOne, sLayerIdOne, |
| 281 | sLayerNameOne, sLayerNameOne, |
Adithya Srinivasan | 58069dc | 2021-06-04 20:37:02 +0000 | [diff] [blame] | 282 | /*isBuffer*/ true, sGameMode); |
Siarhei Vishniakou | fc434ac | 2021-01-13 10:28:00 -1000 | [diff] [blame] | 283 | |
| 284 | EXPECT_EQ(inputEventId, surfaceFrame->getInputEventId()); |
| 285 | } |
| 286 | |
Adithya Srinivasan | f279e04 | 2020-08-17 14:56:27 -0700 | [diff] [blame] | 287 | TEST_F(FrameTimelineTest, presentFenceSignaled_droppedFramesNotUpdated) { |
| 288 | auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
Adithya Srinivasan | f279e04 | 2020-08-17 14:56:27 -0700 | [diff] [blame] | 289 | int64_t token1 = mTokenManager->generateTokenForPredictions({10, 20, 30}); |
Huihong Luo | 3bdef86 | 2022-03-03 11:57:19 -0800 | [diff] [blame] | 290 | FrameTimelineInfo ftInfo; |
| 291 | ftInfo.vsyncId = token1; |
| 292 | ftInfo.inputEventId = sInputEventId; |
Siarhei Vishniakou | fc434ac | 2021-01-13 10:28:00 -1000 | [diff] [blame] | 293 | auto surfaceFrame1 = |
Huihong Luo | 3bdef86 | 2022-03-03 11:57:19 -0800 | [diff] [blame] | 294 | mFrameTimeline->createSurfaceFrameForToken(ftInfo, sPidOne, sUidOne, sLayerIdOne, |
| 295 | sLayerNameOne, sLayerNameOne, |
Adithya Srinivasan | 58069dc | 2021-06-04 20:37:02 +0000 | [diff] [blame] | 296 | /*isBuffer*/ true, sGameMode); |
Adithya Srinivasan | f279e04 | 2020-08-17 14:56:27 -0700 | [diff] [blame] | 297 | |
| 298 | // Set up the display frame |
Pascal Muetschard | ac7bcd9 | 2023-10-03 15:05:36 +0200 | [diff] [blame] | 299 | mFrameTimeline->setSfWakeUp(token1, 20, RR_11, RR_11); |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 300 | surfaceFrame1->setDropTime(12); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 301 | surfaceFrame1->setPresentState(SurfaceFrame::PresentState::Dropped); |
| 302 | mFrameTimeline->addSurfaceFrame(surfaceFrame1); |
Adithya Srinivasan | f279e04 | 2020-08-17 14:56:27 -0700 | [diff] [blame] | 303 | mFrameTimeline->setSfPresent(25, presentFence1); |
| 304 | presentFence1->signalForTest(30); |
| 305 | |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 306 | addEmptyDisplayFrame(); |
Adithya Srinivasan | f279e04 | 2020-08-17 14:56:27 -0700 | [diff] [blame] | 307 | |
| 308 | auto& droppedSurfaceFrame = getSurfaceFrame(0, 0); |
| 309 | EXPECT_EQ(droppedSurfaceFrame.getPresentState(), SurfaceFrame::PresentState::Dropped); |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 310 | EXPECT_EQ(0u, droppedSurfaceFrame.getActuals().endTime); |
| 311 | EXPECT_EQ(12u, droppedSurfaceFrame.getDropTime()); |
Adithya Srinivasan | f279e04 | 2020-08-17 14:56:27 -0700 | [diff] [blame] | 312 | EXPECT_EQ(droppedSurfaceFrame.getActuals().presentTime, 0); |
| 313 | } |
| 314 | |
| 315 | TEST_F(FrameTimelineTest, presentFenceSignaled_presentedFramesUpdated) { |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 316 | // Layer specific increment |
Alec Mouri | 363faf0 | 2021-01-29 16:34:55 -0800 | [diff] [blame] | 317 | EXPECT_CALL(*mTimeStats, incrementJankyFrames(_)).Times(2); |
Adithya Srinivasan | f279e04 | 2020-08-17 14:56:27 -0700 | [diff] [blame] | 318 | auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
| 319 | int64_t surfaceFrameToken1 = mTokenManager->generateTokenForPredictions({10, 20, 30}); |
Adithya Srinivasan | f279e04 | 2020-08-17 14:56:27 -0700 | [diff] [blame] | 320 | int64_t sfToken1 = mTokenManager->generateTokenForPredictions({22, 26, 30}); |
Huihong Luo | 3bdef86 | 2022-03-03 11:57:19 -0800 | [diff] [blame] | 321 | FrameTimelineInfo ftInfo; |
| 322 | ftInfo.vsyncId = surfaceFrameToken1; |
| 323 | ftInfo.inputEventId = sInputEventId; |
Alec Mouri | 9a29e67 | 2020-09-14 12:39:14 -0700 | [diff] [blame] | 324 | auto surfaceFrame1 = |
Huihong Luo | 3bdef86 | 2022-03-03 11:57:19 -0800 | [diff] [blame] | 325 | mFrameTimeline->createSurfaceFrameForToken(ftInfo, sPidOne, sUidOne, sLayerIdOne, |
| 326 | sLayerNameOne, sLayerNameOne, |
| 327 | /*isBuffer*/ true, sGameMode); |
Alec Mouri | 9a29e67 | 2020-09-14 12:39:14 -0700 | [diff] [blame] | 328 | auto surfaceFrame2 = |
Huihong Luo | 3bdef86 | 2022-03-03 11:57:19 -0800 | [diff] [blame] | 329 | mFrameTimeline->createSurfaceFrameForToken(ftInfo, sPidOne, sUidOne, sLayerIdTwo, |
| 330 | sLayerNameTwo, sLayerNameTwo, |
| 331 | /*isBuffer*/ true, sGameMode); |
Pascal Muetschard | ac7bcd9 | 2023-10-03 15:05:36 +0200 | [diff] [blame] | 332 | mFrameTimeline->setSfWakeUp(sfToken1, 22, RR_11, RR_11); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 333 | surfaceFrame1->setPresentState(SurfaceFrame::PresentState::Presented); |
| 334 | mFrameTimeline->addSurfaceFrame(surfaceFrame1); |
| 335 | surfaceFrame2->setPresentState(SurfaceFrame::PresentState::Presented); |
| 336 | mFrameTimeline->addSurfaceFrame(surfaceFrame2); |
Adithya Srinivasan | f279e04 | 2020-08-17 14:56:27 -0700 | [diff] [blame] | 337 | mFrameTimeline->setSfPresent(26, presentFence1); |
| 338 | auto displayFrame = getDisplayFrame(0); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 339 | auto& presentedSurfaceFrame1 = getSurfaceFrame(0, 0); |
| 340 | auto& presentedSurfaceFrame2 = getSurfaceFrame(0, 1); |
Adithya Srinivasan | f279e04 | 2020-08-17 14:56:27 -0700 | [diff] [blame] | 341 | presentFence1->signalForTest(42); |
| 342 | |
| 343 | // Fences haven't been flushed yet, so it should be 0 |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 344 | EXPECT_EQ(displayFrame->getActuals().presentTime, 0); |
Adithya Srinivasan | f279e04 | 2020-08-17 14:56:27 -0700 | [diff] [blame] | 345 | EXPECT_EQ(presentedSurfaceFrame1.getActuals().presentTime, 0); |
| 346 | EXPECT_EQ(presentedSurfaceFrame2.getActuals().presentTime, 0); |
| 347 | |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 348 | addEmptyDisplayFrame(); |
Adithya Srinivasan | f279e04 | 2020-08-17 14:56:27 -0700 | [diff] [blame] | 349 | |
| 350 | // Fences have flushed, so the present timestamps should be updated |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 351 | EXPECT_EQ(displayFrame->getActuals().presentTime, 42); |
Adithya Srinivasan | f279e04 | 2020-08-17 14:56:27 -0700 | [diff] [blame] | 352 | EXPECT_EQ(presentedSurfaceFrame1.getActuals().presentTime, 42); |
| 353 | EXPECT_EQ(presentedSurfaceFrame2.getActuals().presentTime, 42); |
Jorim Jaggi | 9c03b50 | 2020-11-24 23:51:31 +0100 | [diff] [blame] | 354 | EXPECT_NE(surfaceFrame1->getJankType(), std::nullopt); |
Ying Wei | 96eb535 | 2023-11-21 17:37:21 +0000 | [diff] [blame] | 355 | EXPECT_NE(surfaceFrame1->getJankSeverityType(), std::nullopt); |
Jorim Jaggi | 9c03b50 | 2020-11-24 23:51:31 +0100 | [diff] [blame] | 356 | EXPECT_NE(surfaceFrame2->getJankType(), std::nullopt); |
Ying Wei | 96eb535 | 2023-11-21 17:37:21 +0000 | [diff] [blame] | 357 | EXPECT_NE(surfaceFrame2->getJankSeverityType(), std::nullopt); |
Pascal Mütschard | d56514e | 2024-05-24 17:37:13 +0200 | [diff] [blame] | 358 | |
| 359 | EXPECT_EQ(getLayerOneJankData().size(), 1u); |
| 360 | EXPECT_EQ(getLayerTwoJankData().size(), 1u); |
Adithya Srinivasan | f279e04 | 2020-08-17 14:56:27 -0700 | [diff] [blame] | 361 | } |
| 362 | |
Ady Abraham | 14beed7 | 2024-05-15 17:16:45 -0700 | [diff] [blame] | 363 | TEST_F(FrameTimelineTest, displayFrameSkippedComposition) { |
| 364 | // Layer specific increment |
| 365 | EXPECT_CALL(*mTimeStats, incrementJankyFrames(_)).Times(1); |
| 366 | auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
| 367 | int64_t surfaceFrameToken1 = mTokenManager->generateTokenForPredictions({10, 20, 30}); |
| 368 | int64_t sfToken1 = mTokenManager->generateTokenForPredictions({22, 26, 30}); |
| 369 | FrameTimelineInfo ftInfo; |
| 370 | ftInfo.vsyncId = surfaceFrameToken1; |
| 371 | ftInfo.inputEventId = sInputEventId; |
| 372 | auto surfaceFrame1 = |
| 373 | mFrameTimeline->createSurfaceFrameForToken(ftInfo, sPidOne, sUidOne, sLayerIdOne, |
| 374 | sLayerNameOne, sLayerNameOne, |
| 375 | /*isBuffer*/ true, sGameMode); |
| 376 | auto surfaceFrame2 = |
| 377 | mFrameTimeline->createSurfaceFrameForToken(ftInfo, sPidOne, sUidOne, sLayerIdTwo, |
| 378 | sLayerNameTwo, sLayerNameTwo, |
| 379 | /*isBuffer*/ true, sGameMode); |
| 380 | |
| 381 | mFrameTimeline->setSfWakeUp(sfToken1, 22, RR_11, RR_11); |
| 382 | surfaceFrame1->setPresentState(SurfaceFrame::PresentState::Presented); |
| 383 | mFrameTimeline->addSurfaceFrame(surfaceFrame1); |
| 384 | mFrameTimeline->onCommitNotComposited(); |
| 385 | |
| 386 | EXPECT_EQ(surfaceFrame1->getActuals().presentTime, 30); |
| 387 | ASSERT_NE(surfaceFrame1->getJankType(), std::nullopt); |
| 388 | EXPECT_EQ(*surfaceFrame1->getJankType(), JankType::None); |
| 389 | ASSERT_NE(surfaceFrame1->getJankSeverityType(), std::nullopt); |
| 390 | EXPECT_EQ(*surfaceFrame1->getJankSeverityType(), JankSeverityType::None); |
| 391 | |
| 392 | mFrameTimeline->setSfWakeUp(sfToken1, 22, RR_11, RR_11); |
| 393 | surfaceFrame2->setPresentState(SurfaceFrame::PresentState::Presented); |
| 394 | mFrameTimeline->addSurfaceFrame(surfaceFrame2); |
| 395 | mFrameTimeline->setSfPresent(26, presentFence1); |
| 396 | |
| 397 | auto displayFrame = getDisplayFrame(0); |
| 398 | auto& presentedSurfaceFrame2 = getSurfaceFrame(0, 0); |
| 399 | presentFence1->signalForTest(42); |
| 400 | |
| 401 | // Fences haven't been flushed yet, so it should be 0 |
| 402 | EXPECT_EQ(displayFrame->getActuals().presentTime, 0); |
| 403 | EXPECT_EQ(presentedSurfaceFrame2.getActuals().presentTime, 0); |
| 404 | |
| 405 | addEmptyDisplayFrame(); |
| 406 | |
| 407 | // Fences have flushed, so the present timestamps should be updated |
| 408 | EXPECT_EQ(displayFrame->getActuals().presentTime, 42); |
| 409 | EXPECT_EQ(presentedSurfaceFrame2.getActuals().presentTime, 42); |
| 410 | EXPECT_NE(surfaceFrame2->getJankType(), std::nullopt); |
| 411 | EXPECT_NE(surfaceFrame2->getJankSeverityType(), std::nullopt); |
| 412 | } |
| 413 | |
Adithya Srinivasan | f279e04 | 2020-08-17 14:56:27 -0700 | [diff] [blame] | 414 | TEST_F(FrameTimelineTest, displayFramesSlidingWindowMovesAfterLimit) { |
| 415 | // Insert kMaxDisplayFrames' count of DisplayFrames to fill the deque |
| 416 | int frameTimeFactor = 0; |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 417 | // Layer specific increment |
Alec Mouri | 363faf0 | 2021-01-29 16:34:55 -0800 | [diff] [blame] | 418 | EXPECT_CALL(*mTimeStats, incrementJankyFrames(_)) |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 419 | .Times(static_cast<int32_t>(*maxDisplayFrames)); |
Adithya Srinivasan | 2d73632 | 2020-10-01 16:53:48 -0700 | [diff] [blame] | 420 | for (size_t i = 0; i < *maxDisplayFrames; i++) { |
Adithya Srinivasan | f279e04 | 2020-08-17 14:56:27 -0700 | [diff] [blame] | 421 | auto presentFence = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
| 422 | int64_t surfaceFrameToken = mTokenManager->generateTokenForPredictions( |
| 423 | {10 + frameTimeFactor, 20 + frameTimeFactor, 30 + frameTimeFactor}); |
| 424 | int64_t sfToken = mTokenManager->generateTokenForPredictions( |
| 425 | {22 + frameTimeFactor, 26 + frameTimeFactor, 30 + frameTimeFactor}); |
Huihong Luo | 3bdef86 | 2022-03-03 11:57:19 -0800 | [diff] [blame] | 426 | FrameTimelineInfo ftInfo; |
| 427 | ftInfo.vsyncId = surfaceFrameToken; |
| 428 | ftInfo.inputEventId = sInputEventId; |
Alec Mouri | 9a29e67 | 2020-09-14 12:39:14 -0700 | [diff] [blame] | 429 | auto surfaceFrame = |
Huihong Luo | 3bdef86 | 2022-03-03 11:57:19 -0800 | [diff] [blame] | 430 | mFrameTimeline->createSurfaceFrameForToken(ftInfo, sPidOne, sUidOne, sLayerIdOne, |
Adithya Srinivasan | 785addd | 2021-03-09 00:38:00 +0000 | [diff] [blame] | 431 | sLayerNameOne, sLayerNameOne, |
Adithya Srinivasan | 58069dc | 2021-06-04 20:37:02 +0000 | [diff] [blame] | 432 | /*isBuffer*/ true, sGameMode); |
Pascal Muetschard | ac7bcd9 | 2023-10-03 15:05:36 +0200 | [diff] [blame] | 433 | mFrameTimeline->setSfWakeUp(sfToken, 22 + frameTimeFactor, RR_11, RR_11); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 434 | surfaceFrame->setPresentState(SurfaceFrame::PresentState::Presented); |
| 435 | mFrameTimeline->addSurfaceFrame(surfaceFrame); |
Adithya Srinivasan | f279e04 | 2020-08-17 14:56:27 -0700 | [diff] [blame] | 436 | mFrameTimeline->setSfPresent(27 + frameTimeFactor, presentFence); |
| 437 | presentFence->signalForTest(32 + frameTimeFactor); |
| 438 | frameTimeFactor += 30; |
| 439 | } |
| 440 | auto displayFrame0 = getDisplayFrame(0); |
| 441 | |
| 442 | // The 0th Display Frame should have actuals 22, 27, 32 |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 443 | EXPECT_EQ(compareTimelineItems(displayFrame0->getActuals(), TimelineItem(22, 27, 32)), true); |
Adithya Srinivasan | f279e04 | 2020-08-17 14:56:27 -0700 | [diff] [blame] | 444 | |
| 445 | // Add one more display frame |
| 446 | auto presentFence = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
| 447 | int64_t surfaceFrameToken = mTokenManager->generateTokenForPredictions( |
| 448 | {10 + frameTimeFactor, 20 + frameTimeFactor, 30 + frameTimeFactor}); |
| 449 | int64_t sfToken = mTokenManager->generateTokenForPredictions( |
| 450 | {22 + frameTimeFactor, 26 + frameTimeFactor, 30 + frameTimeFactor}); |
Huihong Luo | 3bdef86 | 2022-03-03 11:57:19 -0800 | [diff] [blame] | 451 | FrameTimelineInfo ftInfo; |
| 452 | ftInfo.vsyncId = surfaceFrameToken; |
| 453 | ftInfo.inputEventId = sInputEventId; |
Alec Mouri | 9a29e67 | 2020-09-14 12:39:14 -0700 | [diff] [blame] | 454 | auto surfaceFrame = |
Huihong Luo | 3bdef86 | 2022-03-03 11:57:19 -0800 | [diff] [blame] | 455 | mFrameTimeline->createSurfaceFrameForToken(ftInfo, sPidOne, sUidOne, sLayerIdOne, |
| 456 | sLayerNameOne, sLayerNameOne, |
| 457 | /*isBuffer*/ true, sGameMode); |
Pascal Muetschard | ac7bcd9 | 2023-10-03 15:05:36 +0200 | [diff] [blame] | 458 | mFrameTimeline->setSfWakeUp(sfToken, 22 + frameTimeFactor, RR_11, RR_11); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 459 | surfaceFrame->setPresentState(SurfaceFrame::PresentState::Presented); |
| 460 | mFrameTimeline->addSurfaceFrame(surfaceFrame); |
Adithya Srinivasan | f279e04 | 2020-08-17 14:56:27 -0700 | [diff] [blame] | 461 | mFrameTimeline->setSfPresent(27 + frameTimeFactor, presentFence); |
| 462 | presentFence->signalForTest(32 + frameTimeFactor); |
| 463 | displayFrame0 = getDisplayFrame(0); |
| 464 | |
| 465 | // The window should have slided by 1 now and the previous 0th display frame |
| 466 | // should have been removed from the deque |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 467 | EXPECT_EQ(compareTimelineItems(displayFrame0->getActuals(), TimelineItem(52, 57, 62)), true); |
Pascal Mütschard | d56514e | 2024-05-24 17:37:13 +0200 | [diff] [blame] | 468 | |
| 469 | EXPECT_EQ(getLayerOneJankData().size(), *maxDisplayFrames); |
Adithya Srinivasan | f279e04 | 2020-08-17 14:56:27 -0700 | [diff] [blame] | 470 | } |
| 471 | |
Ady Abraham | 7f8a1e6 | 2020-09-28 16:09:35 -0700 | [diff] [blame] | 472 | TEST_F(FrameTimelineTest, surfaceFrameEndTimeAcquireFenceAfterQueue) { |
Adithya Srinivasan | 58069dc | 2021-06-04 20:37:02 +0000 | [diff] [blame] | 473 | auto surfaceFrame = mFrameTimeline->createSurfaceFrameForToken({}, sPidOne, 0, sLayerIdOne, |
| 474 | "acquireFenceAfterQueue", |
| 475 | "acquireFenceAfterQueue", |
| 476 | /*isBuffer*/ true, sGameMode); |
Ady Abraham | 7f8a1e6 | 2020-09-28 16:09:35 -0700 | [diff] [blame] | 477 | surfaceFrame->setActualQueueTime(123); |
| 478 | surfaceFrame->setAcquireFenceTime(456); |
| 479 | EXPECT_EQ(surfaceFrame->getActuals().endTime, 456); |
| 480 | } |
| 481 | |
Vishnu Nair | bd7d07e | 2024-07-08 13:37:11 -0700 | [diff] [blame] | 482 | TEST_F(FrameTimelineTest, surfaceFrameEndTimeAcquireFenceUnsignaled) { |
| 483 | auto surfaceFrame = mFrameTimeline->createSurfaceFrameForToken({}, sPidOne, 0, sLayerIdOne, |
| 484 | "acquireFenceAfterQueue", |
| 485 | "acquireFenceAfterQueue", |
| 486 | /*isBuffer*/ true, sGameMode); |
| 487 | surfaceFrame->setActualQueueTime(123); |
| 488 | surfaceFrame->setAcquireFenceTime(Fence::SIGNAL_TIME_PENDING); |
| 489 | EXPECT_EQ(surfaceFrame->getActuals().endTime, 123); |
| 490 | } |
| 491 | |
Ady Abraham | 7f8a1e6 | 2020-09-28 16:09:35 -0700 | [diff] [blame] | 492 | TEST_F(FrameTimelineTest, surfaceFrameEndTimeAcquireFenceBeforeQueue) { |
Adithya Srinivasan | 58069dc | 2021-06-04 20:37:02 +0000 | [diff] [blame] | 493 | auto surfaceFrame = mFrameTimeline->createSurfaceFrameForToken({}, sPidOne, 0, sLayerIdOne, |
| 494 | "acquireFenceAfterQueue", |
| 495 | "acquireFenceAfterQueue", |
| 496 | /*isBuffer*/ true, sGameMode); |
Ady Abraham | 7f8a1e6 | 2020-09-28 16:09:35 -0700 | [diff] [blame] | 497 | surfaceFrame->setActualQueueTime(456); |
| 498 | surfaceFrame->setAcquireFenceTime(123); |
| 499 | EXPECT_EQ(surfaceFrame->getActuals().endTime, 456); |
| 500 | } |
| 501 | |
Adithya Srinivasan | 2d73632 | 2020-10-01 16:53:48 -0700 | [diff] [blame] | 502 | TEST_F(FrameTimelineTest, setMaxDisplayFramesSetsSizeProperly) { |
| 503 | auto presentFence = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
| 504 | presentFence->signalForTest(2); |
| 505 | |
| 506 | // Size shouldn't exceed maxDisplayFrames - 64 |
| 507 | for (size_t i = 0; i < *maxDisplayFrames + 10; i++) { |
Adithya Srinivasan | 9febda8 | 2020-10-19 10:49:41 -0700 | [diff] [blame] | 508 | auto surfaceFrame = |
Alec Mouri | adebf5c | 2021-01-05 12:57:36 -0800 | [diff] [blame] | 509 | mFrameTimeline->createSurfaceFrameForToken({}, sPidOne, sUidOne, sLayerIdOne, |
Adithya Srinivasan | 785addd | 2021-03-09 00:38:00 +0000 | [diff] [blame] | 510 | sLayerNameOne, sLayerNameOne, |
Adithya Srinivasan | 58069dc | 2021-06-04 20:37:02 +0000 | [diff] [blame] | 511 | /*isBuffer*/ true, sGameMode); |
Adithya Srinivasan | 2d73632 | 2020-10-01 16:53:48 -0700 | [diff] [blame] | 512 | int64_t sfToken = mTokenManager->generateTokenForPredictions({22, 26, 30}); |
Pascal Muetschard | ac7bcd9 | 2023-10-03 15:05:36 +0200 | [diff] [blame] | 513 | mFrameTimeline->setSfWakeUp(sfToken, 22, RR_11, RR_11); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 514 | surfaceFrame->setPresentState(SurfaceFrame::PresentState::Presented); |
| 515 | mFrameTimeline->addSurfaceFrame(surfaceFrame); |
Adithya Srinivasan | 2d73632 | 2020-10-01 16:53:48 -0700 | [diff] [blame] | 516 | mFrameTimeline->setSfPresent(27, presentFence); |
| 517 | } |
| 518 | EXPECT_EQ(getNumberOfDisplayFrames(), *maxDisplayFrames); |
| 519 | |
| 520 | // Increase the size to 256 |
| 521 | mFrameTimeline->setMaxDisplayFrames(256); |
Siarhei Vishniakou | fc434ac | 2021-01-13 10:28:00 -1000 | [diff] [blame] | 522 | EXPECT_EQ(*maxDisplayFrames, 256u); |
Adithya Srinivasan | 2d73632 | 2020-10-01 16:53:48 -0700 | [diff] [blame] | 523 | |
| 524 | for (size_t i = 0; i < *maxDisplayFrames + 10; i++) { |
Adithya Srinivasan | 9febda8 | 2020-10-19 10:49:41 -0700 | [diff] [blame] | 525 | auto surfaceFrame = |
Alec Mouri | adebf5c | 2021-01-05 12:57:36 -0800 | [diff] [blame] | 526 | mFrameTimeline->createSurfaceFrameForToken({}, sPidOne, sUidOne, sLayerIdOne, |
Adithya Srinivasan | 785addd | 2021-03-09 00:38:00 +0000 | [diff] [blame] | 527 | sLayerNameOne, sLayerNameOne, |
Adithya Srinivasan | 58069dc | 2021-06-04 20:37:02 +0000 | [diff] [blame] | 528 | /*isBuffer*/ true, sGameMode); |
Adithya Srinivasan | 2d73632 | 2020-10-01 16:53:48 -0700 | [diff] [blame] | 529 | int64_t sfToken = mTokenManager->generateTokenForPredictions({22, 26, 30}); |
Pascal Muetschard | ac7bcd9 | 2023-10-03 15:05:36 +0200 | [diff] [blame] | 530 | mFrameTimeline->setSfWakeUp(sfToken, 22, RR_11, RR_11); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 531 | surfaceFrame->setPresentState(SurfaceFrame::PresentState::Presented); |
| 532 | mFrameTimeline->addSurfaceFrame(surfaceFrame); |
Adithya Srinivasan | 2d73632 | 2020-10-01 16:53:48 -0700 | [diff] [blame] | 533 | mFrameTimeline->setSfPresent(27, presentFence); |
| 534 | } |
| 535 | EXPECT_EQ(getNumberOfDisplayFrames(), *maxDisplayFrames); |
| 536 | |
| 537 | // Shrink the size to 128 |
| 538 | mFrameTimeline->setMaxDisplayFrames(128); |
Siarhei Vishniakou | fc434ac | 2021-01-13 10:28:00 -1000 | [diff] [blame] | 539 | EXPECT_EQ(*maxDisplayFrames, 128u); |
Adithya Srinivasan | 2d73632 | 2020-10-01 16:53:48 -0700 | [diff] [blame] | 540 | |
| 541 | for (size_t i = 0; i < *maxDisplayFrames + 10; i++) { |
Adithya Srinivasan | 9febda8 | 2020-10-19 10:49:41 -0700 | [diff] [blame] | 542 | auto surfaceFrame = |
Alec Mouri | adebf5c | 2021-01-05 12:57:36 -0800 | [diff] [blame] | 543 | mFrameTimeline->createSurfaceFrameForToken({}, sPidOne, sUidOne, sLayerIdOne, |
Adithya Srinivasan | 785addd | 2021-03-09 00:38:00 +0000 | [diff] [blame] | 544 | sLayerNameOne, sLayerNameOne, |
Adithya Srinivasan | 58069dc | 2021-06-04 20:37:02 +0000 | [diff] [blame] | 545 | /*isBuffer*/ true, sGameMode); |
Adithya Srinivasan | 2d73632 | 2020-10-01 16:53:48 -0700 | [diff] [blame] | 546 | int64_t sfToken = mTokenManager->generateTokenForPredictions({22, 26, 30}); |
Pascal Muetschard | ac7bcd9 | 2023-10-03 15:05:36 +0200 | [diff] [blame] | 547 | mFrameTimeline->setSfWakeUp(sfToken, 22, RR_11, RR_11); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 548 | surfaceFrame->setPresentState(SurfaceFrame::PresentState::Presented); |
| 549 | mFrameTimeline->addSurfaceFrame(surfaceFrame); |
Adithya Srinivasan | 2d73632 | 2020-10-01 16:53:48 -0700 | [diff] [blame] | 550 | mFrameTimeline->setSfPresent(27, presentFence); |
| 551 | } |
| 552 | EXPECT_EQ(getNumberOfDisplayFrames(), *maxDisplayFrames); |
| 553 | } |
Alec Mouri | 9a29e67 | 2020-09-14 12:39:14 -0700 | [diff] [blame] | 554 | |
Adithya Srinivasan | 7c4ac7a | 2021-03-08 23:48:03 +0000 | [diff] [blame] | 555 | TEST_F(FrameTimelineTest, presentFenceSignaled_invalidSignalTime) { |
Pascal Muetschard | ac7bcd9 | 2023-10-03 15:05:36 +0200 | [diff] [blame] | 556 | Fps refreshRate = RR_11; |
Adithya Srinivasan | 7c4ac7a | 2021-03-08 23:48:03 +0000 | [diff] [blame] | 557 | |
| 558 | auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
| 559 | int64_t surfaceFrameToken1 = mTokenManager->generateTokenForPredictions({10, 20, 60}); |
| 560 | int64_t sfToken1 = mTokenManager->generateTokenForPredictions({52, 60, 60}); |
Huihong Luo | 3bdef86 | 2022-03-03 11:57:19 -0800 | [diff] [blame] | 561 | FrameTimelineInfo ftInfo; |
| 562 | ftInfo.vsyncId = surfaceFrameToken1; |
| 563 | ftInfo.inputEventId = sInputEventId; |
Adithya Srinivasan | 7c4ac7a | 2021-03-08 23:48:03 +0000 | [diff] [blame] | 564 | |
| 565 | auto surfaceFrame1 = |
Huihong Luo | 3bdef86 | 2022-03-03 11:57:19 -0800 | [diff] [blame] | 566 | mFrameTimeline->createSurfaceFrameForToken(ftInfo, sPidOne, sUidOne, sLayerIdOne, |
| 567 | sLayerNameOne, sLayerNameOne, |
| 568 | /*isBuffer*/ true, sGameMode); |
Pascal Muetschard | ac7bcd9 | 2023-10-03 15:05:36 +0200 | [diff] [blame] | 569 | mFrameTimeline->setSfWakeUp(sfToken1, 52, refreshRate, refreshRate); |
Adithya Srinivasan | 7c4ac7a | 2021-03-08 23:48:03 +0000 | [diff] [blame] | 570 | surfaceFrame1->setAcquireFenceTime(20); |
| 571 | surfaceFrame1->setPresentState(SurfaceFrame::PresentState::Presented); |
| 572 | mFrameTimeline->addSurfaceFrame(surfaceFrame1); |
| 573 | |
| 574 | mFrameTimeline->setSfPresent(59, presentFence1); |
| 575 | presentFence1->signalForTest(-1); |
| 576 | addEmptyDisplayFrame(); |
| 577 | |
| 578 | auto displayFrame0 = getDisplayFrame(0); |
Ady Abraham | fcb1686 | 2022-10-10 14:35:21 -0700 | [diff] [blame] | 579 | EXPECT_EQ(displayFrame0->getActuals().presentTime, 59); |
Ady Abraham | b1e10d1 | 2023-03-13 15:23:54 -0700 | [diff] [blame] | 580 | EXPECT_EQ(displayFrame0->getJankType(), JankType::Unknown | JankType::DisplayHAL); |
Ying Wei | 96eb535 | 2023-11-21 17:37:21 +0000 | [diff] [blame] | 581 | EXPECT_EQ(displayFrame0->getJankSeverityType(), JankSeverityType::Unknown); |
Adithya Srinivasan | 7c4ac7a | 2021-03-08 23:48:03 +0000 | [diff] [blame] | 582 | EXPECT_EQ(surfaceFrame1->getActuals().presentTime, -1); |
| 583 | EXPECT_EQ(surfaceFrame1->getJankType(), JankType::Unknown); |
Ying Wei | 96eb535 | 2023-11-21 17:37:21 +0000 | [diff] [blame] | 584 | EXPECT_EQ(surfaceFrame1->getJankSeverityType(), JankSeverityType::Unknown); |
Adithya Srinivasan | 7c4ac7a | 2021-03-08 23:48:03 +0000 | [diff] [blame] | 585 | } |
| 586 | |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 587 | // Tests related to TimeStats |
Adithya Srinivasan | 7c4ac7a | 2021-03-08 23:48:03 +0000 | [diff] [blame] | 588 | TEST_F(FrameTimelineTest, presentFenceSignaled_doesNotReportForInvalidTokens) { |
Pascal Muetschard | ac7bcd9 | 2023-10-03 15:05:36 +0200 | [diff] [blame] | 589 | Fps refreshRate = RR_11; |
Adithya Srinivasan | 7c4ac7a | 2021-03-08 23:48:03 +0000 | [diff] [blame] | 590 | EXPECT_CALL(*mTimeStats, incrementJankyFrames(_)).Times(0); |
| 591 | auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
| 592 | int64_t surfaceFrameToken1 = -1; |
| 593 | int64_t sfToken1 = -1; |
Huihong Luo | 3bdef86 | 2022-03-03 11:57:19 -0800 | [diff] [blame] | 594 | FrameTimelineInfo ftInfo; |
| 595 | ftInfo.vsyncId = surfaceFrameToken1; |
| 596 | ftInfo.inputEventId = sInputEventId; |
Adithya Srinivasan | 7c4ac7a | 2021-03-08 23:48:03 +0000 | [diff] [blame] | 597 | |
| 598 | auto surfaceFrame1 = |
Huihong Luo | 3bdef86 | 2022-03-03 11:57:19 -0800 | [diff] [blame] | 599 | mFrameTimeline->createSurfaceFrameForToken(ftInfo, sPidOne, sUidOne, sLayerIdOne, |
| 600 | sLayerNameOne, sLayerNameOne, |
| 601 | /*isBuffer*/ true, sGameMode); |
Pascal Muetschard | ac7bcd9 | 2023-10-03 15:05:36 +0200 | [diff] [blame] | 602 | mFrameTimeline->setSfWakeUp(sfToken1, 52, refreshRate, refreshRate); |
Adithya Srinivasan | 7c4ac7a | 2021-03-08 23:48:03 +0000 | [diff] [blame] | 603 | surfaceFrame1->setAcquireFenceTime(20); |
| 604 | surfaceFrame1->setPresentState(SurfaceFrame::PresentState::Presented); |
| 605 | mFrameTimeline->addSurfaceFrame(surfaceFrame1); |
| 606 | presentFence1->signalForTest(70); |
| 607 | |
| 608 | mFrameTimeline->setSfPresent(59, presentFence1); |
Pascal Mütschard | d56514e | 2024-05-24 17:37:13 +0200 | [diff] [blame] | 609 | |
| 610 | EXPECT_EQ(getLayerOneJankData().size(), 0u); |
Adithya Srinivasan | 7c4ac7a | 2021-03-08 23:48:03 +0000 | [diff] [blame] | 611 | } |
| 612 | |
Alec Mouri | 9a29e67 | 2020-09-14 12:39:14 -0700 | [diff] [blame] | 613 | TEST_F(FrameTimelineTest, presentFenceSignaled_reportsLongSfCpu) { |
Pascal Muetschard | ac7bcd9 | 2023-10-03 15:05:36 +0200 | [diff] [blame] | 614 | Fps refreshRate = RR_11; |
Alec Mouri | 9a29e67 | 2020-09-14 12:39:14 -0700 | [diff] [blame] | 615 | EXPECT_CALL(*mTimeStats, |
Alec Mouri | 363faf0 | 2021-01-29 16:34:55 -0800 | [diff] [blame] | 616 | incrementJankyFrames( |
| 617 | TimeStats::JankyFramesInfo{refreshRate, std::nullopt, sUidOne, |
Adithya Srinivasan | 58069dc | 2021-06-04 20:37:02 +0000 | [diff] [blame] | 618 | sLayerNameOne, sGameMode, |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 619 | JankType::SurfaceFlingerCpuDeadlineMissed, 2, 10, |
Alec Mouri | 363faf0 | 2021-01-29 16:34:55 -0800 | [diff] [blame] | 620 | 0})); |
Alec Mouri | 9a29e67 | 2020-09-14 12:39:14 -0700 | [diff] [blame] | 621 | auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 622 | int64_t surfaceFrameToken1 = mTokenManager->generateTokenForPredictions({10, 20, 60}); |
| 623 | int64_t sfToken1 = mTokenManager->generateTokenForPredictions({52, 60, 60}); |
Huihong Luo | 3bdef86 | 2022-03-03 11:57:19 -0800 | [diff] [blame] | 624 | FrameTimelineInfo ftInfo; |
| 625 | ftInfo.vsyncId = surfaceFrameToken1; |
| 626 | ftInfo.inputEventId = sInputEventId; |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 627 | |
Alec Mouri | 9a29e67 | 2020-09-14 12:39:14 -0700 | [diff] [blame] | 628 | auto surfaceFrame1 = |
Huihong Luo | 3bdef86 | 2022-03-03 11:57:19 -0800 | [diff] [blame] | 629 | mFrameTimeline->createSurfaceFrameForToken(ftInfo, sPidOne, sUidOne, sLayerIdOne, |
| 630 | sLayerNameOne, sLayerNameOne, |
| 631 | /*isBuffer*/ true, sGameMode); |
Pascal Muetschard | ac7bcd9 | 2023-10-03 15:05:36 +0200 | [diff] [blame] | 632 | mFrameTimeline->setSfWakeUp(sfToken1, 52, refreshRate, refreshRate); |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 633 | surfaceFrame1->setAcquireFenceTime(20); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 634 | surfaceFrame1->setPresentState(SurfaceFrame::PresentState::Presented); |
| 635 | mFrameTimeline->addSurfaceFrame(surfaceFrame1); |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 636 | presentFence1->signalForTest(70); |
Alec Mouri | 9a29e67 | 2020-09-14 12:39:14 -0700 | [diff] [blame] | 637 | |
Adithya Srinivasan | 82eef32 | 2021-04-10 00:06:04 +0000 | [diff] [blame] | 638 | mFrameTimeline->setSfPresent(62, presentFence1); |
Pascal Mütschard | d56514e | 2024-05-24 17:37:13 +0200 | [diff] [blame] | 639 | |
| 640 | auto jankData = getLayerOneJankData(); |
| 641 | EXPECT_EQ(jankData.size(), 1u); |
| 642 | EXPECT_EQ(jankData[0].jankType, JankType::SurfaceFlingerCpuDeadlineMissed); |
Alec Mouri | 9a29e67 | 2020-09-14 12:39:14 -0700 | [diff] [blame] | 643 | } |
| 644 | |
Adithya Srinivasan | 36b01af | 2021-04-07 22:29:47 +0000 | [diff] [blame] | 645 | TEST_F(FrameTimelineTest, presentFenceSignaled_reportsLongSfGpu) { |
Pascal Muetschard | ac7bcd9 | 2023-10-03 15:05:36 +0200 | [diff] [blame] | 646 | Fps refreshRate = RR_11; |
Adithya Srinivasan | 36b01af | 2021-04-07 22:29:47 +0000 | [diff] [blame] | 647 | EXPECT_CALL(*mTimeStats, |
| 648 | incrementJankyFrames( |
| 649 | TimeStats::JankyFramesInfo{refreshRate, std::nullopt, sUidOne, |
Adithya Srinivasan | 58069dc | 2021-06-04 20:37:02 +0000 | [diff] [blame] | 650 | sLayerNameOne, sGameMode, |
Adithya Srinivasan | 36b01af | 2021-04-07 22:29:47 +0000 | [diff] [blame] | 651 | JankType::SurfaceFlingerGpuDeadlineMissed, 4, 10, |
| 652 | 0})); |
| 653 | auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
| 654 | auto gpuFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
| 655 | int64_t surfaceFrameToken1 = mTokenManager->generateTokenForPredictions({10, 20, 60}); |
| 656 | int64_t sfToken1 = mTokenManager->generateTokenForPredictions({52, 60, 60}); |
Huihong Luo | 3bdef86 | 2022-03-03 11:57:19 -0800 | [diff] [blame] | 657 | FrameTimelineInfo ftInfo; |
| 658 | ftInfo.vsyncId = surfaceFrameToken1; |
| 659 | ftInfo.inputEventId = sInputEventId; |
Adithya Srinivasan | 36b01af | 2021-04-07 22:29:47 +0000 | [diff] [blame] | 660 | |
| 661 | auto surfaceFrame1 = |
Huihong Luo | 3bdef86 | 2022-03-03 11:57:19 -0800 | [diff] [blame] | 662 | mFrameTimeline->createSurfaceFrameForToken(ftInfo, sPidOne, sUidOne, sLayerIdOne, |
| 663 | sLayerNameOne, sLayerNameOne, |
| 664 | /*isBuffer*/ true, sGameMode); |
Pascal Muetschard | ac7bcd9 | 2023-10-03 15:05:36 +0200 | [diff] [blame] | 665 | mFrameTimeline->setSfWakeUp(sfToken1, 52, refreshRate, refreshRate); |
Adithya Srinivasan | 36b01af | 2021-04-07 22:29:47 +0000 | [diff] [blame] | 666 | surfaceFrame1->setAcquireFenceTime(20); |
| 667 | surfaceFrame1->setPresentState(SurfaceFrame::PresentState::Presented); |
| 668 | mFrameTimeline->addSurfaceFrame(surfaceFrame1); |
| 669 | gpuFence1->signalForTest(64); |
| 670 | presentFence1->signalForTest(70); |
| 671 | |
| 672 | mFrameTimeline->setSfPresent(59, presentFence1, gpuFence1); |
Pascal Mütschard | d56514e | 2024-05-24 17:37:13 +0200 | [diff] [blame] | 673 | |
| 674 | auto jankData = getLayerOneJankData(); |
| 675 | EXPECT_EQ(jankData.size(), 1u); |
| 676 | EXPECT_EQ(jankData[0].jankType, JankType::SurfaceFlingerGpuDeadlineMissed); |
Adithya Srinivasan | 36b01af | 2021-04-07 22:29:47 +0000 | [diff] [blame] | 677 | } |
| 678 | |
Alec Mouri | 9a29e67 | 2020-09-14 12:39:14 -0700 | [diff] [blame] | 679 | TEST_F(FrameTimelineTest, presentFenceSignaled_reportsDisplayMiss) { |
Pascal Muetschard | ac7bcd9 | 2023-10-03 15:05:36 +0200 | [diff] [blame] | 680 | Fps refreshRate = RR_30; |
Alec Mouri | 9a29e67 | 2020-09-14 12:39:14 -0700 | [diff] [blame] | 681 | EXPECT_CALL(*mTimeStats, |
Alec Mouri | 363faf0 | 2021-01-29 16:34:55 -0800 | [diff] [blame] | 682 | incrementJankyFrames(TimeStats::JankyFramesInfo{refreshRate, std::nullopt, sUidOne, |
Adithya Srinivasan | 58069dc | 2021-06-04 20:37:02 +0000 | [diff] [blame] | 683 | sLayerNameOne, sGameMode, |
| 684 | JankType::DisplayHAL, -4, 0, 0})); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 685 | |
Alec Mouri | 9a29e67 | 2020-09-14 12:39:14 -0700 | [diff] [blame] | 686 | auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 687 | int64_t surfaceFrameToken1 = mTokenManager->generateTokenForPredictions({10, 20, 60}); |
| 688 | int64_t sfToken1 = mTokenManager->generateTokenForPredictions({52, 60, 60}); |
Huihong Luo | 3bdef86 | 2022-03-03 11:57:19 -0800 | [diff] [blame] | 689 | FrameTimelineInfo ftInfo; |
| 690 | ftInfo.vsyncId = surfaceFrameToken1; |
| 691 | ftInfo.inputEventId = sInputEventId; |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 692 | |
Alec Mouri | 9a29e67 | 2020-09-14 12:39:14 -0700 | [diff] [blame] | 693 | auto surfaceFrame1 = |
Huihong Luo | 3bdef86 | 2022-03-03 11:57:19 -0800 | [diff] [blame] | 694 | mFrameTimeline->createSurfaceFrameForToken(ftInfo, sPidOne, sUidOne, sLayerIdOne, |
| 695 | sLayerNameOne, sLayerNameOne, |
| 696 | /*isBuffer*/ true, sGameMode); |
Pascal Muetschard | ac7bcd9 | 2023-10-03 15:05:36 +0200 | [diff] [blame] | 697 | mFrameTimeline->setSfWakeUp(sfToken1, 52, refreshRate, refreshRate); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 698 | surfaceFrame1->setPresentState(SurfaceFrame::PresentState::Presented); |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 699 | surfaceFrame1->setAcquireFenceTime(20); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 700 | mFrameTimeline->addSurfaceFrame(surfaceFrame1); |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 701 | presentFence1->signalForTest(90); |
| 702 | mFrameTimeline->setSfPresent(56, presentFence1); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 703 | EXPECT_EQ(surfaceFrame1->getJankType(), JankType::DisplayHAL); |
Ying Wei | 96eb535 | 2023-11-21 17:37:21 +0000 | [diff] [blame] | 704 | EXPECT_EQ(surfaceFrame1->getJankSeverityType(), JankSeverityType::Full); |
Pascal Mütschard | d56514e | 2024-05-24 17:37:13 +0200 | [diff] [blame] | 705 | |
| 706 | auto jankData = getLayerOneJankData(); |
| 707 | EXPECT_EQ(jankData.size(), 1u); |
| 708 | EXPECT_EQ(jankData[0].jankType, JankType::DisplayHAL); |
Alec Mouri | 9a29e67 | 2020-09-14 12:39:14 -0700 | [diff] [blame] | 709 | } |
| 710 | |
| 711 | TEST_F(FrameTimelineTest, presentFenceSignaled_reportsAppMiss) { |
Dominik Laskowski | 6eab42d | 2021-09-13 14:34:13 -0700 | [diff] [blame] | 712 | Fps refreshRate = 11_Hz; |
Alec Mouri | 9a29e67 | 2020-09-14 12:39:14 -0700 | [diff] [blame] | 713 | EXPECT_CALL(*mTimeStats, |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 714 | incrementJankyFrames(TimeStats::JankyFramesInfo{refreshRate, std::nullopt, sUidOne, |
Adithya Srinivasan | 58069dc | 2021-06-04 20:37:02 +0000 | [diff] [blame] | 715 | sLayerNameOne, sGameMode, |
Adithya Srinivasan | 82eef32 | 2021-04-10 00:06:04 +0000 | [diff] [blame] | 716 | JankType::AppDeadlineMissed, -4, 0, |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 717 | 25})); |
Alec Mouri | 9a29e67 | 2020-09-14 12:39:14 -0700 | [diff] [blame] | 718 | auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 719 | int64_t surfaceFrameToken1 = mTokenManager->generateTokenForPredictions({10, 20, 60}); |
| 720 | int64_t sfToken1 = mTokenManager->generateTokenForPredictions({82, 90, 90}); |
Huihong Luo | 3bdef86 | 2022-03-03 11:57:19 -0800 | [diff] [blame] | 721 | FrameTimelineInfo ftInfo; |
| 722 | ftInfo.vsyncId = surfaceFrameToken1; |
| 723 | ftInfo.inputEventId = sInputEventId; |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 724 | |
Alec Mouri | 9a29e67 | 2020-09-14 12:39:14 -0700 | [diff] [blame] | 725 | auto surfaceFrame1 = |
Huihong Luo | 3bdef86 | 2022-03-03 11:57:19 -0800 | [diff] [blame] | 726 | mFrameTimeline->createSurfaceFrameForToken(ftInfo, sPidOne, sUidOne, sLayerIdOne, |
| 727 | sLayerNameOne, sLayerNameOne, |
| 728 | /*isBuffer*/ true, sGameMode); |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 729 | surfaceFrame1->setAcquireFenceTime(45); |
Pascal Muetschard | ac7bcd9 | 2023-10-03 15:05:36 +0200 | [diff] [blame] | 730 | mFrameTimeline->setSfWakeUp(sfToken1, 52, refreshRate, refreshRate); |
Alec Mouri | 9a29e67 | 2020-09-14 12:39:14 -0700 | [diff] [blame] | 731 | |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 732 | surfaceFrame1->setPresentState(SurfaceFrame::PresentState::Presented); |
| 733 | mFrameTimeline->addSurfaceFrame(surfaceFrame1); |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 734 | presentFence1->signalForTest(90); |
| 735 | mFrameTimeline->setSfPresent(86, presentFence1); |
Jorim Jaggi | 9c03b50 | 2020-11-24 23:51:31 +0100 | [diff] [blame] | 736 | |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 737 | EXPECT_EQ(surfaceFrame1->getJankType(), JankType::AppDeadlineMissed); |
Ying Wei | 96eb535 | 2023-11-21 17:37:21 +0000 | [diff] [blame] | 738 | EXPECT_EQ(surfaceFrame1->getJankSeverityType(), JankSeverityType::Partial); |
Pascal Mütschard | d56514e | 2024-05-24 17:37:13 +0200 | [diff] [blame] | 739 | |
| 740 | auto jankData = getLayerOneJankData(); |
| 741 | EXPECT_EQ(jankData.size(), 1u); |
| 742 | EXPECT_EQ(jankData[0].jankType, JankType::AppDeadlineMissed); |
Alec Mouri | 9a29e67 | 2020-09-14 12:39:14 -0700 | [diff] [blame] | 743 | } |
| 744 | |
Adithya Srinivasan | ead1716 | 2021-02-18 02:17:37 +0000 | [diff] [blame] | 745 | TEST_F(FrameTimelineTest, presentFenceSignaled_reportsSfScheduling) { |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 746 | Fps refreshRate = Fps::fromPeriodNsecs(32); |
Adithya Srinivasan | ead1716 | 2021-02-18 02:17:37 +0000 | [diff] [blame] | 747 | EXPECT_CALL(*mTimeStats, |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 748 | incrementJankyFrames(TimeStats::JankyFramesInfo{refreshRate, std::nullopt, sUidOne, |
Adithya Srinivasan | 58069dc | 2021-06-04 20:37:02 +0000 | [diff] [blame] | 749 | sLayerNameOne, sGameMode, |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 750 | JankType::SurfaceFlingerScheduling, |
Adithya Srinivasan | 82eef32 | 2021-04-10 00:06:04 +0000 | [diff] [blame] | 751 | -4, 0, -10})); |
Adithya Srinivasan | ead1716 | 2021-02-18 02:17:37 +0000 | [diff] [blame] | 752 | auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 753 | int64_t surfaceFrameToken1 = mTokenManager->generateTokenForPredictions({40, 60, 92}); |
| 754 | int64_t sfToken1 = mTokenManager->generateTokenForPredictions({52, 60, 60}); |
Huihong Luo | 3bdef86 | 2022-03-03 11:57:19 -0800 | [diff] [blame] | 755 | FrameTimelineInfo ftInfo; |
| 756 | ftInfo.vsyncId = surfaceFrameToken1; |
| 757 | ftInfo.inputEventId = sInputEventId; |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 758 | |
Adithya Srinivasan | ead1716 | 2021-02-18 02:17:37 +0000 | [diff] [blame] | 759 | auto surfaceFrame1 = |
Huihong Luo | 3bdef86 | 2022-03-03 11:57:19 -0800 | [diff] [blame] | 760 | mFrameTimeline->createSurfaceFrameForToken(ftInfo, sPidOne, sUidOne, sLayerIdOne, |
| 761 | sLayerNameOne, sLayerNameOne, |
| 762 | /*isBuffer*/ true, sGameMode); |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 763 | surfaceFrame1->setAcquireFenceTime(50); |
Pascal Muetschard | ac7bcd9 | 2023-10-03 15:05:36 +0200 | [diff] [blame] | 764 | mFrameTimeline->setSfWakeUp(sfToken1, 52, refreshRate, refreshRate); |
Adithya Srinivasan | ead1716 | 2021-02-18 02:17:37 +0000 | [diff] [blame] | 765 | |
| 766 | surfaceFrame1->setPresentState(SurfaceFrame::PresentState::Presented); |
| 767 | mFrameTimeline->addSurfaceFrame(surfaceFrame1); |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 768 | presentFence1->signalForTest(60); |
| 769 | mFrameTimeline->setSfPresent(56, presentFence1); |
Adithya Srinivasan | ead1716 | 2021-02-18 02:17:37 +0000 | [diff] [blame] | 770 | |
| 771 | EXPECT_EQ(surfaceFrame1->getJankType(), JankType::SurfaceFlingerScheduling); |
Ying Wei | 96eb535 | 2023-11-21 17:37:21 +0000 | [diff] [blame] | 772 | EXPECT_EQ(surfaceFrame1->getJankSeverityType(), JankSeverityType::Full); |
Pascal Mütschard | d56514e | 2024-05-24 17:37:13 +0200 | [diff] [blame] | 773 | |
| 774 | auto jankData = getLayerOneJankData(); |
| 775 | EXPECT_EQ(jankData.size(), 1u); |
| 776 | EXPECT_EQ(jankData[0].jankType, JankType::SurfaceFlingerScheduling); |
Adithya Srinivasan | ead1716 | 2021-02-18 02:17:37 +0000 | [diff] [blame] | 777 | } |
| 778 | |
| 779 | TEST_F(FrameTimelineTest, presentFenceSignaled_reportsSfPredictionError) { |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 780 | Fps refreshRate = Fps::fromPeriodNsecs(16); |
Adithya Srinivasan | ead1716 | 2021-02-18 02:17:37 +0000 | [diff] [blame] | 781 | EXPECT_CALL(*mTimeStats, |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 782 | incrementJankyFrames(TimeStats::JankyFramesInfo{refreshRate, std::nullopt, sUidOne, |
Adithya Srinivasan | 58069dc | 2021-06-04 20:37:02 +0000 | [diff] [blame] | 783 | sLayerNameOne, sGameMode, |
Adithya Srinivasan | 82eef32 | 2021-04-10 00:06:04 +0000 | [diff] [blame] | 784 | JankType::PredictionError, -4, 5, |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 785 | 0})); |
Adithya Srinivasan | ead1716 | 2021-02-18 02:17:37 +0000 | [diff] [blame] | 786 | auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 787 | int64_t surfaceFrameToken1 = mTokenManager->generateTokenForPredictions({30, 40, 60}); |
| 788 | int64_t sfToken1 = mTokenManager->generateTokenForPredictions({52, 60, 60}); |
Huihong Luo | 3bdef86 | 2022-03-03 11:57:19 -0800 | [diff] [blame] | 789 | FrameTimelineInfo ftInfo; |
| 790 | ftInfo.vsyncId = surfaceFrameToken1; |
| 791 | ftInfo.inputEventId = sInputEventId; |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 792 | |
Adithya Srinivasan | ead1716 | 2021-02-18 02:17:37 +0000 | [diff] [blame] | 793 | auto surfaceFrame1 = |
Huihong Luo | 3bdef86 | 2022-03-03 11:57:19 -0800 | [diff] [blame] | 794 | mFrameTimeline->createSurfaceFrameForToken(ftInfo, sPidOne, sUidOne, sLayerIdOne, |
| 795 | sLayerNameOne, sLayerNameOne, |
| 796 | /*isBuffer*/ true, sGameMode); |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 797 | surfaceFrame1->setAcquireFenceTime(40); |
Pascal Muetschard | ac7bcd9 | 2023-10-03 15:05:36 +0200 | [diff] [blame] | 798 | mFrameTimeline->setSfWakeUp(sfToken1, 52, refreshRate, refreshRate); |
Adithya Srinivasan | ead1716 | 2021-02-18 02:17:37 +0000 | [diff] [blame] | 799 | |
| 800 | surfaceFrame1->setPresentState(SurfaceFrame::PresentState::Presented); |
| 801 | mFrameTimeline->addSurfaceFrame(surfaceFrame1); |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 802 | presentFence1->signalForTest(65); |
| 803 | mFrameTimeline->setSfPresent(56, presentFence1); |
Adithya Srinivasan | ead1716 | 2021-02-18 02:17:37 +0000 | [diff] [blame] | 804 | |
| 805 | EXPECT_EQ(surfaceFrame1->getJankType(), JankType::PredictionError); |
Ying Wei | 96eb535 | 2023-11-21 17:37:21 +0000 | [diff] [blame] | 806 | EXPECT_EQ(surfaceFrame1->getJankSeverityType(), JankSeverityType::Partial); |
Pascal Mütschard | d56514e | 2024-05-24 17:37:13 +0200 | [diff] [blame] | 807 | |
| 808 | auto jankData = getLayerOneJankData(); |
| 809 | EXPECT_EQ(jankData.size(), 1u); |
| 810 | EXPECT_EQ(jankData[0].jankType, JankType::PredictionError); |
Adithya Srinivasan | ead1716 | 2021-02-18 02:17:37 +0000 | [diff] [blame] | 811 | } |
| 812 | |
| 813 | TEST_F(FrameTimelineTest, presentFenceSignaled_reportsAppBufferStuffing) { |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 814 | Fps refreshRate = Fps::fromPeriodNsecs(32); |
Adithya Srinivasan | ead1716 | 2021-02-18 02:17:37 +0000 | [diff] [blame] | 815 | EXPECT_CALL(*mTimeStats, |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 816 | incrementJankyFrames(TimeStats::JankyFramesInfo{refreshRate, std::nullopt, sUidOne, |
Adithya Srinivasan | 58069dc | 2021-06-04 20:37:02 +0000 | [diff] [blame] | 817 | sLayerNameOne, sGameMode, |
Adithya Srinivasan | 82eef32 | 2021-04-10 00:06:04 +0000 | [diff] [blame] | 818 | JankType::BufferStuffing, -4, 0, |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 819 | 0})); |
Adithya Srinivasan | ead1716 | 2021-02-18 02:17:37 +0000 | [diff] [blame] | 820 | auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 821 | int64_t surfaceFrameToken1 = mTokenManager->generateTokenForPredictions({30, 40, 58}); |
| 822 | int64_t sfToken1 = mTokenManager->generateTokenForPredictions({82, 90, 90}); |
Huihong Luo | 3bdef86 | 2022-03-03 11:57:19 -0800 | [diff] [blame] | 823 | FrameTimelineInfo ftInfo; |
| 824 | ftInfo.vsyncId = surfaceFrameToken1; |
| 825 | ftInfo.inputEventId = sInputEventId; |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 826 | |
Adithya Srinivasan | ead1716 | 2021-02-18 02:17:37 +0000 | [diff] [blame] | 827 | auto surfaceFrame1 = |
Huihong Luo | 3bdef86 | 2022-03-03 11:57:19 -0800 | [diff] [blame] | 828 | mFrameTimeline->createSurfaceFrameForToken(ftInfo, sPidOne, sUidOne, sLayerIdOne, |
| 829 | sLayerNameOne, sLayerNameOne, |
| 830 | /*isBuffer*/ true, sGameMode); |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 831 | surfaceFrame1->setAcquireFenceTime(40); |
Pascal Muetschard | ac7bcd9 | 2023-10-03 15:05:36 +0200 | [diff] [blame] | 832 | mFrameTimeline->setSfWakeUp(sfToken1, 82, refreshRate, refreshRate); |
Adithya Srinivasan | ead1716 | 2021-02-18 02:17:37 +0000 | [diff] [blame] | 833 | |
| 834 | surfaceFrame1->setPresentState(SurfaceFrame::PresentState::Presented, |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 835 | /*previousLatchTime*/ 56); |
Adithya Srinivasan | ead1716 | 2021-02-18 02:17:37 +0000 | [diff] [blame] | 836 | mFrameTimeline->addSurfaceFrame(surfaceFrame1); |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 837 | presentFence1->signalForTest(90); |
| 838 | mFrameTimeline->setSfPresent(86, presentFence1); |
Adithya Srinivasan | ead1716 | 2021-02-18 02:17:37 +0000 | [diff] [blame] | 839 | |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 840 | EXPECT_EQ(surfaceFrame1->getJankType(), JankType::BufferStuffing); |
Ying Wei | 96eb535 | 2023-11-21 17:37:21 +0000 | [diff] [blame] | 841 | EXPECT_EQ(surfaceFrame1->getJankSeverityType(), JankSeverityType::Full); |
Pascal Mütschard | d56514e | 2024-05-24 17:37:13 +0200 | [diff] [blame] | 842 | |
| 843 | auto jankData = getLayerOneJankData(); |
| 844 | EXPECT_EQ(jankData.size(), 1u); |
| 845 | EXPECT_EQ(jankData[0].jankType, JankType::BufferStuffing); |
Adithya Srinivasan | ead1716 | 2021-02-18 02:17:37 +0000 | [diff] [blame] | 846 | } |
| 847 | |
Alec Mouri | 363faf0 | 2021-01-29 16:34:55 -0800 | [diff] [blame] | 848 | TEST_F(FrameTimelineTest, presentFenceSignaled_reportsAppMissWithRenderRate) { |
Pascal Muetschard | ac7bcd9 | 2023-10-03 15:05:36 +0200 | [diff] [blame] | 849 | Fps refreshRate = RR_11; |
| 850 | Fps renderRate = RR_30; |
Alec Mouri | 363faf0 | 2021-01-29 16:34:55 -0800 | [diff] [blame] | 851 | EXPECT_CALL(*mTimeStats, |
Adithya Srinivasan | 58069dc | 2021-06-04 20:37:02 +0000 | [diff] [blame] | 852 | incrementJankyFrames(TimeStats::JankyFramesInfo{refreshRate, renderRate, sUidOne, |
| 853 | sLayerNameOne, sGameMode, |
| 854 | JankType::AppDeadlineMissed, -4, 0, |
| 855 | 25})); |
Alec Mouri | 363faf0 | 2021-01-29 16:34:55 -0800 | [diff] [blame] | 856 | auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 857 | int64_t surfaceFrameToken1 = mTokenManager->generateTokenForPredictions({10, 20, 60}); |
| 858 | int64_t sfToken1 = mTokenManager->generateTokenForPredictions({82, 90, 90}); |
Huihong Luo | 3bdef86 | 2022-03-03 11:57:19 -0800 | [diff] [blame] | 859 | FrameTimelineInfo ftInfo; |
| 860 | ftInfo.vsyncId = surfaceFrameToken1; |
| 861 | ftInfo.inputEventId = sInputEventId; |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 862 | |
Alec Mouri | 363faf0 | 2021-01-29 16:34:55 -0800 | [diff] [blame] | 863 | auto surfaceFrame1 = |
Huihong Luo | 3bdef86 | 2022-03-03 11:57:19 -0800 | [diff] [blame] | 864 | mFrameTimeline->createSurfaceFrameForToken(ftInfo, sPidOne, sUidOne, sLayerIdOne, |
| 865 | sLayerNameOne, sLayerNameOne, |
| 866 | /*isBuffer*/ true, sGameMode); |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 867 | surfaceFrame1->setAcquireFenceTime(45); |
Pascal Muetschard | ac7bcd9 | 2023-10-03 15:05:36 +0200 | [diff] [blame] | 868 | mFrameTimeline->setSfWakeUp(sfToken1, 52, refreshRate, refreshRate); |
Alec Mouri | 363faf0 | 2021-01-29 16:34:55 -0800 | [diff] [blame] | 869 | |
| 870 | surfaceFrame1->setPresentState(SurfaceFrame::PresentState::Presented); |
| 871 | surfaceFrame1->setRenderRate(renderRate); |
| 872 | mFrameTimeline->addSurfaceFrame(surfaceFrame1); |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 873 | presentFence1->signalForTest(90); |
| 874 | mFrameTimeline->setSfPresent(86, presentFence1); |
Alec Mouri | 363faf0 | 2021-01-29 16:34:55 -0800 | [diff] [blame] | 875 | |
| 876 | EXPECT_EQ(surfaceFrame1->getJankType(), JankType::AppDeadlineMissed); |
Ying Wei | 96eb535 | 2023-11-21 17:37:21 +0000 | [diff] [blame] | 877 | EXPECT_EQ(surfaceFrame1->getJankSeverityType(), JankSeverityType::Full); |
Pascal Mütschard | d56514e | 2024-05-24 17:37:13 +0200 | [diff] [blame] | 878 | |
| 879 | auto jankData = getLayerOneJankData(); |
| 880 | EXPECT_EQ(jankData.size(), 1u); |
| 881 | EXPECT_EQ(jankData[0].jankType, JankType::AppDeadlineMissed); |
Alec Mouri | 363faf0 | 2021-01-29 16:34:55 -0800 | [diff] [blame] | 882 | } |
| 883 | |
Adithya Srinivasan | 115ac69 | 2021-03-06 01:21:30 +0000 | [diff] [blame] | 884 | TEST_F(FrameTimelineTest, presentFenceSignaled_displayFramePredictionExpiredPresentsSurfaceFrame) { |
Pascal Muetschard | ac7bcd9 | 2023-10-03 15:05:36 +0200 | [diff] [blame] | 885 | Fps refreshRate = RR_11; |
| 886 | Fps renderRate = RR_30; |
Adithya Srinivasan | 115ac69 | 2021-03-06 01:21:30 +0000 | [diff] [blame] | 887 | |
| 888 | EXPECT_CALL(*mTimeStats, |
Adithya Srinivasan | 8a94550 | 2021-03-19 19:12:32 +0000 | [diff] [blame] | 889 | incrementJankyFrames( |
| 890 | TimeStats::JankyFramesInfo{refreshRate, renderRate, sUidOne, sLayerNameOne, |
Adithya Srinivasan | 58069dc | 2021-06-04 20:37:02 +0000 | [diff] [blame] | 891 | sGameMode, |
Adithya Srinivasan | 8a94550 | 2021-03-19 19:12:32 +0000 | [diff] [blame] | 892 | JankType::Unknown | JankType::AppDeadlineMissed, |
Adithya Srinivasan | de27245 | 2021-04-10 00:21:00 +0000 | [diff] [blame] | 893 | 0, 0, 25})); |
Adithya Srinivasan | 115ac69 | 2021-03-06 01:21:30 +0000 | [diff] [blame] | 894 | auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
| 895 | int64_t surfaceFrameToken1 = mTokenManager->generateTokenForPredictions({10, 20, 60}); |
| 896 | int64_t sfToken1 = mTokenManager->generateTokenForPredictions({82, 90, 90}); |
Huihong Luo | 3bdef86 | 2022-03-03 11:57:19 -0800 | [diff] [blame] | 897 | FrameTimelineInfo ftInfo; |
| 898 | ftInfo.vsyncId = surfaceFrameToken1; |
| 899 | ftInfo.inputEventId = sInputEventId; |
Adithya Srinivasan | 115ac69 | 2021-03-06 01:21:30 +0000 | [diff] [blame] | 900 | |
| 901 | auto surfaceFrame1 = |
Huihong Luo | 3bdef86 | 2022-03-03 11:57:19 -0800 | [diff] [blame] | 902 | mFrameTimeline->createSurfaceFrameForToken(ftInfo, sPidOne, sUidOne, sLayerIdOne, |
| 903 | sLayerNameOne, sLayerNameOne, |
| 904 | /*isBuffer*/ true, sGameMode); |
Adithya Srinivasan | 115ac69 | 2021-03-06 01:21:30 +0000 | [diff] [blame] | 905 | surfaceFrame1->setAcquireFenceTime(45); |
| 906 | // Trigger a prediction expiry |
Adithya Srinivasan | bed4c4f | 2021-05-03 20:24:46 +0000 | [diff] [blame] | 907 | flushTokens(); |
Pascal Muetschard | ac7bcd9 | 2023-10-03 15:05:36 +0200 | [diff] [blame] | 908 | mFrameTimeline->setSfWakeUp(sfToken1, 52, refreshRate, refreshRate); |
Adithya Srinivasan | 115ac69 | 2021-03-06 01:21:30 +0000 | [diff] [blame] | 909 | |
| 910 | surfaceFrame1->setPresentState(SurfaceFrame::PresentState::Presented); |
| 911 | surfaceFrame1->setRenderRate(renderRate); |
| 912 | mFrameTimeline->addSurfaceFrame(surfaceFrame1); |
| 913 | presentFence1->signalForTest(90); |
| 914 | mFrameTimeline->setSfPresent(86, presentFence1); |
| 915 | |
| 916 | auto displayFrame = getDisplayFrame(0); |
| 917 | EXPECT_EQ(displayFrame->getJankType(), JankType::Unknown); |
Ying Wei | 96eb535 | 2023-11-21 17:37:21 +0000 | [diff] [blame] | 918 | EXPECT_EQ(displayFrame->getJankSeverityType(), JankSeverityType::Unknown); |
Adithya Srinivasan | 115ac69 | 2021-03-06 01:21:30 +0000 | [diff] [blame] | 919 | EXPECT_EQ(displayFrame->getFrameStartMetadata(), FrameStartMetadata::UnknownStart); |
| 920 | EXPECT_EQ(displayFrame->getFrameReadyMetadata(), FrameReadyMetadata::UnknownFinish); |
| 921 | EXPECT_EQ(displayFrame->getFramePresentMetadata(), FramePresentMetadata::UnknownPresent); |
| 922 | |
| 923 | EXPECT_EQ(surfaceFrame1->getActuals().presentTime, 90); |
Adithya Srinivasan | 8a94550 | 2021-03-19 19:12:32 +0000 | [diff] [blame] | 924 | EXPECT_EQ(surfaceFrame1->getJankType(), JankType::Unknown | JankType::AppDeadlineMissed); |
Ying Wei | 96eb535 | 2023-11-21 17:37:21 +0000 | [diff] [blame] | 925 | EXPECT_EQ(surfaceFrame1->getJankSeverityType(), JankSeverityType::Full); |
Pascal Mütschard | d56514e | 2024-05-24 17:37:13 +0200 | [diff] [blame] | 926 | |
| 927 | auto jankData = getLayerOneJankData(); |
| 928 | EXPECT_EQ(jankData.size(), 1u); |
| 929 | EXPECT_EQ(jankData[0].jankType, JankType::Unknown | JankType::AppDeadlineMissed); |
Adithya Srinivasan | 115ac69 | 2021-03-06 01:21:30 +0000 | [diff] [blame] | 930 | } |
| 931 | |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 932 | /* |
| 933 | * Tracing Tests |
| 934 | * |
| 935 | * Trace packets are flushed all the way only when the next packet is traced. |
| 936 | * For example: trace<Display/Surface>Frame() will create a TracePacket but not flush it. Only when |
| 937 | * another TracePacket is created, the previous one is guaranteed to be flushed. The following tests |
| 938 | * will have additional empty frames created for this reason. |
| 939 | */ |
| 940 | TEST_F(FrameTimelineTest, tracing_noPacketsSentWithoutTraceStart) { |
| 941 | auto tracingSession = getTracingSessionForTest(); |
| 942 | auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 943 | int64_t token1 = mTokenManager->generateTokenForPredictions({10, 20, 30}); |
Huihong Luo | 3bdef86 | 2022-03-03 11:57:19 -0800 | [diff] [blame] | 944 | FrameTimelineInfo ftInfo; |
| 945 | ftInfo.vsyncId = token1; |
| 946 | ftInfo.inputEventId = sInputEventId; |
Siarhei Vishniakou | fc434ac | 2021-01-13 10:28:00 -1000 | [diff] [blame] | 947 | auto surfaceFrame1 = |
Huihong Luo | 3bdef86 | 2022-03-03 11:57:19 -0800 | [diff] [blame] | 948 | mFrameTimeline->createSurfaceFrameForToken(ftInfo, sPidOne, sUidOne, sLayerIdOne, |
| 949 | sLayerNameOne, sLayerNameOne, |
Adithya Srinivasan | 58069dc | 2021-06-04 20:37:02 +0000 | [diff] [blame] | 950 | /*isBuffer*/ true, sGameMode); |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 951 | |
| 952 | // Set up the display frame |
Pascal Muetschard | ac7bcd9 | 2023-10-03 15:05:36 +0200 | [diff] [blame] | 953 | mFrameTimeline->setSfWakeUp(token1, 20, RR_11, RR_11); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 954 | surfaceFrame1->setPresentState(SurfaceFrame::PresentState::Dropped); |
| 955 | mFrameTimeline->addSurfaceFrame(surfaceFrame1); |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 956 | mFrameTimeline->setSfPresent(25, presentFence1); |
| 957 | presentFence1->signalForTest(30); |
| 958 | |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 959 | addEmptyDisplayFrame(); |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 960 | |
| 961 | auto packets = readFrameTimelinePacketsBlocking(tracingSession.get()); |
Siarhei Vishniakou | fc434ac | 2021-01-13 10:28:00 -1000 | [diff] [blame] | 962 | EXPECT_EQ(packets.size(), 0u); |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 963 | } |
| 964 | |
| 965 | TEST_F(FrameTimelineTest, tracing_sanityTest) { |
| 966 | auto tracingSession = getTracingSessionForTest(); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 967 | // Layer specific increment |
Alec Mouri | 363faf0 | 2021-01-29 16:34:55 -0800 | [diff] [blame] | 968 | EXPECT_CALL(*mTimeStats, incrementJankyFrames(_)); |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 969 | auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 970 | |
| 971 | tracingSession->StartBlocking(); |
| 972 | int64_t token1 = mTokenManager->generateTokenForPredictions({10, 20, 30}); |
| 973 | int64_t token2 = mTokenManager->generateTokenForPredictions({40, 50, 60}); |
Huihong Luo | 3bdef86 | 2022-03-03 11:57:19 -0800 | [diff] [blame] | 974 | FrameTimelineInfo ftInfo; |
| 975 | ftInfo.vsyncId = token1; |
| 976 | ftInfo.inputEventId = sInputEventId; |
Siarhei Vishniakou | fc434ac | 2021-01-13 10:28:00 -1000 | [diff] [blame] | 977 | auto surfaceFrame1 = |
Huihong Luo | 3bdef86 | 2022-03-03 11:57:19 -0800 | [diff] [blame] | 978 | mFrameTimeline->createSurfaceFrameForToken(ftInfo, sPidOne, sUidOne, sLayerIdOne, |
| 979 | sLayerNameOne, sLayerNameOne, |
Adithya Srinivasan | 58069dc | 2021-06-04 20:37:02 +0000 | [diff] [blame] | 980 | /*isBuffer*/ true, sGameMode); |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 981 | |
| 982 | // Set up the display frame |
Pascal Muetschard | ac7bcd9 | 2023-10-03 15:05:36 +0200 | [diff] [blame] | 983 | mFrameTimeline->setSfWakeUp(token2, 20, RR_11, RR_11); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 984 | surfaceFrame1->setPresentState(SurfaceFrame::PresentState::Presented); |
| 985 | mFrameTimeline->addSurfaceFrame(surfaceFrame1); |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 986 | mFrameTimeline->setSfPresent(25, presentFence1); |
| 987 | presentFence1->signalForTest(30); |
| 988 | |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 989 | addEmptyDisplayFrame(); |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 990 | flushTrace(); |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 991 | tracingSession->StopBlocking(); |
| 992 | |
| 993 | auto packets = readFrameTimelinePacketsBlocking(tracingSession.get()); |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 994 | // Display Frame 1 has 8 packets - 4 from DisplayFrame and 4 from SurfaceFrame. |
Siarhei Vishniakou | fc434ac | 2021-01-13 10:28:00 -1000 | [diff] [blame] | 995 | EXPECT_EQ(packets.size(), 8u); |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 996 | } |
| 997 | |
| 998 | TEST_F(FrameTimelineTest, traceDisplayFrame_invalidTokenDoesNotEmitTracePacket) { |
| 999 | auto tracingSession = getTracingSessionForTest(); |
| 1000 | auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 1001 | |
| 1002 | tracingSession->StartBlocking(); |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 1003 | |
| 1004 | // Set up the display frame |
Pascal Muetschard | ac7bcd9 | 2023-10-03 15:05:36 +0200 | [diff] [blame] | 1005 | mFrameTimeline->setSfWakeUp(-1, 20, RR_11, RR_11); |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 1006 | mFrameTimeline->setSfPresent(25, presentFence1); |
| 1007 | presentFence1->signalForTest(30); |
| 1008 | |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 1009 | addEmptyDisplayFrame(); |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 1010 | flushTrace(); |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 1011 | tracingSession->StopBlocking(); |
| 1012 | |
| 1013 | auto packets = readFrameTimelinePacketsBlocking(tracingSession.get()); |
Siarhei Vishniakou | fc434ac | 2021-01-13 10:28:00 -1000 | [diff] [blame] | 1014 | EXPECT_EQ(packets.size(), 0u); |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 1015 | } |
| 1016 | |
| 1017 | TEST_F(FrameTimelineTest, traceSurfaceFrame_invalidTokenDoesNotEmitTracePacket) { |
| 1018 | auto tracingSession = getTracingSessionForTest(); |
| 1019 | auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 1020 | |
| 1021 | tracingSession->StartBlocking(); |
| 1022 | int64_t token1 = mTokenManager->generateTokenForPredictions({10, 20, 30}); |
Alec Mouri | adebf5c | 2021-01-05 12:57:36 -0800 | [diff] [blame] | 1023 | auto surfaceFrame1 = |
| 1024 | mFrameTimeline->createSurfaceFrameForToken({}, sPidOne, sUidOne, sLayerIdOne, |
Adithya Srinivasan | 785addd | 2021-03-09 00:38:00 +0000 | [diff] [blame] | 1025 | sLayerNameOne, sLayerNameOne, |
Adithya Srinivasan | 58069dc | 2021-06-04 20:37:02 +0000 | [diff] [blame] | 1026 | /*isBuffer*/ true, sGameMode); |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 1027 | |
| 1028 | // Set up the display frame |
Pascal Muetschard | ac7bcd9 | 2023-10-03 15:05:36 +0200 | [diff] [blame] | 1029 | mFrameTimeline->setSfWakeUp(token1, 20, RR_11, RR_11); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1030 | surfaceFrame1->setPresentState(SurfaceFrame::PresentState::Dropped); |
| 1031 | mFrameTimeline->addSurfaceFrame(surfaceFrame1); |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 1032 | mFrameTimeline->setSfPresent(25, presentFence1); |
| 1033 | presentFence1->signalForTest(30); |
| 1034 | |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 1035 | addEmptyDisplayFrame(); |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 1036 | flushTrace(); |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 1037 | tracingSession->StopBlocking(); |
| 1038 | |
| 1039 | auto packets = readFrameTimelinePacketsBlocking(tracingSession.get()); |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 1040 | // Display Frame 1 has 4 packets (SurfaceFrame shouldn't be traced since it has an invalid |
| 1041 | // token). |
Siarhei Vishniakou | fc434ac | 2021-01-13 10:28:00 -1000 | [diff] [blame] | 1042 | EXPECT_EQ(packets.size(), 4u); |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 1043 | } |
| 1044 | |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 1045 | ProtoExpectedDisplayFrameStart createProtoExpectedDisplayFrameStart(int64_t cookie, int64_t token, |
| 1046 | pid_t pid) { |
| 1047 | ProtoExpectedDisplayFrameStart proto; |
| 1048 | proto.set_cookie(cookie); |
| 1049 | proto.set_token(token); |
| 1050 | proto.set_pid(pid); |
| 1051 | return proto; |
| 1052 | } |
| 1053 | |
| 1054 | ProtoActualDisplayFrameStart createProtoActualDisplayFrameStart( |
| 1055 | int64_t cookie, int64_t token, pid_t pid, ProtoPresentType presentType, bool onTimeFinish, |
Ying Wei | 96eb535 | 2023-11-21 17:37:21 +0000 | [diff] [blame] | 1056 | bool gpuComposition, ProtoJankType jankType, ProtoJankSeverityType jankSeverityType, |
| 1057 | ProtoPredictionType predictionType) { |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 1058 | ProtoActualDisplayFrameStart proto; |
| 1059 | proto.set_cookie(cookie); |
| 1060 | proto.set_token(token); |
| 1061 | proto.set_pid(pid); |
| 1062 | proto.set_present_type(presentType); |
| 1063 | proto.set_on_time_finish(onTimeFinish); |
| 1064 | proto.set_gpu_composition(gpuComposition); |
| 1065 | proto.set_jank_type(jankType); |
Ying Wei | 96eb535 | 2023-11-21 17:37:21 +0000 | [diff] [blame] | 1066 | proto.set_jank_severity_type(jankSeverityType); |
Adithya Srinivasan | 78e58af | 2021-02-25 00:08:08 +0000 | [diff] [blame] | 1067 | proto.set_prediction_type(predictionType); |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 1068 | return proto; |
| 1069 | } |
| 1070 | |
| 1071 | ProtoExpectedSurfaceFrameStart createProtoExpectedSurfaceFrameStart(int64_t cookie, int64_t token, |
| 1072 | int64_t displayFrameToken, |
| 1073 | pid_t pid, |
| 1074 | std::string layerName) { |
| 1075 | ProtoExpectedSurfaceFrameStart proto; |
| 1076 | proto.set_cookie(cookie); |
| 1077 | proto.set_token(token); |
| 1078 | proto.set_display_frame_token(displayFrameToken); |
| 1079 | proto.set_pid(pid); |
| 1080 | proto.set_layer_name(layerName); |
| 1081 | return proto; |
| 1082 | } |
| 1083 | |
| 1084 | ProtoActualSurfaceFrameStart createProtoActualSurfaceFrameStart( |
| 1085 | int64_t cookie, int64_t token, int64_t displayFrameToken, pid_t pid, std::string layerName, |
| 1086 | ProtoPresentType presentType, bool onTimeFinish, bool gpuComposition, |
Ying Wei | 96eb535 | 2023-11-21 17:37:21 +0000 | [diff] [blame] | 1087 | ProtoJankType jankType, ProtoJankSeverityType jankSeverityType, |
| 1088 | ProtoPredictionType predictionType, bool isBuffer) { |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 1089 | ProtoActualSurfaceFrameStart proto; |
| 1090 | proto.set_cookie(cookie); |
| 1091 | proto.set_token(token); |
| 1092 | proto.set_display_frame_token(displayFrameToken); |
| 1093 | proto.set_pid(pid); |
| 1094 | proto.set_layer_name(layerName); |
| 1095 | proto.set_present_type(presentType); |
| 1096 | proto.set_on_time_finish(onTimeFinish); |
| 1097 | proto.set_gpu_composition(gpuComposition); |
| 1098 | proto.set_jank_type(jankType); |
Ying Wei | 96eb535 | 2023-11-21 17:37:21 +0000 | [diff] [blame] | 1099 | proto.set_jank_severity_type(jankSeverityType); |
Adithya Srinivasan | 78e58af | 2021-02-25 00:08:08 +0000 | [diff] [blame] | 1100 | proto.set_prediction_type(predictionType); |
Adithya Srinivasan | 1f9450c | 2021-06-10 22:39:19 +0000 | [diff] [blame] | 1101 | proto.set_is_buffer(isBuffer); |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 1102 | return proto; |
| 1103 | } |
| 1104 | |
| 1105 | ProtoFrameEnd createProtoFrameEnd(int64_t cookie) { |
| 1106 | ProtoFrameEnd proto; |
| 1107 | proto.set_cookie(cookie); |
| 1108 | return proto; |
| 1109 | } |
| 1110 | |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 1111 | void validateTraceEvent(const ProtoExpectedDisplayFrameStart& received, |
| 1112 | const ProtoExpectedDisplayFrameStart& source) { |
| 1113 | ASSERT_TRUE(received.has_cookie()); |
| 1114 | EXPECT_EQ(received.cookie(), source.cookie()); |
| 1115 | |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 1116 | ASSERT_TRUE(received.has_token()); |
| 1117 | EXPECT_EQ(received.token(), source.token()); |
| 1118 | |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 1119 | ASSERT_TRUE(received.has_pid()); |
| 1120 | EXPECT_EQ(received.pid(), source.pid()); |
| 1121 | } |
| 1122 | |
| 1123 | void validateTraceEvent(const ProtoActualDisplayFrameStart& received, |
| 1124 | const ProtoActualDisplayFrameStart& source) { |
| 1125 | ASSERT_TRUE(received.has_cookie()); |
| 1126 | EXPECT_EQ(received.cookie(), source.cookie()); |
| 1127 | |
| 1128 | ASSERT_TRUE(received.has_token()); |
| 1129 | EXPECT_EQ(received.token(), source.token()); |
| 1130 | |
| 1131 | ASSERT_TRUE(received.has_pid()); |
| 1132 | EXPECT_EQ(received.pid(), source.pid()); |
| 1133 | |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 1134 | ASSERT_TRUE(received.has_present_type()); |
| 1135 | EXPECT_EQ(received.present_type(), source.present_type()); |
| 1136 | ASSERT_TRUE(received.has_on_time_finish()); |
| 1137 | EXPECT_EQ(received.on_time_finish(), source.on_time_finish()); |
| 1138 | ASSERT_TRUE(received.has_gpu_composition()); |
| 1139 | EXPECT_EQ(received.gpu_composition(), source.gpu_composition()); |
| 1140 | ASSERT_TRUE(received.has_jank_type()); |
| 1141 | EXPECT_EQ(received.jank_type(), source.jank_type()); |
Ying Wei | 96eb535 | 2023-11-21 17:37:21 +0000 | [diff] [blame] | 1142 | ASSERT_TRUE(received.has_jank_severity_type()); |
| 1143 | EXPECT_EQ(received.jank_severity_type(), source.jank_severity_type()); |
Adithya Srinivasan | 78e58af | 2021-02-25 00:08:08 +0000 | [diff] [blame] | 1144 | ASSERT_TRUE(received.has_prediction_type()); |
| 1145 | EXPECT_EQ(received.prediction_type(), source.prediction_type()); |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 1146 | } |
| 1147 | |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 1148 | void validateTraceEvent(const ProtoExpectedSurfaceFrameStart& received, |
| 1149 | const ProtoExpectedSurfaceFrameStart& source) { |
| 1150 | ASSERT_TRUE(received.has_cookie()); |
| 1151 | EXPECT_EQ(received.cookie(), source.cookie()); |
| 1152 | |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 1153 | ASSERT_TRUE(received.has_token()); |
| 1154 | EXPECT_EQ(received.token(), source.token()); |
| 1155 | |
| 1156 | ASSERT_TRUE(received.has_display_frame_token()); |
| 1157 | EXPECT_EQ(received.display_frame_token(), source.display_frame_token()); |
| 1158 | |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 1159 | ASSERT_TRUE(received.has_pid()); |
| 1160 | EXPECT_EQ(received.pid(), source.pid()); |
| 1161 | |
| 1162 | ASSERT_TRUE(received.has_layer_name()); |
| 1163 | EXPECT_EQ(received.layer_name(), source.layer_name()); |
| 1164 | } |
| 1165 | |
| 1166 | void validateTraceEvent(const ProtoActualSurfaceFrameStart& received, |
| 1167 | const ProtoActualSurfaceFrameStart& source) { |
| 1168 | ASSERT_TRUE(received.has_cookie()); |
| 1169 | EXPECT_EQ(received.cookie(), source.cookie()); |
| 1170 | |
| 1171 | ASSERT_TRUE(received.has_token()); |
| 1172 | EXPECT_EQ(received.token(), source.token()); |
| 1173 | |
| 1174 | ASSERT_TRUE(received.has_display_frame_token()); |
| 1175 | EXPECT_EQ(received.display_frame_token(), source.display_frame_token()); |
| 1176 | |
| 1177 | ASSERT_TRUE(received.has_pid()); |
| 1178 | EXPECT_EQ(received.pid(), source.pid()); |
| 1179 | |
| 1180 | ASSERT_TRUE(received.has_layer_name()); |
| 1181 | EXPECT_EQ(received.layer_name(), source.layer_name()); |
| 1182 | |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 1183 | ASSERT_TRUE(received.has_present_type()); |
| 1184 | EXPECT_EQ(received.present_type(), source.present_type()); |
| 1185 | ASSERT_TRUE(received.has_on_time_finish()); |
| 1186 | EXPECT_EQ(received.on_time_finish(), source.on_time_finish()); |
| 1187 | ASSERT_TRUE(received.has_gpu_composition()); |
| 1188 | EXPECT_EQ(received.gpu_composition(), source.gpu_composition()); |
| 1189 | ASSERT_TRUE(received.has_jank_type()); |
| 1190 | EXPECT_EQ(received.jank_type(), source.jank_type()); |
Ying Wei | 96eb535 | 2023-11-21 17:37:21 +0000 | [diff] [blame] | 1191 | ASSERT_TRUE(received.has_jank_severity_type()); |
| 1192 | EXPECT_EQ(received.jank_severity_type(), source.jank_severity_type()); |
Adithya Srinivasan | 78e58af | 2021-02-25 00:08:08 +0000 | [diff] [blame] | 1193 | ASSERT_TRUE(received.has_prediction_type()); |
| 1194 | EXPECT_EQ(received.prediction_type(), source.prediction_type()); |
Adithya Srinivasan | 1f9450c | 2021-06-10 22:39:19 +0000 | [diff] [blame] | 1195 | ASSERT_TRUE(received.has_is_buffer()); |
| 1196 | EXPECT_EQ(received.is_buffer(), source.is_buffer()); |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 1197 | } |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 1198 | |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 1199 | void validateTraceEvent(const ProtoFrameEnd& received, const ProtoFrameEnd& source) { |
| 1200 | ASSERT_TRUE(received.has_cookie()); |
| 1201 | EXPECT_EQ(received.cookie(), source.cookie()); |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 1202 | } |
| 1203 | |
Sally Qi | 2269a69 | 2024-05-17 18:02:28 -0700 | [diff] [blame] | 1204 | TEST_F(FrameTimelineTest, traceDisplayFrameNoSkipped) { |
| 1205 | // setup 2 display frames |
| 1206 | // DF 1: [22, 30] -> [0, 11] |
| 1207 | // DF 2: [82, 90] -> SF [5, 16] |
| 1208 | auto tracingSession = getTracingSessionForTest(); |
| 1209 | tracingSession->StartBlocking(); |
| 1210 | int64_t sfToken1 = mTokenManager->generateTokenForPredictions({22, 30, 40}); |
| 1211 | int64_t sfToken2 = mTokenManager->generateTokenForPredictions({82, 90, 100}); |
| 1212 | int64_t surfaceFrameToken1 = mTokenManager->generateTokenForPredictions({0, 11, 25}); |
| 1213 | int64_t surfaceFrameToken2 = mTokenManager->generateTokenForPredictions({5, 16, 30}); |
| 1214 | auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
| 1215 | |
| 1216 | int64_t traceCookie = snoopCurrentTraceCookie(); |
| 1217 | |
| 1218 | // set up 1st display frame |
| 1219 | FrameTimelineInfo ftInfo1; |
| 1220 | ftInfo1.vsyncId = surfaceFrameToken1; |
| 1221 | ftInfo1.inputEventId = sInputEventId; |
| 1222 | auto surfaceFrame1 = |
| 1223 | mFrameTimeline->createSurfaceFrameForToken(ftInfo1, sPidOne, sUidOne, sLayerIdOne, |
| 1224 | sLayerNameOne, sLayerNameOne, |
| 1225 | /*isBuffer*/ true, sGameMode); |
| 1226 | surfaceFrame1->setAcquireFenceTime(11); |
| 1227 | mFrameTimeline->setSfWakeUp(sfToken1, 22, RR_11, RR_30); |
| 1228 | surfaceFrame1->setPresentState(SurfaceFrame::PresentState::Presented); |
| 1229 | mFrameTimeline->addSurfaceFrame(surfaceFrame1); |
| 1230 | mFrameTimeline->setSfPresent(30, presentFence1); |
| 1231 | presentFence1->signalForTest(40); |
| 1232 | |
| 1233 | // Trigger a flush by finalizing the next DisplayFrame |
| 1234 | auto presentFence2 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
| 1235 | FrameTimelineInfo ftInfo2; |
| 1236 | ftInfo2.vsyncId = surfaceFrameToken2; |
| 1237 | ftInfo2.inputEventId = sInputEventId; |
| 1238 | auto surfaceFrame2 = |
| 1239 | mFrameTimeline->createSurfaceFrameForToken(ftInfo2, sPidOne, sUidOne, sLayerIdOne, |
| 1240 | sLayerNameOne, sLayerNameOne, |
| 1241 | /*isBuffer*/ true, sGameMode); |
| 1242 | |
| 1243 | // set up 2nd display frame |
| 1244 | surfaceFrame2->setAcquireFenceTime(16); |
| 1245 | mFrameTimeline->setSfWakeUp(sfToken2, 82, RR_11, RR_30); |
| 1246 | surfaceFrame2->setPresentState(SurfaceFrame::PresentState::Presented); |
| 1247 | mFrameTimeline->addSurfaceFrame(surfaceFrame2); |
| 1248 | mFrameTimeline->setSfPresent(90, presentFence2); |
| 1249 | presentFence2->signalForTest(100); |
| 1250 | |
| 1251 | // the token of skipped Display Frame |
| 1252 | auto protoSkippedActualDisplayFrameStart = |
| 1253 | createProtoActualDisplayFrameStart(traceCookie + 9, 0, kSurfaceFlingerPid, |
| 1254 | FrameTimelineEvent::PRESENT_DROPPED, true, false, |
| 1255 | FrameTimelineEvent::JANK_DROPPED, |
| 1256 | FrameTimelineEvent::SEVERITY_NONE, |
| 1257 | FrameTimelineEvent::PREDICTION_VALID); |
| 1258 | auto protoSkippedActualDisplayFrameEnd = createProtoFrameEnd(traceCookie + 9); |
| 1259 | |
| 1260 | // Trigger a flush by finalizing the next DisplayFrame |
| 1261 | addEmptyDisplayFrame(); |
| 1262 | flushTrace(); |
| 1263 | tracingSession->StopBlocking(); |
| 1264 | |
| 1265 | auto packets = readFrameTimelinePacketsBlocking(tracingSession.get()); |
| 1266 | // 8 Valid Display Frames + 8 Valid Surface Frames + no Skipped Display Frames |
| 1267 | EXPECT_EQ(packets.size(), 16u); |
| 1268 | } |
| 1269 | |
Sally Qi | aa10774 | 2023-09-29 14:53:14 -0700 | [diff] [blame] | 1270 | TEST_F(FrameTimelineTest, traceDisplayFrameSkipped) { |
Sally Qi | f572125 | 2023-11-17 11:14:53 -0800 | [diff] [blame] | 1271 | SET_FLAG_FOR_TEST(com::android::graphics::surfaceflinger::flags::add_sf_skipped_frames_to_trace, |
| 1272 | true); |
| 1273 | |
Sally Qi | aa10774 | 2023-09-29 14:53:14 -0700 | [diff] [blame] | 1274 | // setup 2 display frames |
| 1275 | // DF 1: [22,40] -> [5, 40] |
| 1276 | // DF : [36, 70] (Skipped one, added by the trace) |
| 1277 | // DF 2: [82, 100] -> SF [25, 70] |
| 1278 | auto tracingSession = getTracingSessionForTest(); |
| 1279 | tracingSession->StartBlocking(); |
| 1280 | int64_t sfToken1 = mTokenManager->generateTokenForPredictions({22, 30, 40}); |
| 1281 | int64_t sfToken2 = mTokenManager->generateTokenForPredictions({82, 90, 100}); |
| 1282 | int64_t surfaceFrameToken1 = mTokenManager->generateTokenForPredictions({5, 16, 40}); |
| 1283 | int64_t surfaceFrameToken2 = mTokenManager->generateTokenForPredictions({25, 36, 70}); |
| 1284 | auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
| 1285 | |
| 1286 | int64_t traceCookie = snoopCurrentTraceCookie(); |
| 1287 | |
| 1288 | // set up 1st display frame |
| 1289 | FrameTimelineInfo ftInfo1; |
| 1290 | ftInfo1.vsyncId = surfaceFrameToken1; |
| 1291 | ftInfo1.inputEventId = sInputEventId; |
| 1292 | auto surfaceFrame1 = |
| 1293 | mFrameTimeline->createSurfaceFrameForToken(ftInfo1, sPidOne, sUidOne, sLayerIdOne, |
| 1294 | sLayerNameOne, sLayerNameOne, |
| 1295 | /*isBuffer*/ true, sGameMode); |
| 1296 | surfaceFrame1->setAcquireFenceTime(16); |
| 1297 | mFrameTimeline->setSfWakeUp(sfToken1, 22, RR_11, RR_30); |
| 1298 | surfaceFrame1->setPresentState(SurfaceFrame::PresentState::Presented); |
| 1299 | mFrameTimeline->addSurfaceFrame(surfaceFrame1); |
| 1300 | mFrameTimeline->setSfPresent(30, presentFence1); |
| 1301 | presentFence1->signalForTest(40); |
| 1302 | |
| 1303 | // Trigger a flush by finalizing the next DisplayFrame |
| 1304 | auto presentFence2 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
| 1305 | FrameTimelineInfo ftInfo2; |
| 1306 | ftInfo2.vsyncId = surfaceFrameToken2; |
| 1307 | ftInfo2.inputEventId = sInputEventId; |
| 1308 | auto surfaceFrame2 = |
| 1309 | mFrameTimeline->createSurfaceFrameForToken(ftInfo2, sPidOne, sUidOne, sLayerIdOne, |
| 1310 | sLayerNameOne, sLayerNameOne, |
| 1311 | /*isBuffer*/ true, sGameMode); |
| 1312 | |
| 1313 | // set up 2nd display frame |
| 1314 | surfaceFrame2->setAcquireFenceTime(36); |
| 1315 | mFrameTimeline->setSfWakeUp(sfToken2, 82, RR_11, RR_30); |
| 1316 | surfaceFrame2->setPresentState(SurfaceFrame::PresentState::Presented); |
| 1317 | mFrameTimeline->addSurfaceFrame(surfaceFrame2); |
| 1318 | mFrameTimeline->setSfPresent(90, presentFence2); |
| 1319 | presentFence2->signalForTest(100); |
| 1320 | |
| 1321 | // the token of skipped Display Frame |
| 1322 | auto protoSkippedActualDisplayFrameStart = |
| 1323 | createProtoActualDisplayFrameStart(traceCookie + 9, 0, kSurfaceFlingerPid, |
| 1324 | FrameTimelineEvent::PRESENT_DROPPED, true, false, |
| 1325 | FrameTimelineEvent::JANK_DROPPED, |
Ying Wei | 96eb535 | 2023-11-21 17:37:21 +0000 | [diff] [blame] | 1326 | FrameTimelineEvent::SEVERITY_NONE, |
Sally Qi | aa10774 | 2023-09-29 14:53:14 -0700 | [diff] [blame] | 1327 | FrameTimelineEvent::PREDICTION_VALID); |
| 1328 | auto protoSkippedActualDisplayFrameEnd = createProtoFrameEnd(traceCookie + 9); |
| 1329 | |
| 1330 | // Trigger a flush by finalizing the next DisplayFrame |
| 1331 | addEmptyDisplayFrame(); |
| 1332 | flushTrace(); |
| 1333 | tracingSession->StopBlocking(); |
| 1334 | |
| 1335 | auto packets = readFrameTimelinePacketsBlocking(tracingSession.get()); |
| 1336 | // 8 Valid Display Frames + 8 Valid Surface Frames + 2 Skipped Display Frames |
| 1337 | EXPECT_EQ(packets.size(), 18u); |
| 1338 | |
| 1339 | // Packet - 16: Actual skipped Display Frame Start |
| 1340 | // the timestamp should be equal to the 2nd expected surface frame's end time |
| 1341 | const auto& packet16 = packets[16]; |
| 1342 | ASSERT_TRUE(packet16.has_timestamp()); |
| 1343 | EXPECT_EQ(packet16.timestamp(), 36u); |
| 1344 | ASSERT_TRUE(packet16.has_frame_timeline_event()); |
| 1345 | |
| 1346 | const auto& event16 = packet16.frame_timeline_event(); |
| 1347 | const auto& actualSkippedDisplayFrameStart = event16.actual_display_frame_start(); |
| 1348 | validateTraceEvent(actualSkippedDisplayFrameStart, protoSkippedActualDisplayFrameStart); |
| 1349 | |
| 1350 | // Packet - 17: Actual skipped Display Frame End |
| 1351 | // the timestamp should be equal to the 2nd expected surface frame's present time |
| 1352 | const auto& packet17 = packets[17]; |
| 1353 | ASSERT_TRUE(packet17.has_timestamp()); |
| 1354 | EXPECT_EQ(packet17.timestamp(), 70u); |
| 1355 | ASSERT_TRUE(packet17.has_frame_timeline_event()); |
| 1356 | |
| 1357 | const auto& event17 = packet17.frame_timeline_event(); |
| 1358 | const auto& actualSkippedDisplayFrameEnd = event17.frame_end(); |
| 1359 | validateTraceEvent(actualSkippedDisplayFrameEnd, protoSkippedActualDisplayFrameEnd); |
| 1360 | } |
| 1361 | |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 1362 | TEST_F(FrameTimelineTest, traceDisplayFrame_emitsValidTracePacket) { |
| 1363 | auto tracingSession = getTracingSessionForTest(); |
| 1364 | auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 1365 | |
| 1366 | tracingSession->StartBlocking(); |
Ady Abraham | 57a8ab4 | 2023-01-26 15:28:19 -0800 | [diff] [blame] | 1367 | |
| 1368 | // Add an empty surface frame so that display frame would get traced. |
| 1369 | addEmptySurfaceFrame(); |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 1370 | int64_t displayFrameToken1 = mTokenManager->generateTokenForPredictions({10, 30, 30}); |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 1371 | |
| 1372 | // Set up the display frame |
Pascal Muetschard | ac7bcd9 | 2023-10-03 15:05:36 +0200 | [diff] [blame] | 1373 | mFrameTimeline->setSfWakeUp(displayFrameToken1, 20, RR_11, RR_11); |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 1374 | mFrameTimeline->setSfPresent(26, presentFence1); |
| 1375 | presentFence1->signalForTest(31); |
| 1376 | |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 1377 | int64_t traceCookie = snoopCurrentTraceCookie(); |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 1378 | auto protoExpectedDisplayFrameStart = |
| 1379 | createProtoExpectedDisplayFrameStart(traceCookie + 1, displayFrameToken1, |
| 1380 | kSurfaceFlingerPid); |
| 1381 | auto protoExpectedDisplayFrameEnd = createProtoFrameEnd(traceCookie + 1); |
| 1382 | auto protoActualDisplayFrameStart = |
| 1383 | createProtoActualDisplayFrameStart(traceCookie + 2, displayFrameToken1, |
| 1384 | kSurfaceFlingerPid, |
| 1385 | FrameTimelineEvent::PRESENT_ON_TIME, true, false, |
Adithya Srinivasan | 78e58af | 2021-02-25 00:08:08 +0000 | [diff] [blame] | 1386 | FrameTimelineEvent::JANK_NONE, |
Ying Wei | 96eb535 | 2023-11-21 17:37:21 +0000 | [diff] [blame] | 1387 | FrameTimelineEvent::SEVERITY_NONE, |
Adithya Srinivasan | 78e58af | 2021-02-25 00:08:08 +0000 | [diff] [blame] | 1388 | FrameTimelineEvent::PREDICTION_VALID); |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 1389 | auto protoActualDisplayFrameEnd = createProtoFrameEnd(traceCookie + 2); |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 1390 | |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 1391 | addEmptyDisplayFrame(); |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 1392 | flushTrace(); |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 1393 | tracingSession->StopBlocking(); |
| 1394 | |
| 1395 | auto packets = readFrameTimelinePacketsBlocking(tracingSession.get()); |
Siarhei Vishniakou | fc434ac | 2021-01-13 10:28:00 -1000 | [diff] [blame] | 1396 | EXPECT_EQ(packets.size(), 4u); |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 1397 | |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 1398 | // Packet - 0 : ExpectedDisplayFrameStart |
| 1399 | const auto& packet0 = packets[0]; |
| 1400 | ASSERT_TRUE(packet0.has_timestamp()); |
Siarhei Vishniakou | fc434ac | 2021-01-13 10:28:00 -1000 | [diff] [blame] | 1401 | EXPECT_EQ(packet0.timestamp(), 10u); |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 1402 | ASSERT_TRUE(packet0.has_frame_timeline_event()); |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 1403 | |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 1404 | const auto& event0 = packet0.frame_timeline_event(); |
| 1405 | ASSERT_TRUE(event0.has_expected_display_frame_start()); |
| 1406 | const auto& expectedDisplayFrameStart = event0.expected_display_frame_start(); |
| 1407 | validateTraceEvent(expectedDisplayFrameStart, protoExpectedDisplayFrameStart); |
| 1408 | |
| 1409 | // Packet - 1 : FrameEnd (ExpectedDisplayFrame) |
| 1410 | const auto& packet1 = packets[1]; |
| 1411 | ASSERT_TRUE(packet1.has_timestamp()); |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 1412 | EXPECT_EQ(packet1.timestamp(), 30u); |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 1413 | ASSERT_TRUE(packet1.has_frame_timeline_event()); |
| 1414 | |
| 1415 | const auto& event1 = packet1.frame_timeline_event(); |
| 1416 | ASSERT_TRUE(event1.has_frame_end()); |
| 1417 | const auto& expectedDisplayFrameEnd = event1.frame_end(); |
| 1418 | validateTraceEvent(expectedDisplayFrameEnd, protoExpectedDisplayFrameEnd); |
| 1419 | |
| 1420 | // Packet - 2 : ActualDisplayFrameStart |
| 1421 | const auto& packet2 = packets[2]; |
| 1422 | ASSERT_TRUE(packet2.has_timestamp()); |
Siarhei Vishniakou | fc434ac | 2021-01-13 10:28:00 -1000 | [diff] [blame] | 1423 | EXPECT_EQ(packet2.timestamp(), 20u); |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 1424 | ASSERT_TRUE(packet2.has_frame_timeline_event()); |
| 1425 | |
| 1426 | const auto& event2 = packet2.frame_timeline_event(); |
| 1427 | ASSERT_TRUE(event2.has_actual_display_frame_start()); |
| 1428 | const auto& actualDisplayFrameStart = event2.actual_display_frame_start(); |
| 1429 | validateTraceEvent(actualDisplayFrameStart, protoActualDisplayFrameStart); |
| 1430 | |
| 1431 | // Packet - 3 : FrameEnd (ActualDisplayFrame) |
| 1432 | const auto& packet3 = packets[3]; |
| 1433 | ASSERT_TRUE(packet3.has_timestamp()); |
Adithya Srinivasan | 1a97163 | 2021-02-26 23:10:29 +0000 | [diff] [blame] | 1434 | EXPECT_EQ(packet3.timestamp(), 31u); |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 1435 | ASSERT_TRUE(packet3.has_frame_timeline_event()); |
| 1436 | |
| 1437 | const auto& event3 = packet3.frame_timeline_event(); |
| 1438 | ASSERT_TRUE(event3.has_frame_end()); |
| 1439 | const auto& actualDisplayFrameEnd = event3.frame_end(); |
| 1440 | validateTraceEvent(actualDisplayFrameEnd, protoActualDisplayFrameEnd); |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 1441 | } |
| 1442 | |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 1443 | TEST_F(FrameTimelineTest, traceDisplayFrame_predictionExpiredDoesNotTraceExpectedTimeline) { |
| 1444 | auto tracingSession = getTracingSessionForTest(); |
| 1445 | auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
| 1446 | |
| 1447 | tracingSession->StartBlocking(); |
| 1448 | int64_t displayFrameToken1 = mTokenManager->generateTokenForPredictions({10, 25, 30}); |
| 1449 | // Flush the token so that it would expire |
Adithya Srinivasan | bed4c4f | 2021-05-03 20:24:46 +0000 | [diff] [blame] | 1450 | flushTokens(); |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 1451 | |
Ady Abraham | 57a8ab4 | 2023-01-26 15:28:19 -0800 | [diff] [blame] | 1452 | // Add an empty surface frame so that display frame would get traced. |
| 1453 | addEmptySurfaceFrame(); |
| 1454 | |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 1455 | // Set up the display frame |
Pascal Muetschard | ac7bcd9 | 2023-10-03 15:05:36 +0200 | [diff] [blame] | 1456 | mFrameTimeline->setSfWakeUp(displayFrameToken1, 20, RR_11, RR_11); |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 1457 | mFrameTimeline->setSfPresent(26, presentFence1); |
| 1458 | presentFence1->signalForTest(31); |
| 1459 | |
| 1460 | int64_t traceCookie = snoopCurrentTraceCookie(); |
| 1461 | |
| 1462 | auto protoActualDisplayFrameStart = |
| 1463 | createProtoActualDisplayFrameStart(traceCookie + 1, displayFrameToken1, |
| 1464 | kSurfaceFlingerPid, |
| 1465 | FrameTimelineEvent::PRESENT_UNSPECIFIED, false, |
Adithya Srinivasan | 78e58af | 2021-02-25 00:08:08 +0000 | [diff] [blame] | 1466 | false, FrameTimelineEvent::JANK_UNKNOWN, |
Ying Wei | 96eb535 | 2023-11-21 17:37:21 +0000 | [diff] [blame] | 1467 | FrameTimelineEvent::SEVERITY_UNKNOWN, |
Adithya Srinivasan | 78e58af | 2021-02-25 00:08:08 +0000 | [diff] [blame] | 1468 | FrameTimelineEvent::PREDICTION_EXPIRED); |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 1469 | auto protoActualDisplayFrameEnd = createProtoFrameEnd(traceCookie + 1); |
| 1470 | |
| 1471 | addEmptyDisplayFrame(); |
| 1472 | flushTrace(); |
| 1473 | tracingSession->StopBlocking(); |
| 1474 | |
| 1475 | auto packets = readFrameTimelinePacketsBlocking(tracingSession.get()); |
| 1476 | // Only actual timeline packets should be in the trace |
| 1477 | EXPECT_EQ(packets.size(), 2u); |
| 1478 | |
| 1479 | // Packet - 0 : ActualDisplayFrameStart |
| 1480 | const auto& packet0 = packets[0]; |
| 1481 | ASSERT_TRUE(packet0.has_timestamp()); |
| 1482 | EXPECT_EQ(packet0.timestamp(), 20u); |
| 1483 | ASSERT_TRUE(packet0.has_frame_timeline_event()); |
| 1484 | |
| 1485 | const auto& event0 = packet0.frame_timeline_event(); |
| 1486 | ASSERT_TRUE(event0.has_actual_display_frame_start()); |
| 1487 | const auto& actualDisplayFrameStart = event0.actual_display_frame_start(); |
| 1488 | validateTraceEvent(actualDisplayFrameStart, protoActualDisplayFrameStart); |
| 1489 | |
| 1490 | // Packet - 1 : FrameEnd (ActualDisplayFrame) |
| 1491 | const auto& packet1 = packets[1]; |
| 1492 | ASSERT_TRUE(packet1.has_timestamp()); |
Adithya Srinivasan | 1a97163 | 2021-02-26 23:10:29 +0000 | [diff] [blame] | 1493 | EXPECT_EQ(packet1.timestamp(), 31u); |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 1494 | ASSERT_TRUE(packet1.has_frame_timeline_event()); |
| 1495 | |
| 1496 | const auto& event1 = packet1.frame_timeline_event(); |
| 1497 | ASSERT_TRUE(event1.has_frame_end()); |
| 1498 | const auto& actualDisplayFrameEnd = event1.frame_end(); |
| 1499 | validateTraceEvent(actualDisplayFrameEnd, protoActualDisplayFrameEnd); |
| 1500 | } |
| 1501 | |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 1502 | TEST_F(FrameTimelineTest, traceSurfaceFrame_emitsValidTracePacket) { |
| 1503 | auto tracingSession = getTracingSessionForTest(); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1504 | // Layer specific increment |
Edgar Arriaga | 631e425 | 2023-03-02 02:11:24 +0000 | [diff] [blame] | 1505 | EXPECT_CALL(*mTimeStats, incrementJankyFrames(_)).Times(2); |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 1506 | auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
| 1507 | auto presentFence2 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
| 1508 | |
| 1509 | tracingSession->StartBlocking(); |
| 1510 | int64_t surfaceFrameToken = mTokenManager->generateTokenForPredictions({10, 25, 40}); |
| 1511 | int64_t displayFrameToken1 = mTokenManager->generateTokenForPredictions({30, 35, 40}); |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 1512 | |
Huihong Luo | 3bdef86 | 2022-03-03 11:57:19 -0800 | [diff] [blame] | 1513 | FrameTimelineInfo ftInfo; |
| 1514 | ftInfo.vsyncId = surfaceFrameToken; |
| 1515 | ftInfo.inputEventId = sInputEventId; |
| 1516 | |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 1517 | auto surfaceFrame1 = |
Huihong Luo | 3bdef86 | 2022-03-03 11:57:19 -0800 | [diff] [blame] | 1518 | mFrameTimeline->createSurfaceFrameForToken(ftInfo, sPidOne, sUidOne, sLayerIdOne, |
| 1519 | sLayerNameOne, sLayerNameOne, |
| 1520 | /*isBuffer*/ true, sGameMode); |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 1521 | auto surfaceFrame2 = |
Huihong Luo | 3bdef86 | 2022-03-03 11:57:19 -0800 | [diff] [blame] | 1522 | mFrameTimeline->createSurfaceFrameForToken(ftInfo, sPidOne, sUidOne, sLayerIdOne, |
| 1523 | sLayerNameOne, sLayerNameOne, |
| 1524 | /*isBuffer*/ true, sGameMode); |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 1525 | surfaceFrame1->setActualQueueTime(10); |
| 1526 | surfaceFrame1->setDropTime(15); |
| 1527 | |
| 1528 | surfaceFrame2->setActualQueueTime(15); |
| 1529 | surfaceFrame2->setAcquireFenceTime(20); |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 1530 | |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 1531 | // First 2 cookies will be used by the DisplayFrame |
| 1532 | int64_t traceCookie = snoopCurrentTraceCookie() + 2; |
| 1533 | |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 1534 | auto protoDroppedSurfaceFrameExpectedStart = |
| 1535 | createProtoExpectedSurfaceFrameStart(traceCookie + 1, surfaceFrameToken, |
| 1536 | displayFrameToken1, sPidOne, sLayerNameOne); |
| 1537 | auto protoDroppedSurfaceFrameExpectedEnd = createProtoFrameEnd(traceCookie + 1); |
| 1538 | auto protoDroppedSurfaceFrameActualStart = |
| 1539 | createProtoActualSurfaceFrameStart(traceCookie + 2, surfaceFrameToken, |
| 1540 | displayFrameToken1, sPidOne, sLayerNameOne, |
Edgar Arriaga | 631e425 | 2023-03-02 02:11:24 +0000 | [diff] [blame] | 1541 | FrameTimelineEvent::PRESENT_DROPPED, true, false, |
| 1542 | FrameTimelineEvent::JANK_DROPPED, |
Ying Wei | 96eb535 | 2023-11-21 17:37:21 +0000 | [diff] [blame] | 1543 | FrameTimelineEvent::SEVERITY_UNKNOWN, |
Adithya Srinivasan | 1f9450c | 2021-06-10 22:39:19 +0000 | [diff] [blame] | 1544 | FrameTimelineEvent::PREDICTION_VALID, true); |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 1545 | auto protoDroppedSurfaceFrameActualEnd = createProtoFrameEnd(traceCookie + 2); |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 1546 | |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 1547 | auto protoPresentedSurfaceFrameExpectedStart = |
| 1548 | createProtoExpectedSurfaceFrameStart(traceCookie + 3, surfaceFrameToken, |
| 1549 | displayFrameToken1, sPidOne, sLayerNameOne); |
| 1550 | auto protoPresentedSurfaceFrameExpectedEnd = createProtoFrameEnd(traceCookie + 3); |
| 1551 | auto protoPresentedSurfaceFrameActualStart = |
| 1552 | createProtoActualSurfaceFrameStart(traceCookie + 4, surfaceFrameToken, |
| 1553 | displayFrameToken1, sPidOne, sLayerNameOne, |
| 1554 | FrameTimelineEvent::PRESENT_ON_TIME, true, false, |
Adithya Srinivasan | 78e58af | 2021-02-25 00:08:08 +0000 | [diff] [blame] | 1555 | FrameTimelineEvent::JANK_NONE, |
Ying Wei | 96eb535 | 2023-11-21 17:37:21 +0000 | [diff] [blame] | 1556 | FrameTimelineEvent::SEVERITY_NONE, |
Adithya Srinivasan | 1f9450c | 2021-06-10 22:39:19 +0000 | [diff] [blame] | 1557 | FrameTimelineEvent::PREDICTION_VALID, true); |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 1558 | auto protoPresentedSurfaceFrameActualEnd = createProtoFrameEnd(traceCookie + 4); |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 1559 | |
| 1560 | // Set up the display frame |
Pascal Muetschard | ac7bcd9 | 2023-10-03 15:05:36 +0200 | [diff] [blame] | 1561 | mFrameTimeline->setSfWakeUp(displayFrameToken1, 20, RR_11, RR_11); |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 1562 | surfaceFrame1->setPresentState(SurfaceFrame::PresentState::Dropped); |
| 1563 | surfaceFrame2->setPresentState(SurfaceFrame::PresentState::Presented); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1564 | mFrameTimeline->addSurfaceFrame(surfaceFrame1); |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 1565 | mFrameTimeline->addSurfaceFrame(surfaceFrame2); |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 1566 | mFrameTimeline->setSfPresent(26, presentFence1); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1567 | presentFence1->signalForTest(40); |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 1568 | |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 1569 | addEmptyDisplayFrame(); |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 1570 | flushTrace(); |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 1571 | tracingSession->StopBlocking(); |
| 1572 | |
| 1573 | auto packets = readFrameTimelinePacketsBlocking(tracingSession.get()); |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 1574 | // 4 DisplayFrame + 4 DroppedSurfaceFrame + 4 PresentedSurfaceFrame |
| 1575 | EXPECT_EQ(packets.size(), 12u); |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 1576 | |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 1577 | // Packet - 4 : ExpectedSurfaceFrameStart1 |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 1578 | const auto& packet4 = packets[4]; |
| 1579 | ASSERT_TRUE(packet4.has_timestamp()); |
Siarhei Vishniakou | fc434ac | 2021-01-13 10:28:00 -1000 | [diff] [blame] | 1580 | EXPECT_EQ(packet4.timestamp(), 10u); |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 1581 | ASSERT_TRUE(packet4.has_frame_timeline_event()); |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 1582 | |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 1583 | const auto& event4 = packet4.frame_timeline_event(); |
| 1584 | ASSERT_TRUE(event4.has_expected_surface_frame_start()); |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 1585 | const auto& expectedSurfaceFrameStart1 = event4.expected_surface_frame_start(); |
| 1586 | validateTraceEvent(expectedSurfaceFrameStart1, protoDroppedSurfaceFrameExpectedStart); |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 1587 | |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 1588 | // Packet - 5 : FrameEnd (ExpectedSurfaceFrame1) |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 1589 | const auto& packet5 = packets[5]; |
| 1590 | ASSERT_TRUE(packet5.has_timestamp()); |
Siarhei Vishniakou | fc434ac | 2021-01-13 10:28:00 -1000 | [diff] [blame] | 1591 | EXPECT_EQ(packet5.timestamp(), 25u); |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 1592 | ASSERT_TRUE(packet5.has_frame_timeline_event()); |
| 1593 | |
| 1594 | const auto& event5 = packet5.frame_timeline_event(); |
| 1595 | ASSERT_TRUE(event5.has_frame_end()); |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 1596 | const auto& expectedSurfaceFrameEnd1 = event5.frame_end(); |
| 1597 | validateTraceEvent(expectedSurfaceFrameEnd1, protoDroppedSurfaceFrameExpectedEnd); |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 1598 | |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 1599 | // Packet - 6 : ActualSurfaceFrameStart1 |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 1600 | const auto& packet6 = packets[6]; |
| 1601 | ASSERT_TRUE(packet6.has_timestamp()); |
Siarhei Vishniakou | fc434ac | 2021-01-13 10:28:00 -1000 | [diff] [blame] | 1602 | EXPECT_EQ(packet6.timestamp(), 10u); |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 1603 | ASSERT_TRUE(packet6.has_frame_timeline_event()); |
| 1604 | |
| 1605 | const auto& event6 = packet6.frame_timeline_event(); |
| 1606 | ASSERT_TRUE(event6.has_actual_surface_frame_start()); |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 1607 | const auto& actualSurfaceFrameStart1 = event6.actual_surface_frame_start(); |
| 1608 | validateTraceEvent(actualSurfaceFrameStart1, protoDroppedSurfaceFrameActualStart); |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 1609 | |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 1610 | // Packet - 7 : FrameEnd (ActualSurfaceFrame1) |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 1611 | const auto& packet7 = packets[7]; |
| 1612 | ASSERT_TRUE(packet7.has_timestamp()); |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 1613 | EXPECT_EQ(packet7.timestamp(), 15u); |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 1614 | ASSERT_TRUE(packet7.has_frame_timeline_event()); |
| 1615 | |
| 1616 | const auto& event7 = packet7.frame_timeline_event(); |
| 1617 | ASSERT_TRUE(event7.has_frame_end()); |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 1618 | const auto& actualSurfaceFrameEnd1 = event7.frame_end(); |
| 1619 | validateTraceEvent(actualSurfaceFrameEnd1, protoDroppedSurfaceFrameActualEnd); |
| 1620 | |
| 1621 | // Packet - 8 : ExpectedSurfaceFrameStart2 |
| 1622 | const auto& packet8 = packets[8]; |
| 1623 | ASSERT_TRUE(packet8.has_timestamp()); |
| 1624 | EXPECT_EQ(packet8.timestamp(), 10u); |
| 1625 | ASSERT_TRUE(packet8.has_frame_timeline_event()); |
| 1626 | |
| 1627 | const auto& event8 = packet8.frame_timeline_event(); |
| 1628 | ASSERT_TRUE(event8.has_expected_surface_frame_start()); |
| 1629 | const auto& expectedSurfaceFrameStart2 = event8.expected_surface_frame_start(); |
| 1630 | validateTraceEvent(expectedSurfaceFrameStart2, protoPresentedSurfaceFrameExpectedStart); |
| 1631 | |
| 1632 | // Packet - 9 : FrameEnd (ExpectedSurfaceFrame2) |
| 1633 | const auto& packet9 = packets[9]; |
| 1634 | ASSERT_TRUE(packet9.has_timestamp()); |
| 1635 | EXPECT_EQ(packet9.timestamp(), 25u); |
| 1636 | ASSERT_TRUE(packet9.has_frame_timeline_event()); |
| 1637 | |
| 1638 | const auto& event9 = packet9.frame_timeline_event(); |
| 1639 | ASSERT_TRUE(event9.has_frame_end()); |
| 1640 | const auto& expectedSurfaceFrameEnd2 = event9.frame_end(); |
| 1641 | validateTraceEvent(expectedSurfaceFrameEnd2, protoPresentedSurfaceFrameExpectedEnd); |
| 1642 | |
| 1643 | // Packet - 10 : ActualSurfaceFrameStart2 |
| 1644 | const auto& packet10 = packets[10]; |
| 1645 | ASSERT_TRUE(packet10.has_timestamp()); |
| 1646 | EXPECT_EQ(packet10.timestamp(), 10u); |
| 1647 | ASSERT_TRUE(packet10.has_frame_timeline_event()); |
| 1648 | |
| 1649 | const auto& event10 = packet10.frame_timeline_event(); |
| 1650 | ASSERT_TRUE(event10.has_actual_surface_frame_start()); |
| 1651 | const auto& actualSurfaceFrameStart2 = event10.actual_surface_frame_start(); |
| 1652 | validateTraceEvent(actualSurfaceFrameStart2, protoPresentedSurfaceFrameActualStart); |
| 1653 | |
| 1654 | // Packet - 11 : FrameEnd (ActualSurfaceFrame2) |
| 1655 | const auto& packet11 = packets[11]; |
| 1656 | ASSERT_TRUE(packet11.has_timestamp()); |
| 1657 | EXPECT_EQ(packet11.timestamp(), 20u); |
| 1658 | ASSERT_TRUE(packet11.has_frame_timeline_event()); |
| 1659 | |
| 1660 | const auto& event11 = packet11.frame_timeline_event(); |
| 1661 | ASSERT_TRUE(event11.has_frame_end()); |
| 1662 | const auto& actualSurfaceFrameEnd2 = event11.frame_end(); |
| 1663 | validateTraceEvent(actualSurfaceFrameEnd2, protoPresentedSurfaceFrameActualEnd); |
| 1664 | } |
| 1665 | |
Ady Abraham | e43ff72 | 2022-02-15 14:44:25 -0800 | [diff] [blame] | 1666 | TEST_F(FrameTimelineTest, traceSurfaceFrame_predictionExpiredIsAppMissedDeadline) { |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 1667 | auto tracingSession = getTracingSessionForTest(); |
| 1668 | auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
| 1669 | |
| 1670 | tracingSession->StartBlocking(); |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 1671 | constexpr nsecs_t appStartTime = std::chrono::nanoseconds(10ms).count(); |
| 1672 | constexpr nsecs_t appEndTime = std::chrono::nanoseconds(20ms).count(); |
| 1673 | constexpr nsecs_t appPresentTime = std::chrono::nanoseconds(30ms).count(); |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 1674 | int64_t surfaceFrameToken = |
| 1675 | mTokenManager->generateTokenForPredictions({appStartTime, appEndTime, appPresentTime}); |
| 1676 | |
| 1677 | // Flush the token so that it would expire |
Adithya Srinivasan | bed4c4f | 2021-05-03 20:24:46 +0000 | [diff] [blame] | 1678 | flushTokens(); |
Huihong Luo | 3bdef86 | 2022-03-03 11:57:19 -0800 | [diff] [blame] | 1679 | FrameTimelineInfo ftInfo; |
| 1680 | ftInfo.vsyncId = surfaceFrameToken; |
| 1681 | ftInfo.inputEventId = 0; |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 1682 | auto surfaceFrame1 = |
Huihong Luo | 3bdef86 | 2022-03-03 11:57:19 -0800 | [diff] [blame] | 1683 | mFrameTimeline->createSurfaceFrameForToken(ftInfo, sPidOne, sUidOne, sLayerIdOne, |
| 1684 | sLayerNameOne, sLayerNameOne, |
| 1685 | /*isBuffer*/ true, sGameMode); |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 1686 | surfaceFrame1->setActualQueueTime(appEndTime); |
| 1687 | surfaceFrame1->setAcquireFenceTime(appEndTime); |
| 1688 | |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 1689 | constexpr nsecs_t sfStartTime = std::chrono::nanoseconds(20ms).count(); |
| 1690 | constexpr nsecs_t sfEndTime = std::chrono::nanoseconds(30ms).count(); |
| 1691 | constexpr nsecs_t sfPresentTime = std::chrono::nanoseconds(30ms).count(); |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 1692 | int64_t displayFrameToken = |
| 1693 | mTokenManager->generateTokenForPredictions({sfStartTime, sfEndTime, sfPresentTime}); |
| 1694 | |
| 1695 | // First 2 cookies will be used by the DisplayFrame |
| 1696 | int64_t traceCookie = snoopCurrentTraceCookie() + 2; |
| 1697 | |
| 1698 | auto protoActualSurfaceFrameStart = |
| 1699 | createProtoActualSurfaceFrameStart(traceCookie + 1, surfaceFrameToken, |
| 1700 | displayFrameToken, sPidOne, sLayerNameOne, |
| 1701 | FrameTimelineEvent::PRESENT_UNSPECIFIED, false, |
Ady Abraham | e43ff72 | 2022-02-15 14:44:25 -0800 | [diff] [blame] | 1702 | false, FrameTimelineEvent::JANK_APP_DEADLINE_MISSED, |
Ying Wei | 96eb535 | 2023-11-21 17:37:21 +0000 | [diff] [blame] | 1703 | FrameTimelineEvent::SEVERITY_UNKNOWN, |
Adithya Srinivasan | 1f9450c | 2021-06-10 22:39:19 +0000 | [diff] [blame] | 1704 | FrameTimelineEvent::PREDICTION_EXPIRED, true); |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 1705 | auto protoActualSurfaceFrameEnd = createProtoFrameEnd(traceCookie + 1); |
| 1706 | |
| 1707 | // Set up the display frame |
Pascal Muetschard | ac7bcd9 | 2023-10-03 15:05:36 +0200 | [diff] [blame] | 1708 | mFrameTimeline->setSfWakeUp(displayFrameToken, sfStartTime, RR_11, RR_11); |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 1709 | surfaceFrame1->setPresentState(SurfaceFrame::PresentState::Presented); |
| 1710 | mFrameTimeline->addSurfaceFrame(surfaceFrame1); |
| 1711 | mFrameTimeline->setSfPresent(sfEndTime, presentFence1); |
| 1712 | presentFence1->signalForTest(sfPresentTime); |
| 1713 | |
| 1714 | addEmptyDisplayFrame(); |
| 1715 | flushTrace(); |
| 1716 | tracingSession->StopBlocking(); |
| 1717 | |
| 1718 | auto packets = readFrameTimelinePacketsBlocking(tracingSession.get()); |
| 1719 | // Display Frame 4 packets + SurfaceFrame 2 packets |
| 1720 | ASSERT_EQ(packets.size(), 6u); |
| 1721 | |
| 1722 | // Packet - 4 : ActualSurfaceFrameStart |
| 1723 | const auto& packet4 = packets[4]; |
| 1724 | ASSERT_TRUE(packet4.has_timestamp()); |
| 1725 | EXPECT_EQ(packet4.timestamp(), |
| 1726 | static_cast<uint64_t>(appEndTime - SurfaceFrame::kPredictionExpiredStartTimeDelta)); |
| 1727 | ASSERT_TRUE(packet4.has_frame_timeline_event()); |
| 1728 | |
| 1729 | const auto& event4 = packet4.frame_timeline_event(); |
| 1730 | ASSERT_TRUE(event4.has_actual_surface_frame_start()); |
| 1731 | const auto& actualSurfaceFrameStart = event4.actual_surface_frame_start(); |
| 1732 | validateTraceEvent(actualSurfaceFrameStart, protoActualSurfaceFrameStart); |
| 1733 | |
| 1734 | // Packet - 5 : FrameEnd (ActualSurfaceFrame) |
| 1735 | const auto& packet5 = packets[5]; |
| 1736 | ASSERT_TRUE(packet5.has_timestamp()); |
| 1737 | EXPECT_EQ(packet5.timestamp(), static_cast<uint64_t>(appEndTime)); |
| 1738 | ASSERT_TRUE(packet5.has_frame_timeline_event()); |
| 1739 | |
| 1740 | const auto& event5 = packet5.frame_timeline_event(); |
| 1741 | ASSERT_TRUE(event5.has_frame_end()); |
| 1742 | const auto& actualSurfaceFrameEnd = event5.frame_end(); |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 1743 | validateTraceEvent(actualSurfaceFrameEnd, protoActualSurfaceFrameEnd); |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 1744 | } |
| 1745 | |
Adithya Srinivasan | b2283c3 | 2021-04-21 21:31:56 +0000 | [diff] [blame] | 1746 | TEST_F(FrameTimelineTest, traceSurfaceFrame_predictionExpiredDroppedFramesTracedProperly) { |
| 1747 | auto tracingSession = getTracingSessionForTest(); |
| 1748 | auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
| 1749 | |
| 1750 | tracingSession->StartBlocking(); |
| 1751 | constexpr nsecs_t appStartTime = std::chrono::nanoseconds(10ms).count(); |
| 1752 | constexpr nsecs_t appEndTime = std::chrono::nanoseconds(20ms).count(); |
| 1753 | constexpr nsecs_t appPresentTime = std::chrono::nanoseconds(30ms).count(); |
| 1754 | int64_t surfaceFrameToken = |
| 1755 | mTokenManager->generateTokenForPredictions({appStartTime, appEndTime, appPresentTime}); |
| 1756 | |
| 1757 | // Flush the token so that it would expire |
Adithya Srinivasan | bed4c4f | 2021-05-03 20:24:46 +0000 | [diff] [blame] | 1758 | flushTokens(); |
Huihong Luo | 3bdef86 | 2022-03-03 11:57:19 -0800 | [diff] [blame] | 1759 | FrameTimelineInfo ftInfo; |
| 1760 | ftInfo.vsyncId = surfaceFrameToken; |
| 1761 | ftInfo.inputEventId = 0; |
Adithya Srinivasan | b2283c3 | 2021-04-21 21:31:56 +0000 | [diff] [blame] | 1762 | auto surfaceFrame1 = |
Huihong Luo | 3bdef86 | 2022-03-03 11:57:19 -0800 | [diff] [blame] | 1763 | mFrameTimeline->createSurfaceFrameForToken(ftInfo, sPidOne, sUidOne, sLayerIdOne, |
| 1764 | sLayerNameOne, sLayerNameOne, |
| 1765 | /*isBuffer*/ true, sGameMode); |
Adithya Srinivasan | b2283c3 | 2021-04-21 21:31:56 +0000 | [diff] [blame] | 1766 | |
| 1767 | constexpr nsecs_t sfStartTime = std::chrono::nanoseconds(22ms).count(); |
| 1768 | constexpr nsecs_t sfEndTime = std::chrono::nanoseconds(30ms).count(); |
| 1769 | constexpr nsecs_t sfPresentTime = std::chrono::nanoseconds(30ms).count(); |
| 1770 | int64_t displayFrameToken = |
| 1771 | mTokenManager->generateTokenForPredictions({sfStartTime, sfEndTime, sfPresentTime}); |
| 1772 | |
| 1773 | // First 2 cookies will be used by the DisplayFrame |
| 1774 | int64_t traceCookie = snoopCurrentTraceCookie() + 2; |
| 1775 | |
| 1776 | auto protoActualSurfaceFrameStart = |
| 1777 | createProtoActualSurfaceFrameStart(traceCookie + 1, surfaceFrameToken, |
| 1778 | displayFrameToken, sPidOne, sLayerNameOne, |
| 1779 | FrameTimelineEvent::PRESENT_DROPPED, false, false, |
Edgar Arriaga | 631e425 | 2023-03-02 02:11:24 +0000 | [diff] [blame] | 1780 | FrameTimelineEvent::JANK_DROPPED, |
Ying Wei | 96eb535 | 2023-11-21 17:37:21 +0000 | [diff] [blame] | 1781 | FrameTimelineEvent::SEVERITY_UNKNOWN, |
Adithya Srinivasan | 1f9450c | 2021-06-10 22:39:19 +0000 | [diff] [blame] | 1782 | FrameTimelineEvent::PREDICTION_EXPIRED, true); |
Adithya Srinivasan | b2283c3 | 2021-04-21 21:31:56 +0000 | [diff] [blame] | 1783 | auto protoActualSurfaceFrameEnd = createProtoFrameEnd(traceCookie + 1); |
| 1784 | |
| 1785 | // Set up the display frame |
Pascal Muetschard | ac7bcd9 | 2023-10-03 15:05:36 +0200 | [diff] [blame] | 1786 | mFrameTimeline->setSfWakeUp(displayFrameToken, sfStartTime, RR_11, RR_11); |
Adithya Srinivasan | b2283c3 | 2021-04-21 21:31:56 +0000 | [diff] [blame] | 1787 | surfaceFrame1->setDropTime(sfStartTime); |
| 1788 | surfaceFrame1->setPresentState(SurfaceFrame::PresentState::Dropped); |
| 1789 | mFrameTimeline->addSurfaceFrame(surfaceFrame1); |
| 1790 | mFrameTimeline->setSfPresent(sfEndTime, presentFence1); |
| 1791 | presentFence1->signalForTest(sfPresentTime); |
| 1792 | |
| 1793 | addEmptyDisplayFrame(); |
| 1794 | flushTrace(); |
| 1795 | tracingSession->StopBlocking(); |
| 1796 | |
| 1797 | auto packets = readFrameTimelinePacketsBlocking(tracingSession.get()); |
| 1798 | // Display Frame 4 packets + SurfaceFrame 2 packets |
| 1799 | ASSERT_EQ(packets.size(), 6u); |
| 1800 | |
| 1801 | // Packet - 4 : ActualSurfaceFrameStart |
| 1802 | const auto& packet4 = packets[4]; |
| 1803 | ASSERT_TRUE(packet4.has_timestamp()); |
| 1804 | EXPECT_EQ(packet4.timestamp(), |
| 1805 | static_cast<uint64_t>(sfStartTime - SurfaceFrame::kPredictionExpiredStartTimeDelta)); |
| 1806 | ASSERT_TRUE(packet4.has_frame_timeline_event()); |
| 1807 | |
| 1808 | const auto& event4 = packet4.frame_timeline_event(); |
| 1809 | ASSERT_TRUE(event4.has_actual_surface_frame_start()); |
| 1810 | const auto& actualSurfaceFrameStart = event4.actual_surface_frame_start(); |
| 1811 | validateTraceEvent(actualSurfaceFrameStart, protoActualSurfaceFrameStart); |
| 1812 | |
| 1813 | // Packet - 5 : FrameEnd (ActualSurfaceFrame) |
| 1814 | const auto& packet5 = packets[5]; |
| 1815 | ASSERT_TRUE(packet5.has_timestamp()); |
| 1816 | EXPECT_EQ(packet5.timestamp(), static_cast<uint64_t>(sfStartTime)); |
| 1817 | ASSERT_TRUE(packet5.has_frame_timeline_event()); |
| 1818 | |
| 1819 | const auto& event5 = packet5.frame_timeline_event(); |
| 1820 | ASSERT_TRUE(event5.has_frame_end()); |
| 1821 | const auto& actualSurfaceFrameEnd = event5.frame_end(); |
| 1822 | validateTraceEvent(actualSurfaceFrameEnd, protoActualSurfaceFrameEnd); |
| 1823 | } |
| 1824 | |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1825 | // Tests for Jank classification |
| 1826 | TEST_F(FrameTimelineTest, jankClassification_presentOnTimeDoesNotClassify) { |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1827 | // Layer specific increment |
Alec Mouri | 363faf0 | 2021-01-29 16:34:55 -0800 | [diff] [blame] | 1828 | EXPECT_CALL(*mTimeStats, incrementJankyFrames(_)); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1829 | auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
| 1830 | int64_t surfaceFrameToken = mTokenManager->generateTokenForPredictions({10, 20, 30}); |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 1831 | int64_t sfToken1 = mTokenManager->generateTokenForPredictions({22, 30, 30}); |
Huihong Luo | 3bdef86 | 2022-03-03 11:57:19 -0800 | [diff] [blame] | 1832 | FrameTimelineInfo ftInfo; |
| 1833 | ftInfo.vsyncId = surfaceFrameToken; |
| 1834 | ftInfo.inputEventId = sInputEventId; |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1835 | auto surfaceFrame = |
Huihong Luo | 3bdef86 | 2022-03-03 11:57:19 -0800 | [diff] [blame] | 1836 | mFrameTimeline->createSurfaceFrameForToken(ftInfo, sPidOne, sUidOne, sLayerIdOne, |
| 1837 | sLayerNameOne, sLayerNameOne, |
| 1838 | /*isBuffer*/ true, sGameMode); |
Pascal Muetschard | ac7bcd9 | 2023-10-03 15:05:36 +0200 | [diff] [blame] | 1839 | mFrameTimeline->setSfWakeUp(sfToken1, 22, RR_11, RR_11); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1840 | surfaceFrame->setPresentState(SurfaceFrame::PresentState::Presented); |
| 1841 | mFrameTimeline->addSurfaceFrame(surfaceFrame); |
| 1842 | mFrameTimeline->setSfPresent(26, presentFence1); |
| 1843 | auto displayFrame = getDisplayFrame(0); |
| 1844 | auto& presentedSurfaceFrame = getSurfaceFrame(0, 0); |
| 1845 | presentFence1->signalForTest(29); |
| 1846 | |
| 1847 | // Fences haven't been flushed yet, so it should be 0 |
| 1848 | EXPECT_EQ(displayFrame->getActuals().presentTime, 0); |
| 1849 | EXPECT_EQ(presentedSurfaceFrame.getActuals().presentTime, 0); |
| 1850 | |
| 1851 | addEmptyDisplayFrame(); |
| 1852 | displayFrame = getDisplayFrame(0); |
| 1853 | |
| 1854 | // Fences have flushed, so the present timestamps should be updated |
| 1855 | EXPECT_EQ(displayFrame->getActuals().presentTime, 29); |
| 1856 | EXPECT_EQ(presentedSurfaceFrame.getActuals().presentTime, 29); |
| 1857 | EXPECT_EQ(displayFrame->getFramePresentMetadata(), FramePresentMetadata::OnTimePresent); |
| 1858 | EXPECT_EQ(displayFrame->getFrameReadyMetadata(), FrameReadyMetadata::OnTimeFinish); |
| 1859 | EXPECT_EQ(displayFrame->getJankType(), JankType::None); |
Ying Wei | 96eb535 | 2023-11-21 17:37:21 +0000 | [diff] [blame] | 1860 | EXPECT_EQ(displayFrame->getJankSeverityType(), JankSeverityType::None); |
Pascal Mütschard | d56514e | 2024-05-24 17:37:13 +0200 | [diff] [blame] | 1861 | |
| 1862 | auto jankData = getLayerOneJankData(); |
| 1863 | EXPECT_EQ(jankData.size(), 1u); |
| 1864 | EXPECT_EQ(jankData[0].jankType, JankType::None); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1865 | } |
| 1866 | |
| 1867 | TEST_F(FrameTimelineTest, jankClassification_displayFrameOnTimeFinishEarlyPresent) { |
Pascal Muetschard | ac7bcd9 | 2023-10-03 15:05:36 +0200 | [diff] [blame] | 1868 | Fps vsyncRate = RR_11; |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1869 | auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 1870 | int64_t sfToken1 = mTokenManager->generateTokenForPredictions({22, 30, 40}); |
| 1871 | int64_t sfToken2 = mTokenManager->generateTokenForPredictions({52, 60, 70}); |
Pascal Muetschard | ac7bcd9 | 2023-10-03 15:05:36 +0200 | [diff] [blame] | 1872 | mFrameTimeline->setSfWakeUp(sfToken1, 22, vsyncRate, vsyncRate); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1873 | mFrameTimeline->setSfPresent(26, presentFence1); |
| 1874 | auto displayFrame = getDisplayFrame(0); |
| 1875 | presentFence1->signalForTest(30); |
| 1876 | |
| 1877 | // Fences for the first frame haven't been flushed yet, so it should be 0 |
| 1878 | EXPECT_EQ(displayFrame->getActuals().presentTime, 0); |
| 1879 | |
| 1880 | // Trigger a flush by finalizing the next DisplayFrame |
| 1881 | auto presentFence2 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
Pascal Muetschard | ac7bcd9 | 2023-10-03 15:05:36 +0200 | [diff] [blame] | 1882 | mFrameTimeline->setSfWakeUp(sfToken2, 52, vsyncRate, vsyncRate); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1883 | mFrameTimeline->setSfPresent(56, presentFence2); |
| 1884 | displayFrame = getDisplayFrame(0); |
| 1885 | |
| 1886 | // Fences for the first frame have flushed, so the present timestamps should be updated |
| 1887 | EXPECT_EQ(displayFrame->getActuals().presentTime, 30); |
| 1888 | EXPECT_EQ(displayFrame->getFramePresentMetadata(), FramePresentMetadata::EarlyPresent); |
| 1889 | EXPECT_EQ(displayFrame->getFrameReadyMetadata(), FrameReadyMetadata::OnTimeFinish); |
| 1890 | EXPECT_EQ(displayFrame->getJankType(), JankType::SurfaceFlingerScheduling); |
Ying Wei | 96eb535 | 2023-11-21 17:37:21 +0000 | [diff] [blame] | 1891 | EXPECT_EQ(displayFrame->getJankSeverityType(), JankSeverityType::Partial); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1892 | |
| 1893 | // Fences for the second frame haven't been flushed yet, so it should be 0 |
| 1894 | auto displayFrame2 = getDisplayFrame(1); |
| 1895 | presentFence2->signalForTest(65); |
| 1896 | EXPECT_EQ(displayFrame2->getActuals().presentTime, 0); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1897 | addEmptyDisplayFrame(); |
| 1898 | displayFrame2 = getDisplayFrame(1); |
| 1899 | |
| 1900 | // Fences for the second frame have flushed, so the present timestamps should be updated |
| 1901 | EXPECT_EQ(displayFrame2->getActuals().presentTime, 65); |
| 1902 | EXPECT_EQ(displayFrame2->getFramePresentMetadata(), FramePresentMetadata::EarlyPresent); |
| 1903 | EXPECT_EQ(displayFrame2->getFrameReadyMetadata(), FrameReadyMetadata::OnTimeFinish); |
| 1904 | EXPECT_EQ(displayFrame2->getJankType(), JankType::PredictionError); |
Ying Wei | 96eb535 | 2023-11-21 17:37:21 +0000 | [diff] [blame] | 1905 | EXPECT_EQ(displayFrame->getJankSeverityType(), JankSeverityType::Partial); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1906 | } |
| 1907 | |
| 1908 | TEST_F(FrameTimelineTest, jankClassification_displayFrameOnTimeFinishLatePresent) { |
Pascal Muetschard | ac7bcd9 | 2023-10-03 15:05:36 +0200 | [diff] [blame] | 1909 | Fps vsyncRate = RR_11; |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1910 | auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 1911 | int64_t sfToken1 = mTokenManager->generateTokenForPredictions({22, 30, 40}); |
| 1912 | int64_t sfToken2 = mTokenManager->generateTokenForPredictions({52, 60, 70}); |
Pascal Muetschard | ac7bcd9 | 2023-10-03 15:05:36 +0200 | [diff] [blame] | 1913 | mFrameTimeline->setSfWakeUp(sfToken1, 22, vsyncRate, vsyncRate); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1914 | mFrameTimeline->setSfPresent(26, presentFence1); |
| 1915 | auto displayFrame = getDisplayFrame(0); |
| 1916 | presentFence1->signalForTest(50); |
| 1917 | |
| 1918 | // Fences for the first frame haven't been flushed yet, so it should be 0 |
| 1919 | EXPECT_EQ(displayFrame->getActuals().presentTime, 0); |
| 1920 | |
| 1921 | // Trigger a flush by finalizing the next DisplayFrame |
| 1922 | auto presentFence2 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
Pascal Muetschard | ac7bcd9 | 2023-10-03 15:05:36 +0200 | [diff] [blame] | 1923 | mFrameTimeline->setSfWakeUp(sfToken2, 52, vsyncRate, vsyncRate); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1924 | mFrameTimeline->setSfPresent(56, presentFence2); |
| 1925 | displayFrame = getDisplayFrame(0); |
| 1926 | |
| 1927 | // Fences for the first frame have flushed, so the present timestamps should be updated |
| 1928 | EXPECT_EQ(displayFrame->getActuals().presentTime, 50); |
| 1929 | EXPECT_EQ(displayFrame->getFramePresentMetadata(), FramePresentMetadata::LatePresent); |
| 1930 | EXPECT_EQ(displayFrame->getFrameReadyMetadata(), FrameReadyMetadata::OnTimeFinish); |
| 1931 | EXPECT_EQ(displayFrame->getJankType(), JankType::DisplayHAL); |
Ying Wei | 96eb535 | 2023-11-21 17:37:21 +0000 | [diff] [blame] | 1932 | EXPECT_EQ(displayFrame->getJankSeverityType(), JankSeverityType::Partial); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1933 | |
| 1934 | // Fences for the second frame haven't been flushed yet, so it should be 0 |
| 1935 | auto displayFrame2 = getDisplayFrame(1); |
| 1936 | presentFence2->signalForTest(75); |
| 1937 | EXPECT_EQ(displayFrame2->getActuals().presentTime, 0); |
| 1938 | |
| 1939 | addEmptyDisplayFrame(); |
| 1940 | displayFrame2 = getDisplayFrame(1); |
| 1941 | |
| 1942 | // Fences for the second frame have flushed, so the present timestamps should be updated |
| 1943 | EXPECT_EQ(displayFrame2->getActuals().presentTime, 75); |
| 1944 | EXPECT_EQ(displayFrame2->getFramePresentMetadata(), FramePresentMetadata::LatePresent); |
| 1945 | EXPECT_EQ(displayFrame2->getFrameReadyMetadata(), FrameReadyMetadata::OnTimeFinish); |
| 1946 | EXPECT_EQ(displayFrame2->getJankType(), JankType::PredictionError); |
Ying Wei | 96eb535 | 2023-11-21 17:37:21 +0000 | [diff] [blame] | 1947 | EXPECT_EQ(displayFrame->getJankSeverityType(), JankSeverityType::Partial); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1948 | } |
| 1949 | |
| 1950 | TEST_F(FrameTimelineTest, jankClassification_displayFrameLateFinishEarlyPresent) { |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1951 | auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
| 1952 | int64_t sfToken1 = mTokenManager->generateTokenForPredictions({12, 18, 40}); |
Pascal Muetschard | ac7bcd9 | 2023-10-03 15:05:36 +0200 | [diff] [blame] | 1953 | mFrameTimeline->setSfWakeUp(sfToken1, 12, RR_11, RR_11); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1954 | |
| 1955 | mFrameTimeline->setSfPresent(22, presentFence1); |
| 1956 | auto displayFrame = getDisplayFrame(0); |
| 1957 | presentFence1->signalForTest(28); |
| 1958 | |
| 1959 | // Fences haven't been flushed yet, so it should be 0 |
| 1960 | EXPECT_EQ(displayFrame->getActuals().presentTime, 0); |
| 1961 | |
| 1962 | addEmptyDisplayFrame(); |
| 1963 | displayFrame = getDisplayFrame(0); |
| 1964 | |
| 1965 | // Fences have flushed, so the present timestamps should be updated |
| 1966 | EXPECT_EQ(displayFrame->getActuals().presentTime, 28); |
| 1967 | EXPECT_EQ(displayFrame->getFramePresentMetadata(), FramePresentMetadata::EarlyPresent); |
| 1968 | EXPECT_EQ(displayFrame->getFrameReadyMetadata(), FrameReadyMetadata::LateFinish); |
| 1969 | EXPECT_EQ(displayFrame->getJankType(), JankType::SurfaceFlingerScheduling); |
Ying Wei | 96eb535 | 2023-11-21 17:37:21 +0000 | [diff] [blame] | 1970 | EXPECT_EQ(displayFrame->getJankSeverityType(), JankSeverityType::Full); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1971 | } |
| 1972 | |
| 1973 | TEST_F(FrameTimelineTest, jankClassification_displayFrameLateFinishLatePresent) { |
Adithya Srinivasan | 36b01af | 2021-04-07 22:29:47 +0000 | [diff] [blame] | 1974 | /* |
| 1975 | * Case 1 - cpu time > vsync period but combined time > deadline > deadline -> cpudeadlinemissed |
| 1976 | * Case 2 - cpu time < vsync period but combined time > deadline -> gpudeadlinemissed |
Adithya Srinivasan | 57dc81d | 2021-04-14 17:31:41 +0000 | [diff] [blame] | 1977 | * Case 3 - previous frame ran longer -> sf_stuffing |
| 1978 | * Case 4 - Long cpu under SF stuffing -> cpudeadlinemissed |
Adithya Srinivasan | 36b01af | 2021-04-07 22:29:47 +0000 | [diff] [blame] | 1979 | */ |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1980 | auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
Adithya Srinivasan | 36b01af | 2021-04-07 22:29:47 +0000 | [diff] [blame] | 1981 | auto presentFence2 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
Adithya Srinivasan | 57dc81d | 2021-04-14 17:31:41 +0000 | [diff] [blame] | 1982 | auto presentFence3 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
| 1983 | auto presentFence4 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
Adithya Srinivasan | 36b01af | 2021-04-07 22:29:47 +0000 | [diff] [blame] | 1984 | auto gpuFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
| 1985 | auto gpuFence2 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
Adithya Srinivasan | 57dc81d | 2021-04-14 17:31:41 +0000 | [diff] [blame] | 1986 | auto gpuFence3 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
| 1987 | auto gpuFence4 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1988 | int64_t sfToken1 = mTokenManager->generateTokenForPredictions({22, 26, 40}); |
Adithya Srinivasan | 36b01af | 2021-04-07 22:29:47 +0000 | [diff] [blame] | 1989 | int64_t sfToken2 = mTokenManager->generateTokenForPredictions({52, 60, 60}); |
Adithya Srinivasan | 57dc81d | 2021-04-14 17:31:41 +0000 | [diff] [blame] | 1990 | int64_t sfToken3 = mTokenManager->generateTokenForPredictions({82, 90, 90}); |
| 1991 | int64_t sfToken4 = mTokenManager->generateTokenForPredictions({112, 120, 120}); |
| 1992 | |
Adithya Srinivasan | 36b01af | 2021-04-07 22:29:47 +0000 | [diff] [blame] | 1993 | // case 1 - cpu time = 33 - 12 = 21, vsync period = 11 |
Pascal Muetschard | ac7bcd9 | 2023-10-03 15:05:36 +0200 | [diff] [blame] | 1994 | mFrameTimeline->setSfWakeUp(sfToken1, 12, RR_11, RR_11); |
Adithya Srinivasan | 36b01af | 2021-04-07 22:29:47 +0000 | [diff] [blame] | 1995 | mFrameTimeline->setSfPresent(33, presentFence1, gpuFence1); |
| 1996 | auto displayFrame0 = getDisplayFrame(0); |
| 1997 | gpuFence1->signalForTest(36); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1998 | presentFence1->signalForTest(52); |
| 1999 | |
| 2000 | // Fences haven't been flushed yet, so it should be 0 |
Adithya Srinivasan | 36b01af | 2021-04-07 22:29:47 +0000 | [diff] [blame] | 2001 | EXPECT_EQ(displayFrame0->getActuals().presentTime, 0); |
| 2002 | |
Adithya Srinivasan | 57dc81d | 2021-04-14 17:31:41 +0000 | [diff] [blame] | 2003 | // case 2 - cpu time = 56 - 52 = 4, vsync period = 30 |
Pascal Muetschard | ac7bcd9 | 2023-10-03 15:05:36 +0200 | [diff] [blame] | 2004 | mFrameTimeline->setSfWakeUp(sfToken2, 52, RR_30, RR_30); |
Adithya Srinivasan | 36b01af | 2021-04-07 22:29:47 +0000 | [diff] [blame] | 2005 | mFrameTimeline->setSfPresent(56, presentFence2, gpuFence2); |
| 2006 | auto displayFrame1 = getDisplayFrame(1); |
Adithya Srinivasan | 57dc81d | 2021-04-14 17:31:41 +0000 | [diff] [blame] | 2007 | gpuFence2->signalForTest(76); |
| 2008 | presentFence2->signalForTest(90); |
Adithya Srinivasan | 36b01af | 2021-04-07 22:29:47 +0000 | [diff] [blame] | 2009 | |
| 2010 | EXPECT_EQ(displayFrame1->getActuals().presentTime, 0); |
| 2011 | // Fences have flushed for first displayFrame, so the present timestamps should be updated |
| 2012 | EXPECT_EQ(displayFrame0->getActuals().presentTime, 52); |
| 2013 | EXPECT_EQ(displayFrame0->getFramePresentMetadata(), FramePresentMetadata::LatePresent); |
| 2014 | EXPECT_EQ(displayFrame0->getFrameReadyMetadata(), FrameReadyMetadata::LateFinish); |
Rachel Lee | 94917b3 | 2022-03-18 17:52:09 -0700 | [diff] [blame] | 2015 | EXPECT_EQ(displayFrame0->getJankType(), JankType::SurfaceFlingerGpuDeadlineMissed); |
Ying Wei | 96eb535 | 2023-11-21 17:37:21 +0000 | [diff] [blame] | 2016 | EXPECT_EQ(displayFrame0->getJankSeverityType(), JankSeverityType::Full); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 2017 | |
Adithya Srinivasan | 57dc81d | 2021-04-14 17:31:41 +0000 | [diff] [blame] | 2018 | // case 3 - cpu time = 86 - 82 = 4, vsync period = 30 |
Pascal Muetschard | ac7bcd9 | 2023-10-03 15:05:36 +0200 | [diff] [blame] | 2019 | mFrameTimeline->setSfWakeUp(sfToken3, 106, RR_30, RR_30); |
Adithya Srinivasan | 57dc81d | 2021-04-14 17:31:41 +0000 | [diff] [blame] | 2020 | mFrameTimeline->setSfPresent(112, presentFence3, gpuFence3); |
| 2021 | auto displayFrame2 = getDisplayFrame(2); |
| 2022 | gpuFence3->signalForTest(116); |
| 2023 | presentFence3->signalForTest(120); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 2024 | |
Adithya Srinivasan | 57dc81d | 2021-04-14 17:31:41 +0000 | [diff] [blame] | 2025 | EXPECT_EQ(displayFrame2->getActuals().presentTime, 0); |
Adithya Srinivasan | 36b01af | 2021-04-07 22:29:47 +0000 | [diff] [blame] | 2026 | // Fences have flushed for second displayFrame, so the present timestamps should be updated |
Adithya Srinivasan | 57dc81d | 2021-04-14 17:31:41 +0000 | [diff] [blame] | 2027 | EXPECT_EQ(displayFrame1->getActuals().presentTime, 90); |
Adithya Srinivasan | 36b01af | 2021-04-07 22:29:47 +0000 | [diff] [blame] | 2028 | EXPECT_EQ(displayFrame1->getFramePresentMetadata(), FramePresentMetadata::LatePresent); |
| 2029 | EXPECT_EQ(displayFrame1->getFrameReadyMetadata(), FrameReadyMetadata::LateFinish); |
| 2030 | EXPECT_EQ(displayFrame1->getJankType(), JankType::SurfaceFlingerGpuDeadlineMissed); |
Ying Wei | 96eb535 | 2023-11-21 17:37:21 +0000 | [diff] [blame] | 2031 | EXPECT_EQ(displayFrame1->getJankSeverityType(), JankSeverityType::Full); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 2032 | |
Adithya Srinivasan | 57dc81d | 2021-04-14 17:31:41 +0000 | [diff] [blame] | 2033 | // case 4 - cpu time = 86 - 82 = 4, vsync period = 30 |
Pascal Muetschard | ac7bcd9 | 2023-10-03 15:05:36 +0200 | [diff] [blame] | 2034 | mFrameTimeline->setSfWakeUp(sfToken4, 120, RR_30, RR_30); |
Adithya Srinivasan | 57dc81d | 2021-04-14 17:31:41 +0000 | [diff] [blame] | 2035 | mFrameTimeline->setSfPresent(140, presentFence4, gpuFence4); |
| 2036 | auto displayFrame3 = getDisplayFrame(3); |
| 2037 | gpuFence4->signalForTest(156); |
| 2038 | presentFence4->signalForTest(180); |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 2039 | |
Adithya Srinivasan | 57dc81d | 2021-04-14 17:31:41 +0000 | [diff] [blame] | 2040 | EXPECT_EQ(displayFrame3->getActuals().presentTime, 0); |
| 2041 | // Fences have flushed for third displayFrame, so the present timestamps should be updated |
| 2042 | EXPECT_EQ(displayFrame2->getActuals().presentTime, 120); |
| 2043 | EXPECT_EQ(displayFrame2->getFramePresentMetadata(), FramePresentMetadata::LatePresent); |
| 2044 | EXPECT_EQ(displayFrame2->getFrameReadyMetadata(), FrameReadyMetadata::LateFinish); |
| 2045 | EXPECT_EQ(displayFrame2->getJankType(), JankType::SurfaceFlingerStuffing); |
Ying Wei | 96eb535 | 2023-11-21 17:37:21 +0000 | [diff] [blame] | 2046 | EXPECT_EQ(displayFrame2->getJankSeverityType(), JankSeverityType::Full); |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 2047 | |
| 2048 | addEmptyDisplayFrame(); |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 2049 | |
Adithya Srinivasan | 57dc81d | 2021-04-14 17:31:41 +0000 | [diff] [blame] | 2050 | // Fences have flushed for third displayFrame, so the present timestamps should be updated |
| 2051 | EXPECT_EQ(displayFrame3->getActuals().presentTime, 180); |
| 2052 | EXPECT_EQ(displayFrame3->getFramePresentMetadata(), FramePresentMetadata::LatePresent); |
| 2053 | EXPECT_EQ(displayFrame3->getFrameReadyMetadata(), FrameReadyMetadata::LateFinish); |
| 2054 | EXPECT_EQ(displayFrame3->getJankType(), JankType::SurfaceFlingerGpuDeadlineMissed); |
Ying Wei | 96eb535 | 2023-11-21 17:37:21 +0000 | [diff] [blame] | 2055 | EXPECT_EQ(displayFrame3->getJankSeverityType(), JankSeverityType::Full); |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 2056 | } |
| 2057 | |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 2058 | TEST_F(FrameTimelineTest, jankClassification_surfaceFrameOnTimeFinishEarlyPresent) { |
Alec Mouri | 363faf0 | 2021-01-29 16:34:55 -0800 | [diff] [blame] | 2059 | EXPECT_CALL(*mTimeStats, incrementJankyFrames(_)); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 2060 | auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 2061 | int64_t sfToken1 = mTokenManager->generateTokenForPredictions({22, 30, 40}); |
| 2062 | int64_t sfToken2 = mTokenManager->generateTokenForPredictions({52, 60, 70}); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 2063 | int64_t surfaceFrameToken1 = mTokenManager->generateTokenForPredictions({5, 16, 40}); |
| 2064 | int64_t surfaceFrameToken2 = mTokenManager->generateTokenForPredictions({25, 36, 70}); |
Huihong Luo | 3bdef86 | 2022-03-03 11:57:19 -0800 | [diff] [blame] | 2065 | FrameTimelineInfo ftInfo; |
| 2066 | ftInfo.vsyncId = surfaceFrameToken1; |
| 2067 | ftInfo.inputEventId = sInputEventId; |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 2068 | auto surfaceFrame1 = |
Huihong Luo | 3bdef86 | 2022-03-03 11:57:19 -0800 | [diff] [blame] | 2069 | mFrameTimeline->createSurfaceFrameForToken(ftInfo, sPidOne, sUidOne, sLayerIdOne, |
| 2070 | sLayerNameOne, sLayerNameOne, |
| 2071 | /*isBuffer*/ true, sGameMode); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 2072 | surfaceFrame1->setAcquireFenceTime(16); |
Pascal Muetschard | ac7bcd9 | 2023-10-03 15:05:36 +0200 | [diff] [blame] | 2073 | mFrameTimeline->setSfWakeUp(sfToken1, 22, RR_11, RR_11); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 2074 | surfaceFrame1->setPresentState(SurfaceFrame::PresentState::Presented); |
| 2075 | mFrameTimeline->addSurfaceFrame(surfaceFrame1); |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 2076 | mFrameTimeline->setSfPresent(27, presentFence1); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 2077 | auto displayFrame1 = getDisplayFrame(0); |
| 2078 | auto& presentedSurfaceFrame1 = getSurfaceFrame(0, 0); |
| 2079 | presentFence1->signalForTest(30); |
| 2080 | |
| 2081 | // Fences for the first frame haven't been flushed yet, so it should be 0 |
| 2082 | EXPECT_EQ(displayFrame1->getActuals().presentTime, 0); |
| 2083 | auto actuals1 = presentedSurfaceFrame1.getActuals(); |
| 2084 | EXPECT_EQ(actuals1.presentTime, 0); |
| 2085 | |
| 2086 | // Trigger a flush by finalizing the next DisplayFrame |
| 2087 | auto presentFence2 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
Huihong Luo | 3bdef86 | 2022-03-03 11:57:19 -0800 | [diff] [blame] | 2088 | FrameTimelineInfo ftInfo2; |
| 2089 | ftInfo2.vsyncId = surfaceFrameToken2; |
| 2090 | ftInfo2.inputEventId = sInputEventId; |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 2091 | auto surfaceFrame2 = |
Huihong Luo | 3bdef86 | 2022-03-03 11:57:19 -0800 | [diff] [blame] | 2092 | mFrameTimeline->createSurfaceFrameForToken(ftInfo2, sPidOne, sUidOne, sLayerIdOne, |
| 2093 | sLayerNameOne, sLayerNameOne, |
| 2094 | /*isBuffer*/ true, sGameMode); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 2095 | surfaceFrame2->setAcquireFenceTime(36); |
Pascal Muetschard | ac7bcd9 | 2023-10-03 15:05:36 +0200 | [diff] [blame] | 2096 | mFrameTimeline->setSfWakeUp(sfToken2, 52, RR_11, RR_11); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 2097 | surfaceFrame2->setPresentState(SurfaceFrame::PresentState::Presented); |
| 2098 | mFrameTimeline->addSurfaceFrame(surfaceFrame2); |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 2099 | mFrameTimeline->setSfPresent(57, presentFence2); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 2100 | auto displayFrame2 = getDisplayFrame(1); |
| 2101 | auto& presentedSurfaceFrame2 = getSurfaceFrame(1, 0); |
| 2102 | |
| 2103 | // Fences for the first frame have flushed, so the present timestamps should be updated |
| 2104 | EXPECT_EQ(displayFrame1->getActuals().presentTime, 30); |
| 2105 | EXPECT_EQ(displayFrame1->getFramePresentMetadata(), FramePresentMetadata::EarlyPresent); |
| 2106 | EXPECT_EQ(displayFrame1->getFrameReadyMetadata(), FrameReadyMetadata::OnTimeFinish); |
| 2107 | EXPECT_EQ(displayFrame1->getJankType(), JankType::SurfaceFlingerScheduling); |
Ying Wei | 96eb535 | 2023-11-21 17:37:21 +0000 | [diff] [blame] | 2108 | EXPECT_EQ(displayFrame1->getJankSeverityType(), JankSeverityType::Partial); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 2109 | |
| 2110 | actuals1 = presentedSurfaceFrame1.getActuals(); |
| 2111 | EXPECT_EQ(actuals1.presentTime, 30); |
| 2112 | EXPECT_EQ(presentedSurfaceFrame1.getFramePresentMetadata(), FramePresentMetadata::EarlyPresent); |
| 2113 | EXPECT_EQ(presentedSurfaceFrame1.getFrameReadyMetadata(), FrameReadyMetadata::OnTimeFinish); |
| 2114 | EXPECT_EQ(presentedSurfaceFrame1.getJankType(), JankType::SurfaceFlingerScheduling); |
Ying Wei | 96eb535 | 2023-11-21 17:37:21 +0000 | [diff] [blame] | 2115 | EXPECT_EQ(presentedSurfaceFrame1.getJankSeverityType(), JankSeverityType::Partial); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 2116 | |
| 2117 | // Fences for the second frame haven't been flushed yet, so it should be 0 |
| 2118 | presentFence2->signalForTest(65); |
| 2119 | EXPECT_EQ(displayFrame2->getActuals().presentTime, 0); |
| 2120 | auto actuals2 = presentedSurfaceFrame2.getActuals(); |
| 2121 | EXPECT_EQ(actuals2.presentTime, 0); |
| 2122 | |
Alec Mouri | 363faf0 | 2021-01-29 16:34:55 -0800 | [diff] [blame] | 2123 | ::testing::Mock::VerifyAndClearExpectations(mTimeStats.get()); |
| 2124 | |
| 2125 | EXPECT_CALL(*mTimeStats, |
Pascal Muetschard | ac7bcd9 | 2023-10-03 15:05:36 +0200 | [diff] [blame] | 2126 | incrementJankyFrames(TimeStats::JankyFramesInfo{RR_11, std::nullopt, sUidOne, |
| 2127 | sLayerNameOne, sGameMode, |
| 2128 | JankType::PredictionError, -3, 5, |
| 2129 | 0})); |
Alec Mouri | 363faf0 | 2021-01-29 16:34:55 -0800 | [diff] [blame] | 2130 | |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 2131 | addEmptyDisplayFrame(); |
| 2132 | |
| 2133 | // Fences for the second frame have flushed, so the present timestamps should be updated |
| 2134 | EXPECT_EQ(displayFrame2->getActuals().presentTime, 65); |
| 2135 | EXPECT_EQ(displayFrame2->getFramePresentMetadata(), FramePresentMetadata::EarlyPresent); |
| 2136 | EXPECT_EQ(displayFrame2->getFrameReadyMetadata(), FrameReadyMetadata::OnTimeFinish); |
| 2137 | EXPECT_EQ(displayFrame2->getJankType(), JankType::PredictionError); |
Ying Wei | 96eb535 | 2023-11-21 17:37:21 +0000 | [diff] [blame] | 2138 | EXPECT_EQ(displayFrame2->getJankSeverityType(), JankSeverityType::Partial); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 2139 | |
| 2140 | actuals2 = presentedSurfaceFrame2.getActuals(); |
| 2141 | EXPECT_EQ(actuals2.presentTime, 65); |
| 2142 | EXPECT_EQ(presentedSurfaceFrame2.getFramePresentMetadata(), FramePresentMetadata::EarlyPresent); |
| 2143 | EXPECT_EQ(presentedSurfaceFrame2.getFrameReadyMetadata(), FrameReadyMetadata::OnTimeFinish); |
| 2144 | EXPECT_EQ(presentedSurfaceFrame2.getJankType(), JankType::PredictionError); |
Ying Wei | 96eb535 | 2023-11-21 17:37:21 +0000 | [diff] [blame] | 2145 | EXPECT_EQ(presentedSurfaceFrame2.getJankSeverityType(), JankSeverityType::Partial); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 2146 | } |
| 2147 | |
| 2148 | TEST_F(FrameTimelineTest, jankClassification_surfaceFrameOnTimeFinishLatePresent) { |
Alec Mouri | 363faf0 | 2021-01-29 16:34:55 -0800 | [diff] [blame] | 2149 | EXPECT_CALL(*mTimeStats, incrementJankyFrames(_)); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 2150 | auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 2151 | int64_t sfToken1 = mTokenManager->generateTokenForPredictions({22, 30, 40}); |
| 2152 | int64_t sfToken2 = mTokenManager->generateTokenForPredictions({52, 60, 70}); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 2153 | int64_t surfaceFrameToken1 = mTokenManager->generateTokenForPredictions({5, 16, 40}); |
| 2154 | int64_t surfaceFrameToken2 = mTokenManager->generateTokenForPredictions({25, 36, 70}); |
Huihong Luo | 3bdef86 | 2022-03-03 11:57:19 -0800 | [diff] [blame] | 2155 | FrameTimelineInfo ftInfo; |
| 2156 | ftInfo.vsyncId = surfaceFrameToken1; |
| 2157 | ftInfo.inputEventId = sInputEventId; |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 2158 | auto surfaceFrame1 = |
Huihong Luo | 3bdef86 | 2022-03-03 11:57:19 -0800 | [diff] [blame] | 2159 | mFrameTimeline->createSurfaceFrameForToken(ftInfo, sPidOne, sUidOne, sLayerIdOne, |
| 2160 | sLayerNameOne, sLayerNameOne, |
| 2161 | /*isBuffer*/ true, sGameMode); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 2162 | surfaceFrame1->setAcquireFenceTime(16); |
Pascal Muetschard | ac7bcd9 | 2023-10-03 15:05:36 +0200 | [diff] [blame] | 2163 | mFrameTimeline->setSfWakeUp(sfToken1, 22, RR_11, RR_11); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 2164 | surfaceFrame1->setPresentState(SurfaceFrame::PresentState::Presented); |
| 2165 | mFrameTimeline->addSurfaceFrame(surfaceFrame1); |
| 2166 | mFrameTimeline->setSfPresent(26, presentFence1); |
| 2167 | auto displayFrame1 = getDisplayFrame(0); |
| 2168 | auto& presentedSurfaceFrame1 = getSurfaceFrame(0, 0); |
| 2169 | presentFence1->signalForTest(50); |
| 2170 | |
| 2171 | // Fences for the first frame haven't been flushed yet, so it should be 0 |
| 2172 | EXPECT_EQ(displayFrame1->getActuals().presentTime, 0); |
| 2173 | auto actuals1 = presentedSurfaceFrame1.getActuals(); |
| 2174 | EXPECT_EQ(actuals1.presentTime, 0); |
| 2175 | |
| 2176 | // Trigger a flush by finalizing the next DisplayFrame |
| 2177 | auto presentFence2 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
Huihong Luo | 3bdef86 | 2022-03-03 11:57:19 -0800 | [diff] [blame] | 2178 | FrameTimelineInfo ftInfo2; |
| 2179 | ftInfo2.vsyncId = surfaceFrameToken2; |
| 2180 | ftInfo2.inputEventId = sInputEventId; |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 2181 | auto surfaceFrame2 = |
Huihong Luo | 3bdef86 | 2022-03-03 11:57:19 -0800 | [diff] [blame] | 2182 | mFrameTimeline->createSurfaceFrameForToken(ftInfo2, sPidOne, sUidOne, sLayerIdOne, |
| 2183 | sLayerNameOne, sLayerNameOne, |
| 2184 | /*isBuffer*/ true, sGameMode); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 2185 | surfaceFrame2->setAcquireFenceTime(36); |
Pascal Muetschard | ac7bcd9 | 2023-10-03 15:05:36 +0200 | [diff] [blame] | 2186 | mFrameTimeline->setSfWakeUp(sfToken2, 52, RR_11, RR_11); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 2187 | surfaceFrame2->setPresentState(SurfaceFrame::PresentState::Presented); |
| 2188 | mFrameTimeline->addSurfaceFrame(surfaceFrame2); |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 2189 | mFrameTimeline->setSfPresent(57, presentFence2); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 2190 | auto displayFrame2 = getDisplayFrame(1); |
| 2191 | auto& presentedSurfaceFrame2 = getSurfaceFrame(1, 0); |
| 2192 | |
| 2193 | // Fences for the first frame have flushed, so the present timestamps should be updated |
| 2194 | EXPECT_EQ(displayFrame1->getActuals().presentTime, 50); |
| 2195 | EXPECT_EQ(displayFrame1->getFramePresentMetadata(), FramePresentMetadata::LatePresent); |
| 2196 | EXPECT_EQ(displayFrame1->getFrameReadyMetadata(), FrameReadyMetadata::OnTimeFinish); |
| 2197 | EXPECT_EQ(displayFrame1->getJankType(), JankType::DisplayHAL); |
Ying Wei | 96eb535 | 2023-11-21 17:37:21 +0000 | [diff] [blame] | 2198 | EXPECT_EQ(displayFrame1->getJankSeverityType(), JankSeverityType::Partial); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 2199 | |
| 2200 | actuals1 = presentedSurfaceFrame1.getActuals(); |
| 2201 | EXPECT_EQ(actuals1.presentTime, 50); |
| 2202 | EXPECT_EQ(presentedSurfaceFrame1.getFramePresentMetadata(), FramePresentMetadata::LatePresent); |
| 2203 | EXPECT_EQ(presentedSurfaceFrame1.getFrameReadyMetadata(), FrameReadyMetadata::OnTimeFinish); |
| 2204 | EXPECT_EQ(presentedSurfaceFrame1.getJankType(), JankType::DisplayHAL); |
Ying Wei | 96eb535 | 2023-11-21 17:37:21 +0000 | [diff] [blame] | 2205 | EXPECT_EQ(presentedSurfaceFrame1.getJankSeverityType(), JankSeverityType::Partial); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 2206 | |
| 2207 | // Fences for the second frame haven't been flushed yet, so it should be 0 |
| 2208 | presentFence2->signalForTest(86); |
| 2209 | EXPECT_EQ(displayFrame2->getActuals().presentTime, 0); |
| 2210 | auto actuals2 = presentedSurfaceFrame2.getActuals(); |
| 2211 | EXPECT_EQ(actuals2.presentTime, 0); |
| 2212 | |
Alec Mouri | 363faf0 | 2021-01-29 16:34:55 -0800 | [diff] [blame] | 2213 | ::testing::Mock::VerifyAndClearExpectations(mTimeStats.get()); |
| 2214 | |
| 2215 | EXPECT_CALL(*mTimeStats, |
Pascal Muetschard | ac7bcd9 | 2023-10-03 15:05:36 +0200 | [diff] [blame] | 2216 | incrementJankyFrames(TimeStats::JankyFramesInfo{RR_11, std::nullopt, sUidOne, |
| 2217 | sLayerNameOne, sGameMode, |
| 2218 | JankType::PredictionError, -3, 5, |
| 2219 | 0})); |
Alec Mouri | 363faf0 | 2021-01-29 16:34:55 -0800 | [diff] [blame] | 2220 | |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 2221 | addEmptyDisplayFrame(); |
| 2222 | |
| 2223 | // Fences for the second frame have flushed, so the present timestamps should be updated |
| 2224 | EXPECT_EQ(displayFrame2->getActuals().presentTime, 86); |
| 2225 | EXPECT_EQ(displayFrame2->getFramePresentMetadata(), FramePresentMetadata::LatePresent); |
| 2226 | EXPECT_EQ(displayFrame2->getFrameReadyMetadata(), FrameReadyMetadata::OnTimeFinish); |
| 2227 | EXPECT_EQ(displayFrame2->getJankType(), JankType::PredictionError); |
Ying Wei | 96eb535 | 2023-11-21 17:37:21 +0000 | [diff] [blame] | 2228 | EXPECT_EQ(displayFrame2->getJankSeverityType(), JankSeverityType::Full); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 2229 | |
| 2230 | actuals2 = presentedSurfaceFrame2.getActuals(); |
| 2231 | EXPECT_EQ(actuals2.presentTime, 86); |
| 2232 | EXPECT_EQ(presentedSurfaceFrame2.getFramePresentMetadata(), FramePresentMetadata::LatePresent); |
| 2233 | EXPECT_EQ(presentedSurfaceFrame2.getFrameReadyMetadata(), FrameReadyMetadata::OnTimeFinish); |
| 2234 | EXPECT_EQ(presentedSurfaceFrame2.getJankType(), JankType::PredictionError); |
Ying Wei | 96eb535 | 2023-11-21 17:37:21 +0000 | [diff] [blame] | 2235 | EXPECT_EQ(presentedSurfaceFrame2.getJankSeverityType(), JankSeverityType::Full); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 2236 | } |
| 2237 | |
| 2238 | TEST_F(FrameTimelineTest, jankClassification_surfaceFrameLateFinishEarlyPresent) { |
Alec Mouri | 363faf0 | 2021-01-29 16:34:55 -0800 | [diff] [blame] | 2239 | EXPECT_CALL(*mTimeStats, incrementJankyFrames(_)); |
Alec Mouri | 7d436ec | 2021-01-27 20:40:50 -0800 | [diff] [blame] | 2240 | |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 2241 | auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 2242 | int64_t sfToken1 = mTokenManager->generateTokenForPredictions({42, 50, 50}); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 2243 | int64_t surfaceFrameToken1 = mTokenManager->generateTokenForPredictions({5, 26, 60}); |
Huihong Luo | 3bdef86 | 2022-03-03 11:57:19 -0800 | [diff] [blame] | 2244 | FrameTimelineInfo ftInfo; |
| 2245 | ftInfo.vsyncId = surfaceFrameToken1; |
| 2246 | ftInfo.inputEventId = sInputEventId; |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 2247 | auto surfaceFrame1 = |
Huihong Luo | 3bdef86 | 2022-03-03 11:57:19 -0800 | [diff] [blame] | 2248 | mFrameTimeline->createSurfaceFrameForToken(ftInfo, sPidOne, sUidOne, sLayerIdOne, |
| 2249 | sLayerNameOne, sLayerNameOne, |
| 2250 | /*isBuffer*/ true, sGameMode); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 2251 | surfaceFrame1->setAcquireFenceTime(40); |
Pascal Muetschard | ac7bcd9 | 2023-10-03 15:05:36 +0200 | [diff] [blame] | 2252 | mFrameTimeline->setSfWakeUp(sfToken1, 42, RR_11, RR_11); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 2253 | surfaceFrame1->setPresentState(SurfaceFrame::PresentState::Presented); |
| 2254 | mFrameTimeline->addSurfaceFrame(surfaceFrame1); |
| 2255 | mFrameTimeline->setSfPresent(46, presentFence1); |
| 2256 | auto displayFrame1 = getDisplayFrame(0); |
| 2257 | auto& presentedSurfaceFrame1 = getSurfaceFrame(0, 0); |
| 2258 | presentFence1->signalForTest(50); |
| 2259 | |
| 2260 | // Fences for the first frame haven't been flushed yet, so it should be 0 |
| 2261 | EXPECT_EQ(displayFrame1->getActuals().presentTime, 0); |
| 2262 | auto actuals1 = presentedSurfaceFrame1.getActuals(); |
| 2263 | EXPECT_EQ(actuals1.presentTime, 0); |
| 2264 | |
| 2265 | addEmptyDisplayFrame(); |
| 2266 | |
| 2267 | // Fences for the first frame have flushed, so the present timestamps should be updated |
| 2268 | EXPECT_EQ(displayFrame1->getActuals().presentTime, 50); |
| 2269 | EXPECT_EQ(displayFrame1->getFramePresentMetadata(), FramePresentMetadata::OnTimePresent); |
| 2270 | EXPECT_EQ(displayFrame1->getFrameReadyMetadata(), FrameReadyMetadata::OnTimeFinish); |
| 2271 | EXPECT_EQ(displayFrame1->getJankType(), JankType::None); |
Ying Wei | 96eb535 | 2023-11-21 17:37:21 +0000 | [diff] [blame] | 2272 | EXPECT_EQ(displayFrame1->getJankSeverityType(), JankSeverityType::None); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 2273 | |
| 2274 | actuals1 = presentedSurfaceFrame1.getActuals(); |
| 2275 | EXPECT_EQ(actuals1.presentTime, 50); |
| 2276 | EXPECT_EQ(presentedSurfaceFrame1.getFramePresentMetadata(), FramePresentMetadata::EarlyPresent); |
| 2277 | EXPECT_EQ(presentedSurfaceFrame1.getFrameReadyMetadata(), FrameReadyMetadata::LateFinish); |
| 2278 | EXPECT_EQ(presentedSurfaceFrame1.getJankType(), JankType::Unknown); |
Ying Wei | 96eb535 | 2023-11-21 17:37:21 +0000 | [diff] [blame] | 2279 | EXPECT_EQ(presentedSurfaceFrame1.getJankSeverityType(), JankSeverityType::Partial); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 2280 | } |
| 2281 | |
| 2282 | TEST_F(FrameTimelineTest, jankClassification_surfaceFrameLateFinishLatePresent) { |
Adithya Srinivasan | 8a94550 | 2021-03-19 19:12:32 +0000 | [diff] [blame] | 2283 | // First frame - DisplayFrame is not janky. This should classify the SurfaceFrame as only |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 2284 | // AppDeadlineMissed. Second frame - DisplayFrame is janky. This should propagate DisplayFrame's |
Adithya Srinivasan | 8a94550 | 2021-03-19 19:12:32 +0000 | [diff] [blame] | 2285 | // jank to the SurfaceFrame along with AppDeadlineMissed. |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 2286 | |
Alec Mouri | 363faf0 | 2021-01-29 16:34:55 -0800 | [diff] [blame] | 2287 | EXPECT_CALL(*mTimeStats, incrementJankyFrames(_)).Times(2); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 2288 | auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 2289 | int64_t sfToken1 = mTokenManager->generateTokenForPredictions({32, 40, 40}); |
| 2290 | int64_t sfToken2 = mTokenManager->generateTokenForPredictions({42, 50, 50}); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 2291 | int64_t surfaceFrameToken1 = mTokenManager->generateTokenForPredictions({5, 16, 30}); |
| 2292 | int64_t surfaceFrameToken2 = mTokenManager->generateTokenForPredictions({25, 36, 50}); |
Huihong Luo | 3bdef86 | 2022-03-03 11:57:19 -0800 | [diff] [blame] | 2293 | FrameTimelineInfo ftInfo; |
| 2294 | ftInfo.vsyncId = surfaceFrameToken1; |
| 2295 | ftInfo.inputEventId = sInputEventId; |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 2296 | auto surfaceFrame1 = |
Huihong Luo | 3bdef86 | 2022-03-03 11:57:19 -0800 | [diff] [blame] | 2297 | mFrameTimeline->createSurfaceFrameForToken(ftInfo, sPidOne, sUidOne, sLayerIdOne, |
| 2298 | sLayerNameOne, sLayerNameOne, |
| 2299 | /*isBuffer*/ true, sGameMode); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 2300 | surfaceFrame1->setAcquireFenceTime(26); |
Pascal Muetschard | ac7bcd9 | 2023-10-03 15:05:36 +0200 | [diff] [blame] | 2301 | mFrameTimeline->setSfWakeUp(sfToken1, 32, RR_11, RR_11); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 2302 | surfaceFrame1->setPresentState(SurfaceFrame::PresentState::Presented); |
| 2303 | mFrameTimeline->addSurfaceFrame(surfaceFrame1); |
| 2304 | mFrameTimeline->setSfPresent(36, presentFence1); |
| 2305 | auto displayFrame1 = getDisplayFrame(0); |
| 2306 | auto& presentedSurfaceFrame1 = getSurfaceFrame(0, 0); |
| 2307 | presentFence1->signalForTest(40); |
| 2308 | |
| 2309 | // Fences for the first frame haven't been flushed yet, so it should be 0 |
| 2310 | EXPECT_EQ(displayFrame1->getActuals().presentTime, 0); |
| 2311 | auto actuals1 = presentedSurfaceFrame1.getActuals(); |
| 2312 | EXPECT_EQ(actuals1.presentTime, 0); |
| 2313 | |
| 2314 | // Trigger a flush by finalizing the next DisplayFrame |
| 2315 | auto presentFence2 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
Huihong Luo | 3bdef86 | 2022-03-03 11:57:19 -0800 | [diff] [blame] | 2316 | FrameTimelineInfo ftInfo2; |
| 2317 | ftInfo2.vsyncId = surfaceFrameToken2; |
| 2318 | ftInfo2.inputEventId = sInputEventId; |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 2319 | auto surfaceFrame2 = |
Huihong Luo | 3bdef86 | 2022-03-03 11:57:19 -0800 | [diff] [blame] | 2320 | mFrameTimeline->createSurfaceFrameForToken(ftInfo2, sPidOne, sUidOne, sLayerIdOne, |
| 2321 | sLayerNameOne, sLayerNameOne, |
| 2322 | /*isBuffer*/ true, sGameMode); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 2323 | surfaceFrame2->setAcquireFenceTime(40); |
Pascal Muetschard | ac7bcd9 | 2023-10-03 15:05:36 +0200 | [diff] [blame] | 2324 | mFrameTimeline->setSfWakeUp(sfToken2, 43, RR_11, RR_11); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 2325 | surfaceFrame2->setPresentState(SurfaceFrame::PresentState::Presented); |
| 2326 | mFrameTimeline->addSurfaceFrame(surfaceFrame2); |
| 2327 | mFrameTimeline->setSfPresent(56, presentFence2); |
| 2328 | auto displayFrame2 = getDisplayFrame(1); |
| 2329 | auto& presentedSurfaceFrame2 = getSurfaceFrame(1, 0); |
| 2330 | |
| 2331 | // Fences for the first frame have flushed, so the present timestamps should be updated |
| 2332 | EXPECT_EQ(displayFrame1->getActuals().presentTime, 40); |
| 2333 | EXPECT_EQ(displayFrame1->getFramePresentMetadata(), FramePresentMetadata::OnTimePresent); |
| 2334 | EXPECT_EQ(displayFrame1->getFrameReadyMetadata(), FrameReadyMetadata::OnTimeFinish); |
| 2335 | EXPECT_EQ(displayFrame1->getJankType(), JankType::None); |
Ying Wei | 96eb535 | 2023-11-21 17:37:21 +0000 | [diff] [blame] | 2336 | EXPECT_EQ(displayFrame1->getJankSeverityType(), JankSeverityType::None); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 2337 | |
| 2338 | actuals1 = presentedSurfaceFrame1.getActuals(); |
| 2339 | EXPECT_EQ(actuals1.presentTime, 40); |
| 2340 | EXPECT_EQ(presentedSurfaceFrame1.getFramePresentMetadata(), FramePresentMetadata::LatePresent); |
| 2341 | EXPECT_EQ(presentedSurfaceFrame1.getFrameReadyMetadata(), FrameReadyMetadata::LateFinish); |
| 2342 | EXPECT_EQ(presentedSurfaceFrame1.getJankType(), JankType::AppDeadlineMissed); |
Ying Wei | 96eb535 | 2023-11-21 17:37:21 +0000 | [diff] [blame] | 2343 | EXPECT_EQ(presentedSurfaceFrame1.getJankSeverityType(), JankSeverityType::Partial); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 2344 | |
| 2345 | // Fences for the second frame haven't been flushed yet, so it should be 0 |
| 2346 | presentFence2->signalForTest(60); |
| 2347 | EXPECT_EQ(displayFrame2->getActuals().presentTime, 0); |
| 2348 | auto actuals2 = presentedSurfaceFrame2.getActuals(); |
| 2349 | EXPECT_EQ(actuals2.presentTime, 0); |
| 2350 | |
| 2351 | addEmptyDisplayFrame(); |
| 2352 | |
| 2353 | // Fences for the second frame have flushed, so the present timestamps should be updated |
| 2354 | EXPECT_EQ(displayFrame2->getActuals().presentTime, 60); |
| 2355 | EXPECT_EQ(displayFrame2->getFramePresentMetadata(), FramePresentMetadata::LatePresent); |
| 2356 | EXPECT_EQ(displayFrame2->getFrameReadyMetadata(), FrameReadyMetadata::LateFinish); |
| 2357 | EXPECT_EQ(displayFrame2->getJankType(), JankType::SurfaceFlingerCpuDeadlineMissed); |
Ying Wei | 96eb535 | 2023-11-21 17:37:21 +0000 | [diff] [blame] | 2358 | EXPECT_EQ(displayFrame2->getJankSeverityType(), JankSeverityType::Partial); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 2359 | |
| 2360 | actuals2 = presentedSurfaceFrame2.getActuals(); |
| 2361 | EXPECT_EQ(actuals2.presentTime, 60); |
| 2362 | EXPECT_EQ(presentedSurfaceFrame2.getFramePresentMetadata(), FramePresentMetadata::LatePresent); |
| 2363 | EXPECT_EQ(presentedSurfaceFrame2.getFrameReadyMetadata(), FrameReadyMetadata::LateFinish); |
Adithya Srinivasan | 8a94550 | 2021-03-19 19:12:32 +0000 | [diff] [blame] | 2364 | EXPECT_EQ(presentedSurfaceFrame2.getJankType(), |
| 2365 | JankType::SurfaceFlingerCpuDeadlineMissed | JankType::AppDeadlineMissed); |
Ying Wei | 96eb535 | 2023-11-21 17:37:21 +0000 | [diff] [blame] | 2366 | EXPECT_EQ(presentedSurfaceFrame2.getJankSeverityType(), JankSeverityType::Partial); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 2367 | } |
| 2368 | |
| 2369 | TEST_F(FrameTimelineTest, jankClassification_multiJankBufferStuffingAndAppDeadlineMissed) { |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 2370 | // Layer specific increment |
Alec Mouri | 363faf0 | 2021-01-29 16:34:55 -0800 | [diff] [blame] | 2371 | EXPECT_CALL(*mTimeStats, incrementJankyFrames(_)).Times(2); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 2372 | auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
| 2373 | int64_t surfaceFrameToken1 = mTokenManager->generateTokenForPredictions({10, 20, 30}); |
| 2374 | int64_t surfaceFrameToken2 = mTokenManager->generateTokenForPredictions({40, 50, 60}); |
| 2375 | |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 2376 | int64_t sfToken1 = mTokenManager->generateTokenForPredictions({52, 60, 60}); |
| 2377 | int64_t sfToken2 = mTokenManager->generateTokenForPredictions({112, 120, 120}); |
Huihong Luo | 3bdef86 | 2022-03-03 11:57:19 -0800 | [diff] [blame] | 2378 | FrameTimelineInfo ftInfo; |
| 2379 | ftInfo.vsyncId = surfaceFrameToken1; |
| 2380 | ftInfo.inputEventId = sInputEventId; |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 2381 | auto surfaceFrame1 = |
Huihong Luo | 3bdef86 | 2022-03-03 11:57:19 -0800 | [diff] [blame] | 2382 | mFrameTimeline->createSurfaceFrameForToken(ftInfo, sPidOne, sUidOne, sLayerIdOne, |
| 2383 | sLayerNameOne, sLayerNameOne, |
| 2384 | /*isBuffer*/ true, sGameMode); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 2385 | surfaceFrame1->setAcquireFenceTime(50); |
Pascal Muetschard | ac7bcd9 | 2023-10-03 15:05:36 +0200 | [diff] [blame] | 2386 | mFrameTimeline->setSfWakeUp(sfToken1, 52, RR_30, RR_30); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 2387 | surfaceFrame1->setPresentState(SurfaceFrame::PresentState::Presented); |
| 2388 | mFrameTimeline->addSurfaceFrame(surfaceFrame1); |
| 2389 | mFrameTimeline->setSfPresent(56, presentFence1); |
| 2390 | auto displayFrame1 = getDisplayFrame(0); |
| 2391 | auto& presentedSurfaceFrame1 = getSurfaceFrame(0, 0); |
| 2392 | presentFence1->signalForTest(60); |
| 2393 | |
| 2394 | // Fences for the first frame haven't been flushed yet, so it should be 0 |
| 2395 | EXPECT_EQ(displayFrame1->getActuals().presentTime, 0); |
| 2396 | auto actuals1 = presentedSurfaceFrame1.getActuals(); |
| 2397 | EXPECT_EQ(actuals1.presentTime, 0); |
| 2398 | |
| 2399 | // Trigger a flush by finalizing the next DisplayFrame |
| 2400 | auto presentFence2 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
Huihong Luo | 3bdef86 | 2022-03-03 11:57:19 -0800 | [diff] [blame] | 2401 | FrameTimelineInfo ftInfo2; |
| 2402 | ftInfo2.vsyncId = surfaceFrameToken2; |
| 2403 | ftInfo2.inputEventId = sInputEventId; |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 2404 | auto surfaceFrame2 = |
Huihong Luo | 3bdef86 | 2022-03-03 11:57:19 -0800 | [diff] [blame] | 2405 | mFrameTimeline->createSurfaceFrameForToken(ftInfo2, sPidOne, sUidOne, sLayerIdOne, |
| 2406 | sLayerNameOne, sLayerNameOne, |
| 2407 | /*isBuffer*/ true, sGameMode); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 2408 | surfaceFrame2->setAcquireFenceTime(84); |
Pascal Muetschard | ac7bcd9 | 2023-10-03 15:05:36 +0200 | [diff] [blame] | 2409 | mFrameTimeline->setSfWakeUp(sfToken2, 112, RR_30, RR_30); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 2410 | surfaceFrame2->setPresentState(SurfaceFrame::PresentState::Presented, 54); |
| 2411 | mFrameTimeline->addSurfaceFrame(surfaceFrame2); |
| 2412 | mFrameTimeline->setSfPresent(116, presentFence2); |
| 2413 | auto displayFrame2 = getDisplayFrame(1); |
| 2414 | auto& presentedSurfaceFrame2 = getSurfaceFrame(1, 0); |
| 2415 | presentFence2->signalForTest(120); |
| 2416 | |
| 2417 | // Fences for the first frame have flushed, so the present timestamps should be updated |
| 2418 | EXPECT_EQ(displayFrame1->getActuals().presentTime, 60); |
| 2419 | actuals1 = presentedSurfaceFrame1.getActuals(); |
| 2420 | EXPECT_EQ(actuals1.endTime, 50); |
| 2421 | EXPECT_EQ(actuals1.presentTime, 60); |
| 2422 | |
| 2423 | EXPECT_EQ(displayFrame1->getFramePresentMetadata(), FramePresentMetadata::OnTimePresent); |
| 2424 | EXPECT_EQ(displayFrame1->getFrameReadyMetadata(), FrameReadyMetadata::OnTimeFinish); |
| 2425 | EXPECT_EQ(displayFrame1->getJankType(), JankType::None); |
Ying Wei | 96eb535 | 2023-11-21 17:37:21 +0000 | [diff] [blame] | 2426 | EXPECT_EQ(displayFrame1->getJankSeverityType(), JankSeverityType::None); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 2427 | |
| 2428 | EXPECT_EQ(presentedSurfaceFrame1.getFramePresentMetadata(), FramePresentMetadata::LatePresent); |
| 2429 | EXPECT_EQ(presentedSurfaceFrame1.getFrameReadyMetadata(), FrameReadyMetadata::LateFinish); |
| 2430 | EXPECT_EQ(presentedSurfaceFrame1.getJankType(), JankType::AppDeadlineMissed); |
Ying Wei | 96eb535 | 2023-11-21 17:37:21 +0000 | [diff] [blame] | 2431 | EXPECT_EQ(presentedSurfaceFrame1.getJankSeverityType(), JankSeverityType::Full); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 2432 | |
| 2433 | // Fences for the second frame haven't been flushed yet, so it should be 0 |
| 2434 | EXPECT_EQ(displayFrame2->getActuals().presentTime, 0); |
| 2435 | auto actuals2 = presentedSurfaceFrame2.getActuals(); |
| 2436 | EXPECT_EQ(actuals2.presentTime, 0); |
| 2437 | |
| 2438 | addEmptyDisplayFrame(); |
| 2439 | |
| 2440 | // Fences for the second frame have flushed, so the present timestamps should be updated |
| 2441 | EXPECT_EQ(displayFrame2->getActuals().presentTime, 120); |
| 2442 | actuals2 = presentedSurfaceFrame2.getActuals(); |
| 2443 | EXPECT_EQ(actuals2.presentTime, 120); |
| 2444 | |
| 2445 | EXPECT_EQ(displayFrame2->getFramePresentMetadata(), FramePresentMetadata::OnTimePresent); |
| 2446 | EXPECT_EQ(displayFrame2->getFrameReadyMetadata(), FrameReadyMetadata::OnTimeFinish); |
| 2447 | EXPECT_EQ(displayFrame2->getJankType(), JankType::None); |
Ying Wei | 96eb535 | 2023-11-21 17:37:21 +0000 | [diff] [blame] | 2448 | EXPECT_EQ(displayFrame2->getJankSeverityType(), JankSeverityType::None); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 2449 | |
| 2450 | EXPECT_EQ(presentedSurfaceFrame2.getFramePresentMetadata(), FramePresentMetadata::LatePresent); |
| 2451 | EXPECT_EQ(presentedSurfaceFrame2.getFrameReadyMetadata(), FrameReadyMetadata::LateFinish); |
| 2452 | EXPECT_EQ(presentedSurfaceFrame2.getJankType(), |
| 2453 | JankType::AppDeadlineMissed | JankType::BufferStuffing); |
Ying Wei | 96eb535 | 2023-11-21 17:37:21 +0000 | [diff] [blame] | 2454 | EXPECT_EQ(presentedSurfaceFrame2.getJankSeverityType(), JankSeverityType::Full); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 2455 | } |
Alec Mouri | adebf5c | 2021-01-05 12:57:36 -0800 | [diff] [blame] | 2456 | |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 2457 | TEST_F(FrameTimelineTest, jankClassification_appDeadlineAdjustedForBufferStuffing) { |
| 2458 | // Layer specific increment |
| 2459 | EXPECT_CALL(*mTimeStats, incrementJankyFrames(_)).Times(2); |
| 2460 | auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
| 2461 | int64_t surfaceFrameToken1 = mTokenManager->generateTokenForPredictions({10, 20, 30}); |
| 2462 | int64_t surfaceFrameToken2 = mTokenManager->generateTokenForPredictions({40, 50, 60}); |
| 2463 | |
| 2464 | int64_t sfToken1 = mTokenManager->generateTokenForPredictions({52, 60, 60}); |
| 2465 | int64_t sfToken2 = mTokenManager->generateTokenForPredictions({82, 90, 90}); |
Huihong Luo | 3bdef86 | 2022-03-03 11:57:19 -0800 | [diff] [blame] | 2466 | FrameTimelineInfo ftInfo; |
| 2467 | ftInfo.vsyncId = surfaceFrameToken1; |
| 2468 | ftInfo.inputEventId = sInputEventId; |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 2469 | auto surfaceFrame1 = |
Huihong Luo | 3bdef86 | 2022-03-03 11:57:19 -0800 | [diff] [blame] | 2470 | mFrameTimeline->createSurfaceFrameForToken(ftInfo, sPidOne, sUidOne, sLayerIdOne, |
| 2471 | sLayerNameOne, sLayerNameOne, |
| 2472 | /*isBuffer*/ true, sGameMode); |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 2473 | surfaceFrame1->setAcquireFenceTime(50); |
Pascal Muetschard | ac7bcd9 | 2023-10-03 15:05:36 +0200 | [diff] [blame] | 2474 | mFrameTimeline->setSfWakeUp(sfToken1, 52, RR_30, RR_30); |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 2475 | surfaceFrame1->setPresentState(SurfaceFrame::PresentState::Presented); |
| 2476 | mFrameTimeline->addSurfaceFrame(surfaceFrame1); |
| 2477 | mFrameTimeline->setSfPresent(56, presentFence1); |
| 2478 | auto displayFrame1 = getDisplayFrame(0); |
| 2479 | auto& presentedSurfaceFrame1 = getSurfaceFrame(0, 0); |
| 2480 | presentFence1->signalForTest(60); |
| 2481 | |
| 2482 | // Fences for the first frame haven't been flushed yet, so it should be 0 |
| 2483 | EXPECT_EQ(displayFrame1->getActuals().presentTime, 0); |
| 2484 | auto actuals1 = presentedSurfaceFrame1.getActuals(); |
| 2485 | EXPECT_EQ(actuals1.presentTime, 0); |
| 2486 | |
| 2487 | // Trigger a flush by finalizing the next DisplayFrame |
| 2488 | auto presentFence2 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
Huihong Luo | 3bdef86 | 2022-03-03 11:57:19 -0800 | [diff] [blame] | 2489 | FrameTimelineInfo ftInfo2; |
| 2490 | ftInfo2.vsyncId = surfaceFrameToken2; |
| 2491 | ftInfo2.inputEventId = sInputEventId; |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 2492 | auto surfaceFrame2 = |
Huihong Luo | 3bdef86 | 2022-03-03 11:57:19 -0800 | [diff] [blame] | 2493 | mFrameTimeline->createSurfaceFrameForToken(ftInfo2, sPidOne, sUidOne, sLayerIdOne, |
| 2494 | sLayerNameOne, sLayerNameOne, |
| 2495 | /*isBuffer*/ true, sGameMode); |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 2496 | surfaceFrame2->setAcquireFenceTime(80); |
Pascal Muetschard | ac7bcd9 | 2023-10-03 15:05:36 +0200 | [diff] [blame] | 2497 | mFrameTimeline->setSfWakeUp(sfToken2, 82, RR_30, RR_30); |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 2498 | // Setting previous latch time to 54, adjusted deadline will be 54 + vsyncTime(30) = 84 |
| 2499 | surfaceFrame2->setPresentState(SurfaceFrame::PresentState::Presented, 54); |
| 2500 | mFrameTimeline->addSurfaceFrame(surfaceFrame2); |
| 2501 | mFrameTimeline->setSfPresent(86, presentFence2); |
| 2502 | auto displayFrame2 = getDisplayFrame(1); |
| 2503 | auto& presentedSurfaceFrame2 = getSurfaceFrame(1, 0); |
| 2504 | presentFence2->signalForTest(90); |
| 2505 | |
| 2506 | // Fences for the first frame have flushed, so the present timestamps should be updated |
| 2507 | EXPECT_EQ(displayFrame1->getActuals().presentTime, 60); |
| 2508 | actuals1 = presentedSurfaceFrame1.getActuals(); |
| 2509 | EXPECT_EQ(actuals1.endTime, 50); |
| 2510 | EXPECT_EQ(actuals1.presentTime, 60); |
| 2511 | |
| 2512 | EXPECT_EQ(displayFrame1->getFramePresentMetadata(), FramePresentMetadata::OnTimePresent); |
| 2513 | EXPECT_EQ(displayFrame1->getFrameReadyMetadata(), FrameReadyMetadata::OnTimeFinish); |
| 2514 | EXPECT_EQ(displayFrame1->getJankType(), JankType::None); |
Ying Wei | 96eb535 | 2023-11-21 17:37:21 +0000 | [diff] [blame] | 2515 | EXPECT_EQ(displayFrame1->getJankSeverityType(), JankSeverityType::None); |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 2516 | |
| 2517 | EXPECT_EQ(presentedSurfaceFrame1.getFramePresentMetadata(), FramePresentMetadata::LatePresent); |
| 2518 | EXPECT_EQ(presentedSurfaceFrame1.getFrameReadyMetadata(), FrameReadyMetadata::LateFinish); |
| 2519 | EXPECT_EQ(presentedSurfaceFrame1.getJankType(), JankType::AppDeadlineMissed); |
Ying Wei | 96eb535 | 2023-11-21 17:37:21 +0000 | [diff] [blame] | 2520 | EXPECT_EQ(presentedSurfaceFrame1.getJankSeverityType(), JankSeverityType::Full); |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 2521 | |
| 2522 | // Fences for the second frame haven't been flushed yet, so it should be 0 |
| 2523 | EXPECT_EQ(displayFrame2->getActuals().presentTime, 0); |
| 2524 | auto actuals2 = presentedSurfaceFrame2.getActuals(); |
| 2525 | EXPECT_EQ(actuals2.presentTime, 0); |
| 2526 | |
| 2527 | addEmptyDisplayFrame(); |
| 2528 | |
| 2529 | // Fences for the second frame have flushed, so the present timestamps should be updated |
| 2530 | EXPECT_EQ(displayFrame2->getActuals().presentTime, 90); |
| 2531 | actuals2 = presentedSurfaceFrame2.getActuals(); |
| 2532 | EXPECT_EQ(actuals2.presentTime, 90); |
| 2533 | |
| 2534 | EXPECT_EQ(displayFrame2->getFramePresentMetadata(), FramePresentMetadata::OnTimePresent); |
| 2535 | EXPECT_EQ(displayFrame2->getFrameReadyMetadata(), FrameReadyMetadata::OnTimeFinish); |
| 2536 | EXPECT_EQ(displayFrame2->getJankType(), JankType::None); |
Ying Wei | 96eb535 | 2023-11-21 17:37:21 +0000 | [diff] [blame] | 2537 | EXPECT_EQ(displayFrame2->getJankSeverityType(), JankSeverityType::None); |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 2538 | |
| 2539 | EXPECT_EQ(presentedSurfaceFrame2.getFramePresentMetadata(), FramePresentMetadata::LatePresent); |
| 2540 | EXPECT_EQ(presentedSurfaceFrame2.getFrameReadyMetadata(), FrameReadyMetadata::OnTimeFinish); |
| 2541 | EXPECT_EQ(presentedSurfaceFrame2.getJankType(), JankType::BufferStuffing); |
Ying Wei | 96eb535 | 2023-11-21 17:37:21 +0000 | [diff] [blame] | 2542 | EXPECT_EQ(presentedSurfaceFrame2.getJankSeverityType(), JankSeverityType::Full); |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 2543 | } |
| 2544 | |
Rachel Lee | 94917b3 | 2022-03-18 17:52:09 -0700 | [diff] [blame] | 2545 | TEST_F(FrameTimelineTest, jankClassification_displayFrameLateFinishLatePresent_GpuAndCpuMiss) { |
| 2546 | auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
| 2547 | auto presentFence2 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
| 2548 | auto gpuFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
| 2549 | int64_t sfToken1 = mTokenManager->generateTokenForPredictions({22, 26, 40}); |
| 2550 | int64_t sfToken2 = mTokenManager->generateTokenForPredictions({52, 60, 60}); |
| 2551 | |
| 2552 | // Case 1: cpu time = 33 - 12 = 21, vsync period = 11 |
Pascal Muetschard | ac7bcd9 | 2023-10-03 15:05:36 +0200 | [diff] [blame] | 2553 | mFrameTimeline->setSfWakeUp(sfToken1, 12, RR_11, RR_11); |
Rachel Lee | 94917b3 | 2022-03-18 17:52:09 -0700 | [diff] [blame] | 2554 | mFrameTimeline->setSfPresent(33, presentFence1, gpuFence1); |
| 2555 | auto displayFrame = getDisplayFrame(0); |
| 2556 | gpuFence1->signalForTest(36); |
| 2557 | presentFence1->signalForTest(52); |
| 2558 | |
| 2559 | // Fences haven't been flushed yet, so it should be 0 |
| 2560 | EXPECT_EQ(displayFrame->getActuals().presentTime, 0); |
| 2561 | |
| 2562 | addEmptyDisplayFrame(); |
| 2563 | displayFrame = getDisplayFrame(0); |
| 2564 | |
| 2565 | // Fences have flushed, so the present timestamps should be updated |
| 2566 | EXPECT_EQ(displayFrame->getActuals().presentTime, 52); |
| 2567 | EXPECT_EQ(displayFrame->getFramePresentMetadata(), FramePresentMetadata::LatePresent); |
| 2568 | EXPECT_EQ(displayFrame->getFrameReadyMetadata(), FrameReadyMetadata::LateFinish); |
| 2569 | EXPECT_EQ(displayFrame->getJankType(), JankType::SurfaceFlingerGpuDeadlineMissed); |
Ying Wei | 96eb535 | 2023-11-21 17:37:21 +0000 | [diff] [blame] | 2570 | EXPECT_EQ(displayFrame->getJankSeverityType(), JankSeverityType::Full); |
Rachel Lee | 94917b3 | 2022-03-18 17:52:09 -0700 | [diff] [blame] | 2571 | |
| 2572 | // Case 2: No GPU fence so it will not use GPU composition. |
Pascal Muetschard | ac7bcd9 | 2023-10-03 15:05:36 +0200 | [diff] [blame] | 2573 | mFrameTimeline->setSfWakeUp(sfToken2, 52, RR_30, RR_30); |
Rachel Lee | 94917b3 | 2022-03-18 17:52:09 -0700 | [diff] [blame] | 2574 | mFrameTimeline->setSfPresent(66, presentFence2); |
| 2575 | auto displayFrame2 = getDisplayFrame(2); // 2 because of previous empty frame |
| 2576 | presentFence2->signalForTest(90); |
| 2577 | |
| 2578 | // Fences for the frame haven't been flushed yet, so it should be 0 |
| 2579 | EXPECT_EQ(displayFrame2->getActuals().presentTime, 0); |
| 2580 | |
| 2581 | addEmptyDisplayFrame(); |
| 2582 | |
| 2583 | // Fences have flushed, so the present timestamps should be updated |
| 2584 | EXPECT_EQ(displayFrame2->getActuals().presentTime, 90); |
| 2585 | EXPECT_EQ(displayFrame2->getFramePresentMetadata(), FramePresentMetadata::LatePresent); |
| 2586 | EXPECT_EQ(displayFrame2->getFrameReadyMetadata(), FrameReadyMetadata::LateFinish); |
| 2587 | EXPECT_EQ(displayFrame2->getJankType(), JankType::SurfaceFlingerCpuDeadlineMissed); |
Ying Wei | 96eb535 | 2023-11-21 17:37:21 +0000 | [diff] [blame] | 2588 | EXPECT_EQ(displayFrame2->getJankSeverityType(), JankSeverityType::Full); |
Rachel Lee | 94917b3 | 2022-03-18 17:52:09 -0700 | [diff] [blame] | 2589 | } |
| 2590 | |
Ady Abraham | fcb1686 | 2022-10-10 14:35:21 -0700 | [diff] [blame] | 2591 | TEST_F(FrameTimelineTest, jankClassification_presentFenceError) { |
| 2592 | auto erroneousPresentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
| 2593 | auto erroneousPresentFence2 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
| 2594 | auto validPresentFence = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
| 2595 | int64_t sfToken1 = mTokenManager->generateTokenForPredictions({22, 26, 40}); |
| 2596 | int64_t sfToken2 = mTokenManager->generateTokenForPredictions({52, 60, 60}); |
| 2597 | int64_t sfToken3 = mTokenManager->generateTokenForPredictions({72, 80, 80}); |
| 2598 | |
Pascal Muetschard | ac7bcd9 | 2023-10-03 15:05:36 +0200 | [diff] [blame] | 2599 | mFrameTimeline->setSfWakeUp(sfToken1, 22, RR_11, RR_11); |
Ady Abraham | fcb1686 | 2022-10-10 14:35:21 -0700 | [diff] [blame] | 2600 | mFrameTimeline->setSfPresent(26, erroneousPresentFence1); |
| 2601 | |
Pascal Muetschard | ac7bcd9 | 2023-10-03 15:05:36 +0200 | [diff] [blame] | 2602 | mFrameTimeline->setSfWakeUp(sfToken2, 52, RR_11, RR_11); |
Ady Abraham | fcb1686 | 2022-10-10 14:35:21 -0700 | [diff] [blame] | 2603 | mFrameTimeline->setSfPresent(60, erroneousPresentFence2); |
| 2604 | |
Pascal Muetschard | ac7bcd9 | 2023-10-03 15:05:36 +0200 | [diff] [blame] | 2605 | mFrameTimeline->setSfWakeUp(sfToken3, 72, RR_11, RR_11); |
Ady Abraham | fcb1686 | 2022-10-10 14:35:21 -0700 | [diff] [blame] | 2606 | mFrameTimeline->setSfPresent(80, validPresentFence); |
| 2607 | |
Ady Abraham | b1e10d1 | 2023-03-13 15:23:54 -0700 | [diff] [blame] | 2608 | erroneousPresentFence2->signalForTest(2); |
Ady Abraham | fcb1686 | 2022-10-10 14:35:21 -0700 | [diff] [blame] | 2609 | validPresentFence->signalForTest(80); |
| 2610 | |
| 2611 | addEmptyDisplayFrame(); |
| 2612 | |
| 2613 | { |
| 2614 | auto displayFrame = getDisplayFrame(0); |
| 2615 | EXPECT_EQ(displayFrame->getActuals().presentTime, 26); |
| 2616 | EXPECT_EQ(displayFrame->getFramePresentMetadata(), FramePresentMetadata::UnknownPresent); |
| 2617 | EXPECT_EQ(displayFrame->getFrameReadyMetadata(), FrameReadyMetadata::UnknownFinish); |
Ady Abraham | b1e10d1 | 2023-03-13 15:23:54 -0700 | [diff] [blame] | 2618 | EXPECT_EQ(displayFrame->getJankType(), JankType::Unknown | JankType::DisplayHAL); |
Ying Wei | 96eb535 | 2023-11-21 17:37:21 +0000 | [diff] [blame] | 2619 | EXPECT_EQ(displayFrame->getJankSeverityType(), JankSeverityType::Unknown); |
Ady Abraham | fcb1686 | 2022-10-10 14:35:21 -0700 | [diff] [blame] | 2620 | } |
| 2621 | { |
| 2622 | auto displayFrame = getDisplayFrame(1); |
| 2623 | EXPECT_EQ(displayFrame->getActuals().presentTime, 60); |
| 2624 | EXPECT_EQ(displayFrame->getFramePresentMetadata(), FramePresentMetadata::UnknownPresent); |
| 2625 | EXPECT_EQ(displayFrame->getFrameReadyMetadata(), FrameReadyMetadata::UnknownFinish); |
Ady Abraham | b1e10d1 | 2023-03-13 15:23:54 -0700 | [diff] [blame] | 2626 | EXPECT_EQ(displayFrame->getJankType(), JankType::Unknown | JankType::DisplayHAL); |
Ying Wei | 96eb535 | 2023-11-21 17:37:21 +0000 | [diff] [blame] | 2627 | EXPECT_EQ(displayFrame->getJankSeverityType(), JankSeverityType::Unknown); |
Ady Abraham | fcb1686 | 2022-10-10 14:35:21 -0700 | [diff] [blame] | 2628 | } |
| 2629 | { |
| 2630 | auto displayFrame = getDisplayFrame(2); |
| 2631 | EXPECT_EQ(displayFrame->getActuals().presentTime, 80); |
| 2632 | EXPECT_EQ(displayFrame->getFramePresentMetadata(), FramePresentMetadata::OnTimePresent); |
| 2633 | EXPECT_EQ(displayFrame->getFrameReadyMetadata(), FrameReadyMetadata::OnTimeFinish); |
| 2634 | EXPECT_EQ(displayFrame->getJankType(), JankType::None); |
Ying Wei | 96eb535 | 2023-11-21 17:37:21 +0000 | [diff] [blame] | 2635 | EXPECT_EQ(displayFrame->getJankSeverityType(), JankSeverityType::None); |
Ady Abraham | fcb1686 | 2022-10-10 14:35:21 -0700 | [diff] [blame] | 2636 | } |
| 2637 | } |
| 2638 | |
Alec Mouri | adebf5c | 2021-01-05 12:57:36 -0800 | [diff] [blame] | 2639 | TEST_F(FrameTimelineTest, computeFps_noLayerIds_returnsZero) { |
| 2640 | EXPECT_EQ(mFrameTimeline->computeFps({}), 0.0f); |
| 2641 | } |
| 2642 | |
| 2643 | TEST_F(FrameTimelineTest, computeFps_singleDisplayFrame_returnsZero) { |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 2644 | const auto oneHundredMs = std::chrono::nanoseconds(100ms).count(); |
Alec Mouri | adebf5c | 2021-01-05 12:57:36 -0800 | [diff] [blame] | 2645 | |
| 2646 | auto surfaceFrame1 = |
| 2647 | mFrameTimeline->createSurfaceFrameForToken(FrameTimelineInfo(), sPidOne, sUidOne, |
Adithya Srinivasan | 785addd | 2021-03-09 00:38:00 +0000 | [diff] [blame] | 2648 | sLayerIdOne, sLayerNameOne, sLayerNameOne, |
Adithya Srinivasan | 58069dc | 2021-06-04 20:37:02 +0000 | [diff] [blame] | 2649 | /*isBuffer*/ true, sGameMode); |
Alec Mouri | adebf5c | 2021-01-05 12:57:36 -0800 | [diff] [blame] | 2650 | auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
| 2651 | surfaceFrame1->setPresentState(SurfaceFrame::PresentState::Presented); |
| 2652 | mFrameTimeline->addSurfaceFrame(surfaceFrame1); |
| 2653 | presentFence1->signalForTest(oneHundredMs); |
| 2654 | mFrameTimeline->setSfPresent(oneHundredMs, presentFence1); |
| 2655 | |
| 2656 | EXPECT_EQ(mFrameTimeline->computeFps({sLayerIdOne}), 0.0f); |
| 2657 | } |
| 2658 | |
| 2659 | TEST_F(FrameTimelineTest, computeFps_twoDisplayFrames_oneLayer) { |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 2660 | const auto oneHundredMs = std::chrono::nanoseconds(100ms).count(); |
| 2661 | const auto twoHundredMs = std::chrono::nanoseconds(200ms).count(); |
Alec Mouri | adebf5c | 2021-01-05 12:57:36 -0800 | [diff] [blame] | 2662 | auto surfaceFrame1 = |
| 2663 | mFrameTimeline->createSurfaceFrameForToken(FrameTimelineInfo(), sPidOne, sUidOne, |
Adithya Srinivasan | 785addd | 2021-03-09 00:38:00 +0000 | [diff] [blame] | 2664 | sLayerIdOne, sLayerNameOne, sLayerNameOne, |
Adithya Srinivasan | 58069dc | 2021-06-04 20:37:02 +0000 | [diff] [blame] | 2665 | /*isBuffer*/ true, sGameMode); |
Alec Mouri | adebf5c | 2021-01-05 12:57:36 -0800 | [diff] [blame] | 2666 | auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
| 2667 | surfaceFrame1->setPresentState(SurfaceFrame::PresentState::Presented); |
| 2668 | mFrameTimeline->addSurfaceFrame(surfaceFrame1); |
| 2669 | presentFence1->signalForTest(oneHundredMs); |
| 2670 | mFrameTimeline->setSfPresent(oneHundredMs, presentFence1); |
| 2671 | |
| 2672 | auto surfaceFrame2 = |
| 2673 | mFrameTimeline->createSurfaceFrameForToken(FrameTimelineInfo(), sPidOne, sUidOne, |
Adithya Srinivasan | 785addd | 2021-03-09 00:38:00 +0000 | [diff] [blame] | 2674 | sLayerIdOne, sLayerNameOne, sLayerNameOne, |
Adithya Srinivasan | 58069dc | 2021-06-04 20:37:02 +0000 | [diff] [blame] | 2675 | /*isBuffer*/ true, sGameMode); |
Alec Mouri | adebf5c | 2021-01-05 12:57:36 -0800 | [diff] [blame] | 2676 | auto presentFence2 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
| 2677 | surfaceFrame2->setPresentState(SurfaceFrame::PresentState::Presented); |
| 2678 | mFrameTimeline->addSurfaceFrame(surfaceFrame2); |
| 2679 | presentFence2->signalForTest(twoHundredMs); |
| 2680 | mFrameTimeline->setSfPresent(twoHundredMs, presentFence2); |
| 2681 | |
| 2682 | EXPECT_EQ(mFrameTimeline->computeFps({sLayerIdOne}), 10.0); |
| 2683 | } |
| 2684 | |
| 2685 | TEST_F(FrameTimelineTest, computeFps_twoDisplayFrames_twoLayers) { |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 2686 | const auto oneHundredMs = std::chrono::nanoseconds(100ms).count(); |
| 2687 | const auto twoHundredMs = std::chrono::nanoseconds(200ms).count(); |
Alec Mouri | adebf5c | 2021-01-05 12:57:36 -0800 | [diff] [blame] | 2688 | auto surfaceFrame1 = |
| 2689 | mFrameTimeline->createSurfaceFrameForToken(FrameTimelineInfo(), sPidOne, sUidOne, |
Adithya Srinivasan | 785addd | 2021-03-09 00:38:00 +0000 | [diff] [blame] | 2690 | sLayerIdOne, sLayerNameOne, sLayerNameOne, |
Adithya Srinivasan | 58069dc | 2021-06-04 20:37:02 +0000 | [diff] [blame] | 2691 | /*isBuffer*/ true, sGameMode); |
Alec Mouri | adebf5c | 2021-01-05 12:57:36 -0800 | [diff] [blame] | 2692 | auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
| 2693 | surfaceFrame1->setPresentState(SurfaceFrame::PresentState::Presented); |
| 2694 | mFrameTimeline->addSurfaceFrame(surfaceFrame1); |
| 2695 | presentFence1->signalForTest(oneHundredMs); |
| 2696 | mFrameTimeline->setSfPresent(oneHundredMs, presentFence1); |
| 2697 | |
| 2698 | auto surfaceFrame2 = |
| 2699 | mFrameTimeline->createSurfaceFrameForToken(FrameTimelineInfo(), sPidOne, sUidOne, |
Adithya Srinivasan | 785addd | 2021-03-09 00:38:00 +0000 | [diff] [blame] | 2700 | sLayerIdTwo, sLayerNameTwo, sLayerNameTwo, |
Adithya Srinivasan | 58069dc | 2021-06-04 20:37:02 +0000 | [diff] [blame] | 2701 | /*isBuffer*/ true, sGameMode); |
Alec Mouri | adebf5c | 2021-01-05 12:57:36 -0800 | [diff] [blame] | 2702 | auto presentFence2 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
| 2703 | surfaceFrame2->setPresentState(SurfaceFrame::PresentState::Presented); |
| 2704 | mFrameTimeline->addSurfaceFrame(surfaceFrame2); |
| 2705 | presentFence2->signalForTest(twoHundredMs); |
| 2706 | mFrameTimeline->setSfPresent(twoHundredMs, presentFence2); |
| 2707 | |
| 2708 | EXPECT_EQ(mFrameTimeline->computeFps({sLayerIdOne, sLayerIdTwo}), 10.0f); |
| 2709 | } |
| 2710 | |
| 2711 | TEST_F(FrameTimelineTest, computeFps_filtersOutLayers) { |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 2712 | const auto oneHundredMs = std::chrono::nanoseconds(100ms).count(); |
| 2713 | const auto twoHundredMs = std::chrono::nanoseconds(200ms).count(); |
Alec Mouri | adebf5c | 2021-01-05 12:57:36 -0800 | [diff] [blame] | 2714 | auto surfaceFrame1 = |
| 2715 | mFrameTimeline->createSurfaceFrameForToken(FrameTimelineInfo(), sPidOne, sUidOne, |
Adithya Srinivasan | 785addd | 2021-03-09 00:38:00 +0000 | [diff] [blame] | 2716 | sLayerIdOne, sLayerNameOne, sLayerNameOne, |
Adithya Srinivasan | 58069dc | 2021-06-04 20:37:02 +0000 | [diff] [blame] | 2717 | /*isBuffer*/ true, sGameMode); |
Alec Mouri | adebf5c | 2021-01-05 12:57:36 -0800 | [diff] [blame] | 2718 | auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
| 2719 | surfaceFrame1->setPresentState(SurfaceFrame::PresentState::Presented); |
| 2720 | mFrameTimeline->addSurfaceFrame(surfaceFrame1); |
| 2721 | presentFence1->signalForTest(oneHundredMs); |
| 2722 | mFrameTimeline->setSfPresent(oneHundredMs, presentFence1); |
| 2723 | |
| 2724 | auto surfaceFrame2 = |
| 2725 | mFrameTimeline->createSurfaceFrameForToken(FrameTimelineInfo(), sPidOne, sUidOne, |
Adithya Srinivasan | 785addd | 2021-03-09 00:38:00 +0000 | [diff] [blame] | 2726 | sLayerIdTwo, sLayerNameTwo, sLayerNameTwo, |
Adithya Srinivasan | 58069dc | 2021-06-04 20:37:02 +0000 | [diff] [blame] | 2727 | /*isBuffer*/ true, sGameMode); |
Alec Mouri | adebf5c | 2021-01-05 12:57:36 -0800 | [diff] [blame] | 2728 | auto presentFence2 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
| 2729 | surfaceFrame2->setPresentState(SurfaceFrame::PresentState::Presented); |
| 2730 | mFrameTimeline->addSurfaceFrame(surfaceFrame2); |
| 2731 | presentFence2->signalForTest(twoHundredMs); |
| 2732 | mFrameTimeline->setSfPresent(twoHundredMs, presentFence2); |
| 2733 | |
| 2734 | EXPECT_EQ(mFrameTimeline->computeFps({sLayerIdOne}), 0.0f); |
| 2735 | } |
| 2736 | |
| 2737 | TEST_F(FrameTimelineTest, computeFps_averagesOverMultipleFrames) { |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 2738 | const auto oneHundredMs = std::chrono::nanoseconds(100ms).count(); |
| 2739 | const auto twoHundredMs = std::chrono::nanoseconds(200ms).count(); |
| 2740 | const auto threeHundredMs = std::chrono::nanoseconds(300ms).count(); |
| 2741 | const auto fiveHundredMs = std::chrono::nanoseconds(500ms).count(); |
| 2742 | const auto sixHundredMs = std::chrono::nanoseconds(600ms).count(); |
Alec Mouri | adebf5c | 2021-01-05 12:57:36 -0800 | [diff] [blame] | 2743 | auto surfaceFrame1 = |
| 2744 | mFrameTimeline->createSurfaceFrameForToken(FrameTimelineInfo(), sPidOne, sUidOne, |
Adithya Srinivasan | 785addd | 2021-03-09 00:38:00 +0000 | [diff] [blame] | 2745 | sLayerIdOne, sLayerNameOne, sLayerNameOne, |
Adithya Srinivasan | 58069dc | 2021-06-04 20:37:02 +0000 | [diff] [blame] | 2746 | /*isBuffer*/ true, sGameMode); |
Alec Mouri | adebf5c | 2021-01-05 12:57:36 -0800 | [diff] [blame] | 2747 | auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
| 2748 | surfaceFrame1->setPresentState(SurfaceFrame::PresentState::Presented); |
| 2749 | mFrameTimeline->addSurfaceFrame(surfaceFrame1); |
| 2750 | presentFence1->signalForTest(oneHundredMs); |
| 2751 | mFrameTimeline->setSfPresent(oneHundredMs, presentFence1); |
| 2752 | |
| 2753 | auto surfaceFrame2 = |
| 2754 | mFrameTimeline->createSurfaceFrameForToken(FrameTimelineInfo(), sPidOne, sUidOne, |
Adithya Srinivasan | 785addd | 2021-03-09 00:38:00 +0000 | [diff] [blame] | 2755 | sLayerIdOne, sLayerNameOne, sLayerNameOne, |
Adithya Srinivasan | 58069dc | 2021-06-04 20:37:02 +0000 | [diff] [blame] | 2756 | /*isBuffer*/ true, sGameMode); |
Alec Mouri | adebf5c | 2021-01-05 12:57:36 -0800 | [diff] [blame] | 2757 | auto presentFence2 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
| 2758 | surfaceFrame2->setPresentState(SurfaceFrame::PresentState::Presented); |
| 2759 | mFrameTimeline->addSurfaceFrame(surfaceFrame2); |
| 2760 | presentFence2->signalForTest(twoHundredMs); |
| 2761 | mFrameTimeline->setSfPresent(twoHundredMs, presentFence2); |
| 2762 | |
| 2763 | auto surfaceFrame3 = |
| 2764 | mFrameTimeline->createSurfaceFrameForToken(FrameTimelineInfo(), sPidOne, sUidOne, |
Adithya Srinivasan | 785addd | 2021-03-09 00:38:00 +0000 | [diff] [blame] | 2765 | sLayerIdTwo, sLayerNameTwo, sLayerNameTwo, |
Adithya Srinivasan | 58069dc | 2021-06-04 20:37:02 +0000 | [diff] [blame] | 2766 | /*isBuffer*/ true, sGameMode); |
Alec Mouri | adebf5c | 2021-01-05 12:57:36 -0800 | [diff] [blame] | 2767 | auto presentFence3 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
| 2768 | surfaceFrame3->setPresentState(SurfaceFrame::PresentState::Presented); |
| 2769 | mFrameTimeline->addSurfaceFrame(surfaceFrame3); |
| 2770 | presentFence3->signalForTest(threeHundredMs); |
| 2771 | mFrameTimeline->setSfPresent(threeHundredMs, presentFence3); |
| 2772 | |
| 2773 | auto surfaceFrame4 = |
| 2774 | mFrameTimeline->createSurfaceFrameForToken(FrameTimelineInfo(), sPidOne, sUidOne, |
Adithya Srinivasan | 785addd | 2021-03-09 00:38:00 +0000 | [diff] [blame] | 2775 | sLayerIdOne, sLayerNameOne, sLayerNameOne, |
Adithya Srinivasan | 58069dc | 2021-06-04 20:37:02 +0000 | [diff] [blame] | 2776 | /*isBuffer*/ true, sGameMode); |
Alec Mouri | adebf5c | 2021-01-05 12:57:36 -0800 | [diff] [blame] | 2777 | auto presentFence4 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
| 2778 | surfaceFrame4->setPresentState(SurfaceFrame::PresentState::Presented); |
| 2779 | mFrameTimeline->addSurfaceFrame(surfaceFrame4); |
| 2780 | presentFence4->signalForTest(fiveHundredMs); |
| 2781 | mFrameTimeline->setSfPresent(fiveHundredMs, presentFence4); |
| 2782 | |
| 2783 | auto surfaceFrame5 = |
| 2784 | mFrameTimeline->createSurfaceFrameForToken(FrameTimelineInfo(), sPidOne, sUidOne, |
Adithya Srinivasan | 785addd | 2021-03-09 00:38:00 +0000 | [diff] [blame] | 2785 | sLayerIdOne, sLayerNameOne, sLayerNameOne, |
Adithya Srinivasan | 58069dc | 2021-06-04 20:37:02 +0000 | [diff] [blame] | 2786 | /*isBuffer*/ true, sGameMode); |
Alec Mouri | adebf5c | 2021-01-05 12:57:36 -0800 | [diff] [blame] | 2787 | auto presentFence5 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
| 2788 | // Dropped frames will be excluded from fps computation |
| 2789 | surfaceFrame5->setPresentState(SurfaceFrame::PresentState::Dropped); |
| 2790 | mFrameTimeline->addSurfaceFrame(surfaceFrame5); |
| 2791 | presentFence5->signalForTest(sixHundredMs); |
| 2792 | mFrameTimeline->setSfPresent(sixHundredMs, presentFence5); |
| 2793 | |
| 2794 | EXPECT_EQ(mFrameTimeline->computeFps({sLayerIdOne}), 5.0f); |
| 2795 | } |
| 2796 | |
ramindani | ea2bb82 | 2022-06-27 19:52:10 +0000 | [diff] [blame] | 2797 | TEST_F(FrameTimelineTest, getMinTime) { |
| 2798 | // Use SurfaceFrame::getBaseTime to test the getMinTime. |
| 2799 | FrameTimelineInfo ftInfo; |
| 2800 | |
| 2801 | // Valid prediction state test. |
| 2802 | ftInfo.vsyncId = 0L; |
| 2803 | mTokenManager->generateTokenForPredictions({10}); |
| 2804 | auto surfaceFrame = |
| 2805 | mFrameTimeline->createSurfaceFrameForToken(ftInfo, sPidOne, sUidOne, sLayerIdOne, |
| 2806 | sLayerNameOne, sLayerNameOne, |
| 2807 | /*isBuffer*/ true, sGameMode); |
| 2808 | ASSERT_EQ(surfaceFrame->getBaseTime(), 10); |
| 2809 | |
| 2810 | // Test prediction state which is not valid. |
| 2811 | ftInfo.vsyncId = FrameTimelineInfo::INVALID_VSYNC_ID; |
| 2812 | surfaceFrame = mFrameTimeline->createSurfaceFrameForToken(ftInfo, sPidOne, sUidOne, sLayerIdOne, |
| 2813 | sLayerNameOne, sLayerNameOne, |
| 2814 | /*isBuffer*/ true, sGameMode); |
| 2815 | // Start time test. |
| 2816 | surfaceFrame->setActualStartTime(200); |
| 2817 | ASSERT_EQ(surfaceFrame->getBaseTime(), 200); |
| 2818 | |
| 2819 | // End time test. |
| 2820 | surfaceFrame->setAcquireFenceTime(100); |
| 2821 | ASSERT_EQ(surfaceFrame->getBaseTime(), 100); |
| 2822 | |
| 2823 | // Present time test. |
| 2824 | auto presentFence = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
| 2825 | surfaceFrame->setPresentState(SurfaceFrame::PresentState::Presented); |
| 2826 | mFrameTimeline->addSurfaceFrame(surfaceFrame); |
| 2827 | presentFence->signalForTest(std::chrono::nanoseconds(50ns).count()); |
| 2828 | mFrameTimeline->setSfPresent(50, presentFence); |
| 2829 | ASSERT_EQ(surfaceFrame->getBaseTime(), 50); |
| 2830 | } |
Pascal Muetschard | ac7bcd9 | 2023-10-03 15:05:36 +0200 | [diff] [blame] | 2831 | |
| 2832 | TEST_F(FrameTimelineTest, surfaceFrameRenderRateUsingDisplayRate) { |
| 2833 | auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
| 2834 | int64_t token1 = mTokenManager->generateTokenForPredictions({10, 20, 30}); |
| 2835 | FrameTimelineInfo ftInfo; |
| 2836 | ftInfo.vsyncId = token1; |
| 2837 | ftInfo.inputEventId = sInputEventId; |
| 2838 | auto surfaceFrame = |
| 2839 | mFrameTimeline->createSurfaceFrameForToken(ftInfo, sPidOne, sUidOne, sLayerIdOne, |
| 2840 | sLayerNameOne, sLayerNameOne, |
| 2841 | /*isBuffer*/ true, sGameMode); |
| 2842 | |
| 2843 | mFrameTimeline->setSfWakeUp(token1, 20, RR_30, RR_11); |
| 2844 | surfaceFrame->setPresentState(SurfaceFrame::PresentState::Presented); |
| 2845 | mFrameTimeline->addSurfaceFrame(surfaceFrame); |
| 2846 | presentFence1->signalForTest(std::chrono::nanoseconds(50ns).count()); |
| 2847 | mFrameTimeline->setSfPresent(50, presentFence1); |
| 2848 | |
| 2849 | EXPECT_EQ(surfaceFrame->getRenderRate().getPeriodNsecs(), 11); |
| 2850 | } |
| 2851 | |
| 2852 | TEST_F(FrameTimelineTest, surfaceFrameRenderRateUsingAppFrameRate) { |
| 2853 | auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
| 2854 | int64_t token1 = mTokenManager->generateTokenForPredictions({10, 20, 30}); |
| 2855 | FrameTimelineInfo ftInfo; |
| 2856 | ftInfo.vsyncId = token1; |
| 2857 | ftInfo.inputEventId = sInputEventId; |
| 2858 | auto surfaceFrame = |
| 2859 | mFrameTimeline->createSurfaceFrameForToken(ftInfo, sPidOne, sUidOne, sLayerIdOne, |
| 2860 | sLayerNameOne, sLayerNameOne, |
| 2861 | /*isBuffer*/ true, sGameMode); |
| 2862 | surfaceFrame->setRenderRate(RR_30); |
| 2863 | mFrameTimeline->setSfWakeUp(token1, 20, RR_11, RR_11); |
| 2864 | surfaceFrame->setPresentState(SurfaceFrame::PresentState::Presented); |
| 2865 | mFrameTimeline->addSurfaceFrame(surfaceFrame); |
| 2866 | presentFence1->signalForTest(std::chrono::nanoseconds(50ns).count()); |
| 2867 | mFrameTimeline->setSfPresent(50, presentFence1); |
| 2868 | |
| 2869 | EXPECT_EQ(surfaceFrame->getRenderRate().getPeriodNsecs(), 30); |
| 2870 | } |
Adithya Srinivasan | f279e04 | 2020-08-17 14:56:27 -0700 | [diff] [blame] | 2871 | } // namespace android::frametimeline |