Adithya Srinivasan | f279e04 | 2020-08-17 14:56:27 -0700 | [diff] [blame] | 1 | /* |
| 2 | * Copyright 2020 The Android Open Source Project |
| 3 | * |
| 4 | * Licensed under the Apache License, Version 2.0 (the "License"); |
| 5 | * you may not use this file except in compliance with the License. |
| 6 | * You may obtain a copy of the License at |
| 7 | * |
| 8 | * http://www.apache.org/licenses/LICENSE-2.0 |
| 9 | * |
| 10 | * Unless required by applicable law or agreed to in writing, software |
| 11 | * distributed under the License is distributed on an "AS IS" BASIS, |
| 12 | * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. |
| 13 | * See the License for the specific language governing permissions and |
| 14 | * limitations under the License. |
| 15 | */ |
| 16 | |
Ady Abraham | 3db8a3c | 2023-11-20 17:53:47 -0800 | [diff] [blame^] | 17 | #include <common/test/FlagUtils.h> |
Sally Qi | f572125 | 2023-11-17 11:14:53 -0800 | [diff] [blame] | 18 | #include "com_android_graphics_surfaceflinger_flags.h" |
Alec Mouri | 9a29e67 | 2020-09-14 12:39:14 -0700 | [diff] [blame] | 19 | #include "gmock/gmock-spec-builders.h" |
| 20 | #include "mock/MockTimeStats.h" |
Adithya Srinivasan | f279e04 | 2020-08-17 14:56:27 -0700 | [diff] [blame] | 21 | #undef LOG_TAG |
| 22 | #define LOG_TAG "LibSurfaceFlingerUnittests" |
| 23 | |
| 24 | #include <FrameTimeline/FrameTimeline.h> |
| 25 | #include <gtest/gtest.h> |
| 26 | #include <log/log.h> |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 27 | #include <perfetto/trace/trace.pb.h> |
Adithya Srinivasan | f279e04 | 2020-08-17 14:56:27 -0700 | [diff] [blame] | 28 | #include <cinttypes> |
| 29 | |
| 30 | using namespace std::chrono_literals; |
Alec Mouri | 363faf0 | 2021-01-29 16:34:55 -0800 | [diff] [blame] | 31 | using testing::_; |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 32 | using testing::AtLeast; |
Alec Mouri | 9a29e67 | 2020-09-14 12:39:14 -0700 | [diff] [blame] | 33 | using testing::Contains; |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 34 | using FrameTimelineEvent = perfetto::protos::FrameTimelineEvent; |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 35 | using ProtoExpectedDisplayFrameStart = |
| 36 | perfetto::protos::FrameTimelineEvent_ExpectedDisplayFrameStart; |
| 37 | using ProtoExpectedSurfaceFrameStart = |
| 38 | perfetto::protos::FrameTimelineEvent_ExpectedSurfaceFrameStart; |
| 39 | using ProtoActualDisplayFrameStart = perfetto::protos::FrameTimelineEvent_ActualDisplayFrameStart; |
| 40 | using ProtoActualSurfaceFrameStart = perfetto::protos::FrameTimelineEvent_ActualSurfaceFrameStart; |
| 41 | using ProtoFrameEnd = perfetto::protos::FrameTimelineEvent_FrameEnd; |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 42 | using ProtoPresentType = perfetto::protos::FrameTimelineEvent_PresentType; |
| 43 | using ProtoJankType = perfetto::protos::FrameTimelineEvent_JankType; |
Adithya Srinivasan | 78e58af | 2021-02-25 00:08:08 +0000 | [diff] [blame] | 44 | using ProtoPredictionType = perfetto::protos::FrameTimelineEvent_PredictionType; |
Alec Mouri | 9a29e67 | 2020-09-14 12:39:14 -0700 | [diff] [blame] | 45 | |
Adithya Srinivasan | f279e04 | 2020-08-17 14:56:27 -0700 | [diff] [blame] | 46 | namespace android::frametimeline { |
| 47 | |
Ady Abraham | 57a8ab4 | 2023-01-26 15:28:19 -0800 | [diff] [blame] | 48 | static const std::string sLayerNameOne = "layer1"; |
| 49 | static const std::string sLayerNameTwo = "layer2"; |
| 50 | |
| 51 | constexpr const uid_t sUidOne = 0; |
| 52 | constexpr pid_t sPidOne = 10; |
| 53 | constexpr pid_t sPidTwo = 20; |
| 54 | constexpr int32_t sInputEventId = 5; |
| 55 | constexpr int32_t sLayerIdOne = 1; |
| 56 | constexpr int32_t sLayerIdTwo = 2; |
| 57 | constexpr GameMode sGameMode = GameMode::Unsupported; |
Pascal Muetschard | ac7bcd9 | 2023-10-03 15:05:36 +0200 | [diff] [blame] | 58 | constexpr Fps RR_11 = Fps::fromPeriodNsecs(11); |
| 59 | constexpr Fps RR_30 = Fps::fromPeriodNsecs(30); |
Ady Abraham | 57a8ab4 | 2023-01-26 15:28:19 -0800 | [diff] [blame] | 60 | |
Adithya Srinivasan | f279e04 | 2020-08-17 14:56:27 -0700 | [diff] [blame] | 61 | class FrameTimelineTest : public testing::Test { |
| 62 | public: |
| 63 | FrameTimelineTest() { |
| 64 | const ::testing::TestInfo* const test_info = |
| 65 | ::testing::UnitTest::GetInstance()->current_test_info(); |
| 66 | ALOGD("**** Setting up for %s.%s\n", test_info->test_case_name(), test_info->name()); |
| 67 | } |
| 68 | |
| 69 | ~FrameTimelineTest() { |
| 70 | const ::testing::TestInfo* const test_info = |
| 71 | ::testing::UnitTest::GetInstance()->current_test_info(); |
| 72 | ALOGD("**** Tearing down after %s.%s\n", test_info->test_case_name(), test_info->name()); |
| 73 | } |
| 74 | |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 75 | static void SetUpTestSuite() { |
| 76 | // Need to initialize tracing in process for testing, and only once per test suite. |
| 77 | perfetto::TracingInitArgs args; |
| 78 | args.backends = perfetto::kInProcessBackend; |
| 79 | perfetto::Tracing::Initialize(args); |
| 80 | } |
| 81 | |
Adithya Srinivasan | f279e04 | 2020-08-17 14:56:27 -0700 | [diff] [blame] | 82 | void SetUp() override { |
Ady Abraham | 57f8e18 | 2022-03-08 15:54:33 -0800 | [diff] [blame] | 83 | constexpr bool kUseBootTimeClock = true; |
Alec Mouri | 9a29e67 | 2020-09-14 12:39:14 -0700 | [diff] [blame] | 84 | mTimeStats = std::make_shared<mock::TimeStats>(); |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 85 | mFrameTimeline = std::make_unique<impl::FrameTimeline>(mTimeStats, kSurfaceFlingerPid, |
Ady Abraham | 57f8e18 | 2022-03-08 15:54:33 -0800 | [diff] [blame] | 86 | kTestThresholds, !kUseBootTimeClock); |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 87 | mFrameTimeline->registerDataSource(); |
Adithya Srinivasan | f279e04 | 2020-08-17 14:56:27 -0700 | [diff] [blame] | 88 | mTokenManager = &mFrameTimeline->mTokenManager; |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 89 | mTraceCookieCounter = &mFrameTimeline->mTraceCookieCounter; |
Adithya Srinivasan | 2d73632 | 2020-10-01 16:53:48 -0700 | [diff] [blame] | 90 | maxDisplayFrames = &mFrameTimeline->mMaxDisplayFrames; |
Adithya Srinivasan | bed4c4f | 2021-05-03 20:24:46 +0000 | [diff] [blame] | 91 | maxTokens = mTokenManager->kMaxTokens; |
Adithya Srinivasan | f279e04 | 2020-08-17 14:56:27 -0700 | [diff] [blame] | 92 | } |
| 93 | |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 94 | // Each tracing session can be used for a single block of Start -> Stop. |
| 95 | static std::unique_ptr<perfetto::TracingSession> getTracingSessionForTest() { |
| 96 | perfetto::TraceConfig cfg; |
| 97 | cfg.set_duration_ms(500); |
| 98 | cfg.add_buffers()->set_size_kb(1024); |
| 99 | auto* ds_cfg = cfg.add_data_sources()->mutable_config(); |
| 100 | ds_cfg->set_name(impl::FrameTimeline::kFrameTimelineDataSource); |
| 101 | |
| 102 | auto tracingSession = perfetto::Tracing::NewTrace(perfetto::kInProcessBackend); |
| 103 | tracingSession->Setup(cfg); |
| 104 | return tracingSession; |
| 105 | } |
| 106 | |
| 107 | std::vector<perfetto::protos::TracePacket> readFrameTimelinePacketsBlocking( |
| 108 | perfetto::TracingSession* tracingSession) { |
| 109 | std::vector<char> raw_trace = tracingSession->ReadTraceBlocking(); |
| 110 | perfetto::protos::Trace trace; |
| 111 | EXPECT_TRUE(trace.ParseFromArray(raw_trace.data(), int(raw_trace.size()))); |
| 112 | |
| 113 | std::vector<perfetto::protos::TracePacket> packets; |
| 114 | for (const auto& packet : trace.packet()) { |
| 115 | if (!packet.has_frame_timeline_event()) { |
| 116 | continue; |
| 117 | } |
| 118 | packets.emplace_back(packet); |
| 119 | } |
| 120 | return packets; |
| 121 | } |
| 122 | |
Ady Abraham | 57a8ab4 | 2023-01-26 15:28:19 -0800 | [diff] [blame] | 123 | void addEmptySurfaceFrame() { |
| 124 | auto surfaceFrame = |
| 125 | mFrameTimeline->createSurfaceFrameForToken({}, sPidOne, sUidOne, sLayerIdOne, |
| 126 | sLayerNameOne, sLayerNameOne, |
| 127 | /*isBuffer*/ false, sGameMode); |
| 128 | mFrameTimeline->addSurfaceFrame(std::move(surfaceFrame)); |
| 129 | } |
| 130 | |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 131 | void addEmptyDisplayFrame() { |
| 132 | auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 133 | // Trigger a flushPresentFence by calling setSfPresent for the next frame |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 134 | mFrameTimeline->setSfPresent(2500, presentFence1); |
| 135 | } |
| 136 | |
Adithya Srinivasan | bed4c4f | 2021-05-03 20:24:46 +0000 | [diff] [blame] | 137 | void flushTokens() { |
| 138 | for (size_t i = 0; i < maxTokens; i++) { |
| 139 | mTokenManager->generateTokenForPredictions({}); |
| 140 | } |
| 141 | EXPECT_EQ(getPredictions().size(), maxTokens); |
Adithya Srinivasan | f279e04 | 2020-08-17 14:56:27 -0700 | [diff] [blame] | 142 | } |
| 143 | |
| 144 | SurfaceFrame& getSurfaceFrame(size_t displayFrameIdx, size_t surfaceFrameIdx) { |
| 145 | std::lock_guard<std::mutex> lock(mFrameTimeline->mMutex); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 146 | return *(mFrameTimeline->mDisplayFrames[displayFrameIdx] |
| 147 | ->getSurfaceFrames()[surfaceFrameIdx]); |
Adithya Srinivasan | f279e04 | 2020-08-17 14:56:27 -0700 | [diff] [blame] | 148 | } |
| 149 | |
| 150 | std::shared_ptr<impl::FrameTimeline::DisplayFrame> getDisplayFrame(size_t idx) { |
| 151 | std::lock_guard<std::mutex> lock(mFrameTimeline->mMutex); |
| 152 | return mFrameTimeline->mDisplayFrames[idx]; |
| 153 | } |
| 154 | |
| 155 | static bool compareTimelineItems(const TimelineItem& a, const TimelineItem& b) { |
| 156 | return a.startTime == b.startTime && a.endTime == b.endTime && |
| 157 | a.presentTime == b.presentTime; |
| 158 | } |
| 159 | |
Adithya Srinivasan | bed4c4f | 2021-05-03 20:24:46 +0000 | [diff] [blame] | 160 | const std::map<int64_t, TimelineItem>& getPredictions() const { |
Adithya Srinivasan | f279e04 | 2020-08-17 14:56:27 -0700 | [diff] [blame] | 161 | return mTokenManager->mPredictions; |
| 162 | } |
| 163 | |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 164 | uint32_t getNumberOfDisplayFrames() const { |
Adithya Srinivasan | 2d73632 | 2020-10-01 16:53:48 -0700 | [diff] [blame] | 165 | std::lock_guard<std::mutex> lock(mFrameTimeline->mMutex); |
| 166 | return static_cast<uint32_t>(mFrameTimeline->mDisplayFrames.size()); |
| 167 | } |
| 168 | |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 169 | int64_t snoopCurrentTraceCookie() const { return mTraceCookieCounter->mTraceCookie; } |
| 170 | |
| 171 | void flushTrace() { |
| 172 | using FrameTimelineDataSource = impl::FrameTimeline::FrameTimelineDataSource; |
| 173 | FrameTimelineDataSource::Trace( |
| 174 | [&](FrameTimelineDataSource::TraceContext ctx) { ctx.Flush(); }); |
| 175 | } |
| 176 | |
Alec Mouri | 9a29e67 | 2020-09-14 12:39:14 -0700 | [diff] [blame] | 177 | std::shared_ptr<mock::TimeStats> mTimeStats; |
Adithya Srinivasan | f279e04 | 2020-08-17 14:56:27 -0700 | [diff] [blame] | 178 | std::unique_ptr<impl::FrameTimeline> mFrameTimeline; |
| 179 | impl::TokenManager* mTokenManager; |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 180 | TraceCookieCounter* mTraceCookieCounter; |
Adithya Srinivasan | f279e04 | 2020-08-17 14:56:27 -0700 | [diff] [blame] | 181 | FenceToFenceTimeMap fenceFactory; |
Adithya Srinivasan | 2d73632 | 2020-10-01 16:53:48 -0700 | [diff] [blame] | 182 | uint32_t* maxDisplayFrames; |
Adithya Srinivasan | bed4c4f | 2021-05-03 20:24:46 +0000 | [diff] [blame] | 183 | size_t maxTokens; |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 184 | static constexpr pid_t kSurfaceFlingerPid = 666; |
Adithya Srinivasan | ead1716 | 2021-02-18 02:17:37 +0000 | [diff] [blame] | 185 | static constexpr nsecs_t kPresentThreshold = std::chrono::nanoseconds(2ns).count(); |
Adithya Srinivasan | 54996e2 | 2021-06-25 22:26:45 +0000 | [diff] [blame] | 186 | static constexpr nsecs_t kDeadlineThreshold = std::chrono::nanoseconds(0ns).count(); |
Adithya Srinivasan | ead1716 | 2021-02-18 02:17:37 +0000 | [diff] [blame] | 187 | static constexpr nsecs_t kStartThreshold = std::chrono::nanoseconds(2ns).count(); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 188 | static constexpr JankClassificationThresholds kTestThresholds{kPresentThreshold, |
| 189 | kDeadlineThreshold, |
| 190 | kStartThreshold}; |
Adithya Srinivasan | f279e04 | 2020-08-17 14:56:27 -0700 | [diff] [blame] | 191 | }; |
| 192 | |
| 193 | TEST_F(FrameTimelineTest, tokenManagerRemovesStalePredictions) { |
| 194 | int64_t token1 = mTokenManager->generateTokenForPredictions({0, 0, 0}); |
Siarhei Vishniakou | fc434ac | 2021-01-13 10:28:00 -1000 | [diff] [blame] | 195 | EXPECT_EQ(getPredictions().size(), 1u); |
Adithya Srinivasan | bed4c4f | 2021-05-03 20:24:46 +0000 | [diff] [blame] | 196 | flushTokens(); |
Adithya Srinivasan | f279e04 | 2020-08-17 14:56:27 -0700 | [diff] [blame] | 197 | int64_t token2 = mTokenManager->generateTokenForPredictions({10, 20, 30}); |
| 198 | std::optional<TimelineItem> predictions = mTokenManager->getPredictionsForToken(token1); |
| 199 | |
| 200 | // token1 should have expired |
Adithya Srinivasan | f279e04 | 2020-08-17 14:56:27 -0700 | [diff] [blame] | 201 | EXPECT_EQ(predictions.has_value(), false); |
| 202 | |
| 203 | predictions = mTokenManager->getPredictionsForToken(token2); |
| 204 | EXPECT_EQ(compareTimelineItems(*predictions, TimelineItem(10, 20, 30)), true); |
| 205 | } |
| 206 | |
Adithya Srinivasan | 9febda8 | 2020-10-19 10:49:41 -0700 | [diff] [blame] | 207 | TEST_F(FrameTimelineTest, createSurfaceFrameForToken_getOwnerPidReturnsCorrectPid) { |
Alec Mouri | adebf5c | 2021-01-05 12:57:36 -0800 | [diff] [blame] | 208 | auto surfaceFrame1 = |
| 209 | mFrameTimeline->createSurfaceFrameForToken({}, sPidOne, sUidOne, sLayerIdOne, |
Adithya Srinivasan | 785addd | 2021-03-09 00:38:00 +0000 | [diff] [blame] | 210 | sLayerNameOne, sLayerNameOne, |
Adithya Srinivasan | 58069dc | 2021-06-04 20:37:02 +0000 | [diff] [blame] | 211 | /*isBuffer*/ true, sGameMode); |
Alec Mouri | adebf5c | 2021-01-05 12:57:36 -0800 | [diff] [blame] | 212 | auto surfaceFrame2 = |
| 213 | mFrameTimeline->createSurfaceFrameForToken({}, sPidTwo, sUidOne, sLayerIdOne, |
Adithya Srinivasan | 785addd | 2021-03-09 00:38:00 +0000 | [diff] [blame] | 214 | sLayerNameOne, sLayerNameOne, |
Adithya Srinivasan | 58069dc | 2021-06-04 20:37:02 +0000 | [diff] [blame] | 215 | /*isBuffer*/ true, sGameMode); |
Adithya Srinivasan | 9febda8 | 2020-10-19 10:49:41 -0700 | [diff] [blame] | 216 | EXPECT_EQ(surfaceFrame1->getOwnerPid(), sPidOne); |
| 217 | EXPECT_EQ(surfaceFrame2->getOwnerPid(), sPidTwo); |
| 218 | } |
| 219 | |
Adithya Srinivasan | f279e04 | 2020-08-17 14:56:27 -0700 | [diff] [blame] | 220 | TEST_F(FrameTimelineTest, createSurfaceFrameForToken_noToken) { |
Alec Mouri | adebf5c | 2021-01-05 12:57:36 -0800 | [diff] [blame] | 221 | auto surfaceFrame = |
| 222 | mFrameTimeline->createSurfaceFrameForToken({}, sPidOne, sUidOne, sLayerIdOne, |
Adithya Srinivasan | 785addd | 2021-03-09 00:38:00 +0000 | [diff] [blame] | 223 | sLayerNameOne, sLayerNameOne, |
Adithya Srinivasan | 58069dc | 2021-06-04 20:37:02 +0000 | [diff] [blame] | 224 | /*isBuffer*/ true, sGameMode); |
Adithya Srinivasan | f279e04 | 2020-08-17 14:56:27 -0700 | [diff] [blame] | 225 | EXPECT_EQ(surfaceFrame->getPredictionState(), PredictionState::None); |
| 226 | } |
| 227 | |
| 228 | TEST_F(FrameTimelineTest, createSurfaceFrameForToken_expiredToken) { |
| 229 | int64_t token1 = mTokenManager->generateTokenForPredictions({0, 0, 0}); |
Adithya Srinivasan | bed4c4f | 2021-05-03 20:24:46 +0000 | [diff] [blame] | 230 | flushTokens(); |
Huihong Luo | 3bdef86 | 2022-03-03 11:57:19 -0800 | [diff] [blame] | 231 | FrameTimelineInfo ftInfo; |
| 232 | ftInfo.vsyncId = token1; |
| 233 | ftInfo.inputEventId = sInputEventId; |
Siarhei Vishniakou | fc434ac | 2021-01-13 10:28:00 -1000 | [diff] [blame] | 234 | auto surfaceFrame = |
Huihong Luo | 3bdef86 | 2022-03-03 11:57:19 -0800 | [diff] [blame] | 235 | mFrameTimeline->createSurfaceFrameForToken(ftInfo, sPidOne, sUidOne, sLayerIdOne, |
| 236 | sLayerNameOne, sLayerNameOne, |
Adithya Srinivasan | 58069dc | 2021-06-04 20:37:02 +0000 | [diff] [blame] | 237 | /*isBuffer*/ true, sGameMode); |
Adithya Srinivasan | f279e04 | 2020-08-17 14:56:27 -0700 | [diff] [blame] | 238 | |
| 239 | EXPECT_EQ(surfaceFrame->getPredictionState(), PredictionState::Expired); |
| 240 | } |
| 241 | |
| 242 | TEST_F(FrameTimelineTest, createSurfaceFrameForToken_validToken) { |
| 243 | int64_t token1 = mTokenManager->generateTokenForPredictions({10, 20, 30}); |
Huihong Luo | 3bdef86 | 2022-03-03 11:57:19 -0800 | [diff] [blame] | 244 | FrameTimelineInfo ftInfo; |
| 245 | ftInfo.vsyncId = token1; |
| 246 | ftInfo.inputEventId = sInputEventId; |
Siarhei Vishniakou | fc434ac | 2021-01-13 10:28:00 -1000 | [diff] [blame] | 247 | auto surfaceFrame = |
Huihong Luo | 3bdef86 | 2022-03-03 11:57:19 -0800 | [diff] [blame] | 248 | mFrameTimeline->createSurfaceFrameForToken(ftInfo, sPidOne, sUidOne, sLayerIdOne, |
| 249 | sLayerNameOne, sLayerNameOne, |
Adithya Srinivasan | 58069dc | 2021-06-04 20:37:02 +0000 | [diff] [blame] | 250 | /*isBuffer*/ true, sGameMode); |
Adithya Srinivasan | f279e04 | 2020-08-17 14:56:27 -0700 | [diff] [blame] | 251 | |
| 252 | EXPECT_EQ(surfaceFrame->getPredictionState(), PredictionState::Valid); |
| 253 | EXPECT_EQ(compareTimelineItems(surfaceFrame->getPredictions(), TimelineItem(10, 20, 30)), true); |
| 254 | } |
| 255 | |
Siarhei Vishniakou | fc434ac | 2021-01-13 10:28:00 -1000 | [diff] [blame] | 256 | TEST_F(FrameTimelineTest, createSurfaceFrameForToken_validInputEventId) { |
| 257 | int64_t token1 = mTokenManager->generateTokenForPredictions({10, 20, 30}); |
| 258 | constexpr int32_t inputEventId = 1; |
Huihong Luo | 3bdef86 | 2022-03-03 11:57:19 -0800 | [diff] [blame] | 259 | FrameTimelineInfo ftInfo; |
| 260 | ftInfo.vsyncId = token1; |
| 261 | ftInfo.inputEventId = inputEventId; |
Siarhei Vishniakou | fc434ac | 2021-01-13 10:28:00 -1000 | [diff] [blame] | 262 | auto surfaceFrame = |
Huihong Luo | 3bdef86 | 2022-03-03 11:57:19 -0800 | [diff] [blame] | 263 | mFrameTimeline->createSurfaceFrameForToken(ftInfo, sPidOne, sUidOne, sLayerIdOne, |
| 264 | sLayerNameOne, sLayerNameOne, |
Adithya Srinivasan | 58069dc | 2021-06-04 20:37:02 +0000 | [diff] [blame] | 265 | /*isBuffer*/ true, sGameMode); |
Siarhei Vishniakou | fc434ac | 2021-01-13 10:28:00 -1000 | [diff] [blame] | 266 | |
| 267 | EXPECT_EQ(inputEventId, surfaceFrame->getInputEventId()); |
| 268 | } |
| 269 | |
Adithya Srinivasan | f279e04 | 2020-08-17 14:56:27 -0700 | [diff] [blame] | 270 | TEST_F(FrameTimelineTest, presentFenceSignaled_droppedFramesNotUpdated) { |
| 271 | auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
Adithya Srinivasan | f279e04 | 2020-08-17 14:56:27 -0700 | [diff] [blame] | 272 | int64_t token1 = mTokenManager->generateTokenForPredictions({10, 20, 30}); |
Huihong Luo | 3bdef86 | 2022-03-03 11:57:19 -0800 | [diff] [blame] | 273 | FrameTimelineInfo ftInfo; |
| 274 | ftInfo.vsyncId = token1; |
| 275 | ftInfo.inputEventId = sInputEventId; |
Siarhei Vishniakou | fc434ac | 2021-01-13 10:28:00 -1000 | [diff] [blame] | 276 | auto surfaceFrame1 = |
Huihong Luo | 3bdef86 | 2022-03-03 11:57:19 -0800 | [diff] [blame] | 277 | mFrameTimeline->createSurfaceFrameForToken(ftInfo, sPidOne, sUidOne, sLayerIdOne, |
| 278 | sLayerNameOne, sLayerNameOne, |
Adithya Srinivasan | 58069dc | 2021-06-04 20:37:02 +0000 | [diff] [blame] | 279 | /*isBuffer*/ true, sGameMode); |
Adithya Srinivasan | f279e04 | 2020-08-17 14:56:27 -0700 | [diff] [blame] | 280 | |
| 281 | // Set up the display frame |
Pascal Muetschard | ac7bcd9 | 2023-10-03 15:05:36 +0200 | [diff] [blame] | 282 | mFrameTimeline->setSfWakeUp(token1, 20, RR_11, RR_11); |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 283 | surfaceFrame1->setDropTime(12); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 284 | surfaceFrame1->setPresentState(SurfaceFrame::PresentState::Dropped); |
| 285 | mFrameTimeline->addSurfaceFrame(surfaceFrame1); |
Adithya Srinivasan | f279e04 | 2020-08-17 14:56:27 -0700 | [diff] [blame] | 286 | mFrameTimeline->setSfPresent(25, presentFence1); |
| 287 | presentFence1->signalForTest(30); |
| 288 | |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 289 | addEmptyDisplayFrame(); |
Adithya Srinivasan | f279e04 | 2020-08-17 14:56:27 -0700 | [diff] [blame] | 290 | |
| 291 | auto& droppedSurfaceFrame = getSurfaceFrame(0, 0); |
| 292 | EXPECT_EQ(droppedSurfaceFrame.getPresentState(), SurfaceFrame::PresentState::Dropped); |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 293 | EXPECT_EQ(0u, droppedSurfaceFrame.getActuals().endTime); |
| 294 | EXPECT_EQ(12u, droppedSurfaceFrame.getDropTime()); |
Adithya Srinivasan | f279e04 | 2020-08-17 14:56:27 -0700 | [diff] [blame] | 295 | EXPECT_EQ(droppedSurfaceFrame.getActuals().presentTime, 0); |
| 296 | } |
| 297 | |
| 298 | TEST_F(FrameTimelineTest, presentFenceSignaled_presentedFramesUpdated) { |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 299 | // Layer specific increment |
Alec Mouri | 363faf0 | 2021-01-29 16:34:55 -0800 | [diff] [blame] | 300 | EXPECT_CALL(*mTimeStats, incrementJankyFrames(_)).Times(2); |
Adithya Srinivasan | f279e04 | 2020-08-17 14:56:27 -0700 | [diff] [blame] | 301 | auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
| 302 | int64_t surfaceFrameToken1 = mTokenManager->generateTokenForPredictions({10, 20, 30}); |
Adithya Srinivasan | f279e04 | 2020-08-17 14:56:27 -0700 | [diff] [blame] | 303 | int64_t sfToken1 = mTokenManager->generateTokenForPredictions({22, 26, 30}); |
Huihong Luo | 3bdef86 | 2022-03-03 11:57:19 -0800 | [diff] [blame] | 304 | FrameTimelineInfo ftInfo; |
| 305 | ftInfo.vsyncId = surfaceFrameToken1; |
| 306 | ftInfo.inputEventId = sInputEventId; |
Alec Mouri | 9a29e67 | 2020-09-14 12:39:14 -0700 | [diff] [blame] | 307 | auto surfaceFrame1 = |
Huihong Luo | 3bdef86 | 2022-03-03 11:57:19 -0800 | [diff] [blame] | 308 | mFrameTimeline->createSurfaceFrameForToken(ftInfo, sPidOne, sUidOne, sLayerIdOne, |
| 309 | sLayerNameOne, sLayerNameOne, |
| 310 | /*isBuffer*/ true, sGameMode); |
Alec Mouri | 9a29e67 | 2020-09-14 12:39:14 -0700 | [diff] [blame] | 311 | auto surfaceFrame2 = |
Huihong Luo | 3bdef86 | 2022-03-03 11:57:19 -0800 | [diff] [blame] | 312 | mFrameTimeline->createSurfaceFrameForToken(ftInfo, sPidOne, sUidOne, sLayerIdTwo, |
| 313 | sLayerNameTwo, sLayerNameTwo, |
| 314 | /*isBuffer*/ true, sGameMode); |
Pascal Muetschard | ac7bcd9 | 2023-10-03 15:05:36 +0200 | [diff] [blame] | 315 | mFrameTimeline->setSfWakeUp(sfToken1, 22, RR_11, RR_11); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 316 | surfaceFrame1->setPresentState(SurfaceFrame::PresentState::Presented); |
| 317 | mFrameTimeline->addSurfaceFrame(surfaceFrame1); |
| 318 | surfaceFrame2->setPresentState(SurfaceFrame::PresentState::Presented); |
| 319 | mFrameTimeline->addSurfaceFrame(surfaceFrame2); |
Adithya Srinivasan | f279e04 | 2020-08-17 14:56:27 -0700 | [diff] [blame] | 320 | mFrameTimeline->setSfPresent(26, presentFence1); |
| 321 | auto displayFrame = getDisplayFrame(0); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 322 | auto& presentedSurfaceFrame1 = getSurfaceFrame(0, 0); |
| 323 | auto& presentedSurfaceFrame2 = getSurfaceFrame(0, 1); |
Adithya Srinivasan | f279e04 | 2020-08-17 14:56:27 -0700 | [diff] [blame] | 324 | presentFence1->signalForTest(42); |
| 325 | |
| 326 | // Fences haven't been flushed yet, so it should be 0 |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 327 | EXPECT_EQ(displayFrame->getActuals().presentTime, 0); |
Adithya Srinivasan | f279e04 | 2020-08-17 14:56:27 -0700 | [diff] [blame] | 328 | EXPECT_EQ(presentedSurfaceFrame1.getActuals().presentTime, 0); |
| 329 | EXPECT_EQ(presentedSurfaceFrame2.getActuals().presentTime, 0); |
| 330 | |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 331 | addEmptyDisplayFrame(); |
Adithya Srinivasan | f279e04 | 2020-08-17 14:56:27 -0700 | [diff] [blame] | 332 | |
| 333 | // Fences have flushed, so the present timestamps should be updated |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 334 | EXPECT_EQ(displayFrame->getActuals().presentTime, 42); |
Adithya Srinivasan | f279e04 | 2020-08-17 14:56:27 -0700 | [diff] [blame] | 335 | EXPECT_EQ(presentedSurfaceFrame1.getActuals().presentTime, 42); |
| 336 | EXPECT_EQ(presentedSurfaceFrame2.getActuals().presentTime, 42); |
Jorim Jaggi | 9c03b50 | 2020-11-24 23:51:31 +0100 | [diff] [blame] | 337 | EXPECT_NE(surfaceFrame1->getJankType(), std::nullopt); |
| 338 | EXPECT_NE(surfaceFrame2->getJankType(), std::nullopt); |
Adithya Srinivasan | f279e04 | 2020-08-17 14:56:27 -0700 | [diff] [blame] | 339 | } |
| 340 | |
| 341 | TEST_F(FrameTimelineTest, displayFramesSlidingWindowMovesAfterLimit) { |
| 342 | // Insert kMaxDisplayFrames' count of DisplayFrames to fill the deque |
| 343 | int frameTimeFactor = 0; |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 344 | // Layer specific increment |
Alec Mouri | 363faf0 | 2021-01-29 16:34:55 -0800 | [diff] [blame] | 345 | EXPECT_CALL(*mTimeStats, incrementJankyFrames(_)) |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 346 | .Times(static_cast<int32_t>(*maxDisplayFrames)); |
Adithya Srinivasan | 2d73632 | 2020-10-01 16:53:48 -0700 | [diff] [blame] | 347 | for (size_t i = 0; i < *maxDisplayFrames; i++) { |
Adithya Srinivasan | f279e04 | 2020-08-17 14:56:27 -0700 | [diff] [blame] | 348 | auto presentFence = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
| 349 | int64_t surfaceFrameToken = mTokenManager->generateTokenForPredictions( |
| 350 | {10 + frameTimeFactor, 20 + frameTimeFactor, 30 + frameTimeFactor}); |
| 351 | int64_t sfToken = mTokenManager->generateTokenForPredictions( |
| 352 | {22 + frameTimeFactor, 26 + frameTimeFactor, 30 + frameTimeFactor}); |
Huihong Luo | 3bdef86 | 2022-03-03 11:57:19 -0800 | [diff] [blame] | 353 | FrameTimelineInfo ftInfo; |
| 354 | ftInfo.vsyncId = surfaceFrameToken; |
| 355 | ftInfo.inputEventId = sInputEventId; |
Alec Mouri | 9a29e67 | 2020-09-14 12:39:14 -0700 | [diff] [blame] | 356 | auto surfaceFrame = |
Huihong Luo | 3bdef86 | 2022-03-03 11:57:19 -0800 | [diff] [blame] | 357 | mFrameTimeline->createSurfaceFrameForToken(ftInfo, sPidOne, sUidOne, sLayerIdOne, |
Adithya Srinivasan | 785addd | 2021-03-09 00:38:00 +0000 | [diff] [blame] | 358 | sLayerNameOne, sLayerNameOne, |
Adithya Srinivasan | 58069dc | 2021-06-04 20:37:02 +0000 | [diff] [blame] | 359 | /*isBuffer*/ true, sGameMode); |
Pascal Muetschard | ac7bcd9 | 2023-10-03 15:05:36 +0200 | [diff] [blame] | 360 | mFrameTimeline->setSfWakeUp(sfToken, 22 + frameTimeFactor, RR_11, RR_11); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 361 | surfaceFrame->setPresentState(SurfaceFrame::PresentState::Presented); |
| 362 | mFrameTimeline->addSurfaceFrame(surfaceFrame); |
Adithya Srinivasan | f279e04 | 2020-08-17 14:56:27 -0700 | [diff] [blame] | 363 | mFrameTimeline->setSfPresent(27 + frameTimeFactor, presentFence); |
| 364 | presentFence->signalForTest(32 + frameTimeFactor); |
| 365 | frameTimeFactor += 30; |
| 366 | } |
| 367 | auto displayFrame0 = getDisplayFrame(0); |
| 368 | |
| 369 | // The 0th Display Frame should have actuals 22, 27, 32 |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 370 | EXPECT_EQ(compareTimelineItems(displayFrame0->getActuals(), TimelineItem(22, 27, 32)), true); |
Adithya Srinivasan | f279e04 | 2020-08-17 14:56:27 -0700 | [diff] [blame] | 371 | |
| 372 | // Add one more display frame |
| 373 | auto presentFence = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
| 374 | int64_t surfaceFrameToken = mTokenManager->generateTokenForPredictions( |
| 375 | {10 + frameTimeFactor, 20 + frameTimeFactor, 30 + frameTimeFactor}); |
| 376 | int64_t sfToken = mTokenManager->generateTokenForPredictions( |
| 377 | {22 + frameTimeFactor, 26 + frameTimeFactor, 30 + frameTimeFactor}); |
Huihong Luo | 3bdef86 | 2022-03-03 11:57:19 -0800 | [diff] [blame] | 378 | FrameTimelineInfo ftInfo; |
| 379 | ftInfo.vsyncId = surfaceFrameToken; |
| 380 | ftInfo.inputEventId = sInputEventId; |
Alec Mouri | 9a29e67 | 2020-09-14 12:39:14 -0700 | [diff] [blame] | 381 | auto surfaceFrame = |
Huihong Luo | 3bdef86 | 2022-03-03 11:57:19 -0800 | [diff] [blame] | 382 | mFrameTimeline->createSurfaceFrameForToken(ftInfo, sPidOne, sUidOne, sLayerIdOne, |
| 383 | sLayerNameOne, sLayerNameOne, |
| 384 | /*isBuffer*/ true, sGameMode); |
Pascal Muetschard | ac7bcd9 | 2023-10-03 15:05:36 +0200 | [diff] [blame] | 385 | mFrameTimeline->setSfWakeUp(sfToken, 22 + frameTimeFactor, RR_11, RR_11); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 386 | surfaceFrame->setPresentState(SurfaceFrame::PresentState::Presented); |
| 387 | mFrameTimeline->addSurfaceFrame(surfaceFrame); |
Adithya Srinivasan | f279e04 | 2020-08-17 14:56:27 -0700 | [diff] [blame] | 388 | mFrameTimeline->setSfPresent(27 + frameTimeFactor, presentFence); |
| 389 | presentFence->signalForTest(32 + frameTimeFactor); |
| 390 | displayFrame0 = getDisplayFrame(0); |
| 391 | |
| 392 | // The window should have slided by 1 now and the previous 0th display frame |
| 393 | // should have been removed from the deque |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 394 | EXPECT_EQ(compareTimelineItems(displayFrame0->getActuals(), TimelineItem(52, 57, 62)), true); |
Adithya Srinivasan | f279e04 | 2020-08-17 14:56:27 -0700 | [diff] [blame] | 395 | } |
| 396 | |
Ady Abraham | 7f8a1e6 | 2020-09-28 16:09:35 -0700 | [diff] [blame] | 397 | TEST_F(FrameTimelineTest, surfaceFrameEndTimeAcquireFenceAfterQueue) { |
Adithya Srinivasan | 58069dc | 2021-06-04 20:37:02 +0000 | [diff] [blame] | 398 | auto surfaceFrame = mFrameTimeline->createSurfaceFrameForToken({}, sPidOne, 0, sLayerIdOne, |
| 399 | "acquireFenceAfterQueue", |
| 400 | "acquireFenceAfterQueue", |
| 401 | /*isBuffer*/ true, sGameMode); |
Ady Abraham | 7f8a1e6 | 2020-09-28 16:09:35 -0700 | [diff] [blame] | 402 | surfaceFrame->setActualQueueTime(123); |
| 403 | surfaceFrame->setAcquireFenceTime(456); |
| 404 | EXPECT_EQ(surfaceFrame->getActuals().endTime, 456); |
| 405 | } |
| 406 | |
| 407 | TEST_F(FrameTimelineTest, surfaceFrameEndTimeAcquireFenceBeforeQueue) { |
Adithya Srinivasan | 58069dc | 2021-06-04 20:37:02 +0000 | [diff] [blame] | 408 | auto surfaceFrame = mFrameTimeline->createSurfaceFrameForToken({}, sPidOne, 0, sLayerIdOne, |
| 409 | "acquireFenceAfterQueue", |
| 410 | "acquireFenceAfterQueue", |
| 411 | /*isBuffer*/ true, sGameMode); |
Ady Abraham | 7f8a1e6 | 2020-09-28 16:09:35 -0700 | [diff] [blame] | 412 | surfaceFrame->setActualQueueTime(456); |
| 413 | surfaceFrame->setAcquireFenceTime(123); |
| 414 | EXPECT_EQ(surfaceFrame->getActuals().endTime, 456); |
| 415 | } |
| 416 | |
Adithya Srinivasan | 2d73632 | 2020-10-01 16:53:48 -0700 | [diff] [blame] | 417 | TEST_F(FrameTimelineTest, setMaxDisplayFramesSetsSizeProperly) { |
| 418 | auto presentFence = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
| 419 | presentFence->signalForTest(2); |
| 420 | |
| 421 | // Size shouldn't exceed maxDisplayFrames - 64 |
| 422 | for (size_t i = 0; i < *maxDisplayFrames + 10; i++) { |
Adithya Srinivasan | 9febda8 | 2020-10-19 10:49:41 -0700 | [diff] [blame] | 423 | auto surfaceFrame = |
Alec Mouri | adebf5c | 2021-01-05 12:57:36 -0800 | [diff] [blame] | 424 | mFrameTimeline->createSurfaceFrameForToken({}, sPidOne, sUidOne, sLayerIdOne, |
Adithya Srinivasan | 785addd | 2021-03-09 00:38:00 +0000 | [diff] [blame] | 425 | sLayerNameOne, sLayerNameOne, |
Adithya Srinivasan | 58069dc | 2021-06-04 20:37:02 +0000 | [diff] [blame] | 426 | /*isBuffer*/ true, sGameMode); |
Adithya Srinivasan | 2d73632 | 2020-10-01 16:53:48 -0700 | [diff] [blame] | 427 | int64_t sfToken = mTokenManager->generateTokenForPredictions({22, 26, 30}); |
Pascal Muetschard | ac7bcd9 | 2023-10-03 15:05:36 +0200 | [diff] [blame] | 428 | mFrameTimeline->setSfWakeUp(sfToken, 22, RR_11, RR_11); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 429 | surfaceFrame->setPresentState(SurfaceFrame::PresentState::Presented); |
| 430 | mFrameTimeline->addSurfaceFrame(surfaceFrame); |
Adithya Srinivasan | 2d73632 | 2020-10-01 16:53:48 -0700 | [diff] [blame] | 431 | mFrameTimeline->setSfPresent(27, presentFence); |
| 432 | } |
| 433 | EXPECT_EQ(getNumberOfDisplayFrames(), *maxDisplayFrames); |
| 434 | |
| 435 | // Increase the size to 256 |
| 436 | mFrameTimeline->setMaxDisplayFrames(256); |
Siarhei Vishniakou | fc434ac | 2021-01-13 10:28:00 -1000 | [diff] [blame] | 437 | EXPECT_EQ(*maxDisplayFrames, 256u); |
Adithya Srinivasan | 2d73632 | 2020-10-01 16:53:48 -0700 | [diff] [blame] | 438 | |
| 439 | for (size_t i = 0; i < *maxDisplayFrames + 10; i++) { |
Adithya Srinivasan | 9febda8 | 2020-10-19 10:49:41 -0700 | [diff] [blame] | 440 | auto surfaceFrame = |
Alec Mouri | adebf5c | 2021-01-05 12:57:36 -0800 | [diff] [blame] | 441 | mFrameTimeline->createSurfaceFrameForToken({}, sPidOne, sUidOne, sLayerIdOne, |
Adithya Srinivasan | 785addd | 2021-03-09 00:38:00 +0000 | [diff] [blame] | 442 | sLayerNameOne, sLayerNameOne, |
Adithya Srinivasan | 58069dc | 2021-06-04 20:37:02 +0000 | [diff] [blame] | 443 | /*isBuffer*/ true, sGameMode); |
Adithya Srinivasan | 2d73632 | 2020-10-01 16:53:48 -0700 | [diff] [blame] | 444 | int64_t sfToken = mTokenManager->generateTokenForPredictions({22, 26, 30}); |
Pascal Muetschard | ac7bcd9 | 2023-10-03 15:05:36 +0200 | [diff] [blame] | 445 | mFrameTimeline->setSfWakeUp(sfToken, 22, RR_11, RR_11); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 446 | surfaceFrame->setPresentState(SurfaceFrame::PresentState::Presented); |
| 447 | mFrameTimeline->addSurfaceFrame(surfaceFrame); |
Adithya Srinivasan | 2d73632 | 2020-10-01 16:53:48 -0700 | [diff] [blame] | 448 | mFrameTimeline->setSfPresent(27, presentFence); |
| 449 | } |
| 450 | EXPECT_EQ(getNumberOfDisplayFrames(), *maxDisplayFrames); |
| 451 | |
| 452 | // Shrink the size to 128 |
| 453 | mFrameTimeline->setMaxDisplayFrames(128); |
Siarhei Vishniakou | fc434ac | 2021-01-13 10:28:00 -1000 | [diff] [blame] | 454 | EXPECT_EQ(*maxDisplayFrames, 128u); |
Adithya Srinivasan | 2d73632 | 2020-10-01 16:53:48 -0700 | [diff] [blame] | 455 | |
| 456 | for (size_t i = 0; i < *maxDisplayFrames + 10; i++) { |
Adithya Srinivasan | 9febda8 | 2020-10-19 10:49:41 -0700 | [diff] [blame] | 457 | auto surfaceFrame = |
Alec Mouri | adebf5c | 2021-01-05 12:57:36 -0800 | [diff] [blame] | 458 | mFrameTimeline->createSurfaceFrameForToken({}, sPidOne, sUidOne, sLayerIdOne, |
Adithya Srinivasan | 785addd | 2021-03-09 00:38:00 +0000 | [diff] [blame] | 459 | sLayerNameOne, sLayerNameOne, |
Adithya Srinivasan | 58069dc | 2021-06-04 20:37:02 +0000 | [diff] [blame] | 460 | /*isBuffer*/ true, sGameMode); |
Adithya Srinivasan | 2d73632 | 2020-10-01 16:53:48 -0700 | [diff] [blame] | 461 | int64_t sfToken = mTokenManager->generateTokenForPredictions({22, 26, 30}); |
Pascal Muetschard | ac7bcd9 | 2023-10-03 15:05:36 +0200 | [diff] [blame] | 462 | mFrameTimeline->setSfWakeUp(sfToken, 22, RR_11, RR_11); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 463 | surfaceFrame->setPresentState(SurfaceFrame::PresentState::Presented); |
| 464 | mFrameTimeline->addSurfaceFrame(surfaceFrame); |
Adithya Srinivasan | 2d73632 | 2020-10-01 16:53:48 -0700 | [diff] [blame] | 465 | mFrameTimeline->setSfPresent(27, presentFence); |
| 466 | } |
| 467 | EXPECT_EQ(getNumberOfDisplayFrames(), *maxDisplayFrames); |
| 468 | } |
Alec Mouri | 9a29e67 | 2020-09-14 12:39:14 -0700 | [diff] [blame] | 469 | |
Adithya Srinivasan | 7c4ac7a | 2021-03-08 23:48:03 +0000 | [diff] [blame] | 470 | TEST_F(FrameTimelineTest, presentFenceSignaled_invalidSignalTime) { |
Pascal Muetschard | ac7bcd9 | 2023-10-03 15:05:36 +0200 | [diff] [blame] | 471 | Fps refreshRate = RR_11; |
Adithya Srinivasan | 7c4ac7a | 2021-03-08 23:48:03 +0000 | [diff] [blame] | 472 | |
| 473 | auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
| 474 | int64_t surfaceFrameToken1 = mTokenManager->generateTokenForPredictions({10, 20, 60}); |
| 475 | int64_t sfToken1 = mTokenManager->generateTokenForPredictions({52, 60, 60}); |
Huihong Luo | 3bdef86 | 2022-03-03 11:57:19 -0800 | [diff] [blame] | 476 | FrameTimelineInfo ftInfo; |
| 477 | ftInfo.vsyncId = surfaceFrameToken1; |
| 478 | ftInfo.inputEventId = sInputEventId; |
Adithya Srinivasan | 7c4ac7a | 2021-03-08 23:48:03 +0000 | [diff] [blame] | 479 | |
| 480 | auto surfaceFrame1 = |
Huihong Luo | 3bdef86 | 2022-03-03 11:57:19 -0800 | [diff] [blame] | 481 | mFrameTimeline->createSurfaceFrameForToken(ftInfo, sPidOne, sUidOne, sLayerIdOne, |
| 482 | sLayerNameOne, sLayerNameOne, |
| 483 | /*isBuffer*/ true, sGameMode); |
Pascal Muetschard | ac7bcd9 | 2023-10-03 15:05:36 +0200 | [diff] [blame] | 484 | mFrameTimeline->setSfWakeUp(sfToken1, 52, refreshRate, refreshRate); |
Adithya Srinivasan | 7c4ac7a | 2021-03-08 23:48:03 +0000 | [diff] [blame] | 485 | surfaceFrame1->setAcquireFenceTime(20); |
| 486 | surfaceFrame1->setPresentState(SurfaceFrame::PresentState::Presented); |
| 487 | mFrameTimeline->addSurfaceFrame(surfaceFrame1); |
| 488 | |
| 489 | mFrameTimeline->setSfPresent(59, presentFence1); |
| 490 | presentFence1->signalForTest(-1); |
| 491 | addEmptyDisplayFrame(); |
| 492 | |
| 493 | auto displayFrame0 = getDisplayFrame(0); |
Ady Abraham | fcb1686 | 2022-10-10 14:35:21 -0700 | [diff] [blame] | 494 | EXPECT_EQ(displayFrame0->getActuals().presentTime, 59); |
Ady Abraham | b1e10d1 | 2023-03-13 15:23:54 -0700 | [diff] [blame] | 495 | EXPECT_EQ(displayFrame0->getJankType(), JankType::Unknown | JankType::DisplayHAL); |
Adithya Srinivasan | 7c4ac7a | 2021-03-08 23:48:03 +0000 | [diff] [blame] | 496 | EXPECT_EQ(surfaceFrame1->getActuals().presentTime, -1); |
| 497 | EXPECT_EQ(surfaceFrame1->getJankType(), JankType::Unknown); |
| 498 | } |
| 499 | |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 500 | // Tests related to TimeStats |
Adithya Srinivasan | 7c4ac7a | 2021-03-08 23:48:03 +0000 | [diff] [blame] | 501 | TEST_F(FrameTimelineTest, presentFenceSignaled_doesNotReportForInvalidTokens) { |
Pascal Muetschard | ac7bcd9 | 2023-10-03 15:05:36 +0200 | [diff] [blame] | 502 | Fps refreshRate = RR_11; |
Adithya Srinivasan | 7c4ac7a | 2021-03-08 23:48:03 +0000 | [diff] [blame] | 503 | EXPECT_CALL(*mTimeStats, incrementJankyFrames(_)).Times(0); |
| 504 | auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
| 505 | int64_t surfaceFrameToken1 = -1; |
| 506 | int64_t sfToken1 = -1; |
Huihong Luo | 3bdef86 | 2022-03-03 11:57:19 -0800 | [diff] [blame] | 507 | FrameTimelineInfo ftInfo; |
| 508 | ftInfo.vsyncId = surfaceFrameToken1; |
| 509 | ftInfo.inputEventId = sInputEventId; |
Adithya Srinivasan | 7c4ac7a | 2021-03-08 23:48:03 +0000 | [diff] [blame] | 510 | |
| 511 | auto surfaceFrame1 = |
Huihong Luo | 3bdef86 | 2022-03-03 11:57:19 -0800 | [diff] [blame] | 512 | mFrameTimeline->createSurfaceFrameForToken(ftInfo, sPidOne, sUidOne, sLayerIdOne, |
| 513 | sLayerNameOne, sLayerNameOne, |
| 514 | /*isBuffer*/ true, sGameMode); |
Pascal Muetschard | ac7bcd9 | 2023-10-03 15:05:36 +0200 | [diff] [blame] | 515 | mFrameTimeline->setSfWakeUp(sfToken1, 52, refreshRate, refreshRate); |
Adithya Srinivasan | 7c4ac7a | 2021-03-08 23:48:03 +0000 | [diff] [blame] | 516 | surfaceFrame1->setAcquireFenceTime(20); |
| 517 | surfaceFrame1->setPresentState(SurfaceFrame::PresentState::Presented); |
| 518 | mFrameTimeline->addSurfaceFrame(surfaceFrame1); |
| 519 | presentFence1->signalForTest(70); |
| 520 | |
| 521 | mFrameTimeline->setSfPresent(59, presentFence1); |
| 522 | } |
| 523 | |
Alec Mouri | 9a29e67 | 2020-09-14 12:39:14 -0700 | [diff] [blame] | 524 | TEST_F(FrameTimelineTest, presentFenceSignaled_reportsLongSfCpu) { |
Pascal Muetschard | ac7bcd9 | 2023-10-03 15:05:36 +0200 | [diff] [blame] | 525 | Fps refreshRate = RR_11; |
Alec Mouri | 9a29e67 | 2020-09-14 12:39:14 -0700 | [diff] [blame] | 526 | EXPECT_CALL(*mTimeStats, |
Alec Mouri | 363faf0 | 2021-01-29 16:34:55 -0800 | [diff] [blame] | 527 | incrementJankyFrames( |
| 528 | TimeStats::JankyFramesInfo{refreshRate, std::nullopt, sUidOne, |
Adithya Srinivasan | 58069dc | 2021-06-04 20:37:02 +0000 | [diff] [blame] | 529 | sLayerNameOne, sGameMode, |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 530 | JankType::SurfaceFlingerCpuDeadlineMissed, 2, 10, |
Alec Mouri | 363faf0 | 2021-01-29 16:34:55 -0800 | [diff] [blame] | 531 | 0})); |
Alec Mouri | 9a29e67 | 2020-09-14 12:39:14 -0700 | [diff] [blame] | 532 | auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 533 | int64_t surfaceFrameToken1 = mTokenManager->generateTokenForPredictions({10, 20, 60}); |
| 534 | int64_t sfToken1 = mTokenManager->generateTokenForPredictions({52, 60, 60}); |
Huihong Luo | 3bdef86 | 2022-03-03 11:57:19 -0800 | [diff] [blame] | 535 | FrameTimelineInfo ftInfo; |
| 536 | ftInfo.vsyncId = surfaceFrameToken1; |
| 537 | ftInfo.inputEventId = sInputEventId; |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 538 | |
Alec Mouri | 9a29e67 | 2020-09-14 12:39:14 -0700 | [diff] [blame] | 539 | auto surfaceFrame1 = |
Huihong Luo | 3bdef86 | 2022-03-03 11:57:19 -0800 | [diff] [blame] | 540 | mFrameTimeline->createSurfaceFrameForToken(ftInfo, sPidOne, sUidOne, sLayerIdOne, |
| 541 | sLayerNameOne, sLayerNameOne, |
| 542 | /*isBuffer*/ true, sGameMode); |
Pascal Muetschard | ac7bcd9 | 2023-10-03 15:05:36 +0200 | [diff] [blame] | 543 | mFrameTimeline->setSfWakeUp(sfToken1, 52, refreshRate, refreshRate); |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 544 | surfaceFrame1->setAcquireFenceTime(20); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 545 | surfaceFrame1->setPresentState(SurfaceFrame::PresentState::Presented); |
| 546 | mFrameTimeline->addSurfaceFrame(surfaceFrame1); |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 547 | presentFence1->signalForTest(70); |
Alec Mouri | 9a29e67 | 2020-09-14 12:39:14 -0700 | [diff] [blame] | 548 | |
Adithya Srinivasan | 82eef32 | 2021-04-10 00:06:04 +0000 | [diff] [blame] | 549 | mFrameTimeline->setSfPresent(62, presentFence1); |
Alec Mouri | 9a29e67 | 2020-09-14 12:39:14 -0700 | [diff] [blame] | 550 | } |
| 551 | |
Adithya Srinivasan | 36b01af | 2021-04-07 22:29:47 +0000 | [diff] [blame] | 552 | TEST_F(FrameTimelineTest, presentFenceSignaled_reportsLongSfGpu) { |
Pascal Muetschard | ac7bcd9 | 2023-10-03 15:05:36 +0200 | [diff] [blame] | 553 | Fps refreshRate = RR_11; |
Adithya Srinivasan | 36b01af | 2021-04-07 22:29:47 +0000 | [diff] [blame] | 554 | EXPECT_CALL(*mTimeStats, |
| 555 | incrementJankyFrames( |
| 556 | TimeStats::JankyFramesInfo{refreshRate, std::nullopt, sUidOne, |
Adithya Srinivasan | 58069dc | 2021-06-04 20:37:02 +0000 | [diff] [blame] | 557 | sLayerNameOne, sGameMode, |
Adithya Srinivasan | 36b01af | 2021-04-07 22:29:47 +0000 | [diff] [blame] | 558 | JankType::SurfaceFlingerGpuDeadlineMissed, 4, 10, |
| 559 | 0})); |
| 560 | auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
| 561 | auto gpuFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
| 562 | int64_t surfaceFrameToken1 = mTokenManager->generateTokenForPredictions({10, 20, 60}); |
| 563 | int64_t sfToken1 = mTokenManager->generateTokenForPredictions({52, 60, 60}); |
Huihong Luo | 3bdef86 | 2022-03-03 11:57:19 -0800 | [diff] [blame] | 564 | FrameTimelineInfo ftInfo; |
| 565 | ftInfo.vsyncId = surfaceFrameToken1; |
| 566 | ftInfo.inputEventId = sInputEventId; |
Adithya Srinivasan | 36b01af | 2021-04-07 22:29:47 +0000 | [diff] [blame] | 567 | |
| 568 | auto surfaceFrame1 = |
Huihong Luo | 3bdef86 | 2022-03-03 11:57:19 -0800 | [diff] [blame] | 569 | mFrameTimeline->createSurfaceFrameForToken(ftInfo, sPidOne, sUidOne, sLayerIdOne, |
| 570 | sLayerNameOne, sLayerNameOne, |
| 571 | /*isBuffer*/ true, sGameMode); |
Pascal Muetschard | ac7bcd9 | 2023-10-03 15:05:36 +0200 | [diff] [blame] | 572 | mFrameTimeline->setSfWakeUp(sfToken1, 52, refreshRate, refreshRate); |
Adithya Srinivasan | 36b01af | 2021-04-07 22:29:47 +0000 | [diff] [blame] | 573 | surfaceFrame1->setAcquireFenceTime(20); |
| 574 | surfaceFrame1->setPresentState(SurfaceFrame::PresentState::Presented); |
| 575 | mFrameTimeline->addSurfaceFrame(surfaceFrame1); |
| 576 | gpuFence1->signalForTest(64); |
| 577 | presentFence1->signalForTest(70); |
| 578 | |
| 579 | mFrameTimeline->setSfPresent(59, presentFence1, gpuFence1); |
| 580 | } |
| 581 | |
Alec Mouri | 9a29e67 | 2020-09-14 12:39:14 -0700 | [diff] [blame] | 582 | TEST_F(FrameTimelineTest, presentFenceSignaled_reportsDisplayMiss) { |
Pascal Muetschard | ac7bcd9 | 2023-10-03 15:05:36 +0200 | [diff] [blame] | 583 | Fps refreshRate = RR_30; |
Alec Mouri | 9a29e67 | 2020-09-14 12:39:14 -0700 | [diff] [blame] | 584 | EXPECT_CALL(*mTimeStats, |
Alec Mouri | 363faf0 | 2021-01-29 16:34:55 -0800 | [diff] [blame] | 585 | incrementJankyFrames(TimeStats::JankyFramesInfo{refreshRate, std::nullopt, sUidOne, |
Adithya Srinivasan | 58069dc | 2021-06-04 20:37:02 +0000 | [diff] [blame] | 586 | sLayerNameOne, sGameMode, |
| 587 | JankType::DisplayHAL, -4, 0, 0})); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 588 | |
Alec Mouri | 9a29e67 | 2020-09-14 12:39:14 -0700 | [diff] [blame] | 589 | auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 590 | int64_t surfaceFrameToken1 = mTokenManager->generateTokenForPredictions({10, 20, 60}); |
| 591 | int64_t sfToken1 = mTokenManager->generateTokenForPredictions({52, 60, 60}); |
Huihong Luo | 3bdef86 | 2022-03-03 11:57:19 -0800 | [diff] [blame] | 592 | FrameTimelineInfo ftInfo; |
| 593 | ftInfo.vsyncId = surfaceFrameToken1; |
| 594 | ftInfo.inputEventId = sInputEventId; |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 595 | |
Alec Mouri | 9a29e67 | 2020-09-14 12:39:14 -0700 | [diff] [blame] | 596 | auto surfaceFrame1 = |
Huihong Luo | 3bdef86 | 2022-03-03 11:57:19 -0800 | [diff] [blame] | 597 | mFrameTimeline->createSurfaceFrameForToken(ftInfo, sPidOne, sUidOne, sLayerIdOne, |
| 598 | sLayerNameOne, sLayerNameOne, |
| 599 | /*isBuffer*/ true, sGameMode); |
Pascal Muetschard | ac7bcd9 | 2023-10-03 15:05:36 +0200 | [diff] [blame] | 600 | mFrameTimeline->setSfWakeUp(sfToken1, 52, refreshRate, refreshRate); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 601 | surfaceFrame1->setPresentState(SurfaceFrame::PresentState::Presented); |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 602 | surfaceFrame1->setAcquireFenceTime(20); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 603 | mFrameTimeline->addSurfaceFrame(surfaceFrame1); |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 604 | presentFence1->signalForTest(90); |
| 605 | mFrameTimeline->setSfPresent(56, presentFence1); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 606 | EXPECT_EQ(surfaceFrame1->getJankType(), JankType::DisplayHAL); |
Alec Mouri | 9a29e67 | 2020-09-14 12:39:14 -0700 | [diff] [blame] | 607 | } |
| 608 | |
| 609 | TEST_F(FrameTimelineTest, presentFenceSignaled_reportsAppMiss) { |
Dominik Laskowski | 6eab42d | 2021-09-13 14:34:13 -0700 | [diff] [blame] | 610 | Fps refreshRate = 11_Hz; |
Alec Mouri | 9a29e67 | 2020-09-14 12:39:14 -0700 | [diff] [blame] | 611 | EXPECT_CALL(*mTimeStats, |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 612 | incrementJankyFrames(TimeStats::JankyFramesInfo{refreshRate, std::nullopt, sUidOne, |
Adithya Srinivasan | 58069dc | 2021-06-04 20:37:02 +0000 | [diff] [blame] | 613 | sLayerNameOne, sGameMode, |
Adithya Srinivasan | 82eef32 | 2021-04-10 00:06:04 +0000 | [diff] [blame] | 614 | JankType::AppDeadlineMissed, -4, 0, |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 615 | 25})); |
Alec Mouri | 9a29e67 | 2020-09-14 12:39:14 -0700 | [diff] [blame] | 616 | auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 617 | int64_t surfaceFrameToken1 = mTokenManager->generateTokenForPredictions({10, 20, 60}); |
| 618 | int64_t sfToken1 = mTokenManager->generateTokenForPredictions({82, 90, 90}); |
Huihong Luo | 3bdef86 | 2022-03-03 11:57:19 -0800 | [diff] [blame] | 619 | FrameTimelineInfo ftInfo; |
| 620 | ftInfo.vsyncId = surfaceFrameToken1; |
| 621 | ftInfo.inputEventId = sInputEventId; |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 622 | |
Alec Mouri | 9a29e67 | 2020-09-14 12:39:14 -0700 | [diff] [blame] | 623 | auto surfaceFrame1 = |
Huihong Luo | 3bdef86 | 2022-03-03 11:57:19 -0800 | [diff] [blame] | 624 | mFrameTimeline->createSurfaceFrameForToken(ftInfo, sPidOne, sUidOne, sLayerIdOne, |
| 625 | sLayerNameOne, sLayerNameOne, |
| 626 | /*isBuffer*/ true, sGameMode); |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 627 | surfaceFrame1->setAcquireFenceTime(45); |
Pascal Muetschard | ac7bcd9 | 2023-10-03 15:05:36 +0200 | [diff] [blame] | 628 | mFrameTimeline->setSfWakeUp(sfToken1, 52, refreshRate, refreshRate); |
Alec Mouri | 9a29e67 | 2020-09-14 12:39:14 -0700 | [diff] [blame] | 629 | |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 630 | surfaceFrame1->setPresentState(SurfaceFrame::PresentState::Presented); |
| 631 | mFrameTimeline->addSurfaceFrame(surfaceFrame1); |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 632 | presentFence1->signalForTest(90); |
| 633 | mFrameTimeline->setSfPresent(86, presentFence1); |
Jorim Jaggi | 9c03b50 | 2020-11-24 23:51:31 +0100 | [diff] [blame] | 634 | |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 635 | EXPECT_EQ(surfaceFrame1->getJankType(), JankType::AppDeadlineMissed); |
Alec Mouri | 9a29e67 | 2020-09-14 12:39:14 -0700 | [diff] [blame] | 636 | } |
| 637 | |
Adithya Srinivasan | ead1716 | 2021-02-18 02:17:37 +0000 | [diff] [blame] | 638 | TEST_F(FrameTimelineTest, presentFenceSignaled_reportsSfScheduling) { |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 639 | Fps refreshRate = Fps::fromPeriodNsecs(32); |
Adithya Srinivasan | ead1716 | 2021-02-18 02:17:37 +0000 | [diff] [blame] | 640 | EXPECT_CALL(*mTimeStats, |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 641 | incrementJankyFrames(TimeStats::JankyFramesInfo{refreshRate, std::nullopt, sUidOne, |
Adithya Srinivasan | 58069dc | 2021-06-04 20:37:02 +0000 | [diff] [blame] | 642 | sLayerNameOne, sGameMode, |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 643 | JankType::SurfaceFlingerScheduling, |
Adithya Srinivasan | 82eef32 | 2021-04-10 00:06:04 +0000 | [diff] [blame] | 644 | -4, 0, -10})); |
Adithya Srinivasan | ead1716 | 2021-02-18 02:17:37 +0000 | [diff] [blame] | 645 | auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 646 | int64_t surfaceFrameToken1 = mTokenManager->generateTokenForPredictions({40, 60, 92}); |
| 647 | int64_t sfToken1 = mTokenManager->generateTokenForPredictions({52, 60, 60}); |
Huihong Luo | 3bdef86 | 2022-03-03 11:57:19 -0800 | [diff] [blame] | 648 | FrameTimelineInfo ftInfo; |
| 649 | ftInfo.vsyncId = surfaceFrameToken1; |
| 650 | ftInfo.inputEventId = sInputEventId; |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 651 | |
Adithya Srinivasan | ead1716 | 2021-02-18 02:17:37 +0000 | [diff] [blame] | 652 | auto surfaceFrame1 = |
Huihong Luo | 3bdef86 | 2022-03-03 11:57:19 -0800 | [diff] [blame] | 653 | mFrameTimeline->createSurfaceFrameForToken(ftInfo, sPidOne, sUidOne, sLayerIdOne, |
| 654 | sLayerNameOne, sLayerNameOne, |
| 655 | /*isBuffer*/ true, sGameMode); |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 656 | surfaceFrame1->setAcquireFenceTime(50); |
Pascal Muetschard | ac7bcd9 | 2023-10-03 15:05:36 +0200 | [diff] [blame] | 657 | mFrameTimeline->setSfWakeUp(sfToken1, 52, refreshRate, refreshRate); |
Adithya Srinivasan | ead1716 | 2021-02-18 02:17:37 +0000 | [diff] [blame] | 658 | |
| 659 | surfaceFrame1->setPresentState(SurfaceFrame::PresentState::Presented); |
| 660 | mFrameTimeline->addSurfaceFrame(surfaceFrame1); |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 661 | presentFence1->signalForTest(60); |
| 662 | mFrameTimeline->setSfPresent(56, presentFence1); |
Adithya Srinivasan | ead1716 | 2021-02-18 02:17:37 +0000 | [diff] [blame] | 663 | |
| 664 | EXPECT_EQ(surfaceFrame1->getJankType(), JankType::SurfaceFlingerScheduling); |
| 665 | } |
| 666 | |
| 667 | TEST_F(FrameTimelineTest, presentFenceSignaled_reportsSfPredictionError) { |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 668 | Fps refreshRate = Fps::fromPeriodNsecs(16); |
Adithya Srinivasan | ead1716 | 2021-02-18 02:17:37 +0000 | [diff] [blame] | 669 | EXPECT_CALL(*mTimeStats, |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 670 | incrementJankyFrames(TimeStats::JankyFramesInfo{refreshRate, std::nullopt, sUidOne, |
Adithya Srinivasan | 58069dc | 2021-06-04 20:37:02 +0000 | [diff] [blame] | 671 | sLayerNameOne, sGameMode, |
Adithya Srinivasan | 82eef32 | 2021-04-10 00:06:04 +0000 | [diff] [blame] | 672 | JankType::PredictionError, -4, 5, |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 673 | 0})); |
Adithya Srinivasan | ead1716 | 2021-02-18 02:17:37 +0000 | [diff] [blame] | 674 | auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 675 | int64_t surfaceFrameToken1 = mTokenManager->generateTokenForPredictions({30, 40, 60}); |
| 676 | int64_t sfToken1 = mTokenManager->generateTokenForPredictions({52, 60, 60}); |
Huihong Luo | 3bdef86 | 2022-03-03 11:57:19 -0800 | [diff] [blame] | 677 | FrameTimelineInfo ftInfo; |
| 678 | ftInfo.vsyncId = surfaceFrameToken1; |
| 679 | ftInfo.inputEventId = sInputEventId; |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 680 | |
Adithya Srinivasan | ead1716 | 2021-02-18 02:17:37 +0000 | [diff] [blame] | 681 | auto surfaceFrame1 = |
Huihong Luo | 3bdef86 | 2022-03-03 11:57:19 -0800 | [diff] [blame] | 682 | mFrameTimeline->createSurfaceFrameForToken(ftInfo, sPidOne, sUidOne, sLayerIdOne, |
| 683 | sLayerNameOne, sLayerNameOne, |
| 684 | /*isBuffer*/ true, sGameMode); |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 685 | surfaceFrame1->setAcquireFenceTime(40); |
Pascal Muetschard | ac7bcd9 | 2023-10-03 15:05:36 +0200 | [diff] [blame] | 686 | mFrameTimeline->setSfWakeUp(sfToken1, 52, refreshRate, refreshRate); |
Adithya Srinivasan | ead1716 | 2021-02-18 02:17:37 +0000 | [diff] [blame] | 687 | |
| 688 | surfaceFrame1->setPresentState(SurfaceFrame::PresentState::Presented); |
| 689 | mFrameTimeline->addSurfaceFrame(surfaceFrame1); |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 690 | presentFence1->signalForTest(65); |
| 691 | mFrameTimeline->setSfPresent(56, presentFence1); |
Adithya Srinivasan | ead1716 | 2021-02-18 02:17:37 +0000 | [diff] [blame] | 692 | |
| 693 | EXPECT_EQ(surfaceFrame1->getJankType(), JankType::PredictionError); |
| 694 | } |
| 695 | |
| 696 | TEST_F(FrameTimelineTest, presentFenceSignaled_reportsAppBufferStuffing) { |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 697 | Fps refreshRate = Fps::fromPeriodNsecs(32); |
Adithya Srinivasan | ead1716 | 2021-02-18 02:17:37 +0000 | [diff] [blame] | 698 | EXPECT_CALL(*mTimeStats, |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 699 | incrementJankyFrames(TimeStats::JankyFramesInfo{refreshRate, std::nullopt, sUidOne, |
Adithya Srinivasan | 58069dc | 2021-06-04 20:37:02 +0000 | [diff] [blame] | 700 | sLayerNameOne, sGameMode, |
Adithya Srinivasan | 82eef32 | 2021-04-10 00:06:04 +0000 | [diff] [blame] | 701 | JankType::BufferStuffing, -4, 0, |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 702 | 0})); |
Adithya Srinivasan | ead1716 | 2021-02-18 02:17:37 +0000 | [diff] [blame] | 703 | auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 704 | int64_t surfaceFrameToken1 = mTokenManager->generateTokenForPredictions({30, 40, 58}); |
| 705 | int64_t sfToken1 = mTokenManager->generateTokenForPredictions({82, 90, 90}); |
Huihong Luo | 3bdef86 | 2022-03-03 11:57:19 -0800 | [diff] [blame] | 706 | FrameTimelineInfo ftInfo; |
| 707 | ftInfo.vsyncId = surfaceFrameToken1; |
| 708 | ftInfo.inputEventId = sInputEventId; |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 709 | |
Adithya Srinivasan | ead1716 | 2021-02-18 02:17:37 +0000 | [diff] [blame] | 710 | auto surfaceFrame1 = |
Huihong Luo | 3bdef86 | 2022-03-03 11:57:19 -0800 | [diff] [blame] | 711 | mFrameTimeline->createSurfaceFrameForToken(ftInfo, sPidOne, sUidOne, sLayerIdOne, |
| 712 | sLayerNameOne, sLayerNameOne, |
| 713 | /*isBuffer*/ true, sGameMode); |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 714 | surfaceFrame1->setAcquireFenceTime(40); |
Pascal Muetschard | ac7bcd9 | 2023-10-03 15:05:36 +0200 | [diff] [blame] | 715 | mFrameTimeline->setSfWakeUp(sfToken1, 82, refreshRate, refreshRate); |
Adithya Srinivasan | ead1716 | 2021-02-18 02:17:37 +0000 | [diff] [blame] | 716 | |
| 717 | surfaceFrame1->setPresentState(SurfaceFrame::PresentState::Presented, |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 718 | /*previousLatchTime*/ 56); |
Adithya Srinivasan | ead1716 | 2021-02-18 02:17:37 +0000 | [diff] [blame] | 719 | mFrameTimeline->addSurfaceFrame(surfaceFrame1); |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 720 | presentFence1->signalForTest(90); |
| 721 | mFrameTimeline->setSfPresent(86, presentFence1); |
Adithya Srinivasan | ead1716 | 2021-02-18 02:17:37 +0000 | [diff] [blame] | 722 | |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 723 | EXPECT_EQ(surfaceFrame1->getJankType(), JankType::BufferStuffing); |
Adithya Srinivasan | ead1716 | 2021-02-18 02:17:37 +0000 | [diff] [blame] | 724 | } |
| 725 | |
Alec Mouri | 363faf0 | 2021-01-29 16:34:55 -0800 | [diff] [blame] | 726 | TEST_F(FrameTimelineTest, presentFenceSignaled_reportsAppMissWithRenderRate) { |
Pascal Muetschard | ac7bcd9 | 2023-10-03 15:05:36 +0200 | [diff] [blame] | 727 | Fps refreshRate = RR_11; |
| 728 | Fps renderRate = RR_30; |
Alec Mouri | 363faf0 | 2021-01-29 16:34:55 -0800 | [diff] [blame] | 729 | EXPECT_CALL(*mTimeStats, |
Adithya Srinivasan | 58069dc | 2021-06-04 20:37:02 +0000 | [diff] [blame] | 730 | incrementJankyFrames(TimeStats::JankyFramesInfo{refreshRate, renderRate, sUidOne, |
| 731 | sLayerNameOne, sGameMode, |
| 732 | JankType::AppDeadlineMissed, -4, 0, |
| 733 | 25})); |
Alec Mouri | 363faf0 | 2021-01-29 16:34:55 -0800 | [diff] [blame] | 734 | auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 735 | int64_t surfaceFrameToken1 = mTokenManager->generateTokenForPredictions({10, 20, 60}); |
| 736 | int64_t sfToken1 = mTokenManager->generateTokenForPredictions({82, 90, 90}); |
Huihong Luo | 3bdef86 | 2022-03-03 11:57:19 -0800 | [diff] [blame] | 737 | FrameTimelineInfo ftInfo; |
| 738 | ftInfo.vsyncId = surfaceFrameToken1; |
| 739 | ftInfo.inputEventId = sInputEventId; |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 740 | |
Alec Mouri | 363faf0 | 2021-01-29 16:34:55 -0800 | [diff] [blame] | 741 | auto surfaceFrame1 = |
Huihong Luo | 3bdef86 | 2022-03-03 11:57:19 -0800 | [diff] [blame] | 742 | mFrameTimeline->createSurfaceFrameForToken(ftInfo, sPidOne, sUidOne, sLayerIdOne, |
| 743 | sLayerNameOne, sLayerNameOne, |
| 744 | /*isBuffer*/ true, sGameMode); |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 745 | surfaceFrame1->setAcquireFenceTime(45); |
Pascal Muetschard | ac7bcd9 | 2023-10-03 15:05:36 +0200 | [diff] [blame] | 746 | mFrameTimeline->setSfWakeUp(sfToken1, 52, refreshRate, refreshRate); |
Alec Mouri | 363faf0 | 2021-01-29 16:34:55 -0800 | [diff] [blame] | 747 | |
| 748 | surfaceFrame1->setPresentState(SurfaceFrame::PresentState::Presented); |
| 749 | surfaceFrame1->setRenderRate(renderRate); |
| 750 | mFrameTimeline->addSurfaceFrame(surfaceFrame1); |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 751 | presentFence1->signalForTest(90); |
| 752 | mFrameTimeline->setSfPresent(86, presentFence1); |
Alec Mouri | 363faf0 | 2021-01-29 16:34:55 -0800 | [diff] [blame] | 753 | |
| 754 | EXPECT_EQ(surfaceFrame1->getJankType(), JankType::AppDeadlineMissed); |
| 755 | } |
| 756 | |
Adithya Srinivasan | 115ac69 | 2021-03-06 01:21:30 +0000 | [diff] [blame] | 757 | TEST_F(FrameTimelineTest, presentFenceSignaled_displayFramePredictionExpiredPresentsSurfaceFrame) { |
Pascal Muetschard | ac7bcd9 | 2023-10-03 15:05:36 +0200 | [diff] [blame] | 758 | Fps refreshRate = RR_11; |
| 759 | Fps renderRate = RR_30; |
Adithya Srinivasan | 115ac69 | 2021-03-06 01:21:30 +0000 | [diff] [blame] | 760 | |
| 761 | EXPECT_CALL(*mTimeStats, |
Adithya Srinivasan | 8a94550 | 2021-03-19 19:12:32 +0000 | [diff] [blame] | 762 | incrementJankyFrames( |
| 763 | TimeStats::JankyFramesInfo{refreshRate, renderRate, sUidOne, sLayerNameOne, |
Adithya Srinivasan | 58069dc | 2021-06-04 20:37:02 +0000 | [diff] [blame] | 764 | sGameMode, |
Adithya Srinivasan | 8a94550 | 2021-03-19 19:12:32 +0000 | [diff] [blame] | 765 | JankType::Unknown | JankType::AppDeadlineMissed, |
Adithya Srinivasan | de27245 | 2021-04-10 00:21:00 +0000 | [diff] [blame] | 766 | 0, 0, 25})); |
Adithya Srinivasan | 115ac69 | 2021-03-06 01:21:30 +0000 | [diff] [blame] | 767 | auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
| 768 | int64_t surfaceFrameToken1 = mTokenManager->generateTokenForPredictions({10, 20, 60}); |
| 769 | int64_t sfToken1 = mTokenManager->generateTokenForPredictions({82, 90, 90}); |
Huihong Luo | 3bdef86 | 2022-03-03 11:57:19 -0800 | [diff] [blame] | 770 | FrameTimelineInfo ftInfo; |
| 771 | ftInfo.vsyncId = surfaceFrameToken1; |
| 772 | ftInfo.inputEventId = sInputEventId; |
Adithya Srinivasan | 115ac69 | 2021-03-06 01:21:30 +0000 | [diff] [blame] | 773 | |
| 774 | auto surfaceFrame1 = |
Huihong Luo | 3bdef86 | 2022-03-03 11:57:19 -0800 | [diff] [blame] | 775 | mFrameTimeline->createSurfaceFrameForToken(ftInfo, sPidOne, sUidOne, sLayerIdOne, |
| 776 | sLayerNameOne, sLayerNameOne, |
| 777 | /*isBuffer*/ true, sGameMode); |
Adithya Srinivasan | 115ac69 | 2021-03-06 01:21:30 +0000 | [diff] [blame] | 778 | surfaceFrame1->setAcquireFenceTime(45); |
| 779 | // Trigger a prediction expiry |
Adithya Srinivasan | bed4c4f | 2021-05-03 20:24:46 +0000 | [diff] [blame] | 780 | flushTokens(); |
Pascal Muetschard | ac7bcd9 | 2023-10-03 15:05:36 +0200 | [diff] [blame] | 781 | mFrameTimeline->setSfWakeUp(sfToken1, 52, refreshRate, refreshRate); |
Adithya Srinivasan | 115ac69 | 2021-03-06 01:21:30 +0000 | [diff] [blame] | 782 | |
| 783 | surfaceFrame1->setPresentState(SurfaceFrame::PresentState::Presented); |
| 784 | surfaceFrame1->setRenderRate(renderRate); |
| 785 | mFrameTimeline->addSurfaceFrame(surfaceFrame1); |
| 786 | presentFence1->signalForTest(90); |
| 787 | mFrameTimeline->setSfPresent(86, presentFence1); |
| 788 | |
| 789 | auto displayFrame = getDisplayFrame(0); |
| 790 | EXPECT_EQ(displayFrame->getJankType(), JankType::Unknown); |
| 791 | EXPECT_EQ(displayFrame->getFrameStartMetadata(), FrameStartMetadata::UnknownStart); |
| 792 | EXPECT_EQ(displayFrame->getFrameReadyMetadata(), FrameReadyMetadata::UnknownFinish); |
| 793 | EXPECT_EQ(displayFrame->getFramePresentMetadata(), FramePresentMetadata::UnknownPresent); |
| 794 | |
| 795 | EXPECT_EQ(surfaceFrame1->getActuals().presentTime, 90); |
Adithya Srinivasan | 8a94550 | 2021-03-19 19:12:32 +0000 | [diff] [blame] | 796 | EXPECT_EQ(surfaceFrame1->getJankType(), JankType::Unknown | JankType::AppDeadlineMissed); |
Adithya Srinivasan | 115ac69 | 2021-03-06 01:21:30 +0000 | [diff] [blame] | 797 | } |
| 798 | |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 799 | /* |
| 800 | * Tracing Tests |
| 801 | * |
| 802 | * Trace packets are flushed all the way only when the next packet is traced. |
| 803 | * For example: trace<Display/Surface>Frame() will create a TracePacket but not flush it. Only when |
| 804 | * another TracePacket is created, the previous one is guaranteed to be flushed. The following tests |
| 805 | * will have additional empty frames created for this reason. |
| 806 | */ |
| 807 | TEST_F(FrameTimelineTest, tracing_noPacketsSentWithoutTraceStart) { |
| 808 | auto tracingSession = getTracingSessionForTest(); |
| 809 | auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 810 | int64_t token1 = mTokenManager->generateTokenForPredictions({10, 20, 30}); |
Huihong Luo | 3bdef86 | 2022-03-03 11:57:19 -0800 | [diff] [blame] | 811 | FrameTimelineInfo ftInfo; |
| 812 | ftInfo.vsyncId = token1; |
| 813 | ftInfo.inputEventId = sInputEventId; |
Siarhei Vishniakou | fc434ac | 2021-01-13 10:28:00 -1000 | [diff] [blame] | 814 | auto surfaceFrame1 = |
Huihong Luo | 3bdef86 | 2022-03-03 11:57:19 -0800 | [diff] [blame] | 815 | mFrameTimeline->createSurfaceFrameForToken(ftInfo, sPidOne, sUidOne, sLayerIdOne, |
| 816 | sLayerNameOne, sLayerNameOne, |
Adithya Srinivasan | 58069dc | 2021-06-04 20:37:02 +0000 | [diff] [blame] | 817 | /*isBuffer*/ true, sGameMode); |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 818 | |
| 819 | // Set up the display frame |
Pascal Muetschard | ac7bcd9 | 2023-10-03 15:05:36 +0200 | [diff] [blame] | 820 | mFrameTimeline->setSfWakeUp(token1, 20, RR_11, RR_11); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 821 | surfaceFrame1->setPresentState(SurfaceFrame::PresentState::Dropped); |
| 822 | mFrameTimeline->addSurfaceFrame(surfaceFrame1); |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 823 | mFrameTimeline->setSfPresent(25, presentFence1); |
| 824 | presentFence1->signalForTest(30); |
| 825 | |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 826 | addEmptyDisplayFrame(); |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 827 | |
| 828 | auto packets = readFrameTimelinePacketsBlocking(tracingSession.get()); |
Siarhei Vishniakou | fc434ac | 2021-01-13 10:28:00 -1000 | [diff] [blame] | 829 | EXPECT_EQ(packets.size(), 0u); |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 830 | } |
| 831 | |
| 832 | TEST_F(FrameTimelineTest, tracing_sanityTest) { |
| 833 | auto tracingSession = getTracingSessionForTest(); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 834 | // Layer specific increment |
Alec Mouri | 363faf0 | 2021-01-29 16:34:55 -0800 | [diff] [blame] | 835 | EXPECT_CALL(*mTimeStats, incrementJankyFrames(_)); |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 836 | auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 837 | |
| 838 | tracingSession->StartBlocking(); |
| 839 | int64_t token1 = mTokenManager->generateTokenForPredictions({10, 20, 30}); |
| 840 | int64_t token2 = mTokenManager->generateTokenForPredictions({40, 50, 60}); |
Huihong Luo | 3bdef86 | 2022-03-03 11:57:19 -0800 | [diff] [blame] | 841 | FrameTimelineInfo ftInfo; |
| 842 | ftInfo.vsyncId = token1; |
| 843 | ftInfo.inputEventId = sInputEventId; |
Siarhei Vishniakou | fc434ac | 2021-01-13 10:28:00 -1000 | [diff] [blame] | 844 | auto surfaceFrame1 = |
Huihong Luo | 3bdef86 | 2022-03-03 11:57:19 -0800 | [diff] [blame] | 845 | mFrameTimeline->createSurfaceFrameForToken(ftInfo, sPidOne, sUidOne, sLayerIdOne, |
| 846 | sLayerNameOne, sLayerNameOne, |
Adithya Srinivasan | 58069dc | 2021-06-04 20:37:02 +0000 | [diff] [blame] | 847 | /*isBuffer*/ true, sGameMode); |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 848 | |
| 849 | // Set up the display frame |
Pascal Muetschard | ac7bcd9 | 2023-10-03 15:05:36 +0200 | [diff] [blame] | 850 | mFrameTimeline->setSfWakeUp(token2, 20, RR_11, RR_11); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 851 | surfaceFrame1->setPresentState(SurfaceFrame::PresentState::Presented); |
| 852 | mFrameTimeline->addSurfaceFrame(surfaceFrame1); |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 853 | mFrameTimeline->setSfPresent(25, presentFence1); |
| 854 | presentFence1->signalForTest(30); |
| 855 | |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 856 | addEmptyDisplayFrame(); |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 857 | flushTrace(); |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 858 | tracingSession->StopBlocking(); |
| 859 | |
| 860 | auto packets = readFrameTimelinePacketsBlocking(tracingSession.get()); |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 861 | // Display Frame 1 has 8 packets - 4 from DisplayFrame and 4 from SurfaceFrame. |
Siarhei Vishniakou | fc434ac | 2021-01-13 10:28:00 -1000 | [diff] [blame] | 862 | EXPECT_EQ(packets.size(), 8u); |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 863 | } |
| 864 | |
| 865 | TEST_F(FrameTimelineTest, traceDisplayFrame_invalidTokenDoesNotEmitTracePacket) { |
| 866 | auto tracingSession = getTracingSessionForTest(); |
| 867 | auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 868 | |
| 869 | tracingSession->StartBlocking(); |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 870 | |
| 871 | // Set up the display frame |
Pascal Muetschard | ac7bcd9 | 2023-10-03 15:05:36 +0200 | [diff] [blame] | 872 | mFrameTimeline->setSfWakeUp(-1, 20, RR_11, RR_11); |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 873 | mFrameTimeline->setSfPresent(25, presentFence1); |
| 874 | presentFence1->signalForTest(30); |
| 875 | |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 876 | addEmptyDisplayFrame(); |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 877 | flushTrace(); |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 878 | tracingSession->StopBlocking(); |
| 879 | |
| 880 | auto packets = readFrameTimelinePacketsBlocking(tracingSession.get()); |
Siarhei Vishniakou | fc434ac | 2021-01-13 10:28:00 -1000 | [diff] [blame] | 881 | EXPECT_EQ(packets.size(), 0u); |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 882 | } |
| 883 | |
| 884 | TEST_F(FrameTimelineTest, traceSurfaceFrame_invalidTokenDoesNotEmitTracePacket) { |
| 885 | auto tracingSession = getTracingSessionForTest(); |
| 886 | auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 887 | |
| 888 | tracingSession->StartBlocking(); |
| 889 | int64_t token1 = mTokenManager->generateTokenForPredictions({10, 20, 30}); |
Alec Mouri | adebf5c | 2021-01-05 12:57:36 -0800 | [diff] [blame] | 890 | auto surfaceFrame1 = |
| 891 | mFrameTimeline->createSurfaceFrameForToken({}, sPidOne, sUidOne, sLayerIdOne, |
Adithya Srinivasan | 785addd | 2021-03-09 00:38:00 +0000 | [diff] [blame] | 892 | sLayerNameOne, sLayerNameOne, |
Adithya Srinivasan | 58069dc | 2021-06-04 20:37:02 +0000 | [diff] [blame] | 893 | /*isBuffer*/ true, sGameMode); |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 894 | |
| 895 | // Set up the display frame |
Pascal Muetschard | ac7bcd9 | 2023-10-03 15:05:36 +0200 | [diff] [blame] | 896 | mFrameTimeline->setSfWakeUp(token1, 20, RR_11, RR_11); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 897 | surfaceFrame1->setPresentState(SurfaceFrame::PresentState::Dropped); |
| 898 | mFrameTimeline->addSurfaceFrame(surfaceFrame1); |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 899 | mFrameTimeline->setSfPresent(25, presentFence1); |
| 900 | presentFence1->signalForTest(30); |
| 901 | |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 902 | addEmptyDisplayFrame(); |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 903 | flushTrace(); |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 904 | tracingSession->StopBlocking(); |
| 905 | |
| 906 | auto packets = readFrameTimelinePacketsBlocking(tracingSession.get()); |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 907 | // Display Frame 1 has 4 packets (SurfaceFrame shouldn't be traced since it has an invalid |
| 908 | // token). |
Siarhei Vishniakou | fc434ac | 2021-01-13 10:28:00 -1000 | [diff] [blame] | 909 | EXPECT_EQ(packets.size(), 4u); |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 910 | } |
| 911 | |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 912 | ProtoExpectedDisplayFrameStart createProtoExpectedDisplayFrameStart(int64_t cookie, int64_t token, |
| 913 | pid_t pid) { |
| 914 | ProtoExpectedDisplayFrameStart proto; |
| 915 | proto.set_cookie(cookie); |
| 916 | proto.set_token(token); |
| 917 | proto.set_pid(pid); |
| 918 | return proto; |
| 919 | } |
| 920 | |
| 921 | ProtoActualDisplayFrameStart createProtoActualDisplayFrameStart( |
| 922 | int64_t cookie, int64_t token, pid_t pid, ProtoPresentType presentType, bool onTimeFinish, |
Adithya Srinivasan | 78e58af | 2021-02-25 00:08:08 +0000 | [diff] [blame] | 923 | bool gpuComposition, ProtoJankType jankType, ProtoPredictionType predictionType) { |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 924 | ProtoActualDisplayFrameStart proto; |
| 925 | proto.set_cookie(cookie); |
| 926 | proto.set_token(token); |
| 927 | proto.set_pid(pid); |
| 928 | proto.set_present_type(presentType); |
| 929 | proto.set_on_time_finish(onTimeFinish); |
| 930 | proto.set_gpu_composition(gpuComposition); |
| 931 | proto.set_jank_type(jankType); |
Adithya Srinivasan | 78e58af | 2021-02-25 00:08:08 +0000 | [diff] [blame] | 932 | proto.set_prediction_type(predictionType); |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 933 | return proto; |
| 934 | } |
| 935 | |
| 936 | ProtoExpectedSurfaceFrameStart createProtoExpectedSurfaceFrameStart(int64_t cookie, int64_t token, |
| 937 | int64_t displayFrameToken, |
| 938 | pid_t pid, |
| 939 | std::string layerName) { |
| 940 | ProtoExpectedSurfaceFrameStart proto; |
| 941 | proto.set_cookie(cookie); |
| 942 | proto.set_token(token); |
| 943 | proto.set_display_frame_token(displayFrameToken); |
| 944 | proto.set_pid(pid); |
| 945 | proto.set_layer_name(layerName); |
| 946 | return proto; |
| 947 | } |
| 948 | |
| 949 | ProtoActualSurfaceFrameStart createProtoActualSurfaceFrameStart( |
| 950 | int64_t cookie, int64_t token, int64_t displayFrameToken, pid_t pid, std::string layerName, |
| 951 | ProtoPresentType presentType, bool onTimeFinish, bool gpuComposition, |
Adithya Srinivasan | 1f9450c | 2021-06-10 22:39:19 +0000 | [diff] [blame] | 952 | ProtoJankType jankType, ProtoPredictionType predictionType, bool isBuffer) { |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 953 | ProtoActualSurfaceFrameStart proto; |
| 954 | proto.set_cookie(cookie); |
| 955 | proto.set_token(token); |
| 956 | proto.set_display_frame_token(displayFrameToken); |
| 957 | proto.set_pid(pid); |
| 958 | proto.set_layer_name(layerName); |
| 959 | proto.set_present_type(presentType); |
| 960 | proto.set_on_time_finish(onTimeFinish); |
| 961 | proto.set_gpu_composition(gpuComposition); |
| 962 | proto.set_jank_type(jankType); |
Adithya Srinivasan | 78e58af | 2021-02-25 00:08:08 +0000 | [diff] [blame] | 963 | proto.set_prediction_type(predictionType); |
Adithya Srinivasan | 1f9450c | 2021-06-10 22:39:19 +0000 | [diff] [blame] | 964 | proto.set_is_buffer(isBuffer); |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 965 | return proto; |
| 966 | } |
| 967 | |
| 968 | ProtoFrameEnd createProtoFrameEnd(int64_t cookie) { |
| 969 | ProtoFrameEnd proto; |
| 970 | proto.set_cookie(cookie); |
| 971 | return proto; |
| 972 | } |
| 973 | |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 974 | void validateTraceEvent(const ProtoExpectedDisplayFrameStart& received, |
| 975 | const ProtoExpectedDisplayFrameStart& source) { |
| 976 | ASSERT_TRUE(received.has_cookie()); |
| 977 | EXPECT_EQ(received.cookie(), source.cookie()); |
| 978 | |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 979 | ASSERT_TRUE(received.has_token()); |
| 980 | EXPECT_EQ(received.token(), source.token()); |
| 981 | |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 982 | ASSERT_TRUE(received.has_pid()); |
| 983 | EXPECT_EQ(received.pid(), source.pid()); |
| 984 | } |
| 985 | |
| 986 | void validateTraceEvent(const ProtoActualDisplayFrameStart& received, |
| 987 | const ProtoActualDisplayFrameStart& source) { |
| 988 | ASSERT_TRUE(received.has_cookie()); |
| 989 | EXPECT_EQ(received.cookie(), source.cookie()); |
| 990 | |
| 991 | ASSERT_TRUE(received.has_token()); |
| 992 | EXPECT_EQ(received.token(), source.token()); |
| 993 | |
| 994 | ASSERT_TRUE(received.has_pid()); |
| 995 | EXPECT_EQ(received.pid(), source.pid()); |
| 996 | |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 997 | ASSERT_TRUE(received.has_present_type()); |
| 998 | EXPECT_EQ(received.present_type(), source.present_type()); |
| 999 | ASSERT_TRUE(received.has_on_time_finish()); |
| 1000 | EXPECT_EQ(received.on_time_finish(), source.on_time_finish()); |
| 1001 | ASSERT_TRUE(received.has_gpu_composition()); |
| 1002 | EXPECT_EQ(received.gpu_composition(), source.gpu_composition()); |
| 1003 | ASSERT_TRUE(received.has_jank_type()); |
| 1004 | EXPECT_EQ(received.jank_type(), source.jank_type()); |
Adithya Srinivasan | 78e58af | 2021-02-25 00:08:08 +0000 | [diff] [blame] | 1005 | ASSERT_TRUE(received.has_prediction_type()); |
| 1006 | EXPECT_EQ(received.prediction_type(), source.prediction_type()); |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 1007 | } |
| 1008 | |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 1009 | void validateTraceEvent(const ProtoExpectedSurfaceFrameStart& received, |
| 1010 | const ProtoExpectedSurfaceFrameStart& source) { |
| 1011 | ASSERT_TRUE(received.has_cookie()); |
| 1012 | EXPECT_EQ(received.cookie(), source.cookie()); |
| 1013 | |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 1014 | ASSERT_TRUE(received.has_token()); |
| 1015 | EXPECT_EQ(received.token(), source.token()); |
| 1016 | |
| 1017 | ASSERT_TRUE(received.has_display_frame_token()); |
| 1018 | EXPECT_EQ(received.display_frame_token(), source.display_frame_token()); |
| 1019 | |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 1020 | ASSERT_TRUE(received.has_pid()); |
| 1021 | EXPECT_EQ(received.pid(), source.pid()); |
| 1022 | |
| 1023 | ASSERT_TRUE(received.has_layer_name()); |
| 1024 | EXPECT_EQ(received.layer_name(), source.layer_name()); |
| 1025 | } |
| 1026 | |
| 1027 | void validateTraceEvent(const ProtoActualSurfaceFrameStart& received, |
| 1028 | const ProtoActualSurfaceFrameStart& source) { |
| 1029 | ASSERT_TRUE(received.has_cookie()); |
| 1030 | EXPECT_EQ(received.cookie(), source.cookie()); |
| 1031 | |
| 1032 | ASSERT_TRUE(received.has_token()); |
| 1033 | EXPECT_EQ(received.token(), source.token()); |
| 1034 | |
| 1035 | ASSERT_TRUE(received.has_display_frame_token()); |
| 1036 | EXPECT_EQ(received.display_frame_token(), source.display_frame_token()); |
| 1037 | |
| 1038 | ASSERT_TRUE(received.has_pid()); |
| 1039 | EXPECT_EQ(received.pid(), source.pid()); |
| 1040 | |
| 1041 | ASSERT_TRUE(received.has_layer_name()); |
| 1042 | EXPECT_EQ(received.layer_name(), source.layer_name()); |
| 1043 | |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 1044 | ASSERT_TRUE(received.has_present_type()); |
| 1045 | EXPECT_EQ(received.present_type(), source.present_type()); |
| 1046 | ASSERT_TRUE(received.has_on_time_finish()); |
| 1047 | EXPECT_EQ(received.on_time_finish(), source.on_time_finish()); |
| 1048 | ASSERT_TRUE(received.has_gpu_composition()); |
| 1049 | EXPECT_EQ(received.gpu_composition(), source.gpu_composition()); |
| 1050 | ASSERT_TRUE(received.has_jank_type()); |
| 1051 | EXPECT_EQ(received.jank_type(), source.jank_type()); |
Adithya Srinivasan | 78e58af | 2021-02-25 00:08:08 +0000 | [diff] [blame] | 1052 | ASSERT_TRUE(received.has_prediction_type()); |
| 1053 | EXPECT_EQ(received.prediction_type(), source.prediction_type()); |
Adithya Srinivasan | 1f9450c | 2021-06-10 22:39:19 +0000 | [diff] [blame] | 1054 | ASSERT_TRUE(received.has_is_buffer()); |
| 1055 | EXPECT_EQ(received.is_buffer(), source.is_buffer()); |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 1056 | } |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 1057 | |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 1058 | void validateTraceEvent(const ProtoFrameEnd& received, const ProtoFrameEnd& source) { |
| 1059 | ASSERT_TRUE(received.has_cookie()); |
| 1060 | EXPECT_EQ(received.cookie(), source.cookie()); |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 1061 | } |
| 1062 | |
Sally Qi | aa10774 | 2023-09-29 14:53:14 -0700 | [diff] [blame] | 1063 | TEST_F(FrameTimelineTest, traceDisplayFrameSkipped) { |
Sally Qi | f572125 | 2023-11-17 11:14:53 -0800 | [diff] [blame] | 1064 | SET_FLAG_FOR_TEST(com::android::graphics::surfaceflinger::flags::add_sf_skipped_frames_to_trace, |
| 1065 | true); |
| 1066 | |
Sally Qi | aa10774 | 2023-09-29 14:53:14 -0700 | [diff] [blame] | 1067 | // setup 2 display frames |
| 1068 | // DF 1: [22,40] -> [5, 40] |
| 1069 | // DF : [36, 70] (Skipped one, added by the trace) |
| 1070 | // DF 2: [82, 100] -> SF [25, 70] |
| 1071 | auto tracingSession = getTracingSessionForTest(); |
| 1072 | tracingSession->StartBlocking(); |
| 1073 | int64_t sfToken1 = mTokenManager->generateTokenForPredictions({22, 30, 40}); |
| 1074 | int64_t sfToken2 = mTokenManager->generateTokenForPredictions({82, 90, 100}); |
| 1075 | int64_t surfaceFrameToken1 = mTokenManager->generateTokenForPredictions({5, 16, 40}); |
| 1076 | int64_t surfaceFrameToken2 = mTokenManager->generateTokenForPredictions({25, 36, 70}); |
| 1077 | auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
| 1078 | |
| 1079 | int64_t traceCookie = snoopCurrentTraceCookie(); |
| 1080 | |
| 1081 | // set up 1st display frame |
| 1082 | FrameTimelineInfo ftInfo1; |
| 1083 | ftInfo1.vsyncId = surfaceFrameToken1; |
| 1084 | ftInfo1.inputEventId = sInputEventId; |
| 1085 | auto surfaceFrame1 = |
| 1086 | mFrameTimeline->createSurfaceFrameForToken(ftInfo1, sPidOne, sUidOne, sLayerIdOne, |
| 1087 | sLayerNameOne, sLayerNameOne, |
| 1088 | /*isBuffer*/ true, sGameMode); |
| 1089 | surfaceFrame1->setAcquireFenceTime(16); |
| 1090 | mFrameTimeline->setSfWakeUp(sfToken1, 22, RR_11, RR_30); |
| 1091 | surfaceFrame1->setPresentState(SurfaceFrame::PresentState::Presented); |
| 1092 | mFrameTimeline->addSurfaceFrame(surfaceFrame1); |
| 1093 | mFrameTimeline->setSfPresent(30, presentFence1); |
| 1094 | presentFence1->signalForTest(40); |
| 1095 | |
| 1096 | // Trigger a flush by finalizing the next DisplayFrame |
| 1097 | auto presentFence2 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
| 1098 | FrameTimelineInfo ftInfo2; |
| 1099 | ftInfo2.vsyncId = surfaceFrameToken2; |
| 1100 | ftInfo2.inputEventId = sInputEventId; |
| 1101 | auto surfaceFrame2 = |
| 1102 | mFrameTimeline->createSurfaceFrameForToken(ftInfo2, sPidOne, sUidOne, sLayerIdOne, |
| 1103 | sLayerNameOne, sLayerNameOne, |
| 1104 | /*isBuffer*/ true, sGameMode); |
| 1105 | |
| 1106 | // set up 2nd display frame |
| 1107 | surfaceFrame2->setAcquireFenceTime(36); |
| 1108 | mFrameTimeline->setSfWakeUp(sfToken2, 82, RR_11, RR_30); |
| 1109 | surfaceFrame2->setPresentState(SurfaceFrame::PresentState::Presented); |
| 1110 | mFrameTimeline->addSurfaceFrame(surfaceFrame2); |
| 1111 | mFrameTimeline->setSfPresent(90, presentFence2); |
| 1112 | presentFence2->signalForTest(100); |
| 1113 | |
| 1114 | // the token of skipped Display Frame |
| 1115 | auto protoSkippedActualDisplayFrameStart = |
| 1116 | createProtoActualDisplayFrameStart(traceCookie + 9, 0, kSurfaceFlingerPid, |
| 1117 | FrameTimelineEvent::PRESENT_DROPPED, true, false, |
| 1118 | FrameTimelineEvent::JANK_DROPPED, |
| 1119 | FrameTimelineEvent::PREDICTION_VALID); |
| 1120 | auto protoSkippedActualDisplayFrameEnd = createProtoFrameEnd(traceCookie + 9); |
| 1121 | |
| 1122 | // Trigger a flush by finalizing the next DisplayFrame |
| 1123 | addEmptyDisplayFrame(); |
| 1124 | flushTrace(); |
| 1125 | tracingSession->StopBlocking(); |
| 1126 | |
| 1127 | auto packets = readFrameTimelinePacketsBlocking(tracingSession.get()); |
| 1128 | // 8 Valid Display Frames + 8 Valid Surface Frames + 2 Skipped Display Frames |
| 1129 | EXPECT_EQ(packets.size(), 18u); |
| 1130 | |
| 1131 | // Packet - 16: Actual skipped Display Frame Start |
| 1132 | // the timestamp should be equal to the 2nd expected surface frame's end time |
| 1133 | const auto& packet16 = packets[16]; |
| 1134 | ASSERT_TRUE(packet16.has_timestamp()); |
| 1135 | EXPECT_EQ(packet16.timestamp(), 36u); |
| 1136 | ASSERT_TRUE(packet16.has_frame_timeline_event()); |
| 1137 | |
| 1138 | const auto& event16 = packet16.frame_timeline_event(); |
| 1139 | const auto& actualSkippedDisplayFrameStart = event16.actual_display_frame_start(); |
| 1140 | validateTraceEvent(actualSkippedDisplayFrameStart, protoSkippedActualDisplayFrameStart); |
| 1141 | |
| 1142 | // Packet - 17: Actual skipped Display Frame End |
| 1143 | // the timestamp should be equal to the 2nd expected surface frame's present time |
| 1144 | const auto& packet17 = packets[17]; |
| 1145 | ASSERT_TRUE(packet17.has_timestamp()); |
| 1146 | EXPECT_EQ(packet17.timestamp(), 70u); |
| 1147 | ASSERT_TRUE(packet17.has_frame_timeline_event()); |
| 1148 | |
| 1149 | const auto& event17 = packet17.frame_timeline_event(); |
| 1150 | const auto& actualSkippedDisplayFrameEnd = event17.frame_end(); |
| 1151 | validateTraceEvent(actualSkippedDisplayFrameEnd, protoSkippedActualDisplayFrameEnd); |
| 1152 | } |
| 1153 | |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 1154 | TEST_F(FrameTimelineTest, traceDisplayFrame_emitsValidTracePacket) { |
| 1155 | auto tracingSession = getTracingSessionForTest(); |
| 1156 | auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 1157 | |
| 1158 | tracingSession->StartBlocking(); |
Ady Abraham | 57a8ab4 | 2023-01-26 15:28:19 -0800 | [diff] [blame] | 1159 | |
| 1160 | // Add an empty surface frame so that display frame would get traced. |
| 1161 | addEmptySurfaceFrame(); |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 1162 | int64_t displayFrameToken1 = mTokenManager->generateTokenForPredictions({10, 30, 30}); |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 1163 | |
| 1164 | // Set up the display frame |
Pascal Muetschard | ac7bcd9 | 2023-10-03 15:05:36 +0200 | [diff] [blame] | 1165 | mFrameTimeline->setSfWakeUp(displayFrameToken1, 20, RR_11, RR_11); |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 1166 | mFrameTimeline->setSfPresent(26, presentFence1); |
| 1167 | presentFence1->signalForTest(31); |
| 1168 | |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 1169 | int64_t traceCookie = snoopCurrentTraceCookie(); |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 1170 | auto protoExpectedDisplayFrameStart = |
| 1171 | createProtoExpectedDisplayFrameStart(traceCookie + 1, displayFrameToken1, |
| 1172 | kSurfaceFlingerPid); |
| 1173 | auto protoExpectedDisplayFrameEnd = createProtoFrameEnd(traceCookie + 1); |
| 1174 | auto protoActualDisplayFrameStart = |
| 1175 | createProtoActualDisplayFrameStart(traceCookie + 2, displayFrameToken1, |
| 1176 | kSurfaceFlingerPid, |
| 1177 | FrameTimelineEvent::PRESENT_ON_TIME, true, false, |
Adithya Srinivasan | 78e58af | 2021-02-25 00:08:08 +0000 | [diff] [blame] | 1178 | FrameTimelineEvent::JANK_NONE, |
| 1179 | FrameTimelineEvent::PREDICTION_VALID); |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 1180 | auto protoActualDisplayFrameEnd = createProtoFrameEnd(traceCookie + 2); |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 1181 | |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 1182 | addEmptyDisplayFrame(); |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 1183 | flushTrace(); |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 1184 | tracingSession->StopBlocking(); |
| 1185 | |
| 1186 | auto packets = readFrameTimelinePacketsBlocking(tracingSession.get()); |
Siarhei Vishniakou | fc434ac | 2021-01-13 10:28:00 -1000 | [diff] [blame] | 1187 | EXPECT_EQ(packets.size(), 4u); |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 1188 | |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 1189 | // Packet - 0 : ExpectedDisplayFrameStart |
| 1190 | const auto& packet0 = packets[0]; |
| 1191 | ASSERT_TRUE(packet0.has_timestamp()); |
Siarhei Vishniakou | fc434ac | 2021-01-13 10:28:00 -1000 | [diff] [blame] | 1192 | EXPECT_EQ(packet0.timestamp(), 10u); |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 1193 | ASSERT_TRUE(packet0.has_frame_timeline_event()); |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 1194 | |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 1195 | const auto& event0 = packet0.frame_timeline_event(); |
| 1196 | ASSERT_TRUE(event0.has_expected_display_frame_start()); |
| 1197 | const auto& expectedDisplayFrameStart = event0.expected_display_frame_start(); |
| 1198 | validateTraceEvent(expectedDisplayFrameStart, protoExpectedDisplayFrameStart); |
| 1199 | |
| 1200 | // Packet - 1 : FrameEnd (ExpectedDisplayFrame) |
| 1201 | const auto& packet1 = packets[1]; |
| 1202 | ASSERT_TRUE(packet1.has_timestamp()); |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 1203 | EXPECT_EQ(packet1.timestamp(), 30u); |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 1204 | ASSERT_TRUE(packet1.has_frame_timeline_event()); |
| 1205 | |
| 1206 | const auto& event1 = packet1.frame_timeline_event(); |
| 1207 | ASSERT_TRUE(event1.has_frame_end()); |
| 1208 | const auto& expectedDisplayFrameEnd = event1.frame_end(); |
| 1209 | validateTraceEvent(expectedDisplayFrameEnd, protoExpectedDisplayFrameEnd); |
| 1210 | |
| 1211 | // Packet - 2 : ActualDisplayFrameStart |
| 1212 | const auto& packet2 = packets[2]; |
| 1213 | ASSERT_TRUE(packet2.has_timestamp()); |
Siarhei Vishniakou | fc434ac | 2021-01-13 10:28:00 -1000 | [diff] [blame] | 1214 | EXPECT_EQ(packet2.timestamp(), 20u); |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 1215 | ASSERT_TRUE(packet2.has_frame_timeline_event()); |
| 1216 | |
| 1217 | const auto& event2 = packet2.frame_timeline_event(); |
| 1218 | ASSERT_TRUE(event2.has_actual_display_frame_start()); |
| 1219 | const auto& actualDisplayFrameStart = event2.actual_display_frame_start(); |
| 1220 | validateTraceEvent(actualDisplayFrameStart, protoActualDisplayFrameStart); |
| 1221 | |
| 1222 | // Packet - 3 : FrameEnd (ActualDisplayFrame) |
| 1223 | const auto& packet3 = packets[3]; |
| 1224 | ASSERT_TRUE(packet3.has_timestamp()); |
Adithya Srinivasan | 1a97163 | 2021-02-26 23:10:29 +0000 | [diff] [blame] | 1225 | EXPECT_EQ(packet3.timestamp(), 31u); |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 1226 | ASSERT_TRUE(packet3.has_frame_timeline_event()); |
| 1227 | |
| 1228 | const auto& event3 = packet3.frame_timeline_event(); |
| 1229 | ASSERT_TRUE(event3.has_frame_end()); |
| 1230 | const auto& actualDisplayFrameEnd = event3.frame_end(); |
| 1231 | validateTraceEvent(actualDisplayFrameEnd, protoActualDisplayFrameEnd); |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 1232 | } |
| 1233 | |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 1234 | TEST_F(FrameTimelineTest, traceDisplayFrame_predictionExpiredDoesNotTraceExpectedTimeline) { |
| 1235 | auto tracingSession = getTracingSessionForTest(); |
| 1236 | auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
| 1237 | |
| 1238 | tracingSession->StartBlocking(); |
| 1239 | int64_t displayFrameToken1 = mTokenManager->generateTokenForPredictions({10, 25, 30}); |
| 1240 | // Flush the token so that it would expire |
Adithya Srinivasan | bed4c4f | 2021-05-03 20:24:46 +0000 | [diff] [blame] | 1241 | flushTokens(); |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 1242 | |
Ady Abraham | 57a8ab4 | 2023-01-26 15:28:19 -0800 | [diff] [blame] | 1243 | // Add an empty surface frame so that display frame would get traced. |
| 1244 | addEmptySurfaceFrame(); |
| 1245 | |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 1246 | // Set up the display frame |
Pascal Muetschard | ac7bcd9 | 2023-10-03 15:05:36 +0200 | [diff] [blame] | 1247 | mFrameTimeline->setSfWakeUp(displayFrameToken1, 20, RR_11, RR_11); |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 1248 | mFrameTimeline->setSfPresent(26, presentFence1); |
| 1249 | presentFence1->signalForTest(31); |
| 1250 | |
| 1251 | int64_t traceCookie = snoopCurrentTraceCookie(); |
| 1252 | |
| 1253 | auto protoActualDisplayFrameStart = |
| 1254 | createProtoActualDisplayFrameStart(traceCookie + 1, displayFrameToken1, |
| 1255 | kSurfaceFlingerPid, |
| 1256 | FrameTimelineEvent::PRESENT_UNSPECIFIED, false, |
Adithya Srinivasan | 78e58af | 2021-02-25 00:08:08 +0000 | [diff] [blame] | 1257 | false, FrameTimelineEvent::JANK_UNKNOWN, |
| 1258 | FrameTimelineEvent::PREDICTION_EXPIRED); |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 1259 | auto protoActualDisplayFrameEnd = createProtoFrameEnd(traceCookie + 1); |
| 1260 | |
| 1261 | addEmptyDisplayFrame(); |
| 1262 | flushTrace(); |
| 1263 | tracingSession->StopBlocking(); |
| 1264 | |
| 1265 | auto packets = readFrameTimelinePacketsBlocking(tracingSession.get()); |
| 1266 | // Only actual timeline packets should be in the trace |
| 1267 | EXPECT_EQ(packets.size(), 2u); |
| 1268 | |
| 1269 | // Packet - 0 : ActualDisplayFrameStart |
| 1270 | const auto& packet0 = packets[0]; |
| 1271 | ASSERT_TRUE(packet0.has_timestamp()); |
| 1272 | EXPECT_EQ(packet0.timestamp(), 20u); |
| 1273 | ASSERT_TRUE(packet0.has_frame_timeline_event()); |
| 1274 | |
| 1275 | const auto& event0 = packet0.frame_timeline_event(); |
| 1276 | ASSERT_TRUE(event0.has_actual_display_frame_start()); |
| 1277 | const auto& actualDisplayFrameStart = event0.actual_display_frame_start(); |
| 1278 | validateTraceEvent(actualDisplayFrameStart, protoActualDisplayFrameStart); |
| 1279 | |
| 1280 | // Packet - 1 : FrameEnd (ActualDisplayFrame) |
| 1281 | const auto& packet1 = packets[1]; |
| 1282 | ASSERT_TRUE(packet1.has_timestamp()); |
Adithya Srinivasan | 1a97163 | 2021-02-26 23:10:29 +0000 | [diff] [blame] | 1283 | EXPECT_EQ(packet1.timestamp(), 31u); |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 1284 | ASSERT_TRUE(packet1.has_frame_timeline_event()); |
| 1285 | |
| 1286 | const auto& event1 = packet1.frame_timeline_event(); |
| 1287 | ASSERT_TRUE(event1.has_frame_end()); |
| 1288 | const auto& actualDisplayFrameEnd = event1.frame_end(); |
| 1289 | validateTraceEvent(actualDisplayFrameEnd, protoActualDisplayFrameEnd); |
| 1290 | } |
| 1291 | |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 1292 | TEST_F(FrameTimelineTest, traceSurfaceFrame_emitsValidTracePacket) { |
| 1293 | auto tracingSession = getTracingSessionForTest(); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1294 | // Layer specific increment |
Edgar Arriaga | 631e425 | 2023-03-02 02:11:24 +0000 | [diff] [blame] | 1295 | EXPECT_CALL(*mTimeStats, incrementJankyFrames(_)).Times(2); |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 1296 | auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
| 1297 | auto presentFence2 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
| 1298 | |
| 1299 | tracingSession->StartBlocking(); |
| 1300 | int64_t surfaceFrameToken = mTokenManager->generateTokenForPredictions({10, 25, 40}); |
| 1301 | int64_t displayFrameToken1 = mTokenManager->generateTokenForPredictions({30, 35, 40}); |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 1302 | |
Huihong Luo | 3bdef86 | 2022-03-03 11:57:19 -0800 | [diff] [blame] | 1303 | FrameTimelineInfo ftInfo; |
| 1304 | ftInfo.vsyncId = surfaceFrameToken; |
| 1305 | ftInfo.inputEventId = sInputEventId; |
| 1306 | |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 1307 | auto surfaceFrame1 = |
Huihong Luo | 3bdef86 | 2022-03-03 11:57:19 -0800 | [diff] [blame] | 1308 | mFrameTimeline->createSurfaceFrameForToken(ftInfo, sPidOne, sUidOne, sLayerIdOne, |
| 1309 | sLayerNameOne, sLayerNameOne, |
| 1310 | /*isBuffer*/ true, sGameMode); |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 1311 | auto surfaceFrame2 = |
Huihong Luo | 3bdef86 | 2022-03-03 11:57:19 -0800 | [diff] [blame] | 1312 | mFrameTimeline->createSurfaceFrameForToken(ftInfo, sPidOne, sUidOne, sLayerIdOne, |
| 1313 | sLayerNameOne, sLayerNameOne, |
| 1314 | /*isBuffer*/ true, sGameMode); |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 1315 | surfaceFrame1->setActualQueueTime(10); |
| 1316 | surfaceFrame1->setDropTime(15); |
| 1317 | |
| 1318 | surfaceFrame2->setActualQueueTime(15); |
| 1319 | surfaceFrame2->setAcquireFenceTime(20); |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 1320 | |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 1321 | // First 2 cookies will be used by the DisplayFrame |
| 1322 | int64_t traceCookie = snoopCurrentTraceCookie() + 2; |
| 1323 | |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 1324 | auto protoDroppedSurfaceFrameExpectedStart = |
| 1325 | createProtoExpectedSurfaceFrameStart(traceCookie + 1, surfaceFrameToken, |
| 1326 | displayFrameToken1, sPidOne, sLayerNameOne); |
| 1327 | auto protoDroppedSurfaceFrameExpectedEnd = createProtoFrameEnd(traceCookie + 1); |
| 1328 | auto protoDroppedSurfaceFrameActualStart = |
| 1329 | createProtoActualSurfaceFrameStart(traceCookie + 2, surfaceFrameToken, |
| 1330 | displayFrameToken1, sPidOne, sLayerNameOne, |
Edgar Arriaga | 631e425 | 2023-03-02 02:11:24 +0000 | [diff] [blame] | 1331 | FrameTimelineEvent::PRESENT_DROPPED, true, false, |
| 1332 | FrameTimelineEvent::JANK_DROPPED, |
Adithya Srinivasan | 1f9450c | 2021-06-10 22:39:19 +0000 | [diff] [blame] | 1333 | FrameTimelineEvent::PREDICTION_VALID, true); |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 1334 | auto protoDroppedSurfaceFrameActualEnd = createProtoFrameEnd(traceCookie + 2); |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 1335 | |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 1336 | auto protoPresentedSurfaceFrameExpectedStart = |
| 1337 | createProtoExpectedSurfaceFrameStart(traceCookie + 3, surfaceFrameToken, |
| 1338 | displayFrameToken1, sPidOne, sLayerNameOne); |
| 1339 | auto protoPresentedSurfaceFrameExpectedEnd = createProtoFrameEnd(traceCookie + 3); |
| 1340 | auto protoPresentedSurfaceFrameActualStart = |
| 1341 | createProtoActualSurfaceFrameStart(traceCookie + 4, surfaceFrameToken, |
| 1342 | displayFrameToken1, sPidOne, sLayerNameOne, |
| 1343 | FrameTimelineEvent::PRESENT_ON_TIME, true, false, |
Adithya Srinivasan | 78e58af | 2021-02-25 00:08:08 +0000 | [diff] [blame] | 1344 | FrameTimelineEvent::JANK_NONE, |
Adithya Srinivasan | 1f9450c | 2021-06-10 22:39:19 +0000 | [diff] [blame] | 1345 | FrameTimelineEvent::PREDICTION_VALID, true); |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 1346 | auto protoPresentedSurfaceFrameActualEnd = createProtoFrameEnd(traceCookie + 4); |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 1347 | |
| 1348 | // Set up the display frame |
Pascal Muetschard | ac7bcd9 | 2023-10-03 15:05:36 +0200 | [diff] [blame] | 1349 | mFrameTimeline->setSfWakeUp(displayFrameToken1, 20, RR_11, RR_11); |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 1350 | surfaceFrame1->setPresentState(SurfaceFrame::PresentState::Dropped); |
| 1351 | surfaceFrame2->setPresentState(SurfaceFrame::PresentState::Presented); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1352 | mFrameTimeline->addSurfaceFrame(surfaceFrame1); |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 1353 | mFrameTimeline->addSurfaceFrame(surfaceFrame2); |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 1354 | mFrameTimeline->setSfPresent(26, presentFence1); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1355 | presentFence1->signalForTest(40); |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 1356 | |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 1357 | addEmptyDisplayFrame(); |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 1358 | flushTrace(); |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 1359 | tracingSession->StopBlocking(); |
| 1360 | |
| 1361 | auto packets = readFrameTimelinePacketsBlocking(tracingSession.get()); |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 1362 | // 4 DisplayFrame + 4 DroppedSurfaceFrame + 4 PresentedSurfaceFrame |
| 1363 | EXPECT_EQ(packets.size(), 12u); |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 1364 | |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 1365 | // Packet - 4 : ExpectedSurfaceFrameStart1 |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 1366 | const auto& packet4 = packets[4]; |
| 1367 | ASSERT_TRUE(packet4.has_timestamp()); |
Siarhei Vishniakou | fc434ac | 2021-01-13 10:28:00 -1000 | [diff] [blame] | 1368 | EXPECT_EQ(packet4.timestamp(), 10u); |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 1369 | ASSERT_TRUE(packet4.has_frame_timeline_event()); |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 1370 | |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 1371 | const auto& event4 = packet4.frame_timeline_event(); |
| 1372 | ASSERT_TRUE(event4.has_expected_surface_frame_start()); |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 1373 | const auto& expectedSurfaceFrameStart1 = event4.expected_surface_frame_start(); |
| 1374 | validateTraceEvent(expectedSurfaceFrameStart1, protoDroppedSurfaceFrameExpectedStart); |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 1375 | |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 1376 | // Packet - 5 : FrameEnd (ExpectedSurfaceFrame1) |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 1377 | const auto& packet5 = packets[5]; |
| 1378 | ASSERT_TRUE(packet5.has_timestamp()); |
Siarhei Vishniakou | fc434ac | 2021-01-13 10:28:00 -1000 | [diff] [blame] | 1379 | EXPECT_EQ(packet5.timestamp(), 25u); |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 1380 | ASSERT_TRUE(packet5.has_frame_timeline_event()); |
| 1381 | |
| 1382 | const auto& event5 = packet5.frame_timeline_event(); |
| 1383 | ASSERT_TRUE(event5.has_frame_end()); |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 1384 | const auto& expectedSurfaceFrameEnd1 = event5.frame_end(); |
| 1385 | validateTraceEvent(expectedSurfaceFrameEnd1, protoDroppedSurfaceFrameExpectedEnd); |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 1386 | |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 1387 | // Packet - 6 : ActualSurfaceFrameStart1 |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 1388 | const auto& packet6 = packets[6]; |
| 1389 | ASSERT_TRUE(packet6.has_timestamp()); |
Siarhei Vishniakou | fc434ac | 2021-01-13 10:28:00 -1000 | [diff] [blame] | 1390 | EXPECT_EQ(packet6.timestamp(), 10u); |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 1391 | ASSERT_TRUE(packet6.has_frame_timeline_event()); |
| 1392 | |
| 1393 | const auto& event6 = packet6.frame_timeline_event(); |
| 1394 | ASSERT_TRUE(event6.has_actual_surface_frame_start()); |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 1395 | const auto& actualSurfaceFrameStart1 = event6.actual_surface_frame_start(); |
| 1396 | validateTraceEvent(actualSurfaceFrameStart1, protoDroppedSurfaceFrameActualStart); |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 1397 | |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 1398 | // Packet - 7 : FrameEnd (ActualSurfaceFrame1) |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 1399 | const auto& packet7 = packets[7]; |
| 1400 | ASSERT_TRUE(packet7.has_timestamp()); |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 1401 | EXPECT_EQ(packet7.timestamp(), 15u); |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 1402 | ASSERT_TRUE(packet7.has_frame_timeline_event()); |
| 1403 | |
| 1404 | const auto& event7 = packet7.frame_timeline_event(); |
| 1405 | ASSERT_TRUE(event7.has_frame_end()); |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 1406 | const auto& actualSurfaceFrameEnd1 = event7.frame_end(); |
| 1407 | validateTraceEvent(actualSurfaceFrameEnd1, protoDroppedSurfaceFrameActualEnd); |
| 1408 | |
| 1409 | // Packet - 8 : ExpectedSurfaceFrameStart2 |
| 1410 | const auto& packet8 = packets[8]; |
| 1411 | ASSERT_TRUE(packet8.has_timestamp()); |
| 1412 | EXPECT_EQ(packet8.timestamp(), 10u); |
| 1413 | ASSERT_TRUE(packet8.has_frame_timeline_event()); |
| 1414 | |
| 1415 | const auto& event8 = packet8.frame_timeline_event(); |
| 1416 | ASSERT_TRUE(event8.has_expected_surface_frame_start()); |
| 1417 | const auto& expectedSurfaceFrameStart2 = event8.expected_surface_frame_start(); |
| 1418 | validateTraceEvent(expectedSurfaceFrameStart2, protoPresentedSurfaceFrameExpectedStart); |
| 1419 | |
| 1420 | // Packet - 9 : FrameEnd (ExpectedSurfaceFrame2) |
| 1421 | const auto& packet9 = packets[9]; |
| 1422 | ASSERT_TRUE(packet9.has_timestamp()); |
| 1423 | EXPECT_EQ(packet9.timestamp(), 25u); |
| 1424 | ASSERT_TRUE(packet9.has_frame_timeline_event()); |
| 1425 | |
| 1426 | const auto& event9 = packet9.frame_timeline_event(); |
| 1427 | ASSERT_TRUE(event9.has_frame_end()); |
| 1428 | const auto& expectedSurfaceFrameEnd2 = event9.frame_end(); |
| 1429 | validateTraceEvent(expectedSurfaceFrameEnd2, protoPresentedSurfaceFrameExpectedEnd); |
| 1430 | |
| 1431 | // Packet - 10 : ActualSurfaceFrameStart2 |
| 1432 | const auto& packet10 = packets[10]; |
| 1433 | ASSERT_TRUE(packet10.has_timestamp()); |
| 1434 | EXPECT_EQ(packet10.timestamp(), 10u); |
| 1435 | ASSERT_TRUE(packet10.has_frame_timeline_event()); |
| 1436 | |
| 1437 | const auto& event10 = packet10.frame_timeline_event(); |
| 1438 | ASSERT_TRUE(event10.has_actual_surface_frame_start()); |
| 1439 | const auto& actualSurfaceFrameStart2 = event10.actual_surface_frame_start(); |
| 1440 | validateTraceEvent(actualSurfaceFrameStart2, protoPresentedSurfaceFrameActualStart); |
| 1441 | |
| 1442 | // Packet - 11 : FrameEnd (ActualSurfaceFrame2) |
| 1443 | const auto& packet11 = packets[11]; |
| 1444 | ASSERT_TRUE(packet11.has_timestamp()); |
| 1445 | EXPECT_EQ(packet11.timestamp(), 20u); |
| 1446 | ASSERT_TRUE(packet11.has_frame_timeline_event()); |
| 1447 | |
| 1448 | const auto& event11 = packet11.frame_timeline_event(); |
| 1449 | ASSERT_TRUE(event11.has_frame_end()); |
| 1450 | const auto& actualSurfaceFrameEnd2 = event11.frame_end(); |
| 1451 | validateTraceEvent(actualSurfaceFrameEnd2, protoPresentedSurfaceFrameActualEnd); |
| 1452 | } |
| 1453 | |
Ady Abraham | e43ff72 | 2022-02-15 14:44:25 -0800 | [diff] [blame] | 1454 | TEST_F(FrameTimelineTest, traceSurfaceFrame_predictionExpiredIsAppMissedDeadline) { |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 1455 | auto tracingSession = getTracingSessionForTest(); |
| 1456 | auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
| 1457 | |
| 1458 | tracingSession->StartBlocking(); |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 1459 | constexpr nsecs_t appStartTime = std::chrono::nanoseconds(10ms).count(); |
| 1460 | constexpr nsecs_t appEndTime = std::chrono::nanoseconds(20ms).count(); |
| 1461 | constexpr nsecs_t appPresentTime = std::chrono::nanoseconds(30ms).count(); |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 1462 | int64_t surfaceFrameToken = |
| 1463 | mTokenManager->generateTokenForPredictions({appStartTime, appEndTime, appPresentTime}); |
| 1464 | |
| 1465 | // Flush the token so that it would expire |
Adithya Srinivasan | bed4c4f | 2021-05-03 20:24:46 +0000 | [diff] [blame] | 1466 | flushTokens(); |
Huihong Luo | 3bdef86 | 2022-03-03 11:57:19 -0800 | [diff] [blame] | 1467 | FrameTimelineInfo ftInfo; |
| 1468 | ftInfo.vsyncId = surfaceFrameToken; |
| 1469 | ftInfo.inputEventId = 0; |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 1470 | auto surfaceFrame1 = |
Huihong Luo | 3bdef86 | 2022-03-03 11:57:19 -0800 | [diff] [blame] | 1471 | mFrameTimeline->createSurfaceFrameForToken(ftInfo, sPidOne, sUidOne, sLayerIdOne, |
| 1472 | sLayerNameOne, sLayerNameOne, |
| 1473 | /*isBuffer*/ true, sGameMode); |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 1474 | surfaceFrame1->setActualQueueTime(appEndTime); |
| 1475 | surfaceFrame1->setAcquireFenceTime(appEndTime); |
| 1476 | |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 1477 | constexpr nsecs_t sfStartTime = std::chrono::nanoseconds(20ms).count(); |
| 1478 | constexpr nsecs_t sfEndTime = std::chrono::nanoseconds(30ms).count(); |
| 1479 | constexpr nsecs_t sfPresentTime = std::chrono::nanoseconds(30ms).count(); |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 1480 | int64_t displayFrameToken = |
| 1481 | mTokenManager->generateTokenForPredictions({sfStartTime, sfEndTime, sfPresentTime}); |
| 1482 | |
| 1483 | // First 2 cookies will be used by the DisplayFrame |
| 1484 | int64_t traceCookie = snoopCurrentTraceCookie() + 2; |
| 1485 | |
| 1486 | auto protoActualSurfaceFrameStart = |
| 1487 | createProtoActualSurfaceFrameStart(traceCookie + 1, surfaceFrameToken, |
| 1488 | displayFrameToken, sPidOne, sLayerNameOne, |
| 1489 | FrameTimelineEvent::PRESENT_UNSPECIFIED, false, |
Ady Abraham | e43ff72 | 2022-02-15 14:44:25 -0800 | [diff] [blame] | 1490 | false, FrameTimelineEvent::JANK_APP_DEADLINE_MISSED, |
Adithya Srinivasan | 1f9450c | 2021-06-10 22:39:19 +0000 | [diff] [blame] | 1491 | FrameTimelineEvent::PREDICTION_EXPIRED, true); |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 1492 | auto protoActualSurfaceFrameEnd = createProtoFrameEnd(traceCookie + 1); |
| 1493 | |
| 1494 | // Set up the display frame |
Pascal Muetschard | ac7bcd9 | 2023-10-03 15:05:36 +0200 | [diff] [blame] | 1495 | mFrameTimeline->setSfWakeUp(displayFrameToken, sfStartTime, RR_11, RR_11); |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 1496 | surfaceFrame1->setPresentState(SurfaceFrame::PresentState::Presented); |
| 1497 | mFrameTimeline->addSurfaceFrame(surfaceFrame1); |
| 1498 | mFrameTimeline->setSfPresent(sfEndTime, presentFence1); |
| 1499 | presentFence1->signalForTest(sfPresentTime); |
| 1500 | |
| 1501 | addEmptyDisplayFrame(); |
| 1502 | flushTrace(); |
| 1503 | tracingSession->StopBlocking(); |
| 1504 | |
| 1505 | auto packets = readFrameTimelinePacketsBlocking(tracingSession.get()); |
| 1506 | // Display Frame 4 packets + SurfaceFrame 2 packets |
| 1507 | ASSERT_EQ(packets.size(), 6u); |
| 1508 | |
| 1509 | // Packet - 4 : ActualSurfaceFrameStart |
| 1510 | const auto& packet4 = packets[4]; |
| 1511 | ASSERT_TRUE(packet4.has_timestamp()); |
| 1512 | EXPECT_EQ(packet4.timestamp(), |
| 1513 | static_cast<uint64_t>(appEndTime - SurfaceFrame::kPredictionExpiredStartTimeDelta)); |
| 1514 | ASSERT_TRUE(packet4.has_frame_timeline_event()); |
| 1515 | |
| 1516 | const auto& event4 = packet4.frame_timeline_event(); |
| 1517 | ASSERT_TRUE(event4.has_actual_surface_frame_start()); |
| 1518 | const auto& actualSurfaceFrameStart = event4.actual_surface_frame_start(); |
| 1519 | validateTraceEvent(actualSurfaceFrameStart, protoActualSurfaceFrameStart); |
| 1520 | |
| 1521 | // Packet - 5 : FrameEnd (ActualSurfaceFrame) |
| 1522 | const auto& packet5 = packets[5]; |
| 1523 | ASSERT_TRUE(packet5.has_timestamp()); |
| 1524 | EXPECT_EQ(packet5.timestamp(), static_cast<uint64_t>(appEndTime)); |
| 1525 | ASSERT_TRUE(packet5.has_frame_timeline_event()); |
| 1526 | |
| 1527 | const auto& event5 = packet5.frame_timeline_event(); |
| 1528 | ASSERT_TRUE(event5.has_frame_end()); |
| 1529 | const auto& actualSurfaceFrameEnd = event5.frame_end(); |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 1530 | validateTraceEvent(actualSurfaceFrameEnd, protoActualSurfaceFrameEnd); |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 1531 | } |
| 1532 | |
Adithya Srinivasan | b2283c3 | 2021-04-21 21:31:56 +0000 | [diff] [blame] | 1533 | TEST_F(FrameTimelineTest, traceSurfaceFrame_predictionExpiredDroppedFramesTracedProperly) { |
| 1534 | auto tracingSession = getTracingSessionForTest(); |
| 1535 | auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
| 1536 | |
| 1537 | tracingSession->StartBlocking(); |
| 1538 | constexpr nsecs_t appStartTime = std::chrono::nanoseconds(10ms).count(); |
| 1539 | constexpr nsecs_t appEndTime = std::chrono::nanoseconds(20ms).count(); |
| 1540 | constexpr nsecs_t appPresentTime = std::chrono::nanoseconds(30ms).count(); |
| 1541 | int64_t surfaceFrameToken = |
| 1542 | mTokenManager->generateTokenForPredictions({appStartTime, appEndTime, appPresentTime}); |
| 1543 | |
| 1544 | // Flush the token so that it would expire |
Adithya Srinivasan | bed4c4f | 2021-05-03 20:24:46 +0000 | [diff] [blame] | 1545 | flushTokens(); |
Huihong Luo | 3bdef86 | 2022-03-03 11:57:19 -0800 | [diff] [blame] | 1546 | FrameTimelineInfo ftInfo; |
| 1547 | ftInfo.vsyncId = surfaceFrameToken; |
| 1548 | ftInfo.inputEventId = 0; |
Adithya Srinivasan | b2283c3 | 2021-04-21 21:31:56 +0000 | [diff] [blame] | 1549 | auto surfaceFrame1 = |
Huihong Luo | 3bdef86 | 2022-03-03 11:57:19 -0800 | [diff] [blame] | 1550 | mFrameTimeline->createSurfaceFrameForToken(ftInfo, sPidOne, sUidOne, sLayerIdOne, |
| 1551 | sLayerNameOne, sLayerNameOne, |
| 1552 | /*isBuffer*/ true, sGameMode); |
Adithya Srinivasan | b2283c3 | 2021-04-21 21:31:56 +0000 | [diff] [blame] | 1553 | |
| 1554 | constexpr nsecs_t sfStartTime = std::chrono::nanoseconds(22ms).count(); |
| 1555 | constexpr nsecs_t sfEndTime = std::chrono::nanoseconds(30ms).count(); |
| 1556 | constexpr nsecs_t sfPresentTime = std::chrono::nanoseconds(30ms).count(); |
| 1557 | int64_t displayFrameToken = |
| 1558 | mTokenManager->generateTokenForPredictions({sfStartTime, sfEndTime, sfPresentTime}); |
| 1559 | |
| 1560 | // First 2 cookies will be used by the DisplayFrame |
| 1561 | int64_t traceCookie = snoopCurrentTraceCookie() + 2; |
| 1562 | |
| 1563 | auto protoActualSurfaceFrameStart = |
| 1564 | createProtoActualSurfaceFrameStart(traceCookie + 1, surfaceFrameToken, |
| 1565 | displayFrameToken, sPidOne, sLayerNameOne, |
| 1566 | FrameTimelineEvent::PRESENT_DROPPED, false, false, |
Edgar Arriaga | 631e425 | 2023-03-02 02:11:24 +0000 | [diff] [blame] | 1567 | FrameTimelineEvent::JANK_DROPPED, |
Adithya Srinivasan | 1f9450c | 2021-06-10 22:39:19 +0000 | [diff] [blame] | 1568 | FrameTimelineEvent::PREDICTION_EXPIRED, true); |
Adithya Srinivasan | b2283c3 | 2021-04-21 21:31:56 +0000 | [diff] [blame] | 1569 | auto protoActualSurfaceFrameEnd = createProtoFrameEnd(traceCookie + 1); |
| 1570 | |
| 1571 | // Set up the display frame |
Pascal Muetschard | ac7bcd9 | 2023-10-03 15:05:36 +0200 | [diff] [blame] | 1572 | mFrameTimeline->setSfWakeUp(displayFrameToken, sfStartTime, RR_11, RR_11); |
Adithya Srinivasan | b2283c3 | 2021-04-21 21:31:56 +0000 | [diff] [blame] | 1573 | surfaceFrame1->setDropTime(sfStartTime); |
| 1574 | surfaceFrame1->setPresentState(SurfaceFrame::PresentState::Dropped); |
| 1575 | mFrameTimeline->addSurfaceFrame(surfaceFrame1); |
| 1576 | mFrameTimeline->setSfPresent(sfEndTime, presentFence1); |
| 1577 | presentFence1->signalForTest(sfPresentTime); |
| 1578 | |
| 1579 | addEmptyDisplayFrame(); |
| 1580 | flushTrace(); |
| 1581 | tracingSession->StopBlocking(); |
| 1582 | |
| 1583 | auto packets = readFrameTimelinePacketsBlocking(tracingSession.get()); |
| 1584 | // Display Frame 4 packets + SurfaceFrame 2 packets |
| 1585 | ASSERT_EQ(packets.size(), 6u); |
| 1586 | |
| 1587 | // Packet - 4 : ActualSurfaceFrameStart |
| 1588 | const auto& packet4 = packets[4]; |
| 1589 | ASSERT_TRUE(packet4.has_timestamp()); |
| 1590 | EXPECT_EQ(packet4.timestamp(), |
| 1591 | static_cast<uint64_t>(sfStartTime - SurfaceFrame::kPredictionExpiredStartTimeDelta)); |
| 1592 | ASSERT_TRUE(packet4.has_frame_timeline_event()); |
| 1593 | |
| 1594 | const auto& event4 = packet4.frame_timeline_event(); |
| 1595 | ASSERT_TRUE(event4.has_actual_surface_frame_start()); |
| 1596 | const auto& actualSurfaceFrameStart = event4.actual_surface_frame_start(); |
| 1597 | validateTraceEvent(actualSurfaceFrameStart, protoActualSurfaceFrameStart); |
| 1598 | |
| 1599 | // Packet - 5 : FrameEnd (ActualSurfaceFrame) |
| 1600 | const auto& packet5 = packets[5]; |
| 1601 | ASSERT_TRUE(packet5.has_timestamp()); |
| 1602 | EXPECT_EQ(packet5.timestamp(), static_cast<uint64_t>(sfStartTime)); |
| 1603 | ASSERT_TRUE(packet5.has_frame_timeline_event()); |
| 1604 | |
| 1605 | const auto& event5 = packet5.frame_timeline_event(); |
| 1606 | ASSERT_TRUE(event5.has_frame_end()); |
| 1607 | const auto& actualSurfaceFrameEnd = event5.frame_end(); |
| 1608 | validateTraceEvent(actualSurfaceFrameEnd, protoActualSurfaceFrameEnd); |
| 1609 | } |
| 1610 | |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1611 | // Tests for Jank classification |
| 1612 | TEST_F(FrameTimelineTest, jankClassification_presentOnTimeDoesNotClassify) { |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1613 | // Layer specific increment |
Alec Mouri | 363faf0 | 2021-01-29 16:34:55 -0800 | [diff] [blame] | 1614 | EXPECT_CALL(*mTimeStats, incrementJankyFrames(_)); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1615 | auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
| 1616 | int64_t surfaceFrameToken = mTokenManager->generateTokenForPredictions({10, 20, 30}); |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 1617 | int64_t sfToken1 = mTokenManager->generateTokenForPredictions({22, 30, 30}); |
Huihong Luo | 3bdef86 | 2022-03-03 11:57:19 -0800 | [diff] [blame] | 1618 | FrameTimelineInfo ftInfo; |
| 1619 | ftInfo.vsyncId = surfaceFrameToken; |
| 1620 | ftInfo.inputEventId = sInputEventId; |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1621 | auto surfaceFrame = |
Huihong Luo | 3bdef86 | 2022-03-03 11:57:19 -0800 | [diff] [blame] | 1622 | mFrameTimeline->createSurfaceFrameForToken(ftInfo, sPidOne, sUidOne, sLayerIdOne, |
| 1623 | sLayerNameOne, sLayerNameOne, |
| 1624 | /*isBuffer*/ true, sGameMode); |
Pascal Muetschard | ac7bcd9 | 2023-10-03 15:05:36 +0200 | [diff] [blame] | 1625 | mFrameTimeline->setSfWakeUp(sfToken1, 22, RR_11, RR_11); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1626 | surfaceFrame->setPresentState(SurfaceFrame::PresentState::Presented); |
| 1627 | mFrameTimeline->addSurfaceFrame(surfaceFrame); |
| 1628 | mFrameTimeline->setSfPresent(26, presentFence1); |
| 1629 | auto displayFrame = getDisplayFrame(0); |
| 1630 | auto& presentedSurfaceFrame = getSurfaceFrame(0, 0); |
| 1631 | presentFence1->signalForTest(29); |
| 1632 | |
| 1633 | // Fences haven't been flushed yet, so it should be 0 |
| 1634 | EXPECT_EQ(displayFrame->getActuals().presentTime, 0); |
| 1635 | EXPECT_EQ(presentedSurfaceFrame.getActuals().presentTime, 0); |
| 1636 | |
| 1637 | addEmptyDisplayFrame(); |
| 1638 | displayFrame = getDisplayFrame(0); |
| 1639 | |
| 1640 | // Fences have flushed, so the present timestamps should be updated |
| 1641 | EXPECT_EQ(displayFrame->getActuals().presentTime, 29); |
| 1642 | EXPECT_EQ(presentedSurfaceFrame.getActuals().presentTime, 29); |
| 1643 | EXPECT_EQ(displayFrame->getFramePresentMetadata(), FramePresentMetadata::OnTimePresent); |
| 1644 | EXPECT_EQ(displayFrame->getFrameReadyMetadata(), FrameReadyMetadata::OnTimeFinish); |
| 1645 | EXPECT_EQ(displayFrame->getJankType(), JankType::None); |
| 1646 | } |
| 1647 | |
| 1648 | TEST_F(FrameTimelineTest, jankClassification_displayFrameOnTimeFinishEarlyPresent) { |
Pascal Muetschard | ac7bcd9 | 2023-10-03 15:05:36 +0200 | [diff] [blame] | 1649 | Fps vsyncRate = RR_11; |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1650 | auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 1651 | int64_t sfToken1 = mTokenManager->generateTokenForPredictions({22, 30, 40}); |
| 1652 | int64_t sfToken2 = mTokenManager->generateTokenForPredictions({52, 60, 70}); |
Pascal Muetschard | ac7bcd9 | 2023-10-03 15:05:36 +0200 | [diff] [blame] | 1653 | mFrameTimeline->setSfWakeUp(sfToken1, 22, vsyncRate, vsyncRate); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1654 | mFrameTimeline->setSfPresent(26, presentFence1); |
| 1655 | auto displayFrame = getDisplayFrame(0); |
| 1656 | presentFence1->signalForTest(30); |
| 1657 | |
| 1658 | // Fences for the first frame haven't been flushed yet, so it should be 0 |
| 1659 | EXPECT_EQ(displayFrame->getActuals().presentTime, 0); |
| 1660 | |
| 1661 | // Trigger a flush by finalizing the next DisplayFrame |
| 1662 | auto presentFence2 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
Pascal Muetschard | ac7bcd9 | 2023-10-03 15:05:36 +0200 | [diff] [blame] | 1663 | mFrameTimeline->setSfWakeUp(sfToken2, 52, vsyncRate, vsyncRate); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1664 | mFrameTimeline->setSfPresent(56, presentFence2); |
| 1665 | displayFrame = getDisplayFrame(0); |
| 1666 | |
| 1667 | // Fences for the first frame have flushed, so the present timestamps should be updated |
| 1668 | EXPECT_EQ(displayFrame->getActuals().presentTime, 30); |
| 1669 | EXPECT_EQ(displayFrame->getFramePresentMetadata(), FramePresentMetadata::EarlyPresent); |
| 1670 | EXPECT_EQ(displayFrame->getFrameReadyMetadata(), FrameReadyMetadata::OnTimeFinish); |
| 1671 | EXPECT_EQ(displayFrame->getJankType(), JankType::SurfaceFlingerScheduling); |
| 1672 | |
| 1673 | // Fences for the second frame haven't been flushed yet, so it should be 0 |
| 1674 | auto displayFrame2 = getDisplayFrame(1); |
| 1675 | presentFence2->signalForTest(65); |
| 1676 | EXPECT_EQ(displayFrame2->getActuals().presentTime, 0); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1677 | addEmptyDisplayFrame(); |
| 1678 | displayFrame2 = getDisplayFrame(1); |
| 1679 | |
| 1680 | // Fences for the second frame have flushed, so the present timestamps should be updated |
| 1681 | EXPECT_EQ(displayFrame2->getActuals().presentTime, 65); |
| 1682 | EXPECT_EQ(displayFrame2->getFramePresentMetadata(), FramePresentMetadata::EarlyPresent); |
| 1683 | EXPECT_EQ(displayFrame2->getFrameReadyMetadata(), FrameReadyMetadata::OnTimeFinish); |
| 1684 | EXPECT_EQ(displayFrame2->getJankType(), JankType::PredictionError); |
| 1685 | } |
| 1686 | |
| 1687 | TEST_F(FrameTimelineTest, jankClassification_displayFrameOnTimeFinishLatePresent) { |
Pascal Muetschard | ac7bcd9 | 2023-10-03 15:05:36 +0200 | [diff] [blame] | 1688 | Fps vsyncRate = RR_11; |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1689 | auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 1690 | int64_t sfToken1 = mTokenManager->generateTokenForPredictions({22, 30, 40}); |
| 1691 | int64_t sfToken2 = mTokenManager->generateTokenForPredictions({52, 60, 70}); |
Pascal Muetschard | ac7bcd9 | 2023-10-03 15:05:36 +0200 | [diff] [blame] | 1692 | mFrameTimeline->setSfWakeUp(sfToken1, 22, vsyncRate, vsyncRate); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1693 | mFrameTimeline->setSfPresent(26, presentFence1); |
| 1694 | auto displayFrame = getDisplayFrame(0); |
| 1695 | presentFence1->signalForTest(50); |
| 1696 | |
| 1697 | // Fences for the first frame haven't been flushed yet, so it should be 0 |
| 1698 | EXPECT_EQ(displayFrame->getActuals().presentTime, 0); |
| 1699 | |
| 1700 | // Trigger a flush by finalizing the next DisplayFrame |
| 1701 | auto presentFence2 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
Pascal Muetschard | ac7bcd9 | 2023-10-03 15:05:36 +0200 | [diff] [blame] | 1702 | mFrameTimeline->setSfWakeUp(sfToken2, 52, vsyncRate, vsyncRate); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1703 | mFrameTimeline->setSfPresent(56, presentFence2); |
| 1704 | displayFrame = getDisplayFrame(0); |
| 1705 | |
| 1706 | // Fences for the first frame have flushed, so the present timestamps should be updated |
| 1707 | EXPECT_EQ(displayFrame->getActuals().presentTime, 50); |
| 1708 | EXPECT_EQ(displayFrame->getFramePresentMetadata(), FramePresentMetadata::LatePresent); |
| 1709 | EXPECT_EQ(displayFrame->getFrameReadyMetadata(), FrameReadyMetadata::OnTimeFinish); |
| 1710 | EXPECT_EQ(displayFrame->getJankType(), JankType::DisplayHAL); |
| 1711 | |
| 1712 | // Fences for the second frame haven't been flushed yet, so it should be 0 |
| 1713 | auto displayFrame2 = getDisplayFrame(1); |
| 1714 | presentFence2->signalForTest(75); |
| 1715 | EXPECT_EQ(displayFrame2->getActuals().presentTime, 0); |
| 1716 | |
| 1717 | addEmptyDisplayFrame(); |
| 1718 | displayFrame2 = getDisplayFrame(1); |
| 1719 | |
| 1720 | // Fences for the second frame have flushed, so the present timestamps should be updated |
| 1721 | EXPECT_EQ(displayFrame2->getActuals().presentTime, 75); |
| 1722 | EXPECT_EQ(displayFrame2->getFramePresentMetadata(), FramePresentMetadata::LatePresent); |
| 1723 | EXPECT_EQ(displayFrame2->getFrameReadyMetadata(), FrameReadyMetadata::OnTimeFinish); |
| 1724 | EXPECT_EQ(displayFrame2->getJankType(), JankType::PredictionError); |
| 1725 | } |
| 1726 | |
| 1727 | TEST_F(FrameTimelineTest, jankClassification_displayFrameLateFinishEarlyPresent) { |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1728 | auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
| 1729 | int64_t sfToken1 = mTokenManager->generateTokenForPredictions({12, 18, 40}); |
Pascal Muetschard | ac7bcd9 | 2023-10-03 15:05:36 +0200 | [diff] [blame] | 1730 | mFrameTimeline->setSfWakeUp(sfToken1, 12, RR_11, RR_11); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1731 | |
| 1732 | mFrameTimeline->setSfPresent(22, presentFence1); |
| 1733 | auto displayFrame = getDisplayFrame(0); |
| 1734 | presentFence1->signalForTest(28); |
| 1735 | |
| 1736 | // Fences haven't been flushed yet, so it should be 0 |
| 1737 | EXPECT_EQ(displayFrame->getActuals().presentTime, 0); |
| 1738 | |
| 1739 | addEmptyDisplayFrame(); |
| 1740 | displayFrame = getDisplayFrame(0); |
| 1741 | |
| 1742 | // Fences have flushed, so the present timestamps should be updated |
| 1743 | EXPECT_EQ(displayFrame->getActuals().presentTime, 28); |
| 1744 | EXPECT_EQ(displayFrame->getFramePresentMetadata(), FramePresentMetadata::EarlyPresent); |
| 1745 | EXPECT_EQ(displayFrame->getFrameReadyMetadata(), FrameReadyMetadata::LateFinish); |
| 1746 | EXPECT_EQ(displayFrame->getJankType(), JankType::SurfaceFlingerScheduling); |
| 1747 | } |
| 1748 | |
| 1749 | TEST_F(FrameTimelineTest, jankClassification_displayFrameLateFinishLatePresent) { |
Adithya Srinivasan | 36b01af | 2021-04-07 22:29:47 +0000 | [diff] [blame] | 1750 | /* |
| 1751 | * Case 1 - cpu time > vsync period but combined time > deadline > deadline -> cpudeadlinemissed |
| 1752 | * Case 2 - cpu time < vsync period but combined time > deadline -> gpudeadlinemissed |
Adithya Srinivasan | 57dc81d | 2021-04-14 17:31:41 +0000 | [diff] [blame] | 1753 | * Case 3 - previous frame ran longer -> sf_stuffing |
| 1754 | * Case 4 - Long cpu under SF stuffing -> cpudeadlinemissed |
Adithya Srinivasan | 36b01af | 2021-04-07 22:29:47 +0000 | [diff] [blame] | 1755 | */ |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1756 | auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
Adithya Srinivasan | 36b01af | 2021-04-07 22:29:47 +0000 | [diff] [blame] | 1757 | auto presentFence2 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
Adithya Srinivasan | 57dc81d | 2021-04-14 17:31:41 +0000 | [diff] [blame] | 1758 | auto presentFence3 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
| 1759 | auto presentFence4 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
Adithya Srinivasan | 36b01af | 2021-04-07 22:29:47 +0000 | [diff] [blame] | 1760 | auto gpuFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
| 1761 | auto gpuFence2 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
Adithya Srinivasan | 57dc81d | 2021-04-14 17:31:41 +0000 | [diff] [blame] | 1762 | auto gpuFence3 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
| 1763 | auto gpuFence4 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1764 | int64_t sfToken1 = mTokenManager->generateTokenForPredictions({22, 26, 40}); |
Adithya Srinivasan | 36b01af | 2021-04-07 22:29:47 +0000 | [diff] [blame] | 1765 | int64_t sfToken2 = mTokenManager->generateTokenForPredictions({52, 60, 60}); |
Adithya Srinivasan | 57dc81d | 2021-04-14 17:31:41 +0000 | [diff] [blame] | 1766 | int64_t sfToken3 = mTokenManager->generateTokenForPredictions({82, 90, 90}); |
| 1767 | int64_t sfToken4 = mTokenManager->generateTokenForPredictions({112, 120, 120}); |
| 1768 | |
Adithya Srinivasan | 36b01af | 2021-04-07 22:29:47 +0000 | [diff] [blame] | 1769 | // case 1 - cpu time = 33 - 12 = 21, vsync period = 11 |
Pascal Muetschard | ac7bcd9 | 2023-10-03 15:05:36 +0200 | [diff] [blame] | 1770 | mFrameTimeline->setSfWakeUp(sfToken1, 12, RR_11, RR_11); |
Adithya Srinivasan | 36b01af | 2021-04-07 22:29:47 +0000 | [diff] [blame] | 1771 | mFrameTimeline->setSfPresent(33, presentFence1, gpuFence1); |
| 1772 | auto displayFrame0 = getDisplayFrame(0); |
| 1773 | gpuFence1->signalForTest(36); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1774 | presentFence1->signalForTest(52); |
| 1775 | |
| 1776 | // Fences haven't been flushed yet, so it should be 0 |
Adithya Srinivasan | 36b01af | 2021-04-07 22:29:47 +0000 | [diff] [blame] | 1777 | EXPECT_EQ(displayFrame0->getActuals().presentTime, 0); |
| 1778 | |
Adithya Srinivasan | 57dc81d | 2021-04-14 17:31:41 +0000 | [diff] [blame] | 1779 | // case 2 - cpu time = 56 - 52 = 4, vsync period = 30 |
Pascal Muetschard | ac7bcd9 | 2023-10-03 15:05:36 +0200 | [diff] [blame] | 1780 | mFrameTimeline->setSfWakeUp(sfToken2, 52, RR_30, RR_30); |
Adithya Srinivasan | 36b01af | 2021-04-07 22:29:47 +0000 | [diff] [blame] | 1781 | mFrameTimeline->setSfPresent(56, presentFence2, gpuFence2); |
| 1782 | auto displayFrame1 = getDisplayFrame(1); |
Adithya Srinivasan | 57dc81d | 2021-04-14 17:31:41 +0000 | [diff] [blame] | 1783 | gpuFence2->signalForTest(76); |
| 1784 | presentFence2->signalForTest(90); |
Adithya Srinivasan | 36b01af | 2021-04-07 22:29:47 +0000 | [diff] [blame] | 1785 | |
| 1786 | EXPECT_EQ(displayFrame1->getActuals().presentTime, 0); |
| 1787 | // Fences have flushed for first displayFrame, so the present timestamps should be updated |
| 1788 | EXPECT_EQ(displayFrame0->getActuals().presentTime, 52); |
| 1789 | EXPECT_EQ(displayFrame0->getFramePresentMetadata(), FramePresentMetadata::LatePresent); |
| 1790 | EXPECT_EQ(displayFrame0->getFrameReadyMetadata(), FrameReadyMetadata::LateFinish); |
Rachel Lee | 94917b3 | 2022-03-18 17:52:09 -0700 | [diff] [blame] | 1791 | EXPECT_EQ(displayFrame0->getJankType(), JankType::SurfaceFlingerGpuDeadlineMissed); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1792 | |
Adithya Srinivasan | 57dc81d | 2021-04-14 17:31:41 +0000 | [diff] [blame] | 1793 | // case 3 - cpu time = 86 - 82 = 4, vsync period = 30 |
Pascal Muetschard | ac7bcd9 | 2023-10-03 15:05:36 +0200 | [diff] [blame] | 1794 | mFrameTimeline->setSfWakeUp(sfToken3, 106, RR_30, RR_30); |
Adithya Srinivasan | 57dc81d | 2021-04-14 17:31:41 +0000 | [diff] [blame] | 1795 | mFrameTimeline->setSfPresent(112, presentFence3, gpuFence3); |
| 1796 | auto displayFrame2 = getDisplayFrame(2); |
| 1797 | gpuFence3->signalForTest(116); |
| 1798 | presentFence3->signalForTest(120); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1799 | |
Adithya Srinivasan | 57dc81d | 2021-04-14 17:31:41 +0000 | [diff] [blame] | 1800 | EXPECT_EQ(displayFrame2->getActuals().presentTime, 0); |
Adithya Srinivasan | 36b01af | 2021-04-07 22:29:47 +0000 | [diff] [blame] | 1801 | // Fences have flushed for second displayFrame, so the present timestamps should be updated |
Adithya Srinivasan | 57dc81d | 2021-04-14 17:31:41 +0000 | [diff] [blame] | 1802 | EXPECT_EQ(displayFrame1->getActuals().presentTime, 90); |
Adithya Srinivasan | 36b01af | 2021-04-07 22:29:47 +0000 | [diff] [blame] | 1803 | EXPECT_EQ(displayFrame1->getFramePresentMetadata(), FramePresentMetadata::LatePresent); |
| 1804 | EXPECT_EQ(displayFrame1->getFrameReadyMetadata(), FrameReadyMetadata::LateFinish); |
| 1805 | EXPECT_EQ(displayFrame1->getJankType(), JankType::SurfaceFlingerGpuDeadlineMissed); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1806 | |
Adithya Srinivasan | 57dc81d | 2021-04-14 17:31:41 +0000 | [diff] [blame] | 1807 | // case 4 - cpu time = 86 - 82 = 4, vsync period = 30 |
Pascal Muetschard | ac7bcd9 | 2023-10-03 15:05:36 +0200 | [diff] [blame] | 1808 | mFrameTimeline->setSfWakeUp(sfToken4, 120, RR_30, RR_30); |
Adithya Srinivasan | 57dc81d | 2021-04-14 17:31:41 +0000 | [diff] [blame] | 1809 | mFrameTimeline->setSfPresent(140, presentFence4, gpuFence4); |
| 1810 | auto displayFrame3 = getDisplayFrame(3); |
| 1811 | gpuFence4->signalForTest(156); |
| 1812 | presentFence4->signalForTest(180); |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 1813 | |
Adithya Srinivasan | 57dc81d | 2021-04-14 17:31:41 +0000 | [diff] [blame] | 1814 | EXPECT_EQ(displayFrame3->getActuals().presentTime, 0); |
| 1815 | // Fences have flushed for third displayFrame, so the present timestamps should be updated |
| 1816 | EXPECT_EQ(displayFrame2->getActuals().presentTime, 120); |
| 1817 | EXPECT_EQ(displayFrame2->getFramePresentMetadata(), FramePresentMetadata::LatePresent); |
| 1818 | EXPECT_EQ(displayFrame2->getFrameReadyMetadata(), FrameReadyMetadata::LateFinish); |
| 1819 | EXPECT_EQ(displayFrame2->getJankType(), JankType::SurfaceFlingerStuffing); |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 1820 | |
| 1821 | addEmptyDisplayFrame(); |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 1822 | |
Adithya Srinivasan | 57dc81d | 2021-04-14 17:31:41 +0000 | [diff] [blame] | 1823 | // Fences have flushed for third displayFrame, so the present timestamps should be updated |
| 1824 | EXPECT_EQ(displayFrame3->getActuals().presentTime, 180); |
| 1825 | EXPECT_EQ(displayFrame3->getFramePresentMetadata(), FramePresentMetadata::LatePresent); |
| 1826 | EXPECT_EQ(displayFrame3->getFrameReadyMetadata(), FrameReadyMetadata::LateFinish); |
| 1827 | EXPECT_EQ(displayFrame3->getJankType(), JankType::SurfaceFlingerGpuDeadlineMissed); |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 1828 | } |
| 1829 | |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1830 | TEST_F(FrameTimelineTest, jankClassification_surfaceFrameOnTimeFinishEarlyPresent) { |
Alec Mouri | 363faf0 | 2021-01-29 16:34:55 -0800 | [diff] [blame] | 1831 | EXPECT_CALL(*mTimeStats, incrementJankyFrames(_)); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1832 | auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 1833 | int64_t sfToken1 = mTokenManager->generateTokenForPredictions({22, 30, 40}); |
| 1834 | int64_t sfToken2 = mTokenManager->generateTokenForPredictions({52, 60, 70}); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1835 | int64_t surfaceFrameToken1 = mTokenManager->generateTokenForPredictions({5, 16, 40}); |
| 1836 | int64_t surfaceFrameToken2 = mTokenManager->generateTokenForPredictions({25, 36, 70}); |
Huihong Luo | 3bdef86 | 2022-03-03 11:57:19 -0800 | [diff] [blame] | 1837 | FrameTimelineInfo ftInfo; |
| 1838 | ftInfo.vsyncId = surfaceFrameToken1; |
| 1839 | ftInfo.inputEventId = sInputEventId; |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1840 | auto surfaceFrame1 = |
Huihong Luo | 3bdef86 | 2022-03-03 11:57:19 -0800 | [diff] [blame] | 1841 | mFrameTimeline->createSurfaceFrameForToken(ftInfo, sPidOne, sUidOne, sLayerIdOne, |
| 1842 | sLayerNameOne, sLayerNameOne, |
| 1843 | /*isBuffer*/ true, sGameMode); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1844 | surfaceFrame1->setAcquireFenceTime(16); |
Pascal Muetschard | ac7bcd9 | 2023-10-03 15:05:36 +0200 | [diff] [blame] | 1845 | mFrameTimeline->setSfWakeUp(sfToken1, 22, RR_11, RR_11); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1846 | surfaceFrame1->setPresentState(SurfaceFrame::PresentState::Presented); |
| 1847 | mFrameTimeline->addSurfaceFrame(surfaceFrame1); |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 1848 | mFrameTimeline->setSfPresent(27, presentFence1); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1849 | auto displayFrame1 = getDisplayFrame(0); |
| 1850 | auto& presentedSurfaceFrame1 = getSurfaceFrame(0, 0); |
| 1851 | presentFence1->signalForTest(30); |
| 1852 | |
| 1853 | // Fences for the first frame haven't been flushed yet, so it should be 0 |
| 1854 | EXPECT_EQ(displayFrame1->getActuals().presentTime, 0); |
| 1855 | auto actuals1 = presentedSurfaceFrame1.getActuals(); |
| 1856 | EXPECT_EQ(actuals1.presentTime, 0); |
| 1857 | |
| 1858 | // Trigger a flush by finalizing the next DisplayFrame |
| 1859 | auto presentFence2 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
Huihong Luo | 3bdef86 | 2022-03-03 11:57:19 -0800 | [diff] [blame] | 1860 | FrameTimelineInfo ftInfo2; |
| 1861 | ftInfo2.vsyncId = surfaceFrameToken2; |
| 1862 | ftInfo2.inputEventId = sInputEventId; |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1863 | auto surfaceFrame2 = |
Huihong Luo | 3bdef86 | 2022-03-03 11:57:19 -0800 | [diff] [blame] | 1864 | mFrameTimeline->createSurfaceFrameForToken(ftInfo2, sPidOne, sUidOne, sLayerIdOne, |
| 1865 | sLayerNameOne, sLayerNameOne, |
| 1866 | /*isBuffer*/ true, sGameMode); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1867 | surfaceFrame2->setAcquireFenceTime(36); |
Pascal Muetschard | ac7bcd9 | 2023-10-03 15:05:36 +0200 | [diff] [blame] | 1868 | mFrameTimeline->setSfWakeUp(sfToken2, 52, RR_11, RR_11); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1869 | surfaceFrame2->setPresentState(SurfaceFrame::PresentState::Presented); |
| 1870 | mFrameTimeline->addSurfaceFrame(surfaceFrame2); |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 1871 | mFrameTimeline->setSfPresent(57, presentFence2); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1872 | auto displayFrame2 = getDisplayFrame(1); |
| 1873 | auto& presentedSurfaceFrame2 = getSurfaceFrame(1, 0); |
| 1874 | |
| 1875 | // Fences for the first frame have flushed, so the present timestamps should be updated |
| 1876 | EXPECT_EQ(displayFrame1->getActuals().presentTime, 30); |
| 1877 | EXPECT_EQ(displayFrame1->getFramePresentMetadata(), FramePresentMetadata::EarlyPresent); |
| 1878 | EXPECT_EQ(displayFrame1->getFrameReadyMetadata(), FrameReadyMetadata::OnTimeFinish); |
| 1879 | EXPECT_EQ(displayFrame1->getJankType(), JankType::SurfaceFlingerScheduling); |
| 1880 | |
| 1881 | actuals1 = presentedSurfaceFrame1.getActuals(); |
| 1882 | EXPECT_EQ(actuals1.presentTime, 30); |
| 1883 | EXPECT_EQ(presentedSurfaceFrame1.getFramePresentMetadata(), FramePresentMetadata::EarlyPresent); |
| 1884 | EXPECT_EQ(presentedSurfaceFrame1.getFrameReadyMetadata(), FrameReadyMetadata::OnTimeFinish); |
| 1885 | EXPECT_EQ(presentedSurfaceFrame1.getJankType(), JankType::SurfaceFlingerScheduling); |
| 1886 | |
| 1887 | // Fences for the second frame haven't been flushed yet, so it should be 0 |
| 1888 | presentFence2->signalForTest(65); |
| 1889 | EXPECT_EQ(displayFrame2->getActuals().presentTime, 0); |
| 1890 | auto actuals2 = presentedSurfaceFrame2.getActuals(); |
| 1891 | EXPECT_EQ(actuals2.presentTime, 0); |
| 1892 | |
Alec Mouri | 363faf0 | 2021-01-29 16:34:55 -0800 | [diff] [blame] | 1893 | ::testing::Mock::VerifyAndClearExpectations(mTimeStats.get()); |
| 1894 | |
| 1895 | EXPECT_CALL(*mTimeStats, |
Pascal Muetschard | ac7bcd9 | 2023-10-03 15:05:36 +0200 | [diff] [blame] | 1896 | incrementJankyFrames(TimeStats::JankyFramesInfo{RR_11, std::nullopt, sUidOne, |
| 1897 | sLayerNameOne, sGameMode, |
| 1898 | JankType::PredictionError, -3, 5, |
| 1899 | 0})); |
Alec Mouri | 363faf0 | 2021-01-29 16:34:55 -0800 | [diff] [blame] | 1900 | |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1901 | addEmptyDisplayFrame(); |
| 1902 | |
| 1903 | // Fences for the second frame have flushed, so the present timestamps should be updated |
| 1904 | EXPECT_EQ(displayFrame2->getActuals().presentTime, 65); |
| 1905 | EXPECT_EQ(displayFrame2->getFramePresentMetadata(), FramePresentMetadata::EarlyPresent); |
| 1906 | EXPECT_EQ(displayFrame2->getFrameReadyMetadata(), FrameReadyMetadata::OnTimeFinish); |
| 1907 | EXPECT_EQ(displayFrame2->getJankType(), JankType::PredictionError); |
| 1908 | |
| 1909 | actuals2 = presentedSurfaceFrame2.getActuals(); |
| 1910 | EXPECT_EQ(actuals2.presentTime, 65); |
| 1911 | EXPECT_EQ(presentedSurfaceFrame2.getFramePresentMetadata(), FramePresentMetadata::EarlyPresent); |
| 1912 | EXPECT_EQ(presentedSurfaceFrame2.getFrameReadyMetadata(), FrameReadyMetadata::OnTimeFinish); |
| 1913 | EXPECT_EQ(presentedSurfaceFrame2.getJankType(), JankType::PredictionError); |
| 1914 | } |
| 1915 | |
| 1916 | TEST_F(FrameTimelineTest, jankClassification_surfaceFrameOnTimeFinishLatePresent) { |
Alec Mouri | 363faf0 | 2021-01-29 16:34:55 -0800 | [diff] [blame] | 1917 | EXPECT_CALL(*mTimeStats, incrementJankyFrames(_)); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1918 | auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 1919 | int64_t sfToken1 = mTokenManager->generateTokenForPredictions({22, 30, 40}); |
| 1920 | int64_t sfToken2 = mTokenManager->generateTokenForPredictions({52, 60, 70}); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1921 | int64_t surfaceFrameToken1 = mTokenManager->generateTokenForPredictions({5, 16, 40}); |
| 1922 | int64_t surfaceFrameToken2 = mTokenManager->generateTokenForPredictions({25, 36, 70}); |
Huihong Luo | 3bdef86 | 2022-03-03 11:57:19 -0800 | [diff] [blame] | 1923 | FrameTimelineInfo ftInfo; |
| 1924 | ftInfo.vsyncId = surfaceFrameToken1; |
| 1925 | ftInfo.inputEventId = sInputEventId; |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1926 | auto surfaceFrame1 = |
Huihong Luo | 3bdef86 | 2022-03-03 11:57:19 -0800 | [diff] [blame] | 1927 | mFrameTimeline->createSurfaceFrameForToken(ftInfo, sPidOne, sUidOne, sLayerIdOne, |
| 1928 | sLayerNameOne, sLayerNameOne, |
| 1929 | /*isBuffer*/ true, sGameMode); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1930 | surfaceFrame1->setAcquireFenceTime(16); |
Pascal Muetschard | ac7bcd9 | 2023-10-03 15:05:36 +0200 | [diff] [blame] | 1931 | mFrameTimeline->setSfWakeUp(sfToken1, 22, RR_11, RR_11); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1932 | surfaceFrame1->setPresentState(SurfaceFrame::PresentState::Presented); |
| 1933 | mFrameTimeline->addSurfaceFrame(surfaceFrame1); |
| 1934 | mFrameTimeline->setSfPresent(26, presentFence1); |
| 1935 | auto displayFrame1 = getDisplayFrame(0); |
| 1936 | auto& presentedSurfaceFrame1 = getSurfaceFrame(0, 0); |
| 1937 | presentFence1->signalForTest(50); |
| 1938 | |
| 1939 | // Fences for the first frame haven't been flushed yet, so it should be 0 |
| 1940 | EXPECT_EQ(displayFrame1->getActuals().presentTime, 0); |
| 1941 | auto actuals1 = presentedSurfaceFrame1.getActuals(); |
| 1942 | EXPECT_EQ(actuals1.presentTime, 0); |
| 1943 | |
| 1944 | // Trigger a flush by finalizing the next DisplayFrame |
| 1945 | auto presentFence2 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
Huihong Luo | 3bdef86 | 2022-03-03 11:57:19 -0800 | [diff] [blame] | 1946 | FrameTimelineInfo ftInfo2; |
| 1947 | ftInfo2.vsyncId = surfaceFrameToken2; |
| 1948 | ftInfo2.inputEventId = sInputEventId; |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1949 | auto surfaceFrame2 = |
Huihong Luo | 3bdef86 | 2022-03-03 11:57:19 -0800 | [diff] [blame] | 1950 | mFrameTimeline->createSurfaceFrameForToken(ftInfo2, sPidOne, sUidOne, sLayerIdOne, |
| 1951 | sLayerNameOne, sLayerNameOne, |
| 1952 | /*isBuffer*/ true, sGameMode); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1953 | surfaceFrame2->setAcquireFenceTime(36); |
Pascal Muetschard | ac7bcd9 | 2023-10-03 15:05:36 +0200 | [diff] [blame] | 1954 | mFrameTimeline->setSfWakeUp(sfToken2, 52, RR_11, RR_11); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1955 | surfaceFrame2->setPresentState(SurfaceFrame::PresentState::Presented); |
| 1956 | mFrameTimeline->addSurfaceFrame(surfaceFrame2); |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 1957 | mFrameTimeline->setSfPresent(57, presentFence2); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1958 | auto displayFrame2 = getDisplayFrame(1); |
| 1959 | auto& presentedSurfaceFrame2 = getSurfaceFrame(1, 0); |
| 1960 | |
| 1961 | // Fences for the first frame have flushed, so the present timestamps should be updated |
| 1962 | EXPECT_EQ(displayFrame1->getActuals().presentTime, 50); |
| 1963 | EXPECT_EQ(displayFrame1->getFramePresentMetadata(), FramePresentMetadata::LatePresent); |
| 1964 | EXPECT_EQ(displayFrame1->getFrameReadyMetadata(), FrameReadyMetadata::OnTimeFinish); |
| 1965 | EXPECT_EQ(displayFrame1->getJankType(), JankType::DisplayHAL); |
| 1966 | |
| 1967 | actuals1 = presentedSurfaceFrame1.getActuals(); |
| 1968 | EXPECT_EQ(actuals1.presentTime, 50); |
| 1969 | EXPECT_EQ(presentedSurfaceFrame1.getFramePresentMetadata(), FramePresentMetadata::LatePresent); |
| 1970 | EXPECT_EQ(presentedSurfaceFrame1.getFrameReadyMetadata(), FrameReadyMetadata::OnTimeFinish); |
| 1971 | EXPECT_EQ(presentedSurfaceFrame1.getJankType(), JankType::DisplayHAL); |
| 1972 | |
| 1973 | // Fences for the second frame haven't been flushed yet, so it should be 0 |
| 1974 | presentFence2->signalForTest(86); |
| 1975 | EXPECT_EQ(displayFrame2->getActuals().presentTime, 0); |
| 1976 | auto actuals2 = presentedSurfaceFrame2.getActuals(); |
| 1977 | EXPECT_EQ(actuals2.presentTime, 0); |
| 1978 | |
Alec Mouri | 363faf0 | 2021-01-29 16:34:55 -0800 | [diff] [blame] | 1979 | ::testing::Mock::VerifyAndClearExpectations(mTimeStats.get()); |
| 1980 | |
| 1981 | EXPECT_CALL(*mTimeStats, |
Pascal Muetschard | ac7bcd9 | 2023-10-03 15:05:36 +0200 | [diff] [blame] | 1982 | incrementJankyFrames(TimeStats::JankyFramesInfo{RR_11, std::nullopt, sUidOne, |
| 1983 | sLayerNameOne, sGameMode, |
| 1984 | JankType::PredictionError, -3, 5, |
| 1985 | 0})); |
Alec Mouri | 363faf0 | 2021-01-29 16:34:55 -0800 | [diff] [blame] | 1986 | |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1987 | addEmptyDisplayFrame(); |
| 1988 | |
| 1989 | // Fences for the second frame have flushed, so the present timestamps should be updated |
| 1990 | EXPECT_EQ(displayFrame2->getActuals().presentTime, 86); |
| 1991 | EXPECT_EQ(displayFrame2->getFramePresentMetadata(), FramePresentMetadata::LatePresent); |
| 1992 | EXPECT_EQ(displayFrame2->getFrameReadyMetadata(), FrameReadyMetadata::OnTimeFinish); |
| 1993 | EXPECT_EQ(displayFrame2->getJankType(), JankType::PredictionError); |
| 1994 | |
| 1995 | actuals2 = presentedSurfaceFrame2.getActuals(); |
| 1996 | EXPECT_EQ(actuals2.presentTime, 86); |
| 1997 | EXPECT_EQ(presentedSurfaceFrame2.getFramePresentMetadata(), FramePresentMetadata::LatePresent); |
| 1998 | EXPECT_EQ(presentedSurfaceFrame2.getFrameReadyMetadata(), FrameReadyMetadata::OnTimeFinish); |
| 1999 | EXPECT_EQ(presentedSurfaceFrame2.getJankType(), JankType::PredictionError); |
| 2000 | } |
| 2001 | |
| 2002 | TEST_F(FrameTimelineTest, jankClassification_surfaceFrameLateFinishEarlyPresent) { |
Alec Mouri | 363faf0 | 2021-01-29 16:34:55 -0800 | [diff] [blame] | 2003 | EXPECT_CALL(*mTimeStats, incrementJankyFrames(_)); |
Alec Mouri | 7d436ec | 2021-01-27 20:40:50 -0800 | [diff] [blame] | 2004 | |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 2005 | auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 2006 | int64_t sfToken1 = mTokenManager->generateTokenForPredictions({42, 50, 50}); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 2007 | int64_t surfaceFrameToken1 = mTokenManager->generateTokenForPredictions({5, 26, 60}); |
Huihong Luo | 3bdef86 | 2022-03-03 11:57:19 -0800 | [diff] [blame] | 2008 | FrameTimelineInfo ftInfo; |
| 2009 | ftInfo.vsyncId = surfaceFrameToken1; |
| 2010 | ftInfo.inputEventId = sInputEventId; |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 2011 | auto surfaceFrame1 = |
Huihong Luo | 3bdef86 | 2022-03-03 11:57:19 -0800 | [diff] [blame] | 2012 | mFrameTimeline->createSurfaceFrameForToken(ftInfo, sPidOne, sUidOne, sLayerIdOne, |
| 2013 | sLayerNameOne, sLayerNameOne, |
| 2014 | /*isBuffer*/ true, sGameMode); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 2015 | surfaceFrame1->setAcquireFenceTime(40); |
Pascal Muetschard | ac7bcd9 | 2023-10-03 15:05:36 +0200 | [diff] [blame] | 2016 | mFrameTimeline->setSfWakeUp(sfToken1, 42, RR_11, RR_11); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 2017 | surfaceFrame1->setPresentState(SurfaceFrame::PresentState::Presented); |
| 2018 | mFrameTimeline->addSurfaceFrame(surfaceFrame1); |
| 2019 | mFrameTimeline->setSfPresent(46, presentFence1); |
| 2020 | auto displayFrame1 = getDisplayFrame(0); |
| 2021 | auto& presentedSurfaceFrame1 = getSurfaceFrame(0, 0); |
| 2022 | presentFence1->signalForTest(50); |
| 2023 | |
| 2024 | // Fences for the first frame haven't been flushed yet, so it should be 0 |
| 2025 | EXPECT_EQ(displayFrame1->getActuals().presentTime, 0); |
| 2026 | auto actuals1 = presentedSurfaceFrame1.getActuals(); |
| 2027 | EXPECT_EQ(actuals1.presentTime, 0); |
| 2028 | |
| 2029 | addEmptyDisplayFrame(); |
| 2030 | |
| 2031 | // Fences for the first frame have flushed, so the present timestamps should be updated |
| 2032 | EXPECT_EQ(displayFrame1->getActuals().presentTime, 50); |
| 2033 | EXPECT_EQ(displayFrame1->getFramePresentMetadata(), FramePresentMetadata::OnTimePresent); |
| 2034 | EXPECT_EQ(displayFrame1->getFrameReadyMetadata(), FrameReadyMetadata::OnTimeFinish); |
| 2035 | EXPECT_EQ(displayFrame1->getJankType(), JankType::None); |
| 2036 | |
| 2037 | actuals1 = presentedSurfaceFrame1.getActuals(); |
| 2038 | EXPECT_EQ(actuals1.presentTime, 50); |
| 2039 | EXPECT_EQ(presentedSurfaceFrame1.getFramePresentMetadata(), FramePresentMetadata::EarlyPresent); |
| 2040 | EXPECT_EQ(presentedSurfaceFrame1.getFrameReadyMetadata(), FrameReadyMetadata::LateFinish); |
| 2041 | EXPECT_EQ(presentedSurfaceFrame1.getJankType(), JankType::Unknown); |
| 2042 | } |
| 2043 | |
| 2044 | TEST_F(FrameTimelineTest, jankClassification_surfaceFrameLateFinishLatePresent) { |
Adithya Srinivasan | 8a94550 | 2021-03-19 19:12:32 +0000 | [diff] [blame] | 2045 | // First frame - DisplayFrame is not janky. This should classify the SurfaceFrame as only |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 2046 | // AppDeadlineMissed. Second frame - DisplayFrame is janky. This should propagate DisplayFrame's |
Adithya Srinivasan | 8a94550 | 2021-03-19 19:12:32 +0000 | [diff] [blame] | 2047 | // jank to the SurfaceFrame along with AppDeadlineMissed. |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 2048 | |
Alec Mouri | 363faf0 | 2021-01-29 16:34:55 -0800 | [diff] [blame] | 2049 | EXPECT_CALL(*mTimeStats, incrementJankyFrames(_)).Times(2); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 2050 | auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 2051 | int64_t sfToken1 = mTokenManager->generateTokenForPredictions({32, 40, 40}); |
| 2052 | int64_t sfToken2 = mTokenManager->generateTokenForPredictions({42, 50, 50}); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 2053 | int64_t surfaceFrameToken1 = mTokenManager->generateTokenForPredictions({5, 16, 30}); |
| 2054 | int64_t surfaceFrameToken2 = mTokenManager->generateTokenForPredictions({25, 36, 50}); |
Huihong Luo | 3bdef86 | 2022-03-03 11:57:19 -0800 | [diff] [blame] | 2055 | FrameTimelineInfo ftInfo; |
| 2056 | ftInfo.vsyncId = surfaceFrameToken1; |
| 2057 | ftInfo.inputEventId = sInputEventId; |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 2058 | auto surfaceFrame1 = |
Huihong Luo | 3bdef86 | 2022-03-03 11:57:19 -0800 | [diff] [blame] | 2059 | mFrameTimeline->createSurfaceFrameForToken(ftInfo, sPidOne, sUidOne, sLayerIdOne, |
| 2060 | sLayerNameOne, sLayerNameOne, |
| 2061 | /*isBuffer*/ true, sGameMode); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 2062 | surfaceFrame1->setAcquireFenceTime(26); |
Pascal Muetschard | ac7bcd9 | 2023-10-03 15:05:36 +0200 | [diff] [blame] | 2063 | mFrameTimeline->setSfWakeUp(sfToken1, 32, RR_11, RR_11); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 2064 | surfaceFrame1->setPresentState(SurfaceFrame::PresentState::Presented); |
| 2065 | mFrameTimeline->addSurfaceFrame(surfaceFrame1); |
| 2066 | mFrameTimeline->setSfPresent(36, presentFence1); |
| 2067 | auto displayFrame1 = getDisplayFrame(0); |
| 2068 | auto& presentedSurfaceFrame1 = getSurfaceFrame(0, 0); |
| 2069 | presentFence1->signalForTest(40); |
| 2070 | |
| 2071 | // Fences for the first frame haven't been flushed yet, so it should be 0 |
| 2072 | EXPECT_EQ(displayFrame1->getActuals().presentTime, 0); |
| 2073 | auto actuals1 = presentedSurfaceFrame1.getActuals(); |
| 2074 | EXPECT_EQ(actuals1.presentTime, 0); |
| 2075 | |
| 2076 | // Trigger a flush by finalizing the next DisplayFrame |
| 2077 | auto presentFence2 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
Huihong Luo | 3bdef86 | 2022-03-03 11:57:19 -0800 | [diff] [blame] | 2078 | FrameTimelineInfo ftInfo2; |
| 2079 | ftInfo2.vsyncId = surfaceFrameToken2; |
| 2080 | ftInfo2.inputEventId = sInputEventId; |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 2081 | auto surfaceFrame2 = |
Huihong Luo | 3bdef86 | 2022-03-03 11:57:19 -0800 | [diff] [blame] | 2082 | mFrameTimeline->createSurfaceFrameForToken(ftInfo2, sPidOne, sUidOne, sLayerIdOne, |
| 2083 | sLayerNameOne, sLayerNameOne, |
| 2084 | /*isBuffer*/ true, sGameMode); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 2085 | surfaceFrame2->setAcquireFenceTime(40); |
Pascal Muetschard | ac7bcd9 | 2023-10-03 15:05:36 +0200 | [diff] [blame] | 2086 | mFrameTimeline->setSfWakeUp(sfToken2, 43, RR_11, RR_11); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 2087 | surfaceFrame2->setPresentState(SurfaceFrame::PresentState::Presented); |
| 2088 | mFrameTimeline->addSurfaceFrame(surfaceFrame2); |
| 2089 | mFrameTimeline->setSfPresent(56, presentFence2); |
| 2090 | auto displayFrame2 = getDisplayFrame(1); |
| 2091 | auto& presentedSurfaceFrame2 = getSurfaceFrame(1, 0); |
| 2092 | |
| 2093 | // Fences for the first frame have flushed, so the present timestamps should be updated |
| 2094 | EXPECT_EQ(displayFrame1->getActuals().presentTime, 40); |
| 2095 | EXPECT_EQ(displayFrame1->getFramePresentMetadata(), FramePresentMetadata::OnTimePresent); |
| 2096 | EXPECT_EQ(displayFrame1->getFrameReadyMetadata(), FrameReadyMetadata::OnTimeFinish); |
| 2097 | EXPECT_EQ(displayFrame1->getJankType(), JankType::None); |
| 2098 | |
| 2099 | actuals1 = presentedSurfaceFrame1.getActuals(); |
| 2100 | EXPECT_EQ(actuals1.presentTime, 40); |
| 2101 | EXPECT_EQ(presentedSurfaceFrame1.getFramePresentMetadata(), FramePresentMetadata::LatePresent); |
| 2102 | EXPECT_EQ(presentedSurfaceFrame1.getFrameReadyMetadata(), FrameReadyMetadata::LateFinish); |
| 2103 | EXPECT_EQ(presentedSurfaceFrame1.getJankType(), JankType::AppDeadlineMissed); |
| 2104 | |
| 2105 | // Fences for the second frame haven't been flushed yet, so it should be 0 |
| 2106 | presentFence2->signalForTest(60); |
| 2107 | EXPECT_EQ(displayFrame2->getActuals().presentTime, 0); |
| 2108 | auto actuals2 = presentedSurfaceFrame2.getActuals(); |
| 2109 | EXPECT_EQ(actuals2.presentTime, 0); |
| 2110 | |
| 2111 | addEmptyDisplayFrame(); |
| 2112 | |
| 2113 | // Fences for the second frame have flushed, so the present timestamps should be updated |
| 2114 | EXPECT_EQ(displayFrame2->getActuals().presentTime, 60); |
| 2115 | EXPECT_EQ(displayFrame2->getFramePresentMetadata(), FramePresentMetadata::LatePresent); |
| 2116 | EXPECT_EQ(displayFrame2->getFrameReadyMetadata(), FrameReadyMetadata::LateFinish); |
| 2117 | EXPECT_EQ(displayFrame2->getJankType(), JankType::SurfaceFlingerCpuDeadlineMissed); |
| 2118 | |
| 2119 | actuals2 = presentedSurfaceFrame2.getActuals(); |
| 2120 | EXPECT_EQ(actuals2.presentTime, 60); |
| 2121 | EXPECT_EQ(presentedSurfaceFrame2.getFramePresentMetadata(), FramePresentMetadata::LatePresent); |
| 2122 | EXPECT_EQ(presentedSurfaceFrame2.getFrameReadyMetadata(), FrameReadyMetadata::LateFinish); |
Adithya Srinivasan | 8a94550 | 2021-03-19 19:12:32 +0000 | [diff] [blame] | 2123 | EXPECT_EQ(presentedSurfaceFrame2.getJankType(), |
| 2124 | JankType::SurfaceFlingerCpuDeadlineMissed | JankType::AppDeadlineMissed); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 2125 | } |
| 2126 | |
| 2127 | TEST_F(FrameTimelineTest, jankClassification_multiJankBufferStuffingAndAppDeadlineMissed) { |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 2128 | // Layer specific increment |
Alec Mouri | 363faf0 | 2021-01-29 16:34:55 -0800 | [diff] [blame] | 2129 | EXPECT_CALL(*mTimeStats, incrementJankyFrames(_)).Times(2); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 2130 | auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
| 2131 | int64_t surfaceFrameToken1 = mTokenManager->generateTokenForPredictions({10, 20, 30}); |
| 2132 | int64_t surfaceFrameToken2 = mTokenManager->generateTokenForPredictions({40, 50, 60}); |
| 2133 | |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 2134 | int64_t sfToken1 = mTokenManager->generateTokenForPredictions({52, 60, 60}); |
| 2135 | int64_t sfToken2 = mTokenManager->generateTokenForPredictions({112, 120, 120}); |
Huihong Luo | 3bdef86 | 2022-03-03 11:57:19 -0800 | [diff] [blame] | 2136 | FrameTimelineInfo ftInfo; |
| 2137 | ftInfo.vsyncId = surfaceFrameToken1; |
| 2138 | ftInfo.inputEventId = sInputEventId; |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 2139 | auto surfaceFrame1 = |
Huihong Luo | 3bdef86 | 2022-03-03 11:57:19 -0800 | [diff] [blame] | 2140 | mFrameTimeline->createSurfaceFrameForToken(ftInfo, sPidOne, sUidOne, sLayerIdOne, |
| 2141 | sLayerNameOne, sLayerNameOne, |
| 2142 | /*isBuffer*/ true, sGameMode); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 2143 | surfaceFrame1->setAcquireFenceTime(50); |
Pascal Muetschard | ac7bcd9 | 2023-10-03 15:05:36 +0200 | [diff] [blame] | 2144 | mFrameTimeline->setSfWakeUp(sfToken1, 52, RR_30, RR_30); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 2145 | surfaceFrame1->setPresentState(SurfaceFrame::PresentState::Presented); |
| 2146 | mFrameTimeline->addSurfaceFrame(surfaceFrame1); |
| 2147 | mFrameTimeline->setSfPresent(56, presentFence1); |
| 2148 | auto displayFrame1 = getDisplayFrame(0); |
| 2149 | auto& presentedSurfaceFrame1 = getSurfaceFrame(0, 0); |
| 2150 | presentFence1->signalForTest(60); |
| 2151 | |
| 2152 | // Fences for the first frame haven't been flushed yet, so it should be 0 |
| 2153 | EXPECT_EQ(displayFrame1->getActuals().presentTime, 0); |
| 2154 | auto actuals1 = presentedSurfaceFrame1.getActuals(); |
| 2155 | EXPECT_EQ(actuals1.presentTime, 0); |
| 2156 | |
| 2157 | // Trigger a flush by finalizing the next DisplayFrame |
| 2158 | auto presentFence2 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
Huihong Luo | 3bdef86 | 2022-03-03 11:57:19 -0800 | [diff] [blame] | 2159 | FrameTimelineInfo ftInfo2; |
| 2160 | ftInfo2.vsyncId = surfaceFrameToken2; |
| 2161 | ftInfo2.inputEventId = sInputEventId; |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 2162 | auto surfaceFrame2 = |
Huihong Luo | 3bdef86 | 2022-03-03 11:57:19 -0800 | [diff] [blame] | 2163 | mFrameTimeline->createSurfaceFrameForToken(ftInfo2, sPidOne, sUidOne, sLayerIdOne, |
| 2164 | sLayerNameOne, sLayerNameOne, |
| 2165 | /*isBuffer*/ true, sGameMode); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 2166 | surfaceFrame2->setAcquireFenceTime(84); |
Pascal Muetschard | ac7bcd9 | 2023-10-03 15:05:36 +0200 | [diff] [blame] | 2167 | mFrameTimeline->setSfWakeUp(sfToken2, 112, RR_30, RR_30); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 2168 | surfaceFrame2->setPresentState(SurfaceFrame::PresentState::Presented, 54); |
| 2169 | mFrameTimeline->addSurfaceFrame(surfaceFrame2); |
| 2170 | mFrameTimeline->setSfPresent(116, presentFence2); |
| 2171 | auto displayFrame2 = getDisplayFrame(1); |
| 2172 | auto& presentedSurfaceFrame2 = getSurfaceFrame(1, 0); |
| 2173 | presentFence2->signalForTest(120); |
| 2174 | |
| 2175 | // Fences for the first frame have flushed, so the present timestamps should be updated |
| 2176 | EXPECT_EQ(displayFrame1->getActuals().presentTime, 60); |
| 2177 | actuals1 = presentedSurfaceFrame1.getActuals(); |
| 2178 | EXPECT_EQ(actuals1.endTime, 50); |
| 2179 | EXPECT_EQ(actuals1.presentTime, 60); |
| 2180 | |
| 2181 | EXPECT_EQ(displayFrame1->getFramePresentMetadata(), FramePresentMetadata::OnTimePresent); |
| 2182 | EXPECT_EQ(displayFrame1->getFrameReadyMetadata(), FrameReadyMetadata::OnTimeFinish); |
| 2183 | EXPECT_EQ(displayFrame1->getJankType(), JankType::None); |
| 2184 | |
| 2185 | EXPECT_EQ(presentedSurfaceFrame1.getFramePresentMetadata(), FramePresentMetadata::LatePresent); |
| 2186 | EXPECT_EQ(presentedSurfaceFrame1.getFrameReadyMetadata(), FrameReadyMetadata::LateFinish); |
| 2187 | EXPECT_EQ(presentedSurfaceFrame1.getJankType(), JankType::AppDeadlineMissed); |
| 2188 | |
| 2189 | // Fences for the second frame haven't been flushed yet, so it should be 0 |
| 2190 | EXPECT_EQ(displayFrame2->getActuals().presentTime, 0); |
| 2191 | auto actuals2 = presentedSurfaceFrame2.getActuals(); |
| 2192 | EXPECT_EQ(actuals2.presentTime, 0); |
| 2193 | |
| 2194 | addEmptyDisplayFrame(); |
| 2195 | |
| 2196 | // Fences for the second frame have flushed, so the present timestamps should be updated |
| 2197 | EXPECT_EQ(displayFrame2->getActuals().presentTime, 120); |
| 2198 | actuals2 = presentedSurfaceFrame2.getActuals(); |
| 2199 | EXPECT_EQ(actuals2.presentTime, 120); |
| 2200 | |
| 2201 | EXPECT_EQ(displayFrame2->getFramePresentMetadata(), FramePresentMetadata::OnTimePresent); |
| 2202 | EXPECT_EQ(displayFrame2->getFrameReadyMetadata(), FrameReadyMetadata::OnTimeFinish); |
| 2203 | EXPECT_EQ(displayFrame2->getJankType(), JankType::None); |
| 2204 | |
| 2205 | EXPECT_EQ(presentedSurfaceFrame2.getFramePresentMetadata(), FramePresentMetadata::LatePresent); |
| 2206 | EXPECT_EQ(presentedSurfaceFrame2.getFrameReadyMetadata(), FrameReadyMetadata::LateFinish); |
| 2207 | EXPECT_EQ(presentedSurfaceFrame2.getJankType(), |
| 2208 | JankType::AppDeadlineMissed | JankType::BufferStuffing); |
| 2209 | } |
Alec Mouri | adebf5c | 2021-01-05 12:57:36 -0800 | [diff] [blame] | 2210 | |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 2211 | TEST_F(FrameTimelineTest, jankClassification_appDeadlineAdjustedForBufferStuffing) { |
| 2212 | // Layer specific increment |
| 2213 | EXPECT_CALL(*mTimeStats, incrementJankyFrames(_)).Times(2); |
| 2214 | auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
| 2215 | int64_t surfaceFrameToken1 = mTokenManager->generateTokenForPredictions({10, 20, 30}); |
| 2216 | int64_t surfaceFrameToken2 = mTokenManager->generateTokenForPredictions({40, 50, 60}); |
| 2217 | |
| 2218 | int64_t sfToken1 = mTokenManager->generateTokenForPredictions({52, 60, 60}); |
| 2219 | int64_t sfToken2 = mTokenManager->generateTokenForPredictions({82, 90, 90}); |
Huihong Luo | 3bdef86 | 2022-03-03 11:57:19 -0800 | [diff] [blame] | 2220 | FrameTimelineInfo ftInfo; |
| 2221 | ftInfo.vsyncId = surfaceFrameToken1; |
| 2222 | ftInfo.inputEventId = sInputEventId; |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 2223 | auto surfaceFrame1 = |
Huihong Luo | 3bdef86 | 2022-03-03 11:57:19 -0800 | [diff] [blame] | 2224 | mFrameTimeline->createSurfaceFrameForToken(ftInfo, sPidOne, sUidOne, sLayerIdOne, |
| 2225 | sLayerNameOne, sLayerNameOne, |
| 2226 | /*isBuffer*/ true, sGameMode); |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 2227 | surfaceFrame1->setAcquireFenceTime(50); |
Pascal Muetschard | ac7bcd9 | 2023-10-03 15:05:36 +0200 | [diff] [blame] | 2228 | mFrameTimeline->setSfWakeUp(sfToken1, 52, RR_30, RR_30); |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 2229 | surfaceFrame1->setPresentState(SurfaceFrame::PresentState::Presented); |
| 2230 | mFrameTimeline->addSurfaceFrame(surfaceFrame1); |
| 2231 | mFrameTimeline->setSfPresent(56, presentFence1); |
| 2232 | auto displayFrame1 = getDisplayFrame(0); |
| 2233 | auto& presentedSurfaceFrame1 = getSurfaceFrame(0, 0); |
| 2234 | presentFence1->signalForTest(60); |
| 2235 | |
| 2236 | // Fences for the first frame haven't been flushed yet, so it should be 0 |
| 2237 | EXPECT_EQ(displayFrame1->getActuals().presentTime, 0); |
| 2238 | auto actuals1 = presentedSurfaceFrame1.getActuals(); |
| 2239 | EXPECT_EQ(actuals1.presentTime, 0); |
| 2240 | |
| 2241 | // Trigger a flush by finalizing the next DisplayFrame |
| 2242 | auto presentFence2 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
Huihong Luo | 3bdef86 | 2022-03-03 11:57:19 -0800 | [diff] [blame] | 2243 | FrameTimelineInfo ftInfo2; |
| 2244 | ftInfo2.vsyncId = surfaceFrameToken2; |
| 2245 | ftInfo2.inputEventId = sInputEventId; |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 2246 | auto surfaceFrame2 = |
Huihong Luo | 3bdef86 | 2022-03-03 11:57:19 -0800 | [diff] [blame] | 2247 | mFrameTimeline->createSurfaceFrameForToken(ftInfo2, sPidOne, sUidOne, sLayerIdOne, |
| 2248 | sLayerNameOne, sLayerNameOne, |
| 2249 | /*isBuffer*/ true, sGameMode); |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 2250 | surfaceFrame2->setAcquireFenceTime(80); |
Pascal Muetschard | ac7bcd9 | 2023-10-03 15:05:36 +0200 | [diff] [blame] | 2251 | mFrameTimeline->setSfWakeUp(sfToken2, 82, RR_30, RR_30); |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 2252 | // Setting previous latch time to 54, adjusted deadline will be 54 + vsyncTime(30) = 84 |
| 2253 | surfaceFrame2->setPresentState(SurfaceFrame::PresentState::Presented, 54); |
| 2254 | mFrameTimeline->addSurfaceFrame(surfaceFrame2); |
| 2255 | mFrameTimeline->setSfPresent(86, presentFence2); |
| 2256 | auto displayFrame2 = getDisplayFrame(1); |
| 2257 | auto& presentedSurfaceFrame2 = getSurfaceFrame(1, 0); |
| 2258 | presentFence2->signalForTest(90); |
| 2259 | |
| 2260 | // Fences for the first frame have flushed, so the present timestamps should be updated |
| 2261 | EXPECT_EQ(displayFrame1->getActuals().presentTime, 60); |
| 2262 | actuals1 = presentedSurfaceFrame1.getActuals(); |
| 2263 | EXPECT_EQ(actuals1.endTime, 50); |
| 2264 | EXPECT_EQ(actuals1.presentTime, 60); |
| 2265 | |
| 2266 | EXPECT_EQ(displayFrame1->getFramePresentMetadata(), FramePresentMetadata::OnTimePresent); |
| 2267 | EXPECT_EQ(displayFrame1->getFrameReadyMetadata(), FrameReadyMetadata::OnTimeFinish); |
| 2268 | EXPECT_EQ(displayFrame1->getJankType(), JankType::None); |
| 2269 | |
| 2270 | EXPECT_EQ(presentedSurfaceFrame1.getFramePresentMetadata(), FramePresentMetadata::LatePresent); |
| 2271 | EXPECT_EQ(presentedSurfaceFrame1.getFrameReadyMetadata(), FrameReadyMetadata::LateFinish); |
| 2272 | EXPECT_EQ(presentedSurfaceFrame1.getJankType(), JankType::AppDeadlineMissed); |
| 2273 | |
| 2274 | // Fences for the second frame haven't been flushed yet, so it should be 0 |
| 2275 | EXPECT_EQ(displayFrame2->getActuals().presentTime, 0); |
| 2276 | auto actuals2 = presentedSurfaceFrame2.getActuals(); |
| 2277 | EXPECT_EQ(actuals2.presentTime, 0); |
| 2278 | |
| 2279 | addEmptyDisplayFrame(); |
| 2280 | |
| 2281 | // Fences for the second frame have flushed, so the present timestamps should be updated |
| 2282 | EXPECT_EQ(displayFrame2->getActuals().presentTime, 90); |
| 2283 | actuals2 = presentedSurfaceFrame2.getActuals(); |
| 2284 | EXPECT_EQ(actuals2.presentTime, 90); |
| 2285 | |
| 2286 | EXPECT_EQ(displayFrame2->getFramePresentMetadata(), FramePresentMetadata::OnTimePresent); |
| 2287 | EXPECT_EQ(displayFrame2->getFrameReadyMetadata(), FrameReadyMetadata::OnTimeFinish); |
| 2288 | EXPECT_EQ(displayFrame2->getJankType(), JankType::None); |
| 2289 | |
| 2290 | EXPECT_EQ(presentedSurfaceFrame2.getFramePresentMetadata(), FramePresentMetadata::LatePresent); |
| 2291 | EXPECT_EQ(presentedSurfaceFrame2.getFrameReadyMetadata(), FrameReadyMetadata::OnTimeFinish); |
| 2292 | EXPECT_EQ(presentedSurfaceFrame2.getJankType(), JankType::BufferStuffing); |
| 2293 | } |
| 2294 | |
Rachel Lee | 94917b3 | 2022-03-18 17:52:09 -0700 | [diff] [blame] | 2295 | TEST_F(FrameTimelineTest, jankClassification_displayFrameLateFinishLatePresent_GpuAndCpuMiss) { |
| 2296 | auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
| 2297 | auto presentFence2 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
| 2298 | auto gpuFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
| 2299 | int64_t sfToken1 = mTokenManager->generateTokenForPredictions({22, 26, 40}); |
| 2300 | int64_t sfToken2 = mTokenManager->generateTokenForPredictions({52, 60, 60}); |
| 2301 | |
| 2302 | // Case 1: cpu time = 33 - 12 = 21, vsync period = 11 |
Pascal Muetschard | ac7bcd9 | 2023-10-03 15:05:36 +0200 | [diff] [blame] | 2303 | mFrameTimeline->setSfWakeUp(sfToken1, 12, RR_11, RR_11); |
Rachel Lee | 94917b3 | 2022-03-18 17:52:09 -0700 | [diff] [blame] | 2304 | mFrameTimeline->setSfPresent(33, presentFence1, gpuFence1); |
| 2305 | auto displayFrame = getDisplayFrame(0); |
| 2306 | gpuFence1->signalForTest(36); |
| 2307 | presentFence1->signalForTest(52); |
| 2308 | |
| 2309 | // Fences haven't been flushed yet, so it should be 0 |
| 2310 | EXPECT_EQ(displayFrame->getActuals().presentTime, 0); |
| 2311 | |
| 2312 | addEmptyDisplayFrame(); |
| 2313 | displayFrame = getDisplayFrame(0); |
| 2314 | |
| 2315 | // Fences have flushed, so the present timestamps should be updated |
| 2316 | EXPECT_EQ(displayFrame->getActuals().presentTime, 52); |
| 2317 | EXPECT_EQ(displayFrame->getFramePresentMetadata(), FramePresentMetadata::LatePresent); |
| 2318 | EXPECT_EQ(displayFrame->getFrameReadyMetadata(), FrameReadyMetadata::LateFinish); |
| 2319 | EXPECT_EQ(displayFrame->getJankType(), JankType::SurfaceFlingerGpuDeadlineMissed); |
| 2320 | |
| 2321 | // Case 2: No GPU fence so it will not use GPU composition. |
Pascal Muetschard | ac7bcd9 | 2023-10-03 15:05:36 +0200 | [diff] [blame] | 2322 | mFrameTimeline->setSfWakeUp(sfToken2, 52, RR_30, RR_30); |
Rachel Lee | 94917b3 | 2022-03-18 17:52:09 -0700 | [diff] [blame] | 2323 | mFrameTimeline->setSfPresent(66, presentFence2); |
| 2324 | auto displayFrame2 = getDisplayFrame(2); // 2 because of previous empty frame |
| 2325 | presentFence2->signalForTest(90); |
| 2326 | |
| 2327 | // Fences for the frame haven't been flushed yet, so it should be 0 |
| 2328 | EXPECT_EQ(displayFrame2->getActuals().presentTime, 0); |
| 2329 | |
| 2330 | addEmptyDisplayFrame(); |
| 2331 | |
| 2332 | // Fences have flushed, so the present timestamps should be updated |
| 2333 | EXPECT_EQ(displayFrame2->getActuals().presentTime, 90); |
| 2334 | EXPECT_EQ(displayFrame2->getFramePresentMetadata(), FramePresentMetadata::LatePresent); |
| 2335 | EXPECT_EQ(displayFrame2->getFrameReadyMetadata(), FrameReadyMetadata::LateFinish); |
| 2336 | EXPECT_EQ(displayFrame2->getJankType(), JankType::SurfaceFlingerCpuDeadlineMissed); |
| 2337 | } |
| 2338 | |
Ady Abraham | fcb1686 | 2022-10-10 14:35:21 -0700 | [diff] [blame] | 2339 | TEST_F(FrameTimelineTest, jankClassification_presentFenceError) { |
| 2340 | auto erroneousPresentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
| 2341 | auto erroneousPresentFence2 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
| 2342 | auto validPresentFence = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
| 2343 | int64_t sfToken1 = mTokenManager->generateTokenForPredictions({22, 26, 40}); |
| 2344 | int64_t sfToken2 = mTokenManager->generateTokenForPredictions({52, 60, 60}); |
| 2345 | int64_t sfToken3 = mTokenManager->generateTokenForPredictions({72, 80, 80}); |
| 2346 | |
Pascal Muetschard | ac7bcd9 | 2023-10-03 15:05:36 +0200 | [diff] [blame] | 2347 | mFrameTimeline->setSfWakeUp(sfToken1, 22, RR_11, RR_11); |
Ady Abraham | fcb1686 | 2022-10-10 14:35:21 -0700 | [diff] [blame] | 2348 | mFrameTimeline->setSfPresent(26, erroneousPresentFence1); |
| 2349 | |
Pascal Muetschard | ac7bcd9 | 2023-10-03 15:05:36 +0200 | [diff] [blame] | 2350 | mFrameTimeline->setSfWakeUp(sfToken2, 52, RR_11, RR_11); |
Ady Abraham | fcb1686 | 2022-10-10 14:35:21 -0700 | [diff] [blame] | 2351 | mFrameTimeline->setSfPresent(60, erroneousPresentFence2); |
| 2352 | |
Pascal Muetschard | ac7bcd9 | 2023-10-03 15:05:36 +0200 | [diff] [blame] | 2353 | mFrameTimeline->setSfWakeUp(sfToken3, 72, RR_11, RR_11); |
Ady Abraham | fcb1686 | 2022-10-10 14:35:21 -0700 | [diff] [blame] | 2354 | mFrameTimeline->setSfPresent(80, validPresentFence); |
| 2355 | |
Ady Abraham | b1e10d1 | 2023-03-13 15:23:54 -0700 | [diff] [blame] | 2356 | erroneousPresentFence2->signalForTest(2); |
Ady Abraham | fcb1686 | 2022-10-10 14:35:21 -0700 | [diff] [blame] | 2357 | validPresentFence->signalForTest(80); |
| 2358 | |
| 2359 | addEmptyDisplayFrame(); |
| 2360 | |
| 2361 | { |
| 2362 | auto displayFrame = getDisplayFrame(0); |
| 2363 | EXPECT_EQ(displayFrame->getActuals().presentTime, 26); |
| 2364 | EXPECT_EQ(displayFrame->getFramePresentMetadata(), FramePresentMetadata::UnknownPresent); |
| 2365 | EXPECT_EQ(displayFrame->getFrameReadyMetadata(), FrameReadyMetadata::UnknownFinish); |
Ady Abraham | b1e10d1 | 2023-03-13 15:23:54 -0700 | [diff] [blame] | 2366 | EXPECT_EQ(displayFrame->getJankType(), JankType::Unknown | JankType::DisplayHAL); |
Ady Abraham | fcb1686 | 2022-10-10 14:35:21 -0700 | [diff] [blame] | 2367 | } |
| 2368 | { |
| 2369 | auto displayFrame = getDisplayFrame(1); |
| 2370 | EXPECT_EQ(displayFrame->getActuals().presentTime, 60); |
| 2371 | EXPECT_EQ(displayFrame->getFramePresentMetadata(), FramePresentMetadata::UnknownPresent); |
| 2372 | EXPECT_EQ(displayFrame->getFrameReadyMetadata(), FrameReadyMetadata::UnknownFinish); |
Ady Abraham | b1e10d1 | 2023-03-13 15:23:54 -0700 | [diff] [blame] | 2373 | EXPECT_EQ(displayFrame->getJankType(), JankType::Unknown | JankType::DisplayHAL); |
Ady Abraham | fcb1686 | 2022-10-10 14:35:21 -0700 | [diff] [blame] | 2374 | } |
| 2375 | { |
| 2376 | auto displayFrame = getDisplayFrame(2); |
| 2377 | EXPECT_EQ(displayFrame->getActuals().presentTime, 80); |
| 2378 | EXPECT_EQ(displayFrame->getFramePresentMetadata(), FramePresentMetadata::OnTimePresent); |
| 2379 | EXPECT_EQ(displayFrame->getFrameReadyMetadata(), FrameReadyMetadata::OnTimeFinish); |
| 2380 | EXPECT_EQ(displayFrame->getJankType(), JankType::None); |
| 2381 | } |
| 2382 | } |
| 2383 | |
Alec Mouri | adebf5c | 2021-01-05 12:57:36 -0800 | [diff] [blame] | 2384 | TEST_F(FrameTimelineTest, computeFps_noLayerIds_returnsZero) { |
| 2385 | EXPECT_EQ(mFrameTimeline->computeFps({}), 0.0f); |
| 2386 | } |
| 2387 | |
| 2388 | TEST_F(FrameTimelineTest, computeFps_singleDisplayFrame_returnsZero) { |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 2389 | const auto oneHundredMs = std::chrono::nanoseconds(100ms).count(); |
Alec Mouri | adebf5c | 2021-01-05 12:57:36 -0800 | [diff] [blame] | 2390 | |
| 2391 | auto surfaceFrame1 = |
| 2392 | mFrameTimeline->createSurfaceFrameForToken(FrameTimelineInfo(), sPidOne, sUidOne, |
Adithya Srinivasan | 785addd | 2021-03-09 00:38:00 +0000 | [diff] [blame] | 2393 | sLayerIdOne, sLayerNameOne, sLayerNameOne, |
Adithya Srinivasan | 58069dc | 2021-06-04 20:37:02 +0000 | [diff] [blame] | 2394 | /*isBuffer*/ true, sGameMode); |
Alec Mouri | adebf5c | 2021-01-05 12:57:36 -0800 | [diff] [blame] | 2395 | auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
| 2396 | surfaceFrame1->setPresentState(SurfaceFrame::PresentState::Presented); |
| 2397 | mFrameTimeline->addSurfaceFrame(surfaceFrame1); |
| 2398 | presentFence1->signalForTest(oneHundredMs); |
| 2399 | mFrameTimeline->setSfPresent(oneHundredMs, presentFence1); |
| 2400 | |
| 2401 | EXPECT_EQ(mFrameTimeline->computeFps({sLayerIdOne}), 0.0f); |
| 2402 | } |
| 2403 | |
| 2404 | TEST_F(FrameTimelineTest, computeFps_twoDisplayFrames_oneLayer) { |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 2405 | const auto oneHundredMs = std::chrono::nanoseconds(100ms).count(); |
| 2406 | const auto twoHundredMs = std::chrono::nanoseconds(200ms).count(); |
Alec Mouri | adebf5c | 2021-01-05 12:57:36 -0800 | [diff] [blame] | 2407 | auto surfaceFrame1 = |
| 2408 | mFrameTimeline->createSurfaceFrameForToken(FrameTimelineInfo(), sPidOne, sUidOne, |
Adithya Srinivasan | 785addd | 2021-03-09 00:38:00 +0000 | [diff] [blame] | 2409 | sLayerIdOne, sLayerNameOne, sLayerNameOne, |
Adithya Srinivasan | 58069dc | 2021-06-04 20:37:02 +0000 | [diff] [blame] | 2410 | /*isBuffer*/ true, sGameMode); |
Alec Mouri | adebf5c | 2021-01-05 12:57:36 -0800 | [diff] [blame] | 2411 | auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
| 2412 | surfaceFrame1->setPresentState(SurfaceFrame::PresentState::Presented); |
| 2413 | mFrameTimeline->addSurfaceFrame(surfaceFrame1); |
| 2414 | presentFence1->signalForTest(oneHundredMs); |
| 2415 | mFrameTimeline->setSfPresent(oneHundredMs, presentFence1); |
| 2416 | |
| 2417 | auto surfaceFrame2 = |
| 2418 | mFrameTimeline->createSurfaceFrameForToken(FrameTimelineInfo(), sPidOne, sUidOne, |
Adithya Srinivasan | 785addd | 2021-03-09 00:38:00 +0000 | [diff] [blame] | 2419 | sLayerIdOne, sLayerNameOne, sLayerNameOne, |
Adithya Srinivasan | 58069dc | 2021-06-04 20:37:02 +0000 | [diff] [blame] | 2420 | /*isBuffer*/ true, sGameMode); |
Alec Mouri | adebf5c | 2021-01-05 12:57:36 -0800 | [diff] [blame] | 2421 | auto presentFence2 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
| 2422 | surfaceFrame2->setPresentState(SurfaceFrame::PresentState::Presented); |
| 2423 | mFrameTimeline->addSurfaceFrame(surfaceFrame2); |
| 2424 | presentFence2->signalForTest(twoHundredMs); |
| 2425 | mFrameTimeline->setSfPresent(twoHundredMs, presentFence2); |
| 2426 | |
| 2427 | EXPECT_EQ(mFrameTimeline->computeFps({sLayerIdOne}), 10.0); |
| 2428 | } |
| 2429 | |
| 2430 | TEST_F(FrameTimelineTest, computeFps_twoDisplayFrames_twoLayers) { |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 2431 | const auto oneHundredMs = std::chrono::nanoseconds(100ms).count(); |
| 2432 | const auto twoHundredMs = std::chrono::nanoseconds(200ms).count(); |
Alec Mouri | adebf5c | 2021-01-05 12:57:36 -0800 | [diff] [blame] | 2433 | auto surfaceFrame1 = |
| 2434 | mFrameTimeline->createSurfaceFrameForToken(FrameTimelineInfo(), sPidOne, sUidOne, |
Adithya Srinivasan | 785addd | 2021-03-09 00:38:00 +0000 | [diff] [blame] | 2435 | sLayerIdOne, sLayerNameOne, sLayerNameOne, |
Adithya Srinivasan | 58069dc | 2021-06-04 20:37:02 +0000 | [diff] [blame] | 2436 | /*isBuffer*/ true, sGameMode); |
Alec Mouri | adebf5c | 2021-01-05 12:57:36 -0800 | [diff] [blame] | 2437 | auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
| 2438 | surfaceFrame1->setPresentState(SurfaceFrame::PresentState::Presented); |
| 2439 | mFrameTimeline->addSurfaceFrame(surfaceFrame1); |
| 2440 | presentFence1->signalForTest(oneHundredMs); |
| 2441 | mFrameTimeline->setSfPresent(oneHundredMs, presentFence1); |
| 2442 | |
| 2443 | auto surfaceFrame2 = |
| 2444 | mFrameTimeline->createSurfaceFrameForToken(FrameTimelineInfo(), sPidOne, sUidOne, |
Adithya Srinivasan | 785addd | 2021-03-09 00:38:00 +0000 | [diff] [blame] | 2445 | sLayerIdTwo, sLayerNameTwo, sLayerNameTwo, |
Adithya Srinivasan | 58069dc | 2021-06-04 20:37:02 +0000 | [diff] [blame] | 2446 | /*isBuffer*/ true, sGameMode); |
Alec Mouri | adebf5c | 2021-01-05 12:57:36 -0800 | [diff] [blame] | 2447 | auto presentFence2 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
| 2448 | surfaceFrame2->setPresentState(SurfaceFrame::PresentState::Presented); |
| 2449 | mFrameTimeline->addSurfaceFrame(surfaceFrame2); |
| 2450 | presentFence2->signalForTest(twoHundredMs); |
| 2451 | mFrameTimeline->setSfPresent(twoHundredMs, presentFence2); |
| 2452 | |
| 2453 | EXPECT_EQ(mFrameTimeline->computeFps({sLayerIdOne, sLayerIdTwo}), 10.0f); |
| 2454 | } |
| 2455 | |
| 2456 | TEST_F(FrameTimelineTest, computeFps_filtersOutLayers) { |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 2457 | const auto oneHundredMs = std::chrono::nanoseconds(100ms).count(); |
| 2458 | const auto twoHundredMs = std::chrono::nanoseconds(200ms).count(); |
Alec Mouri | adebf5c | 2021-01-05 12:57:36 -0800 | [diff] [blame] | 2459 | auto surfaceFrame1 = |
| 2460 | mFrameTimeline->createSurfaceFrameForToken(FrameTimelineInfo(), sPidOne, sUidOne, |
Adithya Srinivasan | 785addd | 2021-03-09 00:38:00 +0000 | [diff] [blame] | 2461 | sLayerIdOne, sLayerNameOne, sLayerNameOne, |
Adithya Srinivasan | 58069dc | 2021-06-04 20:37:02 +0000 | [diff] [blame] | 2462 | /*isBuffer*/ true, sGameMode); |
Alec Mouri | adebf5c | 2021-01-05 12:57:36 -0800 | [diff] [blame] | 2463 | auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
| 2464 | surfaceFrame1->setPresentState(SurfaceFrame::PresentState::Presented); |
| 2465 | mFrameTimeline->addSurfaceFrame(surfaceFrame1); |
| 2466 | presentFence1->signalForTest(oneHundredMs); |
| 2467 | mFrameTimeline->setSfPresent(oneHundredMs, presentFence1); |
| 2468 | |
| 2469 | auto surfaceFrame2 = |
| 2470 | mFrameTimeline->createSurfaceFrameForToken(FrameTimelineInfo(), sPidOne, sUidOne, |
Adithya Srinivasan | 785addd | 2021-03-09 00:38:00 +0000 | [diff] [blame] | 2471 | sLayerIdTwo, sLayerNameTwo, sLayerNameTwo, |
Adithya Srinivasan | 58069dc | 2021-06-04 20:37:02 +0000 | [diff] [blame] | 2472 | /*isBuffer*/ true, sGameMode); |
Alec Mouri | adebf5c | 2021-01-05 12:57:36 -0800 | [diff] [blame] | 2473 | auto presentFence2 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
| 2474 | surfaceFrame2->setPresentState(SurfaceFrame::PresentState::Presented); |
| 2475 | mFrameTimeline->addSurfaceFrame(surfaceFrame2); |
| 2476 | presentFence2->signalForTest(twoHundredMs); |
| 2477 | mFrameTimeline->setSfPresent(twoHundredMs, presentFence2); |
| 2478 | |
| 2479 | EXPECT_EQ(mFrameTimeline->computeFps({sLayerIdOne}), 0.0f); |
| 2480 | } |
| 2481 | |
| 2482 | TEST_F(FrameTimelineTest, computeFps_averagesOverMultipleFrames) { |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 2483 | const auto oneHundredMs = std::chrono::nanoseconds(100ms).count(); |
| 2484 | const auto twoHundredMs = std::chrono::nanoseconds(200ms).count(); |
| 2485 | const auto threeHundredMs = std::chrono::nanoseconds(300ms).count(); |
| 2486 | const auto fiveHundredMs = std::chrono::nanoseconds(500ms).count(); |
| 2487 | const auto sixHundredMs = std::chrono::nanoseconds(600ms).count(); |
Alec Mouri | adebf5c | 2021-01-05 12:57:36 -0800 | [diff] [blame] | 2488 | auto surfaceFrame1 = |
| 2489 | mFrameTimeline->createSurfaceFrameForToken(FrameTimelineInfo(), sPidOne, sUidOne, |
Adithya Srinivasan | 785addd | 2021-03-09 00:38:00 +0000 | [diff] [blame] | 2490 | sLayerIdOne, sLayerNameOne, sLayerNameOne, |
Adithya Srinivasan | 58069dc | 2021-06-04 20:37:02 +0000 | [diff] [blame] | 2491 | /*isBuffer*/ true, sGameMode); |
Alec Mouri | adebf5c | 2021-01-05 12:57:36 -0800 | [diff] [blame] | 2492 | auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
| 2493 | surfaceFrame1->setPresentState(SurfaceFrame::PresentState::Presented); |
| 2494 | mFrameTimeline->addSurfaceFrame(surfaceFrame1); |
| 2495 | presentFence1->signalForTest(oneHundredMs); |
| 2496 | mFrameTimeline->setSfPresent(oneHundredMs, presentFence1); |
| 2497 | |
| 2498 | auto surfaceFrame2 = |
| 2499 | mFrameTimeline->createSurfaceFrameForToken(FrameTimelineInfo(), sPidOne, sUidOne, |
Adithya Srinivasan | 785addd | 2021-03-09 00:38:00 +0000 | [diff] [blame] | 2500 | sLayerIdOne, sLayerNameOne, sLayerNameOne, |
Adithya Srinivasan | 58069dc | 2021-06-04 20:37:02 +0000 | [diff] [blame] | 2501 | /*isBuffer*/ true, sGameMode); |
Alec Mouri | adebf5c | 2021-01-05 12:57:36 -0800 | [diff] [blame] | 2502 | auto presentFence2 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
| 2503 | surfaceFrame2->setPresentState(SurfaceFrame::PresentState::Presented); |
| 2504 | mFrameTimeline->addSurfaceFrame(surfaceFrame2); |
| 2505 | presentFence2->signalForTest(twoHundredMs); |
| 2506 | mFrameTimeline->setSfPresent(twoHundredMs, presentFence2); |
| 2507 | |
| 2508 | auto surfaceFrame3 = |
| 2509 | mFrameTimeline->createSurfaceFrameForToken(FrameTimelineInfo(), sPidOne, sUidOne, |
Adithya Srinivasan | 785addd | 2021-03-09 00:38:00 +0000 | [diff] [blame] | 2510 | sLayerIdTwo, sLayerNameTwo, sLayerNameTwo, |
Adithya Srinivasan | 58069dc | 2021-06-04 20:37:02 +0000 | [diff] [blame] | 2511 | /*isBuffer*/ true, sGameMode); |
Alec Mouri | adebf5c | 2021-01-05 12:57:36 -0800 | [diff] [blame] | 2512 | auto presentFence3 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
| 2513 | surfaceFrame3->setPresentState(SurfaceFrame::PresentState::Presented); |
| 2514 | mFrameTimeline->addSurfaceFrame(surfaceFrame3); |
| 2515 | presentFence3->signalForTest(threeHundredMs); |
| 2516 | mFrameTimeline->setSfPresent(threeHundredMs, presentFence3); |
| 2517 | |
| 2518 | auto surfaceFrame4 = |
| 2519 | mFrameTimeline->createSurfaceFrameForToken(FrameTimelineInfo(), sPidOne, sUidOne, |
Adithya Srinivasan | 785addd | 2021-03-09 00:38:00 +0000 | [diff] [blame] | 2520 | sLayerIdOne, sLayerNameOne, sLayerNameOne, |
Adithya Srinivasan | 58069dc | 2021-06-04 20:37:02 +0000 | [diff] [blame] | 2521 | /*isBuffer*/ true, sGameMode); |
Alec Mouri | adebf5c | 2021-01-05 12:57:36 -0800 | [diff] [blame] | 2522 | auto presentFence4 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
| 2523 | surfaceFrame4->setPresentState(SurfaceFrame::PresentState::Presented); |
| 2524 | mFrameTimeline->addSurfaceFrame(surfaceFrame4); |
| 2525 | presentFence4->signalForTest(fiveHundredMs); |
| 2526 | mFrameTimeline->setSfPresent(fiveHundredMs, presentFence4); |
| 2527 | |
| 2528 | auto surfaceFrame5 = |
| 2529 | mFrameTimeline->createSurfaceFrameForToken(FrameTimelineInfo(), sPidOne, sUidOne, |
Adithya Srinivasan | 785addd | 2021-03-09 00:38:00 +0000 | [diff] [blame] | 2530 | sLayerIdOne, sLayerNameOne, sLayerNameOne, |
Adithya Srinivasan | 58069dc | 2021-06-04 20:37:02 +0000 | [diff] [blame] | 2531 | /*isBuffer*/ true, sGameMode); |
Alec Mouri | adebf5c | 2021-01-05 12:57:36 -0800 | [diff] [blame] | 2532 | auto presentFence5 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
| 2533 | // Dropped frames will be excluded from fps computation |
| 2534 | surfaceFrame5->setPresentState(SurfaceFrame::PresentState::Dropped); |
| 2535 | mFrameTimeline->addSurfaceFrame(surfaceFrame5); |
| 2536 | presentFence5->signalForTest(sixHundredMs); |
| 2537 | mFrameTimeline->setSfPresent(sixHundredMs, presentFence5); |
| 2538 | |
| 2539 | EXPECT_EQ(mFrameTimeline->computeFps({sLayerIdOne}), 5.0f); |
| 2540 | } |
| 2541 | |
ramindani | ea2bb82 | 2022-06-27 19:52:10 +0000 | [diff] [blame] | 2542 | TEST_F(FrameTimelineTest, getMinTime) { |
| 2543 | // Use SurfaceFrame::getBaseTime to test the getMinTime. |
| 2544 | FrameTimelineInfo ftInfo; |
| 2545 | |
| 2546 | // Valid prediction state test. |
| 2547 | ftInfo.vsyncId = 0L; |
| 2548 | mTokenManager->generateTokenForPredictions({10}); |
| 2549 | auto surfaceFrame = |
| 2550 | mFrameTimeline->createSurfaceFrameForToken(ftInfo, sPidOne, sUidOne, sLayerIdOne, |
| 2551 | sLayerNameOne, sLayerNameOne, |
| 2552 | /*isBuffer*/ true, sGameMode); |
| 2553 | ASSERT_EQ(surfaceFrame->getBaseTime(), 10); |
| 2554 | |
| 2555 | // Test prediction state which is not valid. |
| 2556 | ftInfo.vsyncId = FrameTimelineInfo::INVALID_VSYNC_ID; |
| 2557 | surfaceFrame = mFrameTimeline->createSurfaceFrameForToken(ftInfo, sPidOne, sUidOne, sLayerIdOne, |
| 2558 | sLayerNameOne, sLayerNameOne, |
| 2559 | /*isBuffer*/ true, sGameMode); |
| 2560 | // Start time test. |
| 2561 | surfaceFrame->setActualStartTime(200); |
| 2562 | ASSERT_EQ(surfaceFrame->getBaseTime(), 200); |
| 2563 | |
| 2564 | // End time test. |
| 2565 | surfaceFrame->setAcquireFenceTime(100); |
| 2566 | ASSERT_EQ(surfaceFrame->getBaseTime(), 100); |
| 2567 | |
| 2568 | // Present time test. |
| 2569 | auto presentFence = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
| 2570 | surfaceFrame->setPresentState(SurfaceFrame::PresentState::Presented); |
| 2571 | mFrameTimeline->addSurfaceFrame(surfaceFrame); |
| 2572 | presentFence->signalForTest(std::chrono::nanoseconds(50ns).count()); |
| 2573 | mFrameTimeline->setSfPresent(50, presentFence); |
| 2574 | ASSERT_EQ(surfaceFrame->getBaseTime(), 50); |
| 2575 | } |
Pascal Muetschard | ac7bcd9 | 2023-10-03 15:05:36 +0200 | [diff] [blame] | 2576 | |
| 2577 | TEST_F(FrameTimelineTest, surfaceFrameRenderRateUsingDisplayRate) { |
| 2578 | auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
| 2579 | int64_t token1 = mTokenManager->generateTokenForPredictions({10, 20, 30}); |
| 2580 | FrameTimelineInfo ftInfo; |
| 2581 | ftInfo.vsyncId = token1; |
| 2582 | ftInfo.inputEventId = sInputEventId; |
| 2583 | auto surfaceFrame = |
| 2584 | mFrameTimeline->createSurfaceFrameForToken(ftInfo, sPidOne, sUidOne, sLayerIdOne, |
| 2585 | sLayerNameOne, sLayerNameOne, |
| 2586 | /*isBuffer*/ true, sGameMode); |
| 2587 | |
| 2588 | mFrameTimeline->setSfWakeUp(token1, 20, RR_30, RR_11); |
| 2589 | surfaceFrame->setPresentState(SurfaceFrame::PresentState::Presented); |
| 2590 | mFrameTimeline->addSurfaceFrame(surfaceFrame); |
| 2591 | presentFence1->signalForTest(std::chrono::nanoseconds(50ns).count()); |
| 2592 | mFrameTimeline->setSfPresent(50, presentFence1); |
| 2593 | |
| 2594 | EXPECT_EQ(surfaceFrame->getRenderRate().getPeriodNsecs(), 11); |
| 2595 | } |
| 2596 | |
| 2597 | TEST_F(FrameTimelineTest, surfaceFrameRenderRateUsingAppFrameRate) { |
| 2598 | auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
| 2599 | int64_t token1 = mTokenManager->generateTokenForPredictions({10, 20, 30}); |
| 2600 | FrameTimelineInfo ftInfo; |
| 2601 | ftInfo.vsyncId = token1; |
| 2602 | ftInfo.inputEventId = sInputEventId; |
| 2603 | auto surfaceFrame = |
| 2604 | mFrameTimeline->createSurfaceFrameForToken(ftInfo, sPidOne, sUidOne, sLayerIdOne, |
| 2605 | sLayerNameOne, sLayerNameOne, |
| 2606 | /*isBuffer*/ true, sGameMode); |
| 2607 | surfaceFrame->setRenderRate(RR_30); |
| 2608 | mFrameTimeline->setSfWakeUp(token1, 20, RR_11, RR_11); |
| 2609 | surfaceFrame->setPresentState(SurfaceFrame::PresentState::Presented); |
| 2610 | mFrameTimeline->addSurfaceFrame(surfaceFrame); |
| 2611 | presentFence1->signalForTest(std::chrono::nanoseconds(50ns).count()); |
| 2612 | mFrameTimeline->setSfPresent(50, presentFence1); |
| 2613 | |
| 2614 | EXPECT_EQ(surfaceFrame->getRenderRate().getPeriodNsecs(), 30); |
| 2615 | } |
Adithya Srinivasan | f279e04 | 2020-08-17 14:56:27 -0700 | [diff] [blame] | 2616 | } // namespace android::frametimeline |