Adithya Srinivasan | f279e04 | 2020-08-17 14:56:27 -0700 | [diff] [blame] | 1 | /* |
| 2 | * Copyright 2020 The Android Open Source Project |
| 3 | * |
| 4 | * Licensed under the Apache License, Version 2.0 (the "License"); |
| 5 | * you may not use this file except in compliance with the License. |
| 6 | * You may obtain a copy of the License at |
| 7 | * |
| 8 | * http://www.apache.org/licenses/LICENSE-2.0 |
| 9 | * |
| 10 | * Unless required by applicable law or agreed to in writing, software |
| 11 | * distributed under the License is distributed on an "AS IS" BASIS, |
| 12 | * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. |
| 13 | * See the License for the specific language governing permissions and |
| 14 | * limitations under the License. |
| 15 | */ |
| 16 | |
Ady Abraham | 3db8a3c | 2023-11-20 17:53:47 -0800 | [diff] [blame] | 17 | #include <common/test/FlagUtils.h> |
Pascal Mütschard | d56514e | 2024-05-24 17:37:13 +0200 | [diff] [blame^] | 18 | #include "BackgroundExecutor.h" |
| 19 | #include "Jank/JankTracker.h" |
Sally Qi | f572125 | 2023-11-17 11:14:53 -0800 | [diff] [blame] | 20 | #include "com_android_graphics_surfaceflinger_flags.h" |
Alec Mouri | 9a29e67 | 2020-09-14 12:39:14 -0700 | [diff] [blame] | 21 | #include "gmock/gmock-spec-builders.h" |
| 22 | #include "mock/MockTimeStats.h" |
Adithya Srinivasan | f279e04 | 2020-08-17 14:56:27 -0700 | [diff] [blame] | 23 | #undef LOG_TAG |
| 24 | #define LOG_TAG "LibSurfaceFlingerUnittests" |
| 25 | |
| 26 | #include <FrameTimeline/FrameTimeline.h> |
| 27 | #include <gtest/gtest.h> |
| 28 | #include <log/log.h> |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 29 | #include <perfetto/trace/trace.pb.h> |
Adithya Srinivasan | f279e04 | 2020-08-17 14:56:27 -0700 | [diff] [blame] | 30 | #include <cinttypes> |
| 31 | |
| 32 | using namespace std::chrono_literals; |
Alec Mouri | 363faf0 | 2021-01-29 16:34:55 -0800 | [diff] [blame] | 33 | using testing::_; |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 34 | using testing::AtLeast; |
Alec Mouri | 9a29e67 | 2020-09-14 12:39:14 -0700 | [diff] [blame] | 35 | using testing::Contains; |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 36 | using FrameTimelineEvent = perfetto::protos::FrameTimelineEvent; |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 37 | using ProtoExpectedDisplayFrameStart = |
| 38 | perfetto::protos::FrameTimelineEvent_ExpectedDisplayFrameStart; |
| 39 | using ProtoExpectedSurfaceFrameStart = |
| 40 | perfetto::protos::FrameTimelineEvent_ExpectedSurfaceFrameStart; |
| 41 | using ProtoActualDisplayFrameStart = perfetto::protos::FrameTimelineEvent_ActualDisplayFrameStart; |
| 42 | using ProtoActualSurfaceFrameStart = perfetto::protos::FrameTimelineEvent_ActualSurfaceFrameStart; |
| 43 | using ProtoFrameEnd = perfetto::protos::FrameTimelineEvent_FrameEnd; |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 44 | using ProtoPresentType = perfetto::protos::FrameTimelineEvent_PresentType; |
| 45 | using ProtoJankType = perfetto::protos::FrameTimelineEvent_JankType; |
Ying Wei | 96eb535 | 2023-11-21 17:37:21 +0000 | [diff] [blame] | 46 | using ProtoJankSeverityType = perfetto::protos::FrameTimelineEvent_JankSeverityType; |
Adithya Srinivasan | 78e58af | 2021-02-25 00:08:08 +0000 | [diff] [blame] | 47 | using ProtoPredictionType = perfetto::protos::FrameTimelineEvent_PredictionType; |
Alec Mouri | 9a29e67 | 2020-09-14 12:39:14 -0700 | [diff] [blame] | 48 | |
Adithya Srinivasan | f279e04 | 2020-08-17 14:56:27 -0700 | [diff] [blame] | 49 | namespace android::frametimeline { |
| 50 | |
Ady Abraham | 57a8ab4 | 2023-01-26 15:28:19 -0800 | [diff] [blame] | 51 | static const std::string sLayerNameOne = "layer1"; |
| 52 | static const std::string sLayerNameTwo = "layer2"; |
| 53 | |
| 54 | constexpr const uid_t sUidOne = 0; |
| 55 | constexpr pid_t sPidOne = 10; |
| 56 | constexpr pid_t sPidTwo = 20; |
| 57 | constexpr int32_t sInputEventId = 5; |
| 58 | constexpr int32_t sLayerIdOne = 1; |
| 59 | constexpr int32_t sLayerIdTwo = 2; |
| 60 | constexpr GameMode sGameMode = GameMode::Unsupported; |
Pascal Muetschard | ac7bcd9 | 2023-10-03 15:05:36 +0200 | [diff] [blame] | 61 | constexpr Fps RR_11 = Fps::fromPeriodNsecs(11); |
| 62 | constexpr Fps RR_30 = Fps::fromPeriodNsecs(30); |
Ady Abraham | 57a8ab4 | 2023-01-26 15:28:19 -0800 | [diff] [blame] | 63 | |
Adithya Srinivasan | f279e04 | 2020-08-17 14:56:27 -0700 | [diff] [blame] | 64 | class FrameTimelineTest : public testing::Test { |
| 65 | public: |
| 66 | FrameTimelineTest() { |
| 67 | const ::testing::TestInfo* const test_info = |
| 68 | ::testing::UnitTest::GetInstance()->current_test_info(); |
| 69 | ALOGD("**** Setting up for %s.%s\n", test_info->test_case_name(), test_info->name()); |
| 70 | } |
| 71 | |
| 72 | ~FrameTimelineTest() { |
| 73 | const ::testing::TestInfo* const test_info = |
| 74 | ::testing::UnitTest::GetInstance()->current_test_info(); |
| 75 | ALOGD("**** Tearing down after %s.%s\n", test_info->test_case_name(), test_info->name()); |
| 76 | } |
| 77 | |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 78 | static void SetUpTestSuite() { |
| 79 | // Need to initialize tracing in process for testing, and only once per test suite. |
| 80 | perfetto::TracingInitArgs args; |
| 81 | args.backends = perfetto::kInProcessBackend; |
| 82 | perfetto::Tracing::Initialize(args); |
| 83 | } |
| 84 | |
Adithya Srinivasan | f279e04 | 2020-08-17 14:56:27 -0700 | [diff] [blame] | 85 | void SetUp() override { |
Ady Abraham | 57f8e18 | 2022-03-08 15:54:33 -0800 | [diff] [blame] | 86 | constexpr bool kUseBootTimeClock = true; |
Alec Mouri | 9a29e67 | 2020-09-14 12:39:14 -0700 | [diff] [blame] | 87 | mTimeStats = std::make_shared<mock::TimeStats>(); |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 88 | mFrameTimeline = std::make_unique<impl::FrameTimeline>(mTimeStats, kSurfaceFlingerPid, |
Ady Abraham | 57f8e18 | 2022-03-08 15:54:33 -0800 | [diff] [blame] | 89 | kTestThresholds, !kUseBootTimeClock); |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 90 | mFrameTimeline->registerDataSource(); |
Adithya Srinivasan | f279e04 | 2020-08-17 14:56:27 -0700 | [diff] [blame] | 91 | mTokenManager = &mFrameTimeline->mTokenManager; |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 92 | mTraceCookieCounter = &mFrameTimeline->mTraceCookieCounter; |
Adithya Srinivasan | 2d73632 | 2020-10-01 16:53:48 -0700 | [diff] [blame] | 93 | maxDisplayFrames = &mFrameTimeline->mMaxDisplayFrames; |
Adithya Srinivasan | bed4c4f | 2021-05-03 20:24:46 +0000 | [diff] [blame] | 94 | maxTokens = mTokenManager->kMaxTokens; |
Pascal Mütschard | d56514e | 2024-05-24 17:37:13 +0200 | [diff] [blame^] | 95 | |
| 96 | JankTracker::clearAndStartCollectingAllJankDataForTesting(); |
Adithya Srinivasan | f279e04 | 2020-08-17 14:56:27 -0700 | [diff] [blame] | 97 | } |
| 98 | |
Pascal Mütschard | d56514e | 2024-05-24 17:37:13 +0200 | [diff] [blame^] | 99 | void TearDown() override { JankTracker::clearAndStopCollectingAllJankDataForTesting(); } |
| 100 | |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 101 | // Each tracing session can be used for a single block of Start -> Stop. |
| 102 | static std::unique_ptr<perfetto::TracingSession> getTracingSessionForTest() { |
| 103 | perfetto::TraceConfig cfg; |
| 104 | cfg.set_duration_ms(500); |
| 105 | cfg.add_buffers()->set_size_kb(1024); |
| 106 | auto* ds_cfg = cfg.add_data_sources()->mutable_config(); |
| 107 | ds_cfg->set_name(impl::FrameTimeline::kFrameTimelineDataSource); |
| 108 | |
| 109 | auto tracingSession = perfetto::Tracing::NewTrace(perfetto::kInProcessBackend); |
| 110 | tracingSession->Setup(cfg); |
| 111 | return tracingSession; |
| 112 | } |
| 113 | |
| 114 | std::vector<perfetto::protos::TracePacket> readFrameTimelinePacketsBlocking( |
| 115 | perfetto::TracingSession* tracingSession) { |
| 116 | std::vector<char> raw_trace = tracingSession->ReadTraceBlocking(); |
| 117 | perfetto::protos::Trace trace; |
| 118 | EXPECT_TRUE(trace.ParseFromArray(raw_trace.data(), int(raw_trace.size()))); |
| 119 | |
| 120 | std::vector<perfetto::protos::TracePacket> packets; |
| 121 | for (const auto& packet : trace.packet()) { |
| 122 | if (!packet.has_frame_timeline_event()) { |
| 123 | continue; |
| 124 | } |
| 125 | packets.emplace_back(packet); |
| 126 | } |
| 127 | return packets; |
| 128 | } |
| 129 | |
Ady Abraham | 57a8ab4 | 2023-01-26 15:28:19 -0800 | [diff] [blame] | 130 | void addEmptySurfaceFrame() { |
| 131 | auto surfaceFrame = |
| 132 | mFrameTimeline->createSurfaceFrameForToken({}, sPidOne, sUidOne, sLayerIdOne, |
| 133 | sLayerNameOne, sLayerNameOne, |
| 134 | /*isBuffer*/ false, sGameMode); |
| 135 | mFrameTimeline->addSurfaceFrame(std::move(surfaceFrame)); |
| 136 | } |
| 137 | |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 138 | void addEmptyDisplayFrame() { |
| 139 | auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 140 | // Trigger a flushPresentFence by calling setSfPresent for the next frame |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 141 | mFrameTimeline->setSfPresent(2500, presentFence1); |
| 142 | } |
| 143 | |
Adithya Srinivasan | bed4c4f | 2021-05-03 20:24:46 +0000 | [diff] [blame] | 144 | void flushTokens() { |
| 145 | for (size_t i = 0; i < maxTokens; i++) { |
| 146 | mTokenManager->generateTokenForPredictions({}); |
| 147 | } |
| 148 | EXPECT_EQ(getPredictions().size(), maxTokens); |
Adithya Srinivasan | f279e04 | 2020-08-17 14:56:27 -0700 | [diff] [blame] | 149 | } |
| 150 | |
| 151 | SurfaceFrame& getSurfaceFrame(size_t displayFrameIdx, size_t surfaceFrameIdx) { |
| 152 | std::lock_guard<std::mutex> lock(mFrameTimeline->mMutex); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 153 | return *(mFrameTimeline->mDisplayFrames[displayFrameIdx] |
| 154 | ->getSurfaceFrames()[surfaceFrameIdx]); |
Adithya Srinivasan | f279e04 | 2020-08-17 14:56:27 -0700 | [diff] [blame] | 155 | } |
| 156 | |
| 157 | std::shared_ptr<impl::FrameTimeline::DisplayFrame> getDisplayFrame(size_t idx) { |
| 158 | std::lock_guard<std::mutex> lock(mFrameTimeline->mMutex); |
| 159 | return mFrameTimeline->mDisplayFrames[idx]; |
| 160 | } |
| 161 | |
| 162 | static bool compareTimelineItems(const TimelineItem& a, const TimelineItem& b) { |
| 163 | return a.startTime == b.startTime && a.endTime == b.endTime && |
| 164 | a.presentTime == b.presentTime; |
| 165 | } |
| 166 | |
Adithya Srinivasan | bed4c4f | 2021-05-03 20:24:46 +0000 | [diff] [blame] | 167 | const std::map<int64_t, TimelineItem>& getPredictions() const { |
Adithya Srinivasan | f279e04 | 2020-08-17 14:56:27 -0700 | [diff] [blame] | 168 | return mTokenManager->mPredictions; |
| 169 | } |
| 170 | |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 171 | uint32_t getNumberOfDisplayFrames() const { |
Adithya Srinivasan | 2d73632 | 2020-10-01 16:53:48 -0700 | [diff] [blame] | 172 | std::lock_guard<std::mutex> lock(mFrameTimeline->mMutex); |
| 173 | return static_cast<uint32_t>(mFrameTimeline->mDisplayFrames.size()); |
| 174 | } |
| 175 | |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 176 | int64_t snoopCurrentTraceCookie() const { return mTraceCookieCounter->mTraceCookie; } |
| 177 | |
| 178 | void flushTrace() { |
| 179 | using FrameTimelineDataSource = impl::FrameTimeline::FrameTimelineDataSource; |
| 180 | FrameTimelineDataSource::Trace( |
| 181 | [&](FrameTimelineDataSource::TraceContext ctx) { ctx.Flush(); }); |
| 182 | } |
| 183 | |
Pascal Mütschard | d56514e | 2024-05-24 17:37:13 +0200 | [diff] [blame^] | 184 | std::vector<gui::JankData> getLayerOneJankData() { |
| 185 | BackgroundExecutor::getLowPriorityInstance().flushQueue(); |
| 186 | return JankTracker::getCollectedJankDataForTesting(sLayerIdOne); |
| 187 | } |
| 188 | |
| 189 | std::vector<gui::JankData> getLayerTwoJankData() { |
| 190 | BackgroundExecutor::getLowPriorityInstance().flushQueue(); |
| 191 | return JankTracker::getCollectedJankDataForTesting(sLayerIdTwo); |
| 192 | } |
| 193 | |
Alec Mouri | 9a29e67 | 2020-09-14 12:39:14 -0700 | [diff] [blame] | 194 | std::shared_ptr<mock::TimeStats> mTimeStats; |
Adithya Srinivasan | f279e04 | 2020-08-17 14:56:27 -0700 | [diff] [blame] | 195 | std::unique_ptr<impl::FrameTimeline> mFrameTimeline; |
| 196 | impl::TokenManager* mTokenManager; |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 197 | TraceCookieCounter* mTraceCookieCounter; |
Adithya Srinivasan | f279e04 | 2020-08-17 14:56:27 -0700 | [diff] [blame] | 198 | FenceToFenceTimeMap fenceFactory; |
Adithya Srinivasan | 2d73632 | 2020-10-01 16:53:48 -0700 | [diff] [blame] | 199 | uint32_t* maxDisplayFrames; |
Adithya Srinivasan | bed4c4f | 2021-05-03 20:24:46 +0000 | [diff] [blame] | 200 | size_t maxTokens; |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 201 | static constexpr pid_t kSurfaceFlingerPid = 666; |
Adithya Srinivasan | ead1716 | 2021-02-18 02:17:37 +0000 | [diff] [blame] | 202 | static constexpr nsecs_t kPresentThreshold = std::chrono::nanoseconds(2ns).count(); |
Adithya Srinivasan | 54996e2 | 2021-06-25 22:26:45 +0000 | [diff] [blame] | 203 | static constexpr nsecs_t kDeadlineThreshold = std::chrono::nanoseconds(0ns).count(); |
Adithya Srinivasan | ead1716 | 2021-02-18 02:17:37 +0000 | [diff] [blame] | 204 | static constexpr nsecs_t kStartThreshold = std::chrono::nanoseconds(2ns).count(); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 205 | static constexpr JankClassificationThresholds kTestThresholds{kPresentThreshold, |
| 206 | kDeadlineThreshold, |
| 207 | kStartThreshold}; |
Adithya Srinivasan | f279e04 | 2020-08-17 14:56:27 -0700 | [diff] [blame] | 208 | }; |
| 209 | |
| 210 | TEST_F(FrameTimelineTest, tokenManagerRemovesStalePredictions) { |
| 211 | int64_t token1 = mTokenManager->generateTokenForPredictions({0, 0, 0}); |
Siarhei Vishniakou | fc434ac | 2021-01-13 10:28:00 -1000 | [diff] [blame] | 212 | EXPECT_EQ(getPredictions().size(), 1u); |
Adithya Srinivasan | bed4c4f | 2021-05-03 20:24:46 +0000 | [diff] [blame] | 213 | flushTokens(); |
Adithya Srinivasan | f279e04 | 2020-08-17 14:56:27 -0700 | [diff] [blame] | 214 | int64_t token2 = mTokenManager->generateTokenForPredictions({10, 20, 30}); |
| 215 | std::optional<TimelineItem> predictions = mTokenManager->getPredictionsForToken(token1); |
| 216 | |
| 217 | // token1 should have expired |
Adithya Srinivasan | f279e04 | 2020-08-17 14:56:27 -0700 | [diff] [blame] | 218 | EXPECT_EQ(predictions.has_value(), false); |
| 219 | |
| 220 | predictions = mTokenManager->getPredictionsForToken(token2); |
| 221 | EXPECT_EQ(compareTimelineItems(*predictions, TimelineItem(10, 20, 30)), true); |
| 222 | } |
| 223 | |
Adithya Srinivasan | 9febda8 | 2020-10-19 10:49:41 -0700 | [diff] [blame] | 224 | TEST_F(FrameTimelineTest, createSurfaceFrameForToken_getOwnerPidReturnsCorrectPid) { |
Alec Mouri | adebf5c | 2021-01-05 12:57:36 -0800 | [diff] [blame] | 225 | auto surfaceFrame1 = |
| 226 | mFrameTimeline->createSurfaceFrameForToken({}, sPidOne, sUidOne, sLayerIdOne, |
Adithya Srinivasan | 785addd | 2021-03-09 00:38:00 +0000 | [diff] [blame] | 227 | sLayerNameOne, sLayerNameOne, |
Adithya Srinivasan | 58069dc | 2021-06-04 20:37:02 +0000 | [diff] [blame] | 228 | /*isBuffer*/ true, sGameMode); |
Alec Mouri | adebf5c | 2021-01-05 12:57:36 -0800 | [diff] [blame] | 229 | auto surfaceFrame2 = |
| 230 | mFrameTimeline->createSurfaceFrameForToken({}, sPidTwo, sUidOne, sLayerIdOne, |
Adithya Srinivasan | 785addd | 2021-03-09 00:38:00 +0000 | [diff] [blame] | 231 | sLayerNameOne, sLayerNameOne, |
Adithya Srinivasan | 58069dc | 2021-06-04 20:37:02 +0000 | [diff] [blame] | 232 | /*isBuffer*/ true, sGameMode); |
Adithya Srinivasan | 9febda8 | 2020-10-19 10:49:41 -0700 | [diff] [blame] | 233 | EXPECT_EQ(surfaceFrame1->getOwnerPid(), sPidOne); |
| 234 | EXPECT_EQ(surfaceFrame2->getOwnerPid(), sPidTwo); |
| 235 | } |
| 236 | |
Adithya Srinivasan | f279e04 | 2020-08-17 14:56:27 -0700 | [diff] [blame] | 237 | TEST_F(FrameTimelineTest, createSurfaceFrameForToken_noToken) { |
Alec Mouri | adebf5c | 2021-01-05 12:57:36 -0800 | [diff] [blame] | 238 | auto surfaceFrame = |
| 239 | mFrameTimeline->createSurfaceFrameForToken({}, sPidOne, sUidOne, sLayerIdOne, |
Adithya Srinivasan | 785addd | 2021-03-09 00:38:00 +0000 | [diff] [blame] | 240 | sLayerNameOne, sLayerNameOne, |
Adithya Srinivasan | 58069dc | 2021-06-04 20:37:02 +0000 | [diff] [blame] | 241 | /*isBuffer*/ true, sGameMode); |
Adithya Srinivasan | f279e04 | 2020-08-17 14:56:27 -0700 | [diff] [blame] | 242 | EXPECT_EQ(surfaceFrame->getPredictionState(), PredictionState::None); |
| 243 | } |
| 244 | |
| 245 | TEST_F(FrameTimelineTest, createSurfaceFrameForToken_expiredToken) { |
| 246 | int64_t token1 = mTokenManager->generateTokenForPredictions({0, 0, 0}); |
Adithya Srinivasan | bed4c4f | 2021-05-03 20:24:46 +0000 | [diff] [blame] | 247 | flushTokens(); |
Huihong Luo | 3bdef86 | 2022-03-03 11:57:19 -0800 | [diff] [blame] | 248 | FrameTimelineInfo ftInfo; |
| 249 | ftInfo.vsyncId = token1; |
| 250 | ftInfo.inputEventId = sInputEventId; |
Siarhei Vishniakou | fc434ac | 2021-01-13 10:28:00 -1000 | [diff] [blame] | 251 | auto surfaceFrame = |
Huihong Luo | 3bdef86 | 2022-03-03 11:57:19 -0800 | [diff] [blame] | 252 | mFrameTimeline->createSurfaceFrameForToken(ftInfo, sPidOne, sUidOne, sLayerIdOne, |
| 253 | sLayerNameOne, sLayerNameOne, |
Adithya Srinivasan | 58069dc | 2021-06-04 20:37:02 +0000 | [diff] [blame] | 254 | /*isBuffer*/ true, sGameMode); |
Adithya Srinivasan | f279e04 | 2020-08-17 14:56:27 -0700 | [diff] [blame] | 255 | |
| 256 | EXPECT_EQ(surfaceFrame->getPredictionState(), PredictionState::Expired); |
| 257 | } |
| 258 | |
| 259 | TEST_F(FrameTimelineTest, createSurfaceFrameForToken_validToken) { |
| 260 | int64_t token1 = mTokenManager->generateTokenForPredictions({10, 20, 30}); |
Huihong Luo | 3bdef86 | 2022-03-03 11:57:19 -0800 | [diff] [blame] | 261 | FrameTimelineInfo ftInfo; |
| 262 | ftInfo.vsyncId = token1; |
| 263 | ftInfo.inputEventId = sInputEventId; |
Siarhei Vishniakou | fc434ac | 2021-01-13 10:28:00 -1000 | [diff] [blame] | 264 | auto surfaceFrame = |
Huihong Luo | 3bdef86 | 2022-03-03 11:57:19 -0800 | [diff] [blame] | 265 | mFrameTimeline->createSurfaceFrameForToken(ftInfo, sPidOne, sUidOne, sLayerIdOne, |
| 266 | sLayerNameOne, sLayerNameOne, |
Adithya Srinivasan | 58069dc | 2021-06-04 20:37:02 +0000 | [diff] [blame] | 267 | /*isBuffer*/ true, sGameMode); |
Adithya Srinivasan | f279e04 | 2020-08-17 14:56:27 -0700 | [diff] [blame] | 268 | |
| 269 | EXPECT_EQ(surfaceFrame->getPredictionState(), PredictionState::Valid); |
| 270 | EXPECT_EQ(compareTimelineItems(surfaceFrame->getPredictions(), TimelineItem(10, 20, 30)), true); |
| 271 | } |
| 272 | |
Siarhei Vishniakou | fc434ac | 2021-01-13 10:28:00 -1000 | [diff] [blame] | 273 | TEST_F(FrameTimelineTest, createSurfaceFrameForToken_validInputEventId) { |
| 274 | int64_t token1 = mTokenManager->generateTokenForPredictions({10, 20, 30}); |
| 275 | constexpr int32_t inputEventId = 1; |
Huihong Luo | 3bdef86 | 2022-03-03 11:57:19 -0800 | [diff] [blame] | 276 | FrameTimelineInfo ftInfo; |
| 277 | ftInfo.vsyncId = token1; |
| 278 | ftInfo.inputEventId = inputEventId; |
Siarhei Vishniakou | fc434ac | 2021-01-13 10:28:00 -1000 | [diff] [blame] | 279 | auto surfaceFrame = |
Huihong Luo | 3bdef86 | 2022-03-03 11:57:19 -0800 | [diff] [blame] | 280 | mFrameTimeline->createSurfaceFrameForToken(ftInfo, sPidOne, sUidOne, sLayerIdOne, |
| 281 | sLayerNameOne, sLayerNameOne, |
Adithya Srinivasan | 58069dc | 2021-06-04 20:37:02 +0000 | [diff] [blame] | 282 | /*isBuffer*/ true, sGameMode); |
Siarhei Vishniakou | fc434ac | 2021-01-13 10:28:00 -1000 | [diff] [blame] | 283 | |
| 284 | EXPECT_EQ(inputEventId, surfaceFrame->getInputEventId()); |
| 285 | } |
| 286 | |
Adithya Srinivasan | f279e04 | 2020-08-17 14:56:27 -0700 | [diff] [blame] | 287 | TEST_F(FrameTimelineTest, presentFenceSignaled_droppedFramesNotUpdated) { |
| 288 | auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
Adithya Srinivasan | f279e04 | 2020-08-17 14:56:27 -0700 | [diff] [blame] | 289 | int64_t token1 = mTokenManager->generateTokenForPredictions({10, 20, 30}); |
Huihong Luo | 3bdef86 | 2022-03-03 11:57:19 -0800 | [diff] [blame] | 290 | FrameTimelineInfo ftInfo; |
| 291 | ftInfo.vsyncId = token1; |
| 292 | ftInfo.inputEventId = sInputEventId; |
Siarhei Vishniakou | fc434ac | 2021-01-13 10:28:00 -1000 | [diff] [blame] | 293 | auto surfaceFrame1 = |
Huihong Luo | 3bdef86 | 2022-03-03 11:57:19 -0800 | [diff] [blame] | 294 | mFrameTimeline->createSurfaceFrameForToken(ftInfo, sPidOne, sUidOne, sLayerIdOne, |
| 295 | sLayerNameOne, sLayerNameOne, |
Adithya Srinivasan | 58069dc | 2021-06-04 20:37:02 +0000 | [diff] [blame] | 296 | /*isBuffer*/ true, sGameMode); |
Adithya Srinivasan | f279e04 | 2020-08-17 14:56:27 -0700 | [diff] [blame] | 297 | |
| 298 | // Set up the display frame |
Pascal Muetschard | ac7bcd9 | 2023-10-03 15:05:36 +0200 | [diff] [blame] | 299 | mFrameTimeline->setSfWakeUp(token1, 20, RR_11, RR_11); |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 300 | surfaceFrame1->setDropTime(12); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 301 | surfaceFrame1->setPresentState(SurfaceFrame::PresentState::Dropped); |
| 302 | mFrameTimeline->addSurfaceFrame(surfaceFrame1); |
Adithya Srinivasan | f279e04 | 2020-08-17 14:56:27 -0700 | [diff] [blame] | 303 | mFrameTimeline->setSfPresent(25, presentFence1); |
| 304 | presentFence1->signalForTest(30); |
| 305 | |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 306 | addEmptyDisplayFrame(); |
Adithya Srinivasan | f279e04 | 2020-08-17 14:56:27 -0700 | [diff] [blame] | 307 | |
| 308 | auto& droppedSurfaceFrame = getSurfaceFrame(0, 0); |
| 309 | EXPECT_EQ(droppedSurfaceFrame.getPresentState(), SurfaceFrame::PresentState::Dropped); |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 310 | EXPECT_EQ(0u, droppedSurfaceFrame.getActuals().endTime); |
| 311 | EXPECT_EQ(12u, droppedSurfaceFrame.getDropTime()); |
Adithya Srinivasan | f279e04 | 2020-08-17 14:56:27 -0700 | [diff] [blame] | 312 | EXPECT_EQ(droppedSurfaceFrame.getActuals().presentTime, 0); |
| 313 | } |
| 314 | |
| 315 | TEST_F(FrameTimelineTest, presentFenceSignaled_presentedFramesUpdated) { |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 316 | // Layer specific increment |
Alec Mouri | 363faf0 | 2021-01-29 16:34:55 -0800 | [diff] [blame] | 317 | EXPECT_CALL(*mTimeStats, incrementJankyFrames(_)).Times(2); |
Adithya Srinivasan | f279e04 | 2020-08-17 14:56:27 -0700 | [diff] [blame] | 318 | auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
| 319 | int64_t surfaceFrameToken1 = mTokenManager->generateTokenForPredictions({10, 20, 30}); |
Adithya Srinivasan | f279e04 | 2020-08-17 14:56:27 -0700 | [diff] [blame] | 320 | int64_t sfToken1 = mTokenManager->generateTokenForPredictions({22, 26, 30}); |
Huihong Luo | 3bdef86 | 2022-03-03 11:57:19 -0800 | [diff] [blame] | 321 | FrameTimelineInfo ftInfo; |
| 322 | ftInfo.vsyncId = surfaceFrameToken1; |
| 323 | ftInfo.inputEventId = sInputEventId; |
Alec Mouri | 9a29e67 | 2020-09-14 12:39:14 -0700 | [diff] [blame] | 324 | auto surfaceFrame1 = |
Huihong Luo | 3bdef86 | 2022-03-03 11:57:19 -0800 | [diff] [blame] | 325 | mFrameTimeline->createSurfaceFrameForToken(ftInfo, sPidOne, sUidOne, sLayerIdOne, |
| 326 | sLayerNameOne, sLayerNameOne, |
| 327 | /*isBuffer*/ true, sGameMode); |
Alec Mouri | 9a29e67 | 2020-09-14 12:39:14 -0700 | [diff] [blame] | 328 | auto surfaceFrame2 = |
Huihong Luo | 3bdef86 | 2022-03-03 11:57:19 -0800 | [diff] [blame] | 329 | mFrameTimeline->createSurfaceFrameForToken(ftInfo, sPidOne, sUidOne, sLayerIdTwo, |
| 330 | sLayerNameTwo, sLayerNameTwo, |
| 331 | /*isBuffer*/ true, sGameMode); |
Pascal Muetschard | ac7bcd9 | 2023-10-03 15:05:36 +0200 | [diff] [blame] | 332 | mFrameTimeline->setSfWakeUp(sfToken1, 22, RR_11, RR_11); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 333 | surfaceFrame1->setPresentState(SurfaceFrame::PresentState::Presented); |
| 334 | mFrameTimeline->addSurfaceFrame(surfaceFrame1); |
| 335 | surfaceFrame2->setPresentState(SurfaceFrame::PresentState::Presented); |
| 336 | mFrameTimeline->addSurfaceFrame(surfaceFrame2); |
Adithya Srinivasan | f279e04 | 2020-08-17 14:56:27 -0700 | [diff] [blame] | 337 | mFrameTimeline->setSfPresent(26, presentFence1); |
| 338 | auto displayFrame = getDisplayFrame(0); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 339 | auto& presentedSurfaceFrame1 = getSurfaceFrame(0, 0); |
| 340 | auto& presentedSurfaceFrame2 = getSurfaceFrame(0, 1); |
Adithya Srinivasan | f279e04 | 2020-08-17 14:56:27 -0700 | [diff] [blame] | 341 | presentFence1->signalForTest(42); |
| 342 | |
| 343 | // Fences haven't been flushed yet, so it should be 0 |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 344 | EXPECT_EQ(displayFrame->getActuals().presentTime, 0); |
Adithya Srinivasan | f279e04 | 2020-08-17 14:56:27 -0700 | [diff] [blame] | 345 | EXPECT_EQ(presentedSurfaceFrame1.getActuals().presentTime, 0); |
| 346 | EXPECT_EQ(presentedSurfaceFrame2.getActuals().presentTime, 0); |
| 347 | |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 348 | addEmptyDisplayFrame(); |
Adithya Srinivasan | f279e04 | 2020-08-17 14:56:27 -0700 | [diff] [blame] | 349 | |
| 350 | // Fences have flushed, so the present timestamps should be updated |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 351 | EXPECT_EQ(displayFrame->getActuals().presentTime, 42); |
Adithya Srinivasan | f279e04 | 2020-08-17 14:56:27 -0700 | [diff] [blame] | 352 | EXPECT_EQ(presentedSurfaceFrame1.getActuals().presentTime, 42); |
| 353 | EXPECT_EQ(presentedSurfaceFrame2.getActuals().presentTime, 42); |
Jorim Jaggi | 9c03b50 | 2020-11-24 23:51:31 +0100 | [diff] [blame] | 354 | EXPECT_NE(surfaceFrame1->getJankType(), std::nullopt); |
Ying Wei | 96eb535 | 2023-11-21 17:37:21 +0000 | [diff] [blame] | 355 | EXPECT_NE(surfaceFrame1->getJankSeverityType(), std::nullopt); |
Jorim Jaggi | 9c03b50 | 2020-11-24 23:51:31 +0100 | [diff] [blame] | 356 | EXPECT_NE(surfaceFrame2->getJankType(), std::nullopt); |
Ying Wei | 96eb535 | 2023-11-21 17:37:21 +0000 | [diff] [blame] | 357 | EXPECT_NE(surfaceFrame2->getJankSeverityType(), std::nullopt); |
Pascal Mütschard | d56514e | 2024-05-24 17:37:13 +0200 | [diff] [blame^] | 358 | |
| 359 | EXPECT_EQ(getLayerOneJankData().size(), 1u); |
| 360 | EXPECT_EQ(getLayerTwoJankData().size(), 1u); |
Adithya Srinivasan | f279e04 | 2020-08-17 14:56:27 -0700 | [diff] [blame] | 361 | } |
| 362 | |
Ady Abraham | 14beed7 | 2024-05-15 17:16:45 -0700 | [diff] [blame] | 363 | TEST_F(FrameTimelineTest, displayFrameSkippedComposition) { |
| 364 | // Layer specific increment |
| 365 | EXPECT_CALL(*mTimeStats, incrementJankyFrames(_)).Times(1); |
| 366 | auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
| 367 | int64_t surfaceFrameToken1 = mTokenManager->generateTokenForPredictions({10, 20, 30}); |
| 368 | int64_t sfToken1 = mTokenManager->generateTokenForPredictions({22, 26, 30}); |
| 369 | FrameTimelineInfo ftInfo; |
| 370 | ftInfo.vsyncId = surfaceFrameToken1; |
| 371 | ftInfo.inputEventId = sInputEventId; |
| 372 | auto surfaceFrame1 = |
| 373 | mFrameTimeline->createSurfaceFrameForToken(ftInfo, sPidOne, sUidOne, sLayerIdOne, |
| 374 | sLayerNameOne, sLayerNameOne, |
| 375 | /*isBuffer*/ true, sGameMode); |
| 376 | auto surfaceFrame2 = |
| 377 | mFrameTimeline->createSurfaceFrameForToken(ftInfo, sPidOne, sUidOne, sLayerIdTwo, |
| 378 | sLayerNameTwo, sLayerNameTwo, |
| 379 | /*isBuffer*/ true, sGameMode); |
| 380 | |
| 381 | mFrameTimeline->setSfWakeUp(sfToken1, 22, RR_11, RR_11); |
| 382 | surfaceFrame1->setPresentState(SurfaceFrame::PresentState::Presented); |
| 383 | mFrameTimeline->addSurfaceFrame(surfaceFrame1); |
| 384 | mFrameTimeline->onCommitNotComposited(); |
| 385 | |
| 386 | EXPECT_EQ(surfaceFrame1->getActuals().presentTime, 30); |
| 387 | ASSERT_NE(surfaceFrame1->getJankType(), std::nullopt); |
| 388 | EXPECT_EQ(*surfaceFrame1->getJankType(), JankType::None); |
| 389 | ASSERT_NE(surfaceFrame1->getJankSeverityType(), std::nullopt); |
| 390 | EXPECT_EQ(*surfaceFrame1->getJankSeverityType(), JankSeverityType::None); |
| 391 | |
| 392 | mFrameTimeline->setSfWakeUp(sfToken1, 22, RR_11, RR_11); |
| 393 | surfaceFrame2->setPresentState(SurfaceFrame::PresentState::Presented); |
| 394 | mFrameTimeline->addSurfaceFrame(surfaceFrame2); |
| 395 | mFrameTimeline->setSfPresent(26, presentFence1); |
| 396 | |
| 397 | auto displayFrame = getDisplayFrame(0); |
| 398 | auto& presentedSurfaceFrame2 = getSurfaceFrame(0, 0); |
| 399 | presentFence1->signalForTest(42); |
| 400 | |
| 401 | // Fences haven't been flushed yet, so it should be 0 |
| 402 | EXPECT_EQ(displayFrame->getActuals().presentTime, 0); |
| 403 | EXPECT_EQ(presentedSurfaceFrame2.getActuals().presentTime, 0); |
| 404 | |
| 405 | addEmptyDisplayFrame(); |
| 406 | |
| 407 | // Fences have flushed, so the present timestamps should be updated |
| 408 | EXPECT_EQ(displayFrame->getActuals().presentTime, 42); |
| 409 | EXPECT_EQ(presentedSurfaceFrame2.getActuals().presentTime, 42); |
| 410 | EXPECT_NE(surfaceFrame2->getJankType(), std::nullopt); |
| 411 | EXPECT_NE(surfaceFrame2->getJankSeverityType(), std::nullopt); |
| 412 | } |
| 413 | |
Adithya Srinivasan | f279e04 | 2020-08-17 14:56:27 -0700 | [diff] [blame] | 414 | TEST_F(FrameTimelineTest, displayFramesSlidingWindowMovesAfterLimit) { |
| 415 | // Insert kMaxDisplayFrames' count of DisplayFrames to fill the deque |
| 416 | int frameTimeFactor = 0; |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 417 | // Layer specific increment |
Alec Mouri | 363faf0 | 2021-01-29 16:34:55 -0800 | [diff] [blame] | 418 | EXPECT_CALL(*mTimeStats, incrementJankyFrames(_)) |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 419 | .Times(static_cast<int32_t>(*maxDisplayFrames)); |
Adithya Srinivasan | 2d73632 | 2020-10-01 16:53:48 -0700 | [diff] [blame] | 420 | for (size_t i = 0; i < *maxDisplayFrames; i++) { |
Adithya Srinivasan | f279e04 | 2020-08-17 14:56:27 -0700 | [diff] [blame] | 421 | auto presentFence = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
| 422 | int64_t surfaceFrameToken = mTokenManager->generateTokenForPredictions( |
| 423 | {10 + frameTimeFactor, 20 + frameTimeFactor, 30 + frameTimeFactor}); |
| 424 | int64_t sfToken = mTokenManager->generateTokenForPredictions( |
| 425 | {22 + frameTimeFactor, 26 + frameTimeFactor, 30 + frameTimeFactor}); |
Huihong Luo | 3bdef86 | 2022-03-03 11:57:19 -0800 | [diff] [blame] | 426 | FrameTimelineInfo ftInfo; |
| 427 | ftInfo.vsyncId = surfaceFrameToken; |
| 428 | ftInfo.inputEventId = sInputEventId; |
Alec Mouri | 9a29e67 | 2020-09-14 12:39:14 -0700 | [diff] [blame] | 429 | auto surfaceFrame = |
Huihong Luo | 3bdef86 | 2022-03-03 11:57:19 -0800 | [diff] [blame] | 430 | mFrameTimeline->createSurfaceFrameForToken(ftInfo, sPidOne, sUidOne, sLayerIdOne, |
Adithya Srinivasan | 785addd | 2021-03-09 00:38:00 +0000 | [diff] [blame] | 431 | sLayerNameOne, sLayerNameOne, |
Adithya Srinivasan | 58069dc | 2021-06-04 20:37:02 +0000 | [diff] [blame] | 432 | /*isBuffer*/ true, sGameMode); |
Pascal Muetschard | ac7bcd9 | 2023-10-03 15:05:36 +0200 | [diff] [blame] | 433 | mFrameTimeline->setSfWakeUp(sfToken, 22 + frameTimeFactor, RR_11, RR_11); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 434 | surfaceFrame->setPresentState(SurfaceFrame::PresentState::Presented); |
| 435 | mFrameTimeline->addSurfaceFrame(surfaceFrame); |
Adithya Srinivasan | f279e04 | 2020-08-17 14:56:27 -0700 | [diff] [blame] | 436 | mFrameTimeline->setSfPresent(27 + frameTimeFactor, presentFence); |
| 437 | presentFence->signalForTest(32 + frameTimeFactor); |
| 438 | frameTimeFactor += 30; |
| 439 | } |
| 440 | auto displayFrame0 = getDisplayFrame(0); |
| 441 | |
| 442 | // The 0th Display Frame should have actuals 22, 27, 32 |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 443 | EXPECT_EQ(compareTimelineItems(displayFrame0->getActuals(), TimelineItem(22, 27, 32)), true); |
Adithya Srinivasan | f279e04 | 2020-08-17 14:56:27 -0700 | [diff] [blame] | 444 | |
| 445 | // Add one more display frame |
| 446 | auto presentFence = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
| 447 | int64_t surfaceFrameToken = mTokenManager->generateTokenForPredictions( |
| 448 | {10 + frameTimeFactor, 20 + frameTimeFactor, 30 + frameTimeFactor}); |
| 449 | int64_t sfToken = mTokenManager->generateTokenForPredictions( |
| 450 | {22 + frameTimeFactor, 26 + frameTimeFactor, 30 + frameTimeFactor}); |
Huihong Luo | 3bdef86 | 2022-03-03 11:57:19 -0800 | [diff] [blame] | 451 | FrameTimelineInfo ftInfo; |
| 452 | ftInfo.vsyncId = surfaceFrameToken; |
| 453 | ftInfo.inputEventId = sInputEventId; |
Alec Mouri | 9a29e67 | 2020-09-14 12:39:14 -0700 | [diff] [blame] | 454 | auto surfaceFrame = |
Huihong Luo | 3bdef86 | 2022-03-03 11:57:19 -0800 | [diff] [blame] | 455 | mFrameTimeline->createSurfaceFrameForToken(ftInfo, sPidOne, sUidOne, sLayerIdOne, |
| 456 | sLayerNameOne, sLayerNameOne, |
| 457 | /*isBuffer*/ true, sGameMode); |
Pascal Muetschard | ac7bcd9 | 2023-10-03 15:05:36 +0200 | [diff] [blame] | 458 | mFrameTimeline->setSfWakeUp(sfToken, 22 + frameTimeFactor, RR_11, RR_11); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 459 | surfaceFrame->setPresentState(SurfaceFrame::PresentState::Presented); |
| 460 | mFrameTimeline->addSurfaceFrame(surfaceFrame); |
Adithya Srinivasan | f279e04 | 2020-08-17 14:56:27 -0700 | [diff] [blame] | 461 | mFrameTimeline->setSfPresent(27 + frameTimeFactor, presentFence); |
| 462 | presentFence->signalForTest(32 + frameTimeFactor); |
| 463 | displayFrame0 = getDisplayFrame(0); |
| 464 | |
| 465 | // The window should have slided by 1 now and the previous 0th display frame |
| 466 | // should have been removed from the deque |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 467 | EXPECT_EQ(compareTimelineItems(displayFrame0->getActuals(), TimelineItem(52, 57, 62)), true); |
Pascal Mütschard | d56514e | 2024-05-24 17:37:13 +0200 | [diff] [blame^] | 468 | |
| 469 | EXPECT_EQ(getLayerOneJankData().size(), *maxDisplayFrames); |
Adithya Srinivasan | f279e04 | 2020-08-17 14:56:27 -0700 | [diff] [blame] | 470 | } |
| 471 | |
Ady Abraham | 7f8a1e6 | 2020-09-28 16:09:35 -0700 | [diff] [blame] | 472 | TEST_F(FrameTimelineTest, surfaceFrameEndTimeAcquireFenceAfterQueue) { |
Adithya Srinivasan | 58069dc | 2021-06-04 20:37:02 +0000 | [diff] [blame] | 473 | auto surfaceFrame = mFrameTimeline->createSurfaceFrameForToken({}, sPidOne, 0, sLayerIdOne, |
| 474 | "acquireFenceAfterQueue", |
| 475 | "acquireFenceAfterQueue", |
| 476 | /*isBuffer*/ true, sGameMode); |
Ady Abraham | 7f8a1e6 | 2020-09-28 16:09:35 -0700 | [diff] [blame] | 477 | surfaceFrame->setActualQueueTime(123); |
| 478 | surfaceFrame->setAcquireFenceTime(456); |
| 479 | EXPECT_EQ(surfaceFrame->getActuals().endTime, 456); |
| 480 | } |
| 481 | |
| 482 | TEST_F(FrameTimelineTest, surfaceFrameEndTimeAcquireFenceBeforeQueue) { |
Adithya Srinivasan | 58069dc | 2021-06-04 20:37:02 +0000 | [diff] [blame] | 483 | auto surfaceFrame = mFrameTimeline->createSurfaceFrameForToken({}, sPidOne, 0, sLayerIdOne, |
| 484 | "acquireFenceAfterQueue", |
| 485 | "acquireFenceAfterQueue", |
| 486 | /*isBuffer*/ true, sGameMode); |
Ady Abraham | 7f8a1e6 | 2020-09-28 16:09:35 -0700 | [diff] [blame] | 487 | surfaceFrame->setActualQueueTime(456); |
| 488 | surfaceFrame->setAcquireFenceTime(123); |
| 489 | EXPECT_EQ(surfaceFrame->getActuals().endTime, 456); |
| 490 | } |
| 491 | |
Adithya Srinivasan | 2d73632 | 2020-10-01 16:53:48 -0700 | [diff] [blame] | 492 | TEST_F(FrameTimelineTest, setMaxDisplayFramesSetsSizeProperly) { |
| 493 | auto presentFence = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
| 494 | presentFence->signalForTest(2); |
| 495 | |
| 496 | // Size shouldn't exceed maxDisplayFrames - 64 |
| 497 | for (size_t i = 0; i < *maxDisplayFrames + 10; i++) { |
Adithya Srinivasan | 9febda8 | 2020-10-19 10:49:41 -0700 | [diff] [blame] | 498 | auto surfaceFrame = |
Alec Mouri | adebf5c | 2021-01-05 12:57:36 -0800 | [diff] [blame] | 499 | mFrameTimeline->createSurfaceFrameForToken({}, sPidOne, sUidOne, sLayerIdOne, |
Adithya Srinivasan | 785addd | 2021-03-09 00:38:00 +0000 | [diff] [blame] | 500 | sLayerNameOne, sLayerNameOne, |
Adithya Srinivasan | 58069dc | 2021-06-04 20:37:02 +0000 | [diff] [blame] | 501 | /*isBuffer*/ true, sGameMode); |
Adithya Srinivasan | 2d73632 | 2020-10-01 16:53:48 -0700 | [diff] [blame] | 502 | int64_t sfToken = mTokenManager->generateTokenForPredictions({22, 26, 30}); |
Pascal Muetschard | ac7bcd9 | 2023-10-03 15:05:36 +0200 | [diff] [blame] | 503 | mFrameTimeline->setSfWakeUp(sfToken, 22, RR_11, RR_11); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 504 | surfaceFrame->setPresentState(SurfaceFrame::PresentState::Presented); |
| 505 | mFrameTimeline->addSurfaceFrame(surfaceFrame); |
Adithya Srinivasan | 2d73632 | 2020-10-01 16:53:48 -0700 | [diff] [blame] | 506 | mFrameTimeline->setSfPresent(27, presentFence); |
| 507 | } |
| 508 | EXPECT_EQ(getNumberOfDisplayFrames(), *maxDisplayFrames); |
| 509 | |
| 510 | // Increase the size to 256 |
| 511 | mFrameTimeline->setMaxDisplayFrames(256); |
Siarhei Vishniakou | fc434ac | 2021-01-13 10:28:00 -1000 | [diff] [blame] | 512 | EXPECT_EQ(*maxDisplayFrames, 256u); |
Adithya Srinivasan | 2d73632 | 2020-10-01 16:53:48 -0700 | [diff] [blame] | 513 | |
| 514 | for (size_t i = 0; i < *maxDisplayFrames + 10; i++) { |
Adithya Srinivasan | 9febda8 | 2020-10-19 10:49:41 -0700 | [diff] [blame] | 515 | auto surfaceFrame = |
Alec Mouri | adebf5c | 2021-01-05 12:57:36 -0800 | [diff] [blame] | 516 | mFrameTimeline->createSurfaceFrameForToken({}, sPidOne, sUidOne, sLayerIdOne, |
Adithya Srinivasan | 785addd | 2021-03-09 00:38:00 +0000 | [diff] [blame] | 517 | sLayerNameOne, sLayerNameOne, |
Adithya Srinivasan | 58069dc | 2021-06-04 20:37:02 +0000 | [diff] [blame] | 518 | /*isBuffer*/ true, sGameMode); |
Adithya Srinivasan | 2d73632 | 2020-10-01 16:53:48 -0700 | [diff] [blame] | 519 | int64_t sfToken = mTokenManager->generateTokenForPredictions({22, 26, 30}); |
Pascal Muetschard | ac7bcd9 | 2023-10-03 15:05:36 +0200 | [diff] [blame] | 520 | mFrameTimeline->setSfWakeUp(sfToken, 22, RR_11, RR_11); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 521 | surfaceFrame->setPresentState(SurfaceFrame::PresentState::Presented); |
| 522 | mFrameTimeline->addSurfaceFrame(surfaceFrame); |
Adithya Srinivasan | 2d73632 | 2020-10-01 16:53:48 -0700 | [diff] [blame] | 523 | mFrameTimeline->setSfPresent(27, presentFence); |
| 524 | } |
| 525 | EXPECT_EQ(getNumberOfDisplayFrames(), *maxDisplayFrames); |
| 526 | |
| 527 | // Shrink the size to 128 |
| 528 | mFrameTimeline->setMaxDisplayFrames(128); |
Siarhei Vishniakou | fc434ac | 2021-01-13 10:28:00 -1000 | [diff] [blame] | 529 | EXPECT_EQ(*maxDisplayFrames, 128u); |
Adithya Srinivasan | 2d73632 | 2020-10-01 16:53:48 -0700 | [diff] [blame] | 530 | |
| 531 | for (size_t i = 0; i < *maxDisplayFrames + 10; i++) { |
Adithya Srinivasan | 9febda8 | 2020-10-19 10:49:41 -0700 | [diff] [blame] | 532 | auto surfaceFrame = |
Alec Mouri | adebf5c | 2021-01-05 12:57:36 -0800 | [diff] [blame] | 533 | mFrameTimeline->createSurfaceFrameForToken({}, sPidOne, sUidOne, sLayerIdOne, |
Adithya Srinivasan | 785addd | 2021-03-09 00:38:00 +0000 | [diff] [blame] | 534 | sLayerNameOne, sLayerNameOne, |
Adithya Srinivasan | 58069dc | 2021-06-04 20:37:02 +0000 | [diff] [blame] | 535 | /*isBuffer*/ true, sGameMode); |
Adithya Srinivasan | 2d73632 | 2020-10-01 16:53:48 -0700 | [diff] [blame] | 536 | int64_t sfToken = mTokenManager->generateTokenForPredictions({22, 26, 30}); |
Pascal Muetschard | ac7bcd9 | 2023-10-03 15:05:36 +0200 | [diff] [blame] | 537 | mFrameTimeline->setSfWakeUp(sfToken, 22, RR_11, RR_11); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 538 | surfaceFrame->setPresentState(SurfaceFrame::PresentState::Presented); |
| 539 | mFrameTimeline->addSurfaceFrame(surfaceFrame); |
Adithya Srinivasan | 2d73632 | 2020-10-01 16:53:48 -0700 | [diff] [blame] | 540 | mFrameTimeline->setSfPresent(27, presentFence); |
| 541 | } |
| 542 | EXPECT_EQ(getNumberOfDisplayFrames(), *maxDisplayFrames); |
| 543 | } |
Alec Mouri | 9a29e67 | 2020-09-14 12:39:14 -0700 | [diff] [blame] | 544 | |
Adithya Srinivasan | 7c4ac7a | 2021-03-08 23:48:03 +0000 | [diff] [blame] | 545 | TEST_F(FrameTimelineTest, presentFenceSignaled_invalidSignalTime) { |
Pascal Muetschard | ac7bcd9 | 2023-10-03 15:05:36 +0200 | [diff] [blame] | 546 | Fps refreshRate = RR_11; |
Adithya Srinivasan | 7c4ac7a | 2021-03-08 23:48:03 +0000 | [diff] [blame] | 547 | |
| 548 | auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
| 549 | int64_t surfaceFrameToken1 = mTokenManager->generateTokenForPredictions({10, 20, 60}); |
| 550 | int64_t sfToken1 = mTokenManager->generateTokenForPredictions({52, 60, 60}); |
Huihong Luo | 3bdef86 | 2022-03-03 11:57:19 -0800 | [diff] [blame] | 551 | FrameTimelineInfo ftInfo; |
| 552 | ftInfo.vsyncId = surfaceFrameToken1; |
| 553 | ftInfo.inputEventId = sInputEventId; |
Adithya Srinivasan | 7c4ac7a | 2021-03-08 23:48:03 +0000 | [diff] [blame] | 554 | |
| 555 | auto surfaceFrame1 = |
Huihong Luo | 3bdef86 | 2022-03-03 11:57:19 -0800 | [diff] [blame] | 556 | mFrameTimeline->createSurfaceFrameForToken(ftInfo, sPidOne, sUidOne, sLayerIdOne, |
| 557 | sLayerNameOne, sLayerNameOne, |
| 558 | /*isBuffer*/ true, sGameMode); |
Pascal Muetschard | ac7bcd9 | 2023-10-03 15:05:36 +0200 | [diff] [blame] | 559 | mFrameTimeline->setSfWakeUp(sfToken1, 52, refreshRate, refreshRate); |
Adithya Srinivasan | 7c4ac7a | 2021-03-08 23:48:03 +0000 | [diff] [blame] | 560 | surfaceFrame1->setAcquireFenceTime(20); |
| 561 | surfaceFrame1->setPresentState(SurfaceFrame::PresentState::Presented); |
| 562 | mFrameTimeline->addSurfaceFrame(surfaceFrame1); |
| 563 | |
| 564 | mFrameTimeline->setSfPresent(59, presentFence1); |
| 565 | presentFence1->signalForTest(-1); |
| 566 | addEmptyDisplayFrame(); |
| 567 | |
| 568 | auto displayFrame0 = getDisplayFrame(0); |
Ady Abraham | fcb1686 | 2022-10-10 14:35:21 -0700 | [diff] [blame] | 569 | EXPECT_EQ(displayFrame0->getActuals().presentTime, 59); |
Ady Abraham | b1e10d1 | 2023-03-13 15:23:54 -0700 | [diff] [blame] | 570 | EXPECT_EQ(displayFrame0->getJankType(), JankType::Unknown | JankType::DisplayHAL); |
Ying Wei | 96eb535 | 2023-11-21 17:37:21 +0000 | [diff] [blame] | 571 | EXPECT_EQ(displayFrame0->getJankSeverityType(), JankSeverityType::Unknown); |
Adithya Srinivasan | 7c4ac7a | 2021-03-08 23:48:03 +0000 | [diff] [blame] | 572 | EXPECT_EQ(surfaceFrame1->getActuals().presentTime, -1); |
| 573 | EXPECT_EQ(surfaceFrame1->getJankType(), JankType::Unknown); |
Ying Wei | 96eb535 | 2023-11-21 17:37:21 +0000 | [diff] [blame] | 574 | EXPECT_EQ(surfaceFrame1->getJankSeverityType(), JankSeverityType::Unknown); |
Adithya Srinivasan | 7c4ac7a | 2021-03-08 23:48:03 +0000 | [diff] [blame] | 575 | } |
| 576 | |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 577 | // Tests related to TimeStats |
Adithya Srinivasan | 7c4ac7a | 2021-03-08 23:48:03 +0000 | [diff] [blame] | 578 | TEST_F(FrameTimelineTest, presentFenceSignaled_doesNotReportForInvalidTokens) { |
Pascal Muetschard | ac7bcd9 | 2023-10-03 15:05:36 +0200 | [diff] [blame] | 579 | Fps refreshRate = RR_11; |
Adithya Srinivasan | 7c4ac7a | 2021-03-08 23:48:03 +0000 | [diff] [blame] | 580 | EXPECT_CALL(*mTimeStats, incrementJankyFrames(_)).Times(0); |
| 581 | auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
| 582 | int64_t surfaceFrameToken1 = -1; |
| 583 | int64_t sfToken1 = -1; |
Huihong Luo | 3bdef86 | 2022-03-03 11:57:19 -0800 | [diff] [blame] | 584 | FrameTimelineInfo ftInfo; |
| 585 | ftInfo.vsyncId = surfaceFrameToken1; |
| 586 | ftInfo.inputEventId = sInputEventId; |
Adithya Srinivasan | 7c4ac7a | 2021-03-08 23:48:03 +0000 | [diff] [blame] | 587 | |
| 588 | auto surfaceFrame1 = |
Huihong Luo | 3bdef86 | 2022-03-03 11:57:19 -0800 | [diff] [blame] | 589 | mFrameTimeline->createSurfaceFrameForToken(ftInfo, sPidOne, sUidOne, sLayerIdOne, |
| 590 | sLayerNameOne, sLayerNameOne, |
| 591 | /*isBuffer*/ true, sGameMode); |
Pascal Muetschard | ac7bcd9 | 2023-10-03 15:05:36 +0200 | [diff] [blame] | 592 | mFrameTimeline->setSfWakeUp(sfToken1, 52, refreshRate, refreshRate); |
Adithya Srinivasan | 7c4ac7a | 2021-03-08 23:48:03 +0000 | [diff] [blame] | 593 | surfaceFrame1->setAcquireFenceTime(20); |
| 594 | surfaceFrame1->setPresentState(SurfaceFrame::PresentState::Presented); |
| 595 | mFrameTimeline->addSurfaceFrame(surfaceFrame1); |
| 596 | presentFence1->signalForTest(70); |
| 597 | |
| 598 | mFrameTimeline->setSfPresent(59, presentFence1); |
Pascal Mütschard | d56514e | 2024-05-24 17:37:13 +0200 | [diff] [blame^] | 599 | |
| 600 | EXPECT_EQ(getLayerOneJankData().size(), 0u); |
Adithya Srinivasan | 7c4ac7a | 2021-03-08 23:48:03 +0000 | [diff] [blame] | 601 | } |
| 602 | |
Alec Mouri | 9a29e67 | 2020-09-14 12:39:14 -0700 | [diff] [blame] | 603 | TEST_F(FrameTimelineTest, presentFenceSignaled_reportsLongSfCpu) { |
Pascal Muetschard | ac7bcd9 | 2023-10-03 15:05:36 +0200 | [diff] [blame] | 604 | Fps refreshRate = RR_11; |
Alec Mouri | 9a29e67 | 2020-09-14 12:39:14 -0700 | [diff] [blame] | 605 | EXPECT_CALL(*mTimeStats, |
Alec Mouri | 363faf0 | 2021-01-29 16:34:55 -0800 | [diff] [blame] | 606 | incrementJankyFrames( |
| 607 | TimeStats::JankyFramesInfo{refreshRate, std::nullopt, sUidOne, |
Adithya Srinivasan | 58069dc | 2021-06-04 20:37:02 +0000 | [diff] [blame] | 608 | sLayerNameOne, sGameMode, |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 609 | JankType::SurfaceFlingerCpuDeadlineMissed, 2, 10, |
Alec Mouri | 363faf0 | 2021-01-29 16:34:55 -0800 | [diff] [blame] | 610 | 0})); |
Alec Mouri | 9a29e67 | 2020-09-14 12:39:14 -0700 | [diff] [blame] | 611 | auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 612 | int64_t surfaceFrameToken1 = mTokenManager->generateTokenForPredictions({10, 20, 60}); |
| 613 | int64_t sfToken1 = mTokenManager->generateTokenForPredictions({52, 60, 60}); |
Huihong Luo | 3bdef86 | 2022-03-03 11:57:19 -0800 | [diff] [blame] | 614 | FrameTimelineInfo ftInfo; |
| 615 | ftInfo.vsyncId = surfaceFrameToken1; |
| 616 | ftInfo.inputEventId = sInputEventId; |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 617 | |
Alec Mouri | 9a29e67 | 2020-09-14 12:39:14 -0700 | [diff] [blame] | 618 | auto surfaceFrame1 = |
Huihong Luo | 3bdef86 | 2022-03-03 11:57:19 -0800 | [diff] [blame] | 619 | mFrameTimeline->createSurfaceFrameForToken(ftInfo, sPidOne, sUidOne, sLayerIdOne, |
| 620 | sLayerNameOne, sLayerNameOne, |
| 621 | /*isBuffer*/ true, sGameMode); |
Pascal Muetschard | ac7bcd9 | 2023-10-03 15:05:36 +0200 | [diff] [blame] | 622 | mFrameTimeline->setSfWakeUp(sfToken1, 52, refreshRate, refreshRate); |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 623 | surfaceFrame1->setAcquireFenceTime(20); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 624 | surfaceFrame1->setPresentState(SurfaceFrame::PresentState::Presented); |
| 625 | mFrameTimeline->addSurfaceFrame(surfaceFrame1); |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 626 | presentFence1->signalForTest(70); |
Alec Mouri | 9a29e67 | 2020-09-14 12:39:14 -0700 | [diff] [blame] | 627 | |
Adithya Srinivasan | 82eef32 | 2021-04-10 00:06:04 +0000 | [diff] [blame] | 628 | mFrameTimeline->setSfPresent(62, presentFence1); |
Pascal Mütschard | d56514e | 2024-05-24 17:37:13 +0200 | [diff] [blame^] | 629 | |
| 630 | auto jankData = getLayerOneJankData(); |
| 631 | EXPECT_EQ(jankData.size(), 1u); |
| 632 | EXPECT_EQ(jankData[0].jankType, JankType::SurfaceFlingerCpuDeadlineMissed); |
Alec Mouri | 9a29e67 | 2020-09-14 12:39:14 -0700 | [diff] [blame] | 633 | } |
| 634 | |
Adithya Srinivasan | 36b01af | 2021-04-07 22:29:47 +0000 | [diff] [blame] | 635 | TEST_F(FrameTimelineTest, presentFenceSignaled_reportsLongSfGpu) { |
Pascal Muetschard | ac7bcd9 | 2023-10-03 15:05:36 +0200 | [diff] [blame] | 636 | Fps refreshRate = RR_11; |
Adithya Srinivasan | 36b01af | 2021-04-07 22:29:47 +0000 | [diff] [blame] | 637 | EXPECT_CALL(*mTimeStats, |
| 638 | incrementJankyFrames( |
| 639 | TimeStats::JankyFramesInfo{refreshRate, std::nullopt, sUidOne, |
Adithya Srinivasan | 58069dc | 2021-06-04 20:37:02 +0000 | [diff] [blame] | 640 | sLayerNameOne, sGameMode, |
Adithya Srinivasan | 36b01af | 2021-04-07 22:29:47 +0000 | [diff] [blame] | 641 | JankType::SurfaceFlingerGpuDeadlineMissed, 4, 10, |
| 642 | 0})); |
| 643 | auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
| 644 | auto gpuFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
| 645 | int64_t surfaceFrameToken1 = mTokenManager->generateTokenForPredictions({10, 20, 60}); |
| 646 | int64_t sfToken1 = mTokenManager->generateTokenForPredictions({52, 60, 60}); |
Huihong Luo | 3bdef86 | 2022-03-03 11:57:19 -0800 | [diff] [blame] | 647 | FrameTimelineInfo ftInfo; |
| 648 | ftInfo.vsyncId = surfaceFrameToken1; |
| 649 | ftInfo.inputEventId = sInputEventId; |
Adithya Srinivasan | 36b01af | 2021-04-07 22:29:47 +0000 | [diff] [blame] | 650 | |
| 651 | auto surfaceFrame1 = |
Huihong Luo | 3bdef86 | 2022-03-03 11:57:19 -0800 | [diff] [blame] | 652 | mFrameTimeline->createSurfaceFrameForToken(ftInfo, sPidOne, sUidOne, sLayerIdOne, |
| 653 | sLayerNameOne, sLayerNameOne, |
| 654 | /*isBuffer*/ true, sGameMode); |
Pascal Muetschard | ac7bcd9 | 2023-10-03 15:05:36 +0200 | [diff] [blame] | 655 | mFrameTimeline->setSfWakeUp(sfToken1, 52, refreshRate, refreshRate); |
Adithya Srinivasan | 36b01af | 2021-04-07 22:29:47 +0000 | [diff] [blame] | 656 | surfaceFrame1->setAcquireFenceTime(20); |
| 657 | surfaceFrame1->setPresentState(SurfaceFrame::PresentState::Presented); |
| 658 | mFrameTimeline->addSurfaceFrame(surfaceFrame1); |
| 659 | gpuFence1->signalForTest(64); |
| 660 | presentFence1->signalForTest(70); |
| 661 | |
| 662 | mFrameTimeline->setSfPresent(59, presentFence1, gpuFence1); |
Pascal Mütschard | d56514e | 2024-05-24 17:37:13 +0200 | [diff] [blame^] | 663 | |
| 664 | auto jankData = getLayerOneJankData(); |
| 665 | EXPECT_EQ(jankData.size(), 1u); |
| 666 | EXPECT_EQ(jankData[0].jankType, JankType::SurfaceFlingerGpuDeadlineMissed); |
Adithya Srinivasan | 36b01af | 2021-04-07 22:29:47 +0000 | [diff] [blame] | 667 | } |
| 668 | |
Alec Mouri | 9a29e67 | 2020-09-14 12:39:14 -0700 | [diff] [blame] | 669 | TEST_F(FrameTimelineTest, presentFenceSignaled_reportsDisplayMiss) { |
Pascal Muetschard | ac7bcd9 | 2023-10-03 15:05:36 +0200 | [diff] [blame] | 670 | Fps refreshRate = RR_30; |
Alec Mouri | 9a29e67 | 2020-09-14 12:39:14 -0700 | [diff] [blame] | 671 | EXPECT_CALL(*mTimeStats, |
Alec Mouri | 363faf0 | 2021-01-29 16:34:55 -0800 | [diff] [blame] | 672 | incrementJankyFrames(TimeStats::JankyFramesInfo{refreshRate, std::nullopt, sUidOne, |
Adithya Srinivasan | 58069dc | 2021-06-04 20:37:02 +0000 | [diff] [blame] | 673 | sLayerNameOne, sGameMode, |
| 674 | JankType::DisplayHAL, -4, 0, 0})); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 675 | |
Alec Mouri | 9a29e67 | 2020-09-14 12:39:14 -0700 | [diff] [blame] | 676 | auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 677 | int64_t surfaceFrameToken1 = mTokenManager->generateTokenForPredictions({10, 20, 60}); |
| 678 | int64_t sfToken1 = mTokenManager->generateTokenForPredictions({52, 60, 60}); |
Huihong Luo | 3bdef86 | 2022-03-03 11:57:19 -0800 | [diff] [blame] | 679 | FrameTimelineInfo ftInfo; |
| 680 | ftInfo.vsyncId = surfaceFrameToken1; |
| 681 | ftInfo.inputEventId = sInputEventId; |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 682 | |
Alec Mouri | 9a29e67 | 2020-09-14 12:39:14 -0700 | [diff] [blame] | 683 | auto surfaceFrame1 = |
Huihong Luo | 3bdef86 | 2022-03-03 11:57:19 -0800 | [diff] [blame] | 684 | mFrameTimeline->createSurfaceFrameForToken(ftInfo, sPidOne, sUidOne, sLayerIdOne, |
| 685 | sLayerNameOne, sLayerNameOne, |
| 686 | /*isBuffer*/ true, sGameMode); |
Pascal Muetschard | ac7bcd9 | 2023-10-03 15:05:36 +0200 | [diff] [blame] | 687 | mFrameTimeline->setSfWakeUp(sfToken1, 52, refreshRate, refreshRate); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 688 | surfaceFrame1->setPresentState(SurfaceFrame::PresentState::Presented); |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 689 | surfaceFrame1->setAcquireFenceTime(20); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 690 | mFrameTimeline->addSurfaceFrame(surfaceFrame1); |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 691 | presentFence1->signalForTest(90); |
| 692 | mFrameTimeline->setSfPresent(56, presentFence1); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 693 | EXPECT_EQ(surfaceFrame1->getJankType(), JankType::DisplayHAL); |
Ying Wei | 96eb535 | 2023-11-21 17:37:21 +0000 | [diff] [blame] | 694 | EXPECT_EQ(surfaceFrame1->getJankSeverityType(), JankSeverityType::Full); |
Pascal Mütschard | d56514e | 2024-05-24 17:37:13 +0200 | [diff] [blame^] | 695 | |
| 696 | auto jankData = getLayerOneJankData(); |
| 697 | EXPECT_EQ(jankData.size(), 1u); |
| 698 | EXPECT_EQ(jankData[0].jankType, JankType::DisplayHAL); |
Alec Mouri | 9a29e67 | 2020-09-14 12:39:14 -0700 | [diff] [blame] | 699 | } |
| 700 | |
| 701 | TEST_F(FrameTimelineTest, presentFenceSignaled_reportsAppMiss) { |
Dominik Laskowski | 6eab42d | 2021-09-13 14:34:13 -0700 | [diff] [blame] | 702 | Fps refreshRate = 11_Hz; |
Alec Mouri | 9a29e67 | 2020-09-14 12:39:14 -0700 | [diff] [blame] | 703 | EXPECT_CALL(*mTimeStats, |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 704 | incrementJankyFrames(TimeStats::JankyFramesInfo{refreshRate, std::nullopt, sUidOne, |
Adithya Srinivasan | 58069dc | 2021-06-04 20:37:02 +0000 | [diff] [blame] | 705 | sLayerNameOne, sGameMode, |
Adithya Srinivasan | 82eef32 | 2021-04-10 00:06:04 +0000 | [diff] [blame] | 706 | JankType::AppDeadlineMissed, -4, 0, |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 707 | 25})); |
Alec Mouri | 9a29e67 | 2020-09-14 12:39:14 -0700 | [diff] [blame] | 708 | auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 709 | int64_t surfaceFrameToken1 = mTokenManager->generateTokenForPredictions({10, 20, 60}); |
| 710 | int64_t sfToken1 = mTokenManager->generateTokenForPredictions({82, 90, 90}); |
Huihong Luo | 3bdef86 | 2022-03-03 11:57:19 -0800 | [diff] [blame] | 711 | FrameTimelineInfo ftInfo; |
| 712 | ftInfo.vsyncId = surfaceFrameToken1; |
| 713 | ftInfo.inputEventId = sInputEventId; |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 714 | |
Alec Mouri | 9a29e67 | 2020-09-14 12:39:14 -0700 | [diff] [blame] | 715 | auto surfaceFrame1 = |
Huihong Luo | 3bdef86 | 2022-03-03 11:57:19 -0800 | [diff] [blame] | 716 | mFrameTimeline->createSurfaceFrameForToken(ftInfo, sPidOne, sUidOne, sLayerIdOne, |
| 717 | sLayerNameOne, sLayerNameOne, |
| 718 | /*isBuffer*/ true, sGameMode); |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 719 | surfaceFrame1->setAcquireFenceTime(45); |
Pascal Muetschard | ac7bcd9 | 2023-10-03 15:05:36 +0200 | [diff] [blame] | 720 | mFrameTimeline->setSfWakeUp(sfToken1, 52, refreshRate, refreshRate); |
Alec Mouri | 9a29e67 | 2020-09-14 12:39:14 -0700 | [diff] [blame] | 721 | |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 722 | surfaceFrame1->setPresentState(SurfaceFrame::PresentState::Presented); |
| 723 | mFrameTimeline->addSurfaceFrame(surfaceFrame1); |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 724 | presentFence1->signalForTest(90); |
| 725 | mFrameTimeline->setSfPresent(86, presentFence1); |
Jorim Jaggi | 9c03b50 | 2020-11-24 23:51:31 +0100 | [diff] [blame] | 726 | |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 727 | EXPECT_EQ(surfaceFrame1->getJankType(), JankType::AppDeadlineMissed); |
Ying Wei | 96eb535 | 2023-11-21 17:37:21 +0000 | [diff] [blame] | 728 | EXPECT_EQ(surfaceFrame1->getJankSeverityType(), JankSeverityType::Partial); |
Pascal Mütschard | d56514e | 2024-05-24 17:37:13 +0200 | [diff] [blame^] | 729 | |
| 730 | auto jankData = getLayerOneJankData(); |
| 731 | EXPECT_EQ(jankData.size(), 1u); |
| 732 | EXPECT_EQ(jankData[0].jankType, JankType::AppDeadlineMissed); |
Alec Mouri | 9a29e67 | 2020-09-14 12:39:14 -0700 | [diff] [blame] | 733 | } |
| 734 | |
Adithya Srinivasan | ead1716 | 2021-02-18 02:17:37 +0000 | [diff] [blame] | 735 | TEST_F(FrameTimelineTest, presentFenceSignaled_reportsSfScheduling) { |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 736 | Fps refreshRate = Fps::fromPeriodNsecs(32); |
Adithya Srinivasan | ead1716 | 2021-02-18 02:17:37 +0000 | [diff] [blame] | 737 | EXPECT_CALL(*mTimeStats, |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 738 | incrementJankyFrames(TimeStats::JankyFramesInfo{refreshRate, std::nullopt, sUidOne, |
Adithya Srinivasan | 58069dc | 2021-06-04 20:37:02 +0000 | [diff] [blame] | 739 | sLayerNameOne, sGameMode, |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 740 | JankType::SurfaceFlingerScheduling, |
Adithya Srinivasan | 82eef32 | 2021-04-10 00:06:04 +0000 | [diff] [blame] | 741 | -4, 0, -10})); |
Adithya Srinivasan | ead1716 | 2021-02-18 02:17:37 +0000 | [diff] [blame] | 742 | auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 743 | int64_t surfaceFrameToken1 = mTokenManager->generateTokenForPredictions({40, 60, 92}); |
| 744 | int64_t sfToken1 = mTokenManager->generateTokenForPredictions({52, 60, 60}); |
Huihong Luo | 3bdef86 | 2022-03-03 11:57:19 -0800 | [diff] [blame] | 745 | FrameTimelineInfo ftInfo; |
| 746 | ftInfo.vsyncId = surfaceFrameToken1; |
| 747 | ftInfo.inputEventId = sInputEventId; |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 748 | |
Adithya Srinivasan | ead1716 | 2021-02-18 02:17:37 +0000 | [diff] [blame] | 749 | auto surfaceFrame1 = |
Huihong Luo | 3bdef86 | 2022-03-03 11:57:19 -0800 | [diff] [blame] | 750 | mFrameTimeline->createSurfaceFrameForToken(ftInfo, sPidOne, sUidOne, sLayerIdOne, |
| 751 | sLayerNameOne, sLayerNameOne, |
| 752 | /*isBuffer*/ true, sGameMode); |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 753 | surfaceFrame1->setAcquireFenceTime(50); |
Pascal Muetschard | ac7bcd9 | 2023-10-03 15:05:36 +0200 | [diff] [blame] | 754 | mFrameTimeline->setSfWakeUp(sfToken1, 52, refreshRate, refreshRate); |
Adithya Srinivasan | ead1716 | 2021-02-18 02:17:37 +0000 | [diff] [blame] | 755 | |
| 756 | surfaceFrame1->setPresentState(SurfaceFrame::PresentState::Presented); |
| 757 | mFrameTimeline->addSurfaceFrame(surfaceFrame1); |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 758 | presentFence1->signalForTest(60); |
| 759 | mFrameTimeline->setSfPresent(56, presentFence1); |
Adithya Srinivasan | ead1716 | 2021-02-18 02:17:37 +0000 | [diff] [blame] | 760 | |
| 761 | EXPECT_EQ(surfaceFrame1->getJankType(), JankType::SurfaceFlingerScheduling); |
Ying Wei | 96eb535 | 2023-11-21 17:37:21 +0000 | [diff] [blame] | 762 | EXPECT_EQ(surfaceFrame1->getJankSeverityType(), JankSeverityType::Full); |
Pascal Mütschard | d56514e | 2024-05-24 17:37:13 +0200 | [diff] [blame^] | 763 | |
| 764 | auto jankData = getLayerOneJankData(); |
| 765 | EXPECT_EQ(jankData.size(), 1u); |
| 766 | EXPECT_EQ(jankData[0].jankType, JankType::SurfaceFlingerScheduling); |
Adithya Srinivasan | ead1716 | 2021-02-18 02:17:37 +0000 | [diff] [blame] | 767 | } |
| 768 | |
| 769 | TEST_F(FrameTimelineTest, presentFenceSignaled_reportsSfPredictionError) { |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 770 | Fps refreshRate = Fps::fromPeriodNsecs(16); |
Adithya Srinivasan | ead1716 | 2021-02-18 02:17:37 +0000 | [diff] [blame] | 771 | EXPECT_CALL(*mTimeStats, |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 772 | incrementJankyFrames(TimeStats::JankyFramesInfo{refreshRate, std::nullopt, sUidOne, |
Adithya Srinivasan | 58069dc | 2021-06-04 20:37:02 +0000 | [diff] [blame] | 773 | sLayerNameOne, sGameMode, |
Adithya Srinivasan | 82eef32 | 2021-04-10 00:06:04 +0000 | [diff] [blame] | 774 | JankType::PredictionError, -4, 5, |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 775 | 0})); |
Adithya Srinivasan | ead1716 | 2021-02-18 02:17:37 +0000 | [diff] [blame] | 776 | auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 777 | int64_t surfaceFrameToken1 = mTokenManager->generateTokenForPredictions({30, 40, 60}); |
| 778 | int64_t sfToken1 = mTokenManager->generateTokenForPredictions({52, 60, 60}); |
Huihong Luo | 3bdef86 | 2022-03-03 11:57:19 -0800 | [diff] [blame] | 779 | FrameTimelineInfo ftInfo; |
| 780 | ftInfo.vsyncId = surfaceFrameToken1; |
| 781 | ftInfo.inputEventId = sInputEventId; |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 782 | |
Adithya Srinivasan | ead1716 | 2021-02-18 02:17:37 +0000 | [diff] [blame] | 783 | auto surfaceFrame1 = |
Huihong Luo | 3bdef86 | 2022-03-03 11:57:19 -0800 | [diff] [blame] | 784 | mFrameTimeline->createSurfaceFrameForToken(ftInfo, sPidOne, sUidOne, sLayerIdOne, |
| 785 | sLayerNameOne, sLayerNameOne, |
| 786 | /*isBuffer*/ true, sGameMode); |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 787 | surfaceFrame1->setAcquireFenceTime(40); |
Pascal Muetschard | ac7bcd9 | 2023-10-03 15:05:36 +0200 | [diff] [blame] | 788 | mFrameTimeline->setSfWakeUp(sfToken1, 52, refreshRate, refreshRate); |
Adithya Srinivasan | ead1716 | 2021-02-18 02:17:37 +0000 | [diff] [blame] | 789 | |
| 790 | surfaceFrame1->setPresentState(SurfaceFrame::PresentState::Presented); |
| 791 | mFrameTimeline->addSurfaceFrame(surfaceFrame1); |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 792 | presentFence1->signalForTest(65); |
| 793 | mFrameTimeline->setSfPresent(56, presentFence1); |
Adithya Srinivasan | ead1716 | 2021-02-18 02:17:37 +0000 | [diff] [blame] | 794 | |
| 795 | EXPECT_EQ(surfaceFrame1->getJankType(), JankType::PredictionError); |
Ying Wei | 96eb535 | 2023-11-21 17:37:21 +0000 | [diff] [blame] | 796 | EXPECT_EQ(surfaceFrame1->getJankSeverityType(), JankSeverityType::Partial); |
Pascal Mütschard | d56514e | 2024-05-24 17:37:13 +0200 | [diff] [blame^] | 797 | |
| 798 | auto jankData = getLayerOneJankData(); |
| 799 | EXPECT_EQ(jankData.size(), 1u); |
| 800 | EXPECT_EQ(jankData[0].jankType, JankType::PredictionError); |
Adithya Srinivasan | ead1716 | 2021-02-18 02:17:37 +0000 | [diff] [blame] | 801 | } |
| 802 | |
| 803 | TEST_F(FrameTimelineTest, presentFenceSignaled_reportsAppBufferStuffing) { |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 804 | Fps refreshRate = Fps::fromPeriodNsecs(32); |
Adithya Srinivasan | ead1716 | 2021-02-18 02:17:37 +0000 | [diff] [blame] | 805 | EXPECT_CALL(*mTimeStats, |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 806 | incrementJankyFrames(TimeStats::JankyFramesInfo{refreshRate, std::nullopt, sUidOne, |
Adithya Srinivasan | 58069dc | 2021-06-04 20:37:02 +0000 | [diff] [blame] | 807 | sLayerNameOne, sGameMode, |
Adithya Srinivasan | 82eef32 | 2021-04-10 00:06:04 +0000 | [diff] [blame] | 808 | JankType::BufferStuffing, -4, 0, |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 809 | 0})); |
Adithya Srinivasan | ead1716 | 2021-02-18 02:17:37 +0000 | [diff] [blame] | 810 | auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 811 | int64_t surfaceFrameToken1 = mTokenManager->generateTokenForPredictions({30, 40, 58}); |
| 812 | int64_t sfToken1 = mTokenManager->generateTokenForPredictions({82, 90, 90}); |
Huihong Luo | 3bdef86 | 2022-03-03 11:57:19 -0800 | [diff] [blame] | 813 | FrameTimelineInfo ftInfo; |
| 814 | ftInfo.vsyncId = surfaceFrameToken1; |
| 815 | ftInfo.inputEventId = sInputEventId; |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 816 | |
Adithya Srinivasan | ead1716 | 2021-02-18 02:17:37 +0000 | [diff] [blame] | 817 | auto surfaceFrame1 = |
Huihong Luo | 3bdef86 | 2022-03-03 11:57:19 -0800 | [diff] [blame] | 818 | mFrameTimeline->createSurfaceFrameForToken(ftInfo, sPidOne, sUidOne, sLayerIdOne, |
| 819 | sLayerNameOne, sLayerNameOne, |
| 820 | /*isBuffer*/ true, sGameMode); |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 821 | surfaceFrame1->setAcquireFenceTime(40); |
Pascal Muetschard | ac7bcd9 | 2023-10-03 15:05:36 +0200 | [diff] [blame] | 822 | mFrameTimeline->setSfWakeUp(sfToken1, 82, refreshRate, refreshRate); |
Adithya Srinivasan | ead1716 | 2021-02-18 02:17:37 +0000 | [diff] [blame] | 823 | |
| 824 | surfaceFrame1->setPresentState(SurfaceFrame::PresentState::Presented, |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 825 | /*previousLatchTime*/ 56); |
Adithya Srinivasan | ead1716 | 2021-02-18 02:17:37 +0000 | [diff] [blame] | 826 | mFrameTimeline->addSurfaceFrame(surfaceFrame1); |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 827 | presentFence1->signalForTest(90); |
| 828 | mFrameTimeline->setSfPresent(86, presentFence1); |
Adithya Srinivasan | ead1716 | 2021-02-18 02:17:37 +0000 | [diff] [blame] | 829 | |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 830 | EXPECT_EQ(surfaceFrame1->getJankType(), JankType::BufferStuffing); |
Ying Wei | 96eb535 | 2023-11-21 17:37:21 +0000 | [diff] [blame] | 831 | EXPECT_EQ(surfaceFrame1->getJankSeverityType(), JankSeverityType::Full); |
Pascal Mütschard | d56514e | 2024-05-24 17:37:13 +0200 | [diff] [blame^] | 832 | |
| 833 | auto jankData = getLayerOneJankData(); |
| 834 | EXPECT_EQ(jankData.size(), 1u); |
| 835 | EXPECT_EQ(jankData[0].jankType, JankType::BufferStuffing); |
Adithya Srinivasan | ead1716 | 2021-02-18 02:17:37 +0000 | [diff] [blame] | 836 | } |
| 837 | |
Alec Mouri | 363faf0 | 2021-01-29 16:34:55 -0800 | [diff] [blame] | 838 | TEST_F(FrameTimelineTest, presentFenceSignaled_reportsAppMissWithRenderRate) { |
Pascal Muetschard | ac7bcd9 | 2023-10-03 15:05:36 +0200 | [diff] [blame] | 839 | Fps refreshRate = RR_11; |
| 840 | Fps renderRate = RR_30; |
Alec Mouri | 363faf0 | 2021-01-29 16:34:55 -0800 | [diff] [blame] | 841 | EXPECT_CALL(*mTimeStats, |
Adithya Srinivasan | 58069dc | 2021-06-04 20:37:02 +0000 | [diff] [blame] | 842 | incrementJankyFrames(TimeStats::JankyFramesInfo{refreshRate, renderRate, sUidOne, |
| 843 | sLayerNameOne, sGameMode, |
| 844 | JankType::AppDeadlineMissed, -4, 0, |
| 845 | 25})); |
Alec Mouri | 363faf0 | 2021-01-29 16:34:55 -0800 | [diff] [blame] | 846 | auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 847 | int64_t surfaceFrameToken1 = mTokenManager->generateTokenForPredictions({10, 20, 60}); |
| 848 | int64_t sfToken1 = mTokenManager->generateTokenForPredictions({82, 90, 90}); |
Huihong Luo | 3bdef86 | 2022-03-03 11:57:19 -0800 | [diff] [blame] | 849 | FrameTimelineInfo ftInfo; |
| 850 | ftInfo.vsyncId = surfaceFrameToken1; |
| 851 | ftInfo.inputEventId = sInputEventId; |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 852 | |
Alec Mouri | 363faf0 | 2021-01-29 16:34:55 -0800 | [diff] [blame] | 853 | auto surfaceFrame1 = |
Huihong Luo | 3bdef86 | 2022-03-03 11:57:19 -0800 | [diff] [blame] | 854 | mFrameTimeline->createSurfaceFrameForToken(ftInfo, sPidOne, sUidOne, sLayerIdOne, |
| 855 | sLayerNameOne, sLayerNameOne, |
| 856 | /*isBuffer*/ true, sGameMode); |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 857 | surfaceFrame1->setAcquireFenceTime(45); |
Pascal Muetschard | ac7bcd9 | 2023-10-03 15:05:36 +0200 | [diff] [blame] | 858 | mFrameTimeline->setSfWakeUp(sfToken1, 52, refreshRate, refreshRate); |
Alec Mouri | 363faf0 | 2021-01-29 16:34:55 -0800 | [diff] [blame] | 859 | |
| 860 | surfaceFrame1->setPresentState(SurfaceFrame::PresentState::Presented); |
| 861 | surfaceFrame1->setRenderRate(renderRate); |
| 862 | mFrameTimeline->addSurfaceFrame(surfaceFrame1); |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 863 | presentFence1->signalForTest(90); |
| 864 | mFrameTimeline->setSfPresent(86, presentFence1); |
Alec Mouri | 363faf0 | 2021-01-29 16:34:55 -0800 | [diff] [blame] | 865 | |
| 866 | EXPECT_EQ(surfaceFrame1->getJankType(), JankType::AppDeadlineMissed); |
Ying Wei | 96eb535 | 2023-11-21 17:37:21 +0000 | [diff] [blame] | 867 | EXPECT_EQ(surfaceFrame1->getJankSeverityType(), JankSeverityType::Full); |
Pascal Mütschard | d56514e | 2024-05-24 17:37:13 +0200 | [diff] [blame^] | 868 | |
| 869 | auto jankData = getLayerOneJankData(); |
| 870 | EXPECT_EQ(jankData.size(), 1u); |
| 871 | EXPECT_EQ(jankData[0].jankType, JankType::AppDeadlineMissed); |
Alec Mouri | 363faf0 | 2021-01-29 16:34:55 -0800 | [diff] [blame] | 872 | } |
| 873 | |
Adithya Srinivasan | 115ac69 | 2021-03-06 01:21:30 +0000 | [diff] [blame] | 874 | TEST_F(FrameTimelineTest, presentFenceSignaled_displayFramePredictionExpiredPresentsSurfaceFrame) { |
Pascal Muetschard | ac7bcd9 | 2023-10-03 15:05:36 +0200 | [diff] [blame] | 875 | Fps refreshRate = RR_11; |
| 876 | Fps renderRate = RR_30; |
Adithya Srinivasan | 115ac69 | 2021-03-06 01:21:30 +0000 | [diff] [blame] | 877 | |
| 878 | EXPECT_CALL(*mTimeStats, |
Adithya Srinivasan | 8a94550 | 2021-03-19 19:12:32 +0000 | [diff] [blame] | 879 | incrementJankyFrames( |
| 880 | TimeStats::JankyFramesInfo{refreshRate, renderRate, sUidOne, sLayerNameOne, |
Adithya Srinivasan | 58069dc | 2021-06-04 20:37:02 +0000 | [diff] [blame] | 881 | sGameMode, |
Adithya Srinivasan | 8a94550 | 2021-03-19 19:12:32 +0000 | [diff] [blame] | 882 | JankType::Unknown | JankType::AppDeadlineMissed, |
Adithya Srinivasan | de27245 | 2021-04-10 00:21:00 +0000 | [diff] [blame] | 883 | 0, 0, 25})); |
Adithya Srinivasan | 115ac69 | 2021-03-06 01:21:30 +0000 | [diff] [blame] | 884 | auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
| 885 | int64_t surfaceFrameToken1 = mTokenManager->generateTokenForPredictions({10, 20, 60}); |
| 886 | int64_t sfToken1 = mTokenManager->generateTokenForPredictions({82, 90, 90}); |
Huihong Luo | 3bdef86 | 2022-03-03 11:57:19 -0800 | [diff] [blame] | 887 | FrameTimelineInfo ftInfo; |
| 888 | ftInfo.vsyncId = surfaceFrameToken1; |
| 889 | ftInfo.inputEventId = sInputEventId; |
Adithya Srinivasan | 115ac69 | 2021-03-06 01:21:30 +0000 | [diff] [blame] | 890 | |
| 891 | auto surfaceFrame1 = |
Huihong Luo | 3bdef86 | 2022-03-03 11:57:19 -0800 | [diff] [blame] | 892 | mFrameTimeline->createSurfaceFrameForToken(ftInfo, sPidOne, sUidOne, sLayerIdOne, |
| 893 | sLayerNameOne, sLayerNameOne, |
| 894 | /*isBuffer*/ true, sGameMode); |
Adithya Srinivasan | 115ac69 | 2021-03-06 01:21:30 +0000 | [diff] [blame] | 895 | surfaceFrame1->setAcquireFenceTime(45); |
| 896 | // Trigger a prediction expiry |
Adithya Srinivasan | bed4c4f | 2021-05-03 20:24:46 +0000 | [diff] [blame] | 897 | flushTokens(); |
Pascal Muetschard | ac7bcd9 | 2023-10-03 15:05:36 +0200 | [diff] [blame] | 898 | mFrameTimeline->setSfWakeUp(sfToken1, 52, refreshRate, refreshRate); |
Adithya Srinivasan | 115ac69 | 2021-03-06 01:21:30 +0000 | [diff] [blame] | 899 | |
| 900 | surfaceFrame1->setPresentState(SurfaceFrame::PresentState::Presented); |
| 901 | surfaceFrame1->setRenderRate(renderRate); |
| 902 | mFrameTimeline->addSurfaceFrame(surfaceFrame1); |
| 903 | presentFence1->signalForTest(90); |
| 904 | mFrameTimeline->setSfPresent(86, presentFence1); |
| 905 | |
| 906 | auto displayFrame = getDisplayFrame(0); |
| 907 | EXPECT_EQ(displayFrame->getJankType(), JankType::Unknown); |
Ying Wei | 96eb535 | 2023-11-21 17:37:21 +0000 | [diff] [blame] | 908 | EXPECT_EQ(displayFrame->getJankSeverityType(), JankSeverityType::Unknown); |
Adithya Srinivasan | 115ac69 | 2021-03-06 01:21:30 +0000 | [diff] [blame] | 909 | EXPECT_EQ(displayFrame->getFrameStartMetadata(), FrameStartMetadata::UnknownStart); |
| 910 | EXPECT_EQ(displayFrame->getFrameReadyMetadata(), FrameReadyMetadata::UnknownFinish); |
| 911 | EXPECT_EQ(displayFrame->getFramePresentMetadata(), FramePresentMetadata::UnknownPresent); |
| 912 | |
| 913 | EXPECT_EQ(surfaceFrame1->getActuals().presentTime, 90); |
Adithya Srinivasan | 8a94550 | 2021-03-19 19:12:32 +0000 | [diff] [blame] | 914 | EXPECT_EQ(surfaceFrame1->getJankType(), JankType::Unknown | JankType::AppDeadlineMissed); |
Ying Wei | 96eb535 | 2023-11-21 17:37:21 +0000 | [diff] [blame] | 915 | EXPECT_EQ(surfaceFrame1->getJankSeverityType(), JankSeverityType::Full); |
Pascal Mütschard | d56514e | 2024-05-24 17:37:13 +0200 | [diff] [blame^] | 916 | |
| 917 | auto jankData = getLayerOneJankData(); |
| 918 | EXPECT_EQ(jankData.size(), 1u); |
| 919 | EXPECT_EQ(jankData[0].jankType, JankType::Unknown | JankType::AppDeadlineMissed); |
Adithya Srinivasan | 115ac69 | 2021-03-06 01:21:30 +0000 | [diff] [blame] | 920 | } |
| 921 | |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 922 | /* |
| 923 | * Tracing Tests |
| 924 | * |
| 925 | * Trace packets are flushed all the way only when the next packet is traced. |
| 926 | * For example: trace<Display/Surface>Frame() will create a TracePacket but not flush it. Only when |
| 927 | * another TracePacket is created, the previous one is guaranteed to be flushed. The following tests |
| 928 | * will have additional empty frames created for this reason. |
| 929 | */ |
| 930 | TEST_F(FrameTimelineTest, tracing_noPacketsSentWithoutTraceStart) { |
| 931 | auto tracingSession = getTracingSessionForTest(); |
| 932 | auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 933 | int64_t token1 = mTokenManager->generateTokenForPredictions({10, 20, 30}); |
Huihong Luo | 3bdef86 | 2022-03-03 11:57:19 -0800 | [diff] [blame] | 934 | FrameTimelineInfo ftInfo; |
| 935 | ftInfo.vsyncId = token1; |
| 936 | ftInfo.inputEventId = sInputEventId; |
Siarhei Vishniakou | fc434ac | 2021-01-13 10:28:00 -1000 | [diff] [blame] | 937 | auto surfaceFrame1 = |
Huihong Luo | 3bdef86 | 2022-03-03 11:57:19 -0800 | [diff] [blame] | 938 | mFrameTimeline->createSurfaceFrameForToken(ftInfo, sPidOne, sUidOne, sLayerIdOne, |
| 939 | sLayerNameOne, sLayerNameOne, |
Adithya Srinivasan | 58069dc | 2021-06-04 20:37:02 +0000 | [diff] [blame] | 940 | /*isBuffer*/ true, sGameMode); |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 941 | |
| 942 | // Set up the display frame |
Pascal Muetschard | ac7bcd9 | 2023-10-03 15:05:36 +0200 | [diff] [blame] | 943 | mFrameTimeline->setSfWakeUp(token1, 20, RR_11, RR_11); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 944 | surfaceFrame1->setPresentState(SurfaceFrame::PresentState::Dropped); |
| 945 | mFrameTimeline->addSurfaceFrame(surfaceFrame1); |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 946 | mFrameTimeline->setSfPresent(25, presentFence1); |
| 947 | presentFence1->signalForTest(30); |
| 948 | |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 949 | addEmptyDisplayFrame(); |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 950 | |
| 951 | auto packets = readFrameTimelinePacketsBlocking(tracingSession.get()); |
Siarhei Vishniakou | fc434ac | 2021-01-13 10:28:00 -1000 | [diff] [blame] | 952 | EXPECT_EQ(packets.size(), 0u); |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 953 | } |
| 954 | |
| 955 | TEST_F(FrameTimelineTest, tracing_sanityTest) { |
| 956 | auto tracingSession = getTracingSessionForTest(); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 957 | // Layer specific increment |
Alec Mouri | 363faf0 | 2021-01-29 16:34:55 -0800 | [diff] [blame] | 958 | EXPECT_CALL(*mTimeStats, incrementJankyFrames(_)); |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 959 | auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 960 | |
| 961 | tracingSession->StartBlocking(); |
| 962 | int64_t token1 = mTokenManager->generateTokenForPredictions({10, 20, 30}); |
| 963 | int64_t token2 = mTokenManager->generateTokenForPredictions({40, 50, 60}); |
Huihong Luo | 3bdef86 | 2022-03-03 11:57:19 -0800 | [diff] [blame] | 964 | FrameTimelineInfo ftInfo; |
| 965 | ftInfo.vsyncId = token1; |
| 966 | ftInfo.inputEventId = sInputEventId; |
Siarhei Vishniakou | fc434ac | 2021-01-13 10:28:00 -1000 | [diff] [blame] | 967 | auto surfaceFrame1 = |
Huihong Luo | 3bdef86 | 2022-03-03 11:57:19 -0800 | [diff] [blame] | 968 | mFrameTimeline->createSurfaceFrameForToken(ftInfo, sPidOne, sUidOne, sLayerIdOne, |
| 969 | sLayerNameOne, sLayerNameOne, |
Adithya Srinivasan | 58069dc | 2021-06-04 20:37:02 +0000 | [diff] [blame] | 970 | /*isBuffer*/ true, sGameMode); |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 971 | |
| 972 | // Set up the display frame |
Pascal Muetschard | ac7bcd9 | 2023-10-03 15:05:36 +0200 | [diff] [blame] | 973 | mFrameTimeline->setSfWakeUp(token2, 20, RR_11, RR_11); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 974 | surfaceFrame1->setPresentState(SurfaceFrame::PresentState::Presented); |
| 975 | mFrameTimeline->addSurfaceFrame(surfaceFrame1); |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 976 | mFrameTimeline->setSfPresent(25, presentFence1); |
| 977 | presentFence1->signalForTest(30); |
| 978 | |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 979 | addEmptyDisplayFrame(); |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 980 | flushTrace(); |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 981 | tracingSession->StopBlocking(); |
| 982 | |
| 983 | auto packets = readFrameTimelinePacketsBlocking(tracingSession.get()); |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 984 | // Display Frame 1 has 8 packets - 4 from DisplayFrame and 4 from SurfaceFrame. |
Siarhei Vishniakou | fc434ac | 2021-01-13 10:28:00 -1000 | [diff] [blame] | 985 | EXPECT_EQ(packets.size(), 8u); |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 986 | } |
| 987 | |
| 988 | TEST_F(FrameTimelineTest, traceDisplayFrame_invalidTokenDoesNotEmitTracePacket) { |
| 989 | auto tracingSession = getTracingSessionForTest(); |
| 990 | auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 991 | |
| 992 | tracingSession->StartBlocking(); |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 993 | |
| 994 | // Set up the display frame |
Pascal Muetschard | ac7bcd9 | 2023-10-03 15:05:36 +0200 | [diff] [blame] | 995 | mFrameTimeline->setSfWakeUp(-1, 20, RR_11, RR_11); |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 996 | mFrameTimeline->setSfPresent(25, presentFence1); |
| 997 | presentFence1->signalForTest(30); |
| 998 | |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 999 | addEmptyDisplayFrame(); |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 1000 | flushTrace(); |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 1001 | tracingSession->StopBlocking(); |
| 1002 | |
| 1003 | auto packets = readFrameTimelinePacketsBlocking(tracingSession.get()); |
Siarhei Vishniakou | fc434ac | 2021-01-13 10:28:00 -1000 | [diff] [blame] | 1004 | EXPECT_EQ(packets.size(), 0u); |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 1005 | } |
| 1006 | |
| 1007 | TEST_F(FrameTimelineTest, traceSurfaceFrame_invalidTokenDoesNotEmitTracePacket) { |
| 1008 | auto tracingSession = getTracingSessionForTest(); |
| 1009 | auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 1010 | |
| 1011 | tracingSession->StartBlocking(); |
| 1012 | int64_t token1 = mTokenManager->generateTokenForPredictions({10, 20, 30}); |
Alec Mouri | adebf5c | 2021-01-05 12:57:36 -0800 | [diff] [blame] | 1013 | auto surfaceFrame1 = |
| 1014 | mFrameTimeline->createSurfaceFrameForToken({}, sPidOne, sUidOne, sLayerIdOne, |
Adithya Srinivasan | 785addd | 2021-03-09 00:38:00 +0000 | [diff] [blame] | 1015 | sLayerNameOne, sLayerNameOne, |
Adithya Srinivasan | 58069dc | 2021-06-04 20:37:02 +0000 | [diff] [blame] | 1016 | /*isBuffer*/ true, sGameMode); |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 1017 | |
| 1018 | // Set up the display frame |
Pascal Muetschard | ac7bcd9 | 2023-10-03 15:05:36 +0200 | [diff] [blame] | 1019 | mFrameTimeline->setSfWakeUp(token1, 20, RR_11, RR_11); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1020 | surfaceFrame1->setPresentState(SurfaceFrame::PresentState::Dropped); |
| 1021 | mFrameTimeline->addSurfaceFrame(surfaceFrame1); |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 1022 | mFrameTimeline->setSfPresent(25, presentFence1); |
| 1023 | presentFence1->signalForTest(30); |
| 1024 | |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 1025 | addEmptyDisplayFrame(); |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 1026 | flushTrace(); |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 1027 | tracingSession->StopBlocking(); |
| 1028 | |
| 1029 | auto packets = readFrameTimelinePacketsBlocking(tracingSession.get()); |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 1030 | // Display Frame 1 has 4 packets (SurfaceFrame shouldn't be traced since it has an invalid |
| 1031 | // token). |
Siarhei Vishniakou | fc434ac | 2021-01-13 10:28:00 -1000 | [diff] [blame] | 1032 | EXPECT_EQ(packets.size(), 4u); |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 1033 | } |
| 1034 | |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 1035 | ProtoExpectedDisplayFrameStart createProtoExpectedDisplayFrameStart(int64_t cookie, int64_t token, |
| 1036 | pid_t pid) { |
| 1037 | ProtoExpectedDisplayFrameStart proto; |
| 1038 | proto.set_cookie(cookie); |
| 1039 | proto.set_token(token); |
| 1040 | proto.set_pid(pid); |
| 1041 | return proto; |
| 1042 | } |
| 1043 | |
| 1044 | ProtoActualDisplayFrameStart createProtoActualDisplayFrameStart( |
| 1045 | int64_t cookie, int64_t token, pid_t pid, ProtoPresentType presentType, bool onTimeFinish, |
Ying Wei | 96eb535 | 2023-11-21 17:37:21 +0000 | [diff] [blame] | 1046 | bool gpuComposition, ProtoJankType jankType, ProtoJankSeverityType jankSeverityType, |
| 1047 | ProtoPredictionType predictionType) { |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 1048 | ProtoActualDisplayFrameStart proto; |
| 1049 | proto.set_cookie(cookie); |
| 1050 | proto.set_token(token); |
| 1051 | proto.set_pid(pid); |
| 1052 | proto.set_present_type(presentType); |
| 1053 | proto.set_on_time_finish(onTimeFinish); |
| 1054 | proto.set_gpu_composition(gpuComposition); |
| 1055 | proto.set_jank_type(jankType); |
Ying Wei | 96eb535 | 2023-11-21 17:37:21 +0000 | [diff] [blame] | 1056 | proto.set_jank_severity_type(jankSeverityType); |
Adithya Srinivasan | 78e58af | 2021-02-25 00:08:08 +0000 | [diff] [blame] | 1057 | proto.set_prediction_type(predictionType); |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 1058 | return proto; |
| 1059 | } |
| 1060 | |
| 1061 | ProtoExpectedSurfaceFrameStart createProtoExpectedSurfaceFrameStart(int64_t cookie, int64_t token, |
| 1062 | int64_t displayFrameToken, |
| 1063 | pid_t pid, |
| 1064 | std::string layerName) { |
| 1065 | ProtoExpectedSurfaceFrameStart proto; |
| 1066 | proto.set_cookie(cookie); |
| 1067 | proto.set_token(token); |
| 1068 | proto.set_display_frame_token(displayFrameToken); |
| 1069 | proto.set_pid(pid); |
| 1070 | proto.set_layer_name(layerName); |
| 1071 | return proto; |
| 1072 | } |
| 1073 | |
| 1074 | ProtoActualSurfaceFrameStart createProtoActualSurfaceFrameStart( |
| 1075 | int64_t cookie, int64_t token, int64_t displayFrameToken, pid_t pid, std::string layerName, |
| 1076 | ProtoPresentType presentType, bool onTimeFinish, bool gpuComposition, |
Ying Wei | 96eb535 | 2023-11-21 17:37:21 +0000 | [diff] [blame] | 1077 | ProtoJankType jankType, ProtoJankSeverityType jankSeverityType, |
| 1078 | ProtoPredictionType predictionType, bool isBuffer) { |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 1079 | ProtoActualSurfaceFrameStart proto; |
| 1080 | proto.set_cookie(cookie); |
| 1081 | proto.set_token(token); |
| 1082 | proto.set_display_frame_token(displayFrameToken); |
| 1083 | proto.set_pid(pid); |
| 1084 | proto.set_layer_name(layerName); |
| 1085 | proto.set_present_type(presentType); |
| 1086 | proto.set_on_time_finish(onTimeFinish); |
| 1087 | proto.set_gpu_composition(gpuComposition); |
| 1088 | proto.set_jank_type(jankType); |
Ying Wei | 96eb535 | 2023-11-21 17:37:21 +0000 | [diff] [blame] | 1089 | proto.set_jank_severity_type(jankSeverityType); |
Adithya Srinivasan | 78e58af | 2021-02-25 00:08:08 +0000 | [diff] [blame] | 1090 | proto.set_prediction_type(predictionType); |
Adithya Srinivasan | 1f9450c | 2021-06-10 22:39:19 +0000 | [diff] [blame] | 1091 | proto.set_is_buffer(isBuffer); |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 1092 | return proto; |
| 1093 | } |
| 1094 | |
| 1095 | ProtoFrameEnd createProtoFrameEnd(int64_t cookie) { |
| 1096 | ProtoFrameEnd proto; |
| 1097 | proto.set_cookie(cookie); |
| 1098 | return proto; |
| 1099 | } |
| 1100 | |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 1101 | void validateTraceEvent(const ProtoExpectedDisplayFrameStart& received, |
| 1102 | const ProtoExpectedDisplayFrameStart& source) { |
| 1103 | ASSERT_TRUE(received.has_cookie()); |
| 1104 | EXPECT_EQ(received.cookie(), source.cookie()); |
| 1105 | |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 1106 | ASSERT_TRUE(received.has_token()); |
| 1107 | EXPECT_EQ(received.token(), source.token()); |
| 1108 | |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 1109 | ASSERT_TRUE(received.has_pid()); |
| 1110 | EXPECT_EQ(received.pid(), source.pid()); |
| 1111 | } |
| 1112 | |
| 1113 | void validateTraceEvent(const ProtoActualDisplayFrameStart& received, |
| 1114 | const ProtoActualDisplayFrameStart& source) { |
| 1115 | ASSERT_TRUE(received.has_cookie()); |
| 1116 | EXPECT_EQ(received.cookie(), source.cookie()); |
| 1117 | |
| 1118 | ASSERT_TRUE(received.has_token()); |
| 1119 | EXPECT_EQ(received.token(), source.token()); |
| 1120 | |
| 1121 | ASSERT_TRUE(received.has_pid()); |
| 1122 | EXPECT_EQ(received.pid(), source.pid()); |
| 1123 | |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 1124 | ASSERT_TRUE(received.has_present_type()); |
| 1125 | EXPECT_EQ(received.present_type(), source.present_type()); |
| 1126 | ASSERT_TRUE(received.has_on_time_finish()); |
| 1127 | EXPECT_EQ(received.on_time_finish(), source.on_time_finish()); |
| 1128 | ASSERT_TRUE(received.has_gpu_composition()); |
| 1129 | EXPECT_EQ(received.gpu_composition(), source.gpu_composition()); |
| 1130 | ASSERT_TRUE(received.has_jank_type()); |
| 1131 | EXPECT_EQ(received.jank_type(), source.jank_type()); |
Ying Wei | 96eb535 | 2023-11-21 17:37:21 +0000 | [diff] [blame] | 1132 | ASSERT_TRUE(received.has_jank_severity_type()); |
| 1133 | EXPECT_EQ(received.jank_severity_type(), source.jank_severity_type()); |
Adithya Srinivasan | 78e58af | 2021-02-25 00:08:08 +0000 | [diff] [blame] | 1134 | ASSERT_TRUE(received.has_prediction_type()); |
| 1135 | EXPECT_EQ(received.prediction_type(), source.prediction_type()); |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 1136 | } |
| 1137 | |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 1138 | void validateTraceEvent(const ProtoExpectedSurfaceFrameStart& received, |
| 1139 | const ProtoExpectedSurfaceFrameStart& source) { |
| 1140 | ASSERT_TRUE(received.has_cookie()); |
| 1141 | EXPECT_EQ(received.cookie(), source.cookie()); |
| 1142 | |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 1143 | ASSERT_TRUE(received.has_token()); |
| 1144 | EXPECT_EQ(received.token(), source.token()); |
| 1145 | |
| 1146 | ASSERT_TRUE(received.has_display_frame_token()); |
| 1147 | EXPECT_EQ(received.display_frame_token(), source.display_frame_token()); |
| 1148 | |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 1149 | ASSERT_TRUE(received.has_pid()); |
| 1150 | EXPECT_EQ(received.pid(), source.pid()); |
| 1151 | |
| 1152 | ASSERT_TRUE(received.has_layer_name()); |
| 1153 | EXPECT_EQ(received.layer_name(), source.layer_name()); |
| 1154 | } |
| 1155 | |
| 1156 | void validateTraceEvent(const ProtoActualSurfaceFrameStart& received, |
| 1157 | const ProtoActualSurfaceFrameStart& source) { |
| 1158 | ASSERT_TRUE(received.has_cookie()); |
| 1159 | EXPECT_EQ(received.cookie(), source.cookie()); |
| 1160 | |
| 1161 | ASSERT_TRUE(received.has_token()); |
| 1162 | EXPECT_EQ(received.token(), source.token()); |
| 1163 | |
| 1164 | ASSERT_TRUE(received.has_display_frame_token()); |
| 1165 | EXPECT_EQ(received.display_frame_token(), source.display_frame_token()); |
| 1166 | |
| 1167 | ASSERT_TRUE(received.has_pid()); |
| 1168 | EXPECT_EQ(received.pid(), source.pid()); |
| 1169 | |
| 1170 | ASSERT_TRUE(received.has_layer_name()); |
| 1171 | EXPECT_EQ(received.layer_name(), source.layer_name()); |
| 1172 | |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 1173 | ASSERT_TRUE(received.has_present_type()); |
| 1174 | EXPECT_EQ(received.present_type(), source.present_type()); |
| 1175 | ASSERT_TRUE(received.has_on_time_finish()); |
| 1176 | EXPECT_EQ(received.on_time_finish(), source.on_time_finish()); |
| 1177 | ASSERT_TRUE(received.has_gpu_composition()); |
| 1178 | EXPECT_EQ(received.gpu_composition(), source.gpu_composition()); |
| 1179 | ASSERT_TRUE(received.has_jank_type()); |
| 1180 | EXPECT_EQ(received.jank_type(), source.jank_type()); |
Ying Wei | 96eb535 | 2023-11-21 17:37:21 +0000 | [diff] [blame] | 1181 | ASSERT_TRUE(received.has_jank_severity_type()); |
| 1182 | EXPECT_EQ(received.jank_severity_type(), source.jank_severity_type()); |
Adithya Srinivasan | 78e58af | 2021-02-25 00:08:08 +0000 | [diff] [blame] | 1183 | ASSERT_TRUE(received.has_prediction_type()); |
| 1184 | EXPECT_EQ(received.prediction_type(), source.prediction_type()); |
Adithya Srinivasan | 1f9450c | 2021-06-10 22:39:19 +0000 | [diff] [blame] | 1185 | ASSERT_TRUE(received.has_is_buffer()); |
| 1186 | EXPECT_EQ(received.is_buffer(), source.is_buffer()); |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 1187 | } |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 1188 | |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 1189 | void validateTraceEvent(const ProtoFrameEnd& received, const ProtoFrameEnd& source) { |
| 1190 | ASSERT_TRUE(received.has_cookie()); |
| 1191 | EXPECT_EQ(received.cookie(), source.cookie()); |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 1192 | } |
| 1193 | |
Sally Qi | 2269a69 | 2024-05-17 18:02:28 -0700 | [diff] [blame] | 1194 | TEST_F(FrameTimelineTest, traceDisplayFrameNoSkipped) { |
| 1195 | // setup 2 display frames |
| 1196 | // DF 1: [22, 30] -> [0, 11] |
| 1197 | // DF 2: [82, 90] -> SF [5, 16] |
| 1198 | auto tracingSession = getTracingSessionForTest(); |
| 1199 | tracingSession->StartBlocking(); |
| 1200 | int64_t sfToken1 = mTokenManager->generateTokenForPredictions({22, 30, 40}); |
| 1201 | int64_t sfToken2 = mTokenManager->generateTokenForPredictions({82, 90, 100}); |
| 1202 | int64_t surfaceFrameToken1 = mTokenManager->generateTokenForPredictions({0, 11, 25}); |
| 1203 | int64_t surfaceFrameToken2 = mTokenManager->generateTokenForPredictions({5, 16, 30}); |
| 1204 | auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
| 1205 | |
| 1206 | int64_t traceCookie = snoopCurrentTraceCookie(); |
| 1207 | |
| 1208 | // set up 1st display frame |
| 1209 | FrameTimelineInfo ftInfo1; |
| 1210 | ftInfo1.vsyncId = surfaceFrameToken1; |
| 1211 | ftInfo1.inputEventId = sInputEventId; |
| 1212 | auto surfaceFrame1 = |
| 1213 | mFrameTimeline->createSurfaceFrameForToken(ftInfo1, sPidOne, sUidOne, sLayerIdOne, |
| 1214 | sLayerNameOne, sLayerNameOne, |
| 1215 | /*isBuffer*/ true, sGameMode); |
| 1216 | surfaceFrame1->setAcquireFenceTime(11); |
| 1217 | mFrameTimeline->setSfWakeUp(sfToken1, 22, RR_11, RR_30); |
| 1218 | surfaceFrame1->setPresentState(SurfaceFrame::PresentState::Presented); |
| 1219 | mFrameTimeline->addSurfaceFrame(surfaceFrame1); |
| 1220 | mFrameTimeline->setSfPresent(30, presentFence1); |
| 1221 | presentFence1->signalForTest(40); |
| 1222 | |
| 1223 | // Trigger a flush by finalizing the next DisplayFrame |
| 1224 | auto presentFence2 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
| 1225 | FrameTimelineInfo ftInfo2; |
| 1226 | ftInfo2.vsyncId = surfaceFrameToken2; |
| 1227 | ftInfo2.inputEventId = sInputEventId; |
| 1228 | auto surfaceFrame2 = |
| 1229 | mFrameTimeline->createSurfaceFrameForToken(ftInfo2, sPidOne, sUidOne, sLayerIdOne, |
| 1230 | sLayerNameOne, sLayerNameOne, |
| 1231 | /*isBuffer*/ true, sGameMode); |
| 1232 | |
| 1233 | // set up 2nd display frame |
| 1234 | surfaceFrame2->setAcquireFenceTime(16); |
| 1235 | mFrameTimeline->setSfWakeUp(sfToken2, 82, RR_11, RR_30); |
| 1236 | surfaceFrame2->setPresentState(SurfaceFrame::PresentState::Presented); |
| 1237 | mFrameTimeline->addSurfaceFrame(surfaceFrame2); |
| 1238 | mFrameTimeline->setSfPresent(90, presentFence2); |
| 1239 | presentFence2->signalForTest(100); |
| 1240 | |
| 1241 | // the token of skipped Display Frame |
| 1242 | auto protoSkippedActualDisplayFrameStart = |
| 1243 | createProtoActualDisplayFrameStart(traceCookie + 9, 0, kSurfaceFlingerPid, |
| 1244 | FrameTimelineEvent::PRESENT_DROPPED, true, false, |
| 1245 | FrameTimelineEvent::JANK_DROPPED, |
| 1246 | FrameTimelineEvent::SEVERITY_NONE, |
| 1247 | FrameTimelineEvent::PREDICTION_VALID); |
| 1248 | auto protoSkippedActualDisplayFrameEnd = createProtoFrameEnd(traceCookie + 9); |
| 1249 | |
| 1250 | // Trigger a flush by finalizing the next DisplayFrame |
| 1251 | addEmptyDisplayFrame(); |
| 1252 | flushTrace(); |
| 1253 | tracingSession->StopBlocking(); |
| 1254 | |
| 1255 | auto packets = readFrameTimelinePacketsBlocking(tracingSession.get()); |
| 1256 | // 8 Valid Display Frames + 8 Valid Surface Frames + no Skipped Display Frames |
| 1257 | EXPECT_EQ(packets.size(), 16u); |
| 1258 | } |
| 1259 | |
Sally Qi | aa10774 | 2023-09-29 14:53:14 -0700 | [diff] [blame] | 1260 | TEST_F(FrameTimelineTest, traceDisplayFrameSkipped) { |
Sally Qi | f572125 | 2023-11-17 11:14:53 -0800 | [diff] [blame] | 1261 | SET_FLAG_FOR_TEST(com::android::graphics::surfaceflinger::flags::add_sf_skipped_frames_to_trace, |
| 1262 | true); |
| 1263 | |
Sally Qi | aa10774 | 2023-09-29 14:53:14 -0700 | [diff] [blame] | 1264 | // setup 2 display frames |
| 1265 | // DF 1: [22,40] -> [5, 40] |
| 1266 | // DF : [36, 70] (Skipped one, added by the trace) |
| 1267 | // DF 2: [82, 100] -> SF [25, 70] |
| 1268 | auto tracingSession = getTracingSessionForTest(); |
| 1269 | tracingSession->StartBlocking(); |
| 1270 | int64_t sfToken1 = mTokenManager->generateTokenForPredictions({22, 30, 40}); |
| 1271 | int64_t sfToken2 = mTokenManager->generateTokenForPredictions({82, 90, 100}); |
| 1272 | int64_t surfaceFrameToken1 = mTokenManager->generateTokenForPredictions({5, 16, 40}); |
| 1273 | int64_t surfaceFrameToken2 = mTokenManager->generateTokenForPredictions({25, 36, 70}); |
| 1274 | auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
| 1275 | |
| 1276 | int64_t traceCookie = snoopCurrentTraceCookie(); |
| 1277 | |
| 1278 | // set up 1st display frame |
| 1279 | FrameTimelineInfo ftInfo1; |
| 1280 | ftInfo1.vsyncId = surfaceFrameToken1; |
| 1281 | ftInfo1.inputEventId = sInputEventId; |
| 1282 | auto surfaceFrame1 = |
| 1283 | mFrameTimeline->createSurfaceFrameForToken(ftInfo1, sPidOne, sUidOne, sLayerIdOne, |
| 1284 | sLayerNameOne, sLayerNameOne, |
| 1285 | /*isBuffer*/ true, sGameMode); |
| 1286 | surfaceFrame1->setAcquireFenceTime(16); |
| 1287 | mFrameTimeline->setSfWakeUp(sfToken1, 22, RR_11, RR_30); |
| 1288 | surfaceFrame1->setPresentState(SurfaceFrame::PresentState::Presented); |
| 1289 | mFrameTimeline->addSurfaceFrame(surfaceFrame1); |
| 1290 | mFrameTimeline->setSfPresent(30, presentFence1); |
| 1291 | presentFence1->signalForTest(40); |
| 1292 | |
| 1293 | // Trigger a flush by finalizing the next DisplayFrame |
| 1294 | auto presentFence2 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
| 1295 | FrameTimelineInfo ftInfo2; |
| 1296 | ftInfo2.vsyncId = surfaceFrameToken2; |
| 1297 | ftInfo2.inputEventId = sInputEventId; |
| 1298 | auto surfaceFrame2 = |
| 1299 | mFrameTimeline->createSurfaceFrameForToken(ftInfo2, sPidOne, sUidOne, sLayerIdOne, |
| 1300 | sLayerNameOne, sLayerNameOne, |
| 1301 | /*isBuffer*/ true, sGameMode); |
| 1302 | |
| 1303 | // set up 2nd display frame |
| 1304 | surfaceFrame2->setAcquireFenceTime(36); |
| 1305 | mFrameTimeline->setSfWakeUp(sfToken2, 82, RR_11, RR_30); |
| 1306 | surfaceFrame2->setPresentState(SurfaceFrame::PresentState::Presented); |
| 1307 | mFrameTimeline->addSurfaceFrame(surfaceFrame2); |
| 1308 | mFrameTimeline->setSfPresent(90, presentFence2); |
| 1309 | presentFence2->signalForTest(100); |
| 1310 | |
| 1311 | // the token of skipped Display Frame |
| 1312 | auto protoSkippedActualDisplayFrameStart = |
| 1313 | createProtoActualDisplayFrameStart(traceCookie + 9, 0, kSurfaceFlingerPid, |
| 1314 | FrameTimelineEvent::PRESENT_DROPPED, true, false, |
| 1315 | FrameTimelineEvent::JANK_DROPPED, |
Ying Wei | 96eb535 | 2023-11-21 17:37:21 +0000 | [diff] [blame] | 1316 | FrameTimelineEvent::SEVERITY_NONE, |
Sally Qi | aa10774 | 2023-09-29 14:53:14 -0700 | [diff] [blame] | 1317 | FrameTimelineEvent::PREDICTION_VALID); |
| 1318 | auto protoSkippedActualDisplayFrameEnd = createProtoFrameEnd(traceCookie + 9); |
| 1319 | |
| 1320 | // Trigger a flush by finalizing the next DisplayFrame |
| 1321 | addEmptyDisplayFrame(); |
| 1322 | flushTrace(); |
| 1323 | tracingSession->StopBlocking(); |
| 1324 | |
| 1325 | auto packets = readFrameTimelinePacketsBlocking(tracingSession.get()); |
| 1326 | // 8 Valid Display Frames + 8 Valid Surface Frames + 2 Skipped Display Frames |
| 1327 | EXPECT_EQ(packets.size(), 18u); |
| 1328 | |
| 1329 | // Packet - 16: Actual skipped Display Frame Start |
| 1330 | // the timestamp should be equal to the 2nd expected surface frame's end time |
| 1331 | const auto& packet16 = packets[16]; |
| 1332 | ASSERT_TRUE(packet16.has_timestamp()); |
| 1333 | EXPECT_EQ(packet16.timestamp(), 36u); |
| 1334 | ASSERT_TRUE(packet16.has_frame_timeline_event()); |
| 1335 | |
| 1336 | const auto& event16 = packet16.frame_timeline_event(); |
| 1337 | const auto& actualSkippedDisplayFrameStart = event16.actual_display_frame_start(); |
| 1338 | validateTraceEvent(actualSkippedDisplayFrameStart, protoSkippedActualDisplayFrameStart); |
| 1339 | |
| 1340 | // Packet - 17: Actual skipped Display Frame End |
| 1341 | // the timestamp should be equal to the 2nd expected surface frame's present time |
| 1342 | const auto& packet17 = packets[17]; |
| 1343 | ASSERT_TRUE(packet17.has_timestamp()); |
| 1344 | EXPECT_EQ(packet17.timestamp(), 70u); |
| 1345 | ASSERT_TRUE(packet17.has_frame_timeline_event()); |
| 1346 | |
| 1347 | const auto& event17 = packet17.frame_timeline_event(); |
| 1348 | const auto& actualSkippedDisplayFrameEnd = event17.frame_end(); |
| 1349 | validateTraceEvent(actualSkippedDisplayFrameEnd, protoSkippedActualDisplayFrameEnd); |
| 1350 | } |
| 1351 | |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 1352 | TEST_F(FrameTimelineTest, traceDisplayFrame_emitsValidTracePacket) { |
| 1353 | auto tracingSession = getTracingSessionForTest(); |
| 1354 | auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 1355 | |
| 1356 | tracingSession->StartBlocking(); |
Ady Abraham | 57a8ab4 | 2023-01-26 15:28:19 -0800 | [diff] [blame] | 1357 | |
| 1358 | // Add an empty surface frame so that display frame would get traced. |
| 1359 | addEmptySurfaceFrame(); |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 1360 | int64_t displayFrameToken1 = mTokenManager->generateTokenForPredictions({10, 30, 30}); |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 1361 | |
| 1362 | // Set up the display frame |
Pascal Muetschard | ac7bcd9 | 2023-10-03 15:05:36 +0200 | [diff] [blame] | 1363 | mFrameTimeline->setSfWakeUp(displayFrameToken1, 20, RR_11, RR_11); |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 1364 | mFrameTimeline->setSfPresent(26, presentFence1); |
| 1365 | presentFence1->signalForTest(31); |
| 1366 | |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 1367 | int64_t traceCookie = snoopCurrentTraceCookie(); |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 1368 | auto protoExpectedDisplayFrameStart = |
| 1369 | createProtoExpectedDisplayFrameStart(traceCookie + 1, displayFrameToken1, |
| 1370 | kSurfaceFlingerPid); |
| 1371 | auto protoExpectedDisplayFrameEnd = createProtoFrameEnd(traceCookie + 1); |
| 1372 | auto protoActualDisplayFrameStart = |
| 1373 | createProtoActualDisplayFrameStart(traceCookie + 2, displayFrameToken1, |
| 1374 | kSurfaceFlingerPid, |
| 1375 | FrameTimelineEvent::PRESENT_ON_TIME, true, false, |
Adithya Srinivasan | 78e58af | 2021-02-25 00:08:08 +0000 | [diff] [blame] | 1376 | FrameTimelineEvent::JANK_NONE, |
Ying Wei | 96eb535 | 2023-11-21 17:37:21 +0000 | [diff] [blame] | 1377 | FrameTimelineEvent::SEVERITY_NONE, |
Adithya Srinivasan | 78e58af | 2021-02-25 00:08:08 +0000 | [diff] [blame] | 1378 | FrameTimelineEvent::PREDICTION_VALID); |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 1379 | auto protoActualDisplayFrameEnd = createProtoFrameEnd(traceCookie + 2); |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 1380 | |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 1381 | addEmptyDisplayFrame(); |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 1382 | flushTrace(); |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 1383 | tracingSession->StopBlocking(); |
| 1384 | |
| 1385 | auto packets = readFrameTimelinePacketsBlocking(tracingSession.get()); |
Siarhei Vishniakou | fc434ac | 2021-01-13 10:28:00 -1000 | [diff] [blame] | 1386 | EXPECT_EQ(packets.size(), 4u); |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 1387 | |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 1388 | // Packet - 0 : ExpectedDisplayFrameStart |
| 1389 | const auto& packet0 = packets[0]; |
| 1390 | ASSERT_TRUE(packet0.has_timestamp()); |
Siarhei Vishniakou | fc434ac | 2021-01-13 10:28:00 -1000 | [diff] [blame] | 1391 | EXPECT_EQ(packet0.timestamp(), 10u); |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 1392 | ASSERT_TRUE(packet0.has_frame_timeline_event()); |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 1393 | |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 1394 | const auto& event0 = packet0.frame_timeline_event(); |
| 1395 | ASSERT_TRUE(event0.has_expected_display_frame_start()); |
| 1396 | const auto& expectedDisplayFrameStart = event0.expected_display_frame_start(); |
| 1397 | validateTraceEvent(expectedDisplayFrameStart, protoExpectedDisplayFrameStart); |
| 1398 | |
| 1399 | // Packet - 1 : FrameEnd (ExpectedDisplayFrame) |
| 1400 | const auto& packet1 = packets[1]; |
| 1401 | ASSERT_TRUE(packet1.has_timestamp()); |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 1402 | EXPECT_EQ(packet1.timestamp(), 30u); |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 1403 | ASSERT_TRUE(packet1.has_frame_timeline_event()); |
| 1404 | |
| 1405 | const auto& event1 = packet1.frame_timeline_event(); |
| 1406 | ASSERT_TRUE(event1.has_frame_end()); |
| 1407 | const auto& expectedDisplayFrameEnd = event1.frame_end(); |
| 1408 | validateTraceEvent(expectedDisplayFrameEnd, protoExpectedDisplayFrameEnd); |
| 1409 | |
| 1410 | // Packet - 2 : ActualDisplayFrameStart |
| 1411 | const auto& packet2 = packets[2]; |
| 1412 | ASSERT_TRUE(packet2.has_timestamp()); |
Siarhei Vishniakou | fc434ac | 2021-01-13 10:28:00 -1000 | [diff] [blame] | 1413 | EXPECT_EQ(packet2.timestamp(), 20u); |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 1414 | ASSERT_TRUE(packet2.has_frame_timeline_event()); |
| 1415 | |
| 1416 | const auto& event2 = packet2.frame_timeline_event(); |
| 1417 | ASSERT_TRUE(event2.has_actual_display_frame_start()); |
| 1418 | const auto& actualDisplayFrameStart = event2.actual_display_frame_start(); |
| 1419 | validateTraceEvent(actualDisplayFrameStart, protoActualDisplayFrameStart); |
| 1420 | |
| 1421 | // Packet - 3 : FrameEnd (ActualDisplayFrame) |
| 1422 | const auto& packet3 = packets[3]; |
| 1423 | ASSERT_TRUE(packet3.has_timestamp()); |
Adithya Srinivasan | 1a97163 | 2021-02-26 23:10:29 +0000 | [diff] [blame] | 1424 | EXPECT_EQ(packet3.timestamp(), 31u); |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 1425 | ASSERT_TRUE(packet3.has_frame_timeline_event()); |
| 1426 | |
| 1427 | const auto& event3 = packet3.frame_timeline_event(); |
| 1428 | ASSERT_TRUE(event3.has_frame_end()); |
| 1429 | const auto& actualDisplayFrameEnd = event3.frame_end(); |
| 1430 | validateTraceEvent(actualDisplayFrameEnd, protoActualDisplayFrameEnd); |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 1431 | } |
| 1432 | |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 1433 | TEST_F(FrameTimelineTest, traceDisplayFrame_predictionExpiredDoesNotTraceExpectedTimeline) { |
| 1434 | auto tracingSession = getTracingSessionForTest(); |
| 1435 | auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
| 1436 | |
| 1437 | tracingSession->StartBlocking(); |
| 1438 | int64_t displayFrameToken1 = mTokenManager->generateTokenForPredictions({10, 25, 30}); |
| 1439 | // Flush the token so that it would expire |
Adithya Srinivasan | bed4c4f | 2021-05-03 20:24:46 +0000 | [diff] [blame] | 1440 | flushTokens(); |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 1441 | |
Ady Abraham | 57a8ab4 | 2023-01-26 15:28:19 -0800 | [diff] [blame] | 1442 | // Add an empty surface frame so that display frame would get traced. |
| 1443 | addEmptySurfaceFrame(); |
| 1444 | |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 1445 | // Set up the display frame |
Pascal Muetschard | ac7bcd9 | 2023-10-03 15:05:36 +0200 | [diff] [blame] | 1446 | mFrameTimeline->setSfWakeUp(displayFrameToken1, 20, RR_11, RR_11); |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 1447 | mFrameTimeline->setSfPresent(26, presentFence1); |
| 1448 | presentFence1->signalForTest(31); |
| 1449 | |
| 1450 | int64_t traceCookie = snoopCurrentTraceCookie(); |
| 1451 | |
| 1452 | auto protoActualDisplayFrameStart = |
| 1453 | createProtoActualDisplayFrameStart(traceCookie + 1, displayFrameToken1, |
| 1454 | kSurfaceFlingerPid, |
| 1455 | FrameTimelineEvent::PRESENT_UNSPECIFIED, false, |
Adithya Srinivasan | 78e58af | 2021-02-25 00:08:08 +0000 | [diff] [blame] | 1456 | false, FrameTimelineEvent::JANK_UNKNOWN, |
Ying Wei | 96eb535 | 2023-11-21 17:37:21 +0000 | [diff] [blame] | 1457 | FrameTimelineEvent::SEVERITY_UNKNOWN, |
Adithya Srinivasan | 78e58af | 2021-02-25 00:08:08 +0000 | [diff] [blame] | 1458 | FrameTimelineEvent::PREDICTION_EXPIRED); |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 1459 | auto protoActualDisplayFrameEnd = createProtoFrameEnd(traceCookie + 1); |
| 1460 | |
| 1461 | addEmptyDisplayFrame(); |
| 1462 | flushTrace(); |
| 1463 | tracingSession->StopBlocking(); |
| 1464 | |
| 1465 | auto packets = readFrameTimelinePacketsBlocking(tracingSession.get()); |
| 1466 | // Only actual timeline packets should be in the trace |
| 1467 | EXPECT_EQ(packets.size(), 2u); |
| 1468 | |
| 1469 | // Packet - 0 : ActualDisplayFrameStart |
| 1470 | const auto& packet0 = packets[0]; |
| 1471 | ASSERT_TRUE(packet0.has_timestamp()); |
| 1472 | EXPECT_EQ(packet0.timestamp(), 20u); |
| 1473 | ASSERT_TRUE(packet0.has_frame_timeline_event()); |
| 1474 | |
| 1475 | const auto& event0 = packet0.frame_timeline_event(); |
| 1476 | ASSERT_TRUE(event0.has_actual_display_frame_start()); |
| 1477 | const auto& actualDisplayFrameStart = event0.actual_display_frame_start(); |
| 1478 | validateTraceEvent(actualDisplayFrameStart, protoActualDisplayFrameStart); |
| 1479 | |
| 1480 | // Packet - 1 : FrameEnd (ActualDisplayFrame) |
| 1481 | const auto& packet1 = packets[1]; |
| 1482 | ASSERT_TRUE(packet1.has_timestamp()); |
Adithya Srinivasan | 1a97163 | 2021-02-26 23:10:29 +0000 | [diff] [blame] | 1483 | EXPECT_EQ(packet1.timestamp(), 31u); |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 1484 | ASSERT_TRUE(packet1.has_frame_timeline_event()); |
| 1485 | |
| 1486 | const auto& event1 = packet1.frame_timeline_event(); |
| 1487 | ASSERT_TRUE(event1.has_frame_end()); |
| 1488 | const auto& actualDisplayFrameEnd = event1.frame_end(); |
| 1489 | validateTraceEvent(actualDisplayFrameEnd, protoActualDisplayFrameEnd); |
| 1490 | } |
| 1491 | |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 1492 | TEST_F(FrameTimelineTest, traceSurfaceFrame_emitsValidTracePacket) { |
| 1493 | auto tracingSession = getTracingSessionForTest(); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1494 | // Layer specific increment |
Edgar Arriaga | 631e425 | 2023-03-02 02:11:24 +0000 | [diff] [blame] | 1495 | EXPECT_CALL(*mTimeStats, incrementJankyFrames(_)).Times(2); |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 1496 | auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
| 1497 | auto presentFence2 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
| 1498 | |
| 1499 | tracingSession->StartBlocking(); |
| 1500 | int64_t surfaceFrameToken = mTokenManager->generateTokenForPredictions({10, 25, 40}); |
| 1501 | int64_t displayFrameToken1 = mTokenManager->generateTokenForPredictions({30, 35, 40}); |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 1502 | |
Huihong Luo | 3bdef86 | 2022-03-03 11:57:19 -0800 | [diff] [blame] | 1503 | FrameTimelineInfo ftInfo; |
| 1504 | ftInfo.vsyncId = surfaceFrameToken; |
| 1505 | ftInfo.inputEventId = sInputEventId; |
| 1506 | |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 1507 | auto surfaceFrame1 = |
Huihong Luo | 3bdef86 | 2022-03-03 11:57:19 -0800 | [diff] [blame] | 1508 | mFrameTimeline->createSurfaceFrameForToken(ftInfo, sPidOne, sUidOne, sLayerIdOne, |
| 1509 | sLayerNameOne, sLayerNameOne, |
| 1510 | /*isBuffer*/ true, sGameMode); |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 1511 | auto surfaceFrame2 = |
Huihong Luo | 3bdef86 | 2022-03-03 11:57:19 -0800 | [diff] [blame] | 1512 | mFrameTimeline->createSurfaceFrameForToken(ftInfo, sPidOne, sUidOne, sLayerIdOne, |
| 1513 | sLayerNameOne, sLayerNameOne, |
| 1514 | /*isBuffer*/ true, sGameMode); |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 1515 | surfaceFrame1->setActualQueueTime(10); |
| 1516 | surfaceFrame1->setDropTime(15); |
| 1517 | |
| 1518 | surfaceFrame2->setActualQueueTime(15); |
| 1519 | surfaceFrame2->setAcquireFenceTime(20); |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 1520 | |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 1521 | // First 2 cookies will be used by the DisplayFrame |
| 1522 | int64_t traceCookie = snoopCurrentTraceCookie() + 2; |
| 1523 | |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 1524 | auto protoDroppedSurfaceFrameExpectedStart = |
| 1525 | createProtoExpectedSurfaceFrameStart(traceCookie + 1, surfaceFrameToken, |
| 1526 | displayFrameToken1, sPidOne, sLayerNameOne); |
| 1527 | auto protoDroppedSurfaceFrameExpectedEnd = createProtoFrameEnd(traceCookie + 1); |
| 1528 | auto protoDroppedSurfaceFrameActualStart = |
| 1529 | createProtoActualSurfaceFrameStart(traceCookie + 2, surfaceFrameToken, |
| 1530 | displayFrameToken1, sPidOne, sLayerNameOne, |
Edgar Arriaga | 631e425 | 2023-03-02 02:11:24 +0000 | [diff] [blame] | 1531 | FrameTimelineEvent::PRESENT_DROPPED, true, false, |
| 1532 | FrameTimelineEvent::JANK_DROPPED, |
Ying Wei | 96eb535 | 2023-11-21 17:37:21 +0000 | [diff] [blame] | 1533 | FrameTimelineEvent::SEVERITY_UNKNOWN, |
Adithya Srinivasan | 1f9450c | 2021-06-10 22:39:19 +0000 | [diff] [blame] | 1534 | FrameTimelineEvent::PREDICTION_VALID, true); |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 1535 | auto protoDroppedSurfaceFrameActualEnd = createProtoFrameEnd(traceCookie + 2); |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 1536 | |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 1537 | auto protoPresentedSurfaceFrameExpectedStart = |
| 1538 | createProtoExpectedSurfaceFrameStart(traceCookie + 3, surfaceFrameToken, |
| 1539 | displayFrameToken1, sPidOne, sLayerNameOne); |
| 1540 | auto protoPresentedSurfaceFrameExpectedEnd = createProtoFrameEnd(traceCookie + 3); |
| 1541 | auto protoPresentedSurfaceFrameActualStart = |
| 1542 | createProtoActualSurfaceFrameStart(traceCookie + 4, surfaceFrameToken, |
| 1543 | displayFrameToken1, sPidOne, sLayerNameOne, |
| 1544 | FrameTimelineEvent::PRESENT_ON_TIME, true, false, |
Adithya Srinivasan | 78e58af | 2021-02-25 00:08:08 +0000 | [diff] [blame] | 1545 | FrameTimelineEvent::JANK_NONE, |
Ying Wei | 96eb535 | 2023-11-21 17:37:21 +0000 | [diff] [blame] | 1546 | FrameTimelineEvent::SEVERITY_NONE, |
Adithya Srinivasan | 1f9450c | 2021-06-10 22:39:19 +0000 | [diff] [blame] | 1547 | FrameTimelineEvent::PREDICTION_VALID, true); |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 1548 | auto protoPresentedSurfaceFrameActualEnd = createProtoFrameEnd(traceCookie + 4); |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 1549 | |
| 1550 | // Set up the display frame |
Pascal Muetschard | ac7bcd9 | 2023-10-03 15:05:36 +0200 | [diff] [blame] | 1551 | mFrameTimeline->setSfWakeUp(displayFrameToken1, 20, RR_11, RR_11); |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 1552 | surfaceFrame1->setPresentState(SurfaceFrame::PresentState::Dropped); |
| 1553 | surfaceFrame2->setPresentState(SurfaceFrame::PresentState::Presented); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1554 | mFrameTimeline->addSurfaceFrame(surfaceFrame1); |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 1555 | mFrameTimeline->addSurfaceFrame(surfaceFrame2); |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 1556 | mFrameTimeline->setSfPresent(26, presentFence1); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1557 | presentFence1->signalForTest(40); |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 1558 | |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 1559 | addEmptyDisplayFrame(); |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 1560 | flushTrace(); |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 1561 | tracingSession->StopBlocking(); |
| 1562 | |
| 1563 | auto packets = readFrameTimelinePacketsBlocking(tracingSession.get()); |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 1564 | // 4 DisplayFrame + 4 DroppedSurfaceFrame + 4 PresentedSurfaceFrame |
| 1565 | EXPECT_EQ(packets.size(), 12u); |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 1566 | |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 1567 | // Packet - 4 : ExpectedSurfaceFrameStart1 |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 1568 | const auto& packet4 = packets[4]; |
| 1569 | ASSERT_TRUE(packet4.has_timestamp()); |
Siarhei Vishniakou | fc434ac | 2021-01-13 10:28:00 -1000 | [diff] [blame] | 1570 | EXPECT_EQ(packet4.timestamp(), 10u); |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 1571 | ASSERT_TRUE(packet4.has_frame_timeline_event()); |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 1572 | |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 1573 | const auto& event4 = packet4.frame_timeline_event(); |
| 1574 | ASSERT_TRUE(event4.has_expected_surface_frame_start()); |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 1575 | const auto& expectedSurfaceFrameStart1 = event4.expected_surface_frame_start(); |
| 1576 | validateTraceEvent(expectedSurfaceFrameStart1, protoDroppedSurfaceFrameExpectedStart); |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 1577 | |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 1578 | // Packet - 5 : FrameEnd (ExpectedSurfaceFrame1) |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 1579 | const auto& packet5 = packets[5]; |
| 1580 | ASSERT_TRUE(packet5.has_timestamp()); |
Siarhei Vishniakou | fc434ac | 2021-01-13 10:28:00 -1000 | [diff] [blame] | 1581 | EXPECT_EQ(packet5.timestamp(), 25u); |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 1582 | ASSERT_TRUE(packet5.has_frame_timeline_event()); |
| 1583 | |
| 1584 | const auto& event5 = packet5.frame_timeline_event(); |
| 1585 | ASSERT_TRUE(event5.has_frame_end()); |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 1586 | const auto& expectedSurfaceFrameEnd1 = event5.frame_end(); |
| 1587 | validateTraceEvent(expectedSurfaceFrameEnd1, protoDroppedSurfaceFrameExpectedEnd); |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 1588 | |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 1589 | // Packet - 6 : ActualSurfaceFrameStart1 |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 1590 | const auto& packet6 = packets[6]; |
| 1591 | ASSERT_TRUE(packet6.has_timestamp()); |
Siarhei Vishniakou | fc434ac | 2021-01-13 10:28:00 -1000 | [diff] [blame] | 1592 | EXPECT_EQ(packet6.timestamp(), 10u); |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 1593 | ASSERT_TRUE(packet6.has_frame_timeline_event()); |
| 1594 | |
| 1595 | const auto& event6 = packet6.frame_timeline_event(); |
| 1596 | ASSERT_TRUE(event6.has_actual_surface_frame_start()); |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 1597 | const auto& actualSurfaceFrameStart1 = event6.actual_surface_frame_start(); |
| 1598 | validateTraceEvent(actualSurfaceFrameStart1, protoDroppedSurfaceFrameActualStart); |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 1599 | |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 1600 | // Packet - 7 : FrameEnd (ActualSurfaceFrame1) |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 1601 | const auto& packet7 = packets[7]; |
| 1602 | ASSERT_TRUE(packet7.has_timestamp()); |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 1603 | EXPECT_EQ(packet7.timestamp(), 15u); |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 1604 | ASSERT_TRUE(packet7.has_frame_timeline_event()); |
| 1605 | |
| 1606 | const auto& event7 = packet7.frame_timeline_event(); |
| 1607 | ASSERT_TRUE(event7.has_frame_end()); |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 1608 | const auto& actualSurfaceFrameEnd1 = event7.frame_end(); |
| 1609 | validateTraceEvent(actualSurfaceFrameEnd1, protoDroppedSurfaceFrameActualEnd); |
| 1610 | |
| 1611 | // Packet - 8 : ExpectedSurfaceFrameStart2 |
| 1612 | const auto& packet8 = packets[8]; |
| 1613 | ASSERT_TRUE(packet8.has_timestamp()); |
| 1614 | EXPECT_EQ(packet8.timestamp(), 10u); |
| 1615 | ASSERT_TRUE(packet8.has_frame_timeline_event()); |
| 1616 | |
| 1617 | const auto& event8 = packet8.frame_timeline_event(); |
| 1618 | ASSERT_TRUE(event8.has_expected_surface_frame_start()); |
| 1619 | const auto& expectedSurfaceFrameStart2 = event8.expected_surface_frame_start(); |
| 1620 | validateTraceEvent(expectedSurfaceFrameStart2, protoPresentedSurfaceFrameExpectedStart); |
| 1621 | |
| 1622 | // Packet - 9 : FrameEnd (ExpectedSurfaceFrame2) |
| 1623 | const auto& packet9 = packets[9]; |
| 1624 | ASSERT_TRUE(packet9.has_timestamp()); |
| 1625 | EXPECT_EQ(packet9.timestamp(), 25u); |
| 1626 | ASSERT_TRUE(packet9.has_frame_timeline_event()); |
| 1627 | |
| 1628 | const auto& event9 = packet9.frame_timeline_event(); |
| 1629 | ASSERT_TRUE(event9.has_frame_end()); |
| 1630 | const auto& expectedSurfaceFrameEnd2 = event9.frame_end(); |
| 1631 | validateTraceEvent(expectedSurfaceFrameEnd2, protoPresentedSurfaceFrameExpectedEnd); |
| 1632 | |
| 1633 | // Packet - 10 : ActualSurfaceFrameStart2 |
| 1634 | const auto& packet10 = packets[10]; |
| 1635 | ASSERT_TRUE(packet10.has_timestamp()); |
| 1636 | EXPECT_EQ(packet10.timestamp(), 10u); |
| 1637 | ASSERT_TRUE(packet10.has_frame_timeline_event()); |
| 1638 | |
| 1639 | const auto& event10 = packet10.frame_timeline_event(); |
| 1640 | ASSERT_TRUE(event10.has_actual_surface_frame_start()); |
| 1641 | const auto& actualSurfaceFrameStart2 = event10.actual_surface_frame_start(); |
| 1642 | validateTraceEvent(actualSurfaceFrameStart2, protoPresentedSurfaceFrameActualStart); |
| 1643 | |
| 1644 | // Packet - 11 : FrameEnd (ActualSurfaceFrame2) |
| 1645 | const auto& packet11 = packets[11]; |
| 1646 | ASSERT_TRUE(packet11.has_timestamp()); |
| 1647 | EXPECT_EQ(packet11.timestamp(), 20u); |
| 1648 | ASSERT_TRUE(packet11.has_frame_timeline_event()); |
| 1649 | |
| 1650 | const auto& event11 = packet11.frame_timeline_event(); |
| 1651 | ASSERT_TRUE(event11.has_frame_end()); |
| 1652 | const auto& actualSurfaceFrameEnd2 = event11.frame_end(); |
| 1653 | validateTraceEvent(actualSurfaceFrameEnd2, protoPresentedSurfaceFrameActualEnd); |
| 1654 | } |
| 1655 | |
Ady Abraham | e43ff72 | 2022-02-15 14:44:25 -0800 | [diff] [blame] | 1656 | TEST_F(FrameTimelineTest, traceSurfaceFrame_predictionExpiredIsAppMissedDeadline) { |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 1657 | auto tracingSession = getTracingSessionForTest(); |
| 1658 | auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
| 1659 | |
| 1660 | tracingSession->StartBlocking(); |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 1661 | constexpr nsecs_t appStartTime = std::chrono::nanoseconds(10ms).count(); |
| 1662 | constexpr nsecs_t appEndTime = std::chrono::nanoseconds(20ms).count(); |
| 1663 | constexpr nsecs_t appPresentTime = std::chrono::nanoseconds(30ms).count(); |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 1664 | int64_t surfaceFrameToken = |
| 1665 | mTokenManager->generateTokenForPredictions({appStartTime, appEndTime, appPresentTime}); |
| 1666 | |
| 1667 | // Flush the token so that it would expire |
Adithya Srinivasan | bed4c4f | 2021-05-03 20:24:46 +0000 | [diff] [blame] | 1668 | flushTokens(); |
Huihong Luo | 3bdef86 | 2022-03-03 11:57:19 -0800 | [diff] [blame] | 1669 | FrameTimelineInfo ftInfo; |
| 1670 | ftInfo.vsyncId = surfaceFrameToken; |
| 1671 | ftInfo.inputEventId = 0; |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 1672 | auto surfaceFrame1 = |
Huihong Luo | 3bdef86 | 2022-03-03 11:57:19 -0800 | [diff] [blame] | 1673 | mFrameTimeline->createSurfaceFrameForToken(ftInfo, sPidOne, sUidOne, sLayerIdOne, |
| 1674 | sLayerNameOne, sLayerNameOne, |
| 1675 | /*isBuffer*/ true, sGameMode); |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 1676 | surfaceFrame1->setActualQueueTime(appEndTime); |
| 1677 | surfaceFrame1->setAcquireFenceTime(appEndTime); |
| 1678 | |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 1679 | constexpr nsecs_t sfStartTime = std::chrono::nanoseconds(20ms).count(); |
| 1680 | constexpr nsecs_t sfEndTime = std::chrono::nanoseconds(30ms).count(); |
| 1681 | constexpr nsecs_t sfPresentTime = std::chrono::nanoseconds(30ms).count(); |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 1682 | int64_t displayFrameToken = |
| 1683 | mTokenManager->generateTokenForPredictions({sfStartTime, sfEndTime, sfPresentTime}); |
| 1684 | |
| 1685 | // First 2 cookies will be used by the DisplayFrame |
| 1686 | int64_t traceCookie = snoopCurrentTraceCookie() + 2; |
| 1687 | |
| 1688 | auto protoActualSurfaceFrameStart = |
| 1689 | createProtoActualSurfaceFrameStart(traceCookie + 1, surfaceFrameToken, |
| 1690 | displayFrameToken, sPidOne, sLayerNameOne, |
| 1691 | FrameTimelineEvent::PRESENT_UNSPECIFIED, false, |
Ady Abraham | e43ff72 | 2022-02-15 14:44:25 -0800 | [diff] [blame] | 1692 | false, FrameTimelineEvent::JANK_APP_DEADLINE_MISSED, |
Ying Wei | 96eb535 | 2023-11-21 17:37:21 +0000 | [diff] [blame] | 1693 | FrameTimelineEvent::SEVERITY_UNKNOWN, |
Adithya Srinivasan | 1f9450c | 2021-06-10 22:39:19 +0000 | [diff] [blame] | 1694 | FrameTimelineEvent::PREDICTION_EXPIRED, true); |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 1695 | auto protoActualSurfaceFrameEnd = createProtoFrameEnd(traceCookie + 1); |
| 1696 | |
| 1697 | // Set up the display frame |
Pascal Muetschard | ac7bcd9 | 2023-10-03 15:05:36 +0200 | [diff] [blame] | 1698 | mFrameTimeline->setSfWakeUp(displayFrameToken, sfStartTime, RR_11, RR_11); |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 1699 | surfaceFrame1->setPresentState(SurfaceFrame::PresentState::Presented); |
| 1700 | mFrameTimeline->addSurfaceFrame(surfaceFrame1); |
| 1701 | mFrameTimeline->setSfPresent(sfEndTime, presentFence1); |
| 1702 | presentFence1->signalForTest(sfPresentTime); |
| 1703 | |
| 1704 | addEmptyDisplayFrame(); |
| 1705 | flushTrace(); |
| 1706 | tracingSession->StopBlocking(); |
| 1707 | |
| 1708 | auto packets = readFrameTimelinePacketsBlocking(tracingSession.get()); |
| 1709 | // Display Frame 4 packets + SurfaceFrame 2 packets |
| 1710 | ASSERT_EQ(packets.size(), 6u); |
| 1711 | |
| 1712 | // Packet - 4 : ActualSurfaceFrameStart |
| 1713 | const auto& packet4 = packets[4]; |
| 1714 | ASSERT_TRUE(packet4.has_timestamp()); |
| 1715 | EXPECT_EQ(packet4.timestamp(), |
| 1716 | static_cast<uint64_t>(appEndTime - SurfaceFrame::kPredictionExpiredStartTimeDelta)); |
| 1717 | ASSERT_TRUE(packet4.has_frame_timeline_event()); |
| 1718 | |
| 1719 | const auto& event4 = packet4.frame_timeline_event(); |
| 1720 | ASSERT_TRUE(event4.has_actual_surface_frame_start()); |
| 1721 | const auto& actualSurfaceFrameStart = event4.actual_surface_frame_start(); |
| 1722 | validateTraceEvent(actualSurfaceFrameStart, protoActualSurfaceFrameStart); |
| 1723 | |
| 1724 | // Packet - 5 : FrameEnd (ActualSurfaceFrame) |
| 1725 | const auto& packet5 = packets[5]; |
| 1726 | ASSERT_TRUE(packet5.has_timestamp()); |
| 1727 | EXPECT_EQ(packet5.timestamp(), static_cast<uint64_t>(appEndTime)); |
| 1728 | ASSERT_TRUE(packet5.has_frame_timeline_event()); |
| 1729 | |
| 1730 | const auto& event5 = packet5.frame_timeline_event(); |
| 1731 | ASSERT_TRUE(event5.has_frame_end()); |
| 1732 | const auto& actualSurfaceFrameEnd = event5.frame_end(); |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 1733 | validateTraceEvent(actualSurfaceFrameEnd, protoActualSurfaceFrameEnd); |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 1734 | } |
| 1735 | |
Adithya Srinivasan | b2283c3 | 2021-04-21 21:31:56 +0000 | [diff] [blame] | 1736 | TEST_F(FrameTimelineTest, traceSurfaceFrame_predictionExpiredDroppedFramesTracedProperly) { |
| 1737 | auto tracingSession = getTracingSessionForTest(); |
| 1738 | auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
| 1739 | |
| 1740 | tracingSession->StartBlocking(); |
| 1741 | constexpr nsecs_t appStartTime = std::chrono::nanoseconds(10ms).count(); |
| 1742 | constexpr nsecs_t appEndTime = std::chrono::nanoseconds(20ms).count(); |
| 1743 | constexpr nsecs_t appPresentTime = std::chrono::nanoseconds(30ms).count(); |
| 1744 | int64_t surfaceFrameToken = |
| 1745 | mTokenManager->generateTokenForPredictions({appStartTime, appEndTime, appPresentTime}); |
| 1746 | |
| 1747 | // Flush the token so that it would expire |
Adithya Srinivasan | bed4c4f | 2021-05-03 20:24:46 +0000 | [diff] [blame] | 1748 | flushTokens(); |
Huihong Luo | 3bdef86 | 2022-03-03 11:57:19 -0800 | [diff] [blame] | 1749 | FrameTimelineInfo ftInfo; |
| 1750 | ftInfo.vsyncId = surfaceFrameToken; |
| 1751 | ftInfo.inputEventId = 0; |
Adithya Srinivasan | b2283c3 | 2021-04-21 21:31:56 +0000 | [diff] [blame] | 1752 | auto surfaceFrame1 = |
Huihong Luo | 3bdef86 | 2022-03-03 11:57:19 -0800 | [diff] [blame] | 1753 | mFrameTimeline->createSurfaceFrameForToken(ftInfo, sPidOne, sUidOne, sLayerIdOne, |
| 1754 | sLayerNameOne, sLayerNameOne, |
| 1755 | /*isBuffer*/ true, sGameMode); |
Adithya Srinivasan | b2283c3 | 2021-04-21 21:31:56 +0000 | [diff] [blame] | 1756 | |
| 1757 | constexpr nsecs_t sfStartTime = std::chrono::nanoseconds(22ms).count(); |
| 1758 | constexpr nsecs_t sfEndTime = std::chrono::nanoseconds(30ms).count(); |
| 1759 | constexpr nsecs_t sfPresentTime = std::chrono::nanoseconds(30ms).count(); |
| 1760 | int64_t displayFrameToken = |
| 1761 | mTokenManager->generateTokenForPredictions({sfStartTime, sfEndTime, sfPresentTime}); |
| 1762 | |
| 1763 | // First 2 cookies will be used by the DisplayFrame |
| 1764 | int64_t traceCookie = snoopCurrentTraceCookie() + 2; |
| 1765 | |
| 1766 | auto protoActualSurfaceFrameStart = |
| 1767 | createProtoActualSurfaceFrameStart(traceCookie + 1, surfaceFrameToken, |
| 1768 | displayFrameToken, sPidOne, sLayerNameOne, |
| 1769 | FrameTimelineEvent::PRESENT_DROPPED, false, false, |
Edgar Arriaga | 631e425 | 2023-03-02 02:11:24 +0000 | [diff] [blame] | 1770 | FrameTimelineEvent::JANK_DROPPED, |
Ying Wei | 96eb535 | 2023-11-21 17:37:21 +0000 | [diff] [blame] | 1771 | FrameTimelineEvent::SEVERITY_UNKNOWN, |
Adithya Srinivasan | 1f9450c | 2021-06-10 22:39:19 +0000 | [diff] [blame] | 1772 | FrameTimelineEvent::PREDICTION_EXPIRED, true); |
Adithya Srinivasan | b2283c3 | 2021-04-21 21:31:56 +0000 | [diff] [blame] | 1773 | auto protoActualSurfaceFrameEnd = createProtoFrameEnd(traceCookie + 1); |
| 1774 | |
| 1775 | // Set up the display frame |
Pascal Muetschard | ac7bcd9 | 2023-10-03 15:05:36 +0200 | [diff] [blame] | 1776 | mFrameTimeline->setSfWakeUp(displayFrameToken, sfStartTime, RR_11, RR_11); |
Adithya Srinivasan | b2283c3 | 2021-04-21 21:31:56 +0000 | [diff] [blame] | 1777 | surfaceFrame1->setDropTime(sfStartTime); |
| 1778 | surfaceFrame1->setPresentState(SurfaceFrame::PresentState::Dropped); |
| 1779 | mFrameTimeline->addSurfaceFrame(surfaceFrame1); |
| 1780 | mFrameTimeline->setSfPresent(sfEndTime, presentFence1); |
| 1781 | presentFence1->signalForTest(sfPresentTime); |
| 1782 | |
| 1783 | addEmptyDisplayFrame(); |
| 1784 | flushTrace(); |
| 1785 | tracingSession->StopBlocking(); |
| 1786 | |
| 1787 | auto packets = readFrameTimelinePacketsBlocking(tracingSession.get()); |
| 1788 | // Display Frame 4 packets + SurfaceFrame 2 packets |
| 1789 | ASSERT_EQ(packets.size(), 6u); |
| 1790 | |
| 1791 | // Packet - 4 : ActualSurfaceFrameStart |
| 1792 | const auto& packet4 = packets[4]; |
| 1793 | ASSERT_TRUE(packet4.has_timestamp()); |
| 1794 | EXPECT_EQ(packet4.timestamp(), |
| 1795 | static_cast<uint64_t>(sfStartTime - SurfaceFrame::kPredictionExpiredStartTimeDelta)); |
| 1796 | ASSERT_TRUE(packet4.has_frame_timeline_event()); |
| 1797 | |
| 1798 | const auto& event4 = packet4.frame_timeline_event(); |
| 1799 | ASSERT_TRUE(event4.has_actual_surface_frame_start()); |
| 1800 | const auto& actualSurfaceFrameStart = event4.actual_surface_frame_start(); |
| 1801 | validateTraceEvent(actualSurfaceFrameStart, protoActualSurfaceFrameStart); |
| 1802 | |
| 1803 | // Packet - 5 : FrameEnd (ActualSurfaceFrame) |
| 1804 | const auto& packet5 = packets[5]; |
| 1805 | ASSERT_TRUE(packet5.has_timestamp()); |
| 1806 | EXPECT_EQ(packet5.timestamp(), static_cast<uint64_t>(sfStartTime)); |
| 1807 | ASSERT_TRUE(packet5.has_frame_timeline_event()); |
| 1808 | |
| 1809 | const auto& event5 = packet5.frame_timeline_event(); |
| 1810 | ASSERT_TRUE(event5.has_frame_end()); |
| 1811 | const auto& actualSurfaceFrameEnd = event5.frame_end(); |
| 1812 | validateTraceEvent(actualSurfaceFrameEnd, protoActualSurfaceFrameEnd); |
| 1813 | } |
| 1814 | |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1815 | // Tests for Jank classification |
| 1816 | TEST_F(FrameTimelineTest, jankClassification_presentOnTimeDoesNotClassify) { |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1817 | // Layer specific increment |
Alec Mouri | 363faf0 | 2021-01-29 16:34:55 -0800 | [diff] [blame] | 1818 | EXPECT_CALL(*mTimeStats, incrementJankyFrames(_)); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1819 | auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
| 1820 | int64_t surfaceFrameToken = mTokenManager->generateTokenForPredictions({10, 20, 30}); |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 1821 | int64_t sfToken1 = mTokenManager->generateTokenForPredictions({22, 30, 30}); |
Huihong Luo | 3bdef86 | 2022-03-03 11:57:19 -0800 | [diff] [blame] | 1822 | FrameTimelineInfo ftInfo; |
| 1823 | ftInfo.vsyncId = surfaceFrameToken; |
| 1824 | ftInfo.inputEventId = sInputEventId; |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1825 | auto surfaceFrame = |
Huihong Luo | 3bdef86 | 2022-03-03 11:57:19 -0800 | [diff] [blame] | 1826 | mFrameTimeline->createSurfaceFrameForToken(ftInfo, sPidOne, sUidOne, sLayerIdOne, |
| 1827 | sLayerNameOne, sLayerNameOne, |
| 1828 | /*isBuffer*/ true, sGameMode); |
Pascal Muetschard | ac7bcd9 | 2023-10-03 15:05:36 +0200 | [diff] [blame] | 1829 | mFrameTimeline->setSfWakeUp(sfToken1, 22, RR_11, RR_11); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1830 | surfaceFrame->setPresentState(SurfaceFrame::PresentState::Presented); |
| 1831 | mFrameTimeline->addSurfaceFrame(surfaceFrame); |
| 1832 | mFrameTimeline->setSfPresent(26, presentFence1); |
| 1833 | auto displayFrame = getDisplayFrame(0); |
| 1834 | auto& presentedSurfaceFrame = getSurfaceFrame(0, 0); |
| 1835 | presentFence1->signalForTest(29); |
| 1836 | |
| 1837 | // Fences haven't been flushed yet, so it should be 0 |
| 1838 | EXPECT_EQ(displayFrame->getActuals().presentTime, 0); |
| 1839 | EXPECT_EQ(presentedSurfaceFrame.getActuals().presentTime, 0); |
| 1840 | |
| 1841 | addEmptyDisplayFrame(); |
| 1842 | displayFrame = getDisplayFrame(0); |
| 1843 | |
| 1844 | // Fences have flushed, so the present timestamps should be updated |
| 1845 | EXPECT_EQ(displayFrame->getActuals().presentTime, 29); |
| 1846 | EXPECT_EQ(presentedSurfaceFrame.getActuals().presentTime, 29); |
| 1847 | EXPECT_EQ(displayFrame->getFramePresentMetadata(), FramePresentMetadata::OnTimePresent); |
| 1848 | EXPECT_EQ(displayFrame->getFrameReadyMetadata(), FrameReadyMetadata::OnTimeFinish); |
| 1849 | EXPECT_EQ(displayFrame->getJankType(), JankType::None); |
Ying Wei | 96eb535 | 2023-11-21 17:37:21 +0000 | [diff] [blame] | 1850 | EXPECT_EQ(displayFrame->getJankSeverityType(), JankSeverityType::None); |
Pascal Mütschard | d56514e | 2024-05-24 17:37:13 +0200 | [diff] [blame^] | 1851 | |
| 1852 | auto jankData = getLayerOneJankData(); |
| 1853 | EXPECT_EQ(jankData.size(), 1u); |
| 1854 | EXPECT_EQ(jankData[0].jankType, JankType::None); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1855 | } |
| 1856 | |
| 1857 | TEST_F(FrameTimelineTest, jankClassification_displayFrameOnTimeFinishEarlyPresent) { |
Pascal Muetschard | ac7bcd9 | 2023-10-03 15:05:36 +0200 | [diff] [blame] | 1858 | Fps vsyncRate = RR_11; |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1859 | auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 1860 | int64_t sfToken1 = mTokenManager->generateTokenForPredictions({22, 30, 40}); |
| 1861 | int64_t sfToken2 = mTokenManager->generateTokenForPredictions({52, 60, 70}); |
Pascal Muetschard | ac7bcd9 | 2023-10-03 15:05:36 +0200 | [diff] [blame] | 1862 | mFrameTimeline->setSfWakeUp(sfToken1, 22, vsyncRate, vsyncRate); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1863 | mFrameTimeline->setSfPresent(26, presentFence1); |
| 1864 | auto displayFrame = getDisplayFrame(0); |
| 1865 | presentFence1->signalForTest(30); |
| 1866 | |
| 1867 | // Fences for the first frame haven't been flushed yet, so it should be 0 |
| 1868 | EXPECT_EQ(displayFrame->getActuals().presentTime, 0); |
| 1869 | |
| 1870 | // Trigger a flush by finalizing the next DisplayFrame |
| 1871 | auto presentFence2 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
Pascal Muetschard | ac7bcd9 | 2023-10-03 15:05:36 +0200 | [diff] [blame] | 1872 | mFrameTimeline->setSfWakeUp(sfToken2, 52, vsyncRate, vsyncRate); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1873 | mFrameTimeline->setSfPresent(56, presentFence2); |
| 1874 | displayFrame = getDisplayFrame(0); |
| 1875 | |
| 1876 | // Fences for the first frame have flushed, so the present timestamps should be updated |
| 1877 | EXPECT_EQ(displayFrame->getActuals().presentTime, 30); |
| 1878 | EXPECT_EQ(displayFrame->getFramePresentMetadata(), FramePresentMetadata::EarlyPresent); |
| 1879 | EXPECT_EQ(displayFrame->getFrameReadyMetadata(), FrameReadyMetadata::OnTimeFinish); |
| 1880 | EXPECT_EQ(displayFrame->getJankType(), JankType::SurfaceFlingerScheduling); |
Ying Wei | 96eb535 | 2023-11-21 17:37:21 +0000 | [diff] [blame] | 1881 | EXPECT_EQ(displayFrame->getJankSeverityType(), JankSeverityType::Partial); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1882 | |
| 1883 | // Fences for the second frame haven't been flushed yet, so it should be 0 |
| 1884 | auto displayFrame2 = getDisplayFrame(1); |
| 1885 | presentFence2->signalForTest(65); |
| 1886 | EXPECT_EQ(displayFrame2->getActuals().presentTime, 0); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1887 | addEmptyDisplayFrame(); |
| 1888 | displayFrame2 = getDisplayFrame(1); |
| 1889 | |
| 1890 | // Fences for the second frame have flushed, so the present timestamps should be updated |
| 1891 | EXPECT_EQ(displayFrame2->getActuals().presentTime, 65); |
| 1892 | EXPECT_EQ(displayFrame2->getFramePresentMetadata(), FramePresentMetadata::EarlyPresent); |
| 1893 | EXPECT_EQ(displayFrame2->getFrameReadyMetadata(), FrameReadyMetadata::OnTimeFinish); |
| 1894 | EXPECT_EQ(displayFrame2->getJankType(), JankType::PredictionError); |
Ying Wei | 96eb535 | 2023-11-21 17:37:21 +0000 | [diff] [blame] | 1895 | EXPECT_EQ(displayFrame->getJankSeverityType(), JankSeverityType::Partial); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1896 | } |
| 1897 | |
| 1898 | TEST_F(FrameTimelineTest, jankClassification_displayFrameOnTimeFinishLatePresent) { |
Pascal Muetschard | ac7bcd9 | 2023-10-03 15:05:36 +0200 | [diff] [blame] | 1899 | Fps vsyncRate = RR_11; |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1900 | auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 1901 | int64_t sfToken1 = mTokenManager->generateTokenForPredictions({22, 30, 40}); |
| 1902 | int64_t sfToken2 = mTokenManager->generateTokenForPredictions({52, 60, 70}); |
Pascal Muetschard | ac7bcd9 | 2023-10-03 15:05:36 +0200 | [diff] [blame] | 1903 | mFrameTimeline->setSfWakeUp(sfToken1, 22, vsyncRate, vsyncRate); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1904 | mFrameTimeline->setSfPresent(26, presentFence1); |
| 1905 | auto displayFrame = getDisplayFrame(0); |
| 1906 | presentFence1->signalForTest(50); |
| 1907 | |
| 1908 | // Fences for the first frame haven't been flushed yet, so it should be 0 |
| 1909 | EXPECT_EQ(displayFrame->getActuals().presentTime, 0); |
| 1910 | |
| 1911 | // Trigger a flush by finalizing the next DisplayFrame |
| 1912 | auto presentFence2 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
Pascal Muetschard | ac7bcd9 | 2023-10-03 15:05:36 +0200 | [diff] [blame] | 1913 | mFrameTimeline->setSfWakeUp(sfToken2, 52, vsyncRate, vsyncRate); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1914 | mFrameTimeline->setSfPresent(56, presentFence2); |
| 1915 | displayFrame = getDisplayFrame(0); |
| 1916 | |
| 1917 | // Fences for the first frame have flushed, so the present timestamps should be updated |
| 1918 | EXPECT_EQ(displayFrame->getActuals().presentTime, 50); |
| 1919 | EXPECT_EQ(displayFrame->getFramePresentMetadata(), FramePresentMetadata::LatePresent); |
| 1920 | EXPECT_EQ(displayFrame->getFrameReadyMetadata(), FrameReadyMetadata::OnTimeFinish); |
| 1921 | EXPECT_EQ(displayFrame->getJankType(), JankType::DisplayHAL); |
Ying Wei | 96eb535 | 2023-11-21 17:37:21 +0000 | [diff] [blame] | 1922 | EXPECT_EQ(displayFrame->getJankSeverityType(), JankSeverityType::Partial); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1923 | |
| 1924 | // Fences for the second frame haven't been flushed yet, so it should be 0 |
| 1925 | auto displayFrame2 = getDisplayFrame(1); |
| 1926 | presentFence2->signalForTest(75); |
| 1927 | EXPECT_EQ(displayFrame2->getActuals().presentTime, 0); |
| 1928 | |
| 1929 | addEmptyDisplayFrame(); |
| 1930 | displayFrame2 = getDisplayFrame(1); |
| 1931 | |
| 1932 | // Fences for the second frame have flushed, so the present timestamps should be updated |
| 1933 | EXPECT_EQ(displayFrame2->getActuals().presentTime, 75); |
| 1934 | EXPECT_EQ(displayFrame2->getFramePresentMetadata(), FramePresentMetadata::LatePresent); |
| 1935 | EXPECT_EQ(displayFrame2->getFrameReadyMetadata(), FrameReadyMetadata::OnTimeFinish); |
| 1936 | EXPECT_EQ(displayFrame2->getJankType(), JankType::PredictionError); |
Ying Wei | 96eb535 | 2023-11-21 17:37:21 +0000 | [diff] [blame] | 1937 | EXPECT_EQ(displayFrame->getJankSeverityType(), JankSeverityType::Partial); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1938 | } |
| 1939 | |
| 1940 | TEST_F(FrameTimelineTest, jankClassification_displayFrameLateFinishEarlyPresent) { |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1941 | auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
| 1942 | int64_t sfToken1 = mTokenManager->generateTokenForPredictions({12, 18, 40}); |
Pascal Muetschard | ac7bcd9 | 2023-10-03 15:05:36 +0200 | [diff] [blame] | 1943 | mFrameTimeline->setSfWakeUp(sfToken1, 12, RR_11, RR_11); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1944 | |
| 1945 | mFrameTimeline->setSfPresent(22, presentFence1); |
| 1946 | auto displayFrame = getDisplayFrame(0); |
| 1947 | presentFence1->signalForTest(28); |
| 1948 | |
| 1949 | // Fences haven't been flushed yet, so it should be 0 |
| 1950 | EXPECT_EQ(displayFrame->getActuals().presentTime, 0); |
| 1951 | |
| 1952 | addEmptyDisplayFrame(); |
| 1953 | displayFrame = getDisplayFrame(0); |
| 1954 | |
| 1955 | // Fences have flushed, so the present timestamps should be updated |
| 1956 | EXPECT_EQ(displayFrame->getActuals().presentTime, 28); |
| 1957 | EXPECT_EQ(displayFrame->getFramePresentMetadata(), FramePresentMetadata::EarlyPresent); |
| 1958 | EXPECT_EQ(displayFrame->getFrameReadyMetadata(), FrameReadyMetadata::LateFinish); |
| 1959 | EXPECT_EQ(displayFrame->getJankType(), JankType::SurfaceFlingerScheduling); |
Ying Wei | 96eb535 | 2023-11-21 17:37:21 +0000 | [diff] [blame] | 1960 | EXPECT_EQ(displayFrame->getJankSeverityType(), JankSeverityType::Full); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1961 | } |
| 1962 | |
| 1963 | TEST_F(FrameTimelineTest, jankClassification_displayFrameLateFinishLatePresent) { |
Adithya Srinivasan | 36b01af | 2021-04-07 22:29:47 +0000 | [diff] [blame] | 1964 | /* |
| 1965 | * Case 1 - cpu time > vsync period but combined time > deadline > deadline -> cpudeadlinemissed |
| 1966 | * Case 2 - cpu time < vsync period but combined time > deadline -> gpudeadlinemissed |
Adithya Srinivasan | 57dc81d | 2021-04-14 17:31:41 +0000 | [diff] [blame] | 1967 | * Case 3 - previous frame ran longer -> sf_stuffing |
| 1968 | * Case 4 - Long cpu under SF stuffing -> cpudeadlinemissed |
Adithya Srinivasan | 36b01af | 2021-04-07 22:29:47 +0000 | [diff] [blame] | 1969 | */ |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1970 | auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
Adithya Srinivasan | 36b01af | 2021-04-07 22:29:47 +0000 | [diff] [blame] | 1971 | auto presentFence2 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
Adithya Srinivasan | 57dc81d | 2021-04-14 17:31:41 +0000 | [diff] [blame] | 1972 | auto presentFence3 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
| 1973 | auto presentFence4 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
Adithya Srinivasan | 36b01af | 2021-04-07 22:29:47 +0000 | [diff] [blame] | 1974 | auto gpuFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
| 1975 | auto gpuFence2 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
Adithya Srinivasan | 57dc81d | 2021-04-14 17:31:41 +0000 | [diff] [blame] | 1976 | auto gpuFence3 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
| 1977 | auto gpuFence4 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1978 | int64_t sfToken1 = mTokenManager->generateTokenForPredictions({22, 26, 40}); |
Adithya Srinivasan | 36b01af | 2021-04-07 22:29:47 +0000 | [diff] [blame] | 1979 | int64_t sfToken2 = mTokenManager->generateTokenForPredictions({52, 60, 60}); |
Adithya Srinivasan | 57dc81d | 2021-04-14 17:31:41 +0000 | [diff] [blame] | 1980 | int64_t sfToken3 = mTokenManager->generateTokenForPredictions({82, 90, 90}); |
| 1981 | int64_t sfToken4 = mTokenManager->generateTokenForPredictions({112, 120, 120}); |
| 1982 | |
Adithya Srinivasan | 36b01af | 2021-04-07 22:29:47 +0000 | [diff] [blame] | 1983 | // case 1 - cpu time = 33 - 12 = 21, vsync period = 11 |
Pascal Muetschard | ac7bcd9 | 2023-10-03 15:05:36 +0200 | [diff] [blame] | 1984 | mFrameTimeline->setSfWakeUp(sfToken1, 12, RR_11, RR_11); |
Adithya Srinivasan | 36b01af | 2021-04-07 22:29:47 +0000 | [diff] [blame] | 1985 | mFrameTimeline->setSfPresent(33, presentFence1, gpuFence1); |
| 1986 | auto displayFrame0 = getDisplayFrame(0); |
| 1987 | gpuFence1->signalForTest(36); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1988 | presentFence1->signalForTest(52); |
| 1989 | |
| 1990 | // Fences haven't been flushed yet, so it should be 0 |
Adithya Srinivasan | 36b01af | 2021-04-07 22:29:47 +0000 | [diff] [blame] | 1991 | EXPECT_EQ(displayFrame0->getActuals().presentTime, 0); |
| 1992 | |
Adithya Srinivasan | 57dc81d | 2021-04-14 17:31:41 +0000 | [diff] [blame] | 1993 | // case 2 - cpu time = 56 - 52 = 4, vsync period = 30 |
Pascal Muetschard | ac7bcd9 | 2023-10-03 15:05:36 +0200 | [diff] [blame] | 1994 | mFrameTimeline->setSfWakeUp(sfToken2, 52, RR_30, RR_30); |
Adithya Srinivasan | 36b01af | 2021-04-07 22:29:47 +0000 | [diff] [blame] | 1995 | mFrameTimeline->setSfPresent(56, presentFence2, gpuFence2); |
| 1996 | auto displayFrame1 = getDisplayFrame(1); |
Adithya Srinivasan | 57dc81d | 2021-04-14 17:31:41 +0000 | [diff] [blame] | 1997 | gpuFence2->signalForTest(76); |
| 1998 | presentFence2->signalForTest(90); |
Adithya Srinivasan | 36b01af | 2021-04-07 22:29:47 +0000 | [diff] [blame] | 1999 | |
| 2000 | EXPECT_EQ(displayFrame1->getActuals().presentTime, 0); |
| 2001 | // Fences have flushed for first displayFrame, so the present timestamps should be updated |
| 2002 | EXPECT_EQ(displayFrame0->getActuals().presentTime, 52); |
| 2003 | EXPECT_EQ(displayFrame0->getFramePresentMetadata(), FramePresentMetadata::LatePresent); |
| 2004 | EXPECT_EQ(displayFrame0->getFrameReadyMetadata(), FrameReadyMetadata::LateFinish); |
Rachel Lee | 94917b3 | 2022-03-18 17:52:09 -0700 | [diff] [blame] | 2005 | EXPECT_EQ(displayFrame0->getJankType(), JankType::SurfaceFlingerGpuDeadlineMissed); |
Ying Wei | 96eb535 | 2023-11-21 17:37:21 +0000 | [diff] [blame] | 2006 | EXPECT_EQ(displayFrame0->getJankSeverityType(), JankSeverityType::Full); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 2007 | |
Adithya Srinivasan | 57dc81d | 2021-04-14 17:31:41 +0000 | [diff] [blame] | 2008 | // case 3 - cpu time = 86 - 82 = 4, vsync period = 30 |
Pascal Muetschard | ac7bcd9 | 2023-10-03 15:05:36 +0200 | [diff] [blame] | 2009 | mFrameTimeline->setSfWakeUp(sfToken3, 106, RR_30, RR_30); |
Adithya Srinivasan | 57dc81d | 2021-04-14 17:31:41 +0000 | [diff] [blame] | 2010 | mFrameTimeline->setSfPresent(112, presentFence3, gpuFence3); |
| 2011 | auto displayFrame2 = getDisplayFrame(2); |
| 2012 | gpuFence3->signalForTest(116); |
| 2013 | presentFence3->signalForTest(120); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 2014 | |
Adithya Srinivasan | 57dc81d | 2021-04-14 17:31:41 +0000 | [diff] [blame] | 2015 | EXPECT_EQ(displayFrame2->getActuals().presentTime, 0); |
Adithya Srinivasan | 36b01af | 2021-04-07 22:29:47 +0000 | [diff] [blame] | 2016 | // Fences have flushed for second displayFrame, so the present timestamps should be updated |
Adithya Srinivasan | 57dc81d | 2021-04-14 17:31:41 +0000 | [diff] [blame] | 2017 | EXPECT_EQ(displayFrame1->getActuals().presentTime, 90); |
Adithya Srinivasan | 36b01af | 2021-04-07 22:29:47 +0000 | [diff] [blame] | 2018 | EXPECT_EQ(displayFrame1->getFramePresentMetadata(), FramePresentMetadata::LatePresent); |
| 2019 | EXPECT_EQ(displayFrame1->getFrameReadyMetadata(), FrameReadyMetadata::LateFinish); |
| 2020 | EXPECT_EQ(displayFrame1->getJankType(), JankType::SurfaceFlingerGpuDeadlineMissed); |
Ying Wei | 96eb535 | 2023-11-21 17:37:21 +0000 | [diff] [blame] | 2021 | EXPECT_EQ(displayFrame1->getJankSeverityType(), JankSeverityType::Full); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 2022 | |
Adithya Srinivasan | 57dc81d | 2021-04-14 17:31:41 +0000 | [diff] [blame] | 2023 | // case 4 - cpu time = 86 - 82 = 4, vsync period = 30 |
Pascal Muetschard | ac7bcd9 | 2023-10-03 15:05:36 +0200 | [diff] [blame] | 2024 | mFrameTimeline->setSfWakeUp(sfToken4, 120, RR_30, RR_30); |
Adithya Srinivasan | 57dc81d | 2021-04-14 17:31:41 +0000 | [diff] [blame] | 2025 | mFrameTimeline->setSfPresent(140, presentFence4, gpuFence4); |
| 2026 | auto displayFrame3 = getDisplayFrame(3); |
| 2027 | gpuFence4->signalForTest(156); |
| 2028 | presentFence4->signalForTest(180); |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 2029 | |
Adithya Srinivasan | 57dc81d | 2021-04-14 17:31:41 +0000 | [diff] [blame] | 2030 | EXPECT_EQ(displayFrame3->getActuals().presentTime, 0); |
| 2031 | // Fences have flushed for third displayFrame, so the present timestamps should be updated |
| 2032 | EXPECT_EQ(displayFrame2->getActuals().presentTime, 120); |
| 2033 | EXPECT_EQ(displayFrame2->getFramePresentMetadata(), FramePresentMetadata::LatePresent); |
| 2034 | EXPECT_EQ(displayFrame2->getFrameReadyMetadata(), FrameReadyMetadata::LateFinish); |
| 2035 | EXPECT_EQ(displayFrame2->getJankType(), JankType::SurfaceFlingerStuffing); |
Ying Wei | 96eb535 | 2023-11-21 17:37:21 +0000 | [diff] [blame] | 2036 | EXPECT_EQ(displayFrame2->getJankSeverityType(), JankSeverityType::Full); |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 2037 | |
| 2038 | addEmptyDisplayFrame(); |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 2039 | |
Adithya Srinivasan | 57dc81d | 2021-04-14 17:31:41 +0000 | [diff] [blame] | 2040 | // Fences have flushed for third displayFrame, so the present timestamps should be updated |
| 2041 | EXPECT_EQ(displayFrame3->getActuals().presentTime, 180); |
| 2042 | EXPECT_EQ(displayFrame3->getFramePresentMetadata(), FramePresentMetadata::LatePresent); |
| 2043 | EXPECT_EQ(displayFrame3->getFrameReadyMetadata(), FrameReadyMetadata::LateFinish); |
| 2044 | EXPECT_EQ(displayFrame3->getJankType(), JankType::SurfaceFlingerGpuDeadlineMissed); |
Ying Wei | 96eb535 | 2023-11-21 17:37:21 +0000 | [diff] [blame] | 2045 | EXPECT_EQ(displayFrame3->getJankSeverityType(), JankSeverityType::Full); |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 2046 | } |
| 2047 | |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 2048 | TEST_F(FrameTimelineTest, jankClassification_surfaceFrameOnTimeFinishEarlyPresent) { |
Alec Mouri | 363faf0 | 2021-01-29 16:34:55 -0800 | [diff] [blame] | 2049 | EXPECT_CALL(*mTimeStats, incrementJankyFrames(_)); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 2050 | auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 2051 | int64_t sfToken1 = mTokenManager->generateTokenForPredictions({22, 30, 40}); |
| 2052 | int64_t sfToken2 = mTokenManager->generateTokenForPredictions({52, 60, 70}); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 2053 | int64_t surfaceFrameToken1 = mTokenManager->generateTokenForPredictions({5, 16, 40}); |
| 2054 | int64_t surfaceFrameToken2 = mTokenManager->generateTokenForPredictions({25, 36, 70}); |
Huihong Luo | 3bdef86 | 2022-03-03 11:57:19 -0800 | [diff] [blame] | 2055 | FrameTimelineInfo ftInfo; |
| 2056 | ftInfo.vsyncId = surfaceFrameToken1; |
| 2057 | ftInfo.inputEventId = sInputEventId; |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 2058 | auto surfaceFrame1 = |
Huihong Luo | 3bdef86 | 2022-03-03 11:57:19 -0800 | [diff] [blame] | 2059 | mFrameTimeline->createSurfaceFrameForToken(ftInfo, sPidOne, sUidOne, sLayerIdOne, |
| 2060 | sLayerNameOne, sLayerNameOne, |
| 2061 | /*isBuffer*/ true, sGameMode); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 2062 | surfaceFrame1->setAcquireFenceTime(16); |
Pascal Muetschard | ac7bcd9 | 2023-10-03 15:05:36 +0200 | [diff] [blame] | 2063 | mFrameTimeline->setSfWakeUp(sfToken1, 22, RR_11, RR_11); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 2064 | surfaceFrame1->setPresentState(SurfaceFrame::PresentState::Presented); |
| 2065 | mFrameTimeline->addSurfaceFrame(surfaceFrame1); |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 2066 | mFrameTimeline->setSfPresent(27, presentFence1); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 2067 | auto displayFrame1 = getDisplayFrame(0); |
| 2068 | auto& presentedSurfaceFrame1 = getSurfaceFrame(0, 0); |
| 2069 | presentFence1->signalForTest(30); |
| 2070 | |
| 2071 | // Fences for the first frame haven't been flushed yet, so it should be 0 |
| 2072 | EXPECT_EQ(displayFrame1->getActuals().presentTime, 0); |
| 2073 | auto actuals1 = presentedSurfaceFrame1.getActuals(); |
| 2074 | EXPECT_EQ(actuals1.presentTime, 0); |
| 2075 | |
| 2076 | // Trigger a flush by finalizing the next DisplayFrame |
| 2077 | auto presentFence2 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
Huihong Luo | 3bdef86 | 2022-03-03 11:57:19 -0800 | [diff] [blame] | 2078 | FrameTimelineInfo ftInfo2; |
| 2079 | ftInfo2.vsyncId = surfaceFrameToken2; |
| 2080 | ftInfo2.inputEventId = sInputEventId; |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 2081 | auto surfaceFrame2 = |
Huihong Luo | 3bdef86 | 2022-03-03 11:57:19 -0800 | [diff] [blame] | 2082 | mFrameTimeline->createSurfaceFrameForToken(ftInfo2, sPidOne, sUidOne, sLayerIdOne, |
| 2083 | sLayerNameOne, sLayerNameOne, |
| 2084 | /*isBuffer*/ true, sGameMode); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 2085 | surfaceFrame2->setAcquireFenceTime(36); |
Pascal Muetschard | ac7bcd9 | 2023-10-03 15:05:36 +0200 | [diff] [blame] | 2086 | mFrameTimeline->setSfWakeUp(sfToken2, 52, RR_11, RR_11); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 2087 | surfaceFrame2->setPresentState(SurfaceFrame::PresentState::Presented); |
| 2088 | mFrameTimeline->addSurfaceFrame(surfaceFrame2); |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 2089 | mFrameTimeline->setSfPresent(57, presentFence2); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 2090 | auto displayFrame2 = getDisplayFrame(1); |
| 2091 | auto& presentedSurfaceFrame2 = getSurfaceFrame(1, 0); |
| 2092 | |
| 2093 | // Fences for the first frame have flushed, so the present timestamps should be updated |
| 2094 | EXPECT_EQ(displayFrame1->getActuals().presentTime, 30); |
| 2095 | EXPECT_EQ(displayFrame1->getFramePresentMetadata(), FramePresentMetadata::EarlyPresent); |
| 2096 | EXPECT_EQ(displayFrame1->getFrameReadyMetadata(), FrameReadyMetadata::OnTimeFinish); |
| 2097 | EXPECT_EQ(displayFrame1->getJankType(), JankType::SurfaceFlingerScheduling); |
Ying Wei | 96eb535 | 2023-11-21 17:37:21 +0000 | [diff] [blame] | 2098 | EXPECT_EQ(displayFrame1->getJankSeverityType(), JankSeverityType::Partial); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 2099 | |
| 2100 | actuals1 = presentedSurfaceFrame1.getActuals(); |
| 2101 | EXPECT_EQ(actuals1.presentTime, 30); |
| 2102 | EXPECT_EQ(presentedSurfaceFrame1.getFramePresentMetadata(), FramePresentMetadata::EarlyPresent); |
| 2103 | EXPECT_EQ(presentedSurfaceFrame1.getFrameReadyMetadata(), FrameReadyMetadata::OnTimeFinish); |
| 2104 | EXPECT_EQ(presentedSurfaceFrame1.getJankType(), JankType::SurfaceFlingerScheduling); |
Ying Wei | 96eb535 | 2023-11-21 17:37:21 +0000 | [diff] [blame] | 2105 | EXPECT_EQ(presentedSurfaceFrame1.getJankSeverityType(), JankSeverityType::Partial); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 2106 | |
| 2107 | // Fences for the second frame haven't been flushed yet, so it should be 0 |
| 2108 | presentFence2->signalForTest(65); |
| 2109 | EXPECT_EQ(displayFrame2->getActuals().presentTime, 0); |
| 2110 | auto actuals2 = presentedSurfaceFrame2.getActuals(); |
| 2111 | EXPECT_EQ(actuals2.presentTime, 0); |
| 2112 | |
Alec Mouri | 363faf0 | 2021-01-29 16:34:55 -0800 | [diff] [blame] | 2113 | ::testing::Mock::VerifyAndClearExpectations(mTimeStats.get()); |
| 2114 | |
| 2115 | EXPECT_CALL(*mTimeStats, |
Pascal Muetschard | ac7bcd9 | 2023-10-03 15:05:36 +0200 | [diff] [blame] | 2116 | incrementJankyFrames(TimeStats::JankyFramesInfo{RR_11, std::nullopt, sUidOne, |
| 2117 | sLayerNameOne, sGameMode, |
| 2118 | JankType::PredictionError, -3, 5, |
| 2119 | 0})); |
Alec Mouri | 363faf0 | 2021-01-29 16:34:55 -0800 | [diff] [blame] | 2120 | |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 2121 | addEmptyDisplayFrame(); |
| 2122 | |
| 2123 | // Fences for the second frame have flushed, so the present timestamps should be updated |
| 2124 | EXPECT_EQ(displayFrame2->getActuals().presentTime, 65); |
| 2125 | EXPECT_EQ(displayFrame2->getFramePresentMetadata(), FramePresentMetadata::EarlyPresent); |
| 2126 | EXPECT_EQ(displayFrame2->getFrameReadyMetadata(), FrameReadyMetadata::OnTimeFinish); |
| 2127 | EXPECT_EQ(displayFrame2->getJankType(), JankType::PredictionError); |
Ying Wei | 96eb535 | 2023-11-21 17:37:21 +0000 | [diff] [blame] | 2128 | EXPECT_EQ(displayFrame2->getJankSeverityType(), JankSeverityType::Partial); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 2129 | |
| 2130 | actuals2 = presentedSurfaceFrame2.getActuals(); |
| 2131 | EXPECT_EQ(actuals2.presentTime, 65); |
| 2132 | EXPECT_EQ(presentedSurfaceFrame2.getFramePresentMetadata(), FramePresentMetadata::EarlyPresent); |
| 2133 | EXPECT_EQ(presentedSurfaceFrame2.getFrameReadyMetadata(), FrameReadyMetadata::OnTimeFinish); |
| 2134 | EXPECT_EQ(presentedSurfaceFrame2.getJankType(), JankType::PredictionError); |
Ying Wei | 96eb535 | 2023-11-21 17:37:21 +0000 | [diff] [blame] | 2135 | EXPECT_EQ(presentedSurfaceFrame2.getJankSeverityType(), JankSeverityType::Partial); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 2136 | } |
| 2137 | |
| 2138 | TEST_F(FrameTimelineTest, jankClassification_surfaceFrameOnTimeFinishLatePresent) { |
Alec Mouri | 363faf0 | 2021-01-29 16:34:55 -0800 | [diff] [blame] | 2139 | EXPECT_CALL(*mTimeStats, incrementJankyFrames(_)); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 2140 | auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 2141 | int64_t sfToken1 = mTokenManager->generateTokenForPredictions({22, 30, 40}); |
| 2142 | int64_t sfToken2 = mTokenManager->generateTokenForPredictions({52, 60, 70}); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 2143 | int64_t surfaceFrameToken1 = mTokenManager->generateTokenForPredictions({5, 16, 40}); |
| 2144 | int64_t surfaceFrameToken2 = mTokenManager->generateTokenForPredictions({25, 36, 70}); |
Huihong Luo | 3bdef86 | 2022-03-03 11:57:19 -0800 | [diff] [blame] | 2145 | FrameTimelineInfo ftInfo; |
| 2146 | ftInfo.vsyncId = surfaceFrameToken1; |
| 2147 | ftInfo.inputEventId = sInputEventId; |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 2148 | auto surfaceFrame1 = |
Huihong Luo | 3bdef86 | 2022-03-03 11:57:19 -0800 | [diff] [blame] | 2149 | mFrameTimeline->createSurfaceFrameForToken(ftInfo, sPidOne, sUidOne, sLayerIdOne, |
| 2150 | sLayerNameOne, sLayerNameOne, |
| 2151 | /*isBuffer*/ true, sGameMode); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 2152 | surfaceFrame1->setAcquireFenceTime(16); |
Pascal Muetschard | ac7bcd9 | 2023-10-03 15:05:36 +0200 | [diff] [blame] | 2153 | mFrameTimeline->setSfWakeUp(sfToken1, 22, RR_11, RR_11); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 2154 | surfaceFrame1->setPresentState(SurfaceFrame::PresentState::Presented); |
| 2155 | mFrameTimeline->addSurfaceFrame(surfaceFrame1); |
| 2156 | mFrameTimeline->setSfPresent(26, presentFence1); |
| 2157 | auto displayFrame1 = getDisplayFrame(0); |
| 2158 | auto& presentedSurfaceFrame1 = getSurfaceFrame(0, 0); |
| 2159 | presentFence1->signalForTest(50); |
| 2160 | |
| 2161 | // Fences for the first frame haven't been flushed yet, so it should be 0 |
| 2162 | EXPECT_EQ(displayFrame1->getActuals().presentTime, 0); |
| 2163 | auto actuals1 = presentedSurfaceFrame1.getActuals(); |
| 2164 | EXPECT_EQ(actuals1.presentTime, 0); |
| 2165 | |
| 2166 | // Trigger a flush by finalizing the next DisplayFrame |
| 2167 | auto presentFence2 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
Huihong Luo | 3bdef86 | 2022-03-03 11:57:19 -0800 | [diff] [blame] | 2168 | FrameTimelineInfo ftInfo2; |
| 2169 | ftInfo2.vsyncId = surfaceFrameToken2; |
| 2170 | ftInfo2.inputEventId = sInputEventId; |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 2171 | auto surfaceFrame2 = |
Huihong Luo | 3bdef86 | 2022-03-03 11:57:19 -0800 | [diff] [blame] | 2172 | mFrameTimeline->createSurfaceFrameForToken(ftInfo2, sPidOne, sUidOne, sLayerIdOne, |
| 2173 | sLayerNameOne, sLayerNameOne, |
| 2174 | /*isBuffer*/ true, sGameMode); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 2175 | surfaceFrame2->setAcquireFenceTime(36); |
Pascal Muetschard | ac7bcd9 | 2023-10-03 15:05:36 +0200 | [diff] [blame] | 2176 | mFrameTimeline->setSfWakeUp(sfToken2, 52, RR_11, RR_11); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 2177 | surfaceFrame2->setPresentState(SurfaceFrame::PresentState::Presented); |
| 2178 | mFrameTimeline->addSurfaceFrame(surfaceFrame2); |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 2179 | mFrameTimeline->setSfPresent(57, presentFence2); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 2180 | auto displayFrame2 = getDisplayFrame(1); |
| 2181 | auto& presentedSurfaceFrame2 = getSurfaceFrame(1, 0); |
| 2182 | |
| 2183 | // Fences for the first frame have flushed, so the present timestamps should be updated |
| 2184 | EXPECT_EQ(displayFrame1->getActuals().presentTime, 50); |
| 2185 | EXPECT_EQ(displayFrame1->getFramePresentMetadata(), FramePresentMetadata::LatePresent); |
| 2186 | EXPECT_EQ(displayFrame1->getFrameReadyMetadata(), FrameReadyMetadata::OnTimeFinish); |
| 2187 | EXPECT_EQ(displayFrame1->getJankType(), JankType::DisplayHAL); |
Ying Wei | 96eb535 | 2023-11-21 17:37:21 +0000 | [diff] [blame] | 2188 | EXPECT_EQ(displayFrame1->getJankSeverityType(), JankSeverityType::Partial); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 2189 | |
| 2190 | actuals1 = presentedSurfaceFrame1.getActuals(); |
| 2191 | EXPECT_EQ(actuals1.presentTime, 50); |
| 2192 | EXPECT_EQ(presentedSurfaceFrame1.getFramePresentMetadata(), FramePresentMetadata::LatePresent); |
| 2193 | EXPECT_EQ(presentedSurfaceFrame1.getFrameReadyMetadata(), FrameReadyMetadata::OnTimeFinish); |
| 2194 | EXPECT_EQ(presentedSurfaceFrame1.getJankType(), JankType::DisplayHAL); |
Ying Wei | 96eb535 | 2023-11-21 17:37:21 +0000 | [diff] [blame] | 2195 | EXPECT_EQ(presentedSurfaceFrame1.getJankSeverityType(), JankSeverityType::Partial); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 2196 | |
| 2197 | // Fences for the second frame haven't been flushed yet, so it should be 0 |
| 2198 | presentFence2->signalForTest(86); |
| 2199 | EXPECT_EQ(displayFrame2->getActuals().presentTime, 0); |
| 2200 | auto actuals2 = presentedSurfaceFrame2.getActuals(); |
| 2201 | EXPECT_EQ(actuals2.presentTime, 0); |
| 2202 | |
Alec Mouri | 363faf0 | 2021-01-29 16:34:55 -0800 | [diff] [blame] | 2203 | ::testing::Mock::VerifyAndClearExpectations(mTimeStats.get()); |
| 2204 | |
| 2205 | EXPECT_CALL(*mTimeStats, |
Pascal Muetschard | ac7bcd9 | 2023-10-03 15:05:36 +0200 | [diff] [blame] | 2206 | incrementJankyFrames(TimeStats::JankyFramesInfo{RR_11, std::nullopt, sUidOne, |
| 2207 | sLayerNameOne, sGameMode, |
| 2208 | JankType::PredictionError, -3, 5, |
| 2209 | 0})); |
Alec Mouri | 363faf0 | 2021-01-29 16:34:55 -0800 | [diff] [blame] | 2210 | |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 2211 | addEmptyDisplayFrame(); |
| 2212 | |
| 2213 | // Fences for the second frame have flushed, so the present timestamps should be updated |
| 2214 | EXPECT_EQ(displayFrame2->getActuals().presentTime, 86); |
| 2215 | EXPECT_EQ(displayFrame2->getFramePresentMetadata(), FramePresentMetadata::LatePresent); |
| 2216 | EXPECT_EQ(displayFrame2->getFrameReadyMetadata(), FrameReadyMetadata::OnTimeFinish); |
| 2217 | EXPECT_EQ(displayFrame2->getJankType(), JankType::PredictionError); |
Ying Wei | 96eb535 | 2023-11-21 17:37:21 +0000 | [diff] [blame] | 2218 | EXPECT_EQ(displayFrame2->getJankSeverityType(), JankSeverityType::Full); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 2219 | |
| 2220 | actuals2 = presentedSurfaceFrame2.getActuals(); |
| 2221 | EXPECT_EQ(actuals2.presentTime, 86); |
| 2222 | EXPECT_EQ(presentedSurfaceFrame2.getFramePresentMetadata(), FramePresentMetadata::LatePresent); |
| 2223 | EXPECT_EQ(presentedSurfaceFrame2.getFrameReadyMetadata(), FrameReadyMetadata::OnTimeFinish); |
| 2224 | EXPECT_EQ(presentedSurfaceFrame2.getJankType(), JankType::PredictionError); |
Ying Wei | 96eb535 | 2023-11-21 17:37:21 +0000 | [diff] [blame] | 2225 | EXPECT_EQ(presentedSurfaceFrame2.getJankSeverityType(), JankSeverityType::Full); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 2226 | } |
| 2227 | |
| 2228 | TEST_F(FrameTimelineTest, jankClassification_surfaceFrameLateFinishEarlyPresent) { |
Alec Mouri | 363faf0 | 2021-01-29 16:34:55 -0800 | [diff] [blame] | 2229 | EXPECT_CALL(*mTimeStats, incrementJankyFrames(_)); |
Alec Mouri | 7d436ec | 2021-01-27 20:40:50 -0800 | [diff] [blame] | 2230 | |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 2231 | auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 2232 | int64_t sfToken1 = mTokenManager->generateTokenForPredictions({42, 50, 50}); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 2233 | int64_t surfaceFrameToken1 = mTokenManager->generateTokenForPredictions({5, 26, 60}); |
Huihong Luo | 3bdef86 | 2022-03-03 11:57:19 -0800 | [diff] [blame] | 2234 | FrameTimelineInfo ftInfo; |
| 2235 | ftInfo.vsyncId = surfaceFrameToken1; |
| 2236 | ftInfo.inputEventId = sInputEventId; |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 2237 | auto surfaceFrame1 = |
Huihong Luo | 3bdef86 | 2022-03-03 11:57:19 -0800 | [diff] [blame] | 2238 | mFrameTimeline->createSurfaceFrameForToken(ftInfo, sPidOne, sUidOne, sLayerIdOne, |
| 2239 | sLayerNameOne, sLayerNameOne, |
| 2240 | /*isBuffer*/ true, sGameMode); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 2241 | surfaceFrame1->setAcquireFenceTime(40); |
Pascal Muetschard | ac7bcd9 | 2023-10-03 15:05:36 +0200 | [diff] [blame] | 2242 | mFrameTimeline->setSfWakeUp(sfToken1, 42, RR_11, RR_11); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 2243 | surfaceFrame1->setPresentState(SurfaceFrame::PresentState::Presented); |
| 2244 | mFrameTimeline->addSurfaceFrame(surfaceFrame1); |
| 2245 | mFrameTimeline->setSfPresent(46, presentFence1); |
| 2246 | auto displayFrame1 = getDisplayFrame(0); |
| 2247 | auto& presentedSurfaceFrame1 = getSurfaceFrame(0, 0); |
| 2248 | presentFence1->signalForTest(50); |
| 2249 | |
| 2250 | // Fences for the first frame haven't been flushed yet, so it should be 0 |
| 2251 | EXPECT_EQ(displayFrame1->getActuals().presentTime, 0); |
| 2252 | auto actuals1 = presentedSurfaceFrame1.getActuals(); |
| 2253 | EXPECT_EQ(actuals1.presentTime, 0); |
| 2254 | |
| 2255 | addEmptyDisplayFrame(); |
| 2256 | |
| 2257 | // Fences for the first frame have flushed, so the present timestamps should be updated |
| 2258 | EXPECT_EQ(displayFrame1->getActuals().presentTime, 50); |
| 2259 | EXPECT_EQ(displayFrame1->getFramePresentMetadata(), FramePresentMetadata::OnTimePresent); |
| 2260 | EXPECT_EQ(displayFrame1->getFrameReadyMetadata(), FrameReadyMetadata::OnTimeFinish); |
| 2261 | EXPECT_EQ(displayFrame1->getJankType(), JankType::None); |
Ying Wei | 96eb535 | 2023-11-21 17:37:21 +0000 | [diff] [blame] | 2262 | EXPECT_EQ(displayFrame1->getJankSeverityType(), JankSeverityType::None); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 2263 | |
| 2264 | actuals1 = presentedSurfaceFrame1.getActuals(); |
| 2265 | EXPECT_EQ(actuals1.presentTime, 50); |
| 2266 | EXPECT_EQ(presentedSurfaceFrame1.getFramePresentMetadata(), FramePresentMetadata::EarlyPresent); |
| 2267 | EXPECT_EQ(presentedSurfaceFrame1.getFrameReadyMetadata(), FrameReadyMetadata::LateFinish); |
| 2268 | EXPECT_EQ(presentedSurfaceFrame1.getJankType(), JankType::Unknown); |
Ying Wei | 96eb535 | 2023-11-21 17:37:21 +0000 | [diff] [blame] | 2269 | EXPECT_EQ(presentedSurfaceFrame1.getJankSeverityType(), JankSeverityType::Partial); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 2270 | } |
| 2271 | |
| 2272 | TEST_F(FrameTimelineTest, jankClassification_surfaceFrameLateFinishLatePresent) { |
Adithya Srinivasan | 8a94550 | 2021-03-19 19:12:32 +0000 | [diff] [blame] | 2273 | // First frame - DisplayFrame is not janky. This should classify the SurfaceFrame as only |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 2274 | // AppDeadlineMissed. Second frame - DisplayFrame is janky. This should propagate DisplayFrame's |
Adithya Srinivasan | 8a94550 | 2021-03-19 19:12:32 +0000 | [diff] [blame] | 2275 | // jank to the SurfaceFrame along with AppDeadlineMissed. |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 2276 | |
Alec Mouri | 363faf0 | 2021-01-29 16:34:55 -0800 | [diff] [blame] | 2277 | EXPECT_CALL(*mTimeStats, incrementJankyFrames(_)).Times(2); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 2278 | auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 2279 | int64_t sfToken1 = mTokenManager->generateTokenForPredictions({32, 40, 40}); |
| 2280 | int64_t sfToken2 = mTokenManager->generateTokenForPredictions({42, 50, 50}); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 2281 | int64_t surfaceFrameToken1 = mTokenManager->generateTokenForPredictions({5, 16, 30}); |
| 2282 | int64_t surfaceFrameToken2 = mTokenManager->generateTokenForPredictions({25, 36, 50}); |
Huihong Luo | 3bdef86 | 2022-03-03 11:57:19 -0800 | [diff] [blame] | 2283 | FrameTimelineInfo ftInfo; |
| 2284 | ftInfo.vsyncId = surfaceFrameToken1; |
| 2285 | ftInfo.inputEventId = sInputEventId; |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 2286 | auto surfaceFrame1 = |
Huihong Luo | 3bdef86 | 2022-03-03 11:57:19 -0800 | [diff] [blame] | 2287 | mFrameTimeline->createSurfaceFrameForToken(ftInfo, sPidOne, sUidOne, sLayerIdOne, |
| 2288 | sLayerNameOne, sLayerNameOne, |
| 2289 | /*isBuffer*/ true, sGameMode); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 2290 | surfaceFrame1->setAcquireFenceTime(26); |
Pascal Muetschard | ac7bcd9 | 2023-10-03 15:05:36 +0200 | [diff] [blame] | 2291 | mFrameTimeline->setSfWakeUp(sfToken1, 32, RR_11, RR_11); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 2292 | surfaceFrame1->setPresentState(SurfaceFrame::PresentState::Presented); |
| 2293 | mFrameTimeline->addSurfaceFrame(surfaceFrame1); |
| 2294 | mFrameTimeline->setSfPresent(36, presentFence1); |
| 2295 | auto displayFrame1 = getDisplayFrame(0); |
| 2296 | auto& presentedSurfaceFrame1 = getSurfaceFrame(0, 0); |
| 2297 | presentFence1->signalForTest(40); |
| 2298 | |
| 2299 | // Fences for the first frame haven't been flushed yet, so it should be 0 |
| 2300 | EXPECT_EQ(displayFrame1->getActuals().presentTime, 0); |
| 2301 | auto actuals1 = presentedSurfaceFrame1.getActuals(); |
| 2302 | EXPECT_EQ(actuals1.presentTime, 0); |
| 2303 | |
| 2304 | // Trigger a flush by finalizing the next DisplayFrame |
| 2305 | auto presentFence2 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
Huihong Luo | 3bdef86 | 2022-03-03 11:57:19 -0800 | [diff] [blame] | 2306 | FrameTimelineInfo ftInfo2; |
| 2307 | ftInfo2.vsyncId = surfaceFrameToken2; |
| 2308 | ftInfo2.inputEventId = sInputEventId; |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 2309 | auto surfaceFrame2 = |
Huihong Luo | 3bdef86 | 2022-03-03 11:57:19 -0800 | [diff] [blame] | 2310 | mFrameTimeline->createSurfaceFrameForToken(ftInfo2, sPidOne, sUidOne, sLayerIdOne, |
| 2311 | sLayerNameOne, sLayerNameOne, |
| 2312 | /*isBuffer*/ true, sGameMode); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 2313 | surfaceFrame2->setAcquireFenceTime(40); |
Pascal Muetschard | ac7bcd9 | 2023-10-03 15:05:36 +0200 | [diff] [blame] | 2314 | mFrameTimeline->setSfWakeUp(sfToken2, 43, RR_11, RR_11); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 2315 | surfaceFrame2->setPresentState(SurfaceFrame::PresentState::Presented); |
| 2316 | mFrameTimeline->addSurfaceFrame(surfaceFrame2); |
| 2317 | mFrameTimeline->setSfPresent(56, presentFence2); |
| 2318 | auto displayFrame2 = getDisplayFrame(1); |
| 2319 | auto& presentedSurfaceFrame2 = getSurfaceFrame(1, 0); |
| 2320 | |
| 2321 | // Fences for the first frame have flushed, so the present timestamps should be updated |
| 2322 | EXPECT_EQ(displayFrame1->getActuals().presentTime, 40); |
| 2323 | EXPECT_EQ(displayFrame1->getFramePresentMetadata(), FramePresentMetadata::OnTimePresent); |
| 2324 | EXPECT_EQ(displayFrame1->getFrameReadyMetadata(), FrameReadyMetadata::OnTimeFinish); |
| 2325 | EXPECT_EQ(displayFrame1->getJankType(), JankType::None); |
Ying Wei | 96eb535 | 2023-11-21 17:37:21 +0000 | [diff] [blame] | 2326 | EXPECT_EQ(displayFrame1->getJankSeverityType(), JankSeverityType::None); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 2327 | |
| 2328 | actuals1 = presentedSurfaceFrame1.getActuals(); |
| 2329 | EXPECT_EQ(actuals1.presentTime, 40); |
| 2330 | EXPECT_EQ(presentedSurfaceFrame1.getFramePresentMetadata(), FramePresentMetadata::LatePresent); |
| 2331 | EXPECT_EQ(presentedSurfaceFrame1.getFrameReadyMetadata(), FrameReadyMetadata::LateFinish); |
| 2332 | EXPECT_EQ(presentedSurfaceFrame1.getJankType(), JankType::AppDeadlineMissed); |
Ying Wei | 96eb535 | 2023-11-21 17:37:21 +0000 | [diff] [blame] | 2333 | EXPECT_EQ(presentedSurfaceFrame1.getJankSeverityType(), JankSeverityType::Partial); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 2334 | |
| 2335 | // Fences for the second frame haven't been flushed yet, so it should be 0 |
| 2336 | presentFence2->signalForTest(60); |
| 2337 | EXPECT_EQ(displayFrame2->getActuals().presentTime, 0); |
| 2338 | auto actuals2 = presentedSurfaceFrame2.getActuals(); |
| 2339 | EXPECT_EQ(actuals2.presentTime, 0); |
| 2340 | |
| 2341 | addEmptyDisplayFrame(); |
| 2342 | |
| 2343 | // Fences for the second frame have flushed, so the present timestamps should be updated |
| 2344 | EXPECT_EQ(displayFrame2->getActuals().presentTime, 60); |
| 2345 | EXPECT_EQ(displayFrame2->getFramePresentMetadata(), FramePresentMetadata::LatePresent); |
| 2346 | EXPECT_EQ(displayFrame2->getFrameReadyMetadata(), FrameReadyMetadata::LateFinish); |
| 2347 | EXPECT_EQ(displayFrame2->getJankType(), JankType::SurfaceFlingerCpuDeadlineMissed); |
Ying Wei | 96eb535 | 2023-11-21 17:37:21 +0000 | [diff] [blame] | 2348 | EXPECT_EQ(displayFrame2->getJankSeverityType(), JankSeverityType::Partial); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 2349 | |
| 2350 | actuals2 = presentedSurfaceFrame2.getActuals(); |
| 2351 | EXPECT_EQ(actuals2.presentTime, 60); |
| 2352 | EXPECT_EQ(presentedSurfaceFrame2.getFramePresentMetadata(), FramePresentMetadata::LatePresent); |
| 2353 | EXPECT_EQ(presentedSurfaceFrame2.getFrameReadyMetadata(), FrameReadyMetadata::LateFinish); |
Adithya Srinivasan | 8a94550 | 2021-03-19 19:12:32 +0000 | [diff] [blame] | 2354 | EXPECT_EQ(presentedSurfaceFrame2.getJankType(), |
| 2355 | JankType::SurfaceFlingerCpuDeadlineMissed | JankType::AppDeadlineMissed); |
Ying Wei | 96eb535 | 2023-11-21 17:37:21 +0000 | [diff] [blame] | 2356 | EXPECT_EQ(presentedSurfaceFrame2.getJankSeverityType(), JankSeverityType::Partial); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 2357 | } |
| 2358 | |
| 2359 | TEST_F(FrameTimelineTest, jankClassification_multiJankBufferStuffingAndAppDeadlineMissed) { |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 2360 | // Layer specific increment |
Alec Mouri | 363faf0 | 2021-01-29 16:34:55 -0800 | [diff] [blame] | 2361 | EXPECT_CALL(*mTimeStats, incrementJankyFrames(_)).Times(2); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 2362 | auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
| 2363 | int64_t surfaceFrameToken1 = mTokenManager->generateTokenForPredictions({10, 20, 30}); |
| 2364 | int64_t surfaceFrameToken2 = mTokenManager->generateTokenForPredictions({40, 50, 60}); |
| 2365 | |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 2366 | int64_t sfToken1 = mTokenManager->generateTokenForPredictions({52, 60, 60}); |
| 2367 | int64_t sfToken2 = mTokenManager->generateTokenForPredictions({112, 120, 120}); |
Huihong Luo | 3bdef86 | 2022-03-03 11:57:19 -0800 | [diff] [blame] | 2368 | FrameTimelineInfo ftInfo; |
| 2369 | ftInfo.vsyncId = surfaceFrameToken1; |
| 2370 | ftInfo.inputEventId = sInputEventId; |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 2371 | auto surfaceFrame1 = |
Huihong Luo | 3bdef86 | 2022-03-03 11:57:19 -0800 | [diff] [blame] | 2372 | mFrameTimeline->createSurfaceFrameForToken(ftInfo, sPidOne, sUidOne, sLayerIdOne, |
| 2373 | sLayerNameOne, sLayerNameOne, |
| 2374 | /*isBuffer*/ true, sGameMode); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 2375 | surfaceFrame1->setAcquireFenceTime(50); |
Pascal Muetschard | ac7bcd9 | 2023-10-03 15:05:36 +0200 | [diff] [blame] | 2376 | mFrameTimeline->setSfWakeUp(sfToken1, 52, RR_30, RR_30); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 2377 | surfaceFrame1->setPresentState(SurfaceFrame::PresentState::Presented); |
| 2378 | mFrameTimeline->addSurfaceFrame(surfaceFrame1); |
| 2379 | mFrameTimeline->setSfPresent(56, presentFence1); |
| 2380 | auto displayFrame1 = getDisplayFrame(0); |
| 2381 | auto& presentedSurfaceFrame1 = getSurfaceFrame(0, 0); |
| 2382 | presentFence1->signalForTest(60); |
| 2383 | |
| 2384 | // Fences for the first frame haven't been flushed yet, so it should be 0 |
| 2385 | EXPECT_EQ(displayFrame1->getActuals().presentTime, 0); |
| 2386 | auto actuals1 = presentedSurfaceFrame1.getActuals(); |
| 2387 | EXPECT_EQ(actuals1.presentTime, 0); |
| 2388 | |
| 2389 | // Trigger a flush by finalizing the next DisplayFrame |
| 2390 | auto presentFence2 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
Huihong Luo | 3bdef86 | 2022-03-03 11:57:19 -0800 | [diff] [blame] | 2391 | FrameTimelineInfo ftInfo2; |
| 2392 | ftInfo2.vsyncId = surfaceFrameToken2; |
| 2393 | ftInfo2.inputEventId = sInputEventId; |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 2394 | auto surfaceFrame2 = |
Huihong Luo | 3bdef86 | 2022-03-03 11:57:19 -0800 | [diff] [blame] | 2395 | mFrameTimeline->createSurfaceFrameForToken(ftInfo2, sPidOne, sUidOne, sLayerIdOne, |
| 2396 | sLayerNameOne, sLayerNameOne, |
| 2397 | /*isBuffer*/ true, sGameMode); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 2398 | surfaceFrame2->setAcquireFenceTime(84); |
Pascal Muetschard | ac7bcd9 | 2023-10-03 15:05:36 +0200 | [diff] [blame] | 2399 | mFrameTimeline->setSfWakeUp(sfToken2, 112, RR_30, RR_30); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 2400 | surfaceFrame2->setPresentState(SurfaceFrame::PresentState::Presented, 54); |
| 2401 | mFrameTimeline->addSurfaceFrame(surfaceFrame2); |
| 2402 | mFrameTimeline->setSfPresent(116, presentFence2); |
| 2403 | auto displayFrame2 = getDisplayFrame(1); |
| 2404 | auto& presentedSurfaceFrame2 = getSurfaceFrame(1, 0); |
| 2405 | presentFence2->signalForTest(120); |
| 2406 | |
| 2407 | // Fences for the first frame have flushed, so the present timestamps should be updated |
| 2408 | EXPECT_EQ(displayFrame1->getActuals().presentTime, 60); |
| 2409 | actuals1 = presentedSurfaceFrame1.getActuals(); |
| 2410 | EXPECT_EQ(actuals1.endTime, 50); |
| 2411 | EXPECT_EQ(actuals1.presentTime, 60); |
| 2412 | |
| 2413 | EXPECT_EQ(displayFrame1->getFramePresentMetadata(), FramePresentMetadata::OnTimePresent); |
| 2414 | EXPECT_EQ(displayFrame1->getFrameReadyMetadata(), FrameReadyMetadata::OnTimeFinish); |
| 2415 | EXPECT_EQ(displayFrame1->getJankType(), JankType::None); |
Ying Wei | 96eb535 | 2023-11-21 17:37:21 +0000 | [diff] [blame] | 2416 | EXPECT_EQ(displayFrame1->getJankSeverityType(), JankSeverityType::None); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 2417 | |
| 2418 | EXPECT_EQ(presentedSurfaceFrame1.getFramePresentMetadata(), FramePresentMetadata::LatePresent); |
| 2419 | EXPECT_EQ(presentedSurfaceFrame1.getFrameReadyMetadata(), FrameReadyMetadata::LateFinish); |
| 2420 | EXPECT_EQ(presentedSurfaceFrame1.getJankType(), JankType::AppDeadlineMissed); |
Ying Wei | 96eb535 | 2023-11-21 17:37:21 +0000 | [diff] [blame] | 2421 | EXPECT_EQ(presentedSurfaceFrame1.getJankSeverityType(), JankSeverityType::Full); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 2422 | |
| 2423 | // Fences for the second frame haven't been flushed yet, so it should be 0 |
| 2424 | EXPECT_EQ(displayFrame2->getActuals().presentTime, 0); |
| 2425 | auto actuals2 = presentedSurfaceFrame2.getActuals(); |
| 2426 | EXPECT_EQ(actuals2.presentTime, 0); |
| 2427 | |
| 2428 | addEmptyDisplayFrame(); |
| 2429 | |
| 2430 | // Fences for the second frame have flushed, so the present timestamps should be updated |
| 2431 | EXPECT_EQ(displayFrame2->getActuals().presentTime, 120); |
| 2432 | actuals2 = presentedSurfaceFrame2.getActuals(); |
| 2433 | EXPECT_EQ(actuals2.presentTime, 120); |
| 2434 | |
| 2435 | EXPECT_EQ(displayFrame2->getFramePresentMetadata(), FramePresentMetadata::OnTimePresent); |
| 2436 | EXPECT_EQ(displayFrame2->getFrameReadyMetadata(), FrameReadyMetadata::OnTimeFinish); |
| 2437 | EXPECT_EQ(displayFrame2->getJankType(), JankType::None); |
Ying Wei | 96eb535 | 2023-11-21 17:37:21 +0000 | [diff] [blame] | 2438 | EXPECT_EQ(displayFrame2->getJankSeverityType(), JankSeverityType::None); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 2439 | |
| 2440 | EXPECT_EQ(presentedSurfaceFrame2.getFramePresentMetadata(), FramePresentMetadata::LatePresent); |
| 2441 | EXPECT_EQ(presentedSurfaceFrame2.getFrameReadyMetadata(), FrameReadyMetadata::LateFinish); |
| 2442 | EXPECT_EQ(presentedSurfaceFrame2.getJankType(), |
| 2443 | JankType::AppDeadlineMissed | JankType::BufferStuffing); |
Ying Wei | 96eb535 | 2023-11-21 17:37:21 +0000 | [diff] [blame] | 2444 | EXPECT_EQ(presentedSurfaceFrame2.getJankSeverityType(), JankSeverityType::Full); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 2445 | } |
Alec Mouri | adebf5c | 2021-01-05 12:57:36 -0800 | [diff] [blame] | 2446 | |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 2447 | TEST_F(FrameTimelineTest, jankClassification_appDeadlineAdjustedForBufferStuffing) { |
| 2448 | // Layer specific increment |
| 2449 | EXPECT_CALL(*mTimeStats, incrementJankyFrames(_)).Times(2); |
| 2450 | auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
| 2451 | int64_t surfaceFrameToken1 = mTokenManager->generateTokenForPredictions({10, 20, 30}); |
| 2452 | int64_t surfaceFrameToken2 = mTokenManager->generateTokenForPredictions({40, 50, 60}); |
| 2453 | |
| 2454 | int64_t sfToken1 = mTokenManager->generateTokenForPredictions({52, 60, 60}); |
| 2455 | int64_t sfToken2 = mTokenManager->generateTokenForPredictions({82, 90, 90}); |
Huihong Luo | 3bdef86 | 2022-03-03 11:57:19 -0800 | [diff] [blame] | 2456 | FrameTimelineInfo ftInfo; |
| 2457 | ftInfo.vsyncId = surfaceFrameToken1; |
| 2458 | ftInfo.inputEventId = sInputEventId; |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 2459 | auto surfaceFrame1 = |
Huihong Luo | 3bdef86 | 2022-03-03 11:57:19 -0800 | [diff] [blame] | 2460 | mFrameTimeline->createSurfaceFrameForToken(ftInfo, sPidOne, sUidOne, sLayerIdOne, |
| 2461 | sLayerNameOne, sLayerNameOne, |
| 2462 | /*isBuffer*/ true, sGameMode); |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 2463 | surfaceFrame1->setAcquireFenceTime(50); |
Pascal Muetschard | ac7bcd9 | 2023-10-03 15:05:36 +0200 | [diff] [blame] | 2464 | mFrameTimeline->setSfWakeUp(sfToken1, 52, RR_30, RR_30); |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 2465 | surfaceFrame1->setPresentState(SurfaceFrame::PresentState::Presented); |
| 2466 | mFrameTimeline->addSurfaceFrame(surfaceFrame1); |
| 2467 | mFrameTimeline->setSfPresent(56, presentFence1); |
| 2468 | auto displayFrame1 = getDisplayFrame(0); |
| 2469 | auto& presentedSurfaceFrame1 = getSurfaceFrame(0, 0); |
| 2470 | presentFence1->signalForTest(60); |
| 2471 | |
| 2472 | // Fences for the first frame haven't been flushed yet, so it should be 0 |
| 2473 | EXPECT_EQ(displayFrame1->getActuals().presentTime, 0); |
| 2474 | auto actuals1 = presentedSurfaceFrame1.getActuals(); |
| 2475 | EXPECT_EQ(actuals1.presentTime, 0); |
| 2476 | |
| 2477 | // Trigger a flush by finalizing the next DisplayFrame |
| 2478 | auto presentFence2 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
Huihong Luo | 3bdef86 | 2022-03-03 11:57:19 -0800 | [diff] [blame] | 2479 | FrameTimelineInfo ftInfo2; |
| 2480 | ftInfo2.vsyncId = surfaceFrameToken2; |
| 2481 | ftInfo2.inputEventId = sInputEventId; |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 2482 | auto surfaceFrame2 = |
Huihong Luo | 3bdef86 | 2022-03-03 11:57:19 -0800 | [diff] [blame] | 2483 | mFrameTimeline->createSurfaceFrameForToken(ftInfo2, sPidOne, sUidOne, sLayerIdOne, |
| 2484 | sLayerNameOne, sLayerNameOne, |
| 2485 | /*isBuffer*/ true, sGameMode); |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 2486 | surfaceFrame2->setAcquireFenceTime(80); |
Pascal Muetschard | ac7bcd9 | 2023-10-03 15:05:36 +0200 | [diff] [blame] | 2487 | mFrameTimeline->setSfWakeUp(sfToken2, 82, RR_30, RR_30); |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 2488 | // Setting previous latch time to 54, adjusted deadline will be 54 + vsyncTime(30) = 84 |
| 2489 | surfaceFrame2->setPresentState(SurfaceFrame::PresentState::Presented, 54); |
| 2490 | mFrameTimeline->addSurfaceFrame(surfaceFrame2); |
| 2491 | mFrameTimeline->setSfPresent(86, presentFence2); |
| 2492 | auto displayFrame2 = getDisplayFrame(1); |
| 2493 | auto& presentedSurfaceFrame2 = getSurfaceFrame(1, 0); |
| 2494 | presentFence2->signalForTest(90); |
| 2495 | |
| 2496 | // Fences for the first frame have flushed, so the present timestamps should be updated |
| 2497 | EXPECT_EQ(displayFrame1->getActuals().presentTime, 60); |
| 2498 | actuals1 = presentedSurfaceFrame1.getActuals(); |
| 2499 | EXPECT_EQ(actuals1.endTime, 50); |
| 2500 | EXPECT_EQ(actuals1.presentTime, 60); |
| 2501 | |
| 2502 | EXPECT_EQ(displayFrame1->getFramePresentMetadata(), FramePresentMetadata::OnTimePresent); |
| 2503 | EXPECT_EQ(displayFrame1->getFrameReadyMetadata(), FrameReadyMetadata::OnTimeFinish); |
| 2504 | EXPECT_EQ(displayFrame1->getJankType(), JankType::None); |
Ying Wei | 96eb535 | 2023-11-21 17:37:21 +0000 | [diff] [blame] | 2505 | EXPECT_EQ(displayFrame1->getJankSeverityType(), JankSeverityType::None); |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 2506 | |
| 2507 | EXPECT_EQ(presentedSurfaceFrame1.getFramePresentMetadata(), FramePresentMetadata::LatePresent); |
| 2508 | EXPECT_EQ(presentedSurfaceFrame1.getFrameReadyMetadata(), FrameReadyMetadata::LateFinish); |
| 2509 | EXPECT_EQ(presentedSurfaceFrame1.getJankType(), JankType::AppDeadlineMissed); |
Ying Wei | 96eb535 | 2023-11-21 17:37:21 +0000 | [diff] [blame] | 2510 | EXPECT_EQ(presentedSurfaceFrame1.getJankSeverityType(), JankSeverityType::Full); |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 2511 | |
| 2512 | // Fences for the second frame haven't been flushed yet, so it should be 0 |
| 2513 | EXPECT_EQ(displayFrame2->getActuals().presentTime, 0); |
| 2514 | auto actuals2 = presentedSurfaceFrame2.getActuals(); |
| 2515 | EXPECT_EQ(actuals2.presentTime, 0); |
| 2516 | |
| 2517 | addEmptyDisplayFrame(); |
| 2518 | |
| 2519 | // Fences for the second frame have flushed, so the present timestamps should be updated |
| 2520 | EXPECT_EQ(displayFrame2->getActuals().presentTime, 90); |
| 2521 | actuals2 = presentedSurfaceFrame2.getActuals(); |
| 2522 | EXPECT_EQ(actuals2.presentTime, 90); |
| 2523 | |
| 2524 | EXPECT_EQ(displayFrame2->getFramePresentMetadata(), FramePresentMetadata::OnTimePresent); |
| 2525 | EXPECT_EQ(displayFrame2->getFrameReadyMetadata(), FrameReadyMetadata::OnTimeFinish); |
| 2526 | EXPECT_EQ(displayFrame2->getJankType(), JankType::None); |
Ying Wei | 96eb535 | 2023-11-21 17:37:21 +0000 | [diff] [blame] | 2527 | EXPECT_EQ(displayFrame2->getJankSeverityType(), JankSeverityType::None); |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 2528 | |
| 2529 | EXPECT_EQ(presentedSurfaceFrame2.getFramePresentMetadata(), FramePresentMetadata::LatePresent); |
| 2530 | EXPECT_EQ(presentedSurfaceFrame2.getFrameReadyMetadata(), FrameReadyMetadata::OnTimeFinish); |
| 2531 | EXPECT_EQ(presentedSurfaceFrame2.getJankType(), JankType::BufferStuffing); |
Ying Wei | 96eb535 | 2023-11-21 17:37:21 +0000 | [diff] [blame] | 2532 | EXPECT_EQ(presentedSurfaceFrame2.getJankSeverityType(), JankSeverityType::Full); |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 2533 | } |
| 2534 | |
Rachel Lee | 94917b3 | 2022-03-18 17:52:09 -0700 | [diff] [blame] | 2535 | TEST_F(FrameTimelineTest, jankClassification_displayFrameLateFinishLatePresent_GpuAndCpuMiss) { |
| 2536 | auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
| 2537 | auto presentFence2 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
| 2538 | auto gpuFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
| 2539 | int64_t sfToken1 = mTokenManager->generateTokenForPredictions({22, 26, 40}); |
| 2540 | int64_t sfToken2 = mTokenManager->generateTokenForPredictions({52, 60, 60}); |
| 2541 | |
| 2542 | // Case 1: cpu time = 33 - 12 = 21, vsync period = 11 |
Pascal Muetschard | ac7bcd9 | 2023-10-03 15:05:36 +0200 | [diff] [blame] | 2543 | mFrameTimeline->setSfWakeUp(sfToken1, 12, RR_11, RR_11); |
Rachel Lee | 94917b3 | 2022-03-18 17:52:09 -0700 | [diff] [blame] | 2544 | mFrameTimeline->setSfPresent(33, presentFence1, gpuFence1); |
| 2545 | auto displayFrame = getDisplayFrame(0); |
| 2546 | gpuFence1->signalForTest(36); |
| 2547 | presentFence1->signalForTest(52); |
| 2548 | |
| 2549 | // Fences haven't been flushed yet, so it should be 0 |
| 2550 | EXPECT_EQ(displayFrame->getActuals().presentTime, 0); |
| 2551 | |
| 2552 | addEmptyDisplayFrame(); |
| 2553 | displayFrame = getDisplayFrame(0); |
| 2554 | |
| 2555 | // Fences have flushed, so the present timestamps should be updated |
| 2556 | EXPECT_EQ(displayFrame->getActuals().presentTime, 52); |
| 2557 | EXPECT_EQ(displayFrame->getFramePresentMetadata(), FramePresentMetadata::LatePresent); |
| 2558 | EXPECT_EQ(displayFrame->getFrameReadyMetadata(), FrameReadyMetadata::LateFinish); |
| 2559 | EXPECT_EQ(displayFrame->getJankType(), JankType::SurfaceFlingerGpuDeadlineMissed); |
Ying Wei | 96eb535 | 2023-11-21 17:37:21 +0000 | [diff] [blame] | 2560 | EXPECT_EQ(displayFrame->getJankSeverityType(), JankSeverityType::Full); |
Rachel Lee | 94917b3 | 2022-03-18 17:52:09 -0700 | [diff] [blame] | 2561 | |
| 2562 | // Case 2: No GPU fence so it will not use GPU composition. |
Pascal Muetschard | ac7bcd9 | 2023-10-03 15:05:36 +0200 | [diff] [blame] | 2563 | mFrameTimeline->setSfWakeUp(sfToken2, 52, RR_30, RR_30); |
Rachel Lee | 94917b3 | 2022-03-18 17:52:09 -0700 | [diff] [blame] | 2564 | mFrameTimeline->setSfPresent(66, presentFence2); |
| 2565 | auto displayFrame2 = getDisplayFrame(2); // 2 because of previous empty frame |
| 2566 | presentFence2->signalForTest(90); |
| 2567 | |
| 2568 | // Fences for the frame haven't been flushed yet, so it should be 0 |
| 2569 | EXPECT_EQ(displayFrame2->getActuals().presentTime, 0); |
| 2570 | |
| 2571 | addEmptyDisplayFrame(); |
| 2572 | |
| 2573 | // Fences have flushed, so the present timestamps should be updated |
| 2574 | EXPECT_EQ(displayFrame2->getActuals().presentTime, 90); |
| 2575 | EXPECT_EQ(displayFrame2->getFramePresentMetadata(), FramePresentMetadata::LatePresent); |
| 2576 | EXPECT_EQ(displayFrame2->getFrameReadyMetadata(), FrameReadyMetadata::LateFinish); |
| 2577 | EXPECT_EQ(displayFrame2->getJankType(), JankType::SurfaceFlingerCpuDeadlineMissed); |
Ying Wei | 96eb535 | 2023-11-21 17:37:21 +0000 | [diff] [blame] | 2578 | EXPECT_EQ(displayFrame2->getJankSeverityType(), JankSeverityType::Full); |
Rachel Lee | 94917b3 | 2022-03-18 17:52:09 -0700 | [diff] [blame] | 2579 | } |
| 2580 | |
Ady Abraham | fcb1686 | 2022-10-10 14:35:21 -0700 | [diff] [blame] | 2581 | TEST_F(FrameTimelineTest, jankClassification_presentFenceError) { |
| 2582 | auto erroneousPresentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
| 2583 | auto erroneousPresentFence2 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
| 2584 | auto validPresentFence = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
| 2585 | int64_t sfToken1 = mTokenManager->generateTokenForPredictions({22, 26, 40}); |
| 2586 | int64_t sfToken2 = mTokenManager->generateTokenForPredictions({52, 60, 60}); |
| 2587 | int64_t sfToken3 = mTokenManager->generateTokenForPredictions({72, 80, 80}); |
| 2588 | |
Pascal Muetschard | ac7bcd9 | 2023-10-03 15:05:36 +0200 | [diff] [blame] | 2589 | mFrameTimeline->setSfWakeUp(sfToken1, 22, RR_11, RR_11); |
Ady Abraham | fcb1686 | 2022-10-10 14:35:21 -0700 | [diff] [blame] | 2590 | mFrameTimeline->setSfPresent(26, erroneousPresentFence1); |
| 2591 | |
Pascal Muetschard | ac7bcd9 | 2023-10-03 15:05:36 +0200 | [diff] [blame] | 2592 | mFrameTimeline->setSfWakeUp(sfToken2, 52, RR_11, RR_11); |
Ady Abraham | fcb1686 | 2022-10-10 14:35:21 -0700 | [diff] [blame] | 2593 | mFrameTimeline->setSfPresent(60, erroneousPresentFence2); |
| 2594 | |
Pascal Muetschard | ac7bcd9 | 2023-10-03 15:05:36 +0200 | [diff] [blame] | 2595 | mFrameTimeline->setSfWakeUp(sfToken3, 72, RR_11, RR_11); |
Ady Abraham | fcb1686 | 2022-10-10 14:35:21 -0700 | [diff] [blame] | 2596 | mFrameTimeline->setSfPresent(80, validPresentFence); |
| 2597 | |
Ady Abraham | b1e10d1 | 2023-03-13 15:23:54 -0700 | [diff] [blame] | 2598 | erroneousPresentFence2->signalForTest(2); |
Ady Abraham | fcb1686 | 2022-10-10 14:35:21 -0700 | [diff] [blame] | 2599 | validPresentFence->signalForTest(80); |
| 2600 | |
| 2601 | addEmptyDisplayFrame(); |
| 2602 | |
| 2603 | { |
| 2604 | auto displayFrame = getDisplayFrame(0); |
| 2605 | EXPECT_EQ(displayFrame->getActuals().presentTime, 26); |
| 2606 | EXPECT_EQ(displayFrame->getFramePresentMetadata(), FramePresentMetadata::UnknownPresent); |
| 2607 | EXPECT_EQ(displayFrame->getFrameReadyMetadata(), FrameReadyMetadata::UnknownFinish); |
Ady Abraham | b1e10d1 | 2023-03-13 15:23:54 -0700 | [diff] [blame] | 2608 | EXPECT_EQ(displayFrame->getJankType(), JankType::Unknown | JankType::DisplayHAL); |
Ying Wei | 96eb535 | 2023-11-21 17:37:21 +0000 | [diff] [blame] | 2609 | EXPECT_EQ(displayFrame->getJankSeverityType(), JankSeverityType::Unknown); |
Ady Abraham | fcb1686 | 2022-10-10 14:35:21 -0700 | [diff] [blame] | 2610 | } |
| 2611 | { |
| 2612 | auto displayFrame = getDisplayFrame(1); |
| 2613 | EXPECT_EQ(displayFrame->getActuals().presentTime, 60); |
| 2614 | EXPECT_EQ(displayFrame->getFramePresentMetadata(), FramePresentMetadata::UnknownPresent); |
| 2615 | EXPECT_EQ(displayFrame->getFrameReadyMetadata(), FrameReadyMetadata::UnknownFinish); |
Ady Abraham | b1e10d1 | 2023-03-13 15:23:54 -0700 | [diff] [blame] | 2616 | EXPECT_EQ(displayFrame->getJankType(), JankType::Unknown | JankType::DisplayHAL); |
Ying Wei | 96eb535 | 2023-11-21 17:37:21 +0000 | [diff] [blame] | 2617 | EXPECT_EQ(displayFrame->getJankSeverityType(), JankSeverityType::Unknown); |
Ady Abraham | fcb1686 | 2022-10-10 14:35:21 -0700 | [diff] [blame] | 2618 | } |
| 2619 | { |
| 2620 | auto displayFrame = getDisplayFrame(2); |
| 2621 | EXPECT_EQ(displayFrame->getActuals().presentTime, 80); |
| 2622 | EXPECT_EQ(displayFrame->getFramePresentMetadata(), FramePresentMetadata::OnTimePresent); |
| 2623 | EXPECT_EQ(displayFrame->getFrameReadyMetadata(), FrameReadyMetadata::OnTimeFinish); |
| 2624 | EXPECT_EQ(displayFrame->getJankType(), JankType::None); |
Ying Wei | 96eb535 | 2023-11-21 17:37:21 +0000 | [diff] [blame] | 2625 | EXPECT_EQ(displayFrame->getJankSeverityType(), JankSeverityType::None); |
Ady Abraham | fcb1686 | 2022-10-10 14:35:21 -0700 | [diff] [blame] | 2626 | } |
| 2627 | } |
| 2628 | |
Alec Mouri | adebf5c | 2021-01-05 12:57:36 -0800 | [diff] [blame] | 2629 | TEST_F(FrameTimelineTest, computeFps_noLayerIds_returnsZero) { |
| 2630 | EXPECT_EQ(mFrameTimeline->computeFps({}), 0.0f); |
| 2631 | } |
| 2632 | |
| 2633 | TEST_F(FrameTimelineTest, computeFps_singleDisplayFrame_returnsZero) { |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 2634 | const auto oneHundredMs = std::chrono::nanoseconds(100ms).count(); |
Alec Mouri | adebf5c | 2021-01-05 12:57:36 -0800 | [diff] [blame] | 2635 | |
| 2636 | auto surfaceFrame1 = |
| 2637 | mFrameTimeline->createSurfaceFrameForToken(FrameTimelineInfo(), sPidOne, sUidOne, |
Adithya Srinivasan | 785addd | 2021-03-09 00:38:00 +0000 | [diff] [blame] | 2638 | sLayerIdOne, sLayerNameOne, sLayerNameOne, |
Adithya Srinivasan | 58069dc | 2021-06-04 20:37:02 +0000 | [diff] [blame] | 2639 | /*isBuffer*/ true, sGameMode); |
Alec Mouri | adebf5c | 2021-01-05 12:57:36 -0800 | [diff] [blame] | 2640 | auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
| 2641 | surfaceFrame1->setPresentState(SurfaceFrame::PresentState::Presented); |
| 2642 | mFrameTimeline->addSurfaceFrame(surfaceFrame1); |
| 2643 | presentFence1->signalForTest(oneHundredMs); |
| 2644 | mFrameTimeline->setSfPresent(oneHundredMs, presentFence1); |
| 2645 | |
| 2646 | EXPECT_EQ(mFrameTimeline->computeFps({sLayerIdOne}), 0.0f); |
| 2647 | } |
| 2648 | |
| 2649 | TEST_F(FrameTimelineTest, computeFps_twoDisplayFrames_oneLayer) { |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 2650 | const auto oneHundredMs = std::chrono::nanoseconds(100ms).count(); |
| 2651 | const auto twoHundredMs = std::chrono::nanoseconds(200ms).count(); |
Alec Mouri | adebf5c | 2021-01-05 12:57:36 -0800 | [diff] [blame] | 2652 | auto surfaceFrame1 = |
| 2653 | mFrameTimeline->createSurfaceFrameForToken(FrameTimelineInfo(), sPidOne, sUidOne, |
Adithya Srinivasan | 785addd | 2021-03-09 00:38:00 +0000 | [diff] [blame] | 2654 | sLayerIdOne, sLayerNameOne, sLayerNameOne, |
Adithya Srinivasan | 58069dc | 2021-06-04 20:37:02 +0000 | [diff] [blame] | 2655 | /*isBuffer*/ true, sGameMode); |
Alec Mouri | adebf5c | 2021-01-05 12:57:36 -0800 | [diff] [blame] | 2656 | auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
| 2657 | surfaceFrame1->setPresentState(SurfaceFrame::PresentState::Presented); |
| 2658 | mFrameTimeline->addSurfaceFrame(surfaceFrame1); |
| 2659 | presentFence1->signalForTest(oneHundredMs); |
| 2660 | mFrameTimeline->setSfPresent(oneHundredMs, presentFence1); |
| 2661 | |
| 2662 | auto surfaceFrame2 = |
| 2663 | mFrameTimeline->createSurfaceFrameForToken(FrameTimelineInfo(), sPidOne, sUidOne, |
Adithya Srinivasan | 785addd | 2021-03-09 00:38:00 +0000 | [diff] [blame] | 2664 | sLayerIdOne, sLayerNameOne, sLayerNameOne, |
Adithya Srinivasan | 58069dc | 2021-06-04 20:37:02 +0000 | [diff] [blame] | 2665 | /*isBuffer*/ true, sGameMode); |
Alec Mouri | adebf5c | 2021-01-05 12:57:36 -0800 | [diff] [blame] | 2666 | auto presentFence2 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
| 2667 | surfaceFrame2->setPresentState(SurfaceFrame::PresentState::Presented); |
| 2668 | mFrameTimeline->addSurfaceFrame(surfaceFrame2); |
| 2669 | presentFence2->signalForTest(twoHundredMs); |
| 2670 | mFrameTimeline->setSfPresent(twoHundredMs, presentFence2); |
| 2671 | |
| 2672 | EXPECT_EQ(mFrameTimeline->computeFps({sLayerIdOne}), 10.0); |
| 2673 | } |
| 2674 | |
| 2675 | TEST_F(FrameTimelineTest, computeFps_twoDisplayFrames_twoLayers) { |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 2676 | const auto oneHundredMs = std::chrono::nanoseconds(100ms).count(); |
| 2677 | const auto twoHundredMs = std::chrono::nanoseconds(200ms).count(); |
Alec Mouri | adebf5c | 2021-01-05 12:57:36 -0800 | [diff] [blame] | 2678 | auto surfaceFrame1 = |
| 2679 | mFrameTimeline->createSurfaceFrameForToken(FrameTimelineInfo(), sPidOne, sUidOne, |
Adithya Srinivasan | 785addd | 2021-03-09 00:38:00 +0000 | [diff] [blame] | 2680 | sLayerIdOne, sLayerNameOne, sLayerNameOne, |
Adithya Srinivasan | 58069dc | 2021-06-04 20:37:02 +0000 | [diff] [blame] | 2681 | /*isBuffer*/ true, sGameMode); |
Alec Mouri | adebf5c | 2021-01-05 12:57:36 -0800 | [diff] [blame] | 2682 | auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
| 2683 | surfaceFrame1->setPresentState(SurfaceFrame::PresentState::Presented); |
| 2684 | mFrameTimeline->addSurfaceFrame(surfaceFrame1); |
| 2685 | presentFence1->signalForTest(oneHundredMs); |
| 2686 | mFrameTimeline->setSfPresent(oneHundredMs, presentFence1); |
| 2687 | |
| 2688 | auto surfaceFrame2 = |
| 2689 | mFrameTimeline->createSurfaceFrameForToken(FrameTimelineInfo(), sPidOne, sUidOne, |
Adithya Srinivasan | 785addd | 2021-03-09 00:38:00 +0000 | [diff] [blame] | 2690 | sLayerIdTwo, sLayerNameTwo, sLayerNameTwo, |
Adithya Srinivasan | 58069dc | 2021-06-04 20:37:02 +0000 | [diff] [blame] | 2691 | /*isBuffer*/ true, sGameMode); |
Alec Mouri | adebf5c | 2021-01-05 12:57:36 -0800 | [diff] [blame] | 2692 | auto presentFence2 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
| 2693 | surfaceFrame2->setPresentState(SurfaceFrame::PresentState::Presented); |
| 2694 | mFrameTimeline->addSurfaceFrame(surfaceFrame2); |
| 2695 | presentFence2->signalForTest(twoHundredMs); |
| 2696 | mFrameTimeline->setSfPresent(twoHundredMs, presentFence2); |
| 2697 | |
| 2698 | EXPECT_EQ(mFrameTimeline->computeFps({sLayerIdOne, sLayerIdTwo}), 10.0f); |
| 2699 | } |
| 2700 | |
| 2701 | TEST_F(FrameTimelineTest, computeFps_filtersOutLayers) { |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 2702 | const auto oneHundredMs = std::chrono::nanoseconds(100ms).count(); |
| 2703 | const auto twoHundredMs = std::chrono::nanoseconds(200ms).count(); |
Alec Mouri | adebf5c | 2021-01-05 12:57:36 -0800 | [diff] [blame] | 2704 | auto surfaceFrame1 = |
| 2705 | mFrameTimeline->createSurfaceFrameForToken(FrameTimelineInfo(), sPidOne, sUidOne, |
Adithya Srinivasan | 785addd | 2021-03-09 00:38:00 +0000 | [diff] [blame] | 2706 | sLayerIdOne, sLayerNameOne, sLayerNameOne, |
Adithya Srinivasan | 58069dc | 2021-06-04 20:37:02 +0000 | [diff] [blame] | 2707 | /*isBuffer*/ true, sGameMode); |
Alec Mouri | adebf5c | 2021-01-05 12:57:36 -0800 | [diff] [blame] | 2708 | auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
| 2709 | surfaceFrame1->setPresentState(SurfaceFrame::PresentState::Presented); |
| 2710 | mFrameTimeline->addSurfaceFrame(surfaceFrame1); |
| 2711 | presentFence1->signalForTest(oneHundredMs); |
| 2712 | mFrameTimeline->setSfPresent(oneHundredMs, presentFence1); |
| 2713 | |
| 2714 | auto surfaceFrame2 = |
| 2715 | mFrameTimeline->createSurfaceFrameForToken(FrameTimelineInfo(), sPidOne, sUidOne, |
Adithya Srinivasan | 785addd | 2021-03-09 00:38:00 +0000 | [diff] [blame] | 2716 | sLayerIdTwo, sLayerNameTwo, sLayerNameTwo, |
Adithya Srinivasan | 58069dc | 2021-06-04 20:37:02 +0000 | [diff] [blame] | 2717 | /*isBuffer*/ true, sGameMode); |
Alec Mouri | adebf5c | 2021-01-05 12:57:36 -0800 | [diff] [blame] | 2718 | auto presentFence2 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
| 2719 | surfaceFrame2->setPresentState(SurfaceFrame::PresentState::Presented); |
| 2720 | mFrameTimeline->addSurfaceFrame(surfaceFrame2); |
| 2721 | presentFence2->signalForTest(twoHundredMs); |
| 2722 | mFrameTimeline->setSfPresent(twoHundredMs, presentFence2); |
| 2723 | |
| 2724 | EXPECT_EQ(mFrameTimeline->computeFps({sLayerIdOne}), 0.0f); |
| 2725 | } |
| 2726 | |
| 2727 | TEST_F(FrameTimelineTest, computeFps_averagesOverMultipleFrames) { |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 2728 | const auto oneHundredMs = std::chrono::nanoseconds(100ms).count(); |
| 2729 | const auto twoHundredMs = std::chrono::nanoseconds(200ms).count(); |
| 2730 | const auto threeHundredMs = std::chrono::nanoseconds(300ms).count(); |
| 2731 | const auto fiveHundredMs = std::chrono::nanoseconds(500ms).count(); |
| 2732 | const auto sixHundredMs = std::chrono::nanoseconds(600ms).count(); |
Alec Mouri | adebf5c | 2021-01-05 12:57:36 -0800 | [diff] [blame] | 2733 | auto surfaceFrame1 = |
| 2734 | mFrameTimeline->createSurfaceFrameForToken(FrameTimelineInfo(), sPidOne, sUidOne, |
Adithya Srinivasan | 785addd | 2021-03-09 00:38:00 +0000 | [diff] [blame] | 2735 | sLayerIdOne, sLayerNameOne, sLayerNameOne, |
Adithya Srinivasan | 58069dc | 2021-06-04 20:37:02 +0000 | [diff] [blame] | 2736 | /*isBuffer*/ true, sGameMode); |
Alec Mouri | adebf5c | 2021-01-05 12:57:36 -0800 | [diff] [blame] | 2737 | auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
| 2738 | surfaceFrame1->setPresentState(SurfaceFrame::PresentState::Presented); |
| 2739 | mFrameTimeline->addSurfaceFrame(surfaceFrame1); |
| 2740 | presentFence1->signalForTest(oneHundredMs); |
| 2741 | mFrameTimeline->setSfPresent(oneHundredMs, presentFence1); |
| 2742 | |
| 2743 | auto surfaceFrame2 = |
| 2744 | mFrameTimeline->createSurfaceFrameForToken(FrameTimelineInfo(), sPidOne, sUidOne, |
Adithya Srinivasan | 785addd | 2021-03-09 00:38:00 +0000 | [diff] [blame] | 2745 | sLayerIdOne, sLayerNameOne, sLayerNameOne, |
Adithya Srinivasan | 58069dc | 2021-06-04 20:37:02 +0000 | [diff] [blame] | 2746 | /*isBuffer*/ true, sGameMode); |
Alec Mouri | adebf5c | 2021-01-05 12:57:36 -0800 | [diff] [blame] | 2747 | auto presentFence2 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
| 2748 | surfaceFrame2->setPresentState(SurfaceFrame::PresentState::Presented); |
| 2749 | mFrameTimeline->addSurfaceFrame(surfaceFrame2); |
| 2750 | presentFence2->signalForTest(twoHundredMs); |
| 2751 | mFrameTimeline->setSfPresent(twoHundredMs, presentFence2); |
| 2752 | |
| 2753 | auto surfaceFrame3 = |
| 2754 | mFrameTimeline->createSurfaceFrameForToken(FrameTimelineInfo(), sPidOne, sUidOne, |
Adithya Srinivasan | 785addd | 2021-03-09 00:38:00 +0000 | [diff] [blame] | 2755 | sLayerIdTwo, sLayerNameTwo, sLayerNameTwo, |
Adithya Srinivasan | 58069dc | 2021-06-04 20:37:02 +0000 | [diff] [blame] | 2756 | /*isBuffer*/ true, sGameMode); |
Alec Mouri | adebf5c | 2021-01-05 12:57:36 -0800 | [diff] [blame] | 2757 | auto presentFence3 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
| 2758 | surfaceFrame3->setPresentState(SurfaceFrame::PresentState::Presented); |
| 2759 | mFrameTimeline->addSurfaceFrame(surfaceFrame3); |
| 2760 | presentFence3->signalForTest(threeHundredMs); |
| 2761 | mFrameTimeline->setSfPresent(threeHundredMs, presentFence3); |
| 2762 | |
| 2763 | auto surfaceFrame4 = |
| 2764 | mFrameTimeline->createSurfaceFrameForToken(FrameTimelineInfo(), sPidOne, sUidOne, |
Adithya Srinivasan | 785addd | 2021-03-09 00:38:00 +0000 | [diff] [blame] | 2765 | sLayerIdOne, sLayerNameOne, sLayerNameOne, |
Adithya Srinivasan | 58069dc | 2021-06-04 20:37:02 +0000 | [diff] [blame] | 2766 | /*isBuffer*/ true, sGameMode); |
Alec Mouri | adebf5c | 2021-01-05 12:57:36 -0800 | [diff] [blame] | 2767 | auto presentFence4 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
| 2768 | surfaceFrame4->setPresentState(SurfaceFrame::PresentState::Presented); |
| 2769 | mFrameTimeline->addSurfaceFrame(surfaceFrame4); |
| 2770 | presentFence4->signalForTest(fiveHundredMs); |
| 2771 | mFrameTimeline->setSfPresent(fiveHundredMs, presentFence4); |
| 2772 | |
| 2773 | auto surfaceFrame5 = |
| 2774 | mFrameTimeline->createSurfaceFrameForToken(FrameTimelineInfo(), sPidOne, sUidOne, |
Adithya Srinivasan | 785addd | 2021-03-09 00:38:00 +0000 | [diff] [blame] | 2775 | sLayerIdOne, sLayerNameOne, sLayerNameOne, |
Adithya Srinivasan | 58069dc | 2021-06-04 20:37:02 +0000 | [diff] [blame] | 2776 | /*isBuffer*/ true, sGameMode); |
Alec Mouri | adebf5c | 2021-01-05 12:57:36 -0800 | [diff] [blame] | 2777 | auto presentFence5 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
| 2778 | // Dropped frames will be excluded from fps computation |
| 2779 | surfaceFrame5->setPresentState(SurfaceFrame::PresentState::Dropped); |
| 2780 | mFrameTimeline->addSurfaceFrame(surfaceFrame5); |
| 2781 | presentFence5->signalForTest(sixHundredMs); |
| 2782 | mFrameTimeline->setSfPresent(sixHundredMs, presentFence5); |
| 2783 | |
| 2784 | EXPECT_EQ(mFrameTimeline->computeFps({sLayerIdOne}), 5.0f); |
| 2785 | } |
| 2786 | |
ramindani | ea2bb82 | 2022-06-27 19:52:10 +0000 | [diff] [blame] | 2787 | TEST_F(FrameTimelineTest, getMinTime) { |
| 2788 | // Use SurfaceFrame::getBaseTime to test the getMinTime. |
| 2789 | FrameTimelineInfo ftInfo; |
| 2790 | |
| 2791 | // Valid prediction state test. |
| 2792 | ftInfo.vsyncId = 0L; |
| 2793 | mTokenManager->generateTokenForPredictions({10}); |
| 2794 | auto surfaceFrame = |
| 2795 | mFrameTimeline->createSurfaceFrameForToken(ftInfo, sPidOne, sUidOne, sLayerIdOne, |
| 2796 | sLayerNameOne, sLayerNameOne, |
| 2797 | /*isBuffer*/ true, sGameMode); |
| 2798 | ASSERT_EQ(surfaceFrame->getBaseTime(), 10); |
| 2799 | |
| 2800 | // Test prediction state which is not valid. |
| 2801 | ftInfo.vsyncId = FrameTimelineInfo::INVALID_VSYNC_ID; |
| 2802 | surfaceFrame = mFrameTimeline->createSurfaceFrameForToken(ftInfo, sPidOne, sUidOne, sLayerIdOne, |
| 2803 | sLayerNameOne, sLayerNameOne, |
| 2804 | /*isBuffer*/ true, sGameMode); |
| 2805 | // Start time test. |
| 2806 | surfaceFrame->setActualStartTime(200); |
| 2807 | ASSERT_EQ(surfaceFrame->getBaseTime(), 200); |
| 2808 | |
| 2809 | // End time test. |
| 2810 | surfaceFrame->setAcquireFenceTime(100); |
| 2811 | ASSERT_EQ(surfaceFrame->getBaseTime(), 100); |
| 2812 | |
| 2813 | // Present time test. |
| 2814 | auto presentFence = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
| 2815 | surfaceFrame->setPresentState(SurfaceFrame::PresentState::Presented); |
| 2816 | mFrameTimeline->addSurfaceFrame(surfaceFrame); |
| 2817 | presentFence->signalForTest(std::chrono::nanoseconds(50ns).count()); |
| 2818 | mFrameTimeline->setSfPresent(50, presentFence); |
| 2819 | ASSERT_EQ(surfaceFrame->getBaseTime(), 50); |
| 2820 | } |
Pascal Muetschard | ac7bcd9 | 2023-10-03 15:05:36 +0200 | [diff] [blame] | 2821 | |
| 2822 | TEST_F(FrameTimelineTest, surfaceFrameRenderRateUsingDisplayRate) { |
| 2823 | auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
| 2824 | int64_t token1 = mTokenManager->generateTokenForPredictions({10, 20, 30}); |
| 2825 | FrameTimelineInfo ftInfo; |
| 2826 | ftInfo.vsyncId = token1; |
| 2827 | ftInfo.inputEventId = sInputEventId; |
| 2828 | auto surfaceFrame = |
| 2829 | mFrameTimeline->createSurfaceFrameForToken(ftInfo, sPidOne, sUidOne, sLayerIdOne, |
| 2830 | sLayerNameOne, sLayerNameOne, |
| 2831 | /*isBuffer*/ true, sGameMode); |
| 2832 | |
| 2833 | mFrameTimeline->setSfWakeUp(token1, 20, RR_30, RR_11); |
| 2834 | surfaceFrame->setPresentState(SurfaceFrame::PresentState::Presented); |
| 2835 | mFrameTimeline->addSurfaceFrame(surfaceFrame); |
| 2836 | presentFence1->signalForTest(std::chrono::nanoseconds(50ns).count()); |
| 2837 | mFrameTimeline->setSfPresent(50, presentFence1); |
| 2838 | |
| 2839 | EXPECT_EQ(surfaceFrame->getRenderRate().getPeriodNsecs(), 11); |
| 2840 | } |
| 2841 | |
| 2842 | TEST_F(FrameTimelineTest, surfaceFrameRenderRateUsingAppFrameRate) { |
| 2843 | auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
| 2844 | int64_t token1 = mTokenManager->generateTokenForPredictions({10, 20, 30}); |
| 2845 | FrameTimelineInfo ftInfo; |
| 2846 | ftInfo.vsyncId = token1; |
| 2847 | ftInfo.inputEventId = sInputEventId; |
| 2848 | auto surfaceFrame = |
| 2849 | mFrameTimeline->createSurfaceFrameForToken(ftInfo, sPidOne, sUidOne, sLayerIdOne, |
| 2850 | sLayerNameOne, sLayerNameOne, |
| 2851 | /*isBuffer*/ true, sGameMode); |
| 2852 | surfaceFrame->setRenderRate(RR_30); |
| 2853 | mFrameTimeline->setSfWakeUp(token1, 20, RR_11, RR_11); |
| 2854 | surfaceFrame->setPresentState(SurfaceFrame::PresentState::Presented); |
| 2855 | mFrameTimeline->addSurfaceFrame(surfaceFrame); |
| 2856 | presentFence1->signalForTest(std::chrono::nanoseconds(50ns).count()); |
| 2857 | mFrameTimeline->setSfPresent(50, presentFence1); |
| 2858 | |
| 2859 | EXPECT_EQ(surfaceFrame->getRenderRate().getPeriodNsecs(), 30); |
| 2860 | } |
Adithya Srinivasan | f279e04 | 2020-08-17 14:56:27 -0700 | [diff] [blame] | 2861 | } // namespace android::frametimeline |