blob: 4dfd1d03eaa4afab8ed9304d9e44ebbab41e7a68 [file] [log] [blame]
Jeff Sharkey6c2c0562016-12-07 12:12:00 -07001/*
2 * Copyright (C) 2016 The Android Open Source Project
3 *
4 * Licensed under the Apache License, Version 2.0 (the "License");
5 * you may not use this file except in compliance with the License.
6 * You may obtain a copy of the License at
7 *
8 * http://www.apache.org/licenses/LICENSE-2.0
9 *
10 * Unless required by applicable law or agreed to in writing, software
11 * distributed under the License is distributed on an "AS IS" BASIS,
12 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
13 * See the License for the specific language governing permissions and
14 * limitations under the License.
15 */
Alan Stokescb27c342018-04-20 17:09:25 +010016#define LOG_TAG "installd"
Jeff Sharkey6c2c0562016-12-07 12:12:00 -070017
Alan Stokesa25d90c2017-10-16 10:56:00 +010018#include <array>
Jeff Sharkey90aff262016-12-12 14:28:24 -070019#include <fcntl.h>
Jeff Sharkey6c2c0562016-12-07 12:12:00 -070020#include <stdlib.h>
21#include <string.h>
Jeff Sharkey90aff262016-12-12 14:28:24 -070022#include <sys/capability.h>
23#include <sys/file.h>
Jeff Sharkey6c2c0562016-12-07 12:12:00 -070024#include <sys/stat.h>
Jeff Sharkey90aff262016-12-12 14:28:24 -070025#include <sys/time.h>
26#include <sys/types.h>
27#include <sys/resource.h>
28#include <sys/wait.h>
Jeff Sharkey6c2c0562016-12-07 12:12:00 -070029#include <unistd.h>
30
Andreas Gampe023b2242018-02-28 16:03:25 -080031#include <iomanip>
32
Alan Stokesa25d90c2017-10-16 10:56:00 +010033#include <android-base/file.h>
Jeff Sharkey6c2c0562016-12-07 12:12:00 -070034#include <android-base/logging.h>
Andreas Gampe6a9cf722017-07-24 16:49:10 -070035#include <android-base/properties.h>
Jeff Sharkey6c2c0562016-12-07 12:12:00 -070036#include <android-base/stringprintf.h>
Jeff Sharkey90aff262016-12-12 14:28:24 -070037#include <android-base/strings.h>
38#include <android-base/unique_fd.h>
Calin Juravle80a21252017-01-17 14:43:25 -080039#include <cutils/fs.h>
Jeff Sharkey90aff262016-12-12 14:28:24 -070040#include <cutils/properties.h>
41#include <cutils/sched_policy.h>
Mark Salyzyn7823e122016-09-29 08:08:05 -070042#include <log/log.h> // TODO: Move everything to base/logging.
Alan Stokesa25d90c2017-10-16 10:56:00 +010043#include <openssl/sha.h>
Jeff Sharkey90aff262016-12-12 14:28:24 -070044#include <private/android_filesystem_config.h>
Suren Baghdasaryan1cc5de62019-01-25 05:29:23 +000045#include <processgroup/sched_policy.h>
Calin Juravlecb556e32017-04-04 20:22:50 -070046#include <selinux/android.h>
Nicolas Geoffrayaaad21e2019-02-25 13:31:10 +000047#include <server_configurable_flags/get_flags.h>
Jeff Sharkey90aff262016-12-12 14:28:24 -070048#include <system/thread_defs.h>
Jeff Sharkey6c2c0562016-12-07 12:12:00 -070049
50#include "dexopt.h"
Andreas Gampefa2dadd2018-02-28 19:52:47 -080051#include "dexopt_return_codes.h"
Victor Hsiehc9821f12020-08-07 11:32:29 -070052#include "execv_helper.h"
Jeff Sharkeyc1149c92017-09-21 14:51:09 -060053#include "globals.h"
Jeff Sharkey90aff262016-12-12 14:28:24 -070054#include "installd_deps.h"
55#include "otapreopt_utils.h"
Victor Hsiehc9821f12020-08-07 11:32:29 -070056#include "run_dex2oat.h"
Victor Hsiehcb35a062020-08-13 16:11:13 -070057#include "unique_file.h"
Jeff Sharkey6c2c0562016-12-07 12:12:00 -070058#include "utils.h"
59
Victor Hsieh76f19ba2020-08-10 14:37:26 -070060using android::base::Basename;
Jeff Sharkey90aff262016-12-12 14:28:24 -070061using android::base::EndsWith;
Mathieu Chartier9b2da082018-10-26 13:23:11 -070062using android::base::GetBoolProperty;
63using android::base::GetProperty;
David Brazdil4f6027a2019-03-19 11:44:21 +000064using android::base::ReadFdToString;
Alan Stokesa25d90c2017-10-16 10:56:00 +010065using android::base::ReadFully;
66using android::base::StringPrintf;
67using android::base::WriteFully;
Calin Juravle1a0af3b2017-03-09 14:33:33 -080068using android::base::unique_fd;
Jeff Sharkey6c2c0562016-12-07 12:12:00 -070069
70namespace android {
71namespace installd {
72
Andreas Gampefa2dadd2018-02-28 19:52:47 -080073
Calin Juravle114f0812017-03-08 19:05:07 -080074// Deleter using free() for use with std::unique_ptr<>. See also UniqueCPtr<> below.
75struct FreeDelete {
76 // NOTE: Deleting a const object is valid but free() takes a non-const pointer.
77 void operator()(const void* ptr) const {
78 free(const_cast<void*>(ptr));
79 }
80};
81
82// Alias for std::unique_ptr<> that uses the C function free() to delete objects.
83template <typename T>
84using UniqueCPtr = std::unique_ptr<T, FreeDelete>;
85
Calin Juravle1a0af3b2017-03-09 14:33:33 -080086static unique_fd invalid_unique_fd() {
87 return unique_fd(-1);
88}
89
Andreas Gampe6a9cf722017-07-24 16:49:10 -070090static bool is_debug_runtime() {
91 return android::base::GetProperty("persist.sys.dalvik.vm.lib.2", "") == "libartd.so";
92}
93
David Sehra3b5ab62017-10-25 14:27:29 -070094static bool is_debuggable_build() {
95 return android::base::GetBoolProperty("ro.debuggable", false);
96}
97
Jeff Sharkey90aff262016-12-12 14:28:24 -070098static bool clear_profile(const std::string& profile) {
Calin Juravle1a0af3b2017-03-09 14:33:33 -080099 unique_fd ufd(open(profile.c_str(), O_WRONLY | O_NOFOLLOW | O_CLOEXEC));
Jeff Sharkey90aff262016-12-12 14:28:24 -0700100 if (ufd.get() < 0) {
101 if (errno != ENOENT) {
102 PLOG(WARNING) << "Could not open profile " << profile;
103 return false;
104 } else {
105 // Nothing to clear. That's ok.
106 return true;
107 }
108 }
109
110 if (flock(ufd.get(), LOCK_EX | LOCK_NB) != 0) {
111 if (errno != EWOULDBLOCK) {
112 PLOG(WARNING) << "Error locking profile " << profile;
113 }
114 // This implies that the app owning this profile is running
115 // (and has acquired the lock).
116 //
117 // If we can't acquire the lock bail out since clearing is useless anyway
118 // (the app will write again to the profile).
119 //
120 // Note:
121 // This does not impact the this is not an issue for the profiling correctness.
122 // In case this is needed because of an app upgrade, profiles will still be
123 // eventually cleared by the app itself due to checksum mismatch.
124 // If this is needed because profman advised, then keeping the data around
125 // until the next run is again not an issue.
126 //
127 // If the app attempts to acquire a lock while we've held one here,
128 // it will simply skip the current write cycle.
129 return false;
130 }
131
132 bool truncated = ftruncate(ufd.get(), 0) == 0;
133 if (!truncated) {
134 PLOG(WARNING) << "Could not truncate " << profile;
135 }
136 if (flock(ufd.get(), LOCK_UN) != 0) {
137 PLOG(WARNING) << "Error unlocking profile " << profile;
138 }
139 return truncated;
140}
141
Calin Juravle114f0812017-03-08 19:05:07 -0800142// Clear the reference profile for the given location.
Calin Juravle824a64d2018-01-18 20:23:17 -0800143// The location is the profile name for primary apks or the dex path for secondary dex files.
144static bool clear_reference_profile(const std::string& package_name, const std::string& location,
145 bool is_secondary_dex) {
146 return clear_profile(create_reference_profile_path(package_name, location, is_secondary_dex));
Jeff Sharkey90aff262016-12-12 14:28:24 -0700147}
148
Calin Juravle114f0812017-03-08 19:05:07 -0800149// Clear the reference profile for the given location.
Calin Juravle824a64d2018-01-18 20:23:17 -0800150// The location is the profile name for primary apks or the dex path for secondary dex files.
151static bool clear_current_profile(const std::string& package_name, const std::string& location,
152 userid_t user, bool is_secondary_dex) {
153 return clear_profile(create_current_profile_path(user, package_name, location,
154 is_secondary_dex));
Jeff Sharkey90aff262016-12-12 14:28:24 -0700155}
156
Calin Juravle114f0812017-03-08 19:05:07 -0800157// Clear the reference profile for the primary apk of the given package.
Calin Juravle824a64d2018-01-18 20:23:17 -0800158// The location is the profile name for primary apks or the dex path for secondary dex files.
159bool clear_primary_reference_profile(const std::string& package_name,
160 const std::string& location) {
161 return clear_reference_profile(package_name, location, /*is_secondary_dex*/false);
Calin Juravle114f0812017-03-08 19:05:07 -0800162}
163
164// Clear all current profile for the primary apk of the given package.
Calin Juravle824a64d2018-01-18 20:23:17 -0800165// The location is the profile name for primary apks or the dex path for secondary dex files.
166bool clear_primary_current_profiles(const std::string& package_name, const std::string& location) {
Jeff Sharkey90aff262016-12-12 14:28:24 -0700167 bool success = true;
Calin Juravle114f0812017-03-08 19:05:07 -0800168 // For secondary dex files, we don't really need the user but we use it for sanity checks.
Jeff Sharkey90aff262016-12-12 14:28:24 -0700169 std::vector<userid_t> users = get_known_users(/*volume_uuid*/ nullptr);
170 for (auto user : users) {
Calin Juravle824a64d2018-01-18 20:23:17 -0800171 success &= clear_current_profile(package_name, location, user, /*is_secondary_dex*/false);
Jeff Sharkey90aff262016-12-12 14:28:24 -0700172 }
173 return success;
174}
175
Calin Juravle114f0812017-03-08 19:05:07 -0800176// Clear the current profile for the primary apk of the given package and user.
Calin Juravle824a64d2018-01-18 20:23:17 -0800177bool clear_primary_current_profile(const std::string& package_name, const std::string& location,
178 userid_t user) {
179 return clear_current_profile(package_name, location, user, /*is_secondary_dex*/false);
Calin Juravle114f0812017-03-08 19:05:07 -0800180}
181
Calin Juravlef74a7372019-02-28 20:29:41 -0800182// Determines which binary we should use for execution (the debug or non-debug version).
183// e.g. dex2oatd vs dex2oat
184static const char* select_execution_binary(const char* binary, const char* debug_binary,
185 bool background_job_compile) {
186 return select_execution_binary(
187 binary,
188 debug_binary,
189 background_job_compile,
190 is_debug_runtime(),
191 (android::base::GetProperty("ro.build.version.codename", "") == "REL"),
192 is_debuggable_build());
193}
194
195// Determines which binary we should use for execution (the debug or non-debug version).
196// e.g. dex2oatd vs dex2oat
197// This is convenient method which is much easier to test because it doesn't read
198// system properties.
199const char* select_execution_binary(
200 const char* binary,
201 const char* debug_binary,
202 bool background_job_compile,
203 bool is_debug_runtime,
204 bool is_release,
205 bool is_debuggable_build) {
206 // Do not use debug binaries for release candidates (to give more soak time).
207 bool is_debug_bg_job = background_job_compile && is_debuggable_build && !is_release;
208
209 // If the runtime was requested to use libartd.so, we'll run the debug version - assuming
210 // the file is present (it may not be on images with very little space available).
211 bool useDebug = (is_debug_runtime || is_debug_bg_job) && (access(debug_binary, X_OK) == 0);
212
213 return useDebug ? debug_binary : binary;
214}
215
Nicolas Geoffrayaaad21e2019-02-25 13:31:10 +0000216// Namespace for Android Runtime flags applied during boot time.
217static const char* RUNTIME_NATIVE_BOOT_NAMESPACE = "runtime_native_boot";
218// Feature flag name for running the JIT in Zygote experiment, b/119800099.
Nicolas Geoffray5a4c4e92020-02-07 11:37:34 +0000219static const char* ENABLE_JITZYGOTE_IMAGE = "enable_apex_image";
Nicolas Geoffrayaaad21e2019-02-25 13:31:10 +0000220
Mathieu Chartiere97261e2019-10-01 15:36:01 -0700221// Phenotype property name for enabling profiling the boot class path.
222static const char* PROFILE_BOOT_CLASS_PATH = "profilebootclasspath";
223
Calin Juravlef85ddb92020-05-01 14:05:40 -0700224static bool IsBootClassPathProfilingEnable() {
225 std::string profile_boot_class_path = GetProperty("dalvik.vm.profilebootclasspath", "");
226 profile_boot_class_path =
227 server_configurable_flags::GetServerConfigurableFlag(
228 RUNTIME_NATIVE_BOOT_NAMESPACE,
229 PROFILE_BOOT_CLASS_PATH,
230 /*default_value=*/ profile_boot_class_path);
231 return profile_boot_class_path == "true";
232}
233
Victor Hsiehcb35a062020-08-13 16:11:13 -0700234static void UnlinkIgnoreResult(const std::string& path) {
235 if (unlink(path.c_str()) < 0) {
236 PLOG(ERROR) << "Failed to unlink " << path;
237 }
238}
239
Jeff Sharkey90aff262016-12-12 14:28:24 -0700240/*
241 * Whether dexopt should use a swap file when compiling an APK.
242 *
243 * If kAlwaysProvideSwapFile, do this on all devices (dex2oat will make a more informed decision
244 * itself, anyways).
245 *
246 * Otherwise, read "dalvik.vm.dex2oat-swap". If the property exists, return whether it is "true".
247 *
248 * Otherwise, return true if this is a low-mem device.
249 *
250 * Otherwise, return default value.
251 */
252static bool kAlwaysProvideSwapFile = false;
253static bool kDefaultProvideSwapFile = true;
254
255static bool ShouldUseSwapFileForDexopt() {
256 if (kAlwaysProvideSwapFile) {
257 return true;
258 }
259
260 // Check the "override" property. If it exists, return value == "true".
Mathieu Chartier9b2da082018-10-26 13:23:11 -0700261 std::string dex2oat_prop_buf = GetProperty("dalvik.vm.dex2oat-swap", "");
262 if (!dex2oat_prop_buf.empty()) {
263 return dex2oat_prop_buf == "true";
Jeff Sharkey90aff262016-12-12 14:28:24 -0700264 }
265
266 // Shortcut for default value. This is an implementation optimization for the process sketched
267 // above. If the default value is true, we can avoid to check whether this is a low-mem device,
268 // as low-mem is never returning false. The compiler will optimize this away if it can.
269 if (kDefaultProvideSwapFile) {
270 return true;
271 }
272
Mathieu Chartier9b2da082018-10-26 13:23:11 -0700273 if (GetBoolProperty("ro.config.low_ram", false)) {
Jeff Sharkey90aff262016-12-12 14:28:24 -0700274 return true;
275 }
276
277 // Default value must be false here.
278 return kDefaultProvideSwapFile;
279}
280
Richard Uhler76cc0272016-12-08 10:46:35 +0000281static void SetDex2OatScheduling(bool set_to_bg) {
Jeff Sharkey90aff262016-12-12 14:28:24 -0700282 if (set_to_bg) {
283 if (set_sched_policy(0, SP_BACKGROUND) < 0) {
Andreas Gampefa2dadd2018-02-28 19:52:47 -0800284 PLOG(ERROR) << "set_sched_policy failed";
285 exit(DexoptReturnCodes::kSetSchedPolicy);
Jeff Sharkey90aff262016-12-12 14:28:24 -0700286 }
287 if (setpriority(PRIO_PROCESS, 0, ANDROID_PRIORITY_BACKGROUND) < 0) {
Andreas Gampefa2dadd2018-02-28 19:52:47 -0800288 PLOG(ERROR) << "setpriority failed";
289 exit(DexoptReturnCodes::kSetPriority);
Jeff Sharkey90aff262016-12-12 14:28:24 -0700290 }
291 }
292}
293
Calin Juravle29591732017-11-20 17:46:19 -0800294static unique_fd create_profile(uid_t uid, const std::string& profile, int32_t flags) {
295 unique_fd fd(TEMP_FAILURE_RETRY(open(profile.c_str(), flags, 0600)));
Calin Juravle1a0af3b2017-03-09 14:33:33 -0800296 if (fd.get() < 0) {
Calin Juravle29591732017-11-20 17:46:19 -0800297 if (errno != EEXIST) {
Calin Juravle114f0812017-03-08 19:05:07 -0800298 PLOG(ERROR) << "Failed to create profile " << profile;
Calin Juravle29591732017-11-20 17:46:19 -0800299 return invalid_unique_fd();
Calin Juravle114f0812017-03-08 19:05:07 -0800300 }
Jeff Sharkey90aff262016-12-12 14:28:24 -0700301 }
Calin Juravle114f0812017-03-08 19:05:07 -0800302 // Profiles should belong to the app; make sure of that by giving ownership to
303 // the app uid. If we cannot do that, there's no point in returning the fd
304 // since dex2oat/profman will fail with SElinux denials.
305 if (fchown(fd.get(), uid, uid) < 0) {
Roland Levillain019db5b2019-03-14 14:31:59 +0000306 PLOG(ERROR) << "Could not chown profile " << profile;
Calin Juravle29591732017-11-20 17:46:19 -0800307 return invalid_unique_fd();
Calin Juravle114f0812017-03-08 19:05:07 -0800308 }
Calin Juravle29591732017-11-20 17:46:19 -0800309 return fd;
Calin Juravle114f0812017-03-08 19:05:07 -0800310}
311
Calin Juravle29591732017-11-20 17:46:19 -0800312static unique_fd open_profile(uid_t uid, const std::string& profile, int32_t flags) {
Calin Juravle114f0812017-03-08 19:05:07 -0800313 // Do not follow symlinks when opening a profile:
314 // - primary profiles should not contain symlinks in their paths
315 // - secondary dex paths should have been already resolved and validated
316 flags |= O_NOFOLLOW;
317
Calin Juravle29591732017-11-20 17:46:19 -0800318 // Check if we need to create the profile
319 // Reference profiles and snapshots are created on the fly; so they might not exist beforehand.
320 unique_fd fd;
321 if ((flags & O_CREAT) != 0) {
322 fd = create_profile(uid, profile, flags);
323 } else {
324 fd.reset(TEMP_FAILURE_RETRY(open(profile.c_str(), flags)));
325 }
326
Calin Juravle114f0812017-03-08 19:05:07 -0800327 if (fd.get() < 0) {
328 if (errno != ENOENT) {
329 // Profiles might be missing for various reasons. For example, in a
330 // multi-user environment, the profile directory for one user can be created
331 // after we start a merge. In this case the current profile for that user
332 // will not be found.
333 // Also, the secondary dex profiles might be deleted by the app at any time,
334 // so we can't we need to prepare if they are missing.
335 PLOG(ERROR) << "Failed to open profile " << profile;
336 }
337 return invalid_unique_fd();
338 }
339
Jeff Sharkey90aff262016-12-12 14:28:24 -0700340 return fd;
341}
342
Calin Juravle824a64d2018-01-18 20:23:17 -0800343static unique_fd open_current_profile(uid_t uid, userid_t user, const std::string& package_name,
344 const std::string& location, bool is_secondary_dex) {
345 std::string profile = create_current_profile_path(user, package_name, location,
346 is_secondary_dex);
Calin Juravle29591732017-11-20 17:46:19 -0800347 return open_profile(uid, profile, O_RDONLY);
Calin Juravle114f0812017-03-08 19:05:07 -0800348}
349
Calin Juravle824a64d2018-01-18 20:23:17 -0800350static unique_fd open_reference_profile(uid_t uid, const std::string& package_name,
351 const std::string& location, bool read_write, bool is_secondary_dex) {
352 std::string profile = create_reference_profile_path(package_name, location, is_secondary_dex);
Calin Juravle29591732017-11-20 17:46:19 -0800353 return open_profile(uid, profile, read_write ? (O_CREAT | O_RDWR) : O_RDONLY);
354}
355
Victor Hsiehcb35a062020-08-13 16:11:13 -0700356static UniqueFile open_reference_profile_as_unique_file(uid_t uid, const std::string& package_name,
357 const std::string& location, bool read_write, bool is_secondary_dex) {
358 std::string profile_path = create_reference_profile_path(package_name, location,
359 is_secondary_dex);
360 unique_fd ufd = open_profile(uid, profile_path, read_write ? (O_CREAT | O_RDWR) : O_RDONLY);
361 return UniqueFile(ufd.release(), profile_path, [](const std::string& path) {
362 clear_profile(path);
363 });
364}
365
Calin Juravle29591732017-11-20 17:46:19 -0800366static unique_fd open_spnashot_profile(uid_t uid, const std::string& package_name,
Calin Juravle824a64d2018-01-18 20:23:17 -0800367 const std::string& location) {
368 std::string profile = create_snapshot_profile_path(package_name, location);
Calin Juravle29591732017-11-20 17:46:19 -0800369 return open_profile(uid, profile, O_CREAT | O_RDWR | O_TRUNC);
Calin Juravle114f0812017-03-08 19:05:07 -0800370}
371
Calin Juravle824a64d2018-01-18 20:23:17 -0800372static void open_profile_files(uid_t uid, const std::string& package_name,
373 const std::string& location, bool is_secondary_dex,
Calin Juravle1a0af3b2017-03-09 14:33:33 -0800374 /*out*/ std::vector<unique_fd>* profiles_fd, /*out*/ unique_fd* reference_profile_fd) {
Jeff Sharkey90aff262016-12-12 14:28:24 -0700375 // Open the reference profile in read-write mode as profman might need to save the merge.
Calin Juravle824a64d2018-01-18 20:23:17 -0800376 *reference_profile_fd = open_reference_profile(uid, package_name, location,
377 /*read_write*/ true, is_secondary_dex);
Jeff Sharkey90aff262016-12-12 14:28:24 -0700378
Calin Juravle114f0812017-03-08 19:05:07 -0800379 // For secondary dex files, we don't really need the user but we use it for sanity checks.
380 // Note: the user owning the dex file should be the current user.
381 std::vector<userid_t> users;
382 if (is_secondary_dex){
383 users.push_back(multiuser_get_user_id(uid));
384 } else {
385 users = get_known_users(/*volume_uuid*/ nullptr);
386 }
Jeff Sharkey90aff262016-12-12 14:28:24 -0700387 for (auto user : users) {
Calin Juravle824a64d2018-01-18 20:23:17 -0800388 unique_fd profile_fd = open_current_profile(uid, user, package_name, location,
389 is_secondary_dex);
Jeff Sharkey90aff262016-12-12 14:28:24 -0700390 // Add to the lists only if both fds are valid.
Calin Juravle1a0af3b2017-03-09 14:33:33 -0800391 if (profile_fd.get() >= 0) {
392 profiles_fd->push_back(std::move(profile_fd));
Jeff Sharkey90aff262016-12-12 14:28:24 -0700393 }
394 }
395}
396
Calin Juravle76561322019-11-14 09:08:52 -0800397static constexpr int PROFMAN_BIN_RETURN_CODE_SUCCESS = 0;
398static constexpr int PROFMAN_BIN_RETURN_CODE_COMPILE = 1;
399static constexpr int PROFMAN_BIN_RETURN_CODE_SKIP_COMPILATION = 2;
400static constexpr int PROFMAN_BIN_RETURN_CODE_BAD_PROFILES = 3;
401static constexpr int PROFMAN_BIN_RETURN_CODE_ERROR_IO = 4;
402static constexpr int PROFMAN_BIN_RETURN_CODE_ERROR_LOCKING = 5;
403static constexpr int PROFMAN_BIN_RETURN_CODE_ERROR_DIFFERENT_VERSIONS = 6;
Jeff Sharkey90aff262016-12-12 14:28:24 -0700404
Mathieu Chartiercc66c442018-11-09 15:57:21 -0800405class RunProfman : public ExecVHelper {
406 public:
407 void SetupArgs(const std::vector<unique_fd>& profile_fds,
408 const unique_fd& reference_profile_fd,
409 const std::vector<unique_fd>& apk_fds,
410 const std::vector<std::string>& dex_locations,
Calin Juravle78728f32019-11-08 17:55:46 -0800411 bool copy_and_update,
412 bool for_snapshot,
413 bool for_boot_image) {
Calin Juravlef74a7372019-02-28 20:29:41 -0800414
415 // TODO(calin): Assume for now we run in the bg compile job (which is in
416 // most of the invocation). With the current data flow, is not very easy or
417 // clean to discover this in RunProfman (it will require quite a messy refactoring).
418 const char* profman_bin = select_execution_binary(
419 kProfmanPath, kProfmanDebugPath, /*background_job_compile=*/ true);
Jeff Sharkey90aff262016-12-12 14:28:24 -0700420
Mathieu Chartiercc66c442018-11-09 15:57:21 -0800421 if (copy_and_update) {
422 CHECK_EQ(1u, profile_fds.size());
423 CHECK_EQ(1u, apk_fds.size());
Mathieu Chartier31636522018-11-09 23:53:07 +0000424 }
Mathieu Chartiercc66c442018-11-09 15:57:21 -0800425 if (reference_profile_fd != -1) {
426 AddArg("--reference-profile-file-fd=" + std::to_string(reference_profile_fd.get()));
Mathieu Chartier31636522018-11-09 23:53:07 +0000427 }
Mathieu Chartiercc66c442018-11-09 15:57:21 -0800428
429 for (const unique_fd& fd : profile_fds) {
430 AddArg("--profile-file-fd=" + std::to_string(fd.get()));
431 }
432
433 for (const unique_fd& fd : apk_fds) {
434 AddArg("--apk-fd=" + std::to_string(fd.get()));
435 }
436
437 for (const std::string& dex_location : dex_locations) {
438 AddArg("--dex-location=" + dex_location);
439 }
440
441 if (copy_and_update) {
442 AddArg("--copy-and-update-profile-key");
443 }
444
Calin Juravle78728f32019-11-08 17:55:46 -0800445 if (for_snapshot) {
446 AddArg("--force-merge");
447 }
448
449 if (for_boot_image) {
450 AddArg("--boot-image-merge");
451 }
452
yawannga27559e2020-11-13 19:17:44 +0000453 // The percent won't exceed 100, otherwise, don't set it and use the
454 // default one set in profman.
yawanng6fe34a52020-11-06 05:13:53 +0000455 uint32_t min_new_classes_percent_change = ::android::base::GetUintProperty<uint32_t>(
yawannga27559e2020-11-13 19:17:44 +0000456 "dalvik.vm.bgdexopt.new-classes-percent",
457 /*default*/std::numeric_limits<uint32_t>::max());
458 if (min_new_classes_percent_change <= 100) {
yawanng6fe34a52020-11-06 05:13:53 +0000459 AddArg("--min-new-classes-percent-change=" +
460 std::to_string(min_new_classes_percent_change));
461 }
462
yawannga27559e2020-11-13 19:17:44 +0000463 // The percent won't exceed 100, otherwise, don't set it and use the
464 // default one set in profman.
yawanng6fe34a52020-11-06 05:13:53 +0000465 uint32_t min_new_methods_percent_change = ::android::base::GetUintProperty<uint32_t>(
yawannga27559e2020-11-13 19:17:44 +0000466 "dalvik.vm.bgdexopt.new-methods-percent",
467 /*default*/std::numeric_limits<uint32_t>::max());
468 if (min_new_methods_percent_change <= 100) {
yawanng6fe34a52020-11-06 05:13:53 +0000469 AddArg("--min-new-methods-percent-change=" +
470 std::to_string(min_new_methods_percent_change));
471 }
472
Mathieu Chartiercc66c442018-11-09 15:57:21 -0800473 // Do not add after dex2oat_flags, they should override others for debugging.
474 PrepareArgs(profman_bin);
Mathieu Chartier62d218d2018-11-05 09:34:24 -0800475 }
Jeff Sharkey90aff262016-12-12 14:28:24 -0700476
Mathieu Chartiercc66c442018-11-09 15:57:21 -0800477 void SetupMerge(const std::vector<unique_fd>& profiles_fd,
478 const unique_fd& reference_profile_fd,
479 const std::vector<unique_fd>& apk_fds = std::vector<unique_fd>(),
Calin Juravle78728f32019-11-08 17:55:46 -0800480 const std::vector<std::string>& dex_locations = std::vector<std::string>(),
481 bool for_snapshot = false,
482 bool for_boot_image = false) {
Mathieu Chartiercc66c442018-11-09 15:57:21 -0800483 SetupArgs(profiles_fd,
Calin Juravleb3a929d2018-12-11 14:40:00 -0800484 reference_profile_fd,
485 apk_fds,
486 dex_locations,
Calin Juravle78728f32019-11-08 17:55:46 -0800487 /*copy_and_update=*/ false,
488 for_snapshot,
489 for_boot_image);
Mathieu Chartier62d218d2018-11-05 09:34:24 -0800490 }
Jeff Sharkey90aff262016-12-12 14:28:24 -0700491
Mathieu Chartiercc66c442018-11-09 15:57:21 -0800492 void SetupCopyAndUpdate(unique_fd&& profile_fd,
493 unique_fd&& reference_profile_fd,
494 unique_fd&& apk_fd,
495 const std::string& dex_location) {
496 // The fds need to stay open longer than the scope of the function, so put them into a local
497 // variable vector.
498 profiles_fd_.push_back(std::move(profile_fd));
499 apk_fds_.push_back(std::move(apk_fd));
500 reference_profile_fd_ = std::move(reference_profile_fd);
501 std::vector<std::string> dex_locations = {dex_location};
Calin Juravleb3a929d2018-12-11 14:40:00 -0800502 SetupArgs(profiles_fd_,
503 reference_profile_fd_,
504 apk_fds_,
505 dex_locations,
Calin Juravle78728f32019-11-08 17:55:46 -0800506 /*copy_and_update=*/true,
507 /*for_snapshot*/false,
508 /*for_boot_image*/false);
Mathieu Chartiercc66c442018-11-09 15:57:21 -0800509 }
Calin Juravlef63d4792018-01-30 17:43:34 +0000510
Mathieu Chartiercc66c442018-11-09 15:57:21 -0800511 void SetupDump(const std::vector<unique_fd>& profiles_fd,
512 const unique_fd& reference_profile_fd,
513 const std::vector<std::string>& dex_locations,
514 const std::vector<unique_fd>& apk_fds,
515 const unique_fd& output_fd) {
516 AddArg("--dump-only");
517 AddArg(StringPrintf("--dump-output-to-fd=%d", output_fd.get()));
Calin Juravleb3a929d2018-12-11 14:40:00 -0800518 SetupArgs(profiles_fd,
519 reference_profile_fd,
520 apk_fds,
521 dex_locations,
Calin Juravle78728f32019-11-08 17:55:46 -0800522 /*copy_and_update=*/false,
523 /*for_snapshot*/false,
524 /*for_boot_image*/false);
Mathieu Chartiercc66c442018-11-09 15:57:21 -0800525 }
Calin Juravlef63d4792018-01-30 17:43:34 +0000526
Victor Hsiehc9821f12020-08-07 11:32:29 -0700527 using ExecVHelper::Exec; // To suppress -Wno-overloaded-virtual
Mathieu Chartiercc66c442018-11-09 15:57:21 -0800528 void Exec() {
529 ExecVHelper::Exec(DexoptReturnCodes::kProfmanExec);
530 }
Mathieu Chartier31636522018-11-09 23:53:07 +0000531
Mathieu Chartiercc66c442018-11-09 15:57:21 -0800532 private:
533 unique_fd reference_profile_fd_;
534 std::vector<unique_fd> profiles_fd_;
535 std::vector<unique_fd> apk_fds_;
536};
Mathieu Chartier31636522018-11-09 23:53:07 +0000537
Mathieu Chartiercc66c442018-11-09 15:57:21 -0800538
Calin Juravlef63d4792018-01-30 17:43:34 +0000539
Jeff Sharkey90aff262016-12-12 14:28:24 -0700540// Decides if profile guided compilation is needed or not based on existing profiles.
Calin Juravle114f0812017-03-08 19:05:07 -0800541// The location is the package name for primary apks or the dex path for secondary dex files.
542// Returns true if there is enough information in the current profiles that makes it
543// worth to recompile the given location.
Jeff Sharkey90aff262016-12-12 14:28:24 -0700544// If the return value is true all the current profiles would have been merged into
545// the reference profiles accessible with open_reference_profile().
Calin Juravle824a64d2018-01-18 20:23:17 -0800546static bool analyze_profiles(uid_t uid, const std::string& package_name,
547 const std::string& location, bool is_secondary_dex) {
Calin Juravle1a0af3b2017-03-09 14:33:33 -0800548 std::vector<unique_fd> profiles_fd;
549 unique_fd reference_profile_fd;
Calin Juravle824a64d2018-01-18 20:23:17 -0800550 open_profile_files(uid, package_name, location, is_secondary_dex,
551 &profiles_fd, &reference_profile_fd);
Calin Juravle1a0af3b2017-03-09 14:33:33 -0800552 if (profiles_fd.empty() || (reference_profile_fd.get() < 0)) {
Jeff Sharkey90aff262016-12-12 14:28:24 -0700553 // Skip profile guided compilation because no profiles were found.
554 // Or if the reference profile info couldn't be opened.
Jeff Sharkey90aff262016-12-12 14:28:24 -0700555 return false;
556 }
557
Mathieu Chartiercc66c442018-11-09 15:57:21 -0800558 RunProfman profman_merge;
Calin Juravlef85ddb92020-05-01 14:05:40 -0700559 const std::vector<unique_fd>& apk_fds = std::vector<unique_fd>();
560 const std::vector<std::string>& dex_locations = std::vector<std::string>();
561 profman_merge.SetupMerge(
562 profiles_fd,
563 reference_profile_fd,
564 apk_fds,
565 dex_locations,
566 /* for_snapshot= */ false,
567 IsBootClassPathProfilingEnable());
Jeff Sharkey90aff262016-12-12 14:28:24 -0700568 pid_t pid = fork();
569 if (pid == 0) {
570 /* child -- drop privileges before continuing */
571 drop_capabilities(uid);
Mathieu Chartiercc66c442018-11-09 15:57:21 -0800572 profman_merge.Exec();
Jeff Sharkey90aff262016-12-12 14:28:24 -0700573 }
574 /* parent */
575 int return_code = wait_child(pid);
576 bool need_to_compile = false;
577 bool should_clear_current_profiles = false;
578 bool should_clear_reference_profile = false;
579 if (!WIFEXITED(return_code)) {
Calin Juravle114f0812017-03-08 19:05:07 -0800580 LOG(WARNING) << "profman failed for location " << location << ": " << return_code;
Jeff Sharkey90aff262016-12-12 14:28:24 -0700581 } else {
582 return_code = WEXITSTATUS(return_code);
583 switch (return_code) {
584 case PROFMAN_BIN_RETURN_CODE_COMPILE:
585 need_to_compile = true;
586 should_clear_current_profiles = true;
587 should_clear_reference_profile = false;
588 break;
589 case PROFMAN_BIN_RETURN_CODE_SKIP_COMPILATION:
590 need_to_compile = false;
591 should_clear_current_profiles = false;
592 should_clear_reference_profile = false;
593 break;
594 case PROFMAN_BIN_RETURN_CODE_BAD_PROFILES:
Calin Juravle114f0812017-03-08 19:05:07 -0800595 LOG(WARNING) << "Bad profiles for location " << location;
Jeff Sharkey90aff262016-12-12 14:28:24 -0700596 need_to_compile = false;
597 should_clear_current_profiles = true;
598 should_clear_reference_profile = true;
599 break;
600 case PROFMAN_BIN_RETURN_CODE_ERROR_IO: // fall-through
601 case PROFMAN_BIN_RETURN_CODE_ERROR_LOCKING:
602 // Temporary IO problem (e.g. locking). Ignore but log a warning.
Calin Juravle114f0812017-03-08 19:05:07 -0800603 LOG(WARNING) << "IO error while reading profiles for location " << location;
Jeff Sharkey90aff262016-12-12 14:28:24 -0700604 need_to_compile = false;
605 should_clear_current_profiles = false;
606 should_clear_reference_profile = false;
607 break;
Calin Juravle76561322019-11-14 09:08:52 -0800608 case PROFMAN_BIN_RETURN_CODE_ERROR_DIFFERENT_VERSIONS:
609 need_to_compile = false;
610 should_clear_current_profiles = true;
611 should_clear_reference_profile = true;
612 break;
Jeff Sharkey90aff262016-12-12 14:28:24 -0700613 default:
614 // Unknown return code or error. Unlink profiles.
Calin Juravle78728f32019-11-08 17:55:46 -0800615 LOG(WARNING) << "Unexpected error code while processing profiles for location "
Calin Juravle114f0812017-03-08 19:05:07 -0800616 << location << ": " << return_code;
Jeff Sharkey90aff262016-12-12 14:28:24 -0700617 need_to_compile = false;
618 should_clear_current_profiles = true;
619 should_clear_reference_profile = true;
620 break;
621 }
622 }
Calin Juravle1a0af3b2017-03-09 14:33:33 -0800623
Jeff Sharkey90aff262016-12-12 14:28:24 -0700624 if (should_clear_current_profiles) {
Calin Juravle114f0812017-03-08 19:05:07 -0800625 if (is_secondary_dex) {
626 // For secondary dex files, the owning user is the current user.
Calin Juravle824a64d2018-01-18 20:23:17 -0800627 clear_current_profile(package_name, location, multiuser_get_user_id(uid),
628 is_secondary_dex);
Calin Juravle114f0812017-03-08 19:05:07 -0800629 } else {
Calin Juravle824a64d2018-01-18 20:23:17 -0800630 clear_primary_current_profiles(package_name, location);
Calin Juravle114f0812017-03-08 19:05:07 -0800631 }
Jeff Sharkey90aff262016-12-12 14:28:24 -0700632 }
633 if (should_clear_reference_profile) {
Calin Juravle824a64d2018-01-18 20:23:17 -0800634 clear_reference_profile(package_name, location, is_secondary_dex);
Jeff Sharkey90aff262016-12-12 14:28:24 -0700635 }
636 return need_to_compile;
637}
638
Calin Juravle114f0812017-03-08 19:05:07 -0800639// Decides if profile guided compilation is needed or not based on existing profiles.
640// The analysis is done for the primary apks of the given package.
641// Returns true if there is enough information in the current profiles that makes it
642// worth to recompile the package.
643// If the return value is true all the current profiles would have been merged into
644// the reference profiles accessible with open_reference_profile().
Calin Juravle824a64d2018-01-18 20:23:17 -0800645bool analyze_primary_profiles(uid_t uid, const std::string& package_name,
646 const std::string& profile_name) {
647 return analyze_profiles(uid, package_name, profile_name, /*is_secondary_dex*/false);
Calin Juravle114f0812017-03-08 19:05:07 -0800648}
649
Calin Juravle408cd4a2018-01-20 23:34:18 -0800650bool dump_profiles(int32_t uid, const std::string& pkgname, const std::string& profile_name,
651 const std::string& code_path) {
Calin Juravle1a0af3b2017-03-09 14:33:33 -0800652 std::vector<unique_fd> profile_fds;
653 unique_fd reference_profile_fd;
Calin Juravle408cd4a2018-01-20 23:34:18 -0800654 std::string out_file_name = StringPrintf("/data/misc/profman/%s-%s.txt",
655 pkgname.c_str(), profile_name.c_str());
Jeff Sharkey90aff262016-12-12 14:28:24 -0700656
Calin Juravle408cd4a2018-01-20 23:34:18 -0800657 open_profile_files(uid, pkgname, profile_name, /*is_secondary_dex*/false,
Calin Juravle114f0812017-03-08 19:05:07 -0800658 &profile_fds, &reference_profile_fd);
Jeff Sharkey90aff262016-12-12 14:28:24 -0700659
Calin Juravle1a0af3b2017-03-09 14:33:33 -0800660 const bool has_reference_profile = (reference_profile_fd.get() != -1);
Jeff Sharkey90aff262016-12-12 14:28:24 -0700661 const bool has_profiles = !profile_fds.empty();
662
663 if (!has_reference_profile && !has_profiles) {
Calin Juravle76268c52017-03-09 13:19:42 -0800664 LOG(ERROR) << "profman dump: no profiles to dump for " << pkgname;
Jeff Sharkey90aff262016-12-12 14:28:24 -0700665 return false;
666 }
667
Calin Juravle114f0812017-03-08 19:05:07 -0800668 unique_fd output_fd(open(out_file_name.c_str(),
669 O_WRONLY | O_CREAT | O_TRUNC | O_NOFOLLOW, 0644));
Jeff Sharkey90aff262016-12-12 14:28:24 -0700670 if (fchmod(output_fd, S_IRUSR|S_IWUSR|S_IRGRP|S_IROTH) < 0) {
Calin Juravle408cd4a2018-01-20 23:34:18 -0800671 LOG(ERROR) << "installd cannot chmod file for dump_profile" << out_file_name;
Jeff Sharkey90aff262016-12-12 14:28:24 -0700672 return false;
673 }
Calin Juravle408cd4a2018-01-20 23:34:18 -0800674
Jeff Sharkey90aff262016-12-12 14:28:24 -0700675 std::vector<std::string> dex_locations;
Calin Juravle1a0af3b2017-03-09 14:33:33 -0800676 std::vector<unique_fd> apk_fds;
Calin Juravle408cd4a2018-01-20 23:34:18 -0800677 unique_fd apk_fd(open(code_path.c_str(), O_RDONLY | O_NOFOLLOW));
678 if (apk_fd == -1) {
679 PLOG(ERROR) << "installd cannot open " << code_path.c_str();
680 return false;
Jeff Sharkey90aff262016-12-12 14:28:24 -0700681 }
Victor Hsieh76f19ba2020-08-10 14:37:26 -0700682 dex_locations.push_back(Basename(code_path));
Calin Juravle408cd4a2018-01-20 23:34:18 -0800683 apk_fds.push_back(std::move(apk_fd));
684
Jeff Sharkey90aff262016-12-12 14:28:24 -0700685
Mathieu Chartiercc66c442018-11-09 15:57:21 -0800686 RunProfman profman_dump;
687 profman_dump.SetupDump(profile_fds, reference_profile_fd, dex_locations, apk_fds, output_fd);
Jeff Sharkey90aff262016-12-12 14:28:24 -0700688 pid_t pid = fork();
689 if (pid == 0) {
690 /* child -- drop privileges before continuing */
691 drop_capabilities(uid);
Mathieu Chartiercc66c442018-11-09 15:57:21 -0800692 profman_dump.Exec();
Jeff Sharkey90aff262016-12-12 14:28:24 -0700693 }
694 /* parent */
Jeff Sharkey90aff262016-12-12 14:28:24 -0700695 int return_code = wait_child(pid);
696 if (!WIFEXITED(return_code)) {
697 LOG(WARNING) << "profman failed for package " << pkgname << ": "
698 << return_code;
699 return false;
700 }
701 return true;
702}
703
Mathieu Chartierf966f2a2017-05-10 12:48:37 -0700704bool copy_system_profile(const std::string& system_profile,
Calin Juravle824a64d2018-01-18 20:23:17 -0800705 uid_t packageUid, const std::string& package_name, const std::string& profile_name) {
Mathieu Chartierf966f2a2017-05-10 12:48:37 -0700706 unique_fd in_fd(open(system_profile.c_str(), O_RDONLY | O_NOFOLLOW | O_CLOEXEC));
707 unique_fd out_fd(open_reference_profile(packageUid,
Calin Juravle824a64d2018-01-18 20:23:17 -0800708 package_name,
709 profile_name,
Mathieu Chartierf966f2a2017-05-10 12:48:37 -0700710 /*read_write*/ true,
711 /*secondary*/ false));
712 if (in_fd.get() < 0) {
713 PLOG(WARNING) << "Could not open profile " << system_profile;
714 return false;
715 }
716 if (out_fd.get() < 0) {
Calin Juravle824a64d2018-01-18 20:23:17 -0800717 PLOG(WARNING) << "Could not open profile " << package_name;
Mathieu Chartierf966f2a2017-05-10 12:48:37 -0700718 return false;
719 }
720
Mathieu Chartier78f71fe2017-06-14 13:02:26 -0700721 // As a security measure we want to write the profile information with the reduced capabilities
722 // of the package user id. So we fork and drop capabilities in the child.
Mathieu Chartierf966f2a2017-05-10 12:48:37 -0700723 pid_t pid = fork();
724 if (pid == 0) {
725 /* child -- drop privileges before continuing */
726 drop_capabilities(packageUid);
727
728 if (flock(out_fd.get(), LOCK_EX | LOCK_NB) != 0) {
729 if (errno != EWOULDBLOCK) {
Calin Juravle824a64d2018-01-18 20:23:17 -0800730 PLOG(WARNING) << "Error locking profile " << package_name;
Mathieu Chartierf966f2a2017-05-10 12:48:37 -0700731 }
732 // This implies that the app owning this profile is running
733 // (and has acquired the lock).
734 //
735 // The app never acquires the lock for the reference profiles of primary apks.
736 // Only dex2oat from installd will do that. Since installd is single threaded
737 // we should not see this case. Nevertheless be prepared for it.
Calin Juravle824a64d2018-01-18 20:23:17 -0800738 PLOG(WARNING) << "Failed to flock " << package_name;
Mathieu Chartierf966f2a2017-05-10 12:48:37 -0700739 return false;
740 }
741
742 bool truncated = ftruncate(out_fd.get(), 0) == 0;
743 if (!truncated) {
Calin Juravle824a64d2018-01-18 20:23:17 -0800744 PLOG(WARNING) << "Could not truncate " << package_name;
Mathieu Chartierf966f2a2017-05-10 12:48:37 -0700745 }
746
747 // Copy over data.
748 static constexpr size_t kBufferSize = 4 * 1024;
749 char buffer[kBufferSize];
750 while (true) {
751 ssize_t bytes = read(in_fd.get(), buffer, kBufferSize);
752 if (bytes == 0) {
753 break;
754 }
755 write(out_fd.get(), buffer, bytes);
756 }
757 if (flock(out_fd.get(), LOCK_UN) != 0) {
Calin Juravle824a64d2018-01-18 20:23:17 -0800758 PLOG(WARNING) << "Error unlocking profile " << package_name;
Mathieu Chartierf966f2a2017-05-10 12:48:37 -0700759 }
Mathieu Chartier78f71fe2017-06-14 13:02:26 -0700760 // Use _exit since we don't want to run the global destructors in the child.
761 // b/62597429
762 _exit(0);
Mathieu Chartierf966f2a2017-05-10 12:48:37 -0700763 }
764 /* parent */
765 int return_code = wait_child(pid);
766 return return_code == 0;
767}
768
Jeff Sharkey90aff262016-12-12 14:28:24 -0700769static std::string replace_file_extension(const std::string& oat_path, const std::string& new_ext) {
770 // A standard dalvik-cache entry. Replace ".dex" with `new_ext`.
771 if (EndsWith(oat_path, ".dex")) {
772 std::string new_path = oat_path;
773 new_path.replace(new_path.length() - strlen(".dex"), strlen(".dex"), new_ext);
Elliott Hughes969e4f82017-12-20 12:34:09 -0800774 CHECK(EndsWith(new_path, new_ext));
Jeff Sharkey90aff262016-12-12 14:28:24 -0700775 return new_path;
776 }
777
778 // An odex entry. Not that this may not be an extension, e.g., in the OTA
779 // case (where the base name will have an extension for the B artifact).
780 size_t odex_pos = oat_path.rfind(".odex");
781 if (odex_pos != std::string::npos) {
782 std::string new_path = oat_path;
783 new_path.replace(odex_pos, strlen(".odex"), new_ext);
784 CHECK_NE(new_path.find(new_ext), std::string::npos);
785 return new_path;
786 }
787
788 // Don't know how to handle this.
789 return "";
790}
791
792// Translate the given oat path to an art (app image) path. An empty string
793// denotes an error.
794static std::string create_image_filename(const std::string& oat_path) {
795 return replace_file_extension(oat_path, ".art");
796}
797
798// Translate the given oat path to a vdex path. An empty string denotes an error.
799static std::string create_vdex_filename(const std::string& oat_path) {
800 return replace_file_extension(oat_path, ".vdex");
801}
802
Jeff Sharkey90aff262016-12-12 14:28:24 -0700803static int open_output_file(const char* file_name, bool recreate, int permissions) {
804 int flags = O_RDWR | O_CREAT;
805 if (recreate) {
806 if (unlink(file_name) < 0) {
807 if (errno != ENOENT) {
808 PLOG(ERROR) << "open_output_file: Couldn't unlink " << file_name;
809 }
810 }
811 flags |= O_EXCL;
812 }
813 return open(file_name, flags, permissions);
814}
815
Calin Juravle2289c0a2017-02-15 12:44:14 -0800816static bool set_permissions_and_ownership(
817 int fd, bool is_public, int uid, const char* path, bool is_secondary_dex) {
818 // Primary apks are owned by the system. Secondary dex files are owned by the app.
819 int owning_uid = is_secondary_dex ? uid : AID_SYSTEM;
Jeff Sharkey90aff262016-12-12 14:28:24 -0700820 if (fchmod(fd,
821 S_IRUSR|S_IWUSR|S_IRGRP |
822 (is_public ? S_IROTH : 0)) < 0) {
823 ALOGE("installd cannot chmod '%s' during dexopt\n", path);
824 return false;
Calin Juravle2289c0a2017-02-15 12:44:14 -0800825 } else if (fchown(fd, owning_uid, uid) < 0) {
Jeff Sharkey90aff262016-12-12 14:28:24 -0700826 ALOGE("installd cannot chown '%s' during dexopt\n", path);
827 return false;
828 }
829 return true;
830}
831
832static bool IsOutputDalvikCache(const char* oat_dir) {
833 // InstallerConnection.java (which invokes installd) transforms Java null arguments
834 // into '!'. Play it safe by handling it both.
835 // TODO: ensure we never get null.
836 // TODO: pass a flag instead of inferring if the output is dalvik cache.
837 return oat_dir == nullptr || oat_dir[0] == '!';
838}
839
Calin Juravled23dee72017-07-06 16:29:11 -0700840// Best-effort check whether we can fit the the path into our buffers.
841// Note: the cache path will require an additional 5 bytes for ".swap", but we'll try to run
842// without a swap file, if necessary. Reference profiles file also add an extra ".prof"
843// extension to the cache path (5 bytes).
844// TODO(calin): move away from char* buffers and PKG_PATH_MAX.
845static bool validate_dex_path_size(const std::string& dex_path) {
846 if (dex_path.size() >= (PKG_PATH_MAX - 8)) {
847 LOG(ERROR) << "dex_path too long: " << dex_path;
848 return false;
849 }
850 return true;
851}
852
Jeff Sharkey90aff262016-12-12 14:28:24 -0700853static bool create_oat_out_path(const char* apk_path, const char* instruction_set,
Calin Juravle80a21252017-01-17 14:43:25 -0800854 const char* oat_dir, bool is_secondary_dex, /*out*/ char* out_oat_path) {
Calin Juravled23dee72017-07-06 16:29:11 -0700855 if (!validate_dex_path_size(apk_path)) {
Jeff Sharkey90aff262016-12-12 14:28:24 -0700856 return false;
857 }
858
859 if (!IsOutputDalvikCache(oat_dir)) {
Calin Juravle80a21252017-01-17 14:43:25 -0800860 // Oat dirs for secondary dex files are already validated.
861 if (!is_secondary_dex && validate_apk_path(oat_dir)) {
Jeff Sharkey90aff262016-12-12 14:28:24 -0700862 ALOGE("cannot validate apk path with oat_dir '%s'\n", oat_dir);
863 return false;
864 }
865 if (!calculate_oat_file_path(out_oat_path, oat_dir, apk_path, instruction_set)) {
866 return false;
867 }
868 } else {
869 if (!create_cache_path(out_oat_path, apk_path, instruction_set)) {
870 return false;
871 }
872 }
873 return true;
874}
875
Calin Juravle7a570e82017-01-14 16:23:30 -0800876// (re)Creates the app image if needed.
Victor Hsiehcb35a062020-08-13 16:11:13 -0700877UniqueFile maybe_open_app_image(const std::string& out_oat_path,
Mathieu Chartier1dc3dfa2018-03-12 17:55:06 -0700878 bool generate_app_image, bool is_public, int uid, bool is_secondary_dex) {
Nicolas Geoffrayaa17ab42017-08-15 14:51:05 +0100879
Calin Juravle7a570e82017-01-14 16:23:30 -0800880 const std::string image_path = create_image_filename(out_oat_path);
881 if (image_path.empty()) {
882 // Happens when the out_oat_path has an unknown extension.
Victor Hsiehcb35a062020-08-13 16:11:13 -0700883 return UniqueFile();
Calin Juravle7a570e82017-01-14 16:23:30 -0800884 }
Nicolas Geoffrayaa17ab42017-08-15 14:51:05 +0100885
Mathieu Chartier1dc3dfa2018-03-12 17:55:06 -0700886 // In case there is a stale image, remove it now. Ignore any error.
887 unlink(image_path.c_str());
888
889 // Not enabled, exit.
890 if (!generate_app_image) {
Victor Hsiehcb35a062020-08-13 16:11:13 -0700891 return UniqueFile();
Nicolas Geoffrayaa17ab42017-08-15 14:51:05 +0100892 }
Mathieu Chartier9b2da082018-10-26 13:23:11 -0700893 std::string app_image_format = GetProperty("dalvik.vm.appimageformat", "");
894 if (app_image_format.empty()) {
Victor Hsiehcb35a062020-08-13 16:11:13 -0700895 return UniqueFile();
Calin Juravle7a570e82017-01-14 16:23:30 -0800896 }
897 // Recreate is true since we do not want to modify a mapped image. If the app is
898 // already running and we modify the image file, it can cause crashes (b/27493510).
Victor Hsiehcb35a062020-08-13 16:11:13 -0700899 UniqueFile image_file(
Calin Juravle7a570e82017-01-14 16:23:30 -0800900 open_output_file(image_path.c_str(), true /*recreate*/, 0600 /*permissions*/),
Victor Hsiehcb35a062020-08-13 16:11:13 -0700901 image_path,
902 UnlinkIgnoreResult);
903 if (image_file.fd() < 0) {
Calin Juravle7a570e82017-01-14 16:23:30 -0800904 // Could not create application image file. Go on since we can compile without it.
905 LOG(ERROR) << "installd could not create '" << image_path
906 << "' for image file during dexopt";
907 // If we have a valid image file path but no image fd, explicitly erase the image file.
908 if (unlink(image_path.c_str()) < 0) {
909 if (errno != ENOENT) {
910 PLOG(ERROR) << "Couldn't unlink image file " << image_path;
911 }
912 }
913 } else if (!set_permissions_and_ownership(
Victor Hsiehcb35a062020-08-13 16:11:13 -0700914 image_file.fd(), is_public, uid, image_path.c_str(), is_secondary_dex)) {
Calin Juravle7a570e82017-01-14 16:23:30 -0800915 ALOGE("installd cannot set owner '%s' for image during dexopt\n", image_path.c_str());
Victor Hsiehcb35a062020-08-13 16:11:13 -0700916 image_file.reset();
Calin Juravle7a570e82017-01-14 16:23:30 -0800917 }
Jeff Sharkey90aff262016-12-12 14:28:24 -0700918
Victor Hsiehcb35a062020-08-13 16:11:13 -0700919 return image_file;
Calin Juravle7a570e82017-01-14 16:23:30 -0800920}
921
922// Creates the dexopt swap file if necessary and return its fd.
923// Returns -1 if there's no need for a swap or in case of errors.
Victor Hsiehcb35a062020-08-13 16:11:13 -0700924unique_fd maybe_open_dexopt_swap_file(const std::string& out_oat_path) {
Calin Juravle7a570e82017-01-14 16:23:30 -0800925 if (!ShouldUseSwapFileForDexopt()) {
Calin Juravle1a0af3b2017-03-09 14:33:33 -0800926 return invalid_unique_fd();
Calin Juravle7a570e82017-01-14 16:23:30 -0800927 }
Victor Hsiehcb35a062020-08-13 16:11:13 -0700928 auto swap_file_name = out_oat_path + ".swap";
Calin Juravle1a0af3b2017-03-09 14:33:33 -0800929 unique_fd swap_fd(open_output_file(
Jeff Sharkeyc1149c92017-09-21 14:51:09 -0600930 swap_file_name.c_str(), /*recreate*/true, /*permissions*/0600));
Calin Juravle7a570e82017-01-14 16:23:30 -0800931 if (swap_fd.get() < 0) {
932 // Could not create swap file. Optimistically go on and hope that we can compile
933 // without it.
Jeff Sharkeyc1149c92017-09-21 14:51:09 -0600934 ALOGE("installd could not create '%s' for swap during dexopt\n", swap_file_name.c_str());
Calin Juravle7a570e82017-01-14 16:23:30 -0800935 } else {
936 // Immediately unlink. We don't really want to hit flash.
Jeff Sharkeyc1149c92017-09-21 14:51:09 -0600937 if (unlink(swap_file_name.c_str()) < 0) {
Calin Juravle7a570e82017-01-14 16:23:30 -0800938 PLOG(ERROR) << "Couldn't unlink swap file " << swap_file_name;
939 }
940 }
941 return swap_fd;
942}
943
944// Opens the reference profiles if needed.
945// Note that the reference profile might not exist so it's OK if the fd will be -1.
Victor Hsiehcb35a062020-08-13 16:11:13 -0700946UniqueFile maybe_open_reference_profile(const std::string& pkgname,
Calin Juravlec4f6a0b2018-02-01 01:27:24 +0000947 const std::string& dex_path, const char* profile_name, bool profile_guided,
Calin Juravle824a64d2018-01-18 20:23:17 -0800948 bool is_public, int uid, bool is_secondary_dex) {
Calin Juravle5bd1c722018-02-01 17:23:54 +0000949 // If we are not profile guided compilation, or we are compiling system server
950 // do not bother to open the profiles; we won't be using them.
951 if (!profile_guided || (pkgname[0] == '*')) {
Victor Hsiehcb35a062020-08-13 16:11:13 -0700952 return UniqueFile();
Calin Juravle5bd1c722018-02-01 17:23:54 +0000953 }
954
955 // If this is a secondary dex path which is public do not open the profile.
956 // We cannot compile public secondary dex paths with profiles. That's because
957 // it will expose how the dex files are used by their owner.
958 //
959 // Note that the PackageManager is responsible to set the is_public flag for
960 // primary apks and we do not check it here. In some cases, e.g. when
961 // compiling with a public profile from the .dm file the PackageManager will
962 // set is_public toghether with the profile guided compilation.
963 if (is_secondary_dex && is_public) {
Victor Hsiehcb35a062020-08-13 16:11:13 -0700964 return UniqueFile();
Jeff Sharkey90aff262016-12-12 14:28:24 -0700965 }
Calin Juravle114f0812017-03-08 19:05:07 -0800966
967 // Open reference profile in read only mode as dex2oat does not get write permissions.
Calin Juravlec4f6a0b2018-02-01 01:27:24 +0000968 std::string location;
969 if (is_secondary_dex) {
970 location = dex_path;
971 } else {
972 if (profile_name == nullptr) {
973 // This path is taken for system server re-compilation lunched from ZygoteInit.
Victor Hsiehcb35a062020-08-13 16:11:13 -0700974 return UniqueFile();
Calin Juravlec4f6a0b2018-02-01 01:27:24 +0000975 } else {
976 location = profile_name;
977 }
978 }
Victor Hsiehcb35a062020-08-13 16:11:13 -0700979 return open_reference_profile_as_unique_file(uid, pkgname, location, /*read_write*/false,
980 is_secondary_dex);
Calin Juravle7a570e82017-01-14 16:23:30 -0800981}
Jeff Sharkey90aff262016-12-12 14:28:24 -0700982
Victor Hsiehcb35a062020-08-13 16:11:13 -0700983// Opens the vdex files and assigns the input fd to in_vdex_wrapper and the output fd to
984// out_vdex_wrapper. Returns true for success or false in case of errors.
Shubham Ajmerab6bcd222017-10-19 10:08:03 -0700985bool open_vdex_files_for_dex2oat(const char* apk_path, const char* out_oat_path, int dexopt_needed,
Nicolas Geoffray3c95f2d2017-04-24 13:34:59 +0000986 const char* instruction_set, bool is_public, int uid, bool is_secondary_dex,
Victor Hsiehcb35a062020-08-13 16:11:13 -0700987 bool profile_guided, UniqueFile* in_vdex_wrapper,
988 UniqueFile* out_vdex_wrapper) {
989 CHECK(in_vdex_wrapper != nullptr);
990 CHECK(out_vdex_wrapper != nullptr);
Jeff Sharkey90aff262016-12-12 14:28:24 -0700991 // Open the existing VDEX. We do this before creating the new output VDEX, which will
992 // unlink the old one.
Richard Uhler76cc0272016-12-08 10:46:35 +0000993 char in_odex_path[PKG_PATH_MAX];
994 int dexopt_action = abs(dexopt_needed);
995 bool is_odex_location = dexopt_needed < 0;
Nicolas Geoffrayb03814f2017-06-05 12:38:10 +0000996
997 // Infer the name of the output VDEX.
998 const std::string out_vdex_path_str = create_vdex_filename(out_oat_path);
999 if (out_vdex_path_str.empty()) {
1000 return false;
1001 }
1002
1003 bool update_vdex_in_place = false;
Nicolas Geoffray3c95f2d2017-04-24 13:34:59 +00001004 if (dexopt_action != DEX2OAT_FROM_SCRATCH) {
Jeff Sharkey90aff262016-12-12 14:28:24 -07001005 // Open the possibly existing vdex. If none exist, we pass -1 to dex2oat for input-vdex-fd.
1006 const char* path = nullptr;
1007 if (is_odex_location) {
1008 if (calculate_odex_file_path(in_odex_path, apk_path, instruction_set)) {
1009 path = in_odex_path;
1010 } else {
1011 ALOGE("installd cannot compute input vdex location for '%s'\n", apk_path);
Calin Juravle7a570e82017-01-14 16:23:30 -08001012 return false;
Jeff Sharkey90aff262016-12-12 14:28:24 -07001013 }
1014 } else {
1015 path = out_oat_path;
1016 }
Victor Hsiehcb35a062020-08-13 16:11:13 -07001017 std::string in_vdex_path_str = create_vdex_filename(path);
Jeff Sharkey90aff262016-12-12 14:28:24 -07001018 if (in_vdex_path_str.empty()) {
1019 ALOGE("installd cannot compute input vdex location for '%s'\n", path);
Calin Juravle7a570e82017-01-14 16:23:30 -08001020 return false;
Jeff Sharkey90aff262016-12-12 14:28:24 -07001021 }
Nicolas Geoffrayb03814f2017-06-05 12:38:10 +00001022 // We can update in place when all these conditions are met:
1023 // 1) The vdex location to write to is the same as the vdex location to read (vdex files
1024 // on /system typically cannot be updated in place).
1025 // 2) We dex2oat due to boot image change, because we then know the existing vdex file
1026 // cannot be currently used by a running process.
1027 // 3) We are not doing a profile guided compilation, because dexlayout requires two
1028 // different vdex files to operate.
1029 update_vdex_in_place =
1030 (in_vdex_path_str == out_vdex_path_str) &&
1031 (dexopt_action == DEX2OAT_FOR_BOOT_IMAGE) &&
1032 !profile_guided;
1033 if (update_vdex_in_place) {
1034 // Open the file read-write to be able to update it.
Victor Hsiehcb35a062020-08-13 16:11:13 -07001035 in_vdex_wrapper->reset(open(in_vdex_path_str.c_str(), O_RDWR, 0),
1036 in_vdex_path_str);
1037 if (in_vdex_wrapper->fd() == -1) {
Nicolas Geoffrayb03814f2017-06-05 12:38:10 +00001038 // If we failed to open the file, we cannot update it in place.
1039 update_vdex_in_place = false;
1040 }
1041 } else {
Victor Hsiehcb35a062020-08-13 16:11:13 -07001042 in_vdex_wrapper->reset(open(in_vdex_path_str.c_str(), O_RDONLY, 0),
1043 in_vdex_path_str);
Nicolas Geoffrayb03814f2017-06-05 12:38:10 +00001044 }
Jeff Sharkey90aff262016-12-12 14:28:24 -07001045 }
1046
Nicolas Geoffrayb03814f2017-06-05 12:38:10 +00001047 // If we are updating the vdex in place, we do not need to recreate a vdex,
1048 // and can use the same existing one.
1049 if (update_vdex_in_place) {
1050 // We unlink the file in case the invocation of dex2oat fails, to ensure we don't
1051 // have bogus stale vdex files.
Victor Hsiehcb35a062020-08-13 16:11:13 -07001052 out_vdex_wrapper->reset(
1053 in_vdex_wrapper->fd(),
1054 out_vdex_path_str,
1055 UnlinkIgnoreResult);
Nicolas Geoffrayb03814f2017-06-05 12:38:10 +00001056 // Disable auto close for the in wrapper fd (it will be done when destructing the out
1057 // wrapper).
Victor Hsiehcb35a062020-08-13 16:11:13 -07001058 in_vdex_wrapper->DisableAutoClose();
Nicolas Geoffrayb03814f2017-06-05 12:38:10 +00001059 } else {
Victor Hsiehcb35a062020-08-13 16:11:13 -07001060 out_vdex_wrapper->reset(
Nicolas Geoffrayb03814f2017-06-05 12:38:10 +00001061 open_output_file(out_vdex_path_str.c_str(), /*recreate*/true, /*permissions*/0644),
Victor Hsiehcb35a062020-08-13 16:11:13 -07001062 out_vdex_path_str,
1063 UnlinkIgnoreResult);
1064 if (out_vdex_wrapper->fd() < 0) {
Nicolas Geoffrayb03814f2017-06-05 12:38:10 +00001065 ALOGE("installd cannot open vdex'%s' during dexopt\n", out_vdex_path_str.c_str());
1066 return false;
1067 }
Jeff Sharkey90aff262016-12-12 14:28:24 -07001068 }
Victor Hsiehcb35a062020-08-13 16:11:13 -07001069 if (!set_permissions_and_ownership(out_vdex_wrapper->fd(), is_public, uid,
Calin Juravle2289c0a2017-02-15 12:44:14 -08001070 out_vdex_path_str.c_str(), is_secondary_dex)) {
Calin Juravle7a570e82017-01-14 16:23:30 -08001071 ALOGE("installd cannot set owner '%s' for vdex during dexopt\n", out_vdex_path_str.c_str());
1072 return false;
1073 }
1074
1075 // If we got here we successfully opened the vdex files.
1076 return true;
1077}
1078
1079// Opens the output oat file for the given apk.
Victor Hsiehcb35a062020-08-13 16:11:13 -07001080UniqueFile open_oat_out_file(const char* apk_path, const char* oat_dir,
1081 bool is_public, int uid, const char* instruction_set, bool is_secondary_dex) {
1082 char out_oat_path[PKG_PATH_MAX];
Calin Juravle80a21252017-01-17 14:43:25 -08001083 if (!create_oat_out_path(apk_path, instruction_set, oat_dir, is_secondary_dex, out_oat_path)) {
Victor Hsiehcb35a062020-08-13 16:11:13 -07001084 return UniqueFile();
Calin Juravle7a570e82017-01-14 16:23:30 -08001085 }
Victor Hsiehcb35a062020-08-13 16:11:13 -07001086 UniqueFile oat(
Calin Juravle7a570e82017-01-14 16:23:30 -08001087 open_output_file(out_oat_path, /*recreate*/true, /*permissions*/0644),
Victor Hsiehcb35a062020-08-13 16:11:13 -07001088 out_oat_path,
1089 UnlinkIgnoreResult);
1090 if (oat.fd() < 0) {
Calin Juravle80a21252017-01-17 14:43:25 -08001091 PLOG(ERROR) << "installd cannot open output during dexopt" << out_oat_path;
Calin Juravle2289c0a2017-02-15 12:44:14 -08001092 } else if (!set_permissions_and_ownership(
Victor Hsiehcb35a062020-08-13 16:11:13 -07001093 oat.fd(), is_public, uid, out_oat_path, is_secondary_dex)) {
Calin Juravle7a570e82017-01-14 16:23:30 -08001094 ALOGE("installd cannot set owner '%s' for output during dexopt\n", out_oat_path);
Victor Hsiehcb35a062020-08-13 16:11:13 -07001095 oat.reset();
Calin Juravle7a570e82017-01-14 16:23:30 -08001096 }
Victor Hsiehcb35a062020-08-13 16:11:13 -07001097 return oat;
Calin Juravle7a570e82017-01-14 16:23:30 -08001098}
1099
Shubham Ajmerab6bcd222017-10-19 10:08:03 -07001100// Creates RDONLY fds for oat and vdex files, if exist.
1101// Returns false if it fails to create oat out path for the given apk path.
1102// Note that the method returns true even if the files could not be opened.
1103bool maybe_open_oat_and_vdex_file(const std::string& apk_path,
1104 const std::string& oat_dir,
1105 const std::string& instruction_set,
1106 bool is_secondary_dex,
1107 unique_fd* oat_file_fd,
1108 unique_fd* vdex_file_fd) {
1109 char oat_path[PKG_PATH_MAX];
1110 if (!create_oat_out_path(apk_path.c_str(),
1111 instruction_set.c_str(),
1112 oat_dir.c_str(),
1113 is_secondary_dex,
1114 oat_path)) {
Calin Juravle7d765462017-09-04 15:57:10 -07001115 LOG(ERROR) << "Could not create oat out path for "
1116 << apk_path << " with oat dir " << oat_dir;
Shubham Ajmerab6bcd222017-10-19 10:08:03 -07001117 return false;
1118 }
1119 oat_file_fd->reset(open(oat_path, O_RDONLY));
1120 if (oat_file_fd->get() < 0) {
1121 PLOG(INFO) << "installd cannot open oat file during dexopt" << oat_path;
1122 }
1123
1124 std::string vdex_filename = create_vdex_filename(oat_path);
1125 vdex_file_fd->reset(open(vdex_filename.c_str(), O_RDONLY));
1126 if (vdex_file_fd->get() < 0) {
1127 PLOG(INFO) << "installd cannot open vdex file during dexopt" << vdex_filename;
1128 }
1129
1130 return true;
1131}
1132
Calin Juravle80a21252017-01-17 14:43:25 -08001133// Runs (execv) dexoptanalyzer on the given arguments.
Calin Juravle114f0812017-03-08 19:05:07 -08001134// The analyzer will check if the dex_file needs to be (re)compiled to match the compiler_filter.
1135// If this is for a profile guided compilation, profile_was_updated will tell whether or not
1136// the profile has changed.
Mathieu Chartiercc66c442018-11-09 15:57:21 -08001137class RunDexoptAnalyzer : public ExecVHelper {
1138 public:
1139 RunDexoptAnalyzer(const std::string& dex_file,
David Brazdil4f6027a2019-03-19 11:44:21 +00001140 int vdex_fd,
1141 int oat_fd,
1142 int zip_fd,
1143 const std::string& instruction_set,
1144 const std::string& compiler_filter,
1145 bool profile_was_updated,
1146 bool downgrade,
1147 const char* class_loader_context,
1148 const std::string& class_loader_context_fds) {
Mathieu Chartiercc66c442018-11-09 15:57:21 -08001149 CHECK_GE(zip_fd, 0);
Calin Juravlef74a7372019-02-28 20:29:41 -08001150
1151 // We always run the analyzer in the background job.
1152 const char* dexoptanalyzer_bin = select_execution_binary(
1153 kDexoptanalyzerPath, kDexoptanalyzerDebugPath, /*background_job_compile=*/ true);
Calin Juravle80a21252017-01-17 14:43:25 -08001154
Mathieu Chartiercc66c442018-11-09 15:57:21 -08001155 std::string dex_file_arg = "--dex-file=" + dex_file;
1156 std::string oat_fd_arg = "--oat-fd=" + std::to_string(oat_fd);
1157 std::string vdex_fd_arg = "--vdex-fd=" + std::to_string(vdex_fd);
1158 std::string zip_fd_arg = "--zip-fd=" + std::to_string(zip_fd);
1159 std::string isa_arg = "--isa=" + instruction_set;
1160 std::string compiler_filter_arg = "--compiler-filter=" + compiler_filter;
1161 const char* assume_profile_changed = "--assume-profile-changed";
1162 const char* downgrade_flag = "--downgrade";
1163 std::string class_loader_context_arg = "--class-loader-context=";
1164 if (class_loader_context != nullptr) {
1165 class_loader_context_arg += class_loader_context;
1166 }
David Brazdil4f6027a2019-03-19 11:44:21 +00001167 std::string class_loader_context_fds_arg = "--class-loader-context-fds=";
1168 if (!class_loader_context_fds.empty()) {
1169 class_loader_context_fds_arg += class_loader_context_fds;
1170 }
Mathieu Chartier31636522018-11-09 23:53:07 +00001171
Mathieu Chartiercc66c442018-11-09 15:57:21 -08001172 // program name, dex file, isa, filter
1173 AddArg(dex_file_arg);
1174 AddArg(isa_arg);
1175 AddArg(compiler_filter_arg);
1176 if (oat_fd >= 0) {
1177 AddArg(oat_fd_arg);
1178 }
1179 if (vdex_fd >= 0) {
1180 AddArg(vdex_fd_arg);
1181 }
Greg Kaiser8042c372019-03-26 06:23:19 -07001182 AddArg(zip_fd_arg);
Mathieu Chartiercc66c442018-11-09 15:57:21 -08001183 if (profile_was_updated) {
1184 AddArg(assume_profile_changed);
1185 }
1186 if (downgrade) {
1187 AddArg(downgrade_flag);
1188 }
1189 if (class_loader_context != nullptr) {
Greg Kaiser8042c372019-03-26 06:23:19 -07001190 AddArg(class_loader_context_arg);
David Brazdil4f6027a2019-03-19 11:44:21 +00001191 if (!class_loader_context_fds.empty()) {
Greg Kaiser8042c372019-03-26 06:23:19 -07001192 AddArg(class_loader_context_fds_arg);
David Brazdil4f6027a2019-03-19 11:44:21 +00001193 }
Mathieu Chartiercc66c442018-11-09 15:57:21 -08001194 }
Mathieu Chartier31636522018-11-09 23:53:07 +00001195
Mathieu Chartiercc66c442018-11-09 15:57:21 -08001196 PrepareArgs(dexoptanalyzer_bin);
1197 }
David Brazdil4f6027a2019-03-19 11:44:21 +00001198
1199 // Dexoptanalyzer mode which flattens the given class loader context and
1200 // prints a list of its dex files in that flattened order.
1201 RunDexoptAnalyzer(const char* class_loader_context) {
1202 CHECK(class_loader_context != nullptr);
1203
1204 // We always run the analyzer in the background job.
1205 const char* dexoptanalyzer_bin = select_execution_binary(
1206 kDexoptanalyzerPath, kDexoptanalyzerDebugPath, /*background_job_compile=*/ true);
1207
1208 AddArg("--flatten-class-loader-context");
1209 AddArg(std::string("--class-loader-context=") + class_loader_context);
1210 PrepareArgs(dexoptanalyzer_bin);
1211 }
Mathieu Chartiercc66c442018-11-09 15:57:21 -08001212};
Calin Juravle80a21252017-01-17 14:43:25 -08001213
1214// Prepares the oat dir for the secondary dex files.
Calin Juravle114f0812017-03-08 19:05:07 -08001215static bool prepare_secondary_dex_oat_dir(const std::string& dex_path, int uid,
Calin Juravle7d765462017-09-04 15:57:10 -07001216 const char* instruction_set) {
Calin Juravle114f0812017-03-08 19:05:07 -08001217 unsigned long dirIndex = dex_path.rfind('/');
Calin Juravle80a21252017-01-17 14:43:25 -08001218 if (dirIndex == std::string::npos) {
Calin Juravlec9eab382017-01-25 01:17:17 -08001219 LOG(ERROR ) << "Unexpected dir structure for secondary dex " << dex_path;
Calin Juravle80a21252017-01-17 14:43:25 -08001220 return false;
1221 }
Calin Juravle114f0812017-03-08 19:05:07 -08001222 std::string dex_dir = dex_path.substr(0, dirIndex);
Calin Juravle80a21252017-01-17 14:43:25 -08001223
Calin Juravle80a21252017-01-17 14:43:25 -08001224 // Create oat file output directory.
Calin Juravleebc8a792017-04-04 20:21:05 -07001225 mode_t oat_dir_mode = S_IRWXU | S_IRWXG | S_IXOTH;
1226 if (prepare_app_cache_dir(dex_dir, "oat", oat_dir_mode, uid, uid) != 0) {
Calin Juravlec9eab382017-01-25 01:17:17 -08001227 LOG(ERROR) << "Could not prepare oat dir for secondary dex: " << dex_path;
Calin Juravle80a21252017-01-17 14:43:25 -08001228 return false;
1229 }
1230
1231 char oat_dir[PKG_PATH_MAX];
Calin Juravle114f0812017-03-08 19:05:07 -08001232 snprintf(oat_dir, PKG_PATH_MAX, "%s/oat", dex_dir.c_str());
Calin Juravle80a21252017-01-17 14:43:25 -08001233
Calin Juravle7d765462017-09-04 15:57:10 -07001234 if (prepare_app_cache_dir(oat_dir, instruction_set, oat_dir_mode, uid, uid) != 0) {
Calin Juravlec9eab382017-01-25 01:17:17 -08001235 LOG(ERROR) << "Could not prepare oat/isa dir for secondary dex: " << dex_path;
Calin Juravle80a21252017-01-17 14:43:25 -08001236 return false;
1237 }
1238
1239 return true;
1240}
1241
Calin Juravle7d765462017-09-04 15:57:10 -07001242// Return codes for identifying the reason why dexoptanalyzer was not invoked when processing
1243// secondary dex files. This return codes are returned by the child process created for
1244// analyzing secondary dex files in process_secondary_dex_dexopt.
Calin Juravle80a21252017-01-17 14:43:25 -08001245
Andreas Gampe194fe422018-02-28 20:16:19 -08001246enum DexoptAnalyzerSkipCodes {
1247 // The dexoptanalyzer was not invoked because of validation or IO errors.
Andreas Gampe3008bbe2018-02-28 20:24:48 -08001248 // Specific errors are encoded in the name.
1249 kSecondaryDexDexoptAnalyzerSkippedValidatePath = 200,
1250 kSecondaryDexDexoptAnalyzerSkippedOpenZip = 201,
1251 kSecondaryDexDexoptAnalyzerSkippedPrepareDir = 202,
1252 kSecondaryDexDexoptAnalyzerSkippedOpenOutput = 203,
1253 kSecondaryDexDexoptAnalyzerSkippedFailExec = 204,
Andreas Gampe194fe422018-02-28 20:16:19 -08001254 // The dexoptanalyzer was not invoked because the dex file does not exist anymore.
Andreas Gampe3008bbe2018-02-28 20:24:48 -08001255 kSecondaryDexDexoptAnalyzerSkippedNoFile = 205,
Andreas Gampe194fe422018-02-28 20:16:19 -08001256};
Calin Juravle7d765462017-09-04 15:57:10 -07001257
1258// Verifies the result of analyzing secondary dex files from process_secondary_dex_dexopt.
Calin Juravle80a21252017-01-17 14:43:25 -08001259// If the result is valid returns true and sets dexopt_needed_out to a valid value.
1260// Returns false for errors or unexpected result values.
Calin Juravle7d765462017-09-04 15:57:10 -07001261// The result is expected to be either one of SECONDARY_DEX_* codes or a valid exit code
1262// of dexoptanalyzer.
1263static bool process_secondary_dexoptanalyzer_result(const std::string& dex_path, int result,
Andreas Gampe194fe422018-02-28 20:16:19 -08001264 int* dexopt_needed_out, std::string* error_msg) {
Calin Juravle80a21252017-01-17 14:43:25 -08001265 // The result values are defined in dexoptanalyzer.
1266 switch (result) {
Calin Juravle7d765462017-09-04 15:57:10 -07001267 case 0: // dexoptanalyzer: no_dexopt_needed
Calin Juravle80a21252017-01-17 14:43:25 -08001268 *dexopt_needed_out = NO_DEXOPT_NEEDED; return true;
Calin Juravle7d765462017-09-04 15:57:10 -07001269 case 1: // dexoptanalyzer: dex2oat_from_scratch
Calin Juravle80a21252017-01-17 14:43:25 -08001270 *dexopt_needed_out = DEX2OAT_FROM_SCRATCH; return true;
Vladimir Marko1752a112018-09-03 18:15:16 +01001271 case 4: // dexoptanalyzer: dex2oat_for_bootimage_odex
Calin Juravle80a21252017-01-17 14:43:25 -08001272 *dexopt_needed_out = -DEX2OAT_FOR_BOOT_IMAGE; return true;
Vladimir Marko1752a112018-09-03 18:15:16 +01001273 case 5: // dexoptanalyzer: dex2oat_for_filter_odex
Calin Juravle80a21252017-01-17 14:43:25 -08001274 *dexopt_needed_out = -DEX2OAT_FOR_FILTER; return true;
Calin Juravle7d765462017-09-04 15:57:10 -07001275 case 2: // dexoptanalyzer: dex2oat_for_bootimage_oat
1276 case 3: // dexoptanalyzer: dex2oat_for_filter_oat
Andreas Gampe194fe422018-02-28 20:16:19 -08001277 *error_msg = StringPrintf("Dexoptanalyzer return the status of an oat file."
1278 " Expected odex file status for secondary dex %s"
1279 " : dexoptanalyzer result=%d",
1280 dex_path.c_str(),
1281 result);
Calin Juravle80a21252017-01-17 14:43:25 -08001282 return false;
Andreas Gampe194fe422018-02-28 20:16:19 -08001283 }
1284
1285 // Use a second switch for enum switch-case analysis.
1286 switch (static_cast<DexoptAnalyzerSkipCodes>(result)) {
Andreas Gampe3008bbe2018-02-28 20:24:48 -08001287 case kSecondaryDexDexoptAnalyzerSkippedNoFile:
Calin Juravle7d765462017-09-04 15:57:10 -07001288 // If the file does not exist there's no need for dexopt.
1289 *dexopt_needed_out = NO_DEXOPT_NEEDED;
1290 return true;
Andreas Gampe3008bbe2018-02-28 20:24:48 -08001291
1292 case kSecondaryDexDexoptAnalyzerSkippedValidatePath:
1293 *error_msg = "Dexoptanalyzer path validation failed";
1294 return false;
1295 case kSecondaryDexDexoptAnalyzerSkippedOpenZip:
1296 *error_msg = "Dexoptanalyzer open zip failed";
1297 return false;
1298 case kSecondaryDexDexoptAnalyzerSkippedPrepareDir:
1299 *error_msg = "Dexoptanalyzer dir preparation failed";
1300 return false;
1301 case kSecondaryDexDexoptAnalyzerSkippedOpenOutput:
1302 *error_msg = "Dexoptanalyzer open output failed";
1303 return false;
1304 case kSecondaryDexDexoptAnalyzerSkippedFailExec:
1305 *error_msg = "Dexoptanalyzer failed to execute";
Calin Juravle80a21252017-01-17 14:43:25 -08001306 return false;
1307 }
Andreas Gampe194fe422018-02-28 20:16:19 -08001308
1309 *error_msg = StringPrintf("Unexpected result from analyzing secondary dex %s result=%d",
1310 dex_path.c_str(),
1311 result);
1312 return false;
Calin Juravle80a21252017-01-17 14:43:25 -08001313}
1314
Calin Juravle7d765462017-09-04 15:57:10 -07001315enum SecondaryDexAccess {
1316 kSecondaryDexAccessReadOk = 0,
1317 kSecondaryDexAccessDoesNotExist = 1,
1318 kSecondaryDexAccessPermissionError = 2,
1319 kSecondaryDexAccessIOError = 3
1320};
1321
1322static SecondaryDexAccess check_secondary_dex_access(const std::string& dex_path) {
1323 // Check if the path exists and can be read. If not, there's nothing to do.
1324 if (access(dex_path.c_str(), R_OK) == 0) {
1325 return kSecondaryDexAccessReadOk;
1326 } else {
1327 if (errno == ENOENT) {
1328 LOG(INFO) << "Secondary dex does not exist: " << dex_path;
1329 return kSecondaryDexAccessDoesNotExist;
1330 } else {
1331 PLOG(ERROR) << "Could not access secondary dex " << dex_path;
1332 return errno == EACCES
1333 ? kSecondaryDexAccessPermissionError
1334 : kSecondaryDexAccessIOError;
1335 }
1336 }
1337}
1338
1339static bool is_file_public(const std::string& filename) {
1340 struct stat file_stat;
1341 if (stat(filename.c_str(), &file_stat) == 0) {
1342 return (file_stat.st_mode & S_IROTH) != 0;
1343 }
1344 return false;
1345}
1346
1347// Create the oat file structure for the secondary dex 'dex_path' and assign
1348// the individual path component to the 'out_' parameters.
1349static bool create_secondary_dex_oat_layout(const std::string& dex_path, const std::string& isa,
Andreas Gampe194fe422018-02-28 20:16:19 -08001350 char* out_oat_dir, char* out_oat_isa_dir, char* out_oat_path, std::string* error_msg) {
Calin Juravle7d765462017-09-04 15:57:10 -07001351 size_t dirIndex = dex_path.rfind('/');
1352 if (dirIndex == std::string::npos) {
Andreas Gampe194fe422018-02-28 20:16:19 -08001353 *error_msg = std::string("Unexpected dir structure for dex file ").append(dex_path);
Calin Juravle7d765462017-09-04 15:57:10 -07001354 return false;
1355 }
1356 // TODO(calin): we have similar computations in at lest 3 other places
1357 // (InstalldNativeService, otapropt and dexopt). Unify them and get rid of snprintf by
1358 // using string append.
1359 std::string apk_dir = dex_path.substr(0, dirIndex);
1360 snprintf(out_oat_dir, PKG_PATH_MAX, "%s/oat", apk_dir.c_str());
1361 snprintf(out_oat_isa_dir, PKG_PATH_MAX, "%s/%s", out_oat_dir, isa.c_str());
1362
1363 if (!create_oat_out_path(dex_path.c_str(), isa.c_str(), out_oat_dir,
1364 /*is_secondary_dex*/true, out_oat_path)) {
Andreas Gampe194fe422018-02-28 20:16:19 -08001365 *error_msg = std::string("Could not create oat path for secondary dex ").append(dex_path);
Calin Juravle7d765462017-09-04 15:57:10 -07001366 return false;
1367 }
1368 return true;
1369}
1370
1371// Validate that the dexopt_flags contain a valid storage flag and convert that to an installd
1372// recognized storage flags (FLAG_STORAGE_CE or FLAG_STORAGE_DE).
Andreas Gampe194fe422018-02-28 20:16:19 -08001373static bool validate_dexopt_storage_flags(int dexopt_flags,
1374 int* out_storage_flag,
1375 std::string* error_msg) {
Calin Juravle7d765462017-09-04 15:57:10 -07001376 if ((dexopt_flags & DEXOPT_STORAGE_CE) != 0) {
1377 *out_storage_flag = FLAG_STORAGE_CE;
1378 if ((dexopt_flags & DEXOPT_STORAGE_DE) != 0) {
Andreas Gampe194fe422018-02-28 20:16:19 -08001379 *error_msg = "Ambiguous secondary dex storage flag. Both, CE and DE, flags are set";
Calin Juravle7d765462017-09-04 15:57:10 -07001380 return false;
1381 }
1382 } else if ((dexopt_flags & DEXOPT_STORAGE_DE) != 0) {
1383 *out_storage_flag = FLAG_STORAGE_DE;
1384 } else {
Andreas Gampe194fe422018-02-28 20:16:19 -08001385 *error_msg = "Secondary dex storage flag must be set";
Calin Juravle7d765462017-09-04 15:57:10 -07001386 return false;
1387 }
1388 return true;
1389}
1390
David Brazdil4f6027a2019-03-19 11:44:21 +00001391static bool get_class_loader_context_dex_paths(const char* class_loader_context, int uid,
1392 /* out */ std::vector<std::string>* context_dex_paths) {
1393 if (class_loader_context == nullptr) {
1394 return true;
1395 }
1396
1397 LOG(DEBUG) << "Getting dex paths for context " << class_loader_context;
1398
1399 // Pipe to get the hash result back from our child process.
1400 unique_fd pipe_read, pipe_write;
1401 if (!Pipe(&pipe_read, &pipe_write)) {
1402 PLOG(ERROR) << "Failed to create pipe";
1403 return false;
1404 }
1405
1406 pid_t pid = fork();
1407 if (pid == 0) {
1408 // child -- drop privileges before continuing.
1409 drop_capabilities(uid);
1410
1411 // Route stdout to `pipe_write`
1412 while ((dup2(pipe_write, STDOUT_FILENO) == -1) && (errno == EINTR)) {}
1413 pipe_write.reset();
1414 pipe_read.reset();
1415
1416 RunDexoptAnalyzer run_dexopt_analyzer(class_loader_context);
1417 run_dexopt_analyzer.Exec(kSecondaryDexDexoptAnalyzerSkippedFailExec);
1418 }
1419
1420 /* parent */
1421 pipe_write.reset();
1422
1423 std::string str_dex_paths;
1424 if (!ReadFdToString(pipe_read, &str_dex_paths)) {
1425 PLOG(ERROR) << "Failed to read from pipe";
1426 return false;
1427 }
1428 pipe_read.reset();
1429
1430 int return_code = wait_child(pid);
1431 if (!WIFEXITED(return_code)) {
1432 PLOG(ERROR) << "Error waiting for child dexoptanalyzer process";
1433 return false;
1434 }
1435
1436 constexpr int kFlattenClassLoaderContextSuccess = 50;
1437 return_code = WEXITSTATUS(return_code);
1438 if (return_code != kFlattenClassLoaderContextSuccess) {
1439 LOG(ERROR) << "Dexoptanalyzer could not flatten class loader context, code=" << return_code;
1440 return false;
1441 }
1442
1443 if (!str_dex_paths.empty()) {
1444 *context_dex_paths = android::base::Split(str_dex_paths, ":");
1445 }
1446 return true;
1447}
1448
1449static int open_dex_paths(const std::vector<std::string>& dex_paths,
1450 /* out */ std::vector<unique_fd>* zip_fds, /* out */ std::string* error_msg) {
1451 for (const std::string& dex_path : dex_paths) {
1452 zip_fds->emplace_back(open(dex_path.c_str(), O_RDONLY));
1453 if (zip_fds->back().get() < 0) {
1454 *error_msg = StringPrintf(
1455 "installd cannot open '%s' for input during dexopt", dex_path.c_str());
1456 if (errno == ENOENT) {
1457 return kSecondaryDexDexoptAnalyzerSkippedNoFile;
1458 } else {
1459 return kSecondaryDexDexoptAnalyzerSkippedOpenZip;
1460 }
1461 }
1462 }
1463 return 0;
1464}
1465
1466static std::string join_fds(const std::vector<unique_fd>& fds) {
1467 std::stringstream ss;
1468 bool is_first = true;
1469 for (const unique_fd& fd : fds) {
1470 if (is_first) {
1471 is_first = false;
1472 } else {
1473 ss << ":";
1474 }
1475 ss << fd.get();
1476 }
1477 return ss.str();
1478}
1479
Calin Juravlec9eab382017-01-25 01:17:17 -08001480// Processes the dex_path as a secondary dex files and return true if the path dex file should
Calin Juravle80a21252017-01-17 14:43:25 -08001481// be compiled. Returns false for errors (logged) or true if the secondary dex path was process
1482// successfully.
Calin Juravleebc8a792017-04-04 20:21:05 -07001483// When returning true, the output parameters will be:
1484// - is_public_out: whether or not the oat file should not be made public
1485// - dexopt_needed_out: valid OatFileAsssitant::DexOptNeeded
1486// - oat_dir_out: the oat dir path where the oat file should be stored
Calin Juravle7d765462017-09-04 15:57:10 -07001487static bool process_secondary_dex_dexopt(const std::string& dex_path, const char* pkgname,
Calin Juravle80a21252017-01-17 14:43:25 -08001488 int dexopt_flags, const char* volume_uuid, int uid, const char* instruction_set,
Calin Juravleebc8a792017-04-04 20:21:05 -07001489 const char* compiler_filter, bool* is_public_out, int* dexopt_needed_out,
Andreas Gampe194fe422018-02-28 20:16:19 -08001490 std::string* oat_dir_out, bool downgrade, const char* class_loader_context,
David Brazdil4f6027a2019-03-19 11:44:21 +00001491 const std::vector<std::string>& context_dex_paths, /* out */ std::string* error_msg) {
Calin Juravle7d765462017-09-04 15:57:10 -07001492 LOG(DEBUG) << "Processing secondary dex path " << dex_path;
Calin Juravle80a21252017-01-17 14:43:25 -08001493 int storage_flag;
Andreas Gampe194fe422018-02-28 20:16:19 -08001494 if (!validate_dexopt_storage_flags(dexopt_flags, &storage_flag, error_msg)) {
1495 LOG(ERROR) << *error_msg;
Calin Juravle80a21252017-01-17 14:43:25 -08001496 return false;
1497 }
Calin Juravle7d765462017-09-04 15:57:10 -07001498 // Compute the oat dir as it's not easy to extract it from the child computation.
1499 char oat_path[PKG_PATH_MAX];
1500 char oat_dir[PKG_PATH_MAX];
1501 char oat_isa_dir[PKG_PATH_MAX];
1502 if (!create_secondary_dex_oat_layout(
Andreas Gampe194fe422018-02-28 20:16:19 -08001503 dex_path, instruction_set, oat_dir, oat_isa_dir, oat_path, error_msg)) {
1504 LOG(ERROR) << "Could not create secondary odex layout: " << *error_msg;
Calin Juravled23dee72017-07-06 16:29:11 -07001505 return false;
1506 }
Calin Juravle7d765462017-09-04 15:57:10 -07001507 oat_dir_out->assign(oat_dir);
Shubham Ajmerab6bcd222017-10-19 10:08:03 -07001508
Calin Juravle80a21252017-01-17 14:43:25 -08001509 pid_t pid = fork();
1510 if (pid == 0) {
1511 // child -- drop privileges before continuing.
1512 drop_capabilities(uid);
Calin Juravle7d765462017-09-04 15:57:10 -07001513
1514 // Validate the path structure.
1515 if (!validate_secondary_dex_path(pkgname, dex_path, volume_uuid, uid, storage_flag)) {
1516 LOG(ERROR) << "Could not validate secondary dex path " << dex_path;
Andreas Gampe3008bbe2018-02-28 20:24:48 -08001517 _exit(kSecondaryDexDexoptAnalyzerSkippedValidatePath);
Calin Juravle7d765462017-09-04 15:57:10 -07001518 }
1519
1520 // Open the dex file.
1521 unique_fd zip_fd;
1522 zip_fd.reset(open(dex_path.c_str(), O_RDONLY));
1523 if (zip_fd.get() < 0) {
1524 if (errno == ENOENT) {
Andreas Gampe3008bbe2018-02-28 20:24:48 -08001525 _exit(kSecondaryDexDexoptAnalyzerSkippedNoFile);
Calin Juravle7d765462017-09-04 15:57:10 -07001526 } else {
Andreas Gampe3008bbe2018-02-28 20:24:48 -08001527 _exit(kSecondaryDexDexoptAnalyzerSkippedOpenZip);
Calin Juravle7d765462017-09-04 15:57:10 -07001528 }
1529 }
1530
David Brazdil4f6027a2019-03-19 11:44:21 +00001531 // Open class loader context dex files.
1532 std::vector<unique_fd> context_zip_fds;
1533 int open_dex_paths_rc = open_dex_paths(context_dex_paths, &context_zip_fds, error_msg);
1534 if (open_dex_paths_rc != 0) {
1535 _exit(open_dex_paths_rc);
1536 }
1537
Calin Juravle7d765462017-09-04 15:57:10 -07001538 // Prepare the oat directories.
1539 if (!prepare_secondary_dex_oat_dir(dex_path, uid, instruction_set)) {
Andreas Gampe3008bbe2018-02-28 20:24:48 -08001540 _exit(kSecondaryDexDexoptAnalyzerSkippedPrepareDir);
Calin Juravle7d765462017-09-04 15:57:10 -07001541 }
1542
1543 // Open the vdex/oat files if any.
1544 unique_fd oat_file_fd;
1545 unique_fd vdex_file_fd;
1546 if (!maybe_open_oat_and_vdex_file(dex_path,
1547 *oat_dir_out,
1548 instruction_set,
1549 true /* is_secondary_dex */,
1550 &oat_file_fd,
1551 &vdex_file_fd)) {
Andreas Gampe3008bbe2018-02-28 20:24:48 -08001552 _exit(kSecondaryDexDexoptAnalyzerSkippedOpenOutput);
Calin Juravle7d765462017-09-04 15:57:10 -07001553 }
1554
1555 // Analyze profiles.
Calin Juravle824a64d2018-01-18 20:23:17 -08001556 bool profile_was_updated = analyze_profiles(uid, pkgname, dex_path,
1557 /*is_secondary_dex*/true);
Calin Juravle7d765462017-09-04 15:57:10 -07001558
1559 // Run dexoptanalyzer to get dexopt_needed code. This is not expected to return.
Mathieu Chartiercc66c442018-11-09 15:57:21 -08001560 // Note that we do not do it before the fork since opening the files is required to happen
1561 // after forking.
1562 RunDexoptAnalyzer run_dexopt_analyzer(dex_path,
1563 vdex_file_fd.get(),
1564 oat_file_fd.get(),
1565 zip_fd.get(),
1566 instruction_set,
1567 compiler_filter, profile_was_updated,
1568 downgrade,
David Brazdil4f6027a2019-03-19 11:44:21 +00001569 class_loader_context,
1570 join_fds(context_zip_fds));
Mathieu Chartiercc66c442018-11-09 15:57:21 -08001571 run_dexopt_analyzer.Exec(kSecondaryDexDexoptAnalyzerSkippedFailExec);
Calin Juravle80a21252017-01-17 14:43:25 -08001572 }
1573
1574 /* parent */
Calin Juravle80a21252017-01-17 14:43:25 -08001575 int result = wait_child(pid);
1576 if (!WIFEXITED(result)) {
Andreas Gampe194fe422018-02-28 20:16:19 -08001577 *error_msg = StringPrintf("dexoptanalyzer failed for path %s: 0x%04x",
1578 dex_path.c_str(),
1579 result);
1580 LOG(ERROR) << *error_msg;
Calin Juravle80a21252017-01-17 14:43:25 -08001581 return false;
1582 }
1583 result = WEXITSTATUS(result);
Calin Juravle7d765462017-09-04 15:57:10 -07001584 // Check that we successfully executed dexoptanalyzer.
Andreas Gampe194fe422018-02-28 20:16:19 -08001585 bool success = process_secondary_dexoptanalyzer_result(dex_path,
1586 result,
1587 dexopt_needed_out,
1588 error_msg);
1589 if (!success) {
1590 LOG(ERROR) << *error_msg;
1591 }
Calin Juravle7d765462017-09-04 15:57:10 -07001592
1593 LOG(DEBUG) << "Processed secondary dex file " << dex_path << " result=" << result;
1594
Calin Juravle80a21252017-01-17 14:43:25 -08001595 // Run dexopt only if needed or forced.
Calin Juravle7d765462017-09-04 15:57:10 -07001596 // Note that dexoptanalyzer is executed even if force compilation is enabled (because it
1597 // makes the code simpler; force compilation is only needed during tests).
1598 if (success &&
Andreas Gampe3008bbe2018-02-28 20:24:48 -08001599 (result != kSecondaryDexDexoptAnalyzerSkippedNoFile) &&
Calin Juravle7d765462017-09-04 15:57:10 -07001600 ((dexopt_flags & DEXOPT_FORCE) != 0)) {
Calin Juravle80a21252017-01-17 14:43:25 -08001601 *dexopt_needed_out = DEX2OAT_FROM_SCRATCH;
1602 }
1603
Calin Juravle7d765462017-09-04 15:57:10 -07001604 // Check if we should make the oat file public.
1605 // Note that if the dex file is not public the compiled code cannot be made public.
1606 // It is ok to check this flag outside in the parent process.
1607 *is_public_out = ((dexopt_flags & DEXOPT_PUBLIC) != 0) && is_file_public(dex_path);
1608
Calin Juravle80a21252017-01-17 14:43:25 -08001609 return success;
1610}
1611
Andreas Gampefa2dadd2018-02-28 19:52:47 -08001612static std::string format_dexopt_error(int status, const char* dex_path) {
1613 if (WIFEXITED(status)) {
1614 int int_code = WEXITSTATUS(status);
1615 const char* code_name = get_return_code_name(static_cast<DexoptReturnCodes>(int_code));
1616 if (code_name != nullptr) {
1617 return StringPrintf("Dex2oat invocation for %s failed: %s", dex_path, code_name);
1618 }
1619 }
1620 return StringPrintf("Dex2oat invocation for %s failed with 0x%04x", dex_path, status);
Andreas Gampe023b2242018-02-28 16:03:25 -08001621}
1622
Calin Juravlec9eab382017-01-25 01:17:17 -08001623int dexopt(const char* dex_path, uid_t uid, const char* pkgname, const char* instruction_set,
Calin Juravle80a21252017-01-17 14:43:25 -08001624 int dexopt_needed, const char* oat_dir, int dexopt_flags, const char* compiler_filter,
Calin Juravle52c45822017-07-13 22:50:21 -07001625 const char* volume_uuid, const char* class_loader_context, const char* se_info,
Calin Juravle62c5a372018-02-01 17:03:23 +00001626 bool downgrade, int target_sdk_version, const char* profile_name,
Andreas Gampe023b2242018-02-28 16:03:25 -08001627 const char* dex_metadata_path, const char* compilation_reason, std::string* error_msg) {
Calin Juravle7a570e82017-01-14 16:23:30 -08001628 CHECK(pkgname != nullptr);
1629 CHECK(pkgname[0] != 0);
Andreas Gampe023b2242018-02-28 16:03:25 -08001630 CHECK(error_msg != nullptr);
Andreas Gamped32eec22018-02-28 16:02:51 -08001631 CHECK_EQ(dexopt_flags & ~DEXOPT_MASK, 0)
1632 << "dexopt flags contains unknown fields: " << dexopt_flags;
Calin Juravle7a570e82017-01-14 16:23:30 -08001633
Calin Juravled23dee72017-07-06 16:29:11 -07001634 if (!validate_dex_path_size(dex_path)) {
Andreas Gampe023b2242018-02-28 16:03:25 -08001635 *error_msg = StringPrintf("Failed to validate %s", dex_path);
Calin Juravle52c45822017-07-13 22:50:21 -07001636 return -1;
1637 }
1638
1639 if (class_loader_context != nullptr && strlen(class_loader_context) > PKG_PATH_MAX) {
Andreas Gampe023b2242018-02-28 16:03:25 -08001640 *error_msg = StringPrintf("Class loader context exceeds the allowed size: %s",
1641 class_loader_context);
1642 LOG(ERROR) << *error_msg;
Calin Juravle52c45822017-07-13 22:50:21 -07001643 return -1;
Calin Juravled23dee72017-07-06 16:29:11 -07001644 }
1645
Calin Juravleebc8a792017-04-04 20:21:05 -07001646 bool is_public = (dexopt_flags & DEXOPT_PUBLIC) != 0;
Calin Juravle7a570e82017-01-14 16:23:30 -08001647 bool debuggable = (dexopt_flags & DEXOPT_DEBUGGABLE) != 0;
1648 bool boot_complete = (dexopt_flags & DEXOPT_BOOTCOMPLETE) != 0;
1649 bool profile_guided = (dexopt_flags & DEXOPT_PROFILE_GUIDED) != 0;
Calin Juravle80a21252017-01-17 14:43:25 -08001650 bool is_secondary_dex = (dexopt_flags & DEXOPT_SECONDARY_DEX) != 0;
Andreas Gampea73a0cb2017-11-02 18:14:42 -07001651 bool background_job_compile = (dexopt_flags & DEXOPT_IDLE_BACKGROUND_JOB) != 0;
David Brazdil52249162018-02-12 18:04:59 -08001652 bool enable_hidden_api_checks = (dexopt_flags & DEXOPT_ENABLE_HIDDEN_API_CHECKS) != 0;
Mathieu Chartierf69c2f72018-03-06 13:55:58 -08001653 bool generate_compact_dex = (dexopt_flags & DEXOPT_GENERATE_COMPACT_DEX) != 0;
Mathieu Chartier1dc3dfa2018-03-12 17:55:06 -07001654 bool generate_app_image = (dexopt_flags & DEXOPT_GENERATE_APP_IMAGE) != 0;
Patrick Baumann2271b3e2020-04-14 17:03:00 -07001655 bool for_restore = (dexopt_flags & DEXOPT_FOR_RESTORE) != 0;
Calin Juravle80a21252017-01-17 14:43:25 -08001656
1657 // Check if we're dealing with a secondary dex file and if we need to compile it.
1658 std::string oat_dir_str;
David Brazdil4f6027a2019-03-19 11:44:21 +00001659 std::vector<std::string> context_dex_paths;
Calin Juravle80a21252017-01-17 14:43:25 -08001660 if (is_secondary_dex) {
David Brazdil4f6027a2019-03-19 11:44:21 +00001661 if (!get_class_loader_context_dex_paths(class_loader_context, uid, &context_dex_paths)) {
1662 *error_msg = "Failed acquiring context dex paths";
1663 return -1; // We had an error, logged in the process method.
1664 }
1665
Calin Juravlec9eab382017-01-25 01:17:17 -08001666 if (process_secondary_dex_dexopt(dex_path, pkgname, dexopt_flags, volume_uuid, uid,
Calin Juravleebc8a792017-04-04 20:21:05 -07001667 instruction_set, compiler_filter, &is_public, &dexopt_needed, &oat_dir_str,
David Brazdil4f6027a2019-03-19 11:44:21 +00001668 downgrade, class_loader_context, context_dex_paths, error_msg)) {
Calin Juravle80a21252017-01-17 14:43:25 -08001669 oat_dir = oat_dir_str.c_str();
1670 if (dexopt_needed == NO_DEXOPT_NEEDED) {
1671 return 0; // Nothing to do, report success.
1672 }
1673 } else {
Andreas Gampe194fe422018-02-28 20:16:19 -08001674 if (error_msg->empty()) { // TODO: Make this a CHECK.
1675 *error_msg = "Failed processing secondary.";
1676 }
Calin Juravle80a21252017-01-17 14:43:25 -08001677 return -1; // We had an error, logged in the process method.
1678 }
1679 } else {
David Brazdil4f6027a2019-03-19 11:44:21 +00001680 // Currently these flags are only used for secondary dex files.
Calin Juravlec9eab382017-01-25 01:17:17 -08001681 // Verify that they are not set for primary apks.
Calin Juravle80a21252017-01-17 14:43:25 -08001682 CHECK((dexopt_flags & DEXOPT_STORAGE_CE) == 0);
1683 CHECK((dexopt_flags & DEXOPT_STORAGE_DE) == 0);
1684 }
Calin Juravle7a570e82017-01-14 16:23:30 -08001685
1686 // Open the input file.
Victor Hsiehcb35a062020-08-13 16:11:13 -07001687 UniqueFile in_dex(open(dex_path, O_RDONLY, 0), dex_path);
1688 if (in_dex.fd() < 0) {
Andreas Gampe023b2242018-02-28 16:03:25 -08001689 *error_msg = StringPrintf("installd cannot open '%s' for input during dexopt", dex_path);
1690 LOG(ERROR) << *error_msg;
Calin Juravle7a570e82017-01-14 16:23:30 -08001691 return -1;
1692 }
1693
David Brazdil4f6027a2019-03-19 11:44:21 +00001694 // Open class loader context dex files.
1695 std::vector<unique_fd> context_input_fds;
1696 if (open_dex_paths(context_dex_paths, &context_input_fds, error_msg) != 0) {
1697 LOG(ERROR) << *error_msg;
1698 return -1;
1699 }
1700
Calin Juravle7a570e82017-01-14 16:23:30 -08001701 // Create the output OAT file.
Victor Hsiehcb35a062020-08-13 16:11:13 -07001702 UniqueFile out_oat = open_oat_out_file(dex_path, oat_dir, is_public, uid,
1703 instruction_set, is_secondary_dex);
1704 if (out_oat.fd() < 0) {
Andreas Gampe023b2242018-02-28 16:03:25 -08001705 *error_msg = "Could not open out oat file.";
Calin Juravle7a570e82017-01-14 16:23:30 -08001706 return -1;
1707 }
1708
1709 // Open vdex files.
Victor Hsiehcb35a062020-08-13 16:11:13 -07001710 UniqueFile in_vdex;
1711 UniqueFile out_vdex;
1712 if (!open_vdex_files_for_dex2oat(dex_path, out_oat.path().c_str(), dexopt_needed,
1713 instruction_set, is_public, uid, is_secondary_dex, profile_guided, &in_vdex,
1714 &out_vdex)) {
Andreas Gampe023b2242018-02-28 16:03:25 -08001715 *error_msg = "Could not open vdex files.";
Jeff Sharkey90aff262016-12-12 14:28:24 -07001716 return -1;
1717 }
1718
Calin Juravlecb556e32017-04-04 20:22:50 -07001719 // Ensure that the oat dir and the compiler artifacts of secondary dex files have the correct
1720 // selinux context (we generate them on the fly during the dexopt invocation and they don't
1721 // fully inherit their parent context).
1722 // Note that for primary apk the oat files are created before, in a separate installd
1723 // call which also does the restorecon. TODO(calin): unify the paths.
1724 if (is_secondary_dex) {
1725 if (selinux_android_restorecon_pkgdir(oat_dir, se_info, uid,
1726 SELINUX_ANDROID_RESTORECON_RECURSE)) {
Andreas Gampe023b2242018-02-28 16:03:25 -08001727 *error_msg = std::string("Failed to restorecon ").append(oat_dir);
1728 LOG(ERROR) << *error_msg;
Calin Juravlecb556e32017-04-04 20:22:50 -07001729 return -1;
1730 }
1731 }
1732
Jeff Sharkey90aff262016-12-12 14:28:24 -07001733 // Create a swap file if necessary.
Victor Hsiehcb35a062020-08-13 16:11:13 -07001734 unique_fd swap_fd = maybe_open_dexopt_swap_file(out_oat.path());
Jeff Sharkey90aff262016-12-12 14:28:24 -07001735
Calin Juravle7a570e82017-01-14 16:23:30 -08001736 // Open the reference profile if needed.
Victor Hsiehcb35a062020-08-13 16:11:13 -07001737 UniqueFile reference_profile = maybe_open_reference_profile(
Calin Juravle824a64d2018-01-18 20:23:17 -08001738 pkgname, dex_path, profile_name, profile_guided, is_public, uid, is_secondary_dex);
Calin Juravle7a570e82017-01-14 16:23:30 -08001739
Victor Hsiehcb35a062020-08-13 16:11:13 -07001740 if (reference_profile.fd() == -1) {
liulvping61907742018-08-21 09:36:52 +08001741 // We don't create an app image without reference profile since there is no speedup from
1742 // loading it in that case and instead will be a small overhead.
1743 generate_app_image = false;
1744 }
1745
1746 // Create the app image file if needed.
Victor Hsiehcb35a062020-08-13 16:11:13 -07001747 UniqueFile out_image = maybe_open_app_image(
1748 out_oat.path(), generate_app_image, is_public, uid, is_secondary_dex);
liulvping61907742018-08-21 09:36:52 +08001749
Victor Hsiehcb35a062020-08-13 16:11:13 -07001750 UniqueFile dex_metadata;
Calin Juravle62c5a372018-02-01 17:03:23 +00001751 if (dex_metadata_path != nullptr) {
Victor Hsiehcb35a062020-08-13 16:11:13 -07001752 dex_metadata.reset(TEMP_FAILURE_RETRY(open(dex_metadata_path, O_RDONLY | O_NOFOLLOW)),
1753 dex_metadata_path);
1754 if (dex_metadata.fd() < 0) {
Calin Juravle62c5a372018-02-01 17:03:23 +00001755 PLOG(ERROR) << "Failed to open dex metadata file " << dex_metadata_path;
1756 }
1757 }
1758
Victor Hsieh8948a862020-08-07 11:30:55 -07001759 std::string jitzygote_flag = server_configurable_flags::GetServerConfigurableFlag(
1760 RUNTIME_NATIVE_BOOT_NAMESPACE,
1761 ENABLE_JITZYGOTE_IMAGE,
1762 /*default_value=*/ "");
1763 bool use_jitzygote_image = jitzygote_flag == "true" || IsBootClassPathProfilingEnable();
1764
Victor Hsiehe98e6512020-08-10 15:39:22 -07001765 // Decide whether to use dex2oat64.
1766 bool use_dex2oat64 = false;
1767 // Check whether the device even supports 64-bit ABIs.
1768 if (!GetProperty("ro.product.cpu.abilist64", "").empty()) {
1769 use_dex2oat64 = GetBoolProperty("dalvik.vm.dex2oat64.enabled", false);
1770 }
1771 const char* dex2oat_bin = select_execution_binary(
1772 (use_dex2oat64 ? kDex2oat64Path : kDex2oat32Path),
1773 (use_dex2oat64 ? kDex2oatDebug64Path : kDex2oatDebug32Path),
1774 background_job_compile);
1775
Victor Hsiehc9821f12020-08-07 11:32:29 -07001776 auto execv_helper = std::make_unique<ExecVHelper>();
1777
Andreas Gampe023b2242018-02-28 16:03:25 -08001778 LOG(VERBOSE) << "DexInv: --- BEGIN '" << dex_path << "' ---";
Jeff Sharkey90aff262016-12-12 14:28:24 -07001779
Victor Hsiehc9821f12020-08-07 11:32:29 -07001780 RunDex2Oat runner(dex2oat_bin, execv_helper.get());
Victor Hsiehcb35a062020-08-13 16:11:13 -07001781 runner.Initialize(out_oat,
1782 out_vdex,
1783 out_image,
1784 in_dex,
1785 in_vdex,
1786 dex_metadata,
1787 reference_profile,
1788 class_loader_context,
1789 join_fds(context_input_fds),
Mathieu Chartiercc66c442018-11-09 15:57:21 -08001790 swap_fd.get(),
1791 instruction_set,
1792 compiler_filter,
1793 debuggable,
1794 boot_complete,
Patrick Baumann2271b3e2020-04-14 17:03:00 -07001795 for_restore,
Mathieu Chartiercc66c442018-11-09 15:57:21 -08001796 target_sdk_version,
1797 enable_hidden_api_checks,
1798 generate_compact_dex,
Victor Hsieh8948a862020-08-07 11:30:55 -07001799 use_jitzygote_image,
Mathieu Chartiercc66c442018-11-09 15:57:21 -08001800 compilation_reason);
1801
Jeff Sharkey90aff262016-12-12 14:28:24 -07001802 pid_t pid = fork();
1803 if (pid == 0) {
Wei Wange0dbd9b2020-12-11 17:24:19 +00001804 // Need to set schedpolicy before dropping privileges
1805 // for cgroup migration. See details at b/175178520.
1806 SetDex2OatScheduling(boot_complete);
1807
Jeff Sharkey90aff262016-12-12 14:28:24 -07001808 /* child -- drop privileges before continuing */
1809 drop_capabilities(uid);
1810
Victor Hsiehcb35a062020-08-13 16:11:13 -07001811 if (flock(out_oat.fd(), LOCK_EX | LOCK_NB) != 0) {
1812 PLOG(ERROR) << "flock(" << out_oat.path() << ") failed";
Andreas Gampefa2dadd2018-02-28 19:52:47 -08001813 _exit(DexoptReturnCodes::kFlock);
Jeff Sharkey90aff262016-12-12 14:28:24 -07001814 }
1815
Mathieu Chartiercc66c442018-11-09 15:57:21 -08001816 runner.Exec(DexoptReturnCodes::kDex2oatExec);
Jeff Sharkey90aff262016-12-12 14:28:24 -07001817 } else {
1818 int res = wait_child(pid);
1819 if (res == 0) {
Andreas Gampe023b2242018-02-28 16:03:25 -08001820 LOG(VERBOSE) << "DexInv: --- END '" << dex_path << "' (success) ---";
Jeff Sharkey90aff262016-12-12 14:28:24 -07001821 } else {
Andreas Gampe023b2242018-02-28 16:03:25 -08001822 LOG(VERBOSE) << "DexInv: --- END '" << dex_path << "' --- status=0x"
1823 << std::hex << std::setw(4) << res << ", process failed";
1824 *error_msg = format_dexopt_error(res, dex_path);
Andreas Gampe013f02e2017-03-20 18:36:54 -07001825 return res;
Jeff Sharkey90aff262016-12-12 14:28:24 -07001826 }
1827 }
1828
Jeff Sharkey90aff262016-12-12 14:28:24 -07001829 // We've been successful, don't delete output.
Victor Hsiehcb35a062020-08-13 16:11:13 -07001830 out_oat.DisableCleanup();
1831 out_vdex.DisableCleanup();
1832 out_image.DisableCleanup();
1833 reference_profile.DisableCleanup();
Jeff Sharkey90aff262016-12-12 14:28:24 -07001834
1835 return 0;
1836}
1837
Calin Juravlec9eab382017-01-25 01:17:17 -08001838// Try to remove the given directory. Log an error if the directory exists
1839// and is empty but could not be removed.
1840static bool rmdir_if_empty(const char* dir) {
1841 if (rmdir(dir) == 0) {
1842 return true;
1843 }
1844 if (errno == ENOENT || errno == ENOTEMPTY) {
1845 return true;
1846 }
1847 PLOG(ERROR) << "Failed to remove dir: " << dir;
1848 return false;
1849}
1850
1851// Try to unlink the given file. Log an error if the file exists and could not
1852// be unlinked.
1853static bool unlink_if_exists(const std::string& file) {
1854 if (unlink(file.c_str()) == 0) {
1855 return true;
1856 }
1857 if (errno == ENOENT) {
1858 return true;
1859
1860 }
1861 PLOG(ERROR) << "Could not unlink: " << file;
1862 return false;
1863}
1864
Calin Juravle7d765462017-09-04 15:57:10 -07001865enum ReconcileSecondaryDexResult {
1866 kReconcileSecondaryDexExists = 0,
1867 kReconcileSecondaryDexCleanedUp = 1,
1868 kReconcileSecondaryDexValidationError = 2,
1869 kReconcileSecondaryDexCleanUpError = 3,
1870 kReconcileSecondaryDexAccessIOError = 4,
1871};
Calin Juravlec9eab382017-01-25 01:17:17 -08001872
1873// Reconcile the secondary dex 'dex_path' and its generated oat files.
1874// Return true if all the parameters are valid and the secondary dex file was
1875// processed successfully (i.e. the dex_path either exists, or if not, its corresponding
1876// oat/vdex/art files where deleted successfully). In this case, out_secondary_dex_exists
1877// will be true if the secondary dex file still exists. If the secondary dex file does not exist,
1878// the method cleans up any previously generated compiler artifacts (oat, vdex, art).
1879// Return false if there were errors during processing. In this case
1880// out_secondary_dex_exists will be set to false.
1881bool reconcile_secondary_dex_file(const std::string& dex_path,
1882 const std::string& pkgname, int uid, const std::vector<std::string>& isas,
Jooyung Han9fcc4ef2020-01-23 12:45:10 +09001883 const std::optional<std::string>& volume_uuid, int storage_flag,
Calin Juravlec9eab382017-01-25 01:17:17 -08001884 /*out*/bool* out_secondary_dex_exists) {
Calin Juravle7d765462017-09-04 15:57:10 -07001885 *out_secondary_dex_exists = false; // start by assuming the file does not exist.
Calin Juravlec9eab382017-01-25 01:17:17 -08001886 if (isas.size() == 0) {
1887 LOG(ERROR) << "reconcile_secondary_dex_file called with empty isas vector";
1888 return false;
1889 }
1890
Calin Juravle7d765462017-09-04 15:57:10 -07001891 if (storage_flag != FLAG_STORAGE_CE && storage_flag != FLAG_STORAGE_DE) {
1892 LOG(ERROR) << "reconcile_secondary_dex_file called with invalid storage_flag: "
1893 << storage_flag;
Calin Juravlec9eab382017-01-25 01:17:17 -08001894 return false;
1895 }
1896
Shubham Ajmerae6d7ad52017-08-25 13:07:44 -07001897 // As a security measure we want to unlink art artifacts with the reduced capabilities
1898 // of the package user id. So we fork and drop capabilities in the child.
1899 pid_t pid = fork();
1900 if (pid == 0) {
Calin Juravle7d765462017-09-04 15:57:10 -07001901 /* child -- drop privileges before continuing */
1902 drop_capabilities(uid);
1903
Jooyung Han9fcc4ef2020-01-23 12:45:10 +09001904 const char* volume_uuid_cstr = volume_uuid ? volume_uuid->c_str() : nullptr;
Greg Kaiser8042c372019-03-26 06:23:19 -07001905 if (!validate_secondary_dex_path(pkgname, dex_path, volume_uuid_cstr,
Calin Juravle7d765462017-09-04 15:57:10 -07001906 uid, storage_flag)) {
1907 LOG(ERROR) << "Could not validate secondary dex path " << dex_path;
1908 _exit(kReconcileSecondaryDexValidationError);
1909 }
1910
1911 SecondaryDexAccess access_check = check_secondary_dex_access(dex_path);
1912 switch (access_check) {
1913 case kSecondaryDexAccessDoesNotExist:
1914 // File does not exist. Proceed with cleaning.
1915 break;
1916 case kSecondaryDexAccessReadOk: _exit(kReconcileSecondaryDexExists);
1917 case kSecondaryDexAccessIOError: _exit(kReconcileSecondaryDexAccessIOError);
1918 case kSecondaryDexAccessPermissionError: _exit(kReconcileSecondaryDexValidationError);
1919 default:
1920 LOG(ERROR) << "Unexpected result from check_secondary_dex_access: " << access_check;
1921 _exit(kReconcileSecondaryDexValidationError);
1922 }
1923
1924 // The secondary dex does not exist anymore or it's. Clear any generated files.
Shubham Ajmerae6d7ad52017-08-25 13:07:44 -07001925 char oat_path[PKG_PATH_MAX];
1926 char oat_dir[PKG_PATH_MAX];
1927 char oat_isa_dir[PKG_PATH_MAX];
1928 bool result = true;
Shubham Ajmerae6d7ad52017-08-25 13:07:44 -07001929 for (size_t i = 0; i < isas.size(); i++) {
Andreas Gampe194fe422018-02-28 20:16:19 -08001930 std::string error_msg;
Calin Juravle7d765462017-09-04 15:57:10 -07001931 if (!create_secondary_dex_oat_layout(
Andreas Gampe194fe422018-02-28 20:16:19 -08001932 dex_path,isas[i], oat_dir, oat_isa_dir, oat_path, &error_msg)) {
1933 LOG(ERROR) << error_msg;
Calin Juravle7d765462017-09-04 15:57:10 -07001934 _exit(kReconcileSecondaryDexValidationError);
Shubham Ajmerae6d7ad52017-08-25 13:07:44 -07001935 }
Calin Juravle51314092017-05-18 15:33:05 -07001936
Shubham Ajmerae6d7ad52017-08-25 13:07:44 -07001937 // Delete oat/vdex/art files.
1938 result = unlink_if_exists(oat_path) && result;
1939 result = unlink_if_exists(create_vdex_filename(oat_path)) && result;
1940 result = unlink_if_exists(create_image_filename(oat_path)) && result;
Calin Juravlec9eab382017-01-25 01:17:17 -08001941
Shubham Ajmerae6d7ad52017-08-25 13:07:44 -07001942 // Delete profiles.
1943 std::string current_profile = create_current_profile_path(
Calin Juravle824a64d2018-01-18 20:23:17 -08001944 multiuser_get_user_id(uid), pkgname, dex_path, /*is_secondary*/true);
Shubham Ajmerae6d7ad52017-08-25 13:07:44 -07001945 std::string reference_profile = create_reference_profile_path(
Calin Juravle824a64d2018-01-18 20:23:17 -08001946 pkgname, dex_path, /*is_secondary*/true);
Shubham Ajmerae6d7ad52017-08-25 13:07:44 -07001947 result = unlink_if_exists(current_profile) && result;
1948 result = unlink_if_exists(reference_profile) && result;
Calin Juravle51314092017-05-18 15:33:05 -07001949
Shubham Ajmerae6d7ad52017-08-25 13:07:44 -07001950 // We upgraded once the location of current profile for secondary dex files.
1951 // Check for any previous left-overs and remove them as well.
1952 std::string old_current_profile = dex_path + ".prof";
1953 result = unlink_if_exists(old_current_profile);
Calin Juravle3760ad32017-07-27 16:31:55 -07001954
Shubham Ajmerae6d7ad52017-08-25 13:07:44 -07001955 // Try removing the directories as well, they might be empty.
1956 result = rmdir_if_empty(oat_isa_dir) && result;
1957 result = rmdir_if_empty(oat_dir) && result;
1958 }
Calin Juravle7d765462017-09-04 15:57:10 -07001959 if (!result) {
1960 PLOG(ERROR) << "Failed to clean secondary dex artifacts for location " << dex_path;
1961 }
1962 _exit(result ? kReconcileSecondaryDexCleanedUp : kReconcileSecondaryDexAccessIOError);
Calin Juravlec9eab382017-01-25 01:17:17 -08001963 }
1964
Shubham Ajmerae6d7ad52017-08-25 13:07:44 -07001965 int return_code = wait_child(pid);
Calin Juravle7d765462017-09-04 15:57:10 -07001966 if (!WIFEXITED(return_code)) {
1967 LOG(WARNING) << "reconcile dex failed for location " << dex_path << ": " << return_code;
1968 } else {
1969 return_code = WEXITSTATUS(return_code);
1970 }
1971
1972 LOG(DEBUG) << "Reconcile secondary dex path " << dex_path << " result=" << return_code;
1973
1974 switch (return_code) {
1975 case kReconcileSecondaryDexCleanedUp:
1976 case kReconcileSecondaryDexValidationError:
1977 // If we couldn't validate assume the dex file does not exist.
1978 // This will purge the entry from the PM records.
1979 *out_secondary_dex_exists = false;
1980 return true;
1981 case kReconcileSecondaryDexExists:
1982 *out_secondary_dex_exists = true;
1983 return true;
1984 case kReconcileSecondaryDexAccessIOError:
1985 // We had an access IO error.
1986 // Return false so that we can try again.
1987 // The value of out_secondary_dex_exists does not matter in this case and by convention
1988 // is set to false.
1989 *out_secondary_dex_exists = false;
1990 return false;
1991 default:
1992 LOG(ERROR) << "Unexpected code from reconcile_secondary_dex_file: " << return_code;
1993 *out_secondary_dex_exists = false;
1994 return false;
1995 }
Calin Juravlec9eab382017-01-25 01:17:17 -08001996}
1997
Alan Stokesa25d90c2017-10-16 10:56:00 +01001998// Compute and return the hash (SHA-256) of the secondary dex file at dex_path.
1999// Returns true if all parameters are valid and the hash successfully computed and stored in
2000// out_secondary_dex_hash.
2001// Also returns true with an empty hash if the file does not currently exist or is not accessible to
2002// the app.
2003// For any other errors (e.g. if any of the parameters are invalid) returns false.
2004bool hash_secondary_dex_file(const std::string& dex_path, const std::string& pkgname, int uid,
Jooyung Han9fcc4ef2020-01-23 12:45:10 +09002005 const std::optional<std::string>& volume_uuid, int storage_flag,
Alan Stokesa25d90c2017-10-16 10:56:00 +01002006 std::vector<uint8_t>* out_secondary_dex_hash) {
2007 out_secondary_dex_hash->clear();
2008
Jooyung Han9fcc4ef2020-01-23 12:45:10 +09002009 const char* volume_uuid_cstr = volume_uuid ? volume_uuid->c_str() : nullptr;
Alan Stokesa25d90c2017-10-16 10:56:00 +01002010
2011 if (storage_flag != FLAG_STORAGE_CE && storage_flag != FLAG_STORAGE_DE) {
2012 LOG(ERROR) << "hash_secondary_dex_file called with invalid storage_flag: "
2013 << storage_flag;
2014 return false;
2015 }
2016
2017 // Pipe to get the hash result back from our child process.
2018 unique_fd pipe_read, pipe_write;
2019 if (!Pipe(&pipe_read, &pipe_write)) {
2020 PLOG(ERROR) << "Failed to create pipe";
2021 return false;
2022 }
2023
2024 // Fork so that actual access to the files is done in the app's own UID, to ensure we only
2025 // access data the app itself can access.
2026 pid_t pid = fork();
2027 if (pid == 0) {
2028 // child -- drop privileges before continuing
2029 drop_capabilities(uid);
2030 pipe_read.reset();
2031
2032 if (!validate_secondary_dex_path(pkgname, dex_path, volume_uuid_cstr, uid, storage_flag)) {
2033 LOG(ERROR) << "Could not validate secondary dex path " << dex_path;
Andreas Gampefa2dadd2018-02-28 19:52:47 -08002034 _exit(DexoptReturnCodes::kHashValidatePath);
Alan Stokesa25d90c2017-10-16 10:56:00 +01002035 }
2036
2037 unique_fd fd(TEMP_FAILURE_RETRY(open(dex_path.c_str(), O_RDONLY | O_CLOEXEC | O_NOFOLLOW)));
2038 if (fd == -1) {
2039 if (errno == EACCES || errno == ENOENT) {
2040 // Not treated as an error.
2041 _exit(0);
2042 }
2043 PLOG(ERROR) << "Failed to open secondary dex " << dex_path;
Andreas Gampefa2dadd2018-02-28 19:52:47 -08002044 _exit(DexoptReturnCodes::kHashOpenPath);
Alan Stokesa25d90c2017-10-16 10:56:00 +01002045 }
2046
2047 SHA256_CTX ctx;
2048 SHA256_Init(&ctx);
2049
2050 std::vector<uint8_t> buffer(65536);
2051 while (true) {
2052 ssize_t bytes_read = TEMP_FAILURE_RETRY(read(fd, buffer.data(), buffer.size()));
2053 if (bytes_read == 0) {
2054 break;
2055 } else if (bytes_read == -1) {
2056 PLOG(ERROR) << "Failed to read secondary dex " << dex_path;
Andreas Gampefa2dadd2018-02-28 19:52:47 -08002057 _exit(DexoptReturnCodes::kHashReadDex);
Alan Stokesa25d90c2017-10-16 10:56:00 +01002058 }
2059
2060 SHA256_Update(&ctx, buffer.data(), bytes_read);
2061 }
2062
2063 std::array<uint8_t, SHA256_DIGEST_LENGTH> hash;
2064 SHA256_Final(hash.data(), &ctx);
2065 if (!WriteFully(pipe_write, hash.data(), hash.size())) {
Andreas Gampefa2dadd2018-02-28 19:52:47 -08002066 _exit(DexoptReturnCodes::kHashWrite);
Alan Stokesa25d90c2017-10-16 10:56:00 +01002067 }
2068
2069 _exit(0);
2070 }
2071
2072 // parent
2073 pipe_write.reset();
2074
2075 out_secondary_dex_hash->resize(SHA256_DIGEST_LENGTH);
2076 if (!ReadFully(pipe_read, out_secondary_dex_hash->data(), out_secondary_dex_hash->size())) {
2077 out_secondary_dex_hash->clear();
2078 }
2079 return wait_child(pid) == 0;
2080}
2081
Jeff Sharkey90aff262016-12-12 14:28:24 -07002082// Helper for move_ab, so that we can have common failure-case cleanup.
2083static bool unlink_and_rename(const char* from, const char* to) {
2084 // Check whether "from" exists, and if so whether it's regular. If it is, unlink. Otherwise,
2085 // return a failure.
2086 struct stat s;
2087 if (stat(to, &s) == 0) {
2088 if (!S_ISREG(s.st_mode)) {
2089 LOG(ERROR) << from << " is not a regular file to replace for A/B.";
2090 return false;
2091 }
2092 if (unlink(to) != 0) {
2093 LOG(ERROR) << "Could not unlink " << to << " to move A/B.";
2094 return false;
2095 }
2096 } else {
2097 // This may be a permission problem. We could investigate the error code, but we'll just
2098 // let the rename failure do the work for us.
2099 }
2100
2101 // Try to rename "to" to "from."
2102 if (rename(from, to) != 0) {
2103 PLOG(ERROR) << "Could not rename " << from << " to " << to;
2104 return false;
2105 }
2106 return true;
2107}
2108
2109// Move/rename a B artifact (from) to an A artifact (to).
2110static bool move_ab_path(const std::string& b_path, const std::string& a_path) {
2111 // Check whether B exists.
2112 {
2113 struct stat s;
2114 if (stat(b_path.c_str(), &s) != 0) {
2115 // Silently ignore for now. The service calling this isn't smart enough to understand
2116 // lack of artifacts at the moment.
2117 return false;
2118 }
2119 if (!S_ISREG(s.st_mode)) {
2120 LOG(ERROR) << "A/B artifact " << b_path << " is not a regular file.";
2121 // Try to unlink, but swallow errors.
2122 unlink(b_path.c_str());
2123 return false;
2124 }
2125 }
2126
2127 // Rename B to A.
2128 if (!unlink_and_rename(b_path.c_str(), a_path.c_str())) {
2129 // Delete the b_path so we don't try again (or fail earlier).
2130 if (unlink(b_path.c_str()) != 0) {
2131 PLOG(ERROR) << "Could not unlink " << b_path;
2132 }
2133
2134 return false;
2135 }
2136
2137 return true;
2138}
2139
2140bool move_ab(const char* apk_path, const char* instruction_set, const char* oat_dir) {
2141 // Get the current slot suffix. No suffix, no A/B.
Mathieu Chartier9b2da082018-10-26 13:23:11 -07002142 const std::string slot_suffix = GetProperty("ro.boot.slot_suffix", "");
2143 if (slot_suffix.empty()) {
2144 return false;
2145 }
Jeff Sharkey90aff262016-12-12 14:28:24 -07002146
Mathieu Chartier9b2da082018-10-26 13:23:11 -07002147 if (!ValidateTargetSlotSuffix(slot_suffix)) {
2148 LOG(ERROR) << "Target slot suffix not legal: " << slot_suffix;
2149 return false;
Jeff Sharkey90aff262016-12-12 14:28:24 -07002150 }
2151
2152 // Validate other inputs.
2153 if (validate_apk_path(apk_path) != 0) {
2154 LOG(ERROR) << "Invalid apk_path: " << apk_path;
2155 return false;
2156 }
2157 if (validate_apk_path(oat_dir) != 0) {
2158 LOG(ERROR) << "Invalid oat_dir: " << oat_dir;
2159 return false;
2160 }
2161
2162 char a_path[PKG_PATH_MAX];
2163 if (!calculate_oat_file_path(a_path, oat_dir, apk_path, instruction_set)) {
2164 return false;
2165 }
2166 const std::string a_vdex_path = create_vdex_filename(a_path);
2167 const std::string a_image_path = create_image_filename(a_path);
2168
2169 // B path = A path + slot suffix.
2170 const std::string b_path = StringPrintf("%s.%s", a_path, slot_suffix.c_str());
2171 const std::string b_vdex_path = StringPrintf("%s.%s", a_vdex_path.c_str(), slot_suffix.c_str());
2172 const std::string b_image_path = StringPrintf("%s.%s",
2173 a_image_path.c_str(),
2174 slot_suffix.c_str());
2175
2176 bool success = true;
2177 if (move_ab_path(b_path, a_path)) {
2178 if (move_ab_path(b_vdex_path, a_vdex_path)) {
2179 // Note: we can live without an app image. As such, ignore failure to move the image file.
2180 // If we decide to require the app image, or the app image being moved correctly,
2181 // then change accordingly.
2182 constexpr bool kIgnoreAppImageFailure = true;
2183
2184 if (!a_image_path.empty()) {
2185 if (!move_ab_path(b_image_path, a_image_path)) {
2186 unlink(a_image_path.c_str());
2187 if (!kIgnoreAppImageFailure) {
2188 success = false;
2189 }
2190 }
2191 }
2192 } else {
2193 // Cleanup: delete B image, ignore errors.
2194 unlink(b_image_path.c_str());
2195 success = false;
2196 }
2197 } else {
2198 // Cleanup: delete B image, ignore errors.
2199 unlink(b_vdex_path.c_str());
2200 unlink(b_image_path.c_str());
2201 success = false;
2202 }
2203 return success;
2204}
2205
2206bool delete_odex(const char* apk_path, const char* instruction_set, const char* oat_dir) {
2207 // Delete the oat/odex file.
2208 char out_path[PKG_PATH_MAX];
Calin Juravle80a21252017-01-17 14:43:25 -08002209 if (!create_oat_out_path(apk_path, instruction_set, oat_dir,
Calin Juravle114f0812017-03-08 19:05:07 -08002210 /*is_secondary_dex*/false, out_path)) {
Jeff Sharkey90aff262016-12-12 14:28:24 -07002211 return false;
2212 }
2213
2214 // In case of a permission failure report the issue. Otherwise just print a warning.
2215 auto unlink_and_check = [](const char* path) -> bool {
2216 int result = unlink(path);
2217 if (result != 0) {
2218 if (errno == EACCES || errno == EPERM) {
2219 PLOG(ERROR) << "Could not unlink " << path;
2220 return false;
2221 }
2222 PLOG(WARNING) << "Could not unlink " << path;
2223 }
2224 return true;
2225 };
2226
2227 // Delete the oat/odex file.
2228 bool return_value_oat = unlink_and_check(out_path);
2229
2230 // Derive and delete the app image.
2231 bool return_value_art = unlink_and_check(create_image_filename(out_path).c_str());
2232
Nicolas Geoffray192fb962017-05-25 13:58:06 +01002233 // Derive and delete the vdex file.
2234 bool return_value_vdex = unlink_and_check(create_vdex_filename(out_path).c_str());
2235
Jeff Sharkey90aff262016-12-12 14:28:24 -07002236 // Report success.
Nicolas Geoffray192fb962017-05-25 13:58:06 +01002237 return return_value_oat && return_value_art && return_value_vdex;
Jeff Sharkey90aff262016-12-12 14:28:24 -07002238}
2239
Jeff Sharkeyc1149c92017-09-21 14:51:09 -06002240static bool is_absolute_path(const std::string& path) {
2241 if (path.find('/') != 0 || path.find("..") != std::string::npos) {
2242 LOG(ERROR) << "Invalid absolute path " << path;
2243 return false;
2244 } else {
2245 return true;
2246 }
2247}
2248
2249static bool is_valid_instruction_set(const std::string& instruction_set) {
2250 // TODO: add explicit whitelisting of instruction sets
2251 if (instruction_set.find('/') != std::string::npos) {
2252 LOG(ERROR) << "Invalid instruction set " << instruction_set;
2253 return false;
2254 } else {
2255 return true;
2256 }
2257}
2258
2259bool calculate_oat_file_path_default(char path[PKG_PATH_MAX], const char *oat_dir,
2260 const char *apk_path, const char *instruction_set) {
2261 std::string oat_dir_ = oat_dir;
2262 std::string apk_path_ = apk_path;
2263 std::string instruction_set_ = instruction_set;
2264
2265 if (!is_absolute_path(oat_dir_)) return false;
2266 if (!is_absolute_path(apk_path_)) return false;
2267 if (!is_valid_instruction_set(instruction_set_)) return false;
2268
2269 std::string::size_type end = apk_path_.rfind('.');
2270 std::string::size_type start = apk_path_.rfind('/', end);
2271 if (end == std::string::npos || start == std::string::npos) {
2272 LOG(ERROR) << "Invalid apk_path " << apk_path_;
2273 return false;
2274 }
2275
2276 std::string res_ = oat_dir_ + '/' + instruction_set + '/'
2277 + apk_path_.substr(start + 1, end - start - 1) + ".odex";
2278 const char* res = res_.c_str();
2279 if (strlen(res) >= PKG_PATH_MAX) {
2280 LOG(ERROR) << "Result too large";
2281 return false;
2282 } else {
2283 strlcpy(path, res, PKG_PATH_MAX);
2284 return true;
2285 }
2286}
2287
2288bool calculate_odex_file_path_default(char path[PKG_PATH_MAX], const char *apk_path,
2289 const char *instruction_set) {
2290 std::string apk_path_ = apk_path;
2291 std::string instruction_set_ = instruction_set;
2292
2293 if (!is_absolute_path(apk_path_)) return false;
2294 if (!is_valid_instruction_set(instruction_set_)) return false;
2295
2296 std::string::size_type end = apk_path_.rfind('.');
2297 std::string::size_type start = apk_path_.rfind('/', end);
2298 if (end == std::string::npos || start == std::string::npos) {
2299 LOG(ERROR) << "Invalid apk_path " << apk_path_;
2300 return false;
2301 }
2302
2303 std::string oat_dir = apk_path_.substr(0, start + 1) + "oat";
2304 return calculate_oat_file_path_default(path, oat_dir.c_str(), apk_path, instruction_set);
2305}
2306
2307bool create_cache_path_default(char path[PKG_PATH_MAX], const char *src,
2308 const char *instruction_set) {
2309 std::string src_ = src;
2310 std::string instruction_set_ = instruction_set;
2311
2312 if (!is_absolute_path(src_)) return false;
2313 if (!is_valid_instruction_set(instruction_set_)) return false;
2314
2315 for (auto it = src_.begin() + 1; it < src_.end(); ++it) {
2316 if (*it == '/') {
2317 *it = '@';
2318 }
2319 }
2320
2321 std::string res_ = android_data_dir + DALVIK_CACHE + '/' + instruction_set_ + src_
2322 + DALVIK_CACHE_POSTFIX;
2323 const char* res = res_.c_str();
2324 if (strlen(res) >= PKG_PATH_MAX) {
2325 LOG(ERROR) << "Result too large";
2326 return false;
2327 } else {
2328 strlcpy(path, res, PKG_PATH_MAX);
2329 return true;
2330 }
2331}
2332
Calin Juravle59f7ab82018-04-27 17:50:23 -07002333bool open_classpath_files(const std::string& classpath, std::vector<unique_fd>* apk_fds,
2334 std::vector<std::string>* dex_locations) {
Calin Juravle0d0a4922018-01-23 19:54:11 -08002335 std::vector<std::string> classpaths_elems = base::Split(classpath, ":");
2336 for (const std::string& elem : classpaths_elems) {
2337 unique_fd fd(TEMP_FAILURE_RETRY(open(elem.c_str(), O_RDONLY)));
2338 if (fd < 0) {
2339 PLOG(ERROR) << "Could not open classpath elem " << elem;
2340 return false;
2341 } else {
2342 apk_fds->push_back(std::move(fd));
Calin Juravle59f7ab82018-04-27 17:50:23 -07002343 dex_locations->push_back(elem);
Calin Juravle0d0a4922018-01-23 19:54:11 -08002344 }
2345 }
2346 return true;
2347}
2348
2349static bool create_app_profile_snapshot(int32_t app_id,
2350 const std::string& package_name,
2351 const std::string& profile_name,
2352 const std::string& classpath) {
Calin Juravle29591732017-11-20 17:46:19 -08002353 int app_shared_gid = multiuser_get_shared_gid(/*user_id*/ 0, app_id);
2354
Calin Juravle824a64d2018-01-18 20:23:17 -08002355 unique_fd snapshot_fd = open_spnashot_profile(AID_SYSTEM, package_name, profile_name);
Calin Juravle29591732017-11-20 17:46:19 -08002356 if (snapshot_fd < 0) {
2357 return false;
2358 }
2359
2360 std::vector<unique_fd> profiles_fd;
2361 unique_fd reference_profile_fd;
Calin Juravle824a64d2018-01-18 20:23:17 -08002362 open_profile_files(app_shared_gid, package_name, profile_name, /*is_secondary_dex*/ false,
2363 &profiles_fd, &reference_profile_fd);
Calin Juravle29591732017-11-20 17:46:19 -08002364 if (profiles_fd.empty() || (reference_profile_fd.get() < 0)) {
2365 return false;
2366 }
2367
2368 profiles_fd.push_back(std::move(reference_profile_fd));
2369
Calin Juravle0d0a4922018-01-23 19:54:11 -08002370 // Open the class paths elements. These will be used to filter out profile data that does
2371 // not belong to the classpath during merge.
2372 std::vector<unique_fd> apk_fds;
Calin Juravle59f7ab82018-04-27 17:50:23 -07002373 std::vector<std::string> dex_locations;
2374 if (!open_classpath_files(classpath, &apk_fds, &dex_locations)) {
Calin Juravle0d0a4922018-01-23 19:54:11 -08002375 return false;
2376 }
2377
Mathieu Chartiercc66c442018-11-09 15:57:21 -08002378 RunProfman args;
Calin Juravlef85ddb92020-05-01 14:05:40 -07002379 // This is specifically a snapshot for an app, so don't use boot image profiles.
2380 args.SetupMerge(profiles_fd,
2381 snapshot_fd,
2382 apk_fds,
2383 dex_locations,
2384 /* for_snapshot= */ true,
2385 /* for_boot_image= */ false);
Calin Juravle29591732017-11-20 17:46:19 -08002386 pid_t pid = fork();
2387 if (pid == 0) {
2388 /* child -- drop privileges before continuing */
2389 drop_capabilities(app_shared_gid);
Mathieu Chartiercc66c442018-11-09 15:57:21 -08002390 args.Exec();
Calin Juravle29591732017-11-20 17:46:19 -08002391 }
2392
2393 /* parent */
2394 int return_code = wait_child(pid);
2395 if (!WIFEXITED(return_code)) {
Calin Juravle824a64d2018-01-18 20:23:17 -08002396 LOG(WARNING) << "profman failed for " << package_name << ":" << profile_name;
Calin Juravle29591732017-11-20 17:46:19 -08002397 return false;
2398 }
2399
Calin Juravle78728f32019-11-08 17:55:46 -08002400 // Verify that profman finished successfully.
2401 int profman_code = WEXITSTATUS(return_code);
2402 if (profman_code != PROFMAN_BIN_RETURN_CODE_SUCCESS) {
2403 LOG(WARNING) << "profman error for " << package_name << ":" << profile_name
2404 << ":" << profman_code;
2405 return false;
2406 }
Calin Juravle29591732017-11-20 17:46:19 -08002407 return true;
2408}
2409
Calin Juravle0d0a4922018-01-23 19:54:11 -08002410static bool create_boot_image_profile_snapshot(const std::string& package_name,
2411 const std::string& profile_name,
2412 const std::string& classpath) {
2413 // The reference profile directory for the android package might not be prepared. Do it now.
2414 const std::string ref_profile_dir =
2415 create_primary_reference_profile_package_dir_path(package_name);
2416 if (fs_prepare_dir(ref_profile_dir.c_str(), 0770, AID_SYSTEM, AID_SYSTEM) != 0) {
2417 PLOG(ERROR) << "Failed to prepare " << ref_profile_dir;
2418 return false;
2419 }
2420
Mathieu Chartiere0d64a12018-11-01 12:07:26 -07002421 // Return false for empty class path since it may otherwise return true below if profiles is
2422 // empty.
2423 if (classpath.empty()) {
2424 PLOG(ERROR) << "Class path is empty";
2425 return false;
2426 }
2427
Calin Juravle0d0a4922018-01-23 19:54:11 -08002428 // Open and create the snapshot profile.
2429 unique_fd snapshot_fd = open_spnashot_profile(AID_SYSTEM, package_name, profile_name);
2430
2431 // Collect all non empty profiles.
2432 // The collection will traverse all applications profiles and find the non empty files.
2433 // This has the potential of inspecting a large number of files and directories (depending
2434 // on the number of applications and users). So there is a slight increase in the chance
2435 // to get get occasionally I/O errors (e.g. for opening the file). When that happens do not
2436 // fail the snapshot and aggregate whatever profile we could open.
2437 //
2438 // The profile snapshot is a best effort based on available data it's ok if some data
2439 // from some apps is missing. It will be counter productive for the snapshot to fail
2440 // because we could not open or read some of the files.
2441 std::vector<std::string> profiles;
2442 if (!collect_profiles(&profiles)) {
2443 LOG(WARNING) << "There were errors while collecting the profiles for the boot image.";
2444 }
2445
2446 // If we have no profiles return early.
2447 if (profiles.empty()) {
2448 return true;
2449 }
2450
2451 // Open the classpath elements. These will be used to filter out profile data that does
2452 // not belong to the classpath during merge.
2453 std::vector<unique_fd> apk_fds;
Calin Juravle59f7ab82018-04-27 17:50:23 -07002454 std::vector<std::string> dex_locations;
2455 if (!open_classpath_files(classpath, &apk_fds, &dex_locations)) {
Calin Juravle0d0a4922018-01-23 19:54:11 -08002456 return false;
2457 }
2458
2459 // If we could not open any files from the classpath return an error.
2460 if (apk_fds.empty()) {
2461 LOG(ERROR) << "Could not open any of the classpath elements.";
2462 return false;
2463 }
2464
2465 // Aggregate the profiles in batches of kAggregationBatchSize.
2466 // We do this to avoid opening a huge a amount of files.
2467 static constexpr size_t kAggregationBatchSize = 10;
2468
Calin Juravle0d0a4922018-01-23 19:54:11 -08002469 for (size_t i = 0; i < profiles.size(); ) {
Calin Juravlea64fb512019-11-06 16:11:14 -08002470 std::vector<unique_fd> profiles_fd;
Calin Juravle0d0a4922018-01-23 19:54:11 -08002471 for (size_t k = 0; k < kAggregationBatchSize && i < profiles.size(); k++, i++) {
2472 unique_fd fd = open_profile(AID_SYSTEM, profiles[i], O_RDONLY);
2473 if (fd.get() >= 0) {
2474 profiles_fd.push_back(std::move(fd));
2475 }
2476 }
Calin Juravlea64fb512019-11-06 16:11:14 -08002477
2478 // We aggregate (read & write) into the same fd multiple times in a row.
2479 // We need to reset the cursor every time to ensure we read the whole file every time.
2480 if (TEMP_FAILURE_RETRY(lseek(snapshot_fd, 0, SEEK_SET)) == static_cast<off_t>(-1)) {
2481 PLOG(ERROR) << "Cannot reset position for snapshot profile";
2482 return false;
2483 }
2484
Mathieu Chartiercc66c442018-11-09 15:57:21 -08002485 RunProfman args;
Calin Juravleb3a929d2018-12-11 14:40:00 -08002486 args.SetupMerge(profiles_fd,
2487 snapshot_fd,
2488 apk_fds,
Calin Juravle78728f32019-11-08 17:55:46 -08002489 dex_locations,
2490 /*for_snapshot=*/true,
2491 /*for_boot_image=*/true);
Calin Juravle0d0a4922018-01-23 19:54:11 -08002492 pid_t pid = fork();
2493 if (pid == 0) {
2494 /* child -- drop privileges before continuing */
2495 drop_capabilities(AID_SYSTEM);
2496
Calin Juravle59f7ab82018-04-27 17:50:23 -07002497 // The introduction of new access flags into boot jars causes them to
2498 // fail dex file verification.
Mathieu Chartiercc66c442018-11-09 15:57:21 -08002499 args.Exec();
Calin Juravle0d0a4922018-01-23 19:54:11 -08002500 }
2501
2502 /* parent */
2503 int return_code = wait_child(pid);
Calin Juravlea64fb512019-11-06 16:11:14 -08002504
Calin Juravle0d0a4922018-01-23 19:54:11 -08002505 if (!WIFEXITED(return_code)) {
2506 PLOG(WARNING) << "profman failed for " << package_name << ":" << profile_name;
2507 return false;
2508 }
Calin Juravlea64fb512019-11-06 16:11:14 -08002509
2510 // Verify that profman finished successfully.
2511 int profman_code = WEXITSTATUS(return_code);
Calin Juravle78728f32019-11-08 17:55:46 -08002512 if (profman_code != PROFMAN_BIN_RETURN_CODE_SUCCESS) {
2513 LOG(WARNING) << "profman error for " << package_name << ":" << profile_name
2514 << ":" << profman_code;
2515 return false;
Calin Juravlea64fb512019-11-06 16:11:14 -08002516 }
Calin Juravle0d0a4922018-01-23 19:54:11 -08002517 }
Calin Juravlea64fb512019-11-06 16:11:14 -08002518
Calin Juravle0d0a4922018-01-23 19:54:11 -08002519 return true;
2520}
2521
2522bool create_profile_snapshot(int32_t app_id, const std::string& package_name,
2523 const std::string& profile_name, const std::string& classpath) {
2524 if (app_id == -1) {
2525 return create_boot_image_profile_snapshot(package_name, profile_name, classpath);
2526 } else {
2527 return create_app_profile_snapshot(app_id, package_name, profile_name, classpath);
2528 }
2529}
2530
Calin Juravlec3b049e2018-01-18 22:32:58 -08002531bool prepare_app_profile(const std::string& package_name,
2532 userid_t user_id,
2533 appid_t app_id,
2534 const std::string& profile_name,
Calin Juravlef63d4792018-01-30 17:43:34 +00002535 const std::string& code_path,
Jooyung Han9fcc4ef2020-01-23 12:45:10 +09002536 const std::optional<std::string>& dex_metadata) {
Calin Juravlec3b049e2018-01-18 22:32:58 -08002537 // Prepare the current profile.
2538 std::string cur_profile = create_current_profile_path(user_id, package_name, profile_name,
2539 /*is_secondary_dex*/ false);
2540 uid_t uid = multiuser_get_uid(user_id, app_id);
2541 if (fs_prepare_file_strict(cur_profile.c_str(), 0600, uid, uid) != 0) {
2542 PLOG(ERROR) << "Failed to prepare " << cur_profile;
2543 return false;
2544 }
2545
2546 // Check if we need to install the profile from the dex metadata.
Jooyung Han9fcc4ef2020-01-23 12:45:10 +09002547 if (!dex_metadata) {
Calin Juravlec3b049e2018-01-18 22:32:58 -08002548 return true;
2549 }
2550
2551 // We have a dex metdata. Merge the profile into the reference profile.
2552 unique_fd ref_profile_fd = open_reference_profile(uid, package_name, profile_name,
2553 /*read_write*/ true, /*is_secondary_dex*/ false);
2554 unique_fd dex_metadata_fd(TEMP_FAILURE_RETRY(
2555 open(dex_metadata->c_str(), O_RDONLY | O_NOFOLLOW)));
Calin Juravlef63d4792018-01-30 17:43:34 +00002556 unique_fd apk_fd(TEMP_FAILURE_RETRY(open(code_path.c_str(), O_RDONLY | O_NOFOLLOW)));
2557 if (apk_fd < 0) {
2558 PLOG(ERROR) << "Could not open code path " << code_path;
2559 return false;
2560 }
Calin Juravlec3b049e2018-01-18 22:32:58 -08002561
Mathieu Chartiercc66c442018-11-09 15:57:21 -08002562 RunProfman args;
2563 args.SetupCopyAndUpdate(std::move(dex_metadata_fd),
2564 std::move(ref_profile_fd),
2565 std::move(apk_fd),
2566 code_path);
Calin Juravlec3b049e2018-01-18 22:32:58 -08002567 pid_t pid = fork();
2568 if (pid == 0) {
2569 /* child -- drop privileges before continuing */
2570 gid_t app_shared_gid = multiuser_get_shared_gid(user_id, app_id);
2571 drop_capabilities(app_shared_gid);
2572
Calin Juravlef63d4792018-01-30 17:43:34 +00002573 // The copy and update takes ownership over the fds.
Mathieu Chartiercc66c442018-11-09 15:57:21 -08002574 args.Exec();
Calin Juravlec3b049e2018-01-18 22:32:58 -08002575 }
2576
2577 /* parent */
2578 int return_code = wait_child(pid);
2579 if (!WIFEXITED(return_code)) {
2580 PLOG(WARNING) << "profman failed for " << package_name << ":" << profile_name;
2581 return false;
2582 }
2583 return true;
2584}
2585
Jeff Sharkey6c2c0562016-12-07 12:12:00 -07002586} // namespace installd
2587} // namespace android