blob: 83db4433c477cbe9eba461804d39475616ffad07 [file] [log] [blame]
Colin Cross72bb3632017-07-13 16:23:21 -07001// Copyright 2017 Google Inc. All rights reserved.
2//
3// Licensed under the Apache License, Version 2.0 (the "License");
4// you may not use this file except in compliance with the License.
5// You may obtain a copy of the License at
6//
7// http://www.apache.org/licenses/LICENSE-2.0
8//
9// Unless required by applicable law or agreed to in writing, software
10// distributed under the License is distributed on an "AS IS" BASIS,
11// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
12// See the License for the specific language governing permissions and
13// limitations under the License.
14
15package java
16
17import (
Paul Duffin1a393322020-11-18 16:36:47 +000018 "fmt"
Colin Cross72bb3632017-07-13 16:23:21 -070019 "io/ioutil"
20 "os"
21 "path/filepath"
Colin Crossc0806172019-06-14 18:51:47 -070022 "reflect"
Paul Duffindaaa3322020-05-26 18:13:57 +010023 "regexp"
Nan Zhang61eaedb2017-11-02 13:28:15 -070024 "strconv"
Colin Cross72bb3632017-07-13 16:23:21 -070025 "strings"
26 "testing"
Colin Cross86a60ae2018-05-29 14:44:55 -070027
Jeongik Cha28df2572019-11-11 10:46:36 +090028 "github.com/google/blueprint/proptools"
29
Colin Crossa4f08812018-10-02 22:03:40 -070030 "android/soong/android"
31 "android/soong/cc"
Colin Crossc28bb0b2019-02-25 14:20:47 -080032 "android/soong/dexpreopt"
Liz Kammerdd849a82020-06-12 16:38:45 -070033 "android/soong/python"
Colin Cross72bb3632017-07-13 16:23:21 -070034)
35
36var buildDir string
37
38func setUp() {
39 var err error
40 buildDir, err = ioutil.TempDir("", "soong_java_test")
41 if err != nil {
42 panic(err)
43 }
44}
45
46func tearDown() {
47 os.RemoveAll(buildDir)
48}
49
50func TestMain(m *testing.M) {
51 run := func() int {
52 setUp()
53 defer tearDown()
54
55 return m.Run()
56 }
57
58 os.Exit(run())
59}
Colin Cross527012a2017-11-30 22:56:16 -080060
Colin Cross98be1bb2019-12-13 20:41:13 -080061func testConfig(env map[string]string, bp string, fs map[string][]byte) android.Config {
Martin Stjernholmd90676f2020-01-11 00:37:30 +000062 bp += dexpreopt.BpToolModulesForTest()
63
Martin Stjernholm75a48d82020-01-10 20:32:59 +000064 config := TestConfig(buildDir, env, bp, fs)
65
66 // Set up the global Once cache used for dexpreopt.GlobalSoongConfig, so that
67 // it doesn't create a real one, which would fail.
68 _ = dexpreopt.GlobalSoongConfigForTests(config)
69
70 return config
Colin Cross1369cdb2017-09-29 17:58:17 -070071}
72
Colin Crossae8600b2020-10-29 17:09:13 -070073func testContext(config android.Config) *android.TestContext {
Colin Cross72bb3632017-07-13 16:23:21 -070074
Colin Crossae8600b2020-10-29 17:09:13 -070075 ctx := android.NewTestArchContext(config)
Paul Duffinf9b1da02019-12-18 19:51:55 +000076 RegisterJavaBuildComponents(ctx)
77 RegisterAppBuildComponents(ctx)
78 RegisterAARBuildComponents(ctx)
Paul Duffinb0f85072019-12-19 10:28:56 +000079 RegisterGenRuleBuildComponents(ctx)
Paul Duffin43dc1cc2019-12-19 11:18:54 +000080 RegisterSystemModulesBuildComponents(ctx)
Colin Cross4b49b762019-11-22 15:25:03 -080081 ctx.RegisterModuleType("java_plugin", PluginFactory)
Colin Cross4b49b762019-11-22 15:25:03 -080082 ctx.RegisterModuleType("filegroup", android.FileGroupFactory)
Liz Kammerdd849a82020-06-12 16:38:45 -070083 ctx.RegisterModuleType("python_binary_host", python.PythonBinaryHostFactory)
Paul Duffin884363e2019-12-19 10:21:09 +000084 RegisterDocsBuildComponents(ctx)
85 RegisterStubsBuildComponents(ctx)
Paul Duffin43dc1cc2019-12-19 11:18:54 +000086 RegisterSdkLibraryBuildComponents(ctx)
Colin Cross89536d42017-07-07 14:35:50 -070087 ctx.PreArchMutators(android.RegisterDefaultsPreArchMutators)
Paul Duffin44f1d842020-06-26 20:17:02 +010088 ctx.PreArchMutators(android.RegisterComponentsMutator)
Paul Duffina48f7582019-12-19 11:25:19 +000089
90 RegisterPrebuiltApisBuildComponents(ctx)
91
Liz Kammerdd849a82020-06-12 16:38:45 -070092 ctx.PreDepsMutators(python.RegisterPythonPreDepsMutators)
Jaewoong Jungb639a6a2019-05-10 15:16:29 -070093 ctx.PostDepsMutators(android.RegisterOverridePostDepsMutators)
Colin Cross06fa5882020-10-29 18:21:38 -070094 ctx.RegisterPreSingletonType("overlay", android.SingletonFactoryAdaptor(ctx.Context, OverlaySingletonFactory))
95 ctx.RegisterPreSingletonType("sdk_versions", android.SingletonFactoryAdaptor(ctx.Context, sdkPreSingletonFactory))
Colin Crossa4f08812018-10-02 22:03:40 -070096
Paul Duffin021f4e52020-07-30 16:04:17 +010097 android.RegisterPrebuiltMutators(ctx)
98
Colin Crossa4f08812018-10-02 22:03:40 -070099 // Register module types and mutators from cc needed for JNI testing
Paul Duffin77980a82019-12-19 16:01:36 +0000100 cc.RegisterRequiredBuildComponentsForTest(ctx)
Colin Crossa4f08812018-10-02 22:03:40 -0700101
Martin Stjernholmd90676f2020-01-11 00:37:30 +0000102 dexpreopt.RegisterToolModulesForTest(ctx)
103
Jaewoong Jungc779cd42020-10-06 18:56:10 -0700104 ctx.PostDepsMutators(func(ctx android.RegisterMutatorsContext) {
105 ctx.TopDown("propagate_rro_enforcement", propagateRROEnforcementMutator).Parallel()
106 })
107
Colin Cross527012a2017-11-30 22:56:16 -0800108 return ctx
109}
110
111func run(t *testing.T, ctx *android.TestContext, config android.Config) {
Colin Cross6b4a32d2017-12-05 13:42:45 -0800112 t.Helper()
Colin Crossc28bb0b2019-02-25 14:20:47 -0800113
Colin Cross98be1bb2019-12-13 20:41:13 -0800114 pathCtx := android.PathContextForTesting(config)
Martin Stjernholm40f9f3c2020-01-20 18:12:23 +0000115 dexpreopt.SetTestGlobalConfig(config, dexpreopt.GlobalConfigForTests(pathCtx))
Colin Crossc28bb0b2019-02-25 14:20:47 -0800116
Colin Crossae8600b2020-10-29 17:09:13 -0700117 ctx.Register()
Paul Duffinbaccf7e2019-06-11 11:58:30 +0100118 _, errs := ctx.ParseBlueprintsFiles("Android.bp")
Logan Chien42039712018-03-12 16:29:17 +0800119 android.FailIfErrored(t, errs)
Colin Cross72bb3632017-07-13 16:23:21 -0700120 _, errs = ctx.PrepareBuildActions(config)
Logan Chien42039712018-03-12 16:29:17 +0800121 android.FailIfErrored(t, errs)
Colin Cross527012a2017-11-30 22:56:16 -0800122}
123
Jeongik Cha2cc570d2019-10-29 15:44:45 +0900124func testJavaError(t *testing.T, pattern string, bp string) (*android.TestContext, android.Config) {
Jeongik Cha538c0d02019-07-11 15:54:27 +0900125 t.Helper()
Colin Cross98be1bb2019-12-13 20:41:13 -0800126 return testJavaErrorWithConfig(t, pattern, testConfig(nil, bp, nil))
Jeongik Cha2cc570d2019-10-29 15:44:45 +0900127}
128
Colin Cross98be1bb2019-12-13 20:41:13 -0800129func testJavaErrorWithConfig(t *testing.T, pattern string, config android.Config) (*android.TestContext, android.Config) {
Jeongik Cha2cc570d2019-10-29 15:44:45 +0900130 t.Helper()
Colin Crossae8600b2020-10-29 17:09:13 -0700131 ctx := testContext(config)
Jeongik Cha538c0d02019-07-11 15:54:27 +0900132
Colin Cross98be1bb2019-12-13 20:41:13 -0800133 pathCtx := android.PathContextForTesting(config)
Martin Stjernholm40f9f3c2020-01-20 18:12:23 +0000134 dexpreopt.SetTestGlobalConfig(config, dexpreopt.GlobalConfigForTests(pathCtx))
Jeongik Cha538c0d02019-07-11 15:54:27 +0900135
Colin Crossae8600b2020-10-29 17:09:13 -0700136 ctx.Register()
Jeongik Cha538c0d02019-07-11 15:54:27 +0900137 _, errs := ctx.ParseBlueprintsFiles("Android.bp")
138 if len(errs) > 0 {
139 android.FailIfNoMatchingErrors(t, pattern, errs)
Jeongik Cha2cc570d2019-10-29 15:44:45 +0900140 return ctx, config
Jeongik Cha538c0d02019-07-11 15:54:27 +0900141 }
142 _, errs = ctx.PrepareBuildActions(config)
143 if len(errs) > 0 {
144 android.FailIfNoMatchingErrors(t, pattern, errs)
Jeongik Cha2cc570d2019-10-29 15:44:45 +0900145 return ctx, config
Jeongik Cha538c0d02019-07-11 15:54:27 +0900146 }
147
148 t.Fatalf("missing expected error %q (0 errors are returned)", pattern)
Jeongik Cha2cc570d2019-10-29 15:44:45 +0900149
150 return ctx, config
Jeongik Cha538c0d02019-07-11 15:54:27 +0900151}
152
Colin Cross238c1f32020-06-07 16:58:18 -0700153func testJavaWithFS(t *testing.T, bp string, fs map[string][]byte) (*android.TestContext, android.Config) {
154 t.Helper()
155 return testJavaWithConfig(t, testConfig(nil, bp, fs))
156}
157
Jaewoong Jungf9a04432019-07-17 11:15:09 -0700158func testJava(t *testing.T, bp string) (*android.TestContext, android.Config) {
Colin Cross6b4a32d2017-12-05 13:42:45 -0800159 t.Helper()
Colin Cross238c1f32020-06-07 16:58:18 -0700160 return testJavaWithFS(t, bp, nil)
Jeongik Cha2cc570d2019-10-29 15:44:45 +0900161}
162
Colin Cross98be1bb2019-12-13 20:41:13 -0800163func testJavaWithConfig(t *testing.T, config android.Config) (*android.TestContext, android.Config) {
Jeongik Cha2cc570d2019-10-29 15:44:45 +0900164 t.Helper()
Colin Crossae8600b2020-10-29 17:09:13 -0700165 ctx := testContext(config)
Colin Cross527012a2017-11-30 22:56:16 -0800166 run(t, ctx, config)
Colin Cross72bb3632017-07-13 16:23:21 -0700167
Jaewoong Jungf9a04432019-07-17 11:15:09 -0700168 return ctx, config
Colin Cross72bb3632017-07-13 16:23:21 -0700169}
170
Colin Cross2acdae82017-09-15 19:44:24 -0700171func moduleToPath(name string) string {
172 switch {
173 case name == `""`:
174 return name
Colin Crossfc3674a2017-09-18 17:41:52 -0700175 case strings.HasSuffix(name, ".jar"):
176 return name
Nan Zhanged19fc32017-10-19 13:06:22 -0700177 default:
178 return filepath.Join(buildDir, ".intermediates", name, "android_common", "turbine-combined", name+".jar")
Colin Cross2acdae82017-09-15 19:44:24 -0700179 }
180}
181
Jeongik Chae403e9e2019-12-07 00:16:24 +0900182func TestJavaLinkType(t *testing.T) {
183 testJava(t, `
184 java_library {
185 name: "foo",
186 srcs: ["a.java"],
187 libs: ["bar"],
188 static_libs: ["baz"],
189 }
190
191 java_library {
192 name: "bar",
193 sdk_version: "current",
194 srcs: ["b.java"],
195 }
196
197 java_library {
198 name: "baz",
199 sdk_version: "system_current",
200 srcs: ["c.java"],
201 }
202 `)
203
Steven Moreland00298982020-11-17 21:44:36 +0000204 testJavaError(t, "consider adjusting sdk_version: OR platform_apis:", `
Jeongik Chae403e9e2019-12-07 00:16:24 +0900205 java_library {
206 name: "foo",
207 srcs: ["a.java"],
208 libs: ["bar"],
209 sdk_version: "current",
210 static_libs: ["baz"],
211 }
212
213 java_library {
214 name: "bar",
215 sdk_version: "current",
216 srcs: ["b.java"],
217 }
218
219 java_library {
220 name: "baz",
221 sdk_version: "system_current",
222 srcs: ["c.java"],
223 }
224 `)
225
226 testJava(t, `
227 java_library {
228 name: "foo",
229 srcs: ["a.java"],
230 libs: ["bar"],
231 sdk_version: "system_current",
232 static_libs: ["baz"],
233 }
234
235 java_library {
236 name: "bar",
237 sdk_version: "current",
238 srcs: ["b.java"],
239 }
240
241 java_library {
242 name: "baz",
243 sdk_version: "system_current",
244 srcs: ["c.java"],
245 }
246 `)
247
Steven Moreland00298982020-11-17 21:44:36 +0000248 testJavaError(t, "consider adjusting sdk_version: OR platform_apis:", `
Jeongik Chae403e9e2019-12-07 00:16:24 +0900249 java_library {
250 name: "foo",
251 srcs: ["a.java"],
252 libs: ["bar"],
253 sdk_version: "system_current",
254 static_libs: ["baz"],
255 }
256
257 java_library {
258 name: "bar",
259 sdk_version: "current",
260 srcs: ["b.java"],
261 }
262
263 java_library {
264 name: "baz",
265 srcs: ["c.java"],
266 }
267 `)
268}
269
Colin Cross72bb3632017-07-13 16:23:21 -0700270func TestSimple(t *testing.T) {
Jaewoong Jungf9a04432019-07-17 11:15:09 -0700271 ctx, _ := testJava(t, `
Colin Cross72bb3632017-07-13 16:23:21 -0700272 java_library {
273 name: "foo",
274 srcs: ["a.java"],
Colin Crosse8dc34a2017-07-19 11:22:16 -0700275 libs: ["bar"],
276 static_libs: ["baz"],
Colin Cross72bb3632017-07-13 16:23:21 -0700277 }
278
279 java_library {
280 name: "bar",
281 srcs: ["b.java"],
282 }
283
284 java_library {
285 name: "baz",
286 srcs: ["c.java"],
287 }
Colin Crossd5934c82017-10-02 13:55:26 -0700288 `)
Colin Cross72bb3632017-07-13 16:23:21 -0700289
Colin Cross4c428df2017-09-15 17:36:05 -0700290 javac := ctx.ModuleForTests("foo", "android_common").Rule("javac")
Nan Zhanged19fc32017-10-19 13:06:22 -0700291 combineJar := ctx.ModuleForTests("foo", "android_common").Description("for javac")
Colin Cross72bb3632017-07-13 16:23:21 -0700292
293 if len(javac.Inputs) != 1 || javac.Inputs[0].String() != "a.java" {
294 t.Errorf(`foo inputs %v != ["a.java"]`, javac.Inputs)
295 }
296
Colin Cross1ee23172017-10-18 14:44:18 -0700297 baz := ctx.ModuleForTests("baz", "android_common").Rule("javac").Output.String()
Nan Zhanged19fc32017-10-19 13:06:22 -0700298 barTurbine := filepath.Join(buildDir, ".intermediates", "bar", "android_common", "turbine-combined", "bar.jar")
299 bazTurbine := filepath.Join(buildDir, ".intermediates", "baz", "android_common", "turbine-combined", "baz.jar")
Colin Cross0a6e0072017-08-30 14:24:55 -0700300
Nan Zhanged19fc32017-10-19 13:06:22 -0700301 if !strings.Contains(javac.Args["classpath"], barTurbine) {
302 t.Errorf("foo classpath %v does not contain %q", javac.Args["classpath"], barTurbine)
Colin Cross72bb3632017-07-13 16:23:21 -0700303 }
304
Nan Zhanged19fc32017-10-19 13:06:22 -0700305 if !strings.Contains(javac.Args["classpath"], bazTurbine) {
306 t.Errorf("foo classpath %v does not contain %q", javac.Args["classpath"], bazTurbine)
Colin Cross0a6e0072017-08-30 14:24:55 -0700307 }
308
309 if len(combineJar.Inputs) != 2 || combineJar.Inputs[1].String() != baz {
310 t.Errorf("foo combineJar inputs %v does not contain %q", combineJar.Inputs, baz)
Colin Cross72bb3632017-07-13 16:23:21 -0700311 }
312}
313
Artur Satayev9cf46692019-11-26 18:08:34 +0000314func TestExportedPlugins(t *testing.T) {
315 type Result struct {
Colin Crossc9fe10f2020-11-19 18:06:03 -0800316 library string
317 processors string
318 disableTurbine bool
Artur Satayev9cf46692019-11-26 18:08:34 +0000319 }
320 var tests = []struct {
321 name string
322 extra string
323 results []Result
324 }{
325 {
326 name: "Exported plugin is not a direct plugin",
327 extra: `java_library { name: "exports", srcs: ["a.java"], exported_plugins: ["plugin"] }`,
328 results: []Result{{library: "exports", processors: "-proc:none"}},
329 },
330 {
331 name: "Exports plugin to dependee",
332 extra: `
333 java_library{name: "exports", exported_plugins: ["plugin"]}
334 java_library{name: "foo", srcs: ["a.java"], libs: ["exports"]}
335 java_library{name: "bar", srcs: ["a.java"], static_libs: ["exports"]}
336 `,
337 results: []Result{
338 {library: "foo", processors: "-processor com.android.TestPlugin"},
339 {library: "bar", processors: "-processor com.android.TestPlugin"},
340 },
341 },
342 {
343 name: "Exports plugin to android_library",
344 extra: `
345 java_library{name: "exports", exported_plugins: ["plugin"]}
346 android_library{name: "foo", srcs: ["a.java"], libs: ["exports"]}
347 android_library{name: "bar", srcs: ["a.java"], static_libs: ["exports"]}
348 `,
349 results: []Result{
350 {library: "foo", processors: "-processor com.android.TestPlugin"},
351 {library: "bar", processors: "-processor com.android.TestPlugin"},
352 },
353 },
354 {
355 name: "Exports plugin is not propagated via transitive deps",
356 extra: `
357 java_library{name: "exports", exported_plugins: ["plugin"]}
358 java_library{name: "foo", srcs: ["a.java"], libs: ["exports"]}
359 java_library{name: "bar", srcs: ["a.java"], static_libs: ["foo"]}
360 `,
361 results: []Result{
362 {library: "foo", processors: "-processor com.android.TestPlugin"},
363 {library: "bar", processors: "-proc:none"},
364 },
365 },
366 {
367 name: "Exports plugin appends to plugins",
368 extra: `
369 java_plugin{name: "plugin2", processor_class: "com.android.TestPlugin2"}
370 java_library{name: "exports", exported_plugins: ["plugin"]}
371 java_library{name: "foo", srcs: ["a.java"], libs: ["exports"], plugins: ["plugin2"]}
372 `,
373 results: []Result{
374 {library: "foo", processors: "-processor com.android.TestPlugin,com.android.TestPlugin2"},
375 },
376 },
Colin Crossc9fe10f2020-11-19 18:06:03 -0800377 {
378 name: "Exports plugin to with generates_api to dependee",
379 extra: `
380 java_library{name: "exports", exported_plugins: ["plugin_generates_api"]}
381 java_library{name: "foo", srcs: ["a.java"], libs: ["exports"]}
382 java_library{name: "bar", srcs: ["a.java"], static_libs: ["exports"]}
383 `,
384 results: []Result{
385 {library: "foo", processors: "-processor com.android.TestPlugin", disableTurbine: true},
386 {library: "bar", processors: "-processor com.android.TestPlugin", disableTurbine: true},
387 },
388 },
Artur Satayev9cf46692019-11-26 18:08:34 +0000389 }
390
391 for _, test := range tests {
392 t.Run(test.name, func(t *testing.T) {
393 ctx, _ := testJava(t, `
394 java_plugin {
395 name: "plugin",
396 processor_class: "com.android.TestPlugin",
397 }
Colin Crossc9fe10f2020-11-19 18:06:03 -0800398 java_plugin {
399 name: "plugin_generates_api",
400 generates_api: true,
401 processor_class: "com.android.TestPlugin",
402 }
Artur Satayev9cf46692019-11-26 18:08:34 +0000403 `+test.extra)
404
405 for _, want := range test.results {
406 javac := ctx.ModuleForTests(want.library, "android_common").Rule("javac")
407 if javac.Args["processor"] != want.processors {
408 t.Errorf("For library %v, expected %v, found %v", want.library, want.processors, javac.Args["processor"])
409 }
Colin Crossc9fe10f2020-11-19 18:06:03 -0800410 turbine := ctx.ModuleForTests(want.library, "android_common").MaybeRule("turbine")
411 disableTurbine := turbine.BuildParams.Rule == nil
412 if disableTurbine != want.disableTurbine {
413 t.Errorf("For library %v, expected disableTurbine %v, found %v", want.library, want.disableTurbine, disableTurbine)
414 }
Artur Satayev9cf46692019-11-26 18:08:34 +0000415 }
416 })
417 }
418}
419
Jeongik Cha2cc570d2019-10-29 15:44:45 +0900420func TestSdkVersionByPartition(t *testing.T) {
421 testJavaError(t, "sdk_version must have a value when the module is located at vendor or product", `
Jeongik Cha6bd33c12019-06-25 16:26:18 +0900422 java_library {
423 name: "foo",
424 srcs: ["a.java"],
425 vendor: true,
426 }
Jeongik Cha2cc570d2019-10-29 15:44:45 +0900427 `)
Jeongik Cha6bd33c12019-06-25 16:26:18 +0900428
Jeongik Cha2cc570d2019-10-29 15:44:45 +0900429 testJava(t, `
Jeongik Cha6bd33c12019-06-25 16:26:18 +0900430 java_library {
431 name: "bar",
432 srcs: ["b.java"],
433 }
434 `)
435
Jeongik Cha2cc570d2019-10-29 15:44:45 +0900436 for _, enforce := range []bool{true, false} {
Jeongik Cha2cc570d2019-10-29 15:44:45 +0900437 bp := `
438 java_library {
439 name: "foo",
440 srcs: ["a.java"],
441 product_specific: true,
442 }
443 `
Colin Cross98be1bb2019-12-13 20:41:13 -0800444
445 config := testConfig(nil, bp, nil)
446 config.TestProductVariables.EnforceProductPartitionInterface = proptools.BoolPtr(enforce)
Jeongik Cha2cc570d2019-10-29 15:44:45 +0900447 if enforce {
Colin Cross98be1bb2019-12-13 20:41:13 -0800448 testJavaErrorWithConfig(t, "sdk_version must have a value when the module is located at vendor or product", config)
Jeongik Cha2cc570d2019-10-29 15:44:45 +0900449 } else {
Colin Cross98be1bb2019-12-13 20:41:13 -0800450 testJavaWithConfig(t, config)
Jeongik Cha2cc570d2019-10-29 15:44:45 +0900451 }
Jeongik Cha6bd33c12019-06-25 16:26:18 +0900452 }
453}
454
Colin Crossd5934c82017-10-02 13:55:26 -0700455func TestArchSpecific(t *testing.T) {
Jaewoong Jungf9a04432019-07-17 11:15:09 -0700456 ctx, _ := testJava(t, `
Colin Crossd5934c82017-10-02 13:55:26 -0700457 java_library {
458 name: "foo",
459 srcs: ["a.java"],
460 target: {
461 android: {
462 srcs: ["b.java"],
463 },
464 },
465 }
466 `)
467
468 javac := ctx.ModuleForTests("foo", "android_common").Rule("javac")
469 if len(javac.Inputs) != 2 || javac.Inputs[0].String() != "a.java" || javac.Inputs[1].String() != "b.java" {
470 t.Errorf(`foo inputs %v != ["a.java", "b.java"]`, javac.Inputs)
471 }
472}
473
Colin Cross6b4a32d2017-12-05 13:42:45 -0800474func TestBinary(t *testing.T) {
Jaewoong Jungf9a04432019-07-17 11:15:09 -0700475 ctx, _ := testJava(t, `
Colin Cross6b4a32d2017-12-05 13:42:45 -0800476 java_library_host {
477 name: "foo",
478 srcs: ["a.java"],
479 }
480
481 java_binary_host {
482 name: "bar",
483 srcs: ["b.java"],
484 static_libs: ["foo"],
Colin Cross89226d92020-10-09 19:00:54 -0700485 jni_libs: ["libjni"],
486 }
487
488 cc_library_shared {
489 name: "libjni",
490 host_supported: true,
491 device_supported: false,
492 stl: "none",
Colin Cross6b4a32d2017-12-05 13:42:45 -0800493 }
494 `)
495
496 buildOS := android.BuildOs.String()
497
498 bar := ctx.ModuleForTests("bar", buildOS+"_common")
499 barJar := bar.Output("bar.jar").Output.String()
500 barWrapper := ctx.ModuleForTests("bar", buildOS+"_x86_64")
501 barWrapperDeps := barWrapper.Output("bar").Implicits.Strings()
502
Colin Cross89226d92020-10-09 19:00:54 -0700503 libjni := ctx.ModuleForTests("libjni", buildOS+"_x86_64_shared")
504 libjniSO := libjni.Rule("Cp").Output.String()
505
Colin Cross6b4a32d2017-12-05 13:42:45 -0800506 // Test that the install binary wrapper depends on the installed jar file
Colin Crossc179ea62020-10-09 10:54:15 -0700507 if g, w := barWrapperDeps, barJar; !android.InList(w, g) {
508 t.Errorf("expected binary wrapper implicits to contain %q, got %q", w, g)
Colin Cross6b4a32d2017-12-05 13:42:45 -0800509 }
Colin Cross89226d92020-10-09 19:00:54 -0700510
511 // Test that the install binary wrapper depends on the installed JNI libraries
512 if g, w := barWrapperDeps, libjniSO; !android.InList(w, g) {
513 t.Errorf("expected binary wrapper implicits to contain %q, got %q", w, g)
Colin Cross6b4a32d2017-12-05 13:42:45 -0800514 }
Alex Humesky2070e322020-06-09 20:23:08 -0400515}
Colin Cross6b4a32d2017-12-05 13:42:45 -0800516
Alex Humesky2070e322020-06-09 20:23:08 -0400517func TestHostBinaryNoJavaDebugInfoOverride(t *testing.T) {
518 bp := `
519 java_library {
520 name: "target_library",
521 srcs: ["a.java"],
522 }
523
524 java_binary_host {
525 name: "host_binary",
526 srcs: ["b.java"],
527 }
528 `
529 config := testConfig(nil, bp, nil)
530 config.TestProductVariables.MinimizeJavaDebugInfo = proptools.BoolPtr(true)
531
532 ctx, _ := testJavaWithConfig(t, config)
533
Liz Kammer7941b302020-07-28 13:27:34 -0700534 // first, check that the -g flag is added to target modules
Alex Humesky2070e322020-06-09 20:23:08 -0400535 targetLibrary := ctx.ModuleForTests("target_library", "android_common")
536 targetJavaFlags := targetLibrary.Module().VariablesForTests()["javacFlags"]
537 if !strings.Contains(targetJavaFlags, "-g:source,lines") {
538 t.Errorf("target library javac flags %v should contain "+
539 "-g:source,lines override with MinimizeJavaDebugInfo", targetJavaFlags)
540 }
541
542 // check that -g is not overridden for host modules
543 buildOS := android.BuildOs.String()
544 hostBinary := ctx.ModuleForTests("host_binary", buildOS+"_common")
545 hostJavaFlags := hostBinary.Module().VariablesForTests()["javacFlags"]
546 if strings.Contains(hostJavaFlags, "-g:source,lines") {
547 t.Errorf("java_binary_host javac flags %v should not have "+
548 "-g:source,lines override with MinimizeJavaDebugInfo", hostJavaFlags)
549 }
Colin Cross6b4a32d2017-12-05 13:42:45 -0800550}
551
Colin Cross72bb3632017-07-13 16:23:21 -0700552func TestPrebuilts(t *testing.T) {
Jaewoong Jungf9a04432019-07-17 11:15:09 -0700553 ctx, _ := testJava(t, `
Colin Cross72bb3632017-07-13 16:23:21 -0700554 java_library {
555 name: "foo",
Paul Duffin91547182019-11-12 19:39:36 +0000556 srcs: ["a.java", ":stubs-source"],
Paul Duffinfcfd7912020-01-31 17:54:30 +0000557 libs: ["bar", "sdklib"],
Colin Crosse8dc34a2017-07-19 11:22:16 -0700558 static_libs: ["baz"],
Colin Cross72bb3632017-07-13 16:23:21 -0700559 }
560
Colin Cross74d73e22017-08-02 11:05:49 -0700561 java_import {
Colin Cross72bb3632017-07-13 16:23:21 -0700562 name: "bar",
Colin Cross74d73e22017-08-02 11:05:49 -0700563 jars: ["a.jar"],
Colin Cross72bb3632017-07-13 16:23:21 -0700564 }
565
Colin Cross74d73e22017-08-02 11:05:49 -0700566 java_import {
Colin Cross72bb3632017-07-13 16:23:21 -0700567 name: "baz",
Colin Cross74d73e22017-08-02 11:05:49 -0700568 jars: ["b.jar"],
Liz Kammerd6c31d22020-08-05 15:40:41 -0700569 sdk_version: "current",
570 compile_dex: true,
Colin Cross72bb3632017-07-13 16:23:21 -0700571 }
Colin Cross42be7612019-02-21 18:12:14 -0800572
573 dex_import {
574 name: "qux",
575 jars: ["b.jar"],
576 }
Colin Cross79c7c262019-04-17 11:11:46 -0700577
578 java_sdk_library_import {
Paul Duffin56d44902020-01-31 13:36:25 +0000579 name: "sdklib",
580 public: {
581 jars: ["c.jar"],
582 },
583 }
584
Paul Duffin91547182019-11-12 19:39:36 +0000585 prebuilt_stubs_sources {
586 name: "stubs-source",
Paul Duffin9b478b02019-12-10 13:41:51 +0000587 srcs: ["stubs/sources"],
Paul Duffin91547182019-11-12 19:39:36 +0000588 }
Paul Duffin1b82e6a2019-12-03 18:06:47 +0000589
590 java_test_import {
591 name: "test",
592 jars: ["a.jar"],
593 test_suites: ["cts"],
594 test_config: "AndroidTest.xml",
595 }
Colin Cross72bb3632017-07-13 16:23:21 -0700596 `)
597
Paul Duffin9b478b02019-12-10 13:41:51 +0000598 fooModule := ctx.ModuleForTests("foo", "android_common")
599 javac := fooModule.Rule("javac")
Nan Zhanged19fc32017-10-19 13:06:22 -0700600 combineJar := ctx.ModuleForTests("foo", "android_common").Description("for javac")
Liz Kammerd6c31d22020-08-05 15:40:41 -0700601 barModule := ctx.ModuleForTests("bar", "android_common")
602 barJar := barModule.Rule("combineJar").Output
603 bazModule := ctx.ModuleForTests("baz", "android_common")
604 bazJar := bazModule.Rule("combineJar").Output
Colin Cross79c7c262019-04-17 11:11:46 -0700605 sdklibStubsJar := ctx.ModuleForTests("sdklib.stubs", "android_common").Rule("combineJar").Output
Colin Cross72bb3632017-07-13 16:23:21 -0700606
Paul Duffin9b478b02019-12-10 13:41:51 +0000607 fooLibrary := fooModule.Module().(*Library)
608 assertDeepEquals(t, "foo java sources incorrect",
609 []string{"a.java"}, fooLibrary.compiledJavaSrcs.Strings())
Paul Duffin91547182019-11-12 19:39:36 +0000610
Paul Duffin9b478b02019-12-10 13:41:51 +0000611 assertDeepEquals(t, "foo java source jars incorrect",
612 []string{".intermediates/stubs-source/android_common/stubs-source-stubs.srcjar"},
613 android.NormalizePathsForTesting(fooLibrary.compiledSrcJars))
Paul Duffin91547182019-11-12 19:39:36 +0000614
Colin Cross37f6d792018-07-12 12:28:41 -0700615 if !strings.Contains(javac.Args["classpath"], barJar.String()) {
616 t.Errorf("foo classpath %v does not contain %q", javac.Args["classpath"], barJar.String())
Colin Cross72bb3632017-07-13 16:23:21 -0700617 }
618
Liz Kammerd6c31d22020-08-05 15:40:41 -0700619 barDexJar := barModule.Module().(*Import).DexJarBuildPath()
620 if barDexJar != nil {
621 t.Errorf("bar dex jar build path expected to be nil, got %q", barDexJar)
622 }
623
Colin Cross79c7c262019-04-17 11:11:46 -0700624 if !strings.Contains(javac.Args["classpath"], sdklibStubsJar.String()) {
625 t.Errorf("foo classpath %v does not contain %q", javac.Args["classpath"], sdklibStubsJar.String())
626 }
627
Colin Cross37f6d792018-07-12 12:28:41 -0700628 if len(combineJar.Inputs) != 2 || combineJar.Inputs[1].String() != bazJar.String() {
629 t.Errorf("foo combineJar inputs %v does not contain %q", combineJar.Inputs, bazJar.String())
Colin Cross72bb3632017-07-13 16:23:21 -0700630 }
Colin Cross42be7612019-02-21 18:12:14 -0800631
Liz Kammerd6c31d22020-08-05 15:40:41 -0700632 bazDexJar := bazModule.Module().(*Import).DexJarBuildPath().String()
633 expectedDexJar := buildDir + "/.intermediates/baz/android_common/dex/baz.jar"
634 if bazDexJar != expectedDexJar {
635 t.Errorf("baz dex jar build path expected %q, got %q", expectedDexJar, bazDexJar)
636 }
637
Colin Cross42be7612019-02-21 18:12:14 -0800638 ctx.ModuleForTests("qux", "android_common").Rule("Cp")
Colin Cross72bb3632017-07-13 16:23:21 -0700639}
640
Paul Duffin9b478b02019-12-10 13:41:51 +0000641func assertDeepEquals(t *testing.T, message string, expected interface{}, actual interface{}) {
642 if !reflect.DeepEqual(expected, actual) {
643 t.Errorf("%s: expected %q, found %q", message, expected, actual)
644 }
645}
646
Paul Duffin1a393322020-11-18 16:36:47 +0000647func TestPrebuiltStubsSources(t *testing.T) {
648 test := func(t *testing.T, sourcesPath string, expectedInputs []string) {
649 ctx, _ := testJavaWithFS(t, fmt.Sprintf(`
650prebuilt_stubs_sources {
651 name: "stubs-source",
652 srcs: ["%s"],
653}`, sourcesPath), map[string][]byte{
654 "stubs/sources/pkg/A.java": nil,
655 "stubs/sources/pkg/B.java": nil,
656 })
657
658 zipSrc := ctx.ModuleForTests("stubs-source", "android_common").Rule("zip_src")
659 if expected, actual := expectedInputs, zipSrc.Inputs.Strings(); !reflect.DeepEqual(expected, actual) {
660 t.Errorf("mismatch of inputs to soong_zip: expected %q, actual %q", expected, actual)
661 }
662 }
663
664 t.Run("empty/missing directory", func(t *testing.T) {
665 test(t, "empty-directory", []string{})
666 })
667
668 t.Run("non-empty set of sources", func(t *testing.T) {
669 test(t, "stubs/sources", []string{
670 "stubs/sources/pkg/A.java",
671 "stubs/sources/pkg/B.java",
672 })
673 })
674}
675
Paul Duffin56d44902020-01-31 13:36:25 +0000676func TestJavaSdkLibraryImport(t *testing.T) {
677 ctx, _ := testJava(t, `
678 java_library {
679 name: "foo",
680 srcs: ["a.java"],
681 libs: ["sdklib"],
682 sdk_version: "current",
683 }
684
685 java_library {
686 name: "foo.system",
687 srcs: ["a.java"],
688 libs: ["sdklib"],
689 sdk_version: "system_current",
690 }
691
692 java_library {
693 name: "foo.test",
694 srcs: ["a.java"],
695 libs: ["sdklib"],
696 sdk_version: "test_current",
697 }
698
699 java_sdk_library_import {
700 name: "sdklib",
701 public: {
702 jars: ["a.jar"],
703 },
704 system: {
705 jars: ["b.jar"],
706 },
707 test: {
708 jars: ["c.jar"],
Paul Duffin0f8faff2020-05-20 16:18:00 +0100709 stub_srcs: ["c.java"],
Paul Duffin56d44902020-01-31 13:36:25 +0000710 },
711 }
712 `)
713
714 for _, scope := range []string{"", ".system", ".test"} {
715 fooModule := ctx.ModuleForTests("foo"+scope, "android_common")
716 javac := fooModule.Rule("javac")
717
718 sdklibStubsJar := ctx.ModuleForTests("sdklib.stubs"+scope, "android_common").Rule("combineJar").Output
719 if !strings.Contains(javac.Args["classpath"], sdklibStubsJar.String()) {
720 t.Errorf("foo classpath %v does not contain %q", javac.Args["classpath"], sdklibStubsJar.String())
721 }
722 }
Paul Duffinca8d9a52020-06-26 22:20:25 +0100723
Paul Duffincee7e662020-07-09 17:32:57 +0100724 CheckModuleDependencies(t, ctx, "sdklib", "android_common", []string{
Paul Duffinca8d9a52020-06-26 22:20:25 +0100725 `prebuilt_sdklib.stubs`,
726 `prebuilt_sdklib.stubs.source.test`,
727 `prebuilt_sdklib.stubs.system`,
728 `prebuilt_sdklib.stubs.test`,
729 })
730}
731
732func TestJavaSdkLibraryImport_WithSource(t *testing.T) {
733 ctx, _ := testJava(t, `
734 java_sdk_library {
735 name: "sdklib",
736 srcs: ["a.java"],
737 sdk_version: "none",
738 system_modules: "none",
739 public: {
740 enabled: true,
741 },
742 }
743
744 java_sdk_library_import {
745 name: "sdklib",
746 public: {
747 jars: ["a.jar"],
748 },
749 }
750 `)
751
Paul Duffincee7e662020-07-09 17:32:57 +0100752 CheckModuleDependencies(t, ctx, "sdklib", "android_common", []string{
Paul Duffinca8d9a52020-06-26 22:20:25 +0100753 `dex2oatd`,
754 `prebuilt_sdklib`,
755 `sdklib.impl`,
756 `sdklib.stubs`,
757 `sdklib.stubs.source`,
758 `sdklib.xml`,
759 })
760
Paul Duffincee7e662020-07-09 17:32:57 +0100761 CheckModuleDependencies(t, ctx, "prebuilt_sdklib", "android_common", []string{
Paul Duffin44f1d842020-06-26 20:17:02 +0100762 `prebuilt_sdklib.stubs`,
Paul Duffinca8d9a52020-06-26 22:20:25 +0100763 `sdklib.impl`,
764 // This should be prebuilt_sdklib.stubs but is set to sdklib.stubs because the
765 // dependency is added after prebuilts may have been renamed and so has to use
766 // the renamed name.
Paul Duffinca8d9a52020-06-26 22:20:25 +0100767 `sdklib.xml`,
768 })
769}
770
771func TestJavaSdkLibraryImport_Preferred(t *testing.T) {
772 ctx, _ := testJava(t, `
773 java_sdk_library {
774 name: "sdklib",
775 srcs: ["a.java"],
776 sdk_version: "none",
777 system_modules: "none",
778 public: {
779 enabled: true,
780 },
781 }
782
783 java_sdk_library_import {
784 name: "sdklib",
785 prefer: true,
786 public: {
787 jars: ["a.jar"],
788 },
789 }
790 `)
791
Paul Duffincee7e662020-07-09 17:32:57 +0100792 CheckModuleDependencies(t, ctx, "sdklib", "android_common", []string{
Paul Duffinca8d9a52020-06-26 22:20:25 +0100793 `dex2oatd`,
794 `prebuilt_sdklib`,
Paul Duffinca8d9a52020-06-26 22:20:25 +0100795 `sdklib.impl`,
Paul Duffin80342d72020-06-26 22:08:43 +0100796 `sdklib.stubs`,
Paul Duffinca8d9a52020-06-26 22:20:25 +0100797 `sdklib.stubs.source`,
798 `sdklib.xml`,
799 })
800
Paul Duffincee7e662020-07-09 17:32:57 +0100801 CheckModuleDependencies(t, ctx, "prebuilt_sdklib", "android_common", []string{
Paul Duffinca8d9a52020-06-26 22:20:25 +0100802 `prebuilt_sdklib.stubs`,
803 `sdklib.impl`,
804 `sdklib.xml`,
805 })
Paul Duffin56d44902020-01-31 13:36:25 +0000806}
807
Colin Cross89536d42017-07-07 14:35:50 -0700808func TestDefaults(t *testing.T) {
Jaewoong Jungf9a04432019-07-17 11:15:09 -0700809 ctx, _ := testJava(t, `
Colin Cross89536d42017-07-07 14:35:50 -0700810 java_defaults {
811 name: "defaults",
812 srcs: ["a.java"],
813 libs: ["bar"],
814 static_libs: ["baz"],
Sasha Smundak2057f822019-04-16 17:16:58 -0700815 optimize: {enabled: false},
Colin Cross89536d42017-07-07 14:35:50 -0700816 }
817
818 java_library {
819 name: "foo",
820 defaults: ["defaults"],
821 }
822
823 java_library {
824 name: "bar",
825 srcs: ["b.java"],
826 }
827
828 java_library {
829 name: "baz",
830 srcs: ["c.java"],
831 }
Sasha Smundak2057f822019-04-16 17:16:58 -0700832
833 android_test {
834 name: "atestOptimize",
835 defaults: ["defaults"],
836 optimize: {enabled: true},
837 }
838
839 android_test {
840 name: "atestNoOptimize",
841 defaults: ["defaults"],
842 }
843
844 android_test {
845 name: "atestDefault",
846 srcs: ["a.java"],
847 }
Colin Cross89536d42017-07-07 14:35:50 -0700848 `)
849
Colin Cross4c428df2017-09-15 17:36:05 -0700850 javac := ctx.ModuleForTests("foo", "android_common").Rule("javac")
Nan Zhanged19fc32017-10-19 13:06:22 -0700851 combineJar := ctx.ModuleForTests("foo", "android_common").Description("for javac")
Colin Cross89536d42017-07-07 14:35:50 -0700852
853 if len(javac.Inputs) != 1 || javac.Inputs[0].String() != "a.java" {
854 t.Errorf(`foo inputs %v != ["a.java"]`, javac.Inputs)
855 }
856
Nan Zhanged19fc32017-10-19 13:06:22 -0700857 barTurbine := filepath.Join(buildDir, ".intermediates", "bar", "android_common", "turbine-combined", "bar.jar")
858 if !strings.Contains(javac.Args["classpath"], barTurbine) {
859 t.Errorf("foo classpath %v does not contain %q", javac.Args["classpath"], barTurbine)
Colin Cross89536d42017-07-07 14:35:50 -0700860 }
861
Colin Cross1ee23172017-10-18 14:44:18 -0700862 baz := ctx.ModuleForTests("baz", "android_common").Rule("javac").Output.String()
Colin Cross0a6e0072017-08-30 14:24:55 -0700863 if len(combineJar.Inputs) != 2 || combineJar.Inputs[1].String() != baz {
864 t.Errorf("foo combineJar inputs %v does not contain %q", combineJar.Inputs, baz)
Colin Cross89536d42017-07-07 14:35:50 -0700865 }
Sasha Smundak2057f822019-04-16 17:16:58 -0700866
867 atestOptimize := ctx.ModuleForTests("atestOptimize", "android_common").MaybeRule("r8")
868 if atestOptimize.Output == nil {
869 t.Errorf("atestOptimize should optimize APK")
870 }
871
872 atestNoOptimize := ctx.ModuleForTests("atestNoOptimize", "android_common").MaybeRule("d8")
873 if atestNoOptimize.Output == nil {
874 t.Errorf("atestNoOptimize should not optimize APK")
875 }
876
877 atestDefault := ctx.ModuleForTests("atestDefault", "android_common").MaybeRule("r8")
878 if atestDefault.Output == nil {
879 t.Errorf("atestDefault should optimize APK")
880 }
Colin Cross89536d42017-07-07 14:35:50 -0700881}
882
Colin Cross0f37af02017-09-27 17:42:05 -0700883func TestResources(t *testing.T) {
884 var table = []struct {
885 name string
886 prop string
887 extra string
888 args string
889 }{
890 {
Colin Crossaf9c55b2017-10-03 14:50:08 -0700891 // Test that a module with java_resource_dirs includes the files
Colin Cross0f37af02017-09-27 17:42:05 -0700892 name: "resource dirs",
Colin Cross824bee32017-11-22 17:27:51 -0800893 prop: `java_resource_dirs: ["java-res"]`,
Colin Cross0ead1d72018-04-10 13:07:42 -0700894 args: "-C java-res -f java-res/a/a -f java-res/b/b",
Colin Cross0f37af02017-09-27 17:42:05 -0700895 },
896 {
897 // Test that a module with java_resources includes the files
898 name: "resource files",
Colin Cross0ead1d72018-04-10 13:07:42 -0700899 prop: `java_resources: ["java-res/a/a", "java-res/b/b"]`,
900 args: "-C . -f java-res/a/a -f java-res/b/b",
Colin Cross0f37af02017-09-27 17:42:05 -0700901 },
902 {
903 // Test that a module with a filegroup in java_resources includes the files with the
904 // path prefix
905 name: "resource filegroup",
906 prop: `java_resources: [":foo-res"]`,
907 extra: `
908 filegroup {
909 name: "foo-res",
Colin Cross824bee32017-11-22 17:27:51 -0800910 path: "java-res",
Colin Cross0ead1d72018-04-10 13:07:42 -0700911 srcs: ["java-res/a/a", "java-res/b/b"],
Colin Cross0f37af02017-09-27 17:42:05 -0700912 }`,
Colin Cross0ead1d72018-04-10 13:07:42 -0700913 args: "-C java-res -f java-res/a/a -f java-res/b/b",
Colin Cross0f37af02017-09-27 17:42:05 -0700914 },
915 {
Colin Cross0ead1d72018-04-10 13:07:42 -0700916 // Test that a module with wildcards in java_resource_dirs has the correct path prefixes
917 name: "wildcard dirs",
918 prop: `java_resource_dirs: ["java-res/*"]`,
919 args: "-C java-res/a -f java-res/a/a -C java-res/b -f java-res/b/b",
920 },
921 {
922 // Test that a module exclude_java_resource_dirs excludes the files
923 name: "wildcard dirs",
924 prop: `java_resource_dirs: ["java-res/*"], exclude_java_resource_dirs: ["java-res/b"]`,
925 args: "-C java-res/a -f java-res/a/a",
926 },
Colin Crosscedd4762018-09-13 11:26:19 -0700927 {
928 // Test wildcards in java_resources
929 name: "wildcard files",
930 prop: `java_resources: ["java-res/**/*"]`,
931 args: "-C . -f java-res/a/a -f java-res/b/b",
932 },
933 {
934 // Test exclude_java_resources with java_resources
935 name: "wildcard files with exclude",
936 prop: `java_resources: ["java-res/**/*"], exclude_java_resources: ["java-res/b/*"]`,
937 args: "-C . -f java-res/a/a",
938 },
939 {
940 // Test exclude_java_resources with java_resource_dirs
941 name: "resource dirs with exclude files",
942 prop: `java_resource_dirs: ["java-res"], exclude_java_resources: ["java-res/b/b"]`,
943 args: "-C java-res -f java-res/a/a",
944 },
945 {
946 // Test exclude_java_resource_dirs with java_resource_dirs
947 name: "resource dirs with exclude files",
948 prop: `java_resource_dirs: ["java-res", "java-res2"], exclude_java_resource_dirs: ["java-res2"]`,
949 args: "-C java-res -f java-res/a/a -f java-res/b/b",
950 },
Colin Cross0f37af02017-09-27 17:42:05 -0700951 }
952
953 for _, test := range table {
954 t.Run(test.name, func(t *testing.T) {
Colin Cross238c1f32020-06-07 16:58:18 -0700955 ctx, _ := testJavaWithFS(t, `
Colin Cross0f37af02017-09-27 17:42:05 -0700956 java_library {
957 name: "foo",
958 srcs: [
959 "a.java",
960 "b.java",
961 "c.java",
962 ],
963 `+test.prop+`,
964 }
Colin Cross238c1f32020-06-07 16:58:18 -0700965 `+test.extra,
966 map[string][]byte{
967 "java-res/a/a": nil,
968 "java-res/b/b": nil,
969 "java-res2/a": nil,
970 },
971 )
Colin Cross0f37af02017-09-27 17:42:05 -0700972
Colin Cross331a1212018-08-15 20:40:52 -0700973 foo := ctx.ModuleForTests("foo", "android_common").Output("withres/foo.jar")
Colin Cross1ee23172017-10-18 14:44:18 -0700974 fooRes := ctx.ModuleForTests("foo", "android_common").Output("res/foo.jar")
Colin Cross0f37af02017-09-27 17:42:05 -0700975
976 if !inList(fooRes.Output.String(), foo.Inputs.Strings()) {
977 t.Errorf("foo combined jars %v does not contain %q",
978 foo.Inputs.Strings(), fooRes.Output.String())
979 }
980
Colin Crossaf9c55b2017-10-03 14:50:08 -0700981 if fooRes.Args["jarArgs"] != test.args {
982 t.Errorf("foo resource jar args %q is not %q",
Colin Cross0f37af02017-09-27 17:42:05 -0700983 fooRes.Args["jarArgs"], test.args)
984 }
985 })
986 }
987}
988
Colin Cross0c4ce212019-05-03 15:28:19 -0700989func TestIncludeSrcs(t *testing.T) {
Colin Cross238c1f32020-06-07 16:58:18 -0700990 ctx, _ := testJavaWithFS(t, `
Colin Cross0c4ce212019-05-03 15:28:19 -0700991 java_library {
992 name: "foo",
993 srcs: [
994 "a.java",
995 "b.java",
996 "c.java",
997 ],
998 include_srcs: true,
999 }
1000
1001 java_library {
1002 name: "bar",
1003 srcs: [
1004 "a.java",
1005 "b.java",
1006 "c.java",
1007 ],
1008 java_resource_dirs: ["java-res"],
1009 include_srcs: true,
1010 }
Colin Cross238c1f32020-06-07 16:58:18 -07001011 `, map[string][]byte{
1012 "java-res/a/a": nil,
1013 "java-res/b/b": nil,
1014 "java-res2/a": nil,
1015 })
Colin Cross0c4ce212019-05-03 15:28:19 -07001016
1017 // Test a library with include_srcs: true
1018 foo := ctx.ModuleForTests("foo", "android_common").Output("withres/foo.jar")
1019 fooSrcJar := ctx.ModuleForTests("foo", "android_common").Output("foo.srcjar")
1020
1021 if g, w := fooSrcJar.Output.String(), foo.Inputs.Strings(); !inList(g, w) {
1022 t.Errorf("foo combined jars %v does not contain %q", w, g)
1023 }
1024
1025 if g, w := fooSrcJar.Args["jarArgs"], "-C . -f a.java -f b.java -f c.java"; g != w {
1026 t.Errorf("foo source jar args %q is not %q", w, g)
1027 }
1028
1029 // Test a library with include_srcs: true and resources
1030 bar := ctx.ModuleForTests("bar", "android_common").Output("withres/bar.jar")
1031 barResCombined := ctx.ModuleForTests("bar", "android_common").Output("res-combined/bar.jar")
1032 barRes := ctx.ModuleForTests("bar", "android_common").Output("res/bar.jar")
1033 barSrcJar := ctx.ModuleForTests("bar", "android_common").Output("bar.srcjar")
1034
1035 if g, w := barSrcJar.Output.String(), barResCombined.Inputs.Strings(); !inList(g, w) {
1036 t.Errorf("bar combined resource jars %v does not contain %q", w, g)
1037 }
1038
1039 if g, w := barRes.Output.String(), barResCombined.Inputs.Strings(); !inList(g, w) {
1040 t.Errorf("bar combined resource jars %v does not contain %q", w, g)
1041 }
1042
1043 if g, w := barResCombined.Output.String(), bar.Inputs.Strings(); !inList(g, w) {
1044 t.Errorf("bar combined jars %v does not contain %q", w, g)
1045 }
1046
1047 if g, w := barSrcJar.Args["jarArgs"], "-C . -f a.java -f b.java -f c.java"; g != w {
1048 t.Errorf("bar source jar args %q is not %q", w, g)
1049 }
1050
1051 if g, w := barRes.Args["jarArgs"], "-C java-res -f java-res/a/a -f java-res/b/b"; g != w {
1052 t.Errorf("bar resource jar args %q is not %q", w, g)
1053 }
1054}
1055
Colin Cross54190b32017-10-09 15:34:10 -07001056func TestGeneratedSources(t *testing.T) {
Colin Cross238c1f32020-06-07 16:58:18 -07001057 ctx, _ := testJavaWithFS(t, `
Colin Cross54190b32017-10-09 15:34:10 -07001058 java_library {
1059 name: "foo",
1060 srcs: [
1061 "a*.java",
1062 ":gen",
1063 "b*.java",
1064 ],
1065 }
1066
1067 genrule {
1068 name: "gen",
Colin Cross824bee32017-11-22 17:27:51 -08001069 tool_files: ["java-res/a"],
Colin Cross54190b32017-10-09 15:34:10 -07001070 out: ["gen.java"],
1071 }
Colin Cross238c1f32020-06-07 16:58:18 -07001072 `, map[string][]byte{
1073 "a.java": nil,
1074 "b.java": nil,
1075 })
Colin Cross54190b32017-10-09 15:34:10 -07001076
1077 javac := ctx.ModuleForTests("foo", "android_common").Rule("javac")
1078 genrule := ctx.ModuleForTests("gen", "").Rule("generator")
1079
Colin Cross15e86d92017-10-20 15:07:08 -07001080 if filepath.Base(genrule.Output.String()) != "gen.java" {
1081 t.Fatalf(`gen output file %v is not ".../gen.java"`, genrule.Output.String())
Colin Cross54190b32017-10-09 15:34:10 -07001082 }
1083
1084 if len(javac.Inputs) != 3 ||
1085 javac.Inputs[0].String() != "a.java" ||
Colin Cross15e86d92017-10-20 15:07:08 -07001086 javac.Inputs[1].String() != genrule.Output.String() ||
Colin Cross54190b32017-10-09 15:34:10 -07001087 javac.Inputs[2].String() != "b.java" {
1088 t.Errorf(`foo inputs %v != ["a.java", ".../gen.java", "b.java"]`, javac.Inputs)
1089 }
1090}
1091
Nan Zhang61eaedb2017-11-02 13:28:15 -07001092func TestTurbine(t *testing.T) {
Jaewoong Jungf9a04432019-07-17 11:15:09 -07001093 ctx, _ := testJava(t, `
Nan Zhang61eaedb2017-11-02 13:28:15 -07001094 java_library {
1095 name: "foo",
1096 srcs: ["a.java"],
Jiyong Park2d492942018-03-05 17:44:10 +09001097 sdk_version: "14",
Nan Zhang61eaedb2017-11-02 13:28:15 -07001098 }
1099
1100 java_library {
1101 name: "bar",
Colin Cross9bc43432017-12-15 20:20:39 -08001102 srcs: ["b.java"],
Nan Zhang61eaedb2017-11-02 13:28:15 -07001103 static_libs: ["foo"],
Jiyong Park2d492942018-03-05 17:44:10 +09001104 sdk_version: "14",
Nan Zhang61eaedb2017-11-02 13:28:15 -07001105 }
1106
1107 java_library {
1108 name: "baz",
1109 srcs: ["c.java"],
1110 libs: ["bar"],
1111 sdk_version: "14",
1112 }
1113 `)
1114
1115 fooTurbine := ctx.ModuleForTests("foo", "android_common").Rule("turbine")
1116 barTurbine := ctx.ModuleForTests("bar", "android_common").Rule("turbine")
1117 barJavac := ctx.ModuleForTests("bar", "android_common").Rule("javac")
1118 barTurbineCombined := ctx.ModuleForTests("bar", "android_common").Description("for turbine")
1119 bazJavac := ctx.ModuleForTests("baz", "android_common").Rule("javac")
1120
1121 if len(fooTurbine.Inputs) != 1 || fooTurbine.Inputs[0].String() != "a.java" {
1122 t.Errorf(`foo inputs %v != ["a.java"]`, fooTurbine.Inputs)
1123 }
1124
1125 fooHeaderJar := filepath.Join(buildDir, ".intermediates", "foo", "android_common", "turbine-combined", "foo.jar")
1126 if !strings.Contains(barTurbine.Args["classpath"], fooHeaderJar) {
1127 t.Errorf("bar turbine classpath %v does not contain %q", barTurbine.Args["classpath"], fooHeaderJar)
1128 }
1129 if !strings.Contains(barJavac.Args["classpath"], fooHeaderJar) {
1130 t.Errorf("bar javac classpath %v does not contain %q", barJavac.Args["classpath"], fooHeaderJar)
1131 }
1132 if len(barTurbineCombined.Inputs) != 2 || barTurbineCombined.Inputs[1].String() != fooHeaderJar {
1133 t.Errorf("bar turbine combineJar inputs %v does not contain %q", barTurbineCombined.Inputs, fooHeaderJar)
1134 }
Anton Hanssonf66efeb2018-04-11 13:57:30 +01001135 if !strings.Contains(bazJavac.Args["classpath"], "prebuilts/sdk/14/public/android.jar") {
Nan Zhang61eaedb2017-11-02 13:28:15 -07001136 t.Errorf("baz javac classpath %v does not contain %q", bazJavac.Args["classpath"],
Anton Hanssonf66efeb2018-04-11 13:57:30 +01001137 "prebuilts/sdk/14/public/android.jar")
Nan Zhang61eaedb2017-11-02 13:28:15 -07001138 }
1139}
1140
1141func TestSharding(t *testing.T) {
Jaewoong Jungf9a04432019-07-17 11:15:09 -07001142 ctx, _ := testJava(t, `
Nan Zhang61eaedb2017-11-02 13:28:15 -07001143 java_library {
1144 name: "bar",
1145 srcs: ["a.java","b.java","c.java"],
1146 javac_shard_size: 1
1147 }
1148 `)
1149
1150 barHeaderJar := filepath.Join(buildDir, ".intermediates", "bar", "android_common", "turbine-combined", "bar.jar")
1151 for i := 0; i < 3; i++ {
1152 barJavac := ctx.ModuleForTests("bar", "android_common").Description("javac" + strconv.Itoa(i))
1153 if !strings.Contains(barJavac.Args["classpath"], barHeaderJar) {
1154 t.Errorf("bar javac classpath %v does not contain %q", barJavac.Args["classpath"], barHeaderJar)
1155 }
1156 }
1157}
1158
Nan Zhang581fd212018-01-10 16:06:12 -08001159func TestDroiddoc(t *testing.T) {
Colin Cross238c1f32020-06-07 16:58:18 -07001160 ctx, _ := testJavaWithFS(t, `
Paul Duffin884363e2019-12-19 10:21:09 +00001161 droiddoc_exported_dir {
Dan Willemsencc090972018-02-26 14:33:31 -08001162 name: "droiddoc-templates-sdk",
1163 path: ".",
1164 }
Jiyong Park29074592019-07-07 16:27:47 +09001165 filegroup {
1166 name: "bar-doc-aidl-srcs",
1167 srcs: ["bar-doc/IBar.aidl"],
1168 path: "bar-doc",
1169 }
Liz Kammere1ab2502020-09-10 15:29:25 +00001170 droidstubs {
1171 name: "bar-stubs",
Liz Kammer3a55c912020-08-14 12:14:02 -07001172 srcs: [
Steve Kim3666c702020-09-01 17:58:01 +00001173 "bar-doc/a.java",
Liz Kammer3a55c912020-08-14 12:14:02 -07001174 ],
Steve Kim3666c702020-09-01 17:58:01 +00001175 exclude_srcs: [
1176 "bar-doc/b.java"
1177 ],
Liz Kammere1ab2502020-09-10 15:29:25 +00001178 api_levels_annotations_dirs: [
1179 "droiddoc-templates-sdk",
1180 ],
1181 api_levels_annotations_enabled: true,
1182 }
1183 droiddoc {
1184 name: "bar-doc",
1185 srcs: [
1186 ":bar-stubs",
1187 "bar-doc/IFoo.aidl",
1188 ":bar-doc-aidl-srcs",
1189 ],
Dan Willemsencc090972018-02-26 14:33:31 -08001190 custom_template: "droiddoc-templates-sdk",
Nan Zhang581fd212018-01-10 16:06:12 -08001191 hdf: [
1192 "android.whichdoc offline",
1193 ],
1194 knowntags: [
1195 "bar-doc/known_oj_tags.txt",
1196 ],
1197 proofread_file: "libcore-proofread.txt",
1198 todo_file: "libcore-docs-todo.html",
Liz Kammer585cac22020-07-06 09:12:57 -07001199 flags: ["-offlinemode -title \"libcore\""],
Nan Zhang581fd212018-01-10 16:06:12 -08001200 }
Colin Cross238c1f32020-06-07 16:58:18 -07001201 `,
1202 map[string][]byte{
1203 "bar-doc/a.java": nil,
1204 "bar-doc/b.java": nil,
1205 })
Liz Kammere1ab2502020-09-10 15:29:25 +00001206 barStubs := ctx.ModuleForTests("bar-stubs", "android_common")
1207 barStubsOutputs, err := barStubs.Module().(*Droidstubs).OutputFiles("")
1208 if err != nil {
1209 t.Errorf("Unexpected error %q retrieving \"bar-stubs\" output file", err)
1210 }
1211 if len(barStubsOutputs) != 1 {
1212 t.Errorf("Expected one output from \"bar-stubs\" got %s", barStubsOutputs)
Liz Kammer1e2ee122020-07-30 15:07:22 -07001213 }
Nan Zhang581fd212018-01-10 16:06:12 -08001214
Liz Kammere1ab2502020-09-10 15:29:25 +00001215 barStubsOutput := barStubsOutputs[0]
1216 barDoc := ctx.ModuleForTests("bar-doc", "android_common")
1217 javaDoc := barDoc.Rule("javadoc")
1218 if g, w := javaDoc.Implicits.Strings(), barStubsOutput.String(); !inList(w, g) {
1219 t.Errorf("implicits of bar-doc must contain %q, but was %q.", w, g)
Jiyong Park29074592019-07-07 16:27:47 +09001220 }
1221
Liz Kammere1ab2502020-09-10 15:29:25 +00001222 expected := "-sourcepath " + buildDir + "/.intermediates/bar-doc/android_common/srcjars "
1223 if !strings.Contains(javaDoc.RuleParams.Command, expected) {
1224 t.Errorf("bar-doc command does not contain flag %q, but should\n%q", expected, javaDoc.RuleParams.Command)
1225 }
1226
1227 aidl := barDoc.Rule("aidl")
1228 if g, w := javaDoc.Implicits.Strings(), aidl.Output.String(); !inList(w, g) {
Colin Crossc0806172019-06-14 18:51:47 -07001229 t.Errorf("implicits of bar-doc must contain %q, but was %q.", w, g)
1230 }
1231
1232 if g, w := aidl.Implicits.Strings(), []string{"bar-doc/IBar.aidl", "bar-doc/IFoo.aidl"}; !reflect.DeepEqual(w, g) {
1233 t.Errorf("aidl inputs must be %q, but was %q", w, g)
Jiyong Park1e440682018-05-23 18:42:04 +09001234 }
Nan Zhang581fd212018-01-10 16:06:12 -08001235}
1236
Liz Kammer585cac22020-07-06 09:12:57 -07001237func TestDroiddocArgsAndFlagsCausesError(t *testing.T) {
1238 testJavaError(t, "flags is set. Cannot set args", `
1239 droiddoc_exported_dir {
1240 name: "droiddoc-templates-sdk",
1241 path: ".",
1242 }
1243 filegroup {
1244 name: "bar-doc-aidl-srcs",
1245 srcs: ["bar-doc/IBar.aidl"],
1246 path: "bar-doc",
1247 }
Liz Kammere1ab2502020-09-10 15:29:25 +00001248 droidstubs {
1249 name: "bar-stubs",
Liz Kammer3a55c912020-08-14 12:14:02 -07001250 srcs: [
Steve Kim3666c702020-09-01 17:58:01 +00001251 "bar-doc/a.java",
Liz Kammer3a55c912020-08-14 12:14:02 -07001252 ],
Steve Kim3666c702020-09-01 17:58:01 +00001253 exclude_srcs: [
1254 "bar-doc/b.java"
1255 ],
Liz Kammere1ab2502020-09-10 15:29:25 +00001256 api_levels_annotations_dirs: [
1257 "droiddoc-templates-sdk",
1258 ],
1259 api_levels_annotations_enabled: true,
1260 }
1261 droiddoc {
1262 name: "bar-doc",
1263 srcs: [
1264 ":bar-stubs",
1265 "bar-doc/IFoo.aidl",
1266 ":bar-doc-aidl-srcs",
1267 ],
Liz Kammer585cac22020-07-06 09:12:57 -07001268 custom_template: "droiddoc-templates-sdk",
1269 hdf: [
1270 "android.whichdoc offline",
1271 ],
1272 knowntags: [
1273 "bar-doc/known_oj_tags.txt",
1274 ],
1275 proofread_file: "libcore-proofread.txt",
1276 todo_file: "libcore-docs-todo.html",
1277 flags: ["-offlinemode -title \"libcore\""],
1278 args: "-offlinemode -title \"libcore\"",
1279 }
1280 `)
1281}
1282
Liz Kammer3d894b72020-08-04 09:55:13 -07001283func TestDroidstubs(t *testing.T) {
1284 ctx, _ := testJavaWithFS(t, `
1285 droiddoc_exported_dir {
Anton Hansson52ac73d2020-10-26 09:57:40 +00001286 name: "droiddoc-templates-sdk",
1287 path: ".",
Liz Kammer3d894b72020-08-04 09:55:13 -07001288 }
1289
1290 droidstubs {
Anton Hansson52ac73d2020-10-26 09:57:40 +00001291 name: "bar-stubs",
1292 srcs: ["bar-doc/a.java"],
1293 api_levels_annotations_dirs: ["droiddoc-templates-sdk"],
1294 api_levels_annotations_enabled: true,
Liz Kammer3d894b72020-08-04 09:55:13 -07001295 }
1296
1297 droidstubs {
Anton Hansson52ac73d2020-10-26 09:57:40 +00001298 name: "bar-stubs-other",
1299 srcs: ["bar-doc/a.java"],
1300 high_mem: true,
1301 api_levels_annotations_dirs: ["droiddoc-templates-sdk"],
1302 api_levels_annotations_enabled: true,
1303 api_levels_jar_filename: "android.other.jar",
Liz Kammer3d894b72020-08-04 09:55:13 -07001304 }
1305 `,
1306 map[string][]byte{
1307 "bar-doc/a.java": nil,
1308 })
1309 testcases := []struct {
1310 moduleName string
1311 expectedJarFilename string
Anton Hansson52ac73d2020-10-26 09:57:40 +00001312 high_mem bool
Liz Kammer3d894b72020-08-04 09:55:13 -07001313 }{
1314 {
1315 moduleName: "bar-stubs",
1316 expectedJarFilename: "android.jar",
Anton Hansson52ac73d2020-10-26 09:57:40 +00001317 high_mem: false,
Liz Kammer3d894b72020-08-04 09:55:13 -07001318 },
1319 {
1320 moduleName: "bar-stubs-other",
1321 expectedJarFilename: "android.other.jar",
Anton Hansson52ac73d2020-10-26 09:57:40 +00001322 high_mem: true,
Liz Kammer3d894b72020-08-04 09:55:13 -07001323 },
1324 }
1325 for _, c := range testcases {
1326 m := ctx.ModuleForTests(c.moduleName, "android_common")
1327 metalava := m.Rule("metalava")
Anton Hansson52ac73d2020-10-26 09:57:40 +00001328 rp := metalava.RuleParams
Liz Kammer3d894b72020-08-04 09:55:13 -07001329 expected := "--android-jar-pattern ./%/public/" + c.expectedJarFilename
Anton Hansson52ac73d2020-10-26 09:57:40 +00001330 if actual := rp.Command; !strings.Contains(actual, expected) {
Liz Kammer3d894b72020-08-04 09:55:13 -07001331 t.Errorf("For %q, expected metalava argument %q, but was not found %q", c.moduleName, expected, actual)
1332 }
Anton Hansson52ac73d2020-10-26 09:57:40 +00001333
1334 if actual := rp.Pool != nil && strings.Contains(rp.Pool.String(), "highmem"); actual != c.high_mem {
1335 t.Errorf("Expected %q high_mem to be %v, was %v", c.moduleName, c.high_mem, actual)
1336 }
Liz Kammer3d894b72020-08-04 09:55:13 -07001337 }
1338}
1339
Paul Duffin83a2d962019-11-19 19:44:10 +00001340func TestDroidstubsWithSystemModules(t *testing.T) {
1341 ctx, _ := testJava(t, `
1342 droidstubs {
1343 name: "stubs-source-system-modules",
1344 srcs: [
Colin Cross238c1f32020-06-07 16:58:18 -07001345 "bar-doc/a.java",
Paul Duffin83a2d962019-11-19 19:44:10 +00001346 ],
1347 sdk_version: "none",
1348 system_modules: "source-system-modules",
1349 }
1350
1351 java_library {
1352 name: "source-jar",
1353 srcs: [
1354 "a.java",
1355 ],
1356 }
1357
1358 java_system_modules {
1359 name: "source-system-modules",
1360 libs: ["source-jar"],
1361 }
1362
1363 droidstubs {
1364 name: "stubs-prebuilt-system-modules",
1365 srcs: [
Colin Cross238c1f32020-06-07 16:58:18 -07001366 "bar-doc/a.java",
Paul Duffin83a2d962019-11-19 19:44:10 +00001367 ],
1368 sdk_version: "none",
1369 system_modules: "prebuilt-system-modules",
1370 }
1371
1372 java_import {
1373 name: "prebuilt-jar",
1374 jars: ["a.jar"],
1375 }
1376
1377 java_system_modules_import {
1378 name: "prebuilt-system-modules",
1379 libs: ["prebuilt-jar"],
1380 }
1381 `)
1382
1383 checkSystemModulesUseByDroidstubs(t, ctx, "stubs-source-system-modules", "source-jar.jar")
1384
1385 checkSystemModulesUseByDroidstubs(t, ctx, "stubs-prebuilt-system-modules", "prebuilt-jar.jar")
1386}
1387
1388func checkSystemModulesUseByDroidstubs(t *testing.T, ctx *android.TestContext, moduleName string, systemJar string) {
1389 metalavaRule := ctx.ModuleForTests(moduleName, "android_common").Rule("metalava")
1390 var systemJars []string
1391 for _, i := range metalavaRule.Implicits {
1392 systemJars = append(systemJars, i.Base())
1393 }
Ramy Medhatc7965cd2020-04-30 03:08:37 -04001394 if len(systemJars) < 1 || systemJars[0] != systemJar {
Paul Duffin83a2d962019-11-19 19:44:10 +00001395 t.Errorf("inputs of %q must be []string{%q}, but was %#v.", moduleName, systemJar, systemJars)
1396 }
1397}
1398
Colin Cross54250902017-12-05 09:28:08 -08001399func TestJarGenrules(t *testing.T) {
Jaewoong Jungf9a04432019-07-17 11:15:09 -07001400 ctx, _ := testJava(t, `
Colin Cross54250902017-12-05 09:28:08 -08001401 java_library {
1402 name: "foo",
1403 srcs: ["a.java"],
1404 }
1405
1406 java_genrule {
1407 name: "jargen",
1408 tool_files: ["b.java"],
1409 cmd: "$(location b.java) $(in) $(out)",
1410 out: ["jargen.jar"],
1411 srcs: [":foo"],
1412 }
1413
1414 java_library {
1415 name: "bar",
1416 static_libs: ["jargen"],
1417 srcs: ["c.java"],
1418 }
1419
1420 java_library {
1421 name: "baz",
1422 libs: ["jargen"],
1423 srcs: ["c.java"],
1424 }
1425 `)
1426
1427 foo := ctx.ModuleForTests("foo", "android_common").Output("javac/foo.jar")
1428 jargen := ctx.ModuleForTests("jargen", "android_common").Output("jargen.jar")
1429 bar := ctx.ModuleForTests("bar", "android_common").Output("javac/bar.jar")
1430 baz := ctx.ModuleForTests("baz", "android_common").Output("javac/baz.jar")
1431 barCombined := ctx.ModuleForTests("bar", "android_common").Output("combined/bar.jar")
1432
Colin Cross3d680512020-11-13 16:23:53 -08001433 if g, w := jargen.Implicits.Strings(), foo.Output.String(); !android.InList(w, g) {
1434 t.Errorf("expected jargen inputs [%q], got %q", w, g)
Colin Cross54250902017-12-05 09:28:08 -08001435 }
1436
1437 if !strings.Contains(bar.Args["classpath"], jargen.Output.String()) {
1438 t.Errorf("bar classpath %v does not contain %q", bar.Args["classpath"], jargen.Output.String())
1439 }
1440
1441 if !strings.Contains(baz.Args["classpath"], jargen.Output.String()) {
1442 t.Errorf("baz classpath %v does not contain %q", baz.Args["classpath"], jargen.Output.String())
1443 }
1444
1445 if len(barCombined.Inputs) != 2 ||
1446 barCombined.Inputs[0].String() != bar.Output.String() ||
1447 barCombined.Inputs[1].String() != jargen.Output.String() {
1448 t.Errorf("bar combined jar inputs %v is not [%q, %q]",
1449 barCombined.Inputs.Strings(), bar.Output.String(), jargen.Output.String())
1450 }
1451}
1452
Nan Zhang27e284d2018-02-09 21:03:53 +00001453func TestExcludeFileGroupInSrcs(t *testing.T) {
Jaewoong Jungf9a04432019-07-17 11:15:09 -07001454 ctx, _ := testJava(t, `
Nan Zhang27e284d2018-02-09 21:03:53 +00001455 java_library {
1456 name: "foo",
1457 srcs: ["a.java", ":foo-srcs"],
1458 exclude_srcs: ["a.java", ":foo-excludes"],
1459 }
1460
1461 filegroup {
1462 name: "foo-srcs",
1463 srcs: ["java-fg/a.java", "java-fg/b.java", "java-fg/c.java"],
1464 }
1465
1466 filegroup {
1467 name: "foo-excludes",
1468 srcs: ["java-fg/a.java", "java-fg/b.java"],
1469 }
1470 `)
1471
1472 javac := ctx.ModuleForTests("foo", "android_common").Rule("javac")
1473
1474 if len(javac.Inputs) != 1 || javac.Inputs[0].String() != "java-fg/c.java" {
1475 t.Errorf(`foo inputs %v != ["java-fg/c.java"]`, javac.Inputs)
1476 }
1477}
Jiyong Parkc678ad32018-04-10 13:07:10 +09001478
Paul Duffin52d398a2019-06-11 12:31:14 +01001479func TestJavaLibrary(t *testing.T) {
Colin Cross98be1bb2019-12-13 20:41:13 -08001480 config := testConfig(nil, "", map[string][]byte{
Paul Duffin52d398a2019-06-11 12:31:14 +01001481 "libcore/Android.bp": []byte(`
1482 java_library {
1483 name: "core",
1484 sdk_version: "none",
1485 system_modules: "none",
Paul Duffinaa55f742020-10-06 17:20:13 +01001486 }
1487
1488 filegroup {
1489 name: "core-jar",
1490 srcs: [":core{.jar}"],
1491 }
1492`),
1493 })
Colin Crossae8600b2020-10-29 17:09:13 -07001494 ctx := testContext(config)
Paul Duffinaa55f742020-10-06 17:20:13 +01001495 run(t, ctx, config)
1496}
1497
1498func TestJavaImport(t *testing.T) {
1499 config := testConfig(nil, "", map[string][]byte{
1500 "libcore/Android.bp": []byte(`
1501 java_import {
1502 name: "core",
1503 sdk_version: "none",
1504 }
1505
1506 filegroup {
1507 name: "core-jar",
1508 srcs: [":core{.jar}"],
1509 }
1510`),
Paul Duffin52d398a2019-06-11 12:31:14 +01001511 })
Colin Crossae8600b2020-10-29 17:09:13 -07001512 ctx := testContext(config)
Paul Duffin52d398a2019-06-11 12:31:14 +01001513 run(t, ctx, config)
1514}
1515
Jiyong Parkc678ad32018-04-10 13:07:10 +09001516func TestJavaSdkLibrary(t *testing.T) {
Jaewoong Jungf9a04432019-07-17 11:15:09 -07001517 ctx, _ := testJava(t, `
Paul Duffin884363e2019-12-19 10:21:09 +00001518 droiddoc_exported_dir {
Jiyong Parkc678ad32018-04-10 13:07:10 +09001519 name: "droiddoc-templates-sdk",
1520 path: ".",
1521 }
Jiyong Parkc678ad32018-04-10 13:07:10 +09001522 java_sdk_library {
1523 name: "foo",
1524 srcs: ["a.java", "b.java"],
1525 api_packages: ["foo"],
1526 }
1527 java_sdk_library {
1528 name: "bar",
1529 srcs: ["a.java", "b.java"],
1530 api_packages: ["bar"],
1531 }
1532 java_library {
1533 name: "baz",
1534 srcs: ["c.java"],
Paul Duffin859fe962020-05-15 10:20:31 +01001535 libs: ["foo", "bar.stubs"],
Jiyong Parkc678ad32018-04-10 13:07:10 +09001536 sdk_version: "system_current",
1537 }
Paul Duffindfa131e2020-05-15 20:37:11 +01001538 java_sdk_library {
1539 name: "barney",
1540 srcs: ["c.java"],
1541 api_only: true,
1542 }
1543 java_sdk_library {
1544 name: "betty",
1545 srcs: ["c.java"],
1546 shared_library: false,
1547 }
Paul Duffin859fe962020-05-15 10:20:31 +01001548 java_sdk_library_import {
1549 name: "quuz",
1550 public: {
1551 jars: ["c.jar"],
1552 },
1553 }
1554 java_sdk_library_import {
1555 name: "fred",
1556 public: {
1557 jars: ["b.jar"],
1558 },
1559 }
Paul Duffindfa131e2020-05-15 20:37:11 +01001560 java_sdk_library_import {
1561 name: "wilma",
1562 public: {
1563 jars: ["b.jar"],
1564 },
1565 shared_library: false,
1566 }
Jiyong Park1be96912018-05-28 18:02:19 +09001567 java_library {
1568 name: "qux",
1569 srcs: ["c.java"],
Paul Duffindfa131e2020-05-15 20:37:11 +01001570 libs: ["baz", "fred", "quuz.stubs", "wilma", "barney", "betty"],
Jiyong Park1be96912018-05-28 18:02:19 +09001571 sdk_version: "system_current",
1572 }
Paul Duffin726d23c2020-01-22 16:30:37 +00001573 java_library {
1574 name: "baz-test",
1575 srcs: ["c.java"],
1576 libs: ["foo"],
1577 sdk_version: "test_current",
1578 }
Paul Duffina2db18f2020-01-22 17:11:15 +00001579 java_library {
1580 name: "baz-29",
1581 srcs: ["c.java"],
1582 libs: ["foo"],
1583 sdk_version: "system_29",
1584 }
Paul Duffinfb6ae5b2020-09-30 15:17:25 +01001585 java_library {
1586 name: "baz-module-30",
1587 srcs: ["c.java"],
1588 libs: ["foo"],
1589 sdk_version: "module_30",
1590 }
Jiyong Parkc678ad32018-04-10 13:07:10 +09001591 `)
1592
1593 // check the existence of the internal modules
1594 ctx.ModuleForTests("foo", "android_common")
Paul Duffindd9d0742020-05-08 15:52:37 +01001595 ctx.ModuleForTests(apiScopePublic.stubsLibraryModuleName("foo"), "android_common")
1596 ctx.ModuleForTests(apiScopeSystem.stubsLibraryModuleName("foo"), "android_common")
1597 ctx.ModuleForTests(apiScopeTest.stubsLibraryModuleName("foo"), "android_common")
1598 ctx.ModuleForTests(apiScopePublic.stubsSourceModuleName("foo"), "android_common")
1599 ctx.ModuleForTests(apiScopeSystem.stubsSourceModuleName("foo"), "android_common")
1600 ctx.ModuleForTests(apiScopeTest.stubsSourceModuleName("foo"), "android_common")
Jiyong Parke3833882020-02-17 17:28:10 +09001601 ctx.ModuleForTests("foo"+sdkXmlFileSuffix, "android_common")
Jiyong Park58c518b2018-05-12 22:29:12 +09001602 ctx.ModuleForTests("foo.api.public.28", "")
1603 ctx.ModuleForTests("foo.api.system.28", "")
1604 ctx.ModuleForTests("foo.api.test.28", "")
Jiyong Parkc678ad32018-04-10 13:07:10 +09001605
1606 bazJavac := ctx.ModuleForTests("baz", "android_common").Rule("javac")
1607 // tests if baz is actually linked to the stubs lib
1608 if !strings.Contains(bazJavac.Args["classpath"], "foo.stubs.system.jar") {
1609 t.Errorf("baz javac classpath %v does not contain %q", bazJavac.Args["classpath"],
1610 "foo.stubs.system.jar")
1611 }
1612 // ... and not to the impl lib
Sundong Ahn054b19a2018-10-19 13:46:09 +09001613 if strings.Contains(bazJavac.Args["classpath"], "foo.jar") {
Jiyong Parkc678ad32018-04-10 13:07:10 +09001614 t.Errorf("baz javac classpath %v should not contain %q", bazJavac.Args["classpath"],
Sundong Ahn054b19a2018-10-19 13:46:09 +09001615 "foo.jar")
Jiyong Parkc678ad32018-04-10 13:07:10 +09001616 }
1617 // test if baz is not linked to the system variant of foo
1618 if strings.Contains(bazJavac.Args["classpath"], "foo.stubs.jar") {
1619 t.Errorf("baz javac classpath %v should not contain %q", bazJavac.Args["classpath"],
1620 "foo.stubs.jar")
1621 }
Jiyong Park1be96912018-05-28 18:02:19 +09001622
Paul Duffin726d23c2020-01-22 16:30:37 +00001623 bazTestJavac := ctx.ModuleForTests("baz-test", "android_common").Rule("javac")
1624 // tests if baz-test is actually linked to the test stubs lib
1625 if !strings.Contains(bazTestJavac.Args["classpath"], "foo.stubs.test.jar") {
1626 t.Errorf("baz-test javac classpath %v does not contain %q", bazTestJavac.Args["classpath"],
1627 "foo.stubs.test.jar")
1628 }
1629
Paul Duffina2db18f2020-01-22 17:11:15 +00001630 baz29Javac := ctx.ModuleForTests("baz-29", "android_common").Rule("javac")
1631 // tests if baz-29 is actually linked to the system 29 stubs lib
1632 if !strings.Contains(baz29Javac.Args["classpath"], "prebuilts/sdk/29/system/foo.jar") {
1633 t.Errorf("baz-29 javac classpath %v does not contain %q", baz29Javac.Args["classpath"],
1634 "prebuilts/sdk/29/system/foo.jar")
1635 }
1636
Paul Duffinfb6ae5b2020-09-30 15:17:25 +01001637 bazModule30Javac := ctx.ModuleForTests("baz-module-30", "android_common").Rule("javac")
1638 // tests if "baz-module-30" is actually linked to the module 30 stubs lib
1639 if !strings.Contains(bazModule30Javac.Args["classpath"], "prebuilts/sdk/30/module-lib/foo.jar") {
1640 t.Errorf("baz-module-30 javac classpath %v does not contain %q", bazModule30Javac.Args["classpath"],
1641 "prebuilts/sdk/30/module-lib/foo.jar")
1642 }
1643
Jiyong Park1be96912018-05-28 18:02:19 +09001644 // test if baz has exported SDK lib names foo and bar to qux
1645 qux := ctx.ModuleForTests("qux", "android_common")
1646 if quxLib, ok := qux.Module().(*Library); ok {
Ulya Trafimovichb23d28c2020-10-08 12:53:58 +01001647 sdkLibs := quxLib.ClassLoaderContexts().UsesLibs()
Ulya Trafimovich8cbc5d22020-11-03 15:15:46 +00001648 if w := []string{"foo", "bar", "fred", "quuz"}; !reflect.DeepEqual(w, sdkLibs) {
Paul Duffin859fe962020-05-15 10:20:31 +01001649 t.Errorf("qux should export %q but exports %q", w, sdkLibs)
Jiyong Park1be96912018-05-28 18:02:19 +09001650 }
1651 }
Jiyong Parkc678ad32018-04-10 13:07:10 +09001652}
Zoran Jovanovic8736ce22018-08-21 17:10:29 +02001653
Anton Hansson7f66efa2020-10-08 14:47:23 +01001654func TestJavaSdkLibrary_StubOrImplOnlyLibs(t *testing.T) {
1655 ctx, _ := testJava(t, `
1656 java_sdk_library {
1657 name: "sdk_lib",
1658 srcs: ["a.java"],
1659 impl_only_libs: ["foo"],
1660 stub_only_libs: ["bar"],
1661 }
1662 java_library {
1663 name: "foo",
1664 srcs: ["a.java"],
1665 sdk_version: "current",
1666 }
1667 java_library {
1668 name: "bar",
1669 srcs: ["a.java"],
1670 sdk_version: "current",
1671 }
1672 `)
1673
1674 for _, implName := range []string{"sdk_lib", "sdk_lib.impl"} {
1675 implJavacCp := ctx.ModuleForTests(implName, "android_common").Rule("javac").Args["classpath"]
1676 if !strings.Contains(implJavacCp, "/foo.jar") || strings.Contains(implJavacCp, "/bar.jar") {
1677 t.Errorf("%v javac classpath %v does not contain foo and not bar", implName, implJavacCp)
1678 }
1679 }
1680 stubName := apiScopePublic.stubsLibraryModuleName("sdk_lib")
1681 stubsJavacCp := ctx.ModuleForTests(stubName, "android_common").Rule("javac").Args["classpath"]
1682 if strings.Contains(stubsJavacCp, "/foo.jar") || !strings.Contains(stubsJavacCp, "/bar.jar") {
1683 t.Errorf("stubs javac classpath %v does not contain bar and not foo", stubsJavacCp)
1684 }
1685}
1686
Paul Duffindaaa3322020-05-26 18:13:57 +01001687func TestJavaSdkLibrary_DoNotAccessImplWhenItIsNotBuilt(t *testing.T) {
1688 ctx, _ := testJava(t, `
1689 java_sdk_library {
1690 name: "foo",
1691 srcs: ["a.java"],
1692 api_only: true,
1693 public: {
1694 enabled: true,
1695 },
1696 }
1697
1698 java_library {
1699 name: "bar",
1700 srcs: ["b.java"],
1701 libs: ["foo"],
1702 }
1703 `)
1704
1705 // The bar library should depend on the stubs jar.
1706 barLibrary := ctx.ModuleForTests("bar", "android_common").Rule("javac")
1707 if expected, actual := `^-classpath .*:/[^:]*/turbine-combined/foo\.stubs\.jar$`, barLibrary.Args["classpath"]; !regexp.MustCompile(expected).MatchString(actual) {
1708 t.Errorf("expected %q, found %#q", expected, actual)
1709 }
1710}
1711
Paul Duffin46dc45a2020-05-14 15:39:10 +01001712func TestJavaSdkLibrary_UseSourcesFromAnotherSdkLibrary(t *testing.T) {
1713 testJava(t, `
1714 java_sdk_library {
1715 name: "foo",
1716 srcs: ["a.java"],
1717 api_packages: ["foo"],
1718 public: {
1719 enabled: true,
1720 },
1721 }
1722
1723 java_library {
1724 name: "bar",
1725 srcs: ["b.java", ":foo{.public.stubs.source}"],
1726 }
1727 `)
1728}
1729
1730func TestJavaSdkLibrary_AccessOutputFiles_MissingScope(t *testing.T) {
1731 testJavaError(t, `"foo" does not provide api scope system`, `
1732 java_sdk_library {
1733 name: "foo",
1734 srcs: ["a.java"],
1735 api_packages: ["foo"],
1736 public: {
1737 enabled: true,
1738 },
1739 }
1740
1741 java_library {
1742 name: "bar",
1743 srcs: ["b.java", ":foo{.system.stubs.source}"],
1744 }
1745 `)
1746}
1747
Paul Duffinca8d9a52020-06-26 22:20:25 +01001748func TestJavaSdkLibrary_Deps(t *testing.T) {
1749 ctx, _ := testJava(t, `
1750 java_sdk_library {
1751 name: "sdklib",
1752 srcs: ["a.java"],
1753 sdk_version: "none",
1754 system_modules: "none",
1755 public: {
1756 enabled: true,
1757 },
1758 }
1759 `)
1760
Paul Duffincee7e662020-07-09 17:32:57 +01001761 CheckModuleDependencies(t, ctx, "sdklib", "android_common", []string{
Paul Duffinca8d9a52020-06-26 22:20:25 +01001762 `dex2oatd`,
1763 `sdklib.impl`,
1764 `sdklib.stubs`,
1765 `sdklib.stubs.source`,
1766 `sdklib.xml`,
1767 })
1768}
1769
Paul Duffin46dc45a2020-05-14 15:39:10 +01001770func TestJavaSdkLibraryImport_AccessOutputFiles(t *testing.T) {
1771 testJava(t, `
1772 java_sdk_library_import {
1773 name: "foo",
1774 public: {
1775 jars: ["a.jar"],
1776 stub_srcs: ["a.java"],
1777 current_api: "api/current.txt",
1778 removed_api: "api/removed.txt",
1779 },
1780 }
1781
1782 java_library {
1783 name: "bar",
1784 srcs: [":foo{.public.stubs.source}"],
1785 java_resources: [
1786 ":foo{.public.api.txt}",
1787 ":foo{.public.removed-api.txt}",
1788 ],
1789 }
1790 `)
1791}
1792
1793func TestJavaSdkLibraryImport_AccessOutputFiles_Invalid(t *testing.T) {
1794 bp := `
1795 java_sdk_library_import {
1796 name: "foo",
1797 public: {
1798 jars: ["a.jar"],
1799 },
1800 }
1801 `
1802
1803 t.Run("stubs.source", func(t *testing.T) {
1804 testJavaError(t, `stubs.source not available for api scope public`, bp+`
1805 java_library {
1806 name: "bar",
1807 srcs: [":foo{.public.stubs.source}"],
1808 java_resources: [
1809 ":foo{.public.api.txt}",
1810 ":foo{.public.removed-api.txt}",
1811 ],
1812 }
1813 `)
1814 })
1815
1816 t.Run("api.txt", func(t *testing.T) {
1817 testJavaError(t, `api.txt not available for api scope public`, bp+`
1818 java_library {
1819 name: "bar",
1820 srcs: ["a.java"],
1821 java_resources: [
1822 ":foo{.public.api.txt}",
1823 ],
1824 }
1825 `)
1826 })
1827
1828 t.Run("removed-api.txt", func(t *testing.T) {
1829 testJavaError(t, `removed-api.txt not available for api scope public`, bp+`
1830 java_library {
1831 name: "bar",
1832 srcs: ["a.java"],
1833 java_resources: [
1834 ":foo{.public.removed-api.txt}",
1835 ],
1836 }
1837 `)
1838 })
1839}
1840
Paul Duffin3375e352020-04-28 10:44:03 +01001841func TestJavaSdkLibrary_InvalidScopes(t *testing.T) {
1842 testJavaError(t, `module "foo": enabled api scope "system" depends on disabled scope "public"`, `
1843 java_sdk_library {
1844 name: "foo",
1845 srcs: ["a.java", "b.java"],
1846 api_packages: ["foo"],
1847 // Explicitly disable public to test the check that ensures the set of enabled
1848 // scopes is consistent.
1849 public: {
1850 enabled: false,
1851 },
1852 system: {
1853 enabled: true,
1854 },
1855 }
1856 `)
1857}
1858
Paul Duffin87a05a32020-05-12 11:50:28 +01001859func TestJavaSdkLibrary_SdkVersion_ForScope(t *testing.T) {
1860 testJava(t, `
1861 java_sdk_library {
1862 name: "foo",
1863 srcs: ["a.java", "b.java"],
1864 api_packages: ["foo"],
1865 system: {
1866 enabled: true,
1867 sdk_version: "module_current",
1868 },
1869 }
1870 `)
1871}
1872
Paul Duffin0c5bae52020-06-02 13:00:08 +01001873func TestJavaSdkLibrary_ModuleLib(t *testing.T) {
1874 testJava(t, `
1875 java_sdk_library {
1876 name: "foo",
1877 srcs: ["a.java", "b.java"],
1878 api_packages: ["foo"],
1879 system: {
1880 enabled: true,
1881 },
1882 module_lib: {
1883 enabled: true,
1884 },
1885 }
1886 `)
1887}
1888
1889func TestJavaSdkLibrary_SystemServer(t *testing.T) {
1890 testJava(t, `
1891 java_sdk_library {
1892 name: "foo",
1893 srcs: ["a.java", "b.java"],
1894 api_packages: ["foo"],
1895 system: {
1896 enabled: true,
1897 },
1898 system_server: {
1899 enabled: true,
1900 },
1901 }
1902 `)
1903}
1904
Paul Duffin803a9562020-05-20 11:52:25 +01001905func TestJavaSdkLibrary_MissingScope(t *testing.T) {
1906 testJavaError(t, `requires api scope module-lib from foo but it only has \[\] available`, `
1907 java_sdk_library {
1908 name: "foo",
1909 srcs: ["a.java"],
1910 public: {
1911 enabled: false,
1912 },
1913 }
1914
1915 java_library {
1916 name: "baz",
1917 srcs: ["a.java"],
1918 libs: ["foo"],
1919 sdk_version: "module_current",
1920 }
1921 `)
1922}
1923
1924func TestJavaSdkLibrary_FallbackScope(t *testing.T) {
1925 testJava(t, `
1926 java_sdk_library {
1927 name: "foo",
1928 srcs: ["a.java"],
1929 system: {
1930 enabled: true,
1931 },
1932 }
1933
1934 java_library {
1935 name: "baz",
1936 srcs: ["a.java"],
1937 libs: ["foo"],
1938 // foo does not have module-lib scope so it should fallback to system
1939 sdk_version: "module_current",
1940 }
1941 `)
1942}
1943
Jiyong Park932cdfe2020-05-28 00:19:53 +09001944func TestJavaSdkLibrary_DefaultToStubs(t *testing.T) {
1945 ctx, _ := testJava(t, `
1946 java_sdk_library {
1947 name: "foo",
1948 srcs: ["a.java"],
1949 system: {
1950 enabled: true,
1951 },
1952 default_to_stubs: true,
1953 }
1954
1955 java_library {
1956 name: "baz",
1957 srcs: ["a.java"],
1958 libs: ["foo"],
1959 // does not have sdk_version set, should fallback to module,
1960 // which will then fallback to system because the module scope
1961 // is not enabled.
1962 }
1963 `)
1964 // The baz library should depend on the system stubs jar.
1965 bazLibrary := ctx.ModuleForTests("baz", "android_common").Rule("javac")
1966 if expected, actual := `^-classpath .*:/[^:]*/turbine-combined/foo\.stubs.system\.jar$`, bazLibrary.Args["classpath"]; !regexp.MustCompile(expected).MatchString(actual) {
1967 t.Errorf("expected %q, found %#q", expected, actual)
1968 }
1969}
1970
Zoran Jovanovic8736ce22018-08-21 17:10:29 +02001971var compilerFlagsTestCases = []struct {
1972 in string
1973 out bool
1974}{
1975 {
1976 in: "a",
1977 out: false,
1978 },
1979 {
1980 in: "-a",
1981 out: true,
1982 },
1983 {
1984 in: "-no-jdk",
1985 out: false,
1986 },
1987 {
1988 in: "-no-stdlib",
1989 out: false,
1990 },
1991 {
1992 in: "-kotlin-home",
1993 out: false,
1994 },
1995 {
1996 in: "-kotlin-home /some/path",
1997 out: false,
1998 },
1999 {
2000 in: "-include-runtime",
2001 out: false,
2002 },
2003 {
2004 in: "-Xintellij-plugin-root",
2005 out: false,
2006 },
2007}
2008
2009type mockContext struct {
2010 android.ModuleContext
2011 result bool
2012}
2013
2014func (ctx *mockContext) PropertyErrorf(property, format string, args ...interface{}) {
2015 // CheckBadCompilerFlags calls this function when the flag should be rejected
2016 ctx.result = false
2017}
2018
2019func TestCompilerFlags(t *testing.T) {
2020 for _, testCase := range compilerFlagsTestCases {
2021 ctx := &mockContext{result: true}
2022 CheckKotlincFlags(ctx, []string{testCase.in})
2023 if ctx.result != testCase.out {
2024 t.Errorf("incorrect output:")
2025 t.Errorf(" input: %#v", testCase.in)
2026 t.Errorf(" expected: %#v", testCase.out)
2027 t.Errorf(" got: %#v", ctx.result)
2028 }
2029 }
2030}
Jaewoong Jung38e4fb22018-12-12 09:01:34 -08002031
2032// TODO(jungjw): Consider making this more robust by ignoring path order.
2033func checkPatchModuleFlag(t *testing.T, ctx *android.TestContext, moduleName string, expected string) {
2034 variables := ctx.ModuleForTests(moduleName, "android_common").Module().VariablesForTests()
2035 flags := strings.Split(variables["javacFlags"], " ")
2036 got := ""
2037 for _, flag := range flags {
2038 keyEnd := strings.Index(flag, "=")
2039 if keyEnd > -1 && flag[:keyEnd] == "--patch-module" {
2040 got = flag[keyEnd+1:]
2041 break
2042 }
2043 }
2044 if expected != got {
2045 t.Errorf("Unexpected patch-module flag for module %q - expected %q, but got %q", moduleName, expected, got)
2046 }
2047}
2048
2049func TestPatchModule(t *testing.T) {
Pete Gillin0c2143e2019-05-02 15:32:11 +01002050 t.Run("Java language level 8", func(t *testing.T) {
Pete Gillin1b3370f2019-10-01 13:57:31 +01002051 // Test with legacy javac -source 1.8 -target 1.8
Pete Gillinbdf5d712019-10-21 14:29:58 +01002052 bp := `
2053 java_library {
2054 name: "foo",
2055 srcs: ["a.java"],
2056 java_version: "1.8",
2057 }
2058
2059 java_library {
2060 name: "bar",
2061 srcs: ["b.java"],
2062 sdk_version: "none",
2063 system_modules: "none",
2064 patch_module: "java.base",
2065 java_version: "1.8",
2066 }
2067
2068 java_library {
2069 name: "baz",
2070 srcs: ["c.java"],
2071 patch_module: "java.base",
2072 java_version: "1.8",
2073 }
2074 `
2075 ctx, _ := testJava(t, bp)
Jaewoong Jung38e4fb22018-12-12 09:01:34 -08002076
2077 checkPatchModuleFlag(t, ctx, "foo", "")
2078 checkPatchModuleFlag(t, ctx, "bar", "")
2079 checkPatchModuleFlag(t, ctx, "baz", "")
2080 })
2081
Pete Gillin0c2143e2019-05-02 15:32:11 +01002082 t.Run("Java language level 9", func(t *testing.T) {
Pete Gillin1b3370f2019-10-01 13:57:31 +01002083 // Test with default javac -source 9 -target 9
Pete Gillinbdf5d712019-10-21 14:29:58 +01002084 bp := `
2085 java_library {
2086 name: "foo",
2087 srcs: ["a.java"],
2088 }
2089
2090 java_library {
2091 name: "bar",
2092 srcs: ["b.java"],
2093 sdk_version: "none",
2094 system_modules: "none",
2095 patch_module: "java.base",
2096 }
2097
2098 java_library {
2099 name: "baz",
Jingwen Chen5136a6e2020-10-30 01:01:35 -04002100 srcs: [
2101 "c.java",
2102 // Tests for b/150878007
2103 "dir/d.java",
2104 "dir2/e.java",
2105 "dir2/f.java",
2106 "nested/dir/g.java"
2107 ],
Pete Gillinbdf5d712019-10-21 14:29:58 +01002108 patch_module: "java.base",
2109 }
2110 `
Pete Gillin1b3370f2019-10-01 13:57:31 +01002111 ctx, _ := testJava(t, bp)
Jaewoong Jung38e4fb22018-12-12 09:01:34 -08002112
2113 checkPatchModuleFlag(t, ctx, "foo", "")
2114 expected := "java.base=.:" + buildDir
2115 checkPatchModuleFlag(t, ctx, "bar", expected)
Jingwen Chen5136a6e2020-10-30 01:01:35 -04002116 expected = "java.base=" + strings.Join([]string{
2117 ".", buildDir, "dir", "dir2", "nested", moduleToPath("ext"), moduleToPath("framework")}, ":")
Jaewoong Jung38e4fb22018-12-12 09:01:34 -08002118 checkPatchModuleFlag(t, ctx, "baz", expected)
2119 })
2120}
Paul Duffina7b9f422020-01-10 17:12:18 +00002121
2122func TestJavaSystemModules(t *testing.T) {
2123 ctx, _ := testJava(t, `
2124 java_system_modules {
2125 name: "system-modules",
2126 libs: ["system-module1", "system-module2"],
2127 }
2128 java_library {
2129 name: "system-module1",
2130 srcs: ["a.java"],
2131 sdk_version: "none",
2132 system_modules: "none",
2133 }
2134 java_library {
2135 name: "system-module2",
2136 srcs: ["b.java"],
2137 sdk_version: "none",
2138 system_modules: "none",
2139 }
2140 `)
2141
2142 // check the existence of the module
2143 systemModules := ctx.ModuleForTests("system-modules", "android_common")
2144
2145 cmd := systemModules.Rule("jarsTosystemModules")
2146
2147 // make sure the command compiles against the supplied modules.
2148 for _, module := range []string{"system-module1.jar", "system-module2.jar"} {
2149 if !strings.Contains(cmd.Args["classpath"], module) {
2150 t.Errorf("system modules classpath %v does not contain %q", cmd.Args["classpath"],
2151 module)
2152 }
2153 }
2154}
Paul Duffin90169ba2020-01-10 17:16:44 +00002155
2156func TestJavaSystemModulesImport(t *testing.T) {
2157 ctx, _ := testJava(t, `
2158 java_system_modules_import {
2159 name: "system-modules",
2160 libs: ["system-module1", "system-module2"],
2161 }
2162 java_import {
2163 name: "system-module1",
2164 jars: ["a.jar"],
2165 }
2166 java_import {
2167 name: "system-module2",
2168 jars: ["b.jar"],
2169 }
2170 `)
2171
2172 // check the existence of the module
2173 systemModules := ctx.ModuleForTests("system-modules", "android_common")
2174
2175 cmd := systemModules.Rule("jarsTosystemModules")
2176
2177 // make sure the command compiles against the supplied modules.
2178 for _, module := range []string{"system-module1.jar", "system-module2.jar"} {
2179 if !strings.Contains(cmd.Args["classpath"], module) {
2180 t.Errorf("system modules classpath %v does not contain %q", cmd.Args["classpath"],
2181 module)
2182 }
2183 }
2184}
Paul Duffin83a2d962019-11-19 19:44:10 +00002185
2186func TestJavaLibraryWithSystemModules(t *testing.T) {
2187 ctx, _ := testJava(t, `
2188 java_library {
2189 name: "lib-with-source-system-modules",
2190 srcs: [
2191 "a.java",
2192 ],
2193 sdk_version: "none",
2194 system_modules: "source-system-modules",
2195 }
2196
2197 java_library {
2198 name: "source-jar",
2199 srcs: [
2200 "a.java",
2201 ],
2202 }
2203
2204 java_system_modules {
2205 name: "source-system-modules",
2206 libs: ["source-jar"],
2207 }
2208
2209 java_library {
2210 name: "lib-with-prebuilt-system-modules",
2211 srcs: [
2212 "a.java",
2213 ],
2214 sdk_version: "none",
2215 system_modules: "prebuilt-system-modules",
2216 }
2217
2218 java_import {
2219 name: "prebuilt-jar",
2220 jars: ["a.jar"],
2221 }
2222
2223 java_system_modules_import {
2224 name: "prebuilt-system-modules",
2225 libs: ["prebuilt-jar"],
2226 }
2227 `)
2228
2229 checkBootClasspathForSystemModule(t, ctx, "lib-with-source-system-modules", "/source-jar.jar")
2230
2231 checkBootClasspathForSystemModule(t, ctx, "lib-with-prebuilt-system-modules", "/prebuilt-jar.jar")
2232}
2233
2234func checkBootClasspathForSystemModule(t *testing.T, ctx *android.TestContext, moduleName string, expectedSuffix string) {
2235 javacRule := ctx.ModuleForTests(moduleName, "android_common").Rule("javac")
2236 bootClasspath := javacRule.Args["bootClasspath"]
2237 if strings.HasPrefix(bootClasspath, "--system ") && strings.HasSuffix(bootClasspath, expectedSuffix) {
2238 t.Errorf("bootclasspath of %q must start with --system and end with %q, but was %#v.", moduleName, expectedSuffix, bootClasspath)
2239 }
2240}
Jiyong Park19604de2020-03-24 16:44:11 +09002241
2242func TestAidlExportIncludeDirsFromImports(t *testing.T) {
2243 ctx, _ := testJava(t, `
2244 java_library {
2245 name: "foo",
2246 srcs: ["aidl/foo/IFoo.aidl"],
2247 libs: ["bar"],
2248 }
2249
2250 java_import {
2251 name: "bar",
2252 jars: ["a.jar"],
2253 aidl: {
2254 export_include_dirs: ["aidl/bar"],
2255 },
2256 }
2257 `)
2258
2259 aidlCommand := ctx.ModuleForTests("foo", "android_common").Rule("aidl").RuleParams.Command
2260 expectedAidlFlag := "-Iaidl/bar"
2261 if !strings.Contains(aidlCommand, expectedAidlFlag) {
2262 t.Errorf("aidl command %q does not contain %q", aidlCommand, expectedAidlFlag)
2263 }
2264}
Liz Kammerdd849a82020-06-12 16:38:45 -07002265
2266func TestDataNativeBinaries(t *testing.T) {
2267 ctx, config := testJava(t, `
2268 java_test_host {
2269 name: "foo",
2270 srcs: ["a.java"],
2271 data_native_bins: ["bin"]
2272 }
2273
2274 python_binary_host {
2275 name: "bin",
2276 srcs: ["bin.py"],
2277 }
2278 `)
2279
2280 buildOS := android.BuildOs.String()
2281
2282 test := ctx.ModuleForTests("foo", buildOS+"_common").Module().(*TestHost)
2283 entries := android.AndroidMkEntriesForTest(t, config, "", test)[0]
2284 expected := []string{buildDir + "/.intermediates/bin/" + buildOS + "_x86_64_PY3/bin:bin"}
2285 actual := entries.EntryMap["LOCAL_COMPATIBILITY_SUPPORT_FILES"]
2286 if !reflect.DeepEqual(expected, actual) {
2287 t.Errorf("Unexpected test data - expected: %q, actual: %q", expected, actual)
2288 }
2289}