blob: 9895a2043f4da5f012ec3a51ad6eb09b01a29439 [file] [log] [blame]
Jingwen Chen91220d72021-03-24 02:18:33 -04001// Copyright 2021 Google Inc. All rights reserved.
2//
3// Licensed under the Apache License, Version 2.0 (the "License");
4// you may not use this file except in compliance with the License.
5// You may obtain a copy of the License at
6//
Cole Faust7071a052022-07-29 15:58:33 -07007// http://www.apache.org/licenses/LICENSE-2.0
Jingwen Chen91220d72021-03-24 02:18:33 -04008//
9// Unless required by applicable law or agreed to in writing, software
10// distributed under the License is distributed on an "AS IS" BASIS,
11// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
12// See the License for the specific language governing permissions and
13// limitations under the License.
14package cc
15
16import (
Liz Kammerd2871182021-10-04 13:54:37 -040017 "fmt"
Jingwen Chened9c17d2021-04-13 07:14:55 +000018 "path/filepath"
Jingwen Chen3950cd62021-05-12 04:33:00 +000019 "strings"
Spandan Das4242f102023-04-19 22:31:54 +000020 "sync"
Chris Parsons484e50a2021-05-13 15:13:04 -040021
22 "android/soong/android"
23 "android/soong/bazel"
Alix1be00d42022-05-16 22:56:04 +000024 "android/soong/cc/config"
Liz Kammer7a210ac2021-09-22 15:52:58 -040025
Chris Parsons953b3562021-09-20 15:14:39 -040026 "github.com/google/blueprint"
Liz Kammerba7a9c52021-05-26 08:45:30 -040027
28 "github.com/google/blueprint/proptools"
Jingwen Chen91220d72021-03-24 02:18:33 -040029)
30
Liz Kammerae3994e2021-10-19 09:45:48 -040031const (
Trevor Radcliffecee4e052022-09-06 19:31:25 +000032 cSrcPartition = "c"
33 asSrcPartition = "as"
34 asmSrcPartition = "asm"
35 lSrcPartition = "l"
36 llSrcPartition = "ll"
37 cppSrcPartition = "cpp"
38 protoSrcPartition = "proto"
39 aidlSrcPartition = "aidl"
40 syspropSrcPartition = "sysprop"
Alixe2667872023-04-24 14:57:32 +000041
42 yaccSrcPartition = "yacc"
43
44 rScriptSrcPartition = "renderScript"
Liz Kammer91487d42022-09-13 11:27:11 -040045
Liz Kammer5f5dbaa2023-07-17 17:44:08 -040046 xsdSrcPartition = "xsd"
47
48 hdrPartition = "hdr"
49
Liz Kammer91487d42022-09-13 11:27:11 -040050 stubsSuffix = "_stub_libs_current"
Liz Kammerae3994e2021-10-19 09:45:48 -040051)
52
Liz Kammer2222c6b2021-05-24 15:41:47 -040053// staticOrSharedAttributes are the Bazel-ified versions of StaticOrSharedProperties --
Jingwen Chenbcf53042021-05-26 04:42:42 +000054// properties which apply to either the shared or static version of a cc_library module.
Liz Kammer2222c6b2021-05-24 15:41:47 -040055type staticOrSharedAttributes struct {
Vinh Tran9f6796a2022-08-16 13:10:31 -040056 Srcs bazel.LabelListAttribute
57 Srcs_c bazel.LabelListAttribute
58 Srcs_as bazel.LabelListAttribute
59 Srcs_aidl bazel.LabelListAttribute
60 Hdrs bazel.LabelListAttribute
61 Copts bazel.StringListAttribute
Jingwen Chen14a8bda2021-06-02 11:10:02 +000062
Liz Kammer12615db2021-09-28 09:19:17 -040063 Deps bazel.LabelListAttribute
64 Implementation_deps bazel.LabelListAttribute
65 Dynamic_deps bazel.LabelListAttribute
66 Implementation_dynamic_deps bazel.LabelListAttribute
67 Whole_archive_deps bazel.LabelListAttribute
68 Implementation_whole_archive_deps bazel.LabelListAttribute
Cole Faust6b29f592022-08-09 09:50:56 -070069 Runtime_deps bazel.LabelListAttribute
Chris Parsons51f8c392021-08-03 21:01:05 -040070
71 System_dynamic_deps bazel.LabelListAttribute
Chris Parsons58852a02021-12-09 18:10:18 -050072
73 Enabled bazel.BoolAttribute
Yu Liufc603162022-03-01 15:44:08 -080074
Yu Liuf01a0f02022-12-07 15:45:30 -080075 Native_coverage *bool
Yu Liu8d82ac52022-05-17 15:13:28 -070076
Liz Kammeraceec252023-03-24 09:46:36 -040077 Apex_available []string
78
Trevor Radcliffea8b44162023-04-14 18:25:24 +000079 Features bazel.StringListAttribute
80
Yu Liufc603162022-03-01 15:44:08 -080081 sdkAttributes
Sam Delmericofb3bb322022-10-21 10:42:24 -040082
83 tidyAttributes
84}
85
86type tidyAttributes struct {
Sam Delmerico63f0c932023-03-14 14:05:28 -040087 Tidy *string
Sam Delmericofb3bb322022-10-21 10:42:24 -040088 Tidy_flags []string
89 Tidy_checks []string
90 Tidy_checks_as_errors []string
Sam Delmericoc9b8fbd2022-10-25 15:47:17 -040091 Tidy_disabled_srcs bazel.LabelListAttribute
Sam Delmerico4c902d62022-11-02 14:17:15 -040092 Tidy_timeout_srcs bazel.LabelListAttribute
Sam Delmericofb3bb322022-10-21 10:42:24 -040093}
94
Sam Delmericoc9b8fbd2022-10-25 15:47:17 -040095func (m *Module) convertTidyAttributes(ctx android.BaseMutatorContext, moduleAttrs *tidyAttributes) {
Sam Delmericofb3bb322022-10-21 10:42:24 -040096 for _, f := range m.features {
97 if tidy, ok := f.(*tidyFeature); ok {
Sam Delmerico63f0c932023-03-14 14:05:28 -040098 var tidyAttr *string
99 if tidy.Properties.Tidy != nil {
100 if *tidy.Properties.Tidy {
101 tidyAttr = proptools.StringPtr("local")
102 } else {
103 tidyAttr = proptools.StringPtr("never")
104 }
105 }
106 moduleAttrs.Tidy = tidyAttr
Sam Delmericofb3bb322022-10-21 10:42:24 -0400107 moduleAttrs.Tidy_flags = tidy.Properties.Tidy_flags
108 moduleAttrs.Tidy_checks = tidy.Properties.Tidy_checks
109 moduleAttrs.Tidy_checks_as_errors = tidy.Properties.Tidy_checks_as_errors
110 }
Sam Delmericoc9b8fbd2022-10-25 15:47:17 -0400111
112 }
Sam Delmericoc9b8fbd2022-10-25 15:47:17 -0400113 archVariantProps := m.GetArchVariantProperties(ctx, &BaseCompilerProperties{})
114 for axis, configToProps := range archVariantProps {
Sasha Smundak39a301c2022-12-29 17:11:49 -0800115 for cfg, _props := range configToProps {
Sam Delmericoc9b8fbd2022-10-25 15:47:17 -0400116 if archProps, ok := _props.(*BaseCompilerProperties); ok {
117 archDisabledSrcs := android.BazelLabelForModuleSrc(ctx, archProps.Tidy_disabled_srcs)
Sasha Smundak39a301c2022-12-29 17:11:49 -0800118 moduleAttrs.Tidy_disabled_srcs.SetSelectValue(axis, cfg, archDisabledSrcs)
Sam Delmerico4c902d62022-11-02 14:17:15 -0400119 archTimeoutSrcs := android.BazelLabelForModuleSrc(ctx, archProps.Tidy_timeout_srcs)
Sasha Smundak39a301c2022-12-29 17:11:49 -0800120 moduleAttrs.Tidy_timeout_srcs.SetSelectValue(axis, cfg, archTimeoutSrcs)
Sam Delmericoc9b8fbd2022-10-25 15:47:17 -0400121 }
122 }
Sam Delmericofb3bb322022-10-21 10:42:24 -0400123 }
Jingwen Chen53681ef2021-04-29 08:15:13 +0000124}
125
Sam Delmericoc7681022022-02-04 21:01:20 +0000126// groupSrcsByExtension partitions `srcs` into groups based on file extension.
Jingwen Chen55bc8202021-11-02 06:40:51 +0000127func groupSrcsByExtension(ctx android.BazelConversionPathContext, srcs bazel.LabelListAttribute) bazel.PartitionToLabelListAttribute {
Liz Kammer57e2e7a2021-09-20 12:55:02 -0400128 // Convert filegroup dependencies into extension-specific filegroups filtered in the filegroup.bzl
129 // macro.
130 addSuffixForFilegroup := func(suffix string) bazel.LabelMapper {
Vinh Tran9f6796a2022-08-16 13:10:31 -0400131 return func(otherModuleCtx bazel.OtherModuleContext, label bazel.Label) (string, bool) {
132
133 m, exists := otherModuleCtx.ModuleFromName(label.OriginalModuleName)
Liz Kammer12615db2021-09-28 09:19:17 -0400134 labelStr := label.Label
Vinh Tran9f6796a2022-08-16 13:10:31 -0400135 if !exists || !android.IsFilegroup(otherModuleCtx, m) {
136 return labelStr, false
137 }
Yu Liu2aa806b2022-09-01 11:54:47 -0700138 // If the filegroup is already converted to aidl_library or proto_library,
139 // skip creating _c_srcs, _as_srcs, _cpp_srcs filegroups
140 fg, _ := m.(android.FileGroupAsLibrary)
141 if fg.ShouldConvertToAidlLibrary(ctx) || fg.ShouldConvertToProtoLibrary(ctx) {
Liz Kammer12615db2021-09-28 09:19:17 -0400142 return labelStr, false
Jingwen Chen14a8bda2021-06-02 11:10:02 +0000143 }
Liz Kammer12615db2021-09-28 09:19:17 -0400144 return labelStr + suffix, true
Chris Parsons5a34ffb2021-07-21 14:34:58 -0400145 }
Jingwen Chen14a8bda2021-06-02 11:10:02 +0000146 }
147
Liz Kammer57e2e7a2021-09-20 12:55:02 -0400148 // TODO(b/190006308): Handle language detection of sources in a Bazel rule.
Sam Delmericoc7681022022-02-04 21:01:20 +0000149 labels := bazel.LabelPartitions{
150 protoSrcPartition: android.ProtoSrcLabelPartition,
Liz Kammeraabfb5d2021-12-08 15:25:06 -0500151 cSrcPartition: bazel.LabelPartition{Extensions: []string{".c"}, LabelMapper: addSuffixForFilegroup("_c_srcs")},
152 asSrcPartition: bazel.LabelPartition{Extensions: []string{".s", ".S"}, LabelMapper: addSuffixForFilegroup("_as_srcs")},
Cole Faust7071a052022-07-29 15:58:33 -0700153 asmSrcPartition: bazel.LabelPartition{Extensions: []string{".asm"}},
Vinh Tran9f6796a2022-08-16 13:10:31 -0400154 aidlSrcPartition: android.AidlSrcLabelPartition,
Trevor Radcliffeef9c9002022-05-13 20:55:35 +0000155 // TODO(http://b/231968910): If there is ever a filegroup target that
156 // contains .l or .ll files we will need to find a way to add a
157 // LabelMapper for these that identifies these filegroups and
158 // converts them appropriately
Alixe2667872023-04-24 14:57:32 +0000159 lSrcPartition: bazel.LabelPartition{Extensions: []string{".l"}},
160 llSrcPartition: bazel.LabelPartition{Extensions: []string{".ll"}},
161 rScriptSrcPartition: bazel.LabelPartition{Extensions: []string{".fs", ".rscript"}},
Liz Kammer5f5dbaa2023-07-17 17:44:08 -0400162 xsdSrcPartition: bazel.LabelPartition{LabelMapper: android.XsdLabelMapper(xsdConfigCppTarget)},
Liz Kammer57e2e7a2021-09-20 12:55:02 -0400163 // C++ is the "catch-all" group, and comprises generated sources because we don't
164 // know the language of these sources until the genrule is executed.
Trevor Radcliffecee4e052022-09-06 19:31:25 +0000165 cppSrcPartition: bazel.LabelPartition{Extensions: []string{".cpp", ".cc", ".cxx", ".mm"}, LabelMapper: addSuffixForFilegroup("_cpp_srcs"), Keep_remainder: true},
166 syspropSrcPartition: bazel.LabelPartition{Extensions: []string{".sysprop"}},
Spandan Dasdf4c2132023-05-09 23:58:52 +0000167 yaccSrcPartition: bazel.LabelPartition{Extensions: []string{".y", "yy"}},
Sam Delmericoc7681022022-02-04 21:01:20 +0000168 }
Jingwen Chen14a8bda2021-06-02 11:10:02 +0000169
Sam Delmericoc7681022022-02-04 21:01:20 +0000170 return bazel.PartitionLabelListAttribute(ctx, &srcs, labels)
Jingwen Chen14a8bda2021-06-02 11:10:02 +0000171}
172
Liz Kammer5f5dbaa2023-07-17 17:44:08 -0400173func partitionHeaders(ctx android.BazelConversionPathContext, hdrs bazel.LabelListAttribute) bazel.PartitionToLabelListAttribute {
174 labels := bazel.LabelPartitions{
175 xsdSrcPartition: bazel.LabelPartition{LabelMapper: android.XsdLabelMapper(xsdConfigCppTarget)},
176 hdrPartition: bazel.LabelPartition{Keep_remainder: true},
177 }
178 return bazel.PartitionLabelListAttribute(ctx, &hdrs, labels)
179}
180
Alex Márquez Pérez Muñíz Díaz Púras Thaureauxac5097f2021-09-01 21:22:09 +0000181// bp2BuildParseLibProps returns the attributes for a variant of a cc_library.
Jingwen Chen55bc8202021-11-02 06:40:51 +0000182func bp2BuildParseLibProps(ctx android.BazelConversionPathContext, module *Module, isStatic bool) staticOrSharedAttributes {
Jingwen Chen53681ef2021-04-29 08:15:13 +0000183 lib, ok := module.compiler.(*libraryDecorator)
184 if !ok {
Liz Kammer2222c6b2021-05-24 15:41:47 -0400185 return staticOrSharedAttributes{}
Jingwen Chen53681ef2021-04-29 08:15:13 +0000186 }
Alex Márquez Pérez Muñíz Díaz Púras Thaureauxac5097f2021-09-01 21:22:09 +0000187 return bp2buildParseStaticOrSharedProps(ctx, module, lib, isStatic)
188}
Jingwen Chen53681ef2021-04-29 08:15:13 +0000189
Alex Márquez Pérez Muñíz Díaz Púras Thaureauxac5097f2021-09-01 21:22:09 +0000190// bp2buildParseSharedProps returns the attributes for the shared variant of a cc_library.
Jingwen Chen55bc8202021-11-02 06:40:51 +0000191func bp2BuildParseSharedProps(ctx android.BazelConversionPathContext, module *Module) staticOrSharedAttributes {
Alex Márquez Pérez Muñíz Díaz Púras Thaureauxac5097f2021-09-01 21:22:09 +0000192 return bp2BuildParseLibProps(ctx, module, false)
Jingwen Chen53681ef2021-04-29 08:15:13 +0000193}
194
195// bp2buildParseStaticProps returns the attributes for the static variant of a cc_library.
Jingwen Chen55bc8202021-11-02 06:40:51 +0000196func bp2BuildParseStaticProps(ctx android.BazelConversionPathContext, module *Module) staticOrSharedAttributes {
Alex Márquez Pérez Muñíz Díaz Púras Thaureauxac5097f2021-09-01 21:22:09 +0000197 return bp2BuildParseLibProps(ctx, module, true)
Liz Kammer2222c6b2021-05-24 15:41:47 -0400198}
199
Liz Kammer7a210ac2021-09-22 15:52:58 -0400200type depsPartition struct {
201 export bazel.LabelList
202 implementation bazel.LabelList
203}
204
Jingwen Chen55bc8202021-11-02 06:40:51 +0000205type bazelLabelForDepsFn func(android.BazelConversionPathContext, []string) bazel.LabelList
Liz Kammer7a210ac2021-09-22 15:52:58 -0400206
Jingwen Chen55bc8202021-11-02 06:40:51 +0000207func maybePartitionExportedAndImplementationsDeps(ctx android.BazelConversionPathContext, exportsDeps bool, allDeps, exportedDeps []string, fn bazelLabelForDepsFn) depsPartition {
Liz Kammer2b8004b2021-10-04 13:55:44 -0400208 if !exportsDeps {
209 return depsPartition{
210 implementation: fn(ctx, allDeps),
211 }
212 }
213
Liz Kammer7a210ac2021-09-22 15:52:58 -0400214 implementation, export := android.FilterList(allDeps, exportedDeps)
215
216 return depsPartition{
217 export: fn(ctx, export),
218 implementation: fn(ctx, implementation),
219 }
220}
221
Jingwen Chen55bc8202021-11-02 06:40:51 +0000222type bazelLabelForDepsExcludesFn func(android.BazelConversionPathContext, []string, []string) bazel.LabelList
Liz Kammer7a210ac2021-09-22 15:52:58 -0400223
Jingwen Chen55bc8202021-11-02 06:40:51 +0000224func maybePartitionExportedAndImplementationsDepsExcludes(ctx android.BazelConversionPathContext, exportsDeps bool, allDeps, excludes, exportedDeps []string, fn bazelLabelForDepsExcludesFn) depsPartition {
Liz Kammer2b8004b2021-10-04 13:55:44 -0400225 if !exportsDeps {
226 return depsPartition{
227 implementation: fn(ctx, allDeps, excludes),
228 }
229 }
Liz Kammer7a210ac2021-09-22 15:52:58 -0400230 implementation, export := android.FilterList(allDeps, exportedDeps)
231
232 return depsPartition{
233 export: fn(ctx, export, excludes),
234 implementation: fn(ctx, implementation, excludes),
235 }
236}
237
Alex Márquez Pérez Muñíz Díaz Púras Thaureauxb12ff592022-09-01 15:04:04 +0000238func bp2BuildPropParseHelper(ctx android.ArchVariantContext, module *Module, propsType interface{}, parseFunc func(axis bazel.ConfigurationAxis, config string, props interface{})) {
239 for axis, configToProps := range module.GetArchVariantProperties(ctx, propsType) {
Sasha Smundak39a301c2022-12-29 17:11:49 -0800240 for cfg, props := range configToProps {
241 parseFunc(axis, cfg, props)
Alex Márquez Pérez Muñíz Díaz Púras Thaureauxb12ff592022-09-01 15:04:04 +0000242 }
243 }
244}
245
Trevor Radcliffe58ea4512022-04-07 20:36:39 +0000246// Parses properties common to static and shared libraries. Also used for prebuilt libraries.
Liz Kammeraceec252023-03-24 09:46:36 -0400247func bp2buildParseStaticOrSharedProps(ctx android.BazelConversionPathContext, module *Module, lib *libraryDecorator, isStatic bool) staticOrSharedAttributes {
Liz Kammer135bf552021-08-11 10:46:06 -0400248 attrs := staticOrSharedAttributes{}
Jingwen Chenbcf53042021-05-26 04:42:42 +0000249
Liz Kammer9abd62d2021-05-21 08:37:59 -0400250 setAttrs := func(axis bazel.ConfigurationAxis, config string, props StaticOrSharedProperties) {
Trevor Radcliffea8b44162023-04-14 18:25:24 +0000251 attrs.Copts.SetSelectValue(axis, config, parseCommandLineFlags(props.Cflags, filterOutStdFlag, filterOutHiddenVisibility))
Jingwen Chenc4dc9b42021-06-11 12:51:48 +0000252 attrs.Srcs.SetSelectValue(axis, config, android.BazelLabelForModuleSrc(ctx, props.Srcs))
Chris Parsons953b3562021-09-20 15:14:39 -0400253 attrs.System_dynamic_deps.SetSelectValue(axis, config, bazelLabelForSharedDeps(ctx, props.System_shared_libs))
Liz Kammer7a210ac2021-09-22 15:52:58 -0400254
Liz Kammer2b8004b2021-10-04 13:55:44 -0400255 staticDeps := maybePartitionExportedAndImplementationsDeps(ctx, true, props.Static_libs, props.Export_static_lib_headers, bazelLabelForStaticDeps)
Liz Kammer7a210ac2021-09-22 15:52:58 -0400256 attrs.Deps.SetSelectValue(axis, config, staticDeps.export)
257 attrs.Implementation_deps.SetSelectValue(axis, config, staticDeps.implementation)
258
Liz Kammer2b8004b2021-10-04 13:55:44 -0400259 sharedDeps := maybePartitionExportedAndImplementationsDeps(ctx, true, props.Shared_libs, props.Export_shared_lib_headers, bazelLabelForSharedDeps)
Liz Kammer7a210ac2021-09-22 15:52:58 -0400260 attrs.Dynamic_deps.SetSelectValue(axis, config, sharedDeps.export)
261 attrs.Implementation_dynamic_deps.SetSelectValue(axis, config, sharedDeps.implementation)
262
263 attrs.Whole_archive_deps.SetSelectValue(axis, config, bazelLabelForWholeDeps(ctx, props.Whole_static_libs))
Chris Parsons58852a02021-12-09 18:10:18 -0500264 attrs.Enabled.SetSelectValue(axis, config, props.Enabled)
Jingwen Chenbcf53042021-05-26 04:42:42 +0000265 }
Liz Kammer135bf552021-08-11 10:46:06 -0400266 // system_dynamic_deps distinguishes between nil/empty list behavior:
267 // nil -> use default values
268 // empty list -> no values specified
269 attrs.System_dynamic_deps.ForceSpecifyEmptyList = true
Jingwen Chenbcf53042021-05-26 04:42:42 +0000270
Liz Kammeraceec252023-03-24 09:46:36 -0400271 var apexAvailable []string
Jingwen Chenbcf53042021-05-26 04:42:42 +0000272 if isStatic {
Liz Kammeraceec252023-03-24 09:46:36 -0400273 apexAvailable = lib.StaticProperties.Static.Apex_available
Trevor Radcliffe542954f2022-04-21 20:04:42 +0000274 bp2BuildPropParseHelper(ctx, module, &StaticProperties{}, func(axis bazel.ConfigurationAxis, config string, props interface{}) {
275 if staticOrSharedProps, ok := props.(*StaticProperties); ok {
276 setAttrs(axis, config, staticOrSharedProps.Static)
Jingwen Chenbcf53042021-05-26 04:42:42 +0000277 }
Trevor Radcliffe542954f2022-04-21 20:04:42 +0000278 })
Jingwen Chenbcf53042021-05-26 04:42:42 +0000279 } else {
Liz Kammeraceec252023-03-24 09:46:36 -0400280 apexAvailable = lib.SharedProperties.Shared.Apex_available
Trevor Radcliffe542954f2022-04-21 20:04:42 +0000281 bp2BuildPropParseHelper(ctx, module, &SharedProperties{}, func(axis bazel.ConfigurationAxis, config string, props interface{}) {
282 if staticOrSharedProps, ok := props.(*SharedProperties); ok {
283 setAttrs(axis, config, staticOrSharedProps.Shared)
Jingwen Chenbcf53042021-05-26 04:42:42 +0000284 }
Trevor Radcliffe542954f2022-04-21 20:04:42 +0000285 })
Jingwen Chenbcf53042021-05-26 04:42:42 +0000286 }
287
Liz Kammerae3994e2021-10-19 09:45:48 -0400288 partitionedSrcs := groupSrcsByExtension(ctx, attrs.Srcs)
289 attrs.Srcs = partitionedSrcs[cppSrcPartition]
290 attrs.Srcs_c = partitionedSrcs[cSrcPartition]
291 attrs.Srcs_as = partitionedSrcs[asSrcPartition]
Jingwen Chen14a8bda2021-06-02 11:10:02 +0000292
Spandan Das39b6cc52023-04-12 19:05:49 +0000293 attrs.Apex_available = android.ConvertApexAvailableToTagsWithoutTestApexes(ctx.(android.TopDownMutatorContext), apexAvailable)
Liz Kammeraceec252023-03-24 09:46:36 -0400294
Trevor Radcliffea8b44162023-04-14 18:25:24 +0000295 attrs.Features.Append(convertHiddenVisibilityToFeatureStaticOrShared(ctx, module, isStatic))
296
Liz Kammer12615db2021-09-28 09:19:17 -0400297 if !partitionedSrcs[protoSrcPartition].IsEmpty() {
298 // TODO(b/208815215): determine whether this is used and add support if necessary
299 ctx.ModuleErrorf("Migrating static/shared only proto srcs is not currently supported")
300 }
301
Jingwen Chenbcf53042021-05-26 04:42:42 +0000302 return attrs
Jingwen Chen53681ef2021-04-29 08:15:13 +0000303}
304
Rupert Shuttleworthffd45822021-05-14 03:02:34 -0400305// Convenience struct to hold all attributes parsed from prebuilt properties.
306type prebuiltAttributes struct {
Trevor Radcliffe58ea4512022-04-07 20:36:39 +0000307 Src bazel.LabelAttribute
308 Enabled bazel.BoolAttribute
Rupert Shuttleworthffd45822021-05-14 03:02:34 -0400309}
310
Alex Márquez Pérez Muñíz Díaz Púras Thaureauxb12ff592022-09-01 15:04:04 +0000311func parseSrc(ctx android.BazelConversionPathContext, srcLabelAttribute *bazel.LabelAttribute, axis bazel.ConfigurationAxis, config string, srcs []string) {
312 srcFileError := func() {
313 ctx.ModuleErrorf("parseSrc: Expected at most one source file for %s %s\n", axis, config)
314 }
315 if len(srcs) > 1 {
316 srcFileError()
317 return
318 } else if len(srcs) == 0 {
319 return
320 }
321 if srcLabelAttribute.SelectValue(axis, config) != nil {
322 srcFileError()
323 return
324 }
325 srcLabelAttribute.SetSelectValue(axis, config, android.BazelLabelForModuleSrcSingle(ctx, srcs[0]))
326}
327
Alex Márquez Pérez Muñíz Díaz Púras Thaureauxac5097f2021-09-01 21:22:09 +0000328// NOTE: Used outside of Soong repo project, in the clangprebuilts.go bootstrap_go_package
Trevor Radcliffe58ea4512022-04-07 20:36:39 +0000329func Bp2BuildParsePrebuiltLibraryProps(ctx android.BazelConversionPathContext, module *Module, isStatic bool) prebuiltAttributes {
Alex Márquez Pérez Muñíz Díaz Púras Thaureauxb12ff592022-09-01 15:04:04 +0000330
Rupert Shuttleworthffd45822021-05-14 03:02:34 -0400331 var srcLabelAttribute bazel.LabelAttribute
Trevor Radcliffe58ea4512022-04-07 20:36:39 +0000332 bp2BuildPropParseHelper(ctx, module, &prebuiltLinkerProperties{}, func(axis bazel.ConfigurationAxis, config string, props interface{}) {
333 if prebuiltLinkerProperties, ok := props.(*prebuiltLinkerProperties); ok {
Alex Márquez Pérez Muñíz Díaz Púras Thaureauxb12ff592022-09-01 15:04:04 +0000334 parseSrc(ctx, &srcLabelAttribute, axis, config, prebuiltLinkerProperties.Srcs)
Trevor Radcliffe58ea4512022-04-07 20:36:39 +0000335 }
336 })
337
338 var enabledLabelAttribute bazel.BoolAttribute
339 parseAttrs := func(axis bazel.ConfigurationAxis, config string, props StaticOrSharedProperties) {
340 if props.Enabled != nil {
341 enabledLabelAttribute.SetSelectValue(axis, config, props.Enabled)
342 }
Alex Márquez Pérez Muñíz Díaz Púras Thaureauxb12ff592022-09-01 15:04:04 +0000343 parseSrc(ctx, &srcLabelAttribute, axis, config, props.Srcs)
Trevor Radcliffe58ea4512022-04-07 20:36:39 +0000344 }
345
346 if isStatic {
347 bp2BuildPropParseHelper(ctx, module, &StaticProperties{}, func(axis bazel.ConfigurationAxis, config string, props interface{}) {
348 if staticProperties, ok := props.(*StaticProperties); ok {
349 parseAttrs(axis, config, staticProperties.Static)
350 }
351 })
352 } else {
353 bp2BuildPropParseHelper(ctx, module, &SharedProperties{}, func(axis bazel.ConfigurationAxis, config string, props interface{}) {
354 if sharedProperties, ok := props.(*SharedProperties); ok {
355 parseAttrs(axis, config, sharedProperties.Shared)
356 }
357 })
Rupert Shuttleworthffd45822021-05-14 03:02:34 -0400358 }
359
Rupert Shuttleworthffd45822021-05-14 03:02:34 -0400360 return prebuiltAttributes{
Trevor Radcliffe58ea4512022-04-07 20:36:39 +0000361 Src: srcLabelAttribute,
362 Enabled: enabledLabelAttribute,
363 }
364}
365
Alex Márquez Pérez Muñíz Díaz Púras Thaureauxb12ff592022-09-01 15:04:04 +0000366func bp2BuildParsePrebuiltBinaryProps(ctx android.BazelConversionPathContext, module *Module) prebuiltAttributes {
367 var srcLabelAttribute bazel.LabelAttribute
368 bp2BuildPropParseHelper(ctx, module, &prebuiltLinkerProperties{}, func(axis bazel.ConfigurationAxis, config string, props interface{}) {
369 if props, ok := props.(*prebuiltLinkerProperties); ok {
370 parseSrc(ctx, &srcLabelAttribute, axis, config, props.Srcs)
Trevor Radcliffe58ea4512022-04-07 20:36:39 +0000371 }
Alex Márquez Pérez Muñíz Díaz Púras Thaureauxb12ff592022-09-01 15:04:04 +0000372 })
373
374 return prebuiltAttributes{
375 Src: srcLabelAttribute,
Rupert Shuttleworthffd45822021-05-14 03:02:34 -0400376 }
377}
378
Colin Crossc5075e92022-12-05 16:46:39 -0800379func bp2BuildParsePrebuiltObjectProps(ctx android.BazelConversionPathContext, module *Module) prebuiltAttributes {
380 var srcLabelAttribute bazel.LabelAttribute
381 bp2BuildPropParseHelper(ctx, module, &prebuiltObjectProperties{}, func(axis bazel.ConfigurationAxis, config string, props interface{}) {
382 if props, ok := props.(*prebuiltObjectProperties); ok {
383 parseSrc(ctx, &srcLabelAttribute, axis, config, props.Srcs)
384 }
385 })
386
387 return prebuiltAttributes{
388 Src: srcLabelAttribute,
389 }
390}
391
Liz Kammere6583482021-10-19 13:56:10 -0400392type baseAttributes struct {
393 compilerAttributes
394 linkerAttributes
Liz Kammer12615db2021-09-28 09:19:17 -0400395
Trevor Radcliffedb7e0262022-10-28 16:48:18 +0000396 // A combination of compilerAttributes.features and linkerAttributes.features, as well as sanitizer features
Cole Faust5fa4e962022-08-22 14:31:04 -0700397 features bazel.StringListAttribute
Liz Kammer12615db2021-09-28 09:19:17 -0400398 protoDependency *bazel.LabelAttribute
Vinh Tran9f6796a2022-08-16 13:10:31 -0400399 aidlDependency *bazel.LabelAttribute
Yu Liuf01a0f02022-12-07 15:45:30 -0800400 Native_coverage *bool
Liz Kammere6583482021-10-19 13:56:10 -0400401}
402
Jingwen Chen107c0de2021-04-09 10:43:12 +0000403// Convenience struct to hold all attributes parsed from compiler properties.
404type compilerAttributes struct {
Chris Parsons990c4f42021-05-25 12:10:58 -0400405 // Options for all languages
406 copts bazel.StringListAttribute
407 // Assembly options and sources
408 asFlags bazel.StringListAttribute
409 asSrcs bazel.LabelListAttribute
Cole Faust7071a052022-07-29 15:58:33 -0700410 asmSrcs bazel.LabelListAttribute
Chris Parsons990c4f42021-05-25 12:10:58 -0400411 // C options and sources
412 conlyFlags bazel.StringListAttribute
413 cSrcs bazel.LabelListAttribute
414 // C++ options and sources
415 cppFlags bazel.StringListAttribute
Jingwen Chened9c17d2021-04-13 07:14:55 +0000416 srcs bazel.LabelListAttribute
Chris Parsons2c788392021-08-10 11:58:07 -0400417
Liz Kammer084d6a92023-06-22 16:23:53 -0400418 // xsd config sources
Liz Kammer5f5dbaa2023-07-17 17:44:08 -0400419 xsdSrcs bazel.LabelListAttribute
420 exportXsdSrcs bazel.LabelListAttribute
Liz Kammer084d6a92023-06-22 16:23:53 -0400421
Trevor Radcliffeef9c9002022-05-13 20:55:35 +0000422 // Lex sources and options
423 lSrcs bazel.LabelListAttribute
424 llSrcs bazel.LabelListAttribute
425 lexopts bazel.StringListAttribute
426
Trevor Radcliffecee4e052022-09-06 19:31:25 +0000427 // Sysprop sources
428 syspropSrcs bazel.LabelListAttribute
429
Spandan Dasdf4c2132023-05-09 23:58:52 +0000430 // Yacc sources
431 yaccSrc *bazel.LabelAttribute
432 yaccFlags bazel.StringListAttribute
433 yaccGenLocationHeader bazel.BoolAttribute
434 yaccGenPositionHeader bazel.BoolAttribute
435
Alixe2667872023-04-24 14:57:32 +0000436 rsSrcs bazel.LabelListAttribute
437
Liz Kammere6583482021-10-19 13:56:10 -0400438 hdrs bazel.LabelListAttribute
439
Chris Parsons2c788392021-08-10 11:58:07 -0400440 rtti bazel.BoolAttribute
Jingwen Chen5b11ab12021-10-11 17:44:33 +0000441
442 // Not affected by arch variants
443 stl *string
Chris Parsons79bd2b72021-11-29 17:52:41 -0500444 cStd *string
Jingwen Chen5b11ab12021-10-11 17:44:33 +0000445 cppStd *string
Liz Kammer35687bc2021-09-10 10:07:07 -0400446
447 localIncludes bazel.StringListAttribute
448 absoluteIncludes bazel.StringListAttribute
Liz Kammer12615db2021-09-28 09:19:17 -0400449
Liz Kammer1263d9b2021-12-10 14:28:20 -0500450 includes BazelIncludes
451
Alixe2667872023-04-24 14:57:32 +0000452 protoSrcs bazel.LabelListAttribute
453 aidlSrcs bazel.LabelListAttribute
454 rscriptSrcs bazel.LabelListAttribute
Jingwen Chen0ee88a62022-01-07 14:55:29 +0000455
456 stubsSymbolFile *string
457 stubsVersions bazel.StringListAttribute
Cole Faust5fa4e962022-08-22 14:31:04 -0700458
459 features bazel.StringListAttribute
Alex Márquez Pérez Muñíz Díaz Púras Thaureauxa56e9702022-02-23 18:39:59 -0500460
Spandan Das39ccf932023-05-26 18:03:39 +0000461 stem bazel.StringAttribute
Alex Márquez Pérez Muñíz Díaz Púras Thaureauxa56e9702022-02-23 18:39:59 -0500462 suffix bazel.StringAttribute
Vinh Tran99270ea2022-11-28 11:15:23 -0500463
464 fdoProfile bazel.LabelAttribute
Jingwen Chen107c0de2021-04-09 10:43:12 +0000465}
466
Liz Kammercac7f692021-12-16 14:19:32 -0500467type filterOutFn func(string) bool
468
Trevor Radcliffea8b44162023-04-14 18:25:24 +0000469// filterOutHiddenVisibility removes the flag specifying hidden visibility as
470// this flag is converted to a toolchain feature
471func filterOutHiddenVisibility(flag string) bool {
472 return flag == config.VisibilityHiddenFlag
473}
474
Liz Kammercac7f692021-12-16 14:19:32 -0500475func filterOutStdFlag(flag string) bool {
476 return strings.HasPrefix(flag, "-std=")
477}
478
Alix1be00d42022-05-16 22:56:04 +0000479func filterOutClangUnknownCflags(flag string) bool {
480 for _, f := range config.ClangUnknownCflags {
481 if f == flag {
482 return true
483 }
484 }
485 return false
486}
487
Trevor Radcliffeea6a45d2022-09-20 18:58:01 +0000488func parseCommandLineFlags(soongFlags []string, filterOut ...filterOutFn) []string {
Liz Kammere6583482021-10-19 13:56:10 -0400489 var result []string
490 for _, flag := range soongFlags {
Alix1be00d42022-05-16 22:56:04 +0000491 skipFlag := false
492 for _, filter := range filterOut {
493 if filter != nil && filter(flag) {
494 skipFlag = true
495 }
496 }
497 if skipFlag {
Liz Kammercac7f692021-12-16 14:19:32 -0500498 continue
499 }
Liz Kammere6583482021-10-19 13:56:10 -0400500 // Soong's cflags can contain spaces, like `-include header.h`. For
501 // Bazel's copts, split them up to be compatible with the
502 // no_copts_tokenization feature.
Trevor Radcliffeea6a45d2022-09-20 18:58:01 +0000503 result = append(result, strings.Split(flag, " ")...)
Liz Kammere6583482021-10-19 13:56:10 -0400504 }
505 return result
506}
Jingwen Chened9c17d2021-04-13 07:14:55 +0000507
Jingwen Chen55bc8202021-11-02 06:40:51 +0000508func (ca *compilerAttributes) bp2buildForAxisAndConfig(ctx android.BazelConversionPathContext, axis bazel.ConfigurationAxis, config string, props *BaseCompilerProperties) {
Liz Kammere6583482021-10-19 13:56:10 -0400509 // If there's arch specific srcs or exclude_srcs, generate a select entry for it.
510 // TODO(b/186153868): do this for OS specific srcs and exclude_srcs too.
Liz Kammer5f5dbaa2023-07-17 17:44:08 -0400511 srcsList, ok := parseSrcs(ctx, props)
Liz Kammer084d6a92023-06-22 16:23:53 -0400512
513 if ok {
Liz Kammere6583482021-10-19 13:56:10 -0400514 ca.srcs.SetSelectValue(axis, config, srcsList)
Chris Parsons990c4f42021-05-25 12:10:58 -0400515 }
516
Liz Kammere6583482021-10-19 13:56:10 -0400517 localIncludeDirs := props.Local_include_dirs
518 if axis == bazel.NoConfigAxis {
Chris Parsons79bd2b72021-11-29 17:52:41 -0500519 ca.cStd, ca.cppStd = bp2buildResolveCppStdValue(props.C_std, props.Cpp_std, props.Gnu_extensions)
Liz Kammere6583482021-10-19 13:56:10 -0400520 if includeBuildDirectory(props.Include_build_directory) {
521 localIncludeDirs = append(localIncludeDirs, ".")
Liz Kammer222bdcf2021-10-11 14:15:51 -0400522 }
Jingwen Chene32e9e02021-04-23 09:17:24 +0000523 }
524
Liz Kammere6583482021-10-19 13:56:10 -0400525 ca.absoluteIncludes.SetSelectValue(axis, config, props.Include_dirs)
526 ca.localIncludes.SetSelectValue(axis, config, localIncludeDirs)
527
Cole Faust5fa4e962022-08-22 14:31:04 -0700528 instructionSet := proptools.StringDefault(props.Instruction_set, "")
529 if instructionSet == "arm" {
Trevor Radcliffe5f0c2ac2023-05-15 18:00:59 +0000530 ca.features.SetSelectValue(axis, config, []string{"arm_isa_arm"})
Cole Faust5fa4e962022-08-22 14:31:04 -0700531 } else if instructionSet != "" && instructionSet != "thumb" {
532 ctx.ModuleErrorf("Unknown value for instruction_set: %s", instructionSet)
533 }
534
Liz Kammercac7f692021-12-16 14:19:32 -0500535 // In Soong, cflags occur on the command line before -std=<val> flag, resulting in the value being
536 // overridden. In Bazel we always allow overriding, via flags; however, this can cause
537 // incompatibilities, so we remove "-std=" flags from Cflag properties while leaving it in other
538 // cases.
Trevor Radcliffea8b44162023-04-14 18:25:24 +0000539 ca.copts.SetSelectValue(axis, config, parseCommandLineFlags(props.Cflags, filterOutStdFlag, filterOutClangUnknownCflags, filterOutHiddenVisibility))
Trevor Radcliffeea6a45d2022-09-20 18:58:01 +0000540 ca.asFlags.SetSelectValue(axis, config, parseCommandLineFlags(props.Asflags, nil))
541 ca.conlyFlags.SetSelectValue(axis, config, parseCommandLineFlags(props.Conlyflags, filterOutClangUnknownCflags))
542 ca.cppFlags.SetSelectValue(axis, config, parseCommandLineFlags(props.Cppflags, filterOutClangUnknownCflags))
Liz Kammere6583482021-10-19 13:56:10 -0400543 ca.rtti.SetSelectValue(axis, config, props.Rtti)
544}
545
Jingwen Chen55bc8202021-11-02 06:40:51 +0000546func (ca *compilerAttributes) convertStlProps(ctx android.ArchVariantContext, module *Module) {
Trevor Radcliffe542954f2022-04-21 20:04:42 +0000547 bp2BuildPropParseHelper(ctx, module, &StlProperties{}, func(axis bazel.ConfigurationAxis, config string, props interface{}) {
548 if stlProps, ok := props.(*StlProperties); ok {
549 if stlProps.Stl == nil {
550 return
551 }
552 if ca.stl == nil {
Liz Kammer7128d382022-05-12 11:42:33 -0400553 stl := deduplicateStlInput(*stlProps.Stl)
554 ca.stl = &stl
Trevor Radcliffe542954f2022-04-21 20:04:42 +0000555 } else if ca.stl != stlProps.Stl {
556 ctx.ModuleErrorf("Unsupported conversion: module with different stl for different variants: %s and %s", *ca.stl, stlProps.Stl)
Liz Kammer9abd62d2021-05-21 08:37:59 -0400557 }
Jingwen Chenc1c26502021-04-05 10:35:13 +0000558 }
Trevor Radcliffe542954f2022-04-21 20:04:42 +0000559 })
Liz Kammere6583482021-10-19 13:56:10 -0400560}
Jingwen Chenc1c26502021-04-05 10:35:13 +0000561
Jingwen Chen55bc8202021-11-02 06:40:51 +0000562func (ca *compilerAttributes) convertProductVariables(ctx android.BazelConversionPathContext, productVariableProps android.ProductConfigProperties) {
Liz Kammerba7a9c52021-05-26 08:45:30 -0400563 productVarPropNameToAttribute := map[string]*bazel.StringListAttribute{
Liz Kammere6583482021-10-19 13:56:10 -0400564 "Cflags": &ca.copts,
565 "Asflags": &ca.asFlags,
Yu Liu93893ba2023-05-01 13:49:52 -0700566 "Cppflags": &ca.cppFlags,
Liz Kammerba7a9c52021-05-26 08:45:30 -0400567 }
Liz Kammerba7a9c52021-05-26 08:45:30 -0400568 for propName, attr := range productVarPropNameToAttribute {
Jingwen Chen25825ca2021-11-15 12:28:43 +0000569 if productConfigProps, exists := productVariableProps[propName]; exists {
570 for productConfigProp, prop := range productConfigProps {
571 flags, ok := prop.([]string)
Liz Kammerba7a9c52021-05-26 08:45:30 -0400572 if !ok {
573 ctx.ModuleErrorf("Could not convert product variable %s property", proptools.PropertyNameForField(propName))
574 }
Cole Faust150f9a52023-04-26 10:52:24 -0700575 newFlags, _ := bazel.TryVariableSubstitutions(flags, productConfigProp.Name())
Jingwen Chen25825ca2021-11-15 12:28:43 +0000576 attr.SetSelectValue(productConfigProp.ConfigurationAxis(), productConfigProp.SelectKey(), newFlags)
Liz Kammer6fd7b3f2021-05-06 13:54:29 -0400577 }
Liz Kammer6fd7b3f2021-05-06 13:54:29 -0400578 }
579 }
Liz Kammere6583482021-10-19 13:56:10 -0400580}
Liz Kammer6fd7b3f2021-05-06 13:54:29 -0400581
Liz Kammer5f5dbaa2023-07-17 17:44:08 -0400582func (ca *compilerAttributes) finalize(ctx android.BazelConversionPathContext, implementationHdrs, exportHdrs bazel.LabelListAttribute) {
Liz Kammere6583482021-10-19 13:56:10 -0400583 ca.srcs.ResolveExcludes()
584 partitionedSrcs := groupSrcsByExtension(ctx, ca.srcs)
Liz Kammer5f5dbaa2023-07-17 17:44:08 -0400585 partitionedImplHdrs := partitionHeaders(ctx, implementationHdrs)
586 partitionedHdrs := partitionHeaders(ctx, exportHdrs)
Liz Kammere6583482021-10-19 13:56:10 -0400587
Liz Kammer12615db2021-09-28 09:19:17 -0400588 ca.protoSrcs = partitionedSrcs[protoSrcPartition]
Vinh Tran9f6796a2022-08-16 13:10:31 -0400589 ca.aidlSrcs = partitionedSrcs[aidlSrcPartition]
Liz Kammer12615db2021-09-28 09:19:17 -0400590
Liz Kammere6583482021-10-19 13:56:10 -0400591 for p, lla := range partitionedSrcs {
592 // if there are no sources, there is no need for headers
593 if lla.IsEmpty() {
594 continue
595 }
Liz Kammer5f5dbaa2023-07-17 17:44:08 -0400596 lla.Append(partitionedImplHdrs[hdrPartition])
Liz Kammere6583482021-10-19 13:56:10 -0400597 partitionedSrcs[p] = lla
598 }
599
Liz Kammer5f5dbaa2023-07-17 17:44:08 -0400600 ca.hdrs = partitionedHdrs[hdrPartition]
601
602 ca.includesFromHeaders(ctx, partitionedImplHdrs[hdrPartition], partitionedHdrs[hdrPartition])
603
604 xsdSrcs := bazel.SubtractBazelLabelListAttribute(partitionedSrcs[xsdSrcPartition], partitionedHdrs[xsdSrcPartition])
605 xsdSrcs.Append(partitionedImplHdrs[xsdSrcPartition])
606 ca.exportXsdSrcs = partitionedHdrs[xsdSrcPartition]
607 ca.xsdSrcs = bazel.FirstUniqueBazelLabelListAttribute(xsdSrcs)
608
Liz Kammere6583482021-10-19 13:56:10 -0400609 ca.srcs = partitionedSrcs[cppSrcPartition]
610 ca.cSrcs = partitionedSrcs[cSrcPartition]
611 ca.asSrcs = partitionedSrcs[asSrcPartition]
Cole Faust7071a052022-07-29 15:58:33 -0700612 ca.asmSrcs = partitionedSrcs[asmSrcPartition]
Trevor Radcliffeef9c9002022-05-13 20:55:35 +0000613 ca.lSrcs = partitionedSrcs[lSrcPartition]
614 ca.llSrcs = partitionedSrcs[llSrcPartition]
Spandan Dasdf4c2132023-05-09 23:58:52 +0000615 if yacc := partitionedSrcs[yaccSrcPartition]; !yacc.IsEmpty() {
616 if len(yacc.Value.Includes) > 1 {
617 ctx.PropertyErrorf("srcs", "Found multiple yacc (.y/.yy) files in library")
618 }
619 ca.yaccSrc = bazel.MakeLabelAttribute(yacc.Value.Includes[0].Label)
620 }
Trevor Radcliffecee4e052022-09-06 19:31:25 +0000621 ca.syspropSrcs = partitionedSrcs[syspropSrcPartition]
Alixe2667872023-04-24 14:57:32 +0000622 ca.rscriptSrcs = partitionedSrcs[rScriptSrcPartition]
Liz Kammere6583482021-10-19 13:56:10 -0400623
624 ca.absoluteIncludes.DeduplicateAxesFromBase()
625 ca.localIncludes.DeduplicateAxesFromBase()
626}
627
628// Parse srcs from an arch or OS's props value.
Liz Kammer5f5dbaa2023-07-17 17:44:08 -0400629func parseSrcs(ctx android.BazelConversionPathContext, props *BaseCompilerProperties) (bazel.LabelList, bool) {
Liz Kammere6583482021-10-19 13:56:10 -0400630 anySrcs := false
631 // Add srcs-like dependencies such as generated files.
632 // First create a LabelList containing these dependencies, then merge the values with srcs.
Liz Kammer5f5dbaa2023-07-17 17:44:08 -0400633 genSrcs := props.Generated_sources
Spandan Das922171d2023-05-31 23:32:40 +0000634 generatedSrcsLabelList := android.BazelLabelForModuleDepsExcludes(ctx, genSrcs, props.Exclude_generated_sources)
Liz Kammere6583482021-10-19 13:56:10 -0400635 if len(props.Generated_sources) > 0 || len(props.Exclude_generated_sources) > 0 {
636 anySrcs = true
637 }
638
639 allSrcsLabelList := android.BazelLabelForModuleSrcExcludes(ctx, props.Srcs, props.Exclude_srcs)
Vinh Tran9f6796a2022-08-16 13:10:31 -0400640
Liz Kammere6583482021-10-19 13:56:10 -0400641 if len(props.Srcs) > 0 || len(props.Exclude_srcs) > 0 {
642 anySrcs = true
643 }
Vinh Tran9f6796a2022-08-16 13:10:31 -0400644
Liz Kammer5f5dbaa2023-07-17 17:44:08 -0400645 return bazel.AppendBazelLabelLists(allSrcsLabelList, generatedSrcsLabelList), anySrcs
Liz Kammere6583482021-10-19 13:56:10 -0400646}
647
Liz Kammera5a29de2022-05-25 23:19:37 -0400648func bp2buildStdVal(std *string, prefix string, useGnu bool) *string {
649 defaultVal := prefix + "_std_default"
Chris Parsons79bd2b72021-11-29 17:52:41 -0500650 // If c{,pp}std properties are not specified, don't generate them in the BUILD file.
651 // Defaults are handled by the toolchain definition.
652 // However, if gnu_extensions is false, then the default gnu-to-c version must be specified.
Liz Kammera5a29de2022-05-25 23:19:37 -0400653 stdVal := proptools.StringDefault(std, defaultVal)
654 if stdVal == "experimental" || stdVal == defaultVal {
655 if stdVal == "experimental" {
656 stdVal = prefix + "_std_experimental"
657 }
658 if !useGnu {
659 stdVal += "_no_gnu"
660 }
661 } else if !useGnu {
662 stdVal = gnuToCReplacer.Replace(stdVal)
Chris Parsons79bd2b72021-11-29 17:52:41 -0500663 }
664
Liz Kammera5a29de2022-05-25 23:19:37 -0400665 if stdVal == defaultVal {
666 return nil
Liz Kammer46fb7ab2021-12-01 10:09:34 -0500667 }
Liz Kammera5a29de2022-05-25 23:19:37 -0400668 return &stdVal
669}
Liz Kammer46fb7ab2021-12-01 10:09:34 -0500670
Liz Kammera5a29de2022-05-25 23:19:37 -0400671func bp2buildResolveCppStdValue(c_std *string, cpp_std *string, gnu_extensions *bool) (*string, *string) {
672 useGnu := useGnuExtensions(gnu_extensions)
673
674 return bp2buildStdVal(c_std, "c", useGnu), bp2buildStdVal(cpp_std, "cpp", useGnu)
Liz Kammere6583482021-10-19 13:56:10 -0400675}
676
Liz Kammer1263d9b2021-12-10 14:28:20 -0500677// packageFromLabel extracts package from a fully-qualified or relative Label and whether the label
678// is fully-qualified.
679// e.g. fully-qualified "//a/b:foo" -> "a/b", true, relative: ":bar" -> ".", false
680func packageFromLabel(label string) (string, bool) {
681 split := strings.Split(label, ":")
682 if len(split) != 2 {
683 return "", false
684 }
685 if split[0] == "" {
686 return ".", false
687 }
688 // remove leading "//"
689 return split[0][2:], true
690}
691
Liz Kammer5f5dbaa2023-07-17 17:44:08 -0400692// includesFromHeaders gets the include directories needed from generated headers
693func (ca *compilerAttributes) includesFromHeaders(ctx android.BazelConversionPathContext, implHdrs, hdrs bazel.LabelListAttribute) {
694 local, absolute := includesFromLabelListAttribute(implHdrs, ca.localIncludes, ca.absoluteIncludes)
695 localExport, absoluteExport := includesFromLabelListAttribute(hdrs, ca.includes.Includes, ca.includes.AbsoluteIncludes)
696
697 ca.localIncludes = local
698 ca.absoluteIncludes = absolute
699
700 ca.includes.Includes = localExport
701 ca.includes.AbsoluteIncludes = absoluteExport
702}
703
704// includesFromLabelList extracts the packages from a LabelListAttribute that should be includes and
705// combines them with existing local/absolute includes.
706func includesFromLabelListAttribute(attr bazel.LabelListAttribute, existingLocal, existingAbsolute bazel.StringListAttribute) (bazel.StringListAttribute, bazel.StringListAttribute) {
707 localAttr := existingLocal.Clone()
708 absoluteAttr := existingAbsolute.Clone()
709 if !attr.Value.IsEmpty() {
710 l, a := includesFromLabelList(attr.Value, existingLocal.Value, existingAbsolute.Value)
711 localAttr.SetSelectValue(bazel.NoConfigAxis, "", l)
712 absoluteAttr.SetSelectValue(bazel.NoConfigAxis, "", a)
713 }
714 for axis, configToLabels := range attr.ConfigurableValues {
715 for c, labels := range configToLabels {
716 local := existingLocal.SelectValue(axis, c)
717 absolute := existingAbsolute.SelectValue(axis, c)
718 l, a := includesFromLabelList(labels, local, absolute)
719 localAttr.SetSelectValue(axis, c, l)
720 absoluteAttr.SetSelectValue(axis, c, a)
721 }
722 }
723 return *localAttr, *absoluteAttr
724}
725
726// includesFromLabelList extracts relative/absolute includes from a bazel.LabelList.
727func includesFromLabelList(labelList bazel.LabelList, existingRel, existingAbs []string) ([]string, []string) {
728 var relative, absolute []string
Liz Kammer1263d9b2021-12-10 14:28:20 -0500729 for _, hdr := range labelList.Includes {
730 if pkg, hasPkg := packageFromLabel(hdr.Label); hasPkg {
731 absolute = append(absolute, pkg)
732 } else if pkg != "" {
733 relative = append(relative, pkg)
734 }
735 }
Liz Kammer5f5dbaa2023-07-17 17:44:08 -0400736 if len(relative)+len(existingRel) != 0 {
737 relative = android.FirstUniqueStrings(append(append([]string{}, existingRel...), relative...))
738 }
739 if len(absolute)+len(existingAbs) != 0 {
740 absolute = android.FirstUniqueStrings(append(append([]string{}, existingAbs...), absolute...))
741 }
Liz Kammer1263d9b2021-12-10 14:28:20 -0500742 return relative, absolute
743}
744
Cole Faust7071a052022-07-29 15:58:33 -0700745type YasmAttributes struct {
746 Srcs bazel.LabelListAttribute
747 Flags bazel.StringListAttribute
748 Include_dirs bazel.StringListAttribute
749}
750
751func bp2BuildYasm(ctx android.Bp2buildMutatorContext, m *Module, ca compilerAttributes) *bazel.LabelAttribute {
752 if ca.asmSrcs.IsEmpty() {
753 return nil
754 }
755
756 // Yasm needs the include directories from both local_includes and
757 // export_include_dirs. We don't care about actually exporting them from the
758 // yasm rule though, because they will also be present on the cc_ rule that
759 // wraps this yasm rule.
760 includes := ca.localIncludes.Clone()
761 bp2BuildPropParseHelper(ctx, m, &FlagExporterProperties{}, func(axis bazel.ConfigurationAxis, config string, props interface{}) {
762 if flagExporterProperties, ok := props.(*FlagExporterProperties); ok {
763 if len(flagExporterProperties.Export_include_dirs) > 0 {
764 x := bazel.StringListAttribute{}
765 x.SetSelectValue(axis, config, flagExporterProperties.Export_include_dirs)
766 includes.Append(x)
767 }
768 }
769 })
770
771 ctx.CreateBazelTargetModule(
772 bazel.BazelTargetModuleProperties{
773 Rule_class: "yasm",
774 Bzl_load_location: "//build/bazel/rules/cc:yasm.bzl",
775 },
776 android.CommonAttributes{Name: m.Name() + "_yasm"},
777 &YasmAttributes{
778 Srcs: ca.asmSrcs,
779 Flags: ca.asFlags,
780 Include_dirs: *includes,
781 })
782
783 // We only want to add a dependency on the _yasm target if there are asm
784 // sources in the current configuration. If there are unconfigured asm
785 // sources, always add the dependency. Otherwise, add the dependency only
786 // on the configuration axes and values that had asm sources.
787 if len(ca.asmSrcs.Value.Includes) > 0 {
788 return bazel.MakeLabelAttribute(":" + m.Name() + "_yasm")
789 }
790
791 ret := &bazel.LabelAttribute{}
792 for _, axis := range ca.asmSrcs.SortedConfigurationAxes() {
Sasha Smundak39a301c2022-12-29 17:11:49 -0800793 for cfg := range ca.asmSrcs.ConfigurableValues[axis] {
794 ret.SetSelectValue(axis, cfg, bazel.Label{Label: ":" + m.Name() + "_yasm"})
Cole Faust7071a052022-07-29 15:58:33 -0700795 }
796 }
797 return ret
798}
799
Jingwen Chen0ee88a62022-01-07 14:55:29 +0000800// bp2BuildParseBaseProps returns all compiler, linker, library attributes of a cc module..
Liz Kammer12615db2021-09-28 09:19:17 -0400801func bp2BuildParseBaseProps(ctx android.Bp2buildMutatorContext, module *Module) baseAttributes {
Liz Kammere6583482021-10-19 13:56:10 -0400802 archVariantCompilerProps := module.GetArchVariantProperties(ctx, &BaseCompilerProperties{})
803 archVariantLinkerProps := module.GetArchVariantProperties(ctx, &BaseLinkerProperties{})
Jingwen Chen0ee88a62022-01-07 14:55:29 +0000804 archVariantLibraryProperties := module.GetArchVariantProperties(ctx, &LibraryProperties{})
Liz Kammere6583482021-10-19 13:56:10 -0400805
Liz Kammere6583482021-10-19 13:56:10 -0400806 axisToConfigs := map[bazel.ConfigurationAxis]map[string]bool{}
807 allAxesAndConfigs := func(cp android.ConfigurationAxisToArchVariantProperties) {
808 for axis, configMap := range cp {
809 if _, ok := axisToConfigs[axis]; !ok {
810 axisToConfigs[axis] = map[string]bool{}
811 }
Sasha Smundak39a301c2022-12-29 17:11:49 -0800812 for cfg := range configMap {
813 axisToConfigs[axis][cfg] = true
Chris Parsonsa967f252021-09-23 16:34:35 -0400814 }
815 }
816 }
Liz Kammere6583482021-10-19 13:56:10 -0400817 allAxesAndConfigs(archVariantCompilerProps)
818 allAxesAndConfigs(archVariantLinkerProps)
Jingwen Chen0ee88a62022-01-07 14:55:29 +0000819 allAxesAndConfigs(archVariantLibraryProperties)
Chris Parsonsa967f252021-09-23 16:34:35 -0400820
Liz Kammere6583482021-10-19 13:56:10 -0400821 compilerAttrs := compilerAttributes{}
822 linkerAttrs := linkerAttributes{}
823
Vinh Tran367d89d2023-04-28 11:21:25 -0400824 var aidlLibs bazel.LabelList
Liz Kammer5f5dbaa2023-07-17 17:44:08 -0400825 var implementationHdrs, exportHdrs bazel.LabelListAttribute
Vinh Tran367d89d2023-04-28 11:21:25 -0400826
Chris Parsons7b3289b2023-01-26 17:30:44 -0500827 // Iterate through these axes in a deterministic order. This is required
828 // because processing certain dependencies may result in concatenating
829 // elements along other axes. (For example, processing NoConfig may result
830 // in elements being added to InApex). This is thus the only way to ensure
831 // that the order of entries in each list is in a predictable order.
832 for _, axis := range bazel.SortedConfigurationAxes(axisToConfigs) {
833 configs := axisToConfigs[axis]
Sasha Smundak39a301c2022-12-29 17:11:49 -0800834 for cfg := range configs {
Liz Kammer5f5dbaa2023-07-17 17:44:08 -0400835 var allHdrs []string
Sasha Smundak39a301c2022-12-29 17:11:49 -0800836 if baseCompilerProps, ok := archVariantCompilerProps[axis][cfg].(*BaseCompilerProperties); ok {
Liz Kammer5f5dbaa2023-07-17 17:44:08 -0400837 allHdrs = baseCompilerProps.Generated_headers
Spandan Das922171d2023-05-31 23:32:40 +0000838
Trevor Radcliffeef9c9002022-05-13 20:55:35 +0000839 if baseCompilerProps.Lex != nil {
Sasha Smundak39a301c2022-12-29 17:11:49 -0800840 compilerAttrs.lexopts.SetSelectValue(axis, cfg, baseCompilerProps.Lex.Flags)
Trevor Radcliffeef9c9002022-05-13 20:55:35 +0000841 }
Spandan Dasdf4c2132023-05-09 23:58:52 +0000842 if baseCompilerProps.Yacc != nil {
843 compilerAttrs.yaccFlags.SetSelectValue(axis, cfg, baseCompilerProps.Yacc.Flags)
844 compilerAttrs.yaccGenLocationHeader.SetSelectValue(axis, cfg, baseCompilerProps.Yacc.Gen_location_hh)
845 compilerAttrs.yaccGenPositionHeader.SetSelectValue(axis, cfg, baseCompilerProps.Yacc.Gen_position_hh)
846 }
Sasha Smundak39a301c2022-12-29 17:11:49 -0800847 (&compilerAttrs).bp2buildForAxisAndConfig(ctx, axis, cfg, baseCompilerProps)
Vinh Tran367d89d2023-04-28 11:21:25 -0400848 aidlLibs.Append(android.BazelLabelForModuleDeps(ctx, baseCompilerProps.Aidl.Libs))
Liz Kammere6583482021-10-19 13:56:10 -0400849 }
850
Liz Kammer5f5dbaa2023-07-17 17:44:08 -0400851 var exportedHdrs []string
Liz Kammere6583482021-10-19 13:56:10 -0400852
Sasha Smundak39a301c2022-12-29 17:11:49 -0800853 if baseLinkerProps, ok := archVariantLinkerProps[axis][cfg].(*BaseLinkerProperties); ok {
Liz Kammer5f5dbaa2023-07-17 17:44:08 -0400854 exportedHdrs = baseLinkerProps.Export_generated_headers
Liz Kammer48cdbeb2023-03-17 10:17:50 -0400855 (&linkerAttrs).bp2buildForAxisAndConfig(ctx, module, axis, cfg, baseLinkerProps)
Liz Kammere6583482021-10-19 13:56:10 -0400856 }
Liz Kammer084d6a92023-06-22 16:23:53 -0400857
Liz Kammer5f5dbaa2023-07-17 17:44:08 -0400858 headers := maybePartitionExportedAndImplementationsDeps(ctx, !module.Binary(), allHdrs, exportedHdrs, android.BazelLabelForModuleDeps)
Liz Kammer084d6a92023-06-22 16:23:53 -0400859
Sasha Smundak39a301c2022-12-29 17:11:49 -0800860 implementationHdrs.SetSelectValue(axis, cfg, headers.implementation)
Liz Kammer5f5dbaa2023-07-17 17:44:08 -0400861 exportHdrs.SetSelectValue(axis, cfg, headers.export)
Jingwen Chen0ee88a62022-01-07 14:55:29 +0000862
Sasha Smundak39a301c2022-12-29 17:11:49 -0800863 if libraryProps, ok := archVariantLibraryProperties[axis][cfg].(*LibraryProperties); ok {
Jingwen Chen0ee88a62022-01-07 14:55:29 +0000864 if axis == bazel.NoConfigAxis {
Sam Delmerico75dbca22023-04-20 13:13:25 +0000865 if libraryProps.Stubs.Symbol_file != nil {
866 compilerAttrs.stubsSymbolFile = libraryProps.Stubs.Symbol_file
867 versions := android.CopyOf(libraryProps.Stubs.Versions)
868 normalizeVersions(ctx, versions)
869 versions = addCurrentVersionIfNotPresent(versions)
870 compilerAttrs.stubsVersions.SetSelectValue(axis, cfg, versions)
871 }
Jingwen Chen0ee88a62022-01-07 14:55:29 +0000872 }
Spandan Das39ccf932023-05-26 18:03:39 +0000873 if stem := libraryProps.Stem; stem != nil {
874 compilerAttrs.stem.SetSelectValue(axis, cfg, stem)
875 }
Alex Márquez Pérez Muñíz Díaz Púras Thaureauxa56e9702022-02-23 18:39:59 -0500876 if suffix := libraryProps.Suffix; suffix != nil {
Sasha Smundak39a301c2022-12-29 17:11:49 -0800877 compilerAttrs.suffix.SetSelectValue(axis, cfg, suffix)
Alex Márquez Pérez Muñíz Díaz Púras Thaureauxa56e9702022-02-23 18:39:59 -0500878 }
Jingwen Chen0ee88a62022-01-07 14:55:29 +0000879 }
Liz Kammer084d6a92023-06-22 16:23:53 -0400880
Liz Kammere6583482021-10-19 13:56:10 -0400881 }
882 }
Vinh Tran9f6796a2022-08-16 13:10:31 -0400883
Liz Kammere6583482021-10-19 13:56:10 -0400884 compilerAttrs.convertStlProps(ctx, module)
885 (&linkerAttrs).convertStripProps(ctx, module)
886
Yu Liuf01a0f02022-12-07 15:45:30 -0800887 var nativeCoverage *bool
Yu Liu8d82ac52022-05-17 15:13:28 -0700888 if module.coverage != nil && module.coverage.Properties.Native_coverage != nil &&
889 !Bool(module.coverage.Properties.Native_coverage) {
Yu Liuf01a0f02022-12-07 15:45:30 -0800890 nativeCoverage = BoolPtr(false)
Yu Liu8d82ac52022-05-17 15:13:28 -0700891 }
892
Cole Faust912bc882023-03-08 12:29:50 -0800893 productVariableProps := android.ProductVariableProperties(ctx, ctx.Module())
Liz Kammere6583482021-10-19 13:56:10 -0400894
895 (&compilerAttrs).convertProductVariables(ctx, productVariableProps)
896 (&linkerAttrs).convertProductVariables(ctx, productVariableProps)
897
Liz Kammer5f5dbaa2023-07-17 17:44:08 -0400898 (&compilerAttrs).finalize(ctx, implementationHdrs, exportHdrs)
Liz Kammer54309532021-12-14 12:21:22 -0500899 (&linkerAttrs).finalize(ctx)
Liz Kammere6583482021-10-19 13:56:10 -0400900
Cole Faust7071a052022-07-29 15:58:33 -0700901 (&compilerAttrs.srcs).Add(bp2BuildYasm(ctx, module, compilerAttrs))
902
Liz Kammer5f5dbaa2023-07-17 17:44:08 -0400903 (&linkerAttrs).wholeArchiveDeps.Append(compilerAttrs.exportXsdSrcs)
904 (&linkerAttrs).implementationWholeArchiveDeps.Append(compilerAttrs.xsdSrcs)
905
Liz Kammer12615db2021-09-28 09:19:17 -0400906 protoDep := bp2buildProto(ctx, module, compilerAttrs.protoSrcs)
907
908 // bp2buildProto will only set wholeStaticLib or implementationWholeStaticLib, but we don't know
909 // which. This will add the newly generated proto library to the appropriate attribute and nothing
910 // to the other
911 (&linkerAttrs).wholeArchiveDeps.Add(protoDep.wholeStaticLib)
912 (&linkerAttrs).implementationWholeArchiveDeps.Add(protoDep.implementationWholeStaticLib)
Vinh Tranfde57eb2022-08-29 17:46:58 -0400913
Vinh Tran367d89d2023-04-28 11:21:25 -0400914 aidlDep := bp2buildCcAidlLibrary(
915 ctx, module,
916 compilerAttrs.aidlSrcs,
917 bazel.LabelListAttribute{
918 Value: aidlLibs,
919 },
920 linkerAttrs,
Vinh Trane6842942023-04-28 11:21:25 -0400921 compilerAttrs,
Vinh Tran367d89d2023-04-28 11:21:25 -0400922 )
Vinh Tranfde57eb2022-08-29 17:46:58 -0400923 if aidlDep != nil {
924 if lib, ok := module.linker.(*libraryDecorator); ok {
925 if proptools.Bool(lib.Properties.Aidl.Export_aidl_headers) {
926 (&linkerAttrs).wholeArchiveDeps.Add(aidlDep)
927 } else {
928 (&linkerAttrs).implementationWholeArchiveDeps.Add(aidlDep)
929 }
930 }
931 }
Liz Kammer12615db2021-09-28 09:19:17 -0400932
Spandan Dasdf4c2132023-05-09 23:58:52 +0000933 // Create a cc_yacc_static_library if srcs contains .y/.yy files
934 // This internal target will produce an .a file that will be statically linked to the parent library
935 if yaccDep := bp2buildCcYaccLibrary(ctx, compilerAttrs, linkerAttrs); yaccDep != nil {
936 (&linkerAttrs).implementationWholeArchiveDeps.Add(yaccDep)
937 }
938
Trevor Radcliffeef9c9002022-05-13 20:55:35 +0000939 convertedLSrcs := bp2BuildLex(ctx, module.Name(), compilerAttrs)
940 (&compilerAttrs).srcs.Add(&convertedLSrcs.srcName)
941 (&compilerAttrs).cSrcs.Add(&convertedLSrcs.cSrcName)
942
Vinh Tran99270ea2022-11-28 11:15:23 -0500943 if module.afdo != nil && module.afdo.Properties.Afdo {
944 fdoProfileDep := bp2buildFdoProfile(ctx, module)
945 if fdoProfileDep != nil {
946 (&compilerAttrs).fdoProfile.SetValue(*fdoProfileDep)
947 }
948 }
949
Trevor Radcliffecee4e052022-09-06 19:31:25 +0000950 if !compilerAttrs.syspropSrcs.IsEmpty() {
951 (&linkerAttrs).wholeArchiveDeps.Add(bp2buildCcSysprop(ctx, module.Name(), module.Properties.Min_sdk_version, compilerAttrs.syspropSrcs))
952 }
953
Zi Wang9f609db2023-01-04 11:06:54 -0800954 linkerAttrs.wholeArchiveDeps.Prepend = true
955 linkerAttrs.deps.Prepend = true
956 compilerAttrs.localIncludes.Prepend = true
957 compilerAttrs.absoluteIncludes.Prepend = true
958 compilerAttrs.hdrs.Prepend = true
959
Alixe2667872023-04-24 14:57:32 +0000960 convertedRsSrcs, rsAbsIncludes, rsLocalIncludes := bp2buildRScript(ctx, module, compilerAttrs)
961 (&compilerAttrs).srcs.Add(&convertedRsSrcs)
962 (&compilerAttrs).absoluteIncludes.Append(rsAbsIncludes)
963 (&compilerAttrs).localIncludes.Append(rsLocalIncludes)
964 (&compilerAttrs).localIncludes.Value = android.FirstUniqueStrings(compilerAttrs.localIncludes.Value)
965
Trevor Radcliffedb7e0262022-10-28 16:48:18 +0000966 features := compilerAttrs.features.Clone().Append(linkerAttrs.features).Append(bp2buildSanitizerFeatures(ctx, module))
Trevor Radcliffe56b1a2b2023-02-06 21:58:30 +0000967 features = features.Append(bp2buildLtoFeatures(ctx, module))
Trevor Radcliffea8b44162023-04-14 18:25:24 +0000968 features = features.Append(convertHiddenVisibilityToFeatureBase(ctx, module))
Cole Faust5fa4e962022-08-22 14:31:04 -0700969 features.DeduplicateAxesFromBase()
970
Trevor Radcliffe0d1b4022022-12-12 22:26:34 +0000971 addMuslSystemDynamicDeps(ctx, linkerAttrs)
972
Liz Kammere6583482021-10-19 13:56:10 -0400973 return baseAttributes{
974 compilerAttrs,
975 linkerAttrs,
Cole Faust5fa4e962022-08-22 14:31:04 -0700976 *features,
Liz Kammer12615db2021-09-28 09:19:17 -0400977 protoDep.protoDep,
Vinh Tran9f6796a2022-08-16 13:10:31 -0400978 aidlDep,
Yu Liuf01a0f02022-12-07 15:45:30 -0800979 nativeCoverage,
Jingwen Chen107c0de2021-04-09 10:43:12 +0000980 }
981}
982
Spandan Dasdf4c2132023-05-09 23:58:52 +0000983type ccYaccLibraryAttributes struct {
984 Src bazel.LabelAttribute
985 Flags bazel.StringListAttribute
986 Gen_location_hh bazel.BoolAttribute
987 Gen_position_hh bazel.BoolAttribute
988 Local_includes bazel.StringListAttribute
989 Implementation_deps bazel.LabelListAttribute
990 Implementation_dynamic_deps bazel.LabelListAttribute
991}
992
993func bp2buildCcYaccLibrary(ctx android.Bp2buildMutatorContext, ca compilerAttributes, la linkerAttributes) *bazel.LabelAttribute {
994 if ca.yaccSrc == nil {
995 return nil
996 }
997 yaccLibraryLabel := ctx.Module().Name() + "_yacc"
998 ctx.CreateBazelTargetModule(
999 bazel.BazelTargetModuleProperties{
1000 Rule_class: "cc_yacc_static_library",
1001 Bzl_load_location: "//build/bazel/rules/cc:cc_yacc_library.bzl",
1002 },
1003 android.CommonAttributes{
1004 Name: yaccLibraryLabel,
1005 },
1006 &ccYaccLibraryAttributes{
1007 Src: *ca.yaccSrc,
1008 Flags: ca.yaccFlags,
1009 Gen_location_hh: ca.yaccGenLocationHeader,
1010 Gen_position_hh: ca.yaccGenPositionHeader,
1011 Local_includes: ca.localIncludes,
1012 Implementation_deps: la.implementationDeps,
1013 Implementation_dynamic_deps: la.implementationDynamicDeps,
1014 },
1015 )
1016
1017 yaccLibrary := &bazel.LabelAttribute{
1018 Value: &bazel.Label{
1019 Label: ":" + yaccLibraryLabel,
1020 },
1021 }
1022 return yaccLibrary
1023}
1024
Trevor Radcliffe0d1b4022022-12-12 22:26:34 +00001025// As a workaround for b/261657184, we are manually adding the default value
1026// of system_dynamic_deps for the linux_musl os.
1027// TODO: Solve this properly
1028func addMuslSystemDynamicDeps(ctx android.Bp2buildMutatorContext, attrs linkerAttributes) {
1029 systemDynamicDeps := attrs.systemDynamicDeps.SelectValue(bazel.OsConfigurationAxis, "linux_musl")
1030 if attrs.systemDynamicDeps.HasAxisSpecificValues(bazel.OsConfigurationAxis) && systemDynamicDeps.IsNil() {
1031 attrs.systemDynamicDeps.SetSelectValue(bazel.OsConfigurationAxis, "linux_musl", android.BazelLabelForModuleDeps(ctx, config.MuslDefaultSharedLibraries))
1032 }
1033}
1034
Vinh Tran99270ea2022-11-28 11:15:23 -05001035type fdoProfileAttributes struct {
1036 Absolute_path_profile string
1037}
1038
1039func bp2buildFdoProfile(
1040 ctx android.Bp2buildMutatorContext,
1041 m *Module,
1042) *bazel.Label {
1043 for _, project := range globalAfdoProfileProjects {
Vinh Tranbc9c8b42022-12-09 12:03:52 -05001044 // Ensure handcrafted BUILD file exists in the project
1045 BUILDPath := android.ExistentPathForSource(ctx, project, "BUILD")
1046 if BUILDPath.Valid() {
1047 // We handcraft a BUILD file with fdo_profile targets that use the existing profiles in the project
1048 // This implementation is assuming that every afdo profile in globalAfdoProfileProjects already has
1049 // an associated fdo_profile target declared in the same package.
1050 // TODO(b/260714900): Handle arch-specific afdo profiles (e.g. `<module-name>-arm<64>.afdo`)
1051 path := android.ExistentPathForSource(ctx, project, m.Name()+".afdo")
1052 if path.Valid() {
1053 // FIXME: Some profiles only exist internally and are not released to AOSP.
1054 // When generated BUILD files are checked in, we'll run into merge conflict.
1055 // The cc_library_shared target in AOSP won't have reference to an fdo_profile target because
1056 // the profile doesn't exist. Internally, the same cc_library_shared target will
1057 // have reference to the fdo_profile.
1058 // For more context, see b/258682955#comment2
1059 fdoProfileLabel := "//" + strings.TrimSuffix(project, "/") + ":" + m.Name()
1060 return &bazel.Label{
1061 Label: fdoProfileLabel,
1062 }
Vinh Tran99270ea2022-11-28 11:15:23 -05001063 }
1064 }
1065 }
1066
1067 return nil
1068}
1069
Vinh Tran9f6796a2022-08-16 13:10:31 -04001070func bp2buildCcAidlLibrary(
1071 ctx android.Bp2buildMutatorContext,
1072 m *Module,
Vinh Tran367d89d2023-04-28 11:21:25 -04001073 aidlSrcs bazel.LabelListAttribute,
1074 aidlLibs bazel.LabelListAttribute,
Vinh Tran395a1e92022-09-16 18:27:29 -04001075 linkerAttrs linkerAttributes,
Vinh Trane6842942023-04-28 11:21:25 -04001076 compilerAttrs compilerAttributes,
Vinh Tran9f6796a2022-08-16 13:10:31 -04001077) *bazel.LabelAttribute {
Vinh Tran367d89d2023-04-28 11:21:25 -04001078 var aidlLibsFromSrcs, aidlFiles bazel.LabelListAttribute
1079 apexAvailableTags := android.ApexAvailableTagsWithoutTestApexes(ctx.(android.TopDownMutatorContext), ctx.Module())
1080
1081 if !aidlSrcs.IsEmpty() {
1082 aidlLibsFromSrcs, aidlFiles = aidlSrcs.Partition(func(src bazel.Label) bool {
Vinh Trana3b8b782022-09-14 11:40:24 -04001083 if fg, ok := android.ToFileGroupAsLibrary(ctx, src.OriginalModuleName); ok &&
1084 fg.ShouldConvertToAidlLibrary(ctx) {
1085 return true
1086 }
1087 return false
1088 })
Vinh Tran9f6796a2022-08-16 13:10:31 -04001089
Vinh Tran367d89d2023-04-28 11:21:25 -04001090 if !aidlFiles.IsEmpty() {
Vinh Trana3b8b782022-09-14 11:40:24 -04001091 aidlLibName := m.Name() + "_aidl_library"
1092 ctx.CreateBazelTargetModule(
1093 bazel.BazelTargetModuleProperties{
1094 Rule_class: "aidl_library",
Sam Delmericoe55bf082023-03-31 09:47:28 -04001095 Bzl_load_location: "//build/bazel/rules/aidl:aidl_library.bzl",
Vinh Trana3b8b782022-09-14 11:40:24 -04001096 },
Vinh Tran367d89d2023-04-28 11:21:25 -04001097 android.CommonAttributes{
1098 Name: aidlLibName,
Liz Kammer2b3f56e2023-03-23 11:51:49 -04001099 Tags: apexAvailableTags,
Vinh Trana3b8b782022-09-14 11:40:24 -04001100 },
Vinh Tran367d89d2023-04-28 11:21:25 -04001101 &aidlLibraryAttributes{
1102 Srcs: aidlFiles,
Vinh Trana3b8b782022-09-14 11:40:24 -04001103 },
1104 )
Vinh Tran367d89d2023-04-28 11:21:25 -04001105 aidlLibsFromSrcs.Add(&bazel.LabelAttribute{Value: &bazel.Label{Label: ":" + aidlLibName}})
Vinh Trana3b8b782022-09-14 11:40:24 -04001106 }
Vinh Tran9f6796a2022-08-16 13:10:31 -04001107 }
1108
Vinh Tran367d89d2023-04-28 11:21:25 -04001109 allAidlLibs := aidlLibs.Clone()
1110 allAidlLibs.Append(aidlLibsFromSrcs)
1111
1112 if !allAidlLibs.IsEmpty() {
1113 ccAidlLibrarylabel := m.Name() + "_cc_aidl_library"
1114 // Since parent cc_library already has these dependencies, we can add them as implementation
1115 // deps so that they don't re-export
1116 implementationDeps := linkerAttrs.deps.Clone()
1117 implementationDeps.Append(linkerAttrs.implementationDeps)
1118 implementationDynamicDeps := linkerAttrs.dynamicDeps.Clone()
1119 implementationDynamicDeps.Append(linkerAttrs.implementationDynamicDeps)
1120
1121 sdkAttrs := bp2BuildParseSdkAttributes(m)
1122
Vinh Trane6842942023-04-28 11:21:25 -04001123 exportedIncludes := bp2BuildParseExportedIncludes(ctx, m, &compilerAttrs.includes)
1124 includeAttrs := includesAttributes{
1125 Export_includes: exportedIncludes.Includes,
1126 Export_absolute_includes: exportedIncludes.AbsoluteIncludes,
1127 Export_system_includes: exportedIncludes.SystemIncludes,
1128 Local_includes: compilerAttrs.localIncludes,
1129 Absolute_includes: compilerAttrs.absoluteIncludes,
1130 }
1131
Vinh Tran367d89d2023-04-28 11:21:25 -04001132 ctx.CreateBazelTargetModule(
1133 bazel.BazelTargetModuleProperties{
1134 Rule_class: "cc_aidl_library",
1135 Bzl_load_location: "//build/bazel/rules/cc:cc_aidl_library.bzl",
1136 },
1137 android.CommonAttributes{Name: ccAidlLibrarylabel},
1138 &ccAidlLibraryAttributes{
1139 Deps: *allAidlLibs,
1140 Implementation_deps: *implementationDeps,
1141 Implementation_dynamic_deps: *implementationDynamicDeps,
1142 Tags: apexAvailableTags,
1143 sdkAttributes: sdkAttrs,
Vinh Trane6842942023-04-28 11:21:25 -04001144 includesAttributes: includeAttrs,
Vinh Tran367d89d2023-04-28 11:21:25 -04001145 },
1146 )
1147 label := &bazel.LabelAttribute{
1148 Value: &bazel.Label{
1149 Label: ":" + ccAidlLibrarylabel,
1150 },
1151 }
1152 return label
1153 }
1154
Vinh Trana3b8b782022-09-14 11:40:24 -04001155 return nil
Vinh Tran9f6796a2022-08-16 13:10:31 -04001156}
1157
Yu Liufc603162022-03-01 15:44:08 -08001158func bp2BuildParseSdkAttributes(module *Module) sdkAttributes {
Trevor Radcliffe58ea4512022-04-07 20:36:39 +00001159 return sdkAttributes{
1160 Sdk_version: module.Properties.Sdk_version,
Yu Liufc603162022-03-01 15:44:08 -08001161 Min_sdk_version: module.Properties.Min_sdk_version,
1162 }
1163}
1164
1165type sdkAttributes struct {
1166 Sdk_version *string
1167 Min_sdk_version *string
1168}
1169
Jingwen Chen107c0de2021-04-09 10:43:12 +00001170// Convenience struct to hold all attributes parsed from linker properties.
1171type linkerAttributes struct {
Liz Kammer54309532021-12-14 12:21:22 -05001172 deps bazel.LabelListAttribute
1173 implementationDeps bazel.LabelListAttribute
1174 dynamicDeps bazel.LabelListAttribute
1175 implementationDynamicDeps bazel.LabelListAttribute
Cole Faust6b29f592022-08-09 09:50:56 -07001176 runtimeDeps bazel.LabelListAttribute
Liz Kammer54309532021-12-14 12:21:22 -05001177 wholeArchiveDeps bazel.LabelListAttribute
1178 implementationWholeArchiveDeps bazel.LabelListAttribute
1179 systemDynamicDeps bazel.LabelListAttribute
Liz Kammerb4928432023-06-02 18:43:36 -04001180 usedSystemDynamicDepAsStaticDep map[string]bool
Liz Kammer54309532021-12-14 12:21:22 -05001181 usedSystemDynamicDepAsDynamicDep map[string]bool
Liz Kammer7a210ac2021-09-22 15:52:58 -04001182
Rupert Shuttleworth484aa252021-12-10 07:22:53 -05001183 useVersionLib bazel.BoolAttribute
Jingwen Chen3d383bb2021-06-09 07:18:37 +00001184 linkopts bazel.StringListAttribute
Liz Kammerd2871182021-10-04 13:54:37 -04001185 additionalLinkerInputs bazel.LabelListAttribute
Jingwen Chen3d383bb2021-06-09 07:18:37 +00001186 stripKeepSymbols bazel.BoolAttribute
1187 stripKeepSymbolsAndDebugFrame bazel.BoolAttribute
1188 stripKeepSymbolsList bazel.StringListAttribute
1189 stripAll bazel.BoolAttribute
1190 stripNone bazel.BoolAttribute
Liz Kammer0eae52e2021-10-06 10:32:26 -04001191 features bazel.StringListAttribute
Rupert Shuttleworth143be942021-05-09 23:55:51 -04001192}
1193
Liz Kammer54309532021-12-14 12:21:22 -05001194var (
1195 soongSystemSharedLibs = []string{"libc", "libm", "libdl"}
Liz Kammerbaced712022-09-16 09:01:29 -04001196 versionLib = "libbuildversion"
Liz Kammer54309532021-12-14 12:21:22 -05001197)
1198
Vinh Tran85fb07c2022-09-16 16:17:48 -04001199// resolveTargetApex re-adds the shared and static libs in target.apex.exclude_shared|static_libs props to non-apex variant
1200// since all libs are already excluded by default
Liz Kammer748d7072023-01-25 12:07:43 -05001201func (la *linkerAttributes) resolveTargetApexProp(ctx android.BazelConversionPathContext, props *BaseLinkerProperties) {
1202 excludeSharedLibs := bazelLabelForSharedDeps(ctx, props.Target.Apex.Exclude_shared_libs)
1203 sharedExcludes := bazel.LabelList{Excludes: excludeSharedLibs.Includes}
1204 sharedExcludesLabelList := bazel.LabelListAttribute{}
1205 sharedExcludesLabelList.SetSelectValue(bazel.InApexAxis, bazel.InApex, sharedExcludes)
Vinh Tran85fb07c2022-09-16 16:17:48 -04001206
Liz Kammer748d7072023-01-25 12:07:43 -05001207 la.dynamicDeps.Append(sharedExcludesLabelList)
1208 la.implementationDynamicDeps.Append(sharedExcludesLabelList)
1209
1210 excludeStaticLibs := bazelLabelForStaticDeps(ctx, props.Target.Apex.Exclude_static_libs)
1211 staticExcludes := bazel.LabelList{Excludes: excludeStaticLibs.Includes}
1212 staticExcludesLabelList := bazel.LabelListAttribute{}
1213 staticExcludesLabelList.SetSelectValue(bazel.InApexAxis, bazel.InApex, staticExcludes)
1214
1215 la.deps.Append(staticExcludesLabelList)
1216 la.implementationDeps.Append(staticExcludesLabelList)
Vinh Tran85fb07c2022-09-16 16:17:48 -04001217}
1218
Liz Kammer48cdbeb2023-03-17 10:17:50 -04001219func (la *linkerAttributes) bp2buildForAxisAndConfig(ctx android.BazelConversionPathContext, module *Module, axis bazel.ConfigurationAxis, config string, props *BaseLinkerProperties) {
1220 isBinary := module.Binary()
Liz Kammere6583482021-10-19 13:56:10 -04001221 // Use a single variable to capture usage of nocrt in arch variants, so there's only 1 error message for this module
1222 var axisFeatures []string
Liz Kammer7a210ac2021-09-22 15:52:58 -04001223
Liz Kammercc2c1ef2022-03-21 09:03:29 -04001224 wholeStaticLibs := android.FirstUniqueStrings(props.Whole_static_libs)
Liz Kammerbaced712022-09-16 09:01:29 -04001225 staticLibs := android.FirstUniqueStrings(android.RemoveListFromList(props.Static_libs, wholeStaticLibs))
1226 if axis == bazel.NoConfigAxis {
1227 la.useVersionLib.SetSelectValue(axis, config, props.Use_version_lib)
1228 if proptools.Bool(props.Use_version_lib) {
1229 versionLibAlreadyInDeps := android.InList(versionLib, wholeStaticLibs)
1230 // remove from static libs so there is no duplicate dependency
1231 _, staticLibs = android.RemoveFromList(versionLib, staticLibs)
1232 // only add the dep if it is not in progress
1233 if !versionLibAlreadyInDeps {
Yu Liufe978fd2023-04-24 16:37:18 -07001234 wholeStaticLibs = append(wholeStaticLibs, versionLib)
Liz Kammerbaced712022-09-16 09:01:29 -04001235 }
1236 }
1237 }
1238
Liz Kammere6583482021-10-19 13:56:10 -04001239 // Excludes to parallel Soong:
1240 // https://cs.android.com/android/platform/superproject/+/master:build/soong/cc/linker.go;l=247-249;drc=088b53577dde6e40085ffd737a1ae96ad82fc4b0
Liz Kammerbaced712022-09-16 09:01:29 -04001241 la.wholeArchiveDeps.SetSelectValue(axis, config, bazelLabelForWholeDepsExcludes(ctx, wholeStaticLibs, props.Exclude_static_libs))
Liz Kammercc2c1ef2022-03-21 09:03:29 -04001242
Liz Kammerb4928432023-06-02 18:43:36 -04001243 if isBinary && module.StaticExecutable() {
1244 usedSystemStatic := android.FilterListPred(staticLibs, func(s string) bool {
1245 return android.InList(s, soongSystemSharedLibs) && !android.InList(s, props.Exclude_static_libs)
1246 })
1247
1248 for _, el := range usedSystemStatic {
1249 if la.usedSystemDynamicDepAsStaticDep == nil {
1250 la.usedSystemDynamicDepAsStaticDep = map[string]bool{}
1251 }
1252 la.usedSystemDynamicDepAsStaticDep[el] = true
1253 }
1254 }
Vinh Tran85fb07c2022-09-16 16:17:48 -04001255 staticDeps := maybePartitionExportedAndImplementationsDepsExcludes(
1256 ctx,
1257 !isBinary,
1258 staticLibs,
Liz Kammer748d7072023-01-25 12:07:43 -05001259 props.Exclude_static_libs,
Vinh Tran85fb07c2022-09-16 16:17:48 -04001260 props.Export_static_lib_headers,
1261 bazelLabelForStaticDepsExcludes,
1262 )
Liz Kammer7a210ac2021-09-22 15:52:58 -04001263
Liz Kammere6583482021-10-19 13:56:10 -04001264 headerLibs := android.FirstUniqueStrings(props.Header_libs)
1265 hDeps := maybePartitionExportedAndImplementationsDeps(ctx, !isBinary, headerLibs, props.Export_header_lib_headers, bazelLabelForHeaderDeps)
Jingwen Chen63930982021-03-24 10:04:33 -04001266
Liz Kammere6583482021-10-19 13:56:10 -04001267 (&hDeps.export).Append(staticDeps.export)
1268 la.deps.SetSelectValue(axis, config, hDeps.export)
Jingwen Chen3d383bb2021-06-09 07:18:37 +00001269
Liz Kammere6583482021-10-19 13:56:10 -04001270 (&hDeps.implementation).Append(staticDeps.implementation)
1271 la.implementationDeps.SetSelectValue(axis, config, hDeps.implementation)
Liz Kammer0eae52e2021-10-06 10:32:26 -04001272
Liz Kammere6583482021-10-19 13:56:10 -04001273 systemSharedLibs := props.System_shared_libs
1274 // systemSharedLibs distinguishes between nil/empty list behavior:
1275 // nil -> use default values
1276 // empty list -> no values specified
1277 if len(systemSharedLibs) > 0 {
1278 systemSharedLibs = android.FirstUniqueStrings(systemSharedLibs)
1279 }
1280 la.systemDynamicDeps.SetSelectValue(axis, config, bazelLabelForSharedDeps(ctx, systemSharedLibs))
1281
1282 sharedLibs := android.FirstUniqueStrings(props.Shared_libs)
Liz Kammer54309532021-12-14 12:21:22 -05001283 excludeSharedLibs := props.Exclude_shared_libs
1284 usedSystem := android.FilterListPred(sharedLibs, func(s string) bool {
1285 return android.InList(s, soongSystemSharedLibs) && !android.InList(s, excludeSharedLibs)
1286 })
Liz Kammerb4928432023-06-02 18:43:36 -04001287
Liz Kammer54309532021-12-14 12:21:22 -05001288 for _, el := range usedSystem {
1289 if la.usedSystemDynamicDepAsDynamicDep == nil {
1290 la.usedSystemDynamicDepAsDynamicDep = map[string]bool{}
1291 }
1292 la.usedSystemDynamicDepAsDynamicDep[el] = true
1293 }
1294
Vinh Tran85fb07c2022-09-16 16:17:48 -04001295 sharedDeps := maybePartitionExportedAndImplementationsDepsExcludes(
1296 ctx,
1297 !isBinary,
1298 sharedLibs,
Liz Kammer748d7072023-01-25 12:07:43 -05001299 props.Exclude_shared_libs,
Vinh Tran85fb07c2022-09-16 16:17:48 -04001300 props.Export_shared_lib_headers,
1301 bazelLabelForSharedDepsExcludes,
1302 )
Liz Kammere6583482021-10-19 13:56:10 -04001303 la.dynamicDeps.SetSelectValue(axis, config, sharedDeps.export)
1304 la.implementationDynamicDeps.SetSelectValue(axis, config, sharedDeps.implementation)
Liz Kammer748d7072023-01-25 12:07:43 -05001305 la.resolveTargetApexProp(ctx, props)
Vinh Tran85fb07c2022-09-16 16:17:48 -04001306
Wei Li81852ca2022-07-27 00:22:06 -07001307 if axis == bazel.NoConfigAxis || (axis == bazel.OsConfigurationAxis && config == bazel.OsAndroid) {
Yu Liu10174ff2023-02-21 12:05:26 -08001308 // If a dependency in la.implementationDynamicDeps or la.dynamicDeps has stubs, its
1309 // stub variant should be used when the dependency is linked in a APEX. The
1310 // dependencies in NoConfigAxis and OsConfigurationAxis/OsAndroid are grouped by
1311 // having stubs or not, so Bazel select() statement can be used to choose
1312 // source/stub variants of them.
Liz Kammer48cdbeb2023-03-17 10:17:50 -04001313 apexAvailable := module.ApexAvailable()
Spandan Dasac693b22023-04-24 00:07:38 +00001314 setStubsForDynamicDeps(ctx, axis, config, apexAvailable, sharedDeps.export, &la.dynamicDeps, 0, false)
1315 setStubsForDynamicDeps(ctx, axis, config, apexAvailable, sharedDeps.implementation, &la.implementationDynamicDeps, 1, false)
1316 if len(systemSharedLibs) > 0 {
1317 setStubsForDynamicDeps(ctx, axis, config, apexAvailable, bazelLabelForSharedDeps(ctx, systemSharedLibs), &la.systemDynamicDeps, 2, true)
1318 }
Wei Li81852ca2022-07-27 00:22:06 -07001319 }
Liz Kammere6583482021-10-19 13:56:10 -04001320
1321 if !BoolDefault(props.Pack_relocations, packRelocationsDefault) {
1322 axisFeatures = append(axisFeatures, "disable_pack_relocations")
1323 }
1324
1325 if Bool(props.Allow_undefined_symbols) {
1326 axisFeatures = append(axisFeatures, "-no_undefined_symbols")
1327 }
1328
1329 var linkerFlags []string
1330 if len(props.Ldflags) > 0 {
Liz Kammerf38a8372022-02-04 15:39:00 -05001331 linkerFlags = append(linkerFlags, proptools.NinjaEscapeList(props.Ldflags)...)
Liz Kammere6583482021-10-19 13:56:10 -04001332 // binaries remove static flag if -shared is in the linker flags
1333 if isBinary && android.InList("-shared", linkerFlags) {
1334 axisFeatures = append(axisFeatures, "-static_flag")
1335 }
1336 }
Trevor Radcliffeea6a45d2022-09-20 18:58:01 +00001337
Alex Márquez Pérez Muñíz Díaz Puras Thaureaux01ec55e2023-01-30 22:53:04 +00001338 if !props.libCrt() {
1339 axisFeatures = append(axisFeatures, "-use_libcrt")
1340 }
1341 if !props.crt() {
1342 axisFeatures = append(axisFeatures, "-link_crt")
1343 }
1344
Trevor Radcliffeea6a45d2022-09-20 18:58:01 +00001345 // This must happen before the addition of flags for Version Script and
1346 // Dynamic List, as these flags must be split on spaces and those must not
1347 linkerFlags = parseCommandLineFlags(linkerFlags, filterOutClangUnknownCflags)
1348
Trevor Radcliffe37ec2f72022-09-27 01:46:01 +00001349 additionalLinkerInputs := bazel.LabelList{}
Liz Kammere6583482021-10-19 13:56:10 -04001350 if props.Version_script != nil {
1351 label := android.BazelLabelForModuleSrcSingle(ctx, *props.Version_script)
Trevor Radcliffe37ec2f72022-09-27 01:46:01 +00001352 additionalLinkerInputs.Add(&label)
Liz Kammere6583482021-10-19 13:56:10 -04001353 linkerFlags = append(linkerFlags, fmt.Sprintf("-Wl,--version-script,$(location %s)", label.Label))
Trevor Radcliffef06dd912023-05-19 14:51:41 +00001354 axisFeatures = append(axisFeatures, "android_cfi_exports_map")
Liz Kammere6583482021-10-19 13:56:10 -04001355 }
Alix773adaa2022-04-27 17:49:34 +00001356
1357 if props.Dynamic_list != nil {
1358 label := android.BazelLabelForModuleSrcSingle(ctx, *props.Dynamic_list)
Trevor Radcliffe37ec2f72022-09-27 01:46:01 +00001359 additionalLinkerInputs.Add(&label)
Alix773adaa2022-04-27 17:49:34 +00001360 linkerFlags = append(linkerFlags, fmt.Sprintf("-Wl,--dynamic-list,$(location %s)", label.Label))
1361 }
1362
Trevor Radcliffe37ec2f72022-09-27 01:46:01 +00001363 la.additionalLinkerInputs.SetSelectValue(axis, config, additionalLinkerInputs)
Spandan Dasfb04c412023-05-15 18:35:36 +00001364 if axis == bazel.OsConfigurationAxis && (config == bazel.OsDarwin || config == bazel.OsLinux || config == bazel.OsWindows) {
1365 linkerFlags = append(linkerFlags, props.Host_ldlibs...)
1366 }
Trevor Radcliffeea6a45d2022-09-20 18:58:01 +00001367 la.linkopts.SetSelectValue(axis, config, linkerFlags)
Liz Kammere6583482021-10-19 13:56:10 -04001368
1369 if axisFeatures != nil {
1370 la.features.SetSelectValue(axis, config, axisFeatures)
1371 }
Cole Faust6b29f592022-08-09 09:50:56 -07001372
1373 runtimeDeps := android.BazelLabelForModuleDepsExcludes(ctx, props.Runtime_libs, props.Exclude_runtime_libs)
1374 if !runtimeDeps.IsEmpty() {
1375 la.runtimeDeps.SetSelectValue(axis, config, runtimeDeps)
1376 }
Liz Kammere6583482021-10-19 13:56:10 -04001377}
1378
Spandan Das2518c022023-03-17 03:02:32 +00001379var (
1380 apiSurfaceModuleLibCurrentPackage = "@api_surfaces//" + android.ModuleLibApi.String() + "/current:"
1381)
1382
Liz Kammer48cdbeb2023-03-17 10:17:50 -04001383func availableToSameApexes(a, b []string) bool {
1384 if len(a) == 0 && len(b) == 0 {
1385 return true
1386 }
1387 differ, _, _ := android.ListSetDifference(a, b)
1388 return !differ
1389}
1390
Spandan Das4242f102023-04-19 22:31:54 +00001391var (
Spandan Das9cad90f2023-05-04 17:15:44 +00001392 apiDomainConfigSettingKey = android.NewOnceKey("apiDomainConfigSettingKey")
1393 apiDomainConfigSettingLock sync.Mutex
Spandan Das4242f102023-04-19 22:31:54 +00001394)
1395
Spandan Das9cad90f2023-05-04 17:15:44 +00001396func getApiDomainConfigSettingMap(config android.Config) *map[string]bool {
1397 return config.Once(apiDomainConfigSettingKey, func() interface{} {
Spandan Das4242f102023-04-19 22:31:54 +00001398 return &map[string]bool{}
1399 }).(*map[string]bool)
1400}
1401
Spandan Das9cad90f2023-05-04 17:15:44 +00001402var (
1403 testApexNameToApiDomain = map[string]string{
1404 "test_broken_com.android.art": "com.android.art",
1405 }
1406)
1407
Spandan Dasa43ae132023-05-08 18:33:16 +00001408// GetApiDomain returns the canonical name of the apex. This is synonymous to the apex_name definition.
1409// https://cs.android.com/android/_/android/platform/build/soong/+/e3f0281b8897da1fe23b2f4f3a05f1dc87bcc902:apex/prebuilt.go;l=81-83;drc=2dc7244af985a6ad701b22f1271e606cabba527f;bpv=1;bpt=0
1410// For test apexes, it uses a naming convention heuristic to determine the api domain.
1411// TODO (b/281548611): Move this build/soong/android
1412func GetApiDomain(apexName string) string {
Spandan Das9cad90f2023-05-04 17:15:44 +00001413 if apiDomain, exists := testApexNameToApiDomain[apexName]; exists {
1414 return apiDomain
1415 }
1416 // Remove `test_` prefix
1417 return strings.TrimPrefix(apexName, "test_")
1418}
1419
Spandan Das4242f102023-04-19 22:31:54 +00001420// Create a config setting for this apex in build/bazel/rules/apex
1421// The use case for this is stub/impl selection in cc libraries
1422// Long term, these config_setting(s) should be colocated with the respective apex definitions.
1423// Note that this is an anti-pattern: The config_setting should be created from the apex definition
1424// and not from a cc_library.
1425// This anti-pattern is needed today since not all apexes have been allowlisted.
1426func createInApexConfigSetting(ctx android.TopDownMutatorContext, apexName string) {
1427 if apexName == android.AvailableToPlatform || apexName == android.AvailableToAnyApex {
1428 // These correspond to android-non_apex and android-in_apex
1429 return
1430 }
Spandan Das9cad90f2023-05-04 17:15:44 +00001431 apiDomainConfigSettingLock.Lock()
1432 defer apiDomainConfigSettingLock.Unlock()
Spandan Das4242f102023-04-19 22:31:54 +00001433
1434 // Return if a config_setting has already been created
Spandan Dasa43ae132023-05-08 18:33:16 +00001435 apiDomain := GetApiDomain(apexName)
Spandan Das9cad90f2023-05-04 17:15:44 +00001436 acsm := getApiDomainConfigSettingMap(ctx.Config())
1437 if _, exists := (*acsm)[apiDomain]; exists {
Spandan Das4242f102023-04-19 22:31:54 +00001438 return
1439 }
Spandan Das9cad90f2023-05-04 17:15:44 +00001440 (*acsm)[apiDomain] = true
Spandan Das4242f102023-04-19 22:31:54 +00001441
1442 csa := bazel.ConfigSettingAttributes{
1443 Flag_values: bazel.StringMapAttribute{
Spandan Das9cad90f2023-05-04 17:15:44 +00001444 "//build/bazel/rules/apex:api_domain": apiDomain,
Spandan Das4242f102023-04-19 22:31:54 +00001445 },
Spandan Das9cad90f2023-05-04 17:15:44 +00001446 // Constraint this to android
1447 Constraint_values: bazel.MakeLabelListAttribute(
1448 bazel.MakeLabelList(
1449 []bazel.Label{
1450 bazel.Label{Label: "//build/bazel/platforms/os:android"},
1451 },
1452 ),
1453 ),
Spandan Das4242f102023-04-19 22:31:54 +00001454 }
1455 ca := android.CommonAttributes{
Spandan Das9cad90f2023-05-04 17:15:44 +00001456 Name: apiDomain,
Spandan Das4242f102023-04-19 22:31:54 +00001457 }
1458 ctx.CreateBazelConfigSetting(
1459 csa,
1460 ca,
1461 "build/bazel/rules/apex",
1462 )
1463}
1464
1465func inApexConfigSetting(apexAvailable string) string {
1466 if apexAvailable == android.AvailableToPlatform {
Spandan Das6d4d9da2023-04-18 06:20:40 +00001467 return bazel.AndroidPlatform
Spandan Das4242f102023-04-19 22:31:54 +00001468 }
1469 if apexAvailable == android.AvailableToAnyApex {
1470 return bazel.AndroidAndInApex
1471 }
Spandan Dasa43ae132023-05-08 18:33:16 +00001472 apiDomain := GetApiDomain(apexAvailable)
Spandan Das9cad90f2023-05-04 17:15:44 +00001473 return "//build/bazel/rules/apex:" + apiDomain
Spandan Das4242f102023-04-19 22:31:54 +00001474}
1475
Spandan Das6d4d9da2023-04-18 06:20:40 +00001476// Inputs to stub vs impl selection.
1477type stubSelectionInfo struct {
1478 // Label of the implementation library (e.g. //bionic/libc:libc)
1479 impl bazel.Label
1480 // Axis containing the implementation library
1481 axis bazel.ConfigurationAxis
1482 // Axis key containing the implementation library
1483 config string
1484 // API domain of the apex
1485 // For test apexes (test_com.android.foo), this will be the source apex (com.android.foo)
1486 apiDomain string
1487 // List of dep labels
1488 dynamicDeps *bazel.LabelListAttribute
1489 // Boolean value for determining if the dep is in the same api domain
1490 // If false, the label will be rewritten to to the stub label
1491 sameApiDomain bool
1492}
1493
1494func useStubOrImplInApexWithName(ssi stubSelectionInfo) {
1495 lib := ssi.impl
1496 if !ssi.sameApiDomain {
1497 lib = bazel.Label{
1498 Label: apiSurfaceModuleLibCurrentPackage + strings.TrimPrefix(lib.OriginalModuleName, ":"),
1499 }
1500 }
1501 // Create a select statement specific to this apex
1502 inApexSelectValue := ssi.dynamicDeps.SelectValue(bazel.OsAndInApexAxis, inApexConfigSetting(ssi.apiDomain))
1503 (&inApexSelectValue).Append(bazel.MakeLabelList([]bazel.Label{lib}))
1504 ssi.dynamicDeps.SetSelectValue(bazel.OsAndInApexAxis, inApexConfigSetting(ssi.apiDomain), bazel.FirstUniqueBazelLabelList(inApexSelectValue))
1505 // Delete the library from the common config for this apex
1506 implDynamicDeps := ssi.dynamicDeps.SelectValue(ssi.axis, ssi.config)
1507 implDynamicDeps = bazel.SubtractBazelLabelList(implDynamicDeps, bazel.MakeLabelList([]bazel.Label{ssi.impl}))
1508 ssi.dynamicDeps.SetSelectValue(ssi.axis, ssi.config, implDynamicDeps)
1509 if ssi.axis == bazel.NoConfigAxis {
1510 // Set defaults. Defaults (i.e. host) should use impl and not stubs.
1511 defaultSelectValue := ssi.dynamicDeps.SelectValue(bazel.OsAndInApexAxis, bazel.ConditionsDefaultConfigKey)
1512 (&defaultSelectValue).Append(bazel.MakeLabelList([]bazel.Label{ssi.impl}))
1513 ssi.dynamicDeps.SetSelectValue(bazel.OsAndInApexAxis, bazel.ConditionsDefaultConfigKey, bazel.FirstUniqueBazelLabelList(defaultSelectValue))
1514 }
Liz Kammere6583482021-10-19 13:56:10 -04001515}
1516
Yu Liu10174ff2023-02-21 12:05:26 -08001517func setStubsForDynamicDeps(ctx android.BazelConversionPathContext, axis bazel.ConfigurationAxis,
Spandan Dasac693b22023-04-24 00:07:38 +00001518 config string, apexAvailable []string, dynamicLibs bazel.LabelList, dynamicDeps *bazel.LabelListAttribute, ind int, buildNonApexWithStubs bool) {
Liz Kammer48cdbeb2023-03-17 10:17:50 -04001519
Spandan Das4242f102023-04-19 22:31:54 +00001520 // Create a config_setting for each apex_available.
1521 // This will be used to select impl of a dep if dep is available to the same apex.
1522 for _, aa := range apexAvailable {
1523 createInApexConfigSetting(ctx.(android.TopDownMutatorContext), aa)
1524 }
1525
Spandan Das6d4d9da2023-04-18 06:20:40 +00001526 apiDomainForSelects := []string{}
1527 for _, apex := range apexAvailable {
1528 apiDomainForSelects = append(apiDomainForSelects, GetApiDomain(apex))
1529 }
1530 // Always emit a select statement for the platform variant.
1531 // This ensures that b build //foo --config=android works
1532 // Soong always creates a platform variant even when the library might not be available to platform.
1533 if !android.InList(android.AvailableToPlatform, apiDomainForSelects) {
1534 apiDomainForSelects = append(apiDomainForSelects, android.AvailableToPlatform)
1535 }
1536 apiDomainForSelects = android.SortedUniqueStrings(apiDomainForSelects)
1537
1538 // Create a select for each apex this library could be included in.
1539 for _, l := range dynamicLibs.Includes {
1540 dep, _ := ctx.ModuleFromName(l.OriginalModuleName)
1541 if c, ok := dep.(*Module); !ok || !c.HasStubsVariants() {
1542 continue
1543 }
1544 // TODO (b/280339069): Decrease the verbosity of the generated BUILD files
1545 for _, apiDomain := range apiDomainForSelects {
1546 var sameApiDomain bool
1547 if apiDomain == android.AvailableToPlatform {
1548 // Platform variants in Soong use equality of apex_available for stub/impl selection.
1549 // https://cs.android.com/android/_/android/platform/build/soong/+/316b0158fe57ee7764235923e7c6f3d530da39c6:cc/cc.go;l=3393-3404;drc=176271a426496fa2688efe2b40d5c74340c63375;bpv=1;bpt=0
1550 // One of the factors behind this design choice is cc_test
1551 // Tests only have a platform variant, and using equality of apex_available ensures
1552 // that tests of an apex library gets its implementation and not stubs.
1553 // TODO (b/280343104): Discuss if we can drop this special handling for platform variants.
1554 sameApiDomain = availableToSameApexes(apexAvailable, dep.(*Module).ApexAvailable())
Spandan Das6aaab9d2023-05-04 17:27:30 +00001555 if linkable, ok := ctx.Module().(LinkableInterface); ok && linkable.Bootstrap() {
1556 sameApiDomain = true
1557 }
Spandan Das6d4d9da2023-04-18 06:20:40 +00001558 } else {
1559 sameApiDomain = android.InList(apiDomain, dep.(*Module).ApexAvailable())
1560 }
1561 ssi := stubSelectionInfo{
1562 impl: l,
1563 axis: axis,
1564 config: config,
1565 apiDomain: apiDomain,
1566 dynamicDeps: dynamicDeps,
1567 sameApiDomain: sameApiDomain,
1568 }
1569 useStubOrImplInApexWithName(ssi)
1570 }
1571 }
Yu Liu10174ff2023-02-21 12:05:26 -08001572}
1573
Jingwen Chen55bc8202021-11-02 06:40:51 +00001574func (la *linkerAttributes) convertStripProps(ctx android.BazelConversionPathContext, module *Module) {
Trevor Radcliffe542954f2022-04-21 20:04:42 +00001575 bp2BuildPropParseHelper(ctx, module, &StripProperties{}, func(axis bazel.ConfigurationAxis, config string, props interface{}) {
1576 if stripProperties, ok := props.(*StripProperties); ok {
1577 la.stripKeepSymbols.SetSelectValue(axis, config, stripProperties.Strip.Keep_symbols)
1578 la.stripKeepSymbolsList.SetSelectValue(axis, config, stripProperties.Strip.Keep_symbols_list)
1579 la.stripKeepSymbolsAndDebugFrame.SetSelectValue(axis, config, stripProperties.Strip.Keep_symbols_and_debug_frame)
1580 la.stripAll.SetSelectValue(axis, config, stripProperties.Strip.All)
1581 la.stripNone.SetSelectValue(axis, config, stripProperties.Strip.None)
Jingwen Chen3d383bb2021-06-09 07:18:37 +00001582 }
Trevor Radcliffe542954f2022-04-21 20:04:42 +00001583 })
Liz Kammere6583482021-10-19 13:56:10 -04001584}
Jingwen Chen3d383bb2021-06-09 07:18:37 +00001585
Jingwen Chen55bc8202021-11-02 06:40:51 +00001586func (la *linkerAttributes) convertProductVariables(ctx android.BazelConversionPathContext, productVariableProps android.ProductConfigProperties) {
Jingwen Chen6ada5892021-09-17 11:38:09 +00001587
Liz Kammer47535c52021-06-02 16:02:22 -04001588 type productVarDep struct {
1589 // the name of the corresponding excludes field, if one exists
1590 excludesField string
1591 // reference to the bazel attribute that should be set for the given product variable config
1592 attribute *bazel.LabelListAttribute
Liz Kammer2d7bbe32021-06-10 18:20:06 -04001593
Jingwen Chen55bc8202021-11-02 06:40:51 +00001594 depResolutionFunc func(ctx android.BazelConversionPathContext, modules, excludes []string) bazel.LabelList
Liz Kammer47535c52021-06-02 16:02:22 -04001595 }
1596
Zi Wang0a8a1292022-08-30 06:27:01 +00001597 // an intermediate attribute that holds Header_libs info, and will be appended to
1598 // implementationDeps at the end, to solve the confliction that both header_libs
1599 // and static_libs use implementationDeps.
1600 var headerDeps bazel.LabelListAttribute
1601
Liz Kammer47535c52021-06-02 16:02:22 -04001602 productVarToDepFields := map[string]productVarDep{
1603 // product variables do not support exclude_shared_libs
Jingwen Chen55bc8202021-11-02 06:40:51 +00001604 "Shared_libs": {attribute: &la.implementationDynamicDeps, depResolutionFunc: bazelLabelForSharedDepsExcludes},
1605 "Static_libs": {"Exclude_static_libs", &la.implementationDeps, bazelLabelForStaticDepsExcludes},
1606 "Whole_static_libs": {"Exclude_static_libs", &la.wholeArchiveDeps, bazelLabelForWholeDepsExcludes},
Zi Wang0a8a1292022-08-30 06:27:01 +00001607 "Header_libs": {attribute: &headerDeps, depResolutionFunc: bazelLabelForHeaderDepsExcludes},
Liz Kammer47535c52021-06-02 16:02:22 -04001608 }
1609
Liz Kammer47535c52021-06-02 16:02:22 -04001610 for name, dep := range productVarToDepFields {
1611 props, exists := productVariableProps[name]
1612 excludeProps, excludesExists := productVariableProps[dep.excludesField]
Sasha Smundak39a301c2022-12-29 17:11:49 -08001613 // if neither an include nor excludes property exists, then skip it
Liz Kammer47535c52021-06-02 16:02:22 -04001614 if !exists && !excludesExists {
1615 continue
1616 }
Jingwen Chen25825ca2021-11-15 12:28:43 +00001617 // Collect all the configurations that an include or exclude property exists for.
1618 // We want to iterate all configurations rather than either the include or exclude because, for a
1619 // particular configuration, we may have either only an include or an exclude to handle.
Cole Faust150f9a52023-04-26 10:52:24 -07001620 productConfigProps := make(map[android.ProductConfigOrSoongConfigProperty]bool, len(props)+len(excludeProps))
Jingwen Chen25825ca2021-11-15 12:28:43 +00001621 for p := range props {
1622 productConfigProps[p] = true
Liz Kammer47535c52021-06-02 16:02:22 -04001623 }
Jingwen Chen25825ca2021-11-15 12:28:43 +00001624 for p := range excludeProps {
1625 productConfigProps[p] = true
Liz Kammer47535c52021-06-02 16:02:22 -04001626 }
1627
Jingwen Chen25825ca2021-11-15 12:28:43 +00001628 for productConfigProp := range productConfigProps {
1629 prop, includesExists := props[productConfigProp]
1630 excludesProp, excludesExists := excludeProps[productConfigProp]
Liz Kammer47535c52021-06-02 16:02:22 -04001631 var includes, excludes []string
1632 var ok bool
1633 // if there was no includes/excludes property, casting fails and that's expected
Jingwen Chen25825ca2021-11-15 12:28:43 +00001634 if includes, ok = prop.([]string); includesExists && !ok {
Liz Kammer47535c52021-06-02 16:02:22 -04001635 ctx.ModuleErrorf("Could not convert product variable %s property", name)
1636 }
Jingwen Chen25825ca2021-11-15 12:28:43 +00001637 if excludes, ok = excludesProp.([]string); excludesExists && !ok {
Liz Kammer47535c52021-06-02 16:02:22 -04001638 ctx.ModuleErrorf("Could not convert product variable %s property", dep.excludesField)
1639 }
Liz Kammer2d7bbe32021-06-10 18:20:06 -04001640
Jingwen Chen58ff6802021-11-17 12:14:41 +00001641 dep.attribute.EmitEmptyList = productConfigProp.AlwaysEmit()
Jingwen Chen25825ca2021-11-15 12:28:43 +00001642 dep.attribute.SetSelectValue(
1643 productConfigProp.ConfigurationAxis(),
1644 productConfigProp.SelectKey(),
1645 dep.depResolutionFunc(ctx, android.FirstUniqueStrings(includes), excludes),
1646 )
Liz Kammer47535c52021-06-02 16:02:22 -04001647 }
1648 }
Zi Wang0a8a1292022-08-30 06:27:01 +00001649 la.implementationDeps.Append(headerDeps)
Liz Kammere6583482021-10-19 13:56:10 -04001650}
Liz Kammer47535c52021-06-02 16:02:22 -04001651
Liz Kammer54309532021-12-14 12:21:22 -05001652func (la *linkerAttributes) finalize(ctx android.BazelConversionPathContext) {
1653 // if system dynamic deps have the default value, any use of a system dynamic library used will
1654 // result in duplicate library errors for bionic OSes. Here, we explicitly exclude those libraries
Liz Kammer43345e22022-08-04 13:57:35 -04001655 // from bionic OSes and the no config case as these libraries only build for bionic OSes.
Liz Kammer54309532021-12-14 12:21:22 -05001656 if la.systemDynamicDeps.IsNil() && len(la.usedSystemDynamicDepAsDynamicDep) > 0 {
Cole Faust18994c72023-02-28 16:02:16 -08001657 toRemove := bazelLabelForSharedDeps(ctx, android.SortedKeys(la.usedSystemDynamicDepAsDynamicDep))
Liz Kammer43345e22022-08-04 13:57:35 -04001658 la.dynamicDeps.Exclude(bazel.NoConfigAxis, "", toRemove)
Liz Kammer54309532021-12-14 12:21:22 -05001659 la.dynamicDeps.Exclude(bazel.OsConfigurationAxis, "android", toRemove)
1660 la.dynamicDeps.Exclude(bazel.OsConfigurationAxis, "linux_bionic", toRemove)
Liz Kammer91487d42022-09-13 11:27:11 -04001661 la.implementationDynamicDeps.Exclude(bazel.NoConfigAxis, "", toRemove)
Liz Kammer54309532021-12-14 12:21:22 -05001662 la.implementationDynamicDeps.Exclude(bazel.OsConfigurationAxis, "android", toRemove)
1663 la.implementationDynamicDeps.Exclude(bazel.OsConfigurationAxis, "linux_bionic", toRemove)
Liz Kammer91487d42022-09-13 11:27:11 -04001664
1665 la.implementationDynamicDeps.Exclude(bazel.OsAndInApexAxis, bazel.ConditionsDefaultConfigKey, toRemove)
Liz Kammer91487d42022-09-13 11:27:11 -04001666 stubsToRemove := make([]bazel.Label, 0, len(la.usedSystemDynamicDepAsDynamicDep))
1667 for _, lib := range toRemove.Includes {
Spandan Das2518c022023-03-17 03:02:32 +00001668 stubLabelInApiSurfaces := bazel.Label{
1669 Label: apiSurfaceModuleLibCurrentPackage + lib.OriginalModuleName,
1670 }
1671 stubsToRemove = append(stubsToRemove, stubLabelInApiSurfaces)
Liz Kammer91487d42022-09-13 11:27:11 -04001672 }
Spandan Das6d4d9da2023-04-18 06:20:40 +00001673 // system libraries (e.g. libc, libm, libdl) belong the com.android.runtime api domain
1674 // dedupe the stubs of these libraries from the other api domains (platform, other_apexes...)
1675 for _, aa := range ctx.Module().(*Module).ApexAvailable() {
1676 la.implementationDynamicDeps.Exclude(bazel.OsAndInApexAxis, inApexConfigSetting(aa), bazel.MakeLabelList(stubsToRemove))
1677 }
1678 la.implementationDynamicDeps.Exclude(bazel.OsAndInApexAxis, bazel.AndroidPlatform, bazel.MakeLabelList(stubsToRemove))
Liz Kammer54309532021-12-14 12:21:22 -05001679 }
Liz Kammerb4928432023-06-02 18:43:36 -04001680 if la.systemDynamicDeps.IsNil() && len(la.usedSystemDynamicDepAsStaticDep) > 0 {
1681 toRemove := bazelLabelForStaticDeps(ctx, android.SortedKeys(la.usedSystemDynamicDepAsStaticDep))
1682 la.deps.Exclude(bazel.NoConfigAxis, "", toRemove)
1683 la.deps.Exclude(bazel.OsConfigurationAxis, "android", toRemove)
1684 la.deps.Exclude(bazel.OsConfigurationAxis, "linux_bionic", toRemove)
1685 la.implementationDeps.Exclude(bazel.NoConfigAxis, "", toRemove)
1686 la.implementationDeps.Exclude(bazel.OsConfigurationAxis, "android", toRemove)
1687 la.implementationDeps.Exclude(bazel.OsConfigurationAxis, "linux_bionic", toRemove)
1688 }
Liz Kammer54309532021-12-14 12:21:22 -05001689
Liz Kammere6583482021-10-19 13:56:10 -04001690 la.deps.ResolveExcludes()
1691 la.implementationDeps.ResolveExcludes()
1692 la.dynamicDeps.ResolveExcludes()
1693 la.implementationDynamicDeps.ResolveExcludes()
1694 la.wholeArchiveDeps.ResolveExcludes()
1695 la.systemDynamicDeps.ForceSpecifyEmptyList = true
Liz Kammer54309532021-12-14 12:21:22 -05001696
Jingwen Chen91220d72021-03-24 02:18:33 -04001697}
1698
Jingwen Chened9c17d2021-04-13 07:14:55 +00001699// Relativize a list of root-relative paths with respect to the module's
1700// directory.
1701//
1702// include_dirs Soong prop are root-relative (b/183742505), but
1703// local_include_dirs, export_include_dirs and export_system_include_dirs are
1704// module dir relative. This function makes a list of paths entirely module dir
1705// relative.
1706//
1707// For the `include` attribute, Bazel wants the paths to be relative to the
1708// module.
1709func bp2BuildMakePathsRelativeToModule(ctx android.BazelConversionPathContext, paths []string) []string {
Rupert Shuttleworthb8151682021-04-06 20:06:21 +00001710 var relativePaths []string
1711 for _, path := range paths {
Jingwen Chened9c17d2021-04-13 07:14:55 +00001712 // Semantics of filepath.Rel: join(ModuleDir, rel(ModuleDir, path)) == path
1713 relativePath, err := filepath.Rel(ctx.ModuleDir(), path)
1714 if err != nil {
1715 panic(err)
1716 }
Rupert Shuttleworthb8151682021-04-06 20:06:21 +00001717 relativePaths = append(relativePaths, relativePath)
1718 }
1719 return relativePaths
1720}
1721
Liz Kammer5fad5012021-09-09 14:08:21 -04001722// BazelIncludes contains information about -I and -isystem paths from a module converted to Bazel
1723// attributes.
1724type BazelIncludes struct {
Liz Kammer1263d9b2021-12-10 14:28:20 -05001725 AbsoluteIncludes bazel.StringListAttribute
1726 Includes bazel.StringListAttribute
1727 SystemIncludes bazel.StringListAttribute
Liz Kammer5fad5012021-09-09 14:08:21 -04001728}
1729
Liz Kammer54549442022-05-11 13:55:06 -04001730func bp2BuildParseExportedIncludes(ctx android.BazelConversionPathContext, module *Module, includes *BazelIncludes) BazelIncludes {
Liz Kammer1263d9b2021-12-10 14:28:20 -05001731 var exported BazelIncludes
1732 if includes != nil {
1733 exported = *includes
1734 } else {
1735 exported = BazelIncludes{}
1736 }
Zi Wang1cb11802022-12-09 16:08:54 -08001737
1738 // cc library Export_include_dirs and Export_system_include_dirs are marked
1739 // "variant_prepend" in struct tag, set their prepend property to true to make
1740 // sure bp2build generates correct result.
1741 exported.Includes.Prepend = true
1742 exported.SystemIncludes.Prepend = true
1743
Trevor Radcliffe542954f2022-04-21 20:04:42 +00001744 bp2BuildPropParseHelper(ctx, module, &FlagExporterProperties{}, func(axis bazel.ConfigurationAxis, config string, props interface{}) {
1745 if flagExporterProperties, ok := props.(*FlagExporterProperties); ok {
1746 if len(flagExporterProperties.Export_include_dirs) > 0 {
1747 exported.Includes.SetSelectValue(axis, config, android.FirstUniqueStrings(append(exported.Includes.SelectValue(axis, config), flagExporterProperties.Export_include_dirs...)))
1748 }
1749 if len(flagExporterProperties.Export_system_include_dirs) > 0 {
1750 exported.SystemIncludes.SetSelectValue(axis, config, android.FirstUniqueStrings(append(exported.SystemIncludes.SelectValue(axis, config), flagExporterProperties.Export_system_include_dirs...)))
Rupert Shuttleworth375451e2021-04-26 07:49:08 -04001751 }
Rupert Shuttleworth375451e2021-04-26 07:49:08 -04001752 }
Trevor Radcliffe542954f2022-04-21 20:04:42 +00001753 })
Liz Kammer1263d9b2021-12-10 14:28:20 -05001754 exported.AbsoluteIncludes.DeduplicateAxesFromBase()
Liz Kammer5fad5012021-09-09 14:08:21 -04001755 exported.Includes.DeduplicateAxesFromBase()
1756 exported.SystemIncludes.DeduplicateAxesFromBase()
Rupert Shuttleworth375451e2021-04-26 07:49:08 -04001757
Liz Kammer5fad5012021-09-09 14:08:21 -04001758 return exported
Jingwen Chen91220d72021-03-24 02:18:33 -04001759}
Chris Parsons953b3562021-09-20 15:14:39 -04001760
Trevor Radcliffecee4e052022-09-06 19:31:25 +00001761func BazelLabelNameForStaticModule(baseLabel string) string {
1762 return baseLabel + "_bp2build_cc_library_static"
1763}
1764
Jingwen Chen55bc8202021-11-02 06:40:51 +00001765func bazelLabelForStaticModule(ctx android.BazelConversionPathContext, m blueprint.Module) string {
Chris Parsons953b3562021-09-20 15:14:39 -04001766 label := android.BazelModuleLabel(ctx, m)
Sasha Smundak39a301c2022-12-29 17:11:49 -08001767 if ccModule, ok := m.(*Module); ok && ccModule.typ() == fullLibrary {
Trevor Radcliffecee4e052022-09-06 19:31:25 +00001768 return BazelLabelNameForStaticModule(label)
Chris Parsons953b3562021-09-20 15:14:39 -04001769 }
1770 return label
1771}
1772
Jingwen Chen55bc8202021-11-02 06:40:51 +00001773func bazelLabelForSharedModule(ctx android.BazelConversionPathContext, m blueprint.Module) string {
Chris Parsons953b3562021-09-20 15:14:39 -04001774 // cc_library, at it's root name, propagates the shared library, which depends on the static
1775 // library.
1776 return android.BazelModuleLabel(ctx, m)
1777}
1778
Jingwen Chen55bc8202021-11-02 06:40:51 +00001779func bazelLabelForStaticWholeModuleDeps(ctx android.BazelConversionPathContext, m blueprint.Module) string {
Chris Parsons953b3562021-09-20 15:14:39 -04001780 label := bazelLabelForStaticModule(ctx, m)
1781 if aModule, ok := m.(android.Module); ok {
1782 if android.IsModulePrebuilt(aModule) {
1783 label += "_alwayslink"
1784 }
1785 }
1786 return label
1787}
1788
Liz Kammer5f5dbaa2023-07-17 17:44:08 -04001789func xsdConfigCppTarget(xsd android.XsdConfigBp2buildTargets) string {
1790 return xsd.CppBp2buildTargetName()
Liz Kammer084d6a92023-06-22 16:23:53 -04001791}
1792
Jingwen Chen55bc8202021-11-02 06:40:51 +00001793func bazelLabelForWholeDeps(ctx android.BazelConversionPathContext, modules []string) bazel.LabelList {
Chris Parsons953b3562021-09-20 15:14:39 -04001794 return android.BazelLabelForModuleDepsWithFn(ctx, modules, bazelLabelForStaticWholeModuleDeps)
1795}
1796
Jingwen Chen55bc8202021-11-02 06:40:51 +00001797func bazelLabelForWholeDepsExcludes(ctx android.BazelConversionPathContext, modules, excludes []string) bazel.LabelList {
Chris Parsons953b3562021-09-20 15:14:39 -04001798 return android.BazelLabelForModuleDepsExcludesWithFn(ctx, modules, excludes, bazelLabelForStaticWholeModuleDeps)
1799}
1800
Jingwen Chen55bc8202021-11-02 06:40:51 +00001801func bazelLabelForStaticDepsExcludes(ctx android.BazelConversionPathContext, modules, excludes []string) bazel.LabelList {
Chris Parsons953b3562021-09-20 15:14:39 -04001802 return android.BazelLabelForModuleDepsExcludesWithFn(ctx, modules, excludes, bazelLabelForStaticModule)
1803}
1804
Jingwen Chen55bc8202021-11-02 06:40:51 +00001805func bazelLabelForStaticDeps(ctx android.BazelConversionPathContext, modules []string) bazel.LabelList {
Chris Parsons953b3562021-09-20 15:14:39 -04001806 return android.BazelLabelForModuleDepsWithFn(ctx, modules, bazelLabelForStaticModule)
1807}
1808
Jingwen Chen55bc8202021-11-02 06:40:51 +00001809func bazelLabelForSharedDeps(ctx android.BazelConversionPathContext, modules []string) bazel.LabelList {
Chris Parsons953b3562021-09-20 15:14:39 -04001810 return android.BazelLabelForModuleDepsWithFn(ctx, modules, bazelLabelForSharedModule)
1811}
1812
Jingwen Chen55bc8202021-11-02 06:40:51 +00001813func bazelLabelForHeaderDeps(ctx android.BazelConversionPathContext, modules []string) bazel.LabelList {
Chris Parsons953b3562021-09-20 15:14:39 -04001814 // This is not elegant, but bp2build's shared library targets only propagate
1815 // their header information as part of the normal C++ provider.
1816 return bazelLabelForSharedDeps(ctx, modules)
1817}
1818
Zi Wang0a8a1292022-08-30 06:27:01 +00001819func bazelLabelForHeaderDepsExcludes(ctx android.BazelConversionPathContext, modules, excludes []string) bazel.LabelList {
1820 // This is only used when product_variable header_libs is processed, to follow
1821 // the pattern of depResolutionFunc
1822 return android.BazelLabelForModuleDepsExcludesWithFn(ctx, modules, excludes, bazelLabelForSharedModule)
1823}
1824
Jingwen Chen55bc8202021-11-02 06:40:51 +00001825func bazelLabelForSharedDepsExcludes(ctx android.BazelConversionPathContext, modules, excludes []string) bazel.LabelList {
Chris Parsons953b3562021-09-20 15:14:39 -04001826 return android.BazelLabelForModuleDepsExcludesWithFn(ctx, modules, excludes, bazelLabelForSharedModule)
1827}
Liz Kammer2b8004b2021-10-04 13:55:44 -04001828
1829type binaryLinkerAttrs struct {
1830 Linkshared *bool
Spandan Das39ccf932023-05-26 18:03:39 +00001831 Stem bazel.StringAttribute
Alex Márquez Pérez Muñíz Díaz Púras Thaureauxa56e9702022-02-23 18:39:59 -05001832 Suffix bazel.StringAttribute
Liz Kammer2b8004b2021-10-04 13:55:44 -04001833}
1834
Jingwen Chen55bc8202021-11-02 06:40:51 +00001835func bp2buildBinaryLinkerProps(ctx android.BazelConversionPathContext, m *Module) binaryLinkerAttrs {
Liz Kammer2b8004b2021-10-04 13:55:44 -04001836 attrs := binaryLinkerAttrs{}
Trevor Radcliffe542954f2022-04-21 20:04:42 +00001837 bp2BuildPropParseHelper(ctx, m, &BinaryLinkerProperties{}, func(axis bazel.ConfigurationAxis, config string, props interface{}) {
1838 linkerProps := props.(*BinaryLinkerProperties)
1839 staticExecutable := linkerProps.Static_executable
1840 if axis == bazel.NoConfigAxis {
1841 if linkBinaryShared := !proptools.Bool(staticExecutable); !linkBinaryShared {
1842 attrs.Linkshared = &linkBinaryShared
Liz Kammer2b8004b2021-10-04 13:55:44 -04001843 }
Trevor Radcliffe542954f2022-04-21 20:04:42 +00001844 } else if staticExecutable != nil {
1845 // TODO(b/202876379): Static_executable is arch-variant; however, linkshared is a
1846 // nonconfigurable attribute. Only 4 AOSP modules use this feature, defer handling
1847 ctx.ModuleErrorf("bp2build cannot migrate a module with arch/target-specific static_executable values")
Liz Kammer2b8004b2021-10-04 13:55:44 -04001848 }
Spandan Das39ccf932023-05-26 18:03:39 +00001849 if stem := linkerProps.Stem; stem != nil {
1850 attrs.Stem.SetSelectValue(axis, config, stem)
1851 }
Alex Márquez Pérez Muñíz Díaz Púras Thaureauxa56e9702022-02-23 18:39:59 -05001852 if suffix := linkerProps.Suffix; suffix != nil {
1853 attrs.Suffix.SetSelectValue(axis, config, suffix)
1854 }
Trevor Radcliffe542954f2022-04-21 20:04:42 +00001855 })
Liz Kammer2b8004b2021-10-04 13:55:44 -04001856
1857 return attrs
1858}
Trevor Radcliffedb7e0262022-10-28 16:48:18 +00001859
1860func bp2buildSanitizerFeatures(ctx android.BazelConversionPathContext, m *Module) bazel.StringListAttribute {
1861 sanitizerFeatures := bazel.StringListAttribute{}
1862 bp2BuildPropParseHelper(ctx, m, &SanitizeProperties{}, func(axis bazel.ConfigurationAxis, config string, props interface{}) {
1863 var features []string
1864 if sanitizerProps, ok := props.(*SanitizeProperties); ok {
1865 if sanitizerProps.Sanitize.Integer_overflow != nil && *sanitizerProps.Sanitize.Integer_overflow {
1866 features = append(features, "ubsan_integer_overflow")
1867 }
1868 for _, sanitizer := range sanitizerProps.Sanitize.Misc_undefined {
1869 features = append(features, "ubsan_"+sanitizer)
1870 }
Trevor Radcliffeded095c2023-06-12 19:18:28 +00001871 blocklist := sanitizerProps.Sanitize.Blocklist
1872 if blocklist != nil {
1873 // Format the blocklist name to be used in a feature name
1874 blocklistFeatureSuffix := strings.Replace(strings.ToLower(*blocklist), ".", "_", -1)
Trevor Radcliffed7148712023-07-10 18:50:47 +00001875 features = append(features, "sanitizer_blocklist_"+blocklistFeatureSuffix)
Trevor Radcliffeded095c2023-06-12 19:18:28 +00001876 }
Trevor Radcliffe523c5c62023-06-16 20:15:45 +00001877 if sanitizerProps.Sanitize.Cfi != nil && !proptools.Bool(sanitizerProps.Sanitize.Cfi) {
1878 features = append(features, "-android_cfi")
1879 } else if proptools.Bool(sanitizerProps.Sanitize.Cfi) {
Trevor Radcliffe27669c02023-03-28 20:47:10 +00001880 features = append(features, "android_cfi")
1881 if proptools.Bool(sanitizerProps.Sanitize.Config.Cfi_assembly_support) {
1882 features = append(features, "android_cfi_assembly_support")
1883 }
1884 }
Trevor Radcliffedb7e0262022-10-28 16:48:18 +00001885 sanitizerFeatures.SetSelectValue(axis, config, features)
1886 }
1887 })
1888 return sanitizerFeatures
1889}
Trevor Radcliffe56b1a2b2023-02-06 21:58:30 +00001890
1891func bp2buildLtoFeatures(ctx android.BazelConversionPathContext, m *Module) bazel.StringListAttribute {
1892 lto_feature_name := "android_thin_lto"
1893 ltoBoolFeatures := bazel.BoolAttribute{}
1894 bp2BuildPropParseHelper(ctx, m, &LTOProperties{}, func(axis bazel.ConfigurationAxis, config string, props interface{}) {
1895 if ltoProps, ok := props.(*LTOProperties); ok {
1896 thinProp := ltoProps.Lto.Thin != nil && *ltoProps.Lto.Thin
1897 thinPropSetToFalse := ltoProps.Lto.Thin != nil && !*ltoProps.Lto.Thin
1898 neverProp := ltoProps.Lto.Never != nil && *ltoProps.Lto.Never
1899 if thinProp {
1900 ltoBoolFeatures.SetSelectValue(axis, config, BoolPtr(true))
1901 return
1902 }
1903 if neverProp || thinPropSetToFalse {
1904 if thinProp {
1905 ctx.ModuleErrorf("lto.thin and lto.never are mutually exclusive but were specified together")
1906 } else {
1907 ltoBoolFeatures.SetSelectValue(axis, config, BoolPtr(false))
1908 }
1909 return
1910 }
1911 }
1912 ltoBoolFeatures.SetSelectValue(axis, config, nil)
1913 })
1914
1915 props := m.GetArchVariantProperties(ctx, &LTOProperties{})
1916 ltoStringFeatures, err := ltoBoolFeatures.ToStringListAttribute(func(boolPtr *bool, axis bazel.ConfigurationAxis, config string) []string {
1917 if boolPtr == nil {
1918 return []string{}
1919 }
1920 if !*boolPtr {
1921 return []string{"-" + lto_feature_name}
1922 }
1923 features := []string{lto_feature_name}
1924 if ltoProps, ok := props[axis][config].(*LTOProperties); ok {
1925 if ltoProps.Whole_program_vtables != nil && *ltoProps.Whole_program_vtables {
1926 features = append(features, "android_thin_lto_whole_program_vtables")
1927 }
1928 }
1929 return features
1930 })
1931 if err != nil {
1932 ctx.ModuleErrorf("Error processing LTO attributes: %s", err)
1933 }
1934 return ltoStringFeatures
1935}
Trevor Radcliffea8b44162023-04-14 18:25:24 +00001936
1937func convertHiddenVisibilityToFeatureBase(ctx android.BazelConversionPathContext, m *Module) bazel.StringListAttribute {
1938 visibilityHiddenFeature := bazel.StringListAttribute{}
1939 bp2BuildPropParseHelper(ctx, m, &BaseCompilerProperties{}, func(axis bazel.ConfigurationAxis, configString string, props interface{}) {
1940 if baseCompilerProps, ok := props.(*BaseCompilerProperties); ok {
1941 convertHiddenVisibilityToFeatureHelper(&visibilityHiddenFeature, axis, configString, baseCompilerProps.Cflags)
1942 }
1943 })
1944 return visibilityHiddenFeature
1945}
1946
1947func convertHiddenVisibilityToFeatureStaticOrShared(ctx android.BazelConversionPathContext, m *Module, isStatic bool) bazel.StringListAttribute {
1948 visibilityHiddenFeature := bazel.StringListAttribute{}
1949 if isStatic {
1950 bp2BuildPropParseHelper(ctx, m, &StaticProperties{}, func(axis bazel.ConfigurationAxis, configString string, props interface{}) {
1951 if staticProps, ok := props.(*StaticProperties); ok {
1952 convertHiddenVisibilityToFeatureHelper(&visibilityHiddenFeature, axis, configString, staticProps.Static.Cflags)
1953 }
1954 })
1955 } else {
1956 bp2BuildPropParseHelper(ctx, m, &SharedProperties{}, func(axis bazel.ConfigurationAxis, configString string, props interface{}) {
1957 if sharedProps, ok := props.(*SharedProperties); ok {
1958 convertHiddenVisibilityToFeatureHelper(&visibilityHiddenFeature, axis, configString, sharedProps.Shared.Cflags)
1959 }
1960 })
1961 }
1962
1963 return visibilityHiddenFeature
1964}
1965
1966func convertHiddenVisibilityToFeatureHelper(feature *bazel.StringListAttribute, axis bazel.ConfigurationAxis, configString string, cflags []string) {
1967 if inList(config.VisibilityHiddenFlag, cflags) {
1968 feature.SetSelectValue(axis, configString, []string{"visibility_hidden"})
1969 }
1970}