blob: 354892386b9f7a92f43e73a05dd0c8dc1b5b7f42 [file] [log] [blame]
Irvelc274c632016-06-13 16:44:08 -07001/*
2 * Copyright 2016 The Android Open Source Project
3 *
4 * Licensed under the Apache License, Version 2.0 (the "License");
5 * you may not use this file except in compliance with the License.
6 * You may obtain a copy of the License at
7 *
8 * http://www.apache.org/licenses/LICENSE-2.0
9 *
10 * Unless required by applicable law or agreed to in writing, software
11 * distributed under the License is distributed on an "AS IS" BASIS,
12 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
13 * See the License for the specific language governing permissions and
14 * limitations under the License.
15 */
Ady Abrahamb0dbdaa2020-01-06 16:19:42 -080016
17// TODO(b/129481165): remove the #pragma below and fix conversion issues
18#pragma clang diagnostic push
19#pragma clang diagnostic ignored "-Wconversion"
Irvelc274c632016-06-13 16:44:08 -070020#undef LOG_TAG
21#define LOG_TAG "SurfaceInterceptor"
22#define ATRACE_TAG ATRACE_TAG_GRAPHICS
23
24#include "Layer.h"
25#include "SurfaceFlinger.h"
26#include "SurfaceInterceptor.h"
Colin Cross63549382016-10-26 12:52:53 -070027
Irvelc274c632016-06-13 16:44:08 -070028#include <fstream>
29
Mark Salyzyn4dad9ce2016-09-29 08:08:05 -070030#include <android-base/file.h>
31#include <log/log.h>
32#include <utils/Trace.h>
33
Irvelc274c632016-06-13 16:44:08 -070034namespace android {
35
36// ----------------------------------------------------------------------------
Marissa Wall61c58622018-07-18 10:12:20 -070037// TODO(marissaw): add new layer state values to SurfaceInterceptor
Irvelc274c632016-06-13 16:44:08 -070038
Lloyd Pique4dccc412018-01-22 17:21:36 -080039SurfaceInterceptor::~SurfaceInterceptor() = default;
40
41namespace impl {
42
Pablo Gamito6ee484d2020-07-30 14:26:28 +000043void SurfaceInterceptor::addTransactionTraceListener(
44 const sp<gui::ITransactionTraceListener>& listener) {
45 sp<IBinder> asBinder = IInterface::asBinder(listener);
46
47 std::scoped_lock lock(mListenersMutex);
48
49 asBinder->linkToDeath(this);
50
51 listener->onToggled(mEnabled); // notifies of current state
52
53 mTraceToggledListeners.emplace(asBinder, listener);
54}
55
Pablo Gamito5cfc6e52020-09-10 11:18:03 +000056void SurfaceInterceptor::binderDied(const wp<IBinder>& who) {
Pablo Gamito6ee484d2020-07-30 14:26:28 +000057 std::scoped_lock lock(mListenersMutex);
58 mTraceToggledListeners.erase(who);
Pablo Gamito5cfc6e52020-09-10 11:18:03 +000059}
60
Irvelffc9efc2016-07-27 15:16:37 -070061void SurfaceInterceptor::enable(const SortedVector<sp<Layer>>& layers,
62 const DefaultKeyedVector< wp<IBinder>, DisplayDeviceState>& displays)
63{
Irvelc274c632016-06-13 16:44:08 -070064 if (mEnabled) {
65 return;
66 }
Irvelffc9efc2016-07-27 15:16:37 -070067 ATRACE_CALL();
Pablo Gamito6ee484d2020-07-30 14:26:28 +000068 {
69 std::scoped_lock lock(mListenersMutex);
70 for (const auto& [_, listener] : mTraceToggledListeners) {
71 listener->onToggled(true);
72 }
73 }
Irvelc274c632016-06-13 16:44:08 -070074 mEnabled = true;
Pablo Gamito6ee484d2020-07-30 14:26:28 +000075 std::scoped_lock<std::mutex> protoGuard(mTraceMutex);
Irvelffc9efc2016-07-27 15:16:37 -070076 saveExistingDisplaysLocked(displays);
77 saveExistingSurfacesLocked(layers);
Irvelc274c632016-06-13 16:44:08 -070078}
79
80void SurfaceInterceptor::disable() {
Irvelc274c632016-06-13 16:44:08 -070081 if (!mEnabled) {
82 return;
83 }
Irvelffc9efc2016-07-27 15:16:37 -070084 ATRACE_CALL();
Pablo Gamito6ee484d2020-07-30 14:26:28 +000085 {
86 std::scoped_lock lock(mListenersMutex);
87 for (const auto& [_, listener] : mTraceToggledListeners) {
88 listener->onToggled(false);
89 }
90 }
Irvelc274c632016-06-13 16:44:08 -070091 mEnabled = false;
Pablo Gamito6ee484d2020-07-30 14:26:28 +000092 std::scoped_lock<std::mutex> protoGuard(mTraceMutex);
Irvelc274c632016-06-13 16:44:08 -070093 status_t err(writeProtoFileLocked());
94 ALOGE_IF(err == PERMISSION_DENIED, "Could not save the proto file! Permission denied");
95 ALOGE_IF(err == NOT_ENOUGH_DATA, "Could not save the proto file! There are missing fields");
96 mTrace.Clear();
97}
98
Irvelffc9efc2016-07-27 15:16:37 -070099bool SurfaceInterceptor::isEnabled() {
100 return mEnabled;
101}
102
103void SurfaceInterceptor::saveExistingDisplaysLocked(
104 const DefaultKeyedVector< wp<IBinder>, DisplayDeviceState>& displays)
105{
106 // Caveat: The initial snapshot does not capture the power mode of the existing displays
Irvelc274c632016-06-13 16:44:08 -0700107 ATRACE_CALL();
Irvelffc9efc2016-07-27 15:16:37 -0700108 for (size_t i = 0 ; i < displays.size() ; i++) {
109 addDisplayCreationLocked(createTraceIncrementLocked(), displays[i]);
110 addInitialDisplayStateLocked(createTraceIncrementLocked(), displays[i]);
Irvelc274c632016-06-13 16:44:08 -0700111 }
112}
113
Irvelffc9efc2016-07-27 15:16:37 -0700114void SurfaceInterceptor::saveExistingSurfacesLocked(const SortedVector<sp<Layer>>& layers) {
Irvelc274c632016-06-13 16:44:08 -0700115 ATRACE_CALL();
Robert Carr1f0a16a2016-10-24 16:27:39 -0700116 for (const auto& l : layers) {
Dan Stoza412903f2017-04-27 13:42:17 -0700117 l->traverseInZOrder(LayerVector::StateSet::Drawing, [this](Layer* layer) {
Robert Carr1f0a16a2016-10-24 16:27:39 -0700118 addSurfaceCreationLocked(createTraceIncrementLocked(), layer);
119 addInitialSurfaceStateLocked(createTraceIncrementLocked(), layer);
120 });
Irvelc274c632016-06-13 16:44:08 -0700121 }
Irvelffc9efc2016-07-27 15:16:37 -0700122}
123
124void SurfaceInterceptor::addInitialSurfaceStateLocked(Increment* increment,
125 const sp<const Layer>& layer)
126{
Irvelc274c632016-06-13 16:44:08 -0700127 Transaction* transaction(increment->mutable_transaction());
Lloyd Piquef1c675b2018-09-12 20:45:39 -0700128 const uint32_t layerFlags = layer->getTransactionFlags();
129 transaction->set_synchronous(layerFlags & BnSurfaceComposer::eSynchronous);
130 transaction->set_animation(layerFlags & BnSurfaceComposer::eAnimation);
Irvelc274c632016-06-13 16:44:08 -0700131
132 const int32_t layerId(getLayerId(layer));
Lloyd Pique0449b0f2018-12-20 16:23:45 -0800133 addPositionLocked(transaction, layerId, layer->mCurrentState.active_legacy.transform.tx(),
134 layer->mCurrentState.active_legacy.transform.ty());
135 addDepthLocked(transaction, layerId, layer->mCurrentState.z);
136 addAlphaLocked(transaction, layerId, layer->mCurrentState.color.a);
Marissa Wallf58c14b2018-07-24 10:50:43 -0700137 addTransparentRegionLocked(transaction, layerId,
Lloyd Pique0449b0f2018-12-20 16:23:45 -0800138 layer->mCurrentState.activeTransparentRegion_legacy);
139 addLayerStackLocked(transaction, layerId, layer->mCurrentState.layerStack);
140 addCropLocked(transaction, layerId, layer->mCurrentState.crop_legacy);
141 addCornerRadiusLocked(transaction, layerId, layer->mCurrentState.cornerRadius);
Lucas Dupin19c8f0e2019-11-25 17:55:44 -0800142 addBackgroundBlurRadiusLocked(transaction, layerId, layer->mCurrentState.backgroundBlurRadius);
Lucas Dupinc3800b82020-10-02 16:24:48 -0700143 addBlurRegionsLocked(transaction, layerId, layer->mCurrentState.blurRegions);
Lloyd Pique0449b0f2018-12-20 16:23:45 -0800144 if (layer->mCurrentState.barrierLayer_legacy != nullptr) {
Marissa Wallf58c14b2018-07-24 10:50:43 -0700145 addDeferTransactionLocked(transaction, layerId,
Lloyd Pique0449b0f2018-12-20 16:23:45 -0800146 layer->mCurrentState.barrierLayer_legacy.promote(),
Vishnu Nair6b7c5c92020-09-29 17:27:05 -0700147 layer->mCurrentState.barrierFrameNumber);
Irvelc274c632016-06-13 16:44:08 -0700148 }
Vishnu Nair456bbb22019-07-18 16:02:00 -0700149 addFlagsLocked(transaction, layerId, layer->mCurrentState.flags,
150 layer_state_t::eLayerHidden | layer_state_t::eLayerOpaque |
151 layer_state_t::eLayerSecure);
152 addReparentLocked(transaction, layerId, getLayerIdFromWeakRef(layer->mCurrentParent));
153 addDetachChildrenLocked(transaction, layerId, layer->isLayerDetached());
154 addRelativeParentLocked(transaction, layerId,
155 getLayerIdFromWeakRef(layer->mCurrentState.zOrderRelativeOf),
156 layer->mCurrentState.z);
Vishnu Nair95a1ed42019-12-06 12:25:11 -0800157 addShadowRadiusLocked(transaction, layerId, layer->mCurrentState.shadowRadius);
Irvelc274c632016-06-13 16:44:08 -0700158}
159
Irvelffc9efc2016-07-27 15:16:37 -0700160void SurfaceInterceptor::addInitialDisplayStateLocked(Increment* increment,
161 const DisplayDeviceState& display)
162{
163 Transaction* transaction(increment->mutable_transaction());
164 transaction->set_synchronous(false);
165 transaction->set_animation(false);
166
Dominik Laskowski663bd282018-04-19 15:26:54 -0700167 addDisplaySurfaceLocked(transaction, display.sequenceId, display.surface);
168 addDisplayLayerStackLocked(transaction, display.sequenceId, display.layerStack);
169 addDisplaySizeLocked(transaction, display.sequenceId, display.width, display.height);
Dominik Laskowski718f9602019-11-09 20:01:35 -0800170 addDisplayProjectionLocked(transaction, display.sequenceId, toRotationInt(display.orientation),
Marin Shalamanov6ad317c2020-07-29 23:34:07 +0200171 display.layerStackSpaceRect, display.orientedDisplaySpaceRect);
Irvelffc9efc2016-07-27 15:16:37 -0700172}
173
Irvelc274c632016-06-13 16:44:08 -0700174status_t SurfaceInterceptor::writeProtoFileLocked() {
175 ATRACE_CALL();
Colin Cross63549382016-10-26 12:52:53 -0700176 std::string output;
177
Irvelc274c632016-06-13 16:44:08 -0700178 if (!mTrace.IsInitialized()) {
179 return NOT_ENOUGH_DATA;
180 }
Colin Cross63549382016-10-26 12:52:53 -0700181 if (!mTrace.SerializeToString(&output)) {
Irvelc274c632016-06-13 16:44:08 -0700182 return PERMISSION_DENIED;
183 }
Colin Cross63549382016-10-26 12:52:53 -0700184 if (!android::base::WriteStringToFile(output, mOutputFileName, true)) {
185 return PERMISSION_DENIED;
186 }
187
Irvelc274c632016-06-13 16:44:08 -0700188 return NO_ERROR;
189}
190
Vishnu Nair456bbb22019-07-18 16:02:00 -0700191const sp<const Layer> SurfaceInterceptor::getLayer(const wp<const IBinder>& weakHandle) const {
Irvel3017c612016-08-09 16:50:06 -0700192 const sp<const IBinder>& handle(weakHandle.promote());
Irvelc274c632016-06-13 16:44:08 -0700193 const auto layerHandle(static_cast<const Layer::Handle*>(handle.get()));
194 const sp<const Layer> layer(layerHandle->owner.promote());
195 // layer could be a nullptr at this point
196 return layer;
197}
198
Vishnu Nair456bbb22019-07-18 16:02:00 -0700199int32_t SurfaceInterceptor::getLayerId(const sp<const Layer>& layer) const {
Irvelc274c632016-06-13 16:44:08 -0700200 return layer->sequence;
201}
202
Vishnu Nair456bbb22019-07-18 16:02:00 -0700203int32_t SurfaceInterceptor::getLayerIdFromWeakRef(const wp<const Layer>& layer) const {
204 if (layer == nullptr) {
205 return -1;
206 }
207 auto strongLayer = layer.promote();
208 return strongLayer == nullptr ? -1 : getLayerId(strongLayer);
209}
210
211int32_t SurfaceInterceptor::getLayerIdFromHandle(const sp<const IBinder>& handle) const {
212 if (handle == nullptr) {
213 return -1;
214 }
215 const auto layerHandle(static_cast<const Layer::Handle*>(handle.get()));
216 const sp<const Layer> layer(layerHandle->owner.promote());
217 return layer == nullptr ? -1 : getLayerId(layer);
218}
219
Irvelffc9efc2016-07-27 15:16:37 -0700220Increment* SurfaceInterceptor::createTraceIncrementLocked() {
Irvelc274c632016-06-13 16:44:08 -0700221 Increment* increment(mTrace.add_increment());
Vishnu Nair45cb21a2020-03-27 17:39:24 -0700222 increment->set_time_stamp(elapsedRealtimeNano());
Irvelc274c632016-06-13 16:44:08 -0700223 return increment;
224}
225
Irvelffc9efc2016-07-27 15:16:37 -0700226SurfaceChange* SurfaceInterceptor::createSurfaceChangeLocked(Transaction* transaction,
227 int32_t layerId)
228{
229 SurfaceChange* change(transaction->add_surface_change());
Irvelc274c632016-06-13 16:44:08 -0700230 change->set_id(layerId);
231 return change;
232}
233
Irvelffc9efc2016-07-27 15:16:37 -0700234DisplayChange* SurfaceInterceptor::createDisplayChangeLocked(Transaction* transaction,
Dominik Laskowski663bd282018-04-19 15:26:54 -0700235 int32_t sequenceId)
Irvelffc9efc2016-07-27 15:16:37 -0700236{
237 DisplayChange* dispChange(transaction->add_display_change());
Dominik Laskowski663bd282018-04-19 15:26:54 -0700238 dispChange->set_id(sequenceId);
Irvelffc9efc2016-07-27 15:16:37 -0700239 return dispChange;
240}
241
Irvelc274c632016-06-13 16:44:08 -0700242void SurfaceInterceptor::setProtoRectLocked(Rectangle* protoRect, const Rect& rect) {
243 protoRect->set_left(rect.left);
244 protoRect->set_top(rect.top);
245 protoRect->set_right(rect.right);
246 protoRect->set_bottom(rect.bottom);
247}
248
Pablo Gamito3e8f0e62020-06-22 15:55:39 +0000249void SurfaceInterceptor::setTransactionOriginLocked(Transaction* transaction, int32_t pid,
250 int32_t uid) {
251 Origin* origin(transaction->mutable_origin());
252 origin->set_pid(pid);
253 origin->set_uid(uid);
254}
255
Irvelffc9efc2016-07-27 15:16:37 -0700256void SurfaceInterceptor::addPositionLocked(Transaction* transaction, int32_t layerId,
257 float x, float y)
Irvelc274c632016-06-13 16:44:08 -0700258{
Irvelffc9efc2016-07-27 15:16:37 -0700259 SurfaceChange* change(createSurfaceChangeLocked(transaction, layerId));
Irvelc274c632016-06-13 16:44:08 -0700260 PositionChange* posChange(change->mutable_position());
261 posChange->set_x(x);
262 posChange->set_y(y);
263}
264
Irvelffc9efc2016-07-27 15:16:37 -0700265void SurfaceInterceptor::addDepthLocked(Transaction* transaction, int32_t layerId,
266 uint32_t z)
267{
268 SurfaceChange* change(createSurfaceChangeLocked(transaction, layerId));
Irvelc274c632016-06-13 16:44:08 -0700269 LayerChange* depthChange(change->mutable_layer());
270 depthChange->set_layer(z);
271}
272
273void SurfaceInterceptor::addSizeLocked(Transaction* transaction, int32_t layerId, uint32_t w,
274 uint32_t h)
275{
Irvelffc9efc2016-07-27 15:16:37 -0700276 SurfaceChange* change(createSurfaceChangeLocked(transaction, layerId));
Irvelc274c632016-06-13 16:44:08 -0700277 SizeChange* sizeChange(change->mutable_size());
278 sizeChange->set_w(w);
279 sizeChange->set_h(h);
280}
281
Irvelffc9efc2016-07-27 15:16:37 -0700282void SurfaceInterceptor::addAlphaLocked(Transaction* transaction, int32_t layerId,
283 float alpha)
284{
285 SurfaceChange* change(createSurfaceChangeLocked(transaction, layerId));
Irvelc274c632016-06-13 16:44:08 -0700286 AlphaChange* alphaChange(change->mutable_alpha());
287 alphaChange->set_alpha(alpha);
288}
289
290void SurfaceInterceptor::addMatrixLocked(Transaction* transaction, int32_t layerId,
291 const layer_state_t::matrix22_t& matrix)
292{
Irvelffc9efc2016-07-27 15:16:37 -0700293 SurfaceChange* change(createSurfaceChangeLocked(transaction, layerId));
Irvelc274c632016-06-13 16:44:08 -0700294 MatrixChange* matrixChange(change->mutable_matrix());
295 matrixChange->set_dsdx(matrix.dsdx);
296 matrixChange->set_dtdx(matrix.dtdx);
297 matrixChange->set_dsdy(matrix.dsdy);
298 matrixChange->set_dtdy(matrix.dtdy);
299}
300
Irvelffc9efc2016-07-27 15:16:37 -0700301void SurfaceInterceptor::addTransparentRegionLocked(Transaction* transaction,
302 int32_t layerId, const Region& transRegion)
Irvelc274c632016-06-13 16:44:08 -0700303{
Irvelffc9efc2016-07-27 15:16:37 -0700304 SurfaceChange* change(createSurfaceChangeLocked(transaction, layerId));
Irvelc274c632016-06-13 16:44:08 -0700305 TransparentRegionHintChange* transparentChange(change->mutable_transparent_region_hint());
306
307 for (const auto& rect : transRegion) {
308 Rectangle* protoRect(transparentChange->add_region());
309 setProtoRectLocked(protoRect, rect);
310 }
311}
312
Vishnu Nair456bbb22019-07-18 16:02:00 -0700313void SurfaceInterceptor::addFlagsLocked(Transaction* transaction, int32_t layerId, uint8_t flags,
314 uint8_t mask) {
Irvelc274c632016-06-13 16:44:08 -0700315 // There can be multiple flags changed
Vishnu Nair456bbb22019-07-18 16:02:00 -0700316 if (mask & layer_state_t::eLayerHidden) {
Irvelffc9efc2016-07-27 15:16:37 -0700317 SurfaceChange* change(createSurfaceChangeLocked(transaction, layerId));
Irvelc274c632016-06-13 16:44:08 -0700318 HiddenFlagChange* flagChange(change->mutable_hidden_flag());
Vishnu Nair456bbb22019-07-18 16:02:00 -0700319 flagChange->set_hidden_flag(flags & layer_state_t::eLayerHidden);
Irvelc274c632016-06-13 16:44:08 -0700320 }
Vishnu Nair456bbb22019-07-18 16:02:00 -0700321 if (mask & layer_state_t::eLayerOpaque) {
Irvelffc9efc2016-07-27 15:16:37 -0700322 SurfaceChange* change(createSurfaceChangeLocked(transaction, layerId));
Irvelc274c632016-06-13 16:44:08 -0700323 OpaqueFlagChange* flagChange(change->mutable_opaque_flag());
Vishnu Nair456bbb22019-07-18 16:02:00 -0700324 flagChange->set_opaque_flag(flags & layer_state_t::eLayerOpaque);
Irvelc274c632016-06-13 16:44:08 -0700325 }
Vishnu Nair456bbb22019-07-18 16:02:00 -0700326 if (mask & layer_state_t::eLayerSecure) {
Irvelffc9efc2016-07-27 15:16:37 -0700327 SurfaceChange* change(createSurfaceChangeLocked(transaction, layerId));
Irvelc274c632016-06-13 16:44:08 -0700328 SecureFlagChange* flagChange(change->mutable_secure_flag());
Vishnu Nair456bbb22019-07-18 16:02:00 -0700329 flagChange->set_secure_flag(flags & layer_state_t::eLayerSecure);
Irvelc274c632016-06-13 16:44:08 -0700330 }
331}
332
333void SurfaceInterceptor::addLayerStackLocked(Transaction* transaction, int32_t layerId,
334 uint32_t layerStack)
335{
Irvelffc9efc2016-07-27 15:16:37 -0700336 SurfaceChange* change(createSurfaceChangeLocked(transaction, layerId));
Irvelc274c632016-06-13 16:44:08 -0700337 LayerStackChange* layerStackChange(change->mutable_layer_stack());
338 layerStackChange->set_layer_stack(layerStack);
339}
340
341void SurfaceInterceptor::addCropLocked(Transaction* transaction, int32_t layerId,
342 const Rect& rect)
343{
Irvelffc9efc2016-07-27 15:16:37 -0700344 SurfaceChange* change(createSurfaceChangeLocked(transaction, layerId));
Irvelc274c632016-06-13 16:44:08 -0700345 CropChange* cropChange(change->mutable_crop());
346 Rectangle* protoRect(cropChange->mutable_rectangle());
347 setProtoRectLocked(protoRect, rect);
348}
349
Lucas Dupin1b6531c2018-07-05 17:18:21 -0700350void SurfaceInterceptor::addCornerRadiusLocked(Transaction* transaction, int32_t layerId,
351 float cornerRadius)
352{
353 SurfaceChange* change(createSurfaceChangeLocked(transaction, layerId));
354 CornerRadiusChange* cornerRadiusChange(change->mutable_corner_radius());
355 cornerRadiusChange->set_corner_radius(cornerRadius);
356}
357
Lucas Dupin19c8f0e2019-11-25 17:55:44 -0800358void SurfaceInterceptor::addBackgroundBlurRadiusLocked(Transaction* transaction, int32_t layerId,
359 int32_t backgroundBlurRadius) {
360 SurfaceChange* change(createSurfaceChangeLocked(transaction, layerId));
361 BackgroundBlurRadiusChange* blurRadiusChange(change->mutable_background_blur_radius());
362 blurRadiusChange->set_background_blur_radius(backgroundBlurRadius);
363}
364
Lucas Dupinc3800b82020-10-02 16:24:48 -0700365void SurfaceInterceptor::addBlurRegionsLocked(Transaction* transaction, int32_t layerId,
366 const std::vector<BlurRegion>& blurRegions) {
367 SurfaceChange* change(createSurfaceChangeLocked(transaction, layerId));
368 BlurRegionsChange* blurRegionsChange(change->mutable_blur_regions());
369 for (const auto blurRegion : blurRegions) {
370 const auto blurRegionChange = blurRegionsChange->add_blur_regions();
371 blurRegionChange->set_blur_radius(blurRegion.blurRadius);
372 blurRegionChange->set_corner_radius_tl(blurRegion.cornerRadiusTL);
373 blurRegionChange->set_corner_radius_tr(blurRegion.cornerRadiusTR);
374 blurRegionChange->set_corner_radius_bl(blurRegion.cornerRadiusBL);
375 blurRegionChange->set_corner_radius_br(blurRegion.cornerRadiusBR);
376 blurRegionChange->set_alpha(blurRegion.alpha);
377 blurRegionChange->set_left(blurRegion.left);
378 blurRegionChange->set_top(blurRegion.top);
379 blurRegionChange->set_right(blurRegion.right);
380 blurRegionChange->set_bottom(blurRegion.bottom);
381 }
382}
383
Irvelc274c632016-06-13 16:44:08 -0700384void SurfaceInterceptor::addDeferTransactionLocked(Transaction* transaction, int32_t layerId,
Robert Carr0d480722017-01-10 16:42:54 -0800385 const sp<const Layer>& layer, uint64_t frameNumber)
Irvelc274c632016-06-13 16:44:08 -0700386{
Irvelffc9efc2016-07-27 15:16:37 -0700387 SurfaceChange* change(createSurfaceChangeLocked(transaction, layerId));
Irvelc274c632016-06-13 16:44:08 -0700388 if (layer == nullptr) {
389 ALOGE("An existing layer could not be retrieved with the handle"
390 " for the deferred transaction");
391 return;
392 }
393 DeferredTransactionChange* deferTransaction(change->mutable_deferred_transaction());
394 deferTransaction->set_layer_id(getLayerId(layer));
395 deferTransaction->set_frame_number(frameNumber);
396}
397
Vishnu Nair456bbb22019-07-18 16:02:00 -0700398void SurfaceInterceptor::addReparentLocked(Transaction* transaction, int32_t layerId,
399 int32_t parentId) {
400 SurfaceChange* change(createSurfaceChangeLocked(transaction, layerId));
401 ReparentChange* overrideChange(change->mutable_reparent());
402 overrideChange->set_parent_id(parentId);
403}
404
405void SurfaceInterceptor::addReparentChildrenLocked(Transaction* transaction, int32_t layerId,
406 int32_t parentId) {
407 SurfaceChange* change(createSurfaceChangeLocked(transaction, layerId));
408 ReparentChildrenChange* overrideChange(change->mutable_reparent_children());
409 overrideChange->set_parent_id(parentId);
410}
411
412void SurfaceInterceptor::addDetachChildrenLocked(Transaction* transaction, int32_t layerId,
413 bool detached) {
414 SurfaceChange* change(createSurfaceChangeLocked(transaction, layerId));
415 DetachChildrenChange* overrideChange(change->mutable_detach_children());
416 overrideChange->set_detach_children(detached);
417}
418
419void SurfaceInterceptor::addRelativeParentLocked(Transaction* transaction, int32_t layerId,
420 int32_t parentId, int z) {
421 SurfaceChange* change(createSurfaceChangeLocked(transaction, layerId));
422 RelativeParentChange* overrideChange(change->mutable_relative_parent());
423 overrideChange->set_relative_parent_id(parentId);
424 overrideChange->set_z(z);
425}
426
Vishnu Nair95a1ed42019-12-06 12:25:11 -0800427void SurfaceInterceptor::addShadowRadiusLocked(Transaction* transaction, int32_t layerId,
428 float shadowRadius) {
429 SurfaceChange* change(createSurfaceChangeLocked(transaction, layerId));
430 ShadowRadiusChange* overrideChange(change->mutable_shadow_radius());
431 overrideChange->set_radius(shadowRadius);
432}
433
Irvelffc9efc2016-07-27 15:16:37 -0700434void SurfaceInterceptor::addSurfaceChangesLocked(Transaction* transaction,
Irvelc274c632016-06-13 16:44:08 -0700435 const layer_state_t& state)
436{
437 const sp<const Layer> layer(getLayer(state.surface));
438 if (layer == nullptr) {
439 ALOGE("An existing layer could not be retrieved with the surface "
440 "from the layer_state_t surface in the update transaction");
441 return;
442 }
443
444 const int32_t layerId(getLayerId(layer));
445
446 if (state.what & layer_state_t::ePositionChanged) {
447 addPositionLocked(transaction, layerId, state.x, state.y);
448 }
449 if (state.what & layer_state_t::eLayerChanged) {
450 addDepthLocked(transaction, layerId, state.z);
451 }
452 if (state.what & layer_state_t::eSizeChanged) {
453 addSizeLocked(transaction, layerId, state.w, state.h);
454 }
455 if (state.what & layer_state_t::eAlphaChanged) {
456 addAlphaLocked(transaction, layerId, state.alpha);
457 }
458 if (state.what & layer_state_t::eMatrixChanged) {
459 addMatrixLocked(transaction, layerId, state.matrix);
460 }
461 if (state.what & layer_state_t::eTransparentRegionChanged) {
462 addTransparentRegionLocked(transaction, layerId, state.transparentRegion);
463 }
464 if (state.what & layer_state_t::eFlagsChanged) {
Vishnu Nair456bbb22019-07-18 16:02:00 -0700465 addFlagsLocked(transaction, layerId, state.flags, state.mask);
Irvelc274c632016-06-13 16:44:08 -0700466 }
467 if (state.what & layer_state_t::eLayerStackChanged) {
468 addLayerStackLocked(transaction, layerId, state.layerStack);
469 }
Marissa Wallf58c14b2018-07-24 10:50:43 -0700470 if (state.what & layer_state_t::eCropChanged_legacy) {
471 addCropLocked(transaction, layerId, state.crop_legacy);
Irvelc274c632016-06-13 16:44:08 -0700472 }
Lucas Dupin1b6531c2018-07-05 17:18:21 -0700473 if (state.what & layer_state_t::eCornerRadiusChanged) {
474 addCornerRadiusLocked(transaction, layerId, state.cornerRadius);
475 }
Lucas Dupin19c8f0e2019-11-25 17:55:44 -0800476 if (state.what & layer_state_t::eBackgroundBlurRadiusChanged) {
477 addBackgroundBlurRadiusLocked(transaction, layerId, state.backgroundBlurRadius);
478 }
Lucas Dupinc3800b82020-10-02 16:24:48 -0700479 if (state.what & layer_state_t::eBlurRegionsChanged) {
480 addBlurRegionsLocked(transaction, layerId, state.blurRegions);
481 }
Marissa Wallf58c14b2018-07-24 10:50:43 -0700482 if (state.what & layer_state_t::eDeferTransaction_legacy) {
Robert Carr0d480722017-01-10 16:42:54 -0800483 sp<Layer> otherLayer = nullptr;
Pablo Gamito11dcc222020-09-12 15:49:39 +0000484 if (state.barrierSurfaceControl_legacy != nullptr) {
485 otherLayer = static_cast<Layer::Handle*>(
486 state.barrierSurfaceControl_legacy->getHandle().get())
487 ->owner.promote();
Robert Carr0d480722017-01-10 16:42:54 -0800488 }
Vishnu Nair6b7c5c92020-09-29 17:27:05 -0700489 addDeferTransactionLocked(transaction, layerId, otherLayer, state.barrierFrameNumber);
Irvelc274c632016-06-13 16:44:08 -0700490 }
Vishnu Nair456bbb22019-07-18 16:02:00 -0700491 if (state.what & layer_state_t::eReparent) {
Pablo Gamito11dcc222020-09-12 15:49:39 +0000492 auto parentHandle = (state.parentSurfaceControlForChild)
493 ? state.parentSurfaceControlForChild->getHandle()
494 : nullptr;
495 addReparentLocked(transaction, layerId, getLayerIdFromHandle(parentHandle));
Vishnu Nair456bbb22019-07-18 16:02:00 -0700496 }
497 if (state.what & layer_state_t::eReparentChildren) {
Pablo Gamito11dcc222020-09-12 15:49:39 +0000498 addReparentChildrenLocked(transaction, layerId,
499 getLayerIdFromHandle(state.reparentSurfaceControl->getHandle()));
Vishnu Nair456bbb22019-07-18 16:02:00 -0700500 }
501 if (state.what & layer_state_t::eDetachChildren) {
502 addDetachChildrenLocked(transaction, layerId, true);
503 }
504 if (state.what & layer_state_t::eRelativeLayerChanged) {
505 addRelativeParentLocked(transaction, layerId,
Pablo Gamito11dcc222020-09-12 15:49:39 +0000506 getLayerIdFromHandle(
507 state.relativeLayerSurfaceControl->getHandle()),
508 state.z);
Vishnu Nair456bbb22019-07-18 16:02:00 -0700509 }
Vishnu Nair95a1ed42019-12-06 12:25:11 -0800510 if (state.what & layer_state_t::eShadowRadiusChanged) {
511 addShadowRadiusLocked(transaction, layerId, state.shadowRadius);
512 }
Irvelc274c632016-06-13 16:44:08 -0700513}
514
Irvelffc9efc2016-07-27 15:16:37 -0700515void SurfaceInterceptor::addDisplayChangesLocked(Transaction* transaction,
Dominik Laskowski663bd282018-04-19 15:26:54 -0700516 const DisplayState& state, int32_t sequenceId)
Irvelc274c632016-06-13 16:44:08 -0700517{
Irvelffc9efc2016-07-27 15:16:37 -0700518 if (state.what & DisplayState::eSurfaceChanged) {
Dominik Laskowski663bd282018-04-19 15:26:54 -0700519 addDisplaySurfaceLocked(transaction, sequenceId, state.surface);
Irvelffc9efc2016-07-27 15:16:37 -0700520 }
521 if (state.what & DisplayState::eLayerStackChanged) {
Dominik Laskowski663bd282018-04-19 15:26:54 -0700522 addDisplayLayerStackLocked(transaction, sequenceId, state.layerStack);
Irvelffc9efc2016-07-27 15:16:37 -0700523 }
524 if (state.what & DisplayState::eDisplaySizeChanged) {
Dominik Laskowski663bd282018-04-19 15:26:54 -0700525 addDisplaySizeLocked(transaction, sequenceId, state.width, state.height);
Irvelffc9efc2016-07-27 15:16:37 -0700526 }
527 if (state.what & DisplayState::eDisplayProjectionChanged) {
Dominik Laskowski718f9602019-11-09 20:01:35 -0800528 addDisplayProjectionLocked(transaction, sequenceId, toRotationInt(state.orientation),
Marin Shalamanov6ad317c2020-07-29 23:34:07 +0200529 state.layerStackSpaceRect, state.orientedDisplaySpaceRect);
Irvelc274c632016-06-13 16:44:08 -0700530 }
531}
532
Pablo Gamito3e8f0e62020-06-22 15:55:39 +0000533void SurfaceInterceptor::addTransactionLocked(
534 Increment* increment, const Vector<ComposerState>& stateUpdates,
535 const DefaultKeyedVector<wp<IBinder>, DisplayDeviceState>& displays,
Pablo Gamito7eb7ee72020-08-05 10:57:05 +0000536 const Vector<DisplayState>& changedDisplays, uint32_t transactionFlags, int originPid,
537 int originUid, uint64_t transactionId) {
Irvelffc9efc2016-07-27 15:16:37 -0700538 Transaction* transaction(increment->mutable_transaction());
539 transaction->set_synchronous(transactionFlags & BnSurfaceComposer::eSynchronous);
540 transaction->set_animation(transactionFlags & BnSurfaceComposer::eAnimation);
Pablo Gamito7eb7ee72020-08-05 10:57:05 +0000541 setTransactionOriginLocked(transaction, originPid, originUid);
542 transaction->set_id(transactionId);
Irvelffc9efc2016-07-27 15:16:37 -0700543 for (const auto& compState: stateUpdates) {
544 addSurfaceChangesLocked(transaction, compState.state);
545 }
546 for (const auto& disp: changedDisplays) {
547 ssize_t dpyIdx = displays.indexOfKey(disp.token);
548 if (dpyIdx >= 0) {
549 const DisplayDeviceState& dispState(displays.valueAt(dpyIdx));
Dominik Laskowski663bd282018-04-19 15:26:54 -0700550 addDisplayChangesLocked(transaction, disp, dispState.sequenceId);
Irvelffc9efc2016-07-27 15:16:37 -0700551 }
552 }
Irvelc274c632016-06-13 16:44:08 -0700553}
554
Irvelffc9efc2016-07-27 15:16:37 -0700555void SurfaceInterceptor::addSurfaceCreationLocked(Increment* increment,
556 const sp<const Layer>& layer)
557{
558 SurfaceCreation* creation(increment->mutable_surface_creation());
559 creation->set_id(getLayerId(layer));
Dominik Laskowski87a07e42019-10-10 20:38:02 -0700560 creation->set_name(layer->getName());
Lloyd Pique0449b0f2018-12-20 16:23:45 -0800561 creation->set_w(layer->mCurrentState.active_legacy.w);
562 creation->set_h(layer->mCurrentState.active_legacy.h);
Irvelc274c632016-06-13 16:44:08 -0700563}
564
Irvelffc9efc2016-07-27 15:16:37 -0700565void SurfaceInterceptor::addSurfaceDeletionLocked(Increment* increment,
566 const sp<const Layer>& layer)
567{
568 SurfaceDeletion* deletion(increment->mutable_surface_deletion());
569 deletion->set_id(getLayerId(layer));
570}
571
Rob Carra79435b2020-03-06 14:46:07 -0800572void SurfaceInterceptor::addBufferUpdateLocked(Increment* increment, int32_t layerId,
Irvelc274c632016-06-13 16:44:08 -0700573 uint32_t width, uint32_t height, uint64_t frameNumber)
574{
575 BufferUpdate* update(increment->mutable_buffer_update());
Rob Carra79435b2020-03-06 14:46:07 -0800576 update->set_id(layerId);
Irvelc274c632016-06-13 16:44:08 -0700577 update->set_w(width);
578 update->set_h(height);
579 update->set_frame_number(frameNumber);
580}
581
Irvelffc9efc2016-07-27 15:16:37 -0700582void SurfaceInterceptor::addVSyncUpdateLocked(Increment* increment, nsecs_t timestamp) {
Irvelc274c632016-06-13 16:44:08 -0700583 VSyncEvent* event(increment->mutable_vsync_event());
584 event->set_when(timestamp);
585}
586
Dominik Laskowski663bd282018-04-19 15:26:54 -0700587void SurfaceInterceptor::addDisplaySurfaceLocked(Transaction* transaction, int32_t sequenceId,
Irvelffc9efc2016-07-27 15:16:37 -0700588 const sp<const IGraphicBufferProducer>& surface)
Irvelc274c632016-06-13 16:44:08 -0700589{
Irvelffc9efc2016-07-27 15:16:37 -0700590 if (surface == nullptr) {
Irvelc274c632016-06-13 16:44:08 -0700591 return;
592 }
Irvelffc9efc2016-07-27 15:16:37 -0700593 uint64_t bufferQueueId = 0;
594 status_t err(surface->getUniqueId(&bufferQueueId));
595 if (err == NO_ERROR) {
Dominik Laskowski663bd282018-04-19 15:26:54 -0700596 DisplayChange* dispChange(createDisplayChangeLocked(transaction, sequenceId));
Irvelffc9efc2016-07-27 15:16:37 -0700597 DispSurfaceChange* surfaceChange(dispChange->mutable_surface());
598 surfaceChange->set_buffer_queue_id(bufferQueueId);
599 surfaceChange->set_buffer_queue_name(surface->getConsumerName().string());
600 }
601 else {
602 ALOGE("invalid graphic buffer producer received while tracing a display change (%s)",
603 strerror(-err));
604 }
Irvelc274c632016-06-13 16:44:08 -0700605}
606
Irvelffc9efc2016-07-27 15:16:37 -0700607void SurfaceInterceptor::addDisplayLayerStackLocked(Transaction* transaction,
Dominik Laskowski663bd282018-04-19 15:26:54 -0700608 int32_t sequenceId, uint32_t layerStack)
Irvelffc9efc2016-07-27 15:16:37 -0700609{
Dominik Laskowski663bd282018-04-19 15:26:54 -0700610 DisplayChange* dispChange(createDisplayChangeLocked(transaction, sequenceId));
Irvelffc9efc2016-07-27 15:16:37 -0700611 LayerStackChange* layerStackChange(dispChange->mutable_layer_stack());
612 layerStackChange->set_layer_stack(layerStack);
613}
614
Dominik Laskowski663bd282018-04-19 15:26:54 -0700615void SurfaceInterceptor::addDisplaySizeLocked(Transaction* transaction, int32_t sequenceId,
Irvelffc9efc2016-07-27 15:16:37 -0700616 uint32_t w, uint32_t h)
617{
Dominik Laskowski663bd282018-04-19 15:26:54 -0700618 DisplayChange* dispChange(createDisplayChangeLocked(transaction, sequenceId));
Irvelffc9efc2016-07-27 15:16:37 -0700619 SizeChange* sizeChange(dispChange->mutable_size());
620 sizeChange->set_w(w);
621 sizeChange->set_h(h);
622}
623
624void SurfaceInterceptor::addDisplayProjectionLocked(Transaction* transaction,
Dominik Laskowski663bd282018-04-19 15:26:54 -0700625 int32_t sequenceId, int32_t orientation, const Rect& viewport, const Rect& frame)
Irvelffc9efc2016-07-27 15:16:37 -0700626{
Dominik Laskowski663bd282018-04-19 15:26:54 -0700627 DisplayChange* dispChange(createDisplayChangeLocked(transaction, sequenceId));
Irvelffc9efc2016-07-27 15:16:37 -0700628 ProjectionChange* projectionChange(dispChange->mutable_projection());
629 projectionChange->set_orientation(orientation);
630 Rectangle* viewportRect(projectionChange->mutable_viewport());
631 setProtoRectLocked(viewportRect, viewport);
632 Rectangle* frameRect(projectionChange->mutable_frame());
633 setProtoRectLocked(frameRect, frame);
634}
635
636void SurfaceInterceptor::addDisplayCreationLocked(Increment* increment,
637 const DisplayDeviceState& info)
638{
639 DisplayCreation* creation(increment->mutable_display_creation());
Dominik Laskowski663bd282018-04-19 15:26:54 -0700640 creation->set_id(info.sequenceId);
Irvelffc9efc2016-07-27 15:16:37 -0700641 creation->set_name(info.displayName);
Irvelffc9efc2016-07-27 15:16:37 -0700642 creation->set_is_secure(info.isSecure);
Dominik Laskowski55c85402020-01-21 16:25:47 -0800643 if (info.physical) {
644 creation->set_display_id(info.physical->id.value);
Dominik Laskowski075d3172018-05-24 15:50:06 -0700645 }
Irvelffc9efc2016-07-27 15:16:37 -0700646}
647
Dominik Laskowski663bd282018-04-19 15:26:54 -0700648void SurfaceInterceptor::addDisplayDeletionLocked(Increment* increment, int32_t sequenceId) {
Irvelffc9efc2016-07-27 15:16:37 -0700649 DisplayDeletion* deletion(increment->mutable_display_deletion());
Dominik Laskowski663bd282018-04-19 15:26:54 -0700650 deletion->set_id(sequenceId);
Irvelffc9efc2016-07-27 15:16:37 -0700651}
652
Dominik Laskowski663bd282018-04-19 15:26:54 -0700653void SurfaceInterceptor::addPowerModeUpdateLocked(Increment* increment, int32_t sequenceId,
Irvelffc9efc2016-07-27 15:16:37 -0700654 int32_t mode)
655{
656 PowerModeUpdate* powerModeUpdate(increment->mutable_power_mode_update());
Dominik Laskowski663bd282018-04-19 15:26:54 -0700657 powerModeUpdate->set_id(sequenceId);
Irvelffc9efc2016-07-27 15:16:37 -0700658 powerModeUpdate->set_mode(mode);
659}
660
Pablo Gamito3e8f0e62020-06-22 15:55:39 +0000661void SurfaceInterceptor::saveTransaction(
662 const Vector<ComposerState>& stateUpdates,
663 const DefaultKeyedVector<wp<IBinder>, DisplayDeviceState>& displays,
Pablo Gamito7eb7ee72020-08-05 10:57:05 +0000664 const Vector<DisplayState>& changedDisplays, uint32_t flags, int originPid, int originUid,
665 uint64_t transactionId) {
Irvelffc9efc2016-07-27 15:16:37 -0700666 if (!mEnabled || (stateUpdates.size() <= 0 && changedDisplays.size() <= 0)) {
667 return;
668 }
Irvelc274c632016-06-13 16:44:08 -0700669 ATRACE_CALL();
Irvelffc9efc2016-07-27 15:16:37 -0700670 std::lock_guard<std::mutex> protoGuard(mTraceMutex);
671 addTransactionLocked(createTraceIncrementLocked(), stateUpdates, displays, changedDisplays,
Pablo Gamito7eb7ee72020-08-05 10:57:05 +0000672 flags, originPid, originUid, transactionId);
Irvelffc9efc2016-07-27 15:16:37 -0700673}
674
675void SurfaceInterceptor::saveSurfaceCreation(const sp<const Layer>& layer) {
Irvelc274c632016-06-13 16:44:08 -0700676 if (!mEnabled || layer == nullptr) {
677 return;
678 }
Irvelc274c632016-06-13 16:44:08 -0700679 ATRACE_CALL();
Irvelffc9efc2016-07-27 15:16:37 -0700680 std::lock_guard<std::mutex> protoGuard(mTraceMutex);
681 addSurfaceCreationLocked(createTraceIncrementLocked(), layer);
682}
683
684void SurfaceInterceptor::saveSurfaceDeletion(const sp<const Layer>& layer) {
Irvelc274c632016-06-13 16:44:08 -0700685 if (!mEnabled || layer == nullptr) {
686 return;
687 }
Irvelffc9efc2016-07-27 15:16:37 -0700688 ATRACE_CALL();
Irvelc274c632016-06-13 16:44:08 -0700689 std::lock_guard<std::mutex> protoGuard(mTraceMutex);
Irvelffc9efc2016-07-27 15:16:37 -0700690 addSurfaceDeletionLocked(createTraceIncrementLocked(), layer);
Irvelc274c632016-06-13 16:44:08 -0700691}
692
Rob Carra79435b2020-03-06 14:46:07 -0800693/**
694 * Here we pass the layer by ID instead of by sp<> since this is called without
695 * holding the state-lock from a Binder thread. If we required the caller
696 * to pass 'this' by sp<> the temporary sp<> constructed could end up
697 * being the last reference and we might accidentally destroy the Layer
698 * from this binder thread.
699 */
700void SurfaceInterceptor::saveBufferUpdate(int32_t layerId, uint32_t width,
Irvelc274c632016-06-13 16:44:08 -0700701 uint32_t height, uint64_t frameNumber)
702{
Rob Carra79435b2020-03-06 14:46:07 -0800703 if (!mEnabled) {
Irvelc274c632016-06-13 16:44:08 -0700704 return;
705 }
Irvelffc9efc2016-07-27 15:16:37 -0700706 ATRACE_CALL();
Irvelc274c632016-06-13 16:44:08 -0700707 std::lock_guard<std::mutex> protoGuard(mTraceMutex);
Rob Carra79435b2020-03-06 14:46:07 -0800708 addBufferUpdateLocked(createTraceIncrementLocked(), layerId, width, height, frameNumber);
Irvelc274c632016-06-13 16:44:08 -0700709}
710
711void SurfaceInterceptor::saveVSyncEvent(nsecs_t timestamp) {
712 if (!mEnabled) {
713 return;
714 }
715 std::lock_guard<std::mutex> protoGuard(mTraceMutex);
Irvelffc9efc2016-07-27 15:16:37 -0700716 addVSyncUpdateLocked(createTraceIncrementLocked(), timestamp);
Irvelc274c632016-06-13 16:44:08 -0700717}
718
Irvelffc9efc2016-07-27 15:16:37 -0700719void SurfaceInterceptor::saveDisplayCreation(const DisplayDeviceState& info) {
720 if (!mEnabled) {
721 return;
722 }
723 ATRACE_CALL();
724 std::lock_guard<std::mutex> protoGuard(mTraceMutex);
725 addDisplayCreationLocked(createTraceIncrementLocked(), info);
726}
727
Dominik Laskowski663bd282018-04-19 15:26:54 -0700728void SurfaceInterceptor::saveDisplayDeletion(int32_t sequenceId) {
Irvelffc9efc2016-07-27 15:16:37 -0700729 if (!mEnabled) {
730 return;
731 }
732 ATRACE_CALL();
733 std::lock_guard<std::mutex> protoGuard(mTraceMutex);
Dominik Laskowski663bd282018-04-19 15:26:54 -0700734 addDisplayDeletionLocked(createTraceIncrementLocked(), sequenceId);
Irvelffc9efc2016-07-27 15:16:37 -0700735}
736
Dominik Laskowski663bd282018-04-19 15:26:54 -0700737void SurfaceInterceptor::savePowerModeUpdate(int32_t sequenceId, int32_t mode) {
Irvelffc9efc2016-07-27 15:16:37 -0700738 if (!mEnabled) {
739 return;
740 }
741 ATRACE_CALL();
742 std::lock_guard<std::mutex> protoGuard(mTraceMutex);
Dominik Laskowski663bd282018-04-19 15:26:54 -0700743 addPowerModeUpdateLocked(createTraceIncrementLocked(), sequenceId, mode);
Irvelffc9efc2016-07-27 15:16:37 -0700744}
745
Lloyd Pique4dccc412018-01-22 17:21:36 -0800746} // namespace impl
Irvelc274c632016-06-13 16:44:08 -0700747} // namespace android
Ady Abrahamb0dbdaa2020-01-06 16:19:42 -0800748
749// TODO(b/129481165): remove the #pragma below and fix conversion issues
750#pragma clang diagnostic pop // ignored "-Wconversion"