Adithya Srinivasan | f279e04 | 2020-08-17 14:56:27 -0700 | [diff] [blame] | 1 | /* |
| 2 | * Copyright 2020 The Android Open Source Project |
| 3 | * |
| 4 | * Licensed under the Apache License, Version 2.0 (the "License"); |
| 5 | * you may not use this file except in compliance with the License. |
| 6 | * You may obtain a copy of the License at |
| 7 | * |
| 8 | * http://www.apache.org/licenses/LICENSE-2.0 |
| 9 | * |
| 10 | * Unless required by applicable law or agreed to in writing, software |
| 11 | * distributed under the License is distributed on an "AS IS" BASIS, |
| 12 | * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. |
| 13 | * See the License for the specific language governing permissions and |
| 14 | * limitations under the License. |
| 15 | */ |
| 16 | |
Ady Abraham | 3db8a3c | 2023-11-20 17:53:47 -0800 | [diff] [blame] | 17 | #include <common/test/FlagUtils.h> |
Sally Qi | f572125 | 2023-11-17 11:14:53 -0800 | [diff] [blame] | 18 | #include "com_android_graphics_surfaceflinger_flags.h" |
Alec Mouri | 9a29e67 | 2020-09-14 12:39:14 -0700 | [diff] [blame] | 19 | #include "gmock/gmock-spec-builders.h" |
| 20 | #include "mock/MockTimeStats.h" |
Adithya Srinivasan | f279e04 | 2020-08-17 14:56:27 -0700 | [diff] [blame] | 21 | #undef LOG_TAG |
| 22 | #define LOG_TAG "LibSurfaceFlingerUnittests" |
| 23 | |
| 24 | #include <FrameTimeline/FrameTimeline.h> |
| 25 | #include <gtest/gtest.h> |
| 26 | #include <log/log.h> |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 27 | #include <perfetto/trace/trace.pb.h> |
Adithya Srinivasan | f279e04 | 2020-08-17 14:56:27 -0700 | [diff] [blame] | 28 | #include <cinttypes> |
| 29 | |
| 30 | using namespace std::chrono_literals; |
Alec Mouri | 363faf0 | 2021-01-29 16:34:55 -0800 | [diff] [blame] | 31 | using testing::_; |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 32 | using testing::AtLeast; |
Alec Mouri | 9a29e67 | 2020-09-14 12:39:14 -0700 | [diff] [blame] | 33 | using testing::Contains; |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 34 | using FrameTimelineEvent = perfetto::protos::FrameTimelineEvent; |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 35 | using ProtoExpectedDisplayFrameStart = |
| 36 | perfetto::protos::FrameTimelineEvent_ExpectedDisplayFrameStart; |
| 37 | using ProtoExpectedSurfaceFrameStart = |
| 38 | perfetto::protos::FrameTimelineEvent_ExpectedSurfaceFrameStart; |
| 39 | using ProtoActualDisplayFrameStart = perfetto::protos::FrameTimelineEvent_ActualDisplayFrameStart; |
| 40 | using ProtoActualSurfaceFrameStart = perfetto::protos::FrameTimelineEvent_ActualSurfaceFrameStart; |
| 41 | using ProtoFrameEnd = perfetto::protos::FrameTimelineEvent_FrameEnd; |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 42 | using ProtoPresentType = perfetto::protos::FrameTimelineEvent_PresentType; |
| 43 | using ProtoJankType = perfetto::protos::FrameTimelineEvent_JankType; |
Ying Wei | 96eb535 | 2023-11-21 17:37:21 +0000 | [diff] [blame] | 44 | using ProtoJankSeverityType = perfetto::protos::FrameTimelineEvent_JankSeverityType; |
Adithya Srinivasan | 78e58af | 2021-02-25 00:08:08 +0000 | [diff] [blame] | 45 | using ProtoPredictionType = perfetto::protos::FrameTimelineEvent_PredictionType; |
Alec Mouri | 9a29e67 | 2020-09-14 12:39:14 -0700 | [diff] [blame] | 46 | |
Adithya Srinivasan | f279e04 | 2020-08-17 14:56:27 -0700 | [diff] [blame] | 47 | namespace android::frametimeline { |
| 48 | |
Ady Abraham | 57a8ab4 | 2023-01-26 15:28:19 -0800 | [diff] [blame] | 49 | static const std::string sLayerNameOne = "layer1"; |
| 50 | static const std::string sLayerNameTwo = "layer2"; |
| 51 | |
| 52 | constexpr const uid_t sUidOne = 0; |
| 53 | constexpr pid_t sPidOne = 10; |
| 54 | constexpr pid_t sPidTwo = 20; |
| 55 | constexpr int32_t sInputEventId = 5; |
| 56 | constexpr int32_t sLayerIdOne = 1; |
| 57 | constexpr int32_t sLayerIdTwo = 2; |
| 58 | constexpr GameMode sGameMode = GameMode::Unsupported; |
Pascal Muetschard | ac7bcd9 | 2023-10-03 15:05:36 +0200 | [diff] [blame] | 59 | constexpr Fps RR_11 = Fps::fromPeriodNsecs(11); |
| 60 | constexpr Fps RR_30 = Fps::fromPeriodNsecs(30); |
Ady Abraham | 57a8ab4 | 2023-01-26 15:28:19 -0800 | [diff] [blame] | 61 | |
Adithya Srinivasan | f279e04 | 2020-08-17 14:56:27 -0700 | [diff] [blame] | 62 | class FrameTimelineTest : public testing::Test { |
| 63 | public: |
| 64 | FrameTimelineTest() { |
| 65 | const ::testing::TestInfo* const test_info = |
| 66 | ::testing::UnitTest::GetInstance()->current_test_info(); |
| 67 | ALOGD("**** Setting up for %s.%s\n", test_info->test_case_name(), test_info->name()); |
| 68 | } |
| 69 | |
| 70 | ~FrameTimelineTest() { |
| 71 | const ::testing::TestInfo* const test_info = |
| 72 | ::testing::UnitTest::GetInstance()->current_test_info(); |
| 73 | ALOGD("**** Tearing down after %s.%s\n", test_info->test_case_name(), test_info->name()); |
| 74 | } |
| 75 | |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 76 | static void SetUpTestSuite() { |
| 77 | // Need to initialize tracing in process for testing, and only once per test suite. |
| 78 | perfetto::TracingInitArgs args; |
| 79 | args.backends = perfetto::kInProcessBackend; |
| 80 | perfetto::Tracing::Initialize(args); |
| 81 | } |
| 82 | |
Adithya Srinivasan | f279e04 | 2020-08-17 14:56:27 -0700 | [diff] [blame] | 83 | void SetUp() override { |
Ady Abraham | 57f8e18 | 2022-03-08 15:54:33 -0800 | [diff] [blame] | 84 | constexpr bool kUseBootTimeClock = true; |
Alec Mouri | 9a29e67 | 2020-09-14 12:39:14 -0700 | [diff] [blame] | 85 | mTimeStats = std::make_shared<mock::TimeStats>(); |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 86 | mFrameTimeline = std::make_unique<impl::FrameTimeline>(mTimeStats, kSurfaceFlingerPid, |
Ady Abraham | 57f8e18 | 2022-03-08 15:54:33 -0800 | [diff] [blame] | 87 | kTestThresholds, !kUseBootTimeClock); |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 88 | mFrameTimeline->registerDataSource(); |
Adithya Srinivasan | f279e04 | 2020-08-17 14:56:27 -0700 | [diff] [blame] | 89 | mTokenManager = &mFrameTimeline->mTokenManager; |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 90 | mTraceCookieCounter = &mFrameTimeline->mTraceCookieCounter; |
Adithya Srinivasan | 2d73632 | 2020-10-01 16:53:48 -0700 | [diff] [blame] | 91 | maxDisplayFrames = &mFrameTimeline->mMaxDisplayFrames; |
Adithya Srinivasan | bed4c4f | 2021-05-03 20:24:46 +0000 | [diff] [blame] | 92 | maxTokens = mTokenManager->kMaxTokens; |
Adithya Srinivasan | f279e04 | 2020-08-17 14:56:27 -0700 | [diff] [blame] | 93 | } |
| 94 | |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 95 | // Each tracing session can be used for a single block of Start -> Stop. |
| 96 | static std::unique_ptr<perfetto::TracingSession> getTracingSessionForTest() { |
| 97 | perfetto::TraceConfig cfg; |
| 98 | cfg.set_duration_ms(500); |
| 99 | cfg.add_buffers()->set_size_kb(1024); |
| 100 | auto* ds_cfg = cfg.add_data_sources()->mutable_config(); |
| 101 | ds_cfg->set_name(impl::FrameTimeline::kFrameTimelineDataSource); |
| 102 | |
| 103 | auto tracingSession = perfetto::Tracing::NewTrace(perfetto::kInProcessBackend); |
| 104 | tracingSession->Setup(cfg); |
| 105 | return tracingSession; |
| 106 | } |
| 107 | |
| 108 | std::vector<perfetto::protos::TracePacket> readFrameTimelinePacketsBlocking( |
| 109 | perfetto::TracingSession* tracingSession) { |
| 110 | std::vector<char> raw_trace = tracingSession->ReadTraceBlocking(); |
| 111 | perfetto::protos::Trace trace; |
| 112 | EXPECT_TRUE(trace.ParseFromArray(raw_trace.data(), int(raw_trace.size()))); |
| 113 | |
| 114 | std::vector<perfetto::protos::TracePacket> packets; |
| 115 | for (const auto& packet : trace.packet()) { |
| 116 | if (!packet.has_frame_timeline_event()) { |
| 117 | continue; |
| 118 | } |
| 119 | packets.emplace_back(packet); |
| 120 | } |
| 121 | return packets; |
| 122 | } |
| 123 | |
Ady Abraham | 57a8ab4 | 2023-01-26 15:28:19 -0800 | [diff] [blame] | 124 | void addEmptySurfaceFrame() { |
| 125 | auto surfaceFrame = |
| 126 | mFrameTimeline->createSurfaceFrameForToken({}, sPidOne, sUidOne, sLayerIdOne, |
| 127 | sLayerNameOne, sLayerNameOne, |
| 128 | /*isBuffer*/ false, sGameMode); |
| 129 | mFrameTimeline->addSurfaceFrame(std::move(surfaceFrame)); |
| 130 | } |
| 131 | |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 132 | void addEmptyDisplayFrame() { |
| 133 | auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 134 | // Trigger a flushPresentFence by calling setSfPresent for the next frame |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 135 | mFrameTimeline->setSfPresent(2500, presentFence1); |
| 136 | } |
| 137 | |
Adithya Srinivasan | bed4c4f | 2021-05-03 20:24:46 +0000 | [diff] [blame] | 138 | void flushTokens() { |
| 139 | for (size_t i = 0; i < maxTokens; i++) { |
| 140 | mTokenManager->generateTokenForPredictions({}); |
| 141 | } |
| 142 | EXPECT_EQ(getPredictions().size(), maxTokens); |
Adithya Srinivasan | f279e04 | 2020-08-17 14:56:27 -0700 | [diff] [blame] | 143 | } |
| 144 | |
| 145 | SurfaceFrame& getSurfaceFrame(size_t displayFrameIdx, size_t surfaceFrameIdx) { |
| 146 | std::lock_guard<std::mutex> lock(mFrameTimeline->mMutex); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 147 | return *(mFrameTimeline->mDisplayFrames[displayFrameIdx] |
| 148 | ->getSurfaceFrames()[surfaceFrameIdx]); |
Adithya Srinivasan | f279e04 | 2020-08-17 14:56:27 -0700 | [diff] [blame] | 149 | } |
| 150 | |
| 151 | std::shared_ptr<impl::FrameTimeline::DisplayFrame> getDisplayFrame(size_t idx) { |
| 152 | std::lock_guard<std::mutex> lock(mFrameTimeline->mMutex); |
| 153 | return mFrameTimeline->mDisplayFrames[idx]; |
| 154 | } |
| 155 | |
| 156 | static bool compareTimelineItems(const TimelineItem& a, const TimelineItem& b) { |
| 157 | return a.startTime == b.startTime && a.endTime == b.endTime && |
| 158 | a.presentTime == b.presentTime; |
| 159 | } |
| 160 | |
Adithya Srinivasan | bed4c4f | 2021-05-03 20:24:46 +0000 | [diff] [blame] | 161 | const std::map<int64_t, TimelineItem>& getPredictions() const { |
Adithya Srinivasan | f279e04 | 2020-08-17 14:56:27 -0700 | [diff] [blame] | 162 | return mTokenManager->mPredictions; |
| 163 | } |
| 164 | |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 165 | uint32_t getNumberOfDisplayFrames() const { |
Adithya Srinivasan | 2d73632 | 2020-10-01 16:53:48 -0700 | [diff] [blame] | 166 | std::lock_guard<std::mutex> lock(mFrameTimeline->mMutex); |
| 167 | return static_cast<uint32_t>(mFrameTimeline->mDisplayFrames.size()); |
| 168 | } |
| 169 | |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 170 | int64_t snoopCurrentTraceCookie() const { return mTraceCookieCounter->mTraceCookie; } |
| 171 | |
| 172 | void flushTrace() { |
| 173 | using FrameTimelineDataSource = impl::FrameTimeline::FrameTimelineDataSource; |
| 174 | FrameTimelineDataSource::Trace( |
| 175 | [&](FrameTimelineDataSource::TraceContext ctx) { ctx.Flush(); }); |
| 176 | } |
| 177 | |
Alec Mouri | 9a29e67 | 2020-09-14 12:39:14 -0700 | [diff] [blame] | 178 | std::shared_ptr<mock::TimeStats> mTimeStats; |
Adithya Srinivasan | f279e04 | 2020-08-17 14:56:27 -0700 | [diff] [blame] | 179 | std::unique_ptr<impl::FrameTimeline> mFrameTimeline; |
| 180 | impl::TokenManager* mTokenManager; |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 181 | TraceCookieCounter* mTraceCookieCounter; |
Adithya Srinivasan | f279e04 | 2020-08-17 14:56:27 -0700 | [diff] [blame] | 182 | FenceToFenceTimeMap fenceFactory; |
Adithya Srinivasan | 2d73632 | 2020-10-01 16:53:48 -0700 | [diff] [blame] | 183 | uint32_t* maxDisplayFrames; |
Adithya Srinivasan | bed4c4f | 2021-05-03 20:24:46 +0000 | [diff] [blame] | 184 | size_t maxTokens; |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 185 | static constexpr pid_t kSurfaceFlingerPid = 666; |
Adithya Srinivasan | ead1716 | 2021-02-18 02:17:37 +0000 | [diff] [blame] | 186 | static constexpr nsecs_t kPresentThreshold = std::chrono::nanoseconds(2ns).count(); |
Adithya Srinivasan | 54996e2 | 2021-06-25 22:26:45 +0000 | [diff] [blame] | 187 | static constexpr nsecs_t kDeadlineThreshold = std::chrono::nanoseconds(0ns).count(); |
Adithya Srinivasan | ead1716 | 2021-02-18 02:17:37 +0000 | [diff] [blame] | 188 | static constexpr nsecs_t kStartThreshold = std::chrono::nanoseconds(2ns).count(); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 189 | static constexpr JankClassificationThresholds kTestThresholds{kPresentThreshold, |
| 190 | kDeadlineThreshold, |
| 191 | kStartThreshold}; |
Adithya Srinivasan | f279e04 | 2020-08-17 14:56:27 -0700 | [diff] [blame] | 192 | }; |
| 193 | |
| 194 | TEST_F(FrameTimelineTest, tokenManagerRemovesStalePredictions) { |
| 195 | int64_t token1 = mTokenManager->generateTokenForPredictions({0, 0, 0}); |
Siarhei Vishniakou | fc434ac | 2021-01-13 10:28:00 -1000 | [diff] [blame] | 196 | EXPECT_EQ(getPredictions().size(), 1u); |
Adithya Srinivasan | bed4c4f | 2021-05-03 20:24:46 +0000 | [diff] [blame] | 197 | flushTokens(); |
Adithya Srinivasan | f279e04 | 2020-08-17 14:56:27 -0700 | [diff] [blame] | 198 | int64_t token2 = mTokenManager->generateTokenForPredictions({10, 20, 30}); |
| 199 | std::optional<TimelineItem> predictions = mTokenManager->getPredictionsForToken(token1); |
| 200 | |
| 201 | // token1 should have expired |
Adithya Srinivasan | f279e04 | 2020-08-17 14:56:27 -0700 | [diff] [blame] | 202 | EXPECT_EQ(predictions.has_value(), false); |
| 203 | |
| 204 | predictions = mTokenManager->getPredictionsForToken(token2); |
| 205 | EXPECT_EQ(compareTimelineItems(*predictions, TimelineItem(10, 20, 30)), true); |
| 206 | } |
| 207 | |
Adithya Srinivasan | 9febda8 | 2020-10-19 10:49:41 -0700 | [diff] [blame] | 208 | TEST_F(FrameTimelineTest, createSurfaceFrameForToken_getOwnerPidReturnsCorrectPid) { |
Alec Mouri | adebf5c | 2021-01-05 12:57:36 -0800 | [diff] [blame] | 209 | auto surfaceFrame1 = |
| 210 | mFrameTimeline->createSurfaceFrameForToken({}, sPidOne, sUidOne, sLayerIdOne, |
Adithya Srinivasan | 785addd | 2021-03-09 00:38:00 +0000 | [diff] [blame] | 211 | sLayerNameOne, sLayerNameOne, |
Adithya Srinivasan | 58069dc | 2021-06-04 20:37:02 +0000 | [diff] [blame] | 212 | /*isBuffer*/ true, sGameMode); |
Alec Mouri | adebf5c | 2021-01-05 12:57:36 -0800 | [diff] [blame] | 213 | auto surfaceFrame2 = |
| 214 | mFrameTimeline->createSurfaceFrameForToken({}, sPidTwo, sUidOne, sLayerIdOne, |
Adithya Srinivasan | 785addd | 2021-03-09 00:38:00 +0000 | [diff] [blame] | 215 | sLayerNameOne, sLayerNameOne, |
Adithya Srinivasan | 58069dc | 2021-06-04 20:37:02 +0000 | [diff] [blame] | 216 | /*isBuffer*/ true, sGameMode); |
Adithya Srinivasan | 9febda8 | 2020-10-19 10:49:41 -0700 | [diff] [blame] | 217 | EXPECT_EQ(surfaceFrame1->getOwnerPid(), sPidOne); |
| 218 | EXPECT_EQ(surfaceFrame2->getOwnerPid(), sPidTwo); |
| 219 | } |
| 220 | |
Adithya Srinivasan | f279e04 | 2020-08-17 14:56:27 -0700 | [diff] [blame] | 221 | TEST_F(FrameTimelineTest, createSurfaceFrameForToken_noToken) { |
Alec Mouri | adebf5c | 2021-01-05 12:57:36 -0800 | [diff] [blame] | 222 | auto surfaceFrame = |
| 223 | mFrameTimeline->createSurfaceFrameForToken({}, sPidOne, sUidOne, sLayerIdOne, |
Adithya Srinivasan | 785addd | 2021-03-09 00:38:00 +0000 | [diff] [blame] | 224 | sLayerNameOne, sLayerNameOne, |
Adithya Srinivasan | 58069dc | 2021-06-04 20:37:02 +0000 | [diff] [blame] | 225 | /*isBuffer*/ true, sGameMode); |
Adithya Srinivasan | f279e04 | 2020-08-17 14:56:27 -0700 | [diff] [blame] | 226 | EXPECT_EQ(surfaceFrame->getPredictionState(), PredictionState::None); |
| 227 | } |
| 228 | |
| 229 | TEST_F(FrameTimelineTest, createSurfaceFrameForToken_expiredToken) { |
| 230 | int64_t token1 = mTokenManager->generateTokenForPredictions({0, 0, 0}); |
Adithya Srinivasan | bed4c4f | 2021-05-03 20:24:46 +0000 | [diff] [blame] | 231 | flushTokens(); |
Huihong Luo | 3bdef86 | 2022-03-03 11:57:19 -0800 | [diff] [blame] | 232 | FrameTimelineInfo ftInfo; |
| 233 | ftInfo.vsyncId = token1; |
| 234 | ftInfo.inputEventId = sInputEventId; |
Siarhei Vishniakou | fc434ac | 2021-01-13 10:28:00 -1000 | [diff] [blame] | 235 | auto surfaceFrame = |
Huihong Luo | 3bdef86 | 2022-03-03 11:57:19 -0800 | [diff] [blame] | 236 | mFrameTimeline->createSurfaceFrameForToken(ftInfo, sPidOne, sUidOne, sLayerIdOne, |
| 237 | sLayerNameOne, sLayerNameOne, |
Adithya Srinivasan | 58069dc | 2021-06-04 20:37:02 +0000 | [diff] [blame] | 238 | /*isBuffer*/ true, sGameMode); |
Adithya Srinivasan | f279e04 | 2020-08-17 14:56:27 -0700 | [diff] [blame] | 239 | |
| 240 | EXPECT_EQ(surfaceFrame->getPredictionState(), PredictionState::Expired); |
| 241 | } |
| 242 | |
| 243 | TEST_F(FrameTimelineTest, createSurfaceFrameForToken_validToken) { |
| 244 | int64_t token1 = mTokenManager->generateTokenForPredictions({10, 20, 30}); |
Huihong Luo | 3bdef86 | 2022-03-03 11:57:19 -0800 | [diff] [blame] | 245 | FrameTimelineInfo ftInfo; |
| 246 | ftInfo.vsyncId = token1; |
| 247 | ftInfo.inputEventId = sInputEventId; |
Siarhei Vishniakou | fc434ac | 2021-01-13 10:28:00 -1000 | [diff] [blame] | 248 | auto surfaceFrame = |
Huihong Luo | 3bdef86 | 2022-03-03 11:57:19 -0800 | [diff] [blame] | 249 | mFrameTimeline->createSurfaceFrameForToken(ftInfo, sPidOne, sUidOne, sLayerIdOne, |
| 250 | sLayerNameOne, sLayerNameOne, |
Adithya Srinivasan | 58069dc | 2021-06-04 20:37:02 +0000 | [diff] [blame] | 251 | /*isBuffer*/ true, sGameMode); |
Adithya Srinivasan | f279e04 | 2020-08-17 14:56:27 -0700 | [diff] [blame] | 252 | |
| 253 | EXPECT_EQ(surfaceFrame->getPredictionState(), PredictionState::Valid); |
| 254 | EXPECT_EQ(compareTimelineItems(surfaceFrame->getPredictions(), TimelineItem(10, 20, 30)), true); |
| 255 | } |
| 256 | |
Siarhei Vishniakou | fc434ac | 2021-01-13 10:28:00 -1000 | [diff] [blame] | 257 | TEST_F(FrameTimelineTest, createSurfaceFrameForToken_validInputEventId) { |
| 258 | int64_t token1 = mTokenManager->generateTokenForPredictions({10, 20, 30}); |
| 259 | constexpr int32_t inputEventId = 1; |
Huihong Luo | 3bdef86 | 2022-03-03 11:57:19 -0800 | [diff] [blame] | 260 | FrameTimelineInfo ftInfo; |
| 261 | ftInfo.vsyncId = token1; |
| 262 | ftInfo.inputEventId = inputEventId; |
Siarhei Vishniakou | fc434ac | 2021-01-13 10:28:00 -1000 | [diff] [blame] | 263 | auto surfaceFrame = |
Huihong Luo | 3bdef86 | 2022-03-03 11:57:19 -0800 | [diff] [blame] | 264 | mFrameTimeline->createSurfaceFrameForToken(ftInfo, sPidOne, sUidOne, sLayerIdOne, |
| 265 | sLayerNameOne, sLayerNameOne, |
Adithya Srinivasan | 58069dc | 2021-06-04 20:37:02 +0000 | [diff] [blame] | 266 | /*isBuffer*/ true, sGameMode); |
Siarhei Vishniakou | fc434ac | 2021-01-13 10:28:00 -1000 | [diff] [blame] | 267 | |
| 268 | EXPECT_EQ(inputEventId, surfaceFrame->getInputEventId()); |
| 269 | } |
| 270 | |
Adithya Srinivasan | f279e04 | 2020-08-17 14:56:27 -0700 | [diff] [blame] | 271 | TEST_F(FrameTimelineTest, presentFenceSignaled_droppedFramesNotUpdated) { |
| 272 | auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
Adithya Srinivasan | f279e04 | 2020-08-17 14:56:27 -0700 | [diff] [blame] | 273 | int64_t token1 = mTokenManager->generateTokenForPredictions({10, 20, 30}); |
Huihong Luo | 3bdef86 | 2022-03-03 11:57:19 -0800 | [diff] [blame] | 274 | FrameTimelineInfo ftInfo; |
| 275 | ftInfo.vsyncId = token1; |
| 276 | ftInfo.inputEventId = sInputEventId; |
Siarhei Vishniakou | fc434ac | 2021-01-13 10:28:00 -1000 | [diff] [blame] | 277 | auto surfaceFrame1 = |
Huihong Luo | 3bdef86 | 2022-03-03 11:57:19 -0800 | [diff] [blame] | 278 | mFrameTimeline->createSurfaceFrameForToken(ftInfo, sPidOne, sUidOne, sLayerIdOne, |
| 279 | sLayerNameOne, sLayerNameOne, |
Adithya Srinivasan | 58069dc | 2021-06-04 20:37:02 +0000 | [diff] [blame] | 280 | /*isBuffer*/ true, sGameMode); |
Adithya Srinivasan | f279e04 | 2020-08-17 14:56:27 -0700 | [diff] [blame] | 281 | |
| 282 | // Set up the display frame |
Pascal Muetschard | ac7bcd9 | 2023-10-03 15:05:36 +0200 | [diff] [blame] | 283 | mFrameTimeline->setSfWakeUp(token1, 20, RR_11, RR_11); |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 284 | surfaceFrame1->setDropTime(12); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 285 | surfaceFrame1->setPresentState(SurfaceFrame::PresentState::Dropped); |
| 286 | mFrameTimeline->addSurfaceFrame(surfaceFrame1); |
Adithya Srinivasan | f279e04 | 2020-08-17 14:56:27 -0700 | [diff] [blame] | 287 | mFrameTimeline->setSfPresent(25, presentFence1); |
| 288 | presentFence1->signalForTest(30); |
| 289 | |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 290 | addEmptyDisplayFrame(); |
Adithya Srinivasan | f279e04 | 2020-08-17 14:56:27 -0700 | [diff] [blame] | 291 | |
| 292 | auto& droppedSurfaceFrame = getSurfaceFrame(0, 0); |
| 293 | EXPECT_EQ(droppedSurfaceFrame.getPresentState(), SurfaceFrame::PresentState::Dropped); |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 294 | EXPECT_EQ(0u, droppedSurfaceFrame.getActuals().endTime); |
| 295 | EXPECT_EQ(12u, droppedSurfaceFrame.getDropTime()); |
Adithya Srinivasan | f279e04 | 2020-08-17 14:56:27 -0700 | [diff] [blame] | 296 | EXPECT_EQ(droppedSurfaceFrame.getActuals().presentTime, 0); |
| 297 | } |
| 298 | |
| 299 | TEST_F(FrameTimelineTest, presentFenceSignaled_presentedFramesUpdated) { |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 300 | // Layer specific increment |
Alec Mouri | 363faf0 | 2021-01-29 16:34:55 -0800 | [diff] [blame] | 301 | EXPECT_CALL(*mTimeStats, incrementJankyFrames(_)).Times(2); |
Adithya Srinivasan | f279e04 | 2020-08-17 14:56:27 -0700 | [diff] [blame] | 302 | auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
| 303 | int64_t surfaceFrameToken1 = mTokenManager->generateTokenForPredictions({10, 20, 30}); |
Adithya Srinivasan | f279e04 | 2020-08-17 14:56:27 -0700 | [diff] [blame] | 304 | int64_t sfToken1 = mTokenManager->generateTokenForPredictions({22, 26, 30}); |
Huihong Luo | 3bdef86 | 2022-03-03 11:57:19 -0800 | [diff] [blame] | 305 | FrameTimelineInfo ftInfo; |
| 306 | ftInfo.vsyncId = surfaceFrameToken1; |
| 307 | ftInfo.inputEventId = sInputEventId; |
Alec Mouri | 9a29e67 | 2020-09-14 12:39:14 -0700 | [diff] [blame] | 308 | auto surfaceFrame1 = |
Huihong Luo | 3bdef86 | 2022-03-03 11:57:19 -0800 | [diff] [blame] | 309 | mFrameTimeline->createSurfaceFrameForToken(ftInfo, sPidOne, sUidOne, sLayerIdOne, |
| 310 | sLayerNameOne, sLayerNameOne, |
| 311 | /*isBuffer*/ true, sGameMode); |
Alec Mouri | 9a29e67 | 2020-09-14 12:39:14 -0700 | [diff] [blame] | 312 | auto surfaceFrame2 = |
Huihong Luo | 3bdef86 | 2022-03-03 11:57:19 -0800 | [diff] [blame] | 313 | mFrameTimeline->createSurfaceFrameForToken(ftInfo, sPidOne, sUidOne, sLayerIdTwo, |
| 314 | sLayerNameTwo, sLayerNameTwo, |
| 315 | /*isBuffer*/ true, sGameMode); |
Pascal Muetschard | ac7bcd9 | 2023-10-03 15:05:36 +0200 | [diff] [blame] | 316 | mFrameTimeline->setSfWakeUp(sfToken1, 22, RR_11, RR_11); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 317 | surfaceFrame1->setPresentState(SurfaceFrame::PresentState::Presented); |
| 318 | mFrameTimeline->addSurfaceFrame(surfaceFrame1); |
| 319 | surfaceFrame2->setPresentState(SurfaceFrame::PresentState::Presented); |
| 320 | mFrameTimeline->addSurfaceFrame(surfaceFrame2); |
Adithya Srinivasan | f279e04 | 2020-08-17 14:56:27 -0700 | [diff] [blame] | 321 | mFrameTimeline->setSfPresent(26, presentFence1); |
| 322 | auto displayFrame = getDisplayFrame(0); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 323 | auto& presentedSurfaceFrame1 = getSurfaceFrame(0, 0); |
| 324 | auto& presentedSurfaceFrame2 = getSurfaceFrame(0, 1); |
Adithya Srinivasan | f279e04 | 2020-08-17 14:56:27 -0700 | [diff] [blame] | 325 | presentFence1->signalForTest(42); |
| 326 | |
| 327 | // Fences haven't been flushed yet, so it should be 0 |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 328 | EXPECT_EQ(displayFrame->getActuals().presentTime, 0); |
Adithya Srinivasan | f279e04 | 2020-08-17 14:56:27 -0700 | [diff] [blame] | 329 | EXPECT_EQ(presentedSurfaceFrame1.getActuals().presentTime, 0); |
| 330 | EXPECT_EQ(presentedSurfaceFrame2.getActuals().presentTime, 0); |
| 331 | |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 332 | addEmptyDisplayFrame(); |
Adithya Srinivasan | f279e04 | 2020-08-17 14:56:27 -0700 | [diff] [blame] | 333 | |
| 334 | // Fences have flushed, so the present timestamps should be updated |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 335 | EXPECT_EQ(displayFrame->getActuals().presentTime, 42); |
Adithya Srinivasan | f279e04 | 2020-08-17 14:56:27 -0700 | [diff] [blame] | 336 | EXPECT_EQ(presentedSurfaceFrame1.getActuals().presentTime, 42); |
| 337 | EXPECT_EQ(presentedSurfaceFrame2.getActuals().presentTime, 42); |
Jorim Jaggi | 9c03b50 | 2020-11-24 23:51:31 +0100 | [diff] [blame] | 338 | EXPECT_NE(surfaceFrame1->getJankType(), std::nullopt); |
Ying Wei | 96eb535 | 2023-11-21 17:37:21 +0000 | [diff] [blame] | 339 | EXPECT_NE(surfaceFrame1->getJankSeverityType(), std::nullopt); |
Jorim Jaggi | 9c03b50 | 2020-11-24 23:51:31 +0100 | [diff] [blame] | 340 | EXPECT_NE(surfaceFrame2->getJankType(), std::nullopt); |
Ying Wei | 96eb535 | 2023-11-21 17:37:21 +0000 | [diff] [blame] | 341 | EXPECT_NE(surfaceFrame2->getJankSeverityType(), std::nullopt); |
Adithya Srinivasan | f279e04 | 2020-08-17 14:56:27 -0700 | [diff] [blame] | 342 | } |
| 343 | |
Ady Abraham | 14beed7 | 2024-05-15 17:16:45 -0700 | [diff] [blame] | 344 | TEST_F(FrameTimelineTest, displayFrameSkippedComposition) { |
| 345 | // Layer specific increment |
| 346 | EXPECT_CALL(*mTimeStats, incrementJankyFrames(_)).Times(1); |
| 347 | auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
| 348 | int64_t surfaceFrameToken1 = mTokenManager->generateTokenForPredictions({10, 20, 30}); |
| 349 | int64_t sfToken1 = mTokenManager->generateTokenForPredictions({22, 26, 30}); |
| 350 | FrameTimelineInfo ftInfo; |
| 351 | ftInfo.vsyncId = surfaceFrameToken1; |
| 352 | ftInfo.inputEventId = sInputEventId; |
| 353 | auto surfaceFrame1 = |
| 354 | mFrameTimeline->createSurfaceFrameForToken(ftInfo, sPidOne, sUidOne, sLayerIdOne, |
| 355 | sLayerNameOne, sLayerNameOne, |
| 356 | /*isBuffer*/ true, sGameMode); |
| 357 | auto surfaceFrame2 = |
| 358 | mFrameTimeline->createSurfaceFrameForToken(ftInfo, sPidOne, sUidOne, sLayerIdTwo, |
| 359 | sLayerNameTwo, sLayerNameTwo, |
| 360 | /*isBuffer*/ true, sGameMode); |
| 361 | |
| 362 | mFrameTimeline->setSfWakeUp(sfToken1, 22, RR_11, RR_11); |
| 363 | surfaceFrame1->setPresentState(SurfaceFrame::PresentState::Presented); |
| 364 | mFrameTimeline->addSurfaceFrame(surfaceFrame1); |
| 365 | mFrameTimeline->onCommitNotComposited(); |
| 366 | |
| 367 | EXPECT_EQ(surfaceFrame1->getActuals().presentTime, 30); |
| 368 | ASSERT_NE(surfaceFrame1->getJankType(), std::nullopt); |
| 369 | EXPECT_EQ(*surfaceFrame1->getJankType(), JankType::None); |
| 370 | ASSERT_NE(surfaceFrame1->getJankSeverityType(), std::nullopt); |
| 371 | EXPECT_EQ(*surfaceFrame1->getJankSeverityType(), JankSeverityType::None); |
| 372 | |
| 373 | mFrameTimeline->setSfWakeUp(sfToken1, 22, RR_11, RR_11); |
| 374 | surfaceFrame2->setPresentState(SurfaceFrame::PresentState::Presented); |
| 375 | mFrameTimeline->addSurfaceFrame(surfaceFrame2); |
| 376 | mFrameTimeline->setSfPresent(26, presentFence1); |
| 377 | |
| 378 | auto displayFrame = getDisplayFrame(0); |
| 379 | auto& presentedSurfaceFrame2 = getSurfaceFrame(0, 0); |
| 380 | presentFence1->signalForTest(42); |
| 381 | |
| 382 | // Fences haven't been flushed yet, so it should be 0 |
| 383 | EXPECT_EQ(displayFrame->getActuals().presentTime, 0); |
| 384 | EXPECT_EQ(presentedSurfaceFrame2.getActuals().presentTime, 0); |
| 385 | |
| 386 | addEmptyDisplayFrame(); |
| 387 | |
| 388 | // Fences have flushed, so the present timestamps should be updated |
| 389 | EXPECT_EQ(displayFrame->getActuals().presentTime, 42); |
| 390 | EXPECT_EQ(presentedSurfaceFrame2.getActuals().presentTime, 42); |
| 391 | EXPECT_NE(surfaceFrame2->getJankType(), std::nullopt); |
| 392 | EXPECT_NE(surfaceFrame2->getJankSeverityType(), std::nullopt); |
| 393 | } |
| 394 | |
Adithya Srinivasan | f279e04 | 2020-08-17 14:56:27 -0700 | [diff] [blame] | 395 | TEST_F(FrameTimelineTest, displayFramesSlidingWindowMovesAfterLimit) { |
| 396 | // Insert kMaxDisplayFrames' count of DisplayFrames to fill the deque |
| 397 | int frameTimeFactor = 0; |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 398 | // Layer specific increment |
Alec Mouri | 363faf0 | 2021-01-29 16:34:55 -0800 | [diff] [blame] | 399 | EXPECT_CALL(*mTimeStats, incrementJankyFrames(_)) |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 400 | .Times(static_cast<int32_t>(*maxDisplayFrames)); |
Adithya Srinivasan | 2d73632 | 2020-10-01 16:53:48 -0700 | [diff] [blame] | 401 | for (size_t i = 0; i < *maxDisplayFrames; i++) { |
Adithya Srinivasan | f279e04 | 2020-08-17 14:56:27 -0700 | [diff] [blame] | 402 | auto presentFence = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
| 403 | int64_t surfaceFrameToken = mTokenManager->generateTokenForPredictions( |
| 404 | {10 + frameTimeFactor, 20 + frameTimeFactor, 30 + frameTimeFactor}); |
| 405 | int64_t sfToken = mTokenManager->generateTokenForPredictions( |
| 406 | {22 + frameTimeFactor, 26 + frameTimeFactor, 30 + frameTimeFactor}); |
Huihong Luo | 3bdef86 | 2022-03-03 11:57:19 -0800 | [diff] [blame] | 407 | FrameTimelineInfo ftInfo; |
| 408 | ftInfo.vsyncId = surfaceFrameToken; |
| 409 | ftInfo.inputEventId = sInputEventId; |
Alec Mouri | 9a29e67 | 2020-09-14 12:39:14 -0700 | [diff] [blame] | 410 | auto surfaceFrame = |
Huihong Luo | 3bdef86 | 2022-03-03 11:57:19 -0800 | [diff] [blame] | 411 | mFrameTimeline->createSurfaceFrameForToken(ftInfo, sPidOne, sUidOne, sLayerIdOne, |
Adithya Srinivasan | 785addd | 2021-03-09 00:38:00 +0000 | [diff] [blame] | 412 | sLayerNameOne, sLayerNameOne, |
Adithya Srinivasan | 58069dc | 2021-06-04 20:37:02 +0000 | [diff] [blame] | 413 | /*isBuffer*/ true, sGameMode); |
Pascal Muetschard | ac7bcd9 | 2023-10-03 15:05:36 +0200 | [diff] [blame] | 414 | mFrameTimeline->setSfWakeUp(sfToken, 22 + frameTimeFactor, RR_11, RR_11); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 415 | surfaceFrame->setPresentState(SurfaceFrame::PresentState::Presented); |
| 416 | mFrameTimeline->addSurfaceFrame(surfaceFrame); |
Adithya Srinivasan | f279e04 | 2020-08-17 14:56:27 -0700 | [diff] [blame] | 417 | mFrameTimeline->setSfPresent(27 + frameTimeFactor, presentFence); |
| 418 | presentFence->signalForTest(32 + frameTimeFactor); |
| 419 | frameTimeFactor += 30; |
| 420 | } |
| 421 | auto displayFrame0 = getDisplayFrame(0); |
| 422 | |
| 423 | // The 0th Display Frame should have actuals 22, 27, 32 |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 424 | EXPECT_EQ(compareTimelineItems(displayFrame0->getActuals(), TimelineItem(22, 27, 32)), true); |
Adithya Srinivasan | f279e04 | 2020-08-17 14:56:27 -0700 | [diff] [blame] | 425 | |
| 426 | // Add one more display frame |
| 427 | auto presentFence = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
| 428 | int64_t surfaceFrameToken = mTokenManager->generateTokenForPredictions( |
| 429 | {10 + frameTimeFactor, 20 + frameTimeFactor, 30 + frameTimeFactor}); |
| 430 | int64_t sfToken = mTokenManager->generateTokenForPredictions( |
| 431 | {22 + frameTimeFactor, 26 + frameTimeFactor, 30 + frameTimeFactor}); |
Huihong Luo | 3bdef86 | 2022-03-03 11:57:19 -0800 | [diff] [blame] | 432 | FrameTimelineInfo ftInfo; |
| 433 | ftInfo.vsyncId = surfaceFrameToken; |
| 434 | ftInfo.inputEventId = sInputEventId; |
Alec Mouri | 9a29e67 | 2020-09-14 12:39:14 -0700 | [diff] [blame] | 435 | auto surfaceFrame = |
Huihong Luo | 3bdef86 | 2022-03-03 11:57:19 -0800 | [diff] [blame] | 436 | mFrameTimeline->createSurfaceFrameForToken(ftInfo, sPidOne, sUidOne, sLayerIdOne, |
| 437 | sLayerNameOne, sLayerNameOne, |
| 438 | /*isBuffer*/ true, sGameMode); |
Pascal Muetschard | ac7bcd9 | 2023-10-03 15:05:36 +0200 | [diff] [blame] | 439 | mFrameTimeline->setSfWakeUp(sfToken, 22 + frameTimeFactor, RR_11, RR_11); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 440 | surfaceFrame->setPresentState(SurfaceFrame::PresentState::Presented); |
| 441 | mFrameTimeline->addSurfaceFrame(surfaceFrame); |
Adithya Srinivasan | f279e04 | 2020-08-17 14:56:27 -0700 | [diff] [blame] | 442 | mFrameTimeline->setSfPresent(27 + frameTimeFactor, presentFence); |
| 443 | presentFence->signalForTest(32 + frameTimeFactor); |
| 444 | displayFrame0 = getDisplayFrame(0); |
| 445 | |
| 446 | // The window should have slided by 1 now and the previous 0th display frame |
| 447 | // should have been removed from the deque |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 448 | EXPECT_EQ(compareTimelineItems(displayFrame0->getActuals(), TimelineItem(52, 57, 62)), true); |
Adithya Srinivasan | f279e04 | 2020-08-17 14:56:27 -0700 | [diff] [blame] | 449 | } |
| 450 | |
Ady Abraham | 7f8a1e6 | 2020-09-28 16:09:35 -0700 | [diff] [blame] | 451 | TEST_F(FrameTimelineTest, surfaceFrameEndTimeAcquireFenceAfterQueue) { |
Adithya Srinivasan | 58069dc | 2021-06-04 20:37:02 +0000 | [diff] [blame] | 452 | auto surfaceFrame = mFrameTimeline->createSurfaceFrameForToken({}, sPidOne, 0, sLayerIdOne, |
| 453 | "acquireFenceAfterQueue", |
| 454 | "acquireFenceAfterQueue", |
| 455 | /*isBuffer*/ true, sGameMode); |
Ady Abraham | 7f8a1e6 | 2020-09-28 16:09:35 -0700 | [diff] [blame] | 456 | surfaceFrame->setActualQueueTime(123); |
| 457 | surfaceFrame->setAcquireFenceTime(456); |
| 458 | EXPECT_EQ(surfaceFrame->getActuals().endTime, 456); |
| 459 | } |
| 460 | |
| 461 | TEST_F(FrameTimelineTest, surfaceFrameEndTimeAcquireFenceBeforeQueue) { |
Adithya Srinivasan | 58069dc | 2021-06-04 20:37:02 +0000 | [diff] [blame] | 462 | auto surfaceFrame = mFrameTimeline->createSurfaceFrameForToken({}, sPidOne, 0, sLayerIdOne, |
| 463 | "acquireFenceAfterQueue", |
| 464 | "acquireFenceAfterQueue", |
| 465 | /*isBuffer*/ true, sGameMode); |
Ady Abraham | 7f8a1e6 | 2020-09-28 16:09:35 -0700 | [diff] [blame] | 466 | surfaceFrame->setActualQueueTime(456); |
| 467 | surfaceFrame->setAcquireFenceTime(123); |
| 468 | EXPECT_EQ(surfaceFrame->getActuals().endTime, 456); |
| 469 | } |
| 470 | |
Adithya Srinivasan | 2d73632 | 2020-10-01 16:53:48 -0700 | [diff] [blame] | 471 | TEST_F(FrameTimelineTest, setMaxDisplayFramesSetsSizeProperly) { |
| 472 | auto presentFence = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
| 473 | presentFence->signalForTest(2); |
| 474 | |
| 475 | // Size shouldn't exceed maxDisplayFrames - 64 |
| 476 | for (size_t i = 0; i < *maxDisplayFrames + 10; i++) { |
Adithya Srinivasan | 9febda8 | 2020-10-19 10:49:41 -0700 | [diff] [blame] | 477 | auto surfaceFrame = |
Alec Mouri | adebf5c | 2021-01-05 12:57:36 -0800 | [diff] [blame] | 478 | mFrameTimeline->createSurfaceFrameForToken({}, sPidOne, sUidOne, sLayerIdOne, |
Adithya Srinivasan | 785addd | 2021-03-09 00:38:00 +0000 | [diff] [blame] | 479 | sLayerNameOne, sLayerNameOne, |
Adithya Srinivasan | 58069dc | 2021-06-04 20:37:02 +0000 | [diff] [blame] | 480 | /*isBuffer*/ true, sGameMode); |
Adithya Srinivasan | 2d73632 | 2020-10-01 16:53:48 -0700 | [diff] [blame] | 481 | int64_t sfToken = mTokenManager->generateTokenForPredictions({22, 26, 30}); |
Pascal Muetschard | ac7bcd9 | 2023-10-03 15:05:36 +0200 | [diff] [blame] | 482 | mFrameTimeline->setSfWakeUp(sfToken, 22, RR_11, RR_11); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 483 | surfaceFrame->setPresentState(SurfaceFrame::PresentState::Presented); |
| 484 | mFrameTimeline->addSurfaceFrame(surfaceFrame); |
Adithya Srinivasan | 2d73632 | 2020-10-01 16:53:48 -0700 | [diff] [blame] | 485 | mFrameTimeline->setSfPresent(27, presentFence); |
| 486 | } |
| 487 | EXPECT_EQ(getNumberOfDisplayFrames(), *maxDisplayFrames); |
| 488 | |
| 489 | // Increase the size to 256 |
| 490 | mFrameTimeline->setMaxDisplayFrames(256); |
Siarhei Vishniakou | fc434ac | 2021-01-13 10:28:00 -1000 | [diff] [blame] | 491 | EXPECT_EQ(*maxDisplayFrames, 256u); |
Adithya Srinivasan | 2d73632 | 2020-10-01 16:53:48 -0700 | [diff] [blame] | 492 | |
| 493 | for (size_t i = 0; i < *maxDisplayFrames + 10; i++) { |
Adithya Srinivasan | 9febda8 | 2020-10-19 10:49:41 -0700 | [diff] [blame] | 494 | auto surfaceFrame = |
Alec Mouri | adebf5c | 2021-01-05 12:57:36 -0800 | [diff] [blame] | 495 | mFrameTimeline->createSurfaceFrameForToken({}, sPidOne, sUidOne, sLayerIdOne, |
Adithya Srinivasan | 785addd | 2021-03-09 00:38:00 +0000 | [diff] [blame] | 496 | sLayerNameOne, sLayerNameOne, |
Adithya Srinivasan | 58069dc | 2021-06-04 20:37:02 +0000 | [diff] [blame] | 497 | /*isBuffer*/ true, sGameMode); |
Adithya Srinivasan | 2d73632 | 2020-10-01 16:53:48 -0700 | [diff] [blame] | 498 | int64_t sfToken = mTokenManager->generateTokenForPredictions({22, 26, 30}); |
Pascal Muetschard | ac7bcd9 | 2023-10-03 15:05:36 +0200 | [diff] [blame] | 499 | mFrameTimeline->setSfWakeUp(sfToken, 22, RR_11, RR_11); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 500 | surfaceFrame->setPresentState(SurfaceFrame::PresentState::Presented); |
| 501 | mFrameTimeline->addSurfaceFrame(surfaceFrame); |
Adithya Srinivasan | 2d73632 | 2020-10-01 16:53:48 -0700 | [diff] [blame] | 502 | mFrameTimeline->setSfPresent(27, presentFence); |
| 503 | } |
| 504 | EXPECT_EQ(getNumberOfDisplayFrames(), *maxDisplayFrames); |
| 505 | |
| 506 | // Shrink the size to 128 |
| 507 | mFrameTimeline->setMaxDisplayFrames(128); |
Siarhei Vishniakou | fc434ac | 2021-01-13 10:28:00 -1000 | [diff] [blame] | 508 | EXPECT_EQ(*maxDisplayFrames, 128u); |
Adithya Srinivasan | 2d73632 | 2020-10-01 16:53:48 -0700 | [diff] [blame] | 509 | |
| 510 | for (size_t i = 0; i < *maxDisplayFrames + 10; i++) { |
Adithya Srinivasan | 9febda8 | 2020-10-19 10:49:41 -0700 | [diff] [blame] | 511 | auto surfaceFrame = |
Alec Mouri | adebf5c | 2021-01-05 12:57:36 -0800 | [diff] [blame] | 512 | mFrameTimeline->createSurfaceFrameForToken({}, sPidOne, sUidOne, sLayerIdOne, |
Adithya Srinivasan | 785addd | 2021-03-09 00:38:00 +0000 | [diff] [blame] | 513 | sLayerNameOne, sLayerNameOne, |
Adithya Srinivasan | 58069dc | 2021-06-04 20:37:02 +0000 | [diff] [blame] | 514 | /*isBuffer*/ true, sGameMode); |
Adithya Srinivasan | 2d73632 | 2020-10-01 16:53:48 -0700 | [diff] [blame] | 515 | int64_t sfToken = mTokenManager->generateTokenForPredictions({22, 26, 30}); |
Pascal Muetschard | ac7bcd9 | 2023-10-03 15:05:36 +0200 | [diff] [blame] | 516 | mFrameTimeline->setSfWakeUp(sfToken, 22, RR_11, RR_11); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 517 | surfaceFrame->setPresentState(SurfaceFrame::PresentState::Presented); |
| 518 | mFrameTimeline->addSurfaceFrame(surfaceFrame); |
Adithya Srinivasan | 2d73632 | 2020-10-01 16:53:48 -0700 | [diff] [blame] | 519 | mFrameTimeline->setSfPresent(27, presentFence); |
| 520 | } |
| 521 | EXPECT_EQ(getNumberOfDisplayFrames(), *maxDisplayFrames); |
| 522 | } |
Alec Mouri | 9a29e67 | 2020-09-14 12:39:14 -0700 | [diff] [blame] | 523 | |
Adithya Srinivasan | 7c4ac7a | 2021-03-08 23:48:03 +0000 | [diff] [blame] | 524 | TEST_F(FrameTimelineTest, presentFenceSignaled_invalidSignalTime) { |
Pascal Muetschard | ac7bcd9 | 2023-10-03 15:05:36 +0200 | [diff] [blame] | 525 | Fps refreshRate = RR_11; |
Adithya Srinivasan | 7c4ac7a | 2021-03-08 23:48:03 +0000 | [diff] [blame] | 526 | |
| 527 | auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
| 528 | int64_t surfaceFrameToken1 = mTokenManager->generateTokenForPredictions({10, 20, 60}); |
| 529 | int64_t sfToken1 = mTokenManager->generateTokenForPredictions({52, 60, 60}); |
Huihong Luo | 3bdef86 | 2022-03-03 11:57:19 -0800 | [diff] [blame] | 530 | FrameTimelineInfo ftInfo; |
| 531 | ftInfo.vsyncId = surfaceFrameToken1; |
| 532 | ftInfo.inputEventId = sInputEventId; |
Adithya Srinivasan | 7c4ac7a | 2021-03-08 23:48:03 +0000 | [diff] [blame] | 533 | |
| 534 | auto surfaceFrame1 = |
Huihong Luo | 3bdef86 | 2022-03-03 11:57:19 -0800 | [diff] [blame] | 535 | mFrameTimeline->createSurfaceFrameForToken(ftInfo, sPidOne, sUidOne, sLayerIdOne, |
| 536 | sLayerNameOne, sLayerNameOne, |
| 537 | /*isBuffer*/ true, sGameMode); |
Pascal Muetschard | ac7bcd9 | 2023-10-03 15:05:36 +0200 | [diff] [blame] | 538 | mFrameTimeline->setSfWakeUp(sfToken1, 52, refreshRate, refreshRate); |
Adithya Srinivasan | 7c4ac7a | 2021-03-08 23:48:03 +0000 | [diff] [blame] | 539 | surfaceFrame1->setAcquireFenceTime(20); |
| 540 | surfaceFrame1->setPresentState(SurfaceFrame::PresentState::Presented); |
| 541 | mFrameTimeline->addSurfaceFrame(surfaceFrame1); |
| 542 | |
| 543 | mFrameTimeline->setSfPresent(59, presentFence1); |
| 544 | presentFence1->signalForTest(-1); |
| 545 | addEmptyDisplayFrame(); |
| 546 | |
| 547 | auto displayFrame0 = getDisplayFrame(0); |
Ady Abraham | fcb1686 | 2022-10-10 14:35:21 -0700 | [diff] [blame] | 548 | EXPECT_EQ(displayFrame0->getActuals().presentTime, 59); |
Ady Abraham | b1e10d1 | 2023-03-13 15:23:54 -0700 | [diff] [blame] | 549 | EXPECT_EQ(displayFrame0->getJankType(), JankType::Unknown | JankType::DisplayHAL); |
Ying Wei | 96eb535 | 2023-11-21 17:37:21 +0000 | [diff] [blame] | 550 | EXPECT_EQ(displayFrame0->getJankSeverityType(), JankSeverityType::Unknown); |
Adithya Srinivasan | 7c4ac7a | 2021-03-08 23:48:03 +0000 | [diff] [blame] | 551 | EXPECT_EQ(surfaceFrame1->getActuals().presentTime, -1); |
| 552 | EXPECT_EQ(surfaceFrame1->getJankType(), JankType::Unknown); |
Ying Wei | 96eb535 | 2023-11-21 17:37:21 +0000 | [diff] [blame] | 553 | EXPECT_EQ(surfaceFrame1->getJankSeverityType(), JankSeverityType::Unknown); |
Adithya Srinivasan | 7c4ac7a | 2021-03-08 23:48:03 +0000 | [diff] [blame] | 554 | } |
| 555 | |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 556 | // Tests related to TimeStats |
Adithya Srinivasan | 7c4ac7a | 2021-03-08 23:48:03 +0000 | [diff] [blame] | 557 | TEST_F(FrameTimelineTest, presentFenceSignaled_doesNotReportForInvalidTokens) { |
Pascal Muetschard | ac7bcd9 | 2023-10-03 15:05:36 +0200 | [diff] [blame] | 558 | Fps refreshRate = RR_11; |
Adithya Srinivasan | 7c4ac7a | 2021-03-08 23:48:03 +0000 | [diff] [blame] | 559 | EXPECT_CALL(*mTimeStats, incrementJankyFrames(_)).Times(0); |
| 560 | auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
| 561 | int64_t surfaceFrameToken1 = -1; |
| 562 | int64_t sfToken1 = -1; |
Huihong Luo | 3bdef86 | 2022-03-03 11:57:19 -0800 | [diff] [blame] | 563 | FrameTimelineInfo ftInfo; |
| 564 | ftInfo.vsyncId = surfaceFrameToken1; |
| 565 | ftInfo.inputEventId = sInputEventId; |
Adithya Srinivasan | 7c4ac7a | 2021-03-08 23:48:03 +0000 | [diff] [blame] | 566 | |
| 567 | auto surfaceFrame1 = |
Huihong Luo | 3bdef86 | 2022-03-03 11:57:19 -0800 | [diff] [blame] | 568 | mFrameTimeline->createSurfaceFrameForToken(ftInfo, sPidOne, sUidOne, sLayerIdOne, |
| 569 | sLayerNameOne, sLayerNameOne, |
| 570 | /*isBuffer*/ true, sGameMode); |
Pascal Muetschard | ac7bcd9 | 2023-10-03 15:05:36 +0200 | [diff] [blame] | 571 | mFrameTimeline->setSfWakeUp(sfToken1, 52, refreshRate, refreshRate); |
Adithya Srinivasan | 7c4ac7a | 2021-03-08 23:48:03 +0000 | [diff] [blame] | 572 | surfaceFrame1->setAcquireFenceTime(20); |
| 573 | surfaceFrame1->setPresentState(SurfaceFrame::PresentState::Presented); |
| 574 | mFrameTimeline->addSurfaceFrame(surfaceFrame1); |
| 575 | presentFence1->signalForTest(70); |
| 576 | |
| 577 | mFrameTimeline->setSfPresent(59, presentFence1); |
| 578 | } |
| 579 | |
Alec Mouri | 9a29e67 | 2020-09-14 12:39:14 -0700 | [diff] [blame] | 580 | TEST_F(FrameTimelineTest, presentFenceSignaled_reportsLongSfCpu) { |
Pascal Muetschard | ac7bcd9 | 2023-10-03 15:05:36 +0200 | [diff] [blame] | 581 | Fps refreshRate = RR_11; |
Alec Mouri | 9a29e67 | 2020-09-14 12:39:14 -0700 | [diff] [blame] | 582 | EXPECT_CALL(*mTimeStats, |
Alec Mouri | 363faf0 | 2021-01-29 16:34:55 -0800 | [diff] [blame] | 583 | incrementJankyFrames( |
| 584 | TimeStats::JankyFramesInfo{refreshRate, std::nullopt, sUidOne, |
Adithya Srinivasan | 58069dc | 2021-06-04 20:37:02 +0000 | [diff] [blame] | 585 | sLayerNameOne, sGameMode, |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 586 | JankType::SurfaceFlingerCpuDeadlineMissed, 2, 10, |
Alec Mouri | 363faf0 | 2021-01-29 16:34:55 -0800 | [diff] [blame] | 587 | 0})); |
Alec Mouri | 9a29e67 | 2020-09-14 12:39:14 -0700 | [diff] [blame] | 588 | auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 589 | int64_t surfaceFrameToken1 = mTokenManager->generateTokenForPredictions({10, 20, 60}); |
| 590 | int64_t sfToken1 = mTokenManager->generateTokenForPredictions({52, 60, 60}); |
Huihong Luo | 3bdef86 | 2022-03-03 11:57:19 -0800 | [diff] [blame] | 591 | FrameTimelineInfo ftInfo; |
| 592 | ftInfo.vsyncId = surfaceFrameToken1; |
| 593 | ftInfo.inputEventId = sInputEventId; |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 594 | |
Alec Mouri | 9a29e67 | 2020-09-14 12:39:14 -0700 | [diff] [blame] | 595 | auto surfaceFrame1 = |
Huihong Luo | 3bdef86 | 2022-03-03 11:57:19 -0800 | [diff] [blame] | 596 | mFrameTimeline->createSurfaceFrameForToken(ftInfo, sPidOne, sUidOne, sLayerIdOne, |
| 597 | sLayerNameOne, sLayerNameOne, |
| 598 | /*isBuffer*/ true, sGameMode); |
Pascal Muetschard | ac7bcd9 | 2023-10-03 15:05:36 +0200 | [diff] [blame] | 599 | mFrameTimeline->setSfWakeUp(sfToken1, 52, refreshRate, refreshRate); |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 600 | surfaceFrame1->setAcquireFenceTime(20); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 601 | surfaceFrame1->setPresentState(SurfaceFrame::PresentState::Presented); |
| 602 | mFrameTimeline->addSurfaceFrame(surfaceFrame1); |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 603 | presentFence1->signalForTest(70); |
Alec Mouri | 9a29e67 | 2020-09-14 12:39:14 -0700 | [diff] [blame] | 604 | |
Adithya Srinivasan | 82eef32 | 2021-04-10 00:06:04 +0000 | [diff] [blame] | 605 | mFrameTimeline->setSfPresent(62, presentFence1); |
Alec Mouri | 9a29e67 | 2020-09-14 12:39:14 -0700 | [diff] [blame] | 606 | } |
| 607 | |
Adithya Srinivasan | 36b01af | 2021-04-07 22:29:47 +0000 | [diff] [blame] | 608 | TEST_F(FrameTimelineTest, presentFenceSignaled_reportsLongSfGpu) { |
Pascal Muetschard | ac7bcd9 | 2023-10-03 15:05:36 +0200 | [diff] [blame] | 609 | Fps refreshRate = RR_11; |
Adithya Srinivasan | 36b01af | 2021-04-07 22:29:47 +0000 | [diff] [blame] | 610 | EXPECT_CALL(*mTimeStats, |
| 611 | incrementJankyFrames( |
| 612 | TimeStats::JankyFramesInfo{refreshRate, std::nullopt, sUidOne, |
Adithya Srinivasan | 58069dc | 2021-06-04 20:37:02 +0000 | [diff] [blame] | 613 | sLayerNameOne, sGameMode, |
Adithya Srinivasan | 36b01af | 2021-04-07 22:29:47 +0000 | [diff] [blame] | 614 | JankType::SurfaceFlingerGpuDeadlineMissed, 4, 10, |
| 615 | 0})); |
| 616 | auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
| 617 | auto gpuFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
| 618 | int64_t surfaceFrameToken1 = mTokenManager->generateTokenForPredictions({10, 20, 60}); |
| 619 | int64_t sfToken1 = mTokenManager->generateTokenForPredictions({52, 60, 60}); |
Huihong Luo | 3bdef86 | 2022-03-03 11:57:19 -0800 | [diff] [blame] | 620 | FrameTimelineInfo ftInfo; |
| 621 | ftInfo.vsyncId = surfaceFrameToken1; |
| 622 | ftInfo.inputEventId = sInputEventId; |
Adithya Srinivasan | 36b01af | 2021-04-07 22:29:47 +0000 | [diff] [blame] | 623 | |
| 624 | auto surfaceFrame1 = |
Huihong Luo | 3bdef86 | 2022-03-03 11:57:19 -0800 | [diff] [blame] | 625 | mFrameTimeline->createSurfaceFrameForToken(ftInfo, sPidOne, sUidOne, sLayerIdOne, |
| 626 | sLayerNameOne, sLayerNameOne, |
| 627 | /*isBuffer*/ true, sGameMode); |
Pascal Muetschard | ac7bcd9 | 2023-10-03 15:05:36 +0200 | [diff] [blame] | 628 | mFrameTimeline->setSfWakeUp(sfToken1, 52, refreshRate, refreshRate); |
Adithya Srinivasan | 36b01af | 2021-04-07 22:29:47 +0000 | [diff] [blame] | 629 | surfaceFrame1->setAcquireFenceTime(20); |
| 630 | surfaceFrame1->setPresentState(SurfaceFrame::PresentState::Presented); |
| 631 | mFrameTimeline->addSurfaceFrame(surfaceFrame1); |
| 632 | gpuFence1->signalForTest(64); |
| 633 | presentFence1->signalForTest(70); |
| 634 | |
| 635 | mFrameTimeline->setSfPresent(59, presentFence1, gpuFence1); |
| 636 | } |
| 637 | |
Alec Mouri | 9a29e67 | 2020-09-14 12:39:14 -0700 | [diff] [blame] | 638 | TEST_F(FrameTimelineTest, presentFenceSignaled_reportsDisplayMiss) { |
Pascal Muetschard | ac7bcd9 | 2023-10-03 15:05:36 +0200 | [diff] [blame] | 639 | Fps refreshRate = RR_30; |
Alec Mouri | 9a29e67 | 2020-09-14 12:39:14 -0700 | [diff] [blame] | 640 | EXPECT_CALL(*mTimeStats, |
Alec Mouri | 363faf0 | 2021-01-29 16:34:55 -0800 | [diff] [blame] | 641 | incrementJankyFrames(TimeStats::JankyFramesInfo{refreshRate, std::nullopt, sUidOne, |
Adithya Srinivasan | 58069dc | 2021-06-04 20:37:02 +0000 | [diff] [blame] | 642 | sLayerNameOne, sGameMode, |
| 643 | JankType::DisplayHAL, -4, 0, 0})); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 644 | |
Alec Mouri | 9a29e67 | 2020-09-14 12:39:14 -0700 | [diff] [blame] | 645 | auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 646 | int64_t surfaceFrameToken1 = mTokenManager->generateTokenForPredictions({10, 20, 60}); |
| 647 | int64_t sfToken1 = mTokenManager->generateTokenForPredictions({52, 60, 60}); |
Huihong Luo | 3bdef86 | 2022-03-03 11:57:19 -0800 | [diff] [blame] | 648 | FrameTimelineInfo ftInfo; |
| 649 | ftInfo.vsyncId = surfaceFrameToken1; |
| 650 | ftInfo.inputEventId = sInputEventId; |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 651 | |
Alec Mouri | 9a29e67 | 2020-09-14 12:39:14 -0700 | [diff] [blame] | 652 | auto surfaceFrame1 = |
Huihong Luo | 3bdef86 | 2022-03-03 11:57:19 -0800 | [diff] [blame] | 653 | mFrameTimeline->createSurfaceFrameForToken(ftInfo, sPidOne, sUidOne, sLayerIdOne, |
| 654 | sLayerNameOne, sLayerNameOne, |
| 655 | /*isBuffer*/ true, sGameMode); |
Pascal Muetschard | ac7bcd9 | 2023-10-03 15:05:36 +0200 | [diff] [blame] | 656 | mFrameTimeline->setSfWakeUp(sfToken1, 52, refreshRate, refreshRate); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 657 | surfaceFrame1->setPresentState(SurfaceFrame::PresentState::Presented); |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 658 | surfaceFrame1->setAcquireFenceTime(20); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 659 | mFrameTimeline->addSurfaceFrame(surfaceFrame1); |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 660 | presentFence1->signalForTest(90); |
| 661 | mFrameTimeline->setSfPresent(56, presentFence1); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 662 | EXPECT_EQ(surfaceFrame1->getJankType(), JankType::DisplayHAL); |
Ying Wei | 96eb535 | 2023-11-21 17:37:21 +0000 | [diff] [blame] | 663 | EXPECT_EQ(surfaceFrame1->getJankSeverityType(), JankSeverityType::Full); |
Alec Mouri | 9a29e67 | 2020-09-14 12:39:14 -0700 | [diff] [blame] | 664 | } |
| 665 | |
| 666 | TEST_F(FrameTimelineTest, presentFenceSignaled_reportsAppMiss) { |
Dominik Laskowski | 6eab42d | 2021-09-13 14:34:13 -0700 | [diff] [blame] | 667 | Fps refreshRate = 11_Hz; |
Alec Mouri | 9a29e67 | 2020-09-14 12:39:14 -0700 | [diff] [blame] | 668 | EXPECT_CALL(*mTimeStats, |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 669 | incrementJankyFrames(TimeStats::JankyFramesInfo{refreshRate, std::nullopt, sUidOne, |
Adithya Srinivasan | 58069dc | 2021-06-04 20:37:02 +0000 | [diff] [blame] | 670 | sLayerNameOne, sGameMode, |
Adithya Srinivasan | 82eef32 | 2021-04-10 00:06:04 +0000 | [diff] [blame] | 671 | JankType::AppDeadlineMissed, -4, 0, |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 672 | 25})); |
Alec Mouri | 9a29e67 | 2020-09-14 12:39:14 -0700 | [diff] [blame] | 673 | auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 674 | int64_t surfaceFrameToken1 = mTokenManager->generateTokenForPredictions({10, 20, 60}); |
| 675 | int64_t sfToken1 = mTokenManager->generateTokenForPredictions({82, 90, 90}); |
Huihong Luo | 3bdef86 | 2022-03-03 11:57:19 -0800 | [diff] [blame] | 676 | FrameTimelineInfo ftInfo; |
| 677 | ftInfo.vsyncId = surfaceFrameToken1; |
| 678 | ftInfo.inputEventId = sInputEventId; |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 679 | |
Alec Mouri | 9a29e67 | 2020-09-14 12:39:14 -0700 | [diff] [blame] | 680 | auto surfaceFrame1 = |
Huihong Luo | 3bdef86 | 2022-03-03 11:57:19 -0800 | [diff] [blame] | 681 | mFrameTimeline->createSurfaceFrameForToken(ftInfo, sPidOne, sUidOne, sLayerIdOne, |
| 682 | sLayerNameOne, sLayerNameOne, |
| 683 | /*isBuffer*/ true, sGameMode); |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 684 | surfaceFrame1->setAcquireFenceTime(45); |
Pascal Muetschard | ac7bcd9 | 2023-10-03 15:05:36 +0200 | [diff] [blame] | 685 | mFrameTimeline->setSfWakeUp(sfToken1, 52, refreshRate, refreshRate); |
Alec Mouri | 9a29e67 | 2020-09-14 12:39:14 -0700 | [diff] [blame] | 686 | |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 687 | surfaceFrame1->setPresentState(SurfaceFrame::PresentState::Presented); |
| 688 | mFrameTimeline->addSurfaceFrame(surfaceFrame1); |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 689 | presentFence1->signalForTest(90); |
| 690 | mFrameTimeline->setSfPresent(86, presentFence1); |
Jorim Jaggi | 9c03b50 | 2020-11-24 23:51:31 +0100 | [diff] [blame] | 691 | |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 692 | EXPECT_EQ(surfaceFrame1->getJankType(), JankType::AppDeadlineMissed); |
Ying Wei | 96eb535 | 2023-11-21 17:37:21 +0000 | [diff] [blame] | 693 | EXPECT_EQ(surfaceFrame1->getJankSeverityType(), JankSeverityType::Partial); |
Alec Mouri | 9a29e67 | 2020-09-14 12:39:14 -0700 | [diff] [blame] | 694 | } |
| 695 | |
Adithya Srinivasan | ead1716 | 2021-02-18 02:17:37 +0000 | [diff] [blame] | 696 | TEST_F(FrameTimelineTest, presentFenceSignaled_reportsSfScheduling) { |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 697 | Fps refreshRate = Fps::fromPeriodNsecs(32); |
Adithya Srinivasan | ead1716 | 2021-02-18 02:17:37 +0000 | [diff] [blame] | 698 | EXPECT_CALL(*mTimeStats, |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 699 | incrementJankyFrames(TimeStats::JankyFramesInfo{refreshRate, std::nullopt, sUidOne, |
Adithya Srinivasan | 58069dc | 2021-06-04 20:37:02 +0000 | [diff] [blame] | 700 | sLayerNameOne, sGameMode, |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 701 | JankType::SurfaceFlingerScheduling, |
Adithya Srinivasan | 82eef32 | 2021-04-10 00:06:04 +0000 | [diff] [blame] | 702 | -4, 0, -10})); |
Adithya Srinivasan | ead1716 | 2021-02-18 02:17:37 +0000 | [diff] [blame] | 703 | auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 704 | int64_t surfaceFrameToken1 = mTokenManager->generateTokenForPredictions({40, 60, 92}); |
| 705 | int64_t sfToken1 = mTokenManager->generateTokenForPredictions({52, 60, 60}); |
Huihong Luo | 3bdef86 | 2022-03-03 11:57:19 -0800 | [diff] [blame] | 706 | FrameTimelineInfo ftInfo; |
| 707 | ftInfo.vsyncId = surfaceFrameToken1; |
| 708 | ftInfo.inputEventId = sInputEventId; |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 709 | |
Adithya Srinivasan | ead1716 | 2021-02-18 02:17:37 +0000 | [diff] [blame] | 710 | auto surfaceFrame1 = |
Huihong Luo | 3bdef86 | 2022-03-03 11:57:19 -0800 | [diff] [blame] | 711 | mFrameTimeline->createSurfaceFrameForToken(ftInfo, sPidOne, sUidOne, sLayerIdOne, |
| 712 | sLayerNameOne, sLayerNameOne, |
| 713 | /*isBuffer*/ true, sGameMode); |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 714 | surfaceFrame1->setAcquireFenceTime(50); |
Pascal Muetschard | ac7bcd9 | 2023-10-03 15:05:36 +0200 | [diff] [blame] | 715 | mFrameTimeline->setSfWakeUp(sfToken1, 52, refreshRate, refreshRate); |
Adithya Srinivasan | ead1716 | 2021-02-18 02:17:37 +0000 | [diff] [blame] | 716 | |
| 717 | surfaceFrame1->setPresentState(SurfaceFrame::PresentState::Presented); |
| 718 | mFrameTimeline->addSurfaceFrame(surfaceFrame1); |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 719 | presentFence1->signalForTest(60); |
| 720 | mFrameTimeline->setSfPresent(56, presentFence1); |
Adithya Srinivasan | ead1716 | 2021-02-18 02:17:37 +0000 | [diff] [blame] | 721 | |
| 722 | EXPECT_EQ(surfaceFrame1->getJankType(), JankType::SurfaceFlingerScheduling); |
Ying Wei | 96eb535 | 2023-11-21 17:37:21 +0000 | [diff] [blame] | 723 | EXPECT_EQ(surfaceFrame1->getJankSeverityType(), JankSeverityType::Full); |
Adithya Srinivasan | ead1716 | 2021-02-18 02:17:37 +0000 | [diff] [blame] | 724 | } |
| 725 | |
| 726 | TEST_F(FrameTimelineTest, presentFenceSignaled_reportsSfPredictionError) { |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 727 | Fps refreshRate = Fps::fromPeriodNsecs(16); |
Adithya Srinivasan | ead1716 | 2021-02-18 02:17:37 +0000 | [diff] [blame] | 728 | EXPECT_CALL(*mTimeStats, |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 729 | incrementJankyFrames(TimeStats::JankyFramesInfo{refreshRate, std::nullopt, sUidOne, |
Adithya Srinivasan | 58069dc | 2021-06-04 20:37:02 +0000 | [diff] [blame] | 730 | sLayerNameOne, sGameMode, |
Adithya Srinivasan | 82eef32 | 2021-04-10 00:06:04 +0000 | [diff] [blame] | 731 | JankType::PredictionError, -4, 5, |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 732 | 0})); |
Adithya Srinivasan | ead1716 | 2021-02-18 02:17:37 +0000 | [diff] [blame] | 733 | auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 734 | int64_t surfaceFrameToken1 = mTokenManager->generateTokenForPredictions({30, 40, 60}); |
| 735 | int64_t sfToken1 = mTokenManager->generateTokenForPredictions({52, 60, 60}); |
Huihong Luo | 3bdef86 | 2022-03-03 11:57:19 -0800 | [diff] [blame] | 736 | FrameTimelineInfo ftInfo; |
| 737 | ftInfo.vsyncId = surfaceFrameToken1; |
| 738 | ftInfo.inputEventId = sInputEventId; |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 739 | |
Adithya Srinivasan | ead1716 | 2021-02-18 02:17:37 +0000 | [diff] [blame] | 740 | auto surfaceFrame1 = |
Huihong Luo | 3bdef86 | 2022-03-03 11:57:19 -0800 | [diff] [blame] | 741 | mFrameTimeline->createSurfaceFrameForToken(ftInfo, sPidOne, sUidOne, sLayerIdOne, |
| 742 | sLayerNameOne, sLayerNameOne, |
| 743 | /*isBuffer*/ true, sGameMode); |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 744 | surfaceFrame1->setAcquireFenceTime(40); |
Pascal Muetschard | ac7bcd9 | 2023-10-03 15:05:36 +0200 | [diff] [blame] | 745 | mFrameTimeline->setSfWakeUp(sfToken1, 52, refreshRate, refreshRate); |
Adithya Srinivasan | ead1716 | 2021-02-18 02:17:37 +0000 | [diff] [blame] | 746 | |
| 747 | surfaceFrame1->setPresentState(SurfaceFrame::PresentState::Presented); |
| 748 | mFrameTimeline->addSurfaceFrame(surfaceFrame1); |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 749 | presentFence1->signalForTest(65); |
| 750 | mFrameTimeline->setSfPresent(56, presentFence1); |
Adithya Srinivasan | ead1716 | 2021-02-18 02:17:37 +0000 | [diff] [blame] | 751 | |
| 752 | EXPECT_EQ(surfaceFrame1->getJankType(), JankType::PredictionError); |
Ying Wei | 96eb535 | 2023-11-21 17:37:21 +0000 | [diff] [blame] | 753 | EXPECT_EQ(surfaceFrame1->getJankSeverityType(), JankSeverityType::Partial); |
Adithya Srinivasan | ead1716 | 2021-02-18 02:17:37 +0000 | [diff] [blame] | 754 | } |
| 755 | |
| 756 | TEST_F(FrameTimelineTest, presentFenceSignaled_reportsAppBufferStuffing) { |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 757 | Fps refreshRate = Fps::fromPeriodNsecs(32); |
Adithya Srinivasan | ead1716 | 2021-02-18 02:17:37 +0000 | [diff] [blame] | 758 | EXPECT_CALL(*mTimeStats, |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 759 | incrementJankyFrames(TimeStats::JankyFramesInfo{refreshRate, std::nullopt, sUidOne, |
Adithya Srinivasan | 58069dc | 2021-06-04 20:37:02 +0000 | [diff] [blame] | 760 | sLayerNameOne, sGameMode, |
Adithya Srinivasan | 82eef32 | 2021-04-10 00:06:04 +0000 | [diff] [blame] | 761 | JankType::BufferStuffing, -4, 0, |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 762 | 0})); |
Adithya Srinivasan | ead1716 | 2021-02-18 02:17:37 +0000 | [diff] [blame] | 763 | auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 764 | int64_t surfaceFrameToken1 = mTokenManager->generateTokenForPredictions({30, 40, 58}); |
| 765 | int64_t sfToken1 = mTokenManager->generateTokenForPredictions({82, 90, 90}); |
Huihong Luo | 3bdef86 | 2022-03-03 11:57:19 -0800 | [diff] [blame] | 766 | FrameTimelineInfo ftInfo; |
| 767 | ftInfo.vsyncId = surfaceFrameToken1; |
| 768 | ftInfo.inputEventId = sInputEventId; |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 769 | |
Adithya Srinivasan | ead1716 | 2021-02-18 02:17:37 +0000 | [diff] [blame] | 770 | auto surfaceFrame1 = |
Huihong Luo | 3bdef86 | 2022-03-03 11:57:19 -0800 | [diff] [blame] | 771 | mFrameTimeline->createSurfaceFrameForToken(ftInfo, sPidOne, sUidOne, sLayerIdOne, |
| 772 | sLayerNameOne, sLayerNameOne, |
| 773 | /*isBuffer*/ true, sGameMode); |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 774 | surfaceFrame1->setAcquireFenceTime(40); |
Pascal Muetschard | ac7bcd9 | 2023-10-03 15:05:36 +0200 | [diff] [blame] | 775 | mFrameTimeline->setSfWakeUp(sfToken1, 82, refreshRate, refreshRate); |
Adithya Srinivasan | ead1716 | 2021-02-18 02:17:37 +0000 | [diff] [blame] | 776 | |
| 777 | surfaceFrame1->setPresentState(SurfaceFrame::PresentState::Presented, |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 778 | /*previousLatchTime*/ 56); |
Adithya Srinivasan | ead1716 | 2021-02-18 02:17:37 +0000 | [diff] [blame] | 779 | mFrameTimeline->addSurfaceFrame(surfaceFrame1); |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 780 | presentFence1->signalForTest(90); |
| 781 | mFrameTimeline->setSfPresent(86, presentFence1); |
Adithya Srinivasan | ead1716 | 2021-02-18 02:17:37 +0000 | [diff] [blame] | 782 | |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 783 | EXPECT_EQ(surfaceFrame1->getJankType(), JankType::BufferStuffing); |
Ying Wei | 96eb535 | 2023-11-21 17:37:21 +0000 | [diff] [blame] | 784 | EXPECT_EQ(surfaceFrame1->getJankSeverityType(), JankSeverityType::Full); |
Adithya Srinivasan | ead1716 | 2021-02-18 02:17:37 +0000 | [diff] [blame] | 785 | } |
| 786 | |
Alec Mouri | 363faf0 | 2021-01-29 16:34:55 -0800 | [diff] [blame] | 787 | TEST_F(FrameTimelineTest, presentFenceSignaled_reportsAppMissWithRenderRate) { |
Pascal Muetschard | ac7bcd9 | 2023-10-03 15:05:36 +0200 | [diff] [blame] | 788 | Fps refreshRate = RR_11; |
| 789 | Fps renderRate = RR_30; |
Alec Mouri | 363faf0 | 2021-01-29 16:34:55 -0800 | [diff] [blame] | 790 | EXPECT_CALL(*mTimeStats, |
Adithya Srinivasan | 58069dc | 2021-06-04 20:37:02 +0000 | [diff] [blame] | 791 | incrementJankyFrames(TimeStats::JankyFramesInfo{refreshRate, renderRate, sUidOne, |
| 792 | sLayerNameOne, sGameMode, |
| 793 | JankType::AppDeadlineMissed, -4, 0, |
| 794 | 25})); |
Alec Mouri | 363faf0 | 2021-01-29 16:34:55 -0800 | [diff] [blame] | 795 | auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 796 | int64_t surfaceFrameToken1 = mTokenManager->generateTokenForPredictions({10, 20, 60}); |
| 797 | int64_t sfToken1 = mTokenManager->generateTokenForPredictions({82, 90, 90}); |
Huihong Luo | 3bdef86 | 2022-03-03 11:57:19 -0800 | [diff] [blame] | 798 | FrameTimelineInfo ftInfo; |
| 799 | ftInfo.vsyncId = surfaceFrameToken1; |
| 800 | ftInfo.inputEventId = sInputEventId; |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 801 | |
Alec Mouri | 363faf0 | 2021-01-29 16:34:55 -0800 | [diff] [blame] | 802 | auto surfaceFrame1 = |
Huihong Luo | 3bdef86 | 2022-03-03 11:57:19 -0800 | [diff] [blame] | 803 | mFrameTimeline->createSurfaceFrameForToken(ftInfo, sPidOne, sUidOne, sLayerIdOne, |
| 804 | sLayerNameOne, sLayerNameOne, |
| 805 | /*isBuffer*/ true, sGameMode); |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 806 | surfaceFrame1->setAcquireFenceTime(45); |
Pascal Muetschard | ac7bcd9 | 2023-10-03 15:05:36 +0200 | [diff] [blame] | 807 | mFrameTimeline->setSfWakeUp(sfToken1, 52, refreshRate, refreshRate); |
Alec Mouri | 363faf0 | 2021-01-29 16:34:55 -0800 | [diff] [blame] | 808 | |
| 809 | surfaceFrame1->setPresentState(SurfaceFrame::PresentState::Presented); |
| 810 | surfaceFrame1->setRenderRate(renderRate); |
| 811 | mFrameTimeline->addSurfaceFrame(surfaceFrame1); |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 812 | presentFence1->signalForTest(90); |
| 813 | mFrameTimeline->setSfPresent(86, presentFence1); |
Alec Mouri | 363faf0 | 2021-01-29 16:34:55 -0800 | [diff] [blame] | 814 | |
| 815 | EXPECT_EQ(surfaceFrame1->getJankType(), JankType::AppDeadlineMissed); |
Ying Wei | 96eb535 | 2023-11-21 17:37:21 +0000 | [diff] [blame] | 816 | EXPECT_EQ(surfaceFrame1->getJankSeverityType(), JankSeverityType::Full); |
Alec Mouri | 363faf0 | 2021-01-29 16:34:55 -0800 | [diff] [blame] | 817 | } |
| 818 | |
Adithya Srinivasan | 115ac69 | 2021-03-06 01:21:30 +0000 | [diff] [blame] | 819 | TEST_F(FrameTimelineTest, presentFenceSignaled_displayFramePredictionExpiredPresentsSurfaceFrame) { |
Pascal Muetschard | ac7bcd9 | 2023-10-03 15:05:36 +0200 | [diff] [blame] | 820 | Fps refreshRate = RR_11; |
| 821 | Fps renderRate = RR_30; |
Adithya Srinivasan | 115ac69 | 2021-03-06 01:21:30 +0000 | [diff] [blame] | 822 | |
| 823 | EXPECT_CALL(*mTimeStats, |
Adithya Srinivasan | 8a94550 | 2021-03-19 19:12:32 +0000 | [diff] [blame] | 824 | incrementJankyFrames( |
| 825 | TimeStats::JankyFramesInfo{refreshRate, renderRate, sUidOne, sLayerNameOne, |
Adithya Srinivasan | 58069dc | 2021-06-04 20:37:02 +0000 | [diff] [blame] | 826 | sGameMode, |
Adithya Srinivasan | 8a94550 | 2021-03-19 19:12:32 +0000 | [diff] [blame] | 827 | JankType::Unknown | JankType::AppDeadlineMissed, |
Adithya Srinivasan | de27245 | 2021-04-10 00:21:00 +0000 | [diff] [blame] | 828 | 0, 0, 25})); |
Adithya Srinivasan | 115ac69 | 2021-03-06 01:21:30 +0000 | [diff] [blame] | 829 | auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
| 830 | int64_t surfaceFrameToken1 = mTokenManager->generateTokenForPredictions({10, 20, 60}); |
| 831 | int64_t sfToken1 = mTokenManager->generateTokenForPredictions({82, 90, 90}); |
Huihong Luo | 3bdef86 | 2022-03-03 11:57:19 -0800 | [diff] [blame] | 832 | FrameTimelineInfo ftInfo; |
| 833 | ftInfo.vsyncId = surfaceFrameToken1; |
| 834 | ftInfo.inputEventId = sInputEventId; |
Adithya Srinivasan | 115ac69 | 2021-03-06 01:21:30 +0000 | [diff] [blame] | 835 | |
| 836 | auto surfaceFrame1 = |
Huihong Luo | 3bdef86 | 2022-03-03 11:57:19 -0800 | [diff] [blame] | 837 | mFrameTimeline->createSurfaceFrameForToken(ftInfo, sPidOne, sUidOne, sLayerIdOne, |
| 838 | sLayerNameOne, sLayerNameOne, |
| 839 | /*isBuffer*/ true, sGameMode); |
Adithya Srinivasan | 115ac69 | 2021-03-06 01:21:30 +0000 | [diff] [blame] | 840 | surfaceFrame1->setAcquireFenceTime(45); |
| 841 | // Trigger a prediction expiry |
Adithya Srinivasan | bed4c4f | 2021-05-03 20:24:46 +0000 | [diff] [blame] | 842 | flushTokens(); |
Pascal Muetschard | ac7bcd9 | 2023-10-03 15:05:36 +0200 | [diff] [blame] | 843 | mFrameTimeline->setSfWakeUp(sfToken1, 52, refreshRate, refreshRate); |
Adithya Srinivasan | 115ac69 | 2021-03-06 01:21:30 +0000 | [diff] [blame] | 844 | |
| 845 | surfaceFrame1->setPresentState(SurfaceFrame::PresentState::Presented); |
| 846 | surfaceFrame1->setRenderRate(renderRate); |
| 847 | mFrameTimeline->addSurfaceFrame(surfaceFrame1); |
| 848 | presentFence1->signalForTest(90); |
| 849 | mFrameTimeline->setSfPresent(86, presentFence1); |
| 850 | |
| 851 | auto displayFrame = getDisplayFrame(0); |
| 852 | EXPECT_EQ(displayFrame->getJankType(), JankType::Unknown); |
Ying Wei | 96eb535 | 2023-11-21 17:37:21 +0000 | [diff] [blame] | 853 | EXPECT_EQ(displayFrame->getJankSeverityType(), JankSeverityType::Unknown); |
Adithya Srinivasan | 115ac69 | 2021-03-06 01:21:30 +0000 | [diff] [blame] | 854 | EXPECT_EQ(displayFrame->getFrameStartMetadata(), FrameStartMetadata::UnknownStart); |
| 855 | EXPECT_EQ(displayFrame->getFrameReadyMetadata(), FrameReadyMetadata::UnknownFinish); |
| 856 | EXPECT_EQ(displayFrame->getFramePresentMetadata(), FramePresentMetadata::UnknownPresent); |
| 857 | |
| 858 | EXPECT_EQ(surfaceFrame1->getActuals().presentTime, 90); |
Adithya Srinivasan | 8a94550 | 2021-03-19 19:12:32 +0000 | [diff] [blame] | 859 | EXPECT_EQ(surfaceFrame1->getJankType(), JankType::Unknown | JankType::AppDeadlineMissed); |
Ying Wei | 96eb535 | 2023-11-21 17:37:21 +0000 | [diff] [blame] | 860 | EXPECT_EQ(surfaceFrame1->getJankSeverityType(), JankSeverityType::Full); |
Adithya Srinivasan | 115ac69 | 2021-03-06 01:21:30 +0000 | [diff] [blame] | 861 | } |
| 862 | |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 863 | /* |
| 864 | * Tracing Tests |
| 865 | * |
| 866 | * Trace packets are flushed all the way only when the next packet is traced. |
| 867 | * For example: trace<Display/Surface>Frame() will create a TracePacket but not flush it. Only when |
| 868 | * another TracePacket is created, the previous one is guaranteed to be flushed. The following tests |
| 869 | * will have additional empty frames created for this reason. |
| 870 | */ |
| 871 | TEST_F(FrameTimelineTest, tracing_noPacketsSentWithoutTraceStart) { |
| 872 | auto tracingSession = getTracingSessionForTest(); |
| 873 | auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 874 | int64_t token1 = mTokenManager->generateTokenForPredictions({10, 20, 30}); |
Huihong Luo | 3bdef86 | 2022-03-03 11:57:19 -0800 | [diff] [blame] | 875 | FrameTimelineInfo ftInfo; |
| 876 | ftInfo.vsyncId = token1; |
| 877 | ftInfo.inputEventId = sInputEventId; |
Siarhei Vishniakou | fc434ac | 2021-01-13 10:28:00 -1000 | [diff] [blame] | 878 | auto surfaceFrame1 = |
Huihong Luo | 3bdef86 | 2022-03-03 11:57:19 -0800 | [diff] [blame] | 879 | mFrameTimeline->createSurfaceFrameForToken(ftInfo, sPidOne, sUidOne, sLayerIdOne, |
| 880 | sLayerNameOne, sLayerNameOne, |
Adithya Srinivasan | 58069dc | 2021-06-04 20:37:02 +0000 | [diff] [blame] | 881 | /*isBuffer*/ true, sGameMode); |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 882 | |
| 883 | // Set up the display frame |
Pascal Muetschard | ac7bcd9 | 2023-10-03 15:05:36 +0200 | [diff] [blame] | 884 | mFrameTimeline->setSfWakeUp(token1, 20, RR_11, RR_11); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 885 | surfaceFrame1->setPresentState(SurfaceFrame::PresentState::Dropped); |
| 886 | mFrameTimeline->addSurfaceFrame(surfaceFrame1); |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 887 | mFrameTimeline->setSfPresent(25, presentFence1); |
| 888 | presentFence1->signalForTest(30); |
| 889 | |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 890 | addEmptyDisplayFrame(); |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 891 | |
| 892 | auto packets = readFrameTimelinePacketsBlocking(tracingSession.get()); |
Siarhei Vishniakou | fc434ac | 2021-01-13 10:28:00 -1000 | [diff] [blame] | 893 | EXPECT_EQ(packets.size(), 0u); |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 894 | } |
| 895 | |
| 896 | TEST_F(FrameTimelineTest, tracing_sanityTest) { |
| 897 | auto tracingSession = getTracingSessionForTest(); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 898 | // Layer specific increment |
Alec Mouri | 363faf0 | 2021-01-29 16:34:55 -0800 | [diff] [blame] | 899 | EXPECT_CALL(*mTimeStats, incrementJankyFrames(_)); |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 900 | auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 901 | |
| 902 | tracingSession->StartBlocking(); |
| 903 | int64_t token1 = mTokenManager->generateTokenForPredictions({10, 20, 30}); |
| 904 | int64_t token2 = mTokenManager->generateTokenForPredictions({40, 50, 60}); |
Huihong Luo | 3bdef86 | 2022-03-03 11:57:19 -0800 | [diff] [blame] | 905 | FrameTimelineInfo ftInfo; |
| 906 | ftInfo.vsyncId = token1; |
| 907 | ftInfo.inputEventId = sInputEventId; |
Siarhei Vishniakou | fc434ac | 2021-01-13 10:28:00 -1000 | [diff] [blame] | 908 | auto surfaceFrame1 = |
Huihong Luo | 3bdef86 | 2022-03-03 11:57:19 -0800 | [diff] [blame] | 909 | mFrameTimeline->createSurfaceFrameForToken(ftInfo, sPidOne, sUidOne, sLayerIdOne, |
| 910 | sLayerNameOne, sLayerNameOne, |
Adithya Srinivasan | 58069dc | 2021-06-04 20:37:02 +0000 | [diff] [blame] | 911 | /*isBuffer*/ true, sGameMode); |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 912 | |
| 913 | // Set up the display frame |
Pascal Muetschard | ac7bcd9 | 2023-10-03 15:05:36 +0200 | [diff] [blame] | 914 | mFrameTimeline->setSfWakeUp(token2, 20, RR_11, RR_11); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 915 | surfaceFrame1->setPresentState(SurfaceFrame::PresentState::Presented); |
| 916 | mFrameTimeline->addSurfaceFrame(surfaceFrame1); |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 917 | mFrameTimeline->setSfPresent(25, presentFence1); |
| 918 | presentFence1->signalForTest(30); |
| 919 | |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 920 | addEmptyDisplayFrame(); |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 921 | flushTrace(); |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 922 | tracingSession->StopBlocking(); |
| 923 | |
| 924 | auto packets = readFrameTimelinePacketsBlocking(tracingSession.get()); |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 925 | // Display Frame 1 has 8 packets - 4 from DisplayFrame and 4 from SurfaceFrame. |
Siarhei Vishniakou | fc434ac | 2021-01-13 10:28:00 -1000 | [diff] [blame] | 926 | EXPECT_EQ(packets.size(), 8u); |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 927 | } |
| 928 | |
| 929 | TEST_F(FrameTimelineTest, traceDisplayFrame_invalidTokenDoesNotEmitTracePacket) { |
| 930 | auto tracingSession = getTracingSessionForTest(); |
| 931 | auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 932 | |
| 933 | tracingSession->StartBlocking(); |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 934 | |
| 935 | // Set up the display frame |
Pascal Muetschard | ac7bcd9 | 2023-10-03 15:05:36 +0200 | [diff] [blame] | 936 | mFrameTimeline->setSfWakeUp(-1, 20, RR_11, RR_11); |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 937 | mFrameTimeline->setSfPresent(25, presentFence1); |
| 938 | presentFence1->signalForTest(30); |
| 939 | |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 940 | addEmptyDisplayFrame(); |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 941 | flushTrace(); |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 942 | tracingSession->StopBlocking(); |
| 943 | |
| 944 | auto packets = readFrameTimelinePacketsBlocking(tracingSession.get()); |
Siarhei Vishniakou | fc434ac | 2021-01-13 10:28:00 -1000 | [diff] [blame] | 945 | EXPECT_EQ(packets.size(), 0u); |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 946 | } |
| 947 | |
| 948 | TEST_F(FrameTimelineTest, traceSurfaceFrame_invalidTokenDoesNotEmitTracePacket) { |
| 949 | auto tracingSession = getTracingSessionForTest(); |
| 950 | auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 951 | |
| 952 | tracingSession->StartBlocking(); |
| 953 | int64_t token1 = mTokenManager->generateTokenForPredictions({10, 20, 30}); |
Alec Mouri | adebf5c | 2021-01-05 12:57:36 -0800 | [diff] [blame] | 954 | auto surfaceFrame1 = |
| 955 | mFrameTimeline->createSurfaceFrameForToken({}, sPidOne, sUidOne, sLayerIdOne, |
Adithya Srinivasan | 785addd | 2021-03-09 00:38:00 +0000 | [diff] [blame] | 956 | sLayerNameOne, sLayerNameOne, |
Adithya Srinivasan | 58069dc | 2021-06-04 20:37:02 +0000 | [diff] [blame] | 957 | /*isBuffer*/ true, sGameMode); |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 958 | |
| 959 | // Set up the display frame |
Pascal Muetschard | ac7bcd9 | 2023-10-03 15:05:36 +0200 | [diff] [blame] | 960 | mFrameTimeline->setSfWakeUp(token1, 20, RR_11, RR_11); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 961 | surfaceFrame1->setPresentState(SurfaceFrame::PresentState::Dropped); |
| 962 | mFrameTimeline->addSurfaceFrame(surfaceFrame1); |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 963 | mFrameTimeline->setSfPresent(25, presentFence1); |
| 964 | presentFence1->signalForTest(30); |
| 965 | |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 966 | addEmptyDisplayFrame(); |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 967 | flushTrace(); |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 968 | tracingSession->StopBlocking(); |
| 969 | |
| 970 | auto packets = readFrameTimelinePacketsBlocking(tracingSession.get()); |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 971 | // Display Frame 1 has 4 packets (SurfaceFrame shouldn't be traced since it has an invalid |
| 972 | // token). |
Siarhei Vishniakou | fc434ac | 2021-01-13 10:28:00 -1000 | [diff] [blame] | 973 | EXPECT_EQ(packets.size(), 4u); |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 974 | } |
| 975 | |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 976 | ProtoExpectedDisplayFrameStart createProtoExpectedDisplayFrameStart(int64_t cookie, int64_t token, |
| 977 | pid_t pid) { |
| 978 | ProtoExpectedDisplayFrameStart proto; |
| 979 | proto.set_cookie(cookie); |
| 980 | proto.set_token(token); |
| 981 | proto.set_pid(pid); |
| 982 | return proto; |
| 983 | } |
| 984 | |
| 985 | ProtoActualDisplayFrameStart createProtoActualDisplayFrameStart( |
| 986 | int64_t cookie, int64_t token, pid_t pid, ProtoPresentType presentType, bool onTimeFinish, |
Ying Wei | 96eb535 | 2023-11-21 17:37:21 +0000 | [diff] [blame] | 987 | bool gpuComposition, ProtoJankType jankType, ProtoJankSeverityType jankSeverityType, |
| 988 | ProtoPredictionType predictionType) { |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 989 | ProtoActualDisplayFrameStart proto; |
| 990 | proto.set_cookie(cookie); |
| 991 | proto.set_token(token); |
| 992 | proto.set_pid(pid); |
| 993 | proto.set_present_type(presentType); |
| 994 | proto.set_on_time_finish(onTimeFinish); |
| 995 | proto.set_gpu_composition(gpuComposition); |
| 996 | proto.set_jank_type(jankType); |
Ying Wei | 96eb535 | 2023-11-21 17:37:21 +0000 | [diff] [blame] | 997 | proto.set_jank_severity_type(jankSeverityType); |
Adithya Srinivasan | 78e58af | 2021-02-25 00:08:08 +0000 | [diff] [blame] | 998 | proto.set_prediction_type(predictionType); |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 999 | return proto; |
| 1000 | } |
| 1001 | |
| 1002 | ProtoExpectedSurfaceFrameStart createProtoExpectedSurfaceFrameStart(int64_t cookie, int64_t token, |
| 1003 | int64_t displayFrameToken, |
| 1004 | pid_t pid, |
| 1005 | std::string layerName) { |
| 1006 | ProtoExpectedSurfaceFrameStart proto; |
| 1007 | proto.set_cookie(cookie); |
| 1008 | proto.set_token(token); |
| 1009 | proto.set_display_frame_token(displayFrameToken); |
| 1010 | proto.set_pid(pid); |
| 1011 | proto.set_layer_name(layerName); |
| 1012 | return proto; |
| 1013 | } |
| 1014 | |
| 1015 | ProtoActualSurfaceFrameStart createProtoActualSurfaceFrameStart( |
| 1016 | int64_t cookie, int64_t token, int64_t displayFrameToken, pid_t pid, std::string layerName, |
| 1017 | ProtoPresentType presentType, bool onTimeFinish, bool gpuComposition, |
Ying Wei | 96eb535 | 2023-11-21 17:37:21 +0000 | [diff] [blame] | 1018 | ProtoJankType jankType, ProtoJankSeverityType jankSeverityType, |
| 1019 | ProtoPredictionType predictionType, bool isBuffer) { |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 1020 | ProtoActualSurfaceFrameStart proto; |
| 1021 | proto.set_cookie(cookie); |
| 1022 | proto.set_token(token); |
| 1023 | proto.set_display_frame_token(displayFrameToken); |
| 1024 | proto.set_pid(pid); |
| 1025 | proto.set_layer_name(layerName); |
| 1026 | proto.set_present_type(presentType); |
| 1027 | proto.set_on_time_finish(onTimeFinish); |
| 1028 | proto.set_gpu_composition(gpuComposition); |
| 1029 | proto.set_jank_type(jankType); |
Ying Wei | 96eb535 | 2023-11-21 17:37:21 +0000 | [diff] [blame] | 1030 | proto.set_jank_severity_type(jankSeverityType); |
Adithya Srinivasan | 78e58af | 2021-02-25 00:08:08 +0000 | [diff] [blame] | 1031 | proto.set_prediction_type(predictionType); |
Adithya Srinivasan | 1f9450c | 2021-06-10 22:39:19 +0000 | [diff] [blame] | 1032 | proto.set_is_buffer(isBuffer); |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 1033 | return proto; |
| 1034 | } |
| 1035 | |
| 1036 | ProtoFrameEnd createProtoFrameEnd(int64_t cookie) { |
| 1037 | ProtoFrameEnd proto; |
| 1038 | proto.set_cookie(cookie); |
| 1039 | return proto; |
| 1040 | } |
| 1041 | |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 1042 | void validateTraceEvent(const ProtoExpectedDisplayFrameStart& received, |
| 1043 | const ProtoExpectedDisplayFrameStart& source) { |
| 1044 | ASSERT_TRUE(received.has_cookie()); |
| 1045 | EXPECT_EQ(received.cookie(), source.cookie()); |
| 1046 | |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 1047 | ASSERT_TRUE(received.has_token()); |
| 1048 | EXPECT_EQ(received.token(), source.token()); |
| 1049 | |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 1050 | ASSERT_TRUE(received.has_pid()); |
| 1051 | EXPECT_EQ(received.pid(), source.pid()); |
| 1052 | } |
| 1053 | |
| 1054 | void validateTraceEvent(const ProtoActualDisplayFrameStart& received, |
| 1055 | const ProtoActualDisplayFrameStart& source) { |
| 1056 | ASSERT_TRUE(received.has_cookie()); |
| 1057 | EXPECT_EQ(received.cookie(), source.cookie()); |
| 1058 | |
| 1059 | ASSERT_TRUE(received.has_token()); |
| 1060 | EXPECT_EQ(received.token(), source.token()); |
| 1061 | |
| 1062 | ASSERT_TRUE(received.has_pid()); |
| 1063 | EXPECT_EQ(received.pid(), source.pid()); |
| 1064 | |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 1065 | ASSERT_TRUE(received.has_present_type()); |
| 1066 | EXPECT_EQ(received.present_type(), source.present_type()); |
| 1067 | ASSERT_TRUE(received.has_on_time_finish()); |
| 1068 | EXPECT_EQ(received.on_time_finish(), source.on_time_finish()); |
| 1069 | ASSERT_TRUE(received.has_gpu_composition()); |
| 1070 | EXPECT_EQ(received.gpu_composition(), source.gpu_composition()); |
| 1071 | ASSERT_TRUE(received.has_jank_type()); |
| 1072 | EXPECT_EQ(received.jank_type(), source.jank_type()); |
Ying Wei | 96eb535 | 2023-11-21 17:37:21 +0000 | [diff] [blame] | 1073 | ASSERT_TRUE(received.has_jank_severity_type()); |
| 1074 | EXPECT_EQ(received.jank_severity_type(), source.jank_severity_type()); |
Adithya Srinivasan | 78e58af | 2021-02-25 00:08:08 +0000 | [diff] [blame] | 1075 | ASSERT_TRUE(received.has_prediction_type()); |
| 1076 | EXPECT_EQ(received.prediction_type(), source.prediction_type()); |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 1077 | } |
| 1078 | |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 1079 | void validateTraceEvent(const ProtoExpectedSurfaceFrameStart& received, |
| 1080 | const ProtoExpectedSurfaceFrameStart& source) { |
| 1081 | ASSERT_TRUE(received.has_cookie()); |
| 1082 | EXPECT_EQ(received.cookie(), source.cookie()); |
| 1083 | |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 1084 | ASSERT_TRUE(received.has_token()); |
| 1085 | EXPECT_EQ(received.token(), source.token()); |
| 1086 | |
| 1087 | ASSERT_TRUE(received.has_display_frame_token()); |
| 1088 | EXPECT_EQ(received.display_frame_token(), source.display_frame_token()); |
| 1089 | |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 1090 | ASSERT_TRUE(received.has_pid()); |
| 1091 | EXPECT_EQ(received.pid(), source.pid()); |
| 1092 | |
| 1093 | ASSERT_TRUE(received.has_layer_name()); |
| 1094 | EXPECT_EQ(received.layer_name(), source.layer_name()); |
| 1095 | } |
| 1096 | |
| 1097 | void validateTraceEvent(const ProtoActualSurfaceFrameStart& received, |
| 1098 | const ProtoActualSurfaceFrameStart& source) { |
| 1099 | ASSERT_TRUE(received.has_cookie()); |
| 1100 | EXPECT_EQ(received.cookie(), source.cookie()); |
| 1101 | |
| 1102 | ASSERT_TRUE(received.has_token()); |
| 1103 | EXPECT_EQ(received.token(), source.token()); |
| 1104 | |
| 1105 | ASSERT_TRUE(received.has_display_frame_token()); |
| 1106 | EXPECT_EQ(received.display_frame_token(), source.display_frame_token()); |
| 1107 | |
| 1108 | ASSERT_TRUE(received.has_pid()); |
| 1109 | EXPECT_EQ(received.pid(), source.pid()); |
| 1110 | |
| 1111 | ASSERT_TRUE(received.has_layer_name()); |
| 1112 | EXPECT_EQ(received.layer_name(), source.layer_name()); |
| 1113 | |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 1114 | ASSERT_TRUE(received.has_present_type()); |
| 1115 | EXPECT_EQ(received.present_type(), source.present_type()); |
| 1116 | ASSERT_TRUE(received.has_on_time_finish()); |
| 1117 | EXPECT_EQ(received.on_time_finish(), source.on_time_finish()); |
| 1118 | ASSERT_TRUE(received.has_gpu_composition()); |
| 1119 | EXPECT_EQ(received.gpu_composition(), source.gpu_composition()); |
| 1120 | ASSERT_TRUE(received.has_jank_type()); |
| 1121 | EXPECT_EQ(received.jank_type(), source.jank_type()); |
Ying Wei | 96eb535 | 2023-11-21 17:37:21 +0000 | [diff] [blame] | 1122 | ASSERT_TRUE(received.has_jank_severity_type()); |
| 1123 | EXPECT_EQ(received.jank_severity_type(), source.jank_severity_type()); |
Adithya Srinivasan | 78e58af | 2021-02-25 00:08:08 +0000 | [diff] [blame] | 1124 | ASSERT_TRUE(received.has_prediction_type()); |
| 1125 | EXPECT_EQ(received.prediction_type(), source.prediction_type()); |
Adithya Srinivasan | 1f9450c | 2021-06-10 22:39:19 +0000 | [diff] [blame] | 1126 | ASSERT_TRUE(received.has_is_buffer()); |
| 1127 | EXPECT_EQ(received.is_buffer(), source.is_buffer()); |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 1128 | } |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 1129 | |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 1130 | void validateTraceEvent(const ProtoFrameEnd& received, const ProtoFrameEnd& source) { |
| 1131 | ASSERT_TRUE(received.has_cookie()); |
| 1132 | EXPECT_EQ(received.cookie(), source.cookie()); |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 1133 | } |
| 1134 | |
Sally Qi | 2269a69 | 2024-05-17 18:02:28 -0700 | [diff] [blame] | 1135 | TEST_F(FrameTimelineTest, traceDisplayFrameNoSkipped) { |
| 1136 | // setup 2 display frames |
| 1137 | // DF 1: [22, 30] -> [0, 11] |
| 1138 | // DF 2: [82, 90] -> SF [5, 16] |
| 1139 | auto tracingSession = getTracingSessionForTest(); |
| 1140 | tracingSession->StartBlocking(); |
| 1141 | int64_t sfToken1 = mTokenManager->generateTokenForPredictions({22, 30, 40}); |
| 1142 | int64_t sfToken2 = mTokenManager->generateTokenForPredictions({82, 90, 100}); |
| 1143 | int64_t surfaceFrameToken1 = mTokenManager->generateTokenForPredictions({0, 11, 25}); |
| 1144 | int64_t surfaceFrameToken2 = mTokenManager->generateTokenForPredictions({5, 16, 30}); |
| 1145 | auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
| 1146 | |
| 1147 | int64_t traceCookie = snoopCurrentTraceCookie(); |
| 1148 | |
| 1149 | // set up 1st display frame |
| 1150 | FrameTimelineInfo ftInfo1; |
| 1151 | ftInfo1.vsyncId = surfaceFrameToken1; |
| 1152 | ftInfo1.inputEventId = sInputEventId; |
| 1153 | auto surfaceFrame1 = |
| 1154 | mFrameTimeline->createSurfaceFrameForToken(ftInfo1, sPidOne, sUidOne, sLayerIdOne, |
| 1155 | sLayerNameOne, sLayerNameOne, |
| 1156 | /*isBuffer*/ true, sGameMode); |
| 1157 | surfaceFrame1->setAcquireFenceTime(11); |
| 1158 | mFrameTimeline->setSfWakeUp(sfToken1, 22, RR_11, RR_30); |
| 1159 | surfaceFrame1->setPresentState(SurfaceFrame::PresentState::Presented); |
| 1160 | mFrameTimeline->addSurfaceFrame(surfaceFrame1); |
| 1161 | mFrameTimeline->setSfPresent(30, presentFence1); |
| 1162 | presentFence1->signalForTest(40); |
| 1163 | |
| 1164 | // Trigger a flush by finalizing the next DisplayFrame |
| 1165 | auto presentFence2 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
| 1166 | FrameTimelineInfo ftInfo2; |
| 1167 | ftInfo2.vsyncId = surfaceFrameToken2; |
| 1168 | ftInfo2.inputEventId = sInputEventId; |
| 1169 | auto surfaceFrame2 = |
| 1170 | mFrameTimeline->createSurfaceFrameForToken(ftInfo2, sPidOne, sUidOne, sLayerIdOne, |
| 1171 | sLayerNameOne, sLayerNameOne, |
| 1172 | /*isBuffer*/ true, sGameMode); |
| 1173 | |
| 1174 | // set up 2nd display frame |
| 1175 | surfaceFrame2->setAcquireFenceTime(16); |
| 1176 | mFrameTimeline->setSfWakeUp(sfToken2, 82, RR_11, RR_30); |
| 1177 | surfaceFrame2->setPresentState(SurfaceFrame::PresentState::Presented); |
| 1178 | mFrameTimeline->addSurfaceFrame(surfaceFrame2); |
| 1179 | mFrameTimeline->setSfPresent(90, presentFence2); |
| 1180 | presentFence2->signalForTest(100); |
| 1181 | |
| 1182 | // the token of skipped Display Frame |
| 1183 | auto protoSkippedActualDisplayFrameStart = |
| 1184 | createProtoActualDisplayFrameStart(traceCookie + 9, 0, kSurfaceFlingerPid, |
| 1185 | FrameTimelineEvent::PRESENT_DROPPED, true, false, |
| 1186 | FrameTimelineEvent::JANK_DROPPED, |
| 1187 | FrameTimelineEvent::SEVERITY_NONE, |
| 1188 | FrameTimelineEvent::PREDICTION_VALID); |
| 1189 | auto protoSkippedActualDisplayFrameEnd = createProtoFrameEnd(traceCookie + 9); |
| 1190 | |
| 1191 | // Trigger a flush by finalizing the next DisplayFrame |
| 1192 | addEmptyDisplayFrame(); |
| 1193 | flushTrace(); |
| 1194 | tracingSession->StopBlocking(); |
| 1195 | |
| 1196 | auto packets = readFrameTimelinePacketsBlocking(tracingSession.get()); |
| 1197 | // 8 Valid Display Frames + 8 Valid Surface Frames + no Skipped Display Frames |
| 1198 | EXPECT_EQ(packets.size(), 16u); |
| 1199 | } |
| 1200 | |
Sally Qi | aa10774 | 2023-09-29 14:53:14 -0700 | [diff] [blame] | 1201 | TEST_F(FrameTimelineTest, traceDisplayFrameSkipped) { |
Sally Qi | f572125 | 2023-11-17 11:14:53 -0800 | [diff] [blame] | 1202 | SET_FLAG_FOR_TEST(com::android::graphics::surfaceflinger::flags::add_sf_skipped_frames_to_trace, |
| 1203 | true); |
| 1204 | |
Sally Qi | aa10774 | 2023-09-29 14:53:14 -0700 | [diff] [blame] | 1205 | // setup 2 display frames |
| 1206 | // DF 1: [22,40] -> [5, 40] |
| 1207 | // DF : [36, 70] (Skipped one, added by the trace) |
| 1208 | // DF 2: [82, 100] -> SF [25, 70] |
| 1209 | auto tracingSession = getTracingSessionForTest(); |
| 1210 | tracingSession->StartBlocking(); |
| 1211 | int64_t sfToken1 = mTokenManager->generateTokenForPredictions({22, 30, 40}); |
| 1212 | int64_t sfToken2 = mTokenManager->generateTokenForPredictions({82, 90, 100}); |
| 1213 | int64_t surfaceFrameToken1 = mTokenManager->generateTokenForPredictions({5, 16, 40}); |
| 1214 | int64_t surfaceFrameToken2 = mTokenManager->generateTokenForPredictions({25, 36, 70}); |
| 1215 | auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
| 1216 | |
| 1217 | int64_t traceCookie = snoopCurrentTraceCookie(); |
| 1218 | |
| 1219 | // set up 1st display frame |
| 1220 | FrameTimelineInfo ftInfo1; |
| 1221 | ftInfo1.vsyncId = surfaceFrameToken1; |
| 1222 | ftInfo1.inputEventId = sInputEventId; |
| 1223 | auto surfaceFrame1 = |
| 1224 | mFrameTimeline->createSurfaceFrameForToken(ftInfo1, sPidOne, sUidOne, sLayerIdOne, |
| 1225 | sLayerNameOne, sLayerNameOne, |
| 1226 | /*isBuffer*/ true, sGameMode); |
| 1227 | surfaceFrame1->setAcquireFenceTime(16); |
| 1228 | mFrameTimeline->setSfWakeUp(sfToken1, 22, RR_11, RR_30); |
| 1229 | surfaceFrame1->setPresentState(SurfaceFrame::PresentState::Presented); |
| 1230 | mFrameTimeline->addSurfaceFrame(surfaceFrame1); |
| 1231 | mFrameTimeline->setSfPresent(30, presentFence1); |
| 1232 | presentFence1->signalForTest(40); |
| 1233 | |
| 1234 | // Trigger a flush by finalizing the next DisplayFrame |
| 1235 | auto presentFence2 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
| 1236 | FrameTimelineInfo ftInfo2; |
| 1237 | ftInfo2.vsyncId = surfaceFrameToken2; |
| 1238 | ftInfo2.inputEventId = sInputEventId; |
| 1239 | auto surfaceFrame2 = |
| 1240 | mFrameTimeline->createSurfaceFrameForToken(ftInfo2, sPidOne, sUidOne, sLayerIdOne, |
| 1241 | sLayerNameOne, sLayerNameOne, |
| 1242 | /*isBuffer*/ true, sGameMode); |
| 1243 | |
| 1244 | // set up 2nd display frame |
| 1245 | surfaceFrame2->setAcquireFenceTime(36); |
| 1246 | mFrameTimeline->setSfWakeUp(sfToken2, 82, RR_11, RR_30); |
| 1247 | surfaceFrame2->setPresentState(SurfaceFrame::PresentState::Presented); |
| 1248 | mFrameTimeline->addSurfaceFrame(surfaceFrame2); |
| 1249 | mFrameTimeline->setSfPresent(90, presentFence2); |
| 1250 | presentFence2->signalForTest(100); |
| 1251 | |
| 1252 | // the token of skipped Display Frame |
| 1253 | auto protoSkippedActualDisplayFrameStart = |
| 1254 | createProtoActualDisplayFrameStart(traceCookie + 9, 0, kSurfaceFlingerPid, |
| 1255 | FrameTimelineEvent::PRESENT_DROPPED, true, false, |
| 1256 | FrameTimelineEvent::JANK_DROPPED, |
Ying Wei | 96eb535 | 2023-11-21 17:37:21 +0000 | [diff] [blame] | 1257 | FrameTimelineEvent::SEVERITY_NONE, |
Sally Qi | aa10774 | 2023-09-29 14:53:14 -0700 | [diff] [blame] | 1258 | FrameTimelineEvent::PREDICTION_VALID); |
| 1259 | auto protoSkippedActualDisplayFrameEnd = createProtoFrameEnd(traceCookie + 9); |
| 1260 | |
| 1261 | // Trigger a flush by finalizing the next DisplayFrame |
| 1262 | addEmptyDisplayFrame(); |
| 1263 | flushTrace(); |
| 1264 | tracingSession->StopBlocking(); |
| 1265 | |
| 1266 | auto packets = readFrameTimelinePacketsBlocking(tracingSession.get()); |
| 1267 | // 8 Valid Display Frames + 8 Valid Surface Frames + 2 Skipped Display Frames |
| 1268 | EXPECT_EQ(packets.size(), 18u); |
| 1269 | |
| 1270 | // Packet - 16: Actual skipped Display Frame Start |
| 1271 | // the timestamp should be equal to the 2nd expected surface frame's end time |
| 1272 | const auto& packet16 = packets[16]; |
| 1273 | ASSERT_TRUE(packet16.has_timestamp()); |
| 1274 | EXPECT_EQ(packet16.timestamp(), 36u); |
| 1275 | ASSERT_TRUE(packet16.has_frame_timeline_event()); |
| 1276 | |
| 1277 | const auto& event16 = packet16.frame_timeline_event(); |
| 1278 | const auto& actualSkippedDisplayFrameStart = event16.actual_display_frame_start(); |
| 1279 | validateTraceEvent(actualSkippedDisplayFrameStart, protoSkippedActualDisplayFrameStart); |
| 1280 | |
| 1281 | // Packet - 17: Actual skipped Display Frame End |
| 1282 | // the timestamp should be equal to the 2nd expected surface frame's present time |
| 1283 | const auto& packet17 = packets[17]; |
| 1284 | ASSERT_TRUE(packet17.has_timestamp()); |
| 1285 | EXPECT_EQ(packet17.timestamp(), 70u); |
| 1286 | ASSERT_TRUE(packet17.has_frame_timeline_event()); |
| 1287 | |
| 1288 | const auto& event17 = packet17.frame_timeline_event(); |
| 1289 | const auto& actualSkippedDisplayFrameEnd = event17.frame_end(); |
| 1290 | validateTraceEvent(actualSkippedDisplayFrameEnd, protoSkippedActualDisplayFrameEnd); |
| 1291 | } |
| 1292 | |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 1293 | TEST_F(FrameTimelineTest, traceDisplayFrame_emitsValidTracePacket) { |
| 1294 | auto tracingSession = getTracingSessionForTest(); |
| 1295 | auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 1296 | |
| 1297 | tracingSession->StartBlocking(); |
Ady Abraham | 57a8ab4 | 2023-01-26 15:28:19 -0800 | [diff] [blame] | 1298 | |
| 1299 | // Add an empty surface frame so that display frame would get traced. |
| 1300 | addEmptySurfaceFrame(); |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 1301 | int64_t displayFrameToken1 = mTokenManager->generateTokenForPredictions({10, 30, 30}); |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 1302 | |
| 1303 | // Set up the display frame |
Pascal Muetschard | ac7bcd9 | 2023-10-03 15:05:36 +0200 | [diff] [blame] | 1304 | mFrameTimeline->setSfWakeUp(displayFrameToken1, 20, RR_11, RR_11); |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 1305 | mFrameTimeline->setSfPresent(26, presentFence1); |
| 1306 | presentFence1->signalForTest(31); |
| 1307 | |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 1308 | int64_t traceCookie = snoopCurrentTraceCookie(); |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 1309 | auto protoExpectedDisplayFrameStart = |
| 1310 | createProtoExpectedDisplayFrameStart(traceCookie + 1, displayFrameToken1, |
| 1311 | kSurfaceFlingerPid); |
| 1312 | auto protoExpectedDisplayFrameEnd = createProtoFrameEnd(traceCookie + 1); |
| 1313 | auto protoActualDisplayFrameStart = |
| 1314 | createProtoActualDisplayFrameStart(traceCookie + 2, displayFrameToken1, |
| 1315 | kSurfaceFlingerPid, |
| 1316 | FrameTimelineEvent::PRESENT_ON_TIME, true, false, |
Adithya Srinivasan | 78e58af | 2021-02-25 00:08:08 +0000 | [diff] [blame] | 1317 | FrameTimelineEvent::JANK_NONE, |
Ying Wei | 96eb535 | 2023-11-21 17:37:21 +0000 | [diff] [blame] | 1318 | FrameTimelineEvent::SEVERITY_NONE, |
Adithya Srinivasan | 78e58af | 2021-02-25 00:08:08 +0000 | [diff] [blame] | 1319 | FrameTimelineEvent::PREDICTION_VALID); |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 1320 | auto protoActualDisplayFrameEnd = createProtoFrameEnd(traceCookie + 2); |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 1321 | |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 1322 | addEmptyDisplayFrame(); |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 1323 | flushTrace(); |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 1324 | tracingSession->StopBlocking(); |
| 1325 | |
| 1326 | auto packets = readFrameTimelinePacketsBlocking(tracingSession.get()); |
Siarhei Vishniakou | fc434ac | 2021-01-13 10:28:00 -1000 | [diff] [blame] | 1327 | EXPECT_EQ(packets.size(), 4u); |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 1328 | |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 1329 | // Packet - 0 : ExpectedDisplayFrameStart |
| 1330 | const auto& packet0 = packets[0]; |
| 1331 | ASSERT_TRUE(packet0.has_timestamp()); |
Siarhei Vishniakou | fc434ac | 2021-01-13 10:28:00 -1000 | [diff] [blame] | 1332 | EXPECT_EQ(packet0.timestamp(), 10u); |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 1333 | ASSERT_TRUE(packet0.has_frame_timeline_event()); |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 1334 | |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 1335 | const auto& event0 = packet0.frame_timeline_event(); |
| 1336 | ASSERT_TRUE(event0.has_expected_display_frame_start()); |
| 1337 | const auto& expectedDisplayFrameStart = event0.expected_display_frame_start(); |
| 1338 | validateTraceEvent(expectedDisplayFrameStart, protoExpectedDisplayFrameStart); |
| 1339 | |
| 1340 | // Packet - 1 : FrameEnd (ExpectedDisplayFrame) |
| 1341 | const auto& packet1 = packets[1]; |
| 1342 | ASSERT_TRUE(packet1.has_timestamp()); |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 1343 | EXPECT_EQ(packet1.timestamp(), 30u); |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 1344 | ASSERT_TRUE(packet1.has_frame_timeline_event()); |
| 1345 | |
| 1346 | const auto& event1 = packet1.frame_timeline_event(); |
| 1347 | ASSERT_TRUE(event1.has_frame_end()); |
| 1348 | const auto& expectedDisplayFrameEnd = event1.frame_end(); |
| 1349 | validateTraceEvent(expectedDisplayFrameEnd, protoExpectedDisplayFrameEnd); |
| 1350 | |
| 1351 | // Packet - 2 : ActualDisplayFrameStart |
| 1352 | const auto& packet2 = packets[2]; |
| 1353 | ASSERT_TRUE(packet2.has_timestamp()); |
Siarhei Vishniakou | fc434ac | 2021-01-13 10:28:00 -1000 | [diff] [blame] | 1354 | EXPECT_EQ(packet2.timestamp(), 20u); |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 1355 | ASSERT_TRUE(packet2.has_frame_timeline_event()); |
| 1356 | |
| 1357 | const auto& event2 = packet2.frame_timeline_event(); |
| 1358 | ASSERT_TRUE(event2.has_actual_display_frame_start()); |
| 1359 | const auto& actualDisplayFrameStart = event2.actual_display_frame_start(); |
| 1360 | validateTraceEvent(actualDisplayFrameStart, protoActualDisplayFrameStart); |
| 1361 | |
| 1362 | // Packet - 3 : FrameEnd (ActualDisplayFrame) |
| 1363 | const auto& packet3 = packets[3]; |
| 1364 | ASSERT_TRUE(packet3.has_timestamp()); |
Adithya Srinivasan | 1a97163 | 2021-02-26 23:10:29 +0000 | [diff] [blame] | 1365 | EXPECT_EQ(packet3.timestamp(), 31u); |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 1366 | ASSERT_TRUE(packet3.has_frame_timeline_event()); |
| 1367 | |
| 1368 | const auto& event3 = packet3.frame_timeline_event(); |
| 1369 | ASSERT_TRUE(event3.has_frame_end()); |
| 1370 | const auto& actualDisplayFrameEnd = event3.frame_end(); |
| 1371 | validateTraceEvent(actualDisplayFrameEnd, protoActualDisplayFrameEnd); |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 1372 | } |
| 1373 | |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 1374 | TEST_F(FrameTimelineTest, traceDisplayFrame_predictionExpiredDoesNotTraceExpectedTimeline) { |
| 1375 | auto tracingSession = getTracingSessionForTest(); |
| 1376 | auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
| 1377 | |
| 1378 | tracingSession->StartBlocking(); |
| 1379 | int64_t displayFrameToken1 = mTokenManager->generateTokenForPredictions({10, 25, 30}); |
| 1380 | // Flush the token so that it would expire |
Adithya Srinivasan | bed4c4f | 2021-05-03 20:24:46 +0000 | [diff] [blame] | 1381 | flushTokens(); |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 1382 | |
Ady Abraham | 57a8ab4 | 2023-01-26 15:28:19 -0800 | [diff] [blame] | 1383 | // Add an empty surface frame so that display frame would get traced. |
| 1384 | addEmptySurfaceFrame(); |
| 1385 | |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 1386 | // Set up the display frame |
Pascal Muetschard | ac7bcd9 | 2023-10-03 15:05:36 +0200 | [diff] [blame] | 1387 | mFrameTimeline->setSfWakeUp(displayFrameToken1, 20, RR_11, RR_11); |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 1388 | mFrameTimeline->setSfPresent(26, presentFence1); |
| 1389 | presentFence1->signalForTest(31); |
| 1390 | |
| 1391 | int64_t traceCookie = snoopCurrentTraceCookie(); |
| 1392 | |
| 1393 | auto protoActualDisplayFrameStart = |
| 1394 | createProtoActualDisplayFrameStart(traceCookie + 1, displayFrameToken1, |
| 1395 | kSurfaceFlingerPid, |
| 1396 | FrameTimelineEvent::PRESENT_UNSPECIFIED, false, |
Adithya Srinivasan | 78e58af | 2021-02-25 00:08:08 +0000 | [diff] [blame] | 1397 | false, FrameTimelineEvent::JANK_UNKNOWN, |
Ying Wei | 96eb535 | 2023-11-21 17:37:21 +0000 | [diff] [blame] | 1398 | FrameTimelineEvent::SEVERITY_UNKNOWN, |
Adithya Srinivasan | 78e58af | 2021-02-25 00:08:08 +0000 | [diff] [blame] | 1399 | FrameTimelineEvent::PREDICTION_EXPIRED); |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 1400 | auto protoActualDisplayFrameEnd = createProtoFrameEnd(traceCookie + 1); |
| 1401 | |
| 1402 | addEmptyDisplayFrame(); |
| 1403 | flushTrace(); |
| 1404 | tracingSession->StopBlocking(); |
| 1405 | |
| 1406 | auto packets = readFrameTimelinePacketsBlocking(tracingSession.get()); |
| 1407 | // Only actual timeline packets should be in the trace |
| 1408 | EXPECT_EQ(packets.size(), 2u); |
| 1409 | |
| 1410 | // Packet - 0 : ActualDisplayFrameStart |
| 1411 | const auto& packet0 = packets[0]; |
| 1412 | ASSERT_TRUE(packet0.has_timestamp()); |
| 1413 | EXPECT_EQ(packet0.timestamp(), 20u); |
| 1414 | ASSERT_TRUE(packet0.has_frame_timeline_event()); |
| 1415 | |
| 1416 | const auto& event0 = packet0.frame_timeline_event(); |
| 1417 | ASSERT_TRUE(event0.has_actual_display_frame_start()); |
| 1418 | const auto& actualDisplayFrameStart = event0.actual_display_frame_start(); |
| 1419 | validateTraceEvent(actualDisplayFrameStart, protoActualDisplayFrameStart); |
| 1420 | |
| 1421 | // Packet - 1 : FrameEnd (ActualDisplayFrame) |
| 1422 | const auto& packet1 = packets[1]; |
| 1423 | ASSERT_TRUE(packet1.has_timestamp()); |
Adithya Srinivasan | 1a97163 | 2021-02-26 23:10:29 +0000 | [diff] [blame] | 1424 | EXPECT_EQ(packet1.timestamp(), 31u); |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 1425 | ASSERT_TRUE(packet1.has_frame_timeline_event()); |
| 1426 | |
| 1427 | const auto& event1 = packet1.frame_timeline_event(); |
| 1428 | ASSERT_TRUE(event1.has_frame_end()); |
| 1429 | const auto& actualDisplayFrameEnd = event1.frame_end(); |
| 1430 | validateTraceEvent(actualDisplayFrameEnd, protoActualDisplayFrameEnd); |
| 1431 | } |
| 1432 | |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 1433 | TEST_F(FrameTimelineTest, traceSurfaceFrame_emitsValidTracePacket) { |
| 1434 | auto tracingSession = getTracingSessionForTest(); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1435 | // Layer specific increment |
Edgar Arriaga | 631e425 | 2023-03-02 02:11:24 +0000 | [diff] [blame] | 1436 | EXPECT_CALL(*mTimeStats, incrementJankyFrames(_)).Times(2); |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 1437 | auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
| 1438 | auto presentFence2 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
| 1439 | |
| 1440 | tracingSession->StartBlocking(); |
| 1441 | int64_t surfaceFrameToken = mTokenManager->generateTokenForPredictions({10, 25, 40}); |
| 1442 | int64_t displayFrameToken1 = mTokenManager->generateTokenForPredictions({30, 35, 40}); |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 1443 | |
Huihong Luo | 3bdef86 | 2022-03-03 11:57:19 -0800 | [diff] [blame] | 1444 | FrameTimelineInfo ftInfo; |
| 1445 | ftInfo.vsyncId = surfaceFrameToken; |
| 1446 | ftInfo.inputEventId = sInputEventId; |
| 1447 | |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 1448 | auto surfaceFrame1 = |
Huihong Luo | 3bdef86 | 2022-03-03 11:57:19 -0800 | [diff] [blame] | 1449 | mFrameTimeline->createSurfaceFrameForToken(ftInfo, sPidOne, sUidOne, sLayerIdOne, |
| 1450 | sLayerNameOne, sLayerNameOne, |
| 1451 | /*isBuffer*/ true, sGameMode); |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 1452 | auto surfaceFrame2 = |
Huihong Luo | 3bdef86 | 2022-03-03 11:57:19 -0800 | [diff] [blame] | 1453 | mFrameTimeline->createSurfaceFrameForToken(ftInfo, sPidOne, sUidOne, sLayerIdOne, |
| 1454 | sLayerNameOne, sLayerNameOne, |
| 1455 | /*isBuffer*/ true, sGameMode); |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 1456 | surfaceFrame1->setActualQueueTime(10); |
| 1457 | surfaceFrame1->setDropTime(15); |
| 1458 | |
| 1459 | surfaceFrame2->setActualQueueTime(15); |
| 1460 | surfaceFrame2->setAcquireFenceTime(20); |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 1461 | |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 1462 | // First 2 cookies will be used by the DisplayFrame |
| 1463 | int64_t traceCookie = snoopCurrentTraceCookie() + 2; |
| 1464 | |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 1465 | auto protoDroppedSurfaceFrameExpectedStart = |
| 1466 | createProtoExpectedSurfaceFrameStart(traceCookie + 1, surfaceFrameToken, |
| 1467 | displayFrameToken1, sPidOne, sLayerNameOne); |
| 1468 | auto protoDroppedSurfaceFrameExpectedEnd = createProtoFrameEnd(traceCookie + 1); |
| 1469 | auto protoDroppedSurfaceFrameActualStart = |
| 1470 | createProtoActualSurfaceFrameStart(traceCookie + 2, surfaceFrameToken, |
| 1471 | displayFrameToken1, sPidOne, sLayerNameOne, |
Edgar Arriaga | 631e425 | 2023-03-02 02:11:24 +0000 | [diff] [blame] | 1472 | FrameTimelineEvent::PRESENT_DROPPED, true, false, |
| 1473 | FrameTimelineEvent::JANK_DROPPED, |
Ying Wei | 96eb535 | 2023-11-21 17:37:21 +0000 | [diff] [blame] | 1474 | FrameTimelineEvent::SEVERITY_UNKNOWN, |
Adithya Srinivasan | 1f9450c | 2021-06-10 22:39:19 +0000 | [diff] [blame] | 1475 | FrameTimelineEvent::PREDICTION_VALID, true); |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 1476 | auto protoDroppedSurfaceFrameActualEnd = createProtoFrameEnd(traceCookie + 2); |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 1477 | |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 1478 | auto protoPresentedSurfaceFrameExpectedStart = |
| 1479 | createProtoExpectedSurfaceFrameStart(traceCookie + 3, surfaceFrameToken, |
| 1480 | displayFrameToken1, sPidOne, sLayerNameOne); |
| 1481 | auto protoPresentedSurfaceFrameExpectedEnd = createProtoFrameEnd(traceCookie + 3); |
| 1482 | auto protoPresentedSurfaceFrameActualStart = |
| 1483 | createProtoActualSurfaceFrameStart(traceCookie + 4, surfaceFrameToken, |
| 1484 | displayFrameToken1, sPidOne, sLayerNameOne, |
| 1485 | FrameTimelineEvent::PRESENT_ON_TIME, true, false, |
Adithya Srinivasan | 78e58af | 2021-02-25 00:08:08 +0000 | [diff] [blame] | 1486 | FrameTimelineEvent::JANK_NONE, |
Ying Wei | 96eb535 | 2023-11-21 17:37:21 +0000 | [diff] [blame] | 1487 | FrameTimelineEvent::SEVERITY_NONE, |
Adithya Srinivasan | 1f9450c | 2021-06-10 22:39:19 +0000 | [diff] [blame] | 1488 | FrameTimelineEvent::PREDICTION_VALID, true); |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 1489 | auto protoPresentedSurfaceFrameActualEnd = createProtoFrameEnd(traceCookie + 4); |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 1490 | |
| 1491 | // Set up the display frame |
Pascal Muetschard | ac7bcd9 | 2023-10-03 15:05:36 +0200 | [diff] [blame] | 1492 | mFrameTimeline->setSfWakeUp(displayFrameToken1, 20, RR_11, RR_11); |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 1493 | surfaceFrame1->setPresentState(SurfaceFrame::PresentState::Dropped); |
| 1494 | surfaceFrame2->setPresentState(SurfaceFrame::PresentState::Presented); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1495 | mFrameTimeline->addSurfaceFrame(surfaceFrame1); |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 1496 | mFrameTimeline->addSurfaceFrame(surfaceFrame2); |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 1497 | mFrameTimeline->setSfPresent(26, presentFence1); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1498 | presentFence1->signalForTest(40); |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 1499 | |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 1500 | addEmptyDisplayFrame(); |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 1501 | flushTrace(); |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 1502 | tracingSession->StopBlocking(); |
| 1503 | |
| 1504 | auto packets = readFrameTimelinePacketsBlocking(tracingSession.get()); |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 1505 | // 4 DisplayFrame + 4 DroppedSurfaceFrame + 4 PresentedSurfaceFrame |
| 1506 | EXPECT_EQ(packets.size(), 12u); |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 1507 | |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 1508 | // Packet - 4 : ExpectedSurfaceFrameStart1 |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 1509 | const auto& packet4 = packets[4]; |
| 1510 | ASSERT_TRUE(packet4.has_timestamp()); |
Siarhei Vishniakou | fc434ac | 2021-01-13 10:28:00 -1000 | [diff] [blame] | 1511 | EXPECT_EQ(packet4.timestamp(), 10u); |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 1512 | ASSERT_TRUE(packet4.has_frame_timeline_event()); |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 1513 | |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 1514 | const auto& event4 = packet4.frame_timeline_event(); |
| 1515 | ASSERT_TRUE(event4.has_expected_surface_frame_start()); |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 1516 | const auto& expectedSurfaceFrameStart1 = event4.expected_surface_frame_start(); |
| 1517 | validateTraceEvent(expectedSurfaceFrameStart1, protoDroppedSurfaceFrameExpectedStart); |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 1518 | |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 1519 | // Packet - 5 : FrameEnd (ExpectedSurfaceFrame1) |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 1520 | const auto& packet5 = packets[5]; |
| 1521 | ASSERT_TRUE(packet5.has_timestamp()); |
Siarhei Vishniakou | fc434ac | 2021-01-13 10:28:00 -1000 | [diff] [blame] | 1522 | EXPECT_EQ(packet5.timestamp(), 25u); |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 1523 | ASSERT_TRUE(packet5.has_frame_timeline_event()); |
| 1524 | |
| 1525 | const auto& event5 = packet5.frame_timeline_event(); |
| 1526 | ASSERT_TRUE(event5.has_frame_end()); |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 1527 | const auto& expectedSurfaceFrameEnd1 = event5.frame_end(); |
| 1528 | validateTraceEvent(expectedSurfaceFrameEnd1, protoDroppedSurfaceFrameExpectedEnd); |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 1529 | |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 1530 | // Packet - 6 : ActualSurfaceFrameStart1 |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 1531 | const auto& packet6 = packets[6]; |
| 1532 | ASSERT_TRUE(packet6.has_timestamp()); |
Siarhei Vishniakou | fc434ac | 2021-01-13 10:28:00 -1000 | [diff] [blame] | 1533 | EXPECT_EQ(packet6.timestamp(), 10u); |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 1534 | ASSERT_TRUE(packet6.has_frame_timeline_event()); |
| 1535 | |
| 1536 | const auto& event6 = packet6.frame_timeline_event(); |
| 1537 | ASSERT_TRUE(event6.has_actual_surface_frame_start()); |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 1538 | const auto& actualSurfaceFrameStart1 = event6.actual_surface_frame_start(); |
| 1539 | validateTraceEvent(actualSurfaceFrameStart1, protoDroppedSurfaceFrameActualStart); |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 1540 | |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 1541 | // Packet - 7 : FrameEnd (ActualSurfaceFrame1) |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 1542 | const auto& packet7 = packets[7]; |
| 1543 | ASSERT_TRUE(packet7.has_timestamp()); |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 1544 | EXPECT_EQ(packet7.timestamp(), 15u); |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 1545 | ASSERT_TRUE(packet7.has_frame_timeline_event()); |
| 1546 | |
| 1547 | const auto& event7 = packet7.frame_timeline_event(); |
| 1548 | ASSERT_TRUE(event7.has_frame_end()); |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 1549 | const auto& actualSurfaceFrameEnd1 = event7.frame_end(); |
| 1550 | validateTraceEvent(actualSurfaceFrameEnd1, protoDroppedSurfaceFrameActualEnd); |
| 1551 | |
| 1552 | // Packet - 8 : ExpectedSurfaceFrameStart2 |
| 1553 | const auto& packet8 = packets[8]; |
| 1554 | ASSERT_TRUE(packet8.has_timestamp()); |
| 1555 | EXPECT_EQ(packet8.timestamp(), 10u); |
| 1556 | ASSERT_TRUE(packet8.has_frame_timeline_event()); |
| 1557 | |
| 1558 | const auto& event8 = packet8.frame_timeline_event(); |
| 1559 | ASSERT_TRUE(event8.has_expected_surface_frame_start()); |
| 1560 | const auto& expectedSurfaceFrameStart2 = event8.expected_surface_frame_start(); |
| 1561 | validateTraceEvent(expectedSurfaceFrameStart2, protoPresentedSurfaceFrameExpectedStart); |
| 1562 | |
| 1563 | // Packet - 9 : FrameEnd (ExpectedSurfaceFrame2) |
| 1564 | const auto& packet9 = packets[9]; |
| 1565 | ASSERT_TRUE(packet9.has_timestamp()); |
| 1566 | EXPECT_EQ(packet9.timestamp(), 25u); |
| 1567 | ASSERT_TRUE(packet9.has_frame_timeline_event()); |
| 1568 | |
| 1569 | const auto& event9 = packet9.frame_timeline_event(); |
| 1570 | ASSERT_TRUE(event9.has_frame_end()); |
| 1571 | const auto& expectedSurfaceFrameEnd2 = event9.frame_end(); |
| 1572 | validateTraceEvent(expectedSurfaceFrameEnd2, protoPresentedSurfaceFrameExpectedEnd); |
| 1573 | |
| 1574 | // Packet - 10 : ActualSurfaceFrameStart2 |
| 1575 | const auto& packet10 = packets[10]; |
| 1576 | ASSERT_TRUE(packet10.has_timestamp()); |
| 1577 | EXPECT_EQ(packet10.timestamp(), 10u); |
| 1578 | ASSERT_TRUE(packet10.has_frame_timeline_event()); |
| 1579 | |
| 1580 | const auto& event10 = packet10.frame_timeline_event(); |
| 1581 | ASSERT_TRUE(event10.has_actual_surface_frame_start()); |
| 1582 | const auto& actualSurfaceFrameStart2 = event10.actual_surface_frame_start(); |
| 1583 | validateTraceEvent(actualSurfaceFrameStart2, protoPresentedSurfaceFrameActualStart); |
| 1584 | |
| 1585 | // Packet - 11 : FrameEnd (ActualSurfaceFrame2) |
| 1586 | const auto& packet11 = packets[11]; |
| 1587 | ASSERT_TRUE(packet11.has_timestamp()); |
| 1588 | EXPECT_EQ(packet11.timestamp(), 20u); |
| 1589 | ASSERT_TRUE(packet11.has_frame_timeline_event()); |
| 1590 | |
| 1591 | const auto& event11 = packet11.frame_timeline_event(); |
| 1592 | ASSERT_TRUE(event11.has_frame_end()); |
| 1593 | const auto& actualSurfaceFrameEnd2 = event11.frame_end(); |
| 1594 | validateTraceEvent(actualSurfaceFrameEnd2, protoPresentedSurfaceFrameActualEnd); |
| 1595 | } |
| 1596 | |
Ady Abraham | e43ff72 | 2022-02-15 14:44:25 -0800 | [diff] [blame] | 1597 | TEST_F(FrameTimelineTest, traceSurfaceFrame_predictionExpiredIsAppMissedDeadline) { |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 1598 | auto tracingSession = getTracingSessionForTest(); |
| 1599 | auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
| 1600 | |
| 1601 | tracingSession->StartBlocking(); |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 1602 | constexpr nsecs_t appStartTime = std::chrono::nanoseconds(10ms).count(); |
| 1603 | constexpr nsecs_t appEndTime = std::chrono::nanoseconds(20ms).count(); |
| 1604 | constexpr nsecs_t appPresentTime = std::chrono::nanoseconds(30ms).count(); |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 1605 | int64_t surfaceFrameToken = |
| 1606 | mTokenManager->generateTokenForPredictions({appStartTime, appEndTime, appPresentTime}); |
| 1607 | |
| 1608 | // Flush the token so that it would expire |
Adithya Srinivasan | bed4c4f | 2021-05-03 20:24:46 +0000 | [diff] [blame] | 1609 | flushTokens(); |
Huihong Luo | 3bdef86 | 2022-03-03 11:57:19 -0800 | [diff] [blame] | 1610 | FrameTimelineInfo ftInfo; |
| 1611 | ftInfo.vsyncId = surfaceFrameToken; |
| 1612 | ftInfo.inputEventId = 0; |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 1613 | auto surfaceFrame1 = |
Huihong Luo | 3bdef86 | 2022-03-03 11:57:19 -0800 | [diff] [blame] | 1614 | mFrameTimeline->createSurfaceFrameForToken(ftInfo, sPidOne, sUidOne, sLayerIdOne, |
| 1615 | sLayerNameOne, sLayerNameOne, |
| 1616 | /*isBuffer*/ true, sGameMode); |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 1617 | surfaceFrame1->setActualQueueTime(appEndTime); |
| 1618 | surfaceFrame1->setAcquireFenceTime(appEndTime); |
| 1619 | |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 1620 | constexpr nsecs_t sfStartTime = std::chrono::nanoseconds(20ms).count(); |
| 1621 | constexpr nsecs_t sfEndTime = std::chrono::nanoseconds(30ms).count(); |
| 1622 | constexpr nsecs_t sfPresentTime = std::chrono::nanoseconds(30ms).count(); |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 1623 | int64_t displayFrameToken = |
| 1624 | mTokenManager->generateTokenForPredictions({sfStartTime, sfEndTime, sfPresentTime}); |
| 1625 | |
| 1626 | // First 2 cookies will be used by the DisplayFrame |
| 1627 | int64_t traceCookie = snoopCurrentTraceCookie() + 2; |
| 1628 | |
| 1629 | auto protoActualSurfaceFrameStart = |
| 1630 | createProtoActualSurfaceFrameStart(traceCookie + 1, surfaceFrameToken, |
| 1631 | displayFrameToken, sPidOne, sLayerNameOne, |
| 1632 | FrameTimelineEvent::PRESENT_UNSPECIFIED, false, |
Ady Abraham | e43ff72 | 2022-02-15 14:44:25 -0800 | [diff] [blame] | 1633 | false, FrameTimelineEvent::JANK_APP_DEADLINE_MISSED, |
Ying Wei | 96eb535 | 2023-11-21 17:37:21 +0000 | [diff] [blame] | 1634 | FrameTimelineEvent::SEVERITY_UNKNOWN, |
Adithya Srinivasan | 1f9450c | 2021-06-10 22:39:19 +0000 | [diff] [blame] | 1635 | FrameTimelineEvent::PREDICTION_EXPIRED, true); |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 1636 | auto protoActualSurfaceFrameEnd = createProtoFrameEnd(traceCookie + 1); |
| 1637 | |
| 1638 | // Set up the display frame |
Pascal Muetschard | ac7bcd9 | 2023-10-03 15:05:36 +0200 | [diff] [blame] | 1639 | mFrameTimeline->setSfWakeUp(displayFrameToken, sfStartTime, RR_11, RR_11); |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 1640 | surfaceFrame1->setPresentState(SurfaceFrame::PresentState::Presented); |
| 1641 | mFrameTimeline->addSurfaceFrame(surfaceFrame1); |
| 1642 | mFrameTimeline->setSfPresent(sfEndTime, presentFence1); |
| 1643 | presentFence1->signalForTest(sfPresentTime); |
| 1644 | |
| 1645 | addEmptyDisplayFrame(); |
| 1646 | flushTrace(); |
| 1647 | tracingSession->StopBlocking(); |
| 1648 | |
| 1649 | auto packets = readFrameTimelinePacketsBlocking(tracingSession.get()); |
| 1650 | // Display Frame 4 packets + SurfaceFrame 2 packets |
| 1651 | ASSERT_EQ(packets.size(), 6u); |
| 1652 | |
| 1653 | // Packet - 4 : ActualSurfaceFrameStart |
| 1654 | const auto& packet4 = packets[4]; |
| 1655 | ASSERT_TRUE(packet4.has_timestamp()); |
| 1656 | EXPECT_EQ(packet4.timestamp(), |
| 1657 | static_cast<uint64_t>(appEndTime - SurfaceFrame::kPredictionExpiredStartTimeDelta)); |
| 1658 | ASSERT_TRUE(packet4.has_frame_timeline_event()); |
| 1659 | |
| 1660 | const auto& event4 = packet4.frame_timeline_event(); |
| 1661 | ASSERT_TRUE(event4.has_actual_surface_frame_start()); |
| 1662 | const auto& actualSurfaceFrameStart = event4.actual_surface_frame_start(); |
| 1663 | validateTraceEvent(actualSurfaceFrameStart, protoActualSurfaceFrameStart); |
| 1664 | |
| 1665 | // Packet - 5 : FrameEnd (ActualSurfaceFrame) |
| 1666 | const auto& packet5 = packets[5]; |
| 1667 | ASSERT_TRUE(packet5.has_timestamp()); |
| 1668 | EXPECT_EQ(packet5.timestamp(), static_cast<uint64_t>(appEndTime)); |
| 1669 | ASSERT_TRUE(packet5.has_frame_timeline_event()); |
| 1670 | |
| 1671 | const auto& event5 = packet5.frame_timeline_event(); |
| 1672 | ASSERT_TRUE(event5.has_frame_end()); |
| 1673 | const auto& actualSurfaceFrameEnd = event5.frame_end(); |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 1674 | validateTraceEvent(actualSurfaceFrameEnd, protoActualSurfaceFrameEnd); |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 1675 | } |
| 1676 | |
Adithya Srinivasan | b2283c3 | 2021-04-21 21:31:56 +0000 | [diff] [blame] | 1677 | TEST_F(FrameTimelineTest, traceSurfaceFrame_predictionExpiredDroppedFramesTracedProperly) { |
| 1678 | auto tracingSession = getTracingSessionForTest(); |
| 1679 | auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
| 1680 | |
| 1681 | tracingSession->StartBlocking(); |
| 1682 | constexpr nsecs_t appStartTime = std::chrono::nanoseconds(10ms).count(); |
| 1683 | constexpr nsecs_t appEndTime = std::chrono::nanoseconds(20ms).count(); |
| 1684 | constexpr nsecs_t appPresentTime = std::chrono::nanoseconds(30ms).count(); |
| 1685 | int64_t surfaceFrameToken = |
| 1686 | mTokenManager->generateTokenForPredictions({appStartTime, appEndTime, appPresentTime}); |
| 1687 | |
| 1688 | // Flush the token so that it would expire |
Adithya Srinivasan | bed4c4f | 2021-05-03 20:24:46 +0000 | [diff] [blame] | 1689 | flushTokens(); |
Huihong Luo | 3bdef86 | 2022-03-03 11:57:19 -0800 | [diff] [blame] | 1690 | FrameTimelineInfo ftInfo; |
| 1691 | ftInfo.vsyncId = surfaceFrameToken; |
| 1692 | ftInfo.inputEventId = 0; |
Adithya Srinivasan | b2283c3 | 2021-04-21 21:31:56 +0000 | [diff] [blame] | 1693 | auto surfaceFrame1 = |
Huihong Luo | 3bdef86 | 2022-03-03 11:57:19 -0800 | [diff] [blame] | 1694 | mFrameTimeline->createSurfaceFrameForToken(ftInfo, sPidOne, sUidOne, sLayerIdOne, |
| 1695 | sLayerNameOne, sLayerNameOne, |
| 1696 | /*isBuffer*/ true, sGameMode); |
Adithya Srinivasan | b2283c3 | 2021-04-21 21:31:56 +0000 | [diff] [blame] | 1697 | |
| 1698 | constexpr nsecs_t sfStartTime = std::chrono::nanoseconds(22ms).count(); |
| 1699 | constexpr nsecs_t sfEndTime = std::chrono::nanoseconds(30ms).count(); |
| 1700 | constexpr nsecs_t sfPresentTime = std::chrono::nanoseconds(30ms).count(); |
| 1701 | int64_t displayFrameToken = |
| 1702 | mTokenManager->generateTokenForPredictions({sfStartTime, sfEndTime, sfPresentTime}); |
| 1703 | |
| 1704 | // First 2 cookies will be used by the DisplayFrame |
| 1705 | int64_t traceCookie = snoopCurrentTraceCookie() + 2; |
| 1706 | |
| 1707 | auto protoActualSurfaceFrameStart = |
| 1708 | createProtoActualSurfaceFrameStart(traceCookie + 1, surfaceFrameToken, |
| 1709 | displayFrameToken, sPidOne, sLayerNameOne, |
| 1710 | FrameTimelineEvent::PRESENT_DROPPED, false, false, |
Edgar Arriaga | 631e425 | 2023-03-02 02:11:24 +0000 | [diff] [blame] | 1711 | FrameTimelineEvent::JANK_DROPPED, |
Ying Wei | 96eb535 | 2023-11-21 17:37:21 +0000 | [diff] [blame] | 1712 | FrameTimelineEvent::SEVERITY_UNKNOWN, |
Adithya Srinivasan | 1f9450c | 2021-06-10 22:39:19 +0000 | [diff] [blame] | 1713 | FrameTimelineEvent::PREDICTION_EXPIRED, true); |
Adithya Srinivasan | b2283c3 | 2021-04-21 21:31:56 +0000 | [diff] [blame] | 1714 | auto protoActualSurfaceFrameEnd = createProtoFrameEnd(traceCookie + 1); |
| 1715 | |
| 1716 | // Set up the display frame |
Pascal Muetschard | ac7bcd9 | 2023-10-03 15:05:36 +0200 | [diff] [blame] | 1717 | mFrameTimeline->setSfWakeUp(displayFrameToken, sfStartTime, RR_11, RR_11); |
Adithya Srinivasan | b2283c3 | 2021-04-21 21:31:56 +0000 | [diff] [blame] | 1718 | surfaceFrame1->setDropTime(sfStartTime); |
| 1719 | surfaceFrame1->setPresentState(SurfaceFrame::PresentState::Dropped); |
| 1720 | mFrameTimeline->addSurfaceFrame(surfaceFrame1); |
| 1721 | mFrameTimeline->setSfPresent(sfEndTime, presentFence1); |
| 1722 | presentFence1->signalForTest(sfPresentTime); |
| 1723 | |
| 1724 | addEmptyDisplayFrame(); |
| 1725 | flushTrace(); |
| 1726 | tracingSession->StopBlocking(); |
| 1727 | |
| 1728 | auto packets = readFrameTimelinePacketsBlocking(tracingSession.get()); |
| 1729 | // Display Frame 4 packets + SurfaceFrame 2 packets |
| 1730 | ASSERT_EQ(packets.size(), 6u); |
| 1731 | |
| 1732 | // Packet - 4 : ActualSurfaceFrameStart |
| 1733 | const auto& packet4 = packets[4]; |
| 1734 | ASSERT_TRUE(packet4.has_timestamp()); |
| 1735 | EXPECT_EQ(packet4.timestamp(), |
| 1736 | static_cast<uint64_t>(sfStartTime - SurfaceFrame::kPredictionExpiredStartTimeDelta)); |
| 1737 | ASSERT_TRUE(packet4.has_frame_timeline_event()); |
| 1738 | |
| 1739 | const auto& event4 = packet4.frame_timeline_event(); |
| 1740 | ASSERT_TRUE(event4.has_actual_surface_frame_start()); |
| 1741 | const auto& actualSurfaceFrameStart = event4.actual_surface_frame_start(); |
| 1742 | validateTraceEvent(actualSurfaceFrameStart, protoActualSurfaceFrameStart); |
| 1743 | |
| 1744 | // Packet - 5 : FrameEnd (ActualSurfaceFrame) |
| 1745 | const auto& packet5 = packets[5]; |
| 1746 | ASSERT_TRUE(packet5.has_timestamp()); |
| 1747 | EXPECT_EQ(packet5.timestamp(), static_cast<uint64_t>(sfStartTime)); |
| 1748 | ASSERT_TRUE(packet5.has_frame_timeline_event()); |
| 1749 | |
| 1750 | const auto& event5 = packet5.frame_timeline_event(); |
| 1751 | ASSERT_TRUE(event5.has_frame_end()); |
| 1752 | const auto& actualSurfaceFrameEnd = event5.frame_end(); |
| 1753 | validateTraceEvent(actualSurfaceFrameEnd, protoActualSurfaceFrameEnd); |
| 1754 | } |
| 1755 | |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1756 | // Tests for Jank classification |
| 1757 | TEST_F(FrameTimelineTest, jankClassification_presentOnTimeDoesNotClassify) { |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1758 | // Layer specific increment |
Alec Mouri | 363faf0 | 2021-01-29 16:34:55 -0800 | [diff] [blame] | 1759 | EXPECT_CALL(*mTimeStats, incrementJankyFrames(_)); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1760 | auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
| 1761 | int64_t surfaceFrameToken = mTokenManager->generateTokenForPredictions({10, 20, 30}); |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 1762 | int64_t sfToken1 = mTokenManager->generateTokenForPredictions({22, 30, 30}); |
Huihong Luo | 3bdef86 | 2022-03-03 11:57:19 -0800 | [diff] [blame] | 1763 | FrameTimelineInfo ftInfo; |
| 1764 | ftInfo.vsyncId = surfaceFrameToken; |
| 1765 | ftInfo.inputEventId = sInputEventId; |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1766 | auto surfaceFrame = |
Huihong Luo | 3bdef86 | 2022-03-03 11:57:19 -0800 | [diff] [blame] | 1767 | mFrameTimeline->createSurfaceFrameForToken(ftInfo, sPidOne, sUidOne, sLayerIdOne, |
| 1768 | sLayerNameOne, sLayerNameOne, |
| 1769 | /*isBuffer*/ true, sGameMode); |
Pascal Muetschard | ac7bcd9 | 2023-10-03 15:05:36 +0200 | [diff] [blame] | 1770 | mFrameTimeline->setSfWakeUp(sfToken1, 22, RR_11, RR_11); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1771 | surfaceFrame->setPresentState(SurfaceFrame::PresentState::Presented); |
| 1772 | mFrameTimeline->addSurfaceFrame(surfaceFrame); |
| 1773 | mFrameTimeline->setSfPresent(26, presentFence1); |
| 1774 | auto displayFrame = getDisplayFrame(0); |
| 1775 | auto& presentedSurfaceFrame = getSurfaceFrame(0, 0); |
| 1776 | presentFence1->signalForTest(29); |
| 1777 | |
| 1778 | // Fences haven't been flushed yet, so it should be 0 |
| 1779 | EXPECT_EQ(displayFrame->getActuals().presentTime, 0); |
| 1780 | EXPECT_EQ(presentedSurfaceFrame.getActuals().presentTime, 0); |
| 1781 | |
| 1782 | addEmptyDisplayFrame(); |
| 1783 | displayFrame = getDisplayFrame(0); |
| 1784 | |
| 1785 | // Fences have flushed, so the present timestamps should be updated |
| 1786 | EXPECT_EQ(displayFrame->getActuals().presentTime, 29); |
| 1787 | EXPECT_EQ(presentedSurfaceFrame.getActuals().presentTime, 29); |
| 1788 | EXPECT_EQ(displayFrame->getFramePresentMetadata(), FramePresentMetadata::OnTimePresent); |
| 1789 | EXPECT_EQ(displayFrame->getFrameReadyMetadata(), FrameReadyMetadata::OnTimeFinish); |
| 1790 | EXPECT_EQ(displayFrame->getJankType(), JankType::None); |
Ying Wei | 96eb535 | 2023-11-21 17:37:21 +0000 | [diff] [blame] | 1791 | EXPECT_EQ(displayFrame->getJankSeverityType(), JankSeverityType::None); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1792 | } |
| 1793 | |
| 1794 | TEST_F(FrameTimelineTest, jankClassification_displayFrameOnTimeFinishEarlyPresent) { |
Pascal Muetschard | ac7bcd9 | 2023-10-03 15:05:36 +0200 | [diff] [blame] | 1795 | Fps vsyncRate = RR_11; |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1796 | auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 1797 | int64_t sfToken1 = mTokenManager->generateTokenForPredictions({22, 30, 40}); |
| 1798 | int64_t sfToken2 = mTokenManager->generateTokenForPredictions({52, 60, 70}); |
Pascal Muetschard | ac7bcd9 | 2023-10-03 15:05:36 +0200 | [diff] [blame] | 1799 | mFrameTimeline->setSfWakeUp(sfToken1, 22, vsyncRate, vsyncRate); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1800 | mFrameTimeline->setSfPresent(26, presentFence1); |
| 1801 | auto displayFrame = getDisplayFrame(0); |
| 1802 | presentFence1->signalForTest(30); |
| 1803 | |
| 1804 | // Fences for the first frame haven't been flushed yet, so it should be 0 |
| 1805 | EXPECT_EQ(displayFrame->getActuals().presentTime, 0); |
| 1806 | |
| 1807 | // Trigger a flush by finalizing the next DisplayFrame |
| 1808 | auto presentFence2 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
Pascal Muetschard | ac7bcd9 | 2023-10-03 15:05:36 +0200 | [diff] [blame] | 1809 | mFrameTimeline->setSfWakeUp(sfToken2, 52, vsyncRate, vsyncRate); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1810 | mFrameTimeline->setSfPresent(56, presentFence2); |
| 1811 | displayFrame = getDisplayFrame(0); |
| 1812 | |
| 1813 | // Fences for the first frame have flushed, so the present timestamps should be updated |
| 1814 | EXPECT_EQ(displayFrame->getActuals().presentTime, 30); |
| 1815 | EXPECT_EQ(displayFrame->getFramePresentMetadata(), FramePresentMetadata::EarlyPresent); |
| 1816 | EXPECT_EQ(displayFrame->getFrameReadyMetadata(), FrameReadyMetadata::OnTimeFinish); |
| 1817 | EXPECT_EQ(displayFrame->getJankType(), JankType::SurfaceFlingerScheduling); |
Ying Wei | 96eb535 | 2023-11-21 17:37:21 +0000 | [diff] [blame] | 1818 | EXPECT_EQ(displayFrame->getJankSeverityType(), JankSeverityType::Partial); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1819 | |
| 1820 | // Fences for the second frame haven't been flushed yet, so it should be 0 |
| 1821 | auto displayFrame2 = getDisplayFrame(1); |
| 1822 | presentFence2->signalForTest(65); |
| 1823 | EXPECT_EQ(displayFrame2->getActuals().presentTime, 0); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1824 | addEmptyDisplayFrame(); |
| 1825 | displayFrame2 = getDisplayFrame(1); |
| 1826 | |
| 1827 | // Fences for the second frame have flushed, so the present timestamps should be updated |
| 1828 | EXPECT_EQ(displayFrame2->getActuals().presentTime, 65); |
| 1829 | EXPECT_EQ(displayFrame2->getFramePresentMetadata(), FramePresentMetadata::EarlyPresent); |
| 1830 | EXPECT_EQ(displayFrame2->getFrameReadyMetadata(), FrameReadyMetadata::OnTimeFinish); |
| 1831 | EXPECT_EQ(displayFrame2->getJankType(), JankType::PredictionError); |
Ying Wei | 96eb535 | 2023-11-21 17:37:21 +0000 | [diff] [blame] | 1832 | EXPECT_EQ(displayFrame->getJankSeverityType(), JankSeverityType::Partial); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1833 | } |
| 1834 | |
| 1835 | TEST_F(FrameTimelineTest, jankClassification_displayFrameOnTimeFinishLatePresent) { |
Pascal Muetschard | ac7bcd9 | 2023-10-03 15:05:36 +0200 | [diff] [blame] | 1836 | Fps vsyncRate = RR_11; |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1837 | auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 1838 | int64_t sfToken1 = mTokenManager->generateTokenForPredictions({22, 30, 40}); |
| 1839 | int64_t sfToken2 = mTokenManager->generateTokenForPredictions({52, 60, 70}); |
Pascal Muetschard | ac7bcd9 | 2023-10-03 15:05:36 +0200 | [diff] [blame] | 1840 | mFrameTimeline->setSfWakeUp(sfToken1, 22, vsyncRate, vsyncRate); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1841 | mFrameTimeline->setSfPresent(26, presentFence1); |
| 1842 | auto displayFrame = getDisplayFrame(0); |
| 1843 | presentFence1->signalForTest(50); |
| 1844 | |
| 1845 | // Fences for the first frame haven't been flushed yet, so it should be 0 |
| 1846 | EXPECT_EQ(displayFrame->getActuals().presentTime, 0); |
| 1847 | |
| 1848 | // Trigger a flush by finalizing the next DisplayFrame |
| 1849 | auto presentFence2 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
Pascal Muetschard | ac7bcd9 | 2023-10-03 15:05:36 +0200 | [diff] [blame] | 1850 | mFrameTimeline->setSfWakeUp(sfToken2, 52, vsyncRate, vsyncRate); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1851 | mFrameTimeline->setSfPresent(56, presentFence2); |
| 1852 | displayFrame = getDisplayFrame(0); |
| 1853 | |
| 1854 | // Fences for the first frame have flushed, so the present timestamps should be updated |
| 1855 | EXPECT_EQ(displayFrame->getActuals().presentTime, 50); |
| 1856 | EXPECT_EQ(displayFrame->getFramePresentMetadata(), FramePresentMetadata::LatePresent); |
| 1857 | EXPECT_EQ(displayFrame->getFrameReadyMetadata(), FrameReadyMetadata::OnTimeFinish); |
| 1858 | EXPECT_EQ(displayFrame->getJankType(), JankType::DisplayHAL); |
Ying Wei | 96eb535 | 2023-11-21 17:37:21 +0000 | [diff] [blame] | 1859 | EXPECT_EQ(displayFrame->getJankSeverityType(), JankSeverityType::Partial); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1860 | |
| 1861 | // Fences for the second frame haven't been flushed yet, so it should be 0 |
| 1862 | auto displayFrame2 = getDisplayFrame(1); |
| 1863 | presentFence2->signalForTest(75); |
| 1864 | EXPECT_EQ(displayFrame2->getActuals().presentTime, 0); |
| 1865 | |
| 1866 | addEmptyDisplayFrame(); |
| 1867 | displayFrame2 = getDisplayFrame(1); |
| 1868 | |
| 1869 | // Fences for the second frame have flushed, so the present timestamps should be updated |
| 1870 | EXPECT_EQ(displayFrame2->getActuals().presentTime, 75); |
| 1871 | EXPECT_EQ(displayFrame2->getFramePresentMetadata(), FramePresentMetadata::LatePresent); |
| 1872 | EXPECT_EQ(displayFrame2->getFrameReadyMetadata(), FrameReadyMetadata::OnTimeFinish); |
| 1873 | EXPECT_EQ(displayFrame2->getJankType(), JankType::PredictionError); |
Ying Wei | 96eb535 | 2023-11-21 17:37:21 +0000 | [diff] [blame] | 1874 | EXPECT_EQ(displayFrame->getJankSeverityType(), JankSeverityType::Partial); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1875 | } |
| 1876 | |
| 1877 | TEST_F(FrameTimelineTest, jankClassification_displayFrameLateFinishEarlyPresent) { |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1878 | auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
| 1879 | int64_t sfToken1 = mTokenManager->generateTokenForPredictions({12, 18, 40}); |
Pascal Muetschard | ac7bcd9 | 2023-10-03 15:05:36 +0200 | [diff] [blame] | 1880 | mFrameTimeline->setSfWakeUp(sfToken1, 12, RR_11, RR_11); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1881 | |
| 1882 | mFrameTimeline->setSfPresent(22, presentFence1); |
| 1883 | auto displayFrame = getDisplayFrame(0); |
| 1884 | presentFence1->signalForTest(28); |
| 1885 | |
| 1886 | // Fences haven't been flushed yet, so it should be 0 |
| 1887 | EXPECT_EQ(displayFrame->getActuals().presentTime, 0); |
| 1888 | |
| 1889 | addEmptyDisplayFrame(); |
| 1890 | displayFrame = getDisplayFrame(0); |
| 1891 | |
| 1892 | // Fences have flushed, so the present timestamps should be updated |
| 1893 | EXPECT_EQ(displayFrame->getActuals().presentTime, 28); |
| 1894 | EXPECT_EQ(displayFrame->getFramePresentMetadata(), FramePresentMetadata::EarlyPresent); |
| 1895 | EXPECT_EQ(displayFrame->getFrameReadyMetadata(), FrameReadyMetadata::LateFinish); |
| 1896 | EXPECT_EQ(displayFrame->getJankType(), JankType::SurfaceFlingerScheduling); |
Ying Wei | 96eb535 | 2023-11-21 17:37:21 +0000 | [diff] [blame] | 1897 | EXPECT_EQ(displayFrame->getJankSeverityType(), JankSeverityType::Full); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1898 | } |
| 1899 | |
| 1900 | TEST_F(FrameTimelineTest, jankClassification_displayFrameLateFinishLatePresent) { |
Adithya Srinivasan | 36b01af | 2021-04-07 22:29:47 +0000 | [diff] [blame] | 1901 | /* |
| 1902 | * Case 1 - cpu time > vsync period but combined time > deadline > deadline -> cpudeadlinemissed |
| 1903 | * Case 2 - cpu time < vsync period but combined time > deadline -> gpudeadlinemissed |
Adithya Srinivasan | 57dc81d | 2021-04-14 17:31:41 +0000 | [diff] [blame] | 1904 | * Case 3 - previous frame ran longer -> sf_stuffing |
| 1905 | * Case 4 - Long cpu under SF stuffing -> cpudeadlinemissed |
Adithya Srinivasan | 36b01af | 2021-04-07 22:29:47 +0000 | [diff] [blame] | 1906 | */ |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1907 | auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
Adithya Srinivasan | 36b01af | 2021-04-07 22:29:47 +0000 | [diff] [blame] | 1908 | auto presentFence2 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
Adithya Srinivasan | 57dc81d | 2021-04-14 17:31:41 +0000 | [diff] [blame] | 1909 | auto presentFence3 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
| 1910 | auto presentFence4 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
Adithya Srinivasan | 36b01af | 2021-04-07 22:29:47 +0000 | [diff] [blame] | 1911 | auto gpuFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
| 1912 | auto gpuFence2 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
Adithya Srinivasan | 57dc81d | 2021-04-14 17:31:41 +0000 | [diff] [blame] | 1913 | auto gpuFence3 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
| 1914 | auto gpuFence4 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1915 | int64_t sfToken1 = mTokenManager->generateTokenForPredictions({22, 26, 40}); |
Adithya Srinivasan | 36b01af | 2021-04-07 22:29:47 +0000 | [diff] [blame] | 1916 | int64_t sfToken2 = mTokenManager->generateTokenForPredictions({52, 60, 60}); |
Adithya Srinivasan | 57dc81d | 2021-04-14 17:31:41 +0000 | [diff] [blame] | 1917 | int64_t sfToken3 = mTokenManager->generateTokenForPredictions({82, 90, 90}); |
| 1918 | int64_t sfToken4 = mTokenManager->generateTokenForPredictions({112, 120, 120}); |
| 1919 | |
Adithya Srinivasan | 36b01af | 2021-04-07 22:29:47 +0000 | [diff] [blame] | 1920 | // case 1 - cpu time = 33 - 12 = 21, vsync period = 11 |
Pascal Muetschard | ac7bcd9 | 2023-10-03 15:05:36 +0200 | [diff] [blame] | 1921 | mFrameTimeline->setSfWakeUp(sfToken1, 12, RR_11, RR_11); |
Adithya Srinivasan | 36b01af | 2021-04-07 22:29:47 +0000 | [diff] [blame] | 1922 | mFrameTimeline->setSfPresent(33, presentFence1, gpuFence1); |
| 1923 | auto displayFrame0 = getDisplayFrame(0); |
| 1924 | gpuFence1->signalForTest(36); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1925 | presentFence1->signalForTest(52); |
| 1926 | |
| 1927 | // Fences haven't been flushed yet, so it should be 0 |
Adithya Srinivasan | 36b01af | 2021-04-07 22:29:47 +0000 | [diff] [blame] | 1928 | EXPECT_EQ(displayFrame0->getActuals().presentTime, 0); |
| 1929 | |
Adithya Srinivasan | 57dc81d | 2021-04-14 17:31:41 +0000 | [diff] [blame] | 1930 | // case 2 - cpu time = 56 - 52 = 4, vsync period = 30 |
Pascal Muetschard | ac7bcd9 | 2023-10-03 15:05:36 +0200 | [diff] [blame] | 1931 | mFrameTimeline->setSfWakeUp(sfToken2, 52, RR_30, RR_30); |
Adithya Srinivasan | 36b01af | 2021-04-07 22:29:47 +0000 | [diff] [blame] | 1932 | mFrameTimeline->setSfPresent(56, presentFence2, gpuFence2); |
| 1933 | auto displayFrame1 = getDisplayFrame(1); |
Adithya Srinivasan | 57dc81d | 2021-04-14 17:31:41 +0000 | [diff] [blame] | 1934 | gpuFence2->signalForTest(76); |
| 1935 | presentFence2->signalForTest(90); |
Adithya Srinivasan | 36b01af | 2021-04-07 22:29:47 +0000 | [diff] [blame] | 1936 | |
| 1937 | EXPECT_EQ(displayFrame1->getActuals().presentTime, 0); |
| 1938 | // Fences have flushed for first displayFrame, so the present timestamps should be updated |
| 1939 | EXPECT_EQ(displayFrame0->getActuals().presentTime, 52); |
| 1940 | EXPECT_EQ(displayFrame0->getFramePresentMetadata(), FramePresentMetadata::LatePresent); |
| 1941 | EXPECT_EQ(displayFrame0->getFrameReadyMetadata(), FrameReadyMetadata::LateFinish); |
Rachel Lee | 94917b3 | 2022-03-18 17:52:09 -0700 | [diff] [blame] | 1942 | EXPECT_EQ(displayFrame0->getJankType(), JankType::SurfaceFlingerGpuDeadlineMissed); |
Ying Wei | 96eb535 | 2023-11-21 17:37:21 +0000 | [diff] [blame] | 1943 | EXPECT_EQ(displayFrame0->getJankSeverityType(), JankSeverityType::Full); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1944 | |
Adithya Srinivasan | 57dc81d | 2021-04-14 17:31:41 +0000 | [diff] [blame] | 1945 | // case 3 - cpu time = 86 - 82 = 4, vsync period = 30 |
Pascal Muetschard | ac7bcd9 | 2023-10-03 15:05:36 +0200 | [diff] [blame] | 1946 | mFrameTimeline->setSfWakeUp(sfToken3, 106, RR_30, RR_30); |
Adithya Srinivasan | 57dc81d | 2021-04-14 17:31:41 +0000 | [diff] [blame] | 1947 | mFrameTimeline->setSfPresent(112, presentFence3, gpuFence3); |
| 1948 | auto displayFrame2 = getDisplayFrame(2); |
| 1949 | gpuFence3->signalForTest(116); |
| 1950 | presentFence3->signalForTest(120); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1951 | |
Adithya Srinivasan | 57dc81d | 2021-04-14 17:31:41 +0000 | [diff] [blame] | 1952 | EXPECT_EQ(displayFrame2->getActuals().presentTime, 0); |
Adithya Srinivasan | 36b01af | 2021-04-07 22:29:47 +0000 | [diff] [blame] | 1953 | // Fences have flushed for second displayFrame, so the present timestamps should be updated |
Adithya Srinivasan | 57dc81d | 2021-04-14 17:31:41 +0000 | [diff] [blame] | 1954 | EXPECT_EQ(displayFrame1->getActuals().presentTime, 90); |
Adithya Srinivasan | 36b01af | 2021-04-07 22:29:47 +0000 | [diff] [blame] | 1955 | EXPECT_EQ(displayFrame1->getFramePresentMetadata(), FramePresentMetadata::LatePresent); |
| 1956 | EXPECT_EQ(displayFrame1->getFrameReadyMetadata(), FrameReadyMetadata::LateFinish); |
| 1957 | EXPECT_EQ(displayFrame1->getJankType(), JankType::SurfaceFlingerGpuDeadlineMissed); |
Ying Wei | 96eb535 | 2023-11-21 17:37:21 +0000 | [diff] [blame] | 1958 | EXPECT_EQ(displayFrame1->getJankSeverityType(), JankSeverityType::Full); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1959 | |
Adithya Srinivasan | 57dc81d | 2021-04-14 17:31:41 +0000 | [diff] [blame] | 1960 | // case 4 - cpu time = 86 - 82 = 4, vsync period = 30 |
Pascal Muetschard | ac7bcd9 | 2023-10-03 15:05:36 +0200 | [diff] [blame] | 1961 | mFrameTimeline->setSfWakeUp(sfToken4, 120, RR_30, RR_30); |
Adithya Srinivasan | 57dc81d | 2021-04-14 17:31:41 +0000 | [diff] [blame] | 1962 | mFrameTimeline->setSfPresent(140, presentFence4, gpuFence4); |
| 1963 | auto displayFrame3 = getDisplayFrame(3); |
| 1964 | gpuFence4->signalForTest(156); |
| 1965 | presentFence4->signalForTest(180); |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 1966 | |
Adithya Srinivasan | 57dc81d | 2021-04-14 17:31:41 +0000 | [diff] [blame] | 1967 | EXPECT_EQ(displayFrame3->getActuals().presentTime, 0); |
| 1968 | // Fences have flushed for third displayFrame, so the present timestamps should be updated |
| 1969 | EXPECT_EQ(displayFrame2->getActuals().presentTime, 120); |
| 1970 | EXPECT_EQ(displayFrame2->getFramePresentMetadata(), FramePresentMetadata::LatePresent); |
| 1971 | EXPECT_EQ(displayFrame2->getFrameReadyMetadata(), FrameReadyMetadata::LateFinish); |
| 1972 | EXPECT_EQ(displayFrame2->getJankType(), JankType::SurfaceFlingerStuffing); |
Ying Wei | 96eb535 | 2023-11-21 17:37:21 +0000 | [diff] [blame] | 1973 | EXPECT_EQ(displayFrame2->getJankSeverityType(), JankSeverityType::Full); |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 1974 | |
| 1975 | addEmptyDisplayFrame(); |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 1976 | |
Adithya Srinivasan | 57dc81d | 2021-04-14 17:31:41 +0000 | [diff] [blame] | 1977 | // Fences have flushed for third displayFrame, so the present timestamps should be updated |
| 1978 | EXPECT_EQ(displayFrame3->getActuals().presentTime, 180); |
| 1979 | EXPECT_EQ(displayFrame3->getFramePresentMetadata(), FramePresentMetadata::LatePresent); |
| 1980 | EXPECT_EQ(displayFrame3->getFrameReadyMetadata(), FrameReadyMetadata::LateFinish); |
| 1981 | EXPECT_EQ(displayFrame3->getJankType(), JankType::SurfaceFlingerGpuDeadlineMissed); |
Ying Wei | 96eb535 | 2023-11-21 17:37:21 +0000 | [diff] [blame] | 1982 | EXPECT_EQ(displayFrame3->getJankSeverityType(), JankSeverityType::Full); |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 1983 | } |
| 1984 | |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1985 | TEST_F(FrameTimelineTest, jankClassification_surfaceFrameOnTimeFinishEarlyPresent) { |
Alec Mouri | 363faf0 | 2021-01-29 16:34:55 -0800 | [diff] [blame] | 1986 | EXPECT_CALL(*mTimeStats, incrementJankyFrames(_)); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1987 | auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 1988 | int64_t sfToken1 = mTokenManager->generateTokenForPredictions({22, 30, 40}); |
| 1989 | int64_t sfToken2 = mTokenManager->generateTokenForPredictions({52, 60, 70}); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1990 | int64_t surfaceFrameToken1 = mTokenManager->generateTokenForPredictions({5, 16, 40}); |
| 1991 | int64_t surfaceFrameToken2 = mTokenManager->generateTokenForPredictions({25, 36, 70}); |
Huihong Luo | 3bdef86 | 2022-03-03 11:57:19 -0800 | [diff] [blame] | 1992 | FrameTimelineInfo ftInfo; |
| 1993 | ftInfo.vsyncId = surfaceFrameToken1; |
| 1994 | ftInfo.inputEventId = sInputEventId; |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1995 | auto surfaceFrame1 = |
Huihong Luo | 3bdef86 | 2022-03-03 11:57:19 -0800 | [diff] [blame] | 1996 | mFrameTimeline->createSurfaceFrameForToken(ftInfo, sPidOne, sUidOne, sLayerIdOne, |
| 1997 | sLayerNameOne, sLayerNameOne, |
| 1998 | /*isBuffer*/ true, sGameMode); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1999 | surfaceFrame1->setAcquireFenceTime(16); |
Pascal Muetschard | ac7bcd9 | 2023-10-03 15:05:36 +0200 | [diff] [blame] | 2000 | mFrameTimeline->setSfWakeUp(sfToken1, 22, RR_11, RR_11); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 2001 | surfaceFrame1->setPresentState(SurfaceFrame::PresentState::Presented); |
| 2002 | mFrameTimeline->addSurfaceFrame(surfaceFrame1); |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 2003 | mFrameTimeline->setSfPresent(27, presentFence1); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 2004 | auto displayFrame1 = getDisplayFrame(0); |
| 2005 | auto& presentedSurfaceFrame1 = getSurfaceFrame(0, 0); |
| 2006 | presentFence1->signalForTest(30); |
| 2007 | |
| 2008 | // Fences for the first frame haven't been flushed yet, so it should be 0 |
| 2009 | EXPECT_EQ(displayFrame1->getActuals().presentTime, 0); |
| 2010 | auto actuals1 = presentedSurfaceFrame1.getActuals(); |
| 2011 | EXPECT_EQ(actuals1.presentTime, 0); |
| 2012 | |
| 2013 | // Trigger a flush by finalizing the next DisplayFrame |
| 2014 | auto presentFence2 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
Huihong Luo | 3bdef86 | 2022-03-03 11:57:19 -0800 | [diff] [blame] | 2015 | FrameTimelineInfo ftInfo2; |
| 2016 | ftInfo2.vsyncId = surfaceFrameToken2; |
| 2017 | ftInfo2.inputEventId = sInputEventId; |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 2018 | auto surfaceFrame2 = |
Huihong Luo | 3bdef86 | 2022-03-03 11:57:19 -0800 | [diff] [blame] | 2019 | mFrameTimeline->createSurfaceFrameForToken(ftInfo2, sPidOne, sUidOne, sLayerIdOne, |
| 2020 | sLayerNameOne, sLayerNameOne, |
| 2021 | /*isBuffer*/ true, sGameMode); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 2022 | surfaceFrame2->setAcquireFenceTime(36); |
Pascal Muetschard | ac7bcd9 | 2023-10-03 15:05:36 +0200 | [diff] [blame] | 2023 | mFrameTimeline->setSfWakeUp(sfToken2, 52, RR_11, RR_11); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 2024 | surfaceFrame2->setPresentState(SurfaceFrame::PresentState::Presented); |
| 2025 | mFrameTimeline->addSurfaceFrame(surfaceFrame2); |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 2026 | mFrameTimeline->setSfPresent(57, presentFence2); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 2027 | auto displayFrame2 = getDisplayFrame(1); |
| 2028 | auto& presentedSurfaceFrame2 = getSurfaceFrame(1, 0); |
| 2029 | |
| 2030 | // Fences for the first frame have flushed, so the present timestamps should be updated |
| 2031 | EXPECT_EQ(displayFrame1->getActuals().presentTime, 30); |
| 2032 | EXPECT_EQ(displayFrame1->getFramePresentMetadata(), FramePresentMetadata::EarlyPresent); |
| 2033 | EXPECT_EQ(displayFrame1->getFrameReadyMetadata(), FrameReadyMetadata::OnTimeFinish); |
| 2034 | EXPECT_EQ(displayFrame1->getJankType(), JankType::SurfaceFlingerScheduling); |
Ying Wei | 96eb535 | 2023-11-21 17:37:21 +0000 | [diff] [blame] | 2035 | EXPECT_EQ(displayFrame1->getJankSeverityType(), JankSeverityType::Partial); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 2036 | |
| 2037 | actuals1 = presentedSurfaceFrame1.getActuals(); |
| 2038 | EXPECT_EQ(actuals1.presentTime, 30); |
| 2039 | EXPECT_EQ(presentedSurfaceFrame1.getFramePresentMetadata(), FramePresentMetadata::EarlyPresent); |
| 2040 | EXPECT_EQ(presentedSurfaceFrame1.getFrameReadyMetadata(), FrameReadyMetadata::OnTimeFinish); |
| 2041 | EXPECT_EQ(presentedSurfaceFrame1.getJankType(), JankType::SurfaceFlingerScheduling); |
Ying Wei | 96eb535 | 2023-11-21 17:37:21 +0000 | [diff] [blame] | 2042 | EXPECT_EQ(presentedSurfaceFrame1.getJankSeverityType(), JankSeverityType::Partial); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 2043 | |
| 2044 | // Fences for the second frame haven't been flushed yet, so it should be 0 |
| 2045 | presentFence2->signalForTest(65); |
| 2046 | EXPECT_EQ(displayFrame2->getActuals().presentTime, 0); |
| 2047 | auto actuals2 = presentedSurfaceFrame2.getActuals(); |
| 2048 | EXPECT_EQ(actuals2.presentTime, 0); |
| 2049 | |
Alec Mouri | 363faf0 | 2021-01-29 16:34:55 -0800 | [diff] [blame] | 2050 | ::testing::Mock::VerifyAndClearExpectations(mTimeStats.get()); |
| 2051 | |
| 2052 | EXPECT_CALL(*mTimeStats, |
Pascal Muetschard | ac7bcd9 | 2023-10-03 15:05:36 +0200 | [diff] [blame] | 2053 | incrementJankyFrames(TimeStats::JankyFramesInfo{RR_11, std::nullopt, sUidOne, |
| 2054 | sLayerNameOne, sGameMode, |
| 2055 | JankType::PredictionError, -3, 5, |
| 2056 | 0})); |
Alec Mouri | 363faf0 | 2021-01-29 16:34:55 -0800 | [diff] [blame] | 2057 | |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 2058 | addEmptyDisplayFrame(); |
| 2059 | |
| 2060 | // Fences for the second frame have flushed, so the present timestamps should be updated |
| 2061 | EXPECT_EQ(displayFrame2->getActuals().presentTime, 65); |
| 2062 | EXPECT_EQ(displayFrame2->getFramePresentMetadata(), FramePresentMetadata::EarlyPresent); |
| 2063 | EXPECT_EQ(displayFrame2->getFrameReadyMetadata(), FrameReadyMetadata::OnTimeFinish); |
| 2064 | EXPECT_EQ(displayFrame2->getJankType(), JankType::PredictionError); |
Ying Wei | 96eb535 | 2023-11-21 17:37:21 +0000 | [diff] [blame] | 2065 | EXPECT_EQ(displayFrame2->getJankSeverityType(), JankSeverityType::Partial); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 2066 | |
| 2067 | actuals2 = presentedSurfaceFrame2.getActuals(); |
| 2068 | EXPECT_EQ(actuals2.presentTime, 65); |
| 2069 | EXPECT_EQ(presentedSurfaceFrame2.getFramePresentMetadata(), FramePresentMetadata::EarlyPresent); |
| 2070 | EXPECT_EQ(presentedSurfaceFrame2.getFrameReadyMetadata(), FrameReadyMetadata::OnTimeFinish); |
| 2071 | EXPECT_EQ(presentedSurfaceFrame2.getJankType(), JankType::PredictionError); |
Ying Wei | 96eb535 | 2023-11-21 17:37:21 +0000 | [diff] [blame] | 2072 | EXPECT_EQ(presentedSurfaceFrame2.getJankSeverityType(), JankSeverityType::Partial); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 2073 | } |
| 2074 | |
| 2075 | TEST_F(FrameTimelineTest, jankClassification_surfaceFrameOnTimeFinishLatePresent) { |
Alec Mouri | 363faf0 | 2021-01-29 16:34:55 -0800 | [diff] [blame] | 2076 | EXPECT_CALL(*mTimeStats, incrementJankyFrames(_)); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 2077 | auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 2078 | int64_t sfToken1 = mTokenManager->generateTokenForPredictions({22, 30, 40}); |
| 2079 | int64_t sfToken2 = mTokenManager->generateTokenForPredictions({52, 60, 70}); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 2080 | int64_t surfaceFrameToken1 = mTokenManager->generateTokenForPredictions({5, 16, 40}); |
| 2081 | int64_t surfaceFrameToken2 = mTokenManager->generateTokenForPredictions({25, 36, 70}); |
Huihong Luo | 3bdef86 | 2022-03-03 11:57:19 -0800 | [diff] [blame] | 2082 | FrameTimelineInfo ftInfo; |
| 2083 | ftInfo.vsyncId = surfaceFrameToken1; |
| 2084 | ftInfo.inputEventId = sInputEventId; |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 2085 | auto surfaceFrame1 = |
Huihong Luo | 3bdef86 | 2022-03-03 11:57:19 -0800 | [diff] [blame] | 2086 | mFrameTimeline->createSurfaceFrameForToken(ftInfo, sPidOne, sUidOne, sLayerIdOne, |
| 2087 | sLayerNameOne, sLayerNameOne, |
| 2088 | /*isBuffer*/ true, sGameMode); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 2089 | surfaceFrame1->setAcquireFenceTime(16); |
Pascal Muetschard | ac7bcd9 | 2023-10-03 15:05:36 +0200 | [diff] [blame] | 2090 | mFrameTimeline->setSfWakeUp(sfToken1, 22, RR_11, RR_11); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 2091 | surfaceFrame1->setPresentState(SurfaceFrame::PresentState::Presented); |
| 2092 | mFrameTimeline->addSurfaceFrame(surfaceFrame1); |
| 2093 | mFrameTimeline->setSfPresent(26, presentFence1); |
| 2094 | auto displayFrame1 = getDisplayFrame(0); |
| 2095 | auto& presentedSurfaceFrame1 = getSurfaceFrame(0, 0); |
| 2096 | presentFence1->signalForTest(50); |
| 2097 | |
| 2098 | // Fences for the first frame haven't been flushed yet, so it should be 0 |
| 2099 | EXPECT_EQ(displayFrame1->getActuals().presentTime, 0); |
| 2100 | auto actuals1 = presentedSurfaceFrame1.getActuals(); |
| 2101 | EXPECT_EQ(actuals1.presentTime, 0); |
| 2102 | |
| 2103 | // Trigger a flush by finalizing the next DisplayFrame |
| 2104 | auto presentFence2 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
Huihong Luo | 3bdef86 | 2022-03-03 11:57:19 -0800 | [diff] [blame] | 2105 | FrameTimelineInfo ftInfo2; |
| 2106 | ftInfo2.vsyncId = surfaceFrameToken2; |
| 2107 | ftInfo2.inputEventId = sInputEventId; |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 2108 | auto surfaceFrame2 = |
Huihong Luo | 3bdef86 | 2022-03-03 11:57:19 -0800 | [diff] [blame] | 2109 | mFrameTimeline->createSurfaceFrameForToken(ftInfo2, sPidOne, sUidOne, sLayerIdOne, |
| 2110 | sLayerNameOne, sLayerNameOne, |
| 2111 | /*isBuffer*/ true, sGameMode); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 2112 | surfaceFrame2->setAcquireFenceTime(36); |
Pascal Muetschard | ac7bcd9 | 2023-10-03 15:05:36 +0200 | [diff] [blame] | 2113 | mFrameTimeline->setSfWakeUp(sfToken2, 52, RR_11, RR_11); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 2114 | surfaceFrame2->setPresentState(SurfaceFrame::PresentState::Presented); |
| 2115 | mFrameTimeline->addSurfaceFrame(surfaceFrame2); |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 2116 | mFrameTimeline->setSfPresent(57, presentFence2); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 2117 | auto displayFrame2 = getDisplayFrame(1); |
| 2118 | auto& presentedSurfaceFrame2 = getSurfaceFrame(1, 0); |
| 2119 | |
| 2120 | // Fences for the first frame have flushed, so the present timestamps should be updated |
| 2121 | EXPECT_EQ(displayFrame1->getActuals().presentTime, 50); |
| 2122 | EXPECT_EQ(displayFrame1->getFramePresentMetadata(), FramePresentMetadata::LatePresent); |
| 2123 | EXPECT_EQ(displayFrame1->getFrameReadyMetadata(), FrameReadyMetadata::OnTimeFinish); |
| 2124 | EXPECT_EQ(displayFrame1->getJankType(), JankType::DisplayHAL); |
Ying Wei | 96eb535 | 2023-11-21 17:37:21 +0000 | [diff] [blame] | 2125 | EXPECT_EQ(displayFrame1->getJankSeverityType(), JankSeverityType::Partial); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 2126 | |
| 2127 | actuals1 = presentedSurfaceFrame1.getActuals(); |
| 2128 | EXPECT_EQ(actuals1.presentTime, 50); |
| 2129 | EXPECT_EQ(presentedSurfaceFrame1.getFramePresentMetadata(), FramePresentMetadata::LatePresent); |
| 2130 | EXPECT_EQ(presentedSurfaceFrame1.getFrameReadyMetadata(), FrameReadyMetadata::OnTimeFinish); |
| 2131 | EXPECT_EQ(presentedSurfaceFrame1.getJankType(), JankType::DisplayHAL); |
Ying Wei | 96eb535 | 2023-11-21 17:37:21 +0000 | [diff] [blame] | 2132 | EXPECT_EQ(presentedSurfaceFrame1.getJankSeverityType(), JankSeverityType::Partial); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 2133 | |
| 2134 | // Fences for the second frame haven't been flushed yet, so it should be 0 |
| 2135 | presentFence2->signalForTest(86); |
| 2136 | EXPECT_EQ(displayFrame2->getActuals().presentTime, 0); |
| 2137 | auto actuals2 = presentedSurfaceFrame2.getActuals(); |
| 2138 | EXPECT_EQ(actuals2.presentTime, 0); |
| 2139 | |
Alec Mouri | 363faf0 | 2021-01-29 16:34:55 -0800 | [diff] [blame] | 2140 | ::testing::Mock::VerifyAndClearExpectations(mTimeStats.get()); |
| 2141 | |
| 2142 | EXPECT_CALL(*mTimeStats, |
Pascal Muetschard | ac7bcd9 | 2023-10-03 15:05:36 +0200 | [diff] [blame] | 2143 | incrementJankyFrames(TimeStats::JankyFramesInfo{RR_11, std::nullopt, sUidOne, |
| 2144 | sLayerNameOne, sGameMode, |
| 2145 | JankType::PredictionError, -3, 5, |
| 2146 | 0})); |
Alec Mouri | 363faf0 | 2021-01-29 16:34:55 -0800 | [diff] [blame] | 2147 | |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 2148 | addEmptyDisplayFrame(); |
| 2149 | |
| 2150 | // Fences for the second frame have flushed, so the present timestamps should be updated |
| 2151 | EXPECT_EQ(displayFrame2->getActuals().presentTime, 86); |
| 2152 | EXPECT_EQ(displayFrame2->getFramePresentMetadata(), FramePresentMetadata::LatePresent); |
| 2153 | EXPECT_EQ(displayFrame2->getFrameReadyMetadata(), FrameReadyMetadata::OnTimeFinish); |
| 2154 | EXPECT_EQ(displayFrame2->getJankType(), JankType::PredictionError); |
Ying Wei | 96eb535 | 2023-11-21 17:37:21 +0000 | [diff] [blame] | 2155 | EXPECT_EQ(displayFrame2->getJankSeverityType(), JankSeverityType::Full); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 2156 | |
| 2157 | actuals2 = presentedSurfaceFrame2.getActuals(); |
| 2158 | EXPECT_EQ(actuals2.presentTime, 86); |
| 2159 | EXPECT_EQ(presentedSurfaceFrame2.getFramePresentMetadata(), FramePresentMetadata::LatePresent); |
| 2160 | EXPECT_EQ(presentedSurfaceFrame2.getFrameReadyMetadata(), FrameReadyMetadata::OnTimeFinish); |
| 2161 | EXPECT_EQ(presentedSurfaceFrame2.getJankType(), JankType::PredictionError); |
Ying Wei | 96eb535 | 2023-11-21 17:37:21 +0000 | [diff] [blame] | 2162 | EXPECT_EQ(presentedSurfaceFrame2.getJankSeverityType(), JankSeverityType::Full); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 2163 | } |
| 2164 | |
| 2165 | TEST_F(FrameTimelineTest, jankClassification_surfaceFrameLateFinishEarlyPresent) { |
Alec Mouri | 363faf0 | 2021-01-29 16:34:55 -0800 | [diff] [blame] | 2166 | EXPECT_CALL(*mTimeStats, incrementJankyFrames(_)); |
Alec Mouri | 7d436ec | 2021-01-27 20:40:50 -0800 | [diff] [blame] | 2167 | |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 2168 | auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 2169 | int64_t sfToken1 = mTokenManager->generateTokenForPredictions({42, 50, 50}); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 2170 | int64_t surfaceFrameToken1 = mTokenManager->generateTokenForPredictions({5, 26, 60}); |
Huihong Luo | 3bdef86 | 2022-03-03 11:57:19 -0800 | [diff] [blame] | 2171 | FrameTimelineInfo ftInfo; |
| 2172 | ftInfo.vsyncId = surfaceFrameToken1; |
| 2173 | ftInfo.inputEventId = sInputEventId; |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 2174 | auto surfaceFrame1 = |
Huihong Luo | 3bdef86 | 2022-03-03 11:57:19 -0800 | [diff] [blame] | 2175 | mFrameTimeline->createSurfaceFrameForToken(ftInfo, sPidOne, sUidOne, sLayerIdOne, |
| 2176 | sLayerNameOne, sLayerNameOne, |
| 2177 | /*isBuffer*/ true, sGameMode); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 2178 | surfaceFrame1->setAcquireFenceTime(40); |
Pascal Muetschard | ac7bcd9 | 2023-10-03 15:05:36 +0200 | [diff] [blame] | 2179 | mFrameTimeline->setSfWakeUp(sfToken1, 42, RR_11, RR_11); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 2180 | surfaceFrame1->setPresentState(SurfaceFrame::PresentState::Presented); |
| 2181 | mFrameTimeline->addSurfaceFrame(surfaceFrame1); |
| 2182 | mFrameTimeline->setSfPresent(46, presentFence1); |
| 2183 | auto displayFrame1 = getDisplayFrame(0); |
| 2184 | auto& presentedSurfaceFrame1 = getSurfaceFrame(0, 0); |
| 2185 | presentFence1->signalForTest(50); |
| 2186 | |
| 2187 | // Fences for the first frame haven't been flushed yet, so it should be 0 |
| 2188 | EXPECT_EQ(displayFrame1->getActuals().presentTime, 0); |
| 2189 | auto actuals1 = presentedSurfaceFrame1.getActuals(); |
| 2190 | EXPECT_EQ(actuals1.presentTime, 0); |
| 2191 | |
| 2192 | addEmptyDisplayFrame(); |
| 2193 | |
| 2194 | // Fences for the first frame have flushed, so the present timestamps should be updated |
| 2195 | EXPECT_EQ(displayFrame1->getActuals().presentTime, 50); |
| 2196 | EXPECT_EQ(displayFrame1->getFramePresentMetadata(), FramePresentMetadata::OnTimePresent); |
| 2197 | EXPECT_EQ(displayFrame1->getFrameReadyMetadata(), FrameReadyMetadata::OnTimeFinish); |
| 2198 | EXPECT_EQ(displayFrame1->getJankType(), JankType::None); |
Ying Wei | 96eb535 | 2023-11-21 17:37:21 +0000 | [diff] [blame] | 2199 | EXPECT_EQ(displayFrame1->getJankSeverityType(), JankSeverityType::None); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 2200 | |
| 2201 | actuals1 = presentedSurfaceFrame1.getActuals(); |
| 2202 | EXPECT_EQ(actuals1.presentTime, 50); |
| 2203 | EXPECT_EQ(presentedSurfaceFrame1.getFramePresentMetadata(), FramePresentMetadata::EarlyPresent); |
| 2204 | EXPECT_EQ(presentedSurfaceFrame1.getFrameReadyMetadata(), FrameReadyMetadata::LateFinish); |
| 2205 | EXPECT_EQ(presentedSurfaceFrame1.getJankType(), JankType::Unknown); |
Ying Wei | 96eb535 | 2023-11-21 17:37:21 +0000 | [diff] [blame] | 2206 | EXPECT_EQ(presentedSurfaceFrame1.getJankSeverityType(), JankSeverityType::Partial); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 2207 | } |
| 2208 | |
| 2209 | TEST_F(FrameTimelineTest, jankClassification_surfaceFrameLateFinishLatePresent) { |
Adithya Srinivasan | 8a94550 | 2021-03-19 19:12:32 +0000 | [diff] [blame] | 2210 | // First frame - DisplayFrame is not janky. This should classify the SurfaceFrame as only |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 2211 | // AppDeadlineMissed. Second frame - DisplayFrame is janky. This should propagate DisplayFrame's |
Adithya Srinivasan | 8a94550 | 2021-03-19 19:12:32 +0000 | [diff] [blame] | 2212 | // jank to the SurfaceFrame along with AppDeadlineMissed. |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 2213 | |
Alec Mouri | 363faf0 | 2021-01-29 16:34:55 -0800 | [diff] [blame] | 2214 | EXPECT_CALL(*mTimeStats, incrementJankyFrames(_)).Times(2); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 2215 | auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 2216 | int64_t sfToken1 = mTokenManager->generateTokenForPredictions({32, 40, 40}); |
| 2217 | int64_t sfToken2 = mTokenManager->generateTokenForPredictions({42, 50, 50}); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 2218 | int64_t surfaceFrameToken1 = mTokenManager->generateTokenForPredictions({5, 16, 30}); |
| 2219 | int64_t surfaceFrameToken2 = mTokenManager->generateTokenForPredictions({25, 36, 50}); |
Huihong Luo | 3bdef86 | 2022-03-03 11:57:19 -0800 | [diff] [blame] | 2220 | FrameTimelineInfo ftInfo; |
| 2221 | ftInfo.vsyncId = surfaceFrameToken1; |
| 2222 | ftInfo.inputEventId = sInputEventId; |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 2223 | auto surfaceFrame1 = |
Huihong Luo | 3bdef86 | 2022-03-03 11:57:19 -0800 | [diff] [blame] | 2224 | mFrameTimeline->createSurfaceFrameForToken(ftInfo, sPidOne, sUidOne, sLayerIdOne, |
| 2225 | sLayerNameOne, sLayerNameOne, |
| 2226 | /*isBuffer*/ true, sGameMode); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 2227 | surfaceFrame1->setAcquireFenceTime(26); |
Pascal Muetschard | ac7bcd9 | 2023-10-03 15:05:36 +0200 | [diff] [blame] | 2228 | mFrameTimeline->setSfWakeUp(sfToken1, 32, RR_11, RR_11); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 2229 | surfaceFrame1->setPresentState(SurfaceFrame::PresentState::Presented); |
| 2230 | mFrameTimeline->addSurfaceFrame(surfaceFrame1); |
| 2231 | mFrameTimeline->setSfPresent(36, presentFence1); |
| 2232 | auto displayFrame1 = getDisplayFrame(0); |
| 2233 | auto& presentedSurfaceFrame1 = getSurfaceFrame(0, 0); |
| 2234 | presentFence1->signalForTest(40); |
| 2235 | |
| 2236 | // Fences for the first frame haven't been flushed yet, so it should be 0 |
| 2237 | EXPECT_EQ(displayFrame1->getActuals().presentTime, 0); |
| 2238 | auto actuals1 = presentedSurfaceFrame1.getActuals(); |
| 2239 | EXPECT_EQ(actuals1.presentTime, 0); |
| 2240 | |
| 2241 | // Trigger a flush by finalizing the next DisplayFrame |
| 2242 | auto presentFence2 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
Huihong Luo | 3bdef86 | 2022-03-03 11:57:19 -0800 | [diff] [blame] | 2243 | FrameTimelineInfo ftInfo2; |
| 2244 | ftInfo2.vsyncId = surfaceFrameToken2; |
| 2245 | ftInfo2.inputEventId = sInputEventId; |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 2246 | auto surfaceFrame2 = |
Huihong Luo | 3bdef86 | 2022-03-03 11:57:19 -0800 | [diff] [blame] | 2247 | mFrameTimeline->createSurfaceFrameForToken(ftInfo2, sPidOne, sUidOne, sLayerIdOne, |
| 2248 | sLayerNameOne, sLayerNameOne, |
| 2249 | /*isBuffer*/ true, sGameMode); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 2250 | surfaceFrame2->setAcquireFenceTime(40); |
Pascal Muetschard | ac7bcd9 | 2023-10-03 15:05:36 +0200 | [diff] [blame] | 2251 | mFrameTimeline->setSfWakeUp(sfToken2, 43, RR_11, RR_11); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 2252 | surfaceFrame2->setPresentState(SurfaceFrame::PresentState::Presented); |
| 2253 | mFrameTimeline->addSurfaceFrame(surfaceFrame2); |
| 2254 | mFrameTimeline->setSfPresent(56, presentFence2); |
| 2255 | auto displayFrame2 = getDisplayFrame(1); |
| 2256 | auto& presentedSurfaceFrame2 = getSurfaceFrame(1, 0); |
| 2257 | |
| 2258 | // Fences for the first frame have flushed, so the present timestamps should be updated |
| 2259 | EXPECT_EQ(displayFrame1->getActuals().presentTime, 40); |
| 2260 | EXPECT_EQ(displayFrame1->getFramePresentMetadata(), FramePresentMetadata::OnTimePresent); |
| 2261 | EXPECT_EQ(displayFrame1->getFrameReadyMetadata(), FrameReadyMetadata::OnTimeFinish); |
| 2262 | EXPECT_EQ(displayFrame1->getJankType(), JankType::None); |
Ying Wei | 96eb535 | 2023-11-21 17:37:21 +0000 | [diff] [blame] | 2263 | EXPECT_EQ(displayFrame1->getJankSeverityType(), JankSeverityType::None); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 2264 | |
| 2265 | actuals1 = presentedSurfaceFrame1.getActuals(); |
| 2266 | EXPECT_EQ(actuals1.presentTime, 40); |
| 2267 | EXPECT_EQ(presentedSurfaceFrame1.getFramePresentMetadata(), FramePresentMetadata::LatePresent); |
| 2268 | EXPECT_EQ(presentedSurfaceFrame1.getFrameReadyMetadata(), FrameReadyMetadata::LateFinish); |
| 2269 | EXPECT_EQ(presentedSurfaceFrame1.getJankType(), JankType::AppDeadlineMissed); |
Ying Wei | 96eb535 | 2023-11-21 17:37:21 +0000 | [diff] [blame] | 2270 | EXPECT_EQ(presentedSurfaceFrame1.getJankSeverityType(), JankSeverityType::Partial); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 2271 | |
| 2272 | // Fences for the second frame haven't been flushed yet, so it should be 0 |
| 2273 | presentFence2->signalForTest(60); |
| 2274 | EXPECT_EQ(displayFrame2->getActuals().presentTime, 0); |
| 2275 | auto actuals2 = presentedSurfaceFrame2.getActuals(); |
| 2276 | EXPECT_EQ(actuals2.presentTime, 0); |
| 2277 | |
| 2278 | addEmptyDisplayFrame(); |
| 2279 | |
| 2280 | // Fences for the second frame have flushed, so the present timestamps should be updated |
| 2281 | EXPECT_EQ(displayFrame2->getActuals().presentTime, 60); |
| 2282 | EXPECT_EQ(displayFrame2->getFramePresentMetadata(), FramePresentMetadata::LatePresent); |
| 2283 | EXPECT_EQ(displayFrame2->getFrameReadyMetadata(), FrameReadyMetadata::LateFinish); |
| 2284 | EXPECT_EQ(displayFrame2->getJankType(), JankType::SurfaceFlingerCpuDeadlineMissed); |
Ying Wei | 96eb535 | 2023-11-21 17:37:21 +0000 | [diff] [blame] | 2285 | EXPECT_EQ(displayFrame2->getJankSeverityType(), JankSeverityType::Partial); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 2286 | |
| 2287 | actuals2 = presentedSurfaceFrame2.getActuals(); |
| 2288 | EXPECT_EQ(actuals2.presentTime, 60); |
| 2289 | EXPECT_EQ(presentedSurfaceFrame2.getFramePresentMetadata(), FramePresentMetadata::LatePresent); |
| 2290 | EXPECT_EQ(presentedSurfaceFrame2.getFrameReadyMetadata(), FrameReadyMetadata::LateFinish); |
Adithya Srinivasan | 8a94550 | 2021-03-19 19:12:32 +0000 | [diff] [blame] | 2291 | EXPECT_EQ(presentedSurfaceFrame2.getJankType(), |
| 2292 | JankType::SurfaceFlingerCpuDeadlineMissed | JankType::AppDeadlineMissed); |
Ying Wei | 96eb535 | 2023-11-21 17:37:21 +0000 | [diff] [blame] | 2293 | EXPECT_EQ(presentedSurfaceFrame2.getJankSeverityType(), JankSeverityType::Partial); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 2294 | } |
| 2295 | |
| 2296 | TEST_F(FrameTimelineTest, jankClassification_multiJankBufferStuffingAndAppDeadlineMissed) { |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 2297 | // Layer specific increment |
Alec Mouri | 363faf0 | 2021-01-29 16:34:55 -0800 | [diff] [blame] | 2298 | EXPECT_CALL(*mTimeStats, incrementJankyFrames(_)).Times(2); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 2299 | auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
| 2300 | int64_t surfaceFrameToken1 = mTokenManager->generateTokenForPredictions({10, 20, 30}); |
| 2301 | int64_t surfaceFrameToken2 = mTokenManager->generateTokenForPredictions({40, 50, 60}); |
| 2302 | |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 2303 | int64_t sfToken1 = mTokenManager->generateTokenForPredictions({52, 60, 60}); |
| 2304 | int64_t sfToken2 = mTokenManager->generateTokenForPredictions({112, 120, 120}); |
Huihong Luo | 3bdef86 | 2022-03-03 11:57:19 -0800 | [diff] [blame] | 2305 | FrameTimelineInfo ftInfo; |
| 2306 | ftInfo.vsyncId = surfaceFrameToken1; |
| 2307 | ftInfo.inputEventId = sInputEventId; |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 2308 | auto surfaceFrame1 = |
Huihong Luo | 3bdef86 | 2022-03-03 11:57:19 -0800 | [diff] [blame] | 2309 | mFrameTimeline->createSurfaceFrameForToken(ftInfo, sPidOne, sUidOne, sLayerIdOne, |
| 2310 | sLayerNameOne, sLayerNameOne, |
| 2311 | /*isBuffer*/ true, sGameMode); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 2312 | surfaceFrame1->setAcquireFenceTime(50); |
Pascal Muetschard | ac7bcd9 | 2023-10-03 15:05:36 +0200 | [diff] [blame] | 2313 | mFrameTimeline->setSfWakeUp(sfToken1, 52, RR_30, RR_30); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 2314 | surfaceFrame1->setPresentState(SurfaceFrame::PresentState::Presented); |
| 2315 | mFrameTimeline->addSurfaceFrame(surfaceFrame1); |
| 2316 | mFrameTimeline->setSfPresent(56, presentFence1); |
| 2317 | auto displayFrame1 = getDisplayFrame(0); |
| 2318 | auto& presentedSurfaceFrame1 = getSurfaceFrame(0, 0); |
| 2319 | presentFence1->signalForTest(60); |
| 2320 | |
| 2321 | // Fences for the first frame haven't been flushed yet, so it should be 0 |
| 2322 | EXPECT_EQ(displayFrame1->getActuals().presentTime, 0); |
| 2323 | auto actuals1 = presentedSurfaceFrame1.getActuals(); |
| 2324 | EXPECT_EQ(actuals1.presentTime, 0); |
| 2325 | |
| 2326 | // Trigger a flush by finalizing the next DisplayFrame |
| 2327 | auto presentFence2 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
Huihong Luo | 3bdef86 | 2022-03-03 11:57:19 -0800 | [diff] [blame] | 2328 | FrameTimelineInfo ftInfo2; |
| 2329 | ftInfo2.vsyncId = surfaceFrameToken2; |
| 2330 | ftInfo2.inputEventId = sInputEventId; |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 2331 | auto surfaceFrame2 = |
Huihong Luo | 3bdef86 | 2022-03-03 11:57:19 -0800 | [diff] [blame] | 2332 | mFrameTimeline->createSurfaceFrameForToken(ftInfo2, sPidOne, sUidOne, sLayerIdOne, |
| 2333 | sLayerNameOne, sLayerNameOne, |
| 2334 | /*isBuffer*/ true, sGameMode); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 2335 | surfaceFrame2->setAcquireFenceTime(84); |
Pascal Muetschard | ac7bcd9 | 2023-10-03 15:05:36 +0200 | [diff] [blame] | 2336 | mFrameTimeline->setSfWakeUp(sfToken2, 112, RR_30, RR_30); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 2337 | surfaceFrame2->setPresentState(SurfaceFrame::PresentState::Presented, 54); |
| 2338 | mFrameTimeline->addSurfaceFrame(surfaceFrame2); |
| 2339 | mFrameTimeline->setSfPresent(116, presentFence2); |
| 2340 | auto displayFrame2 = getDisplayFrame(1); |
| 2341 | auto& presentedSurfaceFrame2 = getSurfaceFrame(1, 0); |
| 2342 | presentFence2->signalForTest(120); |
| 2343 | |
| 2344 | // Fences for the first frame have flushed, so the present timestamps should be updated |
| 2345 | EXPECT_EQ(displayFrame1->getActuals().presentTime, 60); |
| 2346 | actuals1 = presentedSurfaceFrame1.getActuals(); |
| 2347 | EXPECT_EQ(actuals1.endTime, 50); |
| 2348 | EXPECT_EQ(actuals1.presentTime, 60); |
| 2349 | |
| 2350 | EXPECT_EQ(displayFrame1->getFramePresentMetadata(), FramePresentMetadata::OnTimePresent); |
| 2351 | EXPECT_EQ(displayFrame1->getFrameReadyMetadata(), FrameReadyMetadata::OnTimeFinish); |
| 2352 | EXPECT_EQ(displayFrame1->getJankType(), JankType::None); |
Ying Wei | 96eb535 | 2023-11-21 17:37:21 +0000 | [diff] [blame] | 2353 | EXPECT_EQ(displayFrame1->getJankSeverityType(), JankSeverityType::None); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 2354 | |
| 2355 | EXPECT_EQ(presentedSurfaceFrame1.getFramePresentMetadata(), FramePresentMetadata::LatePresent); |
| 2356 | EXPECT_EQ(presentedSurfaceFrame1.getFrameReadyMetadata(), FrameReadyMetadata::LateFinish); |
| 2357 | EXPECT_EQ(presentedSurfaceFrame1.getJankType(), JankType::AppDeadlineMissed); |
Ying Wei | 96eb535 | 2023-11-21 17:37:21 +0000 | [diff] [blame] | 2358 | EXPECT_EQ(presentedSurfaceFrame1.getJankSeverityType(), JankSeverityType::Full); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 2359 | |
| 2360 | // Fences for the second frame haven't been flushed yet, so it should be 0 |
| 2361 | EXPECT_EQ(displayFrame2->getActuals().presentTime, 0); |
| 2362 | auto actuals2 = presentedSurfaceFrame2.getActuals(); |
| 2363 | EXPECT_EQ(actuals2.presentTime, 0); |
| 2364 | |
| 2365 | addEmptyDisplayFrame(); |
| 2366 | |
| 2367 | // Fences for the second frame have flushed, so the present timestamps should be updated |
| 2368 | EXPECT_EQ(displayFrame2->getActuals().presentTime, 120); |
| 2369 | actuals2 = presentedSurfaceFrame2.getActuals(); |
| 2370 | EXPECT_EQ(actuals2.presentTime, 120); |
| 2371 | |
| 2372 | EXPECT_EQ(displayFrame2->getFramePresentMetadata(), FramePresentMetadata::OnTimePresent); |
| 2373 | EXPECT_EQ(displayFrame2->getFrameReadyMetadata(), FrameReadyMetadata::OnTimeFinish); |
| 2374 | EXPECT_EQ(displayFrame2->getJankType(), JankType::None); |
Ying Wei | 96eb535 | 2023-11-21 17:37:21 +0000 | [diff] [blame] | 2375 | EXPECT_EQ(displayFrame2->getJankSeverityType(), JankSeverityType::None); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 2376 | |
| 2377 | EXPECT_EQ(presentedSurfaceFrame2.getFramePresentMetadata(), FramePresentMetadata::LatePresent); |
| 2378 | EXPECT_EQ(presentedSurfaceFrame2.getFrameReadyMetadata(), FrameReadyMetadata::LateFinish); |
| 2379 | EXPECT_EQ(presentedSurfaceFrame2.getJankType(), |
| 2380 | JankType::AppDeadlineMissed | JankType::BufferStuffing); |
Ying Wei | 96eb535 | 2023-11-21 17:37:21 +0000 | [diff] [blame] | 2381 | EXPECT_EQ(presentedSurfaceFrame2.getJankSeverityType(), JankSeverityType::Full); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 2382 | } |
Alec Mouri | adebf5c | 2021-01-05 12:57:36 -0800 | [diff] [blame] | 2383 | |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 2384 | TEST_F(FrameTimelineTest, jankClassification_appDeadlineAdjustedForBufferStuffing) { |
| 2385 | // Layer specific increment |
| 2386 | EXPECT_CALL(*mTimeStats, incrementJankyFrames(_)).Times(2); |
| 2387 | auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
| 2388 | int64_t surfaceFrameToken1 = mTokenManager->generateTokenForPredictions({10, 20, 30}); |
| 2389 | int64_t surfaceFrameToken2 = mTokenManager->generateTokenForPredictions({40, 50, 60}); |
| 2390 | |
| 2391 | int64_t sfToken1 = mTokenManager->generateTokenForPredictions({52, 60, 60}); |
| 2392 | int64_t sfToken2 = mTokenManager->generateTokenForPredictions({82, 90, 90}); |
Huihong Luo | 3bdef86 | 2022-03-03 11:57:19 -0800 | [diff] [blame] | 2393 | FrameTimelineInfo ftInfo; |
| 2394 | ftInfo.vsyncId = surfaceFrameToken1; |
| 2395 | ftInfo.inputEventId = sInputEventId; |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 2396 | auto surfaceFrame1 = |
Huihong Luo | 3bdef86 | 2022-03-03 11:57:19 -0800 | [diff] [blame] | 2397 | mFrameTimeline->createSurfaceFrameForToken(ftInfo, sPidOne, sUidOne, sLayerIdOne, |
| 2398 | sLayerNameOne, sLayerNameOne, |
| 2399 | /*isBuffer*/ true, sGameMode); |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 2400 | surfaceFrame1->setAcquireFenceTime(50); |
Pascal Muetschard | ac7bcd9 | 2023-10-03 15:05:36 +0200 | [diff] [blame] | 2401 | mFrameTimeline->setSfWakeUp(sfToken1, 52, RR_30, RR_30); |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 2402 | surfaceFrame1->setPresentState(SurfaceFrame::PresentState::Presented); |
| 2403 | mFrameTimeline->addSurfaceFrame(surfaceFrame1); |
| 2404 | mFrameTimeline->setSfPresent(56, presentFence1); |
| 2405 | auto displayFrame1 = getDisplayFrame(0); |
| 2406 | auto& presentedSurfaceFrame1 = getSurfaceFrame(0, 0); |
| 2407 | presentFence1->signalForTest(60); |
| 2408 | |
| 2409 | // Fences for the first frame haven't been flushed yet, so it should be 0 |
| 2410 | EXPECT_EQ(displayFrame1->getActuals().presentTime, 0); |
| 2411 | auto actuals1 = presentedSurfaceFrame1.getActuals(); |
| 2412 | EXPECT_EQ(actuals1.presentTime, 0); |
| 2413 | |
| 2414 | // Trigger a flush by finalizing the next DisplayFrame |
| 2415 | auto presentFence2 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
Huihong Luo | 3bdef86 | 2022-03-03 11:57:19 -0800 | [diff] [blame] | 2416 | FrameTimelineInfo ftInfo2; |
| 2417 | ftInfo2.vsyncId = surfaceFrameToken2; |
| 2418 | ftInfo2.inputEventId = sInputEventId; |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 2419 | auto surfaceFrame2 = |
Huihong Luo | 3bdef86 | 2022-03-03 11:57:19 -0800 | [diff] [blame] | 2420 | mFrameTimeline->createSurfaceFrameForToken(ftInfo2, sPidOne, sUidOne, sLayerIdOne, |
| 2421 | sLayerNameOne, sLayerNameOne, |
| 2422 | /*isBuffer*/ true, sGameMode); |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 2423 | surfaceFrame2->setAcquireFenceTime(80); |
Pascal Muetschard | ac7bcd9 | 2023-10-03 15:05:36 +0200 | [diff] [blame] | 2424 | mFrameTimeline->setSfWakeUp(sfToken2, 82, RR_30, RR_30); |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 2425 | // Setting previous latch time to 54, adjusted deadline will be 54 + vsyncTime(30) = 84 |
| 2426 | surfaceFrame2->setPresentState(SurfaceFrame::PresentState::Presented, 54); |
| 2427 | mFrameTimeline->addSurfaceFrame(surfaceFrame2); |
| 2428 | mFrameTimeline->setSfPresent(86, presentFence2); |
| 2429 | auto displayFrame2 = getDisplayFrame(1); |
| 2430 | auto& presentedSurfaceFrame2 = getSurfaceFrame(1, 0); |
| 2431 | presentFence2->signalForTest(90); |
| 2432 | |
| 2433 | // Fences for the first frame have flushed, so the present timestamps should be updated |
| 2434 | EXPECT_EQ(displayFrame1->getActuals().presentTime, 60); |
| 2435 | actuals1 = presentedSurfaceFrame1.getActuals(); |
| 2436 | EXPECT_EQ(actuals1.endTime, 50); |
| 2437 | EXPECT_EQ(actuals1.presentTime, 60); |
| 2438 | |
| 2439 | EXPECT_EQ(displayFrame1->getFramePresentMetadata(), FramePresentMetadata::OnTimePresent); |
| 2440 | EXPECT_EQ(displayFrame1->getFrameReadyMetadata(), FrameReadyMetadata::OnTimeFinish); |
| 2441 | EXPECT_EQ(displayFrame1->getJankType(), JankType::None); |
Ying Wei | 96eb535 | 2023-11-21 17:37:21 +0000 | [diff] [blame] | 2442 | EXPECT_EQ(displayFrame1->getJankSeverityType(), JankSeverityType::None); |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 2443 | |
| 2444 | EXPECT_EQ(presentedSurfaceFrame1.getFramePresentMetadata(), FramePresentMetadata::LatePresent); |
| 2445 | EXPECT_EQ(presentedSurfaceFrame1.getFrameReadyMetadata(), FrameReadyMetadata::LateFinish); |
| 2446 | EXPECT_EQ(presentedSurfaceFrame1.getJankType(), JankType::AppDeadlineMissed); |
Ying Wei | 96eb535 | 2023-11-21 17:37:21 +0000 | [diff] [blame] | 2447 | EXPECT_EQ(presentedSurfaceFrame1.getJankSeverityType(), JankSeverityType::Full); |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 2448 | |
| 2449 | // Fences for the second frame haven't been flushed yet, so it should be 0 |
| 2450 | EXPECT_EQ(displayFrame2->getActuals().presentTime, 0); |
| 2451 | auto actuals2 = presentedSurfaceFrame2.getActuals(); |
| 2452 | EXPECT_EQ(actuals2.presentTime, 0); |
| 2453 | |
| 2454 | addEmptyDisplayFrame(); |
| 2455 | |
| 2456 | // Fences for the second frame have flushed, so the present timestamps should be updated |
| 2457 | EXPECT_EQ(displayFrame2->getActuals().presentTime, 90); |
| 2458 | actuals2 = presentedSurfaceFrame2.getActuals(); |
| 2459 | EXPECT_EQ(actuals2.presentTime, 90); |
| 2460 | |
| 2461 | EXPECT_EQ(displayFrame2->getFramePresentMetadata(), FramePresentMetadata::OnTimePresent); |
| 2462 | EXPECT_EQ(displayFrame2->getFrameReadyMetadata(), FrameReadyMetadata::OnTimeFinish); |
| 2463 | EXPECT_EQ(displayFrame2->getJankType(), JankType::None); |
Ying Wei | 96eb535 | 2023-11-21 17:37:21 +0000 | [diff] [blame] | 2464 | EXPECT_EQ(displayFrame2->getJankSeverityType(), JankSeverityType::None); |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 2465 | |
| 2466 | EXPECT_EQ(presentedSurfaceFrame2.getFramePresentMetadata(), FramePresentMetadata::LatePresent); |
| 2467 | EXPECT_EQ(presentedSurfaceFrame2.getFrameReadyMetadata(), FrameReadyMetadata::OnTimeFinish); |
| 2468 | EXPECT_EQ(presentedSurfaceFrame2.getJankType(), JankType::BufferStuffing); |
Ying Wei | 96eb535 | 2023-11-21 17:37:21 +0000 | [diff] [blame] | 2469 | EXPECT_EQ(presentedSurfaceFrame2.getJankSeverityType(), JankSeverityType::Full); |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 2470 | } |
| 2471 | |
Rachel Lee | 94917b3 | 2022-03-18 17:52:09 -0700 | [diff] [blame] | 2472 | TEST_F(FrameTimelineTest, jankClassification_displayFrameLateFinishLatePresent_GpuAndCpuMiss) { |
| 2473 | auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
| 2474 | auto presentFence2 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
| 2475 | auto gpuFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
| 2476 | int64_t sfToken1 = mTokenManager->generateTokenForPredictions({22, 26, 40}); |
| 2477 | int64_t sfToken2 = mTokenManager->generateTokenForPredictions({52, 60, 60}); |
| 2478 | |
| 2479 | // Case 1: cpu time = 33 - 12 = 21, vsync period = 11 |
Pascal Muetschard | ac7bcd9 | 2023-10-03 15:05:36 +0200 | [diff] [blame] | 2480 | mFrameTimeline->setSfWakeUp(sfToken1, 12, RR_11, RR_11); |
Rachel Lee | 94917b3 | 2022-03-18 17:52:09 -0700 | [diff] [blame] | 2481 | mFrameTimeline->setSfPresent(33, presentFence1, gpuFence1); |
| 2482 | auto displayFrame = getDisplayFrame(0); |
| 2483 | gpuFence1->signalForTest(36); |
| 2484 | presentFence1->signalForTest(52); |
| 2485 | |
| 2486 | // Fences haven't been flushed yet, so it should be 0 |
| 2487 | EXPECT_EQ(displayFrame->getActuals().presentTime, 0); |
| 2488 | |
| 2489 | addEmptyDisplayFrame(); |
| 2490 | displayFrame = getDisplayFrame(0); |
| 2491 | |
| 2492 | // Fences have flushed, so the present timestamps should be updated |
| 2493 | EXPECT_EQ(displayFrame->getActuals().presentTime, 52); |
| 2494 | EXPECT_EQ(displayFrame->getFramePresentMetadata(), FramePresentMetadata::LatePresent); |
| 2495 | EXPECT_EQ(displayFrame->getFrameReadyMetadata(), FrameReadyMetadata::LateFinish); |
| 2496 | EXPECT_EQ(displayFrame->getJankType(), JankType::SurfaceFlingerGpuDeadlineMissed); |
Ying Wei | 96eb535 | 2023-11-21 17:37:21 +0000 | [diff] [blame] | 2497 | EXPECT_EQ(displayFrame->getJankSeverityType(), JankSeverityType::Full); |
Rachel Lee | 94917b3 | 2022-03-18 17:52:09 -0700 | [diff] [blame] | 2498 | |
| 2499 | // Case 2: No GPU fence so it will not use GPU composition. |
Pascal Muetschard | ac7bcd9 | 2023-10-03 15:05:36 +0200 | [diff] [blame] | 2500 | mFrameTimeline->setSfWakeUp(sfToken2, 52, RR_30, RR_30); |
Rachel Lee | 94917b3 | 2022-03-18 17:52:09 -0700 | [diff] [blame] | 2501 | mFrameTimeline->setSfPresent(66, presentFence2); |
| 2502 | auto displayFrame2 = getDisplayFrame(2); // 2 because of previous empty frame |
| 2503 | presentFence2->signalForTest(90); |
| 2504 | |
| 2505 | // Fences for the frame haven't been flushed yet, so it should be 0 |
| 2506 | EXPECT_EQ(displayFrame2->getActuals().presentTime, 0); |
| 2507 | |
| 2508 | addEmptyDisplayFrame(); |
| 2509 | |
| 2510 | // Fences have flushed, so the present timestamps should be updated |
| 2511 | EXPECT_EQ(displayFrame2->getActuals().presentTime, 90); |
| 2512 | EXPECT_EQ(displayFrame2->getFramePresentMetadata(), FramePresentMetadata::LatePresent); |
| 2513 | EXPECT_EQ(displayFrame2->getFrameReadyMetadata(), FrameReadyMetadata::LateFinish); |
| 2514 | EXPECT_EQ(displayFrame2->getJankType(), JankType::SurfaceFlingerCpuDeadlineMissed); |
Ying Wei | 96eb535 | 2023-11-21 17:37:21 +0000 | [diff] [blame] | 2515 | EXPECT_EQ(displayFrame2->getJankSeverityType(), JankSeverityType::Full); |
Rachel Lee | 94917b3 | 2022-03-18 17:52:09 -0700 | [diff] [blame] | 2516 | } |
| 2517 | |
Ady Abraham | fcb1686 | 2022-10-10 14:35:21 -0700 | [diff] [blame] | 2518 | TEST_F(FrameTimelineTest, jankClassification_presentFenceError) { |
| 2519 | auto erroneousPresentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
| 2520 | auto erroneousPresentFence2 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
| 2521 | auto validPresentFence = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
| 2522 | int64_t sfToken1 = mTokenManager->generateTokenForPredictions({22, 26, 40}); |
| 2523 | int64_t sfToken2 = mTokenManager->generateTokenForPredictions({52, 60, 60}); |
| 2524 | int64_t sfToken3 = mTokenManager->generateTokenForPredictions({72, 80, 80}); |
| 2525 | |
Pascal Muetschard | ac7bcd9 | 2023-10-03 15:05:36 +0200 | [diff] [blame] | 2526 | mFrameTimeline->setSfWakeUp(sfToken1, 22, RR_11, RR_11); |
Ady Abraham | fcb1686 | 2022-10-10 14:35:21 -0700 | [diff] [blame] | 2527 | mFrameTimeline->setSfPresent(26, erroneousPresentFence1); |
| 2528 | |
Pascal Muetschard | ac7bcd9 | 2023-10-03 15:05:36 +0200 | [diff] [blame] | 2529 | mFrameTimeline->setSfWakeUp(sfToken2, 52, RR_11, RR_11); |
Ady Abraham | fcb1686 | 2022-10-10 14:35:21 -0700 | [diff] [blame] | 2530 | mFrameTimeline->setSfPresent(60, erroneousPresentFence2); |
| 2531 | |
Pascal Muetschard | ac7bcd9 | 2023-10-03 15:05:36 +0200 | [diff] [blame] | 2532 | mFrameTimeline->setSfWakeUp(sfToken3, 72, RR_11, RR_11); |
Ady Abraham | fcb1686 | 2022-10-10 14:35:21 -0700 | [diff] [blame] | 2533 | mFrameTimeline->setSfPresent(80, validPresentFence); |
| 2534 | |
Ady Abraham | b1e10d1 | 2023-03-13 15:23:54 -0700 | [diff] [blame] | 2535 | erroneousPresentFence2->signalForTest(2); |
Ady Abraham | fcb1686 | 2022-10-10 14:35:21 -0700 | [diff] [blame] | 2536 | validPresentFence->signalForTest(80); |
| 2537 | |
| 2538 | addEmptyDisplayFrame(); |
| 2539 | |
| 2540 | { |
| 2541 | auto displayFrame = getDisplayFrame(0); |
| 2542 | EXPECT_EQ(displayFrame->getActuals().presentTime, 26); |
| 2543 | EXPECT_EQ(displayFrame->getFramePresentMetadata(), FramePresentMetadata::UnknownPresent); |
| 2544 | EXPECT_EQ(displayFrame->getFrameReadyMetadata(), FrameReadyMetadata::UnknownFinish); |
Ady Abraham | b1e10d1 | 2023-03-13 15:23:54 -0700 | [diff] [blame] | 2545 | EXPECT_EQ(displayFrame->getJankType(), JankType::Unknown | JankType::DisplayHAL); |
Ying Wei | 96eb535 | 2023-11-21 17:37:21 +0000 | [diff] [blame] | 2546 | EXPECT_EQ(displayFrame->getJankSeverityType(), JankSeverityType::Unknown); |
Ady Abraham | fcb1686 | 2022-10-10 14:35:21 -0700 | [diff] [blame] | 2547 | } |
| 2548 | { |
| 2549 | auto displayFrame = getDisplayFrame(1); |
| 2550 | EXPECT_EQ(displayFrame->getActuals().presentTime, 60); |
| 2551 | EXPECT_EQ(displayFrame->getFramePresentMetadata(), FramePresentMetadata::UnknownPresent); |
| 2552 | EXPECT_EQ(displayFrame->getFrameReadyMetadata(), FrameReadyMetadata::UnknownFinish); |
Ady Abraham | b1e10d1 | 2023-03-13 15:23:54 -0700 | [diff] [blame] | 2553 | EXPECT_EQ(displayFrame->getJankType(), JankType::Unknown | JankType::DisplayHAL); |
Ying Wei | 96eb535 | 2023-11-21 17:37:21 +0000 | [diff] [blame] | 2554 | EXPECT_EQ(displayFrame->getJankSeverityType(), JankSeverityType::Unknown); |
Ady Abraham | fcb1686 | 2022-10-10 14:35:21 -0700 | [diff] [blame] | 2555 | } |
| 2556 | { |
| 2557 | auto displayFrame = getDisplayFrame(2); |
| 2558 | EXPECT_EQ(displayFrame->getActuals().presentTime, 80); |
| 2559 | EXPECT_EQ(displayFrame->getFramePresentMetadata(), FramePresentMetadata::OnTimePresent); |
| 2560 | EXPECT_EQ(displayFrame->getFrameReadyMetadata(), FrameReadyMetadata::OnTimeFinish); |
| 2561 | EXPECT_EQ(displayFrame->getJankType(), JankType::None); |
Ying Wei | 96eb535 | 2023-11-21 17:37:21 +0000 | [diff] [blame] | 2562 | EXPECT_EQ(displayFrame->getJankSeverityType(), JankSeverityType::None); |
Ady Abraham | fcb1686 | 2022-10-10 14:35:21 -0700 | [diff] [blame] | 2563 | } |
| 2564 | } |
| 2565 | |
Alec Mouri | adebf5c | 2021-01-05 12:57:36 -0800 | [diff] [blame] | 2566 | TEST_F(FrameTimelineTest, computeFps_noLayerIds_returnsZero) { |
| 2567 | EXPECT_EQ(mFrameTimeline->computeFps({}), 0.0f); |
| 2568 | } |
| 2569 | |
| 2570 | TEST_F(FrameTimelineTest, computeFps_singleDisplayFrame_returnsZero) { |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 2571 | const auto oneHundredMs = std::chrono::nanoseconds(100ms).count(); |
Alec Mouri | adebf5c | 2021-01-05 12:57:36 -0800 | [diff] [blame] | 2572 | |
| 2573 | auto surfaceFrame1 = |
| 2574 | mFrameTimeline->createSurfaceFrameForToken(FrameTimelineInfo(), sPidOne, sUidOne, |
Adithya Srinivasan | 785addd | 2021-03-09 00:38:00 +0000 | [diff] [blame] | 2575 | sLayerIdOne, sLayerNameOne, sLayerNameOne, |
Adithya Srinivasan | 58069dc | 2021-06-04 20:37:02 +0000 | [diff] [blame] | 2576 | /*isBuffer*/ true, sGameMode); |
Alec Mouri | adebf5c | 2021-01-05 12:57:36 -0800 | [diff] [blame] | 2577 | auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
| 2578 | surfaceFrame1->setPresentState(SurfaceFrame::PresentState::Presented); |
| 2579 | mFrameTimeline->addSurfaceFrame(surfaceFrame1); |
| 2580 | presentFence1->signalForTest(oneHundredMs); |
| 2581 | mFrameTimeline->setSfPresent(oneHundredMs, presentFence1); |
| 2582 | |
| 2583 | EXPECT_EQ(mFrameTimeline->computeFps({sLayerIdOne}), 0.0f); |
| 2584 | } |
| 2585 | |
| 2586 | TEST_F(FrameTimelineTest, computeFps_twoDisplayFrames_oneLayer) { |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 2587 | const auto oneHundredMs = std::chrono::nanoseconds(100ms).count(); |
| 2588 | const auto twoHundredMs = std::chrono::nanoseconds(200ms).count(); |
Alec Mouri | adebf5c | 2021-01-05 12:57:36 -0800 | [diff] [blame] | 2589 | auto surfaceFrame1 = |
| 2590 | mFrameTimeline->createSurfaceFrameForToken(FrameTimelineInfo(), sPidOne, sUidOne, |
Adithya Srinivasan | 785addd | 2021-03-09 00:38:00 +0000 | [diff] [blame] | 2591 | sLayerIdOne, sLayerNameOne, sLayerNameOne, |
Adithya Srinivasan | 58069dc | 2021-06-04 20:37:02 +0000 | [diff] [blame] | 2592 | /*isBuffer*/ true, sGameMode); |
Alec Mouri | adebf5c | 2021-01-05 12:57:36 -0800 | [diff] [blame] | 2593 | auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
| 2594 | surfaceFrame1->setPresentState(SurfaceFrame::PresentState::Presented); |
| 2595 | mFrameTimeline->addSurfaceFrame(surfaceFrame1); |
| 2596 | presentFence1->signalForTest(oneHundredMs); |
| 2597 | mFrameTimeline->setSfPresent(oneHundredMs, presentFence1); |
| 2598 | |
| 2599 | auto surfaceFrame2 = |
| 2600 | mFrameTimeline->createSurfaceFrameForToken(FrameTimelineInfo(), sPidOne, sUidOne, |
Adithya Srinivasan | 785addd | 2021-03-09 00:38:00 +0000 | [diff] [blame] | 2601 | sLayerIdOne, sLayerNameOne, sLayerNameOne, |
Adithya Srinivasan | 58069dc | 2021-06-04 20:37:02 +0000 | [diff] [blame] | 2602 | /*isBuffer*/ true, sGameMode); |
Alec Mouri | adebf5c | 2021-01-05 12:57:36 -0800 | [diff] [blame] | 2603 | auto presentFence2 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
| 2604 | surfaceFrame2->setPresentState(SurfaceFrame::PresentState::Presented); |
| 2605 | mFrameTimeline->addSurfaceFrame(surfaceFrame2); |
| 2606 | presentFence2->signalForTest(twoHundredMs); |
| 2607 | mFrameTimeline->setSfPresent(twoHundredMs, presentFence2); |
| 2608 | |
| 2609 | EXPECT_EQ(mFrameTimeline->computeFps({sLayerIdOne}), 10.0); |
| 2610 | } |
| 2611 | |
| 2612 | TEST_F(FrameTimelineTest, computeFps_twoDisplayFrames_twoLayers) { |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 2613 | const auto oneHundredMs = std::chrono::nanoseconds(100ms).count(); |
| 2614 | const auto twoHundredMs = std::chrono::nanoseconds(200ms).count(); |
Alec Mouri | adebf5c | 2021-01-05 12:57:36 -0800 | [diff] [blame] | 2615 | auto surfaceFrame1 = |
| 2616 | mFrameTimeline->createSurfaceFrameForToken(FrameTimelineInfo(), sPidOne, sUidOne, |
Adithya Srinivasan | 785addd | 2021-03-09 00:38:00 +0000 | [diff] [blame] | 2617 | sLayerIdOne, sLayerNameOne, sLayerNameOne, |
Adithya Srinivasan | 58069dc | 2021-06-04 20:37:02 +0000 | [diff] [blame] | 2618 | /*isBuffer*/ true, sGameMode); |
Alec Mouri | adebf5c | 2021-01-05 12:57:36 -0800 | [diff] [blame] | 2619 | auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
| 2620 | surfaceFrame1->setPresentState(SurfaceFrame::PresentState::Presented); |
| 2621 | mFrameTimeline->addSurfaceFrame(surfaceFrame1); |
| 2622 | presentFence1->signalForTest(oneHundredMs); |
| 2623 | mFrameTimeline->setSfPresent(oneHundredMs, presentFence1); |
| 2624 | |
| 2625 | auto surfaceFrame2 = |
| 2626 | mFrameTimeline->createSurfaceFrameForToken(FrameTimelineInfo(), sPidOne, sUidOne, |
Adithya Srinivasan | 785addd | 2021-03-09 00:38:00 +0000 | [diff] [blame] | 2627 | sLayerIdTwo, sLayerNameTwo, sLayerNameTwo, |
Adithya Srinivasan | 58069dc | 2021-06-04 20:37:02 +0000 | [diff] [blame] | 2628 | /*isBuffer*/ true, sGameMode); |
Alec Mouri | adebf5c | 2021-01-05 12:57:36 -0800 | [diff] [blame] | 2629 | auto presentFence2 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
| 2630 | surfaceFrame2->setPresentState(SurfaceFrame::PresentState::Presented); |
| 2631 | mFrameTimeline->addSurfaceFrame(surfaceFrame2); |
| 2632 | presentFence2->signalForTest(twoHundredMs); |
| 2633 | mFrameTimeline->setSfPresent(twoHundredMs, presentFence2); |
| 2634 | |
| 2635 | EXPECT_EQ(mFrameTimeline->computeFps({sLayerIdOne, sLayerIdTwo}), 10.0f); |
| 2636 | } |
| 2637 | |
| 2638 | TEST_F(FrameTimelineTest, computeFps_filtersOutLayers) { |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 2639 | const auto oneHundredMs = std::chrono::nanoseconds(100ms).count(); |
| 2640 | const auto twoHundredMs = std::chrono::nanoseconds(200ms).count(); |
Alec Mouri | adebf5c | 2021-01-05 12:57:36 -0800 | [diff] [blame] | 2641 | auto surfaceFrame1 = |
| 2642 | mFrameTimeline->createSurfaceFrameForToken(FrameTimelineInfo(), sPidOne, sUidOne, |
Adithya Srinivasan | 785addd | 2021-03-09 00:38:00 +0000 | [diff] [blame] | 2643 | sLayerIdOne, sLayerNameOne, sLayerNameOne, |
Adithya Srinivasan | 58069dc | 2021-06-04 20:37:02 +0000 | [diff] [blame] | 2644 | /*isBuffer*/ true, sGameMode); |
Alec Mouri | adebf5c | 2021-01-05 12:57:36 -0800 | [diff] [blame] | 2645 | auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
| 2646 | surfaceFrame1->setPresentState(SurfaceFrame::PresentState::Presented); |
| 2647 | mFrameTimeline->addSurfaceFrame(surfaceFrame1); |
| 2648 | presentFence1->signalForTest(oneHundredMs); |
| 2649 | mFrameTimeline->setSfPresent(oneHundredMs, presentFence1); |
| 2650 | |
| 2651 | auto surfaceFrame2 = |
| 2652 | mFrameTimeline->createSurfaceFrameForToken(FrameTimelineInfo(), sPidOne, sUidOne, |
Adithya Srinivasan | 785addd | 2021-03-09 00:38:00 +0000 | [diff] [blame] | 2653 | sLayerIdTwo, sLayerNameTwo, sLayerNameTwo, |
Adithya Srinivasan | 58069dc | 2021-06-04 20:37:02 +0000 | [diff] [blame] | 2654 | /*isBuffer*/ true, sGameMode); |
Alec Mouri | adebf5c | 2021-01-05 12:57:36 -0800 | [diff] [blame] | 2655 | auto presentFence2 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
| 2656 | surfaceFrame2->setPresentState(SurfaceFrame::PresentState::Presented); |
| 2657 | mFrameTimeline->addSurfaceFrame(surfaceFrame2); |
| 2658 | presentFence2->signalForTest(twoHundredMs); |
| 2659 | mFrameTimeline->setSfPresent(twoHundredMs, presentFence2); |
| 2660 | |
| 2661 | EXPECT_EQ(mFrameTimeline->computeFps({sLayerIdOne}), 0.0f); |
| 2662 | } |
| 2663 | |
| 2664 | TEST_F(FrameTimelineTest, computeFps_averagesOverMultipleFrames) { |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 2665 | const auto oneHundredMs = std::chrono::nanoseconds(100ms).count(); |
| 2666 | const auto twoHundredMs = std::chrono::nanoseconds(200ms).count(); |
| 2667 | const auto threeHundredMs = std::chrono::nanoseconds(300ms).count(); |
| 2668 | const auto fiveHundredMs = std::chrono::nanoseconds(500ms).count(); |
| 2669 | const auto sixHundredMs = std::chrono::nanoseconds(600ms).count(); |
Alec Mouri | adebf5c | 2021-01-05 12:57:36 -0800 | [diff] [blame] | 2670 | auto surfaceFrame1 = |
| 2671 | mFrameTimeline->createSurfaceFrameForToken(FrameTimelineInfo(), sPidOne, sUidOne, |
Adithya Srinivasan | 785addd | 2021-03-09 00:38:00 +0000 | [diff] [blame] | 2672 | sLayerIdOne, sLayerNameOne, sLayerNameOne, |
Adithya Srinivasan | 58069dc | 2021-06-04 20:37:02 +0000 | [diff] [blame] | 2673 | /*isBuffer*/ true, sGameMode); |
Alec Mouri | adebf5c | 2021-01-05 12:57:36 -0800 | [diff] [blame] | 2674 | auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
| 2675 | surfaceFrame1->setPresentState(SurfaceFrame::PresentState::Presented); |
| 2676 | mFrameTimeline->addSurfaceFrame(surfaceFrame1); |
| 2677 | presentFence1->signalForTest(oneHundredMs); |
| 2678 | mFrameTimeline->setSfPresent(oneHundredMs, presentFence1); |
| 2679 | |
| 2680 | auto surfaceFrame2 = |
| 2681 | mFrameTimeline->createSurfaceFrameForToken(FrameTimelineInfo(), sPidOne, sUidOne, |
Adithya Srinivasan | 785addd | 2021-03-09 00:38:00 +0000 | [diff] [blame] | 2682 | sLayerIdOne, sLayerNameOne, sLayerNameOne, |
Adithya Srinivasan | 58069dc | 2021-06-04 20:37:02 +0000 | [diff] [blame] | 2683 | /*isBuffer*/ true, sGameMode); |
Alec Mouri | adebf5c | 2021-01-05 12:57:36 -0800 | [diff] [blame] | 2684 | auto presentFence2 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
| 2685 | surfaceFrame2->setPresentState(SurfaceFrame::PresentState::Presented); |
| 2686 | mFrameTimeline->addSurfaceFrame(surfaceFrame2); |
| 2687 | presentFence2->signalForTest(twoHundredMs); |
| 2688 | mFrameTimeline->setSfPresent(twoHundredMs, presentFence2); |
| 2689 | |
| 2690 | auto surfaceFrame3 = |
| 2691 | mFrameTimeline->createSurfaceFrameForToken(FrameTimelineInfo(), sPidOne, sUidOne, |
Adithya Srinivasan | 785addd | 2021-03-09 00:38:00 +0000 | [diff] [blame] | 2692 | sLayerIdTwo, sLayerNameTwo, sLayerNameTwo, |
Adithya Srinivasan | 58069dc | 2021-06-04 20:37:02 +0000 | [diff] [blame] | 2693 | /*isBuffer*/ true, sGameMode); |
Alec Mouri | adebf5c | 2021-01-05 12:57:36 -0800 | [diff] [blame] | 2694 | auto presentFence3 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
| 2695 | surfaceFrame3->setPresentState(SurfaceFrame::PresentState::Presented); |
| 2696 | mFrameTimeline->addSurfaceFrame(surfaceFrame3); |
| 2697 | presentFence3->signalForTest(threeHundredMs); |
| 2698 | mFrameTimeline->setSfPresent(threeHundredMs, presentFence3); |
| 2699 | |
| 2700 | auto surfaceFrame4 = |
| 2701 | mFrameTimeline->createSurfaceFrameForToken(FrameTimelineInfo(), sPidOne, sUidOne, |
Adithya Srinivasan | 785addd | 2021-03-09 00:38:00 +0000 | [diff] [blame] | 2702 | sLayerIdOne, sLayerNameOne, sLayerNameOne, |
Adithya Srinivasan | 58069dc | 2021-06-04 20:37:02 +0000 | [diff] [blame] | 2703 | /*isBuffer*/ true, sGameMode); |
Alec Mouri | adebf5c | 2021-01-05 12:57:36 -0800 | [diff] [blame] | 2704 | auto presentFence4 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
| 2705 | surfaceFrame4->setPresentState(SurfaceFrame::PresentState::Presented); |
| 2706 | mFrameTimeline->addSurfaceFrame(surfaceFrame4); |
| 2707 | presentFence4->signalForTest(fiveHundredMs); |
| 2708 | mFrameTimeline->setSfPresent(fiveHundredMs, presentFence4); |
| 2709 | |
| 2710 | auto surfaceFrame5 = |
| 2711 | mFrameTimeline->createSurfaceFrameForToken(FrameTimelineInfo(), sPidOne, sUidOne, |
Adithya Srinivasan | 785addd | 2021-03-09 00:38:00 +0000 | [diff] [blame] | 2712 | sLayerIdOne, sLayerNameOne, sLayerNameOne, |
Adithya Srinivasan | 58069dc | 2021-06-04 20:37:02 +0000 | [diff] [blame] | 2713 | /*isBuffer*/ true, sGameMode); |
Alec Mouri | adebf5c | 2021-01-05 12:57:36 -0800 | [diff] [blame] | 2714 | auto presentFence5 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
| 2715 | // Dropped frames will be excluded from fps computation |
| 2716 | surfaceFrame5->setPresentState(SurfaceFrame::PresentState::Dropped); |
| 2717 | mFrameTimeline->addSurfaceFrame(surfaceFrame5); |
| 2718 | presentFence5->signalForTest(sixHundredMs); |
| 2719 | mFrameTimeline->setSfPresent(sixHundredMs, presentFence5); |
| 2720 | |
| 2721 | EXPECT_EQ(mFrameTimeline->computeFps({sLayerIdOne}), 5.0f); |
| 2722 | } |
| 2723 | |
ramindani | ea2bb82 | 2022-06-27 19:52:10 +0000 | [diff] [blame] | 2724 | TEST_F(FrameTimelineTest, getMinTime) { |
| 2725 | // Use SurfaceFrame::getBaseTime to test the getMinTime. |
| 2726 | FrameTimelineInfo ftInfo; |
| 2727 | |
| 2728 | // Valid prediction state test. |
| 2729 | ftInfo.vsyncId = 0L; |
| 2730 | mTokenManager->generateTokenForPredictions({10}); |
| 2731 | auto surfaceFrame = |
| 2732 | mFrameTimeline->createSurfaceFrameForToken(ftInfo, sPidOne, sUidOne, sLayerIdOne, |
| 2733 | sLayerNameOne, sLayerNameOne, |
| 2734 | /*isBuffer*/ true, sGameMode); |
| 2735 | ASSERT_EQ(surfaceFrame->getBaseTime(), 10); |
| 2736 | |
| 2737 | // Test prediction state which is not valid. |
| 2738 | ftInfo.vsyncId = FrameTimelineInfo::INVALID_VSYNC_ID; |
| 2739 | surfaceFrame = mFrameTimeline->createSurfaceFrameForToken(ftInfo, sPidOne, sUidOne, sLayerIdOne, |
| 2740 | sLayerNameOne, sLayerNameOne, |
| 2741 | /*isBuffer*/ true, sGameMode); |
| 2742 | // Start time test. |
| 2743 | surfaceFrame->setActualStartTime(200); |
| 2744 | ASSERT_EQ(surfaceFrame->getBaseTime(), 200); |
| 2745 | |
| 2746 | // End time test. |
| 2747 | surfaceFrame->setAcquireFenceTime(100); |
| 2748 | ASSERT_EQ(surfaceFrame->getBaseTime(), 100); |
| 2749 | |
| 2750 | // Present time test. |
| 2751 | auto presentFence = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
| 2752 | surfaceFrame->setPresentState(SurfaceFrame::PresentState::Presented); |
| 2753 | mFrameTimeline->addSurfaceFrame(surfaceFrame); |
| 2754 | presentFence->signalForTest(std::chrono::nanoseconds(50ns).count()); |
| 2755 | mFrameTimeline->setSfPresent(50, presentFence); |
| 2756 | ASSERT_EQ(surfaceFrame->getBaseTime(), 50); |
| 2757 | } |
Pascal Muetschard | ac7bcd9 | 2023-10-03 15:05:36 +0200 | [diff] [blame] | 2758 | |
| 2759 | TEST_F(FrameTimelineTest, surfaceFrameRenderRateUsingDisplayRate) { |
| 2760 | auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
| 2761 | int64_t token1 = mTokenManager->generateTokenForPredictions({10, 20, 30}); |
| 2762 | FrameTimelineInfo ftInfo; |
| 2763 | ftInfo.vsyncId = token1; |
| 2764 | ftInfo.inputEventId = sInputEventId; |
| 2765 | auto surfaceFrame = |
| 2766 | mFrameTimeline->createSurfaceFrameForToken(ftInfo, sPidOne, sUidOne, sLayerIdOne, |
| 2767 | sLayerNameOne, sLayerNameOne, |
| 2768 | /*isBuffer*/ true, sGameMode); |
| 2769 | |
| 2770 | mFrameTimeline->setSfWakeUp(token1, 20, RR_30, RR_11); |
| 2771 | surfaceFrame->setPresentState(SurfaceFrame::PresentState::Presented); |
| 2772 | mFrameTimeline->addSurfaceFrame(surfaceFrame); |
| 2773 | presentFence1->signalForTest(std::chrono::nanoseconds(50ns).count()); |
| 2774 | mFrameTimeline->setSfPresent(50, presentFence1); |
| 2775 | |
| 2776 | EXPECT_EQ(surfaceFrame->getRenderRate().getPeriodNsecs(), 11); |
| 2777 | } |
| 2778 | |
| 2779 | TEST_F(FrameTimelineTest, surfaceFrameRenderRateUsingAppFrameRate) { |
| 2780 | auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE); |
| 2781 | int64_t token1 = mTokenManager->generateTokenForPredictions({10, 20, 30}); |
| 2782 | FrameTimelineInfo ftInfo; |
| 2783 | ftInfo.vsyncId = token1; |
| 2784 | ftInfo.inputEventId = sInputEventId; |
| 2785 | auto surfaceFrame = |
| 2786 | mFrameTimeline->createSurfaceFrameForToken(ftInfo, sPidOne, sUidOne, sLayerIdOne, |
| 2787 | sLayerNameOne, sLayerNameOne, |
| 2788 | /*isBuffer*/ true, sGameMode); |
| 2789 | surfaceFrame->setRenderRate(RR_30); |
| 2790 | mFrameTimeline->setSfWakeUp(token1, 20, RR_11, RR_11); |
| 2791 | surfaceFrame->setPresentState(SurfaceFrame::PresentState::Presented); |
| 2792 | mFrameTimeline->addSurfaceFrame(surfaceFrame); |
| 2793 | presentFence1->signalForTest(std::chrono::nanoseconds(50ns).count()); |
| 2794 | mFrameTimeline->setSfPresent(50, presentFence1); |
| 2795 | |
| 2796 | EXPECT_EQ(surfaceFrame->getRenderRate().getPeriodNsecs(), 30); |
| 2797 | } |
Adithya Srinivasan | f279e04 | 2020-08-17 14:56:27 -0700 | [diff] [blame] | 2798 | } // namespace android::frametimeline |