blob: 3136a15b0e94c06450ea3ed5e25febdfe2543212 [file] [log] [blame]
Steven Moreland65b3fd92017-12-06 14:18:35 -08001// Copyright 2017 Google Inc. All rights reserved.
2//
3// Licensed under the Apache License, Version 2.0 (the "License");
4// you may not use this file except in compliance with the License.
5// You may obtain a copy of the License at
6//
7// http://www.apache.org/licenses/LICENSE-2.0
8//
9// Unless required by applicable law or agreed to in writing, software
10// distributed under the License is distributed on an "AS IS" BASIS,
11// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
12// See the License for the specific language governing permissions and
13// limitations under the License.
14
15package android
16
17import (
Liz Kammera3d79152021-10-28 18:14:04 -040018 "fmt"
Steven Moreland65b3fd92017-12-06 14:18:35 -080019 "path/filepath"
20 "reflect"
Anton Hansson45376402020-04-09 14:18:21 +010021 "regexp"
Steven Moreland65b3fd92017-12-06 14:18:35 -080022 "strconv"
23 "strings"
24
25 "github.com/google/blueprint/proptools"
26)
27
28// "neverallow" rules for the build system.
29//
30// This allows things which aren't related to the build system and are enforced
Joe Onoratob4638c12021-10-27 15:47:06 -070031// against assumptions, in progress code refactors, or policy to be expressed in a
Steven Moreland65b3fd92017-12-06 14:18:35 -080032// straightforward away disjoint from implementations and tests which should
33// work regardless of these restrictions.
34//
35// A module is disallowed if all of the following are true:
Paul Duffin730f2a52019-06-27 14:08:51 +010036// - it is in one of the "In" paths
37// - it is not in one of the "NotIn" paths
38// - it has all "With" properties matched
Steven Moreland65b3fd92017-12-06 14:18:35 -080039// - - values are matched in their entirety
40// - - nil is interpreted as an empty string
41// - - nested properties are separated with a '.'
42// - - if the property is a list, any of the values in the list being matches
43// counts as a match
Paul Duffin730f2a52019-06-27 14:08:51 +010044// - it has none of the "Without" properties matched (same rules as above)
Steven Moreland65b3fd92017-12-06 14:18:35 -080045
Paul Duffin45338f02021-03-30 23:07:52 +010046func registerNeverallowMutator(ctx RegisterMutatorsContext) {
Colin Cross8a962802024-10-09 15:29:27 -070047 ctx.BottomUp("neverallow", neverallowMutator)
Steven Moreland65b3fd92017-12-06 14:18:35 -080048}
49
Paul Duffin730f2a52019-06-27 14:08:51 +010050var neverallows = []Rule{}
Steven Moreland65b3fd92017-12-06 14:18:35 -080051
Paul Duffin730f2a52019-06-27 14:08:51 +010052func init() {
Paul Duffinc8111702019-07-22 12:13:55 +010053 AddNeverAllowRules(createIncludeDirsRules()...)
Paul Duffin730f2a52019-06-27 14:08:51 +010054 AddNeverAllowRules(createTrebleRules()...)
Paul Duffin730f2a52019-06-27 14:08:51 +010055 AddNeverAllowRules(createJavaDeviceForHostRules()...)
Colin Crossc511bc52020-04-07 16:50:32 +000056 AddNeverAllowRules(createCcSdkVariantRules()...)
David Srbeckye033cba2020-05-20 22:20:28 +010057 AddNeverAllowRules(createUncompressDexRules()...)
Nelson Li43808202024-11-20 09:05:53 +000058 AddNeverAllowRules(createInstallInRootAllowingRules()...)
Jiyong Park3c306f32022-04-05 15:29:53 +090059 AddNeverAllowRules(createProhibitFrameworkAccessRules()...)
Alan Stokes73feba32022-11-14 12:21:24 +000060 AddNeverAllowRules(createCcStubsRule())
Mark Whitea15790a2023-08-22 21:28:11 +000061 AddNeverAllowRules(createProhibitHeaderOnlyRule())
Steven Moreland0db999c2024-09-03 22:06:24 +000062 AddNeverAllowRules(createLimitNdkExportRule()...)
Inseob Kim76e19852024-10-10 17:57:22 +090063 AddNeverAllowRules(createLimitDirgroupRule()...)
Jihoon Kang0d545b82024-10-11 00:21:57 +000064 AddNeverAllowRules(createFilesystemIsAutoGeneratedRule())
Luca Stefani50098f72024-10-12 17:55:31 +020065 AddNeverAllowRules(createKotlinPluginRule()...)
Jihoon Kang2a7bf752024-11-01 21:21:25 +000066 AddNeverAllowRules(createPrebuiltEtcBpDefineRule())
Spandan Dase2f98da2024-11-18 19:22:39 +000067 AddNeverAllowRules(createAutogenRroBpDefineRule())
Neil Fullerdf5f3562018-10-21 17:19:10 +010068}
Steven Moreland65b3fd92017-12-06 14:18:35 -080069
Paul Duffin730f2a52019-06-27 14:08:51 +010070// Add a NeverAllow rule to the set of rules to apply.
71func AddNeverAllowRules(rules ...Rule) {
72 neverallows = append(neverallows, rules...)
73}
74
Sam Delmerico46d08b42022-11-15 15:51:04 -050075var (
76 neverallowNotInIncludeDir = []string{
Paul Duffinc8111702019-07-22 12:13:55 +010077 "art",
Orion Hodson6341f012019-11-06 13:39:46 +000078 "art/libnativebridge",
79 "art/libnativeloader",
Paul Duffinc8111702019-07-22 12:13:55 +010080 "libcore",
81 "libnativehelper",
82 "external/apache-harmony",
83 "external/apache-xml",
84 "external/boringssl",
85 "external/bouncycastle",
86 "external/conscrypt",
87 "external/icu",
88 "external/okhttp",
89 "external/vixl",
90 "external/wycheproof",
Paul Duffinc8111702019-07-22 12:13:55 +010091 }
Sam Delmerico46d08b42022-11-15 15:51:04 -050092 neverallowNoUseIncludeDir = []string{
Steven Morelandf36a3ac2021-04-27 18:03:14 +000093 "frameworks/av/apex",
94 "frameworks/av/tools",
95 "frameworks/native/cmds",
96 "system/apex",
97 "system/bpf",
98 "system/gatekeeper",
99 "system/hwservicemanager",
100 "system/libbase",
Steven Moreland8fc8dbf2021-04-27 02:31:07 +0000101 "system/libfmq",
Steven Morelandf36a3ac2021-04-27 18:03:14 +0000102 "system/libvintf",
Steven Moreland8fc8dbf2021-04-27 02:31:07 +0000103 }
Sam Delmerico46d08b42022-11-15 15:51:04 -0500104)
Paul Duffinc8111702019-07-22 12:13:55 +0100105
Sam Delmerico46d08b42022-11-15 15:51:04 -0500106func createIncludeDirsRules() []Rule {
107 rules := make([]Rule, 0, len(neverallowNotInIncludeDir)+len(neverallowNoUseIncludeDir))
Steven Moreland8fc8dbf2021-04-27 02:31:07 +0000108
Sam Delmerico46d08b42022-11-15 15:51:04 -0500109 for _, path := range neverallowNotInIncludeDir {
Paul Duffinc8111702019-07-22 12:13:55 +0100110 rule :=
111 NeverAllow().
112 WithMatcher("include_dirs", StartsWith(path+"/")).
113 Because("include_dirs is deprecated, all usages of '" + path + "' have been migrated" +
114 " to use alternate mechanisms and so can no longer be used.")
115
116 rules = append(rules, rule)
117 }
118
Sam Delmerico46d08b42022-11-15 15:51:04 -0500119 for _, path := range neverallowNoUseIncludeDir {
Steven Moreland8fc8dbf2021-04-27 02:31:07 +0000120 rule := NeverAllow().In(path+"/").WithMatcher("include_dirs", isSetMatcherInstance).
121 Because("include_dirs is deprecated, all usages of them in '" + path + "' have been migrated" +
122 " to use alternate mechanisms and so can no longer be used.")
123 rules = append(rules, rule)
124 }
125
Paul Duffinc8111702019-07-22 12:13:55 +0100126 return rules
127}
128
Paul Duffin730f2a52019-06-27 14:08:51 +0100129func createTrebleRules() []Rule {
130 return []Rule{
131 NeverAllow().
132 In("vendor", "device").
133 With("vndk.enabled", "true").
134 Without("vendor", "true").
Justin Yun0ecf0b22020-02-28 15:07:59 +0900135 Without("product_specific", "true").
Paul Duffin730f2a52019-06-27 14:08:51 +0100136 Because("the VNDK can never contain a library that is device dependent."),
137 NeverAllow().
138 With("vndk.enabled", "true").
139 Without("vendor", "true").
140 Without("owner", "").
141 Because("a VNDK module can never have an owner."),
Steven Moreland65b3fd92017-12-06 14:18:35 -0800142
Neil Fullerdf5f3562018-10-21 17:19:10 +0100143 // TODO(b/67974785): always enforce the manifest
Paul Duffin730f2a52019-06-27 14:08:51 +0100144 NeverAllow().
Steven Moreland51ce4f62020-02-10 17:21:32 -0800145 Without("name", "libhidlbase-combined-impl").
146 Without("name", "libhidlbase").
Paul Duffin730f2a52019-06-27 14:08:51 +0100147 With("product_variables.enforce_vintf_manifest.cflags", "*").
148 Because("manifest enforcement should be independent of ."),
Neil Fullerdf5f3562018-10-21 17:19:10 +0100149
150 // TODO(b/67975799): vendor code should always use /vendor/bin/sh
Paul Duffin730f2a52019-06-27 14:08:51 +0100151 NeverAllow().
152 Without("name", "libc_bionic_ndk").
153 With("product_variables.treble_linker_namespaces.cflags", "*").
154 Because("nothing should care if linker namespaces are enabled or not"),
Neil Fullerdf5f3562018-10-21 17:19:10 +0100155
156 // Example:
Paul Duffin730f2a52019-06-27 14:08:51 +0100157 // *NeverAllow().with("Srcs", "main.cpp"))
Neil Fullerdf5f3562018-10-21 17:19:10 +0100158 }
159}
160
Paul Duffin730f2a52019-06-27 14:08:51 +0100161func createJavaDeviceForHostRules() []Rule {
Colin Cross440e0d02020-06-11 11:32:11 -0700162 javaDeviceForHostProjectsAllowedList := []string{
Dan Willemsen9fe14102021-07-13 21:52:04 -0700163 "development/build",
Colin Crossb5191a52019-04-11 14:07:38 -0700164 "external/guava",
Steve Elliott8053f822022-10-18 17:09:28 -0400165 "external/kotlinx.coroutines",
Colin Crossfd4f7432019-03-05 15:06:16 -0800166 "external/robolectric-shadows",
Rex Hoffman54641d22022-08-25 17:29:50 +0000167 "external/robolectric",
Makoto Onukib66bba32023-11-11 00:06:09 +0000168 "frameworks/base/ravenwood",
169 "frameworks/base/tools/hoststubgen",
Jerome Gaillard655ee022021-09-23 11:38:08 +0000170 "frameworks/layoutlib",
Colin Crossfd4f7432019-03-05 15:06:16 -0800171 }
172
Paul Duffin730f2a52019-06-27 14:08:51 +0100173 return []Rule{
174 NeverAllow().
Colin Cross440e0d02020-06-11 11:32:11 -0700175 NotIn(javaDeviceForHostProjectsAllowedList...).
Paul Duffin730f2a52019-06-27 14:08:51 +0100176 ModuleType("java_device_for_host", "java_host_for_device").
Colin Cross440e0d02020-06-11 11:32:11 -0700177 Because("java_device_for_host can only be used in allowed projects"),
Colin Crossfd4f7432019-03-05 15:06:16 -0800178 }
179}
180
Colin Crossc511bc52020-04-07 16:50:32 +0000181func createCcSdkVariantRules() []Rule {
Colin Cross440e0d02020-06-11 11:32:11 -0700182 sdkVersionOnlyAllowedList := []string{
Colin Crossc511bc52020-04-07 16:50:32 +0000183 // derive_sdk_prefer32 has stem: "derive_sdk" which conflicts with the derive_sdk.
184 // This sometimes works because the APEX modules that contain derive_sdk and
185 // derive_sdk_prefer32 suppress the platform installation rules, but fails when
186 // the APEX modules contain the SDK variant and the platform variant still exists.
Anton Hansson4b8e64b2020-05-27 18:25:23 +0100187 "packages/modules/SdkExtensions/derive_sdk",
Dan Alberte2054a92020-04-20 14:46:47 -0700188 // These are for apps and shouldn't be used by non-SDK variant modules.
189 "prebuilts/ndk",
Jiyong Parka574d532024-08-28 18:06:43 +0900190 "frameworks/native/libs/binder/ndk",
Dan Alberte2054a92020-04-20 14:46:47 -0700191 "tools/test/graphicsbenchmark/apps/sample_app",
192 "tools/test/graphicsbenchmark/functional_tests/java",
Dan Albert55576052020-04-20 14:46:47 -0700193 "vendor/xts/gts-tests/hostsidetests/gamedevicecert/apps/javatests",
Chang Li66d3cb72021-06-18 14:04:50 +0000194 "external/libtextclassifier/native",
Colin Crossc511bc52020-04-07 16:50:32 +0000195 }
196
Colin Cross440e0d02020-06-11 11:32:11 -0700197 platformVariantPropertiesAllowedList := []string{
Colin Crossc511bc52020-04-07 16:50:32 +0000198 // android_native_app_glue and libRSSupport use native_window.h but target old
199 // sdk versions (minimum and 9 respectively) where libnativewindow didn't exist,
200 // so they can't add libnativewindow to shared_libs to get the header directory
201 // for the platform variant. Allow them to use the platform variant
202 // property to set shared_libs.
203 "prebuilts/ndk",
204 "frameworks/rs",
205 }
206
207 return []Rule{
208 NeverAllow().
Colin Cross440e0d02020-06-11 11:32:11 -0700209 NotIn(sdkVersionOnlyAllowedList...).
Colin Crossc511bc52020-04-07 16:50:32 +0000210 WithMatcher("sdk_variant_only", isSetMatcherInstance).
Colin Cross440e0d02020-06-11 11:32:11 -0700211 Because("sdk_variant_only can only be used in allowed projects"),
Colin Crossc511bc52020-04-07 16:50:32 +0000212 NeverAllow().
Colin Cross440e0d02020-06-11 11:32:11 -0700213 NotIn(platformVariantPropertiesAllowedList...).
Colin Crossc511bc52020-04-07 16:50:32 +0000214 WithMatcher("platform.shared_libs", isSetMatcherInstance).
Colin Cross440e0d02020-06-11 11:32:11 -0700215 Because("platform variant properties can only be used in allowed projects"),
Colin Crossc511bc52020-04-07 16:50:32 +0000216 }
217}
218
Alan Stokes73feba32022-11-14 12:21:24 +0000219func createCcStubsRule() Rule {
220 ccStubsImplementationInstallableProjectsAllowedList := []string{
Jiyong Parkf6736c72024-07-22 11:22:35 +0900221 "packages/modules/Virtualization/libs/libvm_payload",
Alan Stokes73feba32022-11-14 12:21:24 +0000222 }
223
224 return NeverAllow().
225 NotIn(ccStubsImplementationInstallableProjectsAllowedList...).
226 WithMatcher("stubs.implementation_installable", isSetMatcherInstance).
227 Because("implementation_installable can only be used in allowed projects.")
228}
229
David Srbeckye033cba2020-05-20 22:20:28 +0100230func createUncompressDexRules() []Rule {
231 return []Rule{
232 NeverAllow().
233 NotIn("art").
234 WithMatcher("uncompress_dex", isSetMatcherInstance).
235 Because("uncompress_dex is only allowed for certain jars for test in art."),
236 }
237}
238
Nelson Li43808202024-11-20 09:05:53 +0000239func createInstallInRootAllowingRules() []Rule {
Inseob Kim800d1142021-06-14 12:03:51 +0900240 return []Rule{
241 NeverAllow().
Nikita Ioffe11a9c2c2023-06-21 16:51:09 +0100242 Without("name", "init_first_stage_defaults").
Inseob Kim800d1142021-06-14 12:03:51 +0900243 Without("name", "init_first_stage").
Nikita Ioffe11a9c2c2023-06-21 16:51:09 +0100244 Without("name", "init_first_stage.microdroid").
Nelson Li43808202024-11-20 09:05:53 +0000245 Without("name", "librecovery_ui_ext").
Inseob Kim800d1142021-06-14 12:03:51 +0900246 With("install_in_root", "true").
Inseob Kimbe6a66d2024-07-11 15:43:44 +0900247 NotModuleType("prebuilt_root").
Jihoon Kang320ca7c2024-12-03 18:14:50 +0000248 NotModuleType("prebuilt_vendor").
249 NotModuleType("prebuilt_sbin").
250 NotModuleType("prebuilt_system").
251 NotModuleType("prebuilt_first_stage_ramdisk").
Jihoon Kang96f38d22024-12-03 23:17:55 +0000252 NotModuleType("prebuilt_res").
Jihoon Kang3e149662025-03-12 22:14:39 +0000253 NotModuleType("prebuilt_any").
Nelson Li43808202024-11-20 09:05:53 +0000254 Because("install_in_root is only for init_first_stage or librecovery_ui_ext."),
Inseob Kim800d1142021-06-14 12:03:51 +0900255 }
256}
257
Jiyong Park3c306f32022-04-05 15:29:53 +0900258func createProhibitFrameworkAccessRules() []Rule {
259 return []Rule{
260 NeverAllow().
261 With("libs", "framework").
262 WithoutMatcher("sdk_version", Regexp("(core_.*|^$)")).
263 Because("framework can't be used when building against SDK"),
264 }
265}
266
Mark Whitea15790a2023-08-22 21:28:11 +0000267func createProhibitHeaderOnlyRule() Rule {
268 return NeverAllow().
269 Without("name", "framework-minus-apex-headers").
270 With("headers_only", "true").
271 Because("headers_only can only be used for generating framework-minus-apex headers for non-updatable modules")
272}
273
Steven Moreland0db999c2024-09-03 22:06:24 +0000274func createLimitNdkExportRule() []Rule {
275 reason := "If the headers you're trying to export are meant to be a part of the NDK, they should be exposed by an ndk_headers module. If the headers shouldn't be a part of the NDK, the headers should instead be exposed from a separate `cc_library_headers` which consumers depend on."
276 // DO NOT ADD HERE - please consult danalbert@
277 // b/357711733
278 return []Rule{
279 NeverAllow().
280 NotIn("frameworks/native/libs/binder/ndk").
281 ModuleType("ndk_library").
282 WithMatcher("export_header_libs", isSetMatcherInstance).Because(reason),
283 NeverAllow().ModuleType("ndk_library").WithMatcher("export_generated_headers", isSetMatcherInstance).Because(reason),
284 NeverAllow().ModuleType("ndk_library").WithMatcher("export_include_dirs", isSetMatcherInstance).Because(reason),
285 NeverAllow().ModuleType("ndk_library").WithMatcher("export_shared_lib_headers", isSetMatcherInstance).Because(reason),
286 NeverAllow().ModuleType("ndk_library").WithMatcher("export_static_lib_headers", isSetMatcherInstance).Because(reason),
287 }
288}
289
Inseob Kim76e19852024-10-10 17:57:22 +0900290func createLimitDirgroupRule() []Rule {
Inseob Kim7195b062024-11-29 15:40:49 +0900291 reason := "dirgroup module and dir_srcs / keep_gendir property of genrule is allowed only to Trusty build rule."
Inseob Kim76e19852024-10-10 17:57:22 +0900292 return []Rule{
293 NeverAllow().
294 ModuleType("dirgroup").
295 WithMatcher("visibility", NotInList([]string{"//trusty/vendor/google/aosp/scripts"})).Because(reason),
296 NeverAllow().
297 ModuleType("dirgroup").
298 Without("visibility", "//trusty/vendor/google/aosp/scripts").Because(reason),
299 NeverAllow().
300 ModuleType("genrule").
Inseob Kime8b1ac42024-10-24 09:27:44 +0000301 Without("name", "trusty-arm64.lk.elf.gen").
Alice Wang38aed8d2024-11-27 08:18:59 +0000302 Without("name", "trusty-arm64-virt-test-debug.lk.elf.gen").
Inseob Kime8b1ac42024-10-24 09:27:44 +0000303 Without("name", "trusty-x86_64.lk.elf.gen").
304 Without("name", "trusty-x86_64-test.lk.elf.gen").
Inseob Kim76e19852024-10-10 17:57:22 +0900305 WithMatcher("dir_srcs", isSetMatcherInstance).Because(reason),
Inseob Kim7195b062024-11-29 15:40:49 +0900306 NeverAllow().
307 ModuleType("genrule").
308 Without("name", "trusty-arm64.lk.elf.gen").
309 Without("name", "trusty-arm64-virt-test-debug.lk.elf.gen").
310 Without("name", "trusty-x86_64.lk.elf.gen").
311 Without("name", "trusty-x86_64-test.lk.elf.gen").
312 With("keep_gendir", "true").Because(reason),
Inseob Kim76e19852024-10-10 17:57:22 +0900313 }
314}
315
Jihoon Kang0d545b82024-10-11 00:21:57 +0000316func createFilesystemIsAutoGeneratedRule() Rule {
317 return NeverAllow().
318 NotIn("build/soong/fsgen").
319 ModuleType("filesystem", "android_system_image").
320 WithMatcher("is_auto_generated", isSetMatcherInstance).
321 Because("is_auto_generated property is only allowed for filesystem modules in build/soong/fsgen directory")
322}
323
Luca Stefani50098f72024-10-12 17:55:31 +0200324func createKotlinPluginRule() []Rule {
325 kotlinPluginProjectsAllowedList := []string{
326 // TODO: Migrate compose plugin to the bundled compiler plugin
327 // Actual path prebuilts/sdk/current/androidx/m2repository/androidx/compose/compiler/compiler-hosted
328 "prebuilts/sdk/current/androidx",
329 "external/kotlinc",
330 }
331
332 return []Rule{
333 NeverAllow().
334 NotIn(kotlinPluginProjectsAllowedList...).
335 ModuleType("kotlin_plugin").
336 Because("kotlin_plugin can only be used in allowed projects"),
337 }
338}
339
Jihoon Kang2a7bf752024-11-01 21:21:25 +0000340// These module types are introduced to convert PRODUCT_COPY_FILES to Soong,
341// and is only intended to be used by filesystem_creator.
342func createPrebuiltEtcBpDefineRule() Rule {
343 return NeverAllow().
344 ModuleType(
Jihoon Kang3e149662025-03-12 22:14:39 +0000345 "prebuilt_any",
Jihoon Kang2a7bf752024-11-01 21:21:25 +0000346 "prebuilt_usr_srec",
347 "prebuilt_priv_app",
348 "prebuilt_rfs",
349 "prebuilt_framework",
Jihoon Kang2a7bf752024-11-01 21:21:25 +0000350 "prebuilt_wlc_upt",
351 "prebuilt_odm",
Jihoon Kang2e2b7442024-11-05 00:26:20 +0000352 "prebuilt_vendor_dlkm",
353 "prebuilt_bt_firmware",
Jihoon Kangdca2f2b2024-11-06 18:43:19 +0000354 "prebuilt_tvservice",
355 "prebuilt_optee",
Jihoon Kangecf76dd2024-11-12 05:24:46 +0000356 "prebuilt_tvconfig",
Jihoon Kang3ca07a12024-12-02 19:14:30 +0000357 "prebuilt_vendor",
Jihoon Kang320ca7c2024-12-03 18:14:50 +0000358 "prebuilt_sbin",
359 "prebuilt_system",
360 "prebuilt_first_stage_ramdisk",
Jihoon Kang2a7bf752024-11-01 21:21:25 +0000361 ).
362 DefinedInBpFile().
363 Because("module type not allowed to be defined in bp file")
364}
365
Spandan Dase2f98da2024-11-18 19:22:39 +0000366func createAutogenRroBpDefineRule() Rule {
367 return NeverAllow().
368 ModuleType(
369 "autogen_runtime_resource_overlay",
370 ).
371 DefinedInBpFile().
372 Because("Module type will be autogenerated by soong. Use runtime_resource_overlay instead")
373}
374
Steven Moreland65b3fd92017-12-06 14:18:35 -0800375func neverallowMutator(ctx BottomUpMutatorContext) {
376 m, ok := ctx.Module().(Module)
377 if !ok {
378 return
379 }
380
381 dir := ctx.ModuleDir() + "/"
382 properties := m.GetProperties()
383
Paul Duffinf1c9bbe2019-07-26 10:48:06 +0100384 osClass := ctx.Module().Target().Os.Class
385
Paul Duffin115445b2019-08-07 15:31:07 +0100386 for _, r := range neverallowRules(ctx.Config()) {
Paul Duffin730f2a52019-06-27 14:08:51 +0100387 n := r.(*rule)
Steven Moreland65b3fd92017-12-06 14:18:35 -0800388 if !n.appliesToPath(dir) {
389 continue
390 }
391
Colin Crossfd4f7432019-03-05 15:06:16 -0800392 if !n.appliesToModuleType(ctx.ModuleType()) {
393 continue
394 }
395
Cole Faust5b35cb92024-08-27 15:47:06 -0700396 if !n.appliesToProperties(ctx, properties) {
Steven Moreland65b3fd92017-12-06 14:18:35 -0800397 continue
398 }
399
Paul Duffinf1c9bbe2019-07-26 10:48:06 +0100400 if !n.appliesToOsClass(osClass) {
401 continue
402 }
403
Paul Duffin35781882019-07-25 15:41:09 +0100404 if !n.appliesToDirectDeps(ctx) {
405 continue
406 }
407
Jihoon Kang2a7bf752024-11-01 21:21:25 +0000408 if !n.appliesToBpDefinedModule(ctx) {
409 continue
410 }
411
Steven Moreland65b3fd92017-12-06 14:18:35 -0800412 ctx.ModuleErrorf("violates " + n.String())
413 }
414}
415
Paul Duffin73bf0542019-07-12 14:12:49 +0100416type ValueMatcher interface {
Anton Hanssone1b18362021-12-23 15:05:38 +0000417 Test(string) bool
Paul Duffin73bf0542019-07-12 14:12:49 +0100418 String() string
419}
420
421type equalMatcher struct {
422 expected string
423}
424
Anton Hanssone1b18362021-12-23 15:05:38 +0000425func (m *equalMatcher) Test(value string) bool {
Paul Duffin73bf0542019-07-12 14:12:49 +0100426 return m.expected == value
427}
428
429func (m *equalMatcher) String() string {
430 return "=" + m.expected
431}
432
433type anyMatcher struct {
434}
435
Anton Hanssone1b18362021-12-23 15:05:38 +0000436func (m *anyMatcher) Test(value string) bool {
Paul Duffin73bf0542019-07-12 14:12:49 +0100437 return true
438}
439
440func (m *anyMatcher) String() string {
441 return "=*"
442}
443
444var anyMatcherInstance = &anyMatcher{}
445
Paul Duffinc8111702019-07-22 12:13:55 +0100446type startsWithMatcher struct {
447 prefix string
448}
449
Anton Hanssone1b18362021-12-23 15:05:38 +0000450func (m *startsWithMatcher) Test(value string) bool {
Paul Duffinc8111702019-07-22 12:13:55 +0100451 return strings.HasPrefix(value, m.prefix)
452}
453
454func (m *startsWithMatcher) String() string {
455 return ".starts-with(" + m.prefix + ")"
456}
457
Anton Hansson45376402020-04-09 14:18:21 +0100458type regexMatcher struct {
459 re *regexp.Regexp
460}
461
Anton Hanssone1b18362021-12-23 15:05:38 +0000462func (m *regexMatcher) Test(value string) bool {
Anton Hansson45376402020-04-09 14:18:21 +0100463 return m.re.MatchString(value)
464}
465
466func (m *regexMatcher) String() string {
467 return ".regexp(" + m.re.String() + ")"
468}
469
Andrei Onea115e7e72020-06-05 21:14:03 +0100470type notInListMatcher struct {
471 allowed []string
472}
473
Anton Hanssone1b18362021-12-23 15:05:38 +0000474func (m *notInListMatcher) Test(value string) bool {
Andrei Onea115e7e72020-06-05 21:14:03 +0100475 return !InList(value, m.allowed)
476}
477
478func (m *notInListMatcher) String() string {
479 return ".not-in-list(" + strings.Join(m.allowed, ",") + ")"
480}
481
Colin Crossc511bc52020-04-07 16:50:32 +0000482type isSetMatcher struct{}
483
Anton Hanssone1b18362021-12-23 15:05:38 +0000484func (m *isSetMatcher) Test(value string) bool {
Colin Crossc511bc52020-04-07 16:50:32 +0000485 return value != ""
486}
487
488func (m *isSetMatcher) String() string {
489 return ".is-set"
490}
491
492var isSetMatcherInstance = &isSetMatcher{}
493
Steven Moreland65b3fd92017-12-06 14:18:35 -0800494type ruleProperty struct {
Paul Duffin73bf0542019-07-12 14:12:49 +0100495 fields []string // e.x.: Vndk.Enabled
496 matcher ValueMatcher
Steven Moreland65b3fd92017-12-06 14:18:35 -0800497}
498
Liz Kammera3d79152021-10-28 18:14:04 -0400499func (r *ruleProperty) String() string {
500 return fmt.Sprintf("%q matches: %s", strings.Join(r.fields, "."), r.matcher)
501}
502
503type ruleProperties []ruleProperty
504
505func (r ruleProperties) String() string {
506 var s []string
507 for _, r := range r {
508 s = append(s, r.String())
509 }
510 return strings.Join(s, " ")
511}
512
Paul Duffin730f2a52019-06-27 14:08:51 +0100513// A NeverAllow rule.
514type Rule interface {
515 In(path ...string) Rule
516
517 NotIn(path ...string) Rule
518
Paul Duffin35781882019-07-25 15:41:09 +0100519 InDirectDeps(deps ...string) Rule
520
Paul Duffinf1c9bbe2019-07-26 10:48:06 +0100521 WithOsClass(osClasses ...OsClass) Rule
522
Paul Duffin730f2a52019-06-27 14:08:51 +0100523 ModuleType(types ...string) Rule
524
525 NotModuleType(types ...string) Rule
526
527 With(properties, value string) Rule
528
Paul Duffinc8111702019-07-22 12:13:55 +0100529 WithMatcher(properties string, matcher ValueMatcher) Rule
530
Paul Duffin730f2a52019-06-27 14:08:51 +0100531 Without(properties, value string) Rule
532
Paul Duffinc8111702019-07-22 12:13:55 +0100533 WithoutMatcher(properties string, matcher ValueMatcher) Rule
534
Jihoon Kang2a7bf752024-11-01 21:21:25 +0000535 DefinedInBpFile() Rule
536
Paul Duffin730f2a52019-06-27 14:08:51 +0100537 Because(reason string) Rule
538}
539
Steven Moreland65b3fd92017-12-06 14:18:35 -0800540type rule struct {
541 // User string for why this is a thing.
542 reason string
543
544 paths []string
545 unlessPaths []string
546
Paul Duffin35781882019-07-25 15:41:09 +0100547 directDeps map[string]bool
548
Paul Duffinf1c9bbe2019-07-26 10:48:06 +0100549 osClasses []OsClass
550
Colin Crossfd4f7432019-03-05 15:06:16 -0800551 moduleTypes []string
552 unlessModuleTypes []string
553
Liz Kammera3d79152021-10-28 18:14:04 -0400554 props ruleProperties
555 unlessProps ruleProperties
Andrei Onea115e7e72020-06-05 21:14:03 +0100556
557 onlyBootclasspathJar bool
Jihoon Kang2a7bf752024-11-01 21:21:25 +0000558
559 definedInBp bool
Steven Moreland65b3fd92017-12-06 14:18:35 -0800560}
561
Paul Duffin730f2a52019-06-27 14:08:51 +0100562// Create a new NeverAllow rule.
563func NeverAllow() Rule {
Paul Duffin35781882019-07-25 15:41:09 +0100564 return &rule{directDeps: make(map[string]bool)}
Steven Moreland65b3fd92017-12-06 14:18:35 -0800565}
Colin Crossfd4f7432019-03-05 15:06:16 -0800566
Liz Kammera3d79152021-10-28 18:14:04 -0400567// In adds path(s) where this rule applies.
Paul Duffin730f2a52019-06-27 14:08:51 +0100568func (r *rule) In(path ...string) Rule {
Steven Moreland65b3fd92017-12-06 14:18:35 -0800569 r.paths = append(r.paths, cleanPaths(path)...)
570 return r
571}
Colin Crossfd4f7432019-03-05 15:06:16 -0800572
Liz Kammera3d79152021-10-28 18:14:04 -0400573// NotIn adds path(s) to that this rule does not apply to.
Paul Duffin730f2a52019-06-27 14:08:51 +0100574func (r *rule) NotIn(path ...string) Rule {
Steven Moreland65b3fd92017-12-06 14:18:35 -0800575 r.unlessPaths = append(r.unlessPaths, cleanPaths(path)...)
576 return r
577}
Colin Crossfd4f7432019-03-05 15:06:16 -0800578
Liz Kammera3d79152021-10-28 18:14:04 -0400579// InDirectDeps adds dep(s) that are not allowed with this rule.
Paul Duffin35781882019-07-25 15:41:09 +0100580func (r *rule) InDirectDeps(deps ...string) Rule {
581 for _, d := range deps {
582 r.directDeps[d] = true
583 }
584 return r
585}
586
Liz Kammera3d79152021-10-28 18:14:04 -0400587// WithOsClass adds osClass(es) that this rule applies to.
Paul Duffinf1c9bbe2019-07-26 10:48:06 +0100588func (r *rule) WithOsClass(osClasses ...OsClass) Rule {
589 r.osClasses = append(r.osClasses, osClasses...)
590 return r
591}
592
Liz Kammera3d79152021-10-28 18:14:04 -0400593// ModuleType adds type(s) that this rule applies to.
Paul Duffin730f2a52019-06-27 14:08:51 +0100594func (r *rule) ModuleType(types ...string) Rule {
Colin Crossfd4f7432019-03-05 15:06:16 -0800595 r.moduleTypes = append(r.moduleTypes, types...)
596 return r
597}
598
Liz Kammera3d79152021-10-28 18:14:04 -0400599// NotModuleType adds type(s) that this rule does not apply to..
Paul Duffin730f2a52019-06-27 14:08:51 +0100600func (r *rule) NotModuleType(types ...string) Rule {
Colin Crossfd4f7432019-03-05 15:06:16 -0800601 r.unlessModuleTypes = append(r.unlessModuleTypes, types...)
602 return r
603}
604
Liz Kammera3d79152021-10-28 18:14:04 -0400605// With specifies property/value combinations that are restricted for this rule.
Paul Duffin730f2a52019-06-27 14:08:51 +0100606func (r *rule) With(properties, value string) Rule {
Paul Duffinc8111702019-07-22 12:13:55 +0100607 return r.WithMatcher(properties, selectMatcher(value))
608}
609
Liz Kammera3d79152021-10-28 18:14:04 -0400610// WithMatcher specifies property/matcher combinations that are restricted for this rule.
Paul Duffinc8111702019-07-22 12:13:55 +0100611func (r *rule) WithMatcher(properties string, matcher ValueMatcher) Rule {
Steven Moreland65b3fd92017-12-06 14:18:35 -0800612 r.props = append(r.props, ruleProperty{
Paul Duffin73bf0542019-07-12 14:12:49 +0100613 fields: fieldNamesForProperties(properties),
Paul Duffinc8111702019-07-22 12:13:55 +0100614 matcher: matcher,
Steven Moreland65b3fd92017-12-06 14:18:35 -0800615 })
616 return r
617}
Colin Crossfd4f7432019-03-05 15:06:16 -0800618
Liz Kammera3d79152021-10-28 18:14:04 -0400619// Without specifies property/value combinations that this rule does not apply to.
Paul Duffin730f2a52019-06-27 14:08:51 +0100620func (r *rule) Without(properties, value string) Rule {
Paul Duffinc8111702019-07-22 12:13:55 +0100621 return r.WithoutMatcher(properties, selectMatcher(value))
622}
623
Liz Kammera3d79152021-10-28 18:14:04 -0400624// Without specifies property/matcher combinations that this rule does not apply to.
Paul Duffinc8111702019-07-22 12:13:55 +0100625func (r *rule) WithoutMatcher(properties string, matcher ValueMatcher) Rule {
Steven Moreland65b3fd92017-12-06 14:18:35 -0800626 r.unlessProps = append(r.unlessProps, ruleProperty{
Paul Duffin73bf0542019-07-12 14:12:49 +0100627 fields: fieldNamesForProperties(properties),
Paul Duffinc8111702019-07-22 12:13:55 +0100628 matcher: matcher,
Steven Moreland65b3fd92017-12-06 14:18:35 -0800629 })
630 return r
631}
Colin Crossfd4f7432019-03-05 15:06:16 -0800632
Jihoon Kang2a7bf752024-11-01 21:21:25 +0000633// DefinedInBpFile specifies that this rule applies to modules that are defined
634// in bp files, and does not apply to modules that are auto generated by other modules.
635func (r *rule) DefinedInBpFile() Rule {
636 r.definedInBp = true
637 return r
638}
639
Paul Duffin73bf0542019-07-12 14:12:49 +0100640func selectMatcher(expected string) ValueMatcher {
641 if expected == "*" {
642 return anyMatcherInstance
643 }
644 return &equalMatcher{expected: expected}
645}
646
Liz Kammera3d79152021-10-28 18:14:04 -0400647// Because specifies a reason for this rule.
Paul Duffin730f2a52019-06-27 14:08:51 +0100648func (r *rule) Because(reason string) Rule {
Steven Moreland65b3fd92017-12-06 14:18:35 -0800649 r.reason = reason
650 return r
651}
652
653func (r *rule) String() string {
Liz Kammera3d79152021-10-28 18:14:04 -0400654 s := []string{"neverallow requirements. Not allowed:"}
655 if len(r.paths) > 0 {
656 s = append(s, fmt.Sprintf("in dirs: %q", r.paths))
Steven Moreland65b3fd92017-12-06 14:18:35 -0800657 }
Liz Kammera3d79152021-10-28 18:14:04 -0400658 if len(r.moduleTypes) > 0 {
659 s = append(s, fmt.Sprintf("module types: %q", r.moduleTypes))
Steven Moreland65b3fd92017-12-06 14:18:35 -0800660 }
Liz Kammera3d79152021-10-28 18:14:04 -0400661 if len(r.props) > 0 {
662 s = append(s, fmt.Sprintf("properties matching: %s", r.props))
Colin Crossfd4f7432019-03-05 15:06:16 -0800663 }
Liz Kammera3d79152021-10-28 18:14:04 -0400664 if len(r.directDeps) > 0 {
Cole Faust18994c72023-02-28 16:02:16 -0800665 s = append(s, fmt.Sprintf("dep(s): %q", SortedKeys(r.directDeps)))
Colin Crossfd4f7432019-03-05 15:06:16 -0800666 }
Liz Kammera3d79152021-10-28 18:14:04 -0400667 if len(r.osClasses) > 0 {
668 s = append(s, fmt.Sprintf("os class(es): %q", r.osClasses))
Paul Duffinf1c9bbe2019-07-26 10:48:06 +0100669 }
Liz Kammera3d79152021-10-28 18:14:04 -0400670 if len(r.unlessPaths) > 0 {
671 s = append(s, fmt.Sprintf("EXCEPT in dirs: %q", r.unlessPaths))
672 }
673 if len(r.unlessModuleTypes) > 0 {
674 s = append(s, fmt.Sprintf("EXCEPT module types: %q", r.unlessModuleTypes))
675 }
676 if len(r.unlessProps) > 0 {
677 s = append(s, fmt.Sprintf("EXCEPT properties matching: %q", r.unlessProps))
Andrei Onea115e7e72020-06-05 21:14:03 +0100678 }
Steven Moreland65b3fd92017-12-06 14:18:35 -0800679 if len(r.reason) != 0 {
Liz Kammera3d79152021-10-28 18:14:04 -0400680 s = append(s, " which is restricted because "+r.reason)
Steven Moreland65b3fd92017-12-06 14:18:35 -0800681 }
Liz Kammera3d79152021-10-28 18:14:04 -0400682 if len(s) == 1 {
683 s[0] = "neverallow requirements (empty)"
684 }
685 return strings.Join(s, "\n\t")
Steven Moreland65b3fd92017-12-06 14:18:35 -0800686}
687
688func (r *rule) appliesToPath(dir string) bool {
Jaewoong Jung3aff5782020-02-11 07:54:35 -0800689 includePath := len(r.paths) == 0 || HasAnyPrefix(dir, r.paths)
690 excludePath := HasAnyPrefix(dir, r.unlessPaths)
Steven Moreland65b3fd92017-12-06 14:18:35 -0800691 return includePath && !excludePath
692}
693
Paul Duffin35781882019-07-25 15:41:09 +0100694func (r *rule) appliesToDirectDeps(ctx BottomUpMutatorContext) bool {
695 if len(r.directDeps) == 0 {
696 return true
697 }
698
699 matches := false
700 ctx.VisitDirectDeps(func(m Module) {
701 if !matches {
702 name := ctx.OtherModuleName(m)
703 matches = r.directDeps[name]
704 }
705 })
706
707 return matches
708}
709
Paul Duffinf1c9bbe2019-07-26 10:48:06 +0100710func (r *rule) appliesToOsClass(osClass OsClass) bool {
711 if len(r.osClasses) == 0 {
712 return true
713 }
714
715 for _, c := range r.osClasses {
716 if c == osClass {
717 return true
718 }
719 }
720
721 return false
722}
723
Colin Crossfd4f7432019-03-05 15:06:16 -0800724func (r *rule) appliesToModuleType(moduleType string) bool {
Jihoon Kangd5465072024-12-03 00:53:05 +0000725 // Remove prefix for auto-generated modules
726 moduleType = strings.TrimSuffix(moduleType, "__loadHookModule")
727 moduleType = strings.TrimSuffix(moduleType, "__bottomUpMutatorModule")
Colin Crossfd4f7432019-03-05 15:06:16 -0800728 return (len(r.moduleTypes) == 0 || InList(moduleType, r.moduleTypes)) && !InList(moduleType, r.unlessModuleTypes)
729}
730
Cole Faust5b35cb92024-08-27 15:47:06 -0700731func (r *rule) appliesToProperties(ctx BottomUpMutatorContext, properties []interface{}) bool {
732 includeProps := hasAllProperties(ctx, properties, r.props)
733 excludeProps := hasAnyProperty(ctx, properties, r.unlessProps)
Steven Moreland65b3fd92017-12-06 14:18:35 -0800734 return includeProps && !excludeProps
735}
736
Jihoon Kang2a7bf752024-11-01 21:21:25 +0000737func (r *rule) appliesToBpDefinedModule(ctx BottomUpMutatorContext) bool {
738 if !r.definedInBp {
739 return true
740 }
741 return !ctx.OtherModuleIsAutoGenerated(ctx.Module()) == r.definedInBp
742}
743
Paul Duffinc8111702019-07-22 12:13:55 +0100744func StartsWith(prefix string) ValueMatcher {
745 return &startsWithMatcher{prefix}
746}
747
Anton Hansson45376402020-04-09 14:18:21 +0100748func Regexp(re string) ValueMatcher {
749 r, err := regexp.Compile(re)
750 if err != nil {
751 panic(err)
752 }
753 return &regexMatcher{r}
754}
755
Andrei Onea115e7e72020-06-05 21:14:03 +0100756func NotInList(allowed []string) ValueMatcher {
757 return &notInListMatcher{allowed}
758}
759
Steven Moreland65b3fd92017-12-06 14:18:35 -0800760// assorted utils
761
762func cleanPaths(paths []string) []string {
763 res := make([]string, len(paths))
764 for i, v := range paths {
765 res[i] = filepath.Clean(v) + "/"
766 }
767 return res
768}
769
770func fieldNamesForProperties(propertyNames string) []string {
771 names := strings.Split(propertyNames, ".")
772 for i, v := range names {
773 names[i] = proptools.FieldNameForProperty(v)
774 }
775 return names
776}
777
Cole Faust5b35cb92024-08-27 15:47:06 -0700778func hasAnyProperty(ctx BottomUpMutatorContext, properties []interface{}, props []ruleProperty) bool {
Steven Moreland65b3fd92017-12-06 14:18:35 -0800779 for _, v := range props {
Cole Faust5b35cb92024-08-27 15:47:06 -0700780 if hasProperty(ctx, properties, v) {
Steven Moreland65b3fd92017-12-06 14:18:35 -0800781 return true
782 }
783 }
784 return false
785}
786
Cole Faust5b35cb92024-08-27 15:47:06 -0700787func hasAllProperties(ctx BottomUpMutatorContext, properties []interface{}, props []ruleProperty) bool {
Steven Moreland65b3fd92017-12-06 14:18:35 -0800788 for _, v := range props {
Cole Faust5b35cb92024-08-27 15:47:06 -0700789 if !hasProperty(ctx, properties, v) {
Steven Moreland65b3fd92017-12-06 14:18:35 -0800790 return false
791 }
792 }
793 return true
794}
795
Cole Faust5b35cb92024-08-27 15:47:06 -0700796func hasProperty(ctx BottomUpMutatorContext, properties []interface{}, prop ruleProperty) bool {
Steven Moreland65b3fd92017-12-06 14:18:35 -0800797 for _, propertyStruct := range properties {
798 propertiesValue := reflect.ValueOf(propertyStruct).Elem()
799 for _, v := range prop.fields {
800 if !propertiesValue.IsValid() {
801 break
802 }
803 propertiesValue = propertiesValue.FieldByName(v)
804 }
805 if !propertiesValue.IsValid() {
806 continue
807 }
808
Paul Duffin73bf0542019-07-12 14:12:49 +0100809 check := func(value string) bool {
Anton Hanssone1b18362021-12-23 15:05:38 +0000810 return prop.matcher.Test(value)
Steven Moreland65b3fd92017-12-06 14:18:35 -0800811 }
812
Cole Faust5b35cb92024-08-27 15:47:06 -0700813 if matchValue(ctx, propertiesValue, check) {
Steven Moreland65b3fd92017-12-06 14:18:35 -0800814 return true
815 }
816 }
817 return false
818}
819
Cole Faust5b35cb92024-08-27 15:47:06 -0700820func matchValue(ctx BottomUpMutatorContext, value reflect.Value, check func(string) bool) bool {
Steven Moreland65b3fd92017-12-06 14:18:35 -0800821 if !value.IsValid() {
822 return false
823 }
824
825 if value.Kind() == reflect.Ptr {
826 if value.IsNil() {
827 return check("")
828 }
829 value = value.Elem()
830 }
831
Cole Faust5b35cb92024-08-27 15:47:06 -0700832 switch v := value.Interface().(type) {
833 case string:
834 return check(v)
835 case bool:
836 return check(strconv.FormatBool(v))
837 case int:
838 return check(strconv.FormatInt((int64)(v), 10))
839 case []string:
840 for _, v := range v {
841 if check(v) {
842 return true
843 }
Steven Moreland65b3fd92017-12-06 14:18:35 -0800844 }
Cole Faust5b35cb92024-08-27 15:47:06 -0700845 return false
846 case proptools.Configurable[string]:
847 return check(v.GetOrDefault(ctx, ""))
848 case proptools.Configurable[bool]:
849 return check(strconv.FormatBool(v.GetOrDefault(ctx, false)))
850 case proptools.Configurable[[]string]:
851 for _, v := range v.GetOrDefault(ctx, nil) {
Steven Moreland65b3fd92017-12-06 14:18:35 -0800852 if check(v) {
853 return true
854 }
855 }
856 return false
857 }
858
859 panic("Can't handle type: " + value.Kind().String())
860}
Paul Duffin115445b2019-08-07 15:31:07 +0100861
862var neverallowRulesKey = NewOnceKey("neverallowRules")
863
864func neverallowRules(config Config) []Rule {
865 return config.Once(neverallowRulesKey, func() interface{} {
866 // No test rules were set by setTestNeverallowRules, use the global rules
867 return neverallows
868 }).([]Rule)
869}
870
871// Overrides the default neverallow rules for the supplied config.
872//
873// For testing only.
Paul Duffin45338f02021-03-30 23:07:52 +0100874func setTestNeverallowRules(config Config, testRules []Rule) {
Paul Duffin115445b2019-08-07 15:31:07 +0100875 config.Once(neverallowRulesKey, func() interface{} { return testRules })
876}
Paul Duffin45338f02021-03-30 23:07:52 +0100877
878// Prepares for a test by setting neverallow rules and enabling the mutator.
879//
880// If the supplied rules are nil then the default rules are used.
881func PrepareForTestWithNeverallowRules(testRules []Rule) FixturePreparer {
882 return GroupFixturePreparers(
883 FixtureModifyConfig(func(config Config) {
884 if testRules != nil {
885 setTestNeverallowRules(config, testRules)
886 }
887 }),
888 FixtureRegisterWithContext(func(ctx RegistrationContext) {
889 ctx.PostDepsMutators(registerNeverallowMutator)
890 }),
891 )
892}