blob: 1213704bc7592f345cd6c4f642af6cc353d58aac [file] [log] [blame]
Steven Moreland65b3fd92017-12-06 14:18:35 -08001// Copyright 2017 Google Inc. All rights reserved.
2//
3// Licensed under the Apache License, Version 2.0 (the "License");
4// you may not use this file except in compliance with the License.
5// You may obtain a copy of the License at
6//
7// http://www.apache.org/licenses/LICENSE-2.0
8//
9// Unless required by applicable law or agreed to in writing, software
10// distributed under the License is distributed on an "AS IS" BASIS,
11// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
12// See the License for the specific language governing permissions and
13// limitations under the License.
14
15package android
16
17import (
Liz Kammera3d79152021-10-28 18:14:04 -040018 "fmt"
Steven Moreland65b3fd92017-12-06 14:18:35 -080019 "path/filepath"
20 "reflect"
Anton Hansson45376402020-04-09 14:18:21 +010021 "regexp"
Steven Moreland65b3fd92017-12-06 14:18:35 -080022 "strconv"
23 "strings"
24
25 "github.com/google/blueprint/proptools"
26)
27
28// "neverallow" rules for the build system.
29//
30// This allows things which aren't related to the build system and are enforced
Joe Onoratob4638c12021-10-27 15:47:06 -070031// against assumptions, in progress code refactors, or policy to be expressed in a
Steven Moreland65b3fd92017-12-06 14:18:35 -080032// straightforward away disjoint from implementations and tests which should
33// work regardless of these restrictions.
34//
35// A module is disallowed if all of the following are true:
Paul Duffin730f2a52019-06-27 14:08:51 +010036// - it is in one of the "In" paths
37// - it is not in one of the "NotIn" paths
38// - it has all "With" properties matched
Steven Moreland65b3fd92017-12-06 14:18:35 -080039// - - values are matched in their entirety
40// - - nil is interpreted as an empty string
41// - - nested properties are separated with a '.'
42// - - if the property is a list, any of the values in the list being matches
43// counts as a match
Paul Duffin730f2a52019-06-27 14:08:51 +010044// - it has none of the "Without" properties matched (same rules as above)
Steven Moreland65b3fd92017-12-06 14:18:35 -080045
Paul Duffin45338f02021-03-30 23:07:52 +010046func registerNeverallowMutator(ctx RegisterMutatorsContext) {
Colin Cross8a962802024-10-09 15:29:27 -070047 ctx.BottomUp("neverallow", neverallowMutator)
Steven Moreland65b3fd92017-12-06 14:18:35 -080048}
49
Paul Duffin730f2a52019-06-27 14:08:51 +010050var neverallows = []Rule{}
Steven Moreland65b3fd92017-12-06 14:18:35 -080051
Paul Duffin730f2a52019-06-27 14:08:51 +010052func init() {
Paul Duffinc8111702019-07-22 12:13:55 +010053 AddNeverAllowRules(createIncludeDirsRules()...)
Paul Duffin730f2a52019-06-27 14:08:51 +010054 AddNeverAllowRules(createTrebleRules()...)
Paul Duffin730f2a52019-06-27 14:08:51 +010055 AddNeverAllowRules(createJavaDeviceForHostRules()...)
Colin Crossc511bc52020-04-07 16:50:32 +000056 AddNeverAllowRules(createCcSdkVariantRules()...)
David Srbeckye033cba2020-05-20 22:20:28 +010057 AddNeverAllowRules(createUncompressDexRules()...)
Nelson Li43808202024-11-20 09:05:53 +000058 AddNeverAllowRules(createInstallInRootAllowingRules()...)
Jiyong Park3c306f32022-04-05 15:29:53 +090059 AddNeverAllowRules(createProhibitFrameworkAccessRules()...)
Alan Stokes73feba32022-11-14 12:21:24 +000060 AddNeverAllowRules(createCcStubsRule())
Mark Whitea15790a2023-08-22 21:28:11 +000061 AddNeverAllowRules(createProhibitHeaderOnlyRule())
Steven Moreland0db999c2024-09-03 22:06:24 +000062 AddNeverAllowRules(createLimitNdkExportRule()...)
Inseob Kim76e19852024-10-10 17:57:22 +090063 AddNeverAllowRules(createLimitDirgroupRule()...)
Jihoon Kang0d545b82024-10-11 00:21:57 +000064 AddNeverAllowRules(createFilesystemIsAutoGeneratedRule())
Luca Stefani50098f72024-10-12 17:55:31 +020065 AddNeverAllowRules(createKotlinPluginRule()...)
Jihoon Kang2a7bf752024-11-01 21:21:25 +000066 AddNeverAllowRules(createPrebuiltEtcBpDefineRule())
Spandan Dase2f98da2024-11-18 19:22:39 +000067 AddNeverAllowRules(createAutogenRroBpDefineRule())
Neil Fullerdf5f3562018-10-21 17:19:10 +010068}
Steven Moreland65b3fd92017-12-06 14:18:35 -080069
Paul Duffin730f2a52019-06-27 14:08:51 +010070// Add a NeverAllow rule to the set of rules to apply.
71func AddNeverAllowRules(rules ...Rule) {
72 neverallows = append(neverallows, rules...)
73}
74
Sam Delmerico46d08b42022-11-15 15:51:04 -050075var (
76 neverallowNotInIncludeDir = []string{
Paul Duffinc8111702019-07-22 12:13:55 +010077 "art",
Orion Hodson6341f012019-11-06 13:39:46 +000078 "art/libnativebridge",
79 "art/libnativeloader",
Paul Duffinc8111702019-07-22 12:13:55 +010080 "libcore",
81 "libnativehelper",
82 "external/apache-harmony",
83 "external/apache-xml",
84 "external/boringssl",
85 "external/bouncycastle",
86 "external/conscrypt",
87 "external/icu",
88 "external/okhttp",
89 "external/vixl",
90 "external/wycheproof",
Paul Duffinc8111702019-07-22 12:13:55 +010091 }
Sam Delmerico46d08b42022-11-15 15:51:04 -050092 neverallowNoUseIncludeDir = []string{
Steven Morelandf36a3ac2021-04-27 18:03:14 +000093 "frameworks/av/apex",
94 "frameworks/av/tools",
95 "frameworks/native/cmds",
96 "system/apex",
97 "system/bpf",
98 "system/gatekeeper",
99 "system/hwservicemanager",
100 "system/libbase",
Steven Moreland8fc8dbf2021-04-27 02:31:07 +0000101 "system/libfmq",
Steven Morelandf36a3ac2021-04-27 18:03:14 +0000102 "system/libvintf",
Steven Moreland8fc8dbf2021-04-27 02:31:07 +0000103 }
Sam Delmerico46d08b42022-11-15 15:51:04 -0500104)
Paul Duffinc8111702019-07-22 12:13:55 +0100105
Sam Delmerico46d08b42022-11-15 15:51:04 -0500106func createIncludeDirsRules() []Rule {
107 rules := make([]Rule, 0, len(neverallowNotInIncludeDir)+len(neverallowNoUseIncludeDir))
Steven Moreland8fc8dbf2021-04-27 02:31:07 +0000108
Sam Delmerico46d08b42022-11-15 15:51:04 -0500109 for _, path := range neverallowNotInIncludeDir {
Paul Duffinc8111702019-07-22 12:13:55 +0100110 rule :=
111 NeverAllow().
112 WithMatcher("include_dirs", StartsWith(path+"/")).
113 Because("include_dirs is deprecated, all usages of '" + path + "' have been migrated" +
114 " to use alternate mechanisms and so can no longer be used.")
115
116 rules = append(rules, rule)
117 }
118
Sam Delmerico46d08b42022-11-15 15:51:04 -0500119 for _, path := range neverallowNoUseIncludeDir {
Steven Moreland8fc8dbf2021-04-27 02:31:07 +0000120 rule := NeverAllow().In(path+"/").WithMatcher("include_dirs", isSetMatcherInstance).
121 Because("include_dirs is deprecated, all usages of them in '" + path + "' have been migrated" +
122 " to use alternate mechanisms and so can no longer be used.")
123 rules = append(rules, rule)
124 }
125
Paul Duffinc8111702019-07-22 12:13:55 +0100126 return rules
127}
128
Paul Duffin730f2a52019-06-27 14:08:51 +0100129func createTrebleRules() []Rule {
130 return []Rule{
131 NeverAllow().
132 In("vendor", "device").
133 With("vndk.enabled", "true").
134 Without("vendor", "true").
Justin Yun0ecf0b22020-02-28 15:07:59 +0900135 Without("product_specific", "true").
Paul Duffin730f2a52019-06-27 14:08:51 +0100136 Because("the VNDK can never contain a library that is device dependent."),
137 NeverAllow().
138 With("vndk.enabled", "true").
139 Without("vendor", "true").
140 Without("owner", "").
141 Because("a VNDK module can never have an owner."),
Steven Moreland65b3fd92017-12-06 14:18:35 -0800142
Neil Fullerdf5f3562018-10-21 17:19:10 +0100143 // TODO(b/67974785): always enforce the manifest
Paul Duffin730f2a52019-06-27 14:08:51 +0100144 NeverAllow().
Steven Moreland51ce4f62020-02-10 17:21:32 -0800145 Without("name", "libhidlbase-combined-impl").
146 Without("name", "libhidlbase").
Paul Duffin730f2a52019-06-27 14:08:51 +0100147 With("product_variables.enforce_vintf_manifest.cflags", "*").
148 Because("manifest enforcement should be independent of ."),
Neil Fullerdf5f3562018-10-21 17:19:10 +0100149
150 // TODO(b/67975799): vendor code should always use /vendor/bin/sh
Paul Duffin730f2a52019-06-27 14:08:51 +0100151 NeverAllow().
152 Without("name", "libc_bionic_ndk").
153 With("product_variables.treble_linker_namespaces.cflags", "*").
154 Because("nothing should care if linker namespaces are enabled or not"),
Neil Fullerdf5f3562018-10-21 17:19:10 +0100155
156 // Example:
Paul Duffin730f2a52019-06-27 14:08:51 +0100157 // *NeverAllow().with("Srcs", "main.cpp"))
Neil Fullerdf5f3562018-10-21 17:19:10 +0100158 }
159}
160
Paul Duffin730f2a52019-06-27 14:08:51 +0100161func createJavaDeviceForHostRules() []Rule {
Colin Cross440e0d02020-06-11 11:32:11 -0700162 javaDeviceForHostProjectsAllowedList := []string{
Dan Willemsen9fe14102021-07-13 21:52:04 -0700163 "development/build",
Colin Crossb5191a52019-04-11 14:07:38 -0700164 "external/guava",
Steve Elliott8053f822022-10-18 17:09:28 -0400165 "external/kotlinx.coroutines",
Colin Crossfd4f7432019-03-05 15:06:16 -0800166 "external/robolectric-shadows",
Rex Hoffman54641d22022-08-25 17:29:50 +0000167 "external/robolectric",
Makoto Onukib66bba32023-11-11 00:06:09 +0000168 "frameworks/base/ravenwood",
169 "frameworks/base/tools/hoststubgen",
Jerome Gaillard655ee022021-09-23 11:38:08 +0000170 "frameworks/layoutlib",
Colin Crossfd4f7432019-03-05 15:06:16 -0800171 }
172
Paul Duffin730f2a52019-06-27 14:08:51 +0100173 return []Rule{
174 NeverAllow().
Colin Cross440e0d02020-06-11 11:32:11 -0700175 NotIn(javaDeviceForHostProjectsAllowedList...).
Paul Duffin730f2a52019-06-27 14:08:51 +0100176 ModuleType("java_device_for_host", "java_host_for_device").
Colin Cross440e0d02020-06-11 11:32:11 -0700177 Because("java_device_for_host can only be used in allowed projects"),
Colin Crossfd4f7432019-03-05 15:06:16 -0800178 }
179}
180
Colin Crossc511bc52020-04-07 16:50:32 +0000181func createCcSdkVariantRules() []Rule {
Colin Cross440e0d02020-06-11 11:32:11 -0700182 sdkVersionOnlyAllowedList := []string{
Colin Crossc511bc52020-04-07 16:50:32 +0000183 // derive_sdk_prefer32 has stem: "derive_sdk" which conflicts with the derive_sdk.
184 // This sometimes works because the APEX modules that contain derive_sdk and
185 // derive_sdk_prefer32 suppress the platform installation rules, but fails when
186 // the APEX modules contain the SDK variant and the platform variant still exists.
Anton Hansson4b8e64b2020-05-27 18:25:23 +0100187 "packages/modules/SdkExtensions/derive_sdk",
Dan Alberte2054a92020-04-20 14:46:47 -0700188 // These are for apps and shouldn't be used by non-SDK variant modules.
189 "prebuilts/ndk",
Jiyong Parka574d532024-08-28 18:06:43 +0900190 "frameworks/native/libs/binder/ndk",
Dan Alberte2054a92020-04-20 14:46:47 -0700191 "tools/test/graphicsbenchmark/apps/sample_app",
192 "tools/test/graphicsbenchmark/functional_tests/java",
Dan Albert55576052020-04-20 14:46:47 -0700193 "vendor/xts/gts-tests/hostsidetests/gamedevicecert/apps/javatests",
Chang Li66d3cb72021-06-18 14:04:50 +0000194 "external/libtextclassifier/native",
Colin Crossc511bc52020-04-07 16:50:32 +0000195 }
196
Colin Cross440e0d02020-06-11 11:32:11 -0700197 platformVariantPropertiesAllowedList := []string{
Colin Crossc511bc52020-04-07 16:50:32 +0000198 // android_native_app_glue and libRSSupport use native_window.h but target old
199 // sdk versions (minimum and 9 respectively) where libnativewindow didn't exist,
200 // so they can't add libnativewindow to shared_libs to get the header directory
201 // for the platform variant. Allow them to use the platform variant
202 // property to set shared_libs.
203 "prebuilts/ndk",
204 "frameworks/rs",
205 }
206
207 return []Rule{
208 NeverAllow().
Colin Cross440e0d02020-06-11 11:32:11 -0700209 NotIn(sdkVersionOnlyAllowedList...).
Colin Crossc511bc52020-04-07 16:50:32 +0000210 WithMatcher("sdk_variant_only", isSetMatcherInstance).
Colin Cross440e0d02020-06-11 11:32:11 -0700211 Because("sdk_variant_only can only be used in allowed projects"),
Colin Crossc511bc52020-04-07 16:50:32 +0000212 NeverAllow().
Colin Cross440e0d02020-06-11 11:32:11 -0700213 NotIn(platformVariantPropertiesAllowedList...).
Colin Crossc511bc52020-04-07 16:50:32 +0000214 WithMatcher("platform.shared_libs", isSetMatcherInstance).
Colin Cross440e0d02020-06-11 11:32:11 -0700215 Because("platform variant properties can only be used in allowed projects"),
Colin Crossc511bc52020-04-07 16:50:32 +0000216 }
217}
218
Alan Stokes73feba32022-11-14 12:21:24 +0000219func createCcStubsRule() Rule {
220 ccStubsImplementationInstallableProjectsAllowedList := []string{
Jiyong Parkf6736c72024-07-22 11:22:35 +0900221 "packages/modules/Virtualization/libs/libvm_payload",
Alan Stokes73feba32022-11-14 12:21:24 +0000222 }
223
224 return NeverAllow().
225 NotIn(ccStubsImplementationInstallableProjectsAllowedList...).
226 WithMatcher("stubs.implementation_installable", isSetMatcherInstance).
227 Because("implementation_installable can only be used in allowed projects.")
228}
229
David Srbeckye033cba2020-05-20 22:20:28 +0100230func createUncompressDexRules() []Rule {
231 return []Rule{
232 NeverAllow().
233 NotIn("art").
234 WithMatcher("uncompress_dex", isSetMatcherInstance).
235 Because("uncompress_dex is only allowed for certain jars for test in art."),
236 }
237}
238
Nelson Li43808202024-11-20 09:05:53 +0000239func createInstallInRootAllowingRules() []Rule {
Inseob Kim800d1142021-06-14 12:03:51 +0900240 return []Rule{
241 NeverAllow().
Nikita Ioffe11a9c2c2023-06-21 16:51:09 +0100242 Without("name", "init_first_stage_defaults").
Inseob Kim800d1142021-06-14 12:03:51 +0900243 Without("name", "init_first_stage").
Nikita Ioffe11a9c2c2023-06-21 16:51:09 +0100244 Without("name", "init_first_stage.microdroid").
Nelson Li43808202024-11-20 09:05:53 +0000245 Without("name", "librecovery_ui_ext").
Inseob Kim800d1142021-06-14 12:03:51 +0900246 With("install_in_root", "true").
Inseob Kimbe6a66d2024-07-11 15:43:44 +0900247 NotModuleType("prebuilt_root").
Nelson Li43808202024-11-20 09:05:53 +0000248 Because("install_in_root is only for init_first_stage or librecovery_ui_ext."),
Inseob Kim800d1142021-06-14 12:03:51 +0900249 }
250}
251
Jiyong Park3c306f32022-04-05 15:29:53 +0900252func createProhibitFrameworkAccessRules() []Rule {
253 return []Rule{
254 NeverAllow().
255 With("libs", "framework").
256 WithoutMatcher("sdk_version", Regexp("(core_.*|^$)")).
257 Because("framework can't be used when building against SDK"),
258 }
259}
260
Mark Whitea15790a2023-08-22 21:28:11 +0000261func createProhibitHeaderOnlyRule() Rule {
262 return NeverAllow().
263 Without("name", "framework-minus-apex-headers").
264 With("headers_only", "true").
265 Because("headers_only can only be used for generating framework-minus-apex headers for non-updatable modules")
266}
267
Steven Moreland0db999c2024-09-03 22:06:24 +0000268func createLimitNdkExportRule() []Rule {
269 reason := "If the headers you're trying to export are meant to be a part of the NDK, they should be exposed by an ndk_headers module. If the headers shouldn't be a part of the NDK, the headers should instead be exposed from a separate `cc_library_headers` which consumers depend on."
270 // DO NOT ADD HERE - please consult danalbert@
271 // b/357711733
272 return []Rule{
273 NeverAllow().
274 NotIn("frameworks/native/libs/binder/ndk").
275 ModuleType("ndk_library").
276 WithMatcher("export_header_libs", isSetMatcherInstance).Because(reason),
277 NeverAllow().ModuleType("ndk_library").WithMatcher("export_generated_headers", isSetMatcherInstance).Because(reason),
278 NeverAllow().ModuleType("ndk_library").WithMatcher("export_include_dirs", isSetMatcherInstance).Because(reason),
279 NeverAllow().ModuleType("ndk_library").WithMatcher("export_shared_lib_headers", isSetMatcherInstance).Because(reason),
280 NeverAllow().ModuleType("ndk_library").WithMatcher("export_static_lib_headers", isSetMatcherInstance).Because(reason),
281 }
282}
283
Inseob Kim76e19852024-10-10 17:57:22 +0900284func createLimitDirgroupRule() []Rule {
Inseob Kim7195b062024-11-29 15:40:49 +0900285 reason := "dirgroup module and dir_srcs / keep_gendir property of genrule is allowed only to Trusty build rule."
Inseob Kim76e19852024-10-10 17:57:22 +0900286 return []Rule{
287 NeverAllow().
288 ModuleType("dirgroup").
289 WithMatcher("visibility", NotInList([]string{"//trusty/vendor/google/aosp/scripts"})).Because(reason),
290 NeverAllow().
291 ModuleType("dirgroup").
292 Without("visibility", "//trusty/vendor/google/aosp/scripts").Because(reason),
293 NeverAllow().
294 ModuleType("genrule").
Inseob Kime8b1ac42024-10-24 09:27:44 +0000295 Without("name", "trusty-arm64.lk.elf.gen").
Alice Wang38aed8d2024-11-27 08:18:59 +0000296 Without("name", "trusty-arm64-virt-test-debug.lk.elf.gen").
Inseob Kime8b1ac42024-10-24 09:27:44 +0000297 Without("name", "trusty-x86_64.lk.elf.gen").
298 Without("name", "trusty-x86_64-test.lk.elf.gen").
Inseob Kim76e19852024-10-10 17:57:22 +0900299 WithMatcher("dir_srcs", isSetMatcherInstance).Because(reason),
Inseob Kim7195b062024-11-29 15:40:49 +0900300 NeverAllow().
301 ModuleType("genrule").
302 Without("name", "trusty-arm64.lk.elf.gen").
303 Without("name", "trusty-arm64-virt-test-debug.lk.elf.gen").
304 Without("name", "trusty-x86_64.lk.elf.gen").
305 Without("name", "trusty-x86_64-test.lk.elf.gen").
306 With("keep_gendir", "true").Because(reason),
Inseob Kim76e19852024-10-10 17:57:22 +0900307 }
308}
309
Jihoon Kang0d545b82024-10-11 00:21:57 +0000310func createFilesystemIsAutoGeneratedRule() Rule {
311 return NeverAllow().
312 NotIn("build/soong/fsgen").
313 ModuleType("filesystem", "android_system_image").
314 WithMatcher("is_auto_generated", isSetMatcherInstance).
315 Because("is_auto_generated property is only allowed for filesystem modules in build/soong/fsgen directory")
316}
317
Luca Stefani50098f72024-10-12 17:55:31 +0200318func createKotlinPluginRule() []Rule {
319 kotlinPluginProjectsAllowedList := []string{
320 // TODO: Migrate compose plugin to the bundled compiler plugin
321 // Actual path prebuilts/sdk/current/androidx/m2repository/androidx/compose/compiler/compiler-hosted
322 "prebuilts/sdk/current/androidx",
323 "external/kotlinc",
324 }
325
326 return []Rule{
327 NeverAllow().
328 NotIn(kotlinPluginProjectsAllowedList...).
329 ModuleType("kotlin_plugin").
330 Because("kotlin_plugin can only be used in allowed projects"),
331 }
332}
333
Jihoon Kang2a7bf752024-11-01 21:21:25 +0000334// These module types are introduced to convert PRODUCT_COPY_FILES to Soong,
335// and is only intended to be used by filesystem_creator.
336func createPrebuiltEtcBpDefineRule() Rule {
337 return NeverAllow().
338 ModuleType(
339 "prebuilt_usr_srec",
340 "prebuilt_priv_app",
341 "prebuilt_rfs",
342 "prebuilt_framework",
343 "prebuilt_res",
344 "prebuilt_wlc_upt",
345 "prebuilt_odm",
Jihoon Kang2e2b7442024-11-05 00:26:20 +0000346 "prebuilt_vendor_dlkm",
347 "prebuilt_bt_firmware",
Jihoon Kangdca2f2b2024-11-06 18:43:19 +0000348 "prebuilt_tvservice",
349 "prebuilt_optee",
Jihoon Kangecf76dd2024-11-12 05:24:46 +0000350 "prebuilt_tvconfig",
Jihoon Kang2a7bf752024-11-01 21:21:25 +0000351 ).
352 DefinedInBpFile().
353 Because("module type not allowed to be defined in bp file")
354}
355
Spandan Dase2f98da2024-11-18 19:22:39 +0000356func createAutogenRroBpDefineRule() Rule {
357 return NeverAllow().
358 ModuleType(
359 "autogen_runtime_resource_overlay",
360 ).
361 DefinedInBpFile().
362 Because("Module type will be autogenerated by soong. Use runtime_resource_overlay instead")
363}
364
Steven Moreland65b3fd92017-12-06 14:18:35 -0800365func neverallowMutator(ctx BottomUpMutatorContext) {
366 m, ok := ctx.Module().(Module)
367 if !ok {
368 return
369 }
370
371 dir := ctx.ModuleDir() + "/"
372 properties := m.GetProperties()
373
Paul Duffinf1c9bbe2019-07-26 10:48:06 +0100374 osClass := ctx.Module().Target().Os.Class
375
Paul Duffin115445b2019-08-07 15:31:07 +0100376 for _, r := range neverallowRules(ctx.Config()) {
Paul Duffin730f2a52019-06-27 14:08:51 +0100377 n := r.(*rule)
Steven Moreland65b3fd92017-12-06 14:18:35 -0800378 if !n.appliesToPath(dir) {
379 continue
380 }
381
Colin Crossfd4f7432019-03-05 15:06:16 -0800382 if !n.appliesToModuleType(ctx.ModuleType()) {
383 continue
384 }
385
Cole Faust5b35cb92024-08-27 15:47:06 -0700386 if !n.appliesToProperties(ctx, properties) {
Steven Moreland65b3fd92017-12-06 14:18:35 -0800387 continue
388 }
389
Paul Duffinf1c9bbe2019-07-26 10:48:06 +0100390 if !n.appliesToOsClass(osClass) {
391 continue
392 }
393
Paul Duffin35781882019-07-25 15:41:09 +0100394 if !n.appliesToDirectDeps(ctx) {
395 continue
396 }
397
Jihoon Kang2a7bf752024-11-01 21:21:25 +0000398 if !n.appliesToBpDefinedModule(ctx) {
399 continue
400 }
401
Steven Moreland65b3fd92017-12-06 14:18:35 -0800402 ctx.ModuleErrorf("violates " + n.String())
403 }
404}
405
Paul Duffin73bf0542019-07-12 14:12:49 +0100406type ValueMatcher interface {
Anton Hanssone1b18362021-12-23 15:05:38 +0000407 Test(string) bool
Paul Duffin73bf0542019-07-12 14:12:49 +0100408 String() string
409}
410
411type equalMatcher struct {
412 expected string
413}
414
Anton Hanssone1b18362021-12-23 15:05:38 +0000415func (m *equalMatcher) Test(value string) bool {
Paul Duffin73bf0542019-07-12 14:12:49 +0100416 return m.expected == value
417}
418
419func (m *equalMatcher) String() string {
420 return "=" + m.expected
421}
422
423type anyMatcher struct {
424}
425
Anton Hanssone1b18362021-12-23 15:05:38 +0000426func (m *anyMatcher) Test(value string) bool {
Paul Duffin73bf0542019-07-12 14:12:49 +0100427 return true
428}
429
430func (m *anyMatcher) String() string {
431 return "=*"
432}
433
434var anyMatcherInstance = &anyMatcher{}
435
Paul Duffinc8111702019-07-22 12:13:55 +0100436type startsWithMatcher struct {
437 prefix string
438}
439
Anton Hanssone1b18362021-12-23 15:05:38 +0000440func (m *startsWithMatcher) Test(value string) bool {
Paul Duffinc8111702019-07-22 12:13:55 +0100441 return strings.HasPrefix(value, m.prefix)
442}
443
444func (m *startsWithMatcher) String() string {
445 return ".starts-with(" + m.prefix + ")"
446}
447
Anton Hansson45376402020-04-09 14:18:21 +0100448type regexMatcher struct {
449 re *regexp.Regexp
450}
451
Anton Hanssone1b18362021-12-23 15:05:38 +0000452func (m *regexMatcher) Test(value string) bool {
Anton Hansson45376402020-04-09 14:18:21 +0100453 return m.re.MatchString(value)
454}
455
456func (m *regexMatcher) String() string {
457 return ".regexp(" + m.re.String() + ")"
458}
459
Andrei Onea115e7e72020-06-05 21:14:03 +0100460type notInListMatcher struct {
461 allowed []string
462}
463
Anton Hanssone1b18362021-12-23 15:05:38 +0000464func (m *notInListMatcher) Test(value string) bool {
Andrei Onea115e7e72020-06-05 21:14:03 +0100465 return !InList(value, m.allowed)
466}
467
468func (m *notInListMatcher) String() string {
469 return ".not-in-list(" + strings.Join(m.allowed, ",") + ")"
470}
471
Colin Crossc511bc52020-04-07 16:50:32 +0000472type isSetMatcher struct{}
473
Anton Hanssone1b18362021-12-23 15:05:38 +0000474func (m *isSetMatcher) Test(value string) bool {
Colin Crossc511bc52020-04-07 16:50:32 +0000475 return value != ""
476}
477
478func (m *isSetMatcher) String() string {
479 return ".is-set"
480}
481
482var isSetMatcherInstance = &isSetMatcher{}
483
Steven Moreland65b3fd92017-12-06 14:18:35 -0800484type ruleProperty struct {
Paul Duffin73bf0542019-07-12 14:12:49 +0100485 fields []string // e.x.: Vndk.Enabled
486 matcher ValueMatcher
Steven Moreland65b3fd92017-12-06 14:18:35 -0800487}
488
Liz Kammera3d79152021-10-28 18:14:04 -0400489func (r *ruleProperty) String() string {
490 return fmt.Sprintf("%q matches: %s", strings.Join(r.fields, "."), r.matcher)
491}
492
493type ruleProperties []ruleProperty
494
495func (r ruleProperties) String() string {
496 var s []string
497 for _, r := range r {
498 s = append(s, r.String())
499 }
500 return strings.Join(s, " ")
501}
502
Paul Duffin730f2a52019-06-27 14:08:51 +0100503// A NeverAllow rule.
504type Rule interface {
505 In(path ...string) Rule
506
507 NotIn(path ...string) Rule
508
Paul Duffin35781882019-07-25 15:41:09 +0100509 InDirectDeps(deps ...string) Rule
510
Paul Duffinf1c9bbe2019-07-26 10:48:06 +0100511 WithOsClass(osClasses ...OsClass) Rule
512
Paul Duffin730f2a52019-06-27 14:08:51 +0100513 ModuleType(types ...string) Rule
514
515 NotModuleType(types ...string) Rule
516
517 With(properties, value string) Rule
518
Paul Duffinc8111702019-07-22 12:13:55 +0100519 WithMatcher(properties string, matcher ValueMatcher) Rule
520
Paul Duffin730f2a52019-06-27 14:08:51 +0100521 Without(properties, value string) Rule
522
Paul Duffinc8111702019-07-22 12:13:55 +0100523 WithoutMatcher(properties string, matcher ValueMatcher) Rule
524
Jihoon Kang2a7bf752024-11-01 21:21:25 +0000525 DefinedInBpFile() Rule
526
Paul Duffin730f2a52019-06-27 14:08:51 +0100527 Because(reason string) Rule
528}
529
Steven Moreland65b3fd92017-12-06 14:18:35 -0800530type rule struct {
531 // User string for why this is a thing.
532 reason string
533
534 paths []string
535 unlessPaths []string
536
Paul Duffin35781882019-07-25 15:41:09 +0100537 directDeps map[string]bool
538
Paul Duffinf1c9bbe2019-07-26 10:48:06 +0100539 osClasses []OsClass
540
Colin Crossfd4f7432019-03-05 15:06:16 -0800541 moduleTypes []string
542 unlessModuleTypes []string
543
Liz Kammera3d79152021-10-28 18:14:04 -0400544 props ruleProperties
545 unlessProps ruleProperties
Andrei Onea115e7e72020-06-05 21:14:03 +0100546
547 onlyBootclasspathJar bool
Jihoon Kang2a7bf752024-11-01 21:21:25 +0000548
549 definedInBp bool
Steven Moreland65b3fd92017-12-06 14:18:35 -0800550}
551
Paul Duffin730f2a52019-06-27 14:08:51 +0100552// Create a new NeverAllow rule.
553func NeverAllow() Rule {
Paul Duffin35781882019-07-25 15:41:09 +0100554 return &rule{directDeps: make(map[string]bool)}
Steven Moreland65b3fd92017-12-06 14:18:35 -0800555}
Colin Crossfd4f7432019-03-05 15:06:16 -0800556
Liz Kammera3d79152021-10-28 18:14:04 -0400557// In adds path(s) where this rule applies.
Paul Duffin730f2a52019-06-27 14:08:51 +0100558func (r *rule) In(path ...string) Rule {
Steven Moreland65b3fd92017-12-06 14:18:35 -0800559 r.paths = append(r.paths, cleanPaths(path)...)
560 return r
561}
Colin Crossfd4f7432019-03-05 15:06:16 -0800562
Liz Kammera3d79152021-10-28 18:14:04 -0400563// NotIn adds path(s) to that this rule does not apply to.
Paul Duffin730f2a52019-06-27 14:08:51 +0100564func (r *rule) NotIn(path ...string) Rule {
Steven Moreland65b3fd92017-12-06 14:18:35 -0800565 r.unlessPaths = append(r.unlessPaths, cleanPaths(path)...)
566 return r
567}
Colin Crossfd4f7432019-03-05 15:06:16 -0800568
Liz Kammera3d79152021-10-28 18:14:04 -0400569// InDirectDeps adds dep(s) that are not allowed with this rule.
Paul Duffin35781882019-07-25 15:41:09 +0100570func (r *rule) InDirectDeps(deps ...string) Rule {
571 for _, d := range deps {
572 r.directDeps[d] = true
573 }
574 return r
575}
576
Liz Kammera3d79152021-10-28 18:14:04 -0400577// WithOsClass adds osClass(es) that this rule applies to.
Paul Duffinf1c9bbe2019-07-26 10:48:06 +0100578func (r *rule) WithOsClass(osClasses ...OsClass) Rule {
579 r.osClasses = append(r.osClasses, osClasses...)
580 return r
581}
582
Liz Kammera3d79152021-10-28 18:14:04 -0400583// ModuleType adds type(s) that this rule applies to.
Paul Duffin730f2a52019-06-27 14:08:51 +0100584func (r *rule) ModuleType(types ...string) Rule {
Colin Crossfd4f7432019-03-05 15:06:16 -0800585 r.moduleTypes = append(r.moduleTypes, types...)
586 return r
587}
588
Liz Kammera3d79152021-10-28 18:14:04 -0400589// NotModuleType adds type(s) that this rule does not apply to..
Paul Duffin730f2a52019-06-27 14:08:51 +0100590func (r *rule) NotModuleType(types ...string) Rule {
Colin Crossfd4f7432019-03-05 15:06:16 -0800591 r.unlessModuleTypes = append(r.unlessModuleTypes, types...)
592 return r
593}
594
Liz Kammera3d79152021-10-28 18:14:04 -0400595// With specifies property/value combinations that are restricted for this rule.
Paul Duffin730f2a52019-06-27 14:08:51 +0100596func (r *rule) With(properties, value string) Rule {
Paul Duffinc8111702019-07-22 12:13:55 +0100597 return r.WithMatcher(properties, selectMatcher(value))
598}
599
Liz Kammera3d79152021-10-28 18:14:04 -0400600// WithMatcher specifies property/matcher combinations that are restricted for this rule.
Paul Duffinc8111702019-07-22 12:13:55 +0100601func (r *rule) WithMatcher(properties string, matcher ValueMatcher) Rule {
Steven Moreland65b3fd92017-12-06 14:18:35 -0800602 r.props = append(r.props, ruleProperty{
Paul Duffin73bf0542019-07-12 14:12:49 +0100603 fields: fieldNamesForProperties(properties),
Paul Duffinc8111702019-07-22 12:13:55 +0100604 matcher: matcher,
Steven Moreland65b3fd92017-12-06 14:18:35 -0800605 })
606 return r
607}
Colin Crossfd4f7432019-03-05 15:06:16 -0800608
Liz Kammera3d79152021-10-28 18:14:04 -0400609// Without specifies property/value combinations that this rule does not apply to.
Paul Duffin730f2a52019-06-27 14:08:51 +0100610func (r *rule) Without(properties, value string) Rule {
Paul Duffinc8111702019-07-22 12:13:55 +0100611 return r.WithoutMatcher(properties, selectMatcher(value))
612}
613
Liz Kammera3d79152021-10-28 18:14:04 -0400614// Without specifies property/matcher combinations that this rule does not apply to.
Paul Duffinc8111702019-07-22 12:13:55 +0100615func (r *rule) WithoutMatcher(properties string, matcher ValueMatcher) Rule {
Steven Moreland65b3fd92017-12-06 14:18:35 -0800616 r.unlessProps = append(r.unlessProps, ruleProperty{
Paul Duffin73bf0542019-07-12 14:12:49 +0100617 fields: fieldNamesForProperties(properties),
Paul Duffinc8111702019-07-22 12:13:55 +0100618 matcher: matcher,
Steven Moreland65b3fd92017-12-06 14:18:35 -0800619 })
620 return r
621}
Colin Crossfd4f7432019-03-05 15:06:16 -0800622
Jihoon Kang2a7bf752024-11-01 21:21:25 +0000623// DefinedInBpFile specifies that this rule applies to modules that are defined
624// in bp files, and does not apply to modules that are auto generated by other modules.
625func (r *rule) DefinedInBpFile() Rule {
626 r.definedInBp = true
627 return r
628}
629
Paul Duffin73bf0542019-07-12 14:12:49 +0100630func selectMatcher(expected string) ValueMatcher {
631 if expected == "*" {
632 return anyMatcherInstance
633 }
634 return &equalMatcher{expected: expected}
635}
636
Liz Kammera3d79152021-10-28 18:14:04 -0400637// Because specifies a reason for this rule.
Paul Duffin730f2a52019-06-27 14:08:51 +0100638func (r *rule) Because(reason string) Rule {
Steven Moreland65b3fd92017-12-06 14:18:35 -0800639 r.reason = reason
640 return r
641}
642
643func (r *rule) String() string {
Liz Kammera3d79152021-10-28 18:14:04 -0400644 s := []string{"neverallow requirements. Not allowed:"}
645 if len(r.paths) > 0 {
646 s = append(s, fmt.Sprintf("in dirs: %q", r.paths))
Steven Moreland65b3fd92017-12-06 14:18:35 -0800647 }
Liz Kammera3d79152021-10-28 18:14:04 -0400648 if len(r.moduleTypes) > 0 {
649 s = append(s, fmt.Sprintf("module types: %q", r.moduleTypes))
Steven Moreland65b3fd92017-12-06 14:18:35 -0800650 }
Liz Kammera3d79152021-10-28 18:14:04 -0400651 if len(r.props) > 0 {
652 s = append(s, fmt.Sprintf("properties matching: %s", r.props))
Colin Crossfd4f7432019-03-05 15:06:16 -0800653 }
Liz Kammera3d79152021-10-28 18:14:04 -0400654 if len(r.directDeps) > 0 {
Cole Faust18994c72023-02-28 16:02:16 -0800655 s = append(s, fmt.Sprintf("dep(s): %q", SortedKeys(r.directDeps)))
Colin Crossfd4f7432019-03-05 15:06:16 -0800656 }
Liz Kammera3d79152021-10-28 18:14:04 -0400657 if len(r.osClasses) > 0 {
658 s = append(s, fmt.Sprintf("os class(es): %q", r.osClasses))
Paul Duffinf1c9bbe2019-07-26 10:48:06 +0100659 }
Liz Kammera3d79152021-10-28 18:14:04 -0400660 if len(r.unlessPaths) > 0 {
661 s = append(s, fmt.Sprintf("EXCEPT in dirs: %q", r.unlessPaths))
662 }
663 if len(r.unlessModuleTypes) > 0 {
664 s = append(s, fmt.Sprintf("EXCEPT module types: %q", r.unlessModuleTypes))
665 }
666 if len(r.unlessProps) > 0 {
667 s = append(s, fmt.Sprintf("EXCEPT properties matching: %q", r.unlessProps))
Andrei Onea115e7e72020-06-05 21:14:03 +0100668 }
Steven Moreland65b3fd92017-12-06 14:18:35 -0800669 if len(r.reason) != 0 {
Liz Kammera3d79152021-10-28 18:14:04 -0400670 s = append(s, " which is restricted because "+r.reason)
Steven Moreland65b3fd92017-12-06 14:18:35 -0800671 }
Liz Kammera3d79152021-10-28 18:14:04 -0400672 if len(s) == 1 {
673 s[0] = "neverallow requirements (empty)"
674 }
675 return strings.Join(s, "\n\t")
Steven Moreland65b3fd92017-12-06 14:18:35 -0800676}
677
678func (r *rule) appliesToPath(dir string) bool {
Jaewoong Jung3aff5782020-02-11 07:54:35 -0800679 includePath := len(r.paths) == 0 || HasAnyPrefix(dir, r.paths)
680 excludePath := HasAnyPrefix(dir, r.unlessPaths)
Steven Moreland65b3fd92017-12-06 14:18:35 -0800681 return includePath && !excludePath
682}
683
Paul Duffin35781882019-07-25 15:41:09 +0100684func (r *rule) appliesToDirectDeps(ctx BottomUpMutatorContext) bool {
685 if len(r.directDeps) == 0 {
686 return true
687 }
688
689 matches := false
690 ctx.VisitDirectDeps(func(m Module) {
691 if !matches {
692 name := ctx.OtherModuleName(m)
693 matches = r.directDeps[name]
694 }
695 })
696
697 return matches
698}
699
Paul Duffinf1c9bbe2019-07-26 10:48:06 +0100700func (r *rule) appliesToOsClass(osClass OsClass) bool {
701 if len(r.osClasses) == 0 {
702 return true
703 }
704
705 for _, c := range r.osClasses {
706 if c == osClass {
707 return true
708 }
709 }
710
711 return false
712}
713
Colin Crossfd4f7432019-03-05 15:06:16 -0800714func (r *rule) appliesToModuleType(moduleType string) bool {
715 return (len(r.moduleTypes) == 0 || InList(moduleType, r.moduleTypes)) && !InList(moduleType, r.unlessModuleTypes)
716}
717
Cole Faust5b35cb92024-08-27 15:47:06 -0700718func (r *rule) appliesToProperties(ctx BottomUpMutatorContext, properties []interface{}) bool {
719 includeProps := hasAllProperties(ctx, properties, r.props)
720 excludeProps := hasAnyProperty(ctx, properties, r.unlessProps)
Steven Moreland65b3fd92017-12-06 14:18:35 -0800721 return includeProps && !excludeProps
722}
723
Jihoon Kang2a7bf752024-11-01 21:21:25 +0000724func (r *rule) appliesToBpDefinedModule(ctx BottomUpMutatorContext) bool {
725 if !r.definedInBp {
726 return true
727 }
728 return !ctx.OtherModuleIsAutoGenerated(ctx.Module()) == r.definedInBp
729}
730
Paul Duffinc8111702019-07-22 12:13:55 +0100731func StartsWith(prefix string) ValueMatcher {
732 return &startsWithMatcher{prefix}
733}
734
Anton Hansson45376402020-04-09 14:18:21 +0100735func Regexp(re string) ValueMatcher {
736 r, err := regexp.Compile(re)
737 if err != nil {
738 panic(err)
739 }
740 return &regexMatcher{r}
741}
742
Andrei Onea115e7e72020-06-05 21:14:03 +0100743func NotInList(allowed []string) ValueMatcher {
744 return &notInListMatcher{allowed}
745}
746
Steven Moreland65b3fd92017-12-06 14:18:35 -0800747// assorted utils
748
749func cleanPaths(paths []string) []string {
750 res := make([]string, len(paths))
751 for i, v := range paths {
752 res[i] = filepath.Clean(v) + "/"
753 }
754 return res
755}
756
757func fieldNamesForProperties(propertyNames string) []string {
758 names := strings.Split(propertyNames, ".")
759 for i, v := range names {
760 names[i] = proptools.FieldNameForProperty(v)
761 }
762 return names
763}
764
Cole Faust5b35cb92024-08-27 15:47:06 -0700765func hasAnyProperty(ctx BottomUpMutatorContext, properties []interface{}, props []ruleProperty) bool {
Steven Moreland65b3fd92017-12-06 14:18:35 -0800766 for _, v := range props {
Cole Faust5b35cb92024-08-27 15:47:06 -0700767 if hasProperty(ctx, properties, v) {
Steven Moreland65b3fd92017-12-06 14:18:35 -0800768 return true
769 }
770 }
771 return false
772}
773
Cole Faust5b35cb92024-08-27 15:47:06 -0700774func hasAllProperties(ctx BottomUpMutatorContext, properties []interface{}, props []ruleProperty) bool {
Steven Moreland65b3fd92017-12-06 14:18:35 -0800775 for _, v := range props {
Cole Faust5b35cb92024-08-27 15:47:06 -0700776 if !hasProperty(ctx, properties, v) {
Steven Moreland65b3fd92017-12-06 14:18:35 -0800777 return false
778 }
779 }
780 return true
781}
782
Cole Faust5b35cb92024-08-27 15:47:06 -0700783func hasProperty(ctx BottomUpMutatorContext, properties []interface{}, prop ruleProperty) bool {
Steven Moreland65b3fd92017-12-06 14:18:35 -0800784 for _, propertyStruct := range properties {
785 propertiesValue := reflect.ValueOf(propertyStruct).Elem()
786 for _, v := range prop.fields {
787 if !propertiesValue.IsValid() {
788 break
789 }
790 propertiesValue = propertiesValue.FieldByName(v)
791 }
792 if !propertiesValue.IsValid() {
793 continue
794 }
795
Paul Duffin73bf0542019-07-12 14:12:49 +0100796 check := func(value string) bool {
Anton Hanssone1b18362021-12-23 15:05:38 +0000797 return prop.matcher.Test(value)
Steven Moreland65b3fd92017-12-06 14:18:35 -0800798 }
799
Cole Faust5b35cb92024-08-27 15:47:06 -0700800 if matchValue(ctx, propertiesValue, check) {
Steven Moreland65b3fd92017-12-06 14:18:35 -0800801 return true
802 }
803 }
804 return false
805}
806
Cole Faust5b35cb92024-08-27 15:47:06 -0700807func matchValue(ctx BottomUpMutatorContext, value reflect.Value, check func(string) bool) bool {
Steven Moreland65b3fd92017-12-06 14:18:35 -0800808 if !value.IsValid() {
809 return false
810 }
811
812 if value.Kind() == reflect.Ptr {
813 if value.IsNil() {
814 return check("")
815 }
816 value = value.Elem()
817 }
818
Cole Faust5b35cb92024-08-27 15:47:06 -0700819 switch v := value.Interface().(type) {
820 case string:
821 return check(v)
822 case bool:
823 return check(strconv.FormatBool(v))
824 case int:
825 return check(strconv.FormatInt((int64)(v), 10))
826 case []string:
827 for _, v := range v {
828 if check(v) {
829 return true
830 }
Steven Moreland65b3fd92017-12-06 14:18:35 -0800831 }
Cole Faust5b35cb92024-08-27 15:47:06 -0700832 return false
833 case proptools.Configurable[string]:
834 return check(v.GetOrDefault(ctx, ""))
835 case proptools.Configurable[bool]:
836 return check(strconv.FormatBool(v.GetOrDefault(ctx, false)))
837 case proptools.Configurable[[]string]:
838 for _, v := range v.GetOrDefault(ctx, nil) {
Steven Moreland65b3fd92017-12-06 14:18:35 -0800839 if check(v) {
840 return true
841 }
842 }
843 return false
844 }
845
846 panic("Can't handle type: " + value.Kind().String())
847}
Paul Duffin115445b2019-08-07 15:31:07 +0100848
849var neverallowRulesKey = NewOnceKey("neverallowRules")
850
851func neverallowRules(config Config) []Rule {
852 return config.Once(neverallowRulesKey, func() interface{} {
853 // No test rules were set by setTestNeverallowRules, use the global rules
854 return neverallows
855 }).([]Rule)
856}
857
858// Overrides the default neverallow rules for the supplied config.
859//
860// For testing only.
Paul Duffin45338f02021-03-30 23:07:52 +0100861func setTestNeverallowRules(config Config, testRules []Rule) {
Paul Duffin115445b2019-08-07 15:31:07 +0100862 config.Once(neverallowRulesKey, func() interface{} { return testRules })
863}
Paul Duffin45338f02021-03-30 23:07:52 +0100864
865// Prepares for a test by setting neverallow rules and enabling the mutator.
866//
867// If the supplied rules are nil then the default rules are used.
868func PrepareForTestWithNeverallowRules(testRules []Rule) FixturePreparer {
869 return GroupFixturePreparers(
870 FixtureModifyConfig(func(config Config) {
871 if testRules != nil {
872 setTestNeverallowRules(config, testRules)
873 }
874 }),
875 FixtureRegisterWithContext(func(ctx RegistrationContext) {
876 ctx.PostDepsMutators(registerNeverallowMutator)
877 }),
878 )
879}