Steven Moreland | 65b3fd9 | 2017-12-06 14:18:35 -0800 | [diff] [blame] | 1 | // Copyright 2017 Google Inc. All rights reserved. |
| 2 | // |
| 3 | // Licensed under the Apache License, Version 2.0 (the "License"); |
| 4 | // you may not use this file except in compliance with the License. |
| 5 | // You may obtain a copy of the License at |
| 6 | // |
| 7 | // http://www.apache.org/licenses/LICENSE-2.0 |
| 8 | // |
| 9 | // Unless required by applicable law or agreed to in writing, software |
| 10 | // distributed under the License is distributed on an "AS IS" BASIS, |
| 11 | // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. |
| 12 | // See the License for the specific language governing permissions and |
| 13 | // limitations under the License. |
| 14 | |
| 15 | package android |
| 16 | |
| 17 | import ( |
Liz Kammer | a3d7915 | 2021-10-28 18:14:04 -0400 | [diff] [blame] | 18 | "fmt" |
Steven Moreland | 65b3fd9 | 2017-12-06 14:18:35 -0800 | [diff] [blame] | 19 | "path/filepath" |
| 20 | "reflect" |
Anton Hansson | 4537640 | 2020-04-09 14:18:21 +0100 | [diff] [blame] | 21 | "regexp" |
Steven Moreland | 65b3fd9 | 2017-12-06 14:18:35 -0800 | [diff] [blame] | 22 | "strconv" |
| 23 | "strings" |
| 24 | |
| 25 | "github.com/google/blueprint/proptools" |
| 26 | ) |
| 27 | |
| 28 | // "neverallow" rules for the build system. |
| 29 | // |
| 30 | // This allows things which aren't related to the build system and are enforced |
Joe Onorato | b4638c1 | 2021-10-27 15:47:06 -0700 | [diff] [blame] | 31 | // against assumptions, in progress code refactors, or policy to be expressed in a |
Steven Moreland | 65b3fd9 | 2017-12-06 14:18:35 -0800 | [diff] [blame] | 32 | // straightforward away disjoint from implementations and tests which should |
| 33 | // work regardless of these restrictions. |
| 34 | // |
| 35 | // A module is disallowed if all of the following are true: |
Paul Duffin | 730f2a5 | 2019-06-27 14:08:51 +0100 | [diff] [blame] | 36 | // - it is in one of the "In" paths |
| 37 | // - it is not in one of the "NotIn" paths |
| 38 | // - it has all "With" properties matched |
Steven Moreland | 65b3fd9 | 2017-12-06 14:18:35 -0800 | [diff] [blame] | 39 | // - - values are matched in their entirety |
| 40 | // - - nil is interpreted as an empty string |
| 41 | // - - nested properties are separated with a '.' |
| 42 | // - - if the property is a list, any of the values in the list being matches |
| 43 | // counts as a match |
Paul Duffin | 730f2a5 | 2019-06-27 14:08:51 +0100 | [diff] [blame] | 44 | // - it has none of the "Without" properties matched (same rules as above) |
Steven Moreland | 65b3fd9 | 2017-12-06 14:18:35 -0800 | [diff] [blame] | 45 | |
Paul Duffin | 45338f0 | 2021-03-30 23:07:52 +0100 | [diff] [blame] | 46 | func registerNeverallowMutator(ctx RegisterMutatorsContext) { |
Colin Cross | 8a96280 | 2024-10-09 15:29:27 -0700 | [diff] [blame] | 47 | ctx.BottomUp("neverallow", neverallowMutator) |
Steven Moreland | 65b3fd9 | 2017-12-06 14:18:35 -0800 | [diff] [blame] | 48 | } |
| 49 | |
Paul Duffin | 730f2a5 | 2019-06-27 14:08:51 +0100 | [diff] [blame] | 50 | var neverallows = []Rule{} |
Steven Moreland | 65b3fd9 | 2017-12-06 14:18:35 -0800 | [diff] [blame] | 51 | |
Paul Duffin | 730f2a5 | 2019-06-27 14:08:51 +0100 | [diff] [blame] | 52 | func init() { |
Paul Duffin | c811170 | 2019-07-22 12:13:55 +0100 | [diff] [blame] | 53 | AddNeverAllowRules(createIncludeDirsRules()...) |
Paul Duffin | 730f2a5 | 2019-06-27 14:08:51 +0100 | [diff] [blame] | 54 | AddNeverAllowRules(createTrebleRules()...) |
Paul Duffin | 730f2a5 | 2019-06-27 14:08:51 +0100 | [diff] [blame] | 55 | AddNeverAllowRules(createJavaDeviceForHostRules()...) |
Colin Cross | c511bc5 | 2020-04-07 16:50:32 +0000 | [diff] [blame] | 56 | AddNeverAllowRules(createCcSdkVariantRules()...) |
David Srbecky | e033cba | 2020-05-20 22:20:28 +0100 | [diff] [blame] | 57 | AddNeverAllowRules(createUncompressDexRules()...) |
Nelson Li | 4380820 | 2024-11-20 09:05:53 +0000 | [diff] [blame] | 58 | AddNeverAllowRules(createInstallInRootAllowingRules()...) |
Jiyong Park | 3c306f3 | 2022-04-05 15:29:53 +0900 | [diff] [blame] | 59 | AddNeverAllowRules(createProhibitFrameworkAccessRules()...) |
Alan Stokes | 73feba3 | 2022-11-14 12:21:24 +0000 | [diff] [blame] | 60 | AddNeverAllowRules(createCcStubsRule()) |
Mark White | a15790a | 2023-08-22 21:28:11 +0000 | [diff] [blame] | 61 | AddNeverAllowRules(createProhibitHeaderOnlyRule()) |
Steven Moreland | 0db999c | 2024-09-03 22:06:24 +0000 | [diff] [blame] | 62 | AddNeverAllowRules(createLimitNdkExportRule()...) |
Inseob Kim | 76e1985 | 2024-10-10 17:57:22 +0900 | [diff] [blame] | 63 | AddNeverAllowRules(createLimitDirgroupRule()...) |
Jihoon Kang | 0d545b8 | 2024-10-11 00:21:57 +0000 | [diff] [blame] | 64 | AddNeverAllowRules(createFilesystemIsAutoGeneratedRule()) |
Luca Stefani | 50098f7 | 2024-10-12 17:55:31 +0200 | [diff] [blame] | 65 | AddNeverAllowRules(createKotlinPluginRule()...) |
Jihoon Kang | 2a7bf75 | 2024-11-01 21:21:25 +0000 | [diff] [blame] | 66 | AddNeverAllowRules(createPrebuiltEtcBpDefineRule()) |
Spandan Das | e2f98da | 2024-11-18 19:22:39 +0000 | [diff] [blame] | 67 | AddNeverAllowRules(createAutogenRroBpDefineRule()) |
Neil Fuller | df5f356 | 2018-10-21 17:19:10 +0100 | [diff] [blame] | 68 | } |
Steven Moreland | 65b3fd9 | 2017-12-06 14:18:35 -0800 | [diff] [blame] | 69 | |
Paul Duffin | 730f2a5 | 2019-06-27 14:08:51 +0100 | [diff] [blame] | 70 | // Add a NeverAllow rule to the set of rules to apply. |
| 71 | func AddNeverAllowRules(rules ...Rule) { |
| 72 | neverallows = append(neverallows, rules...) |
| 73 | } |
| 74 | |
Sam Delmerico | 46d08b4 | 2022-11-15 15:51:04 -0500 | [diff] [blame] | 75 | var ( |
| 76 | neverallowNotInIncludeDir = []string{ |
Paul Duffin | c811170 | 2019-07-22 12:13:55 +0100 | [diff] [blame] | 77 | "art", |
Orion Hodson | 6341f01 | 2019-11-06 13:39:46 +0000 | [diff] [blame] | 78 | "art/libnativebridge", |
| 79 | "art/libnativeloader", |
Paul Duffin | c811170 | 2019-07-22 12:13:55 +0100 | [diff] [blame] | 80 | "libcore", |
| 81 | "libnativehelper", |
| 82 | "external/apache-harmony", |
| 83 | "external/apache-xml", |
| 84 | "external/boringssl", |
| 85 | "external/bouncycastle", |
| 86 | "external/conscrypt", |
| 87 | "external/icu", |
| 88 | "external/okhttp", |
| 89 | "external/vixl", |
| 90 | "external/wycheproof", |
Paul Duffin | c811170 | 2019-07-22 12:13:55 +0100 | [diff] [blame] | 91 | } |
Sam Delmerico | 46d08b4 | 2022-11-15 15:51:04 -0500 | [diff] [blame] | 92 | neverallowNoUseIncludeDir = []string{ |
Steven Moreland | f36a3ac | 2021-04-27 18:03:14 +0000 | [diff] [blame] | 93 | "frameworks/av/apex", |
| 94 | "frameworks/av/tools", |
| 95 | "frameworks/native/cmds", |
| 96 | "system/apex", |
| 97 | "system/bpf", |
| 98 | "system/gatekeeper", |
| 99 | "system/hwservicemanager", |
| 100 | "system/libbase", |
Steven Moreland | 8fc8dbf | 2021-04-27 02:31:07 +0000 | [diff] [blame] | 101 | "system/libfmq", |
Steven Moreland | f36a3ac | 2021-04-27 18:03:14 +0000 | [diff] [blame] | 102 | "system/libvintf", |
Steven Moreland | 8fc8dbf | 2021-04-27 02:31:07 +0000 | [diff] [blame] | 103 | } |
Sam Delmerico | 46d08b4 | 2022-11-15 15:51:04 -0500 | [diff] [blame] | 104 | ) |
Paul Duffin | c811170 | 2019-07-22 12:13:55 +0100 | [diff] [blame] | 105 | |
Sam Delmerico | 46d08b4 | 2022-11-15 15:51:04 -0500 | [diff] [blame] | 106 | func createIncludeDirsRules() []Rule { |
| 107 | rules := make([]Rule, 0, len(neverallowNotInIncludeDir)+len(neverallowNoUseIncludeDir)) |
Steven Moreland | 8fc8dbf | 2021-04-27 02:31:07 +0000 | [diff] [blame] | 108 | |
Sam Delmerico | 46d08b4 | 2022-11-15 15:51:04 -0500 | [diff] [blame] | 109 | for _, path := range neverallowNotInIncludeDir { |
Paul Duffin | c811170 | 2019-07-22 12:13:55 +0100 | [diff] [blame] | 110 | rule := |
| 111 | NeverAllow(). |
| 112 | WithMatcher("include_dirs", StartsWith(path+"/")). |
| 113 | Because("include_dirs is deprecated, all usages of '" + path + "' have been migrated" + |
| 114 | " to use alternate mechanisms and so can no longer be used.") |
| 115 | |
| 116 | rules = append(rules, rule) |
| 117 | } |
| 118 | |
Sam Delmerico | 46d08b4 | 2022-11-15 15:51:04 -0500 | [diff] [blame] | 119 | for _, path := range neverallowNoUseIncludeDir { |
Steven Moreland | 8fc8dbf | 2021-04-27 02:31:07 +0000 | [diff] [blame] | 120 | rule := NeverAllow().In(path+"/").WithMatcher("include_dirs", isSetMatcherInstance). |
| 121 | Because("include_dirs is deprecated, all usages of them in '" + path + "' have been migrated" + |
| 122 | " to use alternate mechanisms and so can no longer be used.") |
| 123 | rules = append(rules, rule) |
| 124 | } |
| 125 | |
Paul Duffin | c811170 | 2019-07-22 12:13:55 +0100 | [diff] [blame] | 126 | return rules |
| 127 | } |
| 128 | |
Paul Duffin | 730f2a5 | 2019-06-27 14:08:51 +0100 | [diff] [blame] | 129 | func createTrebleRules() []Rule { |
| 130 | return []Rule{ |
| 131 | NeverAllow(). |
| 132 | In("vendor", "device"). |
| 133 | With("vndk.enabled", "true"). |
| 134 | Without("vendor", "true"). |
Justin Yun | 0ecf0b2 | 2020-02-28 15:07:59 +0900 | [diff] [blame] | 135 | Without("product_specific", "true"). |
Paul Duffin | 730f2a5 | 2019-06-27 14:08:51 +0100 | [diff] [blame] | 136 | Because("the VNDK can never contain a library that is device dependent."), |
| 137 | NeverAllow(). |
| 138 | With("vndk.enabled", "true"). |
| 139 | Without("vendor", "true"). |
| 140 | Without("owner", ""). |
| 141 | Because("a VNDK module can never have an owner."), |
Steven Moreland | 65b3fd9 | 2017-12-06 14:18:35 -0800 | [diff] [blame] | 142 | |
Neil Fuller | df5f356 | 2018-10-21 17:19:10 +0100 | [diff] [blame] | 143 | // TODO(b/67974785): always enforce the manifest |
Paul Duffin | 730f2a5 | 2019-06-27 14:08:51 +0100 | [diff] [blame] | 144 | NeverAllow(). |
Steven Moreland | 51ce4f6 | 2020-02-10 17:21:32 -0800 | [diff] [blame] | 145 | Without("name", "libhidlbase-combined-impl"). |
| 146 | Without("name", "libhidlbase"). |
Paul Duffin | 730f2a5 | 2019-06-27 14:08:51 +0100 | [diff] [blame] | 147 | With("product_variables.enforce_vintf_manifest.cflags", "*"). |
| 148 | Because("manifest enforcement should be independent of ."), |
Neil Fuller | df5f356 | 2018-10-21 17:19:10 +0100 | [diff] [blame] | 149 | |
| 150 | // TODO(b/67975799): vendor code should always use /vendor/bin/sh |
Paul Duffin | 730f2a5 | 2019-06-27 14:08:51 +0100 | [diff] [blame] | 151 | NeverAllow(). |
| 152 | Without("name", "libc_bionic_ndk"). |
| 153 | With("product_variables.treble_linker_namespaces.cflags", "*"). |
| 154 | Because("nothing should care if linker namespaces are enabled or not"), |
Neil Fuller | df5f356 | 2018-10-21 17:19:10 +0100 | [diff] [blame] | 155 | |
| 156 | // Example: |
Paul Duffin | 730f2a5 | 2019-06-27 14:08:51 +0100 | [diff] [blame] | 157 | // *NeverAllow().with("Srcs", "main.cpp")) |
Neil Fuller | df5f356 | 2018-10-21 17:19:10 +0100 | [diff] [blame] | 158 | } |
| 159 | } |
| 160 | |
Paul Duffin | 730f2a5 | 2019-06-27 14:08:51 +0100 | [diff] [blame] | 161 | func createJavaDeviceForHostRules() []Rule { |
Colin Cross | 440e0d0 | 2020-06-11 11:32:11 -0700 | [diff] [blame] | 162 | javaDeviceForHostProjectsAllowedList := []string{ |
Dan Willemsen | 9fe1410 | 2021-07-13 21:52:04 -0700 | [diff] [blame] | 163 | "development/build", |
Colin Cross | b5191a5 | 2019-04-11 14:07:38 -0700 | [diff] [blame] | 164 | "external/guava", |
Steve Elliott | 8053f82 | 2022-10-18 17:09:28 -0400 | [diff] [blame] | 165 | "external/kotlinx.coroutines", |
Colin Cross | fd4f743 | 2019-03-05 15:06:16 -0800 | [diff] [blame] | 166 | "external/robolectric-shadows", |
Rex Hoffman | 54641d2 | 2022-08-25 17:29:50 +0000 | [diff] [blame] | 167 | "external/robolectric", |
Makoto Onuki | b66bba3 | 2023-11-11 00:06:09 +0000 | [diff] [blame] | 168 | "frameworks/base/ravenwood", |
| 169 | "frameworks/base/tools/hoststubgen", |
Jerome Gaillard | 655ee02 | 2021-09-23 11:38:08 +0000 | [diff] [blame] | 170 | "frameworks/layoutlib", |
Colin Cross | fd4f743 | 2019-03-05 15:06:16 -0800 | [diff] [blame] | 171 | } |
| 172 | |
Paul Duffin | 730f2a5 | 2019-06-27 14:08:51 +0100 | [diff] [blame] | 173 | return []Rule{ |
| 174 | NeverAllow(). |
Colin Cross | 440e0d0 | 2020-06-11 11:32:11 -0700 | [diff] [blame] | 175 | NotIn(javaDeviceForHostProjectsAllowedList...). |
Paul Duffin | 730f2a5 | 2019-06-27 14:08:51 +0100 | [diff] [blame] | 176 | ModuleType("java_device_for_host", "java_host_for_device"). |
Colin Cross | 440e0d0 | 2020-06-11 11:32:11 -0700 | [diff] [blame] | 177 | Because("java_device_for_host can only be used in allowed projects"), |
Colin Cross | fd4f743 | 2019-03-05 15:06:16 -0800 | [diff] [blame] | 178 | } |
| 179 | } |
| 180 | |
Colin Cross | c511bc5 | 2020-04-07 16:50:32 +0000 | [diff] [blame] | 181 | func createCcSdkVariantRules() []Rule { |
Colin Cross | 440e0d0 | 2020-06-11 11:32:11 -0700 | [diff] [blame] | 182 | sdkVersionOnlyAllowedList := []string{ |
Colin Cross | c511bc5 | 2020-04-07 16:50:32 +0000 | [diff] [blame] | 183 | // derive_sdk_prefer32 has stem: "derive_sdk" which conflicts with the derive_sdk. |
| 184 | // This sometimes works because the APEX modules that contain derive_sdk and |
| 185 | // derive_sdk_prefer32 suppress the platform installation rules, but fails when |
| 186 | // the APEX modules contain the SDK variant and the platform variant still exists. |
Anton Hansson | 4b8e64b | 2020-05-27 18:25:23 +0100 | [diff] [blame] | 187 | "packages/modules/SdkExtensions/derive_sdk", |
Dan Albert | e2054a9 | 2020-04-20 14:46:47 -0700 | [diff] [blame] | 188 | // These are for apps and shouldn't be used by non-SDK variant modules. |
| 189 | "prebuilts/ndk", |
Jiyong Park | a574d53 | 2024-08-28 18:06:43 +0900 | [diff] [blame] | 190 | "frameworks/native/libs/binder/ndk", |
Dan Albert | e2054a9 | 2020-04-20 14:46:47 -0700 | [diff] [blame] | 191 | "tools/test/graphicsbenchmark/apps/sample_app", |
| 192 | "tools/test/graphicsbenchmark/functional_tests/java", |
Dan Albert | 5557605 | 2020-04-20 14:46:47 -0700 | [diff] [blame] | 193 | "vendor/xts/gts-tests/hostsidetests/gamedevicecert/apps/javatests", |
Chang Li | 66d3cb7 | 2021-06-18 14:04:50 +0000 | [diff] [blame] | 194 | "external/libtextclassifier/native", |
Colin Cross | c511bc5 | 2020-04-07 16:50:32 +0000 | [diff] [blame] | 195 | } |
| 196 | |
Colin Cross | 440e0d0 | 2020-06-11 11:32:11 -0700 | [diff] [blame] | 197 | platformVariantPropertiesAllowedList := []string{ |
Colin Cross | c511bc5 | 2020-04-07 16:50:32 +0000 | [diff] [blame] | 198 | // android_native_app_glue and libRSSupport use native_window.h but target old |
| 199 | // sdk versions (minimum and 9 respectively) where libnativewindow didn't exist, |
| 200 | // so they can't add libnativewindow to shared_libs to get the header directory |
| 201 | // for the platform variant. Allow them to use the platform variant |
| 202 | // property to set shared_libs. |
| 203 | "prebuilts/ndk", |
| 204 | "frameworks/rs", |
| 205 | } |
| 206 | |
| 207 | return []Rule{ |
| 208 | NeverAllow(). |
Colin Cross | 440e0d0 | 2020-06-11 11:32:11 -0700 | [diff] [blame] | 209 | NotIn(sdkVersionOnlyAllowedList...). |
Colin Cross | c511bc5 | 2020-04-07 16:50:32 +0000 | [diff] [blame] | 210 | WithMatcher("sdk_variant_only", isSetMatcherInstance). |
Colin Cross | 440e0d0 | 2020-06-11 11:32:11 -0700 | [diff] [blame] | 211 | Because("sdk_variant_only can only be used in allowed projects"), |
Colin Cross | c511bc5 | 2020-04-07 16:50:32 +0000 | [diff] [blame] | 212 | NeverAllow(). |
Colin Cross | 440e0d0 | 2020-06-11 11:32:11 -0700 | [diff] [blame] | 213 | NotIn(platformVariantPropertiesAllowedList...). |
Colin Cross | c511bc5 | 2020-04-07 16:50:32 +0000 | [diff] [blame] | 214 | WithMatcher("platform.shared_libs", isSetMatcherInstance). |
Colin Cross | 440e0d0 | 2020-06-11 11:32:11 -0700 | [diff] [blame] | 215 | Because("platform variant properties can only be used in allowed projects"), |
Colin Cross | c511bc5 | 2020-04-07 16:50:32 +0000 | [diff] [blame] | 216 | } |
| 217 | } |
| 218 | |
Alan Stokes | 73feba3 | 2022-11-14 12:21:24 +0000 | [diff] [blame] | 219 | func createCcStubsRule() Rule { |
| 220 | ccStubsImplementationInstallableProjectsAllowedList := []string{ |
Jiyong Park | f6736c7 | 2024-07-22 11:22:35 +0900 | [diff] [blame] | 221 | "packages/modules/Virtualization/libs/libvm_payload", |
Alan Stokes | 73feba3 | 2022-11-14 12:21:24 +0000 | [diff] [blame] | 222 | } |
| 223 | |
| 224 | return NeverAllow(). |
| 225 | NotIn(ccStubsImplementationInstallableProjectsAllowedList...). |
| 226 | WithMatcher("stubs.implementation_installable", isSetMatcherInstance). |
| 227 | Because("implementation_installable can only be used in allowed projects.") |
| 228 | } |
| 229 | |
David Srbecky | e033cba | 2020-05-20 22:20:28 +0100 | [diff] [blame] | 230 | func createUncompressDexRules() []Rule { |
| 231 | return []Rule{ |
| 232 | NeverAllow(). |
| 233 | NotIn("art"). |
| 234 | WithMatcher("uncompress_dex", isSetMatcherInstance). |
| 235 | Because("uncompress_dex is only allowed for certain jars for test in art."), |
| 236 | } |
| 237 | } |
| 238 | |
Nelson Li | 4380820 | 2024-11-20 09:05:53 +0000 | [diff] [blame] | 239 | func createInstallInRootAllowingRules() []Rule { |
Inseob Kim | 800d114 | 2021-06-14 12:03:51 +0900 | [diff] [blame] | 240 | return []Rule{ |
| 241 | NeverAllow(). |
Nikita Ioffe | 11a9c2c | 2023-06-21 16:51:09 +0100 | [diff] [blame] | 242 | Without("name", "init_first_stage_defaults"). |
Inseob Kim | 800d114 | 2021-06-14 12:03:51 +0900 | [diff] [blame] | 243 | Without("name", "init_first_stage"). |
Nikita Ioffe | 11a9c2c | 2023-06-21 16:51:09 +0100 | [diff] [blame] | 244 | Without("name", "init_first_stage.microdroid"). |
Nelson Li | 4380820 | 2024-11-20 09:05:53 +0000 | [diff] [blame] | 245 | Without("name", "librecovery_ui_ext"). |
Inseob Kim | 800d114 | 2021-06-14 12:03:51 +0900 | [diff] [blame] | 246 | With("install_in_root", "true"). |
Inseob Kim | be6a66d | 2024-07-11 15:43:44 +0900 | [diff] [blame] | 247 | NotModuleType("prebuilt_root"). |
Jihoon Kang | 320ca7c | 2024-12-03 18:14:50 +0000 | [diff] [blame] | 248 | NotModuleType("prebuilt_vendor"). |
| 249 | NotModuleType("prebuilt_sbin"). |
| 250 | NotModuleType("prebuilt_system"). |
| 251 | NotModuleType("prebuilt_first_stage_ramdisk"). |
Jihoon Kang | 96f38d2 | 2024-12-03 23:17:55 +0000 | [diff] [blame^] | 252 | NotModuleType("prebuilt_res"). |
Nelson Li | 4380820 | 2024-11-20 09:05:53 +0000 | [diff] [blame] | 253 | Because("install_in_root is only for init_first_stage or librecovery_ui_ext."), |
Inseob Kim | 800d114 | 2021-06-14 12:03:51 +0900 | [diff] [blame] | 254 | } |
| 255 | } |
| 256 | |
Jiyong Park | 3c306f3 | 2022-04-05 15:29:53 +0900 | [diff] [blame] | 257 | func createProhibitFrameworkAccessRules() []Rule { |
| 258 | return []Rule{ |
| 259 | NeverAllow(). |
| 260 | With("libs", "framework"). |
| 261 | WithoutMatcher("sdk_version", Regexp("(core_.*|^$)")). |
| 262 | Because("framework can't be used when building against SDK"), |
| 263 | } |
| 264 | } |
| 265 | |
Mark White | a15790a | 2023-08-22 21:28:11 +0000 | [diff] [blame] | 266 | func createProhibitHeaderOnlyRule() Rule { |
| 267 | return NeverAllow(). |
| 268 | Without("name", "framework-minus-apex-headers"). |
| 269 | With("headers_only", "true"). |
| 270 | Because("headers_only can only be used for generating framework-minus-apex headers for non-updatable modules") |
| 271 | } |
| 272 | |
Steven Moreland | 0db999c | 2024-09-03 22:06:24 +0000 | [diff] [blame] | 273 | func createLimitNdkExportRule() []Rule { |
| 274 | reason := "If the headers you're trying to export are meant to be a part of the NDK, they should be exposed by an ndk_headers module. If the headers shouldn't be a part of the NDK, the headers should instead be exposed from a separate `cc_library_headers` which consumers depend on." |
| 275 | // DO NOT ADD HERE - please consult danalbert@ |
| 276 | // b/357711733 |
| 277 | return []Rule{ |
| 278 | NeverAllow(). |
| 279 | NotIn("frameworks/native/libs/binder/ndk"). |
| 280 | ModuleType("ndk_library"). |
| 281 | WithMatcher("export_header_libs", isSetMatcherInstance).Because(reason), |
| 282 | NeverAllow().ModuleType("ndk_library").WithMatcher("export_generated_headers", isSetMatcherInstance).Because(reason), |
| 283 | NeverAllow().ModuleType("ndk_library").WithMatcher("export_include_dirs", isSetMatcherInstance).Because(reason), |
| 284 | NeverAllow().ModuleType("ndk_library").WithMatcher("export_shared_lib_headers", isSetMatcherInstance).Because(reason), |
| 285 | NeverAllow().ModuleType("ndk_library").WithMatcher("export_static_lib_headers", isSetMatcherInstance).Because(reason), |
| 286 | } |
| 287 | } |
| 288 | |
Inseob Kim | 76e1985 | 2024-10-10 17:57:22 +0900 | [diff] [blame] | 289 | func createLimitDirgroupRule() []Rule { |
Inseob Kim | 7195b06 | 2024-11-29 15:40:49 +0900 | [diff] [blame] | 290 | reason := "dirgroup module and dir_srcs / keep_gendir property of genrule is allowed only to Trusty build rule." |
Inseob Kim | 76e1985 | 2024-10-10 17:57:22 +0900 | [diff] [blame] | 291 | return []Rule{ |
| 292 | NeverAllow(). |
| 293 | ModuleType("dirgroup"). |
| 294 | WithMatcher("visibility", NotInList([]string{"//trusty/vendor/google/aosp/scripts"})).Because(reason), |
| 295 | NeverAllow(). |
| 296 | ModuleType("dirgroup"). |
| 297 | Without("visibility", "//trusty/vendor/google/aosp/scripts").Because(reason), |
| 298 | NeverAllow(). |
| 299 | ModuleType("genrule"). |
Inseob Kim | e8b1ac4 | 2024-10-24 09:27:44 +0000 | [diff] [blame] | 300 | Without("name", "trusty-arm64.lk.elf.gen"). |
Alice Wang | 38aed8d | 2024-11-27 08:18:59 +0000 | [diff] [blame] | 301 | Without("name", "trusty-arm64-virt-test-debug.lk.elf.gen"). |
Inseob Kim | e8b1ac4 | 2024-10-24 09:27:44 +0000 | [diff] [blame] | 302 | Without("name", "trusty-x86_64.lk.elf.gen"). |
| 303 | Without("name", "trusty-x86_64-test.lk.elf.gen"). |
Inseob Kim | 76e1985 | 2024-10-10 17:57:22 +0900 | [diff] [blame] | 304 | WithMatcher("dir_srcs", isSetMatcherInstance).Because(reason), |
Inseob Kim | 7195b06 | 2024-11-29 15:40:49 +0900 | [diff] [blame] | 305 | NeverAllow(). |
| 306 | ModuleType("genrule"). |
| 307 | Without("name", "trusty-arm64.lk.elf.gen"). |
| 308 | Without("name", "trusty-arm64-virt-test-debug.lk.elf.gen"). |
| 309 | Without("name", "trusty-x86_64.lk.elf.gen"). |
| 310 | Without("name", "trusty-x86_64-test.lk.elf.gen"). |
| 311 | With("keep_gendir", "true").Because(reason), |
Inseob Kim | 76e1985 | 2024-10-10 17:57:22 +0900 | [diff] [blame] | 312 | } |
| 313 | } |
| 314 | |
Jihoon Kang | 0d545b8 | 2024-10-11 00:21:57 +0000 | [diff] [blame] | 315 | func createFilesystemIsAutoGeneratedRule() Rule { |
| 316 | return NeverAllow(). |
| 317 | NotIn("build/soong/fsgen"). |
| 318 | ModuleType("filesystem", "android_system_image"). |
| 319 | WithMatcher("is_auto_generated", isSetMatcherInstance). |
| 320 | Because("is_auto_generated property is only allowed for filesystem modules in build/soong/fsgen directory") |
| 321 | } |
| 322 | |
Luca Stefani | 50098f7 | 2024-10-12 17:55:31 +0200 | [diff] [blame] | 323 | func createKotlinPluginRule() []Rule { |
| 324 | kotlinPluginProjectsAllowedList := []string{ |
| 325 | // TODO: Migrate compose plugin to the bundled compiler plugin |
| 326 | // Actual path prebuilts/sdk/current/androidx/m2repository/androidx/compose/compiler/compiler-hosted |
| 327 | "prebuilts/sdk/current/androidx", |
| 328 | "external/kotlinc", |
| 329 | } |
| 330 | |
| 331 | return []Rule{ |
| 332 | NeverAllow(). |
| 333 | NotIn(kotlinPluginProjectsAllowedList...). |
| 334 | ModuleType("kotlin_plugin"). |
| 335 | Because("kotlin_plugin can only be used in allowed projects"), |
| 336 | } |
| 337 | } |
| 338 | |
Jihoon Kang | 2a7bf75 | 2024-11-01 21:21:25 +0000 | [diff] [blame] | 339 | // These module types are introduced to convert PRODUCT_COPY_FILES to Soong, |
| 340 | // and is only intended to be used by filesystem_creator. |
| 341 | func createPrebuiltEtcBpDefineRule() Rule { |
| 342 | return NeverAllow(). |
| 343 | ModuleType( |
| 344 | "prebuilt_usr_srec", |
| 345 | "prebuilt_priv_app", |
| 346 | "prebuilt_rfs", |
| 347 | "prebuilt_framework", |
Jihoon Kang | 2a7bf75 | 2024-11-01 21:21:25 +0000 | [diff] [blame] | 348 | "prebuilt_wlc_upt", |
| 349 | "prebuilt_odm", |
Jihoon Kang | 2e2b744 | 2024-11-05 00:26:20 +0000 | [diff] [blame] | 350 | "prebuilt_vendor_dlkm", |
| 351 | "prebuilt_bt_firmware", |
Jihoon Kang | dca2f2b | 2024-11-06 18:43:19 +0000 | [diff] [blame] | 352 | "prebuilt_tvservice", |
| 353 | "prebuilt_optee", |
Jihoon Kang | ecf76dd | 2024-11-12 05:24:46 +0000 | [diff] [blame] | 354 | "prebuilt_tvconfig", |
Jihoon Kang | 3ca07a1 | 2024-12-02 19:14:30 +0000 | [diff] [blame] | 355 | "prebuilt_vendor", |
Jihoon Kang | 320ca7c | 2024-12-03 18:14:50 +0000 | [diff] [blame] | 356 | "prebuilt_sbin", |
| 357 | "prebuilt_system", |
| 358 | "prebuilt_first_stage_ramdisk", |
Jihoon Kang | 2a7bf75 | 2024-11-01 21:21:25 +0000 | [diff] [blame] | 359 | ). |
| 360 | DefinedInBpFile(). |
| 361 | Because("module type not allowed to be defined in bp file") |
| 362 | } |
| 363 | |
Spandan Das | e2f98da | 2024-11-18 19:22:39 +0000 | [diff] [blame] | 364 | func createAutogenRroBpDefineRule() Rule { |
| 365 | return NeverAllow(). |
| 366 | ModuleType( |
| 367 | "autogen_runtime_resource_overlay", |
| 368 | ). |
| 369 | DefinedInBpFile(). |
| 370 | Because("Module type will be autogenerated by soong. Use runtime_resource_overlay instead") |
| 371 | } |
| 372 | |
Steven Moreland | 65b3fd9 | 2017-12-06 14:18:35 -0800 | [diff] [blame] | 373 | func neverallowMutator(ctx BottomUpMutatorContext) { |
| 374 | m, ok := ctx.Module().(Module) |
| 375 | if !ok { |
| 376 | return |
| 377 | } |
| 378 | |
| 379 | dir := ctx.ModuleDir() + "/" |
| 380 | properties := m.GetProperties() |
| 381 | |
Paul Duffin | f1c9bbe | 2019-07-26 10:48:06 +0100 | [diff] [blame] | 382 | osClass := ctx.Module().Target().Os.Class |
| 383 | |
Paul Duffin | 115445b | 2019-08-07 15:31:07 +0100 | [diff] [blame] | 384 | for _, r := range neverallowRules(ctx.Config()) { |
Paul Duffin | 730f2a5 | 2019-06-27 14:08:51 +0100 | [diff] [blame] | 385 | n := r.(*rule) |
Steven Moreland | 65b3fd9 | 2017-12-06 14:18:35 -0800 | [diff] [blame] | 386 | if !n.appliesToPath(dir) { |
| 387 | continue |
| 388 | } |
| 389 | |
Colin Cross | fd4f743 | 2019-03-05 15:06:16 -0800 | [diff] [blame] | 390 | if !n.appliesToModuleType(ctx.ModuleType()) { |
| 391 | continue |
| 392 | } |
| 393 | |
Cole Faust | 5b35cb9 | 2024-08-27 15:47:06 -0700 | [diff] [blame] | 394 | if !n.appliesToProperties(ctx, properties) { |
Steven Moreland | 65b3fd9 | 2017-12-06 14:18:35 -0800 | [diff] [blame] | 395 | continue |
| 396 | } |
| 397 | |
Paul Duffin | f1c9bbe | 2019-07-26 10:48:06 +0100 | [diff] [blame] | 398 | if !n.appliesToOsClass(osClass) { |
| 399 | continue |
| 400 | } |
| 401 | |
Paul Duffin | 3578188 | 2019-07-25 15:41:09 +0100 | [diff] [blame] | 402 | if !n.appliesToDirectDeps(ctx) { |
| 403 | continue |
| 404 | } |
| 405 | |
Jihoon Kang | 2a7bf75 | 2024-11-01 21:21:25 +0000 | [diff] [blame] | 406 | if !n.appliesToBpDefinedModule(ctx) { |
| 407 | continue |
| 408 | } |
| 409 | |
Steven Moreland | 65b3fd9 | 2017-12-06 14:18:35 -0800 | [diff] [blame] | 410 | ctx.ModuleErrorf("violates " + n.String()) |
| 411 | } |
| 412 | } |
| 413 | |
Paul Duffin | 73bf054 | 2019-07-12 14:12:49 +0100 | [diff] [blame] | 414 | type ValueMatcher interface { |
Anton Hansson | e1b1836 | 2021-12-23 15:05:38 +0000 | [diff] [blame] | 415 | Test(string) bool |
Paul Duffin | 73bf054 | 2019-07-12 14:12:49 +0100 | [diff] [blame] | 416 | String() string |
| 417 | } |
| 418 | |
| 419 | type equalMatcher struct { |
| 420 | expected string |
| 421 | } |
| 422 | |
Anton Hansson | e1b1836 | 2021-12-23 15:05:38 +0000 | [diff] [blame] | 423 | func (m *equalMatcher) Test(value string) bool { |
Paul Duffin | 73bf054 | 2019-07-12 14:12:49 +0100 | [diff] [blame] | 424 | return m.expected == value |
| 425 | } |
| 426 | |
| 427 | func (m *equalMatcher) String() string { |
| 428 | return "=" + m.expected |
| 429 | } |
| 430 | |
| 431 | type anyMatcher struct { |
| 432 | } |
| 433 | |
Anton Hansson | e1b1836 | 2021-12-23 15:05:38 +0000 | [diff] [blame] | 434 | func (m *anyMatcher) Test(value string) bool { |
Paul Duffin | 73bf054 | 2019-07-12 14:12:49 +0100 | [diff] [blame] | 435 | return true |
| 436 | } |
| 437 | |
| 438 | func (m *anyMatcher) String() string { |
| 439 | return "=*" |
| 440 | } |
| 441 | |
| 442 | var anyMatcherInstance = &anyMatcher{} |
| 443 | |
Paul Duffin | c811170 | 2019-07-22 12:13:55 +0100 | [diff] [blame] | 444 | type startsWithMatcher struct { |
| 445 | prefix string |
| 446 | } |
| 447 | |
Anton Hansson | e1b1836 | 2021-12-23 15:05:38 +0000 | [diff] [blame] | 448 | func (m *startsWithMatcher) Test(value string) bool { |
Paul Duffin | c811170 | 2019-07-22 12:13:55 +0100 | [diff] [blame] | 449 | return strings.HasPrefix(value, m.prefix) |
| 450 | } |
| 451 | |
| 452 | func (m *startsWithMatcher) String() string { |
| 453 | return ".starts-with(" + m.prefix + ")" |
| 454 | } |
| 455 | |
Anton Hansson | 4537640 | 2020-04-09 14:18:21 +0100 | [diff] [blame] | 456 | type regexMatcher struct { |
| 457 | re *regexp.Regexp |
| 458 | } |
| 459 | |
Anton Hansson | e1b1836 | 2021-12-23 15:05:38 +0000 | [diff] [blame] | 460 | func (m *regexMatcher) Test(value string) bool { |
Anton Hansson | 4537640 | 2020-04-09 14:18:21 +0100 | [diff] [blame] | 461 | return m.re.MatchString(value) |
| 462 | } |
| 463 | |
| 464 | func (m *regexMatcher) String() string { |
| 465 | return ".regexp(" + m.re.String() + ")" |
| 466 | } |
| 467 | |
Andrei Onea | 115e7e7 | 2020-06-05 21:14:03 +0100 | [diff] [blame] | 468 | type notInListMatcher struct { |
| 469 | allowed []string |
| 470 | } |
| 471 | |
Anton Hansson | e1b1836 | 2021-12-23 15:05:38 +0000 | [diff] [blame] | 472 | func (m *notInListMatcher) Test(value string) bool { |
Andrei Onea | 115e7e7 | 2020-06-05 21:14:03 +0100 | [diff] [blame] | 473 | return !InList(value, m.allowed) |
| 474 | } |
| 475 | |
| 476 | func (m *notInListMatcher) String() string { |
| 477 | return ".not-in-list(" + strings.Join(m.allowed, ",") + ")" |
| 478 | } |
| 479 | |
Colin Cross | c511bc5 | 2020-04-07 16:50:32 +0000 | [diff] [blame] | 480 | type isSetMatcher struct{} |
| 481 | |
Anton Hansson | e1b1836 | 2021-12-23 15:05:38 +0000 | [diff] [blame] | 482 | func (m *isSetMatcher) Test(value string) bool { |
Colin Cross | c511bc5 | 2020-04-07 16:50:32 +0000 | [diff] [blame] | 483 | return value != "" |
| 484 | } |
| 485 | |
| 486 | func (m *isSetMatcher) String() string { |
| 487 | return ".is-set" |
| 488 | } |
| 489 | |
| 490 | var isSetMatcherInstance = &isSetMatcher{} |
| 491 | |
Steven Moreland | 65b3fd9 | 2017-12-06 14:18:35 -0800 | [diff] [blame] | 492 | type ruleProperty struct { |
Paul Duffin | 73bf054 | 2019-07-12 14:12:49 +0100 | [diff] [blame] | 493 | fields []string // e.x.: Vndk.Enabled |
| 494 | matcher ValueMatcher |
Steven Moreland | 65b3fd9 | 2017-12-06 14:18:35 -0800 | [diff] [blame] | 495 | } |
| 496 | |
Liz Kammer | a3d7915 | 2021-10-28 18:14:04 -0400 | [diff] [blame] | 497 | func (r *ruleProperty) String() string { |
| 498 | return fmt.Sprintf("%q matches: %s", strings.Join(r.fields, "."), r.matcher) |
| 499 | } |
| 500 | |
| 501 | type ruleProperties []ruleProperty |
| 502 | |
| 503 | func (r ruleProperties) String() string { |
| 504 | var s []string |
| 505 | for _, r := range r { |
| 506 | s = append(s, r.String()) |
| 507 | } |
| 508 | return strings.Join(s, " ") |
| 509 | } |
| 510 | |
Paul Duffin | 730f2a5 | 2019-06-27 14:08:51 +0100 | [diff] [blame] | 511 | // A NeverAllow rule. |
| 512 | type Rule interface { |
| 513 | In(path ...string) Rule |
| 514 | |
| 515 | NotIn(path ...string) Rule |
| 516 | |
Paul Duffin | 3578188 | 2019-07-25 15:41:09 +0100 | [diff] [blame] | 517 | InDirectDeps(deps ...string) Rule |
| 518 | |
Paul Duffin | f1c9bbe | 2019-07-26 10:48:06 +0100 | [diff] [blame] | 519 | WithOsClass(osClasses ...OsClass) Rule |
| 520 | |
Paul Duffin | 730f2a5 | 2019-06-27 14:08:51 +0100 | [diff] [blame] | 521 | ModuleType(types ...string) Rule |
| 522 | |
| 523 | NotModuleType(types ...string) Rule |
| 524 | |
| 525 | With(properties, value string) Rule |
| 526 | |
Paul Duffin | c811170 | 2019-07-22 12:13:55 +0100 | [diff] [blame] | 527 | WithMatcher(properties string, matcher ValueMatcher) Rule |
| 528 | |
Paul Duffin | 730f2a5 | 2019-06-27 14:08:51 +0100 | [diff] [blame] | 529 | Without(properties, value string) Rule |
| 530 | |
Paul Duffin | c811170 | 2019-07-22 12:13:55 +0100 | [diff] [blame] | 531 | WithoutMatcher(properties string, matcher ValueMatcher) Rule |
| 532 | |
Jihoon Kang | 2a7bf75 | 2024-11-01 21:21:25 +0000 | [diff] [blame] | 533 | DefinedInBpFile() Rule |
| 534 | |
Paul Duffin | 730f2a5 | 2019-06-27 14:08:51 +0100 | [diff] [blame] | 535 | Because(reason string) Rule |
| 536 | } |
| 537 | |
Steven Moreland | 65b3fd9 | 2017-12-06 14:18:35 -0800 | [diff] [blame] | 538 | type rule struct { |
| 539 | // User string for why this is a thing. |
| 540 | reason string |
| 541 | |
| 542 | paths []string |
| 543 | unlessPaths []string |
| 544 | |
Paul Duffin | 3578188 | 2019-07-25 15:41:09 +0100 | [diff] [blame] | 545 | directDeps map[string]bool |
| 546 | |
Paul Duffin | f1c9bbe | 2019-07-26 10:48:06 +0100 | [diff] [blame] | 547 | osClasses []OsClass |
| 548 | |
Colin Cross | fd4f743 | 2019-03-05 15:06:16 -0800 | [diff] [blame] | 549 | moduleTypes []string |
| 550 | unlessModuleTypes []string |
| 551 | |
Liz Kammer | a3d7915 | 2021-10-28 18:14:04 -0400 | [diff] [blame] | 552 | props ruleProperties |
| 553 | unlessProps ruleProperties |
Andrei Onea | 115e7e7 | 2020-06-05 21:14:03 +0100 | [diff] [blame] | 554 | |
| 555 | onlyBootclasspathJar bool |
Jihoon Kang | 2a7bf75 | 2024-11-01 21:21:25 +0000 | [diff] [blame] | 556 | |
| 557 | definedInBp bool |
Steven Moreland | 65b3fd9 | 2017-12-06 14:18:35 -0800 | [diff] [blame] | 558 | } |
| 559 | |
Paul Duffin | 730f2a5 | 2019-06-27 14:08:51 +0100 | [diff] [blame] | 560 | // Create a new NeverAllow rule. |
| 561 | func NeverAllow() Rule { |
Paul Duffin | 3578188 | 2019-07-25 15:41:09 +0100 | [diff] [blame] | 562 | return &rule{directDeps: make(map[string]bool)} |
Steven Moreland | 65b3fd9 | 2017-12-06 14:18:35 -0800 | [diff] [blame] | 563 | } |
Colin Cross | fd4f743 | 2019-03-05 15:06:16 -0800 | [diff] [blame] | 564 | |
Liz Kammer | a3d7915 | 2021-10-28 18:14:04 -0400 | [diff] [blame] | 565 | // In adds path(s) where this rule applies. |
Paul Duffin | 730f2a5 | 2019-06-27 14:08:51 +0100 | [diff] [blame] | 566 | func (r *rule) In(path ...string) Rule { |
Steven Moreland | 65b3fd9 | 2017-12-06 14:18:35 -0800 | [diff] [blame] | 567 | r.paths = append(r.paths, cleanPaths(path)...) |
| 568 | return r |
| 569 | } |
Colin Cross | fd4f743 | 2019-03-05 15:06:16 -0800 | [diff] [blame] | 570 | |
Liz Kammer | a3d7915 | 2021-10-28 18:14:04 -0400 | [diff] [blame] | 571 | // NotIn adds path(s) to that this rule does not apply to. |
Paul Duffin | 730f2a5 | 2019-06-27 14:08:51 +0100 | [diff] [blame] | 572 | func (r *rule) NotIn(path ...string) Rule { |
Steven Moreland | 65b3fd9 | 2017-12-06 14:18:35 -0800 | [diff] [blame] | 573 | r.unlessPaths = append(r.unlessPaths, cleanPaths(path)...) |
| 574 | return r |
| 575 | } |
Colin Cross | fd4f743 | 2019-03-05 15:06:16 -0800 | [diff] [blame] | 576 | |
Liz Kammer | a3d7915 | 2021-10-28 18:14:04 -0400 | [diff] [blame] | 577 | // InDirectDeps adds dep(s) that are not allowed with this rule. |
Paul Duffin | 3578188 | 2019-07-25 15:41:09 +0100 | [diff] [blame] | 578 | func (r *rule) InDirectDeps(deps ...string) Rule { |
| 579 | for _, d := range deps { |
| 580 | r.directDeps[d] = true |
| 581 | } |
| 582 | return r |
| 583 | } |
| 584 | |
Liz Kammer | a3d7915 | 2021-10-28 18:14:04 -0400 | [diff] [blame] | 585 | // WithOsClass adds osClass(es) that this rule applies to. |
Paul Duffin | f1c9bbe | 2019-07-26 10:48:06 +0100 | [diff] [blame] | 586 | func (r *rule) WithOsClass(osClasses ...OsClass) Rule { |
| 587 | r.osClasses = append(r.osClasses, osClasses...) |
| 588 | return r |
| 589 | } |
| 590 | |
Liz Kammer | a3d7915 | 2021-10-28 18:14:04 -0400 | [diff] [blame] | 591 | // ModuleType adds type(s) that this rule applies to. |
Paul Duffin | 730f2a5 | 2019-06-27 14:08:51 +0100 | [diff] [blame] | 592 | func (r *rule) ModuleType(types ...string) Rule { |
Colin Cross | fd4f743 | 2019-03-05 15:06:16 -0800 | [diff] [blame] | 593 | r.moduleTypes = append(r.moduleTypes, types...) |
| 594 | return r |
| 595 | } |
| 596 | |
Liz Kammer | a3d7915 | 2021-10-28 18:14:04 -0400 | [diff] [blame] | 597 | // NotModuleType adds type(s) that this rule does not apply to.. |
Paul Duffin | 730f2a5 | 2019-06-27 14:08:51 +0100 | [diff] [blame] | 598 | func (r *rule) NotModuleType(types ...string) Rule { |
Colin Cross | fd4f743 | 2019-03-05 15:06:16 -0800 | [diff] [blame] | 599 | r.unlessModuleTypes = append(r.unlessModuleTypes, types...) |
| 600 | return r |
| 601 | } |
| 602 | |
Liz Kammer | a3d7915 | 2021-10-28 18:14:04 -0400 | [diff] [blame] | 603 | // With specifies property/value combinations that are restricted for this rule. |
Paul Duffin | 730f2a5 | 2019-06-27 14:08:51 +0100 | [diff] [blame] | 604 | func (r *rule) With(properties, value string) Rule { |
Paul Duffin | c811170 | 2019-07-22 12:13:55 +0100 | [diff] [blame] | 605 | return r.WithMatcher(properties, selectMatcher(value)) |
| 606 | } |
| 607 | |
Liz Kammer | a3d7915 | 2021-10-28 18:14:04 -0400 | [diff] [blame] | 608 | // WithMatcher specifies property/matcher combinations that are restricted for this rule. |
Paul Duffin | c811170 | 2019-07-22 12:13:55 +0100 | [diff] [blame] | 609 | func (r *rule) WithMatcher(properties string, matcher ValueMatcher) Rule { |
Steven Moreland | 65b3fd9 | 2017-12-06 14:18:35 -0800 | [diff] [blame] | 610 | r.props = append(r.props, ruleProperty{ |
Paul Duffin | 73bf054 | 2019-07-12 14:12:49 +0100 | [diff] [blame] | 611 | fields: fieldNamesForProperties(properties), |
Paul Duffin | c811170 | 2019-07-22 12:13:55 +0100 | [diff] [blame] | 612 | matcher: matcher, |
Steven Moreland | 65b3fd9 | 2017-12-06 14:18:35 -0800 | [diff] [blame] | 613 | }) |
| 614 | return r |
| 615 | } |
Colin Cross | fd4f743 | 2019-03-05 15:06:16 -0800 | [diff] [blame] | 616 | |
Liz Kammer | a3d7915 | 2021-10-28 18:14:04 -0400 | [diff] [blame] | 617 | // Without specifies property/value combinations that this rule does not apply to. |
Paul Duffin | 730f2a5 | 2019-06-27 14:08:51 +0100 | [diff] [blame] | 618 | func (r *rule) Without(properties, value string) Rule { |
Paul Duffin | c811170 | 2019-07-22 12:13:55 +0100 | [diff] [blame] | 619 | return r.WithoutMatcher(properties, selectMatcher(value)) |
| 620 | } |
| 621 | |
Liz Kammer | a3d7915 | 2021-10-28 18:14:04 -0400 | [diff] [blame] | 622 | // Without specifies property/matcher combinations that this rule does not apply to. |
Paul Duffin | c811170 | 2019-07-22 12:13:55 +0100 | [diff] [blame] | 623 | func (r *rule) WithoutMatcher(properties string, matcher ValueMatcher) Rule { |
Steven Moreland | 65b3fd9 | 2017-12-06 14:18:35 -0800 | [diff] [blame] | 624 | r.unlessProps = append(r.unlessProps, ruleProperty{ |
Paul Duffin | 73bf054 | 2019-07-12 14:12:49 +0100 | [diff] [blame] | 625 | fields: fieldNamesForProperties(properties), |
Paul Duffin | c811170 | 2019-07-22 12:13:55 +0100 | [diff] [blame] | 626 | matcher: matcher, |
Steven Moreland | 65b3fd9 | 2017-12-06 14:18:35 -0800 | [diff] [blame] | 627 | }) |
| 628 | return r |
| 629 | } |
Colin Cross | fd4f743 | 2019-03-05 15:06:16 -0800 | [diff] [blame] | 630 | |
Jihoon Kang | 2a7bf75 | 2024-11-01 21:21:25 +0000 | [diff] [blame] | 631 | // DefinedInBpFile specifies that this rule applies to modules that are defined |
| 632 | // in bp files, and does not apply to modules that are auto generated by other modules. |
| 633 | func (r *rule) DefinedInBpFile() Rule { |
| 634 | r.definedInBp = true |
| 635 | return r |
| 636 | } |
| 637 | |
Paul Duffin | 73bf054 | 2019-07-12 14:12:49 +0100 | [diff] [blame] | 638 | func selectMatcher(expected string) ValueMatcher { |
| 639 | if expected == "*" { |
| 640 | return anyMatcherInstance |
| 641 | } |
| 642 | return &equalMatcher{expected: expected} |
| 643 | } |
| 644 | |
Liz Kammer | a3d7915 | 2021-10-28 18:14:04 -0400 | [diff] [blame] | 645 | // Because specifies a reason for this rule. |
Paul Duffin | 730f2a5 | 2019-06-27 14:08:51 +0100 | [diff] [blame] | 646 | func (r *rule) Because(reason string) Rule { |
Steven Moreland | 65b3fd9 | 2017-12-06 14:18:35 -0800 | [diff] [blame] | 647 | r.reason = reason |
| 648 | return r |
| 649 | } |
| 650 | |
| 651 | func (r *rule) String() string { |
Liz Kammer | a3d7915 | 2021-10-28 18:14:04 -0400 | [diff] [blame] | 652 | s := []string{"neverallow requirements. Not allowed:"} |
| 653 | if len(r.paths) > 0 { |
| 654 | s = append(s, fmt.Sprintf("in dirs: %q", r.paths)) |
Steven Moreland | 65b3fd9 | 2017-12-06 14:18:35 -0800 | [diff] [blame] | 655 | } |
Liz Kammer | a3d7915 | 2021-10-28 18:14:04 -0400 | [diff] [blame] | 656 | if len(r.moduleTypes) > 0 { |
| 657 | s = append(s, fmt.Sprintf("module types: %q", r.moduleTypes)) |
Steven Moreland | 65b3fd9 | 2017-12-06 14:18:35 -0800 | [diff] [blame] | 658 | } |
Liz Kammer | a3d7915 | 2021-10-28 18:14:04 -0400 | [diff] [blame] | 659 | if len(r.props) > 0 { |
| 660 | s = append(s, fmt.Sprintf("properties matching: %s", r.props)) |
Colin Cross | fd4f743 | 2019-03-05 15:06:16 -0800 | [diff] [blame] | 661 | } |
Liz Kammer | a3d7915 | 2021-10-28 18:14:04 -0400 | [diff] [blame] | 662 | if len(r.directDeps) > 0 { |
Cole Faust | 18994c7 | 2023-02-28 16:02:16 -0800 | [diff] [blame] | 663 | s = append(s, fmt.Sprintf("dep(s): %q", SortedKeys(r.directDeps))) |
Colin Cross | fd4f743 | 2019-03-05 15:06:16 -0800 | [diff] [blame] | 664 | } |
Liz Kammer | a3d7915 | 2021-10-28 18:14:04 -0400 | [diff] [blame] | 665 | if len(r.osClasses) > 0 { |
| 666 | s = append(s, fmt.Sprintf("os class(es): %q", r.osClasses)) |
Paul Duffin | f1c9bbe | 2019-07-26 10:48:06 +0100 | [diff] [blame] | 667 | } |
Liz Kammer | a3d7915 | 2021-10-28 18:14:04 -0400 | [diff] [blame] | 668 | if len(r.unlessPaths) > 0 { |
| 669 | s = append(s, fmt.Sprintf("EXCEPT in dirs: %q", r.unlessPaths)) |
| 670 | } |
| 671 | if len(r.unlessModuleTypes) > 0 { |
| 672 | s = append(s, fmt.Sprintf("EXCEPT module types: %q", r.unlessModuleTypes)) |
| 673 | } |
| 674 | if len(r.unlessProps) > 0 { |
| 675 | s = append(s, fmt.Sprintf("EXCEPT properties matching: %q", r.unlessProps)) |
Andrei Onea | 115e7e7 | 2020-06-05 21:14:03 +0100 | [diff] [blame] | 676 | } |
Steven Moreland | 65b3fd9 | 2017-12-06 14:18:35 -0800 | [diff] [blame] | 677 | if len(r.reason) != 0 { |
Liz Kammer | a3d7915 | 2021-10-28 18:14:04 -0400 | [diff] [blame] | 678 | s = append(s, " which is restricted because "+r.reason) |
Steven Moreland | 65b3fd9 | 2017-12-06 14:18:35 -0800 | [diff] [blame] | 679 | } |
Liz Kammer | a3d7915 | 2021-10-28 18:14:04 -0400 | [diff] [blame] | 680 | if len(s) == 1 { |
| 681 | s[0] = "neverallow requirements (empty)" |
| 682 | } |
| 683 | return strings.Join(s, "\n\t") |
Steven Moreland | 65b3fd9 | 2017-12-06 14:18:35 -0800 | [diff] [blame] | 684 | } |
| 685 | |
| 686 | func (r *rule) appliesToPath(dir string) bool { |
Jaewoong Jung | 3aff578 | 2020-02-11 07:54:35 -0800 | [diff] [blame] | 687 | includePath := len(r.paths) == 0 || HasAnyPrefix(dir, r.paths) |
| 688 | excludePath := HasAnyPrefix(dir, r.unlessPaths) |
Steven Moreland | 65b3fd9 | 2017-12-06 14:18:35 -0800 | [diff] [blame] | 689 | return includePath && !excludePath |
| 690 | } |
| 691 | |
Paul Duffin | 3578188 | 2019-07-25 15:41:09 +0100 | [diff] [blame] | 692 | func (r *rule) appliesToDirectDeps(ctx BottomUpMutatorContext) bool { |
| 693 | if len(r.directDeps) == 0 { |
| 694 | return true |
| 695 | } |
| 696 | |
| 697 | matches := false |
| 698 | ctx.VisitDirectDeps(func(m Module) { |
| 699 | if !matches { |
| 700 | name := ctx.OtherModuleName(m) |
| 701 | matches = r.directDeps[name] |
| 702 | } |
| 703 | }) |
| 704 | |
| 705 | return matches |
| 706 | } |
| 707 | |
Paul Duffin | f1c9bbe | 2019-07-26 10:48:06 +0100 | [diff] [blame] | 708 | func (r *rule) appliesToOsClass(osClass OsClass) bool { |
| 709 | if len(r.osClasses) == 0 { |
| 710 | return true |
| 711 | } |
| 712 | |
| 713 | for _, c := range r.osClasses { |
| 714 | if c == osClass { |
| 715 | return true |
| 716 | } |
| 717 | } |
| 718 | |
| 719 | return false |
| 720 | } |
| 721 | |
Colin Cross | fd4f743 | 2019-03-05 15:06:16 -0800 | [diff] [blame] | 722 | func (r *rule) appliesToModuleType(moduleType string) bool { |
Jihoon Kang | d546507 | 2024-12-03 00:53:05 +0000 | [diff] [blame] | 723 | // Remove prefix for auto-generated modules |
| 724 | moduleType = strings.TrimSuffix(moduleType, "__loadHookModule") |
| 725 | moduleType = strings.TrimSuffix(moduleType, "__bottomUpMutatorModule") |
Colin Cross | fd4f743 | 2019-03-05 15:06:16 -0800 | [diff] [blame] | 726 | return (len(r.moduleTypes) == 0 || InList(moduleType, r.moduleTypes)) && !InList(moduleType, r.unlessModuleTypes) |
| 727 | } |
| 728 | |
Cole Faust | 5b35cb9 | 2024-08-27 15:47:06 -0700 | [diff] [blame] | 729 | func (r *rule) appliesToProperties(ctx BottomUpMutatorContext, properties []interface{}) bool { |
| 730 | includeProps := hasAllProperties(ctx, properties, r.props) |
| 731 | excludeProps := hasAnyProperty(ctx, properties, r.unlessProps) |
Steven Moreland | 65b3fd9 | 2017-12-06 14:18:35 -0800 | [diff] [blame] | 732 | return includeProps && !excludeProps |
| 733 | } |
| 734 | |
Jihoon Kang | 2a7bf75 | 2024-11-01 21:21:25 +0000 | [diff] [blame] | 735 | func (r *rule) appliesToBpDefinedModule(ctx BottomUpMutatorContext) bool { |
| 736 | if !r.definedInBp { |
| 737 | return true |
| 738 | } |
| 739 | return !ctx.OtherModuleIsAutoGenerated(ctx.Module()) == r.definedInBp |
| 740 | } |
| 741 | |
Paul Duffin | c811170 | 2019-07-22 12:13:55 +0100 | [diff] [blame] | 742 | func StartsWith(prefix string) ValueMatcher { |
| 743 | return &startsWithMatcher{prefix} |
| 744 | } |
| 745 | |
Anton Hansson | 4537640 | 2020-04-09 14:18:21 +0100 | [diff] [blame] | 746 | func Regexp(re string) ValueMatcher { |
| 747 | r, err := regexp.Compile(re) |
| 748 | if err != nil { |
| 749 | panic(err) |
| 750 | } |
| 751 | return ®exMatcher{r} |
| 752 | } |
| 753 | |
Andrei Onea | 115e7e7 | 2020-06-05 21:14:03 +0100 | [diff] [blame] | 754 | func NotInList(allowed []string) ValueMatcher { |
| 755 | return ¬InListMatcher{allowed} |
| 756 | } |
| 757 | |
Steven Moreland | 65b3fd9 | 2017-12-06 14:18:35 -0800 | [diff] [blame] | 758 | // assorted utils |
| 759 | |
| 760 | func cleanPaths(paths []string) []string { |
| 761 | res := make([]string, len(paths)) |
| 762 | for i, v := range paths { |
| 763 | res[i] = filepath.Clean(v) + "/" |
| 764 | } |
| 765 | return res |
| 766 | } |
| 767 | |
| 768 | func fieldNamesForProperties(propertyNames string) []string { |
| 769 | names := strings.Split(propertyNames, ".") |
| 770 | for i, v := range names { |
| 771 | names[i] = proptools.FieldNameForProperty(v) |
| 772 | } |
| 773 | return names |
| 774 | } |
| 775 | |
Cole Faust | 5b35cb9 | 2024-08-27 15:47:06 -0700 | [diff] [blame] | 776 | func hasAnyProperty(ctx BottomUpMutatorContext, properties []interface{}, props []ruleProperty) bool { |
Steven Moreland | 65b3fd9 | 2017-12-06 14:18:35 -0800 | [diff] [blame] | 777 | for _, v := range props { |
Cole Faust | 5b35cb9 | 2024-08-27 15:47:06 -0700 | [diff] [blame] | 778 | if hasProperty(ctx, properties, v) { |
Steven Moreland | 65b3fd9 | 2017-12-06 14:18:35 -0800 | [diff] [blame] | 779 | return true |
| 780 | } |
| 781 | } |
| 782 | return false |
| 783 | } |
| 784 | |
Cole Faust | 5b35cb9 | 2024-08-27 15:47:06 -0700 | [diff] [blame] | 785 | func hasAllProperties(ctx BottomUpMutatorContext, properties []interface{}, props []ruleProperty) bool { |
Steven Moreland | 65b3fd9 | 2017-12-06 14:18:35 -0800 | [diff] [blame] | 786 | for _, v := range props { |
Cole Faust | 5b35cb9 | 2024-08-27 15:47:06 -0700 | [diff] [blame] | 787 | if !hasProperty(ctx, properties, v) { |
Steven Moreland | 65b3fd9 | 2017-12-06 14:18:35 -0800 | [diff] [blame] | 788 | return false |
| 789 | } |
| 790 | } |
| 791 | return true |
| 792 | } |
| 793 | |
Cole Faust | 5b35cb9 | 2024-08-27 15:47:06 -0700 | [diff] [blame] | 794 | func hasProperty(ctx BottomUpMutatorContext, properties []interface{}, prop ruleProperty) bool { |
Steven Moreland | 65b3fd9 | 2017-12-06 14:18:35 -0800 | [diff] [blame] | 795 | for _, propertyStruct := range properties { |
| 796 | propertiesValue := reflect.ValueOf(propertyStruct).Elem() |
| 797 | for _, v := range prop.fields { |
| 798 | if !propertiesValue.IsValid() { |
| 799 | break |
| 800 | } |
| 801 | propertiesValue = propertiesValue.FieldByName(v) |
| 802 | } |
| 803 | if !propertiesValue.IsValid() { |
| 804 | continue |
| 805 | } |
| 806 | |
Paul Duffin | 73bf054 | 2019-07-12 14:12:49 +0100 | [diff] [blame] | 807 | check := func(value string) bool { |
Anton Hansson | e1b1836 | 2021-12-23 15:05:38 +0000 | [diff] [blame] | 808 | return prop.matcher.Test(value) |
Steven Moreland | 65b3fd9 | 2017-12-06 14:18:35 -0800 | [diff] [blame] | 809 | } |
| 810 | |
Cole Faust | 5b35cb9 | 2024-08-27 15:47:06 -0700 | [diff] [blame] | 811 | if matchValue(ctx, propertiesValue, check) { |
Steven Moreland | 65b3fd9 | 2017-12-06 14:18:35 -0800 | [diff] [blame] | 812 | return true |
| 813 | } |
| 814 | } |
| 815 | return false |
| 816 | } |
| 817 | |
Cole Faust | 5b35cb9 | 2024-08-27 15:47:06 -0700 | [diff] [blame] | 818 | func matchValue(ctx BottomUpMutatorContext, value reflect.Value, check func(string) bool) bool { |
Steven Moreland | 65b3fd9 | 2017-12-06 14:18:35 -0800 | [diff] [blame] | 819 | if !value.IsValid() { |
| 820 | return false |
| 821 | } |
| 822 | |
| 823 | if value.Kind() == reflect.Ptr { |
| 824 | if value.IsNil() { |
| 825 | return check("") |
| 826 | } |
| 827 | value = value.Elem() |
| 828 | } |
| 829 | |
Cole Faust | 5b35cb9 | 2024-08-27 15:47:06 -0700 | [diff] [blame] | 830 | switch v := value.Interface().(type) { |
| 831 | case string: |
| 832 | return check(v) |
| 833 | case bool: |
| 834 | return check(strconv.FormatBool(v)) |
| 835 | case int: |
| 836 | return check(strconv.FormatInt((int64)(v), 10)) |
| 837 | case []string: |
| 838 | for _, v := range v { |
| 839 | if check(v) { |
| 840 | return true |
| 841 | } |
Steven Moreland | 65b3fd9 | 2017-12-06 14:18:35 -0800 | [diff] [blame] | 842 | } |
Cole Faust | 5b35cb9 | 2024-08-27 15:47:06 -0700 | [diff] [blame] | 843 | return false |
| 844 | case proptools.Configurable[string]: |
| 845 | return check(v.GetOrDefault(ctx, "")) |
| 846 | case proptools.Configurable[bool]: |
| 847 | return check(strconv.FormatBool(v.GetOrDefault(ctx, false))) |
| 848 | case proptools.Configurable[[]string]: |
| 849 | for _, v := range v.GetOrDefault(ctx, nil) { |
Steven Moreland | 65b3fd9 | 2017-12-06 14:18:35 -0800 | [diff] [blame] | 850 | if check(v) { |
| 851 | return true |
| 852 | } |
| 853 | } |
| 854 | return false |
| 855 | } |
| 856 | |
| 857 | panic("Can't handle type: " + value.Kind().String()) |
| 858 | } |
Paul Duffin | 115445b | 2019-08-07 15:31:07 +0100 | [diff] [blame] | 859 | |
| 860 | var neverallowRulesKey = NewOnceKey("neverallowRules") |
| 861 | |
| 862 | func neverallowRules(config Config) []Rule { |
| 863 | return config.Once(neverallowRulesKey, func() interface{} { |
| 864 | // No test rules were set by setTestNeverallowRules, use the global rules |
| 865 | return neverallows |
| 866 | }).([]Rule) |
| 867 | } |
| 868 | |
| 869 | // Overrides the default neverallow rules for the supplied config. |
| 870 | // |
| 871 | // For testing only. |
Paul Duffin | 45338f0 | 2021-03-30 23:07:52 +0100 | [diff] [blame] | 872 | func setTestNeverallowRules(config Config, testRules []Rule) { |
Paul Duffin | 115445b | 2019-08-07 15:31:07 +0100 | [diff] [blame] | 873 | config.Once(neverallowRulesKey, func() interface{} { return testRules }) |
| 874 | } |
Paul Duffin | 45338f0 | 2021-03-30 23:07:52 +0100 | [diff] [blame] | 875 | |
| 876 | // Prepares for a test by setting neverallow rules and enabling the mutator. |
| 877 | // |
| 878 | // If the supplied rules are nil then the default rules are used. |
| 879 | func PrepareForTestWithNeverallowRules(testRules []Rule) FixturePreparer { |
| 880 | return GroupFixturePreparers( |
| 881 | FixtureModifyConfig(func(config Config) { |
| 882 | if testRules != nil { |
| 883 | setTestNeverallowRules(config, testRules) |
| 884 | } |
| 885 | }), |
| 886 | FixtureRegisterWithContext(func(ctx RegistrationContext) { |
| 887 | ctx.PostDepsMutators(registerNeverallowMutator) |
| 888 | }), |
| 889 | ) |
| 890 | } |