blob: 1b8e9b457d32798b79c3fff58fe1ec603585d43d [file] [log] [blame]
Jingwen Chen63930982021-03-24 10:04:33 -04001// Copyright 2021 Google Inc. All rights reserved.
2//
3// Licensed under the Apache License, Version 2.0 (the "License");
4// you may not use this file except in compliance with the License.
5// You may obtain a copy of the License at
6//
7// http://www.apache.org/licenses/LICENSE-2.0
8//
9// Unless required by applicable law or agreed to in writing, software
10// distributed under the License is distributed on an "AS IS" BASIS,
11// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
12// See the License for the specific language governing permissions and
13// limitations under the License.
14
15package bp2build
16
17import (
Jingwen Chen6ada5892021-09-17 11:38:09 +000018 "fmt"
Alex Márquez Pérez Muñíz Díaz Púras Thaureaux1c92aef2021-08-23 16:10:00 +000019 "testing"
20
Jingwen Chen63930982021-03-24 10:04:33 -040021 "android/soong/android"
22 "android/soong/cc"
Jingwen Chen63930982021-03-24 10:04:33 -040023)
24
25const (
26 // See cc/testing.go for more context
27 soongCcLibraryPreamble = `
28cc_defaults {
Liz Kammer8337ea42021-09-10 10:06:32 -040029 name: "linux_bionic_supported",
Liz Kammerbaced712022-09-16 09:01:29 -040030}
31`
32
33 soongCcVersionLibBpPath = "build/soong/cc/libbuildversion/Android.bp"
34 soongCcVersionLibBp = `
35cc_library_static {
36 name: "libbuildversion",
37 bazel_module: { bp2build_available: false },
38}
39`
Liz Kammer12615db2021-09-28 09:19:17 -040040
41 soongCcProtoLibraries = `
42cc_library {
43 name: "libprotobuf-cpp-lite",
44 bazel_module: { bp2build_available: false },
45}
46
47cc_library {
48 name: "libprotobuf-cpp-full",
49 bazel_module: { bp2build_available: false },
50}`
51
52 soongCcProtoPreamble = soongCcLibraryPreamble + soongCcProtoLibraries
Jingwen Chen63930982021-03-24 10:04:33 -040053)
54
Sam Delmerico3177a6e2022-06-21 19:28:33 +000055func runCcLibraryTestCase(t *testing.T, tc Bp2buildTestCase) {
Liz Kammere4982e82021-05-25 10:39:35 -040056 t.Helper()
Sam Delmerico3177a6e2022-06-21 19:28:33 +000057 RunBp2BuildTestCase(t, registerCcLibraryModuleTypes, tc)
Lukacs T. Berkic1cc3b92021-05-21 09:37:00 +020058}
59
60func registerCcLibraryModuleTypes(ctx android.RegistrationContext) {
61 cc.RegisterCCBuildComponents(ctx)
Jingwen Chen14a8bda2021-06-02 11:10:02 +000062 ctx.RegisterModuleType("filegroup", android.FileGroupFactory)
Lukacs T. Berkic1cc3b92021-05-21 09:37:00 +020063 ctx.RegisterModuleType("cc_library_static", cc.LibraryStaticFactory)
Liz Kammer2d7bbe32021-06-10 18:20:06 -040064 ctx.RegisterModuleType("cc_prebuilt_library_static", cc.PrebuiltStaticLibraryFactory)
Lukacs T. Berkic1cc3b92021-05-21 09:37:00 +020065 ctx.RegisterModuleType("cc_library_headers", cc.LibraryHeaderFactory)
66}
67
Lukacs T. Berkic1cc3b92021-05-21 09:37:00 +020068func TestCcLibrarySimple(t *testing.T) {
Sam Delmerico3177a6e2022-06-21 19:28:33 +000069 runCcLibraryTestCase(t, Bp2buildTestCase{
70 Description: "cc_library - simple example",
71 ModuleTypeUnderTest: "cc_library",
72 ModuleTypeUnderTestFactory: cc.LibraryFactory,
73 Filesystem: map[string]string{
Liz Kammerbaced712022-09-16 09:01:29 -040074 soongCcVersionLibBpPath: soongCcVersionLibBp,
75 "android.cpp": "",
76 "bionic.cpp": "",
77 "darwin.cpp": "",
Lukacs T. Berkic1cc3b92021-05-21 09:37:00 +020078 // Refer to cc.headerExts for the supported header extensions in Soong.
79 "header.h": "",
80 "header.hh": "",
81 "header.hpp": "",
82 "header.hxx": "",
83 "header.h++": "",
84 "header.inl": "",
85 "header.inc": "",
86 "header.ipp": "",
87 "header.h.generic": "",
88 "impl.cpp": "",
89 "linux.cpp": "",
90 "x86.cpp": "",
91 "x86_64.cpp": "",
92 "foo-dir/a.h": "",
93 },
Sam Delmerico3177a6e2022-06-21 19:28:33 +000094 Blueprint: soongCcLibraryPreamble +
Liz Kammer78cfdaa2021-11-08 12:56:31 -050095 simpleModuleDoNotConvertBp2build("cc_library_headers", "some-headers") + `
Jingwen Chen63930982021-03-24 10:04:33 -040096cc_library {
97 name: "foo-lib",
98 srcs: ["impl.cpp"],
99 cflags: ["-Wall"],
100 header_libs: ["some-headers"],
101 export_include_dirs: ["foo-dir"],
102 ldflags: ["-Wl,--exclude-libs=bar.a"],
103 arch: {
104 x86: {
105 ldflags: ["-Wl,--exclude-libs=baz.a"],
106 srcs: ["x86.cpp"],
107 },
108 x86_64: {
109 ldflags: ["-Wl,--exclude-libs=qux.a"],
110 srcs: ["x86_64.cpp"],
111 },
112 },
113 target: {
114 android: {
115 srcs: ["android.cpp"],
116 },
117 linux_glibc: {
118 srcs: ["linux.cpp"],
119 },
120 darwin: {
121 srcs: ["darwin.cpp"],
122 },
Liz Kammer01a16e82021-07-16 16:33:47 -0400123 bionic: {
124 srcs: ["bionic.cpp"]
125 },
Jingwen Chen63930982021-03-24 10:04:33 -0400126 },
Liz Kammer8337ea42021-09-10 10:06:32 -0400127 include_build_directory: false,
Yu Liufc603162022-03-01 15:44:08 -0800128 sdk_version: "current",
129 min_sdk_version: "29",
Yu Liua79c9462022-03-22 16:35:22 -0700130 use_version_lib: true,
Jingwen Chen63930982021-03-24 10:04:33 -0400131}
132`,
Sam Delmerico3177a6e2022-06-21 19:28:33 +0000133 ExpectedBazelTargets: makeCcLibraryTargets("foo-lib", AttrNameToString{
Chris Parsons77acf2e2021-12-03 17:27:16 -0500134 "copts": `["-Wall"]`,
135 "export_includes": `["foo-dir"]`,
136 "implementation_deps": `[":some-headers"]`,
137 "linkopts": `["-Wl,--exclude-libs=bar.a"] + select({
Jingwen Chened9c17d2021-04-13 07:14:55 +0000138 "//build/bazel/platforms/arch:x86": ["-Wl,--exclude-libs=baz.a"],
139 "//build/bazel/platforms/arch:x86_64": ["-Wl,--exclude-libs=qux.a"],
140 "//conditions:default": [],
Liz Kammer78cfdaa2021-11-08 12:56:31 -0500141 })`,
Chris Parsons77acf2e2021-12-03 17:27:16 -0500142 "srcs": `["impl.cpp"] + select({
Jingwen Chenb4628eb2021-04-08 14:40:57 +0000143 "//build/bazel/platforms/arch:x86": ["x86.cpp"],
144 "//build/bazel/platforms/arch:x86_64": ["x86_64.cpp"],
Jingwen Chen63930982021-03-24 10:04:33 -0400145 "//conditions:default": [],
146 }) + select({
Chris Parsons2dde0cb2021-10-01 14:45:30 -0400147 "//build/bazel/platforms/os:android": [
Chris Parsons2dde0cb2021-10-01 14:45:30 -0400148 "bionic.cpp",
Liz Kammerfdd72e62021-10-11 15:41:03 -0400149 "android.cpp",
Chris Parsons2dde0cb2021-10-01 14:45:30 -0400150 ],
Jingwen Chenb4628eb2021-04-08 14:40:57 +0000151 "//build/bazel/platforms/os:darwin": ["darwin.cpp"],
152 "//build/bazel/platforms/os:linux": ["linux.cpp"],
Chris Parsons2dde0cb2021-10-01 14:45:30 -0400153 "//build/bazel/platforms/os:linux_bionic": ["bionic.cpp"],
Liz Kammer01a16e82021-07-16 16:33:47 -0400154 "//conditions:default": [],
Liz Kammer78cfdaa2021-11-08 12:56:31 -0500155 })`,
Liz Kammerbaced712022-09-16 09:01:29 -0400156 "sdk_version": `"current"`,
157 "min_sdk_version": `"29"`,
158 "use_version_lib": `True`,
159 "implementation_whole_archive_deps": `["//build/soong/cc/libbuildversion:libbuildversion"]`,
Chris Parsons77acf2e2021-12-03 17:27:16 -0500160 }),
Liz Kammer78cfdaa2021-11-08 12:56:31 -0500161 })
Lukacs T. Berkic1cc3b92021-05-21 09:37:00 +0200162}
163
164func TestCcLibraryTrimmedLdAndroid(t *testing.T) {
Sam Delmerico3177a6e2022-06-21 19:28:33 +0000165 runCcLibraryTestCase(t, Bp2buildTestCase{
166 Description: "cc_library - trimmed example of //bionic/linker:ld-android",
167 ModuleTypeUnderTest: "cc_library",
168 ModuleTypeUnderTestFactory: cc.LibraryFactory,
169 Filesystem: map[string]string{
Lukacs T. Berkic1cc3b92021-05-21 09:37:00 +0200170 "ld-android.cpp": "",
171 "linked_list.h": "",
172 "linker.h": "",
173 "linker_block_allocator.h": "",
174 "linker_cfi.h": "",
Jingwen Chen63930982021-03-24 10:04:33 -0400175 },
Sam Delmerico3177a6e2022-06-21 19:28:33 +0000176 Blueprint: soongCcLibraryPreamble +
Liz Kammerbe46fcc2021-11-01 15:32:43 -0400177 simpleModuleDoNotConvertBp2build("cc_library_headers", "libc_headers") + `
Jingwen Chen63930982021-03-24 10:04:33 -0400178cc_library {
179 name: "fake-ld-android",
180 srcs: ["ld_android.cpp"],
181 cflags: [
182 "-Wall",
183 "-Wextra",
184 "-Wunused",
185 "-Werror",
186 ],
187 header_libs: ["libc_headers"],
188 ldflags: [
189 "-Wl,--exclude-libs=libgcc.a",
190 "-Wl,--exclude-libs=libgcc_stripped.a",
191 "-Wl,--exclude-libs=libclang_rt.builtins-arm-android.a",
192 "-Wl,--exclude-libs=libclang_rt.builtins-aarch64-android.a",
193 "-Wl,--exclude-libs=libclang_rt.builtins-i686-android.a",
194 "-Wl,--exclude-libs=libclang_rt.builtins-x86_64-android.a",
195 ],
196 arch: {
197 x86: {
198 ldflags: ["-Wl,--exclude-libs=libgcc_eh.a"],
199 },
200 x86_64: {
201 ldflags: ["-Wl,--exclude-libs=libgcc_eh.a"],
202 },
203 },
Liz Kammer8337ea42021-09-10 10:06:32 -0400204 include_build_directory: false,
Jingwen Chen63930982021-03-24 10:04:33 -0400205}
206`,
Sam Delmerico3177a6e2022-06-21 19:28:33 +0000207 ExpectedBazelTargets: makeCcLibraryTargets("fake-ld-android", AttrNameToString{
Chris Parsons77acf2e2021-12-03 17:27:16 -0500208 "srcs": `["ld_android.cpp"]`,
209 "copts": `[
Jingwen Chen63930982021-03-24 10:04:33 -0400210 "-Wall",
211 "-Wextra",
212 "-Wunused",
213 "-Werror",
Liz Kammer78cfdaa2021-11-08 12:56:31 -0500214 ]`,
Chris Parsons77acf2e2021-12-03 17:27:16 -0500215 "implementation_deps": `[":libc_headers"]`,
216 "linkopts": `[
Jingwen Chen63930982021-03-24 10:04:33 -0400217 "-Wl,--exclude-libs=libgcc.a",
218 "-Wl,--exclude-libs=libgcc_stripped.a",
219 "-Wl,--exclude-libs=libclang_rt.builtins-arm-android.a",
220 "-Wl,--exclude-libs=libclang_rt.builtins-aarch64-android.a",
221 "-Wl,--exclude-libs=libclang_rt.builtins-i686-android.a",
222 "-Wl,--exclude-libs=libclang_rt.builtins-x86_64-android.a",
223 ] + select({
Jingwen Chenb4628eb2021-04-08 14:40:57 +0000224 "//build/bazel/platforms/arch:x86": ["-Wl,--exclude-libs=libgcc_eh.a"],
225 "//build/bazel/platforms/arch:x86_64": ["-Wl,--exclude-libs=libgcc_eh.a"],
Jingwen Chen63930982021-03-24 10:04:33 -0400226 "//conditions:default": [],
Liz Kammer78cfdaa2021-11-08 12:56:31 -0500227 })`,
Chris Parsons77acf2e2021-12-03 17:27:16 -0500228 }),
Lukacs T. Berkic1cc3b92021-05-21 09:37:00 +0200229 })
230}
231
232func TestCcLibraryExcludeSrcs(t *testing.T) {
Sam Delmerico3177a6e2022-06-21 19:28:33 +0000233 runCcLibraryTestCase(t, Bp2buildTestCase{
234 Description: "cc_library exclude_srcs - trimmed example of //external/arm-optimized-routines:libarm-optimized-routines-math",
235 ModuleTypeUnderTest: "cc_library",
236 ModuleTypeUnderTestFactory: cc.LibraryFactory,
237 Dir: "external",
238 Filesystem: map[string]string{
Lukacs T. Berkic1cc3b92021-05-21 09:37:00 +0200239 "external/math/cosf.c": "",
240 "external/math/erf.c": "",
241 "external/math/erf_data.c": "",
242 "external/math/erff.c": "",
243 "external/math/erff_data.c": "",
244 "external/Android.bp": `
Jingwen Chen4ecc67d2021-04-27 09:47:02 +0000245cc_library {
246 name: "fake-libarm-optimized-routines-math",
247 exclude_srcs: [
248 // Provided by:
249 // bionic/libm/upstream-freebsd/lib/msun/src/s_erf.c
250 // bionic/libm/upstream-freebsd/lib/msun/src/s_erff.c
251 "math/erf.c",
252 "math/erf_data.c",
253 "math/erff.c",
254 "math/erff_data.c",
255 ],
256 srcs: [
257 "math/*.c",
258 ],
259 // arch-specific settings
260 arch: {
261 arm64: {
262 cflags: [
263 "-DHAVE_FAST_FMA=1",
264 ],
265 },
266 },
267 bazel_module: { bp2build_available: true },
268}
269`,
Lukacs T. Berkic1cc3b92021-05-21 09:37:00 +0200270 },
Sam Delmerico3177a6e2022-06-21 19:28:33 +0000271 Blueprint: soongCcLibraryPreamble,
272 ExpectedBazelTargets: makeCcLibraryTargets("fake-libarm-optimized-routines-math", AttrNameToString{
Chris Parsons77acf2e2021-12-03 17:27:16 -0500273 "copts": `select({
Jingwen Chen4ecc67d2021-04-27 09:47:02 +0000274 "//build/bazel/platforms/arch:arm64": ["-DHAVE_FAST_FMA=1"],
275 "//conditions:default": [],
Liz Kammer78cfdaa2021-11-08 12:56:31 -0500276 })`,
Chris Parsons77acf2e2021-12-03 17:27:16 -0500277 "local_includes": `["."]`,
278 "srcs_c": `["math/cosf.c"]`,
279 }),
Lukacs T. Berkic1cc3b92021-05-21 09:37:00 +0200280 })
281}
282
283func TestCcLibrarySharedStaticProps(t *testing.T) {
Sam Delmerico3177a6e2022-06-21 19:28:33 +0000284 runCcLibraryTestCase(t, Bp2buildTestCase{
285 Description: "cc_library shared/static props",
286 ModuleTypeUnderTest: "cc_library",
287 ModuleTypeUnderTestFactory: cc.LibraryFactory,
288 Filesystem: map[string]string{
Liz Kammer8337ea42021-09-10 10:06:32 -0400289 "both.cpp": "",
290 "sharedonly.cpp": "",
291 "staticonly.cpp": "",
292 },
Sam Delmerico3177a6e2022-06-21 19:28:33 +0000293 Blueprint: soongCcLibraryPreamble + `
Jingwen Chen53681ef2021-04-29 08:15:13 +0000294cc_library {
295 name: "a",
Chris Parsons08648312021-05-06 16:23:19 -0400296 srcs: ["both.cpp"],
297 cflags: ["bothflag"],
298 shared_libs: ["shared_dep_for_both"],
Liz Kammercc2c1ef2022-03-21 09:03:29 -0400299 static_libs: ["static_dep_for_both", "whole_and_static_lib_for_both"],
300 whole_static_libs: ["whole_static_lib_for_both", "whole_and_static_lib_for_both"],
Chris Parsons08648312021-05-06 16:23:19 -0400301 static: {
302 srcs: ["staticonly.cpp"],
303 cflags: ["staticflag"],
304 shared_libs: ["shared_dep_for_static"],
305 static_libs: ["static_dep_for_static"],
306 whole_static_libs: ["whole_static_lib_for_static"],
307 },
308 shared: {
309 srcs: ["sharedonly.cpp"],
310 cflags: ["sharedflag"],
311 shared_libs: ["shared_dep_for_shared"],
312 static_libs: ["static_dep_for_shared"],
313 whole_static_libs: ["whole_static_lib_for_shared"],
314 },
Liz Kammer8337ea42021-09-10 10:06:32 -0400315 include_build_directory: false,
Jingwen Chen53681ef2021-04-29 08:15:13 +0000316}
317
Liz Kammer8337ea42021-09-10 10:06:32 -0400318cc_library_static {
319 name: "static_dep_for_shared",
320 bazel_module: { bp2build_available: false },
321}
Chris Parsons08648312021-05-06 16:23:19 -0400322
Liz Kammer8337ea42021-09-10 10:06:32 -0400323cc_library_static {
324 name: "static_dep_for_static",
325 bazel_module: { bp2build_available: false },
326}
Chris Parsons08648312021-05-06 16:23:19 -0400327
Liz Kammer8337ea42021-09-10 10:06:32 -0400328cc_library_static {
329 name: "static_dep_for_both",
330 bazel_module: { bp2build_available: false },
331}
Chris Parsons08648312021-05-06 16:23:19 -0400332
Liz Kammer8337ea42021-09-10 10:06:32 -0400333cc_library_static {
334 name: "whole_static_lib_for_shared",
335 bazel_module: { bp2build_available: false },
336}
Chris Parsons08648312021-05-06 16:23:19 -0400337
Liz Kammer8337ea42021-09-10 10:06:32 -0400338cc_library_static {
339 name: "whole_static_lib_for_static",
340 bazel_module: { bp2build_available: false },
341}
Chris Parsons08648312021-05-06 16:23:19 -0400342
Liz Kammer8337ea42021-09-10 10:06:32 -0400343cc_library_static {
344 name: "whole_static_lib_for_both",
345 bazel_module: { bp2build_available: false },
346}
Chris Parsons08648312021-05-06 16:23:19 -0400347
Liz Kammercc2c1ef2022-03-21 09:03:29 -0400348cc_library_static {
349 name: "whole_and_static_lib_for_both",
350 bazel_module: { bp2build_available: false },
351}
352
Liz Kammer8337ea42021-09-10 10:06:32 -0400353cc_library {
354 name: "shared_dep_for_shared",
355 bazel_module: { bp2build_available: false },
356}
Chris Parsons08648312021-05-06 16:23:19 -0400357
Liz Kammer8337ea42021-09-10 10:06:32 -0400358cc_library {
359 name: "shared_dep_for_static",
360 bazel_module: { bp2build_available: false },
361}
Chris Parsons08648312021-05-06 16:23:19 -0400362
Liz Kammer8337ea42021-09-10 10:06:32 -0400363cc_library {
364 name: "shared_dep_for_both",
365 bazel_module: { bp2build_available: false },
366}
Jingwen Chen53681ef2021-04-29 08:15:13 +0000367`,
Sam Delmerico3177a6e2022-06-21 19:28:33 +0000368 ExpectedBazelTargets: []string{
Alixe06d75b2022-08-31 18:28:19 +0000369 MakeBazelTarget("cc_library_static", "a_bp2build_cc_library_static", AttrNameToString{
Chris Parsons77acf2e2021-12-03 17:27:16 -0500370 "copts": `[
371 "bothflag",
372 "staticflag",
373 ]`,
374 "implementation_deps": `[
375 ":static_dep_for_both",
376 ":static_dep_for_static",
377 ]`,
378 "implementation_dynamic_deps": `[
379 ":shared_dep_for_both",
380 ":shared_dep_for_static",
381 ]`,
382 "srcs": `[
383 "both.cpp",
384 "staticonly.cpp",
385 ]`,
386 "whole_archive_deps": `[
387 ":whole_static_lib_for_both",
Liz Kammercc2c1ef2022-03-21 09:03:29 -0400388 ":whole_and_static_lib_for_both",
Chris Parsons77acf2e2021-12-03 17:27:16 -0500389 ":whole_static_lib_for_static",
390 ]`}),
Alixe06d75b2022-08-31 18:28:19 +0000391 MakeBazelTarget("cc_library_shared", "a", AttrNameToString{
Chris Parsons77acf2e2021-12-03 17:27:16 -0500392 "copts": `[
393 "bothflag",
394 "sharedflag",
395 ]`,
396 "implementation_deps": `[
397 ":static_dep_for_both",
398 ":static_dep_for_shared",
399 ]`,
400 "implementation_dynamic_deps": `[
401 ":shared_dep_for_both",
402 ":shared_dep_for_shared",
403 ]`,
404 "srcs": `[
405 "both.cpp",
406 "sharedonly.cpp",
407 ]`,
408 "whole_archive_deps": `[
409 ":whole_static_lib_for_both",
Liz Kammercc2c1ef2022-03-21 09:03:29 -0400410 ":whole_and_static_lib_for_both",
Chris Parsons77acf2e2021-12-03 17:27:16 -0500411 ":whole_static_lib_for_shared",
412 ]`,
Liz Kammer78cfdaa2021-11-08 12:56:31 -0500413 }),
414 },
Lukacs T. Berkic1cc3b92021-05-21 09:37:00 +0200415 })
416}
417
Liz Kammer7a210ac2021-09-22 15:52:58 -0400418func TestCcLibraryDeps(t *testing.T) {
Sam Delmerico3177a6e2022-06-21 19:28:33 +0000419 runCcLibraryTestCase(t, Bp2buildTestCase{
420 Description: "cc_library shared/static props",
421 ModuleTypeUnderTest: "cc_library",
422 ModuleTypeUnderTestFactory: cc.LibraryFactory,
423 Filesystem: map[string]string{
Liz Kammer7a210ac2021-09-22 15:52:58 -0400424 "both.cpp": "",
425 "sharedonly.cpp": "",
426 "staticonly.cpp": "",
427 },
Sam Delmerico3177a6e2022-06-21 19:28:33 +0000428 Blueprint: soongCcLibraryPreamble + `
Liz Kammer7a210ac2021-09-22 15:52:58 -0400429cc_library {
430 name: "a",
431 srcs: ["both.cpp"],
432 cflags: ["bothflag"],
433 shared_libs: ["implementation_shared_dep_for_both", "shared_dep_for_both"],
434 export_shared_lib_headers: ["shared_dep_for_both"],
435 static_libs: ["implementation_static_dep_for_both", "static_dep_for_both"],
436 export_static_lib_headers: ["static_dep_for_both", "whole_static_dep_for_both"],
437 whole_static_libs: ["not_explicitly_exported_whole_static_dep_for_both", "whole_static_dep_for_both"],
438 static: {
439 srcs: ["staticonly.cpp"],
440 cflags: ["staticflag"],
441 shared_libs: ["implementation_shared_dep_for_static", "shared_dep_for_static"],
442 export_shared_lib_headers: ["shared_dep_for_static"],
443 static_libs: ["implementation_static_dep_for_static", "static_dep_for_static"],
444 export_static_lib_headers: ["static_dep_for_static", "whole_static_dep_for_static"],
445 whole_static_libs: ["not_explicitly_exported_whole_static_dep_for_static", "whole_static_dep_for_static"],
446 },
447 shared: {
448 srcs: ["sharedonly.cpp"],
449 cflags: ["sharedflag"],
450 shared_libs: ["implementation_shared_dep_for_shared", "shared_dep_for_shared"],
451 export_shared_lib_headers: ["shared_dep_for_shared"],
452 static_libs: ["implementation_static_dep_for_shared", "static_dep_for_shared"],
453 export_static_lib_headers: ["static_dep_for_shared", "whole_static_dep_for_shared"],
454 whole_static_libs: ["not_explicitly_exported_whole_static_dep_for_shared", "whole_static_dep_for_shared"],
455 },
456 include_build_directory: false,
457}
458` + simpleModuleDoNotConvertBp2build("cc_library_static", "static_dep_for_shared") +
459 simpleModuleDoNotConvertBp2build("cc_library_static", "implementation_static_dep_for_shared") +
460 simpleModuleDoNotConvertBp2build("cc_library_static", "static_dep_for_static") +
461 simpleModuleDoNotConvertBp2build("cc_library_static", "implementation_static_dep_for_static") +
462 simpleModuleDoNotConvertBp2build("cc_library_static", "static_dep_for_both") +
463 simpleModuleDoNotConvertBp2build("cc_library_static", "implementation_static_dep_for_both") +
464 simpleModuleDoNotConvertBp2build("cc_library_static", "whole_static_dep_for_shared") +
465 simpleModuleDoNotConvertBp2build("cc_library_static", "not_explicitly_exported_whole_static_dep_for_shared") +
466 simpleModuleDoNotConvertBp2build("cc_library_static", "whole_static_dep_for_static") +
467 simpleModuleDoNotConvertBp2build("cc_library_static", "not_explicitly_exported_whole_static_dep_for_static") +
468 simpleModuleDoNotConvertBp2build("cc_library_static", "whole_static_dep_for_both") +
469 simpleModuleDoNotConvertBp2build("cc_library_static", "not_explicitly_exported_whole_static_dep_for_both") +
470 simpleModuleDoNotConvertBp2build("cc_library", "shared_dep_for_shared") +
471 simpleModuleDoNotConvertBp2build("cc_library", "implementation_shared_dep_for_shared") +
472 simpleModuleDoNotConvertBp2build("cc_library", "shared_dep_for_static") +
473 simpleModuleDoNotConvertBp2build("cc_library", "implementation_shared_dep_for_static") +
474 simpleModuleDoNotConvertBp2build("cc_library", "shared_dep_for_both") +
475 simpleModuleDoNotConvertBp2build("cc_library", "implementation_shared_dep_for_both"),
Sam Delmerico3177a6e2022-06-21 19:28:33 +0000476 ExpectedBazelTargets: []string{
Alixe06d75b2022-08-31 18:28:19 +0000477 MakeBazelTarget("cc_library_static", "a_bp2build_cc_library_static", AttrNameToString{
Chris Parsons77acf2e2021-12-03 17:27:16 -0500478 "copts": `[
479 "bothflag",
480 "staticflag",
481 ]`,
482 "deps": `[
483 ":static_dep_for_both",
484 ":static_dep_for_static",
485 ]`,
486 "dynamic_deps": `[
487 ":shared_dep_for_both",
488 ":shared_dep_for_static",
489 ]`,
490 "implementation_deps": `[
491 ":implementation_static_dep_for_both",
492 ":implementation_static_dep_for_static",
493 ]`,
494 "implementation_dynamic_deps": `[
495 ":implementation_shared_dep_for_both",
496 ":implementation_shared_dep_for_static",
497 ]`,
498 "srcs": `[
499 "both.cpp",
500 "staticonly.cpp",
501 ]`,
Liz Kammer78cfdaa2021-11-08 12:56:31 -0500502 "whole_archive_deps": `[
Liz Kammer7a210ac2021-09-22 15:52:58 -0400503 ":not_explicitly_exported_whole_static_dep_for_both",
504 ":whole_static_dep_for_both",
Chris Parsons77acf2e2021-12-03 17:27:16 -0500505 ":not_explicitly_exported_whole_static_dep_for_static",
506 ":whole_static_dep_for_static",
Liz Kammer78cfdaa2021-11-08 12:56:31 -0500507 ]`,
508 }),
Alixe06d75b2022-08-31 18:28:19 +0000509 MakeBazelTarget("cc_library_shared", "a", AttrNameToString{
Chris Parsons77acf2e2021-12-03 17:27:16 -0500510 "copts": `[
511 "bothflag",
512 "sharedflag",
513 ]`,
514 "deps": `[
515 ":static_dep_for_both",
516 ":static_dep_for_shared",
517 ]`,
518 "dynamic_deps": `[
519 ":shared_dep_for_both",
520 ":shared_dep_for_shared",
521 ]`,
522 "implementation_deps": `[
523 ":implementation_static_dep_for_both",
524 ":implementation_static_dep_for_shared",
525 ]`,
526 "implementation_dynamic_deps": `[
527 ":implementation_shared_dep_for_both",
528 ":implementation_shared_dep_for_shared",
529 ]`,
530 "srcs": `[
531 "both.cpp",
532 "sharedonly.cpp",
533 ]`,
534 "whole_archive_deps": `[
535 ":not_explicitly_exported_whole_static_dep_for_both",
536 ":whole_static_dep_for_both",
537 ":not_explicitly_exported_whole_static_dep_for_shared",
538 ":whole_static_dep_for_shared",
539 ]`,
540 })},
541 },
542 )
Liz Kammer7a210ac2021-09-22 15:52:58 -0400543}
544
Liz Kammer2d7bbe32021-06-10 18:20:06 -0400545func TestCcLibraryWholeStaticLibsAlwaysLink(t *testing.T) {
Sam Delmerico3177a6e2022-06-21 19:28:33 +0000546 runCcLibraryTestCase(t, Bp2buildTestCase{
547 ModuleTypeUnderTest: "cc_library",
548 ModuleTypeUnderTestFactory: cc.LibraryFactory,
549 Dir: "foo/bar",
550 Filesystem: map[string]string{
Liz Kammer2d7bbe32021-06-10 18:20:06 -0400551 "foo/bar/Android.bp": `
552cc_library {
553 name: "a",
554 whole_static_libs: ["whole_static_lib_for_both"],
555 static: {
556 whole_static_libs: ["whole_static_lib_for_static"],
557 },
558 shared: {
559 whole_static_libs: ["whole_static_lib_for_shared"],
560 },
561 bazel_module: { bp2build_available: true },
Liz Kammer8337ea42021-09-10 10:06:32 -0400562 include_build_directory: false,
Liz Kammer2d7bbe32021-06-10 18:20:06 -0400563}
564
565cc_prebuilt_library_static { name: "whole_static_lib_for_shared" }
566
567cc_prebuilt_library_static { name: "whole_static_lib_for_static" }
568
569cc_prebuilt_library_static { name: "whole_static_lib_for_both" }
570`,
571 },
Sam Delmerico3177a6e2022-06-21 19:28:33 +0000572 Blueprint: soongCcLibraryPreamble,
573 ExpectedBazelTargets: []string{
Alixe06d75b2022-08-31 18:28:19 +0000574 MakeBazelTarget("cc_library_static", "a_bp2build_cc_library_static", AttrNameToString{
Chris Parsons77acf2e2021-12-03 17:27:16 -0500575 "whole_archive_deps": `[
576 ":whole_static_lib_for_both_alwayslink",
577 ":whole_static_lib_for_static_alwayslink",
578 ]`,
579 }),
Alixe06d75b2022-08-31 18:28:19 +0000580 MakeBazelTarget("cc_library_shared", "a", AttrNameToString{
Chris Parsons77acf2e2021-12-03 17:27:16 -0500581 "whole_archive_deps": `[
582 ":whole_static_lib_for_both_alwayslink",
583 ":whole_static_lib_for_shared_alwayslink",
584 ]`,
Liz Kammer78cfdaa2021-11-08 12:56:31 -0500585 }),
586 },
Chris Parsons77acf2e2021-12-03 17:27:16 -0500587 },
588 )
Liz Kammer2d7bbe32021-06-10 18:20:06 -0400589}
590
Jingwen Chenbcf53042021-05-26 04:42:42 +0000591func TestCcLibrarySharedStaticPropsInArch(t *testing.T) {
Sam Delmerico3177a6e2022-06-21 19:28:33 +0000592 runCcLibraryTestCase(t, Bp2buildTestCase{
593 Description: "cc_library shared/static props in arch",
594 ModuleTypeUnderTest: "cc_library",
595 ModuleTypeUnderTestFactory: cc.LibraryFactory,
596 Dir: "foo/bar",
597 Filesystem: map[string]string{
Jingwen Chenbcf53042021-05-26 04:42:42 +0000598 "foo/bar/arm.cpp": "",
599 "foo/bar/x86.cpp": "",
600 "foo/bar/sharedonly.cpp": "",
601 "foo/bar/staticonly.cpp": "",
602 "foo/bar/Android.bp": `
603cc_library {
604 name: "a",
605 arch: {
606 arm: {
607 shared: {
608 srcs: ["arm_shared.cpp"],
609 cflags: ["-DARM_SHARED"],
610 static_libs: ["arm_static_dep_for_shared"],
611 whole_static_libs: ["arm_whole_static_dep_for_shared"],
612 shared_libs: ["arm_shared_dep_for_shared"],
613 },
614 },
615 x86: {
616 static: {
617 srcs: ["x86_static.cpp"],
618 cflags: ["-DX86_STATIC"],
619 static_libs: ["x86_dep_for_static"],
620 },
621 },
622 },
623 target: {
624 android: {
625 shared: {
626 srcs: ["android_shared.cpp"],
627 cflags: ["-DANDROID_SHARED"],
628 static_libs: ["android_dep_for_shared"],
629 },
630 },
631 android_arm: {
632 shared: {
633 cflags: ["-DANDROID_ARM_SHARED"],
634 },
635 },
636 },
637 srcs: ["both.cpp"],
638 cflags: ["bothflag"],
639 static_libs: ["static_dep_for_both"],
640 static: {
641 srcs: ["staticonly.cpp"],
642 cflags: ["staticflag"],
643 static_libs: ["static_dep_for_static"],
644 },
645 shared: {
646 srcs: ["sharedonly.cpp"],
647 cflags: ["sharedflag"],
648 static_libs: ["static_dep_for_shared"],
649 },
650 bazel_module: { bp2build_available: true },
651}
652
653cc_library_static { name: "static_dep_for_shared" }
654cc_library_static { name: "static_dep_for_static" }
655cc_library_static { name: "static_dep_for_both" }
656
657cc_library_static { name: "arm_static_dep_for_shared" }
658cc_library_static { name: "arm_whole_static_dep_for_shared" }
659cc_library_static { name: "arm_shared_dep_for_shared" }
660
661cc_library_static { name: "x86_dep_for_static" }
662
663cc_library_static { name: "android_dep_for_shared" }
664`,
665 },
Sam Delmerico3177a6e2022-06-21 19:28:33 +0000666 Blueprint: soongCcLibraryPreamble,
667 ExpectedBazelTargets: []string{
Alixe06d75b2022-08-31 18:28:19 +0000668 MakeBazelTarget("cc_library_static", "a_bp2build_cc_library_static", AttrNameToString{
Chris Parsons77acf2e2021-12-03 17:27:16 -0500669 "copts": `[
670 "bothflag",
671 "staticflag",
672 ] + select({
673 "//build/bazel/platforms/arch:x86": ["-DX86_STATIC"],
674 "//conditions:default": [],
675 })`,
676 "implementation_deps": `[
677 ":static_dep_for_both",
678 ":static_dep_for_static",
679 ] + select({
680 "//build/bazel/platforms/arch:x86": [":x86_dep_for_static"],
681 "//conditions:default": [],
682 })`,
683 "local_includes": `["."]`,
684 "srcs": `[
685 "both.cpp",
686 "staticonly.cpp",
687 ] + select({
688 "//build/bazel/platforms/arch:x86": ["x86_static.cpp"],
689 "//conditions:default": [],
690 })`,
691 }),
Alixe06d75b2022-08-31 18:28:19 +0000692 MakeBazelTarget("cc_library_shared", "a", AttrNameToString{
Chris Parsons77acf2e2021-12-03 17:27:16 -0500693 "copts": `[
694 "bothflag",
695 "sharedflag",
696 ] + select({
697 "//build/bazel/platforms/arch:arm": ["-DARM_SHARED"],
698 "//conditions:default": [],
699 }) + select({
700 "//build/bazel/platforms/os:android": ["-DANDROID_SHARED"],
701 "//conditions:default": [],
702 }) + select({
703 "//build/bazel/platforms/os_arch:android_arm": ["-DANDROID_ARM_SHARED"],
704 "//conditions:default": [],
705 })`,
706 "implementation_deps": `[
707 ":static_dep_for_both",
708 ":static_dep_for_shared",
709 ] + select({
710 "//build/bazel/platforms/arch:arm": [":arm_static_dep_for_shared"],
711 "//conditions:default": [],
712 }) + select({
713 "//build/bazel/platforms/os:android": [":android_dep_for_shared"],
714 "//conditions:default": [],
715 })`,
716 "implementation_dynamic_deps": `select({
717 "//build/bazel/platforms/arch:arm": [":arm_shared_dep_for_shared"],
718 "//conditions:default": [],
719 })`,
720 "local_includes": `["."]`,
721 "srcs": `[
722 "both.cpp",
723 "sharedonly.cpp",
724 ] + select({
725 "//build/bazel/platforms/arch:arm": ["arm_shared.cpp"],
726 "//conditions:default": [],
727 }) + select({
728 "//build/bazel/platforms/os:android": ["android_shared.cpp"],
729 "//conditions:default": [],
730 })`,
731 "whole_archive_deps": `select({
732 "//build/bazel/platforms/arch:arm": [":arm_whole_static_dep_for_shared"],
733 "//conditions:default": [],
734 })`,
Liz Kammer78cfdaa2021-11-08 12:56:31 -0500735 }),
736 },
Chris Parsons77acf2e2021-12-03 17:27:16 -0500737 },
738 )
Jingwen Chenbcf53042021-05-26 04:42:42 +0000739}
740
Jingwen Chen14a8bda2021-06-02 11:10:02 +0000741func TestCcLibrarySharedStaticPropsWithMixedSources(t *testing.T) {
Sam Delmerico3177a6e2022-06-21 19:28:33 +0000742 runCcLibraryTestCase(t, Bp2buildTestCase{
743 Description: "cc_library shared/static props with c/cpp/s mixed sources",
744 ModuleTypeUnderTest: "cc_library",
745 ModuleTypeUnderTestFactory: cc.LibraryFactory,
746 Dir: "foo/bar",
747 Filesystem: map[string]string{
Jingwen Chen14a8bda2021-06-02 11:10:02 +0000748 "foo/bar/both_source.cpp": "",
749 "foo/bar/both_source.cc": "",
750 "foo/bar/both_source.c": "",
751 "foo/bar/both_source.s": "",
752 "foo/bar/both_source.S": "",
753 "foo/bar/shared_source.cpp": "",
754 "foo/bar/shared_source.cc": "",
755 "foo/bar/shared_source.c": "",
756 "foo/bar/shared_source.s": "",
757 "foo/bar/shared_source.S": "",
758 "foo/bar/static_source.cpp": "",
759 "foo/bar/static_source.cc": "",
760 "foo/bar/static_source.c": "",
761 "foo/bar/static_source.s": "",
762 "foo/bar/static_source.S": "",
763 "foo/bar/Android.bp": `
764cc_library {
765 name: "a",
766 srcs: [
Liz Kammerd366c902021-06-03 13:43:01 -0400767 "both_source.cpp",
768 "both_source.cc",
769 "both_source.c",
770 "both_source.s",
771 "both_source.S",
Liz Kammer57e2e7a2021-09-20 12:55:02 -0400772 ":both_filegroup",
Liz Kammerd366c902021-06-03 13:43:01 -0400773 ],
Jingwen Chen14a8bda2021-06-02 11:10:02 +0000774 static: {
Liz Kammer8337ea42021-09-10 10:06:32 -0400775 srcs: [
776 "static_source.cpp",
777 "static_source.cc",
778 "static_source.c",
779 "static_source.s",
780 "static_source.S",
781 ":static_filegroup",
782 ],
Jingwen Chen14a8bda2021-06-02 11:10:02 +0000783 },
784 shared: {
Liz Kammer8337ea42021-09-10 10:06:32 -0400785 srcs: [
786 "shared_source.cpp",
787 "shared_source.cc",
788 "shared_source.c",
789 "shared_source.s",
790 "shared_source.S",
791 ":shared_filegroup",
792 ],
Jingwen Chen14a8bda2021-06-02 11:10:02 +0000793 },
794 bazel_module: { bp2build_available: true },
795}
796
797filegroup {
798 name: "both_filegroup",
799 srcs: [
800 // Not relevant, handled by filegroup macro
Liz Kammerd366c902021-06-03 13:43:01 -0400801 ],
Jingwen Chen14a8bda2021-06-02 11:10:02 +0000802}
803
804filegroup {
805 name: "shared_filegroup",
806 srcs: [
807 // Not relevant, handled by filegroup macro
Liz Kammerd366c902021-06-03 13:43:01 -0400808 ],
Jingwen Chen14a8bda2021-06-02 11:10:02 +0000809}
810
811filegroup {
812 name: "static_filegroup",
813 srcs: [
814 // Not relevant, handled by filegroup macro
Liz Kammerd366c902021-06-03 13:43:01 -0400815 ],
Jingwen Chen14a8bda2021-06-02 11:10:02 +0000816}
817`,
818 },
Sam Delmerico3177a6e2022-06-21 19:28:33 +0000819 Blueprint: soongCcLibraryPreamble,
820 ExpectedBazelTargets: []string{
Alixe06d75b2022-08-31 18:28:19 +0000821 MakeBazelTarget("cc_library_static", "a_bp2build_cc_library_static", AttrNameToString{
Liz Kammer78cfdaa2021-11-08 12:56:31 -0500822 "local_includes": `["."]`,
Liz Kammer78cfdaa2021-11-08 12:56:31 -0500823 "srcs": `[
Jingwen Chen14a8bda2021-06-02 11:10:02 +0000824 "both_source.cpp",
Liz Kammer57e2e7a2021-09-20 12:55:02 -0400825 "both_source.cc",
826 ":both_filegroup_cpp_srcs",
Chris Parsons77acf2e2021-12-03 17:27:16 -0500827 "static_source.cpp",
828 "static_source.cc",
829 ":static_filegroup_cpp_srcs",
Liz Kammer78cfdaa2021-11-08 12:56:31 -0500830 ]`,
831 "srcs_as": `[
Jingwen Chen14a8bda2021-06-02 11:10:02 +0000832 "both_source.s",
833 "both_source.S",
834 ":both_filegroup_as_srcs",
Chris Parsons77acf2e2021-12-03 17:27:16 -0500835 "static_source.s",
836 "static_source.S",
837 ":static_filegroup_as_srcs",
Liz Kammer78cfdaa2021-11-08 12:56:31 -0500838 ]`,
839 "srcs_c": `[
Jingwen Chen14a8bda2021-06-02 11:10:02 +0000840 "both_source.c",
841 ":both_filegroup_c_srcs",
Chris Parsons77acf2e2021-12-03 17:27:16 -0500842 "static_source.c",
843 ":static_filegroup_c_srcs",
Liz Kammer78cfdaa2021-11-08 12:56:31 -0500844 ]`,
Liz Kammer78cfdaa2021-11-08 12:56:31 -0500845 }),
Alixe06d75b2022-08-31 18:28:19 +0000846 MakeBazelTarget("cc_library_shared", "a", AttrNameToString{
Chris Parsons77acf2e2021-12-03 17:27:16 -0500847 "local_includes": `["."]`,
848 "srcs": `[
849 "both_source.cpp",
850 "both_source.cc",
851 ":both_filegroup_cpp_srcs",
852 "shared_source.cpp",
853 "shared_source.cc",
854 ":shared_filegroup_cpp_srcs",
855 ]`,
856 "srcs_as": `[
857 "both_source.s",
858 "both_source.S",
859 ":both_filegroup_as_srcs",
860 "shared_source.s",
861 "shared_source.S",
862 ":shared_filegroup_as_srcs",
863 ]`,
864 "srcs_c": `[
865 "both_source.c",
866 ":both_filegroup_c_srcs",
867 "shared_source.c",
868 ":shared_filegroup_c_srcs",
869 ]`,
870 })}})
Jingwen Chen14a8bda2021-06-02 11:10:02 +0000871}
872
Lukacs T. Berkic1cc3b92021-05-21 09:37:00 +0200873func TestCcLibraryNonConfiguredVersionScript(t *testing.T) {
Sam Delmerico3177a6e2022-06-21 19:28:33 +0000874 runCcLibraryTestCase(t, Bp2buildTestCase{
875 Description: "cc_library non-configured version script",
876 ModuleTypeUnderTest: "cc_library",
877 ModuleTypeUnderTestFactory: cc.LibraryFactory,
878 Dir: "foo/bar",
879 Filesystem: map[string]string{
Lukacs T. Berkic1cc3b92021-05-21 09:37:00 +0200880 "foo/bar/Android.bp": `
Lukacs T. Berki1353e592021-04-30 15:35:09 +0200881cc_library {
882 name: "a",
883 srcs: ["a.cpp"],
884 version_script: "v.map",
885 bazel_module: { bp2build_available: true },
Liz Kammer8337ea42021-09-10 10:06:32 -0400886 include_build_directory: false,
Lukacs T. Berki1353e592021-04-30 15:35:09 +0200887}
888`,
Lukacs T. Berkic1cc3b92021-05-21 09:37:00 +0200889 },
Sam Delmerico3177a6e2022-06-21 19:28:33 +0000890 Blueprint: soongCcLibraryPreamble,
891 ExpectedBazelTargets: makeCcLibraryTargets("a", AttrNameToString{
Chris Parsons77acf2e2021-12-03 17:27:16 -0500892 "additional_linker_inputs": `["v.map"]`,
893 "linkopts": `["-Wl,--version-script,$(location v.map)"]`,
894 "srcs": `["a.cpp"]`,
895 }),
896 },
897 )
Lukacs T. Berkic1cc3b92021-05-21 09:37:00 +0200898}
899
900func TestCcLibraryConfiguredVersionScript(t *testing.T) {
Sam Delmerico3177a6e2022-06-21 19:28:33 +0000901 runCcLibraryTestCase(t, Bp2buildTestCase{
902 Description: "cc_library configured version script",
903 ModuleTypeUnderTest: "cc_library",
904 ModuleTypeUnderTestFactory: cc.LibraryFactory,
905 Dir: "foo/bar",
906 Filesystem: map[string]string{
Lukacs T. Berkic1cc3b92021-05-21 09:37:00 +0200907 "foo/bar/Android.bp": `
Liz Kammer8337ea42021-09-10 10:06:32 -0400908cc_library {
909 name: "a",
910 srcs: ["a.cpp"],
911 arch: {
912 arm: {
913 version_script: "arm.map",
914 },
915 arm64: {
916 version_script: "arm64.map",
917 },
918 },
Lukacs T. Berki56bb0832021-05-12 12:36:45 +0200919
Liz Kammer8337ea42021-09-10 10:06:32 -0400920 bazel_module: { bp2build_available: true },
921 include_build_directory: false,
922}
Liz Kammerd366c902021-06-03 13:43:01 -0400923 `,
Lukacs T. Berkic1cc3b92021-05-21 09:37:00 +0200924 },
Sam Delmerico3177a6e2022-06-21 19:28:33 +0000925 Blueprint: soongCcLibraryPreamble,
926 ExpectedBazelTargets: makeCcLibraryTargets("a", AttrNameToString{
Chris Parsons77acf2e2021-12-03 17:27:16 -0500927 "additional_linker_inputs": `select({
Liz Kammerd2871182021-10-04 13:54:37 -0400928 "//build/bazel/platforms/arch:arm": ["arm.map"],
929 "//build/bazel/platforms/arch:arm64": ["arm64.map"],
930 "//conditions:default": [],
Liz Kammer78cfdaa2021-11-08 12:56:31 -0500931 })`,
Chris Parsons77acf2e2021-12-03 17:27:16 -0500932 "linkopts": `select({
Liz Kammerd2871182021-10-04 13:54:37 -0400933 "//build/bazel/platforms/arch:arm": ["-Wl,--version-script,$(location arm.map)"],
934 "//build/bazel/platforms/arch:arm64": ["-Wl,--version-script,$(location arm64.map)"],
935 "//conditions:default": [],
Liz Kammer78cfdaa2021-11-08 12:56:31 -0500936 })`,
Chris Parsons77acf2e2021-12-03 17:27:16 -0500937 "srcs": `["a.cpp"]`,
938 }),
939 },
940 )
Lukacs T. Berkic1cc3b92021-05-21 09:37:00 +0200941}
942
943func TestCcLibrarySharedLibs(t *testing.T) {
Sam Delmerico3177a6e2022-06-21 19:28:33 +0000944 runCcLibraryTestCase(t, Bp2buildTestCase{
945 Description: "cc_library shared_libs",
946 ModuleTypeUnderTest: "cc_library",
947 ModuleTypeUnderTestFactory: cc.LibraryFactory,
948 Blueprint: soongCcLibraryPreamble + `
Rupert Shuttleworthc50fa8d2021-05-06 02:40:33 -0400949cc_library {
950 name: "mylib",
Liz Kammer8337ea42021-09-10 10:06:32 -0400951 bazel_module: { bp2build_available: false },
Rupert Shuttleworthc50fa8d2021-05-06 02:40:33 -0400952}
953
954cc_library {
955 name: "a",
956 shared_libs: ["mylib",],
Liz Kammer8337ea42021-09-10 10:06:32 -0400957 include_build_directory: false,
Rupert Shuttleworthc50fa8d2021-05-06 02:40:33 -0400958}
959`,
Sam Delmerico3177a6e2022-06-21 19:28:33 +0000960 ExpectedBazelTargets: makeCcLibraryTargets("a", AttrNameToString{
Chris Parsons77acf2e2021-12-03 17:27:16 -0500961 "implementation_dynamic_deps": `[":mylib"]`,
962 }),
963 },
964 )
Lukacs T. Berkic1cc3b92021-05-21 09:37:00 +0200965}
966
Liz Kammer0eae52e2021-10-06 10:32:26 -0400967func TestCcLibraryFeatures(t *testing.T) {
Chris Parsons77acf2e2021-12-03 17:27:16 -0500968 expected_targets := []string{}
Sam Delmerico3177a6e2022-06-21 19:28:33 +0000969 expected_targets = append(expected_targets, makeCcLibraryTargets("a", AttrNameToString{
Chris Parsons77acf2e2021-12-03 17:27:16 -0500970 "features": `[
971 "disable_pack_relocations",
972 "-no_undefined_symbols",
Yu Liu8d82ac52022-05-17 15:13:28 -0700973 "-coverage",
Chris Parsons77acf2e2021-12-03 17:27:16 -0500974 ]`,
975 "srcs": `["a.cpp"]`,
976 })...)
Sam Delmerico3177a6e2022-06-21 19:28:33 +0000977 expected_targets = append(expected_targets, makeCcLibraryTargets("b", AttrNameToString{
Yu Liu8d82ac52022-05-17 15:13:28 -0700978 "features": `["-coverage"] + select({
Chris Parsons77acf2e2021-12-03 17:27:16 -0500979 "//build/bazel/platforms/arch:x86_64": [
980 "disable_pack_relocations",
981 "-no_undefined_symbols",
982 ],
983 "//conditions:default": [],
984 })`,
985 "srcs": `["b.cpp"]`,
986 })...)
Sam Delmerico3177a6e2022-06-21 19:28:33 +0000987 expected_targets = append(expected_targets, makeCcLibraryTargets("c", AttrNameToString{
Chris Parsons77acf2e2021-12-03 17:27:16 -0500988 "features": `select({
989 "//build/bazel/platforms/os:darwin": [
990 "disable_pack_relocations",
991 "-no_undefined_symbols",
992 ],
993 "//conditions:default": [],
994 })`,
995 "srcs": `["c.cpp"]`,
996 })...)
997
Sam Delmerico3177a6e2022-06-21 19:28:33 +0000998 runCcLibraryTestCase(t, Bp2buildTestCase{
999 Description: "cc_library pack_relocations test",
1000 ModuleTypeUnderTest: "cc_library",
1001 ModuleTypeUnderTestFactory: cc.LibraryFactory,
1002 Blueprint: soongCcLibraryPreamble + `
Rupert Shuttleworth143be942021-05-09 23:55:51 -04001003cc_library {
1004 name: "a",
1005 srcs: ["a.cpp"],
1006 pack_relocations: false,
Liz Kammer0eae52e2021-10-06 10:32:26 -04001007 allow_undefined_symbols: true,
Liz Kammer8337ea42021-09-10 10:06:32 -04001008 include_build_directory: false,
Yu Liu8d82ac52022-05-17 15:13:28 -07001009 native_coverage: false,
Rupert Shuttleworth143be942021-05-09 23:55:51 -04001010}
1011
1012cc_library {
1013 name: "b",
1014 srcs: ["b.cpp"],
1015 arch: {
1016 x86_64: {
Liz Kammer8337ea42021-09-10 10:06:32 -04001017 pack_relocations: false,
Liz Kammer0eae52e2021-10-06 10:32:26 -04001018 allow_undefined_symbols: true,
Liz Kammer8337ea42021-09-10 10:06:32 -04001019 },
Rupert Shuttleworth143be942021-05-09 23:55:51 -04001020 },
Liz Kammer8337ea42021-09-10 10:06:32 -04001021 include_build_directory: false,
Yu Liu8d82ac52022-05-17 15:13:28 -07001022 native_coverage: false,
Rupert Shuttleworth143be942021-05-09 23:55:51 -04001023}
1024
1025cc_library {
1026 name: "c",
1027 srcs: ["c.cpp"],
1028 target: {
1029 darwin: {
Liz Kammer8337ea42021-09-10 10:06:32 -04001030 pack_relocations: false,
Liz Kammer0eae52e2021-10-06 10:32:26 -04001031 allow_undefined_symbols: true,
Liz Kammer8337ea42021-09-10 10:06:32 -04001032 },
Rupert Shuttleworth143be942021-05-09 23:55:51 -04001033 },
Liz Kammer8337ea42021-09-10 10:06:32 -04001034 include_build_directory: false,
Rupert Shuttleworth143be942021-05-09 23:55:51 -04001035}`,
Sam Delmerico3177a6e2022-06-21 19:28:33 +00001036 ExpectedBazelTargets: expected_targets,
Lukacs T. Berkic1cc3b92021-05-21 09:37:00 +02001037 })
1038}
1039
1040func TestCcLibrarySpacesInCopts(t *testing.T) {
Sam Delmerico3177a6e2022-06-21 19:28:33 +00001041 runCcLibraryTestCase(t, Bp2buildTestCase{
1042 Description: "cc_library spaces in copts",
1043 ModuleTypeUnderTest: "cc_library",
1044 ModuleTypeUnderTestFactory: cc.LibraryFactory,
1045 Blueprint: soongCcLibraryPreamble + `
Jingwen Chen3950cd62021-05-12 04:33:00 +00001046cc_library {
1047 name: "a",
1048 cflags: ["-include header.h",],
Liz Kammer8337ea42021-09-10 10:06:32 -04001049 include_build_directory: false,
Jingwen Chen3950cd62021-05-12 04:33:00 +00001050}
1051`,
Sam Delmerico3177a6e2022-06-21 19:28:33 +00001052 ExpectedBazelTargets: makeCcLibraryTargets("a", AttrNameToString{
Chris Parsons77acf2e2021-12-03 17:27:16 -05001053 "copts": `[
Jingwen Chen3950cd62021-05-12 04:33:00 +00001054 "-include",
1055 "header.h",
Liz Kammer78cfdaa2021-11-08 12:56:31 -05001056 ]`,
Chris Parsons77acf2e2021-12-03 17:27:16 -05001057 }),
1058 },
1059 )
Lukacs T. Berkic1cc3b92021-05-21 09:37:00 +02001060}
1061
1062func TestCcLibraryCppFlagsGoesIntoCopts(t *testing.T) {
Sam Delmerico3177a6e2022-06-21 19:28:33 +00001063 runCcLibraryTestCase(t, Bp2buildTestCase{
1064 Description: "cc_library cppflags usage",
1065 ModuleTypeUnderTest: "cc_library",
1066 ModuleTypeUnderTestFactory: cc.LibraryFactory,
1067 Blueprint: soongCcLibraryPreamble + `cc_library {
Jingwen Chen75be1ca2021-05-12 05:04:58 +00001068 name: "a",
1069 srcs: ["a.cpp"],
Liz Kammer8337ea42021-09-10 10:06:32 -04001070 cflags: ["-Wall"],
Jingwen Chen75be1ca2021-05-12 05:04:58 +00001071 cppflags: [
1072 "-fsigned-char",
1073 "-pedantic",
Liz Kammer8337ea42021-09-10 10:06:32 -04001074 ],
Jingwen Chen75be1ca2021-05-12 05:04:58 +00001075 arch: {
1076 arm64: {
1077 cppflags: ["-DARM64=1"],
Liz Kammer8337ea42021-09-10 10:06:32 -04001078 },
Liz Kammerd366c902021-06-03 13:43:01 -04001079 },
Jingwen Chen75be1ca2021-05-12 05:04:58 +00001080 target: {
1081 android: {
1082 cppflags: ["-DANDROID=1"],
Liz Kammer8337ea42021-09-10 10:06:32 -04001083 },
Liz Kammerd366c902021-06-03 13:43:01 -04001084 },
Liz Kammer8337ea42021-09-10 10:06:32 -04001085 include_build_directory: false,
Jingwen Chen75be1ca2021-05-12 05:04:58 +00001086}
1087`,
Sam Delmerico3177a6e2022-06-21 19:28:33 +00001088 ExpectedBazelTargets: makeCcLibraryTargets("a", AttrNameToString{
Chris Parsons77acf2e2021-12-03 17:27:16 -05001089 "copts": `["-Wall"]`,
1090 "cppflags": `[
Chris Parsons990c4f42021-05-25 12:10:58 -04001091 "-fsigned-char",
1092 "-pedantic",
Jingwen Chen75be1ca2021-05-12 05:04:58 +00001093 ] + select({
1094 "//build/bazel/platforms/arch:arm64": ["-DARM64=1"],
1095 "//conditions:default": [],
1096 }) + select({
1097 "//build/bazel/platforms/os:android": ["-DANDROID=1"],
1098 "//conditions:default": [],
Liz Kammer78cfdaa2021-11-08 12:56:31 -05001099 })`,
Chris Parsons77acf2e2021-12-03 17:27:16 -05001100 "srcs": `["a.cpp"]`,
1101 }),
1102 },
1103 )
Jingwen Chen63930982021-03-24 10:04:33 -04001104}
Rupert Shuttleworth22cd2eb2021-05-27 02:15:54 -04001105
Liz Kammer47535c52021-06-02 16:02:22 -04001106func TestCcLibraryExcludeLibs(t *testing.T) {
Sam Delmerico3177a6e2022-06-21 19:28:33 +00001107 runCcLibraryTestCase(t, Bp2buildTestCase{
1108 ModuleTypeUnderTest: "cc_library",
1109 ModuleTypeUnderTestFactory: cc.LibraryFactory,
1110 Filesystem: map[string]string{},
1111 Blueprint: soongCcLibraryStaticPreamble + `
Liz Kammer47535c52021-06-02 16:02:22 -04001112cc_library {
1113 name: "foo_static",
1114 srcs: ["common.c"],
1115 whole_static_libs: [
1116 "arm_whole_static_lib_excludes",
1117 "malloc_not_svelte_whole_static_lib_excludes"
1118 ],
1119 static_libs: [
1120 "arm_static_lib_excludes",
1121 "malloc_not_svelte_static_lib_excludes"
1122 ],
1123 shared_libs: [
1124 "arm_shared_lib_excludes",
1125 ],
1126 arch: {
1127 arm: {
1128 exclude_shared_libs: [
1129 "arm_shared_lib_excludes",
1130 ],
1131 exclude_static_libs: [
1132 "arm_static_lib_excludes",
1133 "arm_whole_static_lib_excludes",
1134 ],
1135 },
1136 },
1137 product_variables: {
1138 malloc_not_svelte: {
1139 shared_libs: ["malloc_not_svelte_shared_lib"],
1140 whole_static_libs: ["malloc_not_svelte_whole_static_lib"],
1141 exclude_static_libs: [
1142 "malloc_not_svelte_static_lib_excludes",
1143 "malloc_not_svelte_whole_static_lib_excludes",
1144 ],
1145 },
1146 },
Liz Kammer8337ea42021-09-10 10:06:32 -04001147 include_build_directory: false,
Liz Kammer47535c52021-06-02 16:02:22 -04001148}
1149
1150cc_library {
1151 name: "arm_whole_static_lib_excludes",
1152 bazel_module: { bp2build_available: false },
1153}
1154
1155cc_library {
1156 name: "malloc_not_svelte_whole_static_lib",
1157 bazel_module: { bp2build_available: false },
1158}
1159
1160cc_library {
1161 name: "malloc_not_svelte_whole_static_lib_excludes",
1162 bazel_module: { bp2build_available: false },
1163}
1164
1165cc_library {
1166 name: "arm_static_lib_excludes",
1167 bazel_module: { bp2build_available: false },
1168}
1169
1170cc_library {
1171 name: "malloc_not_svelte_static_lib_excludes",
1172 bazel_module: { bp2build_available: false },
1173}
1174
1175cc_library {
1176 name: "arm_shared_lib_excludes",
1177 bazel_module: { bp2build_available: false },
1178}
1179
1180cc_library {
1181 name: "malloc_not_svelte_shared_lib",
1182 bazel_module: { bp2build_available: false },
1183}
1184`,
Sam Delmerico3177a6e2022-06-21 19:28:33 +00001185 ExpectedBazelTargets: makeCcLibraryTargets("foo_static", AttrNameToString{
Chris Parsons77acf2e2021-12-03 17:27:16 -05001186 "implementation_deps": `select({
Liz Kammer47535c52021-06-02 16:02:22 -04001187 "//build/bazel/platforms/arch:arm": [],
Chris Parsons953b3562021-09-20 15:14:39 -04001188 "//conditions:default": [":arm_static_lib_excludes_bp2build_cc_library_static"],
Liz Kammer47535c52021-06-02 16:02:22 -04001189 }) + select({
1190 "//build/bazel/product_variables:malloc_not_svelte": [],
Chris Parsons953b3562021-09-20 15:14:39 -04001191 "//conditions:default": [":malloc_not_svelte_static_lib_excludes_bp2build_cc_library_static"],
Liz Kammer78cfdaa2021-11-08 12:56:31 -05001192 })`,
Chris Parsons77acf2e2021-12-03 17:27:16 -05001193 "implementation_dynamic_deps": `select({
Liz Kammer7a210ac2021-09-22 15:52:58 -04001194 "//build/bazel/platforms/arch:arm": [],
1195 "//conditions:default": [":arm_shared_lib_excludes"],
1196 }) + select({
1197 "//build/bazel/product_variables:malloc_not_svelte": [":malloc_not_svelte_shared_lib"],
1198 "//conditions:default": [],
Liz Kammer78cfdaa2021-11-08 12:56:31 -05001199 })`,
Chris Parsons77acf2e2021-12-03 17:27:16 -05001200 "srcs_c": `["common.c"]`,
1201 "whole_archive_deps": `select({
Liz Kammer47535c52021-06-02 16:02:22 -04001202 "//build/bazel/platforms/arch:arm": [],
Chris Parsons953b3562021-09-20 15:14:39 -04001203 "//conditions:default": [":arm_whole_static_lib_excludes_bp2build_cc_library_static"],
Liz Kammer47535c52021-06-02 16:02:22 -04001204 }) + select({
Chris Parsons953b3562021-09-20 15:14:39 -04001205 "//build/bazel/product_variables:malloc_not_svelte": [":malloc_not_svelte_whole_static_lib_bp2build_cc_library_static"],
1206 "//conditions:default": [":malloc_not_svelte_whole_static_lib_excludes_bp2build_cc_library_static"],
Liz Kammer78cfdaa2021-11-08 12:56:31 -05001207 })`,
Chris Parsons77acf2e2021-12-03 17:27:16 -05001208 }),
1209 },
1210 )
Liz Kammer47535c52021-06-02 16:02:22 -04001211}
Liz Kammerd366c902021-06-03 13:43:01 -04001212
Zi Wang0a8a1292022-08-30 06:27:01 +00001213func TestCcLibraryProductVariablesHeaderLibs(t *testing.T) {
1214 runCcLibraryTestCase(t, Bp2buildTestCase{
1215 ModuleTypeUnderTest: "cc_library",
1216 ModuleTypeUnderTestFactory: cc.LibraryFactory,
1217 Filesystem: map[string]string{},
1218 Blueprint: soongCcLibraryStaticPreamble + `
1219cc_library {
1220 name: "foo_static",
1221 srcs: ["common.c"],
1222 product_variables: {
1223 malloc_not_svelte: {
1224 header_libs: ["malloc_not_svelte_header_lib"],
1225 },
1226 },
1227 include_build_directory: false,
1228}
1229
1230cc_library {
1231 name: "malloc_not_svelte_header_lib",
1232 bazel_module: { bp2build_available: false },
1233}
1234`,
1235 ExpectedBazelTargets: makeCcLibraryTargets("foo_static", AttrNameToString{
1236 "implementation_deps": `select({
1237 "//build/bazel/product_variables:malloc_not_svelte": [":malloc_not_svelte_header_lib"],
1238 "//conditions:default": [],
1239 })`,
1240 "srcs_c": `["common.c"]`,
1241 "target_compatible_with": `["//build/bazel/platforms/os:android"]`,
1242 }),
1243 },
1244 )
1245}
1246
Liz Kammerd366c902021-06-03 13:43:01 -04001247func TestCCLibraryNoCrtTrue(t *testing.T) {
Sam Delmerico3177a6e2022-06-21 19:28:33 +00001248 runCcLibraryTestCase(t, Bp2buildTestCase{
1249 Description: "cc_library - nocrt: true emits attribute",
1250 ModuleTypeUnderTest: "cc_library",
1251 ModuleTypeUnderTestFactory: cc.LibraryFactory,
1252 Filesystem: map[string]string{
Jingwen Chen6ada5892021-09-17 11:38:09 +00001253 "impl.cpp": "",
1254 },
Sam Delmerico3177a6e2022-06-21 19:28:33 +00001255 Blueprint: soongCcLibraryPreamble + `
Jingwen Chen6ada5892021-09-17 11:38:09 +00001256cc_library {
1257 name: "foo-lib",
1258 srcs: ["impl.cpp"],
1259 nocrt: true,
1260 include_build_directory: false,
1261}
1262`,
Sam Delmerico3177a6e2022-06-21 19:28:33 +00001263 ExpectedBazelTargets: makeCcLibraryTargets("foo-lib", AttrNameToString{
Chris Parsons77acf2e2021-12-03 17:27:16 -05001264 "link_crt": `False`,
1265 "srcs": `["impl.cpp"]`,
1266 }),
1267 },
1268 )
Jingwen Chen6ada5892021-09-17 11:38:09 +00001269}
1270
1271func TestCCLibraryNoCrtFalse(t *testing.T) {
Sam Delmerico3177a6e2022-06-21 19:28:33 +00001272 runCcLibraryTestCase(t, Bp2buildTestCase{
1273 Description: "cc_library - nocrt: false - does not emit attribute",
1274 ModuleTypeUnderTest: "cc_library",
1275 ModuleTypeUnderTestFactory: cc.LibraryFactory,
1276 Filesystem: map[string]string{
Jingwen Chen6ada5892021-09-17 11:38:09 +00001277 "impl.cpp": "",
1278 },
Sam Delmerico3177a6e2022-06-21 19:28:33 +00001279 Blueprint: soongCcLibraryPreamble + `
Jingwen Chen6ada5892021-09-17 11:38:09 +00001280cc_library {
1281 name: "foo-lib",
1282 srcs: ["impl.cpp"],
1283 nocrt: false,
1284 include_build_directory: false,
1285}
1286`,
Sam Delmerico3177a6e2022-06-21 19:28:33 +00001287 ExpectedBazelTargets: makeCcLibraryTargets("foo-lib", AttrNameToString{
Chris Parsons77acf2e2021-12-03 17:27:16 -05001288 "srcs": `["impl.cpp"]`,
1289 }),
Liz Kammer78cfdaa2021-11-08 12:56:31 -05001290 })
Jingwen Chen6ada5892021-09-17 11:38:09 +00001291}
1292
1293func TestCCLibraryNoCrtArchVariant(t *testing.T) {
Sam Delmerico3177a6e2022-06-21 19:28:33 +00001294 runCcLibraryTestCase(t, Bp2buildTestCase{
1295 Description: "cc_library - nocrt in select",
1296 ModuleTypeUnderTest: "cc_library",
1297 ModuleTypeUnderTestFactory: cc.LibraryFactory,
1298 Filesystem: map[string]string{
Jingwen Chen6ada5892021-09-17 11:38:09 +00001299 "impl.cpp": "",
1300 },
Sam Delmerico3177a6e2022-06-21 19:28:33 +00001301 Blueprint: soongCcLibraryPreamble + `
Jingwen Chen6ada5892021-09-17 11:38:09 +00001302cc_library {
1303 name: "foo-lib",
1304 srcs: ["impl.cpp"],
1305 arch: {
1306 arm: {
1307 nocrt: true,
1308 },
1309 x86: {
1310 nocrt: false,
1311 },
1312 },
1313 include_build_directory: false,
1314}
1315`,
Sam Delmerico3177a6e2022-06-21 19:28:33 +00001316 ExpectedErr: fmt.Errorf("module \"foo-lib\": nocrt is not supported for arch variants"),
Jingwen Chen6ada5892021-09-17 11:38:09 +00001317 })
1318}
1319
1320func TestCCLibraryNoLibCrtTrue(t *testing.T) {
Sam Delmerico3177a6e2022-06-21 19:28:33 +00001321 runCcLibraryTestCase(t, Bp2buildTestCase{
1322 ModuleTypeUnderTest: "cc_library",
1323 ModuleTypeUnderTestFactory: cc.LibraryFactory,
1324 Filesystem: map[string]string{
Liz Kammerd366c902021-06-03 13:43:01 -04001325 "impl.cpp": "",
1326 },
Sam Delmerico3177a6e2022-06-21 19:28:33 +00001327 Blueprint: soongCcLibraryPreamble + `
Liz Kammerd366c902021-06-03 13:43:01 -04001328cc_library {
1329 name: "foo-lib",
1330 srcs: ["impl.cpp"],
1331 no_libcrt: true,
Liz Kammer8337ea42021-09-10 10:06:32 -04001332 include_build_directory: false,
Liz Kammerd366c902021-06-03 13:43:01 -04001333}
1334`,
Sam Delmerico3177a6e2022-06-21 19:28:33 +00001335 ExpectedBazelTargets: makeCcLibraryTargets("foo-lib", AttrNameToString{
Chris Parsons77acf2e2021-12-03 17:27:16 -05001336 "srcs": `["impl.cpp"]`,
1337 "use_libcrt": `False`,
1338 }),
1339 })
1340}
1341
Sam Delmerico3177a6e2022-06-21 19:28:33 +00001342func makeCcLibraryTargets(name string, attrs AttrNameToString) []string {
Chris Parsons77acf2e2021-12-03 17:27:16 -05001343 STATIC_ONLY_ATTRS := map[string]bool{}
1344 SHARED_ONLY_ATTRS := map[string]bool{
1345 "link_crt": true,
1346 "additional_linker_inputs": true,
1347 "linkopts": true,
1348 "strip": true,
Yu Liu75be7b92022-02-01 09:54:09 -08001349 "inject_bssl_hash": true,
Wei Li81852ca2022-07-27 00:22:06 -07001350 "has_stubs": true,
Liz Kammerbaced712022-09-16 09:01:29 -04001351 "use_version_lib": true,
Chris Parsons77acf2e2021-12-03 17:27:16 -05001352 }
Wei Li81852ca2022-07-27 00:22:06 -07001353
Sam Delmerico3177a6e2022-06-21 19:28:33 +00001354 sharedAttrs := AttrNameToString{}
1355 staticAttrs := AttrNameToString{}
Chris Parsons77acf2e2021-12-03 17:27:16 -05001356 for key, val := range attrs {
1357 if _, staticOnly := STATIC_ONLY_ATTRS[key]; !staticOnly {
1358 sharedAttrs[key] = val
1359 }
1360 if _, sharedOnly := SHARED_ONLY_ATTRS[key]; !sharedOnly {
1361 staticAttrs[key] = val
1362 }
1363 }
Alixe06d75b2022-08-31 18:28:19 +00001364 sharedTarget := MakeBazelTarget("cc_library_shared", name, sharedAttrs)
1365 staticTarget := MakeBazelTarget("cc_library_static", name+"_bp2build_cc_library_static", staticAttrs)
Chris Parsons77acf2e2021-12-03 17:27:16 -05001366
1367 return []string{staticTarget, sharedTarget}
Liz Kammerd366c902021-06-03 13:43:01 -04001368}
1369
Jingwen Chen6ada5892021-09-17 11:38:09 +00001370func TestCCLibraryNoLibCrtFalse(t *testing.T) {
Sam Delmerico3177a6e2022-06-21 19:28:33 +00001371 runCcLibraryTestCase(t, Bp2buildTestCase{
1372 ModuleTypeUnderTest: "cc_library",
1373 ModuleTypeUnderTestFactory: cc.LibraryFactory,
1374 Filesystem: map[string]string{
Liz Kammerd366c902021-06-03 13:43:01 -04001375 "impl.cpp": "",
1376 },
Sam Delmerico3177a6e2022-06-21 19:28:33 +00001377 Blueprint: soongCcLibraryPreamble + `
Liz Kammerd366c902021-06-03 13:43:01 -04001378cc_library {
1379 name: "foo-lib",
1380 srcs: ["impl.cpp"],
1381 no_libcrt: false,
Liz Kammer8337ea42021-09-10 10:06:32 -04001382 include_build_directory: false,
Liz Kammerd366c902021-06-03 13:43:01 -04001383}
1384`,
Sam Delmerico3177a6e2022-06-21 19:28:33 +00001385 ExpectedBazelTargets: makeCcLibraryTargets("foo-lib", AttrNameToString{
Chris Parsons77acf2e2021-12-03 17:27:16 -05001386 "srcs": `["impl.cpp"]`,
1387 "use_libcrt": `True`,
1388 }),
1389 })
Liz Kammerd366c902021-06-03 13:43:01 -04001390}
1391
Jingwen Chen6ada5892021-09-17 11:38:09 +00001392func TestCCLibraryNoLibCrtArchVariant(t *testing.T) {
Sam Delmerico3177a6e2022-06-21 19:28:33 +00001393 runCcLibraryTestCase(t, Bp2buildTestCase{
1394 ModuleTypeUnderTest: "cc_library",
1395 ModuleTypeUnderTestFactory: cc.LibraryFactory,
1396 Filesystem: map[string]string{
Liz Kammerd366c902021-06-03 13:43:01 -04001397 "impl.cpp": "",
1398 },
Sam Delmerico3177a6e2022-06-21 19:28:33 +00001399 Blueprint: soongCcLibraryPreamble + `
Liz Kammerd366c902021-06-03 13:43:01 -04001400cc_library {
1401 name: "foo-lib",
1402 srcs: ["impl.cpp"],
1403 arch: {
1404 arm: {
1405 no_libcrt: true,
1406 },
1407 x86: {
1408 no_libcrt: true,
1409 },
1410 },
Liz Kammer8337ea42021-09-10 10:06:32 -04001411 include_build_directory: false,
Liz Kammerd366c902021-06-03 13:43:01 -04001412}
1413`,
Sam Delmerico3177a6e2022-06-21 19:28:33 +00001414 ExpectedBazelTargets: makeCcLibraryTargets("foo-lib", AttrNameToString{
Chris Parsons77acf2e2021-12-03 17:27:16 -05001415 "srcs": `["impl.cpp"]`,
1416 "use_libcrt": `select({
Liz Kammerd366c902021-06-03 13:43:01 -04001417 "//build/bazel/platforms/arch:arm": False,
1418 "//build/bazel/platforms/arch:x86": False,
1419 "//conditions:default": None,
Liz Kammer78cfdaa2021-11-08 12:56:31 -05001420 })`,
Chris Parsons77acf2e2021-12-03 17:27:16 -05001421 }),
1422 })
Liz Kammerd366c902021-06-03 13:43:01 -04001423}
1424
Chris Parsons58852a02021-12-09 18:10:18 -05001425func TestCCLibraryNoLibCrtArchAndTargetVariant(t *testing.T) {
Sam Delmerico3177a6e2022-06-21 19:28:33 +00001426 runCcLibraryTestCase(t, Bp2buildTestCase{
1427 ModuleTypeUnderTest: "cc_library",
1428 ModuleTypeUnderTestFactory: cc.LibraryFactory,
1429 Filesystem: map[string]string{
Chris Parsons58852a02021-12-09 18:10:18 -05001430 "impl.cpp": "",
1431 },
Sam Delmerico3177a6e2022-06-21 19:28:33 +00001432 Blueprint: soongCcLibraryPreamble + `
Chris Parsons58852a02021-12-09 18:10:18 -05001433cc_library {
1434 name: "foo-lib",
1435 srcs: ["impl.cpp"],
1436 arch: {
1437 arm: {
1438 no_libcrt: true,
1439 },
1440 x86: {
1441 no_libcrt: true,
1442 },
1443 },
1444 target: {
1445 darwin: {
1446 no_libcrt: true,
1447 }
1448 },
1449 include_build_directory: false,
1450}
1451`,
Sam Delmerico3177a6e2022-06-21 19:28:33 +00001452 ExpectedBazelTargets: makeCcLibraryTargets("foo-lib", AttrNameToString{
Chris Parsons58852a02021-12-09 18:10:18 -05001453 "srcs": `["impl.cpp"]`,
1454 "use_libcrt": `select({
1455 "//build/bazel/platforms/os_arch:android_arm": False,
1456 "//build/bazel/platforms/os_arch:android_x86": False,
1457 "//build/bazel/platforms/os_arch:darwin_arm64": False,
1458 "//build/bazel/platforms/os_arch:darwin_x86_64": False,
1459 "//build/bazel/platforms/os_arch:linux_glibc_x86": False,
1460 "//build/bazel/platforms/os_arch:linux_musl_x86": False,
1461 "//build/bazel/platforms/os_arch:windows_x86": False,
1462 "//conditions:default": None,
1463 })`,
1464 }),
1465 })
1466}
1467
1468func TestCCLibraryNoLibCrtArchAndTargetVariantConflict(t *testing.T) {
Sam Delmerico3177a6e2022-06-21 19:28:33 +00001469 runCcLibraryTestCase(t, Bp2buildTestCase{
1470 ModuleTypeUnderTest: "cc_library",
1471 ModuleTypeUnderTestFactory: cc.LibraryFactory,
1472 Filesystem: map[string]string{
Chris Parsons58852a02021-12-09 18:10:18 -05001473 "impl.cpp": "",
1474 },
Sam Delmerico3177a6e2022-06-21 19:28:33 +00001475 Blueprint: soongCcLibraryPreamble + `
Chris Parsons58852a02021-12-09 18:10:18 -05001476cc_library {
1477 name: "foo-lib",
1478 srcs: ["impl.cpp"],
1479 arch: {
1480 arm: {
1481 no_libcrt: true,
1482 },
1483 // This is expected to override the value for darwin_x86_64.
1484 x86_64: {
1485 no_libcrt: true,
1486 },
1487 },
1488 target: {
1489 darwin: {
1490 no_libcrt: false,
1491 }
1492 },
1493 include_build_directory: false,
1494}
1495`,
Sam Delmerico3177a6e2022-06-21 19:28:33 +00001496 ExpectedBazelTargets: makeCcLibraryTargets("foo-lib", AttrNameToString{
Chris Parsons58852a02021-12-09 18:10:18 -05001497 "srcs": `["impl.cpp"]`,
1498 "use_libcrt": `select({
1499 "//build/bazel/platforms/os_arch:android_arm": False,
1500 "//build/bazel/platforms/os_arch:android_x86_64": False,
1501 "//build/bazel/platforms/os_arch:darwin_arm64": True,
1502 "//build/bazel/platforms/os_arch:darwin_x86_64": False,
1503 "//build/bazel/platforms/os_arch:linux_bionic_x86_64": False,
1504 "//build/bazel/platforms/os_arch:linux_glibc_x86_64": False,
1505 "//build/bazel/platforms/os_arch:linux_musl_x86_64": False,
1506 "//build/bazel/platforms/os_arch:windows_x86_64": False,
1507 "//conditions:default": None,
1508 })`,
1509 }),
1510 })
1511}
1512
Jingwen Chen3d383bb2021-06-09 07:18:37 +00001513func TestCcLibraryStrip(t *testing.T) {
Chris Parsons77acf2e2021-12-03 17:27:16 -05001514 expectedTargets := []string{}
Sam Delmerico3177a6e2022-06-21 19:28:33 +00001515 expectedTargets = append(expectedTargets, makeCcLibraryTargets("all", AttrNameToString{
Chris Parsons77acf2e2021-12-03 17:27:16 -05001516 "strip": `{
1517 "all": True,
1518 }`,
1519 })...)
Sam Delmerico3177a6e2022-06-21 19:28:33 +00001520 expectedTargets = append(expectedTargets, makeCcLibraryTargets("keep_symbols", AttrNameToString{
Chris Parsons77acf2e2021-12-03 17:27:16 -05001521 "strip": `{
1522 "keep_symbols": True,
1523 }`,
1524 })...)
Sam Delmerico3177a6e2022-06-21 19:28:33 +00001525 expectedTargets = append(expectedTargets, makeCcLibraryTargets("keep_symbols_and_debug_frame", AttrNameToString{
Chris Parsons77acf2e2021-12-03 17:27:16 -05001526 "strip": `{
1527 "keep_symbols_and_debug_frame": True,
1528 }`,
1529 })...)
Sam Delmerico3177a6e2022-06-21 19:28:33 +00001530 expectedTargets = append(expectedTargets, makeCcLibraryTargets("keep_symbols_list", AttrNameToString{
Chris Parsons77acf2e2021-12-03 17:27:16 -05001531 "strip": `{
1532 "keep_symbols_list": ["symbol"],
1533 }`,
1534 })...)
Sam Delmerico3177a6e2022-06-21 19:28:33 +00001535 expectedTargets = append(expectedTargets, makeCcLibraryTargets("none", AttrNameToString{
Chris Parsons77acf2e2021-12-03 17:27:16 -05001536 "strip": `{
1537 "none": True,
1538 }`,
1539 })...)
Sam Delmerico3177a6e2022-06-21 19:28:33 +00001540 expectedTargets = append(expectedTargets, makeCcLibraryTargets("nothing", AttrNameToString{})...)
Chris Parsons77acf2e2021-12-03 17:27:16 -05001541
Sam Delmerico3177a6e2022-06-21 19:28:33 +00001542 runCcLibraryTestCase(t, Bp2buildTestCase{
1543 Description: "cc_library strip args",
1544 ModuleTypeUnderTest: "cc_library",
1545 ModuleTypeUnderTestFactory: cc.LibraryFactory,
1546 Blueprint: soongCcLibraryPreamble + `
Jingwen Chen3d383bb2021-06-09 07:18:37 +00001547cc_library {
1548 name: "nothing",
Liz Kammer8337ea42021-09-10 10:06:32 -04001549 include_build_directory: false,
Jingwen Chen3d383bb2021-06-09 07:18:37 +00001550}
1551cc_library {
1552 name: "keep_symbols",
Jingwen Chen3d383bb2021-06-09 07:18:37 +00001553 strip: {
Liz Kammer8337ea42021-09-10 10:06:32 -04001554 keep_symbols: true,
1555 },
1556 include_build_directory: false,
Jingwen Chen3d383bb2021-06-09 07:18:37 +00001557}
1558cc_library {
1559 name: "keep_symbols_and_debug_frame",
Jingwen Chen3d383bb2021-06-09 07:18:37 +00001560 strip: {
Liz Kammer8337ea42021-09-10 10:06:32 -04001561 keep_symbols_and_debug_frame: true,
1562 },
1563 include_build_directory: false,
Jingwen Chen3d383bb2021-06-09 07:18:37 +00001564}
1565cc_library {
1566 name: "none",
Jingwen Chen3d383bb2021-06-09 07:18:37 +00001567 strip: {
Liz Kammer8337ea42021-09-10 10:06:32 -04001568 none: true,
1569 },
1570 include_build_directory: false,
Jingwen Chen3d383bb2021-06-09 07:18:37 +00001571}
1572cc_library {
1573 name: "keep_symbols_list",
Jingwen Chen3d383bb2021-06-09 07:18:37 +00001574 strip: {
Liz Kammer8337ea42021-09-10 10:06:32 -04001575 keep_symbols_list: ["symbol"],
1576 },
1577 include_build_directory: false,
Jingwen Chen3d383bb2021-06-09 07:18:37 +00001578}
1579cc_library {
1580 name: "all",
Jingwen Chen3d383bb2021-06-09 07:18:37 +00001581 strip: {
Liz Kammer8337ea42021-09-10 10:06:32 -04001582 all: true,
1583 },
1584 include_build_directory: false,
Jingwen Chen3d383bb2021-06-09 07:18:37 +00001585}
1586`,
Sam Delmerico3177a6e2022-06-21 19:28:33 +00001587 ExpectedBazelTargets: expectedTargets,
Jingwen Chen3d383bb2021-06-09 07:18:37 +00001588 })
1589}
1590
1591func TestCcLibraryStripWithArch(t *testing.T) {
Sam Delmerico3177a6e2022-06-21 19:28:33 +00001592 runCcLibraryTestCase(t, Bp2buildTestCase{
1593 Description: "cc_library strip args",
1594 ModuleTypeUnderTest: "cc_library",
1595 ModuleTypeUnderTestFactory: cc.LibraryFactory,
1596 Blueprint: soongCcLibraryPreamble + `
Jingwen Chen3d383bb2021-06-09 07:18:37 +00001597cc_library {
1598 name: "multi-arch",
Jingwen Chen3d383bb2021-06-09 07:18:37 +00001599 target: {
1600 darwin: {
1601 strip: {
1602 keep_symbols_list: ["foo", "bar"]
1603 }
1604 },
1605 },
1606 arch: {
1607 arm: {
1608 strip: {
1609 keep_symbols_and_debug_frame: true,
1610 },
1611 },
1612 arm64: {
1613 strip: {
1614 keep_symbols: true,
1615 },
1616 },
Liz Kammer8337ea42021-09-10 10:06:32 -04001617 },
1618 include_build_directory: false,
Jingwen Chen3d383bb2021-06-09 07:18:37 +00001619}
1620`,
Sam Delmerico3177a6e2022-06-21 19:28:33 +00001621 ExpectedBazelTargets: makeCcLibraryTargets("multi-arch", AttrNameToString{
Chris Parsons77acf2e2021-12-03 17:27:16 -05001622 "strip": `{
Jingwen Chen3d383bb2021-06-09 07:18:37 +00001623 "keep_symbols": select({
1624 "//build/bazel/platforms/arch:arm64": True,
1625 "//conditions:default": None,
1626 }),
1627 "keep_symbols_and_debug_frame": select({
1628 "//build/bazel/platforms/arch:arm": True,
1629 "//conditions:default": None,
1630 }),
1631 "keep_symbols_list": select({
1632 "//build/bazel/platforms/os:darwin": [
1633 "foo",
1634 "bar",
1635 ],
1636 "//conditions:default": [],
1637 }),
Liz Kammer78cfdaa2021-11-08 12:56:31 -05001638 }`,
Chris Parsons77acf2e2021-12-03 17:27:16 -05001639 }),
1640 },
1641 )
Jingwen Chen3d383bb2021-06-09 07:18:37 +00001642}
Chris Parsons51f8c392021-08-03 21:01:05 -04001643
1644func TestCcLibrary_SystemSharedLibsRootEmpty(t *testing.T) {
Sam Delmerico3177a6e2022-06-21 19:28:33 +00001645 runCcLibraryTestCase(t, Bp2buildTestCase{
1646 Description: "cc_library system_shared_libs empty at root",
1647 ModuleTypeUnderTest: "cc_library",
1648 ModuleTypeUnderTestFactory: cc.LibraryFactory,
1649 Blueprint: soongCcLibraryPreamble + `
Chris Parsons51f8c392021-08-03 21:01:05 -04001650cc_library {
1651 name: "root_empty",
Liz Kammer8337ea42021-09-10 10:06:32 -04001652 system_shared_libs: [],
1653 include_build_directory: false,
Chris Parsons51f8c392021-08-03 21:01:05 -04001654}
1655`,
Sam Delmerico3177a6e2022-06-21 19:28:33 +00001656 ExpectedBazelTargets: makeCcLibraryTargets("root_empty", AttrNameToString{
Chris Parsons77acf2e2021-12-03 17:27:16 -05001657 "system_dynamic_deps": `[]`,
1658 }),
1659 },
1660 )
Chris Parsons51f8c392021-08-03 21:01:05 -04001661}
1662
1663func TestCcLibrary_SystemSharedLibsStaticEmpty(t *testing.T) {
Sam Delmerico3177a6e2022-06-21 19:28:33 +00001664 runCcLibraryTestCase(t, Bp2buildTestCase{
1665 Description: "cc_library system_shared_libs empty for static variant",
1666 ModuleTypeUnderTest: "cc_library",
1667 ModuleTypeUnderTestFactory: cc.LibraryFactory,
1668 Blueprint: soongCcLibraryPreamble + `
Chris Parsons51f8c392021-08-03 21:01:05 -04001669cc_library {
1670 name: "static_empty",
1671 static: {
Liz Kammer8337ea42021-09-10 10:06:32 -04001672 system_shared_libs: [],
1673 },
1674 include_build_directory: false,
Chris Parsons51f8c392021-08-03 21:01:05 -04001675}
1676`,
Sam Delmerico3177a6e2022-06-21 19:28:33 +00001677 ExpectedBazelTargets: []string{
Alixe06d75b2022-08-31 18:28:19 +00001678 MakeBazelTarget("cc_library_static", "static_empty_bp2build_cc_library_static", AttrNameToString{
Chris Parsons77acf2e2021-12-03 17:27:16 -05001679 "system_dynamic_deps": "[]",
Liz Kammer78cfdaa2021-11-08 12:56:31 -05001680 }),
Alixe06d75b2022-08-31 18:28:19 +00001681 MakeBazelTarget("cc_library_shared", "static_empty", AttrNameToString{}),
Liz Kammer78cfdaa2021-11-08 12:56:31 -05001682 },
Chris Parsons51f8c392021-08-03 21:01:05 -04001683 })
1684}
1685
1686func TestCcLibrary_SystemSharedLibsSharedEmpty(t *testing.T) {
Sam Delmerico3177a6e2022-06-21 19:28:33 +00001687 runCcLibraryTestCase(t, Bp2buildTestCase{
1688 Description: "cc_library system_shared_libs empty for shared variant",
1689 ModuleTypeUnderTest: "cc_library",
1690 ModuleTypeUnderTestFactory: cc.LibraryFactory,
1691 Blueprint: soongCcLibraryPreamble + `
Chris Parsons51f8c392021-08-03 21:01:05 -04001692cc_library {
1693 name: "shared_empty",
1694 shared: {
Liz Kammer8337ea42021-09-10 10:06:32 -04001695 system_shared_libs: [],
1696 },
1697 include_build_directory: false,
Chris Parsons51f8c392021-08-03 21:01:05 -04001698}
1699`,
Sam Delmerico3177a6e2022-06-21 19:28:33 +00001700 ExpectedBazelTargets: []string{
Alixe06d75b2022-08-31 18:28:19 +00001701 MakeBazelTarget("cc_library_static", "shared_empty_bp2build_cc_library_static", AttrNameToString{}),
1702 MakeBazelTarget("cc_library_shared", "shared_empty", AttrNameToString{
Chris Parsons77acf2e2021-12-03 17:27:16 -05001703 "system_dynamic_deps": "[]",
Liz Kammer78cfdaa2021-11-08 12:56:31 -05001704 }),
1705 },
Chris Parsons51f8c392021-08-03 21:01:05 -04001706 })
1707}
1708
1709func TestCcLibrary_SystemSharedLibsSharedBionicEmpty(t *testing.T) {
Sam Delmerico3177a6e2022-06-21 19:28:33 +00001710 runCcLibraryTestCase(t, Bp2buildTestCase{
1711 Description: "cc_library system_shared_libs empty for shared, bionic variant",
1712 ModuleTypeUnderTest: "cc_library",
1713 ModuleTypeUnderTestFactory: cc.LibraryFactory,
1714 Blueprint: soongCcLibraryPreamble + `
Chris Parsons51f8c392021-08-03 21:01:05 -04001715cc_library {
1716 name: "shared_empty",
1717 target: {
1718 bionic: {
1719 shared: {
1720 system_shared_libs: [],
1721 }
1722 }
Liz Kammer8337ea42021-09-10 10:06:32 -04001723 },
1724 include_build_directory: false,
Chris Parsons51f8c392021-08-03 21:01:05 -04001725}
1726`,
Sam Delmerico3177a6e2022-06-21 19:28:33 +00001727 ExpectedBazelTargets: []string{
Alixe06d75b2022-08-31 18:28:19 +00001728 MakeBazelTarget("cc_library_static", "shared_empty_bp2build_cc_library_static", AttrNameToString{}),
1729 MakeBazelTarget("cc_library_shared", "shared_empty", AttrNameToString{
Chris Parsons77acf2e2021-12-03 17:27:16 -05001730 "system_dynamic_deps": "[]",
Liz Kammer78cfdaa2021-11-08 12:56:31 -05001731 }),
1732 },
Chris Parsons51f8c392021-08-03 21:01:05 -04001733 })
1734}
1735
1736func TestCcLibrary_SystemSharedLibsLinuxBionicEmpty(t *testing.T) {
1737 // Note that this behavior is technically incorrect (it's a simplification).
1738 // The correct behavior would be if bp2build wrote `system_dynamic_deps = []`
1739 // only for linux_bionic, but `android` had `["libc", "libdl", "libm"].
1740 // b/195791252 tracks the fix.
Sam Delmerico3177a6e2022-06-21 19:28:33 +00001741 runCcLibraryTestCase(t, Bp2buildTestCase{
1742 Description: "cc_library system_shared_libs empty for linux_bionic variant",
1743 ModuleTypeUnderTest: "cc_library",
1744 ModuleTypeUnderTestFactory: cc.LibraryFactory,
1745 Blueprint: soongCcLibraryPreamble + `
Chris Parsons51f8c392021-08-03 21:01:05 -04001746cc_library {
1747 name: "target_linux_bionic_empty",
1748 target: {
1749 linux_bionic: {
1750 system_shared_libs: [],
1751 },
1752 },
Liz Kammer8337ea42021-09-10 10:06:32 -04001753 include_build_directory: false,
Chris Parsons51f8c392021-08-03 21:01:05 -04001754}
1755`,
Sam Delmerico3177a6e2022-06-21 19:28:33 +00001756 ExpectedBazelTargets: makeCcLibraryTargets("target_linux_bionic_empty", AttrNameToString{
Chris Parsons77acf2e2021-12-03 17:27:16 -05001757 "system_dynamic_deps": `[]`,
1758 }),
1759 },
1760 )
Chris Parsons51f8c392021-08-03 21:01:05 -04001761}
1762
1763func TestCcLibrary_SystemSharedLibsBionicEmpty(t *testing.T) {
Sam Delmerico3177a6e2022-06-21 19:28:33 +00001764 runCcLibraryTestCase(t, Bp2buildTestCase{
1765 Description: "cc_library system_shared_libs empty for bionic variant",
1766 ModuleTypeUnderTest: "cc_library",
1767 ModuleTypeUnderTestFactory: cc.LibraryFactory,
1768 Blueprint: soongCcLibraryPreamble + `
Chris Parsons51f8c392021-08-03 21:01:05 -04001769cc_library {
1770 name: "target_bionic_empty",
1771 target: {
1772 bionic: {
1773 system_shared_libs: [],
1774 },
1775 },
Liz Kammer8337ea42021-09-10 10:06:32 -04001776 include_build_directory: false,
Chris Parsons51f8c392021-08-03 21:01:05 -04001777}
1778`,
Sam Delmerico3177a6e2022-06-21 19:28:33 +00001779 ExpectedBazelTargets: makeCcLibraryTargets("target_bionic_empty", AttrNameToString{
Chris Parsons77acf2e2021-12-03 17:27:16 -05001780 "system_dynamic_deps": `[]`,
1781 }),
1782 },
1783 )
Chris Parsons51f8c392021-08-03 21:01:05 -04001784}
1785
1786func TestCcLibrary_SystemSharedLibsSharedAndRoot(t *testing.T) {
Sam Delmerico3177a6e2022-06-21 19:28:33 +00001787 runCcLibraryTestCase(t, Bp2buildTestCase{
1788 Description: "cc_library system_shared_libs set for shared and root",
1789 ModuleTypeUnderTest: "cc_library",
1790 ModuleTypeUnderTestFactory: cc.LibraryFactory,
1791 Blueprint: soongCcLibraryPreamble + `
Liz Kammer8337ea42021-09-10 10:06:32 -04001792cc_library {
1793 name: "libc",
1794 bazel_module: { bp2build_available: false },
1795}
1796cc_library {
1797 name: "libm",
1798 bazel_module: { bp2build_available: false },
1799}
Chris Parsons51f8c392021-08-03 21:01:05 -04001800
1801cc_library {
1802 name: "foo",
1803 system_shared_libs: ["libc"],
1804 shared: {
Liz Kammer8337ea42021-09-10 10:06:32 -04001805 system_shared_libs: ["libm"],
Chris Parsons51f8c392021-08-03 21:01:05 -04001806 },
Liz Kammer8337ea42021-09-10 10:06:32 -04001807 include_build_directory: false,
Chris Parsons51f8c392021-08-03 21:01:05 -04001808}
1809`,
Sam Delmerico3177a6e2022-06-21 19:28:33 +00001810 ExpectedBazelTargets: []string{
Alixe06d75b2022-08-31 18:28:19 +00001811 MakeBazelTarget("cc_library_static", "foo_bp2build_cc_library_static", AttrNameToString{
Liz Kammer78cfdaa2021-11-08 12:56:31 -05001812 "system_dynamic_deps": `[":libc"]`,
1813 }),
Alixe06d75b2022-08-31 18:28:19 +00001814 MakeBazelTarget("cc_library_shared", "foo", AttrNameToString{
Chris Parsons77acf2e2021-12-03 17:27:16 -05001815 "system_dynamic_deps": `[
1816 ":libc",
1817 ":libm",
1818 ]`,
1819 }),
Liz Kammer78cfdaa2021-11-08 12:56:31 -05001820 },
Chris Parsons51f8c392021-08-03 21:01:05 -04001821 })
1822}
Chris Parsons2dde0cb2021-10-01 14:45:30 -04001823
1824func TestCcLibraryOsSelects(t *testing.T) {
Sam Delmerico3177a6e2022-06-21 19:28:33 +00001825 runCcLibraryTestCase(t, Bp2buildTestCase{
1826 Description: "cc_library - selects for all os targets",
1827 ModuleTypeUnderTest: "cc_library",
1828 ModuleTypeUnderTestFactory: cc.LibraryFactory,
1829 Filesystem: map[string]string{},
1830 Blueprint: soongCcLibraryPreamble + `
Chris Parsons2dde0cb2021-10-01 14:45:30 -04001831cc_library {
1832 name: "foo-lib",
1833 srcs: ["base.cpp"],
1834 target: {
1835 android: {
1836 srcs: ["android.cpp"],
1837 },
1838 linux: {
1839 srcs: ["linux.cpp"],
1840 },
1841 linux_glibc: {
1842 srcs: ["linux_glibc.cpp"],
1843 },
1844 darwin: {
1845 srcs: ["darwin.cpp"],
1846 },
1847 bionic: {
1848 srcs: ["bionic.cpp"],
1849 },
1850 linux_musl: {
1851 srcs: ["linux_musl.cpp"],
1852 },
1853 windows: {
1854 srcs: ["windows.cpp"],
1855 },
1856 },
1857 include_build_directory: false,
1858}
1859`,
Sam Delmerico3177a6e2022-06-21 19:28:33 +00001860 ExpectedBazelTargets: makeCcLibraryTargets("foo-lib", AttrNameToString{
Chris Parsons77acf2e2021-12-03 17:27:16 -05001861 "srcs": `["base.cpp"] + select({
Chris Parsons2dde0cb2021-10-01 14:45:30 -04001862 "//build/bazel/platforms/os:android": [
Chris Parsons2dde0cb2021-10-01 14:45:30 -04001863 "linux.cpp",
Liz Kammer9bad9d62021-10-11 15:40:35 -04001864 "bionic.cpp",
Liz Kammerfdd72e62021-10-11 15:41:03 -04001865 "android.cpp",
Chris Parsons2dde0cb2021-10-01 14:45:30 -04001866 ],
1867 "//build/bazel/platforms/os:darwin": ["darwin.cpp"],
1868 "//build/bazel/platforms/os:linux": [
Liz Kammer9bad9d62021-10-11 15:40:35 -04001869 "linux.cpp",
Liz Kammerfdd72e62021-10-11 15:41:03 -04001870 "linux_glibc.cpp",
Chris Parsons2dde0cb2021-10-01 14:45:30 -04001871 ],
1872 "//build/bazel/platforms/os:linux_bionic": [
Chris Parsons2dde0cb2021-10-01 14:45:30 -04001873 "linux.cpp",
Liz Kammer9bad9d62021-10-11 15:40:35 -04001874 "bionic.cpp",
Chris Parsons2dde0cb2021-10-01 14:45:30 -04001875 ],
1876 "//build/bazel/platforms/os:linux_musl": [
Liz Kammer9bad9d62021-10-11 15:40:35 -04001877 "linux.cpp",
Liz Kammerfdd72e62021-10-11 15:41:03 -04001878 "linux_musl.cpp",
Chris Parsons2dde0cb2021-10-01 14:45:30 -04001879 ],
1880 "//build/bazel/platforms/os:windows": ["windows.cpp"],
1881 "//conditions:default": [],
Liz Kammer78cfdaa2021-11-08 12:56:31 -05001882 })`,
Chris Parsons77acf2e2021-12-03 17:27:16 -05001883 }),
1884 },
1885 )
Jingwen Chen97b85312021-10-08 10:41:31 +00001886}
1887
Yu Liu75be7b92022-02-01 09:54:09 -08001888func TestLibcryptoHashInjection(t *testing.T) {
Sam Delmerico3177a6e2022-06-21 19:28:33 +00001889 runCcLibraryTestCase(t, Bp2buildTestCase{
1890 Description: "cc_library - libcrypto hash injection",
1891 ModuleTypeUnderTest: "cc_library",
1892 ModuleTypeUnderTestFactory: cc.LibraryFactory,
1893 Filesystem: map[string]string{},
1894 Blueprint: soongCcLibraryPreamble + `
Yu Liu75be7b92022-02-01 09:54:09 -08001895cc_library {
1896 name: "libcrypto",
1897 target: {
1898 android: {
1899 inject_bssl_hash: true,
1900 },
1901 },
1902 include_build_directory: false,
1903}
1904`,
Sam Delmerico3177a6e2022-06-21 19:28:33 +00001905 ExpectedBazelTargets: makeCcLibraryTargets("libcrypto", AttrNameToString{
Yu Liu75be7b92022-02-01 09:54:09 -08001906 "inject_bssl_hash": `select({
1907 "//build/bazel/platforms/os:android": True,
1908 "//conditions:default": None,
1909 })`,
1910 }),
1911 },
1912 )
1913}
1914
Jingwen Chen5b11ab12021-10-11 17:44:33 +00001915func TestCcLibraryCppStdWithGnuExtensions_ConvertsToFeatureAttr(t *testing.T) {
Jingwen Chen97b85312021-10-08 10:41:31 +00001916 type testCase struct {
1917 cpp_std string
Chris Parsons79bd2b72021-11-29 17:52:41 -05001918 c_std string
Jingwen Chen97b85312021-10-08 10:41:31 +00001919 gnu_extensions string
1920 bazel_cpp_std string
Chris Parsons79bd2b72021-11-29 17:52:41 -05001921 bazel_c_std string
Jingwen Chen97b85312021-10-08 10:41:31 +00001922 }
1923
1924 testCases := []testCase{
1925 // Existing usages of cpp_std in AOSP are:
1926 // experimental, c++11, c++17, c++2a, c++98, gnu++11, gnu++17
1927 //
1928 // not set, only emit if gnu_extensions is disabled. the default (gnu+17
1929 // is set in the toolchain.)
1930 {cpp_std: "", gnu_extensions: "", bazel_cpp_std: ""},
Liz Kammera5a29de2022-05-25 23:19:37 -04001931 {cpp_std: "", gnu_extensions: "false", bazel_cpp_std: "cpp_std_default_no_gnu", bazel_c_std: "c_std_default_no_gnu"},
Jingwen Chen97b85312021-10-08 10:41:31 +00001932 {cpp_std: "", gnu_extensions: "true", bazel_cpp_std: ""},
1933 // experimental defaults to gnu++2a
Liz Kammera5a29de2022-05-25 23:19:37 -04001934 {cpp_std: "experimental", gnu_extensions: "", bazel_cpp_std: "cpp_std_experimental"},
1935 {cpp_std: "experimental", gnu_extensions: "false", bazel_cpp_std: "cpp_std_experimental_no_gnu", bazel_c_std: "c_std_default_no_gnu"},
1936 {cpp_std: "experimental", gnu_extensions: "true", bazel_cpp_std: "cpp_std_experimental"},
Jingwen Chen97b85312021-10-08 10:41:31 +00001937 // Explicitly setting a c++ std does not use replace gnu++ std even if
1938 // gnu_extensions is true.
1939 // "c++11",
1940 {cpp_std: "c++11", gnu_extensions: "", bazel_cpp_std: "c++11"},
Liz Kammera5a29de2022-05-25 23:19:37 -04001941 {cpp_std: "c++11", gnu_extensions: "false", bazel_cpp_std: "c++11", bazel_c_std: "c_std_default_no_gnu"},
Jingwen Chen97b85312021-10-08 10:41:31 +00001942 {cpp_std: "c++11", gnu_extensions: "true", bazel_cpp_std: "c++11"},
1943 // "c++17",
1944 {cpp_std: "c++17", gnu_extensions: "", bazel_cpp_std: "c++17"},
Liz Kammera5a29de2022-05-25 23:19:37 -04001945 {cpp_std: "c++17", gnu_extensions: "false", bazel_cpp_std: "c++17", bazel_c_std: "c_std_default_no_gnu"},
Jingwen Chen97b85312021-10-08 10:41:31 +00001946 {cpp_std: "c++17", gnu_extensions: "true", bazel_cpp_std: "c++17"},
1947 // "c++2a",
1948 {cpp_std: "c++2a", gnu_extensions: "", bazel_cpp_std: "c++2a"},
Liz Kammera5a29de2022-05-25 23:19:37 -04001949 {cpp_std: "c++2a", gnu_extensions: "false", bazel_cpp_std: "c++2a", bazel_c_std: "c_std_default_no_gnu"},
Jingwen Chen97b85312021-10-08 10:41:31 +00001950 {cpp_std: "c++2a", gnu_extensions: "true", bazel_cpp_std: "c++2a"},
1951 // "c++98",
1952 {cpp_std: "c++98", gnu_extensions: "", bazel_cpp_std: "c++98"},
Liz Kammera5a29de2022-05-25 23:19:37 -04001953 {cpp_std: "c++98", gnu_extensions: "false", bazel_cpp_std: "c++98", bazel_c_std: "c_std_default_no_gnu"},
Jingwen Chen97b85312021-10-08 10:41:31 +00001954 {cpp_std: "c++98", gnu_extensions: "true", bazel_cpp_std: "c++98"},
1955 // gnu++ is replaced with c++ if gnu_extensions is explicitly false.
1956 // "gnu++11",
1957 {cpp_std: "gnu++11", gnu_extensions: "", bazel_cpp_std: "gnu++11"},
Liz Kammera5a29de2022-05-25 23:19:37 -04001958 {cpp_std: "gnu++11", gnu_extensions: "false", bazel_cpp_std: "c++11", bazel_c_std: "c_std_default_no_gnu"},
Jingwen Chen97b85312021-10-08 10:41:31 +00001959 {cpp_std: "gnu++11", gnu_extensions: "true", bazel_cpp_std: "gnu++11"},
1960 // "gnu++17",
1961 {cpp_std: "gnu++17", gnu_extensions: "", bazel_cpp_std: "gnu++17"},
Liz Kammera5a29de2022-05-25 23:19:37 -04001962 {cpp_std: "gnu++17", gnu_extensions: "false", bazel_cpp_std: "c++17", bazel_c_std: "c_std_default_no_gnu"},
Jingwen Chen97b85312021-10-08 10:41:31 +00001963 {cpp_std: "gnu++17", gnu_extensions: "true", bazel_cpp_std: "gnu++17"},
Chris Parsons79bd2b72021-11-29 17:52:41 -05001964
1965 // some c_std test cases
Liz Kammera5a29de2022-05-25 23:19:37 -04001966 {c_std: "experimental", gnu_extensions: "", bazel_c_std: "c_std_experimental"},
1967 {c_std: "experimental", gnu_extensions: "false", bazel_cpp_std: "cpp_std_default_no_gnu", bazel_c_std: "c_std_experimental_no_gnu"},
1968 {c_std: "experimental", gnu_extensions: "true", bazel_c_std: "c_std_experimental"},
Chris Parsons79bd2b72021-11-29 17:52:41 -05001969 {c_std: "gnu11", cpp_std: "gnu++17", gnu_extensions: "", bazel_cpp_std: "gnu++17", bazel_c_std: "gnu11"},
1970 {c_std: "gnu11", cpp_std: "gnu++17", gnu_extensions: "false", bazel_cpp_std: "c++17", bazel_c_std: "c11"},
1971 {c_std: "gnu11", cpp_std: "gnu++17", gnu_extensions: "true", bazel_cpp_std: "gnu++17", bazel_c_std: "gnu11"},
Jingwen Chen97b85312021-10-08 10:41:31 +00001972 }
Chris Parsons79bd2b72021-11-29 17:52:41 -05001973 for i, tc := range testCases {
Liz Kammera5a29de2022-05-25 23:19:37 -04001974 name := fmt.Sprintf("cpp std: %q, c std: %q, gnu_extensions: %q", tc.cpp_std, tc.c_std, tc.gnu_extensions)
1975 t.Run(name, func(t *testing.T) {
1976 name_prefix := fmt.Sprintf("a_%v", i)
1977 cppStdProp := ""
1978 if tc.cpp_std != "" {
1979 cppStdProp = fmt.Sprintf(" cpp_std: \"%s\",", tc.cpp_std)
1980 }
1981 cStdProp := ""
1982 if tc.c_std != "" {
1983 cStdProp = fmt.Sprintf(" c_std: \"%s\",", tc.c_std)
1984 }
1985 gnuExtensionsProp := ""
1986 if tc.gnu_extensions != "" {
1987 gnuExtensionsProp = fmt.Sprintf(" gnu_extensions: %s,", tc.gnu_extensions)
1988 }
Sam Delmerico3177a6e2022-06-21 19:28:33 +00001989 attrs := AttrNameToString{}
Liz Kammera5a29de2022-05-25 23:19:37 -04001990 if tc.bazel_cpp_std != "" {
1991 attrs["cpp_std"] = fmt.Sprintf(`"%s"`, tc.bazel_cpp_std)
1992 }
1993 if tc.bazel_c_std != "" {
1994 attrs["c_std"] = fmt.Sprintf(`"%s"`, tc.bazel_c_std)
1995 }
Jingwen Chen97b85312021-10-08 10:41:31 +00001996
Sam Delmerico3177a6e2022-06-21 19:28:33 +00001997 runCcLibraryTestCase(t, Bp2buildTestCase{
1998 Description: fmt.Sprintf(
Liz Kammera5a29de2022-05-25 23:19:37 -04001999 "cc_library with cpp_std: %s and gnu_extensions: %s", tc.cpp_std, tc.gnu_extensions),
Sam Delmerico3177a6e2022-06-21 19:28:33 +00002000 ModuleTypeUnderTest: "cc_library",
2001 ModuleTypeUnderTestFactory: cc.LibraryFactory,
2002 Blueprint: soongCcLibraryPreamble + fmt.Sprintf(`
Jingwen Chen97b85312021-10-08 10:41:31 +00002003cc_library {
Chris Parsons79bd2b72021-11-29 17:52:41 -05002004 name: "%s_full",
Jingwen Chen97b85312021-10-08 10:41:31 +00002005%s // cpp_std: *string
Chris Parsons79bd2b72021-11-29 17:52:41 -05002006%s // c_std: *string
Jingwen Chen97b85312021-10-08 10:41:31 +00002007%s // gnu_extensions: *bool
2008 include_build_directory: false,
2009}
Chris Parsons79bd2b72021-11-29 17:52:41 -05002010`, name_prefix, cppStdProp, cStdProp, gnuExtensionsProp),
Sam Delmerico3177a6e2022-06-21 19:28:33 +00002011 ExpectedBazelTargets: makeCcLibraryTargets(name_prefix+"_full", attrs),
Liz Kammera5a29de2022-05-25 23:19:37 -04002012 })
Jingwen Chen5b11ab12021-10-11 17:44:33 +00002013
Sam Delmerico3177a6e2022-06-21 19:28:33 +00002014 runCcLibraryStaticTestCase(t, Bp2buildTestCase{
2015 Description: fmt.Sprintf(
Liz Kammera5a29de2022-05-25 23:19:37 -04002016 "cc_library_static with cpp_std: %s and gnu_extensions: %s", tc.cpp_std, tc.gnu_extensions),
Sam Delmerico3177a6e2022-06-21 19:28:33 +00002017 ModuleTypeUnderTest: "cc_library_static",
2018 ModuleTypeUnderTestFactory: cc.LibraryStaticFactory,
2019 Blueprint: soongCcLibraryPreamble + fmt.Sprintf(`
Jingwen Chen5b11ab12021-10-11 17:44:33 +00002020cc_library_static {
Chris Parsons79bd2b72021-11-29 17:52:41 -05002021 name: "%s_static",
Jingwen Chen5b11ab12021-10-11 17:44:33 +00002022%s // cpp_std: *string
Chris Parsons79bd2b72021-11-29 17:52:41 -05002023%s // c_std: *string
Jingwen Chen5b11ab12021-10-11 17:44:33 +00002024%s // gnu_extensions: *bool
2025 include_build_directory: false,
2026}
Chris Parsons79bd2b72021-11-29 17:52:41 -05002027`, name_prefix, cppStdProp, cStdProp, gnuExtensionsProp),
Sam Delmerico3177a6e2022-06-21 19:28:33 +00002028 ExpectedBazelTargets: []string{
Alixe06d75b2022-08-31 18:28:19 +00002029 MakeBazelTarget("cc_library_static", name_prefix+"_static", attrs),
Liz Kammera5a29de2022-05-25 23:19:37 -04002030 },
2031 })
Jingwen Chen5b11ab12021-10-11 17:44:33 +00002032
Sam Delmerico3177a6e2022-06-21 19:28:33 +00002033 runCcLibrarySharedTestCase(t, Bp2buildTestCase{
2034 Description: fmt.Sprintf(
Liz Kammera5a29de2022-05-25 23:19:37 -04002035 "cc_library_shared with cpp_std: %s and gnu_extensions: %s", tc.cpp_std, tc.gnu_extensions),
Sam Delmerico3177a6e2022-06-21 19:28:33 +00002036 ModuleTypeUnderTest: "cc_library_shared",
2037 ModuleTypeUnderTestFactory: cc.LibrarySharedFactory,
2038 Blueprint: soongCcLibraryPreamble + fmt.Sprintf(`
Jingwen Chen5b11ab12021-10-11 17:44:33 +00002039cc_library_shared {
Chris Parsons79bd2b72021-11-29 17:52:41 -05002040 name: "%s_shared",
Jingwen Chen5b11ab12021-10-11 17:44:33 +00002041%s // cpp_std: *string
Chris Parsons79bd2b72021-11-29 17:52:41 -05002042%s // c_std: *string
Jingwen Chen5b11ab12021-10-11 17:44:33 +00002043%s // gnu_extensions: *bool
2044 include_build_directory: false,
2045}
Chris Parsons79bd2b72021-11-29 17:52:41 -05002046`, name_prefix, cppStdProp, cStdProp, gnuExtensionsProp),
Sam Delmerico3177a6e2022-06-21 19:28:33 +00002047 ExpectedBazelTargets: []string{
Alixe06d75b2022-08-31 18:28:19 +00002048 MakeBazelTarget("cc_library_shared", name_prefix+"_shared", attrs),
Liz Kammera5a29de2022-05-25 23:19:37 -04002049 },
2050 })
Jingwen Chen5b11ab12021-10-11 17:44:33 +00002051 })
Jingwen Chen97b85312021-10-08 10:41:31 +00002052 }
Chris Parsons2dde0cb2021-10-01 14:45:30 -04002053}
Liz Kammer12615db2021-09-28 09:19:17 -04002054
2055func TestCcLibraryProtoSimple(t *testing.T) {
Sam Delmerico3177a6e2022-06-21 19:28:33 +00002056 runCcLibraryTestCase(t, Bp2buildTestCase{
2057 ModuleTypeUnderTest: "cc_library",
2058 ModuleTypeUnderTestFactory: cc.LibraryFactory,
2059 Blueprint: soongCcProtoPreamble + `cc_library {
Liz Kammer12615db2021-09-28 09:19:17 -04002060 name: "foo",
2061 srcs: ["foo.proto"],
2062 include_build_directory: false,
2063}`,
Sam Delmerico3177a6e2022-06-21 19:28:33 +00002064 ExpectedBazelTargets: []string{
Alixe06d75b2022-08-31 18:28:19 +00002065 MakeBazelTarget("proto_library", "foo_proto", AttrNameToString{
Liz Kammer7756c8f2022-02-14 20:49:15 -05002066 "srcs": `["foo.proto"]`,
Alixe06d75b2022-08-31 18:28:19 +00002067 }), MakeBazelTarget("cc_lite_proto_library", "foo_cc_proto_lite", AttrNameToString{
Liz Kammer12615db2021-09-28 09:19:17 -04002068 "deps": `[":foo_proto"]`,
Alixe06d75b2022-08-31 18:28:19 +00002069 }), MakeBazelTarget("cc_library_static", "foo_bp2build_cc_library_static", AttrNameToString{
Liz Kammer12615db2021-09-28 09:19:17 -04002070 "implementation_whole_archive_deps": `[":foo_cc_proto_lite"]`,
Chris Parsons77acf2e2021-12-03 17:27:16 -05002071 "deps": `[":libprotobuf-cpp-lite"]`,
Alixe06d75b2022-08-31 18:28:19 +00002072 }), MakeBazelTarget("cc_library_shared", "foo", AttrNameToString{
Liz Kammer84b0ecb2022-09-14 10:49:13 -04002073 "dynamic_deps": `[":libprotobuf-cpp-lite"]`,
2074 "implementation_whole_archive_deps": `[":foo_cc_proto_lite"]`,
Liz Kammer12615db2021-09-28 09:19:17 -04002075 }),
2076 },
2077 })
2078}
2079
2080func TestCcLibraryProtoNoCanonicalPathFromRoot(t *testing.T) {
Sam Delmerico3177a6e2022-06-21 19:28:33 +00002081 runCcLibraryTestCase(t, Bp2buildTestCase{
2082 ModuleTypeUnderTest: "cc_library",
2083 ModuleTypeUnderTestFactory: cc.LibraryFactory,
2084 Blueprint: soongCcProtoPreamble + `cc_library {
Liz Kammer12615db2021-09-28 09:19:17 -04002085 name: "foo",
2086 srcs: ["foo.proto"],
2087 proto: { canonical_path_from_root: false},
2088 include_build_directory: false,
2089}`,
Sam Delmerico3177a6e2022-06-21 19:28:33 +00002090 ExpectedBazelTargets: []string{
Alixe06d75b2022-08-31 18:28:19 +00002091 MakeBazelTarget("proto_library", "foo_proto", AttrNameToString{
Liz Kammer7756c8f2022-02-14 20:49:15 -05002092 "srcs": `["foo.proto"]`,
2093 "strip_import_prefix": `""`,
Alixe06d75b2022-08-31 18:28:19 +00002094 }), MakeBazelTarget("cc_lite_proto_library", "foo_cc_proto_lite", AttrNameToString{
Liz Kammer12615db2021-09-28 09:19:17 -04002095 "deps": `[":foo_proto"]`,
Alixe06d75b2022-08-31 18:28:19 +00002096 }), MakeBazelTarget("cc_library_static", "foo_bp2build_cc_library_static", AttrNameToString{
Liz Kammer12615db2021-09-28 09:19:17 -04002097 "implementation_whole_archive_deps": `[":foo_cc_proto_lite"]`,
Chris Parsons77acf2e2021-12-03 17:27:16 -05002098 "deps": `[":libprotobuf-cpp-lite"]`,
Alixe06d75b2022-08-31 18:28:19 +00002099 }), MakeBazelTarget("cc_library_shared", "foo", AttrNameToString{
Liz Kammer84b0ecb2022-09-14 10:49:13 -04002100 "dynamic_deps": `[":libprotobuf-cpp-lite"]`,
2101 "implementation_whole_archive_deps": `[":foo_cc_proto_lite"]`,
Liz Kammer12615db2021-09-28 09:19:17 -04002102 }),
2103 },
2104 })
2105}
2106
2107func TestCcLibraryProtoExplicitCanonicalPathFromRoot(t *testing.T) {
Sam Delmerico3177a6e2022-06-21 19:28:33 +00002108 runCcLibraryTestCase(t, Bp2buildTestCase{
2109 ModuleTypeUnderTest: "cc_library",
2110 ModuleTypeUnderTestFactory: cc.LibraryFactory,
2111 Blueprint: soongCcProtoPreamble + `cc_library {
Liz Kammer12615db2021-09-28 09:19:17 -04002112 name: "foo",
2113 srcs: ["foo.proto"],
2114 proto: { canonical_path_from_root: true},
2115 include_build_directory: false,
2116}`,
Sam Delmerico3177a6e2022-06-21 19:28:33 +00002117 ExpectedBazelTargets: []string{
Alixe06d75b2022-08-31 18:28:19 +00002118 MakeBazelTarget("proto_library", "foo_proto", AttrNameToString{
Liz Kammer7756c8f2022-02-14 20:49:15 -05002119 "srcs": `["foo.proto"]`,
Alixe06d75b2022-08-31 18:28:19 +00002120 }), MakeBazelTarget("cc_lite_proto_library", "foo_cc_proto_lite", AttrNameToString{
Liz Kammer12615db2021-09-28 09:19:17 -04002121 "deps": `[":foo_proto"]`,
Alixe06d75b2022-08-31 18:28:19 +00002122 }), MakeBazelTarget("cc_library_static", "foo_bp2build_cc_library_static", AttrNameToString{
Liz Kammer12615db2021-09-28 09:19:17 -04002123 "implementation_whole_archive_deps": `[":foo_cc_proto_lite"]`,
Chris Parsons77acf2e2021-12-03 17:27:16 -05002124 "deps": `[":libprotobuf-cpp-lite"]`,
Alixe06d75b2022-08-31 18:28:19 +00002125 }), MakeBazelTarget("cc_library_shared", "foo", AttrNameToString{
Liz Kammer84b0ecb2022-09-14 10:49:13 -04002126 "dynamic_deps": `[":libprotobuf-cpp-lite"]`,
2127 "implementation_whole_archive_deps": `[":foo_cc_proto_lite"]`,
Liz Kammer12615db2021-09-28 09:19:17 -04002128 }),
2129 },
2130 })
2131}
2132
2133func TestCcLibraryProtoFull(t *testing.T) {
Sam Delmerico3177a6e2022-06-21 19:28:33 +00002134 runCcLibraryTestCase(t, Bp2buildTestCase{
2135 ModuleTypeUnderTest: "cc_library",
2136 ModuleTypeUnderTestFactory: cc.LibraryFactory,
2137 Blueprint: soongCcProtoPreamble + `cc_library {
Liz Kammer12615db2021-09-28 09:19:17 -04002138 name: "foo",
2139 srcs: ["foo.proto"],
2140 proto: {
Liz Kammer12615db2021-09-28 09:19:17 -04002141 type: "full",
2142 },
2143 include_build_directory: false,
2144}`,
Sam Delmerico3177a6e2022-06-21 19:28:33 +00002145 ExpectedBazelTargets: []string{
Alixe06d75b2022-08-31 18:28:19 +00002146 MakeBazelTarget("proto_library", "foo_proto", AttrNameToString{
Liz Kammer12615db2021-09-28 09:19:17 -04002147 "srcs": `["foo.proto"]`,
Alixe06d75b2022-08-31 18:28:19 +00002148 }), MakeBazelTarget("cc_proto_library", "foo_cc_proto", AttrNameToString{
Liz Kammer12615db2021-09-28 09:19:17 -04002149 "deps": `[":foo_proto"]`,
Alixe06d75b2022-08-31 18:28:19 +00002150 }), MakeBazelTarget("cc_library_static", "foo_bp2build_cc_library_static", AttrNameToString{
Liz Kammer12615db2021-09-28 09:19:17 -04002151 "implementation_whole_archive_deps": `[":foo_cc_proto"]`,
Chris Parsons77acf2e2021-12-03 17:27:16 -05002152 "deps": `[":libprotobuf-cpp-full"]`,
Alixe06d75b2022-08-31 18:28:19 +00002153 }), MakeBazelTarget("cc_library_shared", "foo", AttrNameToString{
Liz Kammer84b0ecb2022-09-14 10:49:13 -04002154 "dynamic_deps": `[":libprotobuf-cpp-full"]`,
2155 "implementation_whole_archive_deps": `[":foo_cc_proto"]`,
Liz Kammer12615db2021-09-28 09:19:17 -04002156 }),
2157 },
2158 })
2159}
2160
2161func TestCcLibraryProtoLite(t *testing.T) {
Sam Delmerico3177a6e2022-06-21 19:28:33 +00002162 runCcLibraryTestCase(t, Bp2buildTestCase{
2163 ModuleTypeUnderTest: "cc_library",
2164 ModuleTypeUnderTestFactory: cc.LibraryFactory,
2165 Blueprint: soongCcProtoPreamble + `cc_library {
Liz Kammer12615db2021-09-28 09:19:17 -04002166 name: "foo",
2167 srcs: ["foo.proto"],
2168 proto: {
Liz Kammer12615db2021-09-28 09:19:17 -04002169 type: "lite",
2170 },
2171 include_build_directory: false,
2172}`,
Sam Delmerico3177a6e2022-06-21 19:28:33 +00002173 ExpectedBazelTargets: []string{
Alixe06d75b2022-08-31 18:28:19 +00002174 MakeBazelTarget("proto_library", "foo_proto", AttrNameToString{
Liz Kammer12615db2021-09-28 09:19:17 -04002175 "srcs": `["foo.proto"]`,
Alixe06d75b2022-08-31 18:28:19 +00002176 }), MakeBazelTarget("cc_lite_proto_library", "foo_cc_proto_lite", AttrNameToString{
Liz Kammer12615db2021-09-28 09:19:17 -04002177 "deps": `[":foo_proto"]`,
Alixe06d75b2022-08-31 18:28:19 +00002178 }), MakeBazelTarget("cc_library_static", "foo_bp2build_cc_library_static", AttrNameToString{
Liz Kammer12615db2021-09-28 09:19:17 -04002179 "implementation_whole_archive_deps": `[":foo_cc_proto_lite"]`,
Chris Parsons77acf2e2021-12-03 17:27:16 -05002180 "deps": `[":libprotobuf-cpp-lite"]`,
Alixe06d75b2022-08-31 18:28:19 +00002181 }), MakeBazelTarget("cc_library_shared", "foo", AttrNameToString{
Liz Kammer84b0ecb2022-09-14 10:49:13 -04002182 "dynamic_deps": `[":libprotobuf-cpp-lite"]`,
2183 "implementation_whole_archive_deps": `[":foo_cc_proto_lite"]`,
Liz Kammer12615db2021-09-28 09:19:17 -04002184 }),
2185 },
2186 })
2187}
2188
2189func TestCcLibraryProtoExportHeaders(t *testing.T) {
Sam Delmerico3177a6e2022-06-21 19:28:33 +00002190 runCcLibraryTestCase(t, Bp2buildTestCase{
2191 ModuleTypeUnderTest: "cc_library",
2192 ModuleTypeUnderTestFactory: cc.LibraryFactory,
2193 Blueprint: soongCcProtoPreamble + `cc_library {
Liz Kammer12615db2021-09-28 09:19:17 -04002194 name: "foo",
2195 srcs: ["foo.proto"],
2196 proto: {
Liz Kammer12615db2021-09-28 09:19:17 -04002197 export_proto_headers: true,
2198 },
2199 include_build_directory: false,
2200}`,
Sam Delmerico3177a6e2022-06-21 19:28:33 +00002201 ExpectedBazelTargets: []string{
Alixe06d75b2022-08-31 18:28:19 +00002202 MakeBazelTarget("proto_library", "foo_proto", AttrNameToString{
Liz Kammer12615db2021-09-28 09:19:17 -04002203 "srcs": `["foo.proto"]`,
Alixe06d75b2022-08-31 18:28:19 +00002204 }), MakeBazelTarget("cc_lite_proto_library", "foo_cc_proto_lite", AttrNameToString{
Liz Kammer12615db2021-09-28 09:19:17 -04002205 "deps": `[":foo_proto"]`,
Alixe06d75b2022-08-31 18:28:19 +00002206 }), MakeBazelTarget("cc_library_static", "foo_bp2build_cc_library_static", AttrNameToString{
Chris Parsons77acf2e2021-12-03 17:27:16 -05002207 "deps": `[":libprotobuf-cpp-lite"]`,
Liz Kammer12615db2021-09-28 09:19:17 -04002208 "whole_archive_deps": `[":foo_cc_proto_lite"]`,
Alixe06d75b2022-08-31 18:28:19 +00002209 }), MakeBazelTarget("cc_library_shared", "foo", AttrNameToString{
Chris Parsons77acf2e2021-12-03 17:27:16 -05002210 "dynamic_deps": `[":libprotobuf-cpp-lite"]`,
2211 "whole_archive_deps": `[":foo_cc_proto_lite"]`,
Liz Kammer12615db2021-09-28 09:19:17 -04002212 }),
2213 },
2214 })
2215}
Liz Kammeraabfb5d2021-12-08 15:25:06 -05002216
Yu Liu2d136142022-08-18 14:46:13 -07002217func TestCcLibraryProtoIncludeDirs(t *testing.T) {
2218 runCcLibraryTestCase(t, Bp2buildTestCase{
2219 ModuleTypeUnderTest: "cc_library",
2220 ModuleTypeUnderTestFactory: cc.LibraryFactory,
2221 Blueprint: soongCcProtoPreamble + `cc_library {
2222 name: "foo",
2223 srcs: ["foo.proto"],
2224 proto: {
2225 include_dirs: ["external/protobuf/src"],
2226 },
2227 include_build_directory: false,
2228}`,
2229 ExpectedBazelTargets: []string{
2230 MakeBazelTarget("proto_library", "foo_proto", AttrNameToString{
2231 "srcs": `["foo.proto"]`,
2232 "deps": `["//external/protobuf:libprotobuf-proto"]`,
2233 }), MakeBazelTarget("cc_lite_proto_library", "foo_cc_proto_lite", AttrNameToString{
2234 "deps": `[":foo_proto"]`,
2235 }), MakeBazelTarget("cc_library_static", "foo_bp2build_cc_library_static", AttrNameToString{
2236 "deps": `[":libprotobuf-cpp-lite"]`,
2237 "implementation_whole_archive_deps": `[":foo_cc_proto_lite"]`,
2238 }), MakeBazelTarget("cc_library_shared", "foo", AttrNameToString{
Liz Kammer84b0ecb2022-09-14 10:49:13 -04002239 "dynamic_deps": `[":libprotobuf-cpp-lite"]`,
2240 "implementation_whole_archive_deps": `[":foo_cc_proto_lite"]`,
Yu Liu2d136142022-08-18 14:46:13 -07002241 }),
2242 },
2243 })
2244}
2245
2246func TestCcLibraryProtoIncludeDirsUnknown(t *testing.T) {
2247 runCcLibraryTestCase(t, Bp2buildTestCase{
2248 ModuleTypeUnderTest: "cc_library",
2249 ModuleTypeUnderTestFactory: cc.LibraryFactory,
2250 Blueprint: soongCcProtoPreamble + `cc_library {
2251 name: "foo",
2252 srcs: ["foo.proto"],
2253 proto: {
2254 include_dirs: ["external/protobuf/abc"],
2255 },
2256 include_build_directory: false,
2257}`,
2258 ExpectedErr: fmt.Errorf("module \"foo\": Could not find the proto_library target for include dir: external/protobuf/abc"),
2259 })
2260}
2261
Yu Liu2aa806b2022-09-01 11:54:47 -07002262func TestCcLibraryConvertedProtoFilegroups(t *testing.T) {
2263 runCcLibraryTestCase(t, Bp2buildTestCase{
2264 ModuleTypeUnderTest: "cc_library",
2265 ModuleTypeUnderTestFactory: cc.LibraryFactory,
2266 Blueprint: soongCcProtoPreamble + `
2267filegroup {
2268 name: "a_fg_proto",
2269 srcs: ["a_fg.proto"],
2270}
2271
2272cc_library {
2273 name: "a",
2274 srcs: [
2275 ":a_fg_proto",
2276 "a.proto",
2277 ],
2278 proto: {
2279 export_proto_headers: true,
2280 },
2281 include_build_directory: false,
2282}`,
2283 ExpectedBazelTargets: []string{
2284 MakeBazelTarget("proto_library", "a_proto", AttrNameToString{
Yu Liu2a85fb12022-09-15 22:18:48 -07002285 "deps": `[":a_fg_proto_bp2build_converted"]`,
Yu Liu2aa806b2022-09-01 11:54:47 -07002286 "srcs": `["a.proto"]`,
2287 }), MakeBazelTarget("cc_lite_proto_library", "a_cc_proto_lite", AttrNameToString{
2288 "deps": `[
2289 ":a_fg_proto_bp2build_converted",
2290 ":a_proto",
2291 ]`,
2292 }), MakeBazelTarget("cc_library_static", "a_bp2build_cc_library_static", AttrNameToString{
2293 "deps": `[":libprotobuf-cpp-lite"]`,
2294 "whole_archive_deps": `[":a_cc_proto_lite"]`,
2295 }), MakeBazelTarget("cc_library_shared", "a", AttrNameToString{
2296 "dynamic_deps": `[":libprotobuf-cpp-lite"]`,
2297 "whole_archive_deps": `[":a_cc_proto_lite"]`,
2298 }), MakeBazelTargetNoRestrictions("proto_library", "a_fg_proto_bp2build_converted", AttrNameToString{
2299 "srcs": `["a_fg.proto"]`,
Yu Liu2a85fb12022-09-15 22:18:48 -07002300 "tags": `["manual"]`,
Yu Liu2aa806b2022-09-01 11:54:47 -07002301 }), MakeBazelTargetNoRestrictions("filegroup", "a_fg_proto", AttrNameToString{
2302 "srcs": `["a_fg.proto"]`,
2303 }),
2304 },
2305 })
2306}
2307
2308func TestCcLibraryConvertedProtoFilegroupsNoProtoFiles(t *testing.T) {
2309 runCcLibraryTestCase(t, Bp2buildTestCase{
2310 ModuleTypeUnderTest: "cc_library",
2311 ModuleTypeUnderTestFactory: cc.LibraryFactory,
2312 Blueprint: soongCcProtoPreamble + `
2313filegroup {
2314 name: "a_fg_proto",
2315 srcs: ["a_fg.proto"],
2316}
2317
2318cc_library {
2319 name: "a",
2320 srcs: [
2321 ":a_fg_proto",
2322 ],
2323 proto: {
2324 export_proto_headers: true,
2325 },
2326 include_build_directory: false,
2327}`,
2328 ExpectedBazelTargets: []string{
2329 MakeBazelTarget("cc_lite_proto_library", "a_cc_proto_lite", AttrNameToString{
2330 "deps": `[":a_fg_proto_bp2build_converted"]`,
2331 }), MakeBazelTarget("cc_library_static", "a_bp2build_cc_library_static", AttrNameToString{
2332 "deps": `[":libprotobuf-cpp-lite"]`,
2333 "whole_archive_deps": `[":a_cc_proto_lite"]`,
2334 }), MakeBazelTarget("cc_library_shared", "a", AttrNameToString{
2335 "dynamic_deps": `[":libprotobuf-cpp-lite"]`,
2336 "whole_archive_deps": `[":a_cc_proto_lite"]`,
2337 }), MakeBazelTargetNoRestrictions("proto_library", "a_fg_proto_bp2build_converted", AttrNameToString{
2338 "srcs": `["a_fg.proto"]`,
Yu Liu2a85fb12022-09-15 22:18:48 -07002339 "tags": `["manual"]`,
Yu Liu2aa806b2022-09-01 11:54:47 -07002340 }), MakeBazelTargetNoRestrictions("filegroup", "a_fg_proto", AttrNameToString{
2341 "srcs": `["a_fg.proto"]`,
2342 }),
2343 },
2344 })
2345}
2346
2347func TestCcLibraryExternalConvertedProtoFilegroups(t *testing.T) {
2348 runCcLibraryTestCase(t, Bp2buildTestCase{
2349 ModuleTypeUnderTest: "cc_library",
2350 ModuleTypeUnderTestFactory: cc.LibraryFactory,
2351 Filesystem: map[string]string{
2352 "path/to/A/Android.bp": `
2353filegroup {
2354 name: "a_fg_proto",
2355 srcs: ["a_fg.proto"],
2356}`,
2357 },
2358 Blueprint: soongCcProtoPreamble + `
2359cc_library {
2360 name: "a",
2361 srcs: [
2362 ":a_fg_proto",
2363 "a.proto",
2364 ],
2365 proto: {
2366 export_proto_headers: true,
2367 },
2368 include_build_directory: false,
2369}`,
2370 ExpectedBazelTargets: []string{
2371 MakeBazelTarget("proto_library", "a_proto", AttrNameToString{
Yu Liu2a85fb12022-09-15 22:18:48 -07002372 "deps": `["//path/to/A:a_fg_proto_bp2build_converted"]`,
Yu Liu2aa806b2022-09-01 11:54:47 -07002373 "srcs": `["a.proto"]`,
2374 }), MakeBazelTarget("cc_lite_proto_library", "a_cc_proto_lite", AttrNameToString{
2375 "deps": `[
2376 "//path/to/A:a_fg_proto_bp2build_converted",
2377 ":a_proto",
2378 ]`,
2379 }), MakeBazelTarget("cc_library_static", "a_bp2build_cc_library_static", AttrNameToString{
2380 "deps": `[":libprotobuf-cpp-lite"]`,
2381 "whole_archive_deps": `[":a_cc_proto_lite"]`,
2382 }), MakeBazelTarget("cc_library_shared", "a", AttrNameToString{
2383 "dynamic_deps": `[":libprotobuf-cpp-lite"]`,
2384 "whole_archive_deps": `[":a_cc_proto_lite"]`,
2385 }),
2386 },
2387 })
2388}
2389
Liz Kammeraabfb5d2021-12-08 15:25:06 -05002390func TestCcLibraryProtoFilegroups(t *testing.T) {
Sam Delmerico3177a6e2022-06-21 19:28:33 +00002391 runCcLibraryTestCase(t, Bp2buildTestCase{
2392 ModuleTypeUnderTest: "cc_library",
2393 ModuleTypeUnderTestFactory: cc.LibraryFactory,
2394 Blueprint: soongCcProtoPreamble +
Liz Kammeraabfb5d2021-12-08 15:25:06 -05002395 simpleModuleDoNotConvertBp2build("filegroup", "a_fg_proto") +
2396 simpleModuleDoNotConvertBp2build("filegroup", "b_protos") +
2397 simpleModuleDoNotConvertBp2build("filegroup", "c-proto-srcs") +
2398 simpleModuleDoNotConvertBp2build("filegroup", "proto-srcs-d") + `
2399cc_library {
2400 name: "a",
2401 srcs: [":a_fg_proto"],
2402 proto: {
Liz Kammeraabfb5d2021-12-08 15:25:06 -05002403 export_proto_headers: true,
2404 },
2405 include_build_directory: false,
2406}
2407
2408cc_library {
2409 name: "b",
2410 srcs: [":b_protos"],
2411 proto: {
Liz Kammeraabfb5d2021-12-08 15:25:06 -05002412 export_proto_headers: true,
2413 },
2414 include_build_directory: false,
2415}
2416
2417cc_library {
2418 name: "c",
2419 srcs: [":c-proto-srcs"],
2420 proto: {
Liz Kammeraabfb5d2021-12-08 15:25:06 -05002421 export_proto_headers: true,
2422 },
2423 include_build_directory: false,
2424}
2425
2426cc_library {
2427 name: "d",
2428 srcs: [":proto-srcs-d"],
2429 proto: {
Liz Kammeraabfb5d2021-12-08 15:25:06 -05002430 export_proto_headers: true,
2431 },
2432 include_build_directory: false,
2433}`,
Sam Delmerico3177a6e2022-06-21 19:28:33 +00002434 ExpectedBazelTargets: []string{
Alixe06d75b2022-08-31 18:28:19 +00002435 MakeBazelTarget("proto_library", "a_proto", AttrNameToString{
Liz Kammeraabfb5d2021-12-08 15:25:06 -05002436 "srcs": `[":a_fg_proto"]`,
Alixe06d75b2022-08-31 18:28:19 +00002437 }), MakeBazelTarget("cc_lite_proto_library", "a_cc_proto_lite", AttrNameToString{
Liz Kammeraabfb5d2021-12-08 15:25:06 -05002438 "deps": `[":a_proto"]`,
Alixe06d75b2022-08-31 18:28:19 +00002439 }), MakeBazelTarget("cc_library_static", "a_bp2build_cc_library_static", AttrNameToString{
Liz Kammeraabfb5d2021-12-08 15:25:06 -05002440 "deps": `[":libprotobuf-cpp-lite"]`,
2441 "whole_archive_deps": `[":a_cc_proto_lite"]`,
2442 "srcs": `[":a_fg_proto_cpp_srcs"]`,
2443 "srcs_as": `[":a_fg_proto_as_srcs"]`,
2444 "srcs_c": `[":a_fg_proto_c_srcs"]`,
Alixe06d75b2022-08-31 18:28:19 +00002445 }), MakeBazelTarget("cc_library_shared", "a", AttrNameToString{
Liz Kammeraabfb5d2021-12-08 15:25:06 -05002446 "dynamic_deps": `[":libprotobuf-cpp-lite"]`,
2447 "whole_archive_deps": `[":a_cc_proto_lite"]`,
2448 "srcs": `[":a_fg_proto_cpp_srcs"]`,
2449 "srcs_as": `[":a_fg_proto_as_srcs"]`,
2450 "srcs_c": `[":a_fg_proto_c_srcs"]`,
Alixe06d75b2022-08-31 18:28:19 +00002451 }), MakeBazelTarget("proto_library", "b_proto", AttrNameToString{
Liz Kammeraabfb5d2021-12-08 15:25:06 -05002452 "srcs": `[":b_protos"]`,
Alixe06d75b2022-08-31 18:28:19 +00002453 }), MakeBazelTarget("cc_lite_proto_library", "b_cc_proto_lite", AttrNameToString{
Liz Kammeraabfb5d2021-12-08 15:25:06 -05002454 "deps": `[":b_proto"]`,
Alixe06d75b2022-08-31 18:28:19 +00002455 }), MakeBazelTarget("cc_library_static", "b_bp2build_cc_library_static", AttrNameToString{
Liz Kammeraabfb5d2021-12-08 15:25:06 -05002456 "deps": `[":libprotobuf-cpp-lite"]`,
2457 "whole_archive_deps": `[":b_cc_proto_lite"]`,
2458 "srcs": `[":b_protos_cpp_srcs"]`,
2459 "srcs_as": `[":b_protos_as_srcs"]`,
2460 "srcs_c": `[":b_protos_c_srcs"]`,
Alixe06d75b2022-08-31 18:28:19 +00002461 }), MakeBazelTarget("cc_library_shared", "b", AttrNameToString{
Liz Kammeraabfb5d2021-12-08 15:25:06 -05002462 "dynamic_deps": `[":libprotobuf-cpp-lite"]`,
2463 "whole_archive_deps": `[":b_cc_proto_lite"]`,
2464 "srcs": `[":b_protos_cpp_srcs"]`,
2465 "srcs_as": `[":b_protos_as_srcs"]`,
2466 "srcs_c": `[":b_protos_c_srcs"]`,
Alixe06d75b2022-08-31 18:28:19 +00002467 }), MakeBazelTarget("proto_library", "c_proto", AttrNameToString{
Liz Kammeraabfb5d2021-12-08 15:25:06 -05002468 "srcs": `[":c-proto-srcs"]`,
Alixe06d75b2022-08-31 18:28:19 +00002469 }), MakeBazelTarget("cc_lite_proto_library", "c_cc_proto_lite", AttrNameToString{
Liz Kammeraabfb5d2021-12-08 15:25:06 -05002470 "deps": `[":c_proto"]`,
Alixe06d75b2022-08-31 18:28:19 +00002471 }), MakeBazelTarget("cc_library_static", "c_bp2build_cc_library_static", AttrNameToString{
Liz Kammeraabfb5d2021-12-08 15:25:06 -05002472 "deps": `[":libprotobuf-cpp-lite"]`,
2473 "whole_archive_deps": `[":c_cc_proto_lite"]`,
2474 "srcs": `[":c-proto-srcs_cpp_srcs"]`,
2475 "srcs_as": `[":c-proto-srcs_as_srcs"]`,
2476 "srcs_c": `[":c-proto-srcs_c_srcs"]`,
Alixe06d75b2022-08-31 18:28:19 +00002477 }), MakeBazelTarget("cc_library_shared", "c", AttrNameToString{
Liz Kammeraabfb5d2021-12-08 15:25:06 -05002478 "dynamic_deps": `[":libprotobuf-cpp-lite"]`,
2479 "whole_archive_deps": `[":c_cc_proto_lite"]`,
2480 "srcs": `[":c-proto-srcs_cpp_srcs"]`,
2481 "srcs_as": `[":c-proto-srcs_as_srcs"]`,
2482 "srcs_c": `[":c-proto-srcs_c_srcs"]`,
Alixe06d75b2022-08-31 18:28:19 +00002483 }), MakeBazelTarget("proto_library", "d_proto", AttrNameToString{
Liz Kammeraabfb5d2021-12-08 15:25:06 -05002484 "srcs": `[":proto-srcs-d"]`,
Alixe06d75b2022-08-31 18:28:19 +00002485 }), MakeBazelTarget("cc_lite_proto_library", "d_cc_proto_lite", AttrNameToString{
Liz Kammeraabfb5d2021-12-08 15:25:06 -05002486 "deps": `[":d_proto"]`,
Alixe06d75b2022-08-31 18:28:19 +00002487 }), MakeBazelTarget("cc_library_static", "d_bp2build_cc_library_static", AttrNameToString{
Liz Kammeraabfb5d2021-12-08 15:25:06 -05002488 "deps": `[":libprotobuf-cpp-lite"]`,
2489 "whole_archive_deps": `[":d_cc_proto_lite"]`,
2490 "srcs": `[":proto-srcs-d_cpp_srcs"]`,
2491 "srcs_as": `[":proto-srcs-d_as_srcs"]`,
2492 "srcs_c": `[":proto-srcs-d_c_srcs"]`,
Alixe06d75b2022-08-31 18:28:19 +00002493 }), MakeBazelTarget("cc_library_shared", "d", AttrNameToString{
Liz Kammeraabfb5d2021-12-08 15:25:06 -05002494 "dynamic_deps": `[":libprotobuf-cpp-lite"]`,
2495 "whole_archive_deps": `[":d_cc_proto_lite"]`,
2496 "srcs": `[":proto-srcs-d_cpp_srcs"]`,
2497 "srcs_as": `[":proto-srcs-d_as_srcs"]`,
2498 "srcs_c": `[":proto-srcs-d_c_srcs"]`,
2499 }),
2500 },
2501 })
2502}
Chris Parsons58852a02021-12-09 18:10:18 -05002503
2504func TestCcLibraryDisabledArchAndTarget(t *testing.T) {
Sam Delmerico3177a6e2022-06-21 19:28:33 +00002505 runCcLibraryTestCase(t, Bp2buildTestCase{
2506 ModuleTypeUnderTest: "cc_library",
2507 ModuleTypeUnderTestFactory: cc.LibraryFactory,
2508 Blueprint: soongCcProtoPreamble + `cc_library {
Chris Parsons58852a02021-12-09 18:10:18 -05002509 name: "foo",
2510 srcs: ["foo.cpp"],
Liz Kammerdfeb1202022-05-13 17:20:20 -04002511 host_supported: true,
Chris Parsons58852a02021-12-09 18:10:18 -05002512 target: {
2513 darwin: {
2514 enabled: false,
2515 },
2516 windows: {
2517 enabled: false,
2518 },
2519 linux_glibc_x86: {
2520 enabled: false,
2521 },
2522 },
2523 include_build_directory: false,
2524}`,
Sam Delmerico3177a6e2022-06-21 19:28:33 +00002525 ExpectedBazelTargets: makeCcLibraryTargets("foo", AttrNameToString{
Chris Parsons58852a02021-12-09 18:10:18 -05002526 "srcs": `["foo.cpp"]`,
2527 "target_compatible_with": `select({
2528 "//build/bazel/platforms/os_arch:darwin_arm64": ["@platforms//:incompatible"],
2529 "//build/bazel/platforms/os_arch:darwin_x86_64": ["@platforms//:incompatible"],
2530 "//build/bazel/platforms/os_arch:linux_glibc_x86": ["@platforms//:incompatible"],
2531 "//build/bazel/platforms/os_arch:windows_x86": ["@platforms//:incompatible"],
2532 "//build/bazel/platforms/os_arch:windows_x86_64": ["@platforms//:incompatible"],
2533 "//conditions:default": [],
2534 })`,
2535 }),
2536 })
2537}
2538
2539func TestCcLibraryDisabledArchAndTargetWithDefault(t *testing.T) {
Sam Delmerico3177a6e2022-06-21 19:28:33 +00002540 runCcLibraryTestCase(t, Bp2buildTestCase{
2541 ModuleTypeUnderTest: "cc_library",
2542 ModuleTypeUnderTestFactory: cc.LibraryFactory,
2543 Blueprint: soongCcProtoPreamble + `cc_library {
Chris Parsons58852a02021-12-09 18:10:18 -05002544 name: "foo",
2545 srcs: ["foo.cpp"],
2546 enabled: false,
Liz Kammerdfeb1202022-05-13 17:20:20 -04002547 host_supported: true,
Chris Parsons58852a02021-12-09 18:10:18 -05002548 target: {
2549 darwin: {
2550 enabled: true,
2551 },
2552 windows: {
2553 enabled: false,
2554 },
2555 linux_glibc_x86: {
2556 enabled: false,
2557 },
2558 },
2559 include_build_directory: false,
2560}`,
Sam Delmerico3177a6e2022-06-21 19:28:33 +00002561 ExpectedBazelTargets: makeCcLibraryTargets("foo", AttrNameToString{
Chris Parsons58852a02021-12-09 18:10:18 -05002562 "srcs": `["foo.cpp"]`,
2563 "target_compatible_with": `select({
2564 "//build/bazel/platforms/os_arch:darwin_arm64": [],
2565 "//build/bazel/platforms/os_arch:darwin_x86_64": [],
2566 "//conditions:default": ["@platforms//:incompatible"],
2567 })`,
2568 }),
2569 })
2570}
2571
2572func TestCcLibrarySharedDisabled(t *testing.T) {
Sam Delmerico3177a6e2022-06-21 19:28:33 +00002573 runCcLibraryTestCase(t, Bp2buildTestCase{
2574 ModuleTypeUnderTest: "cc_library",
2575 ModuleTypeUnderTestFactory: cc.LibraryFactory,
2576 Blueprint: soongCcProtoPreamble + `cc_library {
Chris Parsons58852a02021-12-09 18:10:18 -05002577 name: "foo",
2578 srcs: ["foo.cpp"],
2579 enabled: false,
2580 shared: {
2581 enabled: true,
2582 },
2583 target: {
2584 android: {
2585 shared: {
2586 enabled: false,
2587 },
2588 }
2589 },
2590 include_build_directory: false,
2591}`,
Alixe06d75b2022-08-31 18:28:19 +00002592 ExpectedBazelTargets: []string{MakeBazelTarget("cc_library_static", "foo_bp2build_cc_library_static", AttrNameToString{
Chris Parsons58852a02021-12-09 18:10:18 -05002593 "srcs": `["foo.cpp"]`,
2594 "target_compatible_with": `["@platforms//:incompatible"]`,
Alixe06d75b2022-08-31 18:28:19 +00002595 }), MakeBazelTarget("cc_library_shared", "foo", AttrNameToString{
Chris Parsons58852a02021-12-09 18:10:18 -05002596 "srcs": `["foo.cpp"]`,
2597 "target_compatible_with": `select({
2598 "//build/bazel/platforms/os:android": ["@platforms//:incompatible"],
2599 "//conditions:default": [],
2600 })`,
2601 }),
2602 },
2603 })
2604}
2605
2606func TestCcLibraryStaticDisabledForSomeArch(t *testing.T) {
Sam Delmerico3177a6e2022-06-21 19:28:33 +00002607 runCcLibraryTestCase(t, Bp2buildTestCase{
2608 ModuleTypeUnderTest: "cc_library",
2609 ModuleTypeUnderTestFactory: cc.LibraryFactory,
2610 Blueprint: soongCcProtoPreamble + `cc_library {
Chris Parsons58852a02021-12-09 18:10:18 -05002611 name: "foo",
Liz Kammerdfeb1202022-05-13 17:20:20 -04002612 host_supported: true,
Chris Parsons58852a02021-12-09 18:10:18 -05002613 srcs: ["foo.cpp"],
2614 shared: {
2615 enabled: false
2616 },
2617 target: {
2618 darwin: {
2619 enabled: true,
2620 },
2621 windows: {
2622 enabled: false,
2623 },
2624 linux_glibc_x86: {
2625 shared: {
2626 enabled: true,
2627 },
2628 },
2629 },
2630 include_build_directory: false,
2631}`,
Alixe06d75b2022-08-31 18:28:19 +00002632 ExpectedBazelTargets: []string{MakeBazelTarget("cc_library_static", "foo_bp2build_cc_library_static", AttrNameToString{
Chris Parsons58852a02021-12-09 18:10:18 -05002633 "srcs": `["foo.cpp"]`,
2634 "target_compatible_with": `select({
2635 "//build/bazel/platforms/os:windows": ["@platforms//:incompatible"],
2636 "//conditions:default": [],
2637 })`,
Alixe06d75b2022-08-31 18:28:19 +00002638 }), MakeBazelTarget("cc_library_shared", "foo", AttrNameToString{
Chris Parsons58852a02021-12-09 18:10:18 -05002639 "srcs": `["foo.cpp"]`,
2640 "target_compatible_with": `select({
2641 "//build/bazel/platforms/os_arch:darwin_arm64": [],
2642 "//build/bazel/platforms/os_arch:darwin_x86_64": [],
2643 "//build/bazel/platforms/os_arch:linux_glibc_x86": [],
2644 "//conditions:default": ["@platforms//:incompatible"],
2645 })`,
2646 }),
2647 }})
2648}
Jingwen Chen0ee88a62022-01-07 14:55:29 +00002649
2650func TestCcLibraryStubs(t *testing.T) {
Wei Li81852ca2022-07-27 00:22:06 -07002651 expectedBazelTargets := makeCcLibraryTargets("a", AttrNameToString{
2652 "has_stubs": `True`,
2653 })
2654 expectedBazelTargets = append(expectedBazelTargets, makeCcStubSuiteTargets("a", AttrNameToString{
2655 "soname": `"a.so"`,
2656 "source_library": `":a"`,
2657 "stubs_symbol_file": `"a.map.txt"`,
2658 "stubs_versions": `[
2659 "28",
2660 "29",
2661 "current",
2662 ]`,
2663 }))
Sam Delmerico3177a6e2022-06-21 19:28:33 +00002664 runCcLibraryTestCase(t, Bp2buildTestCase{
2665 Description: "cc_library stubs",
2666 ModuleTypeUnderTest: "cc_library",
2667 ModuleTypeUnderTestFactory: cc.LibraryFactory,
2668 Dir: "foo/bar",
2669 Filesystem: map[string]string{
Jingwen Chen0ee88a62022-01-07 14:55:29 +00002670 "foo/bar/Android.bp": `
2671cc_library {
2672 name: "a",
2673 stubs: { symbol_file: "a.map.txt", versions: ["28", "29", "current"] },
2674 bazel_module: { bp2build_available: true },
2675 include_build_directory: false,
2676}
2677`,
2678 },
Wei Li81852ca2022-07-27 00:22:06 -07002679 Blueprint: soongCcLibraryPreamble,
2680 ExpectedBazelTargets: expectedBazelTargets,
Jingwen Chen0ee88a62022-01-07 14:55:29 +00002681 },
2682 )
2683}
Liz Kammerf38a8372022-02-04 15:39:00 -05002684
Trevor Radcliffe0ed6b7d2022-09-12 20:19:26 +00002685func TestCcLibraryStubsAcrossConfigsDuplicatesRemoved(t *testing.T) {
2686 runCcLibraryTestCase(t, Bp2buildTestCase{
2687 Description: "stub target generation of the same lib across configs should not result in duplicates",
2688 ModuleTypeUnderTest: "cc_library",
2689 ModuleTypeUnderTestFactory: cc.LibraryFactory,
2690 Filesystem: map[string]string{
2691 "bar.map.txt": "",
2692 },
2693 Blueprint: `
2694cc_library {
2695 name: "barlib",
2696 stubs: { symbol_file: "bar.map.txt", versions: ["28", "29", "current"] },
2697 bazel_module: { bp2build_available: false },
2698}
2699cc_library {
2700 name: "foolib",
2701 shared_libs: ["barlib"],
2702 target: {
2703 android: {
2704 shared_libs: ["barlib"],
2705 },
2706 },
2707 bazel_module: { bp2build_available: true },
2708}`,
2709 ExpectedBazelTargets: makeCcLibraryTargets("foolib", AttrNameToString{
2710 "implementation_dynamic_deps": `select({
2711 "//build/bazel/rules/apex:android-in_apex": [":barlib_stub_libs_current"],
2712 "//conditions:default": [":barlib"],
2713 })`,
2714 "local_includes": `["."]`,
2715 }),
2716 })
2717}
2718
Liz Kammerf38a8372022-02-04 15:39:00 -05002719func TestCcLibraryEscapeLdflags(t *testing.T) {
Sam Delmerico3177a6e2022-06-21 19:28:33 +00002720 runCcLibraryTestCase(t, Bp2buildTestCase{
2721 ModuleTypeUnderTest: "cc_library",
2722 ModuleTypeUnderTestFactory: cc.LibraryFactory,
2723 Blueprint: soongCcProtoPreamble + `cc_library {
Liz Kammerf38a8372022-02-04 15:39:00 -05002724 name: "foo",
2725 ldflags: ["-Wl,--rpath,${ORIGIN}"],
2726 include_build_directory: false,
2727}`,
Sam Delmerico3177a6e2022-06-21 19:28:33 +00002728 ExpectedBazelTargets: makeCcLibraryTargets("foo", AttrNameToString{
Liz Kammerf38a8372022-02-04 15:39:00 -05002729 "linkopts": `["-Wl,--rpath,$${ORIGIN}"]`,
2730 }),
2731 })
2732}
Trevor Radcliffeef9c9002022-05-13 20:55:35 +00002733
2734func TestCcLibraryConvertLex(t *testing.T) {
Sam Delmerico3177a6e2022-06-21 19:28:33 +00002735 runCcLibraryTestCase(t, Bp2buildTestCase{
2736 ModuleTypeUnderTest: "cc_library",
2737 ModuleTypeUnderTestFactory: cc.LibraryFactory,
2738 Filesystem: map[string]string{
Trevor Radcliffeef9c9002022-05-13 20:55:35 +00002739 "foo.c": "",
2740 "bar.cc": "",
2741 "foo1.l": "",
2742 "bar1.ll": "",
2743 "foo2.l": "",
2744 "bar2.ll": "",
2745 },
Sam Delmerico3177a6e2022-06-21 19:28:33 +00002746 Blueprint: `cc_library {
Trevor Radcliffeef9c9002022-05-13 20:55:35 +00002747 name: "foo_lib",
2748 srcs: ["foo.c", "bar.cc", "foo1.l", "foo2.l", "bar1.ll", "bar2.ll"],
2749 lex: { flags: ["--foo_flags"] },
2750 include_build_directory: false,
2751 bazel_module: { bp2build_available: true },
2752}`,
Sam Delmerico3177a6e2022-06-21 19:28:33 +00002753 ExpectedBazelTargets: append([]string{
Alixe06d75b2022-08-31 18:28:19 +00002754 MakeBazelTarget("genlex", "foo_lib_genlex_l", AttrNameToString{
Trevor Radcliffeef9c9002022-05-13 20:55:35 +00002755 "srcs": `[
2756 "foo1.l",
2757 "foo2.l",
2758 ]`,
2759 "lexopts": `["--foo_flags"]`,
2760 }),
Alixe06d75b2022-08-31 18:28:19 +00002761 MakeBazelTarget("genlex", "foo_lib_genlex_ll", AttrNameToString{
Trevor Radcliffeef9c9002022-05-13 20:55:35 +00002762 "srcs": `[
2763 "bar1.ll",
2764 "bar2.ll",
2765 ]`,
2766 "lexopts": `["--foo_flags"]`,
2767 }),
2768 },
Sam Delmerico3177a6e2022-06-21 19:28:33 +00002769 makeCcLibraryTargets("foo_lib", AttrNameToString{
Trevor Radcliffeef9c9002022-05-13 20:55:35 +00002770 "srcs": `[
2771 "bar.cc",
2772 ":foo_lib_genlex_ll",
2773 ]`,
2774 "srcs_c": `[
2775 "foo.c",
2776 ":foo_lib_genlex_l",
2777 ]`,
2778 })...),
2779 })
2780}
Cole Faust6b29f592022-08-09 09:50:56 -07002781
2782func TestCCLibraryRuntimeDeps(t *testing.T) {
2783 runCcLibrarySharedTestCase(t, Bp2buildTestCase{
2784 Blueprint: `cc_library_shared {
2785 name: "bar",
2786}
2787
2788cc_library {
2789 name: "foo",
2790 runtime_libs: ["foo"],
2791}`,
2792 ExpectedBazelTargets: []string{
Alixe06d75b2022-08-31 18:28:19 +00002793 MakeBazelTarget("cc_library_shared", "bar", AttrNameToString{
Cole Faust6b29f592022-08-09 09:50:56 -07002794 "local_includes": `["."]`,
2795 }),
Alixe06d75b2022-08-31 18:28:19 +00002796 MakeBazelTarget("cc_library_static", "foo_bp2build_cc_library_static", AttrNameToString{
Cole Faust6b29f592022-08-09 09:50:56 -07002797 "runtime_deps": `[":foo"]`,
2798 "local_includes": `["."]`,
2799 }),
Alixe06d75b2022-08-31 18:28:19 +00002800 MakeBazelTarget("cc_library_shared", "foo", AttrNameToString{
Cole Faust6b29f592022-08-09 09:50:56 -07002801 "runtime_deps": `[":foo"]`,
2802 "local_includes": `["."]`,
2803 }),
2804 },
2805 })
2806}
Cole Faust5fa4e962022-08-22 14:31:04 -07002807
2808func TestCcLibraryWithInstructionSet(t *testing.T) {
2809 runCcLibraryTestCase(t, Bp2buildTestCase{
2810 ModuleTypeUnderTest: "cc_library",
2811 ModuleTypeUnderTestFactory: cc.LibraryFactory,
2812 Blueprint: `cc_library {
2813 name: "foo",
2814 arch: {
2815 arm: {
2816 instruction_set: "arm",
2817 }
2818 }
2819}
2820`,
2821 ExpectedBazelTargets: makeCcLibraryTargets("foo", AttrNameToString{
2822 "features": `select({
2823 "//build/bazel/platforms/arch:arm": [
2824 "arm_isa_arm",
2825 "-arm_isa_thumb",
2826 ],
2827 "//conditions:default": [],
2828 })`,
2829 "local_includes": `["."]`,
2830 }),
2831 })
2832}
Vinh Tran9f6796a2022-08-16 13:10:31 -04002833
Alex Márquez Pérez Muñíz Díaz Púras Thaureauxa56e9702022-02-23 18:39:59 -05002834func TestCcLibraryEmptySuffix(t *testing.T) {
2835 runCcLibraryTestCase(t, Bp2buildTestCase{
2836 Description: "cc_library with empty suffix",
2837 ModuleTypeUnderTest: "cc_library",
2838 ModuleTypeUnderTestFactory: cc.LibraryFactory,
2839 Filesystem: map[string]string{
2840 "foo.c": "",
2841 },
2842 Blueprint: `cc_library {
2843 name: "foo",
2844 suffix: "",
2845 srcs: ["foo.c"],
2846 include_build_directory: false,
2847}`,
2848 ExpectedBazelTargets: []string{
Alixe06d75b2022-08-31 18:28:19 +00002849 MakeBazelTarget("cc_library_static", "foo_bp2build_cc_library_static", AttrNameToString{
Alex Márquez Pérez Muñíz Díaz Púras Thaureauxa56e9702022-02-23 18:39:59 -05002850 "srcs_c": `["foo.c"]`,
2851 }),
Alixe06d75b2022-08-31 18:28:19 +00002852 MakeBazelTarget("cc_library_shared", "foo", AttrNameToString{
Alex Márquez Pérez Muñíz Díaz Púras Thaureauxa56e9702022-02-23 18:39:59 -05002853 "srcs_c": `["foo.c"]`,
2854 "suffix": `""`,
2855 }),
2856 },
2857 })
2858}
2859
2860func TestCcLibrarySuffix(t *testing.T) {
2861 runCcLibraryTestCase(t, Bp2buildTestCase{
2862 Description: "cc_library with suffix",
2863 ModuleTypeUnderTest: "cc_library",
2864 ModuleTypeUnderTestFactory: cc.LibraryFactory,
2865 Filesystem: map[string]string{
2866 "foo.c": "",
2867 },
2868 Blueprint: `cc_library {
2869 name: "foo",
2870 suffix: "-suf",
2871 srcs: ["foo.c"],
2872 include_build_directory: false,
2873}`,
2874 ExpectedBazelTargets: []string{
Alixe06d75b2022-08-31 18:28:19 +00002875 MakeBazelTarget("cc_library_static", "foo_bp2build_cc_library_static", AttrNameToString{
Alex Márquez Pérez Muñíz Díaz Púras Thaureauxa56e9702022-02-23 18:39:59 -05002876 "srcs_c": `["foo.c"]`,
2877 }),
Alixe06d75b2022-08-31 18:28:19 +00002878 MakeBazelTarget("cc_library_shared", "foo", AttrNameToString{
Alex Márquez Pérez Muñíz Díaz Púras Thaureauxa56e9702022-02-23 18:39:59 -05002879 "srcs_c": `["foo.c"]`,
2880 "suffix": `"-suf"`,
2881 }),
2882 },
2883 })
2884}
2885
2886func TestCcLibraryArchVariantSuffix(t *testing.T) {
2887 runCcLibraryTestCase(t, Bp2buildTestCase{
2888 Description: "cc_library with arch-variant suffix",
2889 ModuleTypeUnderTest: "cc_library",
2890 ModuleTypeUnderTestFactory: cc.LibraryFactory,
2891 Filesystem: map[string]string{
2892 "foo.c": "",
2893 },
2894 Blueprint: `cc_library {
2895 name: "foo",
2896 arch: {
2897 arm64: { suffix: "-64" },
2898 arm: { suffix: "-32" },
2899 },
2900 srcs: ["foo.c"],
2901 include_build_directory: false,
2902}`,
2903 ExpectedBazelTargets: []string{
Alixe06d75b2022-08-31 18:28:19 +00002904 MakeBazelTarget("cc_library_static", "foo_bp2build_cc_library_static", AttrNameToString{
Alex Márquez Pérez Muñíz Díaz Púras Thaureauxa56e9702022-02-23 18:39:59 -05002905 "srcs_c": `["foo.c"]`,
2906 }),
Alixe06d75b2022-08-31 18:28:19 +00002907 MakeBazelTarget("cc_library_shared", "foo", AttrNameToString{
Alex Márquez Pérez Muñíz Díaz Púras Thaureauxa56e9702022-02-23 18:39:59 -05002908 "srcs_c": `["foo.c"]`,
2909 "suffix": `select({
2910 "//build/bazel/platforms/arch:arm": "-32",
2911 "//build/bazel/platforms/arch:arm64": "-64",
2912 "//conditions:default": None,
2913 })`,
2914 }),
2915 },
2916 })
2917}
2918
Vinh Tran9f6796a2022-08-16 13:10:31 -04002919func TestCcLibraryWithAidlSrcs(t *testing.T) {
2920 runCcLibraryTestCase(t, Bp2buildTestCase{
2921 Description: "cc_library with aidl srcs",
2922 ModuleTypeUnderTest: "cc_library",
2923 ModuleTypeUnderTestFactory: cc.LibraryFactory,
2924 Blueprint: `
2925filegroup {
2926 name: "A_aidl",
2927 srcs: ["aidl/A.aidl"],
2928 path: "aidl",
2929}
2930cc_library {
2931 name: "foo",
2932 srcs: [
2933 ":A_aidl",
2934 "B.aidl",
2935 ],
2936}`,
2937 ExpectedBazelTargets: []string{
2938 MakeBazelTargetNoRestrictions("aidl_library", "A_aidl", AttrNameToString{
2939 "srcs": `["aidl/A.aidl"]`,
2940 "strip_import_prefix": `"aidl"`,
2941 }),
Alixe06d75b2022-08-31 18:28:19 +00002942 MakeBazelTarget("aidl_library", "foo_aidl_library", AttrNameToString{
Vinh Tran9f6796a2022-08-16 13:10:31 -04002943 "srcs": `["B.aidl"]`,
2944 }),
Alixe06d75b2022-08-31 18:28:19 +00002945 MakeBazelTarget("cc_aidl_library", "foo_cc_aidl_library", AttrNameToString{
Vinh Tran9f6796a2022-08-16 13:10:31 -04002946 "deps": `[
2947 ":A_aidl",
2948 ":foo_aidl_library",
2949 ]`,
2950 }),
Alixe06d75b2022-08-31 18:28:19 +00002951 MakeBazelTarget("cc_library_static", "foo_bp2build_cc_library_static", AttrNameToString{
Vinh Tranfde57eb2022-08-29 17:46:58 -04002952 "implementation_whole_archive_deps": `[":foo_cc_aidl_library"]`,
2953 "local_includes": `["."]`,
Vinh Tran9f6796a2022-08-16 13:10:31 -04002954 }),
Alixe06d75b2022-08-31 18:28:19 +00002955 MakeBazelTarget("cc_library_shared", "foo", AttrNameToString{
Liz Kammer84b0ecb2022-09-14 10:49:13 -04002956 "implementation_whole_archive_deps": `[":foo_cc_aidl_library"]`,
2957 "local_includes": `["."]`,
Vinh Tran9f6796a2022-08-16 13:10:31 -04002958 }),
2959 },
2960 })
2961}
2962
2963func TestCcLibraryWithNonAdjacentAidlFilegroup(t *testing.T) {
2964 runCcLibraryTestCase(t, Bp2buildTestCase{
2965 Description: "cc_library with non aidl filegroup",
2966 ModuleTypeUnderTest: "cc_library",
2967 ModuleTypeUnderTestFactory: cc.LibraryFactory,
2968 Filesystem: map[string]string{
2969 "path/to/A/Android.bp": `
2970filegroup {
Vinh Tranfde57eb2022-08-29 17:46:58 -04002971 name: "A_aidl",
2972 srcs: ["aidl/A.aidl"],
2973 path: "aidl",
Vinh Tran9f6796a2022-08-16 13:10:31 -04002974}`,
2975 },
2976 Blueprint: `
2977cc_library {
Vinh Tranfde57eb2022-08-29 17:46:58 -04002978 name: "foo",
2979 srcs: [
2980 ":A_aidl",
2981 ],
Vinh Tran9f6796a2022-08-16 13:10:31 -04002982}`,
2983 ExpectedBazelTargets: []string{
Alixe06d75b2022-08-31 18:28:19 +00002984 MakeBazelTarget("cc_aidl_library", "foo_cc_aidl_library", AttrNameToString{
Vinh Tran9f6796a2022-08-16 13:10:31 -04002985 "deps": `["//path/to/A:A_aidl"]`,
2986 }),
Alixe06d75b2022-08-31 18:28:19 +00002987 MakeBazelTarget("cc_library_static", "foo_bp2build_cc_library_static", AttrNameToString{
Vinh Tranfde57eb2022-08-29 17:46:58 -04002988 "implementation_whole_archive_deps": `[":foo_cc_aidl_library"]`,
2989 "local_includes": `["."]`,
2990 }),
Vinh Tranfde57eb2022-08-29 17:46:58 -04002991 MakeBazelTarget("cc_library_shared", "foo", AttrNameToString{
Liz Kammer84b0ecb2022-09-14 10:49:13 -04002992 "local_includes": `["."]`,
2993 "implementation_whole_archive_deps": `[":foo_cc_aidl_library"]`,
Vinh Tranfde57eb2022-08-29 17:46:58 -04002994 }),
2995 },
2996 })
2997}
2998
2999func TestCcLibraryWithExportAidlHeaders(t *testing.T) {
3000 runCcLibraryTestCase(t, Bp2buildTestCase{
3001 Description: "cc_library with export aidl headers",
3002 ModuleTypeUnderTest: "cc_library",
3003 ModuleTypeUnderTestFactory: cc.LibraryFactory,
3004 Blueprint: `
3005cc_library {
3006 name: "foo",
3007 srcs: [
3008 "Foo.aidl",
3009 ],
3010 aidl: {
3011 export_aidl_headers: true,
3012 }
3013}`,
3014 ExpectedBazelTargets: []string{
3015 MakeBazelTarget("aidl_library", "foo_aidl_library", AttrNameToString{
3016 "srcs": `["Foo.aidl"]`,
3017 }),
3018 MakeBazelTarget("cc_aidl_library", "foo_cc_aidl_library", AttrNameToString{
3019 "deps": `[":foo_aidl_library"]`,
3020 }),
3021 MakeBazelTarget("cc_library_static", "foo_bp2build_cc_library_static", AttrNameToString{
Vinh Tran9f6796a2022-08-16 13:10:31 -04003022 "whole_archive_deps": `[":foo_cc_aidl_library"]`,
3023 "local_includes": `["."]`,
3024 }),
Alixe06d75b2022-08-31 18:28:19 +00003025 MakeBazelTarget("cc_library_shared", "foo", AttrNameToString{
Vinh Tran9f6796a2022-08-16 13:10:31 -04003026 "whole_archive_deps": `[":foo_cc_aidl_library"]`,
3027 "local_includes": `["."]`,
3028 }),
3029 },
3030 })
3031}
Vinh Tran85fb07c2022-09-16 16:17:48 -04003032
3033func TestCcLibraryWithTargetApex(t *testing.T) {
3034 runCcLibraryTestCase(t, Bp2buildTestCase{
3035 Description: "cc_library with target.apex",
3036 ModuleTypeUnderTest: "cc_library",
3037 ModuleTypeUnderTestFactory: cc.LibraryFactory,
3038 Blueprint: `
3039cc_library {
3040 name: "foo",
3041 shared_libs: ["bar", "baz"],
3042 static_libs: ["baz", "buh"],
3043 target: {
3044 apex: {
3045 exclude_shared_libs: ["bar"],
3046 exclude_static_libs: ["buh"],
3047 }
3048 }
3049}`,
3050 ExpectedBazelTargets: []string{
3051 MakeBazelTarget("cc_library_static", "foo_bp2build_cc_library_static", AttrNameToString{
3052 "implementation_deps": `[":baz__BP2BUILD__MISSING__DEP"] + select({
3053 "//build/bazel/rules/apex:non_apex": [":buh__BP2BUILD__MISSING__DEP"],
3054 "//conditions:default": [],
3055 })`,
3056 "implementation_dynamic_deps": `[":baz__BP2BUILD__MISSING__DEP"] + select({
3057 "//build/bazel/rules/apex:non_apex": [":bar__BP2BUILD__MISSING__DEP"],
3058 "//conditions:default": [],
3059 })`,
3060 "local_includes": `["."]`,
3061 }),
3062 MakeBazelTarget("cc_library_shared", "foo", AttrNameToString{
3063 "implementation_deps": `[":baz__BP2BUILD__MISSING__DEP"] + select({
3064 "//build/bazel/rules/apex:non_apex": [":buh__BP2BUILD__MISSING__DEP"],
3065 "//conditions:default": [],
3066 })`,
3067 "implementation_dynamic_deps": `[":baz__BP2BUILD__MISSING__DEP"] + select({
3068 "//build/bazel/rules/apex:non_apex": [":bar__BP2BUILD__MISSING__DEP"],
3069 "//conditions:default": [],
3070 })`,
3071 "local_includes": `["."]`,
3072 }),
3073 },
3074 })
3075}
3076
3077func TestCcLibraryWithTargetApexAndExportLibHeaders(t *testing.T) {
3078 runCcLibraryTestCase(t, Bp2buildTestCase{
3079 Description: "cc_library with target.apex and export_shared|static_lib_headers",
3080 ModuleTypeUnderTest: "cc_library",
3081 ModuleTypeUnderTestFactory: cc.LibraryFactory,
3082 Blueprint: `
3083cc_library_static {
3084 name: "foo",
3085 shared_libs: ["bar", "baz"],
3086 static_libs: ["abc"],
3087 export_shared_lib_headers: ["baz"],
3088 export_static_lib_headers: ["abc"],
3089 target: {
3090 apex: {
3091 exclude_shared_libs: ["baz", "bar"],
3092 exclude_static_libs: ["abc"],
3093 }
3094 }
3095}`,
3096 ExpectedBazelTargets: []string{
3097 MakeBazelTarget("cc_library_static", "foo", AttrNameToString{
3098 "implementation_dynamic_deps": `select({
3099 "//build/bazel/rules/apex:non_apex": [":bar__BP2BUILD__MISSING__DEP"],
3100 "//conditions:default": [],
3101 })`,
3102 "dynamic_deps": `select({
3103 "//build/bazel/rules/apex:non_apex": [":baz__BP2BUILD__MISSING__DEP"],
3104 "//conditions:default": [],
3105 })`,
3106 "deps": `select({
3107 "//build/bazel/rules/apex:non_apex": [":abc__BP2BUILD__MISSING__DEP"],
3108 "//conditions:default": [],
3109 })`,
3110 "local_includes": `["."]`,
3111 }),
3112 },
3113 })
3114}
Trevor Radcliffecee4e052022-09-06 19:31:25 +00003115
3116func TestCcLibraryWithSyspropSrcs(t *testing.T) {
3117 runCcLibraryTestCase(t, Bp2buildTestCase{
3118 Description: "cc_library with sysprop sources",
3119 ModuleTypeUnderTest: "cc_library",
3120 ModuleTypeUnderTestFactory: cc.LibraryFactory,
3121 Blueprint: `
3122cc_library {
3123 name: "foo",
3124 srcs: [
3125 "bar.sysprop",
3126 "baz.sysprop",
3127 "blah.cpp",
3128 ],
3129 min_sdk_version: "5",
3130}`,
3131 ExpectedBazelTargets: []string{
3132 MakeBazelTarget("sysprop_library", "foo_sysprop_library", AttrNameToString{
3133 "srcs": `[
3134 "bar.sysprop",
3135 "baz.sysprop",
3136 ]`,
3137 }),
3138 MakeBazelTarget("cc_sysprop_library_static", "foo_cc_sysprop_library_static", AttrNameToString{
3139 "dep": `":foo_sysprop_library"`,
3140 "min_sdk_version": `"5"`,
3141 }),
3142 MakeBazelTarget("cc_library_static", "foo_bp2build_cc_library_static", AttrNameToString{
3143 "srcs": `["blah.cpp"]`,
3144 "local_includes": `["."]`,
3145 "min_sdk_version": `"5"`,
3146 "whole_archive_deps": `[":foo_cc_sysprop_library_static"]`,
3147 }),
3148 MakeBazelTarget("cc_library_shared", "foo", AttrNameToString{
3149 "srcs": `["blah.cpp"]`,
3150 "local_includes": `["."]`,
3151 "min_sdk_version": `"5"`,
3152 "whole_archive_deps": `[":foo_cc_sysprop_library_static"]`,
3153 }),
3154 },
3155 })
3156}
3157
3158func TestCcLibraryWithSyspropSrcsSomeConfigs(t *testing.T) {
3159 runCcLibraryTestCase(t, Bp2buildTestCase{
3160 Description: "cc_library with sysprop sources in some configs but not others",
3161 ModuleTypeUnderTest: "cc_library",
3162 ModuleTypeUnderTestFactory: cc.LibraryFactory,
3163 Blueprint: `
3164cc_library {
3165 name: "foo",
3166 host_supported: true,
3167 srcs: [
3168 "blah.cpp",
3169 ],
3170 target: {
3171 android: {
3172 srcs: ["bar.sysprop"],
3173 },
3174 },
3175 min_sdk_version: "5",
3176}`,
3177 ExpectedBazelTargets: []string{
3178 MakeBazelTargetNoRestrictions("sysprop_library", "foo_sysprop_library", AttrNameToString{
3179 "srcs": `select({
3180 "//build/bazel/platforms/os:android": ["bar.sysprop"],
3181 "//conditions:default": [],
3182 })`,
3183 }),
3184 MakeBazelTargetNoRestrictions("cc_sysprop_library_static", "foo_cc_sysprop_library_static", AttrNameToString{
3185 "dep": `":foo_sysprop_library"`,
3186 "min_sdk_version": `"5"`,
3187 }),
3188 MakeBazelTargetNoRestrictions("cc_library_static", "foo_bp2build_cc_library_static", AttrNameToString{
3189 "srcs": `["blah.cpp"]`,
3190 "local_includes": `["."]`,
3191 "min_sdk_version": `"5"`,
3192 "whole_archive_deps": `select({
3193 "//build/bazel/platforms/os:android": [":foo_cc_sysprop_library_static"],
3194 "//conditions:default": [],
3195 })`,
3196 }),
3197 MakeBazelTargetNoRestrictions("cc_library_shared", "foo", AttrNameToString{
3198 "srcs": `["blah.cpp"]`,
3199 "local_includes": `["."]`,
3200 "min_sdk_version": `"5"`,
3201 "whole_archive_deps": `select({
3202 "//build/bazel/platforms/os:android": [":foo_cc_sysprop_library_static"],
3203 "//conditions:default": [],
3204 })`,
3205 }),
3206 },
3207 })
3208}
Vinh Tran395a1e92022-09-16 18:27:29 -04003209
3210func TestCcLibraryWithAidlAndSharedLibs(t *testing.T) {
3211 runCcLibraryTestCase(t, Bp2buildTestCase{
3212 Description: "cc_aidl_library depends on shared libs from parent cc_library_static",
3213 ModuleTypeUnderTest: "cc_library",
3214 ModuleTypeUnderTestFactory: cc.LibraryFactory,
3215 Blueprint: `
3216cc_library_static {
3217 name: "foo",
3218 srcs: [
3219 "Foo.aidl",
3220 ],
3221 shared_libs: [
3222 "bar",
3223 "baz",
3224 ],
3225 export_shared_lib_headers: [
3226 "baz",
3227 ],
3228}` +
3229 simpleModuleDoNotConvertBp2build("cc_library", "bar") +
3230 simpleModuleDoNotConvertBp2build("cc_library", "baz"),
3231 ExpectedBazelTargets: []string{
3232 MakeBazelTarget("aidl_library", "foo_aidl_library", AttrNameToString{
3233 "srcs": `["Foo.aidl"]`,
3234 }),
3235 MakeBazelTarget("cc_aidl_library", "foo_cc_aidl_library", AttrNameToString{
3236 "deps": `[":foo_aidl_library"]`,
3237 "implementation_dynamic_deps": `[
3238 ":baz",
3239 ":bar",
3240 ]`,
3241 }),
3242 MakeBazelTarget("cc_library_static", "foo", AttrNameToString{
3243 "implementation_whole_archive_deps": `[":foo_cc_aidl_library"]`,
3244 "dynamic_deps": `[":baz"]`,
3245 "implementation_dynamic_deps": `[":bar"]`,
3246 "local_includes": `["."]`,
3247 }),
3248 },
3249 })
3250}