blob: 27ae80af48a2641991f8af206f31d8412880a520 [file] [log] [blame]
Colin Cross72bb3632017-07-13 16:23:21 -07001// Copyright 2017 Google Inc. All rights reserved.
2//
3// Licensed under the Apache License, Version 2.0 (the "License");
4// you may not use this file except in compliance with the License.
5// You may obtain a copy of the License at
6//
7// http://www.apache.org/licenses/LICENSE-2.0
8//
9// Unless required by applicable law or agreed to in writing, software
10// distributed under the License is distributed on an "AS IS" BASIS,
11// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
12// See the License for the specific language governing permissions and
13// limitations under the License.
14
15package java
16
17import (
Paul Duffin1a393322020-11-18 16:36:47 +000018 "fmt"
Colin Cross72bb3632017-07-13 16:23:21 -070019 "io/ioutil"
20 "os"
21 "path/filepath"
Colin Crossc0806172019-06-14 18:51:47 -070022 "reflect"
Paul Duffindaaa3322020-05-26 18:13:57 +010023 "regexp"
Nan Zhang61eaedb2017-11-02 13:28:15 -070024 "strconv"
Colin Cross72bb3632017-07-13 16:23:21 -070025 "strings"
26 "testing"
Colin Cross86a60ae2018-05-29 14:44:55 -070027
Jeongik Cha28df2572019-11-11 10:46:36 +090028 "github.com/google/blueprint/proptools"
29
Colin Crossa4f08812018-10-02 22:03:40 -070030 "android/soong/android"
31 "android/soong/cc"
Colin Crossc28bb0b2019-02-25 14:20:47 -080032 "android/soong/dexpreopt"
Liz Kammerdd849a82020-06-12 16:38:45 -070033 "android/soong/python"
Colin Cross72bb3632017-07-13 16:23:21 -070034)
35
36var buildDir string
37
38func setUp() {
39 var err error
40 buildDir, err = ioutil.TempDir("", "soong_java_test")
41 if err != nil {
42 panic(err)
43 }
44}
45
46func tearDown() {
47 os.RemoveAll(buildDir)
48}
49
50func TestMain(m *testing.M) {
51 run := func() int {
52 setUp()
53 defer tearDown()
54
55 return m.Run()
56 }
57
58 os.Exit(run())
59}
Colin Cross527012a2017-11-30 22:56:16 -080060
Colin Cross98be1bb2019-12-13 20:41:13 -080061func testConfig(env map[string]string, bp string, fs map[string][]byte) android.Config {
Martin Stjernholmd90676f2020-01-11 00:37:30 +000062 bp += dexpreopt.BpToolModulesForTest()
63
Martin Stjernholm75a48d82020-01-10 20:32:59 +000064 config := TestConfig(buildDir, env, bp, fs)
65
66 // Set up the global Once cache used for dexpreopt.GlobalSoongConfig, so that
67 // it doesn't create a real one, which would fail.
68 _ = dexpreopt.GlobalSoongConfigForTests(config)
69
70 return config
Colin Cross1369cdb2017-09-29 17:58:17 -070071}
72
Colin Crossae8600b2020-10-29 17:09:13 -070073func testContext(config android.Config) *android.TestContext {
Colin Cross72bb3632017-07-13 16:23:21 -070074
Colin Crossae8600b2020-10-29 17:09:13 -070075 ctx := android.NewTestArchContext(config)
Paul Duffinf9b1da02019-12-18 19:51:55 +000076 RegisterJavaBuildComponents(ctx)
77 RegisterAppBuildComponents(ctx)
78 RegisterAARBuildComponents(ctx)
Paul Duffinb0f85072019-12-19 10:28:56 +000079 RegisterGenRuleBuildComponents(ctx)
Paul Duffin43dc1cc2019-12-19 11:18:54 +000080 RegisterSystemModulesBuildComponents(ctx)
Colin Cross4b49b762019-11-22 15:25:03 -080081 ctx.RegisterModuleType("java_plugin", PluginFactory)
Colin Cross4b49b762019-11-22 15:25:03 -080082 ctx.RegisterModuleType("filegroup", android.FileGroupFactory)
Liz Kammerdd849a82020-06-12 16:38:45 -070083 ctx.RegisterModuleType("python_binary_host", python.PythonBinaryHostFactory)
Paul Duffin884363e2019-12-19 10:21:09 +000084 RegisterDocsBuildComponents(ctx)
85 RegisterStubsBuildComponents(ctx)
Paul Duffin43dc1cc2019-12-19 11:18:54 +000086 RegisterSdkLibraryBuildComponents(ctx)
Colin Cross89536d42017-07-07 14:35:50 -070087 ctx.PreArchMutators(android.RegisterDefaultsPreArchMutators)
Paul Duffin44f1d842020-06-26 20:17:02 +010088 ctx.PreArchMutators(android.RegisterComponentsMutator)
Paul Duffina48f7582019-12-19 11:25:19 +000089
90 RegisterPrebuiltApisBuildComponents(ctx)
91
Liz Kammerdd849a82020-06-12 16:38:45 -070092 ctx.PreDepsMutators(python.RegisterPythonPreDepsMutators)
Jaewoong Jungb639a6a2019-05-10 15:16:29 -070093 ctx.PostDepsMutators(android.RegisterOverridePostDepsMutators)
Colin Cross06fa5882020-10-29 18:21:38 -070094 ctx.RegisterPreSingletonType("overlay", android.SingletonFactoryAdaptor(ctx.Context, OverlaySingletonFactory))
95 ctx.RegisterPreSingletonType("sdk_versions", android.SingletonFactoryAdaptor(ctx.Context, sdkPreSingletonFactory))
Colin Crossa4f08812018-10-02 22:03:40 -070096
Paul Duffin021f4e52020-07-30 16:04:17 +010097 android.RegisterPrebuiltMutators(ctx)
98
Colin Crossa4f08812018-10-02 22:03:40 -070099 // Register module types and mutators from cc needed for JNI testing
Paul Duffin77980a82019-12-19 16:01:36 +0000100 cc.RegisterRequiredBuildComponentsForTest(ctx)
Colin Crossa4f08812018-10-02 22:03:40 -0700101
Martin Stjernholmd90676f2020-01-11 00:37:30 +0000102 dexpreopt.RegisterToolModulesForTest(ctx)
103
Jaewoong Jungc779cd42020-10-06 18:56:10 -0700104 ctx.PostDepsMutators(func(ctx android.RegisterMutatorsContext) {
105 ctx.TopDown("propagate_rro_enforcement", propagateRROEnforcementMutator).Parallel()
106 })
107
Colin Cross527012a2017-11-30 22:56:16 -0800108 return ctx
109}
110
111func run(t *testing.T, ctx *android.TestContext, config android.Config) {
Colin Cross6b4a32d2017-12-05 13:42:45 -0800112 t.Helper()
Colin Crossc28bb0b2019-02-25 14:20:47 -0800113
Colin Cross98be1bb2019-12-13 20:41:13 -0800114 pathCtx := android.PathContextForTesting(config)
Martin Stjernholm40f9f3c2020-01-20 18:12:23 +0000115 dexpreopt.SetTestGlobalConfig(config, dexpreopt.GlobalConfigForTests(pathCtx))
Colin Crossc28bb0b2019-02-25 14:20:47 -0800116
Colin Crossae8600b2020-10-29 17:09:13 -0700117 ctx.Register()
Paul Duffinbaccf7e2019-06-11 11:58:30 +0100118 _, errs := ctx.ParseBlueprintsFiles("Android.bp")
Logan Chien42039712018-03-12 16:29:17 +0800119 android.FailIfErrored(t, errs)
Colin Cross72bb3632017-07-13 16:23:21 -0700120 _, errs = ctx.PrepareBuildActions(config)
Logan Chien42039712018-03-12 16:29:17 +0800121 android.FailIfErrored(t, errs)
Colin Cross527012a2017-11-30 22:56:16 -0800122}
123
Jeongik Cha2cc570d2019-10-29 15:44:45 +0900124func testJavaError(t *testing.T, pattern string, bp string) (*android.TestContext, android.Config) {
Jeongik Cha538c0d02019-07-11 15:54:27 +0900125 t.Helper()
Colin Cross98be1bb2019-12-13 20:41:13 -0800126 return testJavaErrorWithConfig(t, pattern, testConfig(nil, bp, nil))
Jeongik Cha2cc570d2019-10-29 15:44:45 +0900127}
128
Colin Cross98be1bb2019-12-13 20:41:13 -0800129func testJavaErrorWithConfig(t *testing.T, pattern string, config android.Config) (*android.TestContext, android.Config) {
Jeongik Cha2cc570d2019-10-29 15:44:45 +0900130 t.Helper()
Colin Crossae8600b2020-10-29 17:09:13 -0700131 ctx := testContext(config)
Jeongik Cha538c0d02019-07-11 15:54:27 +0900132
Colin Cross98be1bb2019-12-13 20:41:13 -0800133 pathCtx := android.PathContextForTesting(config)
Martin Stjernholm40f9f3c2020-01-20 18:12:23 +0000134 dexpreopt.SetTestGlobalConfig(config, dexpreopt.GlobalConfigForTests(pathCtx))
Jeongik Cha538c0d02019-07-11 15:54:27 +0900135
Colin Crossae8600b2020-10-29 17:09:13 -0700136 ctx.Register()
Jeongik Cha538c0d02019-07-11 15:54:27 +0900137 _, errs := ctx.ParseBlueprintsFiles("Android.bp")
138 if len(errs) > 0 {
139 android.FailIfNoMatchingErrors(t, pattern, errs)
Jeongik Cha2cc570d2019-10-29 15:44:45 +0900140 return ctx, config
Jeongik Cha538c0d02019-07-11 15:54:27 +0900141 }
142 _, errs = ctx.PrepareBuildActions(config)
143 if len(errs) > 0 {
144 android.FailIfNoMatchingErrors(t, pattern, errs)
Jeongik Cha2cc570d2019-10-29 15:44:45 +0900145 return ctx, config
Jeongik Cha538c0d02019-07-11 15:54:27 +0900146 }
147
148 t.Fatalf("missing expected error %q (0 errors are returned)", pattern)
Jeongik Cha2cc570d2019-10-29 15:44:45 +0900149
150 return ctx, config
Jeongik Cha538c0d02019-07-11 15:54:27 +0900151}
152
Colin Cross238c1f32020-06-07 16:58:18 -0700153func testJavaWithFS(t *testing.T, bp string, fs map[string][]byte) (*android.TestContext, android.Config) {
154 t.Helper()
155 return testJavaWithConfig(t, testConfig(nil, bp, fs))
156}
157
Jaewoong Jungf9a04432019-07-17 11:15:09 -0700158func testJava(t *testing.T, bp string) (*android.TestContext, android.Config) {
Colin Cross6b4a32d2017-12-05 13:42:45 -0800159 t.Helper()
Colin Cross238c1f32020-06-07 16:58:18 -0700160 return testJavaWithFS(t, bp, nil)
Jeongik Cha2cc570d2019-10-29 15:44:45 +0900161}
162
Colin Cross98be1bb2019-12-13 20:41:13 -0800163func testJavaWithConfig(t *testing.T, config android.Config) (*android.TestContext, android.Config) {
Jeongik Cha2cc570d2019-10-29 15:44:45 +0900164 t.Helper()
Colin Crossae8600b2020-10-29 17:09:13 -0700165 ctx := testContext(config)
Colin Cross527012a2017-11-30 22:56:16 -0800166 run(t, ctx, config)
Colin Cross72bb3632017-07-13 16:23:21 -0700167
Jaewoong Jungf9a04432019-07-17 11:15:09 -0700168 return ctx, config
Colin Cross72bb3632017-07-13 16:23:21 -0700169}
170
Colin Cross2acdae82017-09-15 19:44:24 -0700171func moduleToPath(name string) string {
172 switch {
173 case name == `""`:
174 return name
Colin Crossfc3674a2017-09-18 17:41:52 -0700175 case strings.HasSuffix(name, ".jar"):
176 return name
Nan Zhanged19fc32017-10-19 13:06:22 -0700177 default:
178 return filepath.Join(buildDir, ".intermediates", name, "android_common", "turbine-combined", name+".jar")
Colin Cross2acdae82017-09-15 19:44:24 -0700179 }
180}
181
Jeongik Chae403e9e2019-12-07 00:16:24 +0900182func TestJavaLinkType(t *testing.T) {
183 testJava(t, `
184 java_library {
185 name: "foo",
186 srcs: ["a.java"],
187 libs: ["bar"],
188 static_libs: ["baz"],
189 }
190
191 java_library {
192 name: "bar",
193 sdk_version: "current",
194 srcs: ["b.java"],
195 }
196
197 java_library {
198 name: "baz",
199 sdk_version: "system_current",
200 srcs: ["c.java"],
201 }
202 `)
203
Steven Moreland00298982020-11-17 21:44:36 +0000204 testJavaError(t, "consider adjusting sdk_version: OR platform_apis:", `
Jeongik Chae403e9e2019-12-07 00:16:24 +0900205 java_library {
206 name: "foo",
207 srcs: ["a.java"],
208 libs: ["bar"],
209 sdk_version: "current",
210 static_libs: ["baz"],
211 }
212
213 java_library {
214 name: "bar",
215 sdk_version: "current",
216 srcs: ["b.java"],
217 }
218
219 java_library {
220 name: "baz",
221 sdk_version: "system_current",
222 srcs: ["c.java"],
223 }
224 `)
225
226 testJava(t, `
227 java_library {
228 name: "foo",
229 srcs: ["a.java"],
230 libs: ["bar"],
231 sdk_version: "system_current",
232 static_libs: ["baz"],
233 }
234
235 java_library {
236 name: "bar",
237 sdk_version: "current",
238 srcs: ["b.java"],
239 }
240
241 java_library {
242 name: "baz",
243 sdk_version: "system_current",
244 srcs: ["c.java"],
245 }
246 `)
247
Steven Moreland00298982020-11-17 21:44:36 +0000248 testJavaError(t, "consider adjusting sdk_version: OR platform_apis:", `
Jeongik Chae403e9e2019-12-07 00:16:24 +0900249 java_library {
250 name: "foo",
251 srcs: ["a.java"],
252 libs: ["bar"],
253 sdk_version: "system_current",
254 static_libs: ["baz"],
255 }
256
257 java_library {
258 name: "bar",
259 sdk_version: "current",
260 srcs: ["b.java"],
261 }
262
263 java_library {
264 name: "baz",
265 srcs: ["c.java"],
266 }
267 `)
268}
269
Colin Cross72bb3632017-07-13 16:23:21 -0700270func TestSimple(t *testing.T) {
Jaewoong Jungf9a04432019-07-17 11:15:09 -0700271 ctx, _ := testJava(t, `
Colin Cross72bb3632017-07-13 16:23:21 -0700272 java_library {
273 name: "foo",
274 srcs: ["a.java"],
Colin Crosse8dc34a2017-07-19 11:22:16 -0700275 libs: ["bar"],
276 static_libs: ["baz"],
Colin Cross72bb3632017-07-13 16:23:21 -0700277 }
278
279 java_library {
280 name: "bar",
281 srcs: ["b.java"],
282 }
283
284 java_library {
285 name: "baz",
286 srcs: ["c.java"],
287 }
Colin Crossd5934c82017-10-02 13:55:26 -0700288 `)
Colin Cross72bb3632017-07-13 16:23:21 -0700289
Colin Cross4c428df2017-09-15 17:36:05 -0700290 javac := ctx.ModuleForTests("foo", "android_common").Rule("javac")
Nan Zhanged19fc32017-10-19 13:06:22 -0700291 combineJar := ctx.ModuleForTests("foo", "android_common").Description("for javac")
Colin Cross72bb3632017-07-13 16:23:21 -0700292
293 if len(javac.Inputs) != 1 || javac.Inputs[0].String() != "a.java" {
294 t.Errorf(`foo inputs %v != ["a.java"]`, javac.Inputs)
295 }
296
Colin Cross1ee23172017-10-18 14:44:18 -0700297 baz := ctx.ModuleForTests("baz", "android_common").Rule("javac").Output.String()
Nan Zhanged19fc32017-10-19 13:06:22 -0700298 barTurbine := filepath.Join(buildDir, ".intermediates", "bar", "android_common", "turbine-combined", "bar.jar")
299 bazTurbine := filepath.Join(buildDir, ".intermediates", "baz", "android_common", "turbine-combined", "baz.jar")
Colin Cross0a6e0072017-08-30 14:24:55 -0700300
Nan Zhanged19fc32017-10-19 13:06:22 -0700301 if !strings.Contains(javac.Args["classpath"], barTurbine) {
302 t.Errorf("foo classpath %v does not contain %q", javac.Args["classpath"], barTurbine)
Colin Cross72bb3632017-07-13 16:23:21 -0700303 }
304
Nan Zhanged19fc32017-10-19 13:06:22 -0700305 if !strings.Contains(javac.Args["classpath"], bazTurbine) {
306 t.Errorf("foo classpath %v does not contain %q", javac.Args["classpath"], bazTurbine)
Colin Cross0a6e0072017-08-30 14:24:55 -0700307 }
308
309 if len(combineJar.Inputs) != 2 || combineJar.Inputs[1].String() != baz {
310 t.Errorf("foo combineJar inputs %v does not contain %q", combineJar.Inputs, baz)
Colin Cross72bb3632017-07-13 16:23:21 -0700311 }
312}
313
Artur Satayev9cf46692019-11-26 18:08:34 +0000314func TestExportedPlugins(t *testing.T) {
315 type Result struct {
316 library string
317 processors string
318 }
319 var tests = []struct {
320 name string
321 extra string
322 results []Result
323 }{
324 {
325 name: "Exported plugin is not a direct plugin",
326 extra: `java_library { name: "exports", srcs: ["a.java"], exported_plugins: ["plugin"] }`,
327 results: []Result{{library: "exports", processors: "-proc:none"}},
328 },
329 {
330 name: "Exports plugin to dependee",
331 extra: `
332 java_library{name: "exports", exported_plugins: ["plugin"]}
333 java_library{name: "foo", srcs: ["a.java"], libs: ["exports"]}
334 java_library{name: "bar", srcs: ["a.java"], static_libs: ["exports"]}
335 `,
336 results: []Result{
337 {library: "foo", processors: "-processor com.android.TestPlugin"},
338 {library: "bar", processors: "-processor com.android.TestPlugin"},
339 },
340 },
341 {
342 name: "Exports plugin to android_library",
343 extra: `
344 java_library{name: "exports", exported_plugins: ["plugin"]}
345 android_library{name: "foo", srcs: ["a.java"], libs: ["exports"]}
346 android_library{name: "bar", srcs: ["a.java"], static_libs: ["exports"]}
347 `,
348 results: []Result{
349 {library: "foo", processors: "-processor com.android.TestPlugin"},
350 {library: "bar", processors: "-processor com.android.TestPlugin"},
351 },
352 },
353 {
354 name: "Exports plugin is not propagated via transitive deps",
355 extra: `
356 java_library{name: "exports", exported_plugins: ["plugin"]}
357 java_library{name: "foo", srcs: ["a.java"], libs: ["exports"]}
358 java_library{name: "bar", srcs: ["a.java"], static_libs: ["foo"]}
359 `,
360 results: []Result{
361 {library: "foo", processors: "-processor com.android.TestPlugin"},
362 {library: "bar", processors: "-proc:none"},
363 },
364 },
365 {
366 name: "Exports plugin appends to plugins",
367 extra: `
368 java_plugin{name: "plugin2", processor_class: "com.android.TestPlugin2"}
369 java_library{name: "exports", exported_plugins: ["plugin"]}
370 java_library{name: "foo", srcs: ["a.java"], libs: ["exports"], plugins: ["plugin2"]}
371 `,
372 results: []Result{
373 {library: "foo", processors: "-processor com.android.TestPlugin,com.android.TestPlugin2"},
374 },
375 },
376 }
377
378 for _, test := range tests {
379 t.Run(test.name, func(t *testing.T) {
380 ctx, _ := testJava(t, `
381 java_plugin {
382 name: "plugin",
383 processor_class: "com.android.TestPlugin",
384 }
385 `+test.extra)
386
387 for _, want := range test.results {
388 javac := ctx.ModuleForTests(want.library, "android_common").Rule("javac")
389 if javac.Args["processor"] != want.processors {
390 t.Errorf("For library %v, expected %v, found %v", want.library, want.processors, javac.Args["processor"])
391 }
392 }
393 })
394 }
395}
396
Jeongik Cha2cc570d2019-10-29 15:44:45 +0900397func TestSdkVersionByPartition(t *testing.T) {
398 testJavaError(t, "sdk_version must have a value when the module is located at vendor or product", `
Jeongik Cha6bd33c12019-06-25 16:26:18 +0900399 java_library {
400 name: "foo",
401 srcs: ["a.java"],
402 vendor: true,
403 }
Jeongik Cha2cc570d2019-10-29 15:44:45 +0900404 `)
Jeongik Cha6bd33c12019-06-25 16:26:18 +0900405
Jeongik Cha2cc570d2019-10-29 15:44:45 +0900406 testJava(t, `
Jeongik Cha6bd33c12019-06-25 16:26:18 +0900407 java_library {
408 name: "bar",
409 srcs: ["b.java"],
410 }
411 `)
412
Jeongik Cha2cc570d2019-10-29 15:44:45 +0900413 for _, enforce := range []bool{true, false} {
Jeongik Cha2cc570d2019-10-29 15:44:45 +0900414 bp := `
415 java_library {
416 name: "foo",
417 srcs: ["a.java"],
418 product_specific: true,
419 }
420 `
Colin Cross98be1bb2019-12-13 20:41:13 -0800421
422 config := testConfig(nil, bp, nil)
423 config.TestProductVariables.EnforceProductPartitionInterface = proptools.BoolPtr(enforce)
Jeongik Cha2cc570d2019-10-29 15:44:45 +0900424 if enforce {
Colin Cross98be1bb2019-12-13 20:41:13 -0800425 testJavaErrorWithConfig(t, "sdk_version must have a value when the module is located at vendor or product", config)
Jeongik Cha2cc570d2019-10-29 15:44:45 +0900426 } else {
Colin Cross98be1bb2019-12-13 20:41:13 -0800427 testJavaWithConfig(t, config)
Jeongik Cha2cc570d2019-10-29 15:44:45 +0900428 }
Jeongik Cha6bd33c12019-06-25 16:26:18 +0900429 }
430}
431
Colin Crossd5934c82017-10-02 13:55:26 -0700432func TestArchSpecific(t *testing.T) {
Jaewoong Jungf9a04432019-07-17 11:15:09 -0700433 ctx, _ := testJava(t, `
Colin Crossd5934c82017-10-02 13:55:26 -0700434 java_library {
435 name: "foo",
436 srcs: ["a.java"],
437 target: {
438 android: {
439 srcs: ["b.java"],
440 },
441 },
442 }
443 `)
444
445 javac := ctx.ModuleForTests("foo", "android_common").Rule("javac")
446 if len(javac.Inputs) != 2 || javac.Inputs[0].String() != "a.java" || javac.Inputs[1].String() != "b.java" {
447 t.Errorf(`foo inputs %v != ["a.java", "b.java"]`, javac.Inputs)
448 }
449}
450
Colin Cross6b4a32d2017-12-05 13:42:45 -0800451func TestBinary(t *testing.T) {
Jaewoong Jungf9a04432019-07-17 11:15:09 -0700452 ctx, _ := testJava(t, `
Colin Cross6b4a32d2017-12-05 13:42:45 -0800453 java_library_host {
454 name: "foo",
455 srcs: ["a.java"],
456 }
457
458 java_binary_host {
459 name: "bar",
460 srcs: ["b.java"],
461 static_libs: ["foo"],
Colin Cross89226d92020-10-09 19:00:54 -0700462 jni_libs: ["libjni"],
463 }
464
465 cc_library_shared {
466 name: "libjni",
467 host_supported: true,
468 device_supported: false,
469 stl: "none",
Colin Cross6b4a32d2017-12-05 13:42:45 -0800470 }
471 `)
472
473 buildOS := android.BuildOs.String()
474
475 bar := ctx.ModuleForTests("bar", buildOS+"_common")
476 barJar := bar.Output("bar.jar").Output.String()
477 barWrapper := ctx.ModuleForTests("bar", buildOS+"_x86_64")
478 barWrapperDeps := barWrapper.Output("bar").Implicits.Strings()
479
Colin Cross89226d92020-10-09 19:00:54 -0700480 libjni := ctx.ModuleForTests("libjni", buildOS+"_x86_64_shared")
481 libjniSO := libjni.Rule("Cp").Output.String()
482
Colin Cross6b4a32d2017-12-05 13:42:45 -0800483 // Test that the install binary wrapper depends on the installed jar file
Colin Crossc179ea62020-10-09 10:54:15 -0700484 if g, w := barWrapperDeps, barJar; !android.InList(w, g) {
485 t.Errorf("expected binary wrapper implicits to contain %q, got %q", w, g)
Colin Cross6b4a32d2017-12-05 13:42:45 -0800486 }
Colin Cross89226d92020-10-09 19:00:54 -0700487
488 // Test that the install binary wrapper depends on the installed JNI libraries
489 if g, w := barWrapperDeps, libjniSO; !android.InList(w, g) {
490 t.Errorf("expected binary wrapper implicits to contain %q, got %q", w, g)
Colin Cross6b4a32d2017-12-05 13:42:45 -0800491 }
Alex Humesky2070e322020-06-09 20:23:08 -0400492}
Colin Cross6b4a32d2017-12-05 13:42:45 -0800493
Alex Humesky2070e322020-06-09 20:23:08 -0400494func TestHostBinaryNoJavaDebugInfoOverride(t *testing.T) {
495 bp := `
496 java_library {
497 name: "target_library",
498 srcs: ["a.java"],
499 }
500
501 java_binary_host {
502 name: "host_binary",
503 srcs: ["b.java"],
504 }
505 `
506 config := testConfig(nil, bp, nil)
507 config.TestProductVariables.MinimizeJavaDebugInfo = proptools.BoolPtr(true)
508
509 ctx, _ := testJavaWithConfig(t, config)
510
Liz Kammer7941b302020-07-28 13:27:34 -0700511 // first, check that the -g flag is added to target modules
Alex Humesky2070e322020-06-09 20:23:08 -0400512 targetLibrary := ctx.ModuleForTests("target_library", "android_common")
513 targetJavaFlags := targetLibrary.Module().VariablesForTests()["javacFlags"]
514 if !strings.Contains(targetJavaFlags, "-g:source,lines") {
515 t.Errorf("target library javac flags %v should contain "+
516 "-g:source,lines override with MinimizeJavaDebugInfo", targetJavaFlags)
517 }
518
519 // check that -g is not overridden for host modules
520 buildOS := android.BuildOs.String()
521 hostBinary := ctx.ModuleForTests("host_binary", buildOS+"_common")
522 hostJavaFlags := hostBinary.Module().VariablesForTests()["javacFlags"]
523 if strings.Contains(hostJavaFlags, "-g:source,lines") {
524 t.Errorf("java_binary_host javac flags %v should not have "+
525 "-g:source,lines override with MinimizeJavaDebugInfo", hostJavaFlags)
526 }
Colin Cross6b4a32d2017-12-05 13:42:45 -0800527}
528
Colin Cross72bb3632017-07-13 16:23:21 -0700529func TestPrebuilts(t *testing.T) {
Jaewoong Jungf9a04432019-07-17 11:15:09 -0700530 ctx, _ := testJava(t, `
Colin Cross72bb3632017-07-13 16:23:21 -0700531 java_library {
532 name: "foo",
Paul Duffin91547182019-11-12 19:39:36 +0000533 srcs: ["a.java", ":stubs-source"],
Paul Duffinfcfd7912020-01-31 17:54:30 +0000534 libs: ["bar", "sdklib"],
Colin Crosse8dc34a2017-07-19 11:22:16 -0700535 static_libs: ["baz"],
Colin Cross72bb3632017-07-13 16:23:21 -0700536 }
537
Colin Cross74d73e22017-08-02 11:05:49 -0700538 java_import {
Colin Cross72bb3632017-07-13 16:23:21 -0700539 name: "bar",
Colin Cross74d73e22017-08-02 11:05:49 -0700540 jars: ["a.jar"],
Colin Cross72bb3632017-07-13 16:23:21 -0700541 }
542
Colin Cross74d73e22017-08-02 11:05:49 -0700543 java_import {
Colin Cross72bb3632017-07-13 16:23:21 -0700544 name: "baz",
Colin Cross74d73e22017-08-02 11:05:49 -0700545 jars: ["b.jar"],
Liz Kammerd6c31d22020-08-05 15:40:41 -0700546 sdk_version: "current",
547 compile_dex: true,
Colin Cross72bb3632017-07-13 16:23:21 -0700548 }
Colin Cross42be7612019-02-21 18:12:14 -0800549
550 dex_import {
551 name: "qux",
552 jars: ["b.jar"],
553 }
Colin Cross79c7c262019-04-17 11:11:46 -0700554
555 java_sdk_library_import {
Paul Duffin56d44902020-01-31 13:36:25 +0000556 name: "sdklib",
557 public: {
558 jars: ["c.jar"],
559 },
560 }
561
Paul Duffin91547182019-11-12 19:39:36 +0000562 prebuilt_stubs_sources {
563 name: "stubs-source",
Paul Duffin9b478b02019-12-10 13:41:51 +0000564 srcs: ["stubs/sources"],
Paul Duffin91547182019-11-12 19:39:36 +0000565 }
Paul Duffin1b82e6a2019-12-03 18:06:47 +0000566
567 java_test_import {
568 name: "test",
569 jars: ["a.jar"],
570 test_suites: ["cts"],
571 test_config: "AndroidTest.xml",
572 }
Colin Cross72bb3632017-07-13 16:23:21 -0700573 `)
574
Paul Duffin9b478b02019-12-10 13:41:51 +0000575 fooModule := ctx.ModuleForTests("foo", "android_common")
576 javac := fooModule.Rule("javac")
Nan Zhanged19fc32017-10-19 13:06:22 -0700577 combineJar := ctx.ModuleForTests("foo", "android_common").Description("for javac")
Liz Kammerd6c31d22020-08-05 15:40:41 -0700578 barModule := ctx.ModuleForTests("bar", "android_common")
579 barJar := barModule.Rule("combineJar").Output
580 bazModule := ctx.ModuleForTests("baz", "android_common")
581 bazJar := bazModule.Rule("combineJar").Output
Colin Cross79c7c262019-04-17 11:11:46 -0700582 sdklibStubsJar := ctx.ModuleForTests("sdklib.stubs", "android_common").Rule("combineJar").Output
Colin Cross72bb3632017-07-13 16:23:21 -0700583
Paul Duffin9b478b02019-12-10 13:41:51 +0000584 fooLibrary := fooModule.Module().(*Library)
585 assertDeepEquals(t, "foo java sources incorrect",
586 []string{"a.java"}, fooLibrary.compiledJavaSrcs.Strings())
Paul Duffin91547182019-11-12 19:39:36 +0000587
Paul Duffin9b478b02019-12-10 13:41:51 +0000588 assertDeepEquals(t, "foo java source jars incorrect",
589 []string{".intermediates/stubs-source/android_common/stubs-source-stubs.srcjar"},
590 android.NormalizePathsForTesting(fooLibrary.compiledSrcJars))
Paul Duffin91547182019-11-12 19:39:36 +0000591
Colin Cross37f6d792018-07-12 12:28:41 -0700592 if !strings.Contains(javac.Args["classpath"], barJar.String()) {
593 t.Errorf("foo classpath %v does not contain %q", javac.Args["classpath"], barJar.String())
Colin Cross72bb3632017-07-13 16:23:21 -0700594 }
595
Liz Kammerd6c31d22020-08-05 15:40:41 -0700596 barDexJar := barModule.Module().(*Import).DexJarBuildPath()
597 if barDexJar != nil {
598 t.Errorf("bar dex jar build path expected to be nil, got %q", barDexJar)
599 }
600
Colin Cross79c7c262019-04-17 11:11:46 -0700601 if !strings.Contains(javac.Args["classpath"], sdklibStubsJar.String()) {
602 t.Errorf("foo classpath %v does not contain %q", javac.Args["classpath"], sdklibStubsJar.String())
603 }
604
Colin Cross37f6d792018-07-12 12:28:41 -0700605 if len(combineJar.Inputs) != 2 || combineJar.Inputs[1].String() != bazJar.String() {
606 t.Errorf("foo combineJar inputs %v does not contain %q", combineJar.Inputs, bazJar.String())
Colin Cross72bb3632017-07-13 16:23:21 -0700607 }
Colin Cross42be7612019-02-21 18:12:14 -0800608
Liz Kammerd6c31d22020-08-05 15:40:41 -0700609 bazDexJar := bazModule.Module().(*Import).DexJarBuildPath().String()
610 expectedDexJar := buildDir + "/.intermediates/baz/android_common/dex/baz.jar"
611 if bazDexJar != expectedDexJar {
612 t.Errorf("baz dex jar build path expected %q, got %q", expectedDexJar, bazDexJar)
613 }
614
Colin Cross42be7612019-02-21 18:12:14 -0800615 ctx.ModuleForTests("qux", "android_common").Rule("Cp")
Colin Cross72bb3632017-07-13 16:23:21 -0700616}
617
Paul Duffin9b478b02019-12-10 13:41:51 +0000618func assertDeepEquals(t *testing.T, message string, expected interface{}, actual interface{}) {
619 if !reflect.DeepEqual(expected, actual) {
620 t.Errorf("%s: expected %q, found %q", message, expected, actual)
621 }
622}
623
Paul Duffin1a393322020-11-18 16:36:47 +0000624func TestPrebuiltStubsSources(t *testing.T) {
625 test := func(t *testing.T, sourcesPath string, expectedInputs []string) {
626 ctx, _ := testJavaWithFS(t, fmt.Sprintf(`
627prebuilt_stubs_sources {
628 name: "stubs-source",
629 srcs: ["%s"],
630}`, sourcesPath), map[string][]byte{
631 "stubs/sources/pkg/A.java": nil,
632 "stubs/sources/pkg/B.java": nil,
633 })
634
635 zipSrc := ctx.ModuleForTests("stubs-source", "android_common").Rule("zip_src")
636 if expected, actual := expectedInputs, zipSrc.Inputs.Strings(); !reflect.DeepEqual(expected, actual) {
637 t.Errorf("mismatch of inputs to soong_zip: expected %q, actual %q", expected, actual)
638 }
639 }
640
641 t.Run("empty/missing directory", func(t *testing.T) {
642 test(t, "empty-directory", []string{})
643 })
644
645 t.Run("non-empty set of sources", func(t *testing.T) {
646 test(t, "stubs/sources", []string{
647 "stubs/sources/pkg/A.java",
648 "stubs/sources/pkg/B.java",
649 })
650 })
651}
652
Paul Duffin56d44902020-01-31 13:36:25 +0000653func TestJavaSdkLibraryImport(t *testing.T) {
654 ctx, _ := testJava(t, `
655 java_library {
656 name: "foo",
657 srcs: ["a.java"],
658 libs: ["sdklib"],
659 sdk_version: "current",
660 }
661
662 java_library {
663 name: "foo.system",
664 srcs: ["a.java"],
665 libs: ["sdklib"],
666 sdk_version: "system_current",
667 }
668
669 java_library {
670 name: "foo.test",
671 srcs: ["a.java"],
672 libs: ["sdklib"],
673 sdk_version: "test_current",
674 }
675
676 java_sdk_library_import {
677 name: "sdklib",
678 public: {
679 jars: ["a.jar"],
680 },
681 system: {
682 jars: ["b.jar"],
683 },
684 test: {
685 jars: ["c.jar"],
Paul Duffin0f8faff2020-05-20 16:18:00 +0100686 stub_srcs: ["c.java"],
Paul Duffin56d44902020-01-31 13:36:25 +0000687 },
688 }
689 `)
690
691 for _, scope := range []string{"", ".system", ".test"} {
692 fooModule := ctx.ModuleForTests("foo"+scope, "android_common")
693 javac := fooModule.Rule("javac")
694
695 sdklibStubsJar := ctx.ModuleForTests("sdklib.stubs"+scope, "android_common").Rule("combineJar").Output
696 if !strings.Contains(javac.Args["classpath"], sdklibStubsJar.String()) {
697 t.Errorf("foo classpath %v does not contain %q", javac.Args["classpath"], sdklibStubsJar.String())
698 }
699 }
Paul Duffinca8d9a52020-06-26 22:20:25 +0100700
Paul Duffincee7e662020-07-09 17:32:57 +0100701 CheckModuleDependencies(t, ctx, "sdklib", "android_common", []string{
Paul Duffinca8d9a52020-06-26 22:20:25 +0100702 `prebuilt_sdklib.stubs`,
703 `prebuilt_sdklib.stubs.source.test`,
704 `prebuilt_sdklib.stubs.system`,
705 `prebuilt_sdklib.stubs.test`,
706 })
707}
708
709func TestJavaSdkLibraryImport_WithSource(t *testing.T) {
710 ctx, _ := testJava(t, `
711 java_sdk_library {
712 name: "sdklib",
713 srcs: ["a.java"],
714 sdk_version: "none",
715 system_modules: "none",
716 public: {
717 enabled: true,
718 },
719 }
720
721 java_sdk_library_import {
722 name: "sdklib",
723 public: {
724 jars: ["a.jar"],
725 },
726 }
727 `)
728
Paul Duffincee7e662020-07-09 17:32:57 +0100729 CheckModuleDependencies(t, ctx, "sdklib", "android_common", []string{
Paul Duffinca8d9a52020-06-26 22:20:25 +0100730 `dex2oatd`,
731 `prebuilt_sdklib`,
732 `sdklib.impl`,
733 `sdklib.stubs`,
734 `sdklib.stubs.source`,
735 `sdklib.xml`,
736 })
737
Paul Duffincee7e662020-07-09 17:32:57 +0100738 CheckModuleDependencies(t, ctx, "prebuilt_sdklib", "android_common", []string{
Paul Duffin44f1d842020-06-26 20:17:02 +0100739 `prebuilt_sdklib.stubs`,
Paul Duffinca8d9a52020-06-26 22:20:25 +0100740 `sdklib.impl`,
741 // This should be prebuilt_sdklib.stubs but is set to sdklib.stubs because the
742 // dependency is added after prebuilts may have been renamed and so has to use
743 // the renamed name.
Paul Duffinca8d9a52020-06-26 22:20:25 +0100744 `sdklib.xml`,
745 })
746}
747
748func TestJavaSdkLibraryImport_Preferred(t *testing.T) {
749 ctx, _ := testJava(t, `
750 java_sdk_library {
751 name: "sdklib",
752 srcs: ["a.java"],
753 sdk_version: "none",
754 system_modules: "none",
755 public: {
756 enabled: true,
757 },
758 }
759
760 java_sdk_library_import {
761 name: "sdklib",
762 prefer: true,
763 public: {
764 jars: ["a.jar"],
765 },
766 }
767 `)
768
Paul Duffincee7e662020-07-09 17:32:57 +0100769 CheckModuleDependencies(t, ctx, "sdklib", "android_common", []string{
Paul Duffinca8d9a52020-06-26 22:20:25 +0100770 `dex2oatd`,
771 `prebuilt_sdklib`,
Paul Duffinca8d9a52020-06-26 22:20:25 +0100772 `sdklib.impl`,
Paul Duffin80342d72020-06-26 22:08:43 +0100773 `sdklib.stubs`,
Paul Duffinca8d9a52020-06-26 22:20:25 +0100774 `sdklib.stubs.source`,
775 `sdklib.xml`,
776 })
777
Paul Duffincee7e662020-07-09 17:32:57 +0100778 CheckModuleDependencies(t, ctx, "prebuilt_sdklib", "android_common", []string{
Paul Duffinca8d9a52020-06-26 22:20:25 +0100779 `prebuilt_sdklib.stubs`,
780 `sdklib.impl`,
781 `sdklib.xml`,
782 })
Paul Duffin56d44902020-01-31 13:36:25 +0000783}
784
Colin Cross89536d42017-07-07 14:35:50 -0700785func TestDefaults(t *testing.T) {
Jaewoong Jungf9a04432019-07-17 11:15:09 -0700786 ctx, _ := testJava(t, `
Colin Cross89536d42017-07-07 14:35:50 -0700787 java_defaults {
788 name: "defaults",
789 srcs: ["a.java"],
790 libs: ["bar"],
791 static_libs: ["baz"],
Sasha Smundak2057f822019-04-16 17:16:58 -0700792 optimize: {enabled: false},
Colin Cross89536d42017-07-07 14:35:50 -0700793 }
794
795 java_library {
796 name: "foo",
797 defaults: ["defaults"],
798 }
799
800 java_library {
801 name: "bar",
802 srcs: ["b.java"],
803 }
804
805 java_library {
806 name: "baz",
807 srcs: ["c.java"],
808 }
Sasha Smundak2057f822019-04-16 17:16:58 -0700809
810 android_test {
811 name: "atestOptimize",
812 defaults: ["defaults"],
813 optimize: {enabled: true},
814 }
815
816 android_test {
817 name: "atestNoOptimize",
818 defaults: ["defaults"],
819 }
820
821 android_test {
822 name: "atestDefault",
823 srcs: ["a.java"],
824 }
Colin Cross89536d42017-07-07 14:35:50 -0700825 `)
826
Colin Cross4c428df2017-09-15 17:36:05 -0700827 javac := ctx.ModuleForTests("foo", "android_common").Rule("javac")
Nan Zhanged19fc32017-10-19 13:06:22 -0700828 combineJar := ctx.ModuleForTests("foo", "android_common").Description("for javac")
Colin Cross89536d42017-07-07 14:35:50 -0700829
830 if len(javac.Inputs) != 1 || javac.Inputs[0].String() != "a.java" {
831 t.Errorf(`foo inputs %v != ["a.java"]`, javac.Inputs)
832 }
833
Nan Zhanged19fc32017-10-19 13:06:22 -0700834 barTurbine := filepath.Join(buildDir, ".intermediates", "bar", "android_common", "turbine-combined", "bar.jar")
835 if !strings.Contains(javac.Args["classpath"], barTurbine) {
836 t.Errorf("foo classpath %v does not contain %q", javac.Args["classpath"], barTurbine)
Colin Cross89536d42017-07-07 14:35:50 -0700837 }
838
Colin Cross1ee23172017-10-18 14:44:18 -0700839 baz := ctx.ModuleForTests("baz", "android_common").Rule("javac").Output.String()
Colin Cross0a6e0072017-08-30 14:24:55 -0700840 if len(combineJar.Inputs) != 2 || combineJar.Inputs[1].String() != baz {
841 t.Errorf("foo combineJar inputs %v does not contain %q", combineJar.Inputs, baz)
Colin Cross89536d42017-07-07 14:35:50 -0700842 }
Sasha Smundak2057f822019-04-16 17:16:58 -0700843
844 atestOptimize := ctx.ModuleForTests("atestOptimize", "android_common").MaybeRule("r8")
845 if atestOptimize.Output == nil {
846 t.Errorf("atestOptimize should optimize APK")
847 }
848
849 atestNoOptimize := ctx.ModuleForTests("atestNoOptimize", "android_common").MaybeRule("d8")
850 if atestNoOptimize.Output == nil {
851 t.Errorf("atestNoOptimize should not optimize APK")
852 }
853
854 atestDefault := ctx.ModuleForTests("atestDefault", "android_common").MaybeRule("r8")
855 if atestDefault.Output == nil {
856 t.Errorf("atestDefault should optimize APK")
857 }
Colin Cross89536d42017-07-07 14:35:50 -0700858}
859
Colin Cross0f37af02017-09-27 17:42:05 -0700860func TestResources(t *testing.T) {
861 var table = []struct {
862 name string
863 prop string
864 extra string
865 args string
866 }{
867 {
Colin Crossaf9c55b2017-10-03 14:50:08 -0700868 // Test that a module with java_resource_dirs includes the files
Colin Cross0f37af02017-09-27 17:42:05 -0700869 name: "resource dirs",
Colin Cross824bee32017-11-22 17:27:51 -0800870 prop: `java_resource_dirs: ["java-res"]`,
Colin Cross0ead1d72018-04-10 13:07:42 -0700871 args: "-C java-res -f java-res/a/a -f java-res/b/b",
Colin Cross0f37af02017-09-27 17:42:05 -0700872 },
873 {
874 // Test that a module with java_resources includes the files
875 name: "resource files",
Colin Cross0ead1d72018-04-10 13:07:42 -0700876 prop: `java_resources: ["java-res/a/a", "java-res/b/b"]`,
877 args: "-C . -f java-res/a/a -f java-res/b/b",
Colin Cross0f37af02017-09-27 17:42:05 -0700878 },
879 {
880 // Test that a module with a filegroup in java_resources includes the files with the
881 // path prefix
882 name: "resource filegroup",
883 prop: `java_resources: [":foo-res"]`,
884 extra: `
885 filegroup {
886 name: "foo-res",
Colin Cross824bee32017-11-22 17:27:51 -0800887 path: "java-res",
Colin Cross0ead1d72018-04-10 13:07:42 -0700888 srcs: ["java-res/a/a", "java-res/b/b"],
Colin Cross0f37af02017-09-27 17:42:05 -0700889 }`,
Colin Cross0ead1d72018-04-10 13:07:42 -0700890 args: "-C java-res -f java-res/a/a -f java-res/b/b",
Colin Cross0f37af02017-09-27 17:42:05 -0700891 },
892 {
Colin Cross0ead1d72018-04-10 13:07:42 -0700893 // Test that a module with wildcards in java_resource_dirs has the correct path prefixes
894 name: "wildcard dirs",
895 prop: `java_resource_dirs: ["java-res/*"]`,
896 args: "-C java-res/a -f java-res/a/a -C java-res/b -f java-res/b/b",
897 },
898 {
899 // Test that a module exclude_java_resource_dirs excludes the files
900 name: "wildcard dirs",
901 prop: `java_resource_dirs: ["java-res/*"], exclude_java_resource_dirs: ["java-res/b"]`,
902 args: "-C java-res/a -f java-res/a/a",
903 },
Colin Crosscedd4762018-09-13 11:26:19 -0700904 {
905 // Test wildcards in java_resources
906 name: "wildcard files",
907 prop: `java_resources: ["java-res/**/*"]`,
908 args: "-C . -f java-res/a/a -f java-res/b/b",
909 },
910 {
911 // Test exclude_java_resources with java_resources
912 name: "wildcard files with exclude",
913 prop: `java_resources: ["java-res/**/*"], exclude_java_resources: ["java-res/b/*"]`,
914 args: "-C . -f java-res/a/a",
915 },
916 {
917 // Test exclude_java_resources with java_resource_dirs
918 name: "resource dirs with exclude files",
919 prop: `java_resource_dirs: ["java-res"], exclude_java_resources: ["java-res/b/b"]`,
920 args: "-C java-res -f java-res/a/a",
921 },
922 {
923 // Test exclude_java_resource_dirs with java_resource_dirs
924 name: "resource dirs with exclude files",
925 prop: `java_resource_dirs: ["java-res", "java-res2"], exclude_java_resource_dirs: ["java-res2"]`,
926 args: "-C java-res -f java-res/a/a -f java-res/b/b",
927 },
Colin Cross0f37af02017-09-27 17:42:05 -0700928 }
929
930 for _, test := range table {
931 t.Run(test.name, func(t *testing.T) {
Colin Cross238c1f32020-06-07 16:58:18 -0700932 ctx, _ := testJavaWithFS(t, `
Colin Cross0f37af02017-09-27 17:42:05 -0700933 java_library {
934 name: "foo",
935 srcs: [
936 "a.java",
937 "b.java",
938 "c.java",
939 ],
940 `+test.prop+`,
941 }
Colin Cross238c1f32020-06-07 16:58:18 -0700942 `+test.extra,
943 map[string][]byte{
944 "java-res/a/a": nil,
945 "java-res/b/b": nil,
946 "java-res2/a": nil,
947 },
948 )
Colin Cross0f37af02017-09-27 17:42:05 -0700949
Colin Cross331a1212018-08-15 20:40:52 -0700950 foo := ctx.ModuleForTests("foo", "android_common").Output("withres/foo.jar")
Colin Cross1ee23172017-10-18 14:44:18 -0700951 fooRes := ctx.ModuleForTests("foo", "android_common").Output("res/foo.jar")
Colin Cross0f37af02017-09-27 17:42:05 -0700952
953 if !inList(fooRes.Output.String(), foo.Inputs.Strings()) {
954 t.Errorf("foo combined jars %v does not contain %q",
955 foo.Inputs.Strings(), fooRes.Output.String())
956 }
957
Colin Crossaf9c55b2017-10-03 14:50:08 -0700958 if fooRes.Args["jarArgs"] != test.args {
959 t.Errorf("foo resource jar args %q is not %q",
Colin Cross0f37af02017-09-27 17:42:05 -0700960 fooRes.Args["jarArgs"], test.args)
961 }
962 })
963 }
964}
965
Colin Cross0c4ce212019-05-03 15:28:19 -0700966func TestIncludeSrcs(t *testing.T) {
Colin Cross238c1f32020-06-07 16:58:18 -0700967 ctx, _ := testJavaWithFS(t, `
Colin Cross0c4ce212019-05-03 15:28:19 -0700968 java_library {
969 name: "foo",
970 srcs: [
971 "a.java",
972 "b.java",
973 "c.java",
974 ],
975 include_srcs: true,
976 }
977
978 java_library {
979 name: "bar",
980 srcs: [
981 "a.java",
982 "b.java",
983 "c.java",
984 ],
985 java_resource_dirs: ["java-res"],
986 include_srcs: true,
987 }
Colin Cross238c1f32020-06-07 16:58:18 -0700988 `, map[string][]byte{
989 "java-res/a/a": nil,
990 "java-res/b/b": nil,
991 "java-res2/a": nil,
992 })
Colin Cross0c4ce212019-05-03 15:28:19 -0700993
994 // Test a library with include_srcs: true
995 foo := ctx.ModuleForTests("foo", "android_common").Output("withres/foo.jar")
996 fooSrcJar := ctx.ModuleForTests("foo", "android_common").Output("foo.srcjar")
997
998 if g, w := fooSrcJar.Output.String(), foo.Inputs.Strings(); !inList(g, w) {
999 t.Errorf("foo combined jars %v does not contain %q", w, g)
1000 }
1001
1002 if g, w := fooSrcJar.Args["jarArgs"], "-C . -f a.java -f b.java -f c.java"; g != w {
1003 t.Errorf("foo source jar args %q is not %q", w, g)
1004 }
1005
1006 // Test a library with include_srcs: true and resources
1007 bar := ctx.ModuleForTests("bar", "android_common").Output("withres/bar.jar")
1008 barResCombined := ctx.ModuleForTests("bar", "android_common").Output("res-combined/bar.jar")
1009 barRes := ctx.ModuleForTests("bar", "android_common").Output("res/bar.jar")
1010 barSrcJar := ctx.ModuleForTests("bar", "android_common").Output("bar.srcjar")
1011
1012 if g, w := barSrcJar.Output.String(), barResCombined.Inputs.Strings(); !inList(g, w) {
1013 t.Errorf("bar combined resource jars %v does not contain %q", w, g)
1014 }
1015
1016 if g, w := barRes.Output.String(), barResCombined.Inputs.Strings(); !inList(g, w) {
1017 t.Errorf("bar combined resource jars %v does not contain %q", w, g)
1018 }
1019
1020 if g, w := barResCombined.Output.String(), bar.Inputs.Strings(); !inList(g, w) {
1021 t.Errorf("bar combined jars %v does not contain %q", w, g)
1022 }
1023
1024 if g, w := barSrcJar.Args["jarArgs"], "-C . -f a.java -f b.java -f c.java"; g != w {
1025 t.Errorf("bar source jar args %q is not %q", w, g)
1026 }
1027
1028 if g, w := barRes.Args["jarArgs"], "-C java-res -f java-res/a/a -f java-res/b/b"; g != w {
1029 t.Errorf("bar resource jar args %q is not %q", w, g)
1030 }
1031}
1032
Colin Cross54190b32017-10-09 15:34:10 -07001033func TestGeneratedSources(t *testing.T) {
Colin Cross238c1f32020-06-07 16:58:18 -07001034 ctx, _ := testJavaWithFS(t, `
Colin Cross54190b32017-10-09 15:34:10 -07001035 java_library {
1036 name: "foo",
1037 srcs: [
1038 "a*.java",
1039 ":gen",
1040 "b*.java",
1041 ],
1042 }
1043
1044 genrule {
1045 name: "gen",
Colin Cross824bee32017-11-22 17:27:51 -08001046 tool_files: ["java-res/a"],
Colin Cross54190b32017-10-09 15:34:10 -07001047 out: ["gen.java"],
1048 }
Colin Cross238c1f32020-06-07 16:58:18 -07001049 `, map[string][]byte{
1050 "a.java": nil,
1051 "b.java": nil,
1052 })
Colin Cross54190b32017-10-09 15:34:10 -07001053
1054 javac := ctx.ModuleForTests("foo", "android_common").Rule("javac")
1055 genrule := ctx.ModuleForTests("gen", "").Rule("generator")
1056
Colin Cross15e86d92017-10-20 15:07:08 -07001057 if filepath.Base(genrule.Output.String()) != "gen.java" {
1058 t.Fatalf(`gen output file %v is not ".../gen.java"`, genrule.Output.String())
Colin Cross54190b32017-10-09 15:34:10 -07001059 }
1060
1061 if len(javac.Inputs) != 3 ||
1062 javac.Inputs[0].String() != "a.java" ||
Colin Cross15e86d92017-10-20 15:07:08 -07001063 javac.Inputs[1].String() != genrule.Output.String() ||
Colin Cross54190b32017-10-09 15:34:10 -07001064 javac.Inputs[2].String() != "b.java" {
1065 t.Errorf(`foo inputs %v != ["a.java", ".../gen.java", "b.java"]`, javac.Inputs)
1066 }
1067}
1068
Nan Zhang61eaedb2017-11-02 13:28:15 -07001069func TestTurbine(t *testing.T) {
Jaewoong Jungf9a04432019-07-17 11:15:09 -07001070 ctx, _ := testJava(t, `
Nan Zhang61eaedb2017-11-02 13:28:15 -07001071 java_library {
1072 name: "foo",
1073 srcs: ["a.java"],
Jiyong Park2d492942018-03-05 17:44:10 +09001074 sdk_version: "14",
Nan Zhang61eaedb2017-11-02 13:28:15 -07001075 }
1076
1077 java_library {
1078 name: "bar",
Colin Cross9bc43432017-12-15 20:20:39 -08001079 srcs: ["b.java"],
Nan Zhang61eaedb2017-11-02 13:28:15 -07001080 static_libs: ["foo"],
Jiyong Park2d492942018-03-05 17:44:10 +09001081 sdk_version: "14",
Nan Zhang61eaedb2017-11-02 13:28:15 -07001082 }
1083
1084 java_library {
1085 name: "baz",
1086 srcs: ["c.java"],
1087 libs: ["bar"],
1088 sdk_version: "14",
1089 }
1090 `)
1091
1092 fooTurbine := ctx.ModuleForTests("foo", "android_common").Rule("turbine")
1093 barTurbine := ctx.ModuleForTests("bar", "android_common").Rule("turbine")
1094 barJavac := ctx.ModuleForTests("bar", "android_common").Rule("javac")
1095 barTurbineCombined := ctx.ModuleForTests("bar", "android_common").Description("for turbine")
1096 bazJavac := ctx.ModuleForTests("baz", "android_common").Rule("javac")
1097
1098 if len(fooTurbine.Inputs) != 1 || fooTurbine.Inputs[0].String() != "a.java" {
1099 t.Errorf(`foo inputs %v != ["a.java"]`, fooTurbine.Inputs)
1100 }
1101
1102 fooHeaderJar := filepath.Join(buildDir, ".intermediates", "foo", "android_common", "turbine-combined", "foo.jar")
1103 if !strings.Contains(barTurbine.Args["classpath"], fooHeaderJar) {
1104 t.Errorf("bar turbine classpath %v does not contain %q", barTurbine.Args["classpath"], fooHeaderJar)
1105 }
1106 if !strings.Contains(barJavac.Args["classpath"], fooHeaderJar) {
1107 t.Errorf("bar javac classpath %v does not contain %q", barJavac.Args["classpath"], fooHeaderJar)
1108 }
1109 if len(barTurbineCombined.Inputs) != 2 || barTurbineCombined.Inputs[1].String() != fooHeaderJar {
1110 t.Errorf("bar turbine combineJar inputs %v does not contain %q", barTurbineCombined.Inputs, fooHeaderJar)
1111 }
Anton Hanssonf66efeb2018-04-11 13:57:30 +01001112 if !strings.Contains(bazJavac.Args["classpath"], "prebuilts/sdk/14/public/android.jar") {
Nan Zhang61eaedb2017-11-02 13:28:15 -07001113 t.Errorf("baz javac classpath %v does not contain %q", bazJavac.Args["classpath"],
Anton Hanssonf66efeb2018-04-11 13:57:30 +01001114 "prebuilts/sdk/14/public/android.jar")
Nan Zhang61eaedb2017-11-02 13:28:15 -07001115 }
1116}
1117
1118func TestSharding(t *testing.T) {
Jaewoong Jungf9a04432019-07-17 11:15:09 -07001119 ctx, _ := testJava(t, `
Nan Zhang61eaedb2017-11-02 13:28:15 -07001120 java_library {
1121 name: "bar",
1122 srcs: ["a.java","b.java","c.java"],
1123 javac_shard_size: 1
1124 }
1125 `)
1126
1127 barHeaderJar := filepath.Join(buildDir, ".intermediates", "bar", "android_common", "turbine-combined", "bar.jar")
1128 for i := 0; i < 3; i++ {
1129 barJavac := ctx.ModuleForTests("bar", "android_common").Description("javac" + strconv.Itoa(i))
1130 if !strings.Contains(barJavac.Args["classpath"], barHeaderJar) {
1131 t.Errorf("bar javac classpath %v does not contain %q", barJavac.Args["classpath"], barHeaderJar)
1132 }
1133 }
1134}
1135
Nan Zhang581fd212018-01-10 16:06:12 -08001136func TestDroiddoc(t *testing.T) {
Colin Cross238c1f32020-06-07 16:58:18 -07001137 ctx, _ := testJavaWithFS(t, `
Paul Duffin884363e2019-12-19 10:21:09 +00001138 droiddoc_exported_dir {
Dan Willemsencc090972018-02-26 14:33:31 -08001139 name: "droiddoc-templates-sdk",
1140 path: ".",
1141 }
Jiyong Park29074592019-07-07 16:27:47 +09001142 filegroup {
1143 name: "bar-doc-aidl-srcs",
1144 srcs: ["bar-doc/IBar.aidl"],
1145 path: "bar-doc",
1146 }
Liz Kammere1ab2502020-09-10 15:29:25 +00001147 droidstubs {
1148 name: "bar-stubs",
Liz Kammer3a55c912020-08-14 12:14:02 -07001149 srcs: [
Steve Kim3666c702020-09-01 17:58:01 +00001150 "bar-doc/a.java",
Liz Kammer3a55c912020-08-14 12:14:02 -07001151 ],
Steve Kim3666c702020-09-01 17:58:01 +00001152 exclude_srcs: [
1153 "bar-doc/b.java"
1154 ],
Liz Kammere1ab2502020-09-10 15:29:25 +00001155 api_levels_annotations_dirs: [
1156 "droiddoc-templates-sdk",
1157 ],
1158 api_levels_annotations_enabled: true,
1159 }
1160 droiddoc {
1161 name: "bar-doc",
1162 srcs: [
1163 ":bar-stubs",
1164 "bar-doc/IFoo.aidl",
1165 ":bar-doc-aidl-srcs",
1166 ],
Dan Willemsencc090972018-02-26 14:33:31 -08001167 custom_template: "droiddoc-templates-sdk",
Nan Zhang581fd212018-01-10 16:06:12 -08001168 hdf: [
1169 "android.whichdoc offline",
1170 ],
1171 knowntags: [
1172 "bar-doc/known_oj_tags.txt",
1173 ],
1174 proofread_file: "libcore-proofread.txt",
1175 todo_file: "libcore-docs-todo.html",
Liz Kammer585cac22020-07-06 09:12:57 -07001176 flags: ["-offlinemode -title \"libcore\""],
Nan Zhang581fd212018-01-10 16:06:12 -08001177 }
Colin Cross238c1f32020-06-07 16:58:18 -07001178 `,
1179 map[string][]byte{
1180 "bar-doc/a.java": nil,
1181 "bar-doc/b.java": nil,
1182 })
Liz Kammere1ab2502020-09-10 15:29:25 +00001183 barStubs := ctx.ModuleForTests("bar-stubs", "android_common")
1184 barStubsOutputs, err := barStubs.Module().(*Droidstubs).OutputFiles("")
1185 if err != nil {
1186 t.Errorf("Unexpected error %q retrieving \"bar-stubs\" output file", err)
1187 }
1188 if len(barStubsOutputs) != 1 {
1189 t.Errorf("Expected one output from \"bar-stubs\" got %s", barStubsOutputs)
Liz Kammer1e2ee122020-07-30 15:07:22 -07001190 }
Nan Zhang581fd212018-01-10 16:06:12 -08001191
Liz Kammere1ab2502020-09-10 15:29:25 +00001192 barStubsOutput := barStubsOutputs[0]
1193 barDoc := ctx.ModuleForTests("bar-doc", "android_common")
1194 javaDoc := barDoc.Rule("javadoc")
1195 if g, w := javaDoc.Implicits.Strings(), barStubsOutput.String(); !inList(w, g) {
1196 t.Errorf("implicits of bar-doc must contain %q, but was %q.", w, g)
Jiyong Park29074592019-07-07 16:27:47 +09001197 }
1198
Liz Kammere1ab2502020-09-10 15:29:25 +00001199 expected := "-sourcepath " + buildDir + "/.intermediates/bar-doc/android_common/srcjars "
1200 if !strings.Contains(javaDoc.RuleParams.Command, expected) {
1201 t.Errorf("bar-doc command does not contain flag %q, but should\n%q", expected, javaDoc.RuleParams.Command)
1202 }
1203
1204 aidl := barDoc.Rule("aidl")
1205 if g, w := javaDoc.Implicits.Strings(), aidl.Output.String(); !inList(w, g) {
Colin Crossc0806172019-06-14 18:51:47 -07001206 t.Errorf("implicits of bar-doc must contain %q, but was %q.", w, g)
1207 }
1208
1209 if g, w := aidl.Implicits.Strings(), []string{"bar-doc/IBar.aidl", "bar-doc/IFoo.aidl"}; !reflect.DeepEqual(w, g) {
1210 t.Errorf("aidl inputs must be %q, but was %q", w, g)
Jiyong Park1e440682018-05-23 18:42:04 +09001211 }
Nan Zhang581fd212018-01-10 16:06:12 -08001212}
1213
Liz Kammer585cac22020-07-06 09:12:57 -07001214func TestDroiddocArgsAndFlagsCausesError(t *testing.T) {
1215 testJavaError(t, "flags is set. Cannot set args", `
1216 droiddoc_exported_dir {
1217 name: "droiddoc-templates-sdk",
1218 path: ".",
1219 }
1220 filegroup {
1221 name: "bar-doc-aidl-srcs",
1222 srcs: ["bar-doc/IBar.aidl"],
1223 path: "bar-doc",
1224 }
Liz Kammere1ab2502020-09-10 15:29:25 +00001225 droidstubs {
1226 name: "bar-stubs",
Liz Kammer3a55c912020-08-14 12:14:02 -07001227 srcs: [
Steve Kim3666c702020-09-01 17:58:01 +00001228 "bar-doc/a.java",
Liz Kammer3a55c912020-08-14 12:14:02 -07001229 ],
Steve Kim3666c702020-09-01 17:58:01 +00001230 exclude_srcs: [
1231 "bar-doc/b.java"
1232 ],
Liz Kammere1ab2502020-09-10 15:29:25 +00001233 api_levels_annotations_dirs: [
1234 "droiddoc-templates-sdk",
1235 ],
1236 api_levels_annotations_enabled: true,
1237 }
1238 droiddoc {
1239 name: "bar-doc",
1240 srcs: [
1241 ":bar-stubs",
1242 "bar-doc/IFoo.aidl",
1243 ":bar-doc-aidl-srcs",
1244 ],
Liz Kammer585cac22020-07-06 09:12:57 -07001245 custom_template: "droiddoc-templates-sdk",
1246 hdf: [
1247 "android.whichdoc offline",
1248 ],
1249 knowntags: [
1250 "bar-doc/known_oj_tags.txt",
1251 ],
1252 proofread_file: "libcore-proofread.txt",
1253 todo_file: "libcore-docs-todo.html",
1254 flags: ["-offlinemode -title \"libcore\""],
1255 args: "-offlinemode -title \"libcore\"",
1256 }
1257 `)
1258}
1259
Liz Kammer3d894b72020-08-04 09:55:13 -07001260func TestDroidstubs(t *testing.T) {
1261 ctx, _ := testJavaWithFS(t, `
1262 droiddoc_exported_dir {
Anton Hansson52ac73d2020-10-26 09:57:40 +00001263 name: "droiddoc-templates-sdk",
1264 path: ".",
Liz Kammer3d894b72020-08-04 09:55:13 -07001265 }
1266
1267 droidstubs {
Anton Hansson52ac73d2020-10-26 09:57:40 +00001268 name: "bar-stubs",
1269 srcs: ["bar-doc/a.java"],
1270 api_levels_annotations_dirs: ["droiddoc-templates-sdk"],
1271 api_levels_annotations_enabled: true,
Liz Kammer3d894b72020-08-04 09:55:13 -07001272 }
1273
1274 droidstubs {
Anton Hansson52ac73d2020-10-26 09:57:40 +00001275 name: "bar-stubs-other",
1276 srcs: ["bar-doc/a.java"],
1277 high_mem: true,
1278 api_levels_annotations_dirs: ["droiddoc-templates-sdk"],
1279 api_levels_annotations_enabled: true,
1280 api_levels_jar_filename: "android.other.jar",
Liz Kammer3d894b72020-08-04 09:55:13 -07001281 }
1282 `,
1283 map[string][]byte{
1284 "bar-doc/a.java": nil,
1285 })
1286 testcases := []struct {
1287 moduleName string
1288 expectedJarFilename string
Anton Hansson52ac73d2020-10-26 09:57:40 +00001289 high_mem bool
Liz Kammer3d894b72020-08-04 09:55:13 -07001290 }{
1291 {
1292 moduleName: "bar-stubs",
1293 expectedJarFilename: "android.jar",
Anton Hansson52ac73d2020-10-26 09:57:40 +00001294 high_mem: false,
Liz Kammer3d894b72020-08-04 09:55:13 -07001295 },
1296 {
1297 moduleName: "bar-stubs-other",
1298 expectedJarFilename: "android.other.jar",
Anton Hansson52ac73d2020-10-26 09:57:40 +00001299 high_mem: true,
Liz Kammer3d894b72020-08-04 09:55:13 -07001300 },
1301 }
1302 for _, c := range testcases {
1303 m := ctx.ModuleForTests(c.moduleName, "android_common")
1304 metalava := m.Rule("metalava")
Anton Hansson52ac73d2020-10-26 09:57:40 +00001305 rp := metalava.RuleParams
Liz Kammer3d894b72020-08-04 09:55:13 -07001306 expected := "--android-jar-pattern ./%/public/" + c.expectedJarFilename
Anton Hansson52ac73d2020-10-26 09:57:40 +00001307 if actual := rp.Command; !strings.Contains(actual, expected) {
Liz Kammer3d894b72020-08-04 09:55:13 -07001308 t.Errorf("For %q, expected metalava argument %q, but was not found %q", c.moduleName, expected, actual)
1309 }
Anton Hansson52ac73d2020-10-26 09:57:40 +00001310
1311 if actual := rp.Pool != nil && strings.Contains(rp.Pool.String(), "highmem"); actual != c.high_mem {
1312 t.Errorf("Expected %q high_mem to be %v, was %v", c.moduleName, c.high_mem, actual)
1313 }
Liz Kammer3d894b72020-08-04 09:55:13 -07001314 }
1315}
1316
Paul Duffin83a2d962019-11-19 19:44:10 +00001317func TestDroidstubsWithSystemModules(t *testing.T) {
1318 ctx, _ := testJava(t, `
1319 droidstubs {
1320 name: "stubs-source-system-modules",
1321 srcs: [
Colin Cross238c1f32020-06-07 16:58:18 -07001322 "bar-doc/a.java",
Paul Duffin83a2d962019-11-19 19:44:10 +00001323 ],
1324 sdk_version: "none",
1325 system_modules: "source-system-modules",
1326 }
1327
1328 java_library {
1329 name: "source-jar",
1330 srcs: [
1331 "a.java",
1332 ],
1333 }
1334
1335 java_system_modules {
1336 name: "source-system-modules",
1337 libs: ["source-jar"],
1338 }
1339
1340 droidstubs {
1341 name: "stubs-prebuilt-system-modules",
1342 srcs: [
Colin Cross238c1f32020-06-07 16:58:18 -07001343 "bar-doc/a.java",
Paul Duffin83a2d962019-11-19 19:44:10 +00001344 ],
1345 sdk_version: "none",
1346 system_modules: "prebuilt-system-modules",
1347 }
1348
1349 java_import {
1350 name: "prebuilt-jar",
1351 jars: ["a.jar"],
1352 }
1353
1354 java_system_modules_import {
1355 name: "prebuilt-system-modules",
1356 libs: ["prebuilt-jar"],
1357 }
1358 `)
1359
1360 checkSystemModulesUseByDroidstubs(t, ctx, "stubs-source-system-modules", "source-jar.jar")
1361
1362 checkSystemModulesUseByDroidstubs(t, ctx, "stubs-prebuilt-system-modules", "prebuilt-jar.jar")
1363}
1364
1365func checkSystemModulesUseByDroidstubs(t *testing.T, ctx *android.TestContext, moduleName string, systemJar string) {
1366 metalavaRule := ctx.ModuleForTests(moduleName, "android_common").Rule("metalava")
1367 var systemJars []string
1368 for _, i := range metalavaRule.Implicits {
1369 systemJars = append(systemJars, i.Base())
1370 }
Ramy Medhatc7965cd2020-04-30 03:08:37 -04001371 if len(systemJars) < 1 || systemJars[0] != systemJar {
Paul Duffin83a2d962019-11-19 19:44:10 +00001372 t.Errorf("inputs of %q must be []string{%q}, but was %#v.", moduleName, systemJar, systemJars)
1373 }
1374}
1375
Colin Cross54250902017-12-05 09:28:08 -08001376func TestJarGenrules(t *testing.T) {
Jaewoong Jungf9a04432019-07-17 11:15:09 -07001377 ctx, _ := testJava(t, `
Colin Cross54250902017-12-05 09:28:08 -08001378 java_library {
1379 name: "foo",
1380 srcs: ["a.java"],
1381 }
1382
1383 java_genrule {
1384 name: "jargen",
1385 tool_files: ["b.java"],
1386 cmd: "$(location b.java) $(in) $(out)",
1387 out: ["jargen.jar"],
1388 srcs: [":foo"],
1389 }
1390
1391 java_library {
1392 name: "bar",
1393 static_libs: ["jargen"],
1394 srcs: ["c.java"],
1395 }
1396
1397 java_library {
1398 name: "baz",
1399 libs: ["jargen"],
1400 srcs: ["c.java"],
1401 }
1402 `)
1403
1404 foo := ctx.ModuleForTests("foo", "android_common").Output("javac/foo.jar")
1405 jargen := ctx.ModuleForTests("jargen", "android_common").Output("jargen.jar")
1406 bar := ctx.ModuleForTests("bar", "android_common").Output("javac/bar.jar")
1407 baz := ctx.ModuleForTests("baz", "android_common").Output("javac/baz.jar")
1408 barCombined := ctx.ModuleForTests("bar", "android_common").Output("combined/bar.jar")
1409
Colin Cross3d680512020-11-13 16:23:53 -08001410 if g, w := jargen.Implicits.Strings(), foo.Output.String(); !android.InList(w, g) {
1411 t.Errorf("expected jargen inputs [%q], got %q", w, g)
Colin Cross54250902017-12-05 09:28:08 -08001412 }
1413
1414 if !strings.Contains(bar.Args["classpath"], jargen.Output.String()) {
1415 t.Errorf("bar classpath %v does not contain %q", bar.Args["classpath"], jargen.Output.String())
1416 }
1417
1418 if !strings.Contains(baz.Args["classpath"], jargen.Output.String()) {
1419 t.Errorf("baz classpath %v does not contain %q", baz.Args["classpath"], jargen.Output.String())
1420 }
1421
1422 if len(barCombined.Inputs) != 2 ||
1423 barCombined.Inputs[0].String() != bar.Output.String() ||
1424 barCombined.Inputs[1].String() != jargen.Output.String() {
1425 t.Errorf("bar combined jar inputs %v is not [%q, %q]",
1426 barCombined.Inputs.Strings(), bar.Output.String(), jargen.Output.String())
1427 }
1428}
1429
Nan Zhang27e284d2018-02-09 21:03:53 +00001430func TestExcludeFileGroupInSrcs(t *testing.T) {
Jaewoong Jungf9a04432019-07-17 11:15:09 -07001431 ctx, _ := testJava(t, `
Nan Zhang27e284d2018-02-09 21:03:53 +00001432 java_library {
1433 name: "foo",
1434 srcs: ["a.java", ":foo-srcs"],
1435 exclude_srcs: ["a.java", ":foo-excludes"],
1436 }
1437
1438 filegroup {
1439 name: "foo-srcs",
1440 srcs: ["java-fg/a.java", "java-fg/b.java", "java-fg/c.java"],
1441 }
1442
1443 filegroup {
1444 name: "foo-excludes",
1445 srcs: ["java-fg/a.java", "java-fg/b.java"],
1446 }
1447 `)
1448
1449 javac := ctx.ModuleForTests("foo", "android_common").Rule("javac")
1450
1451 if len(javac.Inputs) != 1 || javac.Inputs[0].String() != "java-fg/c.java" {
1452 t.Errorf(`foo inputs %v != ["java-fg/c.java"]`, javac.Inputs)
1453 }
1454}
Jiyong Parkc678ad32018-04-10 13:07:10 +09001455
Paul Duffin52d398a2019-06-11 12:31:14 +01001456func TestJavaLibrary(t *testing.T) {
Colin Cross98be1bb2019-12-13 20:41:13 -08001457 config := testConfig(nil, "", map[string][]byte{
Paul Duffin52d398a2019-06-11 12:31:14 +01001458 "libcore/Android.bp": []byte(`
1459 java_library {
1460 name: "core",
1461 sdk_version: "none",
1462 system_modules: "none",
Paul Duffinaa55f742020-10-06 17:20:13 +01001463 }
1464
1465 filegroup {
1466 name: "core-jar",
1467 srcs: [":core{.jar}"],
1468 }
1469`),
1470 })
Colin Crossae8600b2020-10-29 17:09:13 -07001471 ctx := testContext(config)
Paul Duffinaa55f742020-10-06 17:20:13 +01001472 run(t, ctx, config)
1473}
1474
1475func TestJavaImport(t *testing.T) {
1476 config := testConfig(nil, "", map[string][]byte{
1477 "libcore/Android.bp": []byte(`
1478 java_import {
1479 name: "core",
1480 sdk_version: "none",
1481 }
1482
1483 filegroup {
1484 name: "core-jar",
1485 srcs: [":core{.jar}"],
1486 }
1487`),
Paul Duffin52d398a2019-06-11 12:31:14 +01001488 })
Colin Crossae8600b2020-10-29 17:09:13 -07001489 ctx := testContext(config)
Paul Duffin52d398a2019-06-11 12:31:14 +01001490 run(t, ctx, config)
1491}
1492
Jiyong Parkc678ad32018-04-10 13:07:10 +09001493func TestJavaSdkLibrary(t *testing.T) {
Jaewoong Jungf9a04432019-07-17 11:15:09 -07001494 ctx, _ := testJava(t, `
Paul Duffin884363e2019-12-19 10:21:09 +00001495 droiddoc_exported_dir {
Jiyong Parkc678ad32018-04-10 13:07:10 +09001496 name: "droiddoc-templates-sdk",
1497 path: ".",
1498 }
Jiyong Parkc678ad32018-04-10 13:07:10 +09001499 java_sdk_library {
1500 name: "foo",
1501 srcs: ["a.java", "b.java"],
1502 api_packages: ["foo"],
1503 }
1504 java_sdk_library {
1505 name: "bar",
1506 srcs: ["a.java", "b.java"],
1507 api_packages: ["bar"],
1508 }
1509 java_library {
1510 name: "baz",
1511 srcs: ["c.java"],
Paul Duffin859fe962020-05-15 10:20:31 +01001512 libs: ["foo", "bar.stubs"],
Jiyong Parkc678ad32018-04-10 13:07:10 +09001513 sdk_version: "system_current",
1514 }
Paul Duffindfa131e2020-05-15 20:37:11 +01001515 java_sdk_library {
1516 name: "barney",
1517 srcs: ["c.java"],
1518 api_only: true,
1519 }
1520 java_sdk_library {
1521 name: "betty",
1522 srcs: ["c.java"],
1523 shared_library: false,
1524 }
Paul Duffin859fe962020-05-15 10:20:31 +01001525 java_sdk_library_import {
1526 name: "quuz",
1527 public: {
1528 jars: ["c.jar"],
1529 },
1530 }
1531 java_sdk_library_import {
1532 name: "fred",
1533 public: {
1534 jars: ["b.jar"],
1535 },
1536 }
Paul Duffindfa131e2020-05-15 20:37:11 +01001537 java_sdk_library_import {
1538 name: "wilma",
1539 public: {
1540 jars: ["b.jar"],
1541 },
1542 shared_library: false,
1543 }
Jiyong Park1be96912018-05-28 18:02:19 +09001544 java_library {
1545 name: "qux",
1546 srcs: ["c.java"],
Paul Duffindfa131e2020-05-15 20:37:11 +01001547 libs: ["baz", "fred", "quuz.stubs", "wilma", "barney", "betty"],
Jiyong Park1be96912018-05-28 18:02:19 +09001548 sdk_version: "system_current",
1549 }
Paul Duffin726d23c2020-01-22 16:30:37 +00001550 java_library {
1551 name: "baz-test",
1552 srcs: ["c.java"],
1553 libs: ["foo"],
1554 sdk_version: "test_current",
1555 }
Paul Duffina2db18f2020-01-22 17:11:15 +00001556 java_library {
1557 name: "baz-29",
1558 srcs: ["c.java"],
1559 libs: ["foo"],
1560 sdk_version: "system_29",
1561 }
Paul Duffinfb6ae5b2020-09-30 15:17:25 +01001562 java_library {
1563 name: "baz-module-30",
1564 srcs: ["c.java"],
1565 libs: ["foo"],
1566 sdk_version: "module_30",
1567 }
Jiyong Parkc678ad32018-04-10 13:07:10 +09001568 `)
1569
1570 // check the existence of the internal modules
1571 ctx.ModuleForTests("foo", "android_common")
Paul Duffindd9d0742020-05-08 15:52:37 +01001572 ctx.ModuleForTests(apiScopePublic.stubsLibraryModuleName("foo"), "android_common")
1573 ctx.ModuleForTests(apiScopeSystem.stubsLibraryModuleName("foo"), "android_common")
1574 ctx.ModuleForTests(apiScopeTest.stubsLibraryModuleName("foo"), "android_common")
1575 ctx.ModuleForTests(apiScopePublic.stubsSourceModuleName("foo"), "android_common")
1576 ctx.ModuleForTests(apiScopeSystem.stubsSourceModuleName("foo"), "android_common")
1577 ctx.ModuleForTests(apiScopeTest.stubsSourceModuleName("foo"), "android_common")
Jiyong Parke3833882020-02-17 17:28:10 +09001578 ctx.ModuleForTests("foo"+sdkXmlFileSuffix, "android_common")
Jiyong Park58c518b2018-05-12 22:29:12 +09001579 ctx.ModuleForTests("foo.api.public.28", "")
1580 ctx.ModuleForTests("foo.api.system.28", "")
1581 ctx.ModuleForTests("foo.api.test.28", "")
Jiyong Parkc678ad32018-04-10 13:07:10 +09001582
1583 bazJavac := ctx.ModuleForTests("baz", "android_common").Rule("javac")
1584 // tests if baz is actually linked to the stubs lib
1585 if !strings.Contains(bazJavac.Args["classpath"], "foo.stubs.system.jar") {
1586 t.Errorf("baz javac classpath %v does not contain %q", bazJavac.Args["classpath"],
1587 "foo.stubs.system.jar")
1588 }
1589 // ... and not to the impl lib
Sundong Ahn054b19a2018-10-19 13:46:09 +09001590 if strings.Contains(bazJavac.Args["classpath"], "foo.jar") {
Jiyong Parkc678ad32018-04-10 13:07:10 +09001591 t.Errorf("baz javac classpath %v should not contain %q", bazJavac.Args["classpath"],
Sundong Ahn054b19a2018-10-19 13:46:09 +09001592 "foo.jar")
Jiyong Parkc678ad32018-04-10 13:07:10 +09001593 }
1594 // test if baz is not linked to the system variant of foo
1595 if strings.Contains(bazJavac.Args["classpath"], "foo.stubs.jar") {
1596 t.Errorf("baz javac classpath %v should not contain %q", bazJavac.Args["classpath"],
1597 "foo.stubs.jar")
1598 }
Jiyong Park1be96912018-05-28 18:02:19 +09001599
Paul Duffin726d23c2020-01-22 16:30:37 +00001600 bazTestJavac := ctx.ModuleForTests("baz-test", "android_common").Rule("javac")
1601 // tests if baz-test is actually linked to the test stubs lib
1602 if !strings.Contains(bazTestJavac.Args["classpath"], "foo.stubs.test.jar") {
1603 t.Errorf("baz-test javac classpath %v does not contain %q", bazTestJavac.Args["classpath"],
1604 "foo.stubs.test.jar")
1605 }
1606
Paul Duffina2db18f2020-01-22 17:11:15 +00001607 baz29Javac := ctx.ModuleForTests("baz-29", "android_common").Rule("javac")
1608 // tests if baz-29 is actually linked to the system 29 stubs lib
1609 if !strings.Contains(baz29Javac.Args["classpath"], "prebuilts/sdk/29/system/foo.jar") {
1610 t.Errorf("baz-29 javac classpath %v does not contain %q", baz29Javac.Args["classpath"],
1611 "prebuilts/sdk/29/system/foo.jar")
1612 }
1613
Paul Duffinfb6ae5b2020-09-30 15:17:25 +01001614 bazModule30Javac := ctx.ModuleForTests("baz-module-30", "android_common").Rule("javac")
1615 // tests if "baz-module-30" is actually linked to the module 30 stubs lib
1616 if !strings.Contains(bazModule30Javac.Args["classpath"], "prebuilts/sdk/30/module-lib/foo.jar") {
1617 t.Errorf("baz-module-30 javac classpath %v does not contain %q", bazModule30Javac.Args["classpath"],
1618 "prebuilts/sdk/30/module-lib/foo.jar")
1619 }
1620
Jiyong Park1be96912018-05-28 18:02:19 +09001621 // test if baz has exported SDK lib names foo and bar to qux
1622 qux := ctx.ModuleForTests("qux", "android_common")
1623 if quxLib, ok := qux.Module().(*Library); ok {
Ulya Trafimovichb23d28c2020-10-08 12:53:58 +01001624 sdkLibs := quxLib.ClassLoaderContexts().UsesLibs()
Ulya Trafimovich8cbc5d22020-11-03 15:15:46 +00001625 if w := []string{"foo", "bar", "fred", "quuz"}; !reflect.DeepEqual(w, sdkLibs) {
Paul Duffin859fe962020-05-15 10:20:31 +01001626 t.Errorf("qux should export %q but exports %q", w, sdkLibs)
Jiyong Park1be96912018-05-28 18:02:19 +09001627 }
1628 }
Jiyong Parkc678ad32018-04-10 13:07:10 +09001629}
Zoran Jovanovic8736ce22018-08-21 17:10:29 +02001630
Anton Hansson7f66efa2020-10-08 14:47:23 +01001631func TestJavaSdkLibrary_StubOrImplOnlyLibs(t *testing.T) {
1632 ctx, _ := testJava(t, `
1633 java_sdk_library {
1634 name: "sdk_lib",
1635 srcs: ["a.java"],
1636 impl_only_libs: ["foo"],
1637 stub_only_libs: ["bar"],
1638 }
1639 java_library {
1640 name: "foo",
1641 srcs: ["a.java"],
1642 sdk_version: "current",
1643 }
1644 java_library {
1645 name: "bar",
1646 srcs: ["a.java"],
1647 sdk_version: "current",
1648 }
1649 `)
1650
1651 for _, implName := range []string{"sdk_lib", "sdk_lib.impl"} {
1652 implJavacCp := ctx.ModuleForTests(implName, "android_common").Rule("javac").Args["classpath"]
1653 if !strings.Contains(implJavacCp, "/foo.jar") || strings.Contains(implJavacCp, "/bar.jar") {
1654 t.Errorf("%v javac classpath %v does not contain foo and not bar", implName, implJavacCp)
1655 }
1656 }
1657 stubName := apiScopePublic.stubsLibraryModuleName("sdk_lib")
1658 stubsJavacCp := ctx.ModuleForTests(stubName, "android_common").Rule("javac").Args["classpath"]
1659 if strings.Contains(stubsJavacCp, "/foo.jar") || !strings.Contains(stubsJavacCp, "/bar.jar") {
1660 t.Errorf("stubs javac classpath %v does not contain bar and not foo", stubsJavacCp)
1661 }
1662}
1663
Paul Duffindaaa3322020-05-26 18:13:57 +01001664func TestJavaSdkLibrary_DoNotAccessImplWhenItIsNotBuilt(t *testing.T) {
1665 ctx, _ := testJava(t, `
1666 java_sdk_library {
1667 name: "foo",
1668 srcs: ["a.java"],
1669 api_only: true,
1670 public: {
1671 enabled: true,
1672 },
1673 }
1674
1675 java_library {
1676 name: "bar",
1677 srcs: ["b.java"],
1678 libs: ["foo"],
1679 }
1680 `)
1681
1682 // The bar library should depend on the stubs jar.
1683 barLibrary := ctx.ModuleForTests("bar", "android_common").Rule("javac")
1684 if expected, actual := `^-classpath .*:/[^:]*/turbine-combined/foo\.stubs\.jar$`, barLibrary.Args["classpath"]; !regexp.MustCompile(expected).MatchString(actual) {
1685 t.Errorf("expected %q, found %#q", expected, actual)
1686 }
1687}
1688
Paul Duffin46dc45a2020-05-14 15:39:10 +01001689func TestJavaSdkLibrary_UseSourcesFromAnotherSdkLibrary(t *testing.T) {
1690 testJava(t, `
1691 java_sdk_library {
1692 name: "foo",
1693 srcs: ["a.java"],
1694 api_packages: ["foo"],
1695 public: {
1696 enabled: true,
1697 },
1698 }
1699
1700 java_library {
1701 name: "bar",
1702 srcs: ["b.java", ":foo{.public.stubs.source}"],
1703 }
1704 `)
1705}
1706
1707func TestJavaSdkLibrary_AccessOutputFiles_MissingScope(t *testing.T) {
1708 testJavaError(t, `"foo" does not provide api scope system`, `
1709 java_sdk_library {
1710 name: "foo",
1711 srcs: ["a.java"],
1712 api_packages: ["foo"],
1713 public: {
1714 enabled: true,
1715 },
1716 }
1717
1718 java_library {
1719 name: "bar",
1720 srcs: ["b.java", ":foo{.system.stubs.source}"],
1721 }
1722 `)
1723}
1724
Paul Duffinca8d9a52020-06-26 22:20:25 +01001725func TestJavaSdkLibrary_Deps(t *testing.T) {
1726 ctx, _ := testJava(t, `
1727 java_sdk_library {
1728 name: "sdklib",
1729 srcs: ["a.java"],
1730 sdk_version: "none",
1731 system_modules: "none",
1732 public: {
1733 enabled: true,
1734 },
1735 }
1736 `)
1737
Paul Duffincee7e662020-07-09 17:32:57 +01001738 CheckModuleDependencies(t, ctx, "sdklib", "android_common", []string{
Paul Duffinca8d9a52020-06-26 22:20:25 +01001739 `dex2oatd`,
1740 `sdklib.impl`,
1741 `sdklib.stubs`,
1742 `sdklib.stubs.source`,
1743 `sdklib.xml`,
1744 })
1745}
1746
Paul Duffin46dc45a2020-05-14 15:39:10 +01001747func TestJavaSdkLibraryImport_AccessOutputFiles(t *testing.T) {
1748 testJava(t, `
1749 java_sdk_library_import {
1750 name: "foo",
1751 public: {
1752 jars: ["a.jar"],
1753 stub_srcs: ["a.java"],
1754 current_api: "api/current.txt",
1755 removed_api: "api/removed.txt",
1756 },
1757 }
1758
1759 java_library {
1760 name: "bar",
1761 srcs: [":foo{.public.stubs.source}"],
1762 java_resources: [
1763 ":foo{.public.api.txt}",
1764 ":foo{.public.removed-api.txt}",
1765 ],
1766 }
1767 `)
1768}
1769
1770func TestJavaSdkLibraryImport_AccessOutputFiles_Invalid(t *testing.T) {
1771 bp := `
1772 java_sdk_library_import {
1773 name: "foo",
1774 public: {
1775 jars: ["a.jar"],
1776 },
1777 }
1778 `
1779
1780 t.Run("stubs.source", func(t *testing.T) {
1781 testJavaError(t, `stubs.source not available for api scope public`, bp+`
1782 java_library {
1783 name: "bar",
1784 srcs: [":foo{.public.stubs.source}"],
1785 java_resources: [
1786 ":foo{.public.api.txt}",
1787 ":foo{.public.removed-api.txt}",
1788 ],
1789 }
1790 `)
1791 })
1792
1793 t.Run("api.txt", func(t *testing.T) {
1794 testJavaError(t, `api.txt not available for api scope public`, bp+`
1795 java_library {
1796 name: "bar",
1797 srcs: ["a.java"],
1798 java_resources: [
1799 ":foo{.public.api.txt}",
1800 ],
1801 }
1802 `)
1803 })
1804
1805 t.Run("removed-api.txt", func(t *testing.T) {
1806 testJavaError(t, `removed-api.txt not available for api scope public`, bp+`
1807 java_library {
1808 name: "bar",
1809 srcs: ["a.java"],
1810 java_resources: [
1811 ":foo{.public.removed-api.txt}",
1812 ],
1813 }
1814 `)
1815 })
1816}
1817
Paul Duffin3375e352020-04-28 10:44:03 +01001818func TestJavaSdkLibrary_InvalidScopes(t *testing.T) {
1819 testJavaError(t, `module "foo": enabled api scope "system" depends on disabled scope "public"`, `
1820 java_sdk_library {
1821 name: "foo",
1822 srcs: ["a.java", "b.java"],
1823 api_packages: ["foo"],
1824 // Explicitly disable public to test the check that ensures the set of enabled
1825 // scopes is consistent.
1826 public: {
1827 enabled: false,
1828 },
1829 system: {
1830 enabled: true,
1831 },
1832 }
1833 `)
1834}
1835
Paul Duffin87a05a32020-05-12 11:50:28 +01001836func TestJavaSdkLibrary_SdkVersion_ForScope(t *testing.T) {
1837 testJava(t, `
1838 java_sdk_library {
1839 name: "foo",
1840 srcs: ["a.java", "b.java"],
1841 api_packages: ["foo"],
1842 system: {
1843 enabled: true,
1844 sdk_version: "module_current",
1845 },
1846 }
1847 `)
1848}
1849
Paul Duffin0c5bae52020-06-02 13:00:08 +01001850func TestJavaSdkLibrary_ModuleLib(t *testing.T) {
1851 testJava(t, `
1852 java_sdk_library {
1853 name: "foo",
1854 srcs: ["a.java", "b.java"],
1855 api_packages: ["foo"],
1856 system: {
1857 enabled: true,
1858 },
1859 module_lib: {
1860 enabled: true,
1861 },
1862 }
1863 `)
1864}
1865
1866func TestJavaSdkLibrary_SystemServer(t *testing.T) {
1867 testJava(t, `
1868 java_sdk_library {
1869 name: "foo",
1870 srcs: ["a.java", "b.java"],
1871 api_packages: ["foo"],
1872 system: {
1873 enabled: true,
1874 },
1875 system_server: {
1876 enabled: true,
1877 },
1878 }
1879 `)
1880}
1881
Paul Duffin803a9562020-05-20 11:52:25 +01001882func TestJavaSdkLibrary_MissingScope(t *testing.T) {
1883 testJavaError(t, `requires api scope module-lib from foo but it only has \[\] available`, `
1884 java_sdk_library {
1885 name: "foo",
1886 srcs: ["a.java"],
1887 public: {
1888 enabled: false,
1889 },
1890 }
1891
1892 java_library {
1893 name: "baz",
1894 srcs: ["a.java"],
1895 libs: ["foo"],
1896 sdk_version: "module_current",
1897 }
1898 `)
1899}
1900
1901func TestJavaSdkLibrary_FallbackScope(t *testing.T) {
1902 testJava(t, `
1903 java_sdk_library {
1904 name: "foo",
1905 srcs: ["a.java"],
1906 system: {
1907 enabled: true,
1908 },
1909 }
1910
1911 java_library {
1912 name: "baz",
1913 srcs: ["a.java"],
1914 libs: ["foo"],
1915 // foo does not have module-lib scope so it should fallback to system
1916 sdk_version: "module_current",
1917 }
1918 `)
1919}
1920
Jiyong Park932cdfe2020-05-28 00:19:53 +09001921func TestJavaSdkLibrary_DefaultToStubs(t *testing.T) {
1922 ctx, _ := testJava(t, `
1923 java_sdk_library {
1924 name: "foo",
1925 srcs: ["a.java"],
1926 system: {
1927 enabled: true,
1928 },
1929 default_to_stubs: true,
1930 }
1931
1932 java_library {
1933 name: "baz",
1934 srcs: ["a.java"],
1935 libs: ["foo"],
1936 // does not have sdk_version set, should fallback to module,
1937 // which will then fallback to system because the module scope
1938 // is not enabled.
1939 }
1940 `)
1941 // The baz library should depend on the system stubs jar.
1942 bazLibrary := ctx.ModuleForTests("baz", "android_common").Rule("javac")
1943 if expected, actual := `^-classpath .*:/[^:]*/turbine-combined/foo\.stubs.system\.jar$`, bazLibrary.Args["classpath"]; !regexp.MustCompile(expected).MatchString(actual) {
1944 t.Errorf("expected %q, found %#q", expected, actual)
1945 }
1946}
1947
Zoran Jovanovic8736ce22018-08-21 17:10:29 +02001948var compilerFlagsTestCases = []struct {
1949 in string
1950 out bool
1951}{
1952 {
1953 in: "a",
1954 out: false,
1955 },
1956 {
1957 in: "-a",
1958 out: true,
1959 },
1960 {
1961 in: "-no-jdk",
1962 out: false,
1963 },
1964 {
1965 in: "-no-stdlib",
1966 out: false,
1967 },
1968 {
1969 in: "-kotlin-home",
1970 out: false,
1971 },
1972 {
1973 in: "-kotlin-home /some/path",
1974 out: false,
1975 },
1976 {
1977 in: "-include-runtime",
1978 out: false,
1979 },
1980 {
1981 in: "-Xintellij-plugin-root",
1982 out: false,
1983 },
1984}
1985
1986type mockContext struct {
1987 android.ModuleContext
1988 result bool
1989}
1990
1991func (ctx *mockContext) PropertyErrorf(property, format string, args ...interface{}) {
1992 // CheckBadCompilerFlags calls this function when the flag should be rejected
1993 ctx.result = false
1994}
1995
1996func TestCompilerFlags(t *testing.T) {
1997 for _, testCase := range compilerFlagsTestCases {
1998 ctx := &mockContext{result: true}
1999 CheckKotlincFlags(ctx, []string{testCase.in})
2000 if ctx.result != testCase.out {
2001 t.Errorf("incorrect output:")
2002 t.Errorf(" input: %#v", testCase.in)
2003 t.Errorf(" expected: %#v", testCase.out)
2004 t.Errorf(" got: %#v", ctx.result)
2005 }
2006 }
2007}
Jaewoong Jung38e4fb22018-12-12 09:01:34 -08002008
2009// TODO(jungjw): Consider making this more robust by ignoring path order.
2010func checkPatchModuleFlag(t *testing.T, ctx *android.TestContext, moduleName string, expected string) {
2011 variables := ctx.ModuleForTests(moduleName, "android_common").Module().VariablesForTests()
2012 flags := strings.Split(variables["javacFlags"], " ")
2013 got := ""
2014 for _, flag := range flags {
2015 keyEnd := strings.Index(flag, "=")
2016 if keyEnd > -1 && flag[:keyEnd] == "--patch-module" {
2017 got = flag[keyEnd+1:]
2018 break
2019 }
2020 }
2021 if expected != got {
2022 t.Errorf("Unexpected patch-module flag for module %q - expected %q, but got %q", moduleName, expected, got)
2023 }
2024}
2025
2026func TestPatchModule(t *testing.T) {
Pete Gillin0c2143e2019-05-02 15:32:11 +01002027 t.Run("Java language level 8", func(t *testing.T) {
Pete Gillin1b3370f2019-10-01 13:57:31 +01002028 // Test with legacy javac -source 1.8 -target 1.8
Pete Gillinbdf5d712019-10-21 14:29:58 +01002029 bp := `
2030 java_library {
2031 name: "foo",
2032 srcs: ["a.java"],
2033 java_version: "1.8",
2034 }
2035
2036 java_library {
2037 name: "bar",
2038 srcs: ["b.java"],
2039 sdk_version: "none",
2040 system_modules: "none",
2041 patch_module: "java.base",
2042 java_version: "1.8",
2043 }
2044
2045 java_library {
2046 name: "baz",
2047 srcs: ["c.java"],
2048 patch_module: "java.base",
2049 java_version: "1.8",
2050 }
2051 `
2052 ctx, _ := testJava(t, bp)
Jaewoong Jung38e4fb22018-12-12 09:01:34 -08002053
2054 checkPatchModuleFlag(t, ctx, "foo", "")
2055 checkPatchModuleFlag(t, ctx, "bar", "")
2056 checkPatchModuleFlag(t, ctx, "baz", "")
2057 })
2058
Pete Gillin0c2143e2019-05-02 15:32:11 +01002059 t.Run("Java language level 9", func(t *testing.T) {
Pete Gillin1b3370f2019-10-01 13:57:31 +01002060 // Test with default javac -source 9 -target 9
Pete Gillinbdf5d712019-10-21 14:29:58 +01002061 bp := `
2062 java_library {
2063 name: "foo",
2064 srcs: ["a.java"],
2065 }
2066
2067 java_library {
2068 name: "bar",
2069 srcs: ["b.java"],
2070 sdk_version: "none",
2071 system_modules: "none",
2072 patch_module: "java.base",
2073 }
2074
2075 java_library {
2076 name: "baz",
Jingwen Chen5136a6e2020-10-30 01:01:35 -04002077 srcs: [
2078 "c.java",
2079 // Tests for b/150878007
2080 "dir/d.java",
2081 "dir2/e.java",
2082 "dir2/f.java",
2083 "nested/dir/g.java"
2084 ],
Pete Gillinbdf5d712019-10-21 14:29:58 +01002085 patch_module: "java.base",
2086 }
2087 `
Pete Gillin1b3370f2019-10-01 13:57:31 +01002088 ctx, _ := testJava(t, bp)
Jaewoong Jung38e4fb22018-12-12 09:01:34 -08002089
2090 checkPatchModuleFlag(t, ctx, "foo", "")
2091 expected := "java.base=.:" + buildDir
2092 checkPatchModuleFlag(t, ctx, "bar", expected)
Jingwen Chen5136a6e2020-10-30 01:01:35 -04002093 expected = "java.base=" + strings.Join([]string{
2094 ".", buildDir, "dir", "dir2", "nested", moduleToPath("ext"), moduleToPath("framework")}, ":")
Jaewoong Jung38e4fb22018-12-12 09:01:34 -08002095 checkPatchModuleFlag(t, ctx, "baz", expected)
2096 })
2097}
Paul Duffina7b9f422020-01-10 17:12:18 +00002098
2099func TestJavaSystemModules(t *testing.T) {
2100 ctx, _ := testJava(t, `
2101 java_system_modules {
2102 name: "system-modules",
2103 libs: ["system-module1", "system-module2"],
2104 }
2105 java_library {
2106 name: "system-module1",
2107 srcs: ["a.java"],
2108 sdk_version: "none",
2109 system_modules: "none",
2110 }
2111 java_library {
2112 name: "system-module2",
2113 srcs: ["b.java"],
2114 sdk_version: "none",
2115 system_modules: "none",
2116 }
2117 `)
2118
2119 // check the existence of the module
2120 systemModules := ctx.ModuleForTests("system-modules", "android_common")
2121
2122 cmd := systemModules.Rule("jarsTosystemModules")
2123
2124 // make sure the command compiles against the supplied modules.
2125 for _, module := range []string{"system-module1.jar", "system-module2.jar"} {
2126 if !strings.Contains(cmd.Args["classpath"], module) {
2127 t.Errorf("system modules classpath %v does not contain %q", cmd.Args["classpath"],
2128 module)
2129 }
2130 }
2131}
Paul Duffin90169ba2020-01-10 17:16:44 +00002132
2133func TestJavaSystemModulesImport(t *testing.T) {
2134 ctx, _ := testJava(t, `
2135 java_system_modules_import {
2136 name: "system-modules",
2137 libs: ["system-module1", "system-module2"],
2138 }
2139 java_import {
2140 name: "system-module1",
2141 jars: ["a.jar"],
2142 }
2143 java_import {
2144 name: "system-module2",
2145 jars: ["b.jar"],
2146 }
2147 `)
2148
2149 // check the existence of the module
2150 systemModules := ctx.ModuleForTests("system-modules", "android_common")
2151
2152 cmd := systemModules.Rule("jarsTosystemModules")
2153
2154 // make sure the command compiles against the supplied modules.
2155 for _, module := range []string{"system-module1.jar", "system-module2.jar"} {
2156 if !strings.Contains(cmd.Args["classpath"], module) {
2157 t.Errorf("system modules classpath %v does not contain %q", cmd.Args["classpath"],
2158 module)
2159 }
2160 }
2161}
Paul Duffin83a2d962019-11-19 19:44:10 +00002162
2163func TestJavaLibraryWithSystemModules(t *testing.T) {
2164 ctx, _ := testJava(t, `
2165 java_library {
2166 name: "lib-with-source-system-modules",
2167 srcs: [
2168 "a.java",
2169 ],
2170 sdk_version: "none",
2171 system_modules: "source-system-modules",
2172 }
2173
2174 java_library {
2175 name: "source-jar",
2176 srcs: [
2177 "a.java",
2178 ],
2179 }
2180
2181 java_system_modules {
2182 name: "source-system-modules",
2183 libs: ["source-jar"],
2184 }
2185
2186 java_library {
2187 name: "lib-with-prebuilt-system-modules",
2188 srcs: [
2189 "a.java",
2190 ],
2191 sdk_version: "none",
2192 system_modules: "prebuilt-system-modules",
2193 }
2194
2195 java_import {
2196 name: "prebuilt-jar",
2197 jars: ["a.jar"],
2198 }
2199
2200 java_system_modules_import {
2201 name: "prebuilt-system-modules",
2202 libs: ["prebuilt-jar"],
2203 }
2204 `)
2205
2206 checkBootClasspathForSystemModule(t, ctx, "lib-with-source-system-modules", "/source-jar.jar")
2207
2208 checkBootClasspathForSystemModule(t, ctx, "lib-with-prebuilt-system-modules", "/prebuilt-jar.jar")
2209}
2210
2211func checkBootClasspathForSystemModule(t *testing.T, ctx *android.TestContext, moduleName string, expectedSuffix string) {
2212 javacRule := ctx.ModuleForTests(moduleName, "android_common").Rule("javac")
2213 bootClasspath := javacRule.Args["bootClasspath"]
2214 if strings.HasPrefix(bootClasspath, "--system ") && strings.HasSuffix(bootClasspath, expectedSuffix) {
2215 t.Errorf("bootclasspath of %q must start with --system and end with %q, but was %#v.", moduleName, expectedSuffix, bootClasspath)
2216 }
2217}
Jiyong Park19604de2020-03-24 16:44:11 +09002218
2219func TestAidlExportIncludeDirsFromImports(t *testing.T) {
2220 ctx, _ := testJava(t, `
2221 java_library {
2222 name: "foo",
2223 srcs: ["aidl/foo/IFoo.aidl"],
2224 libs: ["bar"],
2225 }
2226
2227 java_import {
2228 name: "bar",
2229 jars: ["a.jar"],
2230 aidl: {
2231 export_include_dirs: ["aidl/bar"],
2232 },
2233 }
2234 `)
2235
2236 aidlCommand := ctx.ModuleForTests("foo", "android_common").Rule("aidl").RuleParams.Command
2237 expectedAidlFlag := "-Iaidl/bar"
2238 if !strings.Contains(aidlCommand, expectedAidlFlag) {
2239 t.Errorf("aidl command %q does not contain %q", aidlCommand, expectedAidlFlag)
2240 }
2241}
Liz Kammerdd849a82020-06-12 16:38:45 -07002242
2243func TestDataNativeBinaries(t *testing.T) {
2244 ctx, config := testJava(t, `
2245 java_test_host {
2246 name: "foo",
2247 srcs: ["a.java"],
2248 data_native_bins: ["bin"]
2249 }
2250
2251 python_binary_host {
2252 name: "bin",
2253 srcs: ["bin.py"],
2254 }
2255 `)
2256
2257 buildOS := android.BuildOs.String()
2258
2259 test := ctx.ModuleForTests("foo", buildOS+"_common").Module().(*TestHost)
2260 entries := android.AndroidMkEntriesForTest(t, config, "", test)[0]
2261 expected := []string{buildDir + "/.intermediates/bin/" + buildOS + "_x86_64_PY3/bin:bin"}
2262 actual := entries.EntryMap["LOCAL_COMPATIBILITY_SUPPORT_FILES"]
2263 if !reflect.DeepEqual(expected, actual) {
2264 t.Errorf("Unexpected test data - expected: %q, actual: %q", expected, actual)
2265 }
2266}