blob: 3f7bab1948a7fdb2f938ad01d148ce1338934302 [file] [log] [blame]
Colin Cross72bb3632017-07-13 16:23:21 -07001// Copyright 2017 Google Inc. All rights reserved.
2//
3// Licensed under the Apache License, Version 2.0 (the "License");
4// you may not use this file except in compliance with the License.
5// You may obtain a copy of the License at
6//
7// http://www.apache.org/licenses/LICENSE-2.0
8//
9// Unless required by applicable law or agreed to in writing, software
10// distributed under the License is distributed on an "AS IS" BASIS,
11// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
12// See the License for the specific language governing permissions and
13// limitations under the License.
14
15package java
16
17import (
Colin Cross72bb3632017-07-13 16:23:21 -070018 "io/ioutil"
19 "os"
20 "path/filepath"
Colin Crossc0806172019-06-14 18:51:47 -070021 "reflect"
Paul Duffindaaa3322020-05-26 18:13:57 +010022 "regexp"
Nan Zhang61eaedb2017-11-02 13:28:15 -070023 "strconv"
Colin Cross72bb3632017-07-13 16:23:21 -070024 "strings"
25 "testing"
Colin Cross86a60ae2018-05-29 14:44:55 -070026
Jeongik Cha28df2572019-11-11 10:46:36 +090027 "github.com/google/blueprint/proptools"
28
Colin Crossa4f08812018-10-02 22:03:40 -070029 "android/soong/android"
30 "android/soong/cc"
Colin Crossc28bb0b2019-02-25 14:20:47 -080031 "android/soong/dexpreopt"
Colin Crossa4f08812018-10-02 22:03:40 -070032 "android/soong/genrule"
Liz Kammerdd849a82020-06-12 16:38:45 -070033 "android/soong/python"
Colin Cross72bb3632017-07-13 16:23:21 -070034)
35
36var buildDir string
37
38func setUp() {
39 var err error
40 buildDir, err = ioutil.TempDir("", "soong_java_test")
41 if err != nil {
42 panic(err)
43 }
44}
45
46func tearDown() {
47 os.RemoveAll(buildDir)
48}
49
50func TestMain(m *testing.M) {
51 run := func() int {
52 setUp()
53 defer tearDown()
54
55 return m.Run()
56 }
57
58 os.Exit(run())
59}
Colin Cross527012a2017-11-30 22:56:16 -080060
Colin Cross98be1bb2019-12-13 20:41:13 -080061func testConfig(env map[string]string, bp string, fs map[string][]byte) android.Config {
Martin Stjernholmd90676f2020-01-11 00:37:30 +000062 bp += dexpreopt.BpToolModulesForTest()
63
Martin Stjernholm75a48d82020-01-10 20:32:59 +000064 config := TestConfig(buildDir, env, bp, fs)
65
66 // Set up the global Once cache used for dexpreopt.GlobalSoongConfig, so that
67 // it doesn't create a real one, which would fail.
68 _ = dexpreopt.GlobalSoongConfigForTests(config)
69
70 return config
Colin Cross1369cdb2017-09-29 17:58:17 -070071}
72
Colin Cross98be1bb2019-12-13 20:41:13 -080073func testContext() *android.TestContext {
Colin Cross72bb3632017-07-13 16:23:21 -070074
Colin Cross4c428df2017-09-15 17:36:05 -070075 ctx := android.NewTestArchContext()
Paul Duffinf9b1da02019-12-18 19:51:55 +000076 RegisterJavaBuildComponents(ctx)
77 RegisterAppBuildComponents(ctx)
78 RegisterAARBuildComponents(ctx)
Paul Duffinb0f85072019-12-19 10:28:56 +000079 RegisterGenRuleBuildComponents(ctx)
Paul Duffin43dc1cc2019-12-19 11:18:54 +000080 RegisterSystemModulesBuildComponents(ctx)
Colin Cross4b49b762019-11-22 15:25:03 -080081 ctx.RegisterModuleType("java_plugin", PluginFactory)
Colin Cross4b49b762019-11-22 15:25:03 -080082 ctx.RegisterModuleType("filegroup", android.FileGroupFactory)
83 ctx.RegisterModuleType("genrule", genrule.GenRuleFactory)
Liz Kammerdd849a82020-06-12 16:38:45 -070084 ctx.RegisterModuleType("python_binary_host", python.PythonBinaryHostFactory)
Paul Duffin884363e2019-12-19 10:21:09 +000085 RegisterDocsBuildComponents(ctx)
86 RegisterStubsBuildComponents(ctx)
Paul Duffin43dc1cc2019-12-19 11:18:54 +000087 RegisterSdkLibraryBuildComponents(ctx)
Colin Cross89536d42017-07-07 14:35:50 -070088 ctx.PreArchMutators(android.RegisterDefaultsPreArchMutators)
Paul Duffin44f1d842020-06-26 20:17:02 +010089 ctx.PreArchMutators(android.RegisterComponentsMutator)
Paul Duffina48f7582019-12-19 11:25:19 +000090
91 RegisterPrebuiltApisBuildComponents(ctx)
92
Liz Kammerdd849a82020-06-12 16:38:45 -070093 ctx.PreDepsMutators(python.RegisterPythonPreDepsMutators)
Jaewoong Jungb639a6a2019-05-10 15:16:29 -070094 ctx.PostDepsMutators(android.RegisterOverridePostDepsMutators)
Colin Cross3bc7ffa2017-11-22 16:19:37 -080095 ctx.RegisterPreSingletonType("overlay", android.SingletonFactoryAdaptor(OverlaySingletonFactory))
Colin Cross3047fa22019-04-18 10:56:44 -070096 ctx.RegisterPreSingletonType("sdk_versions", android.SingletonFactoryAdaptor(sdkPreSingletonFactory))
Colin Crossa4f08812018-10-02 22:03:40 -070097
Paul Duffin021f4e52020-07-30 16:04:17 +010098 android.RegisterPrebuiltMutators(ctx)
99
Colin Crossa4f08812018-10-02 22:03:40 -0700100 // Register module types and mutators from cc needed for JNI testing
Paul Duffin77980a82019-12-19 16:01:36 +0000101 cc.RegisterRequiredBuildComponentsForTest(ctx)
Colin Crossa4f08812018-10-02 22:03:40 -0700102
Martin Stjernholmd90676f2020-01-11 00:37:30 +0000103 dexpreopt.RegisterToolModulesForTest(ctx)
104
Colin Cross527012a2017-11-30 22:56:16 -0800105 return ctx
106}
107
108func run(t *testing.T, ctx *android.TestContext, config android.Config) {
Colin Cross6b4a32d2017-12-05 13:42:45 -0800109 t.Helper()
Colin Crossc28bb0b2019-02-25 14:20:47 -0800110
Colin Cross98be1bb2019-12-13 20:41:13 -0800111 pathCtx := android.PathContextForTesting(config)
Martin Stjernholm40f9f3c2020-01-20 18:12:23 +0000112 dexpreopt.SetTestGlobalConfig(config, dexpreopt.GlobalConfigForTests(pathCtx))
Colin Crossc28bb0b2019-02-25 14:20:47 -0800113
Colin Cross98be1bb2019-12-13 20:41:13 -0800114 ctx.Register(config)
Paul Duffinbaccf7e2019-06-11 11:58:30 +0100115 _, errs := ctx.ParseBlueprintsFiles("Android.bp")
Logan Chien42039712018-03-12 16:29:17 +0800116 android.FailIfErrored(t, errs)
Colin Cross72bb3632017-07-13 16:23:21 -0700117 _, errs = ctx.PrepareBuildActions(config)
Logan Chien42039712018-03-12 16:29:17 +0800118 android.FailIfErrored(t, errs)
Colin Cross527012a2017-11-30 22:56:16 -0800119}
120
Jeongik Cha2cc570d2019-10-29 15:44:45 +0900121func testJavaError(t *testing.T, pattern string, bp string) (*android.TestContext, android.Config) {
Jeongik Cha538c0d02019-07-11 15:54:27 +0900122 t.Helper()
Colin Cross98be1bb2019-12-13 20:41:13 -0800123 return testJavaErrorWithConfig(t, pattern, testConfig(nil, bp, nil))
Jeongik Cha2cc570d2019-10-29 15:44:45 +0900124}
125
Colin Cross98be1bb2019-12-13 20:41:13 -0800126func testJavaErrorWithConfig(t *testing.T, pattern string, config android.Config) (*android.TestContext, android.Config) {
Jeongik Cha2cc570d2019-10-29 15:44:45 +0900127 t.Helper()
Colin Cross98be1bb2019-12-13 20:41:13 -0800128 ctx := testContext()
Jeongik Cha538c0d02019-07-11 15:54:27 +0900129
Colin Cross98be1bb2019-12-13 20:41:13 -0800130 pathCtx := android.PathContextForTesting(config)
Martin Stjernholm40f9f3c2020-01-20 18:12:23 +0000131 dexpreopt.SetTestGlobalConfig(config, dexpreopt.GlobalConfigForTests(pathCtx))
Jeongik Cha538c0d02019-07-11 15:54:27 +0900132
Colin Cross98be1bb2019-12-13 20:41:13 -0800133 ctx.Register(config)
Jeongik Cha538c0d02019-07-11 15:54:27 +0900134 _, errs := ctx.ParseBlueprintsFiles("Android.bp")
135 if len(errs) > 0 {
136 android.FailIfNoMatchingErrors(t, pattern, errs)
Jeongik Cha2cc570d2019-10-29 15:44:45 +0900137 return ctx, config
Jeongik Cha538c0d02019-07-11 15:54:27 +0900138 }
139 _, errs = ctx.PrepareBuildActions(config)
140 if len(errs) > 0 {
141 android.FailIfNoMatchingErrors(t, pattern, errs)
Jeongik Cha2cc570d2019-10-29 15:44:45 +0900142 return ctx, config
Jeongik Cha538c0d02019-07-11 15:54:27 +0900143 }
144
145 t.Fatalf("missing expected error %q (0 errors are returned)", pattern)
Jeongik Cha2cc570d2019-10-29 15:44:45 +0900146
147 return ctx, config
Jeongik Cha538c0d02019-07-11 15:54:27 +0900148}
149
Colin Cross238c1f32020-06-07 16:58:18 -0700150func testJavaWithFS(t *testing.T, bp string, fs map[string][]byte) (*android.TestContext, android.Config) {
151 t.Helper()
152 return testJavaWithConfig(t, testConfig(nil, bp, fs))
153}
154
Jaewoong Jungf9a04432019-07-17 11:15:09 -0700155func testJava(t *testing.T, bp string) (*android.TestContext, android.Config) {
Colin Cross6b4a32d2017-12-05 13:42:45 -0800156 t.Helper()
Colin Cross238c1f32020-06-07 16:58:18 -0700157 return testJavaWithFS(t, bp, nil)
Jeongik Cha2cc570d2019-10-29 15:44:45 +0900158}
159
Colin Cross98be1bb2019-12-13 20:41:13 -0800160func testJavaWithConfig(t *testing.T, config android.Config) (*android.TestContext, android.Config) {
Jeongik Cha2cc570d2019-10-29 15:44:45 +0900161 t.Helper()
Colin Cross98be1bb2019-12-13 20:41:13 -0800162 ctx := testContext()
Colin Cross527012a2017-11-30 22:56:16 -0800163 run(t, ctx, config)
Colin Cross72bb3632017-07-13 16:23:21 -0700164
Jaewoong Jungf9a04432019-07-17 11:15:09 -0700165 return ctx, config
Colin Cross72bb3632017-07-13 16:23:21 -0700166}
167
Colin Cross2acdae82017-09-15 19:44:24 -0700168func moduleToPath(name string) string {
169 switch {
170 case name == `""`:
171 return name
Colin Crossfc3674a2017-09-18 17:41:52 -0700172 case strings.HasSuffix(name, ".jar"):
173 return name
Nan Zhanged19fc32017-10-19 13:06:22 -0700174 default:
175 return filepath.Join(buildDir, ".intermediates", name, "android_common", "turbine-combined", name+".jar")
Colin Cross2acdae82017-09-15 19:44:24 -0700176 }
177}
178
Jeongik Chae403e9e2019-12-07 00:16:24 +0900179func TestJavaLinkType(t *testing.T) {
180 testJava(t, `
181 java_library {
182 name: "foo",
183 srcs: ["a.java"],
184 libs: ["bar"],
185 static_libs: ["baz"],
186 }
187
188 java_library {
189 name: "bar",
190 sdk_version: "current",
191 srcs: ["b.java"],
192 }
193
194 java_library {
195 name: "baz",
196 sdk_version: "system_current",
197 srcs: ["c.java"],
198 }
199 `)
200
201 testJavaError(t, "Adjust sdk_version: property of the source or target module so that target module is built with the same or smaller API set than the source.", `
202 java_library {
203 name: "foo",
204 srcs: ["a.java"],
205 libs: ["bar"],
206 sdk_version: "current",
207 static_libs: ["baz"],
208 }
209
210 java_library {
211 name: "bar",
212 sdk_version: "current",
213 srcs: ["b.java"],
214 }
215
216 java_library {
217 name: "baz",
218 sdk_version: "system_current",
219 srcs: ["c.java"],
220 }
221 `)
222
223 testJava(t, `
224 java_library {
225 name: "foo",
226 srcs: ["a.java"],
227 libs: ["bar"],
228 sdk_version: "system_current",
229 static_libs: ["baz"],
230 }
231
232 java_library {
233 name: "bar",
234 sdk_version: "current",
235 srcs: ["b.java"],
236 }
237
238 java_library {
239 name: "baz",
240 sdk_version: "system_current",
241 srcs: ["c.java"],
242 }
243 `)
244
245 testJavaError(t, "Adjust sdk_version: property of the source or target module so that target module is built with the same or smaller API set than the source.", `
246 java_library {
247 name: "foo",
248 srcs: ["a.java"],
249 libs: ["bar"],
250 sdk_version: "system_current",
251 static_libs: ["baz"],
252 }
253
254 java_library {
255 name: "bar",
256 sdk_version: "current",
257 srcs: ["b.java"],
258 }
259
260 java_library {
261 name: "baz",
262 srcs: ["c.java"],
263 }
264 `)
265}
266
Colin Cross72bb3632017-07-13 16:23:21 -0700267func TestSimple(t *testing.T) {
Jaewoong Jungf9a04432019-07-17 11:15:09 -0700268 ctx, _ := testJava(t, `
Colin Cross72bb3632017-07-13 16:23:21 -0700269 java_library {
270 name: "foo",
271 srcs: ["a.java"],
Colin Crosse8dc34a2017-07-19 11:22:16 -0700272 libs: ["bar"],
273 static_libs: ["baz"],
Colin Cross72bb3632017-07-13 16:23:21 -0700274 }
275
276 java_library {
277 name: "bar",
278 srcs: ["b.java"],
279 }
280
281 java_library {
282 name: "baz",
283 srcs: ["c.java"],
284 }
Colin Crossd5934c82017-10-02 13:55:26 -0700285 `)
Colin Cross72bb3632017-07-13 16:23:21 -0700286
Colin Cross4c428df2017-09-15 17:36:05 -0700287 javac := ctx.ModuleForTests("foo", "android_common").Rule("javac")
Nan Zhanged19fc32017-10-19 13:06:22 -0700288 combineJar := ctx.ModuleForTests("foo", "android_common").Description("for javac")
Colin Cross72bb3632017-07-13 16:23:21 -0700289
290 if len(javac.Inputs) != 1 || javac.Inputs[0].String() != "a.java" {
291 t.Errorf(`foo inputs %v != ["a.java"]`, javac.Inputs)
292 }
293
Colin Cross1ee23172017-10-18 14:44:18 -0700294 baz := ctx.ModuleForTests("baz", "android_common").Rule("javac").Output.String()
Nan Zhanged19fc32017-10-19 13:06:22 -0700295 barTurbine := filepath.Join(buildDir, ".intermediates", "bar", "android_common", "turbine-combined", "bar.jar")
296 bazTurbine := filepath.Join(buildDir, ".intermediates", "baz", "android_common", "turbine-combined", "baz.jar")
Colin Cross0a6e0072017-08-30 14:24:55 -0700297
Nan Zhanged19fc32017-10-19 13:06:22 -0700298 if !strings.Contains(javac.Args["classpath"], barTurbine) {
299 t.Errorf("foo classpath %v does not contain %q", javac.Args["classpath"], barTurbine)
Colin Cross72bb3632017-07-13 16:23:21 -0700300 }
301
Nan Zhanged19fc32017-10-19 13:06:22 -0700302 if !strings.Contains(javac.Args["classpath"], bazTurbine) {
303 t.Errorf("foo classpath %v does not contain %q", javac.Args["classpath"], bazTurbine)
Colin Cross0a6e0072017-08-30 14:24:55 -0700304 }
305
306 if len(combineJar.Inputs) != 2 || combineJar.Inputs[1].String() != baz {
307 t.Errorf("foo combineJar inputs %v does not contain %q", combineJar.Inputs, baz)
Colin Cross72bb3632017-07-13 16:23:21 -0700308 }
309}
310
Artur Satayev9cf46692019-11-26 18:08:34 +0000311func TestExportedPlugins(t *testing.T) {
312 type Result struct {
313 library string
314 processors string
315 }
316 var tests = []struct {
317 name string
318 extra string
319 results []Result
320 }{
321 {
322 name: "Exported plugin is not a direct plugin",
323 extra: `java_library { name: "exports", srcs: ["a.java"], exported_plugins: ["plugin"] }`,
324 results: []Result{{library: "exports", processors: "-proc:none"}},
325 },
326 {
327 name: "Exports plugin to dependee",
328 extra: `
329 java_library{name: "exports", exported_plugins: ["plugin"]}
330 java_library{name: "foo", srcs: ["a.java"], libs: ["exports"]}
331 java_library{name: "bar", srcs: ["a.java"], static_libs: ["exports"]}
332 `,
333 results: []Result{
334 {library: "foo", processors: "-processor com.android.TestPlugin"},
335 {library: "bar", processors: "-processor com.android.TestPlugin"},
336 },
337 },
338 {
339 name: "Exports plugin to android_library",
340 extra: `
341 java_library{name: "exports", exported_plugins: ["plugin"]}
342 android_library{name: "foo", srcs: ["a.java"], libs: ["exports"]}
343 android_library{name: "bar", srcs: ["a.java"], static_libs: ["exports"]}
344 `,
345 results: []Result{
346 {library: "foo", processors: "-processor com.android.TestPlugin"},
347 {library: "bar", processors: "-processor com.android.TestPlugin"},
348 },
349 },
350 {
351 name: "Exports plugin is not propagated via transitive deps",
352 extra: `
353 java_library{name: "exports", exported_plugins: ["plugin"]}
354 java_library{name: "foo", srcs: ["a.java"], libs: ["exports"]}
355 java_library{name: "bar", srcs: ["a.java"], static_libs: ["foo"]}
356 `,
357 results: []Result{
358 {library: "foo", processors: "-processor com.android.TestPlugin"},
359 {library: "bar", processors: "-proc:none"},
360 },
361 },
362 {
363 name: "Exports plugin appends to plugins",
364 extra: `
365 java_plugin{name: "plugin2", processor_class: "com.android.TestPlugin2"}
366 java_library{name: "exports", exported_plugins: ["plugin"]}
367 java_library{name: "foo", srcs: ["a.java"], libs: ["exports"], plugins: ["plugin2"]}
368 `,
369 results: []Result{
370 {library: "foo", processors: "-processor com.android.TestPlugin,com.android.TestPlugin2"},
371 },
372 },
373 }
374
375 for _, test := range tests {
376 t.Run(test.name, func(t *testing.T) {
377 ctx, _ := testJava(t, `
378 java_plugin {
379 name: "plugin",
380 processor_class: "com.android.TestPlugin",
381 }
382 `+test.extra)
383
384 for _, want := range test.results {
385 javac := ctx.ModuleForTests(want.library, "android_common").Rule("javac")
386 if javac.Args["processor"] != want.processors {
387 t.Errorf("For library %v, expected %v, found %v", want.library, want.processors, javac.Args["processor"])
388 }
389 }
390 })
391 }
392}
393
Jeongik Cha2cc570d2019-10-29 15:44:45 +0900394func TestSdkVersionByPartition(t *testing.T) {
395 testJavaError(t, "sdk_version must have a value when the module is located at vendor or product", `
Jeongik Cha6bd33c12019-06-25 16:26:18 +0900396 java_library {
397 name: "foo",
398 srcs: ["a.java"],
399 vendor: true,
400 }
Jeongik Cha2cc570d2019-10-29 15:44:45 +0900401 `)
Jeongik Cha6bd33c12019-06-25 16:26:18 +0900402
Jeongik Cha2cc570d2019-10-29 15:44:45 +0900403 testJava(t, `
Jeongik Cha6bd33c12019-06-25 16:26:18 +0900404 java_library {
405 name: "bar",
406 srcs: ["b.java"],
407 }
408 `)
409
Jeongik Cha2cc570d2019-10-29 15:44:45 +0900410 for _, enforce := range []bool{true, false} {
Jeongik Cha2cc570d2019-10-29 15:44:45 +0900411 bp := `
412 java_library {
413 name: "foo",
414 srcs: ["a.java"],
415 product_specific: true,
416 }
417 `
Colin Cross98be1bb2019-12-13 20:41:13 -0800418
419 config := testConfig(nil, bp, nil)
420 config.TestProductVariables.EnforceProductPartitionInterface = proptools.BoolPtr(enforce)
Jeongik Cha2cc570d2019-10-29 15:44:45 +0900421 if enforce {
Colin Cross98be1bb2019-12-13 20:41:13 -0800422 testJavaErrorWithConfig(t, "sdk_version must have a value when the module is located at vendor or product", config)
Jeongik Cha2cc570d2019-10-29 15:44:45 +0900423 } else {
Colin Cross98be1bb2019-12-13 20:41:13 -0800424 testJavaWithConfig(t, config)
Jeongik Cha2cc570d2019-10-29 15:44:45 +0900425 }
Jeongik Cha6bd33c12019-06-25 16:26:18 +0900426 }
427}
428
Colin Crossd5934c82017-10-02 13:55:26 -0700429func TestArchSpecific(t *testing.T) {
Jaewoong Jungf9a04432019-07-17 11:15:09 -0700430 ctx, _ := testJava(t, `
Colin Crossd5934c82017-10-02 13:55:26 -0700431 java_library {
432 name: "foo",
433 srcs: ["a.java"],
434 target: {
435 android: {
436 srcs: ["b.java"],
437 },
438 },
439 }
440 `)
441
442 javac := ctx.ModuleForTests("foo", "android_common").Rule("javac")
443 if len(javac.Inputs) != 2 || javac.Inputs[0].String() != "a.java" || javac.Inputs[1].String() != "b.java" {
444 t.Errorf(`foo inputs %v != ["a.java", "b.java"]`, javac.Inputs)
445 }
446}
447
Colin Cross6b4a32d2017-12-05 13:42:45 -0800448func TestBinary(t *testing.T) {
Jaewoong Jungf9a04432019-07-17 11:15:09 -0700449 ctx, _ := testJava(t, `
Colin Cross6b4a32d2017-12-05 13:42:45 -0800450 java_library_host {
451 name: "foo",
452 srcs: ["a.java"],
453 }
454
455 java_binary_host {
456 name: "bar",
457 srcs: ["b.java"],
458 static_libs: ["foo"],
459 }
460 `)
461
462 buildOS := android.BuildOs.String()
463
464 bar := ctx.ModuleForTests("bar", buildOS+"_common")
465 barJar := bar.Output("bar.jar").Output.String()
466 barWrapper := ctx.ModuleForTests("bar", buildOS+"_x86_64")
467 barWrapperDeps := barWrapper.Output("bar").Implicits.Strings()
468
469 // Test that the install binary wrapper depends on the installed jar file
470 if len(barWrapperDeps) != 1 || barWrapperDeps[0] != barJar {
471 t.Errorf("expected binary wrapper implicits [%q], got %v",
472 barJar, barWrapperDeps)
473 }
Alex Humesky2070e322020-06-09 20:23:08 -0400474}
Colin Cross6b4a32d2017-12-05 13:42:45 -0800475
Alex Humesky2070e322020-06-09 20:23:08 -0400476func TestHostBinaryNoJavaDebugInfoOverride(t *testing.T) {
477 bp := `
478 java_library {
479 name: "target_library",
480 srcs: ["a.java"],
481 }
482
483 java_binary_host {
484 name: "host_binary",
485 srcs: ["b.java"],
486 }
487 `
488 config := testConfig(nil, bp, nil)
489 config.TestProductVariables.MinimizeJavaDebugInfo = proptools.BoolPtr(true)
490
491 ctx, _ := testJavaWithConfig(t, config)
492
Liz Kammer7941b302020-07-28 13:27:34 -0700493 // first, check that the -g flag is added to target modules
Alex Humesky2070e322020-06-09 20:23:08 -0400494 targetLibrary := ctx.ModuleForTests("target_library", "android_common")
495 targetJavaFlags := targetLibrary.Module().VariablesForTests()["javacFlags"]
496 if !strings.Contains(targetJavaFlags, "-g:source,lines") {
497 t.Errorf("target library javac flags %v should contain "+
498 "-g:source,lines override with MinimizeJavaDebugInfo", targetJavaFlags)
499 }
500
501 // check that -g is not overridden for host modules
502 buildOS := android.BuildOs.String()
503 hostBinary := ctx.ModuleForTests("host_binary", buildOS+"_common")
504 hostJavaFlags := hostBinary.Module().VariablesForTests()["javacFlags"]
505 if strings.Contains(hostJavaFlags, "-g:source,lines") {
506 t.Errorf("java_binary_host javac flags %v should not have "+
507 "-g:source,lines override with MinimizeJavaDebugInfo", hostJavaFlags)
508 }
Colin Cross6b4a32d2017-12-05 13:42:45 -0800509}
510
Colin Cross72bb3632017-07-13 16:23:21 -0700511func TestPrebuilts(t *testing.T) {
Jaewoong Jungf9a04432019-07-17 11:15:09 -0700512 ctx, _ := testJava(t, `
Colin Cross72bb3632017-07-13 16:23:21 -0700513 java_library {
514 name: "foo",
Paul Duffin91547182019-11-12 19:39:36 +0000515 srcs: ["a.java", ":stubs-source"],
Paul Duffinfcfd7912020-01-31 17:54:30 +0000516 libs: ["bar", "sdklib"],
Colin Crosse8dc34a2017-07-19 11:22:16 -0700517 static_libs: ["baz"],
Colin Cross72bb3632017-07-13 16:23:21 -0700518 }
519
Colin Cross74d73e22017-08-02 11:05:49 -0700520 java_import {
Colin Cross72bb3632017-07-13 16:23:21 -0700521 name: "bar",
Colin Cross74d73e22017-08-02 11:05:49 -0700522 jars: ["a.jar"],
Colin Cross72bb3632017-07-13 16:23:21 -0700523 }
524
Colin Cross74d73e22017-08-02 11:05:49 -0700525 java_import {
Colin Cross72bb3632017-07-13 16:23:21 -0700526 name: "baz",
Colin Cross74d73e22017-08-02 11:05:49 -0700527 jars: ["b.jar"],
Liz Kammerd6c31d22020-08-05 15:40:41 -0700528 sdk_version: "current",
529 compile_dex: true,
Colin Cross72bb3632017-07-13 16:23:21 -0700530 }
Colin Cross42be7612019-02-21 18:12:14 -0800531
532 dex_import {
533 name: "qux",
534 jars: ["b.jar"],
535 }
Colin Cross79c7c262019-04-17 11:11:46 -0700536
537 java_sdk_library_import {
Paul Duffin56d44902020-01-31 13:36:25 +0000538 name: "sdklib",
539 public: {
540 jars: ["c.jar"],
541 },
542 }
543
Paul Duffin91547182019-11-12 19:39:36 +0000544 prebuilt_stubs_sources {
545 name: "stubs-source",
Paul Duffin9b478b02019-12-10 13:41:51 +0000546 srcs: ["stubs/sources"],
Paul Duffin91547182019-11-12 19:39:36 +0000547 }
Paul Duffin1b82e6a2019-12-03 18:06:47 +0000548
549 java_test_import {
550 name: "test",
551 jars: ["a.jar"],
552 test_suites: ["cts"],
553 test_config: "AndroidTest.xml",
554 }
Colin Cross72bb3632017-07-13 16:23:21 -0700555 `)
556
Paul Duffin9b478b02019-12-10 13:41:51 +0000557 fooModule := ctx.ModuleForTests("foo", "android_common")
558 javac := fooModule.Rule("javac")
Nan Zhanged19fc32017-10-19 13:06:22 -0700559 combineJar := ctx.ModuleForTests("foo", "android_common").Description("for javac")
Liz Kammerd6c31d22020-08-05 15:40:41 -0700560 barModule := ctx.ModuleForTests("bar", "android_common")
561 barJar := barModule.Rule("combineJar").Output
562 bazModule := ctx.ModuleForTests("baz", "android_common")
563 bazJar := bazModule.Rule("combineJar").Output
Colin Cross79c7c262019-04-17 11:11:46 -0700564 sdklibStubsJar := ctx.ModuleForTests("sdklib.stubs", "android_common").Rule("combineJar").Output
Colin Cross72bb3632017-07-13 16:23:21 -0700565
Paul Duffin9b478b02019-12-10 13:41:51 +0000566 fooLibrary := fooModule.Module().(*Library)
567 assertDeepEquals(t, "foo java sources incorrect",
568 []string{"a.java"}, fooLibrary.compiledJavaSrcs.Strings())
Paul Duffin91547182019-11-12 19:39:36 +0000569
Paul Duffin9b478b02019-12-10 13:41:51 +0000570 assertDeepEquals(t, "foo java source jars incorrect",
571 []string{".intermediates/stubs-source/android_common/stubs-source-stubs.srcjar"},
572 android.NormalizePathsForTesting(fooLibrary.compiledSrcJars))
Paul Duffin91547182019-11-12 19:39:36 +0000573
Colin Cross37f6d792018-07-12 12:28:41 -0700574 if !strings.Contains(javac.Args["classpath"], barJar.String()) {
575 t.Errorf("foo classpath %v does not contain %q", javac.Args["classpath"], barJar.String())
Colin Cross72bb3632017-07-13 16:23:21 -0700576 }
577
Liz Kammerd6c31d22020-08-05 15:40:41 -0700578 barDexJar := barModule.Module().(*Import).DexJarBuildPath()
579 if barDexJar != nil {
580 t.Errorf("bar dex jar build path expected to be nil, got %q", barDexJar)
581 }
582
Colin Cross79c7c262019-04-17 11:11:46 -0700583 if !strings.Contains(javac.Args["classpath"], sdklibStubsJar.String()) {
584 t.Errorf("foo classpath %v does not contain %q", javac.Args["classpath"], sdklibStubsJar.String())
585 }
586
Colin Cross37f6d792018-07-12 12:28:41 -0700587 if len(combineJar.Inputs) != 2 || combineJar.Inputs[1].String() != bazJar.String() {
588 t.Errorf("foo combineJar inputs %v does not contain %q", combineJar.Inputs, bazJar.String())
Colin Cross72bb3632017-07-13 16:23:21 -0700589 }
Colin Cross42be7612019-02-21 18:12:14 -0800590
Liz Kammerd6c31d22020-08-05 15:40:41 -0700591 bazDexJar := bazModule.Module().(*Import).DexJarBuildPath().String()
592 expectedDexJar := buildDir + "/.intermediates/baz/android_common/dex/baz.jar"
593 if bazDexJar != expectedDexJar {
594 t.Errorf("baz dex jar build path expected %q, got %q", expectedDexJar, bazDexJar)
595 }
596
Colin Cross42be7612019-02-21 18:12:14 -0800597 ctx.ModuleForTests("qux", "android_common").Rule("Cp")
Colin Cross72bb3632017-07-13 16:23:21 -0700598}
599
Paul Duffin9b478b02019-12-10 13:41:51 +0000600func assertDeepEquals(t *testing.T, message string, expected interface{}, actual interface{}) {
601 if !reflect.DeepEqual(expected, actual) {
602 t.Errorf("%s: expected %q, found %q", message, expected, actual)
603 }
604}
605
Paul Duffin56d44902020-01-31 13:36:25 +0000606func TestJavaSdkLibraryImport(t *testing.T) {
607 ctx, _ := testJava(t, `
608 java_library {
609 name: "foo",
610 srcs: ["a.java"],
611 libs: ["sdklib"],
612 sdk_version: "current",
613 }
614
615 java_library {
616 name: "foo.system",
617 srcs: ["a.java"],
618 libs: ["sdklib"],
619 sdk_version: "system_current",
620 }
621
622 java_library {
623 name: "foo.test",
624 srcs: ["a.java"],
625 libs: ["sdklib"],
626 sdk_version: "test_current",
627 }
628
629 java_sdk_library_import {
630 name: "sdklib",
631 public: {
632 jars: ["a.jar"],
633 },
634 system: {
635 jars: ["b.jar"],
636 },
637 test: {
638 jars: ["c.jar"],
Paul Duffin0f8faff2020-05-20 16:18:00 +0100639 stub_srcs: ["c.java"],
Paul Duffin56d44902020-01-31 13:36:25 +0000640 },
641 }
642 `)
643
644 for _, scope := range []string{"", ".system", ".test"} {
645 fooModule := ctx.ModuleForTests("foo"+scope, "android_common")
646 javac := fooModule.Rule("javac")
647
648 sdklibStubsJar := ctx.ModuleForTests("sdklib.stubs"+scope, "android_common").Rule("combineJar").Output
649 if !strings.Contains(javac.Args["classpath"], sdklibStubsJar.String()) {
650 t.Errorf("foo classpath %v does not contain %q", javac.Args["classpath"], sdklibStubsJar.String())
651 }
652 }
Paul Duffinca8d9a52020-06-26 22:20:25 +0100653
Paul Duffincee7e662020-07-09 17:32:57 +0100654 CheckModuleDependencies(t, ctx, "sdklib", "android_common", []string{
Paul Duffinca8d9a52020-06-26 22:20:25 +0100655 `prebuilt_sdklib.stubs`,
656 `prebuilt_sdklib.stubs.source.test`,
657 `prebuilt_sdklib.stubs.system`,
658 `prebuilt_sdklib.stubs.test`,
659 })
660}
661
662func TestJavaSdkLibraryImport_WithSource(t *testing.T) {
663 ctx, _ := testJava(t, `
664 java_sdk_library {
665 name: "sdklib",
666 srcs: ["a.java"],
667 sdk_version: "none",
668 system_modules: "none",
669 public: {
670 enabled: true,
671 },
672 }
673
674 java_sdk_library_import {
675 name: "sdklib",
676 public: {
677 jars: ["a.jar"],
678 },
679 }
680 `)
681
Paul Duffincee7e662020-07-09 17:32:57 +0100682 CheckModuleDependencies(t, ctx, "sdklib", "android_common", []string{
Paul Duffinca8d9a52020-06-26 22:20:25 +0100683 `dex2oatd`,
684 `prebuilt_sdklib`,
685 `sdklib.impl`,
686 `sdklib.stubs`,
687 `sdklib.stubs.source`,
688 `sdklib.xml`,
689 })
690
Paul Duffincee7e662020-07-09 17:32:57 +0100691 CheckModuleDependencies(t, ctx, "prebuilt_sdklib", "android_common", []string{
Paul Duffin44f1d842020-06-26 20:17:02 +0100692 `prebuilt_sdklib.stubs`,
Paul Duffinca8d9a52020-06-26 22:20:25 +0100693 `sdklib.impl`,
694 // This should be prebuilt_sdklib.stubs but is set to sdklib.stubs because the
695 // dependency is added after prebuilts may have been renamed and so has to use
696 // the renamed name.
Paul Duffinca8d9a52020-06-26 22:20:25 +0100697 `sdklib.xml`,
698 })
699}
700
701func TestJavaSdkLibraryImport_Preferred(t *testing.T) {
702 ctx, _ := testJava(t, `
703 java_sdk_library {
704 name: "sdklib",
705 srcs: ["a.java"],
706 sdk_version: "none",
707 system_modules: "none",
708 public: {
709 enabled: true,
710 },
711 }
712
713 java_sdk_library_import {
714 name: "sdklib",
715 prefer: true,
716 public: {
717 jars: ["a.jar"],
718 },
719 }
720 `)
721
Paul Duffincee7e662020-07-09 17:32:57 +0100722 CheckModuleDependencies(t, ctx, "sdklib", "android_common", []string{
Paul Duffinca8d9a52020-06-26 22:20:25 +0100723 `dex2oatd`,
724 `prebuilt_sdklib`,
Paul Duffinca8d9a52020-06-26 22:20:25 +0100725 `sdklib.impl`,
Paul Duffin80342d72020-06-26 22:08:43 +0100726 `sdklib.stubs`,
Paul Duffinca8d9a52020-06-26 22:20:25 +0100727 `sdklib.stubs.source`,
728 `sdklib.xml`,
729 })
730
Paul Duffincee7e662020-07-09 17:32:57 +0100731 CheckModuleDependencies(t, ctx, "prebuilt_sdklib", "android_common", []string{
Paul Duffinca8d9a52020-06-26 22:20:25 +0100732 `prebuilt_sdklib.stubs`,
733 `sdklib.impl`,
734 `sdklib.xml`,
735 })
Paul Duffin56d44902020-01-31 13:36:25 +0000736}
737
Colin Cross89536d42017-07-07 14:35:50 -0700738func TestDefaults(t *testing.T) {
Jaewoong Jungf9a04432019-07-17 11:15:09 -0700739 ctx, _ := testJava(t, `
Colin Cross89536d42017-07-07 14:35:50 -0700740 java_defaults {
741 name: "defaults",
742 srcs: ["a.java"],
743 libs: ["bar"],
744 static_libs: ["baz"],
Sasha Smundak2057f822019-04-16 17:16:58 -0700745 optimize: {enabled: false},
Colin Cross89536d42017-07-07 14:35:50 -0700746 }
747
748 java_library {
749 name: "foo",
750 defaults: ["defaults"],
751 }
752
753 java_library {
754 name: "bar",
755 srcs: ["b.java"],
756 }
757
758 java_library {
759 name: "baz",
760 srcs: ["c.java"],
761 }
Sasha Smundak2057f822019-04-16 17:16:58 -0700762
763 android_test {
764 name: "atestOptimize",
765 defaults: ["defaults"],
766 optimize: {enabled: true},
767 }
768
769 android_test {
770 name: "atestNoOptimize",
771 defaults: ["defaults"],
772 }
773
774 android_test {
775 name: "atestDefault",
776 srcs: ["a.java"],
777 }
Colin Cross89536d42017-07-07 14:35:50 -0700778 `)
779
Colin Cross4c428df2017-09-15 17:36:05 -0700780 javac := ctx.ModuleForTests("foo", "android_common").Rule("javac")
Nan Zhanged19fc32017-10-19 13:06:22 -0700781 combineJar := ctx.ModuleForTests("foo", "android_common").Description("for javac")
Colin Cross89536d42017-07-07 14:35:50 -0700782
783 if len(javac.Inputs) != 1 || javac.Inputs[0].String() != "a.java" {
784 t.Errorf(`foo inputs %v != ["a.java"]`, javac.Inputs)
785 }
786
Nan Zhanged19fc32017-10-19 13:06:22 -0700787 barTurbine := filepath.Join(buildDir, ".intermediates", "bar", "android_common", "turbine-combined", "bar.jar")
788 if !strings.Contains(javac.Args["classpath"], barTurbine) {
789 t.Errorf("foo classpath %v does not contain %q", javac.Args["classpath"], barTurbine)
Colin Cross89536d42017-07-07 14:35:50 -0700790 }
791
Colin Cross1ee23172017-10-18 14:44:18 -0700792 baz := ctx.ModuleForTests("baz", "android_common").Rule("javac").Output.String()
Colin Cross0a6e0072017-08-30 14:24:55 -0700793 if len(combineJar.Inputs) != 2 || combineJar.Inputs[1].String() != baz {
794 t.Errorf("foo combineJar inputs %v does not contain %q", combineJar.Inputs, baz)
Colin Cross89536d42017-07-07 14:35:50 -0700795 }
Sasha Smundak2057f822019-04-16 17:16:58 -0700796
797 atestOptimize := ctx.ModuleForTests("atestOptimize", "android_common").MaybeRule("r8")
798 if atestOptimize.Output == nil {
799 t.Errorf("atestOptimize should optimize APK")
800 }
801
802 atestNoOptimize := ctx.ModuleForTests("atestNoOptimize", "android_common").MaybeRule("d8")
803 if atestNoOptimize.Output == nil {
804 t.Errorf("atestNoOptimize should not optimize APK")
805 }
806
807 atestDefault := ctx.ModuleForTests("atestDefault", "android_common").MaybeRule("r8")
808 if atestDefault.Output == nil {
809 t.Errorf("atestDefault should optimize APK")
810 }
Colin Cross89536d42017-07-07 14:35:50 -0700811}
812
Colin Cross0f37af02017-09-27 17:42:05 -0700813func TestResources(t *testing.T) {
814 var table = []struct {
815 name string
816 prop string
817 extra string
818 args string
819 }{
820 {
Colin Crossaf9c55b2017-10-03 14:50:08 -0700821 // Test that a module with java_resource_dirs includes the files
Colin Cross0f37af02017-09-27 17:42:05 -0700822 name: "resource dirs",
Colin Cross824bee32017-11-22 17:27:51 -0800823 prop: `java_resource_dirs: ["java-res"]`,
Colin Cross0ead1d72018-04-10 13:07:42 -0700824 args: "-C java-res -f java-res/a/a -f java-res/b/b",
Colin Cross0f37af02017-09-27 17:42:05 -0700825 },
826 {
827 // Test that a module with java_resources includes the files
828 name: "resource files",
Colin Cross0ead1d72018-04-10 13:07:42 -0700829 prop: `java_resources: ["java-res/a/a", "java-res/b/b"]`,
830 args: "-C . -f java-res/a/a -f java-res/b/b",
Colin Cross0f37af02017-09-27 17:42:05 -0700831 },
832 {
833 // Test that a module with a filegroup in java_resources includes the files with the
834 // path prefix
835 name: "resource filegroup",
836 prop: `java_resources: [":foo-res"]`,
837 extra: `
838 filegroup {
839 name: "foo-res",
Colin Cross824bee32017-11-22 17:27:51 -0800840 path: "java-res",
Colin Cross0ead1d72018-04-10 13:07:42 -0700841 srcs: ["java-res/a/a", "java-res/b/b"],
Colin Cross0f37af02017-09-27 17:42:05 -0700842 }`,
Colin Cross0ead1d72018-04-10 13:07:42 -0700843 args: "-C java-res -f java-res/a/a -f java-res/b/b",
Colin Cross0f37af02017-09-27 17:42:05 -0700844 },
845 {
Colin Cross0ead1d72018-04-10 13:07:42 -0700846 // Test that a module with wildcards in java_resource_dirs has the correct path prefixes
847 name: "wildcard dirs",
848 prop: `java_resource_dirs: ["java-res/*"]`,
849 args: "-C java-res/a -f java-res/a/a -C java-res/b -f java-res/b/b",
850 },
851 {
852 // Test that a module exclude_java_resource_dirs excludes the files
853 name: "wildcard dirs",
854 prop: `java_resource_dirs: ["java-res/*"], exclude_java_resource_dirs: ["java-res/b"]`,
855 args: "-C java-res/a -f java-res/a/a",
856 },
Colin Crosscedd4762018-09-13 11:26:19 -0700857 {
858 // Test wildcards in java_resources
859 name: "wildcard files",
860 prop: `java_resources: ["java-res/**/*"]`,
861 args: "-C . -f java-res/a/a -f java-res/b/b",
862 },
863 {
864 // Test exclude_java_resources with java_resources
865 name: "wildcard files with exclude",
866 prop: `java_resources: ["java-res/**/*"], exclude_java_resources: ["java-res/b/*"]`,
867 args: "-C . -f java-res/a/a",
868 },
869 {
870 // Test exclude_java_resources with java_resource_dirs
871 name: "resource dirs with exclude files",
872 prop: `java_resource_dirs: ["java-res"], exclude_java_resources: ["java-res/b/b"]`,
873 args: "-C java-res -f java-res/a/a",
874 },
875 {
876 // Test exclude_java_resource_dirs with java_resource_dirs
877 name: "resource dirs with exclude files",
878 prop: `java_resource_dirs: ["java-res", "java-res2"], exclude_java_resource_dirs: ["java-res2"]`,
879 args: "-C java-res -f java-res/a/a -f java-res/b/b",
880 },
Colin Cross0f37af02017-09-27 17:42:05 -0700881 }
882
883 for _, test := range table {
884 t.Run(test.name, func(t *testing.T) {
Colin Cross238c1f32020-06-07 16:58:18 -0700885 ctx, _ := testJavaWithFS(t, `
Colin Cross0f37af02017-09-27 17:42:05 -0700886 java_library {
887 name: "foo",
888 srcs: [
889 "a.java",
890 "b.java",
891 "c.java",
892 ],
893 `+test.prop+`,
894 }
Colin Cross238c1f32020-06-07 16:58:18 -0700895 `+test.extra,
896 map[string][]byte{
897 "java-res/a/a": nil,
898 "java-res/b/b": nil,
899 "java-res2/a": nil,
900 },
901 )
Colin Cross0f37af02017-09-27 17:42:05 -0700902
Colin Cross331a1212018-08-15 20:40:52 -0700903 foo := ctx.ModuleForTests("foo", "android_common").Output("withres/foo.jar")
Colin Cross1ee23172017-10-18 14:44:18 -0700904 fooRes := ctx.ModuleForTests("foo", "android_common").Output("res/foo.jar")
Colin Cross0f37af02017-09-27 17:42:05 -0700905
906 if !inList(fooRes.Output.String(), foo.Inputs.Strings()) {
907 t.Errorf("foo combined jars %v does not contain %q",
908 foo.Inputs.Strings(), fooRes.Output.String())
909 }
910
Colin Crossaf9c55b2017-10-03 14:50:08 -0700911 if fooRes.Args["jarArgs"] != test.args {
912 t.Errorf("foo resource jar args %q is not %q",
Colin Cross0f37af02017-09-27 17:42:05 -0700913 fooRes.Args["jarArgs"], test.args)
914 }
915 })
916 }
917}
918
Colin Cross0c4ce212019-05-03 15:28:19 -0700919func TestIncludeSrcs(t *testing.T) {
Colin Cross238c1f32020-06-07 16:58:18 -0700920 ctx, _ := testJavaWithFS(t, `
Colin Cross0c4ce212019-05-03 15:28:19 -0700921 java_library {
922 name: "foo",
923 srcs: [
924 "a.java",
925 "b.java",
926 "c.java",
927 ],
928 include_srcs: true,
929 }
930
931 java_library {
932 name: "bar",
933 srcs: [
934 "a.java",
935 "b.java",
936 "c.java",
937 ],
938 java_resource_dirs: ["java-res"],
939 include_srcs: true,
940 }
Colin Cross238c1f32020-06-07 16:58:18 -0700941 `, map[string][]byte{
942 "java-res/a/a": nil,
943 "java-res/b/b": nil,
944 "java-res2/a": nil,
945 })
Colin Cross0c4ce212019-05-03 15:28:19 -0700946
947 // Test a library with include_srcs: true
948 foo := ctx.ModuleForTests("foo", "android_common").Output("withres/foo.jar")
949 fooSrcJar := ctx.ModuleForTests("foo", "android_common").Output("foo.srcjar")
950
951 if g, w := fooSrcJar.Output.String(), foo.Inputs.Strings(); !inList(g, w) {
952 t.Errorf("foo combined jars %v does not contain %q", w, g)
953 }
954
955 if g, w := fooSrcJar.Args["jarArgs"], "-C . -f a.java -f b.java -f c.java"; g != w {
956 t.Errorf("foo source jar args %q is not %q", w, g)
957 }
958
959 // Test a library with include_srcs: true and resources
960 bar := ctx.ModuleForTests("bar", "android_common").Output("withres/bar.jar")
961 barResCombined := ctx.ModuleForTests("bar", "android_common").Output("res-combined/bar.jar")
962 barRes := ctx.ModuleForTests("bar", "android_common").Output("res/bar.jar")
963 barSrcJar := ctx.ModuleForTests("bar", "android_common").Output("bar.srcjar")
964
965 if g, w := barSrcJar.Output.String(), barResCombined.Inputs.Strings(); !inList(g, w) {
966 t.Errorf("bar combined resource jars %v does not contain %q", w, g)
967 }
968
969 if g, w := barRes.Output.String(), barResCombined.Inputs.Strings(); !inList(g, w) {
970 t.Errorf("bar combined resource jars %v does not contain %q", w, g)
971 }
972
973 if g, w := barResCombined.Output.String(), bar.Inputs.Strings(); !inList(g, w) {
974 t.Errorf("bar combined jars %v does not contain %q", w, g)
975 }
976
977 if g, w := barSrcJar.Args["jarArgs"], "-C . -f a.java -f b.java -f c.java"; g != w {
978 t.Errorf("bar source jar args %q is not %q", w, g)
979 }
980
981 if g, w := barRes.Args["jarArgs"], "-C java-res -f java-res/a/a -f java-res/b/b"; g != w {
982 t.Errorf("bar resource jar args %q is not %q", w, g)
983 }
984}
985
Colin Cross54190b32017-10-09 15:34:10 -0700986func TestGeneratedSources(t *testing.T) {
Colin Cross238c1f32020-06-07 16:58:18 -0700987 ctx, _ := testJavaWithFS(t, `
Colin Cross54190b32017-10-09 15:34:10 -0700988 java_library {
989 name: "foo",
990 srcs: [
991 "a*.java",
992 ":gen",
993 "b*.java",
994 ],
995 }
996
997 genrule {
998 name: "gen",
Colin Cross824bee32017-11-22 17:27:51 -0800999 tool_files: ["java-res/a"],
Colin Cross54190b32017-10-09 15:34:10 -07001000 out: ["gen.java"],
1001 }
Colin Cross238c1f32020-06-07 16:58:18 -07001002 `, map[string][]byte{
1003 "a.java": nil,
1004 "b.java": nil,
1005 })
Colin Cross54190b32017-10-09 15:34:10 -07001006
1007 javac := ctx.ModuleForTests("foo", "android_common").Rule("javac")
1008 genrule := ctx.ModuleForTests("gen", "").Rule("generator")
1009
Colin Cross15e86d92017-10-20 15:07:08 -07001010 if filepath.Base(genrule.Output.String()) != "gen.java" {
1011 t.Fatalf(`gen output file %v is not ".../gen.java"`, genrule.Output.String())
Colin Cross54190b32017-10-09 15:34:10 -07001012 }
1013
1014 if len(javac.Inputs) != 3 ||
1015 javac.Inputs[0].String() != "a.java" ||
Colin Cross15e86d92017-10-20 15:07:08 -07001016 javac.Inputs[1].String() != genrule.Output.String() ||
Colin Cross54190b32017-10-09 15:34:10 -07001017 javac.Inputs[2].String() != "b.java" {
1018 t.Errorf(`foo inputs %v != ["a.java", ".../gen.java", "b.java"]`, javac.Inputs)
1019 }
1020}
1021
Nan Zhang61eaedb2017-11-02 13:28:15 -07001022func TestTurbine(t *testing.T) {
Jaewoong Jungf9a04432019-07-17 11:15:09 -07001023 ctx, _ := testJava(t, `
Nan Zhang61eaedb2017-11-02 13:28:15 -07001024 java_library {
1025 name: "foo",
1026 srcs: ["a.java"],
Jiyong Park2d492942018-03-05 17:44:10 +09001027 sdk_version: "14",
Nan Zhang61eaedb2017-11-02 13:28:15 -07001028 }
1029
1030 java_library {
1031 name: "bar",
Colin Cross9bc43432017-12-15 20:20:39 -08001032 srcs: ["b.java"],
Nan Zhang61eaedb2017-11-02 13:28:15 -07001033 static_libs: ["foo"],
Jiyong Park2d492942018-03-05 17:44:10 +09001034 sdk_version: "14",
Nan Zhang61eaedb2017-11-02 13:28:15 -07001035 }
1036
1037 java_library {
1038 name: "baz",
1039 srcs: ["c.java"],
1040 libs: ["bar"],
1041 sdk_version: "14",
1042 }
1043 `)
1044
1045 fooTurbine := ctx.ModuleForTests("foo", "android_common").Rule("turbine")
1046 barTurbine := ctx.ModuleForTests("bar", "android_common").Rule("turbine")
1047 barJavac := ctx.ModuleForTests("bar", "android_common").Rule("javac")
1048 barTurbineCombined := ctx.ModuleForTests("bar", "android_common").Description("for turbine")
1049 bazJavac := ctx.ModuleForTests("baz", "android_common").Rule("javac")
1050
1051 if len(fooTurbine.Inputs) != 1 || fooTurbine.Inputs[0].String() != "a.java" {
1052 t.Errorf(`foo inputs %v != ["a.java"]`, fooTurbine.Inputs)
1053 }
1054
1055 fooHeaderJar := filepath.Join(buildDir, ".intermediates", "foo", "android_common", "turbine-combined", "foo.jar")
1056 if !strings.Contains(barTurbine.Args["classpath"], fooHeaderJar) {
1057 t.Errorf("bar turbine classpath %v does not contain %q", barTurbine.Args["classpath"], fooHeaderJar)
1058 }
1059 if !strings.Contains(barJavac.Args["classpath"], fooHeaderJar) {
1060 t.Errorf("bar javac classpath %v does not contain %q", barJavac.Args["classpath"], fooHeaderJar)
1061 }
1062 if len(barTurbineCombined.Inputs) != 2 || barTurbineCombined.Inputs[1].String() != fooHeaderJar {
1063 t.Errorf("bar turbine combineJar inputs %v does not contain %q", barTurbineCombined.Inputs, fooHeaderJar)
1064 }
Anton Hanssonf66efeb2018-04-11 13:57:30 +01001065 if !strings.Contains(bazJavac.Args["classpath"], "prebuilts/sdk/14/public/android.jar") {
Nan Zhang61eaedb2017-11-02 13:28:15 -07001066 t.Errorf("baz javac classpath %v does not contain %q", bazJavac.Args["classpath"],
Anton Hanssonf66efeb2018-04-11 13:57:30 +01001067 "prebuilts/sdk/14/public/android.jar")
Nan Zhang61eaedb2017-11-02 13:28:15 -07001068 }
1069}
1070
1071func TestSharding(t *testing.T) {
Jaewoong Jungf9a04432019-07-17 11:15:09 -07001072 ctx, _ := testJava(t, `
Nan Zhang61eaedb2017-11-02 13:28:15 -07001073 java_library {
1074 name: "bar",
1075 srcs: ["a.java","b.java","c.java"],
1076 javac_shard_size: 1
1077 }
1078 `)
1079
1080 barHeaderJar := filepath.Join(buildDir, ".intermediates", "bar", "android_common", "turbine-combined", "bar.jar")
1081 for i := 0; i < 3; i++ {
1082 barJavac := ctx.ModuleForTests("bar", "android_common").Description("javac" + strconv.Itoa(i))
1083 if !strings.Contains(barJavac.Args["classpath"], barHeaderJar) {
1084 t.Errorf("bar javac classpath %v does not contain %q", barJavac.Args["classpath"], barHeaderJar)
1085 }
1086 }
1087}
1088
Nan Zhang581fd212018-01-10 16:06:12 -08001089func TestDroiddoc(t *testing.T) {
Colin Cross238c1f32020-06-07 16:58:18 -07001090 ctx, _ := testJavaWithFS(t, `
Paul Duffin884363e2019-12-19 10:21:09 +00001091 droiddoc_exported_dir {
Dan Willemsencc090972018-02-26 14:33:31 -08001092 name: "droiddoc-templates-sdk",
1093 path: ".",
1094 }
Jiyong Park29074592019-07-07 16:27:47 +09001095 filegroup {
1096 name: "bar-doc-aidl-srcs",
1097 srcs: ["bar-doc/IBar.aidl"],
1098 path: "bar-doc",
1099 }
Liz Kammer3a55c912020-08-14 12:14:02 -07001100 droiddoc {
1101 name: "bar-doc",
1102 srcs: [
Steve Kim3666c702020-09-01 17:58:01 +00001103 "bar-doc/a.java",
Liz Kammer3a55c912020-08-14 12:14:02 -07001104 "bar-doc/IFoo.aidl",
1105 ":bar-doc-aidl-srcs",
1106 ],
Steve Kim3666c702020-09-01 17:58:01 +00001107 exclude_srcs: [
1108 "bar-doc/b.java"
1109 ],
Dan Willemsencc090972018-02-26 14:33:31 -08001110 custom_template: "droiddoc-templates-sdk",
Nan Zhang581fd212018-01-10 16:06:12 -08001111 hdf: [
1112 "android.whichdoc offline",
1113 ],
1114 knowntags: [
1115 "bar-doc/known_oj_tags.txt",
1116 ],
1117 proofread_file: "libcore-proofread.txt",
1118 todo_file: "libcore-docs-todo.html",
Liz Kammer585cac22020-07-06 09:12:57 -07001119 flags: ["-offlinemode -title \"libcore\""],
Nan Zhang581fd212018-01-10 16:06:12 -08001120 }
Colin Cross238c1f32020-06-07 16:58:18 -07001121 `,
1122 map[string][]byte{
1123 "bar-doc/a.java": nil,
1124 "bar-doc/b.java": nil,
1125 })
Steve Kim3666c702020-09-01 17:58:01 +00001126 barDocModule := ctx.ModuleForTests("bar-doc", "android_common")
1127 barDoc := barDocModule.Rule("javadoc")
1128 notExpected := " -stubs "
1129 if strings.Contains(barDoc.RuleParams.Command, notExpected) {
1130 t.Errorf("bar-doc command contains flag %q to create stubs, but should not", notExpected)
Liz Kammer1e2ee122020-07-30 15:07:22 -07001131 }
Nan Zhang581fd212018-01-10 16:06:12 -08001132
Steve Kim3666c702020-09-01 17:58:01 +00001133 var javaSrcs []string
1134 for _, i := range barDoc.Inputs {
1135 javaSrcs = append(javaSrcs, i.Base())
1136 }
1137 if len(javaSrcs) != 1 || javaSrcs[0] != "a.java" {
1138 t.Errorf("inputs of bar-doc must be []string{\"a.java\"}, but was %#v.", javaSrcs)
Jiyong Park29074592019-07-07 16:27:47 +09001139 }
1140
Steve Kim3666c702020-09-01 17:58:01 +00001141 aidl := barDocModule.Rule("aidl")
1142 if g, w := barDoc.Implicits.Strings(), aidl.Output.String(); !inList(w, g) {
Colin Crossc0806172019-06-14 18:51:47 -07001143 t.Errorf("implicits of bar-doc must contain %q, but was %q.", w, g)
1144 }
1145
1146 if g, w := aidl.Implicits.Strings(), []string{"bar-doc/IBar.aidl", "bar-doc/IFoo.aidl"}; !reflect.DeepEqual(w, g) {
1147 t.Errorf("aidl inputs must be %q, but was %q", w, g)
Jiyong Park1e440682018-05-23 18:42:04 +09001148 }
Nan Zhang581fd212018-01-10 16:06:12 -08001149}
1150
Liz Kammer585cac22020-07-06 09:12:57 -07001151func TestDroiddocArgsAndFlagsCausesError(t *testing.T) {
1152 testJavaError(t, "flags is set. Cannot set args", `
1153 droiddoc_exported_dir {
1154 name: "droiddoc-templates-sdk",
1155 path: ".",
1156 }
1157 filegroup {
1158 name: "bar-doc-aidl-srcs",
1159 srcs: ["bar-doc/IBar.aidl"],
1160 path: "bar-doc",
1161 }
Liz Kammer3a55c912020-08-14 12:14:02 -07001162 droiddoc {
1163 name: "bar-doc",
1164 srcs: [
Steve Kim3666c702020-09-01 17:58:01 +00001165 "bar-doc/a.java",
Liz Kammer3a55c912020-08-14 12:14:02 -07001166 "bar-doc/IFoo.aidl",
1167 ":bar-doc-aidl-srcs",
1168 ],
Steve Kim3666c702020-09-01 17:58:01 +00001169 exclude_srcs: [
1170 "bar-doc/b.java"
1171 ],
Liz Kammer585cac22020-07-06 09:12:57 -07001172 custom_template: "droiddoc-templates-sdk",
1173 hdf: [
1174 "android.whichdoc offline",
1175 ],
1176 knowntags: [
1177 "bar-doc/known_oj_tags.txt",
1178 ],
1179 proofread_file: "libcore-proofread.txt",
1180 todo_file: "libcore-docs-todo.html",
1181 flags: ["-offlinemode -title \"libcore\""],
1182 args: "-offlinemode -title \"libcore\"",
1183 }
1184 `)
1185}
1186
Liz Kammer3d894b72020-08-04 09:55:13 -07001187func TestDroidstubs(t *testing.T) {
1188 ctx, _ := testJavaWithFS(t, `
1189 droiddoc_exported_dir {
1190 name: "droiddoc-templates-sdk",
1191 path: ".",
1192 }
1193
1194 droidstubs {
1195 name: "bar-stubs",
1196 srcs: [
1197 "bar-doc/a.java",
1198 ],
1199 api_levels_annotations_dirs: [
1200 "droiddoc-templates-sdk",
1201 ],
1202 api_levels_annotations_enabled: true,
1203 }
1204
1205 droidstubs {
1206 name: "bar-stubs-other",
1207 srcs: [
1208 "bar-doc/a.java",
1209 ],
1210 api_levels_annotations_dirs: [
1211 "droiddoc-templates-sdk",
1212 ],
1213 api_levels_annotations_enabled: true,
1214 api_levels_jar_filename: "android.other.jar",
1215 }
1216 `,
1217 map[string][]byte{
1218 "bar-doc/a.java": nil,
1219 })
1220 testcases := []struct {
1221 moduleName string
1222 expectedJarFilename string
1223 }{
1224 {
1225 moduleName: "bar-stubs",
1226 expectedJarFilename: "android.jar",
1227 },
1228 {
1229 moduleName: "bar-stubs-other",
1230 expectedJarFilename: "android.other.jar",
1231 },
1232 }
1233 for _, c := range testcases {
1234 m := ctx.ModuleForTests(c.moduleName, "android_common")
1235 metalava := m.Rule("metalava")
1236 expected := "--android-jar-pattern ./%/public/" + c.expectedJarFilename
1237 if actual := metalava.RuleParams.Command; !strings.Contains(actual, expected) {
1238 t.Errorf("For %q, expected metalava argument %q, but was not found %q", c.moduleName, expected, actual)
1239 }
1240 }
1241}
1242
Paul Duffin83a2d962019-11-19 19:44:10 +00001243func TestDroidstubsWithSystemModules(t *testing.T) {
1244 ctx, _ := testJava(t, `
1245 droidstubs {
1246 name: "stubs-source-system-modules",
1247 srcs: [
Colin Cross238c1f32020-06-07 16:58:18 -07001248 "bar-doc/a.java",
Paul Duffin83a2d962019-11-19 19:44:10 +00001249 ],
1250 sdk_version: "none",
1251 system_modules: "source-system-modules",
1252 }
1253
1254 java_library {
1255 name: "source-jar",
1256 srcs: [
1257 "a.java",
1258 ],
1259 }
1260
1261 java_system_modules {
1262 name: "source-system-modules",
1263 libs: ["source-jar"],
1264 }
1265
1266 droidstubs {
1267 name: "stubs-prebuilt-system-modules",
1268 srcs: [
Colin Cross238c1f32020-06-07 16:58:18 -07001269 "bar-doc/a.java",
Paul Duffin83a2d962019-11-19 19:44:10 +00001270 ],
1271 sdk_version: "none",
1272 system_modules: "prebuilt-system-modules",
1273 }
1274
1275 java_import {
1276 name: "prebuilt-jar",
1277 jars: ["a.jar"],
1278 }
1279
1280 java_system_modules_import {
1281 name: "prebuilt-system-modules",
1282 libs: ["prebuilt-jar"],
1283 }
1284 `)
1285
1286 checkSystemModulesUseByDroidstubs(t, ctx, "stubs-source-system-modules", "source-jar.jar")
1287
1288 checkSystemModulesUseByDroidstubs(t, ctx, "stubs-prebuilt-system-modules", "prebuilt-jar.jar")
1289}
1290
1291func checkSystemModulesUseByDroidstubs(t *testing.T, ctx *android.TestContext, moduleName string, systemJar string) {
1292 metalavaRule := ctx.ModuleForTests(moduleName, "android_common").Rule("metalava")
1293 var systemJars []string
1294 for _, i := range metalavaRule.Implicits {
1295 systemJars = append(systemJars, i.Base())
1296 }
Ramy Medhatc7965cd2020-04-30 03:08:37 -04001297 if len(systemJars) < 1 || systemJars[0] != systemJar {
Paul Duffin83a2d962019-11-19 19:44:10 +00001298 t.Errorf("inputs of %q must be []string{%q}, but was %#v.", moduleName, systemJar, systemJars)
1299 }
1300}
1301
Colin Cross54250902017-12-05 09:28:08 -08001302func TestJarGenrules(t *testing.T) {
Jaewoong Jungf9a04432019-07-17 11:15:09 -07001303 ctx, _ := testJava(t, `
Colin Cross54250902017-12-05 09:28:08 -08001304 java_library {
1305 name: "foo",
1306 srcs: ["a.java"],
1307 }
1308
1309 java_genrule {
1310 name: "jargen",
1311 tool_files: ["b.java"],
1312 cmd: "$(location b.java) $(in) $(out)",
1313 out: ["jargen.jar"],
1314 srcs: [":foo"],
1315 }
1316
1317 java_library {
1318 name: "bar",
1319 static_libs: ["jargen"],
1320 srcs: ["c.java"],
1321 }
1322
1323 java_library {
1324 name: "baz",
1325 libs: ["jargen"],
1326 srcs: ["c.java"],
1327 }
1328 `)
1329
1330 foo := ctx.ModuleForTests("foo", "android_common").Output("javac/foo.jar")
1331 jargen := ctx.ModuleForTests("jargen", "android_common").Output("jargen.jar")
1332 bar := ctx.ModuleForTests("bar", "android_common").Output("javac/bar.jar")
1333 baz := ctx.ModuleForTests("baz", "android_common").Output("javac/baz.jar")
1334 barCombined := ctx.ModuleForTests("bar", "android_common").Output("combined/bar.jar")
1335
1336 if len(jargen.Inputs) != 1 || jargen.Inputs[0].String() != foo.Output.String() {
1337 t.Errorf("expected jargen inputs [%q], got %q", foo.Output.String(), jargen.Inputs.Strings())
1338 }
1339
1340 if !strings.Contains(bar.Args["classpath"], jargen.Output.String()) {
1341 t.Errorf("bar classpath %v does not contain %q", bar.Args["classpath"], jargen.Output.String())
1342 }
1343
1344 if !strings.Contains(baz.Args["classpath"], jargen.Output.String()) {
1345 t.Errorf("baz classpath %v does not contain %q", baz.Args["classpath"], jargen.Output.String())
1346 }
1347
1348 if len(barCombined.Inputs) != 2 ||
1349 barCombined.Inputs[0].String() != bar.Output.String() ||
1350 barCombined.Inputs[1].String() != jargen.Output.String() {
1351 t.Errorf("bar combined jar inputs %v is not [%q, %q]",
1352 barCombined.Inputs.Strings(), bar.Output.String(), jargen.Output.String())
1353 }
1354}
1355
Nan Zhang27e284d2018-02-09 21:03:53 +00001356func TestExcludeFileGroupInSrcs(t *testing.T) {
Jaewoong Jungf9a04432019-07-17 11:15:09 -07001357 ctx, _ := testJava(t, `
Nan Zhang27e284d2018-02-09 21:03:53 +00001358 java_library {
1359 name: "foo",
1360 srcs: ["a.java", ":foo-srcs"],
1361 exclude_srcs: ["a.java", ":foo-excludes"],
1362 }
1363
1364 filegroup {
1365 name: "foo-srcs",
1366 srcs: ["java-fg/a.java", "java-fg/b.java", "java-fg/c.java"],
1367 }
1368
1369 filegroup {
1370 name: "foo-excludes",
1371 srcs: ["java-fg/a.java", "java-fg/b.java"],
1372 }
1373 `)
1374
1375 javac := ctx.ModuleForTests("foo", "android_common").Rule("javac")
1376
1377 if len(javac.Inputs) != 1 || javac.Inputs[0].String() != "java-fg/c.java" {
1378 t.Errorf(`foo inputs %v != ["java-fg/c.java"]`, javac.Inputs)
1379 }
1380}
Jiyong Parkc678ad32018-04-10 13:07:10 +09001381
Paul Duffin52d398a2019-06-11 12:31:14 +01001382func TestJavaLibrary(t *testing.T) {
Colin Cross98be1bb2019-12-13 20:41:13 -08001383 config := testConfig(nil, "", map[string][]byte{
Paul Duffin52d398a2019-06-11 12:31:14 +01001384 "libcore/Android.bp": []byte(`
1385 java_library {
1386 name: "core",
1387 sdk_version: "none",
1388 system_modules: "none",
1389 }`),
1390 })
Colin Cross98be1bb2019-12-13 20:41:13 -08001391 ctx := testContext()
Paul Duffin52d398a2019-06-11 12:31:14 +01001392 run(t, ctx, config)
1393}
1394
Jiyong Parkc678ad32018-04-10 13:07:10 +09001395func TestJavaSdkLibrary(t *testing.T) {
Jaewoong Jungf9a04432019-07-17 11:15:09 -07001396 ctx, _ := testJava(t, `
Paul Duffin884363e2019-12-19 10:21:09 +00001397 droiddoc_exported_dir {
Jiyong Parkc678ad32018-04-10 13:07:10 +09001398 name: "droiddoc-templates-sdk",
1399 path: ".",
1400 }
Jiyong Parkc678ad32018-04-10 13:07:10 +09001401 java_sdk_library {
1402 name: "foo",
1403 srcs: ["a.java", "b.java"],
1404 api_packages: ["foo"],
1405 }
1406 java_sdk_library {
1407 name: "bar",
1408 srcs: ["a.java", "b.java"],
1409 api_packages: ["bar"],
1410 }
1411 java_library {
1412 name: "baz",
1413 srcs: ["c.java"],
Paul Duffin859fe962020-05-15 10:20:31 +01001414 libs: ["foo", "bar.stubs"],
Jiyong Parkc678ad32018-04-10 13:07:10 +09001415 sdk_version: "system_current",
1416 }
Paul Duffindfa131e2020-05-15 20:37:11 +01001417 java_sdk_library {
1418 name: "barney",
1419 srcs: ["c.java"],
1420 api_only: true,
1421 }
1422 java_sdk_library {
1423 name: "betty",
1424 srcs: ["c.java"],
1425 shared_library: false,
1426 }
Paul Duffin859fe962020-05-15 10:20:31 +01001427 java_sdk_library_import {
1428 name: "quuz",
1429 public: {
1430 jars: ["c.jar"],
1431 },
1432 }
1433 java_sdk_library_import {
1434 name: "fred",
1435 public: {
1436 jars: ["b.jar"],
1437 },
1438 }
Paul Duffindfa131e2020-05-15 20:37:11 +01001439 java_sdk_library_import {
1440 name: "wilma",
1441 public: {
1442 jars: ["b.jar"],
1443 },
1444 shared_library: false,
1445 }
Jiyong Park1be96912018-05-28 18:02:19 +09001446 java_library {
1447 name: "qux",
1448 srcs: ["c.java"],
Paul Duffindfa131e2020-05-15 20:37:11 +01001449 libs: ["baz", "fred", "quuz.stubs", "wilma", "barney", "betty"],
Jiyong Park1be96912018-05-28 18:02:19 +09001450 sdk_version: "system_current",
1451 }
Paul Duffin726d23c2020-01-22 16:30:37 +00001452 java_library {
1453 name: "baz-test",
1454 srcs: ["c.java"],
1455 libs: ["foo"],
1456 sdk_version: "test_current",
1457 }
Paul Duffina2db18f2020-01-22 17:11:15 +00001458 java_library {
1459 name: "baz-29",
1460 srcs: ["c.java"],
1461 libs: ["foo"],
1462 sdk_version: "system_29",
1463 }
Jiyong Parkc678ad32018-04-10 13:07:10 +09001464 `)
1465
1466 // check the existence of the internal modules
1467 ctx.ModuleForTests("foo", "android_common")
Paul Duffindd9d0742020-05-08 15:52:37 +01001468 ctx.ModuleForTests(apiScopePublic.stubsLibraryModuleName("foo"), "android_common")
1469 ctx.ModuleForTests(apiScopeSystem.stubsLibraryModuleName("foo"), "android_common")
1470 ctx.ModuleForTests(apiScopeTest.stubsLibraryModuleName("foo"), "android_common")
1471 ctx.ModuleForTests(apiScopePublic.stubsSourceModuleName("foo"), "android_common")
1472 ctx.ModuleForTests(apiScopeSystem.stubsSourceModuleName("foo"), "android_common")
1473 ctx.ModuleForTests(apiScopeTest.stubsSourceModuleName("foo"), "android_common")
Jiyong Parke3833882020-02-17 17:28:10 +09001474 ctx.ModuleForTests("foo"+sdkXmlFileSuffix, "android_common")
Jiyong Park58c518b2018-05-12 22:29:12 +09001475 ctx.ModuleForTests("foo.api.public.28", "")
1476 ctx.ModuleForTests("foo.api.system.28", "")
1477 ctx.ModuleForTests("foo.api.test.28", "")
Jiyong Parkc678ad32018-04-10 13:07:10 +09001478
1479 bazJavac := ctx.ModuleForTests("baz", "android_common").Rule("javac")
1480 // tests if baz is actually linked to the stubs lib
1481 if !strings.Contains(bazJavac.Args["classpath"], "foo.stubs.system.jar") {
1482 t.Errorf("baz javac classpath %v does not contain %q", bazJavac.Args["classpath"],
1483 "foo.stubs.system.jar")
1484 }
1485 // ... and not to the impl lib
Sundong Ahn054b19a2018-10-19 13:46:09 +09001486 if strings.Contains(bazJavac.Args["classpath"], "foo.jar") {
Jiyong Parkc678ad32018-04-10 13:07:10 +09001487 t.Errorf("baz javac classpath %v should not contain %q", bazJavac.Args["classpath"],
Sundong Ahn054b19a2018-10-19 13:46:09 +09001488 "foo.jar")
Jiyong Parkc678ad32018-04-10 13:07:10 +09001489 }
1490 // test if baz is not linked to the system variant of foo
1491 if strings.Contains(bazJavac.Args["classpath"], "foo.stubs.jar") {
1492 t.Errorf("baz javac classpath %v should not contain %q", bazJavac.Args["classpath"],
1493 "foo.stubs.jar")
1494 }
Jiyong Park1be96912018-05-28 18:02:19 +09001495
Paul Duffin726d23c2020-01-22 16:30:37 +00001496 bazTestJavac := ctx.ModuleForTests("baz-test", "android_common").Rule("javac")
1497 // tests if baz-test is actually linked to the test stubs lib
1498 if !strings.Contains(bazTestJavac.Args["classpath"], "foo.stubs.test.jar") {
1499 t.Errorf("baz-test javac classpath %v does not contain %q", bazTestJavac.Args["classpath"],
1500 "foo.stubs.test.jar")
1501 }
1502
Paul Duffina2db18f2020-01-22 17:11:15 +00001503 baz29Javac := ctx.ModuleForTests("baz-29", "android_common").Rule("javac")
1504 // tests if baz-29 is actually linked to the system 29 stubs lib
1505 if !strings.Contains(baz29Javac.Args["classpath"], "prebuilts/sdk/29/system/foo.jar") {
1506 t.Errorf("baz-29 javac classpath %v does not contain %q", baz29Javac.Args["classpath"],
1507 "prebuilts/sdk/29/system/foo.jar")
1508 }
1509
Jiyong Park1be96912018-05-28 18:02:19 +09001510 // test if baz has exported SDK lib names foo and bar to qux
1511 qux := ctx.ModuleForTests("qux", "android_common")
1512 if quxLib, ok := qux.Module().(*Library); ok {
Ulya Trafimovichb8063c62020-08-20 11:33:12 +01001513 sdkLibs := android.SortedStringKeys(quxLib.ExportedSdkLibs())
Paul Duffin859fe962020-05-15 10:20:31 +01001514 if w := []string{"bar", "foo", "fred", "quuz"}; !reflect.DeepEqual(w, sdkLibs) {
1515 t.Errorf("qux should export %q but exports %q", w, sdkLibs)
Jiyong Park1be96912018-05-28 18:02:19 +09001516 }
1517 }
Jiyong Parkc678ad32018-04-10 13:07:10 +09001518}
Zoran Jovanovic8736ce22018-08-21 17:10:29 +02001519
Paul Duffindaaa3322020-05-26 18:13:57 +01001520func TestJavaSdkLibrary_DoNotAccessImplWhenItIsNotBuilt(t *testing.T) {
1521 ctx, _ := testJava(t, `
1522 java_sdk_library {
1523 name: "foo",
1524 srcs: ["a.java"],
1525 api_only: true,
1526 public: {
1527 enabled: true,
1528 },
1529 }
1530
1531 java_library {
1532 name: "bar",
1533 srcs: ["b.java"],
1534 libs: ["foo"],
1535 }
1536 `)
1537
1538 // The bar library should depend on the stubs jar.
1539 barLibrary := ctx.ModuleForTests("bar", "android_common").Rule("javac")
1540 if expected, actual := `^-classpath .*:/[^:]*/turbine-combined/foo\.stubs\.jar$`, barLibrary.Args["classpath"]; !regexp.MustCompile(expected).MatchString(actual) {
1541 t.Errorf("expected %q, found %#q", expected, actual)
1542 }
1543}
1544
Paul Duffin46dc45a2020-05-14 15:39:10 +01001545func TestJavaSdkLibrary_UseSourcesFromAnotherSdkLibrary(t *testing.T) {
1546 testJava(t, `
1547 java_sdk_library {
1548 name: "foo",
1549 srcs: ["a.java"],
1550 api_packages: ["foo"],
1551 public: {
1552 enabled: true,
1553 },
1554 }
1555
1556 java_library {
1557 name: "bar",
1558 srcs: ["b.java", ":foo{.public.stubs.source}"],
1559 }
1560 `)
1561}
1562
1563func TestJavaSdkLibrary_AccessOutputFiles_MissingScope(t *testing.T) {
1564 testJavaError(t, `"foo" does not provide api scope system`, `
1565 java_sdk_library {
1566 name: "foo",
1567 srcs: ["a.java"],
1568 api_packages: ["foo"],
1569 public: {
1570 enabled: true,
1571 },
1572 }
1573
1574 java_library {
1575 name: "bar",
1576 srcs: ["b.java", ":foo{.system.stubs.source}"],
1577 }
1578 `)
1579}
1580
Paul Duffinca8d9a52020-06-26 22:20:25 +01001581func TestJavaSdkLibrary_Deps(t *testing.T) {
1582 ctx, _ := testJava(t, `
1583 java_sdk_library {
1584 name: "sdklib",
1585 srcs: ["a.java"],
1586 sdk_version: "none",
1587 system_modules: "none",
1588 public: {
1589 enabled: true,
1590 },
1591 }
1592 `)
1593
Paul Duffincee7e662020-07-09 17:32:57 +01001594 CheckModuleDependencies(t, ctx, "sdklib", "android_common", []string{
Paul Duffinca8d9a52020-06-26 22:20:25 +01001595 `dex2oatd`,
1596 `sdklib.impl`,
1597 `sdklib.stubs`,
1598 `sdklib.stubs.source`,
1599 `sdklib.xml`,
1600 })
1601}
1602
Paul Duffin46dc45a2020-05-14 15:39:10 +01001603func TestJavaSdkLibraryImport_AccessOutputFiles(t *testing.T) {
1604 testJava(t, `
1605 java_sdk_library_import {
1606 name: "foo",
1607 public: {
1608 jars: ["a.jar"],
1609 stub_srcs: ["a.java"],
1610 current_api: "api/current.txt",
1611 removed_api: "api/removed.txt",
1612 },
1613 }
1614
1615 java_library {
1616 name: "bar",
1617 srcs: [":foo{.public.stubs.source}"],
1618 java_resources: [
1619 ":foo{.public.api.txt}",
1620 ":foo{.public.removed-api.txt}",
1621 ],
1622 }
1623 `)
1624}
1625
1626func TestJavaSdkLibraryImport_AccessOutputFiles_Invalid(t *testing.T) {
1627 bp := `
1628 java_sdk_library_import {
1629 name: "foo",
1630 public: {
1631 jars: ["a.jar"],
1632 },
1633 }
1634 `
1635
1636 t.Run("stubs.source", func(t *testing.T) {
1637 testJavaError(t, `stubs.source not available for api scope public`, bp+`
1638 java_library {
1639 name: "bar",
1640 srcs: [":foo{.public.stubs.source}"],
1641 java_resources: [
1642 ":foo{.public.api.txt}",
1643 ":foo{.public.removed-api.txt}",
1644 ],
1645 }
1646 `)
1647 })
1648
1649 t.Run("api.txt", func(t *testing.T) {
1650 testJavaError(t, `api.txt not available for api scope public`, bp+`
1651 java_library {
1652 name: "bar",
1653 srcs: ["a.java"],
1654 java_resources: [
1655 ":foo{.public.api.txt}",
1656 ],
1657 }
1658 `)
1659 })
1660
1661 t.Run("removed-api.txt", func(t *testing.T) {
1662 testJavaError(t, `removed-api.txt not available for api scope public`, bp+`
1663 java_library {
1664 name: "bar",
1665 srcs: ["a.java"],
1666 java_resources: [
1667 ":foo{.public.removed-api.txt}",
1668 ],
1669 }
1670 `)
1671 })
1672}
1673
Paul Duffin3375e352020-04-28 10:44:03 +01001674func TestJavaSdkLibrary_InvalidScopes(t *testing.T) {
1675 testJavaError(t, `module "foo": enabled api scope "system" depends on disabled scope "public"`, `
1676 java_sdk_library {
1677 name: "foo",
1678 srcs: ["a.java", "b.java"],
1679 api_packages: ["foo"],
1680 // Explicitly disable public to test the check that ensures the set of enabled
1681 // scopes is consistent.
1682 public: {
1683 enabled: false,
1684 },
1685 system: {
1686 enabled: true,
1687 },
1688 }
1689 `)
1690}
1691
Paul Duffin87a05a32020-05-12 11:50:28 +01001692func TestJavaSdkLibrary_SdkVersion_ForScope(t *testing.T) {
1693 testJava(t, `
1694 java_sdk_library {
1695 name: "foo",
1696 srcs: ["a.java", "b.java"],
1697 api_packages: ["foo"],
1698 system: {
1699 enabled: true,
1700 sdk_version: "module_current",
1701 },
1702 }
1703 `)
1704}
1705
Paul Duffin0c5bae52020-06-02 13:00:08 +01001706func TestJavaSdkLibrary_ModuleLib(t *testing.T) {
1707 testJava(t, `
1708 java_sdk_library {
1709 name: "foo",
1710 srcs: ["a.java", "b.java"],
1711 api_packages: ["foo"],
1712 system: {
1713 enabled: true,
1714 },
1715 module_lib: {
1716 enabled: true,
1717 },
1718 }
1719 `)
1720}
1721
1722func TestJavaSdkLibrary_SystemServer(t *testing.T) {
1723 testJava(t, `
1724 java_sdk_library {
1725 name: "foo",
1726 srcs: ["a.java", "b.java"],
1727 api_packages: ["foo"],
1728 system: {
1729 enabled: true,
1730 },
1731 system_server: {
1732 enabled: true,
1733 },
1734 }
1735 `)
1736}
1737
Paul Duffin803a9562020-05-20 11:52:25 +01001738func TestJavaSdkLibrary_MissingScope(t *testing.T) {
1739 testJavaError(t, `requires api scope module-lib from foo but it only has \[\] available`, `
1740 java_sdk_library {
1741 name: "foo",
1742 srcs: ["a.java"],
1743 public: {
1744 enabled: false,
1745 },
1746 }
1747
1748 java_library {
1749 name: "baz",
1750 srcs: ["a.java"],
1751 libs: ["foo"],
1752 sdk_version: "module_current",
1753 }
1754 `)
1755}
1756
1757func TestJavaSdkLibrary_FallbackScope(t *testing.T) {
1758 testJava(t, `
1759 java_sdk_library {
1760 name: "foo",
1761 srcs: ["a.java"],
1762 system: {
1763 enabled: true,
1764 },
1765 }
1766
1767 java_library {
1768 name: "baz",
1769 srcs: ["a.java"],
1770 libs: ["foo"],
1771 // foo does not have module-lib scope so it should fallback to system
1772 sdk_version: "module_current",
1773 }
1774 `)
1775}
1776
Jiyong Park932cdfe2020-05-28 00:19:53 +09001777func TestJavaSdkLibrary_DefaultToStubs(t *testing.T) {
1778 ctx, _ := testJava(t, `
1779 java_sdk_library {
1780 name: "foo",
1781 srcs: ["a.java"],
1782 system: {
1783 enabled: true,
1784 },
1785 default_to_stubs: true,
1786 }
1787
1788 java_library {
1789 name: "baz",
1790 srcs: ["a.java"],
1791 libs: ["foo"],
1792 // does not have sdk_version set, should fallback to module,
1793 // which will then fallback to system because the module scope
1794 // is not enabled.
1795 }
1796 `)
1797 // The baz library should depend on the system stubs jar.
1798 bazLibrary := ctx.ModuleForTests("baz", "android_common").Rule("javac")
1799 if expected, actual := `^-classpath .*:/[^:]*/turbine-combined/foo\.stubs.system\.jar$`, bazLibrary.Args["classpath"]; !regexp.MustCompile(expected).MatchString(actual) {
1800 t.Errorf("expected %q, found %#q", expected, actual)
1801 }
1802}
1803
Zoran Jovanovic8736ce22018-08-21 17:10:29 +02001804var compilerFlagsTestCases = []struct {
1805 in string
1806 out bool
1807}{
1808 {
1809 in: "a",
1810 out: false,
1811 },
1812 {
1813 in: "-a",
1814 out: true,
1815 },
1816 {
1817 in: "-no-jdk",
1818 out: false,
1819 },
1820 {
1821 in: "-no-stdlib",
1822 out: false,
1823 },
1824 {
1825 in: "-kotlin-home",
1826 out: false,
1827 },
1828 {
1829 in: "-kotlin-home /some/path",
1830 out: false,
1831 },
1832 {
1833 in: "-include-runtime",
1834 out: false,
1835 },
1836 {
1837 in: "-Xintellij-plugin-root",
1838 out: false,
1839 },
1840}
1841
1842type mockContext struct {
1843 android.ModuleContext
1844 result bool
1845}
1846
1847func (ctx *mockContext) PropertyErrorf(property, format string, args ...interface{}) {
1848 // CheckBadCompilerFlags calls this function when the flag should be rejected
1849 ctx.result = false
1850}
1851
1852func TestCompilerFlags(t *testing.T) {
1853 for _, testCase := range compilerFlagsTestCases {
1854 ctx := &mockContext{result: true}
1855 CheckKotlincFlags(ctx, []string{testCase.in})
1856 if ctx.result != testCase.out {
1857 t.Errorf("incorrect output:")
1858 t.Errorf(" input: %#v", testCase.in)
1859 t.Errorf(" expected: %#v", testCase.out)
1860 t.Errorf(" got: %#v", ctx.result)
1861 }
1862 }
1863}
Jaewoong Jung38e4fb22018-12-12 09:01:34 -08001864
1865// TODO(jungjw): Consider making this more robust by ignoring path order.
1866func checkPatchModuleFlag(t *testing.T, ctx *android.TestContext, moduleName string, expected string) {
1867 variables := ctx.ModuleForTests(moduleName, "android_common").Module().VariablesForTests()
1868 flags := strings.Split(variables["javacFlags"], " ")
1869 got := ""
1870 for _, flag := range flags {
1871 keyEnd := strings.Index(flag, "=")
1872 if keyEnd > -1 && flag[:keyEnd] == "--patch-module" {
1873 got = flag[keyEnd+1:]
1874 break
1875 }
1876 }
1877 if expected != got {
1878 t.Errorf("Unexpected patch-module flag for module %q - expected %q, but got %q", moduleName, expected, got)
1879 }
1880}
1881
1882func TestPatchModule(t *testing.T) {
Pete Gillin0c2143e2019-05-02 15:32:11 +01001883 t.Run("Java language level 8", func(t *testing.T) {
Pete Gillin1b3370f2019-10-01 13:57:31 +01001884 // Test with legacy javac -source 1.8 -target 1.8
Pete Gillinbdf5d712019-10-21 14:29:58 +01001885 bp := `
1886 java_library {
1887 name: "foo",
1888 srcs: ["a.java"],
1889 java_version: "1.8",
1890 }
1891
1892 java_library {
1893 name: "bar",
1894 srcs: ["b.java"],
1895 sdk_version: "none",
1896 system_modules: "none",
1897 patch_module: "java.base",
1898 java_version: "1.8",
1899 }
1900
1901 java_library {
1902 name: "baz",
1903 srcs: ["c.java"],
1904 patch_module: "java.base",
1905 java_version: "1.8",
1906 }
1907 `
1908 ctx, _ := testJava(t, bp)
Jaewoong Jung38e4fb22018-12-12 09:01:34 -08001909
1910 checkPatchModuleFlag(t, ctx, "foo", "")
1911 checkPatchModuleFlag(t, ctx, "bar", "")
1912 checkPatchModuleFlag(t, ctx, "baz", "")
1913 })
1914
Pete Gillin0c2143e2019-05-02 15:32:11 +01001915 t.Run("Java language level 9", func(t *testing.T) {
Pete Gillin1b3370f2019-10-01 13:57:31 +01001916 // Test with default javac -source 9 -target 9
Pete Gillinbdf5d712019-10-21 14:29:58 +01001917 bp := `
1918 java_library {
1919 name: "foo",
1920 srcs: ["a.java"],
1921 }
1922
1923 java_library {
1924 name: "bar",
1925 srcs: ["b.java"],
1926 sdk_version: "none",
1927 system_modules: "none",
1928 patch_module: "java.base",
1929 }
1930
1931 java_library {
1932 name: "baz",
1933 srcs: ["c.java"],
1934 patch_module: "java.base",
1935 }
1936 `
Pete Gillin1b3370f2019-10-01 13:57:31 +01001937 ctx, _ := testJava(t, bp)
Jaewoong Jung38e4fb22018-12-12 09:01:34 -08001938
1939 checkPatchModuleFlag(t, ctx, "foo", "")
1940 expected := "java.base=.:" + buildDir
1941 checkPatchModuleFlag(t, ctx, "bar", expected)
Jiyong Park231d0562019-12-18 17:28:17 +09001942 expected = "java.base=" + strings.Join([]string{".", buildDir, moduleToPath("ext"), moduleToPath("framework")}, ":")
Jaewoong Jung38e4fb22018-12-12 09:01:34 -08001943 checkPatchModuleFlag(t, ctx, "baz", expected)
1944 })
1945}
Paul Duffina7b9f422020-01-10 17:12:18 +00001946
1947func TestJavaSystemModules(t *testing.T) {
1948 ctx, _ := testJava(t, `
1949 java_system_modules {
1950 name: "system-modules",
1951 libs: ["system-module1", "system-module2"],
1952 }
1953 java_library {
1954 name: "system-module1",
1955 srcs: ["a.java"],
1956 sdk_version: "none",
1957 system_modules: "none",
1958 }
1959 java_library {
1960 name: "system-module2",
1961 srcs: ["b.java"],
1962 sdk_version: "none",
1963 system_modules: "none",
1964 }
1965 `)
1966
1967 // check the existence of the module
1968 systemModules := ctx.ModuleForTests("system-modules", "android_common")
1969
1970 cmd := systemModules.Rule("jarsTosystemModules")
1971
1972 // make sure the command compiles against the supplied modules.
1973 for _, module := range []string{"system-module1.jar", "system-module2.jar"} {
1974 if !strings.Contains(cmd.Args["classpath"], module) {
1975 t.Errorf("system modules classpath %v does not contain %q", cmd.Args["classpath"],
1976 module)
1977 }
1978 }
1979}
Paul Duffin90169ba2020-01-10 17:16:44 +00001980
1981func TestJavaSystemModulesImport(t *testing.T) {
1982 ctx, _ := testJava(t, `
1983 java_system_modules_import {
1984 name: "system-modules",
1985 libs: ["system-module1", "system-module2"],
1986 }
1987 java_import {
1988 name: "system-module1",
1989 jars: ["a.jar"],
1990 }
1991 java_import {
1992 name: "system-module2",
1993 jars: ["b.jar"],
1994 }
1995 `)
1996
1997 // check the existence of the module
1998 systemModules := ctx.ModuleForTests("system-modules", "android_common")
1999
2000 cmd := systemModules.Rule("jarsTosystemModules")
2001
2002 // make sure the command compiles against the supplied modules.
2003 for _, module := range []string{"system-module1.jar", "system-module2.jar"} {
2004 if !strings.Contains(cmd.Args["classpath"], module) {
2005 t.Errorf("system modules classpath %v does not contain %q", cmd.Args["classpath"],
2006 module)
2007 }
2008 }
2009}
Paul Duffin83a2d962019-11-19 19:44:10 +00002010
2011func TestJavaLibraryWithSystemModules(t *testing.T) {
2012 ctx, _ := testJava(t, `
2013 java_library {
2014 name: "lib-with-source-system-modules",
2015 srcs: [
2016 "a.java",
2017 ],
2018 sdk_version: "none",
2019 system_modules: "source-system-modules",
2020 }
2021
2022 java_library {
2023 name: "source-jar",
2024 srcs: [
2025 "a.java",
2026 ],
2027 }
2028
2029 java_system_modules {
2030 name: "source-system-modules",
2031 libs: ["source-jar"],
2032 }
2033
2034 java_library {
2035 name: "lib-with-prebuilt-system-modules",
2036 srcs: [
2037 "a.java",
2038 ],
2039 sdk_version: "none",
2040 system_modules: "prebuilt-system-modules",
2041 }
2042
2043 java_import {
2044 name: "prebuilt-jar",
2045 jars: ["a.jar"],
2046 }
2047
2048 java_system_modules_import {
2049 name: "prebuilt-system-modules",
2050 libs: ["prebuilt-jar"],
2051 }
2052 `)
2053
2054 checkBootClasspathForSystemModule(t, ctx, "lib-with-source-system-modules", "/source-jar.jar")
2055
2056 checkBootClasspathForSystemModule(t, ctx, "lib-with-prebuilt-system-modules", "/prebuilt-jar.jar")
2057}
2058
2059func checkBootClasspathForSystemModule(t *testing.T, ctx *android.TestContext, moduleName string, expectedSuffix string) {
2060 javacRule := ctx.ModuleForTests(moduleName, "android_common").Rule("javac")
2061 bootClasspath := javacRule.Args["bootClasspath"]
2062 if strings.HasPrefix(bootClasspath, "--system ") && strings.HasSuffix(bootClasspath, expectedSuffix) {
2063 t.Errorf("bootclasspath of %q must start with --system and end with %q, but was %#v.", moduleName, expectedSuffix, bootClasspath)
2064 }
2065}
Jiyong Park19604de2020-03-24 16:44:11 +09002066
2067func TestAidlExportIncludeDirsFromImports(t *testing.T) {
2068 ctx, _ := testJava(t, `
2069 java_library {
2070 name: "foo",
2071 srcs: ["aidl/foo/IFoo.aidl"],
2072 libs: ["bar"],
2073 }
2074
2075 java_import {
2076 name: "bar",
2077 jars: ["a.jar"],
2078 aidl: {
2079 export_include_dirs: ["aidl/bar"],
2080 },
2081 }
2082 `)
2083
2084 aidlCommand := ctx.ModuleForTests("foo", "android_common").Rule("aidl").RuleParams.Command
2085 expectedAidlFlag := "-Iaidl/bar"
2086 if !strings.Contains(aidlCommand, expectedAidlFlag) {
2087 t.Errorf("aidl command %q does not contain %q", aidlCommand, expectedAidlFlag)
2088 }
2089}
Liz Kammerdd849a82020-06-12 16:38:45 -07002090
2091func TestDataNativeBinaries(t *testing.T) {
2092 ctx, config := testJava(t, `
2093 java_test_host {
2094 name: "foo",
2095 srcs: ["a.java"],
2096 data_native_bins: ["bin"]
2097 }
2098
2099 python_binary_host {
2100 name: "bin",
2101 srcs: ["bin.py"],
2102 }
2103 `)
2104
2105 buildOS := android.BuildOs.String()
2106
2107 test := ctx.ModuleForTests("foo", buildOS+"_common").Module().(*TestHost)
2108 entries := android.AndroidMkEntriesForTest(t, config, "", test)[0]
2109 expected := []string{buildDir + "/.intermediates/bin/" + buildOS + "_x86_64_PY3/bin:bin"}
2110 actual := entries.EntryMap["LOCAL_COMPATIBILITY_SUPPORT_FILES"]
2111 if !reflect.DeepEqual(expected, actual) {
2112 t.Errorf("Unexpected test data - expected: %q, actual: %q", expected, actual)
2113 }
2114}