blob: 958db406d0883730dde6df16089df007175738df [file] [log] [blame]
Colin Cross2207f872021-03-24 12:39:08 -07001// Copyright 2021 Google Inc. All rights reserved.
2//
3// Licensed under the Apache License, Version 2.0 (the "License");
4// you may not use this file except in compliance with the License.
5// You may obtain a copy of the License at
6//
7// http://www.apache.org/licenses/LICENSE-2.0
8//
9// Unless required by applicable law or agreed to in writing, software
10// distributed under the License is distributed on an "AS IS" BASIS,
11// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
12// See the License for the specific language governing permissions and
13// limitations under the License.
14
15package java
16
17import (
18 "fmt"
Anton Hansson86758ac2021-11-03 14:44:12 +000019 "path/filepath"
MÃ¥rten Kongstad802ae0f2022-07-27 13:47:32 +020020 "regexp"
Colin Cross2207f872021-03-24 12:39:08 -070021 "strings"
22
23 "github.com/google/blueprint/proptools"
24
25 "android/soong/android"
26 "android/soong/java/config"
27 "android/soong/remoteexec"
28)
29
Pedro Loureirocc203502021-10-04 17:24:00 +000030// The values allowed for Droidstubs' Api_levels_sdk_type
Cole Faust051fa912022-10-05 12:45:42 -070031var allowedApiLevelSdkTypes = []string{"public", "system", "module-lib", "system-server"}
Pedro Loureirocc203502021-10-04 17:24:00 +000032
Jihoon Kang6592e872023-12-19 01:13:16 +000033type StubsType int
34
35const (
36 Everything StubsType = iota
37 Runtime
38 Exportable
Jihoon Kang78f89142023-12-27 01:40:29 +000039 Unavailable
Jihoon Kang6592e872023-12-19 01:13:16 +000040)
41
42func (s StubsType) String() string {
43 switch s {
44 case Everything:
45 return "everything"
46 case Runtime:
47 return "runtime"
48 case Exportable:
49 return "exportable"
50 default:
51 return ""
52 }
53}
54
Jihoon Kang5d701272024-02-15 21:53:49 +000055func StringToStubsType(s string) StubsType {
56 switch strings.ToLower(s) {
57 case Everything.String():
58 return Everything
59 case Runtime.String():
60 return Runtime
61 case Exportable.String():
62 return Exportable
63 default:
64 return Unavailable
65 }
66}
67
Colin Cross2207f872021-03-24 12:39:08 -070068func init() {
69 RegisterStubsBuildComponents(android.InitRegistrationContext)
70}
71
72func RegisterStubsBuildComponents(ctx android.RegistrationContext) {
73 ctx.RegisterModuleType("stubs_defaults", StubsDefaultsFactory)
74
75 ctx.RegisterModuleType("droidstubs", DroidstubsFactory)
76 ctx.RegisterModuleType("droidstubs_host", DroidstubsHostFactory)
77
78 ctx.RegisterModuleType("prebuilt_stubs_sources", PrebuiltStubsSourcesFactory)
79}
80
Jihoon Kangee113282024-01-23 00:16:41 +000081type stubsArtifacts struct {
82 nullabilityWarningsFile android.WritablePath
83 annotationsZip android.WritablePath
84 apiVersionsXml android.WritablePath
85 metadataZip android.WritablePath
86 metadataDir android.WritablePath
87}
88
Colin Cross2207f872021-03-24 12:39:08 -070089// Droidstubs
Colin Cross2207f872021-03-24 12:39:08 -070090type Droidstubs struct {
91 Javadoc
Spandan Das2cc80ba2023-10-27 17:21:52 +000092 embeddableInModuleAndImport
Colin Cross2207f872021-03-24 12:39:08 -070093
Jihoon Kangee113282024-01-23 00:16:41 +000094 properties DroidstubsProperties
95 apiFile android.Path
96 removedApiFile android.Path
Colin Cross2207f872021-03-24 12:39:08 -070097
98 checkCurrentApiTimestamp android.WritablePath
99 updateCurrentApiTimestamp android.WritablePath
100 checkLastReleasedApiTimestamp android.WritablePath
101 apiLintTimestamp android.WritablePath
102 apiLintReport android.WritablePath
103
104 checkNullabilityWarningsTimestamp android.WritablePath
105
Jihoon Kangee113282024-01-23 00:16:41 +0000106 everythingArtifacts stubsArtifacts
107 exportableArtifacts stubsArtifacts
Jihoon Kang3c89f042023-12-19 02:40:22 +0000108
Jihoon Kangee113282024-01-23 00:16:41 +0000109 exportableApiFile android.WritablePath
110 exportableRemovedApiFile android.WritablePath
Colin Cross2207f872021-03-24 12:39:08 -0700111}
112
113type DroidstubsProperties struct {
114 // The generated public API filename by Metalava, defaults to <module>_api.txt
115 Api_filename *string
116
117 // the generated removed API filename by Metalava, defaults to <module>_removed.txt
118 Removed_api_filename *string
119
Colin Cross2207f872021-03-24 12:39:08 -0700120 Check_api struct {
121 Last_released ApiToCheck
122
123 Current ApiToCheck
124
125 Api_lint struct {
126 Enabled *bool
127
128 // If set, performs api_lint on any new APIs not found in the given signature file
129 New_since *string `android:"path"`
130
131 // If not blank, path to the baseline txt file for approved API lint violations.
132 Baseline_file *string `android:"path"`
133 }
134 }
135
136 // user can specify the version of previous released API file in order to do compatibility check.
137 Previous_api *string `android:"path"`
138
139 // is set to true, Metalava will allow framework SDK to contain annotations.
140 Annotations_enabled *bool
141
142 // a list of top-level directories containing files to merge qualifier annotations (i.e. those intended to be included in the stubs written) from.
143 Merge_annotations_dirs []string
144
145 // a list of top-level directories containing Java stub files to merge show/hide annotations from.
146 Merge_inclusion_annotations_dirs []string
147
148 // a file containing a list of classes to do nullability validation for.
149 Validate_nullability_from_list *string
150
151 // a file containing expected warnings produced by validation of nullability annotations.
152 Check_nullability_warnings *string
153
154 // if set to true, allow Metalava to generate doc_stubs source files. Defaults to false.
155 Create_doc_stubs *bool
156
157 // if set to true, cause Metalava to output Javadoc comments in the stubs source files. Defaults to false.
158 // Has no effect if create_doc_stubs: true.
159 Output_javadoc_comments *bool
160
161 // if set to false then do not write out stubs. Defaults to true.
162 //
163 // TODO(b/146727827): Remove capability when we do not need to generate stubs and API separately.
164 Generate_stubs *bool
165
166 // if set to true, provides a hint to the build system that this rule uses a lot of memory,
Liz Kammer170dd722023-10-16 15:08:39 -0400167 // which can be used for scheduling purposes
Colin Cross2207f872021-03-24 12:39:08 -0700168 High_mem *bool
169
satayev783195c2021-06-23 21:49:57 +0100170 // if set to true, Metalava will allow framework SDK to contain API levels annotations.
Colin Cross2207f872021-03-24 12:39:08 -0700171 Api_levels_annotations_enabled *bool
172
Anton Hanssonc04a16e2022-05-09 09:30:26 +0000173 // Apply the api levels database created by this module rather than generating one in this droidstubs.
174 Api_levels_module *string
175
Colin Cross2207f872021-03-24 12:39:08 -0700176 // the dirs which Metalava extracts API levels annotations from.
177 Api_levels_annotations_dirs []string
178
Cole Faust051fa912022-10-05 12:45:42 -0700179 // the sdk kind which Metalava extracts API levels annotations from. Supports 'public', 'system', 'module-lib' and 'system-server'; defaults to public.
satayev783195c2021-06-23 21:49:57 +0100180 Api_levels_sdk_type *string
181
Colin Cross2207f872021-03-24 12:39:08 -0700182 // the filename which Metalava extracts API levels annotations from. Defaults to android.jar.
183 Api_levels_jar_filename *string
184
185 // if set to true, collect the values used by the Dev tools and
186 // write them in files packaged with the SDK. Defaults to false.
187 Write_sdk_values *bool
MÃ¥rten Kongstad802ae0f2022-07-27 13:47:32 +0200188
189 // path or filegroup to file defining extension an SDK name <-> numerical ID mapping and
190 // what APIs exist in which SDKs; passed to metalava via --sdk-extensions-info
191 Extensions_info_file *string `android:"path"`
Jihoon Kang3198f3c2023-01-26 08:08:52 +0000192
193 // API surface of this module. If set, the module contributes to an API surface.
194 // For the full list of available API surfaces, refer to soong/android/sdk_version.go
195 Api_surface *string
Jihoon Kang6592e872023-12-19 01:13:16 +0000196
197 // a list of aconfig_declarations module names that the stubs generated in this module
198 // depend on.
199 Aconfig_declarations []string
Paul Duffin27819362024-07-22 21:03:50 +0100200
201 // List of hard coded filegroups containing Metalava config files that are passed to every
202 // Metalava invocation that this module performs. See addMetalavaConfigFilesToCmd.
203 ConfigFiles []string `android:"path" blueprint:"mutated"`
Colin Cross2207f872021-03-24 12:39:08 -0700204}
205
Anton Hansson52609322021-05-05 10:36:05 +0100206// Used by xsd_config
207type ApiFilePath interface {
Jihoon Kangee113282024-01-23 00:16:41 +0000208 ApiFilePath(StubsType) (android.Path, error)
Anton Hansson52609322021-05-05 10:36:05 +0100209}
210
211type ApiStubsSrcProvider interface {
Jihoon Kangee113282024-01-23 00:16:41 +0000212 StubsSrcJar(StubsType) (android.Path, error)
Jihoon Kangf55a5f72024-01-08 08:56:20 +0000213}
214
Anton Hansson52609322021-05-05 10:36:05 +0100215// Provider of information about API stubs, used by java_sdk_library.
216type ApiStubsProvider interface {
Jihoon Kangee113282024-01-23 00:16:41 +0000217 AnnotationsZip(StubsType) (android.Path, error)
Anton Hansson52609322021-05-05 10:36:05 +0100218 ApiFilePath
Jihoon Kangee113282024-01-23 00:16:41 +0000219 RemovedApiFilePath(StubsType) (android.Path, error)
Anton Hansson52609322021-05-05 10:36:05 +0100220
221 ApiStubsSrcProvider
222}
223
Jihoon Kang063ec002023-06-28 01:16:23 +0000224type currentApiTimestampProvider interface {
225 CurrentApiTimestamp() android.Path
226}
227
Jihoon Kang3c89f042023-12-19 02:40:22 +0000228type annotationFlagsParams struct {
229 migratingNullability bool
230 validatingNullability bool
231 nullabilityWarningsFile android.WritablePath
232 annotationsZip android.WritablePath
233}
234type stubsCommandParams struct {
235 srcJarDir android.ModuleOutPath
236 stubsDir android.OptionalPath
237 stubsSrcJar android.WritablePath
238 metadataZip android.WritablePath
239 metadataDir android.WritablePath
240 apiVersionsXml android.WritablePath
241 nullabilityWarningsFile android.WritablePath
242 annotationsZip android.WritablePath
243 stubConfig stubsCommandConfigParams
244}
245type stubsCommandConfigParams struct {
Jihoon Kanga11d6792024-03-05 16:12:20 +0000246 stubsType StubsType
247 javaVersion javaVersion
248 deps deps
249 checkApi bool
250 generateStubs bool
251 doApiLint bool
252 doCheckReleased bool
253 writeSdkValues bool
254 migratingNullability bool
255 validatingNullability bool
Jihoon Kang3c89f042023-12-19 02:40:22 +0000256}
257
Colin Cross2207f872021-03-24 12:39:08 -0700258// droidstubs passes sources files through Metalava to generate stub .java files that only contain the API to be
259// documented, filtering out hidden classes and methods. The resulting .java files are intended to be passed to
260// a droiddoc module to generate documentation.
261func DroidstubsFactory() android.Module {
262 module := &Droidstubs{}
263
264 module.AddProperties(&module.properties,
265 &module.Javadoc.properties)
Paul Duffin27819362024-07-22 21:03:50 +0100266 module.properties.ConfigFiles = getMetalavaConfigFilegroupReference()
Spandan Das2cc80ba2023-10-27 17:21:52 +0000267 module.initModuleAndImport(module)
Colin Cross2207f872021-03-24 12:39:08 -0700268
269 InitDroiddocModule(module, android.HostAndDeviceSupported)
Jihoon Kang3198f3c2023-01-26 08:08:52 +0000270
271 module.SetDefaultableHook(func(ctx android.DefaultableHookContext) {
272 module.createApiContribution(ctx)
273 })
Colin Cross2207f872021-03-24 12:39:08 -0700274 return module
275}
276
277// droidstubs_host passes sources files through Metalava to generate stub .java files that only contain the API
278// to be documented, filtering out hidden classes and methods. The resulting .java files are intended to be
279// passed to a droiddoc_host module to generate documentation. Use a droidstubs_host instead of a droidstubs
280// module when symbols needed by the source files are provided by java_library_host modules.
281func DroidstubsHostFactory() android.Module {
282 module := &Droidstubs{}
283
284 module.AddProperties(&module.properties,
285 &module.Javadoc.properties)
286
Paul Duffin27819362024-07-22 21:03:50 +0100287 module.properties.ConfigFiles = getMetalavaConfigFilegroupReference()
Colin Cross2207f872021-03-24 12:39:08 -0700288 InitDroiddocModule(module, android.HostSupported)
289 return module
290}
291
Jihoon Kang246690a2024-02-01 21:55:01 +0000292func (d *Droidstubs) AnnotationsZip(stubsType StubsType) (ret android.Path, err error) {
Jihoon Kang78f89142023-12-27 01:40:29 +0000293 switch stubsType {
294 case Everything:
Jihoon Kang246690a2024-02-01 21:55:01 +0000295 ret, err = d.everythingArtifacts.annotationsZip, nil
Jihoon Kang78f89142023-12-27 01:40:29 +0000296 case Exportable:
Jihoon Kang246690a2024-02-01 21:55:01 +0000297 ret, err = d.exportableArtifacts.annotationsZip, nil
Jihoon Kang78f89142023-12-27 01:40:29 +0000298 default:
Jihoon Kang246690a2024-02-01 21:55:01 +0000299 ret, err = nil, fmt.Errorf("annotations zip not supported for the stub type %s", stubsType.String())
Jihoon Kang78f89142023-12-27 01:40:29 +0000300 }
Jihoon Kang246690a2024-02-01 21:55:01 +0000301 return ret, err
Jihoon Kang78f89142023-12-27 01:40:29 +0000302}
303
Jihoon Kang246690a2024-02-01 21:55:01 +0000304func (d *Droidstubs) ApiFilePath(stubsType StubsType) (ret android.Path, err error) {
Jihoon Kang78f89142023-12-27 01:40:29 +0000305 switch stubsType {
306 case Everything:
Jihoon Kang246690a2024-02-01 21:55:01 +0000307 ret, err = d.apiFile, nil
Jihoon Kang78f89142023-12-27 01:40:29 +0000308 case Exportable:
Jihoon Kang246690a2024-02-01 21:55:01 +0000309 ret, err = d.exportableApiFile, nil
Jihoon Kang78f89142023-12-27 01:40:29 +0000310 default:
Jihoon Kang246690a2024-02-01 21:55:01 +0000311 ret, err = nil, fmt.Errorf("api file path not supported for the stub type %s", stubsType.String())
Jihoon Kang78f89142023-12-27 01:40:29 +0000312 }
Jihoon Kang246690a2024-02-01 21:55:01 +0000313 if ret == nil && err == nil {
Jihoon Kang36c3d962024-03-14 17:28:44 +0000314 err = fmt.Errorf("api file is null for the stub type %s", stubsType.String())
Jihoon Kang246690a2024-02-01 21:55:01 +0000315 }
316 return ret, err
Jihoon Kang78f89142023-12-27 01:40:29 +0000317}
318
Jihoon Kang246690a2024-02-01 21:55:01 +0000319func (d *Droidstubs) ApiVersionsXmlFilePath(stubsType StubsType) (ret android.Path, err error) {
Jihoon Kang78f89142023-12-27 01:40:29 +0000320 switch stubsType {
321 case Everything:
Jihoon Kang246690a2024-02-01 21:55:01 +0000322 ret, err = d.everythingArtifacts.apiVersionsXml, nil
Jihoon Kang78f89142023-12-27 01:40:29 +0000323 case Exportable:
Jihoon Kang246690a2024-02-01 21:55:01 +0000324 ret, err = d.exportableArtifacts.apiVersionsXml, nil
Jihoon Kang78f89142023-12-27 01:40:29 +0000325 default:
Jihoon Kang246690a2024-02-01 21:55:01 +0000326 ret, err = nil, fmt.Errorf("api versions xml file path not supported for the stub type %s", stubsType.String())
Jihoon Kang78f89142023-12-27 01:40:29 +0000327 }
Jihoon Kang246690a2024-02-01 21:55:01 +0000328 if ret == nil && err == nil {
329 err = fmt.Errorf("api versions xml file is null for the stub type %s", stubsType.String())
330 }
331 return ret, err
Jihoon Kang78f89142023-12-27 01:40:29 +0000332}
333
Jihoon Kang246690a2024-02-01 21:55:01 +0000334func (d *Droidstubs) DocZip(stubsType StubsType) (ret android.Path, err error) {
Jihoon Kang78f89142023-12-27 01:40:29 +0000335 switch stubsType {
336 case Everything:
Jihoon Kang246690a2024-02-01 21:55:01 +0000337 ret, err = d.docZip, nil
Jihoon Kang78f89142023-12-27 01:40:29 +0000338 default:
Jihoon Kang246690a2024-02-01 21:55:01 +0000339 ret, err = nil, fmt.Errorf("docs zip not supported for the stub type %s", stubsType.String())
Jihoon Kang78f89142023-12-27 01:40:29 +0000340 }
Jihoon Kang246690a2024-02-01 21:55:01 +0000341 if ret == nil && err == nil {
342 err = fmt.Errorf("docs zip is null for the stub type %s", stubsType.String())
343 }
344 return ret, err
345}
346
347func (d *Droidstubs) RemovedApiFilePath(stubsType StubsType) (ret android.Path, err error) {
348 switch stubsType {
349 case Everything:
350 ret, err = d.removedApiFile, nil
351 case Exportable:
352 ret, err = d.exportableRemovedApiFile, nil
353 default:
354 ret, err = nil, fmt.Errorf("removed api file path not supported for the stub type %s", stubsType.String())
355 }
356 if ret == nil && err == nil {
357 err = fmt.Errorf("removed api file is null for the stub type %s", stubsType.String())
358 }
359 return ret, err
360}
361
362func (d *Droidstubs) StubsSrcJar(stubsType StubsType) (ret android.Path, err error) {
363 switch stubsType {
364 case Everything:
365 ret, err = d.stubsSrcJar, nil
366 case Exportable:
367 ret, err = d.exportableStubsSrcJar, nil
368 default:
369 ret, err = nil, fmt.Errorf("stubs srcjar not supported for the stub type %s", stubsType.String())
370 }
371 if ret == nil && err == nil {
372 err = fmt.Errorf("stubs srcjar is null for the stub type %s", stubsType.String())
373 }
374 return ret, err
Jihoon Kang78f89142023-12-27 01:40:29 +0000375}
376
Jihoon Kang063ec002023-06-28 01:16:23 +0000377func (d *Droidstubs) CurrentApiTimestamp() android.Path {
378 return d.checkCurrentApiTimestamp
379}
380
Colin Cross2207f872021-03-24 12:39:08 -0700381var metalavaMergeAnnotationsDirTag = dependencyTag{name: "metalava-merge-annotations-dir"}
382var metalavaMergeInclusionAnnotationsDirTag = dependencyTag{name: "metalava-merge-inclusion-annotations-dir"}
383var metalavaAPILevelsAnnotationsDirTag = dependencyTag{name: "metalava-api-levels-annotations-dir"}
Anton Hanssonc04a16e2022-05-09 09:30:26 +0000384var metalavaAPILevelsModuleTag = dependencyTag{name: "metalava-api-levels-module-tag"}
Jihoon Kang063ec002023-06-28 01:16:23 +0000385var metalavaCurrentApiTimestampTag = dependencyTag{name: "metalava-current-api-timestamp-tag"}
Colin Cross2207f872021-03-24 12:39:08 -0700386
387func (d *Droidstubs) DepsMutator(ctx android.BottomUpMutatorContext) {
388 d.Javadoc.addDeps(ctx)
389
390 if len(d.properties.Merge_annotations_dirs) != 0 {
391 for _, mergeAnnotationsDir := range d.properties.Merge_annotations_dirs {
392 ctx.AddDependency(ctx.Module(), metalavaMergeAnnotationsDirTag, mergeAnnotationsDir)
393 }
394 }
395
396 if len(d.properties.Merge_inclusion_annotations_dirs) != 0 {
397 for _, mergeInclusionAnnotationsDir := range d.properties.Merge_inclusion_annotations_dirs {
398 ctx.AddDependency(ctx.Module(), metalavaMergeInclusionAnnotationsDirTag, mergeInclusionAnnotationsDir)
399 }
400 }
401
402 if len(d.properties.Api_levels_annotations_dirs) != 0 {
403 for _, apiLevelsAnnotationsDir := range d.properties.Api_levels_annotations_dirs {
404 ctx.AddDependency(ctx.Module(), metalavaAPILevelsAnnotationsDirTag, apiLevelsAnnotationsDir)
405 }
406 }
Anton Hanssonc04a16e2022-05-09 09:30:26 +0000407
Jihoon Kang6592e872023-12-19 01:13:16 +0000408 if len(d.properties.Aconfig_declarations) != 0 {
409 for _, aconfigDeclarationModuleName := range d.properties.Aconfig_declarations {
410 ctx.AddDependency(ctx.Module(), aconfigDeclarationTag, aconfigDeclarationModuleName)
411 }
412 }
413
Anton Hanssonc04a16e2022-05-09 09:30:26 +0000414 if d.properties.Api_levels_module != nil {
415 ctx.AddDependency(ctx.Module(), metalavaAPILevelsModuleTag, proptools.String(d.properties.Api_levels_module))
416 }
Colin Cross2207f872021-03-24 12:39:08 -0700417}
418
Jihoon Kang3c89f042023-12-19 02:40:22 +0000419func (d *Droidstubs) sdkValuesFlags(ctx android.ModuleContext, cmd *android.RuleBuilderCommand, metadataDir android.WritablePath) {
420 cmd.FlagWithArg("--sdk-values ", metadataDir.String())
421}
422
423func (d *Droidstubs) stubsFlags(ctx android.ModuleContext, cmd *android.RuleBuilderCommand, stubsDir android.OptionalPath, stubsType StubsType, checkApi bool) {
Jihoon Kang3c89f042023-12-19 02:40:22 +0000424
Jihoon Kang36c3d962024-03-14 17:28:44 +0000425 apiFileName := proptools.StringDefault(d.properties.Api_filename, ctx.ModuleName()+"_api.txt")
426 uncheckedApiFile := android.PathForModuleOut(ctx, stubsType.String(), apiFileName)
427 cmd.FlagWithOutput("--api ", uncheckedApiFile)
428 if checkApi || String(d.properties.Api_filename) != "" {
Jihoon Kang3c89f042023-12-19 02:40:22 +0000429 if stubsType == Everything {
430 d.apiFile = uncheckedApiFile
431 } else if stubsType == Exportable {
432 d.exportableApiFile = uncheckedApiFile
433 }
Colin Cross2207f872021-03-24 12:39:08 -0700434 } else if sourceApiFile := proptools.String(d.properties.Check_api.Current.Api_file); sourceApiFile != "" {
Jihoon Kang36c3d962024-03-14 17:28:44 +0000435 if stubsType == Everything {
436 // If check api is disabled then make the source file available for export.
437 d.apiFile = android.PathForModuleSrc(ctx, sourceApiFile)
438 } else if stubsType == Exportable {
439 d.exportableApiFile = uncheckedApiFile
440 }
Colin Cross2207f872021-03-24 12:39:08 -0700441 }
442
Jihoon Kang36c3d962024-03-14 17:28:44 +0000443 removedApiFileName := proptools.StringDefault(d.properties.Removed_api_filename, ctx.ModuleName()+"_removed.txt")
444 uncheckedRemovedFile := android.PathForModuleOut(ctx, stubsType.String(), removedApiFileName)
445 cmd.FlagWithOutput("--removed-api ", uncheckedRemovedFile)
Jihoon Kang3c89f042023-12-19 02:40:22 +0000446 if checkApi || String(d.properties.Removed_api_filename) != "" {
Jihoon Kang3c89f042023-12-19 02:40:22 +0000447 if stubsType == Everything {
448 d.removedApiFile = uncheckedRemovedFile
449 } else if stubsType == Exportable {
450 d.exportableRemovedApiFile = uncheckedRemovedFile
451 }
Colin Cross2207f872021-03-24 12:39:08 -0700452 } else if sourceRemovedApiFile := proptools.String(d.properties.Check_api.Current.Removed_api_file); sourceRemovedApiFile != "" {
Jihoon Kang36c3d962024-03-14 17:28:44 +0000453 if stubsType == Everything {
454 // If check api is disabled then make the source removed api file available for export.
455 d.removedApiFile = android.PathForModuleSrc(ctx, sourceRemovedApiFile)
456 } else if stubsType == Exportable {
457 d.exportableRemovedApiFile = uncheckedRemovedFile
458 }
Colin Cross2207f872021-03-24 12:39:08 -0700459 }
460
Colin Cross2207f872021-03-24 12:39:08 -0700461 if stubsDir.Valid() {
462 if Bool(d.properties.Create_doc_stubs) {
463 cmd.FlagWithArg("--doc-stubs ", stubsDir.String())
464 } else {
465 cmd.FlagWithArg("--stubs ", stubsDir.String())
466 if !Bool(d.properties.Output_javadoc_comments) {
467 cmd.Flag("--exclude-documentation-from-stubs")
468 }
469 }
470 }
471}
472
Jihoon Kang3c89f042023-12-19 02:40:22 +0000473func (d *Droidstubs) annotationsFlags(ctx android.ModuleContext, cmd *android.RuleBuilderCommand, params annotationFlagsParams) {
Jihoon Kanga11d6792024-03-05 16:12:20 +0000474 if Bool(d.properties.Annotations_enabled) {
475 cmd.Flag(config.MetalavaAnnotationsFlags)
Andrei Onea4985e512021-04-29 16:29:34 +0100476
Jihoon Kanga11d6792024-03-05 16:12:20 +0000477 if params.migratingNullability {
Jihoon Kang5623e542024-01-31 23:27:26 +0000478 previousApiFiles := android.PathsForModuleSrc(ctx, []string{String(d.properties.Previous_api)})
479 cmd.FlagForEachInput("--migrate-nullness ", previousApiFiles)
Jihoon Kanga11d6792024-03-05 16:12:20 +0000480 }
Jihoon Kang6b93b382024-01-26 22:37:41 +0000481
Jihoon Kanga11d6792024-03-05 16:12:20 +0000482 if s := String(d.properties.Validate_nullability_from_list); s != "" {
483 cmd.FlagWithInput("--validate-nullability-from-list ", android.PathForModuleSrc(ctx, s))
484 }
Jihoon Kang6b93b382024-01-26 22:37:41 +0000485
Jihoon Kanga11d6792024-03-05 16:12:20 +0000486 if params.validatingNullability {
487 cmd.FlagWithOutput("--nullability-warnings-txt ", params.nullabilityWarningsFile)
488 }
Jihoon Kang6b93b382024-01-26 22:37:41 +0000489
Jihoon Kangca2f9e82024-01-26 01:45:12 +0000490 cmd.FlagWithOutput("--extract-annotations ", params.annotationsZip)
Jihoon Kang6b93b382024-01-26 22:37:41 +0000491
Jihoon Kanga11d6792024-03-05 16:12:20 +0000492 if len(d.properties.Merge_annotations_dirs) != 0 {
493 d.mergeAnnoDirFlags(ctx, cmd)
494 }
Jihoon Kang6b93b382024-01-26 22:37:41 +0000495
Jihoon Kanga11d6792024-03-05 16:12:20 +0000496 cmd.Flag(config.MetalavaAnnotationsWarningsFlags)
Colin Cross2207f872021-03-24 12:39:08 -0700497 }
Colin Cross2207f872021-03-24 12:39:08 -0700498}
499
500func (d *Droidstubs) mergeAnnoDirFlags(ctx android.ModuleContext, cmd *android.RuleBuilderCommand) {
501 ctx.VisitDirectDepsWithTag(metalavaMergeAnnotationsDirTag, func(m android.Module) {
502 if t, ok := m.(*ExportedDroiddocDir); ok {
503 cmd.FlagWithArg("--merge-qualifier-annotations ", t.dir.String()).Implicits(t.deps)
504 } else {
505 ctx.PropertyErrorf("merge_annotations_dirs",
506 "module %q is not a metalava merge-annotations dir", ctx.OtherModuleName(m))
507 }
508 })
509}
510
511func (d *Droidstubs) inclusionAnnotationsFlags(ctx android.ModuleContext, cmd *android.RuleBuilderCommand) {
512 ctx.VisitDirectDepsWithTag(metalavaMergeInclusionAnnotationsDirTag, func(m android.Module) {
513 if t, ok := m.(*ExportedDroiddocDir); ok {
514 cmd.FlagWithArg("--merge-inclusion-annotations ", t.dir.String()).Implicits(t.deps)
515 } else {
516 ctx.PropertyErrorf("merge_inclusion_annotations_dirs",
517 "module %q is not a metalava merge-annotations dir", ctx.OtherModuleName(m))
518 }
519 })
520}
521
Jihoon Kanga11d6792024-03-05 16:12:20 +0000522func (d *Droidstubs) apiLevelsAnnotationsFlags(ctx android.ModuleContext, cmd *android.RuleBuilderCommand, stubsType StubsType, apiVersionsXml android.WritablePath) {
Anton Hanssonc04a16e2022-05-09 09:30:26 +0000523 var apiVersions android.Path
Jihoon Kanga11d6792024-03-05 16:12:20 +0000524 if proptools.Bool(d.properties.Api_levels_annotations_enabled) {
Jihoon Kang3c89f042023-12-19 02:40:22 +0000525 d.apiLevelsGenerationFlags(ctx, cmd, stubsType, apiVersionsXml)
Jihoon Kangd9a06942024-01-26 01:49:20 +0000526 apiVersions = apiVersionsXml
Anton Hanssonc04a16e2022-05-09 09:30:26 +0000527 } else {
528 ctx.VisitDirectDepsWithTag(metalavaAPILevelsModuleTag, func(m android.Module) {
529 if s, ok := m.(*Droidstubs); ok {
Jihoon Kangd9a06942024-01-26 01:49:20 +0000530 if stubsType == Everything {
531 apiVersions = s.everythingArtifacts.apiVersionsXml
532 } else if stubsType == Exportable {
533 apiVersions = s.exportableArtifacts.apiVersionsXml
534 } else {
Jihoon Kangd40c5912024-03-05 16:12:20 +0000535 ctx.ModuleErrorf("%s stubs type does not generate api-versions.xml file", stubsType.String())
Jihoon Kangd9a06942024-01-26 01:49:20 +0000536 }
Anton Hanssonc04a16e2022-05-09 09:30:26 +0000537 } else {
538 ctx.PropertyErrorf("api_levels_module",
539 "module %q is not a droidstubs module", ctx.OtherModuleName(m))
540 }
541 })
Colin Cross2207f872021-03-24 12:39:08 -0700542 }
Anton Hanssonc04a16e2022-05-09 09:30:26 +0000543 if apiVersions != nil {
544 cmd.FlagWithArg("--current-version ", ctx.Config().PlatformSdkVersion().String())
545 cmd.FlagWithArg("--current-codename ", ctx.Config().PlatformSdkCodename())
546 cmd.FlagWithInput("--apply-api-levels ", apiVersions)
547 }
548}
Colin Cross2207f872021-03-24 12:39:08 -0700549
Paul Duffin5a195f42024-05-01 12:52:35 +0100550// AndroidPlusUpdatableJar is the name of some extra jars added into `module-lib` and
551// `system-server` directories that contain all the APIs provided by the platform and updatable
552// modules because the `android.jar` files do not. See b/337836752.
553const AndroidPlusUpdatableJar = "android-plus-updatable.jar"
554
Jihoon Kang3c89f042023-12-19 02:40:22 +0000555func (d *Droidstubs) apiLevelsGenerationFlags(ctx android.ModuleContext, cmd *android.RuleBuilderCommand, stubsType StubsType, apiVersionsXml android.WritablePath) {
Colin Cross2207f872021-03-24 12:39:08 -0700556 if len(d.properties.Api_levels_annotations_dirs) == 0 {
557 ctx.PropertyErrorf("api_levels_annotations_dirs",
558 "has to be non-empty if api levels annotations was enabled!")
559 }
560
Jihoon Kang3c89f042023-12-19 02:40:22 +0000561 cmd.FlagWithOutput("--generate-api-levels ", apiVersionsXml)
Colin Cross2207f872021-03-24 12:39:08 -0700562
563 filename := proptools.StringDefault(d.properties.Api_levels_jar_filename, "android.jar")
564
Paul Duffin58cfc9a2024-04-25 17:01:49 +0100565 // TODO: Avoid the duplication of API surfaces, reuse apiScope.
566 // Add all relevant --android-jar-pattern patterns for Metalava.
567 // When parsing a stub jar for a specific version, Metalava picks the first pattern that defines
568 // an actual file present on disk (in the order the patterns were passed). For system APIs for
569 // privileged apps that are only defined since API level 21 (Lollipop), fallback to public stubs
570 // for older releases. Similarly, module-lib falls back to system API.
571 var sdkDirs []string
Paul Duffin92efc612024-05-02 17:18:05 +0100572 apiLevelsSdkType := proptools.StringDefault(d.properties.Api_levels_sdk_type, "public")
573 switch apiLevelsSdkType {
Paul Duffin58cfc9a2024-04-25 17:01:49 +0100574 case "system-server":
575 sdkDirs = []string{"system-server", "module-lib", "system", "public"}
576 case "module-lib":
577 sdkDirs = []string{"module-lib", "system", "public"}
578 case "system":
579 sdkDirs = []string{"system", "public"}
580 case "public":
581 sdkDirs = []string{"public"}
582 default:
583 ctx.PropertyErrorf("api_levels_sdk_type", "needs to be one of %v", allowedApiLevelSdkTypes)
584 return
585 }
586
Paul Duffin92efc612024-05-02 17:18:05 +0100587 // Construct a pattern to match the appropriate extensions that should be included in the
588 // generated api-versions.xml file.
589 //
Paul Duffin58cfc9a2024-04-25 17:01:49 +0100590 // Use the first item in the sdkDirs array as that is the sdk type for the target API levels
591 // being generated but has the advantage over `Api_levels_sdk_type` as it has been validated.
Paul Duffin92efc612024-05-02 17:18:05 +0100592 // The exception is for system-server which needs to include module-lib and system-server. That
593 // is because while system-server extends module-lib the system-server extension directory only
594 // contains service-* modules which provide system-server APIs it does not list the modules which
595 // only provide a module-lib, so they have to be included separately.
596 extensionSurfacesPattern := sdkDirs[0]
597 if apiLevelsSdkType == "system-server" {
598 // Take the first two items in sdkDirs, which are system-server and module-lib, and construct
599 // a pattern that will match either.
600 extensionSurfacesPattern = strings.Join(sdkDirs[0:2], "|")
601 }
602 extensionsPattern := fmt.Sprintf(`/extensions/[0-9]+/(%s)/.*\.jar`, extensionSurfacesPattern)
Paul Duffin58cfc9a2024-04-25 17:01:49 +0100603
satayev783195c2021-06-23 21:49:57 +0100604 var dirs []string
MÃ¥rten Kongstad802ae0f2022-07-27 13:47:32 +0200605 var extensions_dir string
Colin Cross2207f872021-03-24 12:39:08 -0700606 ctx.VisitDirectDepsWithTag(metalavaAPILevelsAnnotationsDirTag, func(m android.Module) {
607 if t, ok := m.(*ExportedDroiddocDir); ok {
Paul Duffin58cfc9a2024-04-25 17:01:49 +0100608 extRegex := regexp.MustCompile(t.dir.String() + extensionsPattern)
MÃ¥rten Kongstad802ae0f2022-07-27 13:47:32 +0200609
610 // Grab the first extensions_dir and we find while scanning ExportedDroiddocDir.deps;
611 // ideally this should be read from prebuiltApis.properties.Extensions_*
Colin Cross2207f872021-03-24 12:39:08 -0700612 for _, dep := range t.deps {
Paul Duffin2ced2eb2024-05-01 13:13:51 +0100613 // Check to see if it matches an extension first.
614 depBase := dep.Base()
MÃ¥rten Kongstad802ae0f2022-07-27 13:47:32 +0200615 if extRegex.MatchString(dep.String()) && d.properties.Extensions_info_file != nil {
616 if extensions_dir == "" {
617 extensions_dir = t.dir.String() + "/extensions"
618 }
619 cmd.Implicit(dep)
Paul Duffin2ced2eb2024-05-01 13:13:51 +0100620 } else if depBase == filename {
621 // Check to see if it matches a dessert release for an SDK, e.g. Android, Car, Wear, etc..
Colin Cross5f6ffc72021-03-29 21:54:45 -0700622 cmd.Implicit(dep)
Paul Duffin5a195f42024-05-01 12:52:35 +0100623 } else if depBase == AndroidPlusUpdatableJar && d.properties.Extensions_info_file != nil {
624 // The output api-versions.xml has been requested to include information on SDK
Paul Duffinee5e0932025-01-15 18:00:35 +0000625 // extensions, i.e. updatable Apis. That means it also needs to include the history of
626 // those updatable APIs. Usually, they would be included in the `android.jar` file but
627 // unfortunately, the `module-lib` and `system-server` cannot as it would lead to build
628 // cycles. So, the module-lib and system-server directories contain an
629 // `android-plus-updatable.jar` that should be used instead of `android.jar`. See
630 // AndroidPlusUpdatableJar for more information.
Paul Duffin5a195f42024-05-01 12:52:35 +0100631 cmd.Implicit(dep)
Colin Cross2207f872021-03-24 12:39:08 -0700632 }
633 }
satayev783195c2021-06-23 21:49:57 +0100634
635 dirs = append(dirs, t.dir.String())
Colin Cross2207f872021-03-24 12:39:08 -0700636 } else {
637 ctx.PropertyErrorf("api_levels_annotations_dirs",
638 "module %q is not a metalava api-levels-annotations dir", ctx.OtherModuleName(m))
639 }
640 })
satayev783195c2021-06-23 21:49:57 +0100641
Paul Duffin5a195f42024-05-01 12:52:35 +0100642 // Generate the list of --android-jar-pattern options. The order matters so the first one which
Paul Duffin4c9d3052025-01-07 16:03:10 +0000643 // matches will be the one that is used for a specific api level.
Pedro Loureirocc203502021-10-04 17:24:00 +0000644 for _, sdkDir := range sdkDirs {
645 for _, dir := range dirs {
Paul Duffin5a195f42024-05-01 12:52:35 +0100646 addPattern := func(jarFilename string) {
Paul Duffin4c9d3052025-01-07 16:03:10 +0000647 cmd.FlagWithArg("--android-jar-pattern ", fmt.Sprintf("%s/{version:level}/%s/%s", dir, sdkDir, jarFilename))
Paul Duffin5a195f42024-05-01 12:52:35 +0100648 }
649
650 if sdkDir == "module-lib" || sdkDir == "system-server" {
651 // The module-lib and system-server android.jars do not include the updatable modules (as
652 // doing so in the source would introduce dependency cycles and the prebuilts have to
653 // match the sources). So, instead an additional `android-plus-updatable.jar` will be used
654 // that does include the updatable modules and this pattern will match that. This pattern
655 // is added in addition to the following pattern to decouple this change from the change
656 // to add the `android-plus-updatable.jar`.
657 addPattern(AndroidPlusUpdatableJar)
658 }
659
660 addPattern(filename)
Pedro Loureirocc203502021-10-04 17:24:00 +0000661 }
Paul Duffin4f707292025-01-16 14:12:31 +0000662
663 if extensions_dir != "" {
664 cmd.FlagWithArg("--android-jar-pattern ", fmt.Sprintf("%s/{version:extension}/%s/{module}.jar", extensions_dir, sdkDir))
665 }
satayev783195c2021-06-23 21:49:57 +0100666 }
MÃ¥rten Kongstad802ae0f2022-07-27 13:47:32 +0200667
668 if d.properties.Extensions_info_file != nil {
669 if extensions_dir == "" {
670 ctx.ModuleErrorf("extensions_info_file set, but no SDK extension dirs found")
671 }
672 info_file := android.PathForModuleSrc(ctx, *d.properties.Extensions_info_file)
673 cmd.Implicit(info_file)
MÃ¥rten Kongstad802ae0f2022-07-27 13:47:32 +0200674 cmd.FlagWithArg("--sdk-extensions-info ", info_file.String())
675 }
Colin Cross2207f872021-03-24 12:39:08 -0700676}
677
Jihoon Kang472f73f2024-03-28 20:59:29 +0000678func (d *Droidstubs) apiCompatibilityFlags(ctx android.ModuleContext, cmd *android.RuleBuilderCommand, stubsType StubsType) {
679 if len(d.Javadoc.properties.Out) > 0 {
680 ctx.PropertyErrorf("out", "out property may not be combined with check_api")
681 }
682
Jihoon Kang5623e542024-01-31 23:27:26 +0000683 apiFiles := android.PathsForModuleSrc(ctx, []string{String(d.properties.Check_api.Last_released.Api_file)})
684 removedApiFiles := android.PathsForModuleSrc(ctx, []string{String(d.properties.Check_api.Last_released.Removed_api_file)})
Jihoon Kang472f73f2024-03-28 20:59:29 +0000685
Jihoon Kang5623e542024-01-31 23:27:26 +0000686 cmd.FlagForEachInput("--check-compatibility:api:released ", apiFiles)
687 cmd.FlagForEachInput("--check-compatibility:removed:released ", removedApiFiles)
Jihoon Kang472f73f2024-03-28 20:59:29 +0000688
689 baselineFile := android.OptionalPathForModuleSrc(ctx, d.properties.Check_api.Last_released.Baseline_file)
690 if baselineFile.Valid() {
691 cmd.FlagWithInput("--baseline:compatibility:released ", baselineFile.Path())
692 }
693}
694
Colin Crosse52c2ac2022-03-28 17:03:35 -0700695func metalavaUseRbe(ctx android.ModuleContext) bool {
696 return ctx.Config().UseRBE() && ctx.Config().IsEnvTrue("RBE_METALAVA")
697}
698
Jihoon Kang421c1cd2024-04-22 21:17:12 +0000699func metalavaCmd(ctx android.ModuleContext, rule *android.RuleBuilder, srcs android.Paths,
Paul Duffin27819362024-07-22 21:03:50 +0100700 srcJarList android.Path, homeDir android.WritablePath, params stubsCommandConfigParams, configFiles android.Paths) *android.RuleBuilderCommand {
Colin Cross2207f872021-03-24 12:39:08 -0700701 rule.Command().Text("rm -rf").Flag(homeDir.String())
702 rule.Command().Text("mkdir -p").Flag(homeDir.String())
703
Anton Hansson556e8142021-06-04 16:20:25 +0100704 cmd := rule.Command()
Colin Cross2207f872021-03-24 12:39:08 -0700705 cmd.FlagWithArg("ANDROID_PREFS_ROOT=", homeDir.String())
706
Colin Crosse52c2ac2022-03-28 17:03:35 -0700707 if metalavaUseRbe(ctx) {
Colin Cross2207f872021-03-24 12:39:08 -0700708 rule.Remoteable(android.RemoteRuleSupports{RBE: true})
Colin Cross8095c292021-03-30 16:40:48 -0700709 execStrategy := ctx.Config().GetenvWithDefault("RBE_METALAVA_EXEC_STRATEGY", remoteexec.LocalExecStrategy)
Anas Sulaiman9d7a36d2023-11-21 23:00:07 +0000710 compare := ctx.Config().IsEnvTrue("RBE_METALAVA_COMPARE")
711 remoteUpdateCache := !ctx.Config().IsEnvFalse("RBE_METALAVA_REMOTE_UPDATE_CACHE")
Colin Cross8095c292021-03-30 16:40:48 -0700712 labels := map[string]string{"type": "tool", "name": "metalava"}
713 // TODO: metalava pool rejects these jobs
714 pool := ctx.Config().GetenvWithDefault("RBE_METALAVA_POOL", "java16")
715 rule.Rewrapper(&remoteexec.REParams{
Anas Sulaiman9d7a36d2023-11-21 23:00:07 +0000716 Labels: labels,
717 ExecStrategy: execStrategy,
718 ToolchainInputs: []string{config.JavaCmd(ctx).String()},
719 Platform: map[string]string{remoteexec.PoolKey: pool},
720 Compare: compare,
721 NumLocalRuns: 1,
722 NumRemoteRuns: 1,
723 NoRemoteUpdateCache: !remoteUpdateCache,
Colin Cross8095c292021-03-30 16:40:48 -0700724 })
Colin Cross2207f872021-03-24 12:39:08 -0700725 }
726
Colin Cross6aa5c402021-03-24 12:28:50 -0700727 cmd.BuiltTool("metalava").ImplicitTool(ctx.Config().HostJavaToolPath(ctx, "metalava.jar")).
Colin Cross2207f872021-03-24 12:39:08 -0700728 Flag(config.JavacVmFlags).
Liz Kammere09e20e2023-10-16 15:07:54 -0400729 Flag(config.MetalavaAddOpens).
Jihoon Kang421c1cd2024-04-22 21:17:12 +0000730 FlagWithArg("--java-source ", params.javaVersion.String()).
731 FlagWithRspFileInputList("@", android.PathForModuleOut(ctx, fmt.Sprintf("%s.metalava.rsp", params.stubsType.String())), srcs).
Colin Cross2207f872021-03-24 12:39:08 -0700732 FlagWithInput("@", srcJarList)
733
Paul Duffinf8aaaa12023-08-10 15:16:35 +0100734 // Metalava does not differentiate between bootclasspath and classpath and has not done so for
735 // years, so it is unlikely to change any time soon.
Jihoon Kang421c1cd2024-04-22 21:17:12 +0000736 combinedPaths := append(([]android.Path)(nil), params.deps.bootClasspath.Paths()...)
737 combinedPaths = append(combinedPaths, params.deps.classpath.Paths()...)
Paul Duffinf8aaaa12023-08-10 15:16:35 +0100738 if len(combinedPaths) > 0 {
739 cmd.FlagWithInputList("--classpath ", combinedPaths, ":")
Colin Cross2207f872021-03-24 12:39:08 -0700740 }
741
Liz Kammere09e20e2023-10-16 15:07:54 -0400742 cmd.Flag(config.MetalavaFlags)
Jihoon Kangc8313892023-09-20 00:54:47 +0000743
Paul Duffin27819362024-07-22 21:03:50 +0100744 addMetalavaConfigFilesToCmd(cmd, configFiles)
745
Colin Cross2207f872021-03-24 12:39:08 -0700746 return cmd
747}
748
Paul Duffin27819362024-07-22 21:03:50 +0100749// MetalavaConfigFilegroup is the name of the filegroup in build/soong/java/metalava that lists
750// the configuration files to pass to Metalava.
751const MetalavaConfigFilegroup = "metalava-config-files"
752
753// Get a reference to the MetalavaConfigFilegroup suitable for use in a property.
754func getMetalavaConfigFilegroupReference() []string {
755 return []string{":" + MetalavaConfigFilegroup}
756}
757
758// addMetalavaConfigFilesToCmd adds --config-file options to use the config files list in the
759// MetalavaConfigFilegroup filegroup.
760func addMetalavaConfigFilesToCmd(cmd *android.RuleBuilderCommand, configFiles android.Paths) {
761 cmd.FlagForEachInput("--config-file ", configFiles)
762}
763
Jihoon Kang3c89f042023-12-19 02:40:22 +0000764// Pass flagged apis related flags to metalava. When aconfig_declarations property is not
765// defined for a module, simply revert all flagged apis annotations. If aconfig_declarations
766// property is defined, apply transformations and only revert the flagged apis that are not
767// enabled via release configurations and are not specified in aconfig_declarations
Jihoon Kang5d701272024-02-15 21:53:49 +0000768func generateRevertAnnotationArgs(ctx android.ModuleContext, cmd *android.RuleBuilderCommand, stubsType StubsType, aconfigFlagsPaths android.Paths) {
Jihoon Kang6592e872023-12-19 01:13:16 +0000769 var filterArgs string
770 switch stubsType {
771 // No flagged apis specific flags need to be passed to metalava when generating
772 // everything stubs
773 case Everything:
774 return
775
776 case Runtime:
777 filterArgs = "--filter='state:ENABLED+permission:READ_ONLY' --filter='permission:READ_WRITE'"
778
779 case Exportable:
Jihoon Kang59198152024-02-06 22:43:18 +0000780 // When the build flag RELEASE_EXPORT_RUNTIME_APIS is set to true, apis marked with
781 // the flagged apis that have read_write permissions are exposed on top of the enabled
782 // and read_only apis. This is to support local override of flag values at runtime.
783 if ctx.Config().ReleaseExportRuntimeApis() {
784 filterArgs = "--filter='state:ENABLED+permission:READ_ONLY' --filter='permission:READ_WRITE'"
785 } else {
786 filterArgs = "--filter='state:ENABLED+permission:READ_ONLY'"
787 }
Jihoon Kang6592e872023-12-19 01:13:16 +0000788 }
789
Jihoon Kangf1e0ff02024-11-20 21:10:40 +0000790 if len(aconfigFlagsPaths) == 0 {
791 // This argument should not be added for "everything" stubs
792 cmd.Flag("--revert-annotation android.annotation.FlaggedApi")
793 return
794 }
795
796 releasedFlaggedApisFile := android.PathForModuleOut(ctx, fmt.Sprintf("released-flagged-apis-%s.txt", stubsType.String()))
797 revertAnnotationsFile := android.PathForModuleOut(ctx, fmt.Sprintf("revert-annotations-%s.txt", stubsType.String()))
798
Jihoon Kang6592e872023-12-19 01:13:16 +0000799 ctx.Build(pctx, android.BuildParams{
800 Rule: gatherReleasedFlaggedApisRule,
801 Inputs: aconfigFlagsPaths,
802 Output: releasedFlaggedApisFile,
803 Description: fmt.Sprintf("%s gather aconfig flags", stubsType),
804 Args: map[string]string{
805 "flags_path": android.JoinPathsWithPrefix(aconfigFlagsPaths, "--cache "),
806 "filter_args": filterArgs,
807 },
808 })
809
810 ctx.Build(pctx, android.BuildParams{
811 Rule: generateMetalavaRevertAnnotationsRule,
812 Input: releasedFlaggedApisFile,
813 Output: revertAnnotationsFile,
814 Description: fmt.Sprintf("%s revert annotations", stubsType),
815 })
Jihoon Kang3c89f042023-12-19 02:40:22 +0000816
817 cmd.FlagWithInput("@", revertAnnotationsFile)
Jihoon Kang6592e872023-12-19 01:13:16 +0000818}
819
Jihoon Kang3c89f042023-12-19 02:40:22 +0000820func (d *Droidstubs) commonMetalavaStubCmd(ctx android.ModuleContext, rule *android.RuleBuilder,
821 params stubsCommandParams) *android.RuleBuilderCommand {
Colin Cross2207f872021-03-24 12:39:08 -0700822 if BoolDefault(d.properties.High_mem, false) {
823 // This metalava run uses lots of memory, restrict the number of metalava jobs that can run in parallel.
824 rule.HighMem()
825 }
826
Jihoon Kang3c89f042023-12-19 02:40:22 +0000827 if params.stubConfig.generateStubs {
828 rule.Command().Text("rm -rf").Text(params.stubsDir.String())
829 rule.Command().Text("mkdir -p").Text(params.stubsDir.String())
Colin Cross2207f872021-03-24 12:39:08 -0700830 }
831
Jihoon Kang3c89f042023-12-19 02:40:22 +0000832 srcJarList := zipSyncCmd(ctx, rule, params.srcJarDir, d.Javadoc.srcJars)
Colin Cross2207f872021-03-24 12:39:08 -0700833
Jihoon Kang3c89f042023-12-19 02:40:22 +0000834 homeDir := android.PathForModuleOut(ctx, params.stubConfig.stubsType.String(), "home")
Paul Duffin27819362024-07-22 21:03:50 +0100835
836 configFiles := android.PathsForModuleSrc(ctx, d.properties.ConfigFiles)
837
838 cmd := metalavaCmd(ctx, rule, d.Javadoc.srcFiles, srcJarList, homeDir, params.stubConfig, configFiles)
Colin Cross2207f872021-03-24 12:39:08 -0700839 cmd.Implicits(d.Javadoc.implicits)
840
Jihoon Kang3c89f042023-12-19 02:40:22 +0000841 d.stubsFlags(ctx, cmd, params.stubsDir, params.stubConfig.stubsType, params.stubConfig.checkApi)
Colin Cross2207f872021-03-24 12:39:08 -0700842
Jihoon Kang3c89f042023-12-19 02:40:22 +0000843 if params.stubConfig.writeSdkValues {
844 d.sdkValuesFlags(ctx, cmd, params.metadataDir)
845 }
846
847 annotationParams := annotationFlagsParams{
848 migratingNullability: params.stubConfig.migratingNullability,
849 validatingNullability: params.stubConfig.validatingNullability,
850 nullabilityWarningsFile: params.nullabilityWarningsFile,
851 annotationsZip: params.annotationsZip,
852 }
853
Jihoon Kanga11d6792024-03-05 16:12:20 +0000854 d.annotationsFlags(ctx, cmd, annotationParams)
Colin Cross2207f872021-03-24 12:39:08 -0700855 d.inclusionAnnotationsFlags(ctx, cmd)
Jihoon Kanga11d6792024-03-05 16:12:20 +0000856 d.apiLevelsAnnotationsFlags(ctx, cmd, params.stubConfig.stubsType, params.apiVersionsXml)
Colin Cross2207f872021-03-24 12:39:08 -0700857
Jihoon Kang472f73f2024-03-28 20:59:29 +0000858 if params.stubConfig.doCheckReleased {
859 d.apiCompatibilityFlags(ctx, cmd, params.stubConfig.stubsType)
860 }
861
Colin Crossbc139922021-03-25 18:33:16 -0700862 d.expandArgs(ctx, cmd)
Colin Cross2207f872021-03-24 12:39:08 -0700863
Colin Cross2207f872021-03-24 12:39:08 -0700864 for _, o := range d.Javadoc.properties.Out {
865 cmd.ImplicitOutput(android.PathForModuleGen(ctx, o))
866 }
867
Jihoon Kang3c89f042023-12-19 02:40:22 +0000868 return cmd
869}
Colin Cross2207f872021-03-24 12:39:08 -0700870
Jihoon Kang3c89f042023-12-19 02:40:22 +0000871// Sandbox rule for generating the everything stubs and other artifacts
872func (d *Droidstubs) everythingStubCmd(ctx android.ModuleContext, params stubsCommandConfigParams) {
873 srcJarDir := android.PathForModuleOut(ctx, Everything.String(), "srcjars")
874 rule := android.NewRuleBuilder(pctx, ctx)
875 rule.Sbox(android.PathForModuleOut(ctx, Everything.String()),
876 android.PathForModuleOut(ctx, "metalava.sbox.textproto")).
877 SandboxInputs()
878
879 var stubsDir android.OptionalPath
880 if params.generateStubs {
881 stubsDir = android.OptionalPathForPath(android.PathForModuleOut(ctx, Everything.String(), "stubsDir"))
882 d.Javadoc.stubsSrcJar = android.PathForModuleOut(ctx, Everything.String(), ctx.ModuleName()+"-"+"stubs.srcjar")
883 }
884
885 if params.writeSdkValues {
Jihoon Kangee113282024-01-23 00:16:41 +0000886 d.everythingArtifacts.metadataDir = android.PathForModuleOut(ctx, Everything.String(), "metadata")
887 d.everythingArtifacts.metadataZip = android.PathForModuleOut(ctx, Everything.String(), ctx.ModuleName()+"-metadata.zip")
Jihoon Kang3c89f042023-12-19 02:40:22 +0000888 }
889
Jihoon Kanga11d6792024-03-05 16:12:20 +0000890 if Bool(d.properties.Annotations_enabled) {
Jihoon Kang3c89f042023-12-19 02:40:22 +0000891 if params.validatingNullability {
Jihoon Kangee113282024-01-23 00:16:41 +0000892 d.everythingArtifacts.nullabilityWarningsFile = android.PathForModuleOut(ctx, Everything.String(), ctx.ModuleName()+"_nullability_warnings.txt")
Jihoon Kang3c89f042023-12-19 02:40:22 +0000893 }
Jihoon Kangee113282024-01-23 00:16:41 +0000894 d.everythingArtifacts.annotationsZip = android.PathForModuleOut(ctx, Everything.String(), ctx.ModuleName()+"_annotations.zip")
Jihoon Kang3c89f042023-12-19 02:40:22 +0000895 }
Jihoon Kanga11d6792024-03-05 16:12:20 +0000896 if Bool(d.properties.Api_levels_annotations_enabled) {
Jihoon Kangee113282024-01-23 00:16:41 +0000897 d.everythingArtifacts.apiVersionsXml = android.PathForModuleOut(ctx, Everything.String(), "api-versions.xml")
Jihoon Kang3c89f042023-12-19 02:40:22 +0000898 }
899
900 commonCmdParams := stubsCommandParams{
901 srcJarDir: srcJarDir,
902 stubsDir: stubsDir,
903 stubsSrcJar: d.Javadoc.stubsSrcJar,
Jihoon Kangee113282024-01-23 00:16:41 +0000904 metadataDir: d.everythingArtifacts.metadataDir,
905 apiVersionsXml: d.everythingArtifacts.apiVersionsXml,
906 nullabilityWarningsFile: d.everythingArtifacts.nullabilityWarningsFile,
907 annotationsZip: d.everythingArtifacts.annotationsZip,
Jihoon Kang3c89f042023-12-19 02:40:22 +0000908 stubConfig: params,
909 }
910
911 cmd := d.commonMetalavaStubCmd(ctx, rule, commonCmdParams)
912
913 d.everythingOptionalCmd(ctx, cmd, params.doApiLint, params.doCheckReleased)
914
915 if params.generateStubs {
916 rule.Command().
917 BuiltTool("soong_zip").
918 Flag("-write_if_changed").
919 Flag("-jar").
920 FlagWithOutput("-o ", d.Javadoc.stubsSrcJar).
921 FlagWithArg("-C ", stubsDir.String()).
922 FlagWithArg("-D ", stubsDir.String())
923 }
924
925 if params.writeSdkValues {
926 rule.Command().
927 BuiltTool("soong_zip").
928 Flag("-write_if_changed").
929 Flag("-d").
Jihoon Kangee113282024-01-23 00:16:41 +0000930 FlagWithOutput("-o ", d.everythingArtifacts.metadataZip).
931 FlagWithArg("-C ", d.everythingArtifacts.metadataDir.String()).
932 FlagWithArg("-D ", d.everythingArtifacts.metadataDir.String())
Jihoon Kang3c89f042023-12-19 02:40:22 +0000933 }
934
935 // TODO: We don't really need two separate API files, but this is a reminiscence of how
936 // we used to run metalava separately for API lint and the "last_released" check. Unify them.
937 if params.doApiLint {
938 rule.Command().Text("touch").Output(d.apiLintTimestamp)
939 }
940 if params.doCheckReleased {
941 rule.Command().Text("touch").Output(d.checkLastReleasedApiTimestamp)
942 }
943
944 // TODO(b/183630617): rewrapper doesn't support restat rules
945 if !metalavaUseRbe(ctx) {
946 rule.Restat()
947 }
948
949 zipSyncCleanupCmd(rule, srcJarDir)
950
951 rule.Build("metalava", "metalava merged")
952}
953
954// Sandbox rule for generating the everything artifacts that are not run by
955// default but only run based on the module configurations
956func (d *Droidstubs) everythingOptionalCmd(ctx android.ModuleContext, cmd *android.RuleBuilderCommand, doApiLint bool, doCheckReleased bool) {
Colin Cross2207f872021-03-24 12:39:08 -0700957
958 // Add API lint options.
Paul Duffinbaf34782024-05-28 17:27:22 +0100959 treatDocumentationIssuesAsErrors := false
Jihoon Kang3c89f042023-12-19 02:40:22 +0000960 if doApiLint {
Jihoon Kang5623e542024-01-31 23:27:26 +0000961 var newSince android.Paths
962 if d.properties.Check_api.Api_lint.New_since != nil {
963 newSince = android.PathsForModuleSrc(ctx, []string{proptools.String(d.properties.Check_api.Api_lint.New_since)})
964 }
Paul Duffin0a71d732024-04-22 13:22:56 +0100965 cmd.Flag("--api-lint")
966 cmd.FlagForEachInput("--api-lint-previous-api ", newSince)
Jihoon Kang3c89f042023-12-19 02:40:22 +0000967 d.apiLintReport = android.PathForModuleOut(ctx, Everything.String(), "api_lint_report.txt")
Colin Cross2207f872021-03-24 12:39:08 -0700968 cmd.FlagWithOutput("--report-even-if-suppressed ", d.apiLintReport) // TODO: Change to ":api-lint"
969
Paul Duffinc540bee2024-08-29 15:35:58 +0100970 // If UnflaggedApi issues have not already been configured then make sure that existing
971 // UnflaggedApi issues are reported as warnings but issues in new/changed code are treated as
972 // errors by the Build Warnings Aye Aye Analyzer in Gerrit.
Paul Duffin88d3b392024-08-28 17:37:36 +0100973 // Once existing issues have been fixed this will be changed to error.
Paul Duffinc540bee2024-08-29 15:35:58 +0100974 // TODO(b/362771529): Switch to --error
975 if !strings.Contains(cmd.String(), " UnflaggedApi ") {
976 cmd.Flag("--error-when-new UnflaggedApi")
977 }
Paul Duffin88d3b392024-08-28 17:37:36 +0100978
Colin Cross0d532412021-03-25 09:38:45 -0700979 // TODO(b/154317059): Clean up this allowlist by baselining and/or checking in last-released.
Colin Cross2207f872021-03-24 12:39:08 -0700980 if d.Name() != "android.car-system-stubs-docs" &&
981 d.Name() != "android.car-stubs-docs" {
Paul Duffinbaf34782024-05-28 17:27:22 +0100982 treatDocumentationIssuesAsErrors = true
Colin Cross2207f872021-03-24 12:39:08 -0700983 cmd.Flag("--warnings-as-errors") // Most lints are actually warnings.
984 }
985
986 baselineFile := android.OptionalPathForModuleSrc(ctx, d.properties.Check_api.Api_lint.Baseline_file)
Jihoon Kang3c89f042023-12-19 02:40:22 +0000987 updatedBaselineOutput := android.PathForModuleOut(ctx, Everything.String(), "api_lint_baseline.txt")
988 d.apiLintTimestamp = android.PathForModuleOut(ctx, Everything.String(), "api_lint.timestamp")
Colin Cross2207f872021-03-24 12:39:08 -0700989
990 // Note this string includes a special shell quote $' ... ', which decodes the "\n"s.
Colin Cross2207f872021-03-24 12:39:08 -0700991 //
992 // TODO: metalava also has a slightly different message hardcoded. Should we unify this
993 // message and metalava's one?
994 msg := `$'` + // Enclose with $' ... '
995 `************************************************************\n` +
996 `Your API changes are triggering API Lint warnings or errors.\n` +
Colin Cross2207f872021-03-24 12:39:08 -0700997 `\n` +
Adrian Roos40be6472024-11-05 14:25:35 +0000998 `To make the failures go away:\n` +
Colin Cross2207f872021-03-24 12:39:08 -0700999 `\n` +
Adrian Roos40be6472024-11-05 14:25:35 +00001000 `1. REQUIRED: Read the messages carefully and address them by` +
1001 ` fixing the API if appropriate.\n` +
1002 `2. If the failure is a false positive, you can suppress it with:\n` +
1003 ` @SuppressLint("<id>")\n` +
Aurimas Liutikasb23b7452021-05-24 18:00:37 +00001004 ` where the <id> is given in brackets in the error message above.\n`
Colin Cross2207f872021-03-24 12:39:08 -07001005
1006 if baselineFile.Valid() {
1007 cmd.FlagWithInput("--baseline:api-lint ", baselineFile.Path())
1008 cmd.FlagWithOutput("--update-baseline:api-lint ", updatedBaselineOutput)
1009
1010 msg += fmt.Sprintf(``+
Cole Faust5146e782024-11-15 14:47:49 -08001011 `3. FOR LSC ONLY: You can update the baseline by executing\n`+
Adrian Roos40be6472024-11-05 14:25:35 +00001012 ` the following command:\n`+
Colin Cross63eeda02021-04-15 19:01:57 -07001013 ` (cd $ANDROID_BUILD_TOP && cp \\\n`+
1014 ` "%s" \\\n`+
1015 ` "%s")\n`+
Colin Cross2207f872021-03-24 12:39:08 -07001016 ` To submit the revised baseline.txt to the main Android\n`+
1017 ` repository, you will need approval.\n`, updatedBaselineOutput, baselineFile.Path())
1018 } else {
1019 msg += fmt.Sprintf(``+
Adrian Roos40be6472024-11-05 14:25:35 +00001020 `3. FOR LSC ONLY: You can add a baseline file of existing lint failures\n`+
Colin Cross2207f872021-03-24 12:39:08 -07001021 ` to the build rule of %s.\n`, d.Name())
1022 }
1023 // Note the message ends with a ' (single quote), to close the $' ... ' .
1024 msg += `************************************************************\n'`
1025
1026 cmd.FlagWithArg("--error-message:api-lint ", msg)
1027 }
1028
Paul Duffinbaf34782024-05-28 17:27:22 +01001029 if !treatDocumentationIssuesAsErrors {
Paul Duffinb679bdd2024-06-10 14:29:41 +01001030 treatDocumentationIssuesAsWarningErrorWhenNew(cmd)
Paul Duffinbaf34782024-05-28 17:27:22 +01001031 }
1032
Colin Cross2207f872021-03-24 12:39:08 -07001033 // Add "check released" options. (Detect incompatible API changes from the last public release)
Jihoon Kang3c89f042023-12-19 02:40:22 +00001034 if doCheckReleased {
Colin Cross2207f872021-03-24 12:39:08 -07001035 baselineFile := android.OptionalPathForModuleSrc(ctx, d.properties.Check_api.Last_released.Baseline_file)
Jihoon Kang3c89f042023-12-19 02:40:22 +00001036 d.checkLastReleasedApiTimestamp = android.PathForModuleOut(ctx, Everything.String(), "check_last_released_api.timestamp")
Colin Cross2207f872021-03-24 12:39:08 -07001037 if baselineFile.Valid() {
Jihoon Kang472f73f2024-03-28 20:59:29 +00001038 updatedBaselineOutput := android.PathForModuleOut(ctx, Everything.String(), "last_released_baseline.txt")
Colin Cross2207f872021-03-24 12:39:08 -07001039 cmd.FlagWithOutput("--update-baseline:compatibility:released ", updatedBaselineOutput)
1040 }
Colin Cross2207f872021-03-24 12:39:08 -07001041 // Note this string includes quote ($' ... '), which decodes the "\n"s.
1042 msg := `$'\n******************************\n` +
1043 `You have tried to change the API from what has been previously released in\n` +
1044 `an SDK. Please fix the errors listed above.\n` +
1045 `******************************\n'`
1046
1047 cmd.FlagWithArg("--error-message:compatibility:released ", msg)
1048 }
1049
Paul Duffin10a23c22023-08-11 22:47:31 +01001050 if apiCheckEnabled(ctx, d.properties.Check_api.Current, "current") {
1051 // Pass the current API file into metalava so it can use it as the basis for determining how to
1052 // generate the output signature files (both api and removed).
1053 currentApiFile := android.PathForModuleSrc(ctx, String(d.properties.Check_api.Current.Api_file))
1054 cmd.FlagWithInput("--use-same-format-as ", currentApiFile)
1055 }
Jihoon Kang3c89f042023-12-19 02:40:22 +00001056}
Paul Duffin10a23c22023-08-11 22:47:31 +01001057
Paul Duffinb679bdd2024-06-10 14:29:41 +01001058// HIDDEN_DOCUMENTATION_ISSUES is the set of documentation related issues that should always be
1059// hidden as they are very noisy and provide little value.
1060var HIDDEN_DOCUMENTATION_ISSUES = []string{
1061 "Deprecated",
1062 "IntDef",
1063 "Nullable",
1064}
1065
1066func treatDocumentationIssuesAsWarningErrorWhenNew(cmd *android.RuleBuilderCommand) {
1067 // Treat documentation issues as warnings, but error when new.
1068 cmd.Flag("--error-when-new-category").Flag("Documentation")
1069
1070 // Hide some documentation issues that generated a lot of noise for little benefit.
1071 cmd.FlagForEachArg("--hide ", HIDDEN_DOCUMENTATION_ISSUES)
1072}
1073
Jihoon Kang3c89f042023-12-19 02:40:22 +00001074// Sandbox rule for generating exportable stubs and other artifacts
1075func (d *Droidstubs) exportableStubCmd(ctx android.ModuleContext, params stubsCommandConfigParams) {
1076 optionalCmdParams := stubsCommandParams{
1077 stubConfig: params,
1078 }
1079
Jihoon Kang246690a2024-02-01 21:55:01 +00001080 if params.generateStubs {
1081 d.Javadoc.exportableStubsSrcJar = android.PathForModuleOut(ctx, params.stubsType.String(), ctx.ModuleName()+"-"+"stubs.srcjar")
1082 optionalCmdParams.stubsSrcJar = d.Javadoc.exportableStubsSrcJar
1083 }
1084
Jihoon Kang3c89f042023-12-19 02:40:22 +00001085 if params.writeSdkValues {
Jihoon Kangee113282024-01-23 00:16:41 +00001086 d.exportableArtifacts.metadataZip = android.PathForModuleOut(ctx, params.stubsType.String(), ctx.ModuleName()+"-metadata.zip")
1087 d.exportableArtifacts.metadataDir = android.PathForModuleOut(ctx, params.stubsType.String(), "metadata")
1088 optionalCmdParams.metadataZip = d.exportableArtifacts.metadataZip
1089 optionalCmdParams.metadataDir = d.exportableArtifacts.metadataDir
Jihoon Kang3c89f042023-12-19 02:40:22 +00001090 }
1091
Jihoon Kanga11d6792024-03-05 16:12:20 +00001092 if Bool(d.properties.Annotations_enabled) {
Jihoon Kang3c89f042023-12-19 02:40:22 +00001093 if params.validatingNullability {
Jihoon Kangee113282024-01-23 00:16:41 +00001094 d.exportableArtifacts.nullabilityWarningsFile = android.PathForModuleOut(ctx, params.stubsType.String(), ctx.ModuleName()+"_nullability_warnings.txt")
1095 optionalCmdParams.nullabilityWarningsFile = d.exportableArtifacts.nullabilityWarningsFile
Jihoon Kang3c89f042023-12-19 02:40:22 +00001096 }
Jihoon Kangee113282024-01-23 00:16:41 +00001097 d.exportableArtifacts.annotationsZip = android.PathForModuleOut(ctx, params.stubsType.String(), ctx.ModuleName()+"_annotations.zip")
1098 optionalCmdParams.annotationsZip = d.exportableArtifacts.annotationsZip
Jihoon Kang3c89f042023-12-19 02:40:22 +00001099 }
Jihoon Kanga11d6792024-03-05 16:12:20 +00001100 if Bool(d.properties.Api_levels_annotations_enabled) {
Jihoon Kangee113282024-01-23 00:16:41 +00001101 d.exportableArtifacts.apiVersionsXml = android.PathForModuleOut(ctx, params.stubsType.String(), "api-versions.xml")
1102 optionalCmdParams.apiVersionsXml = d.exportableArtifacts.apiVersionsXml
Jihoon Kang3c89f042023-12-19 02:40:22 +00001103 }
1104
1105 if params.checkApi || String(d.properties.Api_filename) != "" {
1106 filename := proptools.StringDefault(d.properties.Api_filename, ctx.ModuleName()+"_api.txt")
1107 d.exportableApiFile = android.PathForModuleOut(ctx, params.stubsType.String(), filename)
1108 }
1109
1110 if params.checkApi || String(d.properties.Removed_api_filename) != "" {
1111 filename := proptools.StringDefault(d.properties.Removed_api_filename, ctx.ModuleName()+"_api.txt")
1112 d.exportableRemovedApiFile = android.PathForModuleOut(ctx, params.stubsType.String(), filename)
1113 }
1114
1115 d.optionalStubCmd(ctx, optionalCmdParams)
1116}
1117
1118func (d *Droidstubs) optionalStubCmd(ctx android.ModuleContext, params stubsCommandParams) {
1119
1120 params.srcJarDir = android.PathForModuleOut(ctx, params.stubConfig.stubsType.String(), "srcjars")
1121 rule := android.NewRuleBuilder(pctx, ctx)
1122 rule.Sbox(android.PathForModuleOut(ctx, params.stubConfig.stubsType.String()),
1123 android.PathForModuleOut(ctx, fmt.Sprintf("metalava_%s.sbox.textproto", params.stubConfig.stubsType.String()))).
1124 SandboxInputs()
1125
1126 if params.stubConfig.generateStubs {
1127 params.stubsDir = android.OptionalPathForPath(android.PathForModuleOut(ctx, params.stubConfig.stubsType.String(), "stubsDir"))
1128 }
1129
1130 cmd := d.commonMetalavaStubCmd(ctx, rule, params)
1131
Jihoon Kang5d701272024-02-15 21:53:49 +00001132 generateRevertAnnotationArgs(ctx, cmd, params.stubConfig.stubsType, params.stubConfig.deps.aconfigProtoFiles)
Jihoon Kang3c89f042023-12-19 02:40:22 +00001133
1134 if params.stubConfig.doApiLint {
1135 // Pass the lint baseline file as an input to resolve the lint errors.
1136 // The exportable stubs generation does not update the lint baseline file.
1137 // Lint baseline file update is handled by the everything stubs
1138 baselineFile := android.OptionalPathForModuleSrc(ctx, d.properties.Check_api.Api_lint.Baseline_file)
1139 if baselineFile.Valid() {
1140 cmd.FlagWithInput("--baseline:api-lint ", baselineFile.Path())
1141 }
1142 }
1143
Paul Duffin71527b72024-05-31 13:30:32 +01001144 // Treat documentation issues as warnings, but error when new.
Paul Duffinb679bdd2024-06-10 14:29:41 +01001145 treatDocumentationIssuesAsWarningErrorWhenNew(cmd)
Paul Duffin71527b72024-05-31 13:30:32 +01001146
Jihoon Kang3c89f042023-12-19 02:40:22 +00001147 if params.stubConfig.generateStubs {
Colin Cross2207f872021-03-24 12:39:08 -07001148 rule.Command().
1149 BuiltTool("soong_zip").
1150 Flag("-write_if_changed").
1151 Flag("-jar").
Jihoon Kang3c89f042023-12-19 02:40:22 +00001152 FlagWithOutput("-o ", params.stubsSrcJar).
1153 FlagWithArg("-C ", params.stubsDir.String()).
1154 FlagWithArg("-D ", params.stubsDir.String())
Colin Cross2207f872021-03-24 12:39:08 -07001155 }
1156
Jihoon Kang3c89f042023-12-19 02:40:22 +00001157 if params.stubConfig.writeSdkValues {
Colin Cross2207f872021-03-24 12:39:08 -07001158 rule.Command().
1159 BuiltTool("soong_zip").
1160 Flag("-write_if_changed").
1161 Flag("-d").
Jihoon Kang3c89f042023-12-19 02:40:22 +00001162 FlagWithOutput("-o ", params.metadataZip).
1163 FlagWithArg("-C ", params.metadataDir.String()).
1164 FlagWithArg("-D ", params.metadataDir.String())
Colin Cross2207f872021-03-24 12:39:08 -07001165 }
1166
Colin Cross6aa5c402021-03-24 12:28:50 -07001167 // TODO(b/183630617): rewrapper doesn't support restat rules
Colin Crosse52c2ac2022-03-28 17:03:35 -07001168 if !metalavaUseRbe(ctx) {
1169 rule.Restat()
1170 }
Colin Cross2207f872021-03-24 12:39:08 -07001171
Jihoon Kang3c89f042023-12-19 02:40:22 +00001172 zipSyncCleanupCmd(rule, params.srcJarDir)
Colin Cross2207f872021-03-24 12:39:08 -07001173
Jihoon Kang3c89f042023-12-19 02:40:22 +00001174 rule.Build(fmt.Sprintf("metalava_%s", params.stubConfig.stubsType.String()), "metalava merged")
1175}
1176
1177func (d *Droidstubs) GenerateAndroidBuildActions(ctx android.ModuleContext) {
1178 deps := d.Javadoc.collectDeps(ctx)
1179
1180 javaVersion := getJavaVersion(ctx, String(d.Javadoc.properties.Java_version), android.SdkContext(d))
1181 generateStubs := BoolDefault(d.properties.Generate_stubs, true)
1182
1183 // Add options for the other optional tasks: API-lint and check-released.
1184 // We generate separate timestamp files for them.
1185 doApiLint := BoolDefault(d.properties.Check_api.Api_lint.Enabled, false)
1186 doCheckReleased := apiCheckEnabled(ctx, d.properties.Check_api.Last_released, "last_released")
1187
1188 writeSdkValues := Bool(d.properties.Write_sdk_values)
1189
1190 annotationsEnabled := Bool(d.properties.Annotations_enabled)
1191
1192 migratingNullability := annotationsEnabled && String(d.properties.Previous_api) != ""
1193 validatingNullability := annotationsEnabled && (strings.Contains(String(d.Javadoc.properties.Args), "--validate-nullability-from-merged-stubs") ||
1194 String(d.properties.Validate_nullability_from_list) != "")
1195
1196 checkApi := apiCheckEnabled(ctx, d.properties.Check_api.Current, "current") ||
1197 apiCheckEnabled(ctx, d.properties.Check_api.Last_released, "last_released")
1198
1199 stubCmdParams := stubsCommandConfigParams{
Jihoon Kanga11d6792024-03-05 16:12:20 +00001200 javaVersion: javaVersion,
1201 deps: deps,
1202 checkApi: checkApi,
1203 generateStubs: generateStubs,
1204 doApiLint: doApiLint,
1205 doCheckReleased: doCheckReleased,
1206 writeSdkValues: writeSdkValues,
1207 migratingNullability: migratingNullability,
1208 validatingNullability: validatingNullability,
Jihoon Kang3c89f042023-12-19 02:40:22 +00001209 }
1210 stubCmdParams.stubsType = Everything
1211 // Create default (i.e. "everything" stubs) rule for metalava
1212 d.everythingStubCmd(ctx, stubCmdParams)
1213
Jihoon Kangd40c5912024-03-05 16:12:20 +00001214 // The module generates "exportable" (and "runtime" eventually) stubs regardless of whether
Jihoon Kang3c89f042023-12-19 02:40:22 +00001215 // aconfig_declarations property is defined or not. If the property is not defined, the module simply
1216 // strips all flagged apis to generate the "exportable" stubs
1217 stubCmdParams.stubsType = Exportable
1218 d.exportableStubCmd(ctx, stubCmdParams)
Paul Duffinc166b682022-05-27 12:23:08 +00001219
Paul Duffine7a86642022-08-16 15:43:20 +00001220 if apiCheckEnabled(ctx, d.properties.Check_api.Current, "current") {
1221
1222 if len(d.Javadoc.properties.Out) > 0 {
1223 ctx.PropertyErrorf("out", "out property may not be combined with check_api")
1224 }
1225
1226 apiFile := android.PathForModuleSrc(ctx, String(d.properties.Check_api.Current.Api_file))
1227 removedApiFile := android.PathForModuleSrc(ctx, String(d.properties.Check_api.Current.Removed_api_file))
1228 baselineFile := android.OptionalPathForModuleSrc(ctx, d.properties.Check_api.Current.Baseline_file)
1229
1230 if baselineFile.Valid() {
1231 ctx.PropertyErrorf("baseline_file", "current API check can't have a baseline file. (module %s)", ctx.ModuleName())
1232 }
1233
Jihoon Kang3c89f042023-12-19 02:40:22 +00001234 d.checkCurrentApiTimestamp = android.PathForModuleOut(ctx, Everything.String(), "check_current_api.timestamp")
Paul Duffine7a86642022-08-16 15:43:20 +00001235
1236 rule := android.NewRuleBuilder(pctx, ctx)
1237
1238 // Diff command line.
1239 // -F matches the closest "opening" line, such as "package android {"
1240 // and " public class Intent {".
1241 diff := `diff -u -F '{ *$'`
1242
1243 rule.Command().Text("( true")
1244 rule.Command().
1245 Text(diff).
1246 Input(apiFile).Input(d.apiFile)
1247
1248 rule.Command().
1249 Text(diff).
1250 Input(removedApiFile).Input(d.removedApiFile)
1251
1252 msg := fmt.Sprintf(`\n******************************\n`+
1253 `You have tried to change the API from what has been previously approved.\n\n`+
1254 `To make these errors go away, you have two choices:\n`+
1255 ` 1. You can add '@hide' javadoc comments (and remove @SystemApi/@TestApi/etc)\n`+
1256 ` to the new methods, etc. shown in the above diff.\n\n`+
1257 ` 2. You can update current.txt and/or removed.txt by executing the following command:\n`+
1258 ` m %s-update-current-api\n\n`+
1259 ` To submit the revised current.txt to the main Android repository,\n`+
1260 ` you will need approval.\n`+
Jihoon Kang3ea64672023-11-03 00:40:26 +00001261 `If your build failed due to stub validation, you can resolve the errors with\n`+
1262 `either of the two choices above and try re-building the target.\n`+
1263 `If the mismatch between the stubs and the current.txt is intended,\n`+
1264 `you can try re-building the target by executing the following command:\n`+
Jihoon Kang91bf3dd2024-01-24 00:40:23 +00001265 `m DISABLE_STUB_VALIDATION=true <your build target>.\n`+
1266 `Note that DISABLE_STUB_VALIDATION=true does not bypass checkapi.\n`+
Paul Duffine7a86642022-08-16 15:43:20 +00001267 `******************************\n`, ctx.ModuleName())
1268
1269 rule.Command().
1270 Text("touch").Output(d.checkCurrentApiTimestamp).
1271 Text(") || (").
1272 Text("echo").Flag("-e").Flag(`"` + msg + `"`).
1273 Text("; exit 38").
1274 Text(")")
1275
1276 rule.Build("metalavaCurrentApiCheck", "check current API")
1277
Jihoon Kang3c89f042023-12-19 02:40:22 +00001278 d.updateCurrentApiTimestamp = android.PathForModuleOut(ctx, Everything.String(), "update_current_api.timestamp")
Paul Duffine7a86642022-08-16 15:43:20 +00001279
1280 // update API rule
1281 rule = android.NewRuleBuilder(pctx, ctx)
1282
1283 rule.Command().Text("( true")
1284
1285 rule.Command().
1286 Text("cp").Flag("-f").
1287 Input(d.apiFile).Flag(apiFile.String())
1288
1289 rule.Command().
1290 Text("cp").Flag("-f").
1291 Input(d.removedApiFile).Flag(removedApiFile.String())
1292
1293 msg = "failed to update public API"
1294
1295 rule.Command().
1296 Text("touch").Output(d.updateCurrentApiTimestamp).
1297 Text(") || (").
1298 Text("echo").Flag("-e").Flag(`"` + msg + `"`).
1299 Text("; exit 38").
1300 Text(")")
1301
1302 rule.Build("metalavaCurrentApiUpdate", "update current API")
1303 }
1304
Colin Cross2207f872021-03-24 12:39:08 -07001305 if String(d.properties.Check_nullability_warnings) != "" {
Jihoon Kangee113282024-01-23 00:16:41 +00001306 if d.everythingArtifacts.nullabilityWarningsFile == nil {
Colin Cross2207f872021-03-24 12:39:08 -07001307 ctx.PropertyErrorf("check_nullability_warnings",
1308 "Cannot specify check_nullability_warnings unless validating nullability")
1309 }
1310
1311 checkNullabilityWarnings := android.PathForModuleSrc(ctx, String(d.properties.Check_nullability_warnings))
1312
Jihoon Kang3c89f042023-12-19 02:40:22 +00001313 d.checkNullabilityWarningsTimestamp = android.PathForModuleOut(ctx, Everything.String(), "check_nullability_warnings.timestamp")
Colin Cross2207f872021-03-24 12:39:08 -07001314
1315 msg := fmt.Sprintf(`\n******************************\n`+
1316 `The warnings encountered during nullability annotation validation did\n`+
1317 `not match the checked in file of expected warnings. The diffs are shown\n`+
1318 `above. You have two options:\n`+
1319 ` 1. Resolve the differences by editing the nullability annotations.\n`+
1320 ` 2. Update the file of expected warnings by running:\n`+
1321 ` cp %s %s\n`+
1322 ` and submitting the updated file as part of your change.`,
Jihoon Kangee113282024-01-23 00:16:41 +00001323 d.everythingArtifacts.nullabilityWarningsFile, checkNullabilityWarnings)
Colin Cross2207f872021-03-24 12:39:08 -07001324
1325 rule := android.NewRuleBuilder(pctx, ctx)
1326
1327 rule.Command().
1328 Text("(").
Jihoon Kangee113282024-01-23 00:16:41 +00001329 Text("diff").Input(checkNullabilityWarnings).Input(d.everythingArtifacts.nullabilityWarningsFile).
Colin Cross2207f872021-03-24 12:39:08 -07001330 Text("&&").
1331 Text("touch").Output(d.checkNullabilityWarningsTimestamp).
1332 Text(") || (").
1333 Text("echo").Flag("-e").Flag(`"` + msg + `"`).
1334 Text("; exit 38").
1335 Text(")")
1336
1337 rule.Build("nullabilityWarningsCheck", "nullability warnings check")
1338 }
mrziwang39e68ff2024-07-01 16:35:32 -07001339
1340 d.setOutputFiles(ctx)
1341}
1342
1343// This method sets the outputFiles property, which is used to set the
1344// OutputFilesProvider later.
1345// Droidstubs' tag supports specifying with the stubs type.
1346// While supporting the pre-existing tags, it also supports tags with
1347// the stubs type prefix. Some examples are shown below:
1348// {.annotations.zip} - pre-existing behavior. Returns the path to the
1349// annotation zip.
1350// {.exportable} - Returns the path to the exportable stubs src jar.
1351// {.exportable.annotations.zip} - Returns the path to the exportable
1352// annotations zip file.
1353// {.runtime.api_versions.xml} - Runtime stubs does not generate api versions
1354// xml file. For unsupported combinations, the default everything output file
1355// is returned.
1356func (d *Droidstubs) setOutputFiles(ctx android.ModuleContext) {
1357 tagToOutputFileFunc := map[string]func(StubsType) (android.Path, error){
1358 "": d.StubsSrcJar,
1359 ".docs.zip": d.DocZip,
1360 ".api.txt": d.ApiFilePath,
1361 android.DefaultDistTag: d.ApiFilePath,
1362 ".removed-api.txt": d.RemovedApiFilePath,
1363 ".annotations.zip": d.AnnotationsZip,
1364 ".api_versions.xml": d.ApiVersionsXmlFilePath,
1365 }
1366 stubsTypeToPrefix := map[StubsType]string{
1367 Everything: "",
1368 Exportable: ".exportable",
1369 }
1370 for _, tag := range android.SortedKeys(tagToOutputFileFunc) {
1371 for _, stubType := range android.SortedKeys(stubsTypeToPrefix) {
1372 tagWithPrefix := stubsTypeToPrefix[stubType] + tag
1373 outputFile, err := tagToOutputFileFunc[tag](stubType)
Cole Faust5146e782024-11-15 14:47:49 -08001374 if err == nil && outputFile != nil {
mrziwang39e68ff2024-07-01 16:35:32 -07001375 ctx.SetOutputFiles(android.Paths{outputFile}, tagWithPrefix)
1376 }
1377 }
1378 }
Colin Cross2207f872021-03-24 12:39:08 -07001379}
1380
Jihoon Kang3198f3c2023-01-26 08:08:52 +00001381func (d *Droidstubs) createApiContribution(ctx android.DefaultableHookContext) {
1382 api_file := d.properties.Check_api.Current.Api_file
1383 api_surface := d.properties.Api_surface
1384
1385 props := struct {
1386 Name *string
1387 Api_surface *string
1388 Api_file *string
Jihoon Kang42b589c2023-02-03 22:56:13 +00001389 Visibility []string
Jihoon Kang3198f3c2023-01-26 08:08:52 +00001390 }{}
1391
1392 props.Name = proptools.StringPtr(d.Name() + ".api.contribution")
1393 props.Api_surface = api_surface
1394 props.Api_file = api_file
Jihoon Kang42b589c2023-02-03 22:56:13 +00001395 props.Visibility = []string{"//visibility:override", "//visibility:public"}
Jihoon Kang3198f3c2023-01-26 08:08:52 +00001396
1397 ctx.CreateModule(ApiContributionFactory, &props)
1398}
1399
Spandan Das0b555e32022-11-28 18:48:51 +00001400// TODO (b/262014796): Export the API contributions of CorePlatformApi
1401// A map to populate the api surface of a droidstub from a substring appearing in its name
1402// This map assumes that droidstubs (either checked-in or created by java_sdk_library)
1403// use a strict naming convention
1404var (
1405 droidstubsModuleNamingToSdkKind = map[string]android.SdkKind{
Paul Duffin2ced2eb2024-05-01 13:13:51 +01001406 // public is commented out since the core libraries use public in their java_sdk_library names
Spandan Das0b555e32022-11-28 18:48:51 +00001407 "intracore": android.SdkIntraCore,
1408 "intra.core": android.SdkIntraCore,
1409 "system_server": android.SdkSystemServer,
1410 "system-server": android.SdkSystemServer,
1411 "system": android.SdkSystem,
1412 "module_lib": android.SdkModule,
1413 "module-lib": android.SdkModule,
Spandan Dasda977552023-01-26 20:45:16 +00001414 "platform.api": android.SdkCorePlatform,
Spandan Das0b555e32022-11-28 18:48:51 +00001415 "test": android.SdkTest,
Spandan Das4ac2aed2022-12-28 01:54:29 +00001416 "toolchain": android.SdkToolchain,
Spandan Das0b555e32022-11-28 18:48:51 +00001417 }
1418)
1419
Colin Cross2207f872021-03-24 12:39:08 -07001420func StubsDefaultsFactory() android.Module {
1421 module := &DocDefaults{}
1422
1423 module.AddProperties(
1424 &JavadocProperties{},
1425 &DroidstubsProperties{},
1426 )
1427
1428 android.InitDefaultsModule(module)
1429
1430 return module
1431}
1432
1433var _ android.PrebuiltInterface = (*PrebuiltStubsSources)(nil)
1434
1435type PrebuiltStubsSourcesProperties struct {
1436 Srcs []string `android:"path"`
Spandan Das23956d12024-01-19 00:22:22 +00001437
1438 // Name of the source soong module that gets shadowed by this prebuilt
1439 // If unspecified, follows the naming convention that the source module of
1440 // the prebuilt is Name() without "prebuilt_" prefix
1441 Source_module_name *string
1442
1443 // Non-nil if this prebuilt stub srcs module was dynamically created by a java_sdk_library_import
1444 // The name is the undecorated name of the java_sdk_library as it appears in the blueprint file
1445 // (without any prebuilt_ prefix)
1446 Created_by_java_sdk_library_name *string `blueprint:"mutated"`
1447}
1448
1449func (j *PrebuiltStubsSources) BaseModuleName() string {
1450 return proptools.StringDefault(j.properties.Source_module_name, j.ModuleBase.Name())
1451}
1452
1453func (j *PrebuiltStubsSources) CreatedByJavaSdkLibraryName() *string {
1454 return j.properties.Created_by_java_sdk_library_name
Colin Cross2207f872021-03-24 12:39:08 -07001455}
1456
1457type PrebuiltStubsSources struct {
1458 android.ModuleBase
1459 android.DefaultableModuleBase
Spandan Das2cc80ba2023-10-27 17:21:52 +00001460 embeddableInModuleAndImport
1461
Colin Cross2207f872021-03-24 12:39:08 -07001462 prebuilt android.Prebuilt
Colin Cross2207f872021-03-24 12:39:08 -07001463
1464 properties PrebuiltStubsSourcesProperties
1465
kgui67007242022-01-25 13:50:25 +08001466 stubsSrcJar android.Path
Colin Cross2207f872021-03-24 12:39:08 -07001467}
1468
Jihoon Kangee113282024-01-23 00:16:41 +00001469func (d *PrebuiltStubsSources) StubsSrcJar(_ StubsType) (android.Path, error) {
1470 return d.stubsSrcJar, nil
Colin Cross2207f872021-03-24 12:39:08 -07001471}
1472
1473func (p *PrebuiltStubsSources) GenerateAndroidBuildActions(ctx android.ModuleContext) {
Colin Cross2207f872021-03-24 12:39:08 -07001474 if len(p.properties.Srcs) != 1 {
Anton Hansson86758ac2021-11-03 14:44:12 +00001475 ctx.PropertyErrorf("srcs", "must only specify one directory path or srcjar, contains %d paths", len(p.properties.Srcs))
Colin Cross2207f872021-03-24 12:39:08 -07001476 return
1477 }
1478
Anton Hansson86758ac2021-11-03 14:44:12 +00001479 src := p.properties.Srcs[0]
1480 if filepath.Ext(src) == ".srcjar" {
1481 // This is a srcjar. We can use it directly.
1482 p.stubsSrcJar = android.PathForModuleSrc(ctx, src)
1483 } else {
1484 outPath := android.PathForModuleOut(ctx, ctx.ModuleName()+"-"+"stubs.srcjar")
Colin Cross2207f872021-03-24 12:39:08 -07001485
Anton Hansson86758ac2021-11-03 14:44:12 +00001486 // This is a directory. Glob the contents just in case the directory does not exist.
1487 srcGlob := src + "/**/*"
1488 srcPaths := android.PathsForModuleSrc(ctx, []string{srcGlob})
Colin Cross2207f872021-03-24 12:39:08 -07001489
Anton Hansson86758ac2021-11-03 14:44:12 +00001490 // Although PathForModuleSrc can return nil if either the path doesn't exist or
1491 // the path components are invalid it won't in this case because no components
1492 // are specified and the module directory must exist in order to get this far.
1493 srcDir := android.PathForModuleSrc(ctx).(android.SourcePath).Join(ctx, src)
Colin Cross2207f872021-03-24 12:39:08 -07001494
Anton Hansson86758ac2021-11-03 14:44:12 +00001495 rule := android.NewRuleBuilder(pctx, ctx)
1496 rule.Command().
1497 BuiltTool("soong_zip").
1498 Flag("-write_if_changed").
1499 Flag("-jar").
1500 FlagWithOutput("-o ", outPath).
1501 FlagWithArg("-C ", srcDir.String()).
1502 FlagWithRspFileInputList("-r ", outPath.ReplaceExtension(ctx, "rsp"), srcPaths)
1503 rule.Restat()
1504 rule.Build("zip src", "Create srcjar from prebuilt source")
1505 p.stubsSrcJar = outPath
1506 }
mrziwangaa2a2b62024-07-01 12:09:20 -07001507
1508 ctx.SetOutputFiles(android.Paths{p.stubsSrcJar}, "")
1509 // prebuilt droidstubs does not output "exportable" stubs.
1510 // Output the "everything" stubs srcjar file if the tag is ".exportable".
1511 ctx.SetOutputFiles(android.Paths{p.stubsSrcJar}, ".exportable")
Colin Cross2207f872021-03-24 12:39:08 -07001512}
1513
1514func (p *PrebuiltStubsSources) Prebuilt() *android.Prebuilt {
1515 return &p.prebuilt
1516}
1517
1518func (p *PrebuiltStubsSources) Name() string {
1519 return p.prebuilt.Name(p.ModuleBase.Name())
1520}
1521
1522// prebuilt_stubs_sources imports a set of java source files as if they were
1523// generated by droidstubs.
1524//
1525// By default, a prebuilt_stubs_sources has a single variant that expects a
1526// set of `.java` files generated by droidstubs.
1527//
1528// Specifying `host_supported: true` will produce two variants, one for use as a dependency of device modules and one
1529// for host modules.
1530//
1531// Intended only for use by sdk snapshots.
1532func PrebuiltStubsSourcesFactory() android.Module {
1533 module := &PrebuiltStubsSources{}
1534
1535 module.AddProperties(&module.properties)
Spandan Das2cc80ba2023-10-27 17:21:52 +00001536 module.initModuleAndImport(module)
Colin Cross2207f872021-03-24 12:39:08 -07001537
1538 android.InitPrebuiltModule(module, &module.properties.Srcs)
Colin Cross2207f872021-03-24 12:39:08 -07001539 InitDroiddocModule(module, android.HostAndDeviceSupported)
1540 return module
1541}