blob: 2676f3d6ce88e5e52f761ae52d3fe2ef7c4c11aa [file] [log] [blame]
Colin Cross2207f872021-03-24 12:39:08 -07001// Copyright 2021 Google Inc. All rights reserved.
2//
3// Licensed under the Apache License, Version 2.0 (the "License");
4// you may not use this file except in compliance with the License.
5// You may obtain a copy of the License at
6//
7// http://www.apache.org/licenses/LICENSE-2.0
8//
9// Unless required by applicable law or agreed to in writing, software
10// distributed under the License is distributed on an "AS IS" BASIS,
11// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
12// See the License for the specific language governing permissions and
13// limitations under the License.
14
15package java
16
17import (
18 "fmt"
19 "strings"
20
21 "github.com/google/blueprint/proptools"
22
23 "android/soong/android"
24 "android/soong/java/config"
25 "android/soong/remoteexec"
26)
27
28func init() {
29 RegisterStubsBuildComponents(android.InitRegistrationContext)
30}
31
32func RegisterStubsBuildComponents(ctx android.RegistrationContext) {
33 ctx.RegisterModuleType("stubs_defaults", StubsDefaultsFactory)
34
35 ctx.RegisterModuleType("droidstubs", DroidstubsFactory)
36 ctx.RegisterModuleType("droidstubs_host", DroidstubsHostFactory)
37
38 ctx.RegisterModuleType("prebuilt_stubs_sources", PrebuiltStubsSourcesFactory)
39}
40
41//
42// Droidstubs
43//
44type Droidstubs struct {
45 Javadoc
46 android.SdkBase
47
48 properties DroidstubsProperties
49 apiFile android.WritablePath
50 apiXmlFile android.WritablePath
51 lastReleasedApiXmlFile android.WritablePath
52 privateApiFile android.WritablePath
53 removedApiFile android.WritablePath
54 removedDexApiFile android.WritablePath
55 nullabilityWarningsFile android.WritablePath
56
57 checkCurrentApiTimestamp android.WritablePath
58 updateCurrentApiTimestamp android.WritablePath
59 checkLastReleasedApiTimestamp android.WritablePath
60 apiLintTimestamp android.WritablePath
61 apiLintReport android.WritablePath
62
63 checkNullabilityWarningsTimestamp android.WritablePath
64
65 annotationsZip android.WritablePath
66 apiVersionsXml android.WritablePath
67
68 apiFilePath android.Path
69 removedApiFilePath android.Path
70
71 metadataZip android.WritablePath
72 metadataDir android.WritablePath
73}
74
75type DroidstubsProperties struct {
76 // The generated public API filename by Metalava, defaults to <module>_api.txt
77 Api_filename *string
78
79 // the generated removed API filename by Metalava, defaults to <module>_removed.txt
80 Removed_api_filename *string
81
82 // the generated removed Dex API filename by Metalava.
83 Removed_dex_api_filename *string
84
85 Check_api struct {
86 Last_released ApiToCheck
87
88 Current ApiToCheck
89
90 Api_lint struct {
91 Enabled *bool
92
93 // If set, performs api_lint on any new APIs not found in the given signature file
94 New_since *string `android:"path"`
95
96 // If not blank, path to the baseline txt file for approved API lint violations.
97 Baseline_file *string `android:"path"`
98 }
99 }
100
101 // user can specify the version of previous released API file in order to do compatibility check.
102 Previous_api *string `android:"path"`
103
104 // is set to true, Metalava will allow framework SDK to contain annotations.
105 Annotations_enabled *bool
106
107 // a list of top-level directories containing files to merge qualifier annotations (i.e. those intended to be included in the stubs written) from.
108 Merge_annotations_dirs []string
109
110 // a list of top-level directories containing Java stub files to merge show/hide annotations from.
111 Merge_inclusion_annotations_dirs []string
112
113 // a file containing a list of classes to do nullability validation for.
114 Validate_nullability_from_list *string
115
116 // a file containing expected warnings produced by validation of nullability annotations.
117 Check_nullability_warnings *string
118
119 // if set to true, allow Metalava to generate doc_stubs source files. Defaults to false.
120 Create_doc_stubs *bool
121
122 // if set to true, cause Metalava to output Javadoc comments in the stubs source files. Defaults to false.
123 // Has no effect if create_doc_stubs: true.
124 Output_javadoc_comments *bool
125
126 // if set to false then do not write out stubs. Defaults to true.
127 //
128 // TODO(b/146727827): Remove capability when we do not need to generate stubs and API separately.
129 Generate_stubs *bool
130
131 // if set to true, provides a hint to the build system that this rule uses a lot of memory,
132 // whicih can be used for scheduling purposes
133 High_mem *bool
134
135 // is set to true, Metalava will allow framework SDK to contain API levels annotations.
136 Api_levels_annotations_enabled *bool
137
138 // the dirs which Metalava extracts API levels annotations from.
139 Api_levels_annotations_dirs []string
140
141 // the filename which Metalava extracts API levels annotations from. Defaults to android.jar.
142 Api_levels_jar_filename *string
143
144 // if set to true, collect the values used by the Dev tools and
145 // write them in files packaged with the SDK. Defaults to false.
146 Write_sdk_values *bool
147}
148
149// droidstubs passes sources files through Metalava to generate stub .java files that only contain the API to be
150// documented, filtering out hidden classes and methods. The resulting .java files are intended to be passed to
151// a droiddoc module to generate documentation.
152func DroidstubsFactory() android.Module {
153 module := &Droidstubs{}
154
155 module.AddProperties(&module.properties,
156 &module.Javadoc.properties)
157
158 InitDroiddocModule(module, android.HostAndDeviceSupported)
159 android.InitSdkAwareModule(module)
160 return module
161}
162
163// droidstubs_host passes sources files through Metalava to generate stub .java files that only contain the API
164// to be documented, filtering out hidden classes and methods. The resulting .java files are intended to be
165// passed to a droiddoc_host module to generate documentation. Use a droidstubs_host instead of a droidstubs
166// module when symbols needed by the source files are provided by java_library_host modules.
167func DroidstubsHostFactory() android.Module {
168 module := &Droidstubs{}
169
170 module.AddProperties(&module.properties,
171 &module.Javadoc.properties)
172
173 InitDroiddocModule(module, android.HostSupported)
174 return module
175}
176
177func (d *Droidstubs) OutputFiles(tag string) (android.Paths, error) {
178 switch tag {
179 case "":
180 return android.Paths{d.stubsSrcJar}, nil
181 case ".docs.zip":
182 return android.Paths{d.docZip}, nil
183 case ".api.txt", android.DefaultDistTag:
184 // This is the default dist path for dist properties that have no tag property.
185 return android.Paths{d.apiFilePath}, nil
186 case ".removed-api.txt":
187 return android.Paths{d.removedApiFilePath}, nil
188 case ".annotations.zip":
189 return android.Paths{d.annotationsZip}, nil
190 case ".api_versions.xml":
191 return android.Paths{d.apiVersionsXml}, nil
192 default:
193 return nil, fmt.Errorf("unsupported module reference tag %q", tag)
194 }
195}
196
197func (d *Droidstubs) ApiFilePath() android.Path {
198 return d.apiFilePath
199}
200
201func (d *Droidstubs) RemovedApiFilePath() android.Path {
202 return d.removedApiFilePath
203}
204
205func (d *Droidstubs) StubsSrcJar() android.Path {
206 return d.stubsSrcJar
207}
208
209var metalavaMergeAnnotationsDirTag = dependencyTag{name: "metalava-merge-annotations-dir"}
210var metalavaMergeInclusionAnnotationsDirTag = dependencyTag{name: "metalava-merge-inclusion-annotations-dir"}
211var metalavaAPILevelsAnnotationsDirTag = dependencyTag{name: "metalava-api-levels-annotations-dir"}
212
213func (d *Droidstubs) DepsMutator(ctx android.BottomUpMutatorContext) {
214 d.Javadoc.addDeps(ctx)
215
216 if len(d.properties.Merge_annotations_dirs) != 0 {
217 for _, mergeAnnotationsDir := range d.properties.Merge_annotations_dirs {
218 ctx.AddDependency(ctx.Module(), metalavaMergeAnnotationsDirTag, mergeAnnotationsDir)
219 }
220 }
221
222 if len(d.properties.Merge_inclusion_annotations_dirs) != 0 {
223 for _, mergeInclusionAnnotationsDir := range d.properties.Merge_inclusion_annotations_dirs {
224 ctx.AddDependency(ctx.Module(), metalavaMergeInclusionAnnotationsDirTag, mergeInclusionAnnotationsDir)
225 }
226 }
227
228 if len(d.properties.Api_levels_annotations_dirs) != 0 {
229 for _, apiLevelsAnnotationsDir := range d.properties.Api_levels_annotations_dirs {
230 ctx.AddDependency(ctx.Module(), metalavaAPILevelsAnnotationsDirTag, apiLevelsAnnotationsDir)
231 }
232 }
233}
234
235func (d *Droidstubs) stubsFlags(ctx android.ModuleContext, cmd *android.RuleBuilderCommand, stubsDir android.OptionalPath) {
236 if apiCheckEnabled(ctx, d.properties.Check_api.Current, "current") ||
237 apiCheckEnabled(ctx, d.properties.Check_api.Last_released, "last_released") ||
238 String(d.properties.Api_filename) != "" {
239 filename := proptools.StringDefault(d.properties.Api_filename, ctx.ModuleName()+"_api.txt")
Colin Crosscb77f752021-03-24 12:04:44 -0700240 d.apiFile = android.PathForModuleOut(ctx, "metalava", filename)
Colin Cross2207f872021-03-24 12:39:08 -0700241 cmd.FlagWithOutput("--api ", d.apiFile)
242 d.apiFilePath = d.apiFile
243 } else if sourceApiFile := proptools.String(d.properties.Check_api.Current.Api_file); sourceApiFile != "" {
244 // If check api is disabled then make the source file available for export.
245 d.apiFilePath = android.PathForModuleSrc(ctx, sourceApiFile)
246 }
247
248 if apiCheckEnabled(ctx, d.properties.Check_api.Current, "current") ||
249 apiCheckEnabled(ctx, d.properties.Check_api.Last_released, "last_released") ||
250 String(d.properties.Removed_api_filename) != "" {
251 filename := proptools.StringDefault(d.properties.Removed_api_filename, ctx.ModuleName()+"_removed.txt")
Colin Crosscb77f752021-03-24 12:04:44 -0700252 d.removedApiFile = android.PathForModuleOut(ctx, "metalava", filename)
Colin Cross2207f872021-03-24 12:39:08 -0700253 cmd.FlagWithOutput("--removed-api ", d.removedApiFile)
254 d.removedApiFilePath = d.removedApiFile
255 } else if sourceRemovedApiFile := proptools.String(d.properties.Check_api.Current.Removed_api_file); sourceRemovedApiFile != "" {
256 // If check api is disabled then make the source removed api file available for export.
257 d.removedApiFilePath = android.PathForModuleSrc(ctx, sourceRemovedApiFile)
258 }
259
260 if String(d.properties.Removed_dex_api_filename) != "" {
Colin Crosscb77f752021-03-24 12:04:44 -0700261 d.removedDexApiFile = android.PathForModuleOut(ctx, "metalava", String(d.properties.Removed_dex_api_filename))
Colin Cross2207f872021-03-24 12:39:08 -0700262 cmd.FlagWithOutput("--removed-dex-api ", d.removedDexApiFile)
263 }
264
265 if Bool(d.properties.Write_sdk_values) {
Colin Crosscb77f752021-03-24 12:04:44 -0700266 d.metadataDir = android.PathForModuleOut(ctx, "metalava", "metadata")
Colin Cross2207f872021-03-24 12:39:08 -0700267 cmd.FlagWithArg("--sdk-values ", d.metadataDir.String())
268 }
269
270 if stubsDir.Valid() {
271 if Bool(d.properties.Create_doc_stubs) {
272 cmd.FlagWithArg("--doc-stubs ", stubsDir.String())
273 } else {
274 cmd.FlagWithArg("--stubs ", stubsDir.String())
275 if !Bool(d.properties.Output_javadoc_comments) {
276 cmd.Flag("--exclude-documentation-from-stubs")
277 }
278 }
279 }
280}
281
282func (d *Droidstubs) annotationsFlags(ctx android.ModuleContext, cmd *android.RuleBuilderCommand) {
283 if Bool(d.properties.Annotations_enabled) {
284 cmd.Flag("--include-annotations")
285
286 validatingNullability :=
Colin Crossbc139922021-03-25 18:33:16 -0700287 strings.Contains(String(d.Javadoc.properties.Args), "--validate-nullability-from-merged-stubs") ||
Colin Cross2207f872021-03-24 12:39:08 -0700288 String(d.properties.Validate_nullability_from_list) != ""
289
290 migratingNullability := String(d.properties.Previous_api) != ""
291 if migratingNullability {
292 previousApi := android.PathForModuleSrc(ctx, String(d.properties.Previous_api))
293 cmd.FlagWithInput("--migrate-nullness ", previousApi)
294 }
295
296 if s := String(d.properties.Validate_nullability_from_list); s != "" {
297 cmd.FlagWithInput("--validate-nullability-from-list ", android.PathForModuleSrc(ctx, s))
298 }
299
300 if validatingNullability {
Colin Crosscb77f752021-03-24 12:04:44 -0700301 d.nullabilityWarningsFile = android.PathForModuleOut(ctx, "metalava", ctx.ModuleName()+"_nullability_warnings.txt")
Colin Cross2207f872021-03-24 12:39:08 -0700302 cmd.FlagWithOutput("--nullability-warnings-txt ", d.nullabilityWarningsFile)
303 }
304
Colin Crosscb77f752021-03-24 12:04:44 -0700305 d.annotationsZip = android.PathForModuleOut(ctx, "metalava", ctx.ModuleName()+"_annotations.zip")
Colin Cross2207f872021-03-24 12:39:08 -0700306 cmd.FlagWithOutput("--extract-annotations ", d.annotationsZip)
307
308 if len(d.properties.Merge_annotations_dirs) != 0 {
309 d.mergeAnnoDirFlags(ctx, cmd)
310 }
311
312 // TODO(tnorbye): find owners to fix these warnings when annotation was enabled.
313 cmd.FlagWithArg("--hide ", "HiddenTypedefConstant").
314 FlagWithArg("--hide ", "SuperfluousPrefix").
315 FlagWithArg("--hide ", "AnnotationExtraction")
316 }
317}
318
319func (d *Droidstubs) mergeAnnoDirFlags(ctx android.ModuleContext, cmd *android.RuleBuilderCommand) {
320 ctx.VisitDirectDepsWithTag(metalavaMergeAnnotationsDirTag, func(m android.Module) {
321 if t, ok := m.(*ExportedDroiddocDir); ok {
322 cmd.FlagWithArg("--merge-qualifier-annotations ", t.dir.String()).Implicits(t.deps)
323 } else {
324 ctx.PropertyErrorf("merge_annotations_dirs",
325 "module %q is not a metalava merge-annotations dir", ctx.OtherModuleName(m))
326 }
327 })
328}
329
330func (d *Droidstubs) inclusionAnnotationsFlags(ctx android.ModuleContext, cmd *android.RuleBuilderCommand) {
331 ctx.VisitDirectDepsWithTag(metalavaMergeInclusionAnnotationsDirTag, func(m android.Module) {
332 if t, ok := m.(*ExportedDroiddocDir); ok {
333 cmd.FlagWithArg("--merge-inclusion-annotations ", t.dir.String()).Implicits(t.deps)
334 } else {
335 ctx.PropertyErrorf("merge_inclusion_annotations_dirs",
336 "module %q is not a metalava merge-annotations dir", ctx.OtherModuleName(m))
337 }
338 })
339}
340
341func (d *Droidstubs) apiLevelsAnnotationsFlags(ctx android.ModuleContext, cmd *android.RuleBuilderCommand) {
342 if !Bool(d.properties.Api_levels_annotations_enabled) {
343 return
344 }
345
Colin Crosscb77f752021-03-24 12:04:44 -0700346 d.apiVersionsXml = android.PathForModuleOut(ctx, "metalava", "api-versions.xml")
Colin Cross2207f872021-03-24 12:39:08 -0700347
348 if len(d.properties.Api_levels_annotations_dirs) == 0 {
349 ctx.PropertyErrorf("api_levels_annotations_dirs",
350 "has to be non-empty if api levels annotations was enabled!")
351 }
352
353 cmd.FlagWithOutput("--generate-api-levels ", d.apiVersionsXml)
354 cmd.FlagWithInput("--apply-api-levels ", d.apiVersionsXml)
355 cmd.FlagWithArg("--current-version ", ctx.Config().PlatformSdkVersion().String())
356 cmd.FlagWithArg("--current-codename ", ctx.Config().PlatformSdkCodename())
357
358 filename := proptools.StringDefault(d.properties.Api_levels_jar_filename, "android.jar")
359
360 ctx.VisitDirectDepsWithTag(metalavaAPILevelsAnnotationsDirTag, func(m android.Module) {
361 if t, ok := m.(*ExportedDroiddocDir); ok {
362 for _, dep := range t.deps {
Colin Cross5f6ffc72021-03-29 21:54:45 -0700363 if dep.Base() == filename {
364 cmd.Implicit(dep)
365 }
366 if filename != "android.jar" && dep.Base() == "android.jar" {
367 // Metalava implicitly searches these patterns:
368 // prebuilts/tools/common/api-versions/android-%/android.jar
369 // prebuilts/sdk/%/public/android.jar
370 // Add android.jar files from the api_levels_annotations_dirs directories to try
371 // to satisfy these patterns. If Metalava can't find a match for an API level
372 // between 1 and 28 in at least one pattern it will fail.
Colin Cross2207f872021-03-24 12:39:08 -0700373 cmd.Implicit(dep)
374 }
375 }
376 cmd.FlagWithArg("--android-jar-pattern ", t.dir.String()+"/%/public/"+filename)
377 } else {
378 ctx.PropertyErrorf("api_levels_annotations_dirs",
379 "module %q is not a metalava api-levels-annotations dir", ctx.OtherModuleName(m))
380 }
381 })
382}
383
384func metalavaCmd(ctx android.ModuleContext, rule *android.RuleBuilder, javaVersion javaVersion, srcs android.Paths,
385 srcJarList android.Path, bootclasspath, classpath classpath, sourcepaths android.Paths,
Colin Cross8095c292021-03-30 16:40:48 -0700386 homeDir android.WritablePath) *android.RuleBuilderCommand {
Colin Cross2207f872021-03-24 12:39:08 -0700387 rule.Command().Text("rm -rf").Flag(homeDir.String())
388 rule.Command().Text("mkdir -p").Flag(homeDir.String())
389
390 cmd := rule.Command()
391 cmd.FlagWithArg("ANDROID_PREFS_ROOT=", homeDir.String())
392
393 if ctx.Config().UseRBE() && ctx.Config().IsEnvTrue("RBE_METALAVA") {
394 rule.Remoteable(android.RemoteRuleSupports{RBE: true})
Colin Cross8095c292021-03-30 16:40:48 -0700395 execStrategy := ctx.Config().GetenvWithDefault("RBE_METALAVA_EXEC_STRATEGY", remoteexec.LocalExecStrategy)
396 labels := map[string]string{"type": "tool", "name": "metalava"}
397 // TODO: metalava pool rejects these jobs
398 pool := ctx.Config().GetenvWithDefault("RBE_METALAVA_POOL", "java16")
399 rule.Rewrapper(&remoteexec.REParams{
400 Labels: labels,
401 ExecStrategy: execStrategy,
402 ToolchainInputs: []string{config.JavaCmd(ctx).String()},
403 Platform: map[string]string{remoteexec.PoolKey: pool},
404 })
Colin Cross2207f872021-03-24 12:39:08 -0700405 }
406
Colin Cross6aa5c402021-03-24 12:28:50 -0700407 cmd.BuiltTool("metalava").ImplicitTool(ctx.Config().HostJavaToolPath(ctx, "metalava.jar")).
Colin Cross2207f872021-03-24 12:39:08 -0700408 Flag(config.JavacVmFlags).
409 Flag("-J--add-opens=java.base/java.util=ALL-UNNAMED").
410 FlagWithArg("-encoding ", "UTF-8").
411 FlagWithArg("-source ", javaVersion.String()).
412 FlagWithRspFileInputList("@", android.PathForModuleOut(ctx, "metalava.rsp"), srcs).
413 FlagWithInput("@", srcJarList)
414
Colin Cross2207f872021-03-24 12:39:08 -0700415 if len(bootclasspath) > 0 {
416 cmd.FlagWithInputList("-bootclasspath ", bootclasspath.Paths(), ":")
417 }
418
419 if len(classpath) > 0 {
420 cmd.FlagWithInputList("-classpath ", classpath.Paths(), ":")
421 }
422
423 if len(sourcepaths) > 0 {
424 cmd.FlagWithList("-sourcepath ", sourcepaths.Strings(), ":")
425 } else {
426 cmd.FlagWithArg("-sourcepath ", `""`)
427 }
428
429 cmd.Flag("--no-banner").
430 Flag("--color").
431 Flag("--quiet").
432 Flag("--format=v2").
433 FlagWithArg("--repeat-errors-max ", "10").
434 FlagWithArg("--hide ", "UnresolvedImport")
435
436 return cmd
437}
438
439func (d *Droidstubs) GenerateAndroidBuildActions(ctx android.ModuleContext) {
440 deps := d.Javadoc.collectDeps(ctx)
441
Jiyong Parkf1691d22021-03-29 20:11:58 +0900442 javaVersion := getJavaVersion(ctx, String(d.Javadoc.properties.Java_version), android.SdkContext(d))
Colin Cross2207f872021-03-24 12:39:08 -0700443
444 // Create rule for metalava
445
Colin Crosscb77f752021-03-24 12:04:44 -0700446 srcJarDir := android.PathForModuleOut(ctx, "metalava", "srcjars")
Colin Cross2207f872021-03-24 12:39:08 -0700447
448 rule := android.NewRuleBuilder(pctx, ctx)
449
Colin Cross8095c292021-03-30 16:40:48 -0700450 rule.Sbox(android.PathForModuleOut(ctx, "metalava"),
451 android.PathForModuleOut(ctx, "metalava.sbox.textproto")).
452 SandboxInputs()
Colin Cross6aa5c402021-03-24 12:28:50 -0700453
Colin Cross2207f872021-03-24 12:39:08 -0700454 if BoolDefault(d.properties.High_mem, false) {
455 // This metalava run uses lots of memory, restrict the number of metalava jobs that can run in parallel.
456 rule.HighMem()
457 }
458
459 generateStubs := BoolDefault(d.properties.Generate_stubs, true)
460 var stubsDir android.OptionalPath
461 if generateStubs {
Colin Crosscb77f752021-03-24 12:04:44 -0700462 d.Javadoc.stubsSrcJar = android.PathForModuleOut(ctx, "metalava", ctx.ModuleName()+"-"+"stubs.srcjar")
463 stubsDir = android.OptionalPathForPath(android.PathForModuleOut(ctx, "metalava", "stubsDir"))
Colin Cross2207f872021-03-24 12:39:08 -0700464 rule.Command().Text("rm -rf").Text(stubsDir.String())
465 rule.Command().Text("mkdir -p").Text(stubsDir.String())
466 }
467
468 srcJarList := zipSyncCmd(ctx, rule, srcJarDir, d.Javadoc.srcJars)
469
Colin Crosscb77f752021-03-24 12:04:44 -0700470 homeDir := android.PathForModuleOut(ctx, "metalava", "home")
Colin Cross2207f872021-03-24 12:39:08 -0700471 cmd := metalavaCmd(ctx, rule, javaVersion, d.Javadoc.srcFiles, srcJarList,
Colin Cross8095c292021-03-30 16:40:48 -0700472 deps.bootClasspath, deps.classpath, d.Javadoc.sourcepaths, homeDir)
Colin Cross2207f872021-03-24 12:39:08 -0700473 cmd.Implicits(d.Javadoc.implicits)
474
475 d.stubsFlags(ctx, cmd, stubsDir)
476
477 d.annotationsFlags(ctx, cmd)
478 d.inclusionAnnotationsFlags(ctx, cmd)
479 d.apiLevelsAnnotationsFlags(ctx, cmd)
480
Colin Crossbc139922021-03-25 18:33:16 -0700481 d.expandArgs(ctx, cmd)
Colin Cross2207f872021-03-24 12:39:08 -0700482
Colin Cross2207f872021-03-24 12:39:08 -0700483 for _, o := range d.Javadoc.properties.Out {
484 cmd.ImplicitOutput(android.PathForModuleGen(ctx, o))
485 }
486
487 // Add options for the other optional tasks: API-lint and check-released.
488 // We generate separate timestamp files for them.
489
490 doApiLint := false
491 doCheckReleased := false
492
493 // Add API lint options.
494
495 if BoolDefault(d.properties.Check_api.Api_lint.Enabled, false) {
496 doApiLint = true
497
498 newSince := android.OptionalPathForModuleSrc(ctx, d.properties.Check_api.Api_lint.New_since)
499 if newSince.Valid() {
500 cmd.FlagWithInput("--api-lint ", newSince.Path())
501 } else {
502 cmd.Flag("--api-lint")
503 }
Colin Crosscb77f752021-03-24 12:04:44 -0700504 d.apiLintReport = android.PathForModuleOut(ctx, "metalava", "api_lint_report.txt")
Colin Cross2207f872021-03-24 12:39:08 -0700505 cmd.FlagWithOutput("--report-even-if-suppressed ", d.apiLintReport) // TODO: Change to ":api-lint"
506
Colin Cross0d532412021-03-25 09:38:45 -0700507 // TODO(b/154317059): Clean up this allowlist by baselining and/or checking in last-released.
Colin Cross2207f872021-03-24 12:39:08 -0700508 if d.Name() != "android.car-system-stubs-docs" &&
509 d.Name() != "android.car-stubs-docs" {
510 cmd.Flag("--lints-as-errors")
511 cmd.Flag("--warnings-as-errors") // Most lints are actually warnings.
512 }
513
514 baselineFile := android.OptionalPathForModuleSrc(ctx, d.properties.Check_api.Api_lint.Baseline_file)
Colin Crosscb77f752021-03-24 12:04:44 -0700515 updatedBaselineOutput := android.PathForModuleOut(ctx, "metalava", "api_lint_baseline.txt")
516 d.apiLintTimestamp = android.PathForModuleOut(ctx, "metalava", "api_lint.timestamp")
Colin Cross2207f872021-03-24 12:39:08 -0700517
518 // Note this string includes a special shell quote $' ... ', which decodes the "\n"s.
Colin Cross2207f872021-03-24 12:39:08 -0700519 //
520 // TODO: metalava also has a slightly different message hardcoded. Should we unify this
521 // message and metalava's one?
522 msg := `$'` + // Enclose with $' ... '
523 `************************************************************\n` +
524 `Your API changes are triggering API Lint warnings or errors.\n` +
525 `To make these errors go away, fix the code according to the\n` +
526 `error and/or warning messages above.\n` +
527 `\n` +
528 `If it is not possible to do so, there are workarounds:\n` +
529 `\n` +
530 `1. You can suppress the errors with @SuppressLint("<id>")\n`
531
532 if baselineFile.Valid() {
533 cmd.FlagWithInput("--baseline:api-lint ", baselineFile.Path())
534 cmd.FlagWithOutput("--update-baseline:api-lint ", updatedBaselineOutput)
535
536 msg += fmt.Sprintf(``+
537 `2. You can update the baseline by executing the following\n`+
538 ` command:\n`+
Colin Cross63eeda02021-04-15 19:01:57 -0700539 ` (cd $ANDROID_BUILD_TOP && cp \\\n`+
540 ` "%s" \\\n`+
541 ` "%s")\n`+
Colin Cross2207f872021-03-24 12:39:08 -0700542 ` To submit the revised baseline.txt to the main Android\n`+
543 ` repository, you will need approval.\n`, updatedBaselineOutput, baselineFile.Path())
544 } else {
545 msg += fmt.Sprintf(``+
546 `2. You can add a baseline file of existing lint failures\n`+
547 ` to the build rule of %s.\n`, d.Name())
548 }
549 // Note the message ends with a ' (single quote), to close the $' ... ' .
550 msg += `************************************************************\n'`
551
552 cmd.FlagWithArg("--error-message:api-lint ", msg)
553 }
554
555 // Add "check released" options. (Detect incompatible API changes from the last public release)
556
557 if apiCheckEnabled(ctx, d.properties.Check_api.Last_released, "last_released") {
558 doCheckReleased = true
559
560 if len(d.Javadoc.properties.Out) > 0 {
561 ctx.PropertyErrorf("out", "out property may not be combined with check_api")
562 }
563
564 apiFile := android.PathForModuleSrc(ctx, String(d.properties.Check_api.Last_released.Api_file))
565 removedApiFile := android.PathForModuleSrc(ctx, String(d.properties.Check_api.Last_released.Removed_api_file))
566 baselineFile := android.OptionalPathForModuleSrc(ctx, d.properties.Check_api.Last_released.Baseline_file)
Colin Crosscb77f752021-03-24 12:04:44 -0700567 updatedBaselineOutput := android.PathForModuleOut(ctx, "metalava", "last_released_baseline.txt")
Colin Cross2207f872021-03-24 12:39:08 -0700568
Colin Crosscb77f752021-03-24 12:04:44 -0700569 d.checkLastReleasedApiTimestamp = android.PathForModuleOut(ctx, "metalava", "check_last_released_api.timestamp")
Colin Cross2207f872021-03-24 12:39:08 -0700570
571 cmd.FlagWithInput("--check-compatibility:api:released ", apiFile)
572 cmd.FlagWithInput("--check-compatibility:removed:released ", removedApiFile)
573
574 if baselineFile.Valid() {
575 cmd.FlagWithInput("--baseline:compatibility:released ", baselineFile.Path())
576 cmd.FlagWithOutput("--update-baseline:compatibility:released ", updatedBaselineOutput)
577 }
578
579 // Note this string includes quote ($' ... '), which decodes the "\n"s.
580 msg := `$'\n******************************\n` +
581 `You have tried to change the API from what has been previously released in\n` +
582 `an SDK. Please fix the errors listed above.\n` +
583 `******************************\n'`
584
585 cmd.FlagWithArg("--error-message:compatibility:released ", msg)
586 }
587
Colin Cross2207f872021-03-24 12:39:08 -0700588 if generateStubs {
589 rule.Command().
590 BuiltTool("soong_zip").
591 Flag("-write_if_changed").
592 Flag("-jar").
593 FlagWithOutput("-o ", d.Javadoc.stubsSrcJar).
594 FlagWithArg("-C ", stubsDir.String()).
595 FlagWithArg("-D ", stubsDir.String())
596 }
597
598 if Bool(d.properties.Write_sdk_values) {
Colin Crosscb77f752021-03-24 12:04:44 -0700599 d.metadataZip = android.PathForModuleOut(ctx, "metalava", ctx.ModuleName()+"-metadata.zip")
Colin Cross2207f872021-03-24 12:39:08 -0700600 rule.Command().
601 BuiltTool("soong_zip").
602 Flag("-write_if_changed").
603 Flag("-d").
604 FlagWithOutput("-o ", d.metadataZip).
605 FlagWithArg("-C ", d.metadataDir.String()).
606 FlagWithArg("-D ", d.metadataDir.String())
607 }
608
609 // TODO: We don't really need two separate API files, but this is a reminiscence of how
610 // we used to run metalava separately for API lint and the "last_released" check. Unify them.
611 if doApiLint {
612 rule.Command().Text("touch").Output(d.apiLintTimestamp)
613 }
614 if doCheckReleased {
615 rule.Command().Text("touch").Output(d.checkLastReleasedApiTimestamp)
616 }
617
Colin Cross6aa5c402021-03-24 12:28:50 -0700618 // TODO(b/183630617): rewrapper doesn't support restat rules
Colin Cross8095c292021-03-30 16:40:48 -0700619 // rule.Restat()
Colin Cross2207f872021-03-24 12:39:08 -0700620
621 zipSyncCleanupCmd(rule, srcJarDir)
622
623 rule.Build("metalava", "metalava merged")
624
625 if apiCheckEnabled(ctx, d.properties.Check_api.Current, "current") {
626
627 if len(d.Javadoc.properties.Out) > 0 {
628 ctx.PropertyErrorf("out", "out property may not be combined with check_api")
629 }
630
631 apiFile := android.PathForModuleSrc(ctx, String(d.properties.Check_api.Current.Api_file))
632 removedApiFile := android.PathForModuleSrc(ctx, String(d.properties.Check_api.Current.Removed_api_file))
633 baselineFile := android.OptionalPathForModuleSrc(ctx, d.properties.Check_api.Current.Baseline_file)
634
635 if baselineFile.Valid() {
636 ctx.PropertyErrorf("baseline_file", "current API check can't have a baseline file. (module %s)", ctx.ModuleName())
637 }
638
Colin Crosscb77f752021-03-24 12:04:44 -0700639 d.checkCurrentApiTimestamp = android.PathForModuleOut(ctx, "metalava", "check_current_api.timestamp")
Colin Cross2207f872021-03-24 12:39:08 -0700640
641 rule := android.NewRuleBuilder(pctx, ctx)
642
643 // Diff command line.
644 // -F matches the closest "opening" line, such as "package android {"
645 // and " public class Intent {".
646 diff := `diff -u -F '{ *$'`
647
648 rule.Command().Text("( true")
649 rule.Command().
650 Text(diff).
651 Input(apiFile).Input(d.apiFile)
652
653 rule.Command().
654 Text(diff).
655 Input(removedApiFile).Input(d.removedApiFile)
656
657 msg := fmt.Sprintf(`\n******************************\n`+
658 `You have tried to change the API from what has been previously approved.\n\n`+
659 `To make these errors go away, you have two choices:\n`+
660 ` 1. You can add '@hide' javadoc comments (and remove @SystemApi/@TestApi/etc)\n`+
661 ` to the new methods, etc. shown in the above diff.\n\n`+
662 ` 2. You can update current.txt and/or removed.txt by executing the following command:\n`+
663 ` m %s-update-current-api\n\n`+
664 ` To submit the revised current.txt to the main Android repository,\n`+
665 ` you will need approval.\n`+
666 `******************************\n`, ctx.ModuleName())
667
668 rule.Command().
669 Text("touch").Output(d.checkCurrentApiTimestamp).
670 Text(") || (").
671 Text("echo").Flag("-e").Flag(`"` + msg + `"`).
672 Text("; exit 38").
673 Text(")")
674
675 rule.Build("metalavaCurrentApiCheck", "check current API")
676
Colin Crosscb77f752021-03-24 12:04:44 -0700677 d.updateCurrentApiTimestamp = android.PathForModuleOut(ctx, "metalava", "update_current_api.timestamp")
Colin Cross2207f872021-03-24 12:39:08 -0700678
679 // update API rule
680 rule = android.NewRuleBuilder(pctx, ctx)
681
682 rule.Command().Text("( true")
683
684 rule.Command().
685 Text("cp").Flag("-f").
686 Input(d.apiFile).Flag(apiFile.String())
687
688 rule.Command().
689 Text("cp").Flag("-f").
690 Input(d.removedApiFile).Flag(removedApiFile.String())
691
692 msg = "failed to update public API"
693
694 rule.Command().
695 Text("touch").Output(d.updateCurrentApiTimestamp).
696 Text(") || (").
697 Text("echo").Flag("-e").Flag(`"` + msg + `"`).
698 Text("; exit 38").
699 Text(")")
700
701 rule.Build("metalavaCurrentApiUpdate", "update current API")
702 }
703
704 if String(d.properties.Check_nullability_warnings) != "" {
705 if d.nullabilityWarningsFile == nil {
706 ctx.PropertyErrorf("check_nullability_warnings",
707 "Cannot specify check_nullability_warnings unless validating nullability")
708 }
709
710 checkNullabilityWarnings := android.PathForModuleSrc(ctx, String(d.properties.Check_nullability_warnings))
711
Colin Crosscb77f752021-03-24 12:04:44 -0700712 d.checkNullabilityWarningsTimestamp = android.PathForModuleOut(ctx, "metalava", "check_nullability_warnings.timestamp")
Colin Cross2207f872021-03-24 12:39:08 -0700713
714 msg := fmt.Sprintf(`\n******************************\n`+
715 `The warnings encountered during nullability annotation validation did\n`+
716 `not match the checked in file of expected warnings. The diffs are shown\n`+
717 `above. You have two options:\n`+
718 ` 1. Resolve the differences by editing the nullability annotations.\n`+
719 ` 2. Update the file of expected warnings by running:\n`+
720 ` cp %s %s\n`+
721 ` and submitting the updated file as part of your change.`,
722 d.nullabilityWarningsFile, checkNullabilityWarnings)
723
724 rule := android.NewRuleBuilder(pctx, ctx)
725
726 rule.Command().
727 Text("(").
728 Text("diff").Input(checkNullabilityWarnings).Input(d.nullabilityWarningsFile).
729 Text("&&").
730 Text("touch").Output(d.checkNullabilityWarningsTimestamp).
731 Text(") || (").
732 Text("echo").Flag("-e").Flag(`"` + msg + `"`).
733 Text("; exit 38").
734 Text(")")
735
736 rule.Build("nullabilityWarningsCheck", "nullability warnings check")
737 }
738}
739
740func StubsDefaultsFactory() android.Module {
741 module := &DocDefaults{}
742
743 module.AddProperties(
744 &JavadocProperties{},
745 &DroidstubsProperties{},
746 )
747
748 android.InitDefaultsModule(module)
749
750 return module
751}
752
753var _ android.PrebuiltInterface = (*PrebuiltStubsSources)(nil)
754
755type PrebuiltStubsSourcesProperties struct {
756 Srcs []string `android:"path"`
757}
758
759type PrebuiltStubsSources struct {
760 android.ModuleBase
761 android.DefaultableModuleBase
762 prebuilt android.Prebuilt
763 android.SdkBase
764
765 properties PrebuiltStubsSourcesProperties
766
767 stubsSrcJar android.ModuleOutPath
768}
769
770func (p *PrebuiltStubsSources) OutputFiles(tag string) (android.Paths, error) {
771 switch tag {
772 case "":
773 return android.Paths{p.stubsSrcJar}, nil
774 default:
775 return nil, fmt.Errorf("unsupported module reference tag %q", tag)
776 }
777}
778
779func (d *PrebuiltStubsSources) StubsSrcJar() android.Path {
780 return d.stubsSrcJar
781}
782
783func (p *PrebuiltStubsSources) GenerateAndroidBuildActions(ctx android.ModuleContext) {
784 p.stubsSrcJar = android.PathForModuleOut(ctx, ctx.ModuleName()+"-"+"stubs.srcjar")
785
786 if len(p.properties.Srcs) != 1 {
787 ctx.PropertyErrorf("srcs", "must only specify one directory path, contains %d paths", len(p.properties.Srcs))
788 return
789 }
790
791 localSrcDir := p.properties.Srcs[0]
792 // Although PathForModuleSrc can return nil if either the path doesn't exist or
793 // the path components are invalid it won't in this case because no components
794 // are specified and the module directory must exist in order to get this far.
795 srcDir := android.PathForModuleSrc(ctx).(android.SourcePath).Join(ctx, localSrcDir)
796
797 // Glob the contents of the directory just in case the directory does not exist.
798 srcGlob := localSrcDir + "/**/*"
799 srcPaths := android.PathsForModuleSrc(ctx, []string{srcGlob})
800
801 rule := android.NewRuleBuilder(pctx, ctx)
802 rule.Command().
803 BuiltTool("soong_zip").
804 Flag("-write_if_changed").
805 Flag("-jar").
806 FlagWithOutput("-o ", p.stubsSrcJar).
807 FlagWithArg("-C ", srcDir.String()).
808 FlagWithRspFileInputList("-r ", p.stubsSrcJar.ReplaceExtension(ctx, "rsp"), srcPaths)
809
810 rule.Restat()
811
812 rule.Build("zip src", "Create srcjar from prebuilt source")
813}
814
815func (p *PrebuiltStubsSources) Prebuilt() *android.Prebuilt {
816 return &p.prebuilt
817}
818
819func (p *PrebuiltStubsSources) Name() string {
820 return p.prebuilt.Name(p.ModuleBase.Name())
821}
822
823// prebuilt_stubs_sources imports a set of java source files as if they were
824// generated by droidstubs.
825//
826// By default, a prebuilt_stubs_sources has a single variant that expects a
827// set of `.java` files generated by droidstubs.
828//
829// Specifying `host_supported: true` will produce two variants, one for use as a dependency of device modules and one
830// for host modules.
831//
832// Intended only for use by sdk snapshots.
833func PrebuiltStubsSourcesFactory() android.Module {
834 module := &PrebuiltStubsSources{}
835
836 module.AddProperties(&module.properties)
837
838 android.InitPrebuiltModule(module, &module.properties.Srcs)
839 android.InitSdkAwareModule(module)
840 InitDroiddocModule(module, android.HostAndDeviceSupported)
841 return module
842}