blob: 3011250f74eb7719215faa6a534bd240851add19 [file] [log] [blame]
Colin Cross2207f872021-03-24 12:39:08 -07001// Copyright 2021 Google Inc. All rights reserved.
2//
3// Licensed under the Apache License, Version 2.0 (the "License");
4// you may not use this file except in compliance with the License.
5// You may obtain a copy of the License at
6//
7// http://www.apache.org/licenses/LICENSE-2.0
8//
9// Unless required by applicable law or agreed to in writing, software
10// distributed under the License is distributed on an "AS IS" BASIS,
11// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
12// See the License for the specific language governing permissions and
13// limitations under the License.
14
15package java
16
17import (
18 "fmt"
19 "strings"
20
21 "github.com/google/blueprint/proptools"
22
23 "android/soong/android"
24 "android/soong/java/config"
25 "android/soong/remoteexec"
26)
27
28func init() {
29 RegisterStubsBuildComponents(android.InitRegistrationContext)
30}
31
32func RegisterStubsBuildComponents(ctx android.RegistrationContext) {
33 ctx.RegisterModuleType("stubs_defaults", StubsDefaultsFactory)
34
35 ctx.RegisterModuleType("droidstubs", DroidstubsFactory)
36 ctx.RegisterModuleType("droidstubs_host", DroidstubsHostFactory)
37
38 ctx.RegisterModuleType("prebuilt_stubs_sources", PrebuiltStubsSourcesFactory)
39}
40
41//
42// Droidstubs
43//
44type Droidstubs struct {
45 Javadoc
46 android.SdkBase
47
48 properties DroidstubsProperties
49 apiFile android.WritablePath
50 apiXmlFile android.WritablePath
51 lastReleasedApiXmlFile android.WritablePath
52 privateApiFile android.WritablePath
53 removedApiFile android.WritablePath
54 removedDexApiFile android.WritablePath
55 nullabilityWarningsFile android.WritablePath
56
57 checkCurrentApiTimestamp android.WritablePath
58 updateCurrentApiTimestamp android.WritablePath
59 checkLastReleasedApiTimestamp android.WritablePath
60 apiLintTimestamp android.WritablePath
61 apiLintReport android.WritablePath
62
63 checkNullabilityWarningsTimestamp android.WritablePath
64
65 annotationsZip android.WritablePath
66 apiVersionsXml android.WritablePath
67
68 apiFilePath android.Path
69 removedApiFilePath android.Path
70
71 metadataZip android.WritablePath
72 metadataDir android.WritablePath
73}
74
75type DroidstubsProperties struct {
76 // The generated public API filename by Metalava, defaults to <module>_api.txt
77 Api_filename *string
78
79 // the generated removed API filename by Metalava, defaults to <module>_removed.txt
80 Removed_api_filename *string
81
82 // the generated removed Dex API filename by Metalava.
83 Removed_dex_api_filename *string
84
85 Check_api struct {
86 Last_released ApiToCheck
87
88 Current ApiToCheck
89
90 Api_lint struct {
91 Enabled *bool
92
93 // If set, performs api_lint on any new APIs not found in the given signature file
94 New_since *string `android:"path"`
95
96 // If not blank, path to the baseline txt file for approved API lint violations.
97 Baseline_file *string `android:"path"`
98 }
99 }
100
101 // user can specify the version of previous released API file in order to do compatibility check.
102 Previous_api *string `android:"path"`
103
104 // is set to true, Metalava will allow framework SDK to contain annotations.
105 Annotations_enabled *bool
106
107 // a list of top-level directories containing files to merge qualifier annotations (i.e. those intended to be included in the stubs written) from.
108 Merge_annotations_dirs []string
109
110 // a list of top-level directories containing Java stub files to merge show/hide annotations from.
111 Merge_inclusion_annotations_dirs []string
112
113 // a file containing a list of classes to do nullability validation for.
114 Validate_nullability_from_list *string
115
116 // a file containing expected warnings produced by validation of nullability annotations.
117 Check_nullability_warnings *string
118
119 // if set to true, allow Metalava to generate doc_stubs source files. Defaults to false.
120 Create_doc_stubs *bool
121
122 // if set to true, cause Metalava to output Javadoc comments in the stubs source files. Defaults to false.
123 // Has no effect if create_doc_stubs: true.
124 Output_javadoc_comments *bool
125
126 // if set to false then do not write out stubs. Defaults to true.
127 //
128 // TODO(b/146727827): Remove capability when we do not need to generate stubs and API separately.
129 Generate_stubs *bool
130
131 // if set to true, provides a hint to the build system that this rule uses a lot of memory,
132 // whicih can be used for scheduling purposes
133 High_mem *bool
134
135 // is set to true, Metalava will allow framework SDK to contain API levels annotations.
136 Api_levels_annotations_enabled *bool
137
138 // the dirs which Metalava extracts API levels annotations from.
139 Api_levels_annotations_dirs []string
140
141 // the filename which Metalava extracts API levels annotations from. Defaults to android.jar.
142 Api_levels_jar_filename *string
143
144 // if set to true, collect the values used by the Dev tools and
145 // write them in files packaged with the SDK. Defaults to false.
146 Write_sdk_values *bool
147}
148
Anton Hansson52609322021-05-05 10:36:05 +0100149// Used by xsd_config
150type ApiFilePath interface {
151 ApiFilePath() android.Path
152}
153
154type ApiStubsSrcProvider interface {
155 StubsSrcJar() android.Path
156}
157
158// Provider of information about API stubs, used by java_sdk_library.
159type ApiStubsProvider interface {
160 ApiFilePath
161 RemovedApiFilePath() android.Path
162
163 ApiStubsSrcProvider
164}
165
Colin Cross2207f872021-03-24 12:39:08 -0700166// droidstubs passes sources files through Metalava to generate stub .java files that only contain the API to be
167// documented, filtering out hidden classes and methods. The resulting .java files are intended to be passed to
168// a droiddoc module to generate documentation.
169func DroidstubsFactory() android.Module {
170 module := &Droidstubs{}
171
172 module.AddProperties(&module.properties,
173 &module.Javadoc.properties)
174
175 InitDroiddocModule(module, android.HostAndDeviceSupported)
176 android.InitSdkAwareModule(module)
177 return module
178}
179
180// droidstubs_host passes sources files through Metalava to generate stub .java files that only contain the API
181// to be documented, filtering out hidden classes and methods. The resulting .java files are intended to be
182// passed to a droiddoc_host module to generate documentation. Use a droidstubs_host instead of a droidstubs
183// module when symbols needed by the source files are provided by java_library_host modules.
184func DroidstubsHostFactory() android.Module {
185 module := &Droidstubs{}
186
187 module.AddProperties(&module.properties,
188 &module.Javadoc.properties)
189
190 InitDroiddocModule(module, android.HostSupported)
191 return module
192}
193
194func (d *Droidstubs) OutputFiles(tag string) (android.Paths, error) {
195 switch tag {
196 case "":
197 return android.Paths{d.stubsSrcJar}, nil
198 case ".docs.zip":
199 return android.Paths{d.docZip}, nil
200 case ".api.txt", android.DefaultDistTag:
201 // This is the default dist path for dist properties that have no tag property.
202 return android.Paths{d.apiFilePath}, nil
203 case ".removed-api.txt":
204 return android.Paths{d.removedApiFilePath}, nil
205 case ".annotations.zip":
206 return android.Paths{d.annotationsZip}, nil
207 case ".api_versions.xml":
208 return android.Paths{d.apiVersionsXml}, nil
209 default:
210 return nil, fmt.Errorf("unsupported module reference tag %q", tag)
211 }
212}
213
214func (d *Droidstubs) ApiFilePath() android.Path {
215 return d.apiFilePath
216}
217
218func (d *Droidstubs) RemovedApiFilePath() android.Path {
219 return d.removedApiFilePath
220}
221
222func (d *Droidstubs) StubsSrcJar() android.Path {
223 return d.stubsSrcJar
224}
225
226var metalavaMergeAnnotationsDirTag = dependencyTag{name: "metalava-merge-annotations-dir"}
227var metalavaMergeInclusionAnnotationsDirTag = dependencyTag{name: "metalava-merge-inclusion-annotations-dir"}
228var metalavaAPILevelsAnnotationsDirTag = dependencyTag{name: "metalava-api-levels-annotations-dir"}
229
230func (d *Droidstubs) DepsMutator(ctx android.BottomUpMutatorContext) {
231 d.Javadoc.addDeps(ctx)
232
233 if len(d.properties.Merge_annotations_dirs) != 0 {
234 for _, mergeAnnotationsDir := range d.properties.Merge_annotations_dirs {
235 ctx.AddDependency(ctx.Module(), metalavaMergeAnnotationsDirTag, mergeAnnotationsDir)
236 }
237 }
238
239 if len(d.properties.Merge_inclusion_annotations_dirs) != 0 {
240 for _, mergeInclusionAnnotationsDir := range d.properties.Merge_inclusion_annotations_dirs {
241 ctx.AddDependency(ctx.Module(), metalavaMergeInclusionAnnotationsDirTag, mergeInclusionAnnotationsDir)
242 }
243 }
244
245 if len(d.properties.Api_levels_annotations_dirs) != 0 {
246 for _, apiLevelsAnnotationsDir := range d.properties.Api_levels_annotations_dirs {
247 ctx.AddDependency(ctx.Module(), metalavaAPILevelsAnnotationsDirTag, apiLevelsAnnotationsDir)
248 }
249 }
250}
251
252func (d *Droidstubs) stubsFlags(ctx android.ModuleContext, cmd *android.RuleBuilderCommand, stubsDir android.OptionalPath) {
253 if apiCheckEnabled(ctx, d.properties.Check_api.Current, "current") ||
254 apiCheckEnabled(ctx, d.properties.Check_api.Last_released, "last_released") ||
255 String(d.properties.Api_filename) != "" {
256 filename := proptools.StringDefault(d.properties.Api_filename, ctx.ModuleName()+"_api.txt")
Colin Crosscb77f752021-03-24 12:04:44 -0700257 d.apiFile = android.PathForModuleOut(ctx, "metalava", filename)
Colin Cross2207f872021-03-24 12:39:08 -0700258 cmd.FlagWithOutput("--api ", d.apiFile)
259 d.apiFilePath = d.apiFile
260 } else if sourceApiFile := proptools.String(d.properties.Check_api.Current.Api_file); sourceApiFile != "" {
261 // If check api is disabled then make the source file available for export.
262 d.apiFilePath = android.PathForModuleSrc(ctx, sourceApiFile)
263 }
264
265 if apiCheckEnabled(ctx, d.properties.Check_api.Current, "current") ||
266 apiCheckEnabled(ctx, d.properties.Check_api.Last_released, "last_released") ||
267 String(d.properties.Removed_api_filename) != "" {
268 filename := proptools.StringDefault(d.properties.Removed_api_filename, ctx.ModuleName()+"_removed.txt")
Colin Crosscb77f752021-03-24 12:04:44 -0700269 d.removedApiFile = android.PathForModuleOut(ctx, "metalava", filename)
Colin Cross2207f872021-03-24 12:39:08 -0700270 cmd.FlagWithOutput("--removed-api ", d.removedApiFile)
271 d.removedApiFilePath = d.removedApiFile
272 } else if sourceRemovedApiFile := proptools.String(d.properties.Check_api.Current.Removed_api_file); sourceRemovedApiFile != "" {
273 // If check api is disabled then make the source removed api file available for export.
274 d.removedApiFilePath = android.PathForModuleSrc(ctx, sourceRemovedApiFile)
275 }
276
277 if String(d.properties.Removed_dex_api_filename) != "" {
Colin Crosscb77f752021-03-24 12:04:44 -0700278 d.removedDexApiFile = android.PathForModuleOut(ctx, "metalava", String(d.properties.Removed_dex_api_filename))
Colin Cross2207f872021-03-24 12:39:08 -0700279 cmd.FlagWithOutput("--removed-dex-api ", d.removedDexApiFile)
280 }
281
282 if Bool(d.properties.Write_sdk_values) {
Colin Crosscb77f752021-03-24 12:04:44 -0700283 d.metadataDir = android.PathForModuleOut(ctx, "metalava", "metadata")
Colin Cross2207f872021-03-24 12:39:08 -0700284 cmd.FlagWithArg("--sdk-values ", d.metadataDir.String())
285 }
286
287 if stubsDir.Valid() {
288 if Bool(d.properties.Create_doc_stubs) {
289 cmd.FlagWithArg("--doc-stubs ", stubsDir.String())
290 } else {
291 cmd.FlagWithArg("--stubs ", stubsDir.String())
292 if !Bool(d.properties.Output_javadoc_comments) {
293 cmd.Flag("--exclude-documentation-from-stubs")
294 }
295 }
296 }
297}
298
299func (d *Droidstubs) annotationsFlags(ctx android.ModuleContext, cmd *android.RuleBuilderCommand) {
300 if Bool(d.properties.Annotations_enabled) {
301 cmd.Flag("--include-annotations")
302
303 validatingNullability :=
Colin Crossbc139922021-03-25 18:33:16 -0700304 strings.Contains(String(d.Javadoc.properties.Args), "--validate-nullability-from-merged-stubs") ||
Colin Cross2207f872021-03-24 12:39:08 -0700305 String(d.properties.Validate_nullability_from_list) != ""
306
307 migratingNullability := String(d.properties.Previous_api) != ""
308 if migratingNullability {
309 previousApi := android.PathForModuleSrc(ctx, String(d.properties.Previous_api))
310 cmd.FlagWithInput("--migrate-nullness ", previousApi)
311 }
312
313 if s := String(d.properties.Validate_nullability_from_list); s != "" {
314 cmd.FlagWithInput("--validate-nullability-from-list ", android.PathForModuleSrc(ctx, s))
315 }
316
317 if validatingNullability {
Colin Crosscb77f752021-03-24 12:04:44 -0700318 d.nullabilityWarningsFile = android.PathForModuleOut(ctx, "metalava", ctx.ModuleName()+"_nullability_warnings.txt")
Colin Cross2207f872021-03-24 12:39:08 -0700319 cmd.FlagWithOutput("--nullability-warnings-txt ", d.nullabilityWarningsFile)
320 }
321
Colin Crosscb77f752021-03-24 12:04:44 -0700322 d.annotationsZip = android.PathForModuleOut(ctx, "metalava", ctx.ModuleName()+"_annotations.zip")
Colin Cross2207f872021-03-24 12:39:08 -0700323 cmd.FlagWithOutput("--extract-annotations ", d.annotationsZip)
324
325 if len(d.properties.Merge_annotations_dirs) != 0 {
326 d.mergeAnnoDirFlags(ctx, cmd)
327 }
328
329 // TODO(tnorbye): find owners to fix these warnings when annotation was enabled.
330 cmd.FlagWithArg("--hide ", "HiddenTypedefConstant").
331 FlagWithArg("--hide ", "SuperfluousPrefix").
332 FlagWithArg("--hide ", "AnnotationExtraction")
333 }
334}
335
336func (d *Droidstubs) mergeAnnoDirFlags(ctx android.ModuleContext, cmd *android.RuleBuilderCommand) {
337 ctx.VisitDirectDepsWithTag(metalavaMergeAnnotationsDirTag, func(m android.Module) {
338 if t, ok := m.(*ExportedDroiddocDir); ok {
339 cmd.FlagWithArg("--merge-qualifier-annotations ", t.dir.String()).Implicits(t.deps)
340 } else {
341 ctx.PropertyErrorf("merge_annotations_dirs",
342 "module %q is not a metalava merge-annotations dir", ctx.OtherModuleName(m))
343 }
344 })
345}
346
347func (d *Droidstubs) inclusionAnnotationsFlags(ctx android.ModuleContext, cmd *android.RuleBuilderCommand) {
348 ctx.VisitDirectDepsWithTag(metalavaMergeInclusionAnnotationsDirTag, func(m android.Module) {
349 if t, ok := m.(*ExportedDroiddocDir); ok {
350 cmd.FlagWithArg("--merge-inclusion-annotations ", t.dir.String()).Implicits(t.deps)
351 } else {
352 ctx.PropertyErrorf("merge_inclusion_annotations_dirs",
353 "module %q is not a metalava merge-annotations dir", ctx.OtherModuleName(m))
354 }
355 })
356}
357
358func (d *Droidstubs) apiLevelsAnnotationsFlags(ctx android.ModuleContext, cmd *android.RuleBuilderCommand) {
359 if !Bool(d.properties.Api_levels_annotations_enabled) {
360 return
361 }
362
Colin Crosscb77f752021-03-24 12:04:44 -0700363 d.apiVersionsXml = android.PathForModuleOut(ctx, "metalava", "api-versions.xml")
Colin Cross2207f872021-03-24 12:39:08 -0700364
365 if len(d.properties.Api_levels_annotations_dirs) == 0 {
366 ctx.PropertyErrorf("api_levels_annotations_dirs",
367 "has to be non-empty if api levels annotations was enabled!")
368 }
369
370 cmd.FlagWithOutput("--generate-api-levels ", d.apiVersionsXml)
371 cmd.FlagWithInput("--apply-api-levels ", d.apiVersionsXml)
372 cmd.FlagWithArg("--current-version ", ctx.Config().PlatformSdkVersion().String())
373 cmd.FlagWithArg("--current-codename ", ctx.Config().PlatformSdkCodename())
374
375 filename := proptools.StringDefault(d.properties.Api_levels_jar_filename, "android.jar")
376
377 ctx.VisitDirectDepsWithTag(metalavaAPILevelsAnnotationsDirTag, func(m android.Module) {
378 if t, ok := m.(*ExportedDroiddocDir); ok {
379 for _, dep := range t.deps {
Colin Cross5f6ffc72021-03-29 21:54:45 -0700380 if dep.Base() == filename {
381 cmd.Implicit(dep)
382 }
383 if filename != "android.jar" && dep.Base() == "android.jar" {
384 // Metalava implicitly searches these patterns:
385 // prebuilts/tools/common/api-versions/android-%/android.jar
386 // prebuilts/sdk/%/public/android.jar
387 // Add android.jar files from the api_levels_annotations_dirs directories to try
388 // to satisfy these patterns. If Metalava can't find a match for an API level
389 // between 1 and 28 in at least one pattern it will fail.
Colin Cross2207f872021-03-24 12:39:08 -0700390 cmd.Implicit(dep)
391 }
392 }
393 cmd.FlagWithArg("--android-jar-pattern ", t.dir.String()+"/%/public/"+filename)
394 } else {
395 ctx.PropertyErrorf("api_levels_annotations_dirs",
396 "module %q is not a metalava api-levels-annotations dir", ctx.OtherModuleName(m))
397 }
398 })
399}
400
401func metalavaCmd(ctx android.ModuleContext, rule *android.RuleBuilder, javaVersion javaVersion, srcs android.Paths,
402 srcJarList android.Path, bootclasspath, classpath classpath, sourcepaths android.Paths,
Colin Cross8095c292021-03-30 16:40:48 -0700403 homeDir android.WritablePath) *android.RuleBuilderCommand {
Colin Cross2207f872021-03-24 12:39:08 -0700404 rule.Command().Text("rm -rf").Flag(homeDir.String())
405 rule.Command().Text("mkdir -p").Flag(homeDir.String())
406
407 cmd := rule.Command()
408 cmd.FlagWithArg("ANDROID_PREFS_ROOT=", homeDir.String())
409
410 if ctx.Config().UseRBE() && ctx.Config().IsEnvTrue("RBE_METALAVA") {
411 rule.Remoteable(android.RemoteRuleSupports{RBE: true})
Colin Cross8095c292021-03-30 16:40:48 -0700412 execStrategy := ctx.Config().GetenvWithDefault("RBE_METALAVA_EXEC_STRATEGY", remoteexec.LocalExecStrategy)
413 labels := map[string]string{"type": "tool", "name": "metalava"}
414 // TODO: metalava pool rejects these jobs
415 pool := ctx.Config().GetenvWithDefault("RBE_METALAVA_POOL", "java16")
416 rule.Rewrapper(&remoteexec.REParams{
417 Labels: labels,
418 ExecStrategy: execStrategy,
419 ToolchainInputs: []string{config.JavaCmd(ctx).String()},
420 Platform: map[string]string{remoteexec.PoolKey: pool},
421 })
Colin Cross2207f872021-03-24 12:39:08 -0700422 }
423
Colin Cross6aa5c402021-03-24 12:28:50 -0700424 cmd.BuiltTool("metalava").ImplicitTool(ctx.Config().HostJavaToolPath(ctx, "metalava.jar")).
Colin Cross2207f872021-03-24 12:39:08 -0700425 Flag(config.JavacVmFlags).
426 Flag("-J--add-opens=java.base/java.util=ALL-UNNAMED").
427 FlagWithArg("-encoding ", "UTF-8").
428 FlagWithArg("-source ", javaVersion.String()).
429 FlagWithRspFileInputList("@", android.PathForModuleOut(ctx, "metalava.rsp"), srcs).
430 FlagWithInput("@", srcJarList)
431
Colin Cross2207f872021-03-24 12:39:08 -0700432 if len(bootclasspath) > 0 {
433 cmd.FlagWithInputList("-bootclasspath ", bootclasspath.Paths(), ":")
434 }
435
436 if len(classpath) > 0 {
437 cmd.FlagWithInputList("-classpath ", classpath.Paths(), ":")
438 }
439
440 if len(sourcepaths) > 0 {
441 cmd.FlagWithList("-sourcepath ", sourcepaths.Strings(), ":")
442 } else {
443 cmd.FlagWithArg("-sourcepath ", `""`)
444 }
445
446 cmd.Flag("--no-banner").
447 Flag("--color").
448 Flag("--quiet").
449 Flag("--format=v2").
450 FlagWithArg("--repeat-errors-max ", "10").
451 FlagWithArg("--hide ", "UnresolvedImport")
452
453 return cmd
454}
455
456func (d *Droidstubs) GenerateAndroidBuildActions(ctx android.ModuleContext) {
457 deps := d.Javadoc.collectDeps(ctx)
458
Jiyong Parkf1691d22021-03-29 20:11:58 +0900459 javaVersion := getJavaVersion(ctx, String(d.Javadoc.properties.Java_version), android.SdkContext(d))
Colin Cross2207f872021-03-24 12:39:08 -0700460
461 // Create rule for metalava
462
Colin Crosscb77f752021-03-24 12:04:44 -0700463 srcJarDir := android.PathForModuleOut(ctx, "metalava", "srcjars")
Colin Cross2207f872021-03-24 12:39:08 -0700464
465 rule := android.NewRuleBuilder(pctx, ctx)
466
Colin Cross8095c292021-03-30 16:40:48 -0700467 rule.Sbox(android.PathForModuleOut(ctx, "metalava"),
468 android.PathForModuleOut(ctx, "metalava.sbox.textproto")).
469 SandboxInputs()
Colin Cross6aa5c402021-03-24 12:28:50 -0700470
Colin Cross2207f872021-03-24 12:39:08 -0700471 if BoolDefault(d.properties.High_mem, false) {
472 // This metalava run uses lots of memory, restrict the number of metalava jobs that can run in parallel.
473 rule.HighMem()
474 }
475
476 generateStubs := BoolDefault(d.properties.Generate_stubs, true)
477 var stubsDir android.OptionalPath
478 if generateStubs {
Colin Crosscb77f752021-03-24 12:04:44 -0700479 d.Javadoc.stubsSrcJar = android.PathForModuleOut(ctx, "metalava", ctx.ModuleName()+"-"+"stubs.srcjar")
480 stubsDir = android.OptionalPathForPath(android.PathForModuleOut(ctx, "metalava", "stubsDir"))
Colin Cross2207f872021-03-24 12:39:08 -0700481 rule.Command().Text("rm -rf").Text(stubsDir.String())
482 rule.Command().Text("mkdir -p").Text(stubsDir.String())
483 }
484
485 srcJarList := zipSyncCmd(ctx, rule, srcJarDir, d.Javadoc.srcJars)
486
Colin Crosscb77f752021-03-24 12:04:44 -0700487 homeDir := android.PathForModuleOut(ctx, "metalava", "home")
Colin Cross2207f872021-03-24 12:39:08 -0700488 cmd := metalavaCmd(ctx, rule, javaVersion, d.Javadoc.srcFiles, srcJarList,
Colin Cross8095c292021-03-30 16:40:48 -0700489 deps.bootClasspath, deps.classpath, d.Javadoc.sourcepaths, homeDir)
Colin Cross2207f872021-03-24 12:39:08 -0700490 cmd.Implicits(d.Javadoc.implicits)
491
492 d.stubsFlags(ctx, cmd, stubsDir)
493
494 d.annotationsFlags(ctx, cmd)
495 d.inclusionAnnotationsFlags(ctx, cmd)
496 d.apiLevelsAnnotationsFlags(ctx, cmd)
497
Colin Crossbc139922021-03-25 18:33:16 -0700498 d.expandArgs(ctx, cmd)
Colin Cross2207f872021-03-24 12:39:08 -0700499
Colin Cross2207f872021-03-24 12:39:08 -0700500 for _, o := range d.Javadoc.properties.Out {
501 cmd.ImplicitOutput(android.PathForModuleGen(ctx, o))
502 }
503
504 // Add options for the other optional tasks: API-lint and check-released.
505 // We generate separate timestamp files for them.
506
507 doApiLint := false
508 doCheckReleased := false
509
510 // Add API lint options.
511
512 if BoolDefault(d.properties.Check_api.Api_lint.Enabled, false) {
513 doApiLint = true
514
515 newSince := android.OptionalPathForModuleSrc(ctx, d.properties.Check_api.Api_lint.New_since)
516 if newSince.Valid() {
517 cmd.FlagWithInput("--api-lint ", newSince.Path())
518 } else {
519 cmd.Flag("--api-lint")
520 }
Colin Crosscb77f752021-03-24 12:04:44 -0700521 d.apiLintReport = android.PathForModuleOut(ctx, "metalava", "api_lint_report.txt")
Colin Cross2207f872021-03-24 12:39:08 -0700522 cmd.FlagWithOutput("--report-even-if-suppressed ", d.apiLintReport) // TODO: Change to ":api-lint"
523
Colin Cross0d532412021-03-25 09:38:45 -0700524 // TODO(b/154317059): Clean up this allowlist by baselining and/or checking in last-released.
Colin Cross2207f872021-03-24 12:39:08 -0700525 if d.Name() != "android.car-system-stubs-docs" &&
526 d.Name() != "android.car-stubs-docs" {
527 cmd.Flag("--lints-as-errors")
528 cmd.Flag("--warnings-as-errors") // Most lints are actually warnings.
529 }
530
531 baselineFile := android.OptionalPathForModuleSrc(ctx, d.properties.Check_api.Api_lint.Baseline_file)
Colin Crosscb77f752021-03-24 12:04:44 -0700532 updatedBaselineOutput := android.PathForModuleOut(ctx, "metalava", "api_lint_baseline.txt")
533 d.apiLintTimestamp = android.PathForModuleOut(ctx, "metalava", "api_lint.timestamp")
Colin Cross2207f872021-03-24 12:39:08 -0700534
535 // Note this string includes a special shell quote $' ... ', which decodes the "\n"s.
Colin Cross2207f872021-03-24 12:39:08 -0700536 //
537 // TODO: metalava also has a slightly different message hardcoded. Should we unify this
538 // message and metalava's one?
539 msg := `$'` + // Enclose with $' ... '
540 `************************************************************\n` +
541 `Your API changes are triggering API Lint warnings or errors.\n` +
542 `To make these errors go away, fix the code according to the\n` +
543 `error and/or warning messages above.\n` +
544 `\n` +
545 `If it is not possible to do so, there are workarounds:\n` +
546 `\n` +
547 `1. You can suppress the errors with @SuppressLint("<id>")\n`
548
549 if baselineFile.Valid() {
550 cmd.FlagWithInput("--baseline:api-lint ", baselineFile.Path())
551 cmd.FlagWithOutput("--update-baseline:api-lint ", updatedBaselineOutput)
552
553 msg += fmt.Sprintf(``+
554 `2. You can update the baseline by executing the following\n`+
555 ` command:\n`+
Colin Cross63eeda02021-04-15 19:01:57 -0700556 ` (cd $ANDROID_BUILD_TOP && cp \\\n`+
557 ` "%s" \\\n`+
558 ` "%s")\n`+
Colin Cross2207f872021-03-24 12:39:08 -0700559 ` To submit the revised baseline.txt to the main Android\n`+
560 ` repository, you will need approval.\n`, updatedBaselineOutput, baselineFile.Path())
561 } else {
562 msg += fmt.Sprintf(``+
563 `2. You can add a baseline file of existing lint failures\n`+
564 ` to the build rule of %s.\n`, d.Name())
565 }
566 // Note the message ends with a ' (single quote), to close the $' ... ' .
567 msg += `************************************************************\n'`
568
569 cmd.FlagWithArg("--error-message:api-lint ", msg)
570 }
571
572 // Add "check released" options. (Detect incompatible API changes from the last public release)
573
574 if apiCheckEnabled(ctx, d.properties.Check_api.Last_released, "last_released") {
575 doCheckReleased = true
576
577 if len(d.Javadoc.properties.Out) > 0 {
578 ctx.PropertyErrorf("out", "out property may not be combined with check_api")
579 }
580
581 apiFile := android.PathForModuleSrc(ctx, String(d.properties.Check_api.Last_released.Api_file))
582 removedApiFile := android.PathForModuleSrc(ctx, String(d.properties.Check_api.Last_released.Removed_api_file))
583 baselineFile := android.OptionalPathForModuleSrc(ctx, d.properties.Check_api.Last_released.Baseline_file)
Colin Crosscb77f752021-03-24 12:04:44 -0700584 updatedBaselineOutput := android.PathForModuleOut(ctx, "metalava", "last_released_baseline.txt")
Colin Cross2207f872021-03-24 12:39:08 -0700585
Colin Crosscb77f752021-03-24 12:04:44 -0700586 d.checkLastReleasedApiTimestamp = android.PathForModuleOut(ctx, "metalava", "check_last_released_api.timestamp")
Colin Cross2207f872021-03-24 12:39:08 -0700587
588 cmd.FlagWithInput("--check-compatibility:api:released ", apiFile)
589 cmd.FlagWithInput("--check-compatibility:removed:released ", removedApiFile)
590
591 if baselineFile.Valid() {
592 cmd.FlagWithInput("--baseline:compatibility:released ", baselineFile.Path())
593 cmd.FlagWithOutput("--update-baseline:compatibility:released ", updatedBaselineOutput)
594 }
595
596 // Note this string includes quote ($' ... '), which decodes the "\n"s.
597 msg := `$'\n******************************\n` +
598 `You have tried to change the API from what has been previously released in\n` +
599 `an SDK. Please fix the errors listed above.\n` +
600 `******************************\n'`
601
602 cmd.FlagWithArg("--error-message:compatibility:released ", msg)
603 }
604
Colin Cross2207f872021-03-24 12:39:08 -0700605 if generateStubs {
606 rule.Command().
607 BuiltTool("soong_zip").
608 Flag("-write_if_changed").
609 Flag("-jar").
610 FlagWithOutput("-o ", d.Javadoc.stubsSrcJar).
611 FlagWithArg("-C ", stubsDir.String()).
612 FlagWithArg("-D ", stubsDir.String())
613 }
614
615 if Bool(d.properties.Write_sdk_values) {
Colin Crosscb77f752021-03-24 12:04:44 -0700616 d.metadataZip = android.PathForModuleOut(ctx, "metalava", ctx.ModuleName()+"-metadata.zip")
Colin Cross2207f872021-03-24 12:39:08 -0700617 rule.Command().
618 BuiltTool("soong_zip").
619 Flag("-write_if_changed").
620 Flag("-d").
621 FlagWithOutput("-o ", d.metadataZip).
622 FlagWithArg("-C ", d.metadataDir.String()).
623 FlagWithArg("-D ", d.metadataDir.String())
624 }
625
626 // TODO: We don't really need two separate API files, but this is a reminiscence of how
627 // we used to run metalava separately for API lint and the "last_released" check. Unify them.
628 if doApiLint {
629 rule.Command().Text("touch").Output(d.apiLintTimestamp)
630 }
631 if doCheckReleased {
632 rule.Command().Text("touch").Output(d.checkLastReleasedApiTimestamp)
633 }
634
Colin Cross6aa5c402021-03-24 12:28:50 -0700635 // TODO(b/183630617): rewrapper doesn't support restat rules
Colin Cross8095c292021-03-30 16:40:48 -0700636 // rule.Restat()
Colin Cross2207f872021-03-24 12:39:08 -0700637
638 zipSyncCleanupCmd(rule, srcJarDir)
639
640 rule.Build("metalava", "metalava merged")
641
642 if apiCheckEnabled(ctx, d.properties.Check_api.Current, "current") {
643
644 if len(d.Javadoc.properties.Out) > 0 {
645 ctx.PropertyErrorf("out", "out property may not be combined with check_api")
646 }
647
648 apiFile := android.PathForModuleSrc(ctx, String(d.properties.Check_api.Current.Api_file))
649 removedApiFile := android.PathForModuleSrc(ctx, String(d.properties.Check_api.Current.Removed_api_file))
650 baselineFile := android.OptionalPathForModuleSrc(ctx, d.properties.Check_api.Current.Baseline_file)
651
652 if baselineFile.Valid() {
653 ctx.PropertyErrorf("baseline_file", "current API check can't have a baseline file. (module %s)", ctx.ModuleName())
654 }
655
Colin Crosscb77f752021-03-24 12:04:44 -0700656 d.checkCurrentApiTimestamp = android.PathForModuleOut(ctx, "metalava", "check_current_api.timestamp")
Colin Cross2207f872021-03-24 12:39:08 -0700657
658 rule := android.NewRuleBuilder(pctx, ctx)
659
660 // Diff command line.
661 // -F matches the closest "opening" line, such as "package android {"
662 // and " public class Intent {".
663 diff := `diff -u -F '{ *$'`
664
665 rule.Command().Text("( true")
666 rule.Command().
667 Text(diff).
668 Input(apiFile).Input(d.apiFile)
669
670 rule.Command().
671 Text(diff).
672 Input(removedApiFile).Input(d.removedApiFile)
673
674 msg := fmt.Sprintf(`\n******************************\n`+
675 `You have tried to change the API from what has been previously approved.\n\n`+
676 `To make these errors go away, you have two choices:\n`+
677 ` 1. You can add '@hide' javadoc comments (and remove @SystemApi/@TestApi/etc)\n`+
678 ` to the new methods, etc. shown in the above diff.\n\n`+
679 ` 2. You can update current.txt and/or removed.txt by executing the following command:\n`+
680 ` m %s-update-current-api\n\n`+
681 ` To submit the revised current.txt to the main Android repository,\n`+
682 ` you will need approval.\n`+
683 `******************************\n`, ctx.ModuleName())
684
685 rule.Command().
686 Text("touch").Output(d.checkCurrentApiTimestamp).
687 Text(") || (").
688 Text("echo").Flag("-e").Flag(`"` + msg + `"`).
689 Text("; exit 38").
690 Text(")")
691
692 rule.Build("metalavaCurrentApiCheck", "check current API")
693
Colin Crosscb77f752021-03-24 12:04:44 -0700694 d.updateCurrentApiTimestamp = android.PathForModuleOut(ctx, "metalava", "update_current_api.timestamp")
Colin Cross2207f872021-03-24 12:39:08 -0700695
696 // update API rule
697 rule = android.NewRuleBuilder(pctx, ctx)
698
699 rule.Command().Text("( true")
700
701 rule.Command().
702 Text("cp").Flag("-f").
703 Input(d.apiFile).Flag(apiFile.String())
704
705 rule.Command().
706 Text("cp").Flag("-f").
707 Input(d.removedApiFile).Flag(removedApiFile.String())
708
709 msg = "failed to update public API"
710
711 rule.Command().
712 Text("touch").Output(d.updateCurrentApiTimestamp).
713 Text(") || (").
714 Text("echo").Flag("-e").Flag(`"` + msg + `"`).
715 Text("; exit 38").
716 Text(")")
717
718 rule.Build("metalavaCurrentApiUpdate", "update current API")
719 }
720
721 if String(d.properties.Check_nullability_warnings) != "" {
722 if d.nullabilityWarningsFile == nil {
723 ctx.PropertyErrorf("check_nullability_warnings",
724 "Cannot specify check_nullability_warnings unless validating nullability")
725 }
726
727 checkNullabilityWarnings := android.PathForModuleSrc(ctx, String(d.properties.Check_nullability_warnings))
728
Colin Crosscb77f752021-03-24 12:04:44 -0700729 d.checkNullabilityWarningsTimestamp = android.PathForModuleOut(ctx, "metalava", "check_nullability_warnings.timestamp")
Colin Cross2207f872021-03-24 12:39:08 -0700730
731 msg := fmt.Sprintf(`\n******************************\n`+
732 `The warnings encountered during nullability annotation validation did\n`+
733 `not match the checked in file of expected warnings. The diffs are shown\n`+
734 `above. You have two options:\n`+
735 ` 1. Resolve the differences by editing the nullability annotations.\n`+
736 ` 2. Update the file of expected warnings by running:\n`+
737 ` cp %s %s\n`+
738 ` and submitting the updated file as part of your change.`,
739 d.nullabilityWarningsFile, checkNullabilityWarnings)
740
741 rule := android.NewRuleBuilder(pctx, ctx)
742
743 rule.Command().
744 Text("(").
745 Text("diff").Input(checkNullabilityWarnings).Input(d.nullabilityWarningsFile).
746 Text("&&").
747 Text("touch").Output(d.checkNullabilityWarningsTimestamp).
748 Text(") || (").
749 Text("echo").Flag("-e").Flag(`"` + msg + `"`).
750 Text("; exit 38").
751 Text(")")
752
753 rule.Build("nullabilityWarningsCheck", "nullability warnings check")
754 }
755}
756
757func StubsDefaultsFactory() android.Module {
758 module := &DocDefaults{}
759
760 module.AddProperties(
761 &JavadocProperties{},
762 &DroidstubsProperties{},
763 )
764
765 android.InitDefaultsModule(module)
766
767 return module
768}
769
770var _ android.PrebuiltInterface = (*PrebuiltStubsSources)(nil)
771
772type PrebuiltStubsSourcesProperties struct {
773 Srcs []string `android:"path"`
774}
775
776type PrebuiltStubsSources struct {
777 android.ModuleBase
778 android.DefaultableModuleBase
779 prebuilt android.Prebuilt
780 android.SdkBase
781
782 properties PrebuiltStubsSourcesProperties
783
784 stubsSrcJar android.ModuleOutPath
785}
786
787func (p *PrebuiltStubsSources) OutputFiles(tag string) (android.Paths, error) {
788 switch tag {
789 case "":
790 return android.Paths{p.stubsSrcJar}, nil
791 default:
792 return nil, fmt.Errorf("unsupported module reference tag %q", tag)
793 }
794}
795
796func (d *PrebuiltStubsSources) StubsSrcJar() android.Path {
797 return d.stubsSrcJar
798}
799
800func (p *PrebuiltStubsSources) GenerateAndroidBuildActions(ctx android.ModuleContext) {
801 p.stubsSrcJar = android.PathForModuleOut(ctx, ctx.ModuleName()+"-"+"stubs.srcjar")
802
803 if len(p.properties.Srcs) != 1 {
804 ctx.PropertyErrorf("srcs", "must only specify one directory path, contains %d paths", len(p.properties.Srcs))
805 return
806 }
807
808 localSrcDir := p.properties.Srcs[0]
809 // Although PathForModuleSrc can return nil if either the path doesn't exist or
810 // the path components are invalid it won't in this case because no components
811 // are specified and the module directory must exist in order to get this far.
812 srcDir := android.PathForModuleSrc(ctx).(android.SourcePath).Join(ctx, localSrcDir)
813
814 // Glob the contents of the directory just in case the directory does not exist.
815 srcGlob := localSrcDir + "/**/*"
816 srcPaths := android.PathsForModuleSrc(ctx, []string{srcGlob})
817
818 rule := android.NewRuleBuilder(pctx, ctx)
819 rule.Command().
820 BuiltTool("soong_zip").
821 Flag("-write_if_changed").
822 Flag("-jar").
823 FlagWithOutput("-o ", p.stubsSrcJar).
824 FlagWithArg("-C ", srcDir.String()).
825 FlagWithRspFileInputList("-r ", p.stubsSrcJar.ReplaceExtension(ctx, "rsp"), srcPaths)
826
827 rule.Restat()
828
829 rule.Build("zip src", "Create srcjar from prebuilt source")
830}
831
832func (p *PrebuiltStubsSources) Prebuilt() *android.Prebuilt {
833 return &p.prebuilt
834}
835
836func (p *PrebuiltStubsSources) Name() string {
837 return p.prebuilt.Name(p.ModuleBase.Name())
838}
839
840// prebuilt_stubs_sources imports a set of java source files as if they were
841// generated by droidstubs.
842//
843// By default, a prebuilt_stubs_sources has a single variant that expects a
844// set of `.java` files generated by droidstubs.
845//
846// Specifying `host_supported: true` will produce two variants, one for use as a dependency of device modules and one
847// for host modules.
848//
849// Intended only for use by sdk snapshots.
850func PrebuiltStubsSourcesFactory() android.Module {
851 module := &PrebuiltStubsSources{}
852
853 module.AddProperties(&module.properties)
854
855 android.InitPrebuiltModule(module, &module.properties.Srcs)
856 android.InitSdkAwareModule(module)
857 InitDroiddocModule(module, android.HostAndDeviceSupported)
858 return module
859}