blob: 63611d6bdb55f76f7fe7a55b6ff3c7ba1dba8cdf [file] [log] [blame]
Colin Cross2207f872021-03-24 12:39:08 -07001// Copyright 2021 Google Inc. All rights reserved.
2//
3// Licensed under the Apache License, Version 2.0 (the "License");
4// you may not use this file except in compliance with the License.
5// You may obtain a copy of the License at
6//
7// http://www.apache.org/licenses/LICENSE-2.0
8//
9// Unless required by applicable law or agreed to in writing, software
10// distributed under the License is distributed on an "AS IS" BASIS,
11// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
12// See the License for the specific language governing permissions and
13// limitations under the License.
14
15package java
16
17import (
18 "fmt"
Anton Hansson86758ac2021-11-03 14:44:12 +000019 "path/filepath"
MÃ¥rten Kongstad802ae0f2022-07-27 13:47:32 +020020 "regexp"
Colin Cross2207f872021-03-24 12:39:08 -070021 "strings"
22
23 "github.com/google/blueprint/proptools"
24
25 "android/soong/android"
26 "android/soong/java/config"
27 "android/soong/remoteexec"
28)
29
Pedro Loureirocc203502021-10-04 17:24:00 +000030// The values allowed for Droidstubs' Api_levels_sdk_type
Cole Faust051fa912022-10-05 12:45:42 -070031var allowedApiLevelSdkTypes = []string{"public", "system", "module-lib", "system-server"}
Pedro Loureirocc203502021-10-04 17:24:00 +000032
Jihoon Kang6592e872023-12-19 01:13:16 +000033type StubsType int
34
35const (
36 Everything StubsType = iota
37 Runtime
38 Exportable
Jihoon Kang78f89142023-12-27 01:40:29 +000039 Unavailable
Jihoon Kang6592e872023-12-19 01:13:16 +000040)
41
42func (s StubsType) String() string {
43 switch s {
44 case Everything:
45 return "everything"
46 case Runtime:
47 return "runtime"
48 case Exportable:
49 return "exportable"
50 default:
51 return ""
52 }
53}
54
Jihoon Kang5d701272024-02-15 21:53:49 +000055func StringToStubsType(s string) StubsType {
56 switch strings.ToLower(s) {
57 case Everything.String():
58 return Everything
59 case Runtime.String():
60 return Runtime
61 case Exportable.String():
62 return Exportable
63 default:
64 return Unavailable
65 }
66}
67
Colin Cross2207f872021-03-24 12:39:08 -070068func init() {
69 RegisterStubsBuildComponents(android.InitRegistrationContext)
70}
71
72func RegisterStubsBuildComponents(ctx android.RegistrationContext) {
73 ctx.RegisterModuleType("stubs_defaults", StubsDefaultsFactory)
74
75 ctx.RegisterModuleType("droidstubs", DroidstubsFactory)
76 ctx.RegisterModuleType("droidstubs_host", DroidstubsHostFactory)
77
78 ctx.RegisterModuleType("prebuilt_stubs_sources", PrebuiltStubsSourcesFactory)
79}
80
Jihoon Kangee113282024-01-23 00:16:41 +000081type stubsArtifacts struct {
82 nullabilityWarningsFile android.WritablePath
83 annotationsZip android.WritablePath
84 apiVersionsXml android.WritablePath
85 metadataZip android.WritablePath
86 metadataDir android.WritablePath
87}
88
Colin Cross2207f872021-03-24 12:39:08 -070089// Droidstubs
Colin Cross2207f872021-03-24 12:39:08 -070090type Droidstubs struct {
91 Javadoc
Spandan Das2cc80ba2023-10-27 17:21:52 +000092 embeddableInModuleAndImport
Colin Cross2207f872021-03-24 12:39:08 -070093
Jihoon Kangee113282024-01-23 00:16:41 +000094 properties DroidstubsProperties
95 apiFile android.Path
96 removedApiFile android.Path
Colin Cross2207f872021-03-24 12:39:08 -070097
98 checkCurrentApiTimestamp android.WritablePath
99 updateCurrentApiTimestamp android.WritablePath
100 checkLastReleasedApiTimestamp android.WritablePath
101 apiLintTimestamp android.WritablePath
102 apiLintReport android.WritablePath
103
104 checkNullabilityWarningsTimestamp android.WritablePath
105
Jihoon Kangee113282024-01-23 00:16:41 +0000106 everythingArtifacts stubsArtifacts
107 exportableArtifacts stubsArtifacts
Jihoon Kang3c89f042023-12-19 02:40:22 +0000108
Jihoon Kangee113282024-01-23 00:16:41 +0000109 exportableApiFile android.WritablePath
110 exportableRemovedApiFile android.WritablePath
Colin Cross2207f872021-03-24 12:39:08 -0700111}
112
113type DroidstubsProperties struct {
114 // The generated public API filename by Metalava, defaults to <module>_api.txt
115 Api_filename *string
116
117 // the generated removed API filename by Metalava, defaults to <module>_removed.txt
118 Removed_api_filename *string
119
Colin Cross2207f872021-03-24 12:39:08 -0700120 Check_api struct {
121 Last_released ApiToCheck
122
123 Current ApiToCheck
124
125 Api_lint struct {
126 Enabled *bool
127
128 // If set, performs api_lint on any new APIs not found in the given signature file
129 New_since *string `android:"path"`
130
131 // If not blank, path to the baseline txt file for approved API lint violations.
132 Baseline_file *string `android:"path"`
133 }
134 }
135
136 // user can specify the version of previous released API file in order to do compatibility check.
137 Previous_api *string `android:"path"`
138
139 // is set to true, Metalava will allow framework SDK to contain annotations.
140 Annotations_enabled *bool
141
142 // a list of top-level directories containing files to merge qualifier annotations (i.e. those intended to be included in the stubs written) from.
143 Merge_annotations_dirs []string
144
145 // a list of top-level directories containing Java stub files to merge show/hide annotations from.
146 Merge_inclusion_annotations_dirs []string
147
148 // a file containing a list of classes to do nullability validation for.
149 Validate_nullability_from_list *string
150
151 // a file containing expected warnings produced by validation of nullability annotations.
152 Check_nullability_warnings *string
153
154 // if set to true, allow Metalava to generate doc_stubs source files. Defaults to false.
155 Create_doc_stubs *bool
156
157 // if set to true, cause Metalava to output Javadoc comments in the stubs source files. Defaults to false.
158 // Has no effect if create_doc_stubs: true.
159 Output_javadoc_comments *bool
160
161 // if set to false then do not write out stubs. Defaults to true.
162 //
163 // TODO(b/146727827): Remove capability when we do not need to generate stubs and API separately.
164 Generate_stubs *bool
165
166 // if set to true, provides a hint to the build system that this rule uses a lot of memory,
Liz Kammer170dd722023-10-16 15:08:39 -0400167 // which can be used for scheduling purposes
Colin Cross2207f872021-03-24 12:39:08 -0700168 High_mem *bool
169
satayev783195c2021-06-23 21:49:57 +0100170 // if set to true, Metalava will allow framework SDK to contain API levels annotations.
Colin Cross2207f872021-03-24 12:39:08 -0700171 Api_levels_annotations_enabled *bool
172
Anton Hanssonc04a16e2022-05-09 09:30:26 +0000173 // Apply the api levels database created by this module rather than generating one in this droidstubs.
174 Api_levels_module *string
175
Colin Cross2207f872021-03-24 12:39:08 -0700176 // the dirs which Metalava extracts API levels annotations from.
177 Api_levels_annotations_dirs []string
178
Cole Faust051fa912022-10-05 12:45:42 -0700179 // the sdk kind which Metalava extracts API levels annotations from. Supports 'public', 'system', 'module-lib' and 'system-server'; defaults to public.
satayev783195c2021-06-23 21:49:57 +0100180 Api_levels_sdk_type *string
181
Colin Cross2207f872021-03-24 12:39:08 -0700182 // the filename which Metalava extracts API levels annotations from. Defaults to android.jar.
183 Api_levels_jar_filename *string
184
185 // if set to true, collect the values used by the Dev tools and
186 // write them in files packaged with the SDK. Defaults to false.
187 Write_sdk_values *bool
MÃ¥rten Kongstad802ae0f2022-07-27 13:47:32 +0200188
189 // path or filegroup to file defining extension an SDK name <-> numerical ID mapping and
190 // what APIs exist in which SDKs; passed to metalava via --sdk-extensions-info
191 Extensions_info_file *string `android:"path"`
Jihoon Kang3198f3c2023-01-26 08:08:52 +0000192
193 // API surface of this module. If set, the module contributes to an API surface.
194 // For the full list of available API surfaces, refer to soong/android/sdk_version.go
195 Api_surface *string
Jihoon Kang6592e872023-12-19 01:13:16 +0000196
197 // a list of aconfig_declarations module names that the stubs generated in this module
198 // depend on.
199 Aconfig_declarations []string
Paul Duffin27819362024-07-22 21:03:50 +0100200
201 // List of hard coded filegroups containing Metalava config files that are passed to every
202 // Metalava invocation that this module performs. See addMetalavaConfigFilesToCmd.
203 ConfigFiles []string `android:"path" blueprint:"mutated"`
Colin Cross2207f872021-03-24 12:39:08 -0700204}
205
Anton Hansson52609322021-05-05 10:36:05 +0100206// Used by xsd_config
207type ApiFilePath interface {
Jihoon Kangee113282024-01-23 00:16:41 +0000208 ApiFilePath(StubsType) (android.Path, error)
Anton Hansson52609322021-05-05 10:36:05 +0100209}
210
211type ApiStubsSrcProvider interface {
Jihoon Kangee113282024-01-23 00:16:41 +0000212 StubsSrcJar(StubsType) (android.Path, error)
Jihoon Kangf55a5f72024-01-08 08:56:20 +0000213}
214
Anton Hansson52609322021-05-05 10:36:05 +0100215// Provider of information about API stubs, used by java_sdk_library.
216type ApiStubsProvider interface {
Jihoon Kangee113282024-01-23 00:16:41 +0000217 AnnotationsZip(StubsType) (android.Path, error)
Anton Hansson52609322021-05-05 10:36:05 +0100218 ApiFilePath
Jihoon Kangee113282024-01-23 00:16:41 +0000219 RemovedApiFilePath(StubsType) (android.Path, error)
Anton Hansson52609322021-05-05 10:36:05 +0100220
221 ApiStubsSrcProvider
222}
223
Jihoon Kang063ec002023-06-28 01:16:23 +0000224type currentApiTimestampProvider interface {
225 CurrentApiTimestamp() android.Path
226}
227
Jihoon Kang3c89f042023-12-19 02:40:22 +0000228type annotationFlagsParams struct {
229 migratingNullability bool
230 validatingNullability bool
231 nullabilityWarningsFile android.WritablePath
232 annotationsZip android.WritablePath
233}
234type stubsCommandParams struct {
235 srcJarDir android.ModuleOutPath
236 stubsDir android.OptionalPath
237 stubsSrcJar android.WritablePath
238 metadataZip android.WritablePath
239 metadataDir android.WritablePath
240 apiVersionsXml android.WritablePath
241 nullabilityWarningsFile android.WritablePath
242 annotationsZip android.WritablePath
243 stubConfig stubsCommandConfigParams
244}
245type stubsCommandConfigParams struct {
Jihoon Kanga11d6792024-03-05 16:12:20 +0000246 stubsType StubsType
247 javaVersion javaVersion
248 deps deps
249 checkApi bool
250 generateStubs bool
251 doApiLint bool
252 doCheckReleased bool
253 writeSdkValues bool
254 migratingNullability bool
255 validatingNullability bool
Jihoon Kang3c89f042023-12-19 02:40:22 +0000256}
257
Colin Cross2207f872021-03-24 12:39:08 -0700258// droidstubs passes sources files through Metalava to generate stub .java files that only contain the API to be
259// documented, filtering out hidden classes and methods. The resulting .java files are intended to be passed to
260// a droiddoc module to generate documentation.
261func DroidstubsFactory() android.Module {
262 module := &Droidstubs{}
263
264 module.AddProperties(&module.properties,
265 &module.Javadoc.properties)
Paul Duffin27819362024-07-22 21:03:50 +0100266 module.properties.ConfigFiles = getMetalavaConfigFilegroupReference()
Spandan Das2cc80ba2023-10-27 17:21:52 +0000267 module.initModuleAndImport(module)
Colin Cross2207f872021-03-24 12:39:08 -0700268
269 InitDroiddocModule(module, android.HostAndDeviceSupported)
Jihoon Kang3198f3c2023-01-26 08:08:52 +0000270
271 module.SetDefaultableHook(func(ctx android.DefaultableHookContext) {
272 module.createApiContribution(ctx)
273 })
Colin Cross2207f872021-03-24 12:39:08 -0700274 return module
275}
276
277// droidstubs_host passes sources files through Metalava to generate stub .java files that only contain the API
278// to be documented, filtering out hidden classes and methods. The resulting .java files are intended to be
279// passed to a droiddoc_host module to generate documentation. Use a droidstubs_host instead of a droidstubs
280// module when symbols needed by the source files are provided by java_library_host modules.
281func DroidstubsHostFactory() android.Module {
282 module := &Droidstubs{}
283
284 module.AddProperties(&module.properties,
285 &module.Javadoc.properties)
286
Paul Duffin27819362024-07-22 21:03:50 +0100287 module.properties.ConfigFiles = getMetalavaConfigFilegroupReference()
Colin Cross2207f872021-03-24 12:39:08 -0700288 InitDroiddocModule(module, android.HostSupported)
289 return module
290}
291
Jihoon Kang246690a2024-02-01 21:55:01 +0000292func (d *Droidstubs) AnnotationsZip(stubsType StubsType) (ret android.Path, err error) {
Jihoon Kang78f89142023-12-27 01:40:29 +0000293 switch stubsType {
294 case Everything:
Jihoon Kang246690a2024-02-01 21:55:01 +0000295 ret, err = d.everythingArtifacts.annotationsZip, nil
Jihoon Kang78f89142023-12-27 01:40:29 +0000296 case Exportable:
Jihoon Kang246690a2024-02-01 21:55:01 +0000297 ret, err = d.exportableArtifacts.annotationsZip, nil
Jihoon Kang78f89142023-12-27 01:40:29 +0000298 default:
Jihoon Kang246690a2024-02-01 21:55:01 +0000299 ret, err = nil, fmt.Errorf("annotations zip not supported for the stub type %s", stubsType.String())
Jihoon Kang78f89142023-12-27 01:40:29 +0000300 }
Jihoon Kang246690a2024-02-01 21:55:01 +0000301 return ret, err
Jihoon Kang78f89142023-12-27 01:40:29 +0000302}
303
Jihoon Kang246690a2024-02-01 21:55:01 +0000304func (d *Droidstubs) ApiFilePath(stubsType StubsType) (ret android.Path, err error) {
Jihoon Kang78f89142023-12-27 01:40:29 +0000305 switch stubsType {
306 case Everything:
Jihoon Kang246690a2024-02-01 21:55:01 +0000307 ret, err = d.apiFile, nil
Jihoon Kang78f89142023-12-27 01:40:29 +0000308 case Exportable:
Jihoon Kang246690a2024-02-01 21:55:01 +0000309 ret, err = d.exportableApiFile, nil
Jihoon Kang78f89142023-12-27 01:40:29 +0000310 default:
Jihoon Kang246690a2024-02-01 21:55:01 +0000311 ret, err = nil, fmt.Errorf("api file path not supported for the stub type %s", stubsType.String())
Jihoon Kang78f89142023-12-27 01:40:29 +0000312 }
Jihoon Kang246690a2024-02-01 21:55:01 +0000313 if ret == nil && err == nil {
Jihoon Kang36c3d962024-03-14 17:28:44 +0000314 err = fmt.Errorf("api file is null for the stub type %s", stubsType.String())
Jihoon Kang246690a2024-02-01 21:55:01 +0000315 }
316 return ret, err
Jihoon Kang78f89142023-12-27 01:40:29 +0000317}
318
Jihoon Kang246690a2024-02-01 21:55:01 +0000319func (d *Droidstubs) ApiVersionsXmlFilePath(stubsType StubsType) (ret android.Path, err error) {
Jihoon Kang78f89142023-12-27 01:40:29 +0000320 switch stubsType {
321 case Everything:
Jihoon Kang246690a2024-02-01 21:55:01 +0000322 ret, err = d.everythingArtifacts.apiVersionsXml, nil
Jihoon Kang78f89142023-12-27 01:40:29 +0000323 case Exportable:
Jihoon Kang246690a2024-02-01 21:55:01 +0000324 ret, err = d.exportableArtifacts.apiVersionsXml, nil
Jihoon Kang78f89142023-12-27 01:40:29 +0000325 default:
Jihoon Kang246690a2024-02-01 21:55:01 +0000326 ret, err = nil, fmt.Errorf("api versions xml file path not supported for the stub type %s", stubsType.String())
Jihoon Kang78f89142023-12-27 01:40:29 +0000327 }
Jihoon Kang246690a2024-02-01 21:55:01 +0000328 if ret == nil && err == nil {
329 err = fmt.Errorf("api versions xml file is null for the stub type %s", stubsType.String())
330 }
331 return ret, err
Jihoon Kang78f89142023-12-27 01:40:29 +0000332}
333
Jihoon Kang246690a2024-02-01 21:55:01 +0000334func (d *Droidstubs) DocZip(stubsType StubsType) (ret android.Path, err error) {
Jihoon Kang78f89142023-12-27 01:40:29 +0000335 switch stubsType {
336 case Everything:
Jihoon Kang246690a2024-02-01 21:55:01 +0000337 ret, err = d.docZip, nil
Jihoon Kang78f89142023-12-27 01:40:29 +0000338 default:
Jihoon Kang246690a2024-02-01 21:55:01 +0000339 ret, err = nil, fmt.Errorf("docs zip not supported for the stub type %s", stubsType.String())
Jihoon Kang78f89142023-12-27 01:40:29 +0000340 }
Jihoon Kang246690a2024-02-01 21:55:01 +0000341 if ret == nil && err == nil {
342 err = fmt.Errorf("docs zip is null for the stub type %s", stubsType.String())
343 }
344 return ret, err
345}
346
347func (d *Droidstubs) RemovedApiFilePath(stubsType StubsType) (ret android.Path, err error) {
348 switch stubsType {
349 case Everything:
350 ret, err = d.removedApiFile, nil
351 case Exportable:
352 ret, err = d.exportableRemovedApiFile, nil
353 default:
354 ret, err = nil, fmt.Errorf("removed api file path not supported for the stub type %s", stubsType.String())
355 }
356 if ret == nil && err == nil {
357 err = fmt.Errorf("removed api file is null for the stub type %s", stubsType.String())
358 }
359 return ret, err
360}
361
362func (d *Droidstubs) StubsSrcJar(stubsType StubsType) (ret android.Path, err error) {
363 switch stubsType {
364 case Everything:
365 ret, err = d.stubsSrcJar, nil
366 case Exportable:
367 ret, err = d.exportableStubsSrcJar, nil
368 default:
369 ret, err = nil, fmt.Errorf("stubs srcjar not supported for the stub type %s", stubsType.String())
370 }
371 if ret == nil && err == nil {
372 err = fmt.Errorf("stubs srcjar is null for the stub type %s", stubsType.String())
373 }
374 return ret, err
Jihoon Kang78f89142023-12-27 01:40:29 +0000375}
376
Jihoon Kang063ec002023-06-28 01:16:23 +0000377func (d *Droidstubs) CurrentApiTimestamp() android.Path {
378 return d.checkCurrentApiTimestamp
379}
380
Colin Cross2207f872021-03-24 12:39:08 -0700381var metalavaMergeAnnotationsDirTag = dependencyTag{name: "metalava-merge-annotations-dir"}
382var metalavaMergeInclusionAnnotationsDirTag = dependencyTag{name: "metalava-merge-inclusion-annotations-dir"}
383var metalavaAPILevelsAnnotationsDirTag = dependencyTag{name: "metalava-api-levels-annotations-dir"}
Anton Hanssonc04a16e2022-05-09 09:30:26 +0000384var metalavaAPILevelsModuleTag = dependencyTag{name: "metalava-api-levels-module-tag"}
Jihoon Kang063ec002023-06-28 01:16:23 +0000385var metalavaCurrentApiTimestampTag = dependencyTag{name: "metalava-current-api-timestamp-tag"}
Colin Cross2207f872021-03-24 12:39:08 -0700386
387func (d *Droidstubs) DepsMutator(ctx android.BottomUpMutatorContext) {
388 d.Javadoc.addDeps(ctx)
389
390 if len(d.properties.Merge_annotations_dirs) != 0 {
391 for _, mergeAnnotationsDir := range d.properties.Merge_annotations_dirs {
392 ctx.AddDependency(ctx.Module(), metalavaMergeAnnotationsDirTag, mergeAnnotationsDir)
393 }
394 }
395
396 if len(d.properties.Merge_inclusion_annotations_dirs) != 0 {
397 for _, mergeInclusionAnnotationsDir := range d.properties.Merge_inclusion_annotations_dirs {
398 ctx.AddDependency(ctx.Module(), metalavaMergeInclusionAnnotationsDirTag, mergeInclusionAnnotationsDir)
399 }
400 }
401
402 if len(d.properties.Api_levels_annotations_dirs) != 0 {
403 for _, apiLevelsAnnotationsDir := range d.properties.Api_levels_annotations_dirs {
404 ctx.AddDependency(ctx.Module(), metalavaAPILevelsAnnotationsDirTag, apiLevelsAnnotationsDir)
405 }
406 }
Anton Hanssonc04a16e2022-05-09 09:30:26 +0000407
Jihoon Kang6592e872023-12-19 01:13:16 +0000408 if len(d.properties.Aconfig_declarations) != 0 {
409 for _, aconfigDeclarationModuleName := range d.properties.Aconfig_declarations {
410 ctx.AddDependency(ctx.Module(), aconfigDeclarationTag, aconfigDeclarationModuleName)
411 }
412 }
413
Anton Hanssonc04a16e2022-05-09 09:30:26 +0000414 if d.properties.Api_levels_module != nil {
415 ctx.AddDependency(ctx.Module(), metalavaAPILevelsModuleTag, proptools.String(d.properties.Api_levels_module))
416 }
Colin Cross2207f872021-03-24 12:39:08 -0700417}
418
Jihoon Kang3c89f042023-12-19 02:40:22 +0000419func (d *Droidstubs) sdkValuesFlags(ctx android.ModuleContext, cmd *android.RuleBuilderCommand, metadataDir android.WritablePath) {
420 cmd.FlagWithArg("--sdk-values ", metadataDir.String())
421}
422
423func (d *Droidstubs) stubsFlags(ctx android.ModuleContext, cmd *android.RuleBuilderCommand, stubsDir android.OptionalPath, stubsType StubsType, checkApi bool) {
Jihoon Kang3c89f042023-12-19 02:40:22 +0000424
Jihoon Kang36c3d962024-03-14 17:28:44 +0000425 apiFileName := proptools.StringDefault(d.properties.Api_filename, ctx.ModuleName()+"_api.txt")
426 uncheckedApiFile := android.PathForModuleOut(ctx, stubsType.String(), apiFileName)
427 cmd.FlagWithOutput("--api ", uncheckedApiFile)
428 if checkApi || String(d.properties.Api_filename) != "" {
Jihoon Kang3c89f042023-12-19 02:40:22 +0000429 if stubsType == Everything {
430 d.apiFile = uncheckedApiFile
431 } else if stubsType == Exportable {
432 d.exportableApiFile = uncheckedApiFile
433 }
Colin Cross2207f872021-03-24 12:39:08 -0700434 } else if sourceApiFile := proptools.String(d.properties.Check_api.Current.Api_file); sourceApiFile != "" {
Jihoon Kang36c3d962024-03-14 17:28:44 +0000435 if stubsType == Everything {
436 // If check api is disabled then make the source file available for export.
437 d.apiFile = android.PathForModuleSrc(ctx, sourceApiFile)
438 } else if stubsType == Exportable {
439 d.exportableApiFile = uncheckedApiFile
440 }
Colin Cross2207f872021-03-24 12:39:08 -0700441 }
442
Jihoon Kang36c3d962024-03-14 17:28:44 +0000443 removedApiFileName := proptools.StringDefault(d.properties.Removed_api_filename, ctx.ModuleName()+"_removed.txt")
444 uncheckedRemovedFile := android.PathForModuleOut(ctx, stubsType.String(), removedApiFileName)
445 cmd.FlagWithOutput("--removed-api ", uncheckedRemovedFile)
Jihoon Kang3c89f042023-12-19 02:40:22 +0000446 if checkApi || String(d.properties.Removed_api_filename) != "" {
Jihoon Kang3c89f042023-12-19 02:40:22 +0000447 if stubsType == Everything {
448 d.removedApiFile = uncheckedRemovedFile
449 } else if stubsType == Exportable {
450 d.exportableRemovedApiFile = uncheckedRemovedFile
451 }
Colin Cross2207f872021-03-24 12:39:08 -0700452 } else if sourceRemovedApiFile := proptools.String(d.properties.Check_api.Current.Removed_api_file); sourceRemovedApiFile != "" {
Jihoon Kang36c3d962024-03-14 17:28:44 +0000453 if stubsType == Everything {
454 // If check api is disabled then make the source removed api file available for export.
455 d.removedApiFile = android.PathForModuleSrc(ctx, sourceRemovedApiFile)
456 } else if stubsType == Exportable {
457 d.exportableRemovedApiFile = uncheckedRemovedFile
458 }
Colin Cross2207f872021-03-24 12:39:08 -0700459 }
460
Colin Cross2207f872021-03-24 12:39:08 -0700461 if stubsDir.Valid() {
462 if Bool(d.properties.Create_doc_stubs) {
463 cmd.FlagWithArg("--doc-stubs ", stubsDir.String())
464 } else {
465 cmd.FlagWithArg("--stubs ", stubsDir.String())
466 if !Bool(d.properties.Output_javadoc_comments) {
467 cmd.Flag("--exclude-documentation-from-stubs")
468 }
469 }
470 }
471}
472
Jihoon Kang3c89f042023-12-19 02:40:22 +0000473func (d *Droidstubs) annotationsFlags(ctx android.ModuleContext, cmd *android.RuleBuilderCommand, params annotationFlagsParams) {
Jihoon Kanga11d6792024-03-05 16:12:20 +0000474 if Bool(d.properties.Annotations_enabled) {
475 cmd.Flag(config.MetalavaAnnotationsFlags)
Andrei Onea4985e512021-04-29 16:29:34 +0100476
Jihoon Kanga11d6792024-03-05 16:12:20 +0000477 if params.migratingNullability {
Jihoon Kang5623e542024-01-31 23:27:26 +0000478 previousApiFiles := android.PathsForModuleSrc(ctx, []string{String(d.properties.Previous_api)})
479 cmd.FlagForEachInput("--migrate-nullness ", previousApiFiles)
Jihoon Kanga11d6792024-03-05 16:12:20 +0000480 }
Jihoon Kang6b93b382024-01-26 22:37:41 +0000481
Jihoon Kanga11d6792024-03-05 16:12:20 +0000482 if s := String(d.properties.Validate_nullability_from_list); s != "" {
483 cmd.FlagWithInput("--validate-nullability-from-list ", android.PathForModuleSrc(ctx, s))
484 }
Jihoon Kang6b93b382024-01-26 22:37:41 +0000485
Jihoon Kanga11d6792024-03-05 16:12:20 +0000486 if params.validatingNullability {
487 cmd.FlagWithOutput("--nullability-warnings-txt ", params.nullabilityWarningsFile)
488 }
Jihoon Kang6b93b382024-01-26 22:37:41 +0000489
Jihoon Kangca2f9e82024-01-26 01:45:12 +0000490 cmd.FlagWithOutput("--extract-annotations ", params.annotationsZip)
Jihoon Kang6b93b382024-01-26 22:37:41 +0000491
Jihoon Kanga11d6792024-03-05 16:12:20 +0000492 if len(d.properties.Merge_annotations_dirs) != 0 {
493 d.mergeAnnoDirFlags(ctx, cmd)
494 }
Jihoon Kang6b93b382024-01-26 22:37:41 +0000495
Jihoon Kanga11d6792024-03-05 16:12:20 +0000496 cmd.Flag(config.MetalavaAnnotationsWarningsFlags)
Colin Cross2207f872021-03-24 12:39:08 -0700497 }
Colin Cross2207f872021-03-24 12:39:08 -0700498}
499
500func (d *Droidstubs) mergeAnnoDirFlags(ctx android.ModuleContext, cmd *android.RuleBuilderCommand) {
501 ctx.VisitDirectDepsWithTag(metalavaMergeAnnotationsDirTag, func(m android.Module) {
502 if t, ok := m.(*ExportedDroiddocDir); ok {
503 cmd.FlagWithArg("--merge-qualifier-annotations ", t.dir.String()).Implicits(t.deps)
504 } else {
505 ctx.PropertyErrorf("merge_annotations_dirs",
506 "module %q is not a metalava merge-annotations dir", ctx.OtherModuleName(m))
507 }
508 })
509}
510
511func (d *Droidstubs) inclusionAnnotationsFlags(ctx android.ModuleContext, cmd *android.RuleBuilderCommand) {
512 ctx.VisitDirectDepsWithTag(metalavaMergeInclusionAnnotationsDirTag, func(m android.Module) {
513 if t, ok := m.(*ExportedDroiddocDir); ok {
514 cmd.FlagWithArg("--merge-inclusion-annotations ", t.dir.String()).Implicits(t.deps)
515 } else {
516 ctx.PropertyErrorf("merge_inclusion_annotations_dirs",
517 "module %q is not a metalava merge-annotations dir", ctx.OtherModuleName(m))
518 }
519 })
520}
521
Jihoon Kanga11d6792024-03-05 16:12:20 +0000522func (d *Droidstubs) apiLevelsAnnotationsFlags(ctx android.ModuleContext, cmd *android.RuleBuilderCommand, stubsType StubsType, apiVersionsXml android.WritablePath) {
Anton Hanssonc04a16e2022-05-09 09:30:26 +0000523 var apiVersions android.Path
Jihoon Kanga11d6792024-03-05 16:12:20 +0000524 if proptools.Bool(d.properties.Api_levels_annotations_enabled) {
Jihoon Kang3c89f042023-12-19 02:40:22 +0000525 d.apiLevelsGenerationFlags(ctx, cmd, stubsType, apiVersionsXml)
Jihoon Kangd9a06942024-01-26 01:49:20 +0000526 apiVersions = apiVersionsXml
Anton Hanssonc04a16e2022-05-09 09:30:26 +0000527 } else {
528 ctx.VisitDirectDepsWithTag(metalavaAPILevelsModuleTag, func(m android.Module) {
529 if s, ok := m.(*Droidstubs); ok {
Jihoon Kangd9a06942024-01-26 01:49:20 +0000530 if stubsType == Everything {
531 apiVersions = s.everythingArtifacts.apiVersionsXml
532 } else if stubsType == Exportable {
533 apiVersions = s.exportableArtifacts.apiVersionsXml
534 } else {
Jihoon Kangd40c5912024-03-05 16:12:20 +0000535 ctx.ModuleErrorf("%s stubs type does not generate api-versions.xml file", stubsType.String())
Jihoon Kangd9a06942024-01-26 01:49:20 +0000536 }
Anton Hanssonc04a16e2022-05-09 09:30:26 +0000537 } else {
538 ctx.PropertyErrorf("api_levels_module",
539 "module %q is not a droidstubs module", ctx.OtherModuleName(m))
540 }
541 })
Colin Cross2207f872021-03-24 12:39:08 -0700542 }
Anton Hanssonc04a16e2022-05-09 09:30:26 +0000543 if apiVersions != nil {
544 cmd.FlagWithArg("--current-version ", ctx.Config().PlatformSdkVersion().String())
545 cmd.FlagWithArg("--current-codename ", ctx.Config().PlatformSdkCodename())
546 cmd.FlagWithInput("--apply-api-levels ", apiVersions)
547 }
548}
Colin Cross2207f872021-03-24 12:39:08 -0700549
Paul Duffin5a195f42024-05-01 12:52:35 +0100550// AndroidPlusUpdatableJar is the name of some extra jars added into `module-lib` and
551// `system-server` directories that contain all the APIs provided by the platform and updatable
552// modules because the `android.jar` files do not. See b/337836752.
553const AndroidPlusUpdatableJar = "android-plus-updatable.jar"
554
Jihoon Kang3c89f042023-12-19 02:40:22 +0000555func (d *Droidstubs) apiLevelsGenerationFlags(ctx android.ModuleContext, cmd *android.RuleBuilderCommand, stubsType StubsType, apiVersionsXml android.WritablePath) {
Colin Cross2207f872021-03-24 12:39:08 -0700556 if len(d.properties.Api_levels_annotations_dirs) == 0 {
557 ctx.PropertyErrorf("api_levels_annotations_dirs",
558 "has to be non-empty if api levels annotations was enabled!")
559 }
560
Jihoon Kang3c89f042023-12-19 02:40:22 +0000561 cmd.FlagWithOutput("--generate-api-levels ", apiVersionsXml)
Colin Cross2207f872021-03-24 12:39:08 -0700562
563 filename := proptools.StringDefault(d.properties.Api_levels_jar_filename, "android.jar")
564
Paul Duffin58cfc9a2024-04-25 17:01:49 +0100565 // TODO: Avoid the duplication of API surfaces, reuse apiScope.
566 // Add all relevant --android-jar-pattern patterns for Metalava.
567 // When parsing a stub jar for a specific version, Metalava picks the first pattern that defines
568 // an actual file present on disk (in the order the patterns were passed). For system APIs for
569 // privileged apps that are only defined since API level 21 (Lollipop), fallback to public stubs
570 // for older releases. Similarly, module-lib falls back to system API.
571 var sdkDirs []string
Paul Duffin92efc612024-05-02 17:18:05 +0100572 apiLevelsSdkType := proptools.StringDefault(d.properties.Api_levels_sdk_type, "public")
573 switch apiLevelsSdkType {
Paul Duffin58cfc9a2024-04-25 17:01:49 +0100574 case "system-server":
575 sdkDirs = []string{"system-server", "module-lib", "system", "public"}
576 case "module-lib":
577 sdkDirs = []string{"module-lib", "system", "public"}
578 case "system":
579 sdkDirs = []string{"system", "public"}
580 case "public":
581 sdkDirs = []string{"public"}
582 default:
583 ctx.PropertyErrorf("api_levels_sdk_type", "needs to be one of %v", allowedApiLevelSdkTypes)
584 return
585 }
586
Paul Duffin92efc612024-05-02 17:18:05 +0100587 // Construct a pattern to match the appropriate extensions that should be included in the
588 // generated api-versions.xml file.
589 //
Paul Duffin58cfc9a2024-04-25 17:01:49 +0100590 // Use the first item in the sdkDirs array as that is the sdk type for the target API levels
591 // being generated but has the advantage over `Api_levels_sdk_type` as it has been validated.
Paul Duffin92efc612024-05-02 17:18:05 +0100592 // The exception is for system-server which needs to include module-lib and system-server. That
593 // is because while system-server extends module-lib the system-server extension directory only
594 // contains service-* modules which provide system-server APIs it does not list the modules which
595 // only provide a module-lib, so they have to be included separately.
596 extensionSurfacesPattern := sdkDirs[0]
597 if apiLevelsSdkType == "system-server" {
598 // Take the first two items in sdkDirs, which are system-server and module-lib, and construct
599 // a pattern that will match either.
600 extensionSurfacesPattern = strings.Join(sdkDirs[0:2], "|")
601 }
602 extensionsPattern := fmt.Sprintf(`/extensions/[0-9]+/(%s)/.*\.jar`, extensionSurfacesPattern)
Paul Duffin58cfc9a2024-04-25 17:01:49 +0100603
satayev783195c2021-06-23 21:49:57 +0100604 var dirs []string
MÃ¥rten Kongstad802ae0f2022-07-27 13:47:32 +0200605 var extensions_dir string
Colin Cross2207f872021-03-24 12:39:08 -0700606 ctx.VisitDirectDepsWithTag(metalavaAPILevelsAnnotationsDirTag, func(m android.Module) {
607 if t, ok := m.(*ExportedDroiddocDir); ok {
Paul Duffin58cfc9a2024-04-25 17:01:49 +0100608 extRegex := regexp.MustCompile(t.dir.String() + extensionsPattern)
MÃ¥rten Kongstad802ae0f2022-07-27 13:47:32 +0200609
610 // Grab the first extensions_dir and we find while scanning ExportedDroiddocDir.deps;
611 // ideally this should be read from prebuiltApis.properties.Extensions_*
Colin Cross2207f872021-03-24 12:39:08 -0700612 for _, dep := range t.deps {
Paul Duffin2ced2eb2024-05-01 13:13:51 +0100613 // Check to see if it matches an extension first.
614 depBase := dep.Base()
MÃ¥rten Kongstad802ae0f2022-07-27 13:47:32 +0200615 if extRegex.MatchString(dep.String()) && d.properties.Extensions_info_file != nil {
616 if extensions_dir == "" {
617 extensions_dir = t.dir.String() + "/extensions"
618 }
619 cmd.Implicit(dep)
Paul Duffin2ced2eb2024-05-01 13:13:51 +0100620 } else if depBase == filename {
621 // Check to see if it matches a dessert release for an SDK, e.g. Android, Car, Wear, etc..
Colin Cross5f6ffc72021-03-29 21:54:45 -0700622 cmd.Implicit(dep)
Paul Duffin5a195f42024-05-01 12:52:35 +0100623 } else if depBase == AndroidPlusUpdatableJar && d.properties.Extensions_info_file != nil {
624 // The output api-versions.xml has been requested to include information on SDK
Paul Duffinee5e0932025-01-15 18:00:35 +0000625 // extensions, i.e. updatable Apis. That means it also needs to include the history of
626 // those updatable APIs. Usually, they would be included in the `android.jar` file but
627 // unfortunately, the `module-lib` and `system-server` cannot as it would lead to build
628 // cycles. So, the module-lib and system-server directories contain an
629 // `android-plus-updatable.jar` that should be used instead of `android.jar`. See
630 // AndroidPlusUpdatableJar for more information.
Paul Duffin5a195f42024-05-01 12:52:35 +0100631 cmd.Implicit(dep)
Colin Cross2207f872021-03-24 12:39:08 -0700632 }
633 }
satayev783195c2021-06-23 21:49:57 +0100634
635 dirs = append(dirs, t.dir.String())
Colin Cross2207f872021-03-24 12:39:08 -0700636 } else {
637 ctx.PropertyErrorf("api_levels_annotations_dirs",
638 "module %q is not a metalava api-levels-annotations dir", ctx.OtherModuleName(m))
639 }
640 })
satayev783195c2021-06-23 21:49:57 +0100641
Paul Duffin5a195f42024-05-01 12:52:35 +0100642 // Generate the list of --android-jar-pattern options. The order matters so the first one which
Paul Duffin4c9d3052025-01-07 16:03:10 +0000643 // matches will be the one that is used for a specific api level.
Pedro Loureirocc203502021-10-04 17:24:00 +0000644 for _, sdkDir := range sdkDirs {
645 for _, dir := range dirs {
Paul Duffin5a195f42024-05-01 12:52:35 +0100646 addPattern := func(jarFilename string) {
Paul Duffin4c9d3052025-01-07 16:03:10 +0000647 cmd.FlagWithArg("--android-jar-pattern ", fmt.Sprintf("%s/{version:level}/%s/%s", dir, sdkDir, jarFilename))
Paul Duffin5a195f42024-05-01 12:52:35 +0100648 }
649
650 if sdkDir == "module-lib" || sdkDir == "system-server" {
651 // The module-lib and system-server android.jars do not include the updatable modules (as
652 // doing so in the source would introduce dependency cycles and the prebuilts have to
653 // match the sources). So, instead an additional `android-plus-updatable.jar` will be used
654 // that does include the updatable modules and this pattern will match that. This pattern
655 // is added in addition to the following pattern to decouple this change from the change
656 // to add the `android-plus-updatable.jar`.
657 addPattern(AndroidPlusUpdatableJar)
658 }
659
660 addPattern(filename)
Pedro Loureirocc203502021-10-04 17:24:00 +0000661 }
satayev783195c2021-06-23 21:49:57 +0100662 }
MÃ¥rten Kongstad802ae0f2022-07-27 13:47:32 +0200663
664 if d.properties.Extensions_info_file != nil {
665 if extensions_dir == "" {
666 ctx.ModuleErrorf("extensions_info_file set, but no SDK extension dirs found")
667 }
668 info_file := android.PathForModuleSrc(ctx, *d.properties.Extensions_info_file)
669 cmd.Implicit(info_file)
670 cmd.FlagWithArg("--sdk-extensions-root ", extensions_dir)
671 cmd.FlagWithArg("--sdk-extensions-info ", info_file.String())
672 }
Colin Cross2207f872021-03-24 12:39:08 -0700673}
674
Jihoon Kang472f73f2024-03-28 20:59:29 +0000675func (d *Droidstubs) apiCompatibilityFlags(ctx android.ModuleContext, cmd *android.RuleBuilderCommand, stubsType StubsType) {
676 if len(d.Javadoc.properties.Out) > 0 {
677 ctx.PropertyErrorf("out", "out property may not be combined with check_api")
678 }
679
Jihoon Kang5623e542024-01-31 23:27:26 +0000680 apiFiles := android.PathsForModuleSrc(ctx, []string{String(d.properties.Check_api.Last_released.Api_file)})
681 removedApiFiles := android.PathsForModuleSrc(ctx, []string{String(d.properties.Check_api.Last_released.Removed_api_file)})
Jihoon Kang472f73f2024-03-28 20:59:29 +0000682
Jihoon Kang5623e542024-01-31 23:27:26 +0000683 cmd.FlagForEachInput("--check-compatibility:api:released ", apiFiles)
684 cmd.FlagForEachInput("--check-compatibility:removed:released ", removedApiFiles)
Jihoon Kang472f73f2024-03-28 20:59:29 +0000685
686 baselineFile := android.OptionalPathForModuleSrc(ctx, d.properties.Check_api.Last_released.Baseline_file)
687 if baselineFile.Valid() {
688 cmd.FlagWithInput("--baseline:compatibility:released ", baselineFile.Path())
689 }
690}
691
Colin Crosse52c2ac2022-03-28 17:03:35 -0700692func metalavaUseRbe(ctx android.ModuleContext) bool {
693 return ctx.Config().UseRBE() && ctx.Config().IsEnvTrue("RBE_METALAVA")
694}
695
Jihoon Kang421c1cd2024-04-22 21:17:12 +0000696func metalavaCmd(ctx android.ModuleContext, rule *android.RuleBuilder, srcs android.Paths,
Paul Duffin27819362024-07-22 21:03:50 +0100697 srcJarList android.Path, homeDir android.WritablePath, params stubsCommandConfigParams, configFiles android.Paths) *android.RuleBuilderCommand {
Colin Cross2207f872021-03-24 12:39:08 -0700698 rule.Command().Text("rm -rf").Flag(homeDir.String())
699 rule.Command().Text("mkdir -p").Flag(homeDir.String())
700
Anton Hansson556e8142021-06-04 16:20:25 +0100701 cmd := rule.Command()
Colin Cross2207f872021-03-24 12:39:08 -0700702 cmd.FlagWithArg("ANDROID_PREFS_ROOT=", homeDir.String())
703
Colin Crosse52c2ac2022-03-28 17:03:35 -0700704 if metalavaUseRbe(ctx) {
Colin Cross2207f872021-03-24 12:39:08 -0700705 rule.Remoteable(android.RemoteRuleSupports{RBE: true})
Colin Cross8095c292021-03-30 16:40:48 -0700706 execStrategy := ctx.Config().GetenvWithDefault("RBE_METALAVA_EXEC_STRATEGY", remoteexec.LocalExecStrategy)
Anas Sulaiman9d7a36d2023-11-21 23:00:07 +0000707 compare := ctx.Config().IsEnvTrue("RBE_METALAVA_COMPARE")
708 remoteUpdateCache := !ctx.Config().IsEnvFalse("RBE_METALAVA_REMOTE_UPDATE_CACHE")
Colin Cross8095c292021-03-30 16:40:48 -0700709 labels := map[string]string{"type": "tool", "name": "metalava"}
710 // TODO: metalava pool rejects these jobs
711 pool := ctx.Config().GetenvWithDefault("RBE_METALAVA_POOL", "java16")
712 rule.Rewrapper(&remoteexec.REParams{
Anas Sulaiman9d7a36d2023-11-21 23:00:07 +0000713 Labels: labels,
714 ExecStrategy: execStrategy,
715 ToolchainInputs: []string{config.JavaCmd(ctx).String()},
716 Platform: map[string]string{remoteexec.PoolKey: pool},
717 Compare: compare,
718 NumLocalRuns: 1,
719 NumRemoteRuns: 1,
720 NoRemoteUpdateCache: !remoteUpdateCache,
Colin Cross8095c292021-03-30 16:40:48 -0700721 })
Colin Cross2207f872021-03-24 12:39:08 -0700722 }
723
Colin Cross6aa5c402021-03-24 12:28:50 -0700724 cmd.BuiltTool("metalava").ImplicitTool(ctx.Config().HostJavaToolPath(ctx, "metalava.jar")).
Colin Cross2207f872021-03-24 12:39:08 -0700725 Flag(config.JavacVmFlags).
Liz Kammere09e20e2023-10-16 15:07:54 -0400726 Flag(config.MetalavaAddOpens).
Jihoon Kang421c1cd2024-04-22 21:17:12 +0000727 FlagWithArg("--java-source ", params.javaVersion.String()).
728 FlagWithRspFileInputList("@", android.PathForModuleOut(ctx, fmt.Sprintf("%s.metalava.rsp", params.stubsType.String())), srcs).
Colin Cross2207f872021-03-24 12:39:08 -0700729 FlagWithInput("@", srcJarList)
730
Paul Duffinf8aaaa12023-08-10 15:16:35 +0100731 // Metalava does not differentiate between bootclasspath and classpath and has not done so for
732 // years, so it is unlikely to change any time soon.
Jihoon Kang421c1cd2024-04-22 21:17:12 +0000733 combinedPaths := append(([]android.Path)(nil), params.deps.bootClasspath.Paths()...)
734 combinedPaths = append(combinedPaths, params.deps.classpath.Paths()...)
Paul Duffinf8aaaa12023-08-10 15:16:35 +0100735 if len(combinedPaths) > 0 {
736 cmd.FlagWithInputList("--classpath ", combinedPaths, ":")
Colin Cross2207f872021-03-24 12:39:08 -0700737 }
738
Liz Kammere09e20e2023-10-16 15:07:54 -0400739 cmd.Flag(config.MetalavaFlags)
Jihoon Kangc8313892023-09-20 00:54:47 +0000740
Paul Duffin27819362024-07-22 21:03:50 +0100741 addMetalavaConfigFilesToCmd(cmd, configFiles)
742
Colin Cross2207f872021-03-24 12:39:08 -0700743 return cmd
744}
745
Paul Duffin27819362024-07-22 21:03:50 +0100746// MetalavaConfigFilegroup is the name of the filegroup in build/soong/java/metalava that lists
747// the configuration files to pass to Metalava.
748const MetalavaConfigFilegroup = "metalava-config-files"
749
750// Get a reference to the MetalavaConfigFilegroup suitable for use in a property.
751func getMetalavaConfigFilegroupReference() []string {
752 return []string{":" + MetalavaConfigFilegroup}
753}
754
755// addMetalavaConfigFilesToCmd adds --config-file options to use the config files list in the
756// MetalavaConfigFilegroup filegroup.
757func addMetalavaConfigFilesToCmd(cmd *android.RuleBuilderCommand, configFiles android.Paths) {
758 cmd.FlagForEachInput("--config-file ", configFiles)
759}
760
Jihoon Kang3c89f042023-12-19 02:40:22 +0000761// Pass flagged apis related flags to metalava. When aconfig_declarations property is not
762// defined for a module, simply revert all flagged apis annotations. If aconfig_declarations
763// property is defined, apply transformations and only revert the flagged apis that are not
764// enabled via release configurations and are not specified in aconfig_declarations
Jihoon Kang5d701272024-02-15 21:53:49 +0000765func generateRevertAnnotationArgs(ctx android.ModuleContext, cmd *android.RuleBuilderCommand, stubsType StubsType, aconfigFlagsPaths android.Paths) {
Jihoon Kang6592e872023-12-19 01:13:16 +0000766 var filterArgs string
767 switch stubsType {
768 // No flagged apis specific flags need to be passed to metalava when generating
769 // everything stubs
770 case Everything:
771 return
772
773 case Runtime:
774 filterArgs = "--filter='state:ENABLED+permission:READ_ONLY' --filter='permission:READ_WRITE'"
775
776 case Exportable:
Jihoon Kang59198152024-02-06 22:43:18 +0000777 // When the build flag RELEASE_EXPORT_RUNTIME_APIS is set to true, apis marked with
778 // the flagged apis that have read_write permissions are exposed on top of the enabled
779 // and read_only apis. This is to support local override of flag values at runtime.
780 if ctx.Config().ReleaseExportRuntimeApis() {
781 filterArgs = "--filter='state:ENABLED+permission:READ_ONLY' --filter='permission:READ_WRITE'"
782 } else {
783 filterArgs = "--filter='state:ENABLED+permission:READ_ONLY'"
784 }
Jihoon Kang6592e872023-12-19 01:13:16 +0000785 }
786
Jihoon Kangf1e0ff02024-11-20 21:10:40 +0000787 if len(aconfigFlagsPaths) == 0 {
788 // This argument should not be added for "everything" stubs
789 cmd.Flag("--revert-annotation android.annotation.FlaggedApi")
790 return
791 }
792
793 releasedFlaggedApisFile := android.PathForModuleOut(ctx, fmt.Sprintf("released-flagged-apis-%s.txt", stubsType.String()))
794 revertAnnotationsFile := android.PathForModuleOut(ctx, fmt.Sprintf("revert-annotations-%s.txt", stubsType.String()))
795
Jihoon Kang6592e872023-12-19 01:13:16 +0000796 ctx.Build(pctx, android.BuildParams{
797 Rule: gatherReleasedFlaggedApisRule,
798 Inputs: aconfigFlagsPaths,
799 Output: releasedFlaggedApisFile,
800 Description: fmt.Sprintf("%s gather aconfig flags", stubsType),
801 Args: map[string]string{
802 "flags_path": android.JoinPathsWithPrefix(aconfigFlagsPaths, "--cache "),
803 "filter_args": filterArgs,
804 },
805 })
806
807 ctx.Build(pctx, android.BuildParams{
808 Rule: generateMetalavaRevertAnnotationsRule,
809 Input: releasedFlaggedApisFile,
810 Output: revertAnnotationsFile,
811 Description: fmt.Sprintf("%s revert annotations", stubsType),
812 })
Jihoon Kang3c89f042023-12-19 02:40:22 +0000813
814 cmd.FlagWithInput("@", revertAnnotationsFile)
Jihoon Kang6592e872023-12-19 01:13:16 +0000815}
816
Jihoon Kang3c89f042023-12-19 02:40:22 +0000817func (d *Droidstubs) commonMetalavaStubCmd(ctx android.ModuleContext, rule *android.RuleBuilder,
818 params stubsCommandParams) *android.RuleBuilderCommand {
Colin Cross2207f872021-03-24 12:39:08 -0700819 if BoolDefault(d.properties.High_mem, false) {
820 // This metalava run uses lots of memory, restrict the number of metalava jobs that can run in parallel.
821 rule.HighMem()
822 }
823
Jihoon Kang3c89f042023-12-19 02:40:22 +0000824 if params.stubConfig.generateStubs {
825 rule.Command().Text("rm -rf").Text(params.stubsDir.String())
826 rule.Command().Text("mkdir -p").Text(params.stubsDir.String())
Colin Cross2207f872021-03-24 12:39:08 -0700827 }
828
Jihoon Kang3c89f042023-12-19 02:40:22 +0000829 srcJarList := zipSyncCmd(ctx, rule, params.srcJarDir, d.Javadoc.srcJars)
Colin Cross2207f872021-03-24 12:39:08 -0700830
Jihoon Kang3c89f042023-12-19 02:40:22 +0000831 homeDir := android.PathForModuleOut(ctx, params.stubConfig.stubsType.String(), "home")
Paul Duffin27819362024-07-22 21:03:50 +0100832
833 configFiles := android.PathsForModuleSrc(ctx, d.properties.ConfigFiles)
834
835 cmd := metalavaCmd(ctx, rule, d.Javadoc.srcFiles, srcJarList, homeDir, params.stubConfig, configFiles)
Colin Cross2207f872021-03-24 12:39:08 -0700836 cmd.Implicits(d.Javadoc.implicits)
837
Jihoon Kang3c89f042023-12-19 02:40:22 +0000838 d.stubsFlags(ctx, cmd, params.stubsDir, params.stubConfig.stubsType, params.stubConfig.checkApi)
Colin Cross2207f872021-03-24 12:39:08 -0700839
Jihoon Kang3c89f042023-12-19 02:40:22 +0000840 if params.stubConfig.writeSdkValues {
841 d.sdkValuesFlags(ctx, cmd, params.metadataDir)
842 }
843
844 annotationParams := annotationFlagsParams{
845 migratingNullability: params.stubConfig.migratingNullability,
846 validatingNullability: params.stubConfig.validatingNullability,
847 nullabilityWarningsFile: params.nullabilityWarningsFile,
848 annotationsZip: params.annotationsZip,
849 }
850
Jihoon Kanga11d6792024-03-05 16:12:20 +0000851 d.annotationsFlags(ctx, cmd, annotationParams)
Colin Cross2207f872021-03-24 12:39:08 -0700852 d.inclusionAnnotationsFlags(ctx, cmd)
Jihoon Kanga11d6792024-03-05 16:12:20 +0000853 d.apiLevelsAnnotationsFlags(ctx, cmd, params.stubConfig.stubsType, params.apiVersionsXml)
Colin Cross2207f872021-03-24 12:39:08 -0700854
Jihoon Kang472f73f2024-03-28 20:59:29 +0000855 if params.stubConfig.doCheckReleased {
856 d.apiCompatibilityFlags(ctx, cmd, params.stubConfig.stubsType)
857 }
858
Colin Crossbc139922021-03-25 18:33:16 -0700859 d.expandArgs(ctx, cmd)
Colin Cross2207f872021-03-24 12:39:08 -0700860
Colin Cross2207f872021-03-24 12:39:08 -0700861 for _, o := range d.Javadoc.properties.Out {
862 cmd.ImplicitOutput(android.PathForModuleGen(ctx, o))
863 }
864
Jihoon Kang3c89f042023-12-19 02:40:22 +0000865 return cmd
866}
Colin Cross2207f872021-03-24 12:39:08 -0700867
Jihoon Kang3c89f042023-12-19 02:40:22 +0000868// Sandbox rule for generating the everything stubs and other artifacts
869func (d *Droidstubs) everythingStubCmd(ctx android.ModuleContext, params stubsCommandConfigParams) {
870 srcJarDir := android.PathForModuleOut(ctx, Everything.String(), "srcjars")
871 rule := android.NewRuleBuilder(pctx, ctx)
872 rule.Sbox(android.PathForModuleOut(ctx, Everything.String()),
873 android.PathForModuleOut(ctx, "metalava.sbox.textproto")).
874 SandboxInputs()
875
876 var stubsDir android.OptionalPath
877 if params.generateStubs {
878 stubsDir = android.OptionalPathForPath(android.PathForModuleOut(ctx, Everything.String(), "stubsDir"))
879 d.Javadoc.stubsSrcJar = android.PathForModuleOut(ctx, Everything.String(), ctx.ModuleName()+"-"+"stubs.srcjar")
880 }
881
882 if params.writeSdkValues {
Jihoon Kangee113282024-01-23 00:16:41 +0000883 d.everythingArtifacts.metadataDir = android.PathForModuleOut(ctx, Everything.String(), "metadata")
884 d.everythingArtifacts.metadataZip = android.PathForModuleOut(ctx, Everything.String(), ctx.ModuleName()+"-metadata.zip")
Jihoon Kang3c89f042023-12-19 02:40:22 +0000885 }
886
Jihoon Kanga11d6792024-03-05 16:12:20 +0000887 if Bool(d.properties.Annotations_enabled) {
Jihoon Kang3c89f042023-12-19 02:40:22 +0000888 if params.validatingNullability {
Jihoon Kangee113282024-01-23 00:16:41 +0000889 d.everythingArtifacts.nullabilityWarningsFile = android.PathForModuleOut(ctx, Everything.String(), ctx.ModuleName()+"_nullability_warnings.txt")
Jihoon Kang3c89f042023-12-19 02:40:22 +0000890 }
Jihoon Kangee113282024-01-23 00:16:41 +0000891 d.everythingArtifacts.annotationsZip = android.PathForModuleOut(ctx, Everything.String(), ctx.ModuleName()+"_annotations.zip")
Jihoon Kang3c89f042023-12-19 02:40:22 +0000892 }
Jihoon Kanga11d6792024-03-05 16:12:20 +0000893 if Bool(d.properties.Api_levels_annotations_enabled) {
Jihoon Kangee113282024-01-23 00:16:41 +0000894 d.everythingArtifacts.apiVersionsXml = android.PathForModuleOut(ctx, Everything.String(), "api-versions.xml")
Jihoon Kang3c89f042023-12-19 02:40:22 +0000895 }
896
897 commonCmdParams := stubsCommandParams{
898 srcJarDir: srcJarDir,
899 stubsDir: stubsDir,
900 stubsSrcJar: d.Javadoc.stubsSrcJar,
Jihoon Kangee113282024-01-23 00:16:41 +0000901 metadataDir: d.everythingArtifacts.metadataDir,
902 apiVersionsXml: d.everythingArtifacts.apiVersionsXml,
903 nullabilityWarningsFile: d.everythingArtifacts.nullabilityWarningsFile,
904 annotationsZip: d.everythingArtifacts.annotationsZip,
Jihoon Kang3c89f042023-12-19 02:40:22 +0000905 stubConfig: params,
906 }
907
908 cmd := d.commonMetalavaStubCmd(ctx, rule, commonCmdParams)
909
910 d.everythingOptionalCmd(ctx, cmd, params.doApiLint, params.doCheckReleased)
911
912 if params.generateStubs {
913 rule.Command().
914 BuiltTool("soong_zip").
915 Flag("-write_if_changed").
916 Flag("-jar").
917 FlagWithOutput("-o ", d.Javadoc.stubsSrcJar).
918 FlagWithArg("-C ", stubsDir.String()).
919 FlagWithArg("-D ", stubsDir.String())
920 }
921
922 if params.writeSdkValues {
923 rule.Command().
924 BuiltTool("soong_zip").
925 Flag("-write_if_changed").
926 Flag("-d").
Jihoon Kangee113282024-01-23 00:16:41 +0000927 FlagWithOutput("-o ", d.everythingArtifacts.metadataZip).
928 FlagWithArg("-C ", d.everythingArtifacts.metadataDir.String()).
929 FlagWithArg("-D ", d.everythingArtifacts.metadataDir.String())
Jihoon Kang3c89f042023-12-19 02:40:22 +0000930 }
931
932 // TODO: We don't really need two separate API files, but this is a reminiscence of how
933 // we used to run metalava separately for API lint and the "last_released" check. Unify them.
934 if params.doApiLint {
935 rule.Command().Text("touch").Output(d.apiLintTimestamp)
936 }
937 if params.doCheckReleased {
938 rule.Command().Text("touch").Output(d.checkLastReleasedApiTimestamp)
939 }
940
941 // TODO(b/183630617): rewrapper doesn't support restat rules
942 if !metalavaUseRbe(ctx) {
943 rule.Restat()
944 }
945
946 zipSyncCleanupCmd(rule, srcJarDir)
947
948 rule.Build("metalava", "metalava merged")
949}
950
951// Sandbox rule for generating the everything artifacts that are not run by
952// default but only run based on the module configurations
953func (d *Droidstubs) everythingOptionalCmd(ctx android.ModuleContext, cmd *android.RuleBuilderCommand, doApiLint bool, doCheckReleased bool) {
Colin Cross2207f872021-03-24 12:39:08 -0700954
955 // Add API lint options.
Paul Duffinbaf34782024-05-28 17:27:22 +0100956 treatDocumentationIssuesAsErrors := false
Jihoon Kang3c89f042023-12-19 02:40:22 +0000957 if doApiLint {
Jihoon Kang5623e542024-01-31 23:27:26 +0000958 var newSince android.Paths
959 if d.properties.Check_api.Api_lint.New_since != nil {
960 newSince = android.PathsForModuleSrc(ctx, []string{proptools.String(d.properties.Check_api.Api_lint.New_since)})
961 }
Paul Duffin0a71d732024-04-22 13:22:56 +0100962 cmd.Flag("--api-lint")
963 cmd.FlagForEachInput("--api-lint-previous-api ", newSince)
Jihoon Kang3c89f042023-12-19 02:40:22 +0000964 d.apiLintReport = android.PathForModuleOut(ctx, Everything.String(), "api_lint_report.txt")
Colin Cross2207f872021-03-24 12:39:08 -0700965 cmd.FlagWithOutput("--report-even-if-suppressed ", d.apiLintReport) // TODO: Change to ":api-lint"
966
Paul Duffinc540bee2024-08-29 15:35:58 +0100967 // If UnflaggedApi issues have not already been configured then make sure that existing
968 // UnflaggedApi issues are reported as warnings but issues in new/changed code are treated as
969 // errors by the Build Warnings Aye Aye Analyzer in Gerrit.
Paul Duffin88d3b392024-08-28 17:37:36 +0100970 // Once existing issues have been fixed this will be changed to error.
Paul Duffinc540bee2024-08-29 15:35:58 +0100971 // TODO(b/362771529): Switch to --error
972 if !strings.Contains(cmd.String(), " UnflaggedApi ") {
973 cmd.Flag("--error-when-new UnflaggedApi")
974 }
Paul Duffin88d3b392024-08-28 17:37:36 +0100975
Colin Cross0d532412021-03-25 09:38:45 -0700976 // TODO(b/154317059): Clean up this allowlist by baselining and/or checking in last-released.
Colin Cross2207f872021-03-24 12:39:08 -0700977 if d.Name() != "android.car-system-stubs-docs" &&
978 d.Name() != "android.car-stubs-docs" {
Paul Duffinbaf34782024-05-28 17:27:22 +0100979 treatDocumentationIssuesAsErrors = true
Colin Cross2207f872021-03-24 12:39:08 -0700980 cmd.Flag("--warnings-as-errors") // Most lints are actually warnings.
981 }
982
983 baselineFile := android.OptionalPathForModuleSrc(ctx, d.properties.Check_api.Api_lint.Baseline_file)
Jihoon Kang3c89f042023-12-19 02:40:22 +0000984 updatedBaselineOutput := android.PathForModuleOut(ctx, Everything.String(), "api_lint_baseline.txt")
985 d.apiLintTimestamp = android.PathForModuleOut(ctx, Everything.String(), "api_lint.timestamp")
Colin Cross2207f872021-03-24 12:39:08 -0700986
987 // Note this string includes a special shell quote $' ... ', which decodes the "\n"s.
Colin Cross2207f872021-03-24 12:39:08 -0700988 //
989 // TODO: metalava also has a slightly different message hardcoded. Should we unify this
990 // message and metalava's one?
991 msg := `$'` + // Enclose with $' ... '
992 `************************************************************\n` +
993 `Your API changes are triggering API Lint warnings or errors.\n` +
Colin Cross2207f872021-03-24 12:39:08 -0700994 `\n` +
Adrian Roos40be6472024-11-05 14:25:35 +0000995 `To make the failures go away:\n` +
Colin Cross2207f872021-03-24 12:39:08 -0700996 `\n` +
Adrian Roos40be6472024-11-05 14:25:35 +0000997 `1. REQUIRED: Read the messages carefully and address them by` +
998 ` fixing the API if appropriate.\n` +
999 `2. If the failure is a false positive, you can suppress it with:\n` +
1000 ` @SuppressLint("<id>")\n` +
Aurimas Liutikasb23b7452021-05-24 18:00:37 +00001001 ` where the <id> is given in brackets in the error message above.\n`
Colin Cross2207f872021-03-24 12:39:08 -07001002
1003 if baselineFile.Valid() {
1004 cmd.FlagWithInput("--baseline:api-lint ", baselineFile.Path())
1005 cmd.FlagWithOutput("--update-baseline:api-lint ", updatedBaselineOutput)
1006
1007 msg += fmt.Sprintf(``+
Cole Faust5146e782024-11-15 14:47:49 -08001008 `3. FOR LSC ONLY: You can update the baseline by executing\n`+
Adrian Roos40be6472024-11-05 14:25:35 +00001009 ` the following command:\n`+
Colin Cross63eeda02021-04-15 19:01:57 -07001010 ` (cd $ANDROID_BUILD_TOP && cp \\\n`+
1011 ` "%s" \\\n`+
1012 ` "%s")\n`+
Colin Cross2207f872021-03-24 12:39:08 -07001013 ` To submit the revised baseline.txt to the main Android\n`+
1014 ` repository, you will need approval.\n`, updatedBaselineOutput, baselineFile.Path())
1015 } else {
1016 msg += fmt.Sprintf(``+
Adrian Roos40be6472024-11-05 14:25:35 +00001017 `3. FOR LSC ONLY: You can add a baseline file of existing lint failures\n`+
Colin Cross2207f872021-03-24 12:39:08 -07001018 ` to the build rule of %s.\n`, d.Name())
1019 }
1020 // Note the message ends with a ' (single quote), to close the $' ... ' .
1021 msg += `************************************************************\n'`
1022
1023 cmd.FlagWithArg("--error-message:api-lint ", msg)
1024 }
1025
Paul Duffinbaf34782024-05-28 17:27:22 +01001026 if !treatDocumentationIssuesAsErrors {
Paul Duffinb679bdd2024-06-10 14:29:41 +01001027 treatDocumentationIssuesAsWarningErrorWhenNew(cmd)
Paul Duffinbaf34782024-05-28 17:27:22 +01001028 }
1029
Colin Cross2207f872021-03-24 12:39:08 -07001030 // Add "check released" options. (Detect incompatible API changes from the last public release)
Jihoon Kang3c89f042023-12-19 02:40:22 +00001031 if doCheckReleased {
Colin Cross2207f872021-03-24 12:39:08 -07001032 baselineFile := android.OptionalPathForModuleSrc(ctx, d.properties.Check_api.Last_released.Baseline_file)
Jihoon Kang3c89f042023-12-19 02:40:22 +00001033 d.checkLastReleasedApiTimestamp = android.PathForModuleOut(ctx, Everything.String(), "check_last_released_api.timestamp")
Colin Cross2207f872021-03-24 12:39:08 -07001034 if baselineFile.Valid() {
Jihoon Kang472f73f2024-03-28 20:59:29 +00001035 updatedBaselineOutput := android.PathForModuleOut(ctx, Everything.String(), "last_released_baseline.txt")
Colin Cross2207f872021-03-24 12:39:08 -07001036 cmd.FlagWithOutput("--update-baseline:compatibility:released ", updatedBaselineOutput)
1037 }
Colin Cross2207f872021-03-24 12:39:08 -07001038 // Note this string includes quote ($' ... '), which decodes the "\n"s.
1039 msg := `$'\n******************************\n` +
1040 `You have tried to change the API from what has been previously released in\n` +
1041 `an SDK. Please fix the errors listed above.\n` +
1042 `******************************\n'`
1043
1044 cmd.FlagWithArg("--error-message:compatibility:released ", msg)
1045 }
1046
Paul Duffin10a23c22023-08-11 22:47:31 +01001047 if apiCheckEnabled(ctx, d.properties.Check_api.Current, "current") {
1048 // Pass the current API file into metalava so it can use it as the basis for determining how to
1049 // generate the output signature files (both api and removed).
1050 currentApiFile := android.PathForModuleSrc(ctx, String(d.properties.Check_api.Current.Api_file))
1051 cmd.FlagWithInput("--use-same-format-as ", currentApiFile)
1052 }
Jihoon Kang3c89f042023-12-19 02:40:22 +00001053}
Paul Duffin10a23c22023-08-11 22:47:31 +01001054
Paul Duffinb679bdd2024-06-10 14:29:41 +01001055// HIDDEN_DOCUMENTATION_ISSUES is the set of documentation related issues that should always be
1056// hidden as they are very noisy and provide little value.
1057var HIDDEN_DOCUMENTATION_ISSUES = []string{
1058 "Deprecated",
1059 "IntDef",
1060 "Nullable",
1061}
1062
1063func treatDocumentationIssuesAsWarningErrorWhenNew(cmd *android.RuleBuilderCommand) {
1064 // Treat documentation issues as warnings, but error when new.
1065 cmd.Flag("--error-when-new-category").Flag("Documentation")
1066
1067 // Hide some documentation issues that generated a lot of noise for little benefit.
1068 cmd.FlagForEachArg("--hide ", HIDDEN_DOCUMENTATION_ISSUES)
1069}
1070
Jihoon Kang3c89f042023-12-19 02:40:22 +00001071// Sandbox rule for generating exportable stubs and other artifacts
1072func (d *Droidstubs) exportableStubCmd(ctx android.ModuleContext, params stubsCommandConfigParams) {
1073 optionalCmdParams := stubsCommandParams{
1074 stubConfig: params,
1075 }
1076
Jihoon Kang246690a2024-02-01 21:55:01 +00001077 if params.generateStubs {
1078 d.Javadoc.exportableStubsSrcJar = android.PathForModuleOut(ctx, params.stubsType.String(), ctx.ModuleName()+"-"+"stubs.srcjar")
1079 optionalCmdParams.stubsSrcJar = d.Javadoc.exportableStubsSrcJar
1080 }
1081
Jihoon Kang3c89f042023-12-19 02:40:22 +00001082 if params.writeSdkValues {
Jihoon Kangee113282024-01-23 00:16:41 +00001083 d.exportableArtifacts.metadataZip = android.PathForModuleOut(ctx, params.stubsType.String(), ctx.ModuleName()+"-metadata.zip")
1084 d.exportableArtifacts.metadataDir = android.PathForModuleOut(ctx, params.stubsType.String(), "metadata")
1085 optionalCmdParams.metadataZip = d.exportableArtifacts.metadataZip
1086 optionalCmdParams.metadataDir = d.exportableArtifacts.metadataDir
Jihoon Kang3c89f042023-12-19 02:40:22 +00001087 }
1088
Jihoon Kanga11d6792024-03-05 16:12:20 +00001089 if Bool(d.properties.Annotations_enabled) {
Jihoon Kang3c89f042023-12-19 02:40:22 +00001090 if params.validatingNullability {
Jihoon Kangee113282024-01-23 00:16:41 +00001091 d.exportableArtifacts.nullabilityWarningsFile = android.PathForModuleOut(ctx, params.stubsType.String(), ctx.ModuleName()+"_nullability_warnings.txt")
1092 optionalCmdParams.nullabilityWarningsFile = d.exportableArtifacts.nullabilityWarningsFile
Jihoon Kang3c89f042023-12-19 02:40:22 +00001093 }
Jihoon Kangee113282024-01-23 00:16:41 +00001094 d.exportableArtifacts.annotationsZip = android.PathForModuleOut(ctx, params.stubsType.String(), ctx.ModuleName()+"_annotations.zip")
1095 optionalCmdParams.annotationsZip = d.exportableArtifacts.annotationsZip
Jihoon Kang3c89f042023-12-19 02:40:22 +00001096 }
Jihoon Kanga11d6792024-03-05 16:12:20 +00001097 if Bool(d.properties.Api_levels_annotations_enabled) {
Jihoon Kangee113282024-01-23 00:16:41 +00001098 d.exportableArtifacts.apiVersionsXml = android.PathForModuleOut(ctx, params.stubsType.String(), "api-versions.xml")
1099 optionalCmdParams.apiVersionsXml = d.exportableArtifacts.apiVersionsXml
Jihoon Kang3c89f042023-12-19 02:40:22 +00001100 }
1101
1102 if params.checkApi || String(d.properties.Api_filename) != "" {
1103 filename := proptools.StringDefault(d.properties.Api_filename, ctx.ModuleName()+"_api.txt")
1104 d.exportableApiFile = android.PathForModuleOut(ctx, params.stubsType.String(), filename)
1105 }
1106
1107 if params.checkApi || String(d.properties.Removed_api_filename) != "" {
1108 filename := proptools.StringDefault(d.properties.Removed_api_filename, ctx.ModuleName()+"_api.txt")
1109 d.exportableRemovedApiFile = android.PathForModuleOut(ctx, params.stubsType.String(), filename)
1110 }
1111
1112 d.optionalStubCmd(ctx, optionalCmdParams)
1113}
1114
1115func (d *Droidstubs) optionalStubCmd(ctx android.ModuleContext, params stubsCommandParams) {
1116
1117 params.srcJarDir = android.PathForModuleOut(ctx, params.stubConfig.stubsType.String(), "srcjars")
1118 rule := android.NewRuleBuilder(pctx, ctx)
1119 rule.Sbox(android.PathForModuleOut(ctx, params.stubConfig.stubsType.String()),
1120 android.PathForModuleOut(ctx, fmt.Sprintf("metalava_%s.sbox.textproto", params.stubConfig.stubsType.String()))).
1121 SandboxInputs()
1122
1123 if params.stubConfig.generateStubs {
1124 params.stubsDir = android.OptionalPathForPath(android.PathForModuleOut(ctx, params.stubConfig.stubsType.String(), "stubsDir"))
1125 }
1126
1127 cmd := d.commonMetalavaStubCmd(ctx, rule, params)
1128
Jihoon Kang5d701272024-02-15 21:53:49 +00001129 generateRevertAnnotationArgs(ctx, cmd, params.stubConfig.stubsType, params.stubConfig.deps.aconfigProtoFiles)
Jihoon Kang3c89f042023-12-19 02:40:22 +00001130
1131 if params.stubConfig.doApiLint {
1132 // Pass the lint baseline file as an input to resolve the lint errors.
1133 // The exportable stubs generation does not update the lint baseline file.
1134 // Lint baseline file update is handled by the everything stubs
1135 baselineFile := android.OptionalPathForModuleSrc(ctx, d.properties.Check_api.Api_lint.Baseline_file)
1136 if baselineFile.Valid() {
1137 cmd.FlagWithInput("--baseline:api-lint ", baselineFile.Path())
1138 }
1139 }
1140
Paul Duffin71527b72024-05-31 13:30:32 +01001141 // Treat documentation issues as warnings, but error when new.
Paul Duffinb679bdd2024-06-10 14:29:41 +01001142 treatDocumentationIssuesAsWarningErrorWhenNew(cmd)
Paul Duffin71527b72024-05-31 13:30:32 +01001143
Jihoon Kang3c89f042023-12-19 02:40:22 +00001144 if params.stubConfig.generateStubs {
Colin Cross2207f872021-03-24 12:39:08 -07001145 rule.Command().
1146 BuiltTool("soong_zip").
1147 Flag("-write_if_changed").
1148 Flag("-jar").
Jihoon Kang3c89f042023-12-19 02:40:22 +00001149 FlagWithOutput("-o ", params.stubsSrcJar).
1150 FlagWithArg("-C ", params.stubsDir.String()).
1151 FlagWithArg("-D ", params.stubsDir.String())
Colin Cross2207f872021-03-24 12:39:08 -07001152 }
1153
Jihoon Kang3c89f042023-12-19 02:40:22 +00001154 if params.stubConfig.writeSdkValues {
Colin Cross2207f872021-03-24 12:39:08 -07001155 rule.Command().
1156 BuiltTool("soong_zip").
1157 Flag("-write_if_changed").
1158 Flag("-d").
Jihoon Kang3c89f042023-12-19 02:40:22 +00001159 FlagWithOutput("-o ", params.metadataZip).
1160 FlagWithArg("-C ", params.metadataDir.String()).
1161 FlagWithArg("-D ", params.metadataDir.String())
Colin Cross2207f872021-03-24 12:39:08 -07001162 }
1163
Colin Cross6aa5c402021-03-24 12:28:50 -07001164 // TODO(b/183630617): rewrapper doesn't support restat rules
Colin Crosse52c2ac2022-03-28 17:03:35 -07001165 if !metalavaUseRbe(ctx) {
1166 rule.Restat()
1167 }
Colin Cross2207f872021-03-24 12:39:08 -07001168
Jihoon Kang3c89f042023-12-19 02:40:22 +00001169 zipSyncCleanupCmd(rule, params.srcJarDir)
Colin Cross2207f872021-03-24 12:39:08 -07001170
Jihoon Kang3c89f042023-12-19 02:40:22 +00001171 rule.Build(fmt.Sprintf("metalava_%s", params.stubConfig.stubsType.String()), "metalava merged")
1172}
1173
1174func (d *Droidstubs) GenerateAndroidBuildActions(ctx android.ModuleContext) {
1175 deps := d.Javadoc.collectDeps(ctx)
1176
1177 javaVersion := getJavaVersion(ctx, String(d.Javadoc.properties.Java_version), android.SdkContext(d))
1178 generateStubs := BoolDefault(d.properties.Generate_stubs, true)
1179
1180 // Add options for the other optional tasks: API-lint and check-released.
1181 // We generate separate timestamp files for them.
1182 doApiLint := BoolDefault(d.properties.Check_api.Api_lint.Enabled, false)
1183 doCheckReleased := apiCheckEnabled(ctx, d.properties.Check_api.Last_released, "last_released")
1184
1185 writeSdkValues := Bool(d.properties.Write_sdk_values)
1186
1187 annotationsEnabled := Bool(d.properties.Annotations_enabled)
1188
1189 migratingNullability := annotationsEnabled && String(d.properties.Previous_api) != ""
1190 validatingNullability := annotationsEnabled && (strings.Contains(String(d.Javadoc.properties.Args), "--validate-nullability-from-merged-stubs") ||
1191 String(d.properties.Validate_nullability_from_list) != "")
1192
1193 checkApi := apiCheckEnabled(ctx, d.properties.Check_api.Current, "current") ||
1194 apiCheckEnabled(ctx, d.properties.Check_api.Last_released, "last_released")
1195
1196 stubCmdParams := stubsCommandConfigParams{
Jihoon Kanga11d6792024-03-05 16:12:20 +00001197 javaVersion: javaVersion,
1198 deps: deps,
1199 checkApi: checkApi,
1200 generateStubs: generateStubs,
1201 doApiLint: doApiLint,
1202 doCheckReleased: doCheckReleased,
1203 writeSdkValues: writeSdkValues,
1204 migratingNullability: migratingNullability,
1205 validatingNullability: validatingNullability,
Jihoon Kang3c89f042023-12-19 02:40:22 +00001206 }
1207 stubCmdParams.stubsType = Everything
1208 // Create default (i.e. "everything" stubs) rule for metalava
1209 d.everythingStubCmd(ctx, stubCmdParams)
1210
Jihoon Kangd40c5912024-03-05 16:12:20 +00001211 // The module generates "exportable" (and "runtime" eventually) stubs regardless of whether
Jihoon Kang3c89f042023-12-19 02:40:22 +00001212 // aconfig_declarations property is defined or not. If the property is not defined, the module simply
1213 // strips all flagged apis to generate the "exportable" stubs
1214 stubCmdParams.stubsType = Exportable
1215 d.exportableStubCmd(ctx, stubCmdParams)
Paul Duffinc166b682022-05-27 12:23:08 +00001216
Paul Duffine7a86642022-08-16 15:43:20 +00001217 if apiCheckEnabled(ctx, d.properties.Check_api.Current, "current") {
1218
1219 if len(d.Javadoc.properties.Out) > 0 {
1220 ctx.PropertyErrorf("out", "out property may not be combined with check_api")
1221 }
1222
1223 apiFile := android.PathForModuleSrc(ctx, String(d.properties.Check_api.Current.Api_file))
1224 removedApiFile := android.PathForModuleSrc(ctx, String(d.properties.Check_api.Current.Removed_api_file))
1225 baselineFile := android.OptionalPathForModuleSrc(ctx, d.properties.Check_api.Current.Baseline_file)
1226
1227 if baselineFile.Valid() {
1228 ctx.PropertyErrorf("baseline_file", "current API check can't have a baseline file. (module %s)", ctx.ModuleName())
1229 }
1230
Jihoon Kang3c89f042023-12-19 02:40:22 +00001231 d.checkCurrentApiTimestamp = android.PathForModuleOut(ctx, Everything.String(), "check_current_api.timestamp")
Paul Duffine7a86642022-08-16 15:43:20 +00001232
1233 rule := android.NewRuleBuilder(pctx, ctx)
1234
1235 // Diff command line.
1236 // -F matches the closest "opening" line, such as "package android {"
1237 // and " public class Intent {".
1238 diff := `diff -u -F '{ *$'`
1239
1240 rule.Command().Text("( true")
1241 rule.Command().
1242 Text(diff).
1243 Input(apiFile).Input(d.apiFile)
1244
1245 rule.Command().
1246 Text(diff).
1247 Input(removedApiFile).Input(d.removedApiFile)
1248
1249 msg := fmt.Sprintf(`\n******************************\n`+
1250 `You have tried to change the API from what has been previously approved.\n\n`+
1251 `To make these errors go away, you have two choices:\n`+
1252 ` 1. You can add '@hide' javadoc comments (and remove @SystemApi/@TestApi/etc)\n`+
1253 ` to the new methods, etc. shown in the above diff.\n\n`+
1254 ` 2. You can update current.txt and/or removed.txt by executing the following command:\n`+
1255 ` m %s-update-current-api\n\n`+
1256 ` To submit the revised current.txt to the main Android repository,\n`+
1257 ` you will need approval.\n`+
Jihoon Kang3ea64672023-11-03 00:40:26 +00001258 `If your build failed due to stub validation, you can resolve the errors with\n`+
1259 `either of the two choices above and try re-building the target.\n`+
1260 `If the mismatch between the stubs and the current.txt is intended,\n`+
1261 `you can try re-building the target by executing the following command:\n`+
Jihoon Kang91bf3dd2024-01-24 00:40:23 +00001262 `m DISABLE_STUB_VALIDATION=true <your build target>.\n`+
1263 `Note that DISABLE_STUB_VALIDATION=true does not bypass checkapi.\n`+
Paul Duffine7a86642022-08-16 15:43:20 +00001264 `******************************\n`, ctx.ModuleName())
1265
1266 rule.Command().
1267 Text("touch").Output(d.checkCurrentApiTimestamp).
1268 Text(") || (").
1269 Text("echo").Flag("-e").Flag(`"` + msg + `"`).
1270 Text("; exit 38").
1271 Text(")")
1272
1273 rule.Build("metalavaCurrentApiCheck", "check current API")
1274
Jihoon Kang3c89f042023-12-19 02:40:22 +00001275 d.updateCurrentApiTimestamp = android.PathForModuleOut(ctx, Everything.String(), "update_current_api.timestamp")
Paul Duffine7a86642022-08-16 15:43:20 +00001276
1277 // update API rule
1278 rule = android.NewRuleBuilder(pctx, ctx)
1279
1280 rule.Command().Text("( true")
1281
1282 rule.Command().
1283 Text("cp").Flag("-f").
1284 Input(d.apiFile).Flag(apiFile.String())
1285
1286 rule.Command().
1287 Text("cp").Flag("-f").
1288 Input(d.removedApiFile).Flag(removedApiFile.String())
1289
1290 msg = "failed to update public API"
1291
1292 rule.Command().
1293 Text("touch").Output(d.updateCurrentApiTimestamp).
1294 Text(") || (").
1295 Text("echo").Flag("-e").Flag(`"` + msg + `"`).
1296 Text("; exit 38").
1297 Text(")")
1298
1299 rule.Build("metalavaCurrentApiUpdate", "update current API")
1300 }
1301
Colin Cross2207f872021-03-24 12:39:08 -07001302 if String(d.properties.Check_nullability_warnings) != "" {
Jihoon Kangee113282024-01-23 00:16:41 +00001303 if d.everythingArtifacts.nullabilityWarningsFile == nil {
Colin Cross2207f872021-03-24 12:39:08 -07001304 ctx.PropertyErrorf("check_nullability_warnings",
1305 "Cannot specify check_nullability_warnings unless validating nullability")
1306 }
1307
1308 checkNullabilityWarnings := android.PathForModuleSrc(ctx, String(d.properties.Check_nullability_warnings))
1309
Jihoon Kang3c89f042023-12-19 02:40:22 +00001310 d.checkNullabilityWarningsTimestamp = android.PathForModuleOut(ctx, Everything.String(), "check_nullability_warnings.timestamp")
Colin Cross2207f872021-03-24 12:39:08 -07001311
1312 msg := fmt.Sprintf(`\n******************************\n`+
1313 `The warnings encountered during nullability annotation validation did\n`+
1314 `not match the checked in file of expected warnings. The diffs are shown\n`+
1315 `above. You have two options:\n`+
1316 ` 1. Resolve the differences by editing the nullability annotations.\n`+
1317 ` 2. Update the file of expected warnings by running:\n`+
1318 ` cp %s %s\n`+
1319 ` and submitting the updated file as part of your change.`,
Jihoon Kangee113282024-01-23 00:16:41 +00001320 d.everythingArtifacts.nullabilityWarningsFile, checkNullabilityWarnings)
Colin Cross2207f872021-03-24 12:39:08 -07001321
1322 rule := android.NewRuleBuilder(pctx, ctx)
1323
1324 rule.Command().
1325 Text("(").
Jihoon Kangee113282024-01-23 00:16:41 +00001326 Text("diff").Input(checkNullabilityWarnings).Input(d.everythingArtifacts.nullabilityWarningsFile).
Colin Cross2207f872021-03-24 12:39:08 -07001327 Text("&&").
1328 Text("touch").Output(d.checkNullabilityWarningsTimestamp).
1329 Text(") || (").
1330 Text("echo").Flag("-e").Flag(`"` + msg + `"`).
1331 Text("; exit 38").
1332 Text(")")
1333
1334 rule.Build("nullabilityWarningsCheck", "nullability warnings check")
1335 }
mrziwang39e68ff2024-07-01 16:35:32 -07001336
1337 d.setOutputFiles(ctx)
1338}
1339
1340// This method sets the outputFiles property, which is used to set the
1341// OutputFilesProvider later.
1342// Droidstubs' tag supports specifying with the stubs type.
1343// While supporting the pre-existing tags, it also supports tags with
1344// the stubs type prefix. Some examples are shown below:
1345// {.annotations.zip} - pre-existing behavior. Returns the path to the
1346// annotation zip.
1347// {.exportable} - Returns the path to the exportable stubs src jar.
1348// {.exportable.annotations.zip} - Returns the path to the exportable
1349// annotations zip file.
1350// {.runtime.api_versions.xml} - Runtime stubs does not generate api versions
1351// xml file. For unsupported combinations, the default everything output file
1352// is returned.
1353func (d *Droidstubs) setOutputFiles(ctx android.ModuleContext) {
1354 tagToOutputFileFunc := map[string]func(StubsType) (android.Path, error){
1355 "": d.StubsSrcJar,
1356 ".docs.zip": d.DocZip,
1357 ".api.txt": d.ApiFilePath,
1358 android.DefaultDistTag: d.ApiFilePath,
1359 ".removed-api.txt": d.RemovedApiFilePath,
1360 ".annotations.zip": d.AnnotationsZip,
1361 ".api_versions.xml": d.ApiVersionsXmlFilePath,
1362 }
1363 stubsTypeToPrefix := map[StubsType]string{
1364 Everything: "",
1365 Exportable: ".exportable",
1366 }
1367 for _, tag := range android.SortedKeys(tagToOutputFileFunc) {
1368 for _, stubType := range android.SortedKeys(stubsTypeToPrefix) {
1369 tagWithPrefix := stubsTypeToPrefix[stubType] + tag
1370 outputFile, err := tagToOutputFileFunc[tag](stubType)
Cole Faust5146e782024-11-15 14:47:49 -08001371 if err == nil && outputFile != nil {
mrziwang39e68ff2024-07-01 16:35:32 -07001372 ctx.SetOutputFiles(android.Paths{outputFile}, tagWithPrefix)
1373 }
1374 }
1375 }
Colin Cross2207f872021-03-24 12:39:08 -07001376}
1377
Jihoon Kang3198f3c2023-01-26 08:08:52 +00001378func (d *Droidstubs) createApiContribution(ctx android.DefaultableHookContext) {
1379 api_file := d.properties.Check_api.Current.Api_file
1380 api_surface := d.properties.Api_surface
1381
1382 props := struct {
1383 Name *string
1384 Api_surface *string
1385 Api_file *string
Jihoon Kang42b589c2023-02-03 22:56:13 +00001386 Visibility []string
Jihoon Kang3198f3c2023-01-26 08:08:52 +00001387 }{}
1388
1389 props.Name = proptools.StringPtr(d.Name() + ".api.contribution")
1390 props.Api_surface = api_surface
1391 props.Api_file = api_file
Jihoon Kang42b589c2023-02-03 22:56:13 +00001392 props.Visibility = []string{"//visibility:override", "//visibility:public"}
Jihoon Kang3198f3c2023-01-26 08:08:52 +00001393
1394 ctx.CreateModule(ApiContributionFactory, &props)
1395}
1396
Spandan Das0b555e32022-11-28 18:48:51 +00001397// TODO (b/262014796): Export the API contributions of CorePlatformApi
1398// A map to populate the api surface of a droidstub from a substring appearing in its name
1399// This map assumes that droidstubs (either checked-in or created by java_sdk_library)
1400// use a strict naming convention
1401var (
1402 droidstubsModuleNamingToSdkKind = map[string]android.SdkKind{
Paul Duffin2ced2eb2024-05-01 13:13:51 +01001403 // public is commented out since the core libraries use public in their java_sdk_library names
Spandan Das0b555e32022-11-28 18:48:51 +00001404 "intracore": android.SdkIntraCore,
1405 "intra.core": android.SdkIntraCore,
1406 "system_server": android.SdkSystemServer,
1407 "system-server": android.SdkSystemServer,
1408 "system": android.SdkSystem,
1409 "module_lib": android.SdkModule,
1410 "module-lib": android.SdkModule,
Spandan Dasda977552023-01-26 20:45:16 +00001411 "platform.api": android.SdkCorePlatform,
Spandan Das0b555e32022-11-28 18:48:51 +00001412 "test": android.SdkTest,
Spandan Das4ac2aed2022-12-28 01:54:29 +00001413 "toolchain": android.SdkToolchain,
Spandan Das0b555e32022-11-28 18:48:51 +00001414 }
1415)
1416
Colin Cross2207f872021-03-24 12:39:08 -07001417func StubsDefaultsFactory() android.Module {
1418 module := &DocDefaults{}
1419
1420 module.AddProperties(
1421 &JavadocProperties{},
1422 &DroidstubsProperties{},
1423 )
1424
1425 android.InitDefaultsModule(module)
1426
1427 return module
1428}
1429
1430var _ android.PrebuiltInterface = (*PrebuiltStubsSources)(nil)
1431
1432type PrebuiltStubsSourcesProperties struct {
1433 Srcs []string `android:"path"`
Spandan Das23956d12024-01-19 00:22:22 +00001434
1435 // Name of the source soong module that gets shadowed by this prebuilt
1436 // If unspecified, follows the naming convention that the source module of
1437 // the prebuilt is Name() without "prebuilt_" prefix
1438 Source_module_name *string
1439
1440 // Non-nil if this prebuilt stub srcs module was dynamically created by a java_sdk_library_import
1441 // The name is the undecorated name of the java_sdk_library as it appears in the blueprint file
1442 // (without any prebuilt_ prefix)
1443 Created_by_java_sdk_library_name *string `blueprint:"mutated"`
1444}
1445
1446func (j *PrebuiltStubsSources) BaseModuleName() string {
1447 return proptools.StringDefault(j.properties.Source_module_name, j.ModuleBase.Name())
1448}
1449
1450func (j *PrebuiltStubsSources) CreatedByJavaSdkLibraryName() *string {
1451 return j.properties.Created_by_java_sdk_library_name
Colin Cross2207f872021-03-24 12:39:08 -07001452}
1453
1454type PrebuiltStubsSources struct {
1455 android.ModuleBase
1456 android.DefaultableModuleBase
Spandan Das2cc80ba2023-10-27 17:21:52 +00001457 embeddableInModuleAndImport
1458
Colin Cross2207f872021-03-24 12:39:08 -07001459 prebuilt android.Prebuilt
Colin Cross2207f872021-03-24 12:39:08 -07001460
1461 properties PrebuiltStubsSourcesProperties
1462
kgui67007242022-01-25 13:50:25 +08001463 stubsSrcJar android.Path
Colin Cross2207f872021-03-24 12:39:08 -07001464}
1465
Jihoon Kangee113282024-01-23 00:16:41 +00001466func (d *PrebuiltStubsSources) StubsSrcJar(_ StubsType) (android.Path, error) {
1467 return d.stubsSrcJar, nil
Colin Cross2207f872021-03-24 12:39:08 -07001468}
1469
1470func (p *PrebuiltStubsSources) GenerateAndroidBuildActions(ctx android.ModuleContext) {
Colin Cross2207f872021-03-24 12:39:08 -07001471 if len(p.properties.Srcs) != 1 {
Anton Hansson86758ac2021-11-03 14:44:12 +00001472 ctx.PropertyErrorf("srcs", "must only specify one directory path or srcjar, contains %d paths", len(p.properties.Srcs))
Colin Cross2207f872021-03-24 12:39:08 -07001473 return
1474 }
1475
Anton Hansson86758ac2021-11-03 14:44:12 +00001476 src := p.properties.Srcs[0]
1477 if filepath.Ext(src) == ".srcjar" {
1478 // This is a srcjar. We can use it directly.
1479 p.stubsSrcJar = android.PathForModuleSrc(ctx, src)
1480 } else {
1481 outPath := android.PathForModuleOut(ctx, ctx.ModuleName()+"-"+"stubs.srcjar")
Colin Cross2207f872021-03-24 12:39:08 -07001482
Anton Hansson86758ac2021-11-03 14:44:12 +00001483 // This is a directory. Glob the contents just in case the directory does not exist.
1484 srcGlob := src + "/**/*"
1485 srcPaths := android.PathsForModuleSrc(ctx, []string{srcGlob})
Colin Cross2207f872021-03-24 12:39:08 -07001486
Anton Hansson86758ac2021-11-03 14:44:12 +00001487 // Although PathForModuleSrc can return nil if either the path doesn't exist or
1488 // the path components are invalid it won't in this case because no components
1489 // are specified and the module directory must exist in order to get this far.
1490 srcDir := android.PathForModuleSrc(ctx).(android.SourcePath).Join(ctx, src)
Colin Cross2207f872021-03-24 12:39:08 -07001491
Anton Hansson86758ac2021-11-03 14:44:12 +00001492 rule := android.NewRuleBuilder(pctx, ctx)
1493 rule.Command().
1494 BuiltTool("soong_zip").
1495 Flag("-write_if_changed").
1496 Flag("-jar").
1497 FlagWithOutput("-o ", outPath).
1498 FlagWithArg("-C ", srcDir.String()).
1499 FlagWithRspFileInputList("-r ", outPath.ReplaceExtension(ctx, "rsp"), srcPaths)
1500 rule.Restat()
1501 rule.Build("zip src", "Create srcjar from prebuilt source")
1502 p.stubsSrcJar = outPath
1503 }
mrziwangaa2a2b62024-07-01 12:09:20 -07001504
1505 ctx.SetOutputFiles(android.Paths{p.stubsSrcJar}, "")
1506 // prebuilt droidstubs does not output "exportable" stubs.
1507 // Output the "everything" stubs srcjar file if the tag is ".exportable".
1508 ctx.SetOutputFiles(android.Paths{p.stubsSrcJar}, ".exportable")
Colin Cross2207f872021-03-24 12:39:08 -07001509}
1510
1511func (p *PrebuiltStubsSources) Prebuilt() *android.Prebuilt {
1512 return &p.prebuilt
1513}
1514
1515func (p *PrebuiltStubsSources) Name() string {
1516 return p.prebuilt.Name(p.ModuleBase.Name())
1517}
1518
1519// prebuilt_stubs_sources imports a set of java source files as if they were
1520// generated by droidstubs.
1521//
1522// By default, a prebuilt_stubs_sources has a single variant that expects a
1523// set of `.java` files generated by droidstubs.
1524//
1525// Specifying `host_supported: true` will produce two variants, one for use as a dependency of device modules and one
1526// for host modules.
1527//
1528// Intended only for use by sdk snapshots.
1529func PrebuiltStubsSourcesFactory() android.Module {
1530 module := &PrebuiltStubsSources{}
1531
1532 module.AddProperties(&module.properties)
Spandan Das2cc80ba2023-10-27 17:21:52 +00001533 module.initModuleAndImport(module)
Colin Cross2207f872021-03-24 12:39:08 -07001534
1535 android.InitPrebuiltModule(module, &module.properties.Srcs)
Colin Cross2207f872021-03-24 12:39:08 -07001536 InitDroiddocModule(module, android.HostAndDeviceSupported)
1537 return module
1538}