blob: d2117849dd01d581087434fb13bff35e70a13e2f [file] [log] [blame]
Steven Moreland65b3fd92017-12-06 14:18:35 -08001// Copyright 2017 Google Inc. All rights reserved.
2//
3// Licensed under the Apache License, Version 2.0 (the "License");
4// you may not use this file except in compliance with the License.
5// You may obtain a copy of the License at
6//
7// http://www.apache.org/licenses/LICENSE-2.0
8//
9// Unless required by applicable law or agreed to in writing, software
10// distributed under the License is distributed on an "AS IS" BASIS,
11// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
12// See the License for the specific language governing permissions and
13// limitations under the License.
14
15package android
16
17import (
Liz Kammera3d79152021-10-28 18:14:04 -040018 "fmt"
Steven Moreland65b3fd92017-12-06 14:18:35 -080019 "path/filepath"
20 "reflect"
Anton Hansson45376402020-04-09 14:18:21 +010021 "regexp"
Steven Moreland65b3fd92017-12-06 14:18:35 -080022 "strconv"
23 "strings"
24
25 "github.com/google/blueprint/proptools"
26)
27
28// "neverallow" rules for the build system.
29//
30// This allows things which aren't related to the build system and are enforced
Joe Onoratob4638c12021-10-27 15:47:06 -070031// against assumptions, in progress code refactors, or policy to be expressed in a
Steven Moreland65b3fd92017-12-06 14:18:35 -080032// straightforward away disjoint from implementations and tests which should
33// work regardless of these restrictions.
34//
35// A module is disallowed if all of the following are true:
Paul Duffin730f2a52019-06-27 14:08:51 +010036// - it is in one of the "In" paths
37// - it is not in one of the "NotIn" paths
38// - it has all "With" properties matched
Steven Moreland65b3fd92017-12-06 14:18:35 -080039// - - values are matched in their entirety
40// - - nil is interpreted as an empty string
41// - - nested properties are separated with a '.'
42// - - if the property is a list, any of the values in the list being matches
43// counts as a match
Paul Duffin730f2a52019-06-27 14:08:51 +010044// - it has none of the "Without" properties matched (same rules as above)
Steven Moreland65b3fd92017-12-06 14:18:35 -080045
Paul Duffin45338f02021-03-30 23:07:52 +010046func registerNeverallowMutator(ctx RegisterMutatorsContext) {
Colin Cross8a962802024-10-09 15:29:27 -070047 ctx.BottomUp("neverallow", neverallowMutator)
Steven Moreland65b3fd92017-12-06 14:18:35 -080048}
49
Paul Duffin730f2a52019-06-27 14:08:51 +010050var neverallows = []Rule{}
Steven Moreland65b3fd92017-12-06 14:18:35 -080051
Paul Duffin730f2a52019-06-27 14:08:51 +010052func init() {
Paul Duffinc8111702019-07-22 12:13:55 +010053 AddNeverAllowRules(createIncludeDirsRules()...)
Paul Duffin730f2a52019-06-27 14:08:51 +010054 AddNeverAllowRules(createTrebleRules()...)
Paul Duffin730f2a52019-06-27 14:08:51 +010055 AddNeverAllowRules(createJavaDeviceForHostRules()...)
Colin Crossc511bc52020-04-07 16:50:32 +000056 AddNeverAllowRules(createCcSdkVariantRules()...)
David Srbeckye033cba2020-05-20 22:20:28 +010057 AddNeverAllowRules(createUncompressDexRules()...)
Nelson Li43808202024-11-20 09:05:53 +000058 AddNeverAllowRules(createInstallInRootAllowingRules()...)
Jiyong Park3c306f32022-04-05 15:29:53 +090059 AddNeverAllowRules(createProhibitFrameworkAccessRules()...)
Alan Stokes73feba32022-11-14 12:21:24 +000060 AddNeverAllowRules(createCcStubsRule())
Mark Whitea15790a2023-08-22 21:28:11 +000061 AddNeverAllowRules(createProhibitHeaderOnlyRule())
Steven Moreland0db999c2024-09-03 22:06:24 +000062 AddNeverAllowRules(createLimitNdkExportRule()...)
Inseob Kim76e19852024-10-10 17:57:22 +090063 AddNeverAllowRules(createLimitDirgroupRule()...)
Jihoon Kang0d545b82024-10-11 00:21:57 +000064 AddNeverAllowRules(createFilesystemIsAutoGeneratedRule())
Luca Stefani50098f72024-10-12 17:55:31 +020065 AddNeverAllowRules(createKotlinPluginRule()...)
Jihoon Kang2a7bf752024-11-01 21:21:25 +000066 AddNeverAllowRules(createPrebuiltEtcBpDefineRule())
Spandan Dase2f98da2024-11-18 19:22:39 +000067 AddNeverAllowRules(createAutogenRroBpDefineRule())
Neil Fullerdf5f3562018-10-21 17:19:10 +010068}
Steven Moreland65b3fd92017-12-06 14:18:35 -080069
Paul Duffin730f2a52019-06-27 14:08:51 +010070// Add a NeverAllow rule to the set of rules to apply.
71func AddNeverAllowRules(rules ...Rule) {
72 neverallows = append(neverallows, rules...)
73}
74
Sam Delmerico46d08b42022-11-15 15:51:04 -050075var (
76 neverallowNotInIncludeDir = []string{
Paul Duffinc8111702019-07-22 12:13:55 +010077 "art",
Orion Hodson6341f012019-11-06 13:39:46 +000078 "art/libnativebridge",
79 "art/libnativeloader",
Paul Duffinc8111702019-07-22 12:13:55 +010080 "libcore",
81 "libnativehelper",
82 "external/apache-harmony",
83 "external/apache-xml",
84 "external/boringssl",
85 "external/bouncycastle",
86 "external/conscrypt",
87 "external/icu",
88 "external/okhttp",
89 "external/vixl",
90 "external/wycheproof",
Paul Duffinc8111702019-07-22 12:13:55 +010091 }
Sam Delmerico46d08b42022-11-15 15:51:04 -050092 neverallowNoUseIncludeDir = []string{
Steven Morelandf36a3ac2021-04-27 18:03:14 +000093 "frameworks/av/apex",
94 "frameworks/av/tools",
95 "frameworks/native/cmds",
96 "system/apex",
97 "system/bpf",
98 "system/gatekeeper",
99 "system/hwservicemanager",
100 "system/libbase",
Steven Moreland8fc8dbf2021-04-27 02:31:07 +0000101 "system/libfmq",
Steven Morelandf36a3ac2021-04-27 18:03:14 +0000102 "system/libvintf",
Steven Moreland8fc8dbf2021-04-27 02:31:07 +0000103 }
Sam Delmerico46d08b42022-11-15 15:51:04 -0500104)
Paul Duffinc8111702019-07-22 12:13:55 +0100105
Sam Delmerico46d08b42022-11-15 15:51:04 -0500106func createIncludeDirsRules() []Rule {
107 rules := make([]Rule, 0, len(neverallowNotInIncludeDir)+len(neverallowNoUseIncludeDir))
Steven Moreland8fc8dbf2021-04-27 02:31:07 +0000108
Sam Delmerico46d08b42022-11-15 15:51:04 -0500109 for _, path := range neverallowNotInIncludeDir {
Paul Duffinc8111702019-07-22 12:13:55 +0100110 rule :=
111 NeverAllow().
112 WithMatcher("include_dirs", StartsWith(path+"/")).
113 Because("include_dirs is deprecated, all usages of '" + path + "' have been migrated" +
114 " to use alternate mechanisms and so can no longer be used.")
115
116 rules = append(rules, rule)
117 }
118
Sam Delmerico46d08b42022-11-15 15:51:04 -0500119 for _, path := range neverallowNoUseIncludeDir {
Steven Moreland8fc8dbf2021-04-27 02:31:07 +0000120 rule := NeverAllow().In(path+"/").WithMatcher("include_dirs", isSetMatcherInstance).
121 Because("include_dirs is deprecated, all usages of them in '" + path + "' have been migrated" +
122 " to use alternate mechanisms and so can no longer be used.")
123 rules = append(rules, rule)
124 }
125
Paul Duffinc8111702019-07-22 12:13:55 +0100126 return rules
127}
128
Paul Duffin730f2a52019-06-27 14:08:51 +0100129func createTrebleRules() []Rule {
130 return []Rule{
131 NeverAllow().
132 In("vendor", "device").
133 With("vndk.enabled", "true").
134 Without("vendor", "true").
Justin Yun0ecf0b22020-02-28 15:07:59 +0900135 Without("product_specific", "true").
Paul Duffin730f2a52019-06-27 14:08:51 +0100136 Because("the VNDK can never contain a library that is device dependent."),
137 NeverAllow().
138 With("vndk.enabled", "true").
139 Without("vendor", "true").
140 Without("owner", "").
141 Because("a VNDK module can never have an owner."),
Steven Moreland65b3fd92017-12-06 14:18:35 -0800142
Neil Fullerdf5f3562018-10-21 17:19:10 +0100143 // TODO(b/67974785): always enforce the manifest
Paul Duffin730f2a52019-06-27 14:08:51 +0100144 NeverAllow().
Steven Moreland51ce4f62020-02-10 17:21:32 -0800145 Without("name", "libhidlbase-combined-impl").
146 Without("name", "libhidlbase").
Paul Duffin730f2a52019-06-27 14:08:51 +0100147 With("product_variables.enforce_vintf_manifest.cflags", "*").
148 Because("manifest enforcement should be independent of ."),
Neil Fullerdf5f3562018-10-21 17:19:10 +0100149
150 // TODO(b/67975799): vendor code should always use /vendor/bin/sh
Paul Duffin730f2a52019-06-27 14:08:51 +0100151 NeverAllow().
152 Without("name", "libc_bionic_ndk").
153 With("product_variables.treble_linker_namespaces.cflags", "*").
154 Because("nothing should care if linker namespaces are enabled or not"),
Neil Fullerdf5f3562018-10-21 17:19:10 +0100155
156 // Example:
Paul Duffin730f2a52019-06-27 14:08:51 +0100157 // *NeverAllow().with("Srcs", "main.cpp"))
Neil Fullerdf5f3562018-10-21 17:19:10 +0100158 }
159}
160
Paul Duffin730f2a52019-06-27 14:08:51 +0100161func createJavaDeviceForHostRules() []Rule {
Colin Cross440e0d02020-06-11 11:32:11 -0700162 javaDeviceForHostProjectsAllowedList := []string{
Dan Willemsen9fe14102021-07-13 21:52:04 -0700163 "development/build",
Colin Crossb5191a52019-04-11 14:07:38 -0700164 "external/guava",
Steve Elliott8053f822022-10-18 17:09:28 -0400165 "external/kotlinx.coroutines",
Colin Crossfd4f7432019-03-05 15:06:16 -0800166 "external/robolectric-shadows",
Rex Hoffman54641d22022-08-25 17:29:50 +0000167 "external/robolectric",
Makoto Onukib66bba32023-11-11 00:06:09 +0000168 "frameworks/base/ravenwood",
169 "frameworks/base/tools/hoststubgen",
Jerome Gaillard655ee022021-09-23 11:38:08 +0000170 "frameworks/layoutlib",
Colin Crossfd4f7432019-03-05 15:06:16 -0800171 }
172
Paul Duffin730f2a52019-06-27 14:08:51 +0100173 return []Rule{
174 NeverAllow().
Colin Cross440e0d02020-06-11 11:32:11 -0700175 NotIn(javaDeviceForHostProjectsAllowedList...).
Paul Duffin730f2a52019-06-27 14:08:51 +0100176 ModuleType("java_device_for_host", "java_host_for_device").
Colin Cross440e0d02020-06-11 11:32:11 -0700177 Because("java_device_for_host can only be used in allowed projects"),
Colin Crossfd4f7432019-03-05 15:06:16 -0800178 }
179}
180
Colin Crossc511bc52020-04-07 16:50:32 +0000181func createCcSdkVariantRules() []Rule {
Colin Cross440e0d02020-06-11 11:32:11 -0700182 sdkVersionOnlyAllowedList := []string{
Colin Crossc511bc52020-04-07 16:50:32 +0000183 // derive_sdk_prefer32 has stem: "derive_sdk" which conflicts with the derive_sdk.
184 // This sometimes works because the APEX modules that contain derive_sdk and
185 // derive_sdk_prefer32 suppress the platform installation rules, but fails when
186 // the APEX modules contain the SDK variant and the platform variant still exists.
Anton Hansson4b8e64b2020-05-27 18:25:23 +0100187 "packages/modules/SdkExtensions/derive_sdk",
Dan Alberte2054a92020-04-20 14:46:47 -0700188 // These are for apps and shouldn't be used by non-SDK variant modules.
189 "prebuilts/ndk",
Jiyong Parka574d532024-08-28 18:06:43 +0900190 "frameworks/native/libs/binder/ndk",
Dan Alberte2054a92020-04-20 14:46:47 -0700191 "tools/test/graphicsbenchmark/apps/sample_app",
192 "tools/test/graphicsbenchmark/functional_tests/java",
Dan Albert55576052020-04-20 14:46:47 -0700193 "vendor/xts/gts-tests/hostsidetests/gamedevicecert/apps/javatests",
Chang Li66d3cb72021-06-18 14:04:50 +0000194 "external/libtextclassifier/native",
Colin Crossc511bc52020-04-07 16:50:32 +0000195 }
196
Colin Cross440e0d02020-06-11 11:32:11 -0700197 platformVariantPropertiesAllowedList := []string{
Colin Crossc511bc52020-04-07 16:50:32 +0000198 // android_native_app_glue and libRSSupport use native_window.h but target old
199 // sdk versions (minimum and 9 respectively) where libnativewindow didn't exist,
200 // so they can't add libnativewindow to shared_libs to get the header directory
201 // for the platform variant. Allow them to use the platform variant
202 // property to set shared_libs.
203 "prebuilts/ndk",
204 "frameworks/rs",
205 }
206
207 return []Rule{
208 NeverAllow().
Colin Cross440e0d02020-06-11 11:32:11 -0700209 NotIn(sdkVersionOnlyAllowedList...).
Colin Crossc511bc52020-04-07 16:50:32 +0000210 WithMatcher("sdk_variant_only", isSetMatcherInstance).
Colin Cross440e0d02020-06-11 11:32:11 -0700211 Because("sdk_variant_only can only be used in allowed projects"),
Colin Crossc511bc52020-04-07 16:50:32 +0000212 NeverAllow().
Colin Cross440e0d02020-06-11 11:32:11 -0700213 NotIn(platformVariantPropertiesAllowedList...).
Colin Crossc511bc52020-04-07 16:50:32 +0000214 WithMatcher("platform.shared_libs", isSetMatcherInstance).
Colin Cross440e0d02020-06-11 11:32:11 -0700215 Because("platform variant properties can only be used in allowed projects"),
Colin Crossc511bc52020-04-07 16:50:32 +0000216 }
217}
218
Alan Stokes73feba32022-11-14 12:21:24 +0000219func createCcStubsRule() Rule {
220 ccStubsImplementationInstallableProjectsAllowedList := []string{
Jiyong Parkf6736c72024-07-22 11:22:35 +0900221 "packages/modules/Virtualization/libs/libvm_payload",
Alan Stokes73feba32022-11-14 12:21:24 +0000222 }
223
224 return NeverAllow().
225 NotIn(ccStubsImplementationInstallableProjectsAllowedList...).
226 WithMatcher("stubs.implementation_installable", isSetMatcherInstance).
227 Because("implementation_installable can only be used in allowed projects.")
228}
229
David Srbeckye033cba2020-05-20 22:20:28 +0100230func createUncompressDexRules() []Rule {
231 return []Rule{
232 NeverAllow().
233 NotIn("art").
234 WithMatcher("uncompress_dex", isSetMatcherInstance).
235 Because("uncompress_dex is only allowed for certain jars for test in art."),
236 }
237}
238
Nelson Li43808202024-11-20 09:05:53 +0000239func createInstallInRootAllowingRules() []Rule {
Inseob Kim800d1142021-06-14 12:03:51 +0900240 return []Rule{
241 NeverAllow().
Nikita Ioffe11a9c2c2023-06-21 16:51:09 +0100242 Without("name", "init_first_stage_defaults").
Inseob Kim800d1142021-06-14 12:03:51 +0900243 Without("name", "init_first_stage").
Nikita Ioffe11a9c2c2023-06-21 16:51:09 +0100244 Without("name", "init_first_stage.microdroid").
Nelson Li43808202024-11-20 09:05:53 +0000245 Without("name", "librecovery_ui_ext").
Inseob Kim800d1142021-06-14 12:03:51 +0900246 With("install_in_root", "true").
Inseob Kimbe6a66d2024-07-11 15:43:44 +0900247 NotModuleType("prebuilt_root").
Jihoon Kang320ca7c2024-12-03 18:14:50 +0000248 NotModuleType("prebuilt_vendor").
249 NotModuleType("prebuilt_sbin").
250 NotModuleType("prebuilt_system").
251 NotModuleType("prebuilt_first_stage_ramdisk").
Jihoon Kang96f38d22024-12-03 23:17:55 +0000252 NotModuleType("prebuilt_res").
Nelson Li43808202024-11-20 09:05:53 +0000253 Because("install_in_root is only for init_first_stage or librecovery_ui_ext."),
Inseob Kim800d1142021-06-14 12:03:51 +0900254 }
255}
256
Jiyong Park3c306f32022-04-05 15:29:53 +0900257func createProhibitFrameworkAccessRules() []Rule {
258 return []Rule{
259 NeverAllow().
260 With("libs", "framework").
261 WithoutMatcher("sdk_version", Regexp("(core_.*|^$)")).
262 Because("framework can't be used when building against SDK"),
263 }
264}
265
Mark Whitea15790a2023-08-22 21:28:11 +0000266func createProhibitHeaderOnlyRule() Rule {
267 return NeverAllow().
268 Without("name", "framework-minus-apex-headers").
269 With("headers_only", "true").
270 Because("headers_only can only be used for generating framework-minus-apex headers for non-updatable modules")
271}
272
Steven Moreland0db999c2024-09-03 22:06:24 +0000273func createLimitNdkExportRule() []Rule {
274 reason := "If the headers you're trying to export are meant to be a part of the NDK, they should be exposed by an ndk_headers module. If the headers shouldn't be a part of the NDK, the headers should instead be exposed from a separate `cc_library_headers` which consumers depend on."
275 // DO NOT ADD HERE - please consult danalbert@
276 // b/357711733
277 return []Rule{
278 NeverAllow().
279 NotIn("frameworks/native/libs/binder/ndk").
280 ModuleType("ndk_library").
281 WithMatcher("export_header_libs", isSetMatcherInstance).Because(reason),
282 NeverAllow().ModuleType("ndk_library").WithMatcher("export_generated_headers", isSetMatcherInstance).Because(reason),
283 NeverAllow().ModuleType("ndk_library").WithMatcher("export_include_dirs", isSetMatcherInstance).Because(reason),
284 NeverAllow().ModuleType("ndk_library").WithMatcher("export_shared_lib_headers", isSetMatcherInstance).Because(reason),
285 NeverAllow().ModuleType("ndk_library").WithMatcher("export_static_lib_headers", isSetMatcherInstance).Because(reason),
286 }
287}
288
Inseob Kim76e19852024-10-10 17:57:22 +0900289func createLimitDirgroupRule() []Rule {
Inseob Kim7195b062024-11-29 15:40:49 +0900290 reason := "dirgroup module and dir_srcs / keep_gendir property of genrule is allowed only to Trusty build rule."
Inseob Kim76e19852024-10-10 17:57:22 +0900291 return []Rule{
292 NeverAllow().
293 ModuleType("dirgroup").
294 WithMatcher("visibility", NotInList([]string{"//trusty/vendor/google/aosp/scripts"})).Because(reason),
295 NeverAllow().
296 ModuleType("dirgroup").
297 Without("visibility", "//trusty/vendor/google/aosp/scripts").Because(reason),
298 NeverAllow().
299 ModuleType("genrule").
Inseob Kime8b1ac42024-10-24 09:27:44 +0000300 Without("name", "trusty-arm64.lk.elf.gen").
Alice Wang38aed8d2024-11-27 08:18:59 +0000301 Without("name", "trusty-arm64-virt-test-debug.lk.elf.gen").
Inseob Kime8b1ac42024-10-24 09:27:44 +0000302 Without("name", "trusty-x86_64.lk.elf.gen").
303 Without("name", "trusty-x86_64-test.lk.elf.gen").
Inseob Kim76e19852024-10-10 17:57:22 +0900304 WithMatcher("dir_srcs", isSetMatcherInstance).Because(reason),
Inseob Kim7195b062024-11-29 15:40:49 +0900305 NeverAllow().
306 ModuleType("genrule").
307 Without("name", "trusty-arm64.lk.elf.gen").
308 Without("name", "trusty-arm64-virt-test-debug.lk.elf.gen").
309 Without("name", "trusty-x86_64.lk.elf.gen").
310 Without("name", "trusty-x86_64-test.lk.elf.gen").
311 With("keep_gendir", "true").Because(reason),
Inseob Kim76e19852024-10-10 17:57:22 +0900312 }
313}
314
Jihoon Kang0d545b82024-10-11 00:21:57 +0000315func createFilesystemIsAutoGeneratedRule() Rule {
316 return NeverAllow().
317 NotIn("build/soong/fsgen").
318 ModuleType("filesystem", "android_system_image").
319 WithMatcher("is_auto_generated", isSetMatcherInstance).
320 Because("is_auto_generated property is only allowed for filesystem modules in build/soong/fsgen directory")
321}
322
Luca Stefani50098f72024-10-12 17:55:31 +0200323func createKotlinPluginRule() []Rule {
324 kotlinPluginProjectsAllowedList := []string{
Luca Stefani50098f72024-10-12 17:55:31 +0200325 "external/kotlinc",
326 }
327
328 return []Rule{
329 NeverAllow().
330 NotIn(kotlinPluginProjectsAllowedList...).
331 ModuleType("kotlin_plugin").
332 Because("kotlin_plugin can only be used in allowed projects"),
333 }
334}
335
Jihoon Kang2a7bf752024-11-01 21:21:25 +0000336// These module types are introduced to convert PRODUCT_COPY_FILES to Soong,
337// and is only intended to be used by filesystem_creator.
338func createPrebuiltEtcBpDefineRule() Rule {
339 return NeverAllow().
340 ModuleType(
341 "prebuilt_usr_srec",
342 "prebuilt_priv_app",
343 "prebuilt_rfs",
344 "prebuilt_framework",
Jihoon Kang2a7bf752024-11-01 21:21:25 +0000345 "prebuilt_wlc_upt",
346 "prebuilt_odm",
Jihoon Kang2e2b7442024-11-05 00:26:20 +0000347 "prebuilt_vendor_dlkm",
348 "prebuilt_bt_firmware",
Jihoon Kangdca2f2b2024-11-06 18:43:19 +0000349 "prebuilt_tvservice",
350 "prebuilt_optee",
Jihoon Kangecf76dd2024-11-12 05:24:46 +0000351 "prebuilt_tvconfig",
Jihoon Kang3ca07a12024-12-02 19:14:30 +0000352 "prebuilt_vendor",
Jihoon Kang320ca7c2024-12-03 18:14:50 +0000353 "prebuilt_sbin",
354 "prebuilt_system",
355 "prebuilt_first_stage_ramdisk",
Jihoon Kang2a7bf752024-11-01 21:21:25 +0000356 ).
357 DefinedInBpFile().
358 Because("module type not allowed to be defined in bp file")
359}
360
Spandan Dase2f98da2024-11-18 19:22:39 +0000361func createAutogenRroBpDefineRule() Rule {
362 return NeverAllow().
363 ModuleType(
364 "autogen_runtime_resource_overlay",
365 ).
366 DefinedInBpFile().
367 Because("Module type will be autogenerated by soong. Use runtime_resource_overlay instead")
368}
369
Steven Moreland65b3fd92017-12-06 14:18:35 -0800370func neverallowMutator(ctx BottomUpMutatorContext) {
371 m, ok := ctx.Module().(Module)
372 if !ok {
373 return
374 }
375
376 dir := ctx.ModuleDir() + "/"
377 properties := m.GetProperties()
378
Paul Duffinf1c9bbe2019-07-26 10:48:06 +0100379 osClass := ctx.Module().Target().Os.Class
380
Paul Duffin115445b2019-08-07 15:31:07 +0100381 for _, r := range neverallowRules(ctx.Config()) {
Paul Duffin730f2a52019-06-27 14:08:51 +0100382 n := r.(*rule)
Steven Moreland65b3fd92017-12-06 14:18:35 -0800383 if !n.appliesToPath(dir) {
384 continue
385 }
386
Colin Crossfd4f7432019-03-05 15:06:16 -0800387 if !n.appliesToModuleType(ctx.ModuleType()) {
388 continue
389 }
390
Cole Faust5b35cb92024-08-27 15:47:06 -0700391 if !n.appliesToProperties(ctx, properties) {
Steven Moreland65b3fd92017-12-06 14:18:35 -0800392 continue
393 }
394
Paul Duffinf1c9bbe2019-07-26 10:48:06 +0100395 if !n.appliesToOsClass(osClass) {
396 continue
397 }
398
Paul Duffin35781882019-07-25 15:41:09 +0100399 if !n.appliesToDirectDeps(ctx) {
400 continue
401 }
402
Jihoon Kang2a7bf752024-11-01 21:21:25 +0000403 if !n.appliesToBpDefinedModule(ctx) {
404 continue
405 }
406
Steven Moreland65b3fd92017-12-06 14:18:35 -0800407 ctx.ModuleErrorf("violates " + n.String())
408 }
409}
410
Paul Duffin73bf0542019-07-12 14:12:49 +0100411type ValueMatcher interface {
Anton Hanssone1b18362021-12-23 15:05:38 +0000412 Test(string) bool
Paul Duffin73bf0542019-07-12 14:12:49 +0100413 String() string
414}
415
416type equalMatcher struct {
417 expected string
418}
419
Anton Hanssone1b18362021-12-23 15:05:38 +0000420func (m *equalMatcher) Test(value string) bool {
Paul Duffin73bf0542019-07-12 14:12:49 +0100421 return m.expected == value
422}
423
424func (m *equalMatcher) String() string {
425 return "=" + m.expected
426}
427
428type anyMatcher struct {
429}
430
Anton Hanssone1b18362021-12-23 15:05:38 +0000431func (m *anyMatcher) Test(value string) bool {
Paul Duffin73bf0542019-07-12 14:12:49 +0100432 return true
433}
434
435func (m *anyMatcher) String() string {
436 return "=*"
437}
438
439var anyMatcherInstance = &anyMatcher{}
440
Paul Duffinc8111702019-07-22 12:13:55 +0100441type startsWithMatcher struct {
442 prefix string
443}
444
Anton Hanssone1b18362021-12-23 15:05:38 +0000445func (m *startsWithMatcher) Test(value string) bool {
Paul Duffinc8111702019-07-22 12:13:55 +0100446 return strings.HasPrefix(value, m.prefix)
447}
448
449func (m *startsWithMatcher) String() string {
450 return ".starts-with(" + m.prefix + ")"
451}
452
Anton Hansson45376402020-04-09 14:18:21 +0100453type regexMatcher struct {
454 re *regexp.Regexp
455}
456
Anton Hanssone1b18362021-12-23 15:05:38 +0000457func (m *regexMatcher) Test(value string) bool {
Anton Hansson45376402020-04-09 14:18:21 +0100458 return m.re.MatchString(value)
459}
460
461func (m *regexMatcher) String() string {
462 return ".regexp(" + m.re.String() + ")"
463}
464
Andrei Onea115e7e72020-06-05 21:14:03 +0100465type notInListMatcher struct {
466 allowed []string
467}
468
Anton Hanssone1b18362021-12-23 15:05:38 +0000469func (m *notInListMatcher) Test(value string) bool {
Andrei Onea115e7e72020-06-05 21:14:03 +0100470 return !InList(value, m.allowed)
471}
472
473func (m *notInListMatcher) String() string {
474 return ".not-in-list(" + strings.Join(m.allowed, ",") + ")"
475}
476
Colin Crossc511bc52020-04-07 16:50:32 +0000477type isSetMatcher struct{}
478
Anton Hanssone1b18362021-12-23 15:05:38 +0000479func (m *isSetMatcher) Test(value string) bool {
Colin Crossc511bc52020-04-07 16:50:32 +0000480 return value != ""
481}
482
483func (m *isSetMatcher) String() string {
484 return ".is-set"
485}
486
487var isSetMatcherInstance = &isSetMatcher{}
488
Steven Moreland65b3fd92017-12-06 14:18:35 -0800489type ruleProperty struct {
Paul Duffin73bf0542019-07-12 14:12:49 +0100490 fields []string // e.x.: Vndk.Enabled
491 matcher ValueMatcher
Steven Moreland65b3fd92017-12-06 14:18:35 -0800492}
493
Liz Kammera3d79152021-10-28 18:14:04 -0400494func (r *ruleProperty) String() string {
495 return fmt.Sprintf("%q matches: %s", strings.Join(r.fields, "."), r.matcher)
496}
497
498type ruleProperties []ruleProperty
499
500func (r ruleProperties) String() string {
501 var s []string
502 for _, r := range r {
503 s = append(s, r.String())
504 }
505 return strings.Join(s, " ")
506}
507
Paul Duffin730f2a52019-06-27 14:08:51 +0100508// A NeverAllow rule.
509type Rule interface {
510 In(path ...string) Rule
511
512 NotIn(path ...string) Rule
513
Paul Duffin35781882019-07-25 15:41:09 +0100514 InDirectDeps(deps ...string) Rule
515
Paul Duffinf1c9bbe2019-07-26 10:48:06 +0100516 WithOsClass(osClasses ...OsClass) Rule
517
Paul Duffin730f2a52019-06-27 14:08:51 +0100518 ModuleType(types ...string) Rule
519
520 NotModuleType(types ...string) Rule
521
522 With(properties, value string) Rule
523
Paul Duffinc8111702019-07-22 12:13:55 +0100524 WithMatcher(properties string, matcher ValueMatcher) Rule
525
Paul Duffin730f2a52019-06-27 14:08:51 +0100526 Without(properties, value string) Rule
527
Paul Duffinc8111702019-07-22 12:13:55 +0100528 WithoutMatcher(properties string, matcher ValueMatcher) Rule
529
Jihoon Kang2a7bf752024-11-01 21:21:25 +0000530 DefinedInBpFile() Rule
531
Paul Duffin730f2a52019-06-27 14:08:51 +0100532 Because(reason string) Rule
533}
534
Steven Moreland65b3fd92017-12-06 14:18:35 -0800535type rule struct {
536 // User string for why this is a thing.
537 reason string
538
539 paths []string
540 unlessPaths []string
541
Paul Duffin35781882019-07-25 15:41:09 +0100542 directDeps map[string]bool
543
Paul Duffinf1c9bbe2019-07-26 10:48:06 +0100544 osClasses []OsClass
545
Colin Crossfd4f7432019-03-05 15:06:16 -0800546 moduleTypes []string
547 unlessModuleTypes []string
548
Liz Kammera3d79152021-10-28 18:14:04 -0400549 props ruleProperties
550 unlessProps ruleProperties
Andrei Onea115e7e72020-06-05 21:14:03 +0100551
552 onlyBootclasspathJar bool
Jihoon Kang2a7bf752024-11-01 21:21:25 +0000553
554 definedInBp bool
Steven Moreland65b3fd92017-12-06 14:18:35 -0800555}
556
Paul Duffin730f2a52019-06-27 14:08:51 +0100557// Create a new NeverAllow rule.
558func NeverAllow() Rule {
Paul Duffin35781882019-07-25 15:41:09 +0100559 return &rule{directDeps: make(map[string]bool)}
Steven Moreland65b3fd92017-12-06 14:18:35 -0800560}
Colin Crossfd4f7432019-03-05 15:06:16 -0800561
Liz Kammera3d79152021-10-28 18:14:04 -0400562// In adds path(s) where this rule applies.
Paul Duffin730f2a52019-06-27 14:08:51 +0100563func (r *rule) In(path ...string) Rule {
Steven Moreland65b3fd92017-12-06 14:18:35 -0800564 r.paths = append(r.paths, cleanPaths(path)...)
565 return r
566}
Colin Crossfd4f7432019-03-05 15:06:16 -0800567
Liz Kammera3d79152021-10-28 18:14:04 -0400568// NotIn adds path(s) to that this rule does not apply to.
Paul Duffin730f2a52019-06-27 14:08:51 +0100569func (r *rule) NotIn(path ...string) Rule {
Steven Moreland65b3fd92017-12-06 14:18:35 -0800570 r.unlessPaths = append(r.unlessPaths, cleanPaths(path)...)
571 return r
572}
Colin Crossfd4f7432019-03-05 15:06:16 -0800573
Liz Kammera3d79152021-10-28 18:14:04 -0400574// InDirectDeps adds dep(s) that are not allowed with this rule.
Paul Duffin35781882019-07-25 15:41:09 +0100575func (r *rule) InDirectDeps(deps ...string) Rule {
576 for _, d := range deps {
577 r.directDeps[d] = true
578 }
579 return r
580}
581
Liz Kammera3d79152021-10-28 18:14:04 -0400582// WithOsClass adds osClass(es) that this rule applies to.
Paul Duffinf1c9bbe2019-07-26 10:48:06 +0100583func (r *rule) WithOsClass(osClasses ...OsClass) Rule {
584 r.osClasses = append(r.osClasses, osClasses...)
585 return r
586}
587
Liz Kammera3d79152021-10-28 18:14:04 -0400588// ModuleType adds type(s) that this rule applies to.
Paul Duffin730f2a52019-06-27 14:08:51 +0100589func (r *rule) ModuleType(types ...string) Rule {
Colin Crossfd4f7432019-03-05 15:06:16 -0800590 r.moduleTypes = append(r.moduleTypes, types...)
591 return r
592}
593
Liz Kammera3d79152021-10-28 18:14:04 -0400594// NotModuleType adds type(s) that this rule does not apply to..
Paul Duffin730f2a52019-06-27 14:08:51 +0100595func (r *rule) NotModuleType(types ...string) Rule {
Colin Crossfd4f7432019-03-05 15:06:16 -0800596 r.unlessModuleTypes = append(r.unlessModuleTypes, types...)
597 return r
598}
599
Liz Kammera3d79152021-10-28 18:14:04 -0400600// With specifies property/value combinations that are restricted for this rule.
Paul Duffin730f2a52019-06-27 14:08:51 +0100601func (r *rule) With(properties, value string) Rule {
Paul Duffinc8111702019-07-22 12:13:55 +0100602 return r.WithMatcher(properties, selectMatcher(value))
603}
604
Liz Kammera3d79152021-10-28 18:14:04 -0400605// WithMatcher specifies property/matcher combinations that are restricted for this rule.
Paul Duffinc8111702019-07-22 12:13:55 +0100606func (r *rule) WithMatcher(properties string, matcher ValueMatcher) Rule {
Steven Moreland65b3fd92017-12-06 14:18:35 -0800607 r.props = append(r.props, ruleProperty{
Paul Duffin73bf0542019-07-12 14:12:49 +0100608 fields: fieldNamesForProperties(properties),
Paul Duffinc8111702019-07-22 12:13:55 +0100609 matcher: matcher,
Steven Moreland65b3fd92017-12-06 14:18:35 -0800610 })
611 return r
612}
Colin Crossfd4f7432019-03-05 15:06:16 -0800613
Liz Kammera3d79152021-10-28 18:14:04 -0400614// Without specifies property/value combinations that this rule does not apply to.
Paul Duffin730f2a52019-06-27 14:08:51 +0100615func (r *rule) Without(properties, value string) Rule {
Paul Duffinc8111702019-07-22 12:13:55 +0100616 return r.WithoutMatcher(properties, selectMatcher(value))
617}
618
Liz Kammera3d79152021-10-28 18:14:04 -0400619// Without specifies property/matcher combinations that this rule does not apply to.
Paul Duffinc8111702019-07-22 12:13:55 +0100620func (r *rule) WithoutMatcher(properties string, matcher ValueMatcher) Rule {
Steven Moreland65b3fd92017-12-06 14:18:35 -0800621 r.unlessProps = append(r.unlessProps, ruleProperty{
Paul Duffin73bf0542019-07-12 14:12:49 +0100622 fields: fieldNamesForProperties(properties),
Paul Duffinc8111702019-07-22 12:13:55 +0100623 matcher: matcher,
Steven Moreland65b3fd92017-12-06 14:18:35 -0800624 })
625 return r
626}
Colin Crossfd4f7432019-03-05 15:06:16 -0800627
Jihoon Kang2a7bf752024-11-01 21:21:25 +0000628// DefinedInBpFile specifies that this rule applies to modules that are defined
629// in bp files, and does not apply to modules that are auto generated by other modules.
630func (r *rule) DefinedInBpFile() Rule {
631 r.definedInBp = true
632 return r
633}
634
Paul Duffin73bf0542019-07-12 14:12:49 +0100635func selectMatcher(expected string) ValueMatcher {
636 if expected == "*" {
637 return anyMatcherInstance
638 }
639 return &equalMatcher{expected: expected}
640}
641
Liz Kammera3d79152021-10-28 18:14:04 -0400642// Because specifies a reason for this rule.
Paul Duffin730f2a52019-06-27 14:08:51 +0100643func (r *rule) Because(reason string) Rule {
Steven Moreland65b3fd92017-12-06 14:18:35 -0800644 r.reason = reason
645 return r
646}
647
648func (r *rule) String() string {
Liz Kammera3d79152021-10-28 18:14:04 -0400649 s := []string{"neverallow requirements. Not allowed:"}
650 if len(r.paths) > 0 {
651 s = append(s, fmt.Sprintf("in dirs: %q", r.paths))
Steven Moreland65b3fd92017-12-06 14:18:35 -0800652 }
Liz Kammera3d79152021-10-28 18:14:04 -0400653 if len(r.moduleTypes) > 0 {
654 s = append(s, fmt.Sprintf("module types: %q", r.moduleTypes))
Steven Moreland65b3fd92017-12-06 14:18:35 -0800655 }
Liz Kammera3d79152021-10-28 18:14:04 -0400656 if len(r.props) > 0 {
657 s = append(s, fmt.Sprintf("properties matching: %s", r.props))
Colin Crossfd4f7432019-03-05 15:06:16 -0800658 }
Liz Kammera3d79152021-10-28 18:14:04 -0400659 if len(r.directDeps) > 0 {
Cole Faust18994c72023-02-28 16:02:16 -0800660 s = append(s, fmt.Sprintf("dep(s): %q", SortedKeys(r.directDeps)))
Colin Crossfd4f7432019-03-05 15:06:16 -0800661 }
Liz Kammera3d79152021-10-28 18:14:04 -0400662 if len(r.osClasses) > 0 {
663 s = append(s, fmt.Sprintf("os class(es): %q", r.osClasses))
Paul Duffinf1c9bbe2019-07-26 10:48:06 +0100664 }
Liz Kammera3d79152021-10-28 18:14:04 -0400665 if len(r.unlessPaths) > 0 {
666 s = append(s, fmt.Sprintf("EXCEPT in dirs: %q", r.unlessPaths))
667 }
668 if len(r.unlessModuleTypes) > 0 {
669 s = append(s, fmt.Sprintf("EXCEPT module types: %q", r.unlessModuleTypes))
670 }
671 if len(r.unlessProps) > 0 {
672 s = append(s, fmt.Sprintf("EXCEPT properties matching: %q", r.unlessProps))
Andrei Onea115e7e72020-06-05 21:14:03 +0100673 }
Steven Moreland65b3fd92017-12-06 14:18:35 -0800674 if len(r.reason) != 0 {
Liz Kammera3d79152021-10-28 18:14:04 -0400675 s = append(s, " which is restricted because "+r.reason)
Steven Moreland65b3fd92017-12-06 14:18:35 -0800676 }
Liz Kammera3d79152021-10-28 18:14:04 -0400677 if len(s) == 1 {
678 s[0] = "neverallow requirements (empty)"
679 }
680 return strings.Join(s, "\n\t")
Steven Moreland65b3fd92017-12-06 14:18:35 -0800681}
682
683func (r *rule) appliesToPath(dir string) bool {
Jaewoong Jung3aff5782020-02-11 07:54:35 -0800684 includePath := len(r.paths) == 0 || HasAnyPrefix(dir, r.paths)
685 excludePath := HasAnyPrefix(dir, r.unlessPaths)
Steven Moreland65b3fd92017-12-06 14:18:35 -0800686 return includePath && !excludePath
687}
688
Paul Duffin35781882019-07-25 15:41:09 +0100689func (r *rule) appliesToDirectDeps(ctx BottomUpMutatorContext) bool {
690 if len(r.directDeps) == 0 {
691 return true
692 }
693
694 matches := false
695 ctx.VisitDirectDeps(func(m Module) {
696 if !matches {
697 name := ctx.OtherModuleName(m)
698 matches = r.directDeps[name]
699 }
700 })
701
702 return matches
703}
704
Paul Duffinf1c9bbe2019-07-26 10:48:06 +0100705func (r *rule) appliesToOsClass(osClass OsClass) bool {
706 if len(r.osClasses) == 0 {
707 return true
708 }
709
710 for _, c := range r.osClasses {
711 if c == osClass {
712 return true
713 }
714 }
715
716 return false
717}
718
Colin Crossfd4f7432019-03-05 15:06:16 -0800719func (r *rule) appliesToModuleType(moduleType string) bool {
Jihoon Kangd5465072024-12-03 00:53:05 +0000720 // Remove prefix for auto-generated modules
721 moduleType = strings.TrimSuffix(moduleType, "__loadHookModule")
722 moduleType = strings.TrimSuffix(moduleType, "__bottomUpMutatorModule")
Colin Crossfd4f7432019-03-05 15:06:16 -0800723 return (len(r.moduleTypes) == 0 || InList(moduleType, r.moduleTypes)) && !InList(moduleType, r.unlessModuleTypes)
724}
725
Cole Faust5b35cb92024-08-27 15:47:06 -0700726func (r *rule) appliesToProperties(ctx BottomUpMutatorContext, properties []interface{}) bool {
727 includeProps := hasAllProperties(ctx, properties, r.props)
728 excludeProps := hasAnyProperty(ctx, properties, r.unlessProps)
Steven Moreland65b3fd92017-12-06 14:18:35 -0800729 return includeProps && !excludeProps
730}
731
Jihoon Kang2a7bf752024-11-01 21:21:25 +0000732func (r *rule) appliesToBpDefinedModule(ctx BottomUpMutatorContext) bool {
733 if !r.definedInBp {
734 return true
735 }
736 return !ctx.OtherModuleIsAutoGenerated(ctx.Module()) == r.definedInBp
737}
738
Paul Duffinc8111702019-07-22 12:13:55 +0100739func StartsWith(prefix string) ValueMatcher {
740 return &startsWithMatcher{prefix}
741}
742
Anton Hansson45376402020-04-09 14:18:21 +0100743func Regexp(re string) ValueMatcher {
744 r, err := regexp.Compile(re)
745 if err != nil {
746 panic(err)
747 }
748 return &regexMatcher{r}
749}
750
Andrei Onea115e7e72020-06-05 21:14:03 +0100751func NotInList(allowed []string) ValueMatcher {
752 return &notInListMatcher{allowed}
753}
754
Steven Moreland65b3fd92017-12-06 14:18:35 -0800755// assorted utils
756
757func cleanPaths(paths []string) []string {
758 res := make([]string, len(paths))
759 for i, v := range paths {
760 res[i] = filepath.Clean(v) + "/"
761 }
762 return res
763}
764
765func fieldNamesForProperties(propertyNames string) []string {
766 names := strings.Split(propertyNames, ".")
767 for i, v := range names {
768 names[i] = proptools.FieldNameForProperty(v)
769 }
770 return names
771}
772
Cole Faust5b35cb92024-08-27 15:47:06 -0700773func hasAnyProperty(ctx BottomUpMutatorContext, properties []interface{}, props []ruleProperty) bool {
Steven Moreland65b3fd92017-12-06 14:18:35 -0800774 for _, v := range props {
Cole Faust5b35cb92024-08-27 15:47:06 -0700775 if hasProperty(ctx, properties, v) {
Steven Moreland65b3fd92017-12-06 14:18:35 -0800776 return true
777 }
778 }
779 return false
780}
781
Cole Faust5b35cb92024-08-27 15:47:06 -0700782func hasAllProperties(ctx BottomUpMutatorContext, properties []interface{}, props []ruleProperty) bool {
Steven Moreland65b3fd92017-12-06 14:18:35 -0800783 for _, v := range props {
Cole Faust5b35cb92024-08-27 15:47:06 -0700784 if !hasProperty(ctx, properties, v) {
Steven Moreland65b3fd92017-12-06 14:18:35 -0800785 return false
786 }
787 }
788 return true
789}
790
Cole Faust5b35cb92024-08-27 15:47:06 -0700791func hasProperty(ctx BottomUpMutatorContext, properties []interface{}, prop ruleProperty) bool {
Steven Moreland65b3fd92017-12-06 14:18:35 -0800792 for _, propertyStruct := range properties {
793 propertiesValue := reflect.ValueOf(propertyStruct).Elem()
794 for _, v := range prop.fields {
795 if !propertiesValue.IsValid() {
796 break
797 }
798 propertiesValue = propertiesValue.FieldByName(v)
799 }
800 if !propertiesValue.IsValid() {
801 continue
802 }
803
Paul Duffin73bf0542019-07-12 14:12:49 +0100804 check := func(value string) bool {
Anton Hanssone1b18362021-12-23 15:05:38 +0000805 return prop.matcher.Test(value)
Steven Moreland65b3fd92017-12-06 14:18:35 -0800806 }
807
Cole Faust5b35cb92024-08-27 15:47:06 -0700808 if matchValue(ctx, propertiesValue, check) {
Steven Moreland65b3fd92017-12-06 14:18:35 -0800809 return true
810 }
811 }
812 return false
813}
814
Cole Faust5b35cb92024-08-27 15:47:06 -0700815func matchValue(ctx BottomUpMutatorContext, value reflect.Value, check func(string) bool) bool {
Steven Moreland65b3fd92017-12-06 14:18:35 -0800816 if !value.IsValid() {
817 return false
818 }
819
820 if value.Kind() == reflect.Ptr {
821 if value.IsNil() {
822 return check("")
823 }
824 value = value.Elem()
825 }
826
Cole Faust5b35cb92024-08-27 15:47:06 -0700827 switch v := value.Interface().(type) {
828 case string:
829 return check(v)
830 case bool:
831 return check(strconv.FormatBool(v))
832 case int:
833 return check(strconv.FormatInt((int64)(v), 10))
834 case []string:
835 for _, v := range v {
836 if check(v) {
837 return true
838 }
Steven Moreland65b3fd92017-12-06 14:18:35 -0800839 }
Cole Faust5b35cb92024-08-27 15:47:06 -0700840 return false
841 case proptools.Configurable[string]:
842 return check(v.GetOrDefault(ctx, ""))
843 case proptools.Configurable[bool]:
844 return check(strconv.FormatBool(v.GetOrDefault(ctx, false)))
845 case proptools.Configurable[[]string]:
846 for _, v := range v.GetOrDefault(ctx, nil) {
Steven Moreland65b3fd92017-12-06 14:18:35 -0800847 if check(v) {
848 return true
849 }
850 }
851 return false
852 }
853
854 panic("Can't handle type: " + value.Kind().String())
855}
Paul Duffin115445b2019-08-07 15:31:07 +0100856
857var neverallowRulesKey = NewOnceKey("neverallowRules")
858
859func neverallowRules(config Config) []Rule {
860 return config.Once(neverallowRulesKey, func() interface{} {
861 // No test rules were set by setTestNeverallowRules, use the global rules
862 return neverallows
863 }).([]Rule)
864}
865
866// Overrides the default neverallow rules for the supplied config.
867//
868// For testing only.
Paul Duffin45338f02021-03-30 23:07:52 +0100869func setTestNeverallowRules(config Config, testRules []Rule) {
Paul Duffin115445b2019-08-07 15:31:07 +0100870 config.Once(neverallowRulesKey, func() interface{} { return testRules })
871}
Paul Duffin45338f02021-03-30 23:07:52 +0100872
873// Prepares for a test by setting neverallow rules and enabling the mutator.
874//
875// If the supplied rules are nil then the default rules are used.
876func PrepareForTestWithNeverallowRules(testRules []Rule) FixturePreparer {
877 return GroupFixturePreparers(
878 FixtureModifyConfig(func(config Config) {
879 if testRules != nil {
880 setTestNeverallowRules(config, testRules)
881 }
882 }),
883 FixtureRegisterWithContext(func(ctx RegistrationContext) {
884 ctx.PostDepsMutators(registerNeverallowMutator)
885 }),
886 )
887}