blob: 4424999ccdb43fa35d48a6d2915a48b4b88d3a58 [file] [log] [blame]
Colin Cross72bb3632017-07-13 16:23:21 -07001// Copyright 2017 Google Inc. All rights reserved.
2//
3// Licensed under the Apache License, Version 2.0 (the "License");
4// you may not use this file except in compliance with the License.
5// You may obtain a copy of the License at
6//
7// http://www.apache.org/licenses/LICENSE-2.0
8//
9// Unless required by applicable law or agreed to in writing, software
10// distributed under the License is distributed on an "AS IS" BASIS,
11// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
12// See the License for the specific language governing permissions and
13// limitations under the License.
14
15package java
16
17import (
Colin Cross72bb3632017-07-13 16:23:21 -070018 "io/ioutil"
19 "os"
20 "path/filepath"
Colin Crossc0806172019-06-14 18:51:47 -070021 "reflect"
Paul Duffindaaa3322020-05-26 18:13:57 +010022 "regexp"
Nan Zhang61eaedb2017-11-02 13:28:15 -070023 "strconv"
Colin Cross72bb3632017-07-13 16:23:21 -070024 "strings"
25 "testing"
Colin Cross86a60ae2018-05-29 14:44:55 -070026
Jeongik Cha28df2572019-11-11 10:46:36 +090027 "github.com/google/blueprint/proptools"
28
Colin Crossa4f08812018-10-02 22:03:40 -070029 "android/soong/android"
30 "android/soong/cc"
Colin Crossc28bb0b2019-02-25 14:20:47 -080031 "android/soong/dexpreopt"
Colin Crossa4f08812018-10-02 22:03:40 -070032 "android/soong/genrule"
Liz Kammerdd849a82020-06-12 16:38:45 -070033 "android/soong/python"
Colin Cross72bb3632017-07-13 16:23:21 -070034)
35
36var buildDir string
37
38func setUp() {
39 var err error
40 buildDir, err = ioutil.TempDir("", "soong_java_test")
41 if err != nil {
42 panic(err)
43 }
44}
45
46func tearDown() {
47 os.RemoveAll(buildDir)
48}
49
50func TestMain(m *testing.M) {
51 run := func() int {
52 setUp()
53 defer tearDown()
54
55 return m.Run()
56 }
57
58 os.Exit(run())
59}
Colin Cross527012a2017-11-30 22:56:16 -080060
Colin Cross98be1bb2019-12-13 20:41:13 -080061func testConfig(env map[string]string, bp string, fs map[string][]byte) android.Config {
Martin Stjernholmd90676f2020-01-11 00:37:30 +000062 bp += dexpreopt.BpToolModulesForTest()
63
Martin Stjernholm75a48d82020-01-10 20:32:59 +000064 config := TestConfig(buildDir, env, bp, fs)
65
66 // Set up the global Once cache used for dexpreopt.GlobalSoongConfig, so that
67 // it doesn't create a real one, which would fail.
68 _ = dexpreopt.GlobalSoongConfigForTests(config)
69
70 return config
Colin Cross1369cdb2017-09-29 17:58:17 -070071}
72
Colin Cross98be1bb2019-12-13 20:41:13 -080073func testContext() *android.TestContext {
Colin Cross72bb3632017-07-13 16:23:21 -070074
Colin Cross4c428df2017-09-15 17:36:05 -070075 ctx := android.NewTestArchContext()
Paul Duffinf9b1da02019-12-18 19:51:55 +000076 RegisterJavaBuildComponents(ctx)
77 RegisterAppBuildComponents(ctx)
78 RegisterAARBuildComponents(ctx)
Paul Duffinb0f85072019-12-19 10:28:56 +000079 RegisterGenRuleBuildComponents(ctx)
Paul Duffin43dc1cc2019-12-19 11:18:54 +000080 RegisterSystemModulesBuildComponents(ctx)
Colin Cross4b49b762019-11-22 15:25:03 -080081 ctx.RegisterModuleType("java_plugin", PluginFactory)
Colin Cross4b49b762019-11-22 15:25:03 -080082 ctx.RegisterModuleType("filegroup", android.FileGroupFactory)
83 ctx.RegisterModuleType("genrule", genrule.GenRuleFactory)
Liz Kammerdd849a82020-06-12 16:38:45 -070084 ctx.RegisterModuleType("python_binary_host", python.PythonBinaryHostFactory)
Paul Duffin884363e2019-12-19 10:21:09 +000085 RegisterDocsBuildComponents(ctx)
86 RegisterStubsBuildComponents(ctx)
Paul Duffin43dc1cc2019-12-19 11:18:54 +000087 RegisterSdkLibraryBuildComponents(ctx)
Colin Cross89536d42017-07-07 14:35:50 -070088 ctx.PreArchMutators(android.RegisterDefaultsPreArchMutators)
Paul Duffin44f1d842020-06-26 20:17:02 +010089 ctx.PreArchMutators(android.RegisterComponentsMutator)
Paul Duffina48f7582019-12-19 11:25:19 +000090
91 RegisterPrebuiltApisBuildComponents(ctx)
92
Liz Kammerdd849a82020-06-12 16:38:45 -070093 ctx.PreDepsMutators(python.RegisterPythonPreDepsMutators)
Jaewoong Jungb639a6a2019-05-10 15:16:29 -070094 ctx.PostDepsMutators(android.RegisterOverridePostDepsMutators)
Colin Cross3bc7ffa2017-11-22 16:19:37 -080095 ctx.RegisterPreSingletonType("overlay", android.SingletonFactoryAdaptor(OverlaySingletonFactory))
Colin Cross3047fa22019-04-18 10:56:44 -070096 ctx.RegisterPreSingletonType("sdk_versions", android.SingletonFactoryAdaptor(sdkPreSingletonFactory))
Colin Crossa4f08812018-10-02 22:03:40 -070097
Paul Duffin021f4e52020-07-30 16:04:17 +010098 android.RegisterPrebuiltMutators(ctx)
99
Colin Crossa4f08812018-10-02 22:03:40 -0700100 // Register module types and mutators from cc needed for JNI testing
Paul Duffin77980a82019-12-19 16:01:36 +0000101 cc.RegisterRequiredBuildComponentsForTest(ctx)
Colin Crossa4f08812018-10-02 22:03:40 -0700102
Martin Stjernholmd90676f2020-01-11 00:37:30 +0000103 dexpreopt.RegisterToolModulesForTest(ctx)
104
Colin Cross527012a2017-11-30 22:56:16 -0800105 return ctx
106}
107
108func run(t *testing.T, ctx *android.TestContext, config android.Config) {
Colin Cross6b4a32d2017-12-05 13:42:45 -0800109 t.Helper()
Colin Crossc28bb0b2019-02-25 14:20:47 -0800110
Colin Cross98be1bb2019-12-13 20:41:13 -0800111 pathCtx := android.PathContextForTesting(config)
Martin Stjernholm40f9f3c2020-01-20 18:12:23 +0000112 dexpreopt.SetTestGlobalConfig(config, dexpreopt.GlobalConfigForTests(pathCtx))
Colin Crossc28bb0b2019-02-25 14:20:47 -0800113
Colin Cross98be1bb2019-12-13 20:41:13 -0800114 ctx.Register(config)
Paul Duffinbaccf7e2019-06-11 11:58:30 +0100115 _, errs := ctx.ParseBlueprintsFiles("Android.bp")
Logan Chien42039712018-03-12 16:29:17 +0800116 android.FailIfErrored(t, errs)
Colin Cross72bb3632017-07-13 16:23:21 -0700117 _, errs = ctx.PrepareBuildActions(config)
Logan Chien42039712018-03-12 16:29:17 +0800118 android.FailIfErrored(t, errs)
Colin Cross527012a2017-11-30 22:56:16 -0800119}
120
Jeongik Cha2cc570d2019-10-29 15:44:45 +0900121func testJavaError(t *testing.T, pattern string, bp string) (*android.TestContext, android.Config) {
Jeongik Cha538c0d02019-07-11 15:54:27 +0900122 t.Helper()
Colin Cross98be1bb2019-12-13 20:41:13 -0800123 return testJavaErrorWithConfig(t, pattern, testConfig(nil, bp, nil))
Jeongik Cha2cc570d2019-10-29 15:44:45 +0900124}
125
Colin Cross98be1bb2019-12-13 20:41:13 -0800126func testJavaErrorWithConfig(t *testing.T, pattern string, config android.Config) (*android.TestContext, android.Config) {
Jeongik Cha2cc570d2019-10-29 15:44:45 +0900127 t.Helper()
Colin Cross98be1bb2019-12-13 20:41:13 -0800128 ctx := testContext()
Jeongik Cha538c0d02019-07-11 15:54:27 +0900129
Colin Cross98be1bb2019-12-13 20:41:13 -0800130 pathCtx := android.PathContextForTesting(config)
Martin Stjernholm40f9f3c2020-01-20 18:12:23 +0000131 dexpreopt.SetTestGlobalConfig(config, dexpreopt.GlobalConfigForTests(pathCtx))
Jeongik Cha538c0d02019-07-11 15:54:27 +0900132
Colin Cross98be1bb2019-12-13 20:41:13 -0800133 ctx.Register(config)
Jeongik Cha538c0d02019-07-11 15:54:27 +0900134 _, errs := ctx.ParseBlueprintsFiles("Android.bp")
135 if len(errs) > 0 {
136 android.FailIfNoMatchingErrors(t, pattern, errs)
Jeongik Cha2cc570d2019-10-29 15:44:45 +0900137 return ctx, config
Jeongik Cha538c0d02019-07-11 15:54:27 +0900138 }
139 _, errs = ctx.PrepareBuildActions(config)
140 if len(errs) > 0 {
141 android.FailIfNoMatchingErrors(t, pattern, errs)
Jeongik Cha2cc570d2019-10-29 15:44:45 +0900142 return ctx, config
Jeongik Cha538c0d02019-07-11 15:54:27 +0900143 }
144
145 t.Fatalf("missing expected error %q (0 errors are returned)", pattern)
Jeongik Cha2cc570d2019-10-29 15:44:45 +0900146
147 return ctx, config
Jeongik Cha538c0d02019-07-11 15:54:27 +0900148}
149
Colin Cross238c1f32020-06-07 16:58:18 -0700150func testJavaWithFS(t *testing.T, bp string, fs map[string][]byte) (*android.TestContext, android.Config) {
151 t.Helper()
152 return testJavaWithConfig(t, testConfig(nil, bp, fs))
153}
154
Jaewoong Jungf9a04432019-07-17 11:15:09 -0700155func testJava(t *testing.T, bp string) (*android.TestContext, android.Config) {
Colin Cross6b4a32d2017-12-05 13:42:45 -0800156 t.Helper()
Colin Cross238c1f32020-06-07 16:58:18 -0700157 return testJavaWithFS(t, bp, nil)
Jeongik Cha2cc570d2019-10-29 15:44:45 +0900158}
159
Colin Cross98be1bb2019-12-13 20:41:13 -0800160func testJavaWithConfig(t *testing.T, config android.Config) (*android.TestContext, android.Config) {
Jeongik Cha2cc570d2019-10-29 15:44:45 +0900161 t.Helper()
Colin Cross98be1bb2019-12-13 20:41:13 -0800162 ctx := testContext()
Colin Cross527012a2017-11-30 22:56:16 -0800163 run(t, ctx, config)
Colin Cross72bb3632017-07-13 16:23:21 -0700164
Jaewoong Jungf9a04432019-07-17 11:15:09 -0700165 return ctx, config
Colin Cross72bb3632017-07-13 16:23:21 -0700166}
167
Colin Cross2acdae82017-09-15 19:44:24 -0700168func moduleToPath(name string) string {
169 switch {
170 case name == `""`:
171 return name
Colin Crossfc3674a2017-09-18 17:41:52 -0700172 case strings.HasSuffix(name, ".jar"):
173 return name
Nan Zhanged19fc32017-10-19 13:06:22 -0700174 default:
175 return filepath.Join(buildDir, ".intermediates", name, "android_common", "turbine-combined", name+".jar")
Colin Cross2acdae82017-09-15 19:44:24 -0700176 }
177}
178
Jeongik Chae403e9e2019-12-07 00:16:24 +0900179func TestJavaLinkType(t *testing.T) {
Colin Cross323dc602020-09-18 14:25:31 -0700180 t.Parallel()
Jeongik Chae403e9e2019-12-07 00:16:24 +0900181 testJava(t, `
182 java_library {
183 name: "foo",
184 srcs: ["a.java"],
185 libs: ["bar"],
186 static_libs: ["baz"],
187 }
188
189 java_library {
190 name: "bar",
191 sdk_version: "current",
192 srcs: ["b.java"],
193 }
194
195 java_library {
196 name: "baz",
197 sdk_version: "system_current",
198 srcs: ["c.java"],
199 }
200 `)
201
202 testJavaError(t, "Adjust sdk_version: property of the source or target module so that target module is built with the same or smaller API set than the source.", `
203 java_library {
204 name: "foo",
205 srcs: ["a.java"],
206 libs: ["bar"],
207 sdk_version: "current",
208 static_libs: ["baz"],
209 }
210
211 java_library {
212 name: "bar",
213 sdk_version: "current",
214 srcs: ["b.java"],
215 }
216
217 java_library {
218 name: "baz",
219 sdk_version: "system_current",
220 srcs: ["c.java"],
221 }
222 `)
223
224 testJava(t, `
225 java_library {
226 name: "foo",
227 srcs: ["a.java"],
228 libs: ["bar"],
229 sdk_version: "system_current",
230 static_libs: ["baz"],
231 }
232
233 java_library {
234 name: "bar",
235 sdk_version: "current",
236 srcs: ["b.java"],
237 }
238
239 java_library {
240 name: "baz",
241 sdk_version: "system_current",
242 srcs: ["c.java"],
243 }
244 `)
245
246 testJavaError(t, "Adjust sdk_version: property of the source or target module so that target module is built with the same or smaller API set than the source.", `
247 java_library {
248 name: "foo",
249 srcs: ["a.java"],
250 libs: ["bar"],
251 sdk_version: "system_current",
252 static_libs: ["baz"],
253 }
254
255 java_library {
256 name: "bar",
257 sdk_version: "current",
258 srcs: ["b.java"],
259 }
260
261 java_library {
262 name: "baz",
263 srcs: ["c.java"],
264 }
265 `)
266}
267
Colin Cross72bb3632017-07-13 16:23:21 -0700268func TestSimple(t *testing.T) {
Colin Cross323dc602020-09-18 14:25:31 -0700269 t.Parallel()
Jaewoong Jungf9a04432019-07-17 11:15:09 -0700270 ctx, _ := testJava(t, `
Colin Cross72bb3632017-07-13 16:23:21 -0700271 java_library {
272 name: "foo",
273 srcs: ["a.java"],
Colin Crosse8dc34a2017-07-19 11:22:16 -0700274 libs: ["bar"],
275 static_libs: ["baz"],
Colin Cross72bb3632017-07-13 16:23:21 -0700276 }
277
278 java_library {
279 name: "bar",
280 srcs: ["b.java"],
281 }
282
283 java_library {
284 name: "baz",
285 srcs: ["c.java"],
286 }
Colin Crossd5934c82017-10-02 13:55:26 -0700287 `)
Colin Cross72bb3632017-07-13 16:23:21 -0700288
Colin Cross4c428df2017-09-15 17:36:05 -0700289 javac := ctx.ModuleForTests("foo", "android_common").Rule("javac")
Nan Zhanged19fc32017-10-19 13:06:22 -0700290 combineJar := ctx.ModuleForTests("foo", "android_common").Description("for javac")
Colin Cross72bb3632017-07-13 16:23:21 -0700291
292 if len(javac.Inputs) != 1 || javac.Inputs[0].String() != "a.java" {
293 t.Errorf(`foo inputs %v != ["a.java"]`, javac.Inputs)
294 }
295
Colin Cross1ee23172017-10-18 14:44:18 -0700296 baz := ctx.ModuleForTests("baz", "android_common").Rule("javac").Output.String()
Nan Zhanged19fc32017-10-19 13:06:22 -0700297 barTurbine := filepath.Join(buildDir, ".intermediates", "bar", "android_common", "turbine-combined", "bar.jar")
298 bazTurbine := filepath.Join(buildDir, ".intermediates", "baz", "android_common", "turbine-combined", "baz.jar")
Colin Cross0a6e0072017-08-30 14:24:55 -0700299
Nan Zhanged19fc32017-10-19 13:06:22 -0700300 if !strings.Contains(javac.Args["classpath"], barTurbine) {
301 t.Errorf("foo classpath %v does not contain %q", javac.Args["classpath"], barTurbine)
Colin Cross72bb3632017-07-13 16:23:21 -0700302 }
303
Nan Zhanged19fc32017-10-19 13:06:22 -0700304 if !strings.Contains(javac.Args["classpath"], bazTurbine) {
305 t.Errorf("foo classpath %v does not contain %q", javac.Args["classpath"], bazTurbine)
Colin Cross0a6e0072017-08-30 14:24:55 -0700306 }
307
308 if len(combineJar.Inputs) != 2 || combineJar.Inputs[1].String() != baz {
309 t.Errorf("foo combineJar inputs %v does not contain %q", combineJar.Inputs, baz)
Colin Cross72bb3632017-07-13 16:23:21 -0700310 }
311}
312
Artur Satayev9cf46692019-11-26 18:08:34 +0000313func TestExportedPlugins(t *testing.T) {
Colin Cross323dc602020-09-18 14:25:31 -0700314 t.Parallel()
Artur Satayev9cf46692019-11-26 18:08:34 +0000315 type Result struct {
316 library string
317 processors string
318 }
319 var tests = []struct {
320 name string
321 extra string
322 results []Result
323 }{
324 {
325 name: "Exported plugin is not a direct plugin",
326 extra: `java_library { name: "exports", srcs: ["a.java"], exported_plugins: ["plugin"] }`,
327 results: []Result{{library: "exports", processors: "-proc:none"}},
328 },
329 {
330 name: "Exports plugin to dependee",
331 extra: `
332 java_library{name: "exports", exported_plugins: ["plugin"]}
333 java_library{name: "foo", srcs: ["a.java"], libs: ["exports"]}
334 java_library{name: "bar", srcs: ["a.java"], static_libs: ["exports"]}
335 `,
336 results: []Result{
337 {library: "foo", processors: "-processor com.android.TestPlugin"},
338 {library: "bar", processors: "-processor com.android.TestPlugin"},
339 },
340 },
341 {
342 name: "Exports plugin to android_library",
343 extra: `
344 java_library{name: "exports", exported_plugins: ["plugin"]}
345 android_library{name: "foo", srcs: ["a.java"], libs: ["exports"]}
346 android_library{name: "bar", srcs: ["a.java"], static_libs: ["exports"]}
347 `,
348 results: []Result{
349 {library: "foo", processors: "-processor com.android.TestPlugin"},
350 {library: "bar", processors: "-processor com.android.TestPlugin"},
351 },
352 },
353 {
354 name: "Exports plugin is not propagated via transitive deps",
355 extra: `
356 java_library{name: "exports", exported_plugins: ["plugin"]}
357 java_library{name: "foo", srcs: ["a.java"], libs: ["exports"]}
358 java_library{name: "bar", srcs: ["a.java"], static_libs: ["foo"]}
359 `,
360 results: []Result{
361 {library: "foo", processors: "-processor com.android.TestPlugin"},
362 {library: "bar", processors: "-proc:none"},
363 },
364 },
365 {
366 name: "Exports plugin appends to plugins",
367 extra: `
368 java_plugin{name: "plugin2", processor_class: "com.android.TestPlugin2"}
369 java_library{name: "exports", exported_plugins: ["plugin"]}
370 java_library{name: "foo", srcs: ["a.java"], libs: ["exports"], plugins: ["plugin2"]}
371 `,
372 results: []Result{
373 {library: "foo", processors: "-processor com.android.TestPlugin,com.android.TestPlugin2"},
374 },
375 },
376 }
377
378 for _, test := range tests {
379 t.Run(test.name, func(t *testing.T) {
380 ctx, _ := testJava(t, `
381 java_plugin {
382 name: "plugin",
383 processor_class: "com.android.TestPlugin",
384 }
385 `+test.extra)
386
387 for _, want := range test.results {
388 javac := ctx.ModuleForTests(want.library, "android_common").Rule("javac")
389 if javac.Args["processor"] != want.processors {
390 t.Errorf("For library %v, expected %v, found %v", want.library, want.processors, javac.Args["processor"])
391 }
392 }
393 })
394 }
395}
396
Jeongik Cha2cc570d2019-10-29 15:44:45 +0900397func TestSdkVersionByPartition(t *testing.T) {
Colin Cross323dc602020-09-18 14:25:31 -0700398 t.Parallel()
Jeongik Cha2cc570d2019-10-29 15:44:45 +0900399 testJavaError(t, "sdk_version must have a value when the module is located at vendor or product", `
Jeongik Cha6bd33c12019-06-25 16:26:18 +0900400 java_library {
401 name: "foo",
402 srcs: ["a.java"],
403 vendor: true,
404 }
Jeongik Cha2cc570d2019-10-29 15:44:45 +0900405 `)
Jeongik Cha6bd33c12019-06-25 16:26:18 +0900406
Jeongik Cha2cc570d2019-10-29 15:44:45 +0900407 testJava(t, `
Jeongik Cha6bd33c12019-06-25 16:26:18 +0900408 java_library {
409 name: "bar",
410 srcs: ["b.java"],
411 }
412 `)
413
Jeongik Cha2cc570d2019-10-29 15:44:45 +0900414 for _, enforce := range []bool{true, false} {
Jeongik Cha2cc570d2019-10-29 15:44:45 +0900415 bp := `
416 java_library {
417 name: "foo",
418 srcs: ["a.java"],
419 product_specific: true,
420 }
421 `
Colin Cross98be1bb2019-12-13 20:41:13 -0800422
423 config := testConfig(nil, bp, nil)
424 config.TestProductVariables.EnforceProductPartitionInterface = proptools.BoolPtr(enforce)
Jeongik Cha2cc570d2019-10-29 15:44:45 +0900425 if enforce {
Colin Cross98be1bb2019-12-13 20:41:13 -0800426 testJavaErrorWithConfig(t, "sdk_version must have a value when the module is located at vendor or product", config)
Jeongik Cha2cc570d2019-10-29 15:44:45 +0900427 } else {
Colin Cross98be1bb2019-12-13 20:41:13 -0800428 testJavaWithConfig(t, config)
Jeongik Cha2cc570d2019-10-29 15:44:45 +0900429 }
Jeongik Cha6bd33c12019-06-25 16:26:18 +0900430 }
431}
432
Colin Crossd5934c82017-10-02 13:55:26 -0700433func TestArchSpecific(t *testing.T) {
Colin Cross323dc602020-09-18 14:25:31 -0700434 t.Parallel()
Jaewoong Jungf9a04432019-07-17 11:15:09 -0700435 ctx, _ := testJava(t, `
Colin Crossd5934c82017-10-02 13:55:26 -0700436 java_library {
437 name: "foo",
438 srcs: ["a.java"],
439 target: {
440 android: {
441 srcs: ["b.java"],
442 },
443 },
444 }
445 `)
446
447 javac := ctx.ModuleForTests("foo", "android_common").Rule("javac")
448 if len(javac.Inputs) != 2 || javac.Inputs[0].String() != "a.java" || javac.Inputs[1].String() != "b.java" {
449 t.Errorf(`foo inputs %v != ["a.java", "b.java"]`, javac.Inputs)
450 }
451}
452
Colin Cross6b4a32d2017-12-05 13:42:45 -0800453func TestBinary(t *testing.T) {
Colin Cross323dc602020-09-18 14:25:31 -0700454 t.Parallel()
Jaewoong Jungf9a04432019-07-17 11:15:09 -0700455 ctx, _ := testJava(t, `
Colin Cross6b4a32d2017-12-05 13:42:45 -0800456 java_library_host {
457 name: "foo",
458 srcs: ["a.java"],
459 }
460
461 java_binary_host {
462 name: "bar",
463 srcs: ["b.java"],
464 static_libs: ["foo"],
465 }
466 `)
467
468 buildOS := android.BuildOs.String()
469
470 bar := ctx.ModuleForTests("bar", buildOS+"_common")
471 barJar := bar.Output("bar.jar").Output.String()
472 barWrapper := ctx.ModuleForTests("bar", buildOS+"_x86_64")
473 barWrapperDeps := barWrapper.Output("bar").Implicits.Strings()
474
475 // Test that the install binary wrapper depends on the installed jar file
476 if len(barWrapperDeps) != 1 || barWrapperDeps[0] != barJar {
477 t.Errorf("expected binary wrapper implicits [%q], got %v",
478 barJar, barWrapperDeps)
479 }
Alex Humesky2070e322020-06-09 20:23:08 -0400480}
Colin Cross6b4a32d2017-12-05 13:42:45 -0800481
Alex Humesky2070e322020-06-09 20:23:08 -0400482func TestHostBinaryNoJavaDebugInfoOverride(t *testing.T) {
Colin Cross323dc602020-09-18 14:25:31 -0700483 t.Parallel()
Alex Humesky2070e322020-06-09 20:23:08 -0400484 bp := `
485 java_library {
486 name: "target_library",
487 srcs: ["a.java"],
488 }
489
490 java_binary_host {
491 name: "host_binary",
492 srcs: ["b.java"],
493 }
494 `
495 config := testConfig(nil, bp, nil)
496 config.TestProductVariables.MinimizeJavaDebugInfo = proptools.BoolPtr(true)
497
498 ctx, _ := testJavaWithConfig(t, config)
499
Liz Kammer7941b302020-07-28 13:27:34 -0700500 // first, check that the -g flag is added to target modules
Alex Humesky2070e322020-06-09 20:23:08 -0400501 targetLibrary := ctx.ModuleForTests("target_library", "android_common")
502 targetJavaFlags := targetLibrary.Module().VariablesForTests()["javacFlags"]
503 if !strings.Contains(targetJavaFlags, "-g:source,lines") {
504 t.Errorf("target library javac flags %v should contain "+
505 "-g:source,lines override with MinimizeJavaDebugInfo", targetJavaFlags)
506 }
507
508 // check that -g is not overridden for host modules
509 buildOS := android.BuildOs.String()
510 hostBinary := ctx.ModuleForTests("host_binary", buildOS+"_common")
511 hostJavaFlags := hostBinary.Module().VariablesForTests()["javacFlags"]
512 if strings.Contains(hostJavaFlags, "-g:source,lines") {
513 t.Errorf("java_binary_host javac flags %v should not have "+
514 "-g:source,lines override with MinimizeJavaDebugInfo", hostJavaFlags)
515 }
Colin Cross6b4a32d2017-12-05 13:42:45 -0800516}
517
Colin Cross72bb3632017-07-13 16:23:21 -0700518func TestPrebuilts(t *testing.T) {
Colin Cross323dc602020-09-18 14:25:31 -0700519 t.Parallel()
Jaewoong Jungf9a04432019-07-17 11:15:09 -0700520 ctx, _ := testJava(t, `
Colin Cross72bb3632017-07-13 16:23:21 -0700521 java_library {
522 name: "foo",
Paul Duffin91547182019-11-12 19:39:36 +0000523 srcs: ["a.java", ":stubs-source"],
Paul Duffinfcfd7912020-01-31 17:54:30 +0000524 libs: ["bar", "sdklib"],
Colin Crosse8dc34a2017-07-19 11:22:16 -0700525 static_libs: ["baz"],
Colin Cross72bb3632017-07-13 16:23:21 -0700526 }
527
Colin Cross74d73e22017-08-02 11:05:49 -0700528 java_import {
Colin Cross72bb3632017-07-13 16:23:21 -0700529 name: "bar",
Colin Cross74d73e22017-08-02 11:05:49 -0700530 jars: ["a.jar"],
Colin Cross72bb3632017-07-13 16:23:21 -0700531 }
532
Colin Cross74d73e22017-08-02 11:05:49 -0700533 java_import {
Colin Cross72bb3632017-07-13 16:23:21 -0700534 name: "baz",
Colin Cross74d73e22017-08-02 11:05:49 -0700535 jars: ["b.jar"],
Liz Kammerd6c31d22020-08-05 15:40:41 -0700536 sdk_version: "current",
537 compile_dex: true,
Colin Cross72bb3632017-07-13 16:23:21 -0700538 }
Colin Cross42be7612019-02-21 18:12:14 -0800539
540 dex_import {
541 name: "qux",
542 jars: ["b.jar"],
543 }
Colin Cross79c7c262019-04-17 11:11:46 -0700544
545 java_sdk_library_import {
Paul Duffin56d44902020-01-31 13:36:25 +0000546 name: "sdklib",
547 public: {
548 jars: ["c.jar"],
549 },
550 }
551
Paul Duffin91547182019-11-12 19:39:36 +0000552 prebuilt_stubs_sources {
553 name: "stubs-source",
Paul Duffin9b478b02019-12-10 13:41:51 +0000554 srcs: ["stubs/sources"],
Paul Duffin91547182019-11-12 19:39:36 +0000555 }
Paul Duffin1b82e6a2019-12-03 18:06:47 +0000556
557 java_test_import {
558 name: "test",
559 jars: ["a.jar"],
560 test_suites: ["cts"],
561 test_config: "AndroidTest.xml",
562 }
Colin Cross72bb3632017-07-13 16:23:21 -0700563 `)
564
Paul Duffin9b478b02019-12-10 13:41:51 +0000565 fooModule := ctx.ModuleForTests("foo", "android_common")
566 javac := fooModule.Rule("javac")
Nan Zhanged19fc32017-10-19 13:06:22 -0700567 combineJar := ctx.ModuleForTests("foo", "android_common").Description("for javac")
Liz Kammerd6c31d22020-08-05 15:40:41 -0700568 barModule := ctx.ModuleForTests("bar", "android_common")
569 barJar := barModule.Rule("combineJar").Output
570 bazModule := ctx.ModuleForTests("baz", "android_common")
571 bazJar := bazModule.Rule("combineJar").Output
Colin Cross79c7c262019-04-17 11:11:46 -0700572 sdklibStubsJar := ctx.ModuleForTests("sdklib.stubs", "android_common").Rule("combineJar").Output
Colin Cross72bb3632017-07-13 16:23:21 -0700573
Paul Duffin9b478b02019-12-10 13:41:51 +0000574 fooLibrary := fooModule.Module().(*Library)
575 assertDeepEquals(t, "foo java sources incorrect",
576 []string{"a.java"}, fooLibrary.compiledJavaSrcs.Strings())
Paul Duffin91547182019-11-12 19:39:36 +0000577
Paul Duffin9b478b02019-12-10 13:41:51 +0000578 assertDeepEquals(t, "foo java source jars incorrect",
579 []string{".intermediates/stubs-source/android_common/stubs-source-stubs.srcjar"},
580 android.NormalizePathsForTesting(fooLibrary.compiledSrcJars))
Paul Duffin91547182019-11-12 19:39:36 +0000581
Colin Cross37f6d792018-07-12 12:28:41 -0700582 if !strings.Contains(javac.Args["classpath"], barJar.String()) {
583 t.Errorf("foo classpath %v does not contain %q", javac.Args["classpath"], barJar.String())
Colin Cross72bb3632017-07-13 16:23:21 -0700584 }
585
Liz Kammerd6c31d22020-08-05 15:40:41 -0700586 barDexJar := barModule.Module().(*Import).DexJarBuildPath()
587 if barDexJar != nil {
588 t.Errorf("bar dex jar build path expected to be nil, got %q", barDexJar)
589 }
590
Colin Cross79c7c262019-04-17 11:11:46 -0700591 if !strings.Contains(javac.Args["classpath"], sdklibStubsJar.String()) {
592 t.Errorf("foo classpath %v does not contain %q", javac.Args["classpath"], sdklibStubsJar.String())
593 }
594
Colin Cross37f6d792018-07-12 12:28:41 -0700595 if len(combineJar.Inputs) != 2 || combineJar.Inputs[1].String() != bazJar.String() {
596 t.Errorf("foo combineJar inputs %v does not contain %q", combineJar.Inputs, bazJar.String())
Colin Cross72bb3632017-07-13 16:23:21 -0700597 }
Colin Cross42be7612019-02-21 18:12:14 -0800598
Liz Kammerd6c31d22020-08-05 15:40:41 -0700599 bazDexJar := bazModule.Module().(*Import).DexJarBuildPath().String()
600 expectedDexJar := buildDir + "/.intermediates/baz/android_common/dex/baz.jar"
601 if bazDexJar != expectedDexJar {
602 t.Errorf("baz dex jar build path expected %q, got %q", expectedDexJar, bazDexJar)
603 }
604
Colin Cross42be7612019-02-21 18:12:14 -0800605 ctx.ModuleForTests("qux", "android_common").Rule("Cp")
Colin Cross72bb3632017-07-13 16:23:21 -0700606}
607
Paul Duffin9b478b02019-12-10 13:41:51 +0000608func assertDeepEquals(t *testing.T, message string, expected interface{}, actual interface{}) {
609 if !reflect.DeepEqual(expected, actual) {
610 t.Errorf("%s: expected %q, found %q", message, expected, actual)
611 }
612}
613
Paul Duffin56d44902020-01-31 13:36:25 +0000614func TestJavaSdkLibraryImport(t *testing.T) {
Colin Cross323dc602020-09-18 14:25:31 -0700615 t.Parallel()
Paul Duffin56d44902020-01-31 13:36:25 +0000616 ctx, _ := testJava(t, `
617 java_library {
618 name: "foo",
619 srcs: ["a.java"],
620 libs: ["sdklib"],
621 sdk_version: "current",
622 }
623
624 java_library {
625 name: "foo.system",
626 srcs: ["a.java"],
627 libs: ["sdklib"],
628 sdk_version: "system_current",
629 }
630
631 java_library {
632 name: "foo.test",
633 srcs: ["a.java"],
634 libs: ["sdklib"],
635 sdk_version: "test_current",
636 }
637
638 java_sdk_library_import {
639 name: "sdklib",
640 public: {
641 jars: ["a.jar"],
642 },
643 system: {
644 jars: ["b.jar"],
645 },
646 test: {
647 jars: ["c.jar"],
Paul Duffin0f8faff2020-05-20 16:18:00 +0100648 stub_srcs: ["c.java"],
Paul Duffin56d44902020-01-31 13:36:25 +0000649 },
650 }
651 `)
652
653 for _, scope := range []string{"", ".system", ".test"} {
654 fooModule := ctx.ModuleForTests("foo"+scope, "android_common")
655 javac := fooModule.Rule("javac")
656
657 sdklibStubsJar := ctx.ModuleForTests("sdklib.stubs"+scope, "android_common").Rule("combineJar").Output
658 if !strings.Contains(javac.Args["classpath"], sdklibStubsJar.String()) {
659 t.Errorf("foo classpath %v does not contain %q", javac.Args["classpath"], sdklibStubsJar.String())
660 }
661 }
Paul Duffinca8d9a52020-06-26 22:20:25 +0100662
Paul Duffincee7e662020-07-09 17:32:57 +0100663 CheckModuleDependencies(t, ctx, "sdklib", "android_common", []string{
Paul Duffinca8d9a52020-06-26 22:20:25 +0100664 `prebuilt_sdklib.stubs`,
665 `prebuilt_sdklib.stubs.source.test`,
666 `prebuilt_sdklib.stubs.system`,
667 `prebuilt_sdklib.stubs.test`,
668 })
669}
670
671func TestJavaSdkLibraryImport_WithSource(t *testing.T) {
Colin Cross323dc602020-09-18 14:25:31 -0700672 t.Parallel()
Paul Duffinca8d9a52020-06-26 22:20:25 +0100673 ctx, _ := testJava(t, `
674 java_sdk_library {
675 name: "sdklib",
676 srcs: ["a.java"],
677 sdk_version: "none",
678 system_modules: "none",
679 public: {
680 enabled: true,
681 },
682 }
683
684 java_sdk_library_import {
685 name: "sdklib",
686 public: {
687 jars: ["a.jar"],
688 },
689 }
690 `)
691
Paul Duffincee7e662020-07-09 17:32:57 +0100692 CheckModuleDependencies(t, ctx, "sdklib", "android_common", []string{
Paul Duffinca8d9a52020-06-26 22:20:25 +0100693 `dex2oatd`,
694 `prebuilt_sdklib`,
695 `sdklib.impl`,
696 `sdklib.stubs`,
697 `sdklib.stubs.source`,
698 `sdklib.xml`,
699 })
700
Paul Duffincee7e662020-07-09 17:32:57 +0100701 CheckModuleDependencies(t, ctx, "prebuilt_sdklib", "android_common", []string{
Paul Duffin44f1d842020-06-26 20:17:02 +0100702 `prebuilt_sdklib.stubs`,
Paul Duffinca8d9a52020-06-26 22:20:25 +0100703 `sdklib.impl`,
704 // This should be prebuilt_sdklib.stubs but is set to sdklib.stubs because the
705 // dependency is added after prebuilts may have been renamed and so has to use
706 // the renamed name.
Paul Duffinca8d9a52020-06-26 22:20:25 +0100707 `sdklib.xml`,
708 })
709}
710
711func TestJavaSdkLibraryImport_Preferred(t *testing.T) {
Colin Cross323dc602020-09-18 14:25:31 -0700712 t.Parallel()
Paul Duffinca8d9a52020-06-26 22:20:25 +0100713 ctx, _ := testJava(t, `
714 java_sdk_library {
715 name: "sdklib",
716 srcs: ["a.java"],
717 sdk_version: "none",
718 system_modules: "none",
719 public: {
720 enabled: true,
721 },
722 }
723
724 java_sdk_library_import {
725 name: "sdklib",
726 prefer: true,
727 public: {
728 jars: ["a.jar"],
729 },
730 }
731 `)
732
Paul Duffincee7e662020-07-09 17:32:57 +0100733 CheckModuleDependencies(t, ctx, "sdklib", "android_common", []string{
Paul Duffinca8d9a52020-06-26 22:20:25 +0100734 `dex2oatd`,
735 `prebuilt_sdklib`,
Paul Duffinca8d9a52020-06-26 22:20:25 +0100736 `sdklib.impl`,
Paul Duffin80342d72020-06-26 22:08:43 +0100737 `sdklib.stubs`,
Paul Duffinca8d9a52020-06-26 22:20:25 +0100738 `sdklib.stubs.source`,
739 `sdklib.xml`,
740 })
741
Paul Duffincee7e662020-07-09 17:32:57 +0100742 CheckModuleDependencies(t, ctx, "prebuilt_sdklib", "android_common", []string{
Paul Duffinca8d9a52020-06-26 22:20:25 +0100743 `prebuilt_sdklib.stubs`,
744 `sdklib.impl`,
745 `sdklib.xml`,
746 })
Paul Duffin56d44902020-01-31 13:36:25 +0000747}
748
Colin Cross89536d42017-07-07 14:35:50 -0700749func TestDefaults(t *testing.T) {
Colin Cross323dc602020-09-18 14:25:31 -0700750 t.Parallel()
Jaewoong Jungf9a04432019-07-17 11:15:09 -0700751 ctx, _ := testJava(t, `
Colin Cross89536d42017-07-07 14:35:50 -0700752 java_defaults {
753 name: "defaults",
754 srcs: ["a.java"],
755 libs: ["bar"],
756 static_libs: ["baz"],
Sasha Smundak2057f822019-04-16 17:16:58 -0700757 optimize: {enabled: false},
Colin Cross89536d42017-07-07 14:35:50 -0700758 }
759
760 java_library {
761 name: "foo",
762 defaults: ["defaults"],
763 }
764
765 java_library {
766 name: "bar",
767 srcs: ["b.java"],
768 }
769
770 java_library {
771 name: "baz",
772 srcs: ["c.java"],
773 }
Sasha Smundak2057f822019-04-16 17:16:58 -0700774
775 android_test {
776 name: "atestOptimize",
777 defaults: ["defaults"],
778 optimize: {enabled: true},
779 }
780
781 android_test {
782 name: "atestNoOptimize",
783 defaults: ["defaults"],
784 }
785
786 android_test {
787 name: "atestDefault",
788 srcs: ["a.java"],
789 }
Colin Cross89536d42017-07-07 14:35:50 -0700790 `)
791
Colin Cross4c428df2017-09-15 17:36:05 -0700792 javac := ctx.ModuleForTests("foo", "android_common").Rule("javac")
Nan Zhanged19fc32017-10-19 13:06:22 -0700793 combineJar := ctx.ModuleForTests("foo", "android_common").Description("for javac")
Colin Cross89536d42017-07-07 14:35:50 -0700794
795 if len(javac.Inputs) != 1 || javac.Inputs[0].String() != "a.java" {
796 t.Errorf(`foo inputs %v != ["a.java"]`, javac.Inputs)
797 }
798
Nan Zhanged19fc32017-10-19 13:06:22 -0700799 barTurbine := filepath.Join(buildDir, ".intermediates", "bar", "android_common", "turbine-combined", "bar.jar")
800 if !strings.Contains(javac.Args["classpath"], barTurbine) {
801 t.Errorf("foo classpath %v does not contain %q", javac.Args["classpath"], barTurbine)
Colin Cross89536d42017-07-07 14:35:50 -0700802 }
803
Colin Cross1ee23172017-10-18 14:44:18 -0700804 baz := ctx.ModuleForTests("baz", "android_common").Rule("javac").Output.String()
Colin Cross0a6e0072017-08-30 14:24:55 -0700805 if len(combineJar.Inputs) != 2 || combineJar.Inputs[1].String() != baz {
806 t.Errorf("foo combineJar inputs %v does not contain %q", combineJar.Inputs, baz)
Colin Cross89536d42017-07-07 14:35:50 -0700807 }
Sasha Smundak2057f822019-04-16 17:16:58 -0700808
809 atestOptimize := ctx.ModuleForTests("atestOptimize", "android_common").MaybeRule("r8")
810 if atestOptimize.Output == nil {
811 t.Errorf("atestOptimize should optimize APK")
812 }
813
814 atestNoOptimize := ctx.ModuleForTests("atestNoOptimize", "android_common").MaybeRule("d8")
815 if atestNoOptimize.Output == nil {
816 t.Errorf("atestNoOptimize should not optimize APK")
817 }
818
819 atestDefault := ctx.ModuleForTests("atestDefault", "android_common").MaybeRule("r8")
820 if atestDefault.Output == nil {
821 t.Errorf("atestDefault should optimize APK")
822 }
Colin Cross89536d42017-07-07 14:35:50 -0700823}
824
Colin Cross0f37af02017-09-27 17:42:05 -0700825func TestResources(t *testing.T) {
Colin Cross323dc602020-09-18 14:25:31 -0700826 t.Parallel()
Colin Cross0f37af02017-09-27 17:42:05 -0700827 var table = []struct {
828 name string
829 prop string
830 extra string
831 args string
832 }{
833 {
Colin Crossaf9c55b2017-10-03 14:50:08 -0700834 // Test that a module with java_resource_dirs includes the files
Colin Cross0f37af02017-09-27 17:42:05 -0700835 name: "resource dirs",
Colin Cross824bee32017-11-22 17:27:51 -0800836 prop: `java_resource_dirs: ["java-res"]`,
Colin Cross0ead1d72018-04-10 13:07:42 -0700837 args: "-C java-res -f java-res/a/a -f java-res/b/b",
Colin Cross0f37af02017-09-27 17:42:05 -0700838 },
839 {
840 // Test that a module with java_resources includes the files
841 name: "resource files",
Colin Cross0ead1d72018-04-10 13:07:42 -0700842 prop: `java_resources: ["java-res/a/a", "java-res/b/b"]`,
843 args: "-C . -f java-res/a/a -f java-res/b/b",
Colin Cross0f37af02017-09-27 17:42:05 -0700844 },
845 {
846 // Test that a module with a filegroup in java_resources includes the files with the
847 // path prefix
848 name: "resource filegroup",
849 prop: `java_resources: [":foo-res"]`,
850 extra: `
851 filegroup {
852 name: "foo-res",
Colin Cross824bee32017-11-22 17:27:51 -0800853 path: "java-res",
Colin Cross0ead1d72018-04-10 13:07:42 -0700854 srcs: ["java-res/a/a", "java-res/b/b"],
Colin Cross0f37af02017-09-27 17:42:05 -0700855 }`,
Colin Cross0ead1d72018-04-10 13:07:42 -0700856 args: "-C java-res -f java-res/a/a -f java-res/b/b",
Colin Cross0f37af02017-09-27 17:42:05 -0700857 },
858 {
Colin Cross0ead1d72018-04-10 13:07:42 -0700859 // Test that a module with wildcards in java_resource_dirs has the correct path prefixes
860 name: "wildcard dirs",
861 prop: `java_resource_dirs: ["java-res/*"]`,
862 args: "-C java-res/a -f java-res/a/a -C java-res/b -f java-res/b/b",
863 },
864 {
865 // Test that a module exclude_java_resource_dirs excludes the files
866 name: "wildcard dirs",
867 prop: `java_resource_dirs: ["java-res/*"], exclude_java_resource_dirs: ["java-res/b"]`,
868 args: "-C java-res/a -f java-res/a/a",
869 },
Colin Crosscedd4762018-09-13 11:26:19 -0700870 {
871 // Test wildcards in java_resources
872 name: "wildcard files",
873 prop: `java_resources: ["java-res/**/*"]`,
874 args: "-C . -f java-res/a/a -f java-res/b/b",
875 },
876 {
877 // Test exclude_java_resources with java_resources
878 name: "wildcard files with exclude",
879 prop: `java_resources: ["java-res/**/*"], exclude_java_resources: ["java-res/b/*"]`,
880 args: "-C . -f java-res/a/a",
881 },
882 {
883 // Test exclude_java_resources with java_resource_dirs
884 name: "resource dirs with exclude files",
885 prop: `java_resource_dirs: ["java-res"], exclude_java_resources: ["java-res/b/b"]`,
886 args: "-C java-res -f java-res/a/a",
887 },
888 {
889 // Test exclude_java_resource_dirs with java_resource_dirs
890 name: "resource dirs with exclude files",
891 prop: `java_resource_dirs: ["java-res", "java-res2"], exclude_java_resource_dirs: ["java-res2"]`,
892 args: "-C java-res -f java-res/a/a -f java-res/b/b",
893 },
Colin Cross0f37af02017-09-27 17:42:05 -0700894 }
895
896 for _, test := range table {
897 t.Run(test.name, func(t *testing.T) {
Colin Cross238c1f32020-06-07 16:58:18 -0700898 ctx, _ := testJavaWithFS(t, `
Colin Cross0f37af02017-09-27 17:42:05 -0700899 java_library {
900 name: "foo",
901 srcs: [
902 "a.java",
903 "b.java",
904 "c.java",
905 ],
906 `+test.prop+`,
907 }
Colin Cross238c1f32020-06-07 16:58:18 -0700908 `+test.extra,
909 map[string][]byte{
910 "java-res/a/a": nil,
911 "java-res/b/b": nil,
912 "java-res2/a": nil,
913 },
914 )
Colin Cross0f37af02017-09-27 17:42:05 -0700915
Colin Cross331a1212018-08-15 20:40:52 -0700916 foo := ctx.ModuleForTests("foo", "android_common").Output("withres/foo.jar")
Colin Cross1ee23172017-10-18 14:44:18 -0700917 fooRes := ctx.ModuleForTests("foo", "android_common").Output("res/foo.jar")
Colin Cross0f37af02017-09-27 17:42:05 -0700918
919 if !inList(fooRes.Output.String(), foo.Inputs.Strings()) {
920 t.Errorf("foo combined jars %v does not contain %q",
921 foo.Inputs.Strings(), fooRes.Output.String())
922 }
923
Colin Crossaf9c55b2017-10-03 14:50:08 -0700924 if fooRes.Args["jarArgs"] != test.args {
925 t.Errorf("foo resource jar args %q is not %q",
Colin Cross0f37af02017-09-27 17:42:05 -0700926 fooRes.Args["jarArgs"], test.args)
927 }
928 })
929 }
930}
931
Colin Cross0c4ce212019-05-03 15:28:19 -0700932func TestIncludeSrcs(t *testing.T) {
Colin Cross323dc602020-09-18 14:25:31 -0700933 t.Parallel()
Colin Cross238c1f32020-06-07 16:58:18 -0700934 ctx, _ := testJavaWithFS(t, `
Colin Cross0c4ce212019-05-03 15:28:19 -0700935 java_library {
936 name: "foo",
937 srcs: [
938 "a.java",
939 "b.java",
940 "c.java",
941 ],
942 include_srcs: true,
943 }
944
945 java_library {
946 name: "bar",
947 srcs: [
948 "a.java",
949 "b.java",
950 "c.java",
951 ],
952 java_resource_dirs: ["java-res"],
953 include_srcs: true,
954 }
Colin Cross238c1f32020-06-07 16:58:18 -0700955 `, map[string][]byte{
956 "java-res/a/a": nil,
957 "java-res/b/b": nil,
958 "java-res2/a": nil,
959 })
Colin Cross0c4ce212019-05-03 15:28:19 -0700960
961 // Test a library with include_srcs: true
962 foo := ctx.ModuleForTests("foo", "android_common").Output("withres/foo.jar")
963 fooSrcJar := ctx.ModuleForTests("foo", "android_common").Output("foo.srcjar")
964
965 if g, w := fooSrcJar.Output.String(), foo.Inputs.Strings(); !inList(g, w) {
966 t.Errorf("foo combined jars %v does not contain %q", w, g)
967 }
968
969 if g, w := fooSrcJar.Args["jarArgs"], "-C . -f a.java -f b.java -f c.java"; g != w {
970 t.Errorf("foo source jar args %q is not %q", w, g)
971 }
972
973 // Test a library with include_srcs: true and resources
974 bar := ctx.ModuleForTests("bar", "android_common").Output("withres/bar.jar")
975 barResCombined := ctx.ModuleForTests("bar", "android_common").Output("res-combined/bar.jar")
976 barRes := ctx.ModuleForTests("bar", "android_common").Output("res/bar.jar")
977 barSrcJar := ctx.ModuleForTests("bar", "android_common").Output("bar.srcjar")
978
979 if g, w := barSrcJar.Output.String(), barResCombined.Inputs.Strings(); !inList(g, w) {
980 t.Errorf("bar combined resource jars %v does not contain %q", w, g)
981 }
982
983 if g, w := barRes.Output.String(), barResCombined.Inputs.Strings(); !inList(g, w) {
984 t.Errorf("bar combined resource jars %v does not contain %q", w, g)
985 }
986
987 if g, w := barResCombined.Output.String(), bar.Inputs.Strings(); !inList(g, w) {
988 t.Errorf("bar combined jars %v does not contain %q", w, g)
989 }
990
991 if g, w := barSrcJar.Args["jarArgs"], "-C . -f a.java -f b.java -f c.java"; g != w {
992 t.Errorf("bar source jar args %q is not %q", w, g)
993 }
994
995 if g, w := barRes.Args["jarArgs"], "-C java-res -f java-res/a/a -f java-res/b/b"; g != w {
996 t.Errorf("bar resource jar args %q is not %q", w, g)
997 }
998}
999
Colin Cross54190b32017-10-09 15:34:10 -07001000func TestGeneratedSources(t *testing.T) {
Colin Cross323dc602020-09-18 14:25:31 -07001001 t.Parallel()
Colin Cross238c1f32020-06-07 16:58:18 -07001002 ctx, _ := testJavaWithFS(t, `
Colin Cross54190b32017-10-09 15:34:10 -07001003 java_library {
1004 name: "foo",
1005 srcs: [
1006 "a*.java",
1007 ":gen",
1008 "b*.java",
1009 ],
1010 }
1011
1012 genrule {
1013 name: "gen",
Colin Cross824bee32017-11-22 17:27:51 -08001014 tool_files: ["java-res/a"],
Colin Cross54190b32017-10-09 15:34:10 -07001015 out: ["gen.java"],
1016 }
Colin Cross238c1f32020-06-07 16:58:18 -07001017 `, map[string][]byte{
1018 "a.java": nil,
1019 "b.java": nil,
1020 })
Colin Cross54190b32017-10-09 15:34:10 -07001021
1022 javac := ctx.ModuleForTests("foo", "android_common").Rule("javac")
1023 genrule := ctx.ModuleForTests("gen", "").Rule("generator")
1024
Colin Cross15e86d92017-10-20 15:07:08 -07001025 if filepath.Base(genrule.Output.String()) != "gen.java" {
1026 t.Fatalf(`gen output file %v is not ".../gen.java"`, genrule.Output.String())
Colin Cross54190b32017-10-09 15:34:10 -07001027 }
1028
1029 if len(javac.Inputs) != 3 ||
1030 javac.Inputs[0].String() != "a.java" ||
Colin Cross15e86d92017-10-20 15:07:08 -07001031 javac.Inputs[1].String() != genrule.Output.String() ||
Colin Cross54190b32017-10-09 15:34:10 -07001032 javac.Inputs[2].String() != "b.java" {
1033 t.Errorf(`foo inputs %v != ["a.java", ".../gen.java", "b.java"]`, javac.Inputs)
1034 }
1035}
1036
Nan Zhang61eaedb2017-11-02 13:28:15 -07001037func TestTurbine(t *testing.T) {
Colin Cross323dc602020-09-18 14:25:31 -07001038 t.Parallel()
Jaewoong Jungf9a04432019-07-17 11:15:09 -07001039 ctx, _ := testJava(t, `
Nan Zhang61eaedb2017-11-02 13:28:15 -07001040 java_library {
1041 name: "foo",
1042 srcs: ["a.java"],
Jiyong Park2d492942018-03-05 17:44:10 +09001043 sdk_version: "14",
Nan Zhang61eaedb2017-11-02 13:28:15 -07001044 }
1045
1046 java_library {
1047 name: "bar",
Colin Cross9bc43432017-12-15 20:20:39 -08001048 srcs: ["b.java"],
Nan Zhang61eaedb2017-11-02 13:28:15 -07001049 static_libs: ["foo"],
Jiyong Park2d492942018-03-05 17:44:10 +09001050 sdk_version: "14",
Nan Zhang61eaedb2017-11-02 13:28:15 -07001051 }
1052
1053 java_library {
1054 name: "baz",
1055 srcs: ["c.java"],
1056 libs: ["bar"],
1057 sdk_version: "14",
1058 }
1059 `)
1060
1061 fooTurbine := ctx.ModuleForTests("foo", "android_common").Rule("turbine")
1062 barTurbine := ctx.ModuleForTests("bar", "android_common").Rule("turbine")
1063 barJavac := ctx.ModuleForTests("bar", "android_common").Rule("javac")
1064 barTurbineCombined := ctx.ModuleForTests("bar", "android_common").Description("for turbine")
1065 bazJavac := ctx.ModuleForTests("baz", "android_common").Rule("javac")
1066
1067 if len(fooTurbine.Inputs) != 1 || fooTurbine.Inputs[0].String() != "a.java" {
1068 t.Errorf(`foo inputs %v != ["a.java"]`, fooTurbine.Inputs)
1069 }
1070
1071 fooHeaderJar := filepath.Join(buildDir, ".intermediates", "foo", "android_common", "turbine-combined", "foo.jar")
1072 if !strings.Contains(barTurbine.Args["classpath"], fooHeaderJar) {
1073 t.Errorf("bar turbine classpath %v does not contain %q", barTurbine.Args["classpath"], fooHeaderJar)
1074 }
1075 if !strings.Contains(barJavac.Args["classpath"], fooHeaderJar) {
1076 t.Errorf("bar javac classpath %v does not contain %q", barJavac.Args["classpath"], fooHeaderJar)
1077 }
1078 if len(barTurbineCombined.Inputs) != 2 || barTurbineCombined.Inputs[1].String() != fooHeaderJar {
1079 t.Errorf("bar turbine combineJar inputs %v does not contain %q", barTurbineCombined.Inputs, fooHeaderJar)
1080 }
Anton Hanssonf66efeb2018-04-11 13:57:30 +01001081 if !strings.Contains(bazJavac.Args["classpath"], "prebuilts/sdk/14/public/android.jar") {
Nan Zhang61eaedb2017-11-02 13:28:15 -07001082 t.Errorf("baz javac classpath %v does not contain %q", bazJavac.Args["classpath"],
Anton Hanssonf66efeb2018-04-11 13:57:30 +01001083 "prebuilts/sdk/14/public/android.jar")
Nan Zhang61eaedb2017-11-02 13:28:15 -07001084 }
1085}
1086
1087func TestSharding(t *testing.T) {
Colin Cross323dc602020-09-18 14:25:31 -07001088 t.Parallel()
Jaewoong Jungf9a04432019-07-17 11:15:09 -07001089 ctx, _ := testJava(t, `
Nan Zhang61eaedb2017-11-02 13:28:15 -07001090 java_library {
1091 name: "bar",
1092 srcs: ["a.java","b.java","c.java"],
1093 javac_shard_size: 1
1094 }
1095 `)
1096
1097 barHeaderJar := filepath.Join(buildDir, ".intermediates", "bar", "android_common", "turbine-combined", "bar.jar")
1098 for i := 0; i < 3; i++ {
1099 barJavac := ctx.ModuleForTests("bar", "android_common").Description("javac" + strconv.Itoa(i))
1100 if !strings.Contains(barJavac.Args["classpath"], barHeaderJar) {
1101 t.Errorf("bar javac classpath %v does not contain %q", barJavac.Args["classpath"], barHeaderJar)
1102 }
1103 }
1104}
1105
Nan Zhang581fd212018-01-10 16:06:12 -08001106func TestDroiddoc(t *testing.T) {
Colin Cross323dc602020-09-18 14:25:31 -07001107 t.Parallel()
Colin Cross238c1f32020-06-07 16:58:18 -07001108 ctx, _ := testJavaWithFS(t, `
Paul Duffin884363e2019-12-19 10:21:09 +00001109 droiddoc_exported_dir {
Dan Willemsencc090972018-02-26 14:33:31 -08001110 name: "droiddoc-templates-sdk",
1111 path: ".",
1112 }
Jiyong Park29074592019-07-07 16:27:47 +09001113 filegroup {
1114 name: "bar-doc-aidl-srcs",
1115 srcs: ["bar-doc/IBar.aidl"],
1116 path: "bar-doc",
1117 }
Liz Kammere1ab2502020-09-10 15:29:25 +00001118 droidstubs {
1119 name: "bar-stubs",
Liz Kammer3a55c912020-08-14 12:14:02 -07001120 srcs: [
Steve Kim3666c702020-09-01 17:58:01 +00001121 "bar-doc/a.java",
Liz Kammer3a55c912020-08-14 12:14:02 -07001122 ],
Steve Kim3666c702020-09-01 17:58:01 +00001123 exclude_srcs: [
1124 "bar-doc/b.java"
1125 ],
Liz Kammere1ab2502020-09-10 15:29:25 +00001126 api_levels_annotations_dirs: [
1127 "droiddoc-templates-sdk",
1128 ],
1129 api_levels_annotations_enabled: true,
1130 }
1131 droiddoc {
1132 name: "bar-doc",
1133 srcs: [
1134 ":bar-stubs",
1135 "bar-doc/IFoo.aidl",
1136 ":bar-doc-aidl-srcs",
1137 ],
Dan Willemsencc090972018-02-26 14:33:31 -08001138 custom_template: "droiddoc-templates-sdk",
Nan Zhang581fd212018-01-10 16:06:12 -08001139 hdf: [
1140 "android.whichdoc offline",
1141 ],
1142 knowntags: [
1143 "bar-doc/known_oj_tags.txt",
1144 ],
1145 proofread_file: "libcore-proofread.txt",
1146 todo_file: "libcore-docs-todo.html",
Liz Kammer585cac22020-07-06 09:12:57 -07001147 flags: ["-offlinemode -title \"libcore\""],
Nan Zhang581fd212018-01-10 16:06:12 -08001148 }
Colin Cross238c1f32020-06-07 16:58:18 -07001149 `,
1150 map[string][]byte{
1151 "bar-doc/a.java": nil,
1152 "bar-doc/b.java": nil,
1153 })
Liz Kammere1ab2502020-09-10 15:29:25 +00001154 barStubs := ctx.ModuleForTests("bar-stubs", "android_common")
1155 barStubsOutputs, err := barStubs.Module().(*Droidstubs).OutputFiles("")
1156 if err != nil {
1157 t.Errorf("Unexpected error %q retrieving \"bar-stubs\" output file", err)
1158 }
1159 if len(barStubsOutputs) != 1 {
1160 t.Errorf("Expected one output from \"bar-stubs\" got %s", barStubsOutputs)
Liz Kammer1e2ee122020-07-30 15:07:22 -07001161 }
Nan Zhang581fd212018-01-10 16:06:12 -08001162
Liz Kammere1ab2502020-09-10 15:29:25 +00001163 barStubsOutput := barStubsOutputs[0]
1164 barDoc := ctx.ModuleForTests("bar-doc", "android_common")
1165 javaDoc := barDoc.Rule("javadoc")
1166 if g, w := javaDoc.Implicits.Strings(), barStubsOutput.String(); !inList(w, g) {
1167 t.Errorf("implicits of bar-doc must contain %q, but was %q.", w, g)
Jiyong Park29074592019-07-07 16:27:47 +09001168 }
1169
Liz Kammere1ab2502020-09-10 15:29:25 +00001170 expected := "-sourcepath " + buildDir + "/.intermediates/bar-doc/android_common/srcjars "
1171 if !strings.Contains(javaDoc.RuleParams.Command, expected) {
1172 t.Errorf("bar-doc command does not contain flag %q, but should\n%q", expected, javaDoc.RuleParams.Command)
1173 }
1174
1175 aidl := barDoc.Rule("aidl")
1176 if g, w := javaDoc.Implicits.Strings(), aidl.Output.String(); !inList(w, g) {
Colin Crossc0806172019-06-14 18:51:47 -07001177 t.Errorf("implicits of bar-doc must contain %q, but was %q.", w, g)
1178 }
1179
1180 if g, w := aidl.Implicits.Strings(), []string{"bar-doc/IBar.aidl", "bar-doc/IFoo.aidl"}; !reflect.DeepEqual(w, g) {
1181 t.Errorf("aidl inputs must be %q, but was %q", w, g)
Jiyong Park1e440682018-05-23 18:42:04 +09001182 }
Nan Zhang581fd212018-01-10 16:06:12 -08001183}
1184
Liz Kammer585cac22020-07-06 09:12:57 -07001185func TestDroiddocArgsAndFlagsCausesError(t *testing.T) {
Colin Cross323dc602020-09-18 14:25:31 -07001186 t.Parallel()
Liz Kammer585cac22020-07-06 09:12:57 -07001187 testJavaError(t, "flags is set. Cannot set args", `
1188 droiddoc_exported_dir {
1189 name: "droiddoc-templates-sdk",
1190 path: ".",
1191 }
1192 filegroup {
1193 name: "bar-doc-aidl-srcs",
1194 srcs: ["bar-doc/IBar.aidl"],
1195 path: "bar-doc",
1196 }
Liz Kammere1ab2502020-09-10 15:29:25 +00001197 droidstubs {
1198 name: "bar-stubs",
Liz Kammer3a55c912020-08-14 12:14:02 -07001199 srcs: [
Steve Kim3666c702020-09-01 17:58:01 +00001200 "bar-doc/a.java",
Liz Kammer3a55c912020-08-14 12:14:02 -07001201 ],
Steve Kim3666c702020-09-01 17:58:01 +00001202 exclude_srcs: [
1203 "bar-doc/b.java"
1204 ],
Liz Kammere1ab2502020-09-10 15:29:25 +00001205 api_levels_annotations_dirs: [
1206 "droiddoc-templates-sdk",
1207 ],
1208 api_levels_annotations_enabled: true,
1209 }
1210 droiddoc {
1211 name: "bar-doc",
1212 srcs: [
1213 ":bar-stubs",
1214 "bar-doc/IFoo.aidl",
1215 ":bar-doc-aidl-srcs",
1216 ],
Liz Kammer585cac22020-07-06 09:12:57 -07001217 custom_template: "droiddoc-templates-sdk",
1218 hdf: [
1219 "android.whichdoc offline",
1220 ],
1221 knowntags: [
1222 "bar-doc/known_oj_tags.txt",
1223 ],
1224 proofread_file: "libcore-proofread.txt",
1225 todo_file: "libcore-docs-todo.html",
1226 flags: ["-offlinemode -title \"libcore\""],
1227 args: "-offlinemode -title \"libcore\"",
1228 }
1229 `)
1230}
1231
Liz Kammer3d894b72020-08-04 09:55:13 -07001232func TestDroidstubs(t *testing.T) {
Colin Cross323dc602020-09-18 14:25:31 -07001233 t.Parallel()
Liz Kammer3d894b72020-08-04 09:55:13 -07001234 ctx, _ := testJavaWithFS(t, `
1235 droiddoc_exported_dir {
1236 name: "droiddoc-templates-sdk",
1237 path: ".",
1238 }
1239
1240 droidstubs {
1241 name: "bar-stubs",
1242 srcs: [
1243 "bar-doc/a.java",
1244 ],
1245 api_levels_annotations_dirs: [
1246 "droiddoc-templates-sdk",
1247 ],
1248 api_levels_annotations_enabled: true,
1249 }
1250
1251 droidstubs {
1252 name: "bar-stubs-other",
1253 srcs: [
1254 "bar-doc/a.java",
1255 ],
1256 api_levels_annotations_dirs: [
1257 "droiddoc-templates-sdk",
1258 ],
1259 api_levels_annotations_enabled: true,
1260 api_levels_jar_filename: "android.other.jar",
1261 }
1262 `,
1263 map[string][]byte{
1264 "bar-doc/a.java": nil,
1265 })
1266 testcases := []struct {
1267 moduleName string
1268 expectedJarFilename string
1269 }{
1270 {
1271 moduleName: "bar-stubs",
1272 expectedJarFilename: "android.jar",
1273 },
1274 {
1275 moduleName: "bar-stubs-other",
1276 expectedJarFilename: "android.other.jar",
1277 },
1278 }
1279 for _, c := range testcases {
1280 m := ctx.ModuleForTests(c.moduleName, "android_common")
1281 metalava := m.Rule("metalava")
1282 expected := "--android-jar-pattern ./%/public/" + c.expectedJarFilename
1283 if actual := metalava.RuleParams.Command; !strings.Contains(actual, expected) {
1284 t.Errorf("For %q, expected metalava argument %q, but was not found %q", c.moduleName, expected, actual)
1285 }
1286 }
1287}
1288
Paul Duffin83a2d962019-11-19 19:44:10 +00001289func TestDroidstubsWithSystemModules(t *testing.T) {
Colin Cross323dc602020-09-18 14:25:31 -07001290 t.Parallel()
Paul Duffin83a2d962019-11-19 19:44:10 +00001291 ctx, _ := testJava(t, `
1292 droidstubs {
1293 name: "stubs-source-system-modules",
1294 srcs: [
Colin Cross238c1f32020-06-07 16:58:18 -07001295 "bar-doc/a.java",
Paul Duffin83a2d962019-11-19 19:44:10 +00001296 ],
1297 sdk_version: "none",
1298 system_modules: "source-system-modules",
1299 }
1300
1301 java_library {
1302 name: "source-jar",
1303 srcs: [
1304 "a.java",
1305 ],
1306 }
1307
1308 java_system_modules {
1309 name: "source-system-modules",
1310 libs: ["source-jar"],
1311 }
1312
1313 droidstubs {
1314 name: "stubs-prebuilt-system-modules",
1315 srcs: [
Colin Cross238c1f32020-06-07 16:58:18 -07001316 "bar-doc/a.java",
Paul Duffin83a2d962019-11-19 19:44:10 +00001317 ],
1318 sdk_version: "none",
1319 system_modules: "prebuilt-system-modules",
1320 }
1321
1322 java_import {
1323 name: "prebuilt-jar",
1324 jars: ["a.jar"],
1325 }
1326
1327 java_system_modules_import {
1328 name: "prebuilt-system-modules",
1329 libs: ["prebuilt-jar"],
1330 }
1331 `)
1332
1333 checkSystemModulesUseByDroidstubs(t, ctx, "stubs-source-system-modules", "source-jar.jar")
1334
1335 checkSystemModulesUseByDroidstubs(t, ctx, "stubs-prebuilt-system-modules", "prebuilt-jar.jar")
1336}
1337
1338func checkSystemModulesUseByDroidstubs(t *testing.T, ctx *android.TestContext, moduleName string, systemJar string) {
1339 metalavaRule := ctx.ModuleForTests(moduleName, "android_common").Rule("metalava")
1340 var systemJars []string
1341 for _, i := range metalavaRule.Implicits {
1342 systemJars = append(systemJars, i.Base())
1343 }
Ramy Medhatc7965cd2020-04-30 03:08:37 -04001344 if len(systemJars) < 1 || systemJars[0] != systemJar {
Paul Duffin83a2d962019-11-19 19:44:10 +00001345 t.Errorf("inputs of %q must be []string{%q}, but was %#v.", moduleName, systemJar, systemJars)
1346 }
1347}
1348
Colin Cross54250902017-12-05 09:28:08 -08001349func TestJarGenrules(t *testing.T) {
Colin Cross323dc602020-09-18 14:25:31 -07001350 t.Parallel()
Jaewoong Jungf9a04432019-07-17 11:15:09 -07001351 ctx, _ := testJava(t, `
Colin Cross54250902017-12-05 09:28:08 -08001352 java_library {
1353 name: "foo",
1354 srcs: ["a.java"],
1355 }
1356
1357 java_genrule {
1358 name: "jargen",
1359 tool_files: ["b.java"],
1360 cmd: "$(location b.java) $(in) $(out)",
1361 out: ["jargen.jar"],
1362 srcs: [":foo"],
1363 }
1364
1365 java_library {
1366 name: "bar",
1367 static_libs: ["jargen"],
1368 srcs: ["c.java"],
1369 }
1370
1371 java_library {
1372 name: "baz",
1373 libs: ["jargen"],
1374 srcs: ["c.java"],
1375 }
1376 `)
1377
1378 foo := ctx.ModuleForTests("foo", "android_common").Output("javac/foo.jar")
1379 jargen := ctx.ModuleForTests("jargen", "android_common").Output("jargen.jar")
1380 bar := ctx.ModuleForTests("bar", "android_common").Output("javac/bar.jar")
1381 baz := ctx.ModuleForTests("baz", "android_common").Output("javac/baz.jar")
1382 barCombined := ctx.ModuleForTests("bar", "android_common").Output("combined/bar.jar")
1383
1384 if len(jargen.Inputs) != 1 || jargen.Inputs[0].String() != foo.Output.String() {
1385 t.Errorf("expected jargen inputs [%q], got %q", foo.Output.String(), jargen.Inputs.Strings())
1386 }
1387
1388 if !strings.Contains(bar.Args["classpath"], jargen.Output.String()) {
1389 t.Errorf("bar classpath %v does not contain %q", bar.Args["classpath"], jargen.Output.String())
1390 }
1391
1392 if !strings.Contains(baz.Args["classpath"], jargen.Output.String()) {
1393 t.Errorf("baz classpath %v does not contain %q", baz.Args["classpath"], jargen.Output.String())
1394 }
1395
1396 if len(barCombined.Inputs) != 2 ||
1397 barCombined.Inputs[0].String() != bar.Output.String() ||
1398 barCombined.Inputs[1].String() != jargen.Output.String() {
1399 t.Errorf("bar combined jar inputs %v is not [%q, %q]",
1400 barCombined.Inputs.Strings(), bar.Output.String(), jargen.Output.String())
1401 }
1402}
1403
Nan Zhang27e284d2018-02-09 21:03:53 +00001404func TestExcludeFileGroupInSrcs(t *testing.T) {
Colin Cross323dc602020-09-18 14:25:31 -07001405 t.Parallel()
Jaewoong Jungf9a04432019-07-17 11:15:09 -07001406 ctx, _ := testJava(t, `
Nan Zhang27e284d2018-02-09 21:03:53 +00001407 java_library {
1408 name: "foo",
1409 srcs: ["a.java", ":foo-srcs"],
1410 exclude_srcs: ["a.java", ":foo-excludes"],
1411 }
1412
1413 filegroup {
1414 name: "foo-srcs",
1415 srcs: ["java-fg/a.java", "java-fg/b.java", "java-fg/c.java"],
1416 }
1417
1418 filegroup {
1419 name: "foo-excludes",
1420 srcs: ["java-fg/a.java", "java-fg/b.java"],
1421 }
1422 `)
1423
1424 javac := ctx.ModuleForTests("foo", "android_common").Rule("javac")
1425
1426 if len(javac.Inputs) != 1 || javac.Inputs[0].String() != "java-fg/c.java" {
1427 t.Errorf(`foo inputs %v != ["java-fg/c.java"]`, javac.Inputs)
1428 }
1429}
Jiyong Parkc678ad32018-04-10 13:07:10 +09001430
Paul Duffin52d398a2019-06-11 12:31:14 +01001431func TestJavaLibrary(t *testing.T) {
Colin Cross323dc602020-09-18 14:25:31 -07001432 t.Parallel()
Colin Cross98be1bb2019-12-13 20:41:13 -08001433 config := testConfig(nil, "", map[string][]byte{
Paul Duffin52d398a2019-06-11 12:31:14 +01001434 "libcore/Android.bp": []byte(`
1435 java_library {
1436 name: "core",
1437 sdk_version: "none",
1438 system_modules: "none",
1439 }`),
1440 })
Colin Cross98be1bb2019-12-13 20:41:13 -08001441 ctx := testContext()
Paul Duffin52d398a2019-06-11 12:31:14 +01001442 run(t, ctx, config)
1443}
1444
Jiyong Parkc678ad32018-04-10 13:07:10 +09001445func TestJavaSdkLibrary(t *testing.T) {
Colin Cross323dc602020-09-18 14:25:31 -07001446 t.Parallel()
Jaewoong Jungf9a04432019-07-17 11:15:09 -07001447 ctx, _ := testJava(t, `
Paul Duffin884363e2019-12-19 10:21:09 +00001448 droiddoc_exported_dir {
Jiyong Parkc678ad32018-04-10 13:07:10 +09001449 name: "droiddoc-templates-sdk",
1450 path: ".",
1451 }
Jiyong Parkc678ad32018-04-10 13:07:10 +09001452 java_sdk_library {
1453 name: "foo",
1454 srcs: ["a.java", "b.java"],
1455 api_packages: ["foo"],
1456 }
1457 java_sdk_library {
1458 name: "bar",
1459 srcs: ["a.java", "b.java"],
1460 api_packages: ["bar"],
1461 }
1462 java_library {
1463 name: "baz",
1464 srcs: ["c.java"],
Paul Duffin859fe962020-05-15 10:20:31 +01001465 libs: ["foo", "bar.stubs"],
Jiyong Parkc678ad32018-04-10 13:07:10 +09001466 sdk_version: "system_current",
1467 }
Paul Duffindfa131e2020-05-15 20:37:11 +01001468 java_sdk_library {
1469 name: "barney",
1470 srcs: ["c.java"],
1471 api_only: true,
1472 }
1473 java_sdk_library {
1474 name: "betty",
1475 srcs: ["c.java"],
1476 shared_library: false,
1477 }
Paul Duffin859fe962020-05-15 10:20:31 +01001478 java_sdk_library_import {
1479 name: "quuz",
1480 public: {
1481 jars: ["c.jar"],
1482 },
1483 }
1484 java_sdk_library_import {
1485 name: "fred",
1486 public: {
1487 jars: ["b.jar"],
1488 },
1489 }
Paul Duffindfa131e2020-05-15 20:37:11 +01001490 java_sdk_library_import {
1491 name: "wilma",
1492 public: {
1493 jars: ["b.jar"],
1494 },
1495 shared_library: false,
1496 }
Jiyong Park1be96912018-05-28 18:02:19 +09001497 java_library {
1498 name: "qux",
1499 srcs: ["c.java"],
Paul Duffindfa131e2020-05-15 20:37:11 +01001500 libs: ["baz", "fred", "quuz.stubs", "wilma", "barney", "betty"],
Jiyong Park1be96912018-05-28 18:02:19 +09001501 sdk_version: "system_current",
1502 }
Paul Duffin726d23c2020-01-22 16:30:37 +00001503 java_library {
1504 name: "baz-test",
1505 srcs: ["c.java"],
1506 libs: ["foo"],
1507 sdk_version: "test_current",
1508 }
Paul Duffina2db18f2020-01-22 17:11:15 +00001509 java_library {
1510 name: "baz-29",
1511 srcs: ["c.java"],
1512 libs: ["foo"],
1513 sdk_version: "system_29",
1514 }
Paul Duffinfb6ae5b2020-09-30 15:17:25 +01001515 java_library {
1516 name: "baz-module-30",
1517 srcs: ["c.java"],
1518 libs: ["foo"],
1519 sdk_version: "module_30",
1520 }
Jiyong Parkc678ad32018-04-10 13:07:10 +09001521 `)
1522
1523 // check the existence of the internal modules
1524 ctx.ModuleForTests("foo", "android_common")
Paul Duffindd9d0742020-05-08 15:52:37 +01001525 ctx.ModuleForTests(apiScopePublic.stubsLibraryModuleName("foo"), "android_common")
1526 ctx.ModuleForTests(apiScopeSystem.stubsLibraryModuleName("foo"), "android_common")
1527 ctx.ModuleForTests(apiScopeTest.stubsLibraryModuleName("foo"), "android_common")
1528 ctx.ModuleForTests(apiScopePublic.stubsSourceModuleName("foo"), "android_common")
1529 ctx.ModuleForTests(apiScopeSystem.stubsSourceModuleName("foo"), "android_common")
1530 ctx.ModuleForTests(apiScopeTest.stubsSourceModuleName("foo"), "android_common")
Jiyong Parke3833882020-02-17 17:28:10 +09001531 ctx.ModuleForTests("foo"+sdkXmlFileSuffix, "android_common")
Jiyong Park58c518b2018-05-12 22:29:12 +09001532 ctx.ModuleForTests("foo.api.public.28", "")
1533 ctx.ModuleForTests("foo.api.system.28", "")
1534 ctx.ModuleForTests("foo.api.test.28", "")
Jiyong Parkc678ad32018-04-10 13:07:10 +09001535
1536 bazJavac := ctx.ModuleForTests("baz", "android_common").Rule("javac")
1537 // tests if baz is actually linked to the stubs lib
1538 if !strings.Contains(bazJavac.Args["classpath"], "foo.stubs.system.jar") {
1539 t.Errorf("baz javac classpath %v does not contain %q", bazJavac.Args["classpath"],
1540 "foo.stubs.system.jar")
1541 }
1542 // ... and not to the impl lib
Sundong Ahn054b19a2018-10-19 13:46:09 +09001543 if strings.Contains(bazJavac.Args["classpath"], "foo.jar") {
Jiyong Parkc678ad32018-04-10 13:07:10 +09001544 t.Errorf("baz javac classpath %v should not contain %q", bazJavac.Args["classpath"],
Sundong Ahn054b19a2018-10-19 13:46:09 +09001545 "foo.jar")
Jiyong Parkc678ad32018-04-10 13:07:10 +09001546 }
1547 // test if baz is not linked to the system variant of foo
1548 if strings.Contains(bazJavac.Args["classpath"], "foo.stubs.jar") {
1549 t.Errorf("baz javac classpath %v should not contain %q", bazJavac.Args["classpath"],
1550 "foo.stubs.jar")
1551 }
Jiyong Park1be96912018-05-28 18:02:19 +09001552
Paul Duffin726d23c2020-01-22 16:30:37 +00001553 bazTestJavac := ctx.ModuleForTests("baz-test", "android_common").Rule("javac")
1554 // tests if baz-test is actually linked to the test stubs lib
1555 if !strings.Contains(bazTestJavac.Args["classpath"], "foo.stubs.test.jar") {
1556 t.Errorf("baz-test javac classpath %v does not contain %q", bazTestJavac.Args["classpath"],
1557 "foo.stubs.test.jar")
1558 }
1559
Paul Duffina2db18f2020-01-22 17:11:15 +00001560 baz29Javac := ctx.ModuleForTests("baz-29", "android_common").Rule("javac")
1561 // tests if baz-29 is actually linked to the system 29 stubs lib
1562 if !strings.Contains(baz29Javac.Args["classpath"], "prebuilts/sdk/29/system/foo.jar") {
1563 t.Errorf("baz-29 javac classpath %v does not contain %q", baz29Javac.Args["classpath"],
1564 "prebuilts/sdk/29/system/foo.jar")
1565 }
1566
Paul Duffinfb6ae5b2020-09-30 15:17:25 +01001567 bazModule30Javac := ctx.ModuleForTests("baz-module-30", "android_common").Rule("javac")
1568 // tests if "baz-module-30" is actually linked to the module 30 stubs lib
1569 if !strings.Contains(bazModule30Javac.Args["classpath"], "prebuilts/sdk/30/module-lib/foo.jar") {
1570 t.Errorf("baz-module-30 javac classpath %v does not contain %q", bazModule30Javac.Args["classpath"],
1571 "prebuilts/sdk/30/module-lib/foo.jar")
1572 }
1573
Jiyong Park1be96912018-05-28 18:02:19 +09001574 // test if baz has exported SDK lib names foo and bar to qux
1575 qux := ctx.ModuleForTests("qux", "android_common")
1576 if quxLib, ok := qux.Module().(*Library); ok {
Ulya Trafimovichb8063c62020-08-20 11:33:12 +01001577 sdkLibs := android.SortedStringKeys(quxLib.ExportedSdkLibs())
Paul Duffin859fe962020-05-15 10:20:31 +01001578 if w := []string{"bar", "foo", "fred", "quuz"}; !reflect.DeepEqual(w, sdkLibs) {
1579 t.Errorf("qux should export %q but exports %q", w, sdkLibs)
Jiyong Park1be96912018-05-28 18:02:19 +09001580 }
1581 }
Jiyong Parkc678ad32018-04-10 13:07:10 +09001582}
Zoran Jovanovic8736ce22018-08-21 17:10:29 +02001583
Paul Duffindaaa3322020-05-26 18:13:57 +01001584func TestJavaSdkLibrary_DoNotAccessImplWhenItIsNotBuilt(t *testing.T) {
Colin Cross323dc602020-09-18 14:25:31 -07001585 t.Parallel()
Paul Duffindaaa3322020-05-26 18:13:57 +01001586 ctx, _ := testJava(t, `
1587 java_sdk_library {
1588 name: "foo",
1589 srcs: ["a.java"],
1590 api_only: true,
1591 public: {
1592 enabled: true,
1593 },
1594 }
1595
1596 java_library {
1597 name: "bar",
1598 srcs: ["b.java"],
1599 libs: ["foo"],
1600 }
1601 `)
1602
1603 // The bar library should depend on the stubs jar.
1604 barLibrary := ctx.ModuleForTests("bar", "android_common").Rule("javac")
1605 if expected, actual := `^-classpath .*:/[^:]*/turbine-combined/foo\.stubs\.jar$`, barLibrary.Args["classpath"]; !regexp.MustCompile(expected).MatchString(actual) {
1606 t.Errorf("expected %q, found %#q", expected, actual)
1607 }
1608}
1609
Paul Duffin46dc45a2020-05-14 15:39:10 +01001610func TestJavaSdkLibrary_UseSourcesFromAnotherSdkLibrary(t *testing.T) {
Colin Cross323dc602020-09-18 14:25:31 -07001611 t.Parallel()
Paul Duffin46dc45a2020-05-14 15:39:10 +01001612 testJava(t, `
1613 java_sdk_library {
1614 name: "foo",
1615 srcs: ["a.java"],
1616 api_packages: ["foo"],
1617 public: {
1618 enabled: true,
1619 },
1620 }
1621
1622 java_library {
1623 name: "bar",
1624 srcs: ["b.java", ":foo{.public.stubs.source}"],
1625 }
1626 `)
1627}
1628
1629func TestJavaSdkLibrary_AccessOutputFiles_MissingScope(t *testing.T) {
Colin Cross323dc602020-09-18 14:25:31 -07001630 t.Parallel()
Paul Duffin46dc45a2020-05-14 15:39:10 +01001631 testJavaError(t, `"foo" does not provide api scope system`, `
1632 java_sdk_library {
1633 name: "foo",
1634 srcs: ["a.java"],
1635 api_packages: ["foo"],
1636 public: {
1637 enabled: true,
1638 },
1639 }
1640
1641 java_library {
1642 name: "bar",
1643 srcs: ["b.java", ":foo{.system.stubs.source}"],
1644 }
1645 `)
1646}
1647
Paul Duffinca8d9a52020-06-26 22:20:25 +01001648func TestJavaSdkLibrary_Deps(t *testing.T) {
Colin Cross323dc602020-09-18 14:25:31 -07001649 t.Parallel()
Paul Duffinca8d9a52020-06-26 22:20:25 +01001650 ctx, _ := testJava(t, `
1651 java_sdk_library {
1652 name: "sdklib",
1653 srcs: ["a.java"],
1654 sdk_version: "none",
1655 system_modules: "none",
1656 public: {
1657 enabled: true,
1658 },
1659 }
1660 `)
1661
Paul Duffincee7e662020-07-09 17:32:57 +01001662 CheckModuleDependencies(t, ctx, "sdklib", "android_common", []string{
Paul Duffinca8d9a52020-06-26 22:20:25 +01001663 `dex2oatd`,
1664 `sdklib.impl`,
1665 `sdklib.stubs`,
1666 `sdklib.stubs.source`,
1667 `sdklib.xml`,
1668 })
1669}
1670
Paul Duffin46dc45a2020-05-14 15:39:10 +01001671func TestJavaSdkLibraryImport_AccessOutputFiles(t *testing.T) {
Colin Cross323dc602020-09-18 14:25:31 -07001672 t.Parallel()
Paul Duffin46dc45a2020-05-14 15:39:10 +01001673 testJava(t, `
1674 java_sdk_library_import {
1675 name: "foo",
1676 public: {
1677 jars: ["a.jar"],
1678 stub_srcs: ["a.java"],
1679 current_api: "api/current.txt",
1680 removed_api: "api/removed.txt",
1681 },
1682 }
1683
1684 java_library {
1685 name: "bar",
1686 srcs: [":foo{.public.stubs.source}"],
1687 java_resources: [
1688 ":foo{.public.api.txt}",
1689 ":foo{.public.removed-api.txt}",
1690 ],
1691 }
1692 `)
1693}
1694
1695func TestJavaSdkLibraryImport_AccessOutputFiles_Invalid(t *testing.T) {
Colin Cross323dc602020-09-18 14:25:31 -07001696 t.Parallel()
Paul Duffin46dc45a2020-05-14 15:39:10 +01001697 bp := `
1698 java_sdk_library_import {
1699 name: "foo",
1700 public: {
1701 jars: ["a.jar"],
1702 },
1703 }
1704 `
1705
1706 t.Run("stubs.source", func(t *testing.T) {
1707 testJavaError(t, `stubs.source not available for api scope public`, bp+`
1708 java_library {
1709 name: "bar",
1710 srcs: [":foo{.public.stubs.source}"],
1711 java_resources: [
1712 ":foo{.public.api.txt}",
1713 ":foo{.public.removed-api.txt}",
1714 ],
1715 }
1716 `)
1717 })
1718
1719 t.Run("api.txt", func(t *testing.T) {
1720 testJavaError(t, `api.txt not available for api scope public`, bp+`
1721 java_library {
1722 name: "bar",
1723 srcs: ["a.java"],
1724 java_resources: [
1725 ":foo{.public.api.txt}",
1726 ],
1727 }
1728 `)
1729 })
1730
1731 t.Run("removed-api.txt", func(t *testing.T) {
1732 testJavaError(t, `removed-api.txt not available for api scope public`, bp+`
1733 java_library {
1734 name: "bar",
1735 srcs: ["a.java"],
1736 java_resources: [
1737 ":foo{.public.removed-api.txt}",
1738 ],
1739 }
1740 `)
1741 })
1742}
1743
Paul Duffin3375e352020-04-28 10:44:03 +01001744func TestJavaSdkLibrary_InvalidScopes(t *testing.T) {
Colin Cross323dc602020-09-18 14:25:31 -07001745 t.Parallel()
Paul Duffin3375e352020-04-28 10:44:03 +01001746 testJavaError(t, `module "foo": enabled api scope "system" depends on disabled scope "public"`, `
1747 java_sdk_library {
1748 name: "foo",
1749 srcs: ["a.java", "b.java"],
1750 api_packages: ["foo"],
1751 // Explicitly disable public to test the check that ensures the set of enabled
1752 // scopes is consistent.
1753 public: {
1754 enabled: false,
1755 },
1756 system: {
1757 enabled: true,
1758 },
1759 }
1760 `)
1761}
1762
Paul Duffin87a05a32020-05-12 11:50:28 +01001763func TestJavaSdkLibrary_SdkVersion_ForScope(t *testing.T) {
Colin Cross323dc602020-09-18 14:25:31 -07001764 t.Parallel()
Paul Duffin87a05a32020-05-12 11:50:28 +01001765 testJava(t, `
1766 java_sdk_library {
1767 name: "foo",
1768 srcs: ["a.java", "b.java"],
1769 api_packages: ["foo"],
1770 system: {
1771 enabled: true,
1772 sdk_version: "module_current",
1773 },
1774 }
1775 `)
1776}
1777
Paul Duffin0c5bae52020-06-02 13:00:08 +01001778func TestJavaSdkLibrary_ModuleLib(t *testing.T) {
Colin Cross323dc602020-09-18 14:25:31 -07001779 t.Parallel()
Paul Duffin0c5bae52020-06-02 13:00:08 +01001780 testJava(t, `
1781 java_sdk_library {
1782 name: "foo",
1783 srcs: ["a.java", "b.java"],
1784 api_packages: ["foo"],
1785 system: {
1786 enabled: true,
1787 },
1788 module_lib: {
1789 enabled: true,
1790 },
1791 }
1792 `)
1793}
1794
1795func TestJavaSdkLibrary_SystemServer(t *testing.T) {
Colin Cross323dc602020-09-18 14:25:31 -07001796 t.Parallel()
Paul Duffin0c5bae52020-06-02 13:00:08 +01001797 testJava(t, `
1798 java_sdk_library {
1799 name: "foo",
1800 srcs: ["a.java", "b.java"],
1801 api_packages: ["foo"],
1802 system: {
1803 enabled: true,
1804 },
1805 system_server: {
1806 enabled: true,
1807 },
1808 }
1809 `)
1810}
1811
Paul Duffin803a9562020-05-20 11:52:25 +01001812func TestJavaSdkLibrary_MissingScope(t *testing.T) {
Colin Cross323dc602020-09-18 14:25:31 -07001813 t.Parallel()
Paul Duffin803a9562020-05-20 11:52:25 +01001814 testJavaError(t, `requires api scope module-lib from foo but it only has \[\] available`, `
1815 java_sdk_library {
1816 name: "foo",
1817 srcs: ["a.java"],
1818 public: {
1819 enabled: false,
1820 },
1821 }
1822
1823 java_library {
1824 name: "baz",
1825 srcs: ["a.java"],
1826 libs: ["foo"],
1827 sdk_version: "module_current",
1828 }
1829 `)
1830}
1831
1832func TestJavaSdkLibrary_FallbackScope(t *testing.T) {
Colin Cross323dc602020-09-18 14:25:31 -07001833 t.Parallel()
Paul Duffin803a9562020-05-20 11:52:25 +01001834 testJava(t, `
1835 java_sdk_library {
1836 name: "foo",
1837 srcs: ["a.java"],
1838 system: {
1839 enabled: true,
1840 },
1841 }
1842
1843 java_library {
1844 name: "baz",
1845 srcs: ["a.java"],
1846 libs: ["foo"],
1847 // foo does not have module-lib scope so it should fallback to system
1848 sdk_version: "module_current",
1849 }
1850 `)
1851}
1852
Jiyong Park932cdfe2020-05-28 00:19:53 +09001853func TestJavaSdkLibrary_DefaultToStubs(t *testing.T) {
Colin Cross323dc602020-09-18 14:25:31 -07001854 t.Parallel()
Jiyong Park932cdfe2020-05-28 00:19:53 +09001855 ctx, _ := testJava(t, `
1856 java_sdk_library {
1857 name: "foo",
1858 srcs: ["a.java"],
1859 system: {
1860 enabled: true,
1861 },
1862 default_to_stubs: true,
1863 }
1864
1865 java_library {
1866 name: "baz",
1867 srcs: ["a.java"],
1868 libs: ["foo"],
1869 // does not have sdk_version set, should fallback to module,
1870 // which will then fallback to system because the module scope
1871 // is not enabled.
1872 }
1873 `)
1874 // The baz library should depend on the system stubs jar.
1875 bazLibrary := ctx.ModuleForTests("baz", "android_common").Rule("javac")
1876 if expected, actual := `^-classpath .*:/[^:]*/turbine-combined/foo\.stubs.system\.jar$`, bazLibrary.Args["classpath"]; !regexp.MustCompile(expected).MatchString(actual) {
1877 t.Errorf("expected %q, found %#q", expected, actual)
1878 }
1879}
1880
Zoran Jovanovic8736ce22018-08-21 17:10:29 +02001881var compilerFlagsTestCases = []struct {
1882 in string
1883 out bool
1884}{
1885 {
1886 in: "a",
1887 out: false,
1888 },
1889 {
1890 in: "-a",
1891 out: true,
1892 },
1893 {
1894 in: "-no-jdk",
1895 out: false,
1896 },
1897 {
1898 in: "-no-stdlib",
1899 out: false,
1900 },
1901 {
1902 in: "-kotlin-home",
1903 out: false,
1904 },
1905 {
1906 in: "-kotlin-home /some/path",
1907 out: false,
1908 },
1909 {
1910 in: "-include-runtime",
1911 out: false,
1912 },
1913 {
1914 in: "-Xintellij-plugin-root",
1915 out: false,
1916 },
1917}
1918
1919type mockContext struct {
1920 android.ModuleContext
1921 result bool
1922}
1923
1924func (ctx *mockContext) PropertyErrorf(property, format string, args ...interface{}) {
1925 // CheckBadCompilerFlags calls this function when the flag should be rejected
1926 ctx.result = false
1927}
1928
1929func TestCompilerFlags(t *testing.T) {
Colin Cross323dc602020-09-18 14:25:31 -07001930 t.Parallel()
Zoran Jovanovic8736ce22018-08-21 17:10:29 +02001931 for _, testCase := range compilerFlagsTestCases {
1932 ctx := &mockContext{result: true}
1933 CheckKotlincFlags(ctx, []string{testCase.in})
1934 if ctx.result != testCase.out {
1935 t.Errorf("incorrect output:")
1936 t.Errorf(" input: %#v", testCase.in)
1937 t.Errorf(" expected: %#v", testCase.out)
1938 t.Errorf(" got: %#v", ctx.result)
1939 }
1940 }
1941}
Jaewoong Jung38e4fb22018-12-12 09:01:34 -08001942
1943// TODO(jungjw): Consider making this more robust by ignoring path order.
1944func checkPatchModuleFlag(t *testing.T, ctx *android.TestContext, moduleName string, expected string) {
1945 variables := ctx.ModuleForTests(moduleName, "android_common").Module().VariablesForTests()
1946 flags := strings.Split(variables["javacFlags"], " ")
1947 got := ""
1948 for _, flag := range flags {
1949 keyEnd := strings.Index(flag, "=")
1950 if keyEnd > -1 && flag[:keyEnd] == "--patch-module" {
1951 got = flag[keyEnd+1:]
1952 break
1953 }
1954 }
1955 if expected != got {
1956 t.Errorf("Unexpected patch-module flag for module %q - expected %q, but got %q", moduleName, expected, got)
1957 }
1958}
1959
1960func TestPatchModule(t *testing.T) {
Colin Cross323dc602020-09-18 14:25:31 -07001961 t.Parallel()
Pete Gillin0c2143e2019-05-02 15:32:11 +01001962 t.Run("Java language level 8", func(t *testing.T) {
Pete Gillin1b3370f2019-10-01 13:57:31 +01001963 // Test with legacy javac -source 1.8 -target 1.8
Pete Gillinbdf5d712019-10-21 14:29:58 +01001964 bp := `
1965 java_library {
1966 name: "foo",
1967 srcs: ["a.java"],
1968 java_version: "1.8",
1969 }
1970
1971 java_library {
1972 name: "bar",
1973 srcs: ["b.java"],
1974 sdk_version: "none",
1975 system_modules: "none",
1976 patch_module: "java.base",
1977 java_version: "1.8",
1978 }
1979
1980 java_library {
1981 name: "baz",
1982 srcs: ["c.java"],
1983 patch_module: "java.base",
1984 java_version: "1.8",
1985 }
1986 `
1987 ctx, _ := testJava(t, bp)
Jaewoong Jung38e4fb22018-12-12 09:01:34 -08001988
1989 checkPatchModuleFlag(t, ctx, "foo", "")
1990 checkPatchModuleFlag(t, ctx, "bar", "")
1991 checkPatchModuleFlag(t, ctx, "baz", "")
1992 })
1993
Pete Gillin0c2143e2019-05-02 15:32:11 +01001994 t.Run("Java language level 9", func(t *testing.T) {
Pete Gillin1b3370f2019-10-01 13:57:31 +01001995 // Test with default javac -source 9 -target 9
Pete Gillinbdf5d712019-10-21 14:29:58 +01001996 bp := `
1997 java_library {
1998 name: "foo",
1999 srcs: ["a.java"],
2000 }
2001
2002 java_library {
2003 name: "bar",
2004 srcs: ["b.java"],
2005 sdk_version: "none",
2006 system_modules: "none",
2007 patch_module: "java.base",
2008 }
2009
2010 java_library {
2011 name: "baz",
2012 srcs: ["c.java"],
2013 patch_module: "java.base",
2014 }
2015 `
Pete Gillin1b3370f2019-10-01 13:57:31 +01002016 ctx, _ := testJava(t, bp)
Jaewoong Jung38e4fb22018-12-12 09:01:34 -08002017
2018 checkPatchModuleFlag(t, ctx, "foo", "")
2019 expected := "java.base=.:" + buildDir
2020 checkPatchModuleFlag(t, ctx, "bar", expected)
Jiyong Park231d0562019-12-18 17:28:17 +09002021 expected = "java.base=" + strings.Join([]string{".", buildDir, moduleToPath("ext"), moduleToPath("framework")}, ":")
Jaewoong Jung38e4fb22018-12-12 09:01:34 -08002022 checkPatchModuleFlag(t, ctx, "baz", expected)
2023 })
2024}
Paul Duffina7b9f422020-01-10 17:12:18 +00002025
2026func TestJavaSystemModules(t *testing.T) {
Colin Cross323dc602020-09-18 14:25:31 -07002027 t.Parallel()
Paul Duffina7b9f422020-01-10 17:12:18 +00002028 ctx, _ := testJava(t, `
2029 java_system_modules {
2030 name: "system-modules",
2031 libs: ["system-module1", "system-module2"],
2032 }
2033 java_library {
2034 name: "system-module1",
2035 srcs: ["a.java"],
2036 sdk_version: "none",
2037 system_modules: "none",
2038 }
2039 java_library {
2040 name: "system-module2",
2041 srcs: ["b.java"],
2042 sdk_version: "none",
2043 system_modules: "none",
2044 }
2045 `)
2046
2047 // check the existence of the module
2048 systemModules := ctx.ModuleForTests("system-modules", "android_common")
2049
2050 cmd := systemModules.Rule("jarsTosystemModules")
2051
2052 // make sure the command compiles against the supplied modules.
2053 for _, module := range []string{"system-module1.jar", "system-module2.jar"} {
2054 if !strings.Contains(cmd.Args["classpath"], module) {
2055 t.Errorf("system modules classpath %v does not contain %q", cmd.Args["classpath"],
2056 module)
2057 }
2058 }
2059}
Paul Duffin90169ba2020-01-10 17:16:44 +00002060
2061func TestJavaSystemModulesImport(t *testing.T) {
Colin Cross323dc602020-09-18 14:25:31 -07002062 t.Parallel()
Paul Duffin90169ba2020-01-10 17:16:44 +00002063 ctx, _ := testJava(t, `
2064 java_system_modules_import {
2065 name: "system-modules",
2066 libs: ["system-module1", "system-module2"],
2067 }
2068 java_import {
2069 name: "system-module1",
2070 jars: ["a.jar"],
2071 }
2072 java_import {
2073 name: "system-module2",
2074 jars: ["b.jar"],
2075 }
2076 `)
2077
2078 // check the existence of the module
2079 systemModules := ctx.ModuleForTests("system-modules", "android_common")
2080
2081 cmd := systemModules.Rule("jarsTosystemModules")
2082
2083 // make sure the command compiles against the supplied modules.
2084 for _, module := range []string{"system-module1.jar", "system-module2.jar"} {
2085 if !strings.Contains(cmd.Args["classpath"], module) {
2086 t.Errorf("system modules classpath %v does not contain %q", cmd.Args["classpath"],
2087 module)
2088 }
2089 }
2090}
Paul Duffin83a2d962019-11-19 19:44:10 +00002091
2092func TestJavaLibraryWithSystemModules(t *testing.T) {
Colin Cross323dc602020-09-18 14:25:31 -07002093 t.Parallel()
Paul Duffin83a2d962019-11-19 19:44:10 +00002094 ctx, _ := testJava(t, `
2095 java_library {
2096 name: "lib-with-source-system-modules",
2097 srcs: [
2098 "a.java",
2099 ],
2100 sdk_version: "none",
2101 system_modules: "source-system-modules",
2102 }
2103
2104 java_library {
2105 name: "source-jar",
2106 srcs: [
2107 "a.java",
2108 ],
2109 }
2110
2111 java_system_modules {
2112 name: "source-system-modules",
2113 libs: ["source-jar"],
2114 }
2115
2116 java_library {
2117 name: "lib-with-prebuilt-system-modules",
2118 srcs: [
2119 "a.java",
2120 ],
2121 sdk_version: "none",
2122 system_modules: "prebuilt-system-modules",
2123 }
2124
2125 java_import {
2126 name: "prebuilt-jar",
2127 jars: ["a.jar"],
2128 }
2129
2130 java_system_modules_import {
2131 name: "prebuilt-system-modules",
2132 libs: ["prebuilt-jar"],
2133 }
2134 `)
2135
2136 checkBootClasspathForSystemModule(t, ctx, "lib-with-source-system-modules", "/source-jar.jar")
2137
2138 checkBootClasspathForSystemModule(t, ctx, "lib-with-prebuilt-system-modules", "/prebuilt-jar.jar")
2139}
2140
2141func checkBootClasspathForSystemModule(t *testing.T, ctx *android.TestContext, moduleName string, expectedSuffix string) {
2142 javacRule := ctx.ModuleForTests(moduleName, "android_common").Rule("javac")
2143 bootClasspath := javacRule.Args["bootClasspath"]
2144 if strings.HasPrefix(bootClasspath, "--system ") && strings.HasSuffix(bootClasspath, expectedSuffix) {
2145 t.Errorf("bootclasspath of %q must start with --system and end with %q, but was %#v.", moduleName, expectedSuffix, bootClasspath)
2146 }
2147}
Jiyong Park19604de2020-03-24 16:44:11 +09002148
2149func TestAidlExportIncludeDirsFromImports(t *testing.T) {
Colin Cross323dc602020-09-18 14:25:31 -07002150 t.Parallel()
Jiyong Park19604de2020-03-24 16:44:11 +09002151 ctx, _ := testJava(t, `
2152 java_library {
2153 name: "foo",
2154 srcs: ["aidl/foo/IFoo.aidl"],
2155 libs: ["bar"],
2156 }
2157
2158 java_import {
2159 name: "bar",
2160 jars: ["a.jar"],
2161 aidl: {
2162 export_include_dirs: ["aidl/bar"],
2163 },
2164 }
2165 `)
2166
2167 aidlCommand := ctx.ModuleForTests("foo", "android_common").Rule("aidl").RuleParams.Command
2168 expectedAidlFlag := "-Iaidl/bar"
2169 if !strings.Contains(aidlCommand, expectedAidlFlag) {
2170 t.Errorf("aidl command %q does not contain %q", aidlCommand, expectedAidlFlag)
2171 }
2172}
Liz Kammerdd849a82020-06-12 16:38:45 -07002173
2174func TestDataNativeBinaries(t *testing.T) {
Colin Cross323dc602020-09-18 14:25:31 -07002175 t.Parallel()
Liz Kammerdd849a82020-06-12 16:38:45 -07002176 ctx, config := testJava(t, `
2177 java_test_host {
2178 name: "foo",
2179 srcs: ["a.java"],
2180 data_native_bins: ["bin"]
2181 }
2182
2183 python_binary_host {
2184 name: "bin",
2185 srcs: ["bin.py"],
2186 }
2187 `)
2188
2189 buildOS := android.BuildOs.String()
2190
2191 test := ctx.ModuleForTests("foo", buildOS+"_common").Module().(*TestHost)
2192 entries := android.AndroidMkEntriesForTest(t, config, "", test)[0]
2193 expected := []string{buildDir + "/.intermediates/bin/" + buildOS + "_x86_64_PY3/bin:bin"}
2194 actual := entries.EntryMap["LOCAL_COMPATIBILITY_SUPPORT_FILES"]
2195 if !reflect.DeepEqual(expected, actual) {
2196 t.Errorf("Unexpected test data - expected: %q, actual: %q", expected, actual)
2197 }
2198}