blob: 71bd4573fd5e9fecaad90d6304fe18435c76c1f2 [file] [log] [blame]
Colin Cross72bb3632017-07-13 16:23:21 -07001// Copyright 2017 Google Inc. All rights reserved.
2//
3// Licensed under the Apache License, Version 2.0 (the "License");
4// you may not use this file except in compliance with the License.
5// You may obtain a copy of the License at
6//
7// http://www.apache.org/licenses/LICENSE-2.0
8//
9// Unless required by applicable law or agreed to in writing, software
10// distributed under the License is distributed on an "AS IS" BASIS,
11// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
12// See the License for the specific language governing permissions and
13// limitations under the License.
14
15package java
16
17import (
Paul Duffin1a393322020-11-18 16:36:47 +000018 "fmt"
Colin Cross72bb3632017-07-13 16:23:21 -070019 "os"
20 "path/filepath"
Colin Crossc0806172019-06-14 18:51:47 -070021 "reflect"
Paul Duffindaaa3322020-05-26 18:13:57 +010022 "regexp"
Colin Crossf8d9c492021-01-26 11:01:43 -080023 "runtime"
Nan Zhang61eaedb2017-11-02 13:28:15 -070024 "strconv"
Colin Cross72bb3632017-07-13 16:23:21 -070025 "strings"
26 "testing"
Colin Cross86a60ae2018-05-29 14:44:55 -070027
Jeongik Cha28df2572019-11-11 10:46:36 +090028 "github.com/google/blueprint/proptools"
29
Colin Crossa4f08812018-10-02 22:03:40 -070030 "android/soong/android"
31 "android/soong/cc"
Colin Crossc28bb0b2019-02-25 14:20:47 -080032 "android/soong/dexpreopt"
Colin Cross1661aff2021-03-12 17:56:51 -080033 "android/soong/genrule"
Liz Kammerdd849a82020-06-12 16:38:45 -070034 "android/soong/python"
Colin Cross72bb3632017-07-13 16:23:21 -070035)
36
Paul Duffin70d3bee2021-03-21 11:26:05 +000037// Legacy preparer used for running tests within the java package.
38//
39// This includes everything that was needed to run any test in the java package prior to the
40// introduction of the test fixtures. Tests that are being converted to use fixtures directly
41// rather than through the testJava...() methods should avoid using this and instead use the
42// various preparers directly, using android.GroupFixturePreparers(...) to group them when
43// necessary.
44//
45// deprecated
46var prepareForJavaTest = android.GroupFixturePreparers(
Paul Duffin95bdab42021-03-08 21:48:46 +000047 genrule.PrepareForTestWithGenRuleBuildComponents,
48 // Get the CC build components but not default modules.
49 cc.PrepareForTestWithCcBuildComponents,
50 // Include all the default java modules.
51 PrepareForTestWithJavaDefaultModules,
Paul Duffin42da69d2021-03-22 13:41:36 +000052 PrepareForTestWithOverlayBuildComponents,
Paul Duffin220ddd72021-03-17 23:54:30 +000053 python.PrepareForTestWithPythonBuildComponents,
Paul Duffin95bdab42021-03-08 21:48:46 +000054 android.FixtureRegisterWithContext(func(ctx android.RegistrationContext) {
Paul Duffin95bdab42021-03-08 21:48:46 +000055 ctx.RegisterPreSingletonType("sdk_versions", sdkPreSingletonFactory)
56 }),
Paul Duffin9fc9f532021-03-23 15:41:11 +000057 PrepareForTestWithDexpreopt,
Paul Duffin95bdab42021-03-08 21:48:46 +000058)
59
Colin Cross72bb3632017-07-13 16:23:21 -070060func TestMain(m *testing.M) {
Paul Duffind6339af2021-03-22 18:05:04 +000061 os.Exit(m.Run())
Colin Cross527012a2017-11-30 22:56:16 -080062}
63
Paul Duffin95bdab42021-03-08 21:48:46 +000064// testJavaError is a legacy way of running tests of java modules that expect errors.
65//
66// See testJava for an explanation as to how to stop using this deprecated method.
67//
68// deprecated
Jeongik Cha2cc570d2019-10-29 15:44:45 +090069func testJavaError(t *testing.T, pattern string, bp string) (*android.TestContext, android.Config) {
Jeongik Cha538c0d02019-07-11 15:54:27 +090070 t.Helper()
Paul Duffin71ae5942021-03-22 15:36:52 +000071 result := android.GroupFixturePreparers(
Paul Duffin9fc9f532021-03-23 15:41:11 +000072 prepareForJavaTest, dexpreopt.PrepareForTestByEnablingDexpreopt).
Paul Duffin6bac49c2021-03-12 21:28:15 +000073 ExtendWithErrorHandler(android.FixtureExpectsAtLeastOneErrorMatchingPattern(pattern)).
74 RunTestWithBp(t, bp)
75 return result.TestContext, result.Config
Jeongik Cha2cc570d2019-10-29 15:44:45 +090076}
77
Paul Duffin71ae5942021-03-22 15:36:52 +000078// testJavaWithFS runs tests using the prepareForJavaTest
Paul Duffin95bdab42021-03-08 21:48:46 +000079//
80// See testJava for an explanation as to how to stop using this deprecated method.
81//
82// deprecated
83func testJavaWithFS(t *testing.T, bp string, fs android.MockFS) (*android.TestContext, android.Config) {
Colin Cross238c1f32020-06-07 16:58:18 -070084 t.Helper()
Paul Duffin71ae5942021-03-22 15:36:52 +000085 result := android.GroupFixturePreparers(
86 prepareForJavaTest, fs.AddToFixture()).RunTestWithBp(t, bp)
Paul Duffin95bdab42021-03-08 21:48:46 +000087 return result.TestContext, result.Config
Colin Cross238c1f32020-06-07 16:58:18 -070088}
89
Paul Duffin71ae5942021-03-22 15:36:52 +000090// testJava runs tests using the prepareForJavaTest
Paul Duffin95bdab42021-03-08 21:48:46 +000091//
Paul Duffin71ae5942021-03-22 15:36:52 +000092// Do not add any new usages of this, instead use the prepareForJavaTest directly as it makes it
Paul Duffin95bdab42021-03-08 21:48:46 +000093// much easier to customize the test behavior.
94//
95// If it is necessary to customize the behavior of an existing test that uses this then please first
Paul Duffin71ae5942021-03-22 15:36:52 +000096// convert the test to using prepareForJavaTest first and then in a following change add the
Paul Duffin95bdab42021-03-08 21:48:46 +000097// appropriate fixture preparers. Keeping the conversion change separate makes it easy to verify
98// that it did not change the test behavior unexpectedly.
99//
100// deprecated
Jaewoong Jungf9a04432019-07-17 11:15:09 -0700101func testJava(t *testing.T, bp string) (*android.TestContext, android.Config) {
Colin Cross6b4a32d2017-12-05 13:42:45 -0800102 t.Helper()
Paul Duffin71ae5942021-03-22 15:36:52 +0000103 result := prepareForJavaTest.RunTestWithBp(t, bp)
Paul Duffin95bdab42021-03-08 21:48:46 +0000104 return result.TestContext, result.Config
Jeongik Cha2cc570d2019-10-29 15:44:45 +0900105}
106
Paul Duffin95bdab42021-03-08 21:48:46 +0000107// defaultModuleToPath constructs a path to the turbine generate jar for a default test module that
108// is defined in PrepareForIntegrationTestWithJava
109func defaultModuleToPath(name string) string {
Paul Duffin76101fa2021-03-13 09:55:25 +0000110 switch {
111 case name == `""`:
112 return name
113 case strings.HasSuffix(name, ".jar"):
114 return name
115 default:
Paul Duffin414ea5e2021-03-22 17:31:52 +0000116 return filepath.Join("out", "soong", ".intermediates", defaultJavaDir, name, "android_common", "turbine-combined", name+".jar")
Paul Duffin76101fa2021-03-13 09:55:25 +0000117 }
Paul Duffin95bdab42021-03-08 21:48:46 +0000118}
119
Paul Duffin76e5c8a2021-03-20 14:19:46 +0000120// Test that the PrepareForTestWithJavaDefaultModules provides all the files that it uses by
121// running it in a fixture that requires all source files to exist.
122func TestPrepareForTestWithJavaDefaultModules(t *testing.T) {
123 android.GroupFixturePreparers(
124 PrepareForTestWithJavaDefaultModules,
125 android.PrepareForTestDisallowNonExistentPaths,
126 ).RunTest(t)
127}
128
Jeongik Chae403e9e2019-12-07 00:16:24 +0900129func TestJavaLinkType(t *testing.T) {
130 testJava(t, `
131 java_library {
132 name: "foo",
133 srcs: ["a.java"],
134 libs: ["bar"],
135 static_libs: ["baz"],
136 }
137
138 java_library {
139 name: "bar",
140 sdk_version: "current",
141 srcs: ["b.java"],
142 }
143
144 java_library {
145 name: "baz",
146 sdk_version: "system_current",
147 srcs: ["c.java"],
148 }
149 `)
150
Steven Moreland00298982020-11-17 21:44:36 +0000151 testJavaError(t, "consider adjusting sdk_version: OR platform_apis:", `
Jeongik Chae403e9e2019-12-07 00:16:24 +0900152 java_library {
153 name: "foo",
154 srcs: ["a.java"],
155 libs: ["bar"],
156 sdk_version: "current",
157 static_libs: ["baz"],
158 }
159
160 java_library {
161 name: "bar",
162 sdk_version: "current",
163 srcs: ["b.java"],
164 }
165
166 java_library {
167 name: "baz",
168 sdk_version: "system_current",
169 srcs: ["c.java"],
170 }
171 `)
172
173 testJava(t, `
174 java_library {
175 name: "foo",
176 srcs: ["a.java"],
177 libs: ["bar"],
178 sdk_version: "system_current",
179 static_libs: ["baz"],
180 }
181
182 java_library {
183 name: "bar",
184 sdk_version: "current",
185 srcs: ["b.java"],
186 }
187
188 java_library {
189 name: "baz",
190 sdk_version: "system_current",
191 srcs: ["c.java"],
192 }
193 `)
194
Steven Moreland00298982020-11-17 21:44:36 +0000195 testJavaError(t, "consider adjusting sdk_version: OR platform_apis:", `
Jeongik Chae403e9e2019-12-07 00:16:24 +0900196 java_library {
197 name: "foo",
198 srcs: ["a.java"],
199 libs: ["bar"],
200 sdk_version: "system_current",
201 static_libs: ["baz"],
202 }
203
204 java_library {
205 name: "bar",
206 sdk_version: "current",
207 srcs: ["b.java"],
208 }
209
210 java_library {
211 name: "baz",
212 srcs: ["c.java"],
213 }
214 `)
215}
216
Colin Cross72bb3632017-07-13 16:23:21 -0700217func TestSimple(t *testing.T) {
Jaewoong Jungf9a04432019-07-17 11:15:09 -0700218 ctx, _ := testJava(t, `
Colin Cross72bb3632017-07-13 16:23:21 -0700219 java_library {
220 name: "foo",
221 srcs: ["a.java"],
Colin Crosse8dc34a2017-07-19 11:22:16 -0700222 libs: ["bar"],
223 static_libs: ["baz"],
Colin Cross72bb3632017-07-13 16:23:21 -0700224 }
225
226 java_library {
227 name: "bar",
228 srcs: ["b.java"],
229 }
230
231 java_library {
232 name: "baz",
233 srcs: ["c.java"],
234 }
Colin Crossd5934c82017-10-02 13:55:26 -0700235 `)
Colin Cross72bb3632017-07-13 16:23:21 -0700236
Paul Duffina71a67a2021-03-29 00:42:57 +0100237 javac := ctx.ModuleForTests("foo", "android_common").Rule("javac")
Nan Zhanged19fc32017-10-19 13:06:22 -0700238 combineJar := ctx.ModuleForTests("foo", "android_common").Description("for javac")
Colin Cross72bb3632017-07-13 16:23:21 -0700239
240 if len(javac.Inputs) != 1 || javac.Inputs[0].String() != "a.java" {
241 t.Errorf(`foo inputs %v != ["a.java"]`, javac.Inputs)
242 }
243
Colin Cross1ee23172017-10-18 14:44:18 -0700244 baz := ctx.ModuleForTests("baz", "android_common").Rule("javac").Output.String()
Paul Duffin414ea5e2021-03-22 17:31:52 +0000245 barTurbine := filepath.Join("out", "soong", ".intermediates", "bar", "android_common", "turbine-combined", "bar.jar")
246 bazTurbine := filepath.Join("out", "soong", ".intermediates", "baz", "android_common", "turbine-combined", "baz.jar")
Colin Cross0a6e0072017-08-30 14:24:55 -0700247
Paul Duffin22b77cd2021-03-12 19:15:01 +0000248 android.AssertStringDoesContain(t, "foo classpath", javac.Args["classpath"], barTurbine)
Colin Cross72bb3632017-07-13 16:23:21 -0700249
Paul Duffin22b77cd2021-03-12 19:15:01 +0000250 android.AssertStringDoesContain(t, "foo classpath", javac.Args["classpath"], bazTurbine)
Colin Cross0a6e0072017-08-30 14:24:55 -0700251
252 if len(combineJar.Inputs) != 2 || combineJar.Inputs[1].String() != baz {
253 t.Errorf("foo combineJar inputs %v does not contain %q", combineJar.Inputs, baz)
Colin Cross72bb3632017-07-13 16:23:21 -0700254 }
255}
256
Artur Satayev9cf46692019-11-26 18:08:34 +0000257func TestExportedPlugins(t *testing.T) {
258 type Result struct {
Colin Crossc9fe10f2020-11-19 18:06:03 -0800259 library string
260 processors string
261 disableTurbine bool
Artur Satayev9cf46692019-11-26 18:08:34 +0000262 }
263 var tests = []struct {
264 name string
265 extra string
266 results []Result
267 }{
268 {
269 name: "Exported plugin is not a direct plugin",
270 extra: `java_library { name: "exports", srcs: ["a.java"], exported_plugins: ["plugin"] }`,
271 results: []Result{{library: "exports", processors: "-proc:none"}},
272 },
273 {
274 name: "Exports plugin to dependee",
275 extra: `
276 java_library{name: "exports", exported_plugins: ["plugin"]}
277 java_library{name: "foo", srcs: ["a.java"], libs: ["exports"]}
278 java_library{name: "bar", srcs: ["a.java"], static_libs: ["exports"]}
279 `,
280 results: []Result{
281 {library: "foo", processors: "-processor com.android.TestPlugin"},
282 {library: "bar", processors: "-processor com.android.TestPlugin"},
283 },
284 },
285 {
286 name: "Exports plugin to android_library",
287 extra: `
288 java_library{name: "exports", exported_plugins: ["plugin"]}
289 android_library{name: "foo", srcs: ["a.java"], libs: ["exports"]}
290 android_library{name: "bar", srcs: ["a.java"], static_libs: ["exports"]}
291 `,
292 results: []Result{
293 {library: "foo", processors: "-processor com.android.TestPlugin"},
294 {library: "bar", processors: "-processor com.android.TestPlugin"},
295 },
296 },
297 {
298 name: "Exports plugin is not propagated via transitive deps",
299 extra: `
300 java_library{name: "exports", exported_plugins: ["plugin"]}
301 java_library{name: "foo", srcs: ["a.java"], libs: ["exports"]}
302 java_library{name: "bar", srcs: ["a.java"], static_libs: ["foo"]}
303 `,
304 results: []Result{
305 {library: "foo", processors: "-processor com.android.TestPlugin"},
306 {library: "bar", processors: "-proc:none"},
307 },
308 },
309 {
310 name: "Exports plugin appends to plugins",
311 extra: `
312 java_plugin{name: "plugin2", processor_class: "com.android.TestPlugin2"}
313 java_library{name: "exports", exported_plugins: ["plugin"]}
314 java_library{name: "foo", srcs: ["a.java"], libs: ["exports"], plugins: ["plugin2"]}
315 `,
316 results: []Result{
317 {library: "foo", processors: "-processor com.android.TestPlugin,com.android.TestPlugin2"},
318 },
319 },
Colin Crossc9fe10f2020-11-19 18:06:03 -0800320 {
321 name: "Exports plugin to with generates_api to dependee",
322 extra: `
323 java_library{name: "exports", exported_plugins: ["plugin_generates_api"]}
324 java_library{name: "foo", srcs: ["a.java"], libs: ["exports"]}
325 java_library{name: "bar", srcs: ["a.java"], static_libs: ["exports"]}
326 `,
327 results: []Result{
328 {library: "foo", processors: "-processor com.android.TestPlugin", disableTurbine: true},
329 {library: "bar", processors: "-processor com.android.TestPlugin", disableTurbine: true},
330 },
331 },
Artur Satayev9cf46692019-11-26 18:08:34 +0000332 }
333
334 for _, test := range tests {
335 t.Run(test.name, func(t *testing.T) {
336 ctx, _ := testJava(t, `
337 java_plugin {
338 name: "plugin",
339 processor_class: "com.android.TestPlugin",
340 }
Colin Crossc9fe10f2020-11-19 18:06:03 -0800341 java_plugin {
342 name: "plugin_generates_api",
343 generates_api: true,
344 processor_class: "com.android.TestPlugin",
345 }
Artur Satayev9cf46692019-11-26 18:08:34 +0000346 `+test.extra)
347
348 for _, want := range test.results {
349 javac := ctx.ModuleForTests(want.library, "android_common").Rule("javac")
350 if javac.Args["processor"] != want.processors {
351 t.Errorf("For library %v, expected %v, found %v", want.library, want.processors, javac.Args["processor"])
352 }
Colin Crossc9fe10f2020-11-19 18:06:03 -0800353 turbine := ctx.ModuleForTests(want.library, "android_common").MaybeRule("turbine")
354 disableTurbine := turbine.BuildParams.Rule == nil
355 if disableTurbine != want.disableTurbine {
356 t.Errorf("For library %v, expected disableTurbine %v, found %v", want.library, want.disableTurbine, disableTurbine)
357 }
Artur Satayev9cf46692019-11-26 18:08:34 +0000358 }
359 })
360 }
361}
362
Jeongik Cha2cc570d2019-10-29 15:44:45 +0900363func TestSdkVersionByPartition(t *testing.T) {
364 testJavaError(t, "sdk_version must have a value when the module is located at vendor or product", `
Jeongik Cha6bd33c12019-06-25 16:26:18 +0900365 java_library {
366 name: "foo",
367 srcs: ["a.java"],
368 vendor: true,
369 }
Jeongik Cha2cc570d2019-10-29 15:44:45 +0900370 `)
Jeongik Cha6bd33c12019-06-25 16:26:18 +0900371
Jeongik Cha2cc570d2019-10-29 15:44:45 +0900372 testJava(t, `
Jeongik Cha6bd33c12019-06-25 16:26:18 +0900373 java_library {
374 name: "bar",
375 srcs: ["b.java"],
376 }
377 `)
378
Jeongik Cha2cc570d2019-10-29 15:44:45 +0900379 for _, enforce := range []bool{true, false} {
Jeongik Cha2cc570d2019-10-29 15:44:45 +0900380 bp := `
381 java_library {
382 name: "foo",
383 srcs: ["a.java"],
384 product_specific: true,
385 }
386 `
Colin Cross98be1bb2019-12-13 20:41:13 -0800387
Paul Duffin414ea5e2021-03-22 17:31:52 +0000388 errorHandler := android.FixtureExpectsNoErrors
Jeongik Cha2cc570d2019-10-29 15:44:45 +0900389 if enforce {
Paul Duffin414ea5e2021-03-22 17:31:52 +0000390 errorHandler = android.FixtureExpectsAtLeastOneErrorMatchingPattern("sdk_version must have a value when the module is located at vendor or product")
Jeongik Cha2cc570d2019-10-29 15:44:45 +0900391 }
Paul Duffin414ea5e2021-03-22 17:31:52 +0000392
393 android.GroupFixturePreparers(
394 PrepareForTestWithJavaDefaultModules,
395 android.FixtureModifyProductVariables(func(variables android.FixtureProductVariables) {
396 variables.EnforceProductPartitionInterface = proptools.BoolPtr(enforce)
397 }),
398 ).
399 ExtendWithErrorHandler(errorHandler).
400 RunTestWithBp(t, bp)
Jeongik Cha6bd33c12019-06-25 16:26:18 +0900401 }
402}
403
Colin Crossd5934c82017-10-02 13:55:26 -0700404func TestArchSpecific(t *testing.T) {
Jaewoong Jungf9a04432019-07-17 11:15:09 -0700405 ctx, _ := testJava(t, `
Colin Crossd5934c82017-10-02 13:55:26 -0700406 java_library {
407 name: "foo",
408 srcs: ["a.java"],
409 target: {
410 android: {
411 srcs: ["b.java"],
412 },
413 },
414 }
415 `)
416
417 javac := ctx.ModuleForTests("foo", "android_common").Rule("javac")
418 if len(javac.Inputs) != 2 || javac.Inputs[0].String() != "a.java" || javac.Inputs[1].String() != "b.java" {
419 t.Errorf(`foo inputs %v != ["a.java", "b.java"]`, javac.Inputs)
420 }
421}
422
Colin Cross6b4a32d2017-12-05 13:42:45 -0800423func TestBinary(t *testing.T) {
Jaewoong Jungf9a04432019-07-17 11:15:09 -0700424 ctx, _ := testJava(t, `
Colin Cross6b4a32d2017-12-05 13:42:45 -0800425 java_library_host {
426 name: "foo",
427 srcs: ["a.java"],
428 }
429
430 java_binary_host {
431 name: "bar",
432 srcs: ["b.java"],
433 static_libs: ["foo"],
Colin Cross89226d92020-10-09 19:00:54 -0700434 jni_libs: ["libjni"],
435 }
436
437 cc_library_shared {
438 name: "libjni",
439 host_supported: true,
440 device_supported: false,
441 stl: "none",
Colin Cross6b4a32d2017-12-05 13:42:45 -0800442 }
443 `)
444
445 buildOS := android.BuildOs.String()
446
447 bar := ctx.ModuleForTests("bar", buildOS+"_common")
448 barJar := bar.Output("bar.jar").Output.String()
449 barWrapper := ctx.ModuleForTests("bar", buildOS+"_x86_64")
450 barWrapperDeps := barWrapper.Output("bar").Implicits.Strings()
451
Colin Cross89226d92020-10-09 19:00:54 -0700452 libjni := ctx.ModuleForTests("libjni", buildOS+"_x86_64_shared")
453 libjniSO := libjni.Rule("Cp").Output.String()
454
Colin Cross6b4a32d2017-12-05 13:42:45 -0800455 // Test that the install binary wrapper depends on the installed jar file
Colin Crossc179ea62020-10-09 10:54:15 -0700456 if g, w := barWrapperDeps, barJar; !android.InList(w, g) {
457 t.Errorf("expected binary wrapper implicits to contain %q, got %q", w, g)
Colin Cross6b4a32d2017-12-05 13:42:45 -0800458 }
Colin Cross89226d92020-10-09 19:00:54 -0700459
460 // Test that the install binary wrapper depends on the installed JNI libraries
461 if g, w := barWrapperDeps, libjniSO; !android.InList(w, g) {
462 t.Errorf("expected binary wrapper implicits to contain %q, got %q", w, g)
Colin Cross6b4a32d2017-12-05 13:42:45 -0800463 }
Alex Humesky2070e322020-06-09 20:23:08 -0400464}
Colin Cross6b4a32d2017-12-05 13:42:45 -0800465
Colin Crossf8d9c492021-01-26 11:01:43 -0800466func TestTest(t *testing.T) {
467 ctx, _ := testJava(t, `
468 java_test_host {
469 name: "foo",
470 srcs: ["a.java"],
471 jni_libs: ["libjni"],
472 }
473
474 cc_library_shared {
475 name: "libjni",
476 host_supported: true,
477 device_supported: false,
478 stl: "none",
479 }
480 `)
481
482 buildOS := android.BuildOs.String()
483
484 foo := ctx.ModuleForTests("foo", buildOS+"_common").Module().(*TestHost)
485
486 expected := "lib64/libjni.so"
487 if runtime.GOOS == "darwin" {
488 expected = "lib64/libjni.dylib"
489 }
490
491 fooTestData := foo.data
492 if len(fooTestData) != 1 || fooTestData[0].Rel() != expected {
493 t.Errorf(`expected foo test data relative path [%q], got %q`,
494 expected, fooTestData.Strings())
495 }
496}
497
Alex Humesky2070e322020-06-09 20:23:08 -0400498func TestHostBinaryNoJavaDebugInfoOverride(t *testing.T) {
499 bp := `
500 java_library {
501 name: "target_library",
502 srcs: ["a.java"],
503 }
504
505 java_binary_host {
506 name: "host_binary",
507 srcs: ["b.java"],
508 }
509 `
Alex Humesky2070e322020-06-09 20:23:08 -0400510
Paul Duffin414ea5e2021-03-22 17:31:52 +0000511 result := android.GroupFixturePreparers(
512 PrepareForTestWithJavaDefaultModules,
513 android.FixtureModifyProductVariables(func(variables android.FixtureProductVariables) {
514 variables.MinimizeJavaDebugInfo = proptools.BoolPtr(true)
515 }),
516 ).RunTestWithBp(t, bp)
Alex Humesky2070e322020-06-09 20:23:08 -0400517
Liz Kammer7941b302020-07-28 13:27:34 -0700518 // first, check that the -g flag is added to target modules
Paul Duffin414ea5e2021-03-22 17:31:52 +0000519 targetLibrary := result.ModuleForTests("target_library", "android_common")
Alex Humesky2070e322020-06-09 20:23:08 -0400520 targetJavaFlags := targetLibrary.Module().VariablesForTests()["javacFlags"]
521 if !strings.Contains(targetJavaFlags, "-g:source,lines") {
522 t.Errorf("target library javac flags %v should contain "+
523 "-g:source,lines override with MinimizeJavaDebugInfo", targetJavaFlags)
524 }
525
526 // check that -g is not overridden for host modules
527 buildOS := android.BuildOs.String()
Paul Duffin414ea5e2021-03-22 17:31:52 +0000528 hostBinary := result.ModuleForTests("host_binary", buildOS+"_common")
Alex Humesky2070e322020-06-09 20:23:08 -0400529 hostJavaFlags := hostBinary.Module().VariablesForTests()["javacFlags"]
530 if strings.Contains(hostJavaFlags, "-g:source,lines") {
531 t.Errorf("java_binary_host javac flags %v should not have "+
532 "-g:source,lines override with MinimizeJavaDebugInfo", hostJavaFlags)
533 }
Colin Cross6b4a32d2017-12-05 13:42:45 -0800534}
535
Colin Cross72bb3632017-07-13 16:23:21 -0700536func TestPrebuilts(t *testing.T) {
Jaewoong Jungf9a04432019-07-17 11:15:09 -0700537 ctx, _ := testJava(t, `
Colin Cross72bb3632017-07-13 16:23:21 -0700538 java_library {
539 name: "foo",
Paul Duffin91547182019-11-12 19:39:36 +0000540 srcs: ["a.java", ":stubs-source"],
Paul Duffinfcfd7912020-01-31 17:54:30 +0000541 libs: ["bar", "sdklib"],
Colin Crosse8dc34a2017-07-19 11:22:16 -0700542 static_libs: ["baz"],
Colin Cross72bb3632017-07-13 16:23:21 -0700543 }
544
Colin Cross74d73e22017-08-02 11:05:49 -0700545 java_import {
Colin Cross72bb3632017-07-13 16:23:21 -0700546 name: "bar",
Colin Cross74d73e22017-08-02 11:05:49 -0700547 jars: ["a.jar"],
Colin Cross72bb3632017-07-13 16:23:21 -0700548 }
549
Colin Cross74d73e22017-08-02 11:05:49 -0700550 java_import {
Colin Cross72bb3632017-07-13 16:23:21 -0700551 name: "baz",
Colin Cross74d73e22017-08-02 11:05:49 -0700552 jars: ["b.jar"],
Liz Kammerd6c31d22020-08-05 15:40:41 -0700553 sdk_version: "current",
554 compile_dex: true,
Colin Cross72bb3632017-07-13 16:23:21 -0700555 }
Colin Cross42be7612019-02-21 18:12:14 -0800556
557 dex_import {
558 name: "qux",
559 jars: ["b.jar"],
560 }
Colin Cross79c7c262019-04-17 11:11:46 -0700561
562 java_sdk_library_import {
Paul Duffin56d44902020-01-31 13:36:25 +0000563 name: "sdklib",
564 public: {
565 jars: ["c.jar"],
566 },
567 }
568
Paul Duffin91547182019-11-12 19:39:36 +0000569 prebuilt_stubs_sources {
570 name: "stubs-source",
Paul Duffin9b478b02019-12-10 13:41:51 +0000571 srcs: ["stubs/sources"],
Paul Duffin91547182019-11-12 19:39:36 +0000572 }
Paul Duffin1b82e6a2019-12-03 18:06:47 +0000573
574 java_test_import {
575 name: "test",
576 jars: ["a.jar"],
577 test_suites: ["cts"],
578 test_config: "AndroidTest.xml",
579 }
Colin Cross72bb3632017-07-13 16:23:21 -0700580 `)
581
Paul Duffin9b478b02019-12-10 13:41:51 +0000582 fooModule := ctx.ModuleForTests("foo", "android_common")
583 javac := fooModule.Rule("javac")
Nan Zhanged19fc32017-10-19 13:06:22 -0700584 combineJar := ctx.ModuleForTests("foo", "android_common").Description("for javac")
Liz Kammerd6c31d22020-08-05 15:40:41 -0700585 barModule := ctx.ModuleForTests("bar", "android_common")
586 barJar := barModule.Rule("combineJar").Output
587 bazModule := ctx.ModuleForTests("baz", "android_common")
588 bazJar := bazModule.Rule("combineJar").Output
Colin Cross79c7c262019-04-17 11:11:46 -0700589 sdklibStubsJar := ctx.ModuleForTests("sdklib.stubs", "android_common").Rule("combineJar").Output
Colin Cross72bb3632017-07-13 16:23:21 -0700590
Paul Duffin9b478b02019-12-10 13:41:51 +0000591 fooLibrary := fooModule.Module().(*Library)
592 assertDeepEquals(t, "foo java sources incorrect",
593 []string{"a.java"}, fooLibrary.compiledJavaSrcs.Strings())
Paul Duffin91547182019-11-12 19:39:36 +0000594
Paul Duffin9b478b02019-12-10 13:41:51 +0000595 assertDeepEquals(t, "foo java source jars incorrect",
596 []string{".intermediates/stubs-source/android_common/stubs-source-stubs.srcjar"},
597 android.NormalizePathsForTesting(fooLibrary.compiledSrcJars))
Paul Duffin91547182019-11-12 19:39:36 +0000598
Colin Cross37f6d792018-07-12 12:28:41 -0700599 if !strings.Contains(javac.Args["classpath"], barJar.String()) {
600 t.Errorf("foo classpath %v does not contain %q", javac.Args["classpath"], barJar.String())
Colin Cross72bb3632017-07-13 16:23:21 -0700601 }
602
Liz Kammerd6c31d22020-08-05 15:40:41 -0700603 barDexJar := barModule.Module().(*Import).DexJarBuildPath()
604 if barDexJar != nil {
605 t.Errorf("bar dex jar build path expected to be nil, got %q", barDexJar)
606 }
607
Colin Cross79c7c262019-04-17 11:11:46 -0700608 if !strings.Contains(javac.Args["classpath"], sdklibStubsJar.String()) {
609 t.Errorf("foo classpath %v does not contain %q", javac.Args["classpath"], sdklibStubsJar.String())
610 }
611
Colin Cross37f6d792018-07-12 12:28:41 -0700612 if len(combineJar.Inputs) != 2 || combineJar.Inputs[1].String() != bazJar.String() {
613 t.Errorf("foo combineJar inputs %v does not contain %q", combineJar.Inputs, bazJar.String())
Colin Cross72bb3632017-07-13 16:23:21 -0700614 }
Colin Cross42be7612019-02-21 18:12:14 -0800615
Paul Duffin414ea5e2021-03-22 17:31:52 +0000616 bazDexJar := bazModule.Module().(*Import).DexJarBuildPath()
617 expectedDexJar := "out/soong/.intermediates/baz/android_common/dex/baz.jar"
618 android.AssertPathRelativeToTopEquals(t, "baz dex jar build path", expectedDexJar, bazDexJar)
Liz Kammerd6c31d22020-08-05 15:40:41 -0700619
Colin Cross42be7612019-02-21 18:12:14 -0800620 ctx.ModuleForTests("qux", "android_common").Rule("Cp")
Colin Cross72bb3632017-07-13 16:23:21 -0700621}
622
Paul Duffin9b478b02019-12-10 13:41:51 +0000623func assertDeepEquals(t *testing.T, message string, expected interface{}, actual interface{}) {
624 if !reflect.DeepEqual(expected, actual) {
625 t.Errorf("%s: expected %q, found %q", message, expected, actual)
626 }
627}
628
Paul Duffin1a393322020-11-18 16:36:47 +0000629func TestPrebuiltStubsSources(t *testing.T) {
630 test := func(t *testing.T, sourcesPath string, expectedInputs []string) {
631 ctx, _ := testJavaWithFS(t, fmt.Sprintf(`
632prebuilt_stubs_sources {
633 name: "stubs-source",
634 srcs: ["%s"],
635}`, sourcesPath), map[string][]byte{
636 "stubs/sources/pkg/A.java": nil,
637 "stubs/sources/pkg/B.java": nil,
638 })
639
640 zipSrc := ctx.ModuleForTests("stubs-source", "android_common").Rule("zip_src")
641 if expected, actual := expectedInputs, zipSrc.Inputs.Strings(); !reflect.DeepEqual(expected, actual) {
642 t.Errorf("mismatch of inputs to soong_zip: expected %q, actual %q", expected, actual)
643 }
644 }
645
646 t.Run("empty/missing directory", func(t *testing.T) {
Colin Crossce3a51d2021-03-19 16:22:12 -0700647 test(t, "empty-directory", nil)
Paul Duffin1a393322020-11-18 16:36:47 +0000648 })
649
650 t.Run("non-empty set of sources", func(t *testing.T) {
651 test(t, "stubs/sources", []string{
652 "stubs/sources/pkg/A.java",
653 "stubs/sources/pkg/B.java",
654 })
655 })
656}
657
Paul Duffin56d44902020-01-31 13:36:25 +0000658func TestJavaSdkLibraryImport(t *testing.T) {
Paul Duffin71ae5942021-03-22 15:36:52 +0000659 result := prepareForJavaTest.RunTestWithBp(t, `
Paul Duffin56d44902020-01-31 13:36:25 +0000660 java_library {
661 name: "foo",
662 srcs: ["a.java"],
663 libs: ["sdklib"],
664 sdk_version: "current",
665 }
666
667 java_library {
668 name: "foo.system",
669 srcs: ["a.java"],
670 libs: ["sdklib"],
671 sdk_version: "system_current",
672 }
673
674 java_library {
675 name: "foo.test",
676 srcs: ["a.java"],
677 libs: ["sdklib"],
678 sdk_version: "test_current",
679 }
680
681 java_sdk_library_import {
682 name: "sdklib",
683 public: {
684 jars: ["a.jar"],
685 },
686 system: {
687 jars: ["b.jar"],
688 },
689 test: {
690 jars: ["c.jar"],
Paul Duffin0f8faff2020-05-20 16:18:00 +0100691 stub_srcs: ["c.java"],
Paul Duffin56d44902020-01-31 13:36:25 +0000692 },
693 }
694 `)
695
696 for _, scope := range []string{"", ".system", ".test"} {
Paul Duffin22b77cd2021-03-12 19:15:01 +0000697 fooModule := result.ModuleForTests("foo"+scope, "android_common")
Paul Duffin56d44902020-01-31 13:36:25 +0000698 javac := fooModule.Rule("javac")
699
Paul Duffin22b77cd2021-03-12 19:15:01 +0000700 sdklibStubsJar := result.ModuleForTests("sdklib.stubs"+scope, "android_common").Rule("combineJar").Output
701 android.AssertStringDoesContain(t, "foo classpath", javac.Args["classpath"], sdklibStubsJar.String())
Paul Duffin56d44902020-01-31 13:36:25 +0000702 }
Paul Duffinca8d9a52020-06-26 22:20:25 +0100703
Paul Duffin22b77cd2021-03-12 19:15:01 +0000704 CheckModuleDependencies(t, result.TestContext, "sdklib", "android_common", []string{
Paul Duffinca8d9a52020-06-26 22:20:25 +0100705 `prebuilt_sdklib.stubs`,
706 `prebuilt_sdklib.stubs.source.test`,
707 `prebuilt_sdklib.stubs.system`,
708 `prebuilt_sdklib.stubs.test`,
709 })
710}
711
712func TestJavaSdkLibraryImport_WithSource(t *testing.T) {
Paul Duffin71ae5942021-03-22 15:36:52 +0000713 result := android.GroupFixturePreparers(
714 prepareForJavaTest,
Paul Duffin163043d2021-03-12 19:18:49 +0000715 PrepareForTestWithJavaSdkLibraryFiles,
716 FixtureWithLastReleaseApis("sdklib"),
717 ).RunTestWithBp(t, `
Paul Duffinca8d9a52020-06-26 22:20:25 +0100718 java_sdk_library {
719 name: "sdklib",
720 srcs: ["a.java"],
721 sdk_version: "none",
722 system_modules: "none",
723 public: {
724 enabled: true,
725 },
726 }
727
728 java_sdk_library_import {
729 name: "sdklib",
730 public: {
731 jars: ["a.jar"],
732 },
733 }
734 `)
735
Paul Duffin22b77cd2021-03-12 19:15:01 +0000736 CheckModuleDependencies(t, result.TestContext, "sdklib", "android_common", []string{
Paul Duffinca8d9a52020-06-26 22:20:25 +0100737 `dex2oatd`,
738 `prebuilt_sdklib`,
739 `sdklib.impl`,
740 `sdklib.stubs`,
741 `sdklib.stubs.source`,
742 `sdklib.xml`,
743 })
744
Paul Duffin22b77cd2021-03-12 19:15:01 +0000745 CheckModuleDependencies(t, result.TestContext, "prebuilt_sdklib", "android_common", []string{
Paul Duffin44f1d842020-06-26 20:17:02 +0100746 `prebuilt_sdklib.stubs`,
Paul Duffinca8d9a52020-06-26 22:20:25 +0100747 `sdklib.impl`,
748 // This should be prebuilt_sdklib.stubs but is set to sdklib.stubs because the
749 // dependency is added after prebuilts may have been renamed and so has to use
750 // the renamed name.
Paul Duffinca8d9a52020-06-26 22:20:25 +0100751 `sdklib.xml`,
752 })
753}
754
755func TestJavaSdkLibraryImport_Preferred(t *testing.T) {
Paul Duffin71ae5942021-03-22 15:36:52 +0000756 result := android.GroupFixturePreparers(
757 prepareForJavaTest,
Paul Duffin163043d2021-03-12 19:18:49 +0000758 PrepareForTestWithJavaSdkLibraryFiles,
759 FixtureWithLastReleaseApis("sdklib"),
760 ).RunTestWithBp(t, `
Paul Duffinca8d9a52020-06-26 22:20:25 +0100761 java_sdk_library {
762 name: "sdklib",
763 srcs: ["a.java"],
764 sdk_version: "none",
765 system_modules: "none",
766 public: {
767 enabled: true,
768 },
769 }
770
771 java_sdk_library_import {
772 name: "sdklib",
773 prefer: true,
774 public: {
775 jars: ["a.jar"],
776 },
777 }
778 `)
779
Paul Duffin22b77cd2021-03-12 19:15:01 +0000780 CheckModuleDependencies(t, result.TestContext, "sdklib", "android_common", []string{
Paul Duffinca8d9a52020-06-26 22:20:25 +0100781 `dex2oatd`,
782 `prebuilt_sdklib`,
Paul Duffinca8d9a52020-06-26 22:20:25 +0100783 `sdklib.impl`,
Paul Duffin80342d72020-06-26 22:08:43 +0100784 `sdklib.stubs`,
Paul Duffinca8d9a52020-06-26 22:20:25 +0100785 `sdklib.stubs.source`,
786 `sdklib.xml`,
787 })
788
Paul Duffin22b77cd2021-03-12 19:15:01 +0000789 CheckModuleDependencies(t, result.TestContext, "prebuilt_sdklib", "android_common", []string{
Paul Duffinca8d9a52020-06-26 22:20:25 +0100790 `prebuilt_sdklib.stubs`,
791 `sdklib.impl`,
792 `sdklib.xml`,
793 })
Paul Duffin56d44902020-01-31 13:36:25 +0000794}
795
JaeMan Parkff715562020-10-19 17:25:58 +0900796func TestJavaSdkLibraryEnforce(t *testing.T) {
797 partitionToBpOption := func(partition string) string {
798 switch partition {
799 case "system":
800 return ""
801 case "vendor":
802 return "soc_specific: true,"
803 case "product":
804 return "product_specific: true,"
805 default:
806 panic("Invalid partition group name: " + partition)
807 }
808 }
809
810 type testConfigInfo struct {
811 libraryType string
812 fromPartition string
813 toPartition string
814 enforceVendorInterface bool
815 enforceProductInterface bool
816 enforceJavaSdkLibraryCheck bool
817 allowList []string
818 }
819
Paul Duffin05f72de2021-03-12 21:28:51 +0000820 createPreparer := func(info testConfigInfo) android.FixturePreparer {
JaeMan Parkff715562020-10-19 17:25:58 +0900821 bpFileTemplate := `
822 java_library {
823 name: "foo",
824 srcs: ["foo.java"],
825 libs: ["bar"],
826 sdk_version: "current",
827 %s
828 }
829
830 %s {
831 name: "bar",
832 srcs: ["bar.java"],
833 sdk_version: "current",
834 %s
835 }
836 `
837
838 bpFile := fmt.Sprintf(bpFileTemplate,
839 partitionToBpOption(info.fromPartition),
840 info.libraryType,
841 partitionToBpOption(info.toPartition))
842
Paul Duffin05f72de2021-03-12 21:28:51 +0000843 return android.GroupFixturePreparers(
Paul Duffin163043d2021-03-12 19:18:49 +0000844 PrepareForTestWithJavaSdkLibraryFiles,
845 FixtureWithLastReleaseApis("bar"),
Paul Duffin05f72de2021-03-12 21:28:51 +0000846 android.FixtureWithRootAndroidBp(bpFile),
847 android.FixtureModifyProductVariables(func(variables android.FixtureProductVariables) {
848 variables.EnforceProductPartitionInterface = proptools.BoolPtr(info.enforceProductInterface)
849 if info.enforceVendorInterface {
850 variables.DeviceVndkVersion = proptools.StringPtr("current")
851 }
852 variables.EnforceInterPartitionJavaSdkLibrary = proptools.BoolPtr(info.enforceJavaSdkLibraryCheck)
853 variables.InterPartitionJavaLibraryAllowList = info.allowList
854 }),
855 )
JaeMan Parkff715562020-10-19 17:25:58 +0900856 }
857
Paul Duffinaa6caa72021-03-13 16:50:15 +0000858 runTest := func(t *testing.T, info testConfigInfo, expectedErrorPattern string) {
Paul Duffina35178b2021-03-24 14:54:12 +0000859 t.Run(fmt.Sprintf("%v", info), func(t *testing.T) {
Paul Duffin05f72de2021-03-12 21:28:51 +0000860 errorHandler := android.FixtureExpectsNoErrors
861 if expectedErrorPattern != "" {
862 errorHandler = android.FixtureExpectsAtLeastOneErrorMatchingPattern(expectedErrorPattern)
Paul Duffinaa6caa72021-03-13 16:50:15 +0000863 }
Paul Duffin55e740e2021-03-29 02:06:19 +0100864 android.GroupFixturePreparers(
865 prepareForJavaTest,
866 createPreparer(info),
867 ).
868 ExtendWithErrorHandler(errorHandler).
869 RunTest(t)
Paul Duffinaa6caa72021-03-13 16:50:15 +0000870 })
871 }
872
JaeMan Parkff715562020-10-19 17:25:58 +0900873 errorMessage := "is not allowed across the partitions"
874
Paul Duffinaa6caa72021-03-13 16:50:15 +0000875 runTest(t, testConfigInfo{
JaeMan Park90e75352021-01-14 11:56:56 +0900876 libraryType: "java_library",
877 fromPartition: "product",
878 toPartition: "system",
879 enforceVendorInterface: true,
880 enforceProductInterface: true,
881 enforceJavaSdkLibraryCheck: false,
Paul Duffinaa6caa72021-03-13 16:50:15 +0000882 }, "")
JaeMan Parkff715562020-10-19 17:25:58 +0900883
Paul Duffinaa6caa72021-03-13 16:50:15 +0000884 runTest(t, testConfigInfo{
JaeMan Park90e75352021-01-14 11:56:56 +0900885 libraryType: "java_library",
886 fromPartition: "product",
887 toPartition: "system",
888 enforceVendorInterface: true,
889 enforceProductInterface: false,
890 enforceJavaSdkLibraryCheck: true,
Paul Duffinaa6caa72021-03-13 16:50:15 +0000891 }, "")
JaeMan Parkff715562020-10-19 17:25:58 +0900892
Paul Duffinaa6caa72021-03-13 16:50:15 +0000893 runTest(t, testConfigInfo{
JaeMan Park90e75352021-01-14 11:56:56 +0900894 libraryType: "java_library",
895 fromPartition: "product",
896 toPartition: "system",
897 enforceVendorInterface: true,
898 enforceProductInterface: true,
899 enforceJavaSdkLibraryCheck: true,
Paul Duffinaa6caa72021-03-13 16:50:15 +0000900 }, errorMessage)
JaeMan Parkff715562020-10-19 17:25:58 +0900901
Paul Duffinaa6caa72021-03-13 16:50:15 +0000902 runTest(t, testConfigInfo{
JaeMan Park90e75352021-01-14 11:56:56 +0900903 libraryType: "java_library",
904 fromPartition: "vendor",
905 toPartition: "system",
906 enforceVendorInterface: true,
907 enforceProductInterface: true,
908 enforceJavaSdkLibraryCheck: true,
Paul Duffinaa6caa72021-03-13 16:50:15 +0000909 }, errorMessage)
JaeMan Parkff715562020-10-19 17:25:58 +0900910
Paul Duffinaa6caa72021-03-13 16:50:15 +0000911 runTest(t, testConfigInfo{
JaeMan Parkff715562020-10-19 17:25:58 +0900912 libraryType: "java_library",
913 fromPartition: "vendor",
914 toPartition: "system",
915 enforceVendorInterface: true,
916 enforceProductInterface: true,
917 enforceJavaSdkLibraryCheck: true,
918 allowList: []string{"bar"},
Paul Duffinaa6caa72021-03-13 16:50:15 +0000919 }, "")
JaeMan Parkff715562020-10-19 17:25:58 +0900920
Paul Duffinaa6caa72021-03-13 16:50:15 +0000921 runTest(t, testConfigInfo{
JaeMan Parkff715562020-10-19 17:25:58 +0900922 libraryType: "java_library",
923 fromPartition: "vendor",
JaeMan Park90e75352021-01-14 11:56:56 +0900924 toPartition: "product",
925 enforceVendorInterface: true,
926 enforceProductInterface: true,
927 enforceJavaSdkLibraryCheck: true,
Paul Duffinaa6caa72021-03-13 16:50:15 +0000928 }, errorMessage)
JaeMan Park90e75352021-01-14 11:56:56 +0900929
Paul Duffinaa6caa72021-03-13 16:50:15 +0000930 runTest(t, testConfigInfo{
JaeMan Park90e75352021-01-14 11:56:56 +0900931 libraryType: "java_sdk_library",
932 fromPartition: "product",
JaeMan Parkff715562020-10-19 17:25:58 +0900933 toPartition: "system",
934 enforceVendorInterface: true,
935 enforceProductInterface: true,
936 enforceJavaSdkLibraryCheck: true,
Paul Duffinaa6caa72021-03-13 16:50:15 +0000937 }, "")
JaeMan Park90e75352021-01-14 11:56:56 +0900938
Paul Duffinaa6caa72021-03-13 16:50:15 +0000939 runTest(t, testConfigInfo{
JaeMan Park90e75352021-01-14 11:56:56 +0900940 libraryType: "java_sdk_library",
941 fromPartition: "vendor",
942 toPartition: "system",
943 enforceVendorInterface: true,
944 enforceProductInterface: true,
945 enforceJavaSdkLibraryCheck: true,
Paul Duffinaa6caa72021-03-13 16:50:15 +0000946 }, "")
JaeMan Park90e75352021-01-14 11:56:56 +0900947
Paul Duffinaa6caa72021-03-13 16:50:15 +0000948 runTest(t, testConfigInfo{
JaeMan Park90e75352021-01-14 11:56:56 +0900949 libraryType: "java_sdk_library",
950 fromPartition: "vendor",
951 toPartition: "product",
952 enforceVendorInterface: true,
953 enforceProductInterface: true,
954 enforceJavaSdkLibraryCheck: true,
Paul Duffinaa6caa72021-03-13 16:50:15 +0000955 }, "")
JaeMan Parkff715562020-10-19 17:25:58 +0900956}
957
Colin Cross89536d42017-07-07 14:35:50 -0700958func TestDefaults(t *testing.T) {
Jaewoong Jungf9a04432019-07-17 11:15:09 -0700959 ctx, _ := testJava(t, `
Colin Cross89536d42017-07-07 14:35:50 -0700960 java_defaults {
961 name: "defaults",
962 srcs: ["a.java"],
963 libs: ["bar"],
964 static_libs: ["baz"],
Sasha Smundak2057f822019-04-16 17:16:58 -0700965 optimize: {enabled: false},
Colin Cross89536d42017-07-07 14:35:50 -0700966 }
967
968 java_library {
969 name: "foo",
970 defaults: ["defaults"],
971 }
972
973 java_library {
974 name: "bar",
975 srcs: ["b.java"],
976 }
977
978 java_library {
979 name: "baz",
980 srcs: ["c.java"],
981 }
Sasha Smundak2057f822019-04-16 17:16:58 -0700982
983 android_test {
984 name: "atestOptimize",
985 defaults: ["defaults"],
986 optimize: {enabled: true},
987 }
988
989 android_test {
990 name: "atestNoOptimize",
991 defaults: ["defaults"],
992 }
993
994 android_test {
995 name: "atestDefault",
996 srcs: ["a.java"],
997 }
Colin Cross89536d42017-07-07 14:35:50 -0700998 `)
999
Paul Duffina71a67a2021-03-29 00:42:57 +01001000 javac := ctx.ModuleForTests("foo", "android_common").Rule("javac")
Nan Zhanged19fc32017-10-19 13:06:22 -07001001 combineJar := ctx.ModuleForTests("foo", "android_common").Description("for javac")
Colin Cross89536d42017-07-07 14:35:50 -07001002
1003 if len(javac.Inputs) != 1 || javac.Inputs[0].String() != "a.java" {
1004 t.Errorf(`foo inputs %v != ["a.java"]`, javac.Inputs)
1005 }
1006
Paul Duffin414ea5e2021-03-22 17:31:52 +00001007 barTurbine := filepath.Join("out", "soong", ".intermediates", "bar", "android_common", "turbine-combined", "bar.jar")
Nan Zhanged19fc32017-10-19 13:06:22 -07001008 if !strings.Contains(javac.Args["classpath"], barTurbine) {
1009 t.Errorf("foo classpath %v does not contain %q", javac.Args["classpath"], barTurbine)
Colin Cross89536d42017-07-07 14:35:50 -07001010 }
1011
Colin Cross1ee23172017-10-18 14:44:18 -07001012 baz := ctx.ModuleForTests("baz", "android_common").Rule("javac").Output.String()
Colin Cross0a6e0072017-08-30 14:24:55 -07001013 if len(combineJar.Inputs) != 2 || combineJar.Inputs[1].String() != baz {
1014 t.Errorf("foo combineJar inputs %v does not contain %q", combineJar.Inputs, baz)
Colin Cross89536d42017-07-07 14:35:50 -07001015 }
Sasha Smundak2057f822019-04-16 17:16:58 -07001016
1017 atestOptimize := ctx.ModuleForTests("atestOptimize", "android_common").MaybeRule("r8")
1018 if atestOptimize.Output == nil {
1019 t.Errorf("atestOptimize should optimize APK")
1020 }
1021
1022 atestNoOptimize := ctx.ModuleForTests("atestNoOptimize", "android_common").MaybeRule("d8")
1023 if atestNoOptimize.Output == nil {
1024 t.Errorf("atestNoOptimize should not optimize APK")
1025 }
1026
1027 atestDefault := ctx.ModuleForTests("atestDefault", "android_common").MaybeRule("r8")
1028 if atestDefault.Output == nil {
1029 t.Errorf("atestDefault should optimize APK")
1030 }
Colin Cross89536d42017-07-07 14:35:50 -07001031}
1032
Colin Cross0f37af02017-09-27 17:42:05 -07001033func TestResources(t *testing.T) {
1034 var table = []struct {
1035 name string
1036 prop string
1037 extra string
1038 args string
1039 }{
1040 {
Colin Crossaf9c55b2017-10-03 14:50:08 -07001041 // Test that a module with java_resource_dirs includes the files
Colin Cross0f37af02017-09-27 17:42:05 -07001042 name: "resource dirs",
Colin Cross824bee32017-11-22 17:27:51 -08001043 prop: `java_resource_dirs: ["java-res"]`,
Colin Cross0ead1d72018-04-10 13:07:42 -07001044 args: "-C java-res -f java-res/a/a -f java-res/b/b",
Colin Cross0f37af02017-09-27 17:42:05 -07001045 },
1046 {
1047 // Test that a module with java_resources includes the files
1048 name: "resource files",
Colin Cross0ead1d72018-04-10 13:07:42 -07001049 prop: `java_resources: ["java-res/a/a", "java-res/b/b"]`,
1050 args: "-C . -f java-res/a/a -f java-res/b/b",
Colin Cross0f37af02017-09-27 17:42:05 -07001051 },
1052 {
1053 // Test that a module with a filegroup in java_resources includes the files with the
1054 // path prefix
1055 name: "resource filegroup",
1056 prop: `java_resources: [":foo-res"]`,
1057 extra: `
1058 filegroup {
1059 name: "foo-res",
Colin Cross824bee32017-11-22 17:27:51 -08001060 path: "java-res",
Colin Cross0ead1d72018-04-10 13:07:42 -07001061 srcs: ["java-res/a/a", "java-res/b/b"],
Colin Cross0f37af02017-09-27 17:42:05 -07001062 }`,
Colin Cross0ead1d72018-04-10 13:07:42 -07001063 args: "-C java-res -f java-res/a/a -f java-res/b/b",
Colin Cross0f37af02017-09-27 17:42:05 -07001064 },
1065 {
Colin Cross0ead1d72018-04-10 13:07:42 -07001066 // Test that a module with wildcards in java_resource_dirs has the correct path prefixes
1067 name: "wildcard dirs",
1068 prop: `java_resource_dirs: ["java-res/*"]`,
1069 args: "-C java-res/a -f java-res/a/a -C java-res/b -f java-res/b/b",
1070 },
1071 {
1072 // Test that a module exclude_java_resource_dirs excludes the files
1073 name: "wildcard dirs",
1074 prop: `java_resource_dirs: ["java-res/*"], exclude_java_resource_dirs: ["java-res/b"]`,
1075 args: "-C java-res/a -f java-res/a/a",
1076 },
Colin Crosscedd4762018-09-13 11:26:19 -07001077 {
1078 // Test wildcards in java_resources
1079 name: "wildcard files",
1080 prop: `java_resources: ["java-res/**/*"]`,
1081 args: "-C . -f java-res/a/a -f java-res/b/b",
1082 },
1083 {
1084 // Test exclude_java_resources with java_resources
1085 name: "wildcard files with exclude",
1086 prop: `java_resources: ["java-res/**/*"], exclude_java_resources: ["java-res/b/*"]`,
1087 args: "-C . -f java-res/a/a",
1088 },
1089 {
1090 // Test exclude_java_resources with java_resource_dirs
1091 name: "resource dirs with exclude files",
1092 prop: `java_resource_dirs: ["java-res"], exclude_java_resources: ["java-res/b/b"]`,
1093 args: "-C java-res -f java-res/a/a",
1094 },
1095 {
1096 // Test exclude_java_resource_dirs with java_resource_dirs
1097 name: "resource dirs with exclude files",
1098 prop: `java_resource_dirs: ["java-res", "java-res2"], exclude_java_resource_dirs: ["java-res2"]`,
1099 args: "-C java-res -f java-res/a/a -f java-res/b/b",
1100 },
Colin Cross0f37af02017-09-27 17:42:05 -07001101 }
1102
1103 for _, test := range table {
1104 t.Run(test.name, func(t *testing.T) {
Colin Cross238c1f32020-06-07 16:58:18 -07001105 ctx, _ := testJavaWithFS(t, `
Colin Cross0f37af02017-09-27 17:42:05 -07001106 java_library {
1107 name: "foo",
1108 srcs: [
1109 "a.java",
1110 "b.java",
1111 "c.java",
1112 ],
1113 `+test.prop+`,
1114 }
Colin Cross238c1f32020-06-07 16:58:18 -07001115 `+test.extra,
1116 map[string][]byte{
1117 "java-res/a/a": nil,
1118 "java-res/b/b": nil,
1119 "java-res2/a": nil,
1120 },
1121 )
Colin Cross0f37af02017-09-27 17:42:05 -07001122
Colin Cross331a1212018-08-15 20:40:52 -07001123 foo := ctx.ModuleForTests("foo", "android_common").Output("withres/foo.jar")
Colin Cross1ee23172017-10-18 14:44:18 -07001124 fooRes := ctx.ModuleForTests("foo", "android_common").Output("res/foo.jar")
Colin Cross0f37af02017-09-27 17:42:05 -07001125
1126 if !inList(fooRes.Output.String(), foo.Inputs.Strings()) {
1127 t.Errorf("foo combined jars %v does not contain %q",
1128 foo.Inputs.Strings(), fooRes.Output.String())
1129 }
1130
Colin Crossaf9c55b2017-10-03 14:50:08 -07001131 if fooRes.Args["jarArgs"] != test.args {
1132 t.Errorf("foo resource jar args %q is not %q",
Colin Cross0f37af02017-09-27 17:42:05 -07001133 fooRes.Args["jarArgs"], test.args)
1134 }
1135 })
1136 }
1137}
1138
Colin Cross0c4ce212019-05-03 15:28:19 -07001139func TestIncludeSrcs(t *testing.T) {
Colin Cross238c1f32020-06-07 16:58:18 -07001140 ctx, _ := testJavaWithFS(t, `
Colin Cross0c4ce212019-05-03 15:28:19 -07001141 java_library {
1142 name: "foo",
1143 srcs: [
1144 "a.java",
1145 "b.java",
1146 "c.java",
1147 ],
1148 include_srcs: true,
1149 }
1150
1151 java_library {
1152 name: "bar",
1153 srcs: [
1154 "a.java",
1155 "b.java",
1156 "c.java",
1157 ],
1158 java_resource_dirs: ["java-res"],
1159 include_srcs: true,
1160 }
Colin Cross238c1f32020-06-07 16:58:18 -07001161 `, map[string][]byte{
1162 "java-res/a/a": nil,
1163 "java-res/b/b": nil,
1164 "java-res2/a": nil,
1165 })
Colin Cross0c4ce212019-05-03 15:28:19 -07001166
1167 // Test a library with include_srcs: true
1168 foo := ctx.ModuleForTests("foo", "android_common").Output("withres/foo.jar")
1169 fooSrcJar := ctx.ModuleForTests("foo", "android_common").Output("foo.srcjar")
1170
1171 if g, w := fooSrcJar.Output.String(), foo.Inputs.Strings(); !inList(g, w) {
1172 t.Errorf("foo combined jars %v does not contain %q", w, g)
1173 }
1174
1175 if g, w := fooSrcJar.Args["jarArgs"], "-C . -f a.java -f b.java -f c.java"; g != w {
1176 t.Errorf("foo source jar args %q is not %q", w, g)
1177 }
1178
1179 // Test a library with include_srcs: true and resources
1180 bar := ctx.ModuleForTests("bar", "android_common").Output("withres/bar.jar")
1181 barResCombined := ctx.ModuleForTests("bar", "android_common").Output("res-combined/bar.jar")
1182 barRes := ctx.ModuleForTests("bar", "android_common").Output("res/bar.jar")
1183 barSrcJar := ctx.ModuleForTests("bar", "android_common").Output("bar.srcjar")
1184
1185 if g, w := barSrcJar.Output.String(), barResCombined.Inputs.Strings(); !inList(g, w) {
1186 t.Errorf("bar combined resource jars %v does not contain %q", w, g)
1187 }
1188
1189 if g, w := barRes.Output.String(), barResCombined.Inputs.Strings(); !inList(g, w) {
1190 t.Errorf("bar combined resource jars %v does not contain %q", w, g)
1191 }
1192
1193 if g, w := barResCombined.Output.String(), bar.Inputs.Strings(); !inList(g, w) {
1194 t.Errorf("bar combined jars %v does not contain %q", w, g)
1195 }
1196
1197 if g, w := barSrcJar.Args["jarArgs"], "-C . -f a.java -f b.java -f c.java"; g != w {
1198 t.Errorf("bar source jar args %q is not %q", w, g)
1199 }
1200
1201 if g, w := barRes.Args["jarArgs"], "-C java-res -f java-res/a/a -f java-res/b/b"; g != w {
1202 t.Errorf("bar resource jar args %q is not %q", w, g)
1203 }
1204}
1205
Colin Cross54190b32017-10-09 15:34:10 -07001206func TestGeneratedSources(t *testing.T) {
Colin Cross238c1f32020-06-07 16:58:18 -07001207 ctx, _ := testJavaWithFS(t, `
Colin Cross54190b32017-10-09 15:34:10 -07001208 java_library {
1209 name: "foo",
1210 srcs: [
1211 "a*.java",
1212 ":gen",
1213 "b*.java",
1214 ],
1215 }
1216
1217 genrule {
1218 name: "gen",
Colin Cross824bee32017-11-22 17:27:51 -08001219 tool_files: ["java-res/a"],
Colin Cross54190b32017-10-09 15:34:10 -07001220 out: ["gen.java"],
1221 }
Colin Cross238c1f32020-06-07 16:58:18 -07001222 `, map[string][]byte{
1223 "a.java": nil,
1224 "b.java": nil,
1225 })
Colin Cross54190b32017-10-09 15:34:10 -07001226
1227 javac := ctx.ModuleForTests("foo", "android_common").Rule("javac")
1228 genrule := ctx.ModuleForTests("gen", "").Rule("generator")
1229
Colin Cross15e86d92017-10-20 15:07:08 -07001230 if filepath.Base(genrule.Output.String()) != "gen.java" {
1231 t.Fatalf(`gen output file %v is not ".../gen.java"`, genrule.Output.String())
Colin Cross54190b32017-10-09 15:34:10 -07001232 }
1233
1234 if len(javac.Inputs) != 3 ||
1235 javac.Inputs[0].String() != "a.java" ||
Colin Cross15e86d92017-10-20 15:07:08 -07001236 javac.Inputs[1].String() != genrule.Output.String() ||
Colin Cross54190b32017-10-09 15:34:10 -07001237 javac.Inputs[2].String() != "b.java" {
1238 t.Errorf(`foo inputs %v != ["a.java", ".../gen.java", "b.java"]`, javac.Inputs)
1239 }
1240}
1241
Nan Zhang61eaedb2017-11-02 13:28:15 -07001242func TestTurbine(t *testing.T) {
Paul Duffin71ae5942021-03-22 15:36:52 +00001243 result := android.GroupFixturePreparers(
1244 prepareForJavaTest, FixtureWithPrebuiltApis(map[string][]string{"14": {"foo"}})).
Paul Duffin3d9f2682021-03-13 09:47:16 +00001245 RunTestWithBp(t, `
Nan Zhang61eaedb2017-11-02 13:28:15 -07001246 java_library {
1247 name: "foo",
1248 srcs: ["a.java"],
Jiyong Park2d492942018-03-05 17:44:10 +09001249 sdk_version: "14",
Nan Zhang61eaedb2017-11-02 13:28:15 -07001250 }
1251
1252 java_library {
1253 name: "bar",
Colin Cross9bc43432017-12-15 20:20:39 -08001254 srcs: ["b.java"],
Nan Zhang61eaedb2017-11-02 13:28:15 -07001255 static_libs: ["foo"],
Jiyong Park2d492942018-03-05 17:44:10 +09001256 sdk_version: "14",
Nan Zhang61eaedb2017-11-02 13:28:15 -07001257 }
1258
1259 java_library {
1260 name: "baz",
1261 srcs: ["c.java"],
1262 libs: ["bar"],
1263 sdk_version: "14",
1264 }
1265 `)
1266
Paul Duffina71a67a2021-03-29 00:42:57 +01001267 fooTurbine := result.ModuleForTests("foo", "android_common").Rule("turbine")
1268 barTurbine := result.ModuleForTests("bar", "android_common").Rule("turbine")
1269 barJavac := result.ModuleForTests("bar", "android_common").Rule("javac")
1270 barTurbineCombined := result.ModuleForTests("bar", "android_common").Description("for turbine")
1271 bazJavac := result.ModuleForTests("baz", "android_common").Rule("javac")
Nan Zhang61eaedb2017-11-02 13:28:15 -07001272
Paul Duffin414ea5e2021-03-22 17:31:52 +00001273 android.AssertPathsRelativeToTopEquals(t, "foo inputs", []string{"a.java"}, fooTurbine.Inputs)
Nan Zhang61eaedb2017-11-02 13:28:15 -07001274
Paul Duffin414ea5e2021-03-22 17:31:52 +00001275 fooHeaderJar := filepath.Join("out", "soong", ".intermediates", "foo", "android_common", "turbine-combined", "foo.jar")
1276 barTurbineJar := filepath.Join("out", "soong", ".intermediates", "bar", "android_common", "turbine", "bar.jar")
Paul Duffin3d9f2682021-03-13 09:47:16 +00001277 android.AssertStringDoesContain(t, "bar turbine classpath", barTurbine.Args["classpath"], fooHeaderJar)
1278 android.AssertStringDoesContain(t, "bar javac classpath", barJavac.Args["classpath"], fooHeaderJar)
Paul Duffin414ea5e2021-03-22 17:31:52 +00001279 android.AssertPathsRelativeToTopEquals(t, "bar turbine combineJar", []string{barTurbineJar, fooHeaderJar}, barTurbineCombined.Inputs)
Paul Duffin3d9f2682021-03-13 09:47:16 +00001280 android.AssertStringDoesContain(t, "baz javac classpath", bazJavac.Args["classpath"], "prebuilts/sdk/14/public/android.jar")
Nan Zhang61eaedb2017-11-02 13:28:15 -07001281}
1282
1283func TestSharding(t *testing.T) {
Jaewoong Jungf9a04432019-07-17 11:15:09 -07001284 ctx, _ := testJava(t, `
Nan Zhang61eaedb2017-11-02 13:28:15 -07001285 java_library {
1286 name: "bar",
1287 srcs: ["a.java","b.java","c.java"],
1288 javac_shard_size: 1
1289 }
1290 `)
1291
Paul Duffin414ea5e2021-03-22 17:31:52 +00001292 barHeaderJar := filepath.Join("out", "soong", ".intermediates", "bar", "android_common", "turbine-combined", "bar.jar")
Nan Zhang61eaedb2017-11-02 13:28:15 -07001293 for i := 0; i < 3; i++ {
Paul Duffina71a67a2021-03-29 00:42:57 +01001294 barJavac := ctx.ModuleForTests("bar", "android_common").Description("javac" + strconv.Itoa(i))
Nan Zhang61eaedb2017-11-02 13:28:15 -07001295 if !strings.Contains(barJavac.Args["classpath"], barHeaderJar) {
1296 t.Errorf("bar javac classpath %v does not contain %q", barJavac.Args["classpath"], barHeaderJar)
1297 }
1298 }
1299}
1300
Colin Cross54250902017-12-05 09:28:08 -08001301func TestJarGenrules(t *testing.T) {
Jaewoong Jungf9a04432019-07-17 11:15:09 -07001302 ctx, _ := testJava(t, `
Colin Cross54250902017-12-05 09:28:08 -08001303 java_library {
1304 name: "foo",
1305 srcs: ["a.java"],
1306 }
1307
1308 java_genrule {
1309 name: "jargen",
1310 tool_files: ["b.java"],
1311 cmd: "$(location b.java) $(in) $(out)",
1312 out: ["jargen.jar"],
1313 srcs: [":foo"],
1314 }
1315
1316 java_library {
1317 name: "bar",
1318 static_libs: ["jargen"],
1319 srcs: ["c.java"],
1320 }
1321
1322 java_library {
1323 name: "baz",
1324 libs: ["jargen"],
1325 srcs: ["c.java"],
1326 }
1327 `)
1328
1329 foo := ctx.ModuleForTests("foo", "android_common").Output("javac/foo.jar")
1330 jargen := ctx.ModuleForTests("jargen", "android_common").Output("jargen.jar")
1331 bar := ctx.ModuleForTests("bar", "android_common").Output("javac/bar.jar")
1332 baz := ctx.ModuleForTests("baz", "android_common").Output("javac/baz.jar")
1333 barCombined := ctx.ModuleForTests("bar", "android_common").Output("combined/bar.jar")
1334
Colin Cross3d680512020-11-13 16:23:53 -08001335 if g, w := jargen.Implicits.Strings(), foo.Output.String(); !android.InList(w, g) {
1336 t.Errorf("expected jargen inputs [%q], got %q", w, g)
Colin Cross54250902017-12-05 09:28:08 -08001337 }
1338
1339 if !strings.Contains(bar.Args["classpath"], jargen.Output.String()) {
1340 t.Errorf("bar classpath %v does not contain %q", bar.Args["classpath"], jargen.Output.String())
1341 }
1342
1343 if !strings.Contains(baz.Args["classpath"], jargen.Output.String()) {
1344 t.Errorf("baz classpath %v does not contain %q", baz.Args["classpath"], jargen.Output.String())
1345 }
1346
1347 if len(barCombined.Inputs) != 2 ||
1348 barCombined.Inputs[0].String() != bar.Output.String() ||
1349 barCombined.Inputs[1].String() != jargen.Output.String() {
1350 t.Errorf("bar combined jar inputs %v is not [%q, %q]",
1351 barCombined.Inputs.Strings(), bar.Output.String(), jargen.Output.String())
1352 }
1353}
1354
Nan Zhang27e284d2018-02-09 21:03:53 +00001355func TestExcludeFileGroupInSrcs(t *testing.T) {
Jaewoong Jungf9a04432019-07-17 11:15:09 -07001356 ctx, _ := testJava(t, `
Nan Zhang27e284d2018-02-09 21:03:53 +00001357 java_library {
1358 name: "foo",
1359 srcs: ["a.java", ":foo-srcs"],
1360 exclude_srcs: ["a.java", ":foo-excludes"],
1361 }
1362
1363 filegroup {
1364 name: "foo-srcs",
1365 srcs: ["java-fg/a.java", "java-fg/b.java", "java-fg/c.java"],
1366 }
1367
1368 filegroup {
1369 name: "foo-excludes",
1370 srcs: ["java-fg/a.java", "java-fg/b.java"],
1371 }
1372 `)
1373
1374 javac := ctx.ModuleForTests("foo", "android_common").Rule("javac")
1375
1376 if len(javac.Inputs) != 1 || javac.Inputs[0].String() != "java-fg/c.java" {
1377 t.Errorf(`foo inputs %v != ["java-fg/c.java"]`, javac.Inputs)
1378 }
1379}
Jiyong Parkc678ad32018-04-10 13:07:10 +09001380
Paul Duffin52d398a2019-06-11 12:31:14 +01001381func TestJavaLibrary(t *testing.T) {
Paul Duffin414ea5e2021-03-22 17:31:52 +00001382 testJavaWithFS(t, "", map[string][]byte{
Paul Duffin52d398a2019-06-11 12:31:14 +01001383 "libcore/Android.bp": []byte(`
1384 java_library {
1385 name: "core",
1386 sdk_version: "none",
1387 system_modules: "none",
Paul Duffinaa55f742020-10-06 17:20:13 +01001388 }
1389
1390 filegroup {
1391 name: "core-jar",
1392 srcs: [":core{.jar}"],
1393 }
Paul Duffin414ea5e2021-03-22 17:31:52 +00001394 `),
Paul Duffinaa55f742020-10-06 17:20:13 +01001395 })
Paul Duffinaa55f742020-10-06 17:20:13 +01001396}
1397
1398func TestJavaImport(t *testing.T) {
Paul Duffin414ea5e2021-03-22 17:31:52 +00001399 testJavaWithFS(t, "", map[string][]byte{
Paul Duffinaa55f742020-10-06 17:20:13 +01001400 "libcore/Android.bp": []byte(`
1401 java_import {
1402 name: "core",
1403 sdk_version: "none",
1404 }
1405
1406 filegroup {
1407 name: "core-jar",
1408 srcs: [":core{.jar}"],
1409 }
Paul Duffin414ea5e2021-03-22 17:31:52 +00001410 `),
Paul Duffin52d398a2019-06-11 12:31:14 +01001411 })
Paul Duffin52d398a2019-06-11 12:31:14 +01001412}
1413
Jiyong Parkc678ad32018-04-10 13:07:10 +09001414func TestJavaSdkLibrary(t *testing.T) {
Paul Duffin71ae5942021-03-22 15:36:52 +00001415 result := android.GroupFixturePreparers(
1416 prepareForJavaTest,
Paul Duffin163043d2021-03-12 19:18:49 +00001417 PrepareForTestWithJavaSdkLibraryFiles,
1418 FixtureWithPrebuiltApis(map[string][]string{
1419 "28": {"foo"},
1420 "29": {"foo"},
1421 "30": {"bar", "barney", "baz", "betty", "foo", "fred", "quuz", "wilma"},
1422 }),
1423 ).RunTestWithBp(t, `
Paul Duffin884363e2019-12-19 10:21:09 +00001424 droiddoc_exported_dir {
Jiyong Parkc678ad32018-04-10 13:07:10 +09001425 name: "droiddoc-templates-sdk",
1426 path: ".",
1427 }
Jiyong Parkc678ad32018-04-10 13:07:10 +09001428 java_sdk_library {
1429 name: "foo",
1430 srcs: ["a.java", "b.java"],
1431 api_packages: ["foo"],
1432 }
1433 java_sdk_library {
1434 name: "bar",
1435 srcs: ["a.java", "b.java"],
1436 api_packages: ["bar"],
1437 }
1438 java_library {
1439 name: "baz",
1440 srcs: ["c.java"],
Paul Duffin859fe962020-05-15 10:20:31 +01001441 libs: ["foo", "bar.stubs"],
Jiyong Parkc678ad32018-04-10 13:07:10 +09001442 sdk_version: "system_current",
1443 }
Paul Duffindfa131e2020-05-15 20:37:11 +01001444 java_sdk_library {
1445 name: "barney",
1446 srcs: ["c.java"],
1447 api_only: true,
1448 }
1449 java_sdk_library {
1450 name: "betty",
1451 srcs: ["c.java"],
1452 shared_library: false,
1453 }
Paul Duffin859fe962020-05-15 10:20:31 +01001454 java_sdk_library_import {
1455 name: "quuz",
1456 public: {
1457 jars: ["c.jar"],
1458 },
1459 }
1460 java_sdk_library_import {
1461 name: "fred",
1462 public: {
1463 jars: ["b.jar"],
1464 },
1465 }
Paul Duffindfa131e2020-05-15 20:37:11 +01001466 java_sdk_library_import {
1467 name: "wilma",
1468 public: {
1469 jars: ["b.jar"],
1470 },
1471 shared_library: false,
1472 }
Jiyong Park1be96912018-05-28 18:02:19 +09001473 java_library {
1474 name: "qux",
1475 srcs: ["c.java"],
Paul Duffindfa131e2020-05-15 20:37:11 +01001476 libs: ["baz", "fred", "quuz.stubs", "wilma", "barney", "betty"],
Jiyong Park1be96912018-05-28 18:02:19 +09001477 sdk_version: "system_current",
1478 }
Paul Duffin726d23c2020-01-22 16:30:37 +00001479 java_library {
1480 name: "baz-test",
1481 srcs: ["c.java"],
1482 libs: ["foo"],
1483 sdk_version: "test_current",
1484 }
Paul Duffina2db18f2020-01-22 17:11:15 +00001485 java_library {
1486 name: "baz-29",
1487 srcs: ["c.java"],
1488 libs: ["foo"],
1489 sdk_version: "system_29",
1490 }
Paul Duffinfb6ae5b2020-09-30 15:17:25 +01001491 java_library {
1492 name: "baz-module-30",
1493 srcs: ["c.java"],
1494 libs: ["foo"],
1495 sdk_version: "module_30",
1496 }
Jiyong Parkc678ad32018-04-10 13:07:10 +09001497 `)
1498
1499 // check the existence of the internal modules
Paul Duffin22b77cd2021-03-12 19:15:01 +00001500 result.ModuleForTests("foo", "android_common")
1501 result.ModuleForTests(apiScopePublic.stubsLibraryModuleName("foo"), "android_common")
1502 result.ModuleForTests(apiScopeSystem.stubsLibraryModuleName("foo"), "android_common")
1503 result.ModuleForTests(apiScopeTest.stubsLibraryModuleName("foo"), "android_common")
1504 result.ModuleForTests(apiScopePublic.stubsSourceModuleName("foo"), "android_common")
1505 result.ModuleForTests(apiScopeSystem.stubsSourceModuleName("foo"), "android_common")
1506 result.ModuleForTests(apiScopeTest.stubsSourceModuleName("foo"), "android_common")
1507 result.ModuleForTests("foo"+sdkXmlFileSuffix, "android_common")
1508 result.ModuleForTests("foo.api.public.28", "")
1509 result.ModuleForTests("foo.api.system.28", "")
1510 result.ModuleForTests("foo.api.test.28", "")
Jiyong Parkc678ad32018-04-10 13:07:10 +09001511
Paul Duffin22b77cd2021-03-12 19:15:01 +00001512 bazJavac := result.ModuleForTests("baz", "android_common").Rule("javac")
Jiyong Parkc678ad32018-04-10 13:07:10 +09001513 // tests if baz is actually linked to the stubs lib
Paul Duffin22b77cd2021-03-12 19:15:01 +00001514 android.AssertStringDoesContain(t, "baz javac classpath", bazJavac.Args["classpath"], "foo.stubs.system.jar")
Jiyong Parkc678ad32018-04-10 13:07:10 +09001515 // ... and not to the impl lib
Paul Duffin22b77cd2021-03-12 19:15:01 +00001516 android.AssertStringDoesNotContain(t, "baz javac classpath", bazJavac.Args["classpath"], "foo.jar")
Jiyong Parkc678ad32018-04-10 13:07:10 +09001517 // test if baz is not linked to the system variant of foo
Paul Duffin22b77cd2021-03-12 19:15:01 +00001518 android.AssertStringDoesNotContain(t, "baz javac classpath", bazJavac.Args["classpath"], "foo.stubs.jar")
Jiyong Park1be96912018-05-28 18:02:19 +09001519
Paul Duffin22b77cd2021-03-12 19:15:01 +00001520 bazTestJavac := result.ModuleForTests("baz-test", "android_common").Rule("javac")
Paul Duffin726d23c2020-01-22 16:30:37 +00001521 // tests if baz-test is actually linked to the test stubs lib
Paul Duffin22b77cd2021-03-12 19:15:01 +00001522 android.AssertStringDoesContain(t, "baz-test javac classpath", bazTestJavac.Args["classpath"], "foo.stubs.test.jar")
Paul Duffin726d23c2020-01-22 16:30:37 +00001523
Paul Duffin22b77cd2021-03-12 19:15:01 +00001524 baz29Javac := result.ModuleForTests("baz-29", "android_common").Rule("javac")
Paul Duffina2db18f2020-01-22 17:11:15 +00001525 // tests if baz-29 is actually linked to the system 29 stubs lib
Paul Duffin22b77cd2021-03-12 19:15:01 +00001526 android.AssertStringDoesContain(t, "baz-29 javac classpath", baz29Javac.Args["classpath"], "prebuilts/sdk/29/system/foo.jar")
Paul Duffina2db18f2020-01-22 17:11:15 +00001527
Paul Duffin22b77cd2021-03-12 19:15:01 +00001528 bazModule30Javac := result.ModuleForTests("baz-module-30", "android_common").Rule("javac")
Paul Duffinfb6ae5b2020-09-30 15:17:25 +01001529 // tests if "baz-module-30" is actually linked to the module 30 stubs lib
Paul Duffin22b77cd2021-03-12 19:15:01 +00001530 android.AssertStringDoesContain(t, "baz-module-30 javac classpath", bazModule30Javac.Args["classpath"], "prebuilts/sdk/30/module-lib/foo.jar")
Paul Duffinfb6ae5b2020-09-30 15:17:25 +01001531
Jiyong Park1be96912018-05-28 18:02:19 +09001532 // test if baz has exported SDK lib names foo and bar to qux
Paul Duffin22b77cd2021-03-12 19:15:01 +00001533 qux := result.ModuleForTests("qux", "android_common")
Jiyong Park1be96912018-05-28 18:02:19 +09001534 if quxLib, ok := qux.Module().(*Library); ok {
Ulya Trafimovichb23d28c2020-10-08 12:53:58 +01001535 sdkLibs := quxLib.ClassLoaderContexts().UsesLibs()
Paul Duffin22b77cd2021-03-12 19:15:01 +00001536 android.AssertDeepEquals(t, "qux exports", []string{"foo", "bar", "fred", "quuz"}, sdkLibs)
Jiyong Park1be96912018-05-28 18:02:19 +09001537 }
Jiyong Parkc678ad32018-04-10 13:07:10 +09001538}
Zoran Jovanovic8736ce22018-08-21 17:10:29 +02001539
Anton Hansson7f66efa2020-10-08 14:47:23 +01001540func TestJavaSdkLibrary_StubOrImplOnlyLibs(t *testing.T) {
Paul Duffin71ae5942021-03-22 15:36:52 +00001541 result := android.GroupFixturePreparers(
1542 prepareForJavaTest,
Paul Duffin163043d2021-03-12 19:18:49 +00001543 PrepareForTestWithJavaSdkLibraryFiles,
1544 FixtureWithLastReleaseApis("sdklib"),
1545 ).RunTestWithBp(t, `
Anton Hansson7f66efa2020-10-08 14:47:23 +01001546 java_sdk_library {
Anton Hanssondff2c782020-12-21 17:10:01 +00001547 name: "sdklib",
Anton Hansson7f66efa2020-10-08 14:47:23 +01001548 srcs: ["a.java"],
1549 impl_only_libs: ["foo"],
1550 stub_only_libs: ["bar"],
1551 }
1552 java_library {
1553 name: "foo",
1554 srcs: ["a.java"],
1555 sdk_version: "current",
1556 }
1557 java_library {
1558 name: "bar",
1559 srcs: ["a.java"],
1560 sdk_version: "current",
1561 }
1562 `)
1563
Anton Hanssondff2c782020-12-21 17:10:01 +00001564 for _, implName := range []string{"sdklib", "sdklib.impl"} {
Paul Duffin22b77cd2021-03-12 19:15:01 +00001565 implJavacCp := result.ModuleForTests(implName, "android_common").Rule("javac").Args["classpath"]
Anton Hansson7f66efa2020-10-08 14:47:23 +01001566 if !strings.Contains(implJavacCp, "/foo.jar") || strings.Contains(implJavacCp, "/bar.jar") {
1567 t.Errorf("%v javac classpath %v does not contain foo and not bar", implName, implJavacCp)
1568 }
1569 }
Anton Hanssondff2c782020-12-21 17:10:01 +00001570 stubName := apiScopePublic.stubsLibraryModuleName("sdklib")
Paul Duffin22b77cd2021-03-12 19:15:01 +00001571 stubsJavacCp := result.ModuleForTests(stubName, "android_common").Rule("javac").Args["classpath"]
Anton Hansson7f66efa2020-10-08 14:47:23 +01001572 if strings.Contains(stubsJavacCp, "/foo.jar") || !strings.Contains(stubsJavacCp, "/bar.jar") {
1573 t.Errorf("stubs javac classpath %v does not contain bar and not foo", stubsJavacCp)
1574 }
1575}
1576
Paul Duffindaaa3322020-05-26 18:13:57 +01001577func TestJavaSdkLibrary_DoNotAccessImplWhenItIsNotBuilt(t *testing.T) {
Paul Duffin71ae5942021-03-22 15:36:52 +00001578 result := android.GroupFixturePreparers(
1579 prepareForJavaTest,
Paul Duffin163043d2021-03-12 19:18:49 +00001580 PrepareForTestWithJavaSdkLibraryFiles,
1581 FixtureWithLastReleaseApis("foo"),
1582 ).RunTestWithBp(t, `
Paul Duffindaaa3322020-05-26 18:13:57 +01001583 java_sdk_library {
1584 name: "foo",
1585 srcs: ["a.java"],
1586 api_only: true,
1587 public: {
1588 enabled: true,
1589 },
1590 }
1591
1592 java_library {
1593 name: "bar",
1594 srcs: ["b.java"],
1595 libs: ["foo"],
1596 }
1597 `)
1598
1599 // The bar library should depend on the stubs jar.
Paul Duffin22b77cd2021-03-12 19:15:01 +00001600 barLibrary := result.ModuleForTests("bar", "android_common").Rule("javac")
Paul Duffine8366da2021-03-24 10:40:38 +00001601 if expected, actual := `^-classpath .*:out/soong/[^:]*/turbine-combined/foo\.stubs\.jar$`, barLibrary.Args["classpath"]; !regexp.MustCompile(expected).MatchString(actual) {
Paul Duffindaaa3322020-05-26 18:13:57 +01001602 t.Errorf("expected %q, found %#q", expected, actual)
1603 }
1604}
1605
Paul Duffin46dc45a2020-05-14 15:39:10 +01001606func TestJavaSdkLibrary_UseSourcesFromAnotherSdkLibrary(t *testing.T) {
Paul Duffin71ae5942021-03-22 15:36:52 +00001607 android.GroupFixturePreparers(
1608 prepareForJavaTest,
Paul Duffin163043d2021-03-12 19:18:49 +00001609 PrepareForTestWithJavaSdkLibraryFiles,
1610 FixtureWithLastReleaseApis("foo"),
1611 ).RunTestWithBp(t, `
Paul Duffin46dc45a2020-05-14 15:39:10 +01001612 java_sdk_library {
1613 name: "foo",
1614 srcs: ["a.java"],
1615 api_packages: ["foo"],
1616 public: {
1617 enabled: true,
1618 },
1619 }
1620
1621 java_library {
1622 name: "bar",
1623 srcs: ["b.java", ":foo{.public.stubs.source}"],
1624 }
1625 `)
1626}
1627
1628func TestJavaSdkLibrary_AccessOutputFiles_MissingScope(t *testing.T) {
Paul Duffin71ae5942021-03-22 15:36:52 +00001629 android.GroupFixturePreparers(
1630 prepareForJavaTest,
1631 PrepareForTestWithJavaSdkLibraryFiles,
1632 FixtureWithLastReleaseApis("foo"),
1633 ).
Paul Duffin22b77cd2021-03-12 19:15:01 +00001634 ExtendWithErrorHandler(android.FixtureExpectsAtLeastOneErrorMatchingPattern(`"foo" does not provide api scope system`)).
1635 RunTestWithBp(t, `
Paul Duffin46dc45a2020-05-14 15:39:10 +01001636 java_sdk_library {
1637 name: "foo",
1638 srcs: ["a.java"],
1639 api_packages: ["foo"],
1640 public: {
1641 enabled: true,
1642 },
1643 }
1644
1645 java_library {
1646 name: "bar",
1647 srcs: ["b.java", ":foo{.system.stubs.source}"],
1648 }
1649 `)
1650}
1651
Paul Duffinca8d9a52020-06-26 22:20:25 +01001652func TestJavaSdkLibrary_Deps(t *testing.T) {
Paul Duffin71ae5942021-03-22 15:36:52 +00001653 result := android.GroupFixturePreparers(
1654 prepareForJavaTest,
Paul Duffin163043d2021-03-12 19:18:49 +00001655 PrepareForTestWithJavaSdkLibraryFiles,
1656 FixtureWithLastReleaseApis("sdklib"),
1657 ).RunTestWithBp(t, `
Paul Duffinca8d9a52020-06-26 22:20:25 +01001658 java_sdk_library {
1659 name: "sdklib",
1660 srcs: ["a.java"],
1661 sdk_version: "none",
1662 system_modules: "none",
1663 public: {
1664 enabled: true,
1665 },
1666 }
1667 `)
1668
Paul Duffin22b77cd2021-03-12 19:15:01 +00001669 CheckModuleDependencies(t, result.TestContext, "sdklib", "android_common", []string{
Paul Duffinca8d9a52020-06-26 22:20:25 +01001670 `dex2oatd`,
1671 `sdklib.impl`,
1672 `sdklib.stubs`,
1673 `sdklib.stubs.source`,
1674 `sdklib.xml`,
1675 })
1676}
1677
Paul Duffin46dc45a2020-05-14 15:39:10 +01001678func TestJavaSdkLibraryImport_AccessOutputFiles(t *testing.T) {
Paul Duffin71ae5942021-03-22 15:36:52 +00001679 prepareForJavaTest.RunTestWithBp(t, `
Paul Duffin46dc45a2020-05-14 15:39:10 +01001680 java_sdk_library_import {
1681 name: "foo",
1682 public: {
1683 jars: ["a.jar"],
1684 stub_srcs: ["a.java"],
1685 current_api: "api/current.txt",
1686 removed_api: "api/removed.txt",
1687 },
1688 }
1689
1690 java_library {
1691 name: "bar",
1692 srcs: [":foo{.public.stubs.source}"],
1693 java_resources: [
1694 ":foo{.public.api.txt}",
1695 ":foo{.public.removed-api.txt}",
1696 ],
1697 }
1698 `)
1699}
1700
1701func TestJavaSdkLibraryImport_AccessOutputFiles_Invalid(t *testing.T) {
1702 bp := `
1703 java_sdk_library_import {
1704 name: "foo",
1705 public: {
1706 jars: ["a.jar"],
1707 },
1708 }
1709 `
1710
1711 t.Run("stubs.source", func(t *testing.T) {
Paul Duffin71ae5942021-03-22 15:36:52 +00001712 prepareForJavaTest.
Paul Duffin22b77cd2021-03-12 19:15:01 +00001713 ExtendWithErrorHandler(android.FixtureExpectsAtLeastOneErrorMatchingPattern(`stubs.source not available for api scope public`)).
1714 RunTestWithBp(t, bp+`
1715 java_library {
1716 name: "bar",
1717 srcs: [":foo{.public.stubs.source}"],
1718 java_resources: [
1719 ":foo{.public.api.txt}",
1720 ":foo{.public.removed-api.txt}",
1721 ],
1722 }
1723 `)
Paul Duffin46dc45a2020-05-14 15:39:10 +01001724 })
1725
1726 t.Run("api.txt", func(t *testing.T) {
Paul Duffin71ae5942021-03-22 15:36:52 +00001727 prepareForJavaTest.
Paul Duffin22b77cd2021-03-12 19:15:01 +00001728 ExtendWithErrorHandler(android.FixtureExpectsAtLeastOneErrorMatchingPattern(`api.txt not available for api scope public`)).
1729 RunTestWithBp(t, bp+`
1730 java_library {
1731 name: "bar",
1732 srcs: ["a.java"],
1733 java_resources: [
1734 ":foo{.public.api.txt}",
1735 ],
1736 }
1737 `)
Paul Duffin46dc45a2020-05-14 15:39:10 +01001738 })
1739
1740 t.Run("removed-api.txt", func(t *testing.T) {
Paul Duffin71ae5942021-03-22 15:36:52 +00001741 prepareForJavaTest.
Paul Duffin22b77cd2021-03-12 19:15:01 +00001742 ExtendWithErrorHandler(android.FixtureExpectsAtLeastOneErrorMatchingPattern(`removed-api.txt not available for api scope public`)).
1743 RunTestWithBp(t, bp+`
1744 java_library {
1745 name: "bar",
1746 srcs: ["a.java"],
1747 java_resources: [
1748 ":foo{.public.removed-api.txt}",
1749 ],
1750 }
1751 `)
Paul Duffin46dc45a2020-05-14 15:39:10 +01001752 })
1753}
1754
Paul Duffin3375e352020-04-28 10:44:03 +01001755func TestJavaSdkLibrary_InvalidScopes(t *testing.T) {
Paul Duffin71ae5942021-03-22 15:36:52 +00001756 prepareForJavaTest.
Paul Duffin22b77cd2021-03-12 19:15:01 +00001757 ExtendWithErrorHandler(android.FixtureExpectsAtLeastOneErrorMatchingPattern(`module "foo": enabled api scope "system" depends on disabled scope "public"`)).
1758 RunTestWithBp(t, `
1759 java_sdk_library {
1760 name: "foo",
1761 srcs: ["a.java", "b.java"],
1762 api_packages: ["foo"],
1763 // Explicitly disable public to test the check that ensures the set of enabled
1764 // scopes is consistent.
1765 public: {
1766 enabled: false,
1767 },
1768 system: {
1769 enabled: true,
1770 },
1771 }
Paul Duffin3375e352020-04-28 10:44:03 +01001772 `)
1773}
1774
Paul Duffin87a05a32020-05-12 11:50:28 +01001775func TestJavaSdkLibrary_SdkVersion_ForScope(t *testing.T) {
Paul Duffin71ae5942021-03-22 15:36:52 +00001776 android.GroupFixturePreparers(
1777 prepareForJavaTest,
Paul Duffin163043d2021-03-12 19:18:49 +00001778 PrepareForTestWithJavaSdkLibraryFiles,
1779 FixtureWithLastReleaseApis("foo"),
1780 ).RunTestWithBp(t, `
Paul Duffin87a05a32020-05-12 11:50:28 +01001781 java_sdk_library {
1782 name: "foo",
1783 srcs: ["a.java", "b.java"],
1784 api_packages: ["foo"],
1785 system: {
1786 enabled: true,
1787 sdk_version: "module_current",
1788 },
1789 }
1790 `)
1791}
1792
Paul Duffin0c5bae52020-06-02 13:00:08 +01001793func TestJavaSdkLibrary_ModuleLib(t *testing.T) {
Paul Duffin71ae5942021-03-22 15:36:52 +00001794 android.GroupFixturePreparers(
1795 prepareForJavaTest,
Paul Duffin163043d2021-03-12 19:18:49 +00001796 PrepareForTestWithJavaSdkLibraryFiles,
1797 FixtureWithLastReleaseApis("foo"),
1798 ).RunTestWithBp(t, `
Paul Duffin0c5bae52020-06-02 13:00:08 +01001799 java_sdk_library {
1800 name: "foo",
1801 srcs: ["a.java", "b.java"],
1802 api_packages: ["foo"],
1803 system: {
1804 enabled: true,
1805 },
1806 module_lib: {
1807 enabled: true,
1808 },
1809 }
1810 `)
1811}
1812
1813func TestJavaSdkLibrary_SystemServer(t *testing.T) {
Paul Duffin71ae5942021-03-22 15:36:52 +00001814 android.GroupFixturePreparers(
1815 prepareForJavaTest,
Paul Duffin163043d2021-03-12 19:18:49 +00001816 PrepareForTestWithJavaSdkLibraryFiles,
1817 FixtureWithLastReleaseApis("foo"),
1818 ).RunTestWithBp(t, `
Paul Duffin0c5bae52020-06-02 13:00:08 +01001819 java_sdk_library {
1820 name: "foo",
1821 srcs: ["a.java", "b.java"],
1822 api_packages: ["foo"],
1823 system: {
1824 enabled: true,
1825 },
1826 system_server: {
1827 enabled: true,
1828 },
1829 }
1830 `)
1831}
1832
Paul Duffin803a9562020-05-20 11:52:25 +01001833func TestJavaSdkLibrary_MissingScope(t *testing.T) {
Paul Duffin71ae5942021-03-22 15:36:52 +00001834 prepareForJavaTest.
Paul Duffin22b77cd2021-03-12 19:15:01 +00001835 ExtendWithErrorHandler(android.FixtureExpectsAtLeastOneErrorMatchingPattern(`requires api scope module-lib from foo but it only has \[\] available`)).
1836 RunTestWithBp(t, `
1837 java_sdk_library {
1838 name: "foo",
1839 srcs: ["a.java"],
1840 public: {
1841 enabled: false,
1842 },
1843 }
Paul Duffin803a9562020-05-20 11:52:25 +01001844
Paul Duffin22b77cd2021-03-12 19:15:01 +00001845 java_library {
1846 name: "baz",
1847 srcs: ["a.java"],
1848 libs: ["foo"],
1849 sdk_version: "module_current",
1850 }
Paul Duffin803a9562020-05-20 11:52:25 +01001851 `)
1852}
1853
1854func TestJavaSdkLibrary_FallbackScope(t *testing.T) {
Paul Duffin71ae5942021-03-22 15:36:52 +00001855 android.GroupFixturePreparers(
1856 prepareForJavaTest,
Paul Duffin163043d2021-03-12 19:18:49 +00001857 PrepareForTestWithJavaSdkLibraryFiles,
1858 FixtureWithLastReleaseApis("foo"),
1859 ).RunTestWithBp(t, `
Paul Duffin803a9562020-05-20 11:52:25 +01001860 java_sdk_library {
1861 name: "foo",
1862 srcs: ["a.java"],
1863 system: {
1864 enabled: true,
1865 },
1866 }
1867
1868 java_library {
1869 name: "baz",
1870 srcs: ["a.java"],
1871 libs: ["foo"],
1872 // foo does not have module-lib scope so it should fallback to system
1873 sdk_version: "module_current",
1874 }
1875 `)
1876}
1877
Jiyong Park932cdfe2020-05-28 00:19:53 +09001878func TestJavaSdkLibrary_DefaultToStubs(t *testing.T) {
Paul Duffin71ae5942021-03-22 15:36:52 +00001879 result := android.GroupFixturePreparers(
1880 prepareForJavaTest,
Paul Duffin163043d2021-03-12 19:18:49 +00001881 PrepareForTestWithJavaSdkLibraryFiles,
1882 FixtureWithLastReleaseApis("foo"),
1883 ).RunTestWithBp(t, `
Jiyong Park932cdfe2020-05-28 00:19:53 +09001884 java_sdk_library {
1885 name: "foo",
1886 srcs: ["a.java"],
1887 system: {
1888 enabled: true,
1889 },
1890 default_to_stubs: true,
1891 }
1892
1893 java_library {
1894 name: "baz",
1895 srcs: ["a.java"],
1896 libs: ["foo"],
1897 // does not have sdk_version set, should fallback to module,
1898 // which will then fallback to system because the module scope
1899 // is not enabled.
1900 }
1901 `)
1902 // The baz library should depend on the system stubs jar.
Paul Duffin22b77cd2021-03-12 19:15:01 +00001903 bazLibrary := result.ModuleForTests("baz", "android_common").Rule("javac")
Paul Duffine8366da2021-03-24 10:40:38 +00001904 if expected, actual := `^-classpath .*:out/soong/[^:]*/turbine-combined/foo\.stubs.system\.jar$`, bazLibrary.Args["classpath"]; !regexp.MustCompile(expected).MatchString(actual) {
Jiyong Park932cdfe2020-05-28 00:19:53 +09001905 t.Errorf("expected %q, found %#q", expected, actual)
1906 }
1907}
1908
Zoran Jovanovic8736ce22018-08-21 17:10:29 +02001909var compilerFlagsTestCases = []struct {
1910 in string
1911 out bool
1912}{
1913 {
1914 in: "a",
1915 out: false,
1916 },
1917 {
1918 in: "-a",
1919 out: true,
1920 },
1921 {
1922 in: "-no-jdk",
1923 out: false,
1924 },
1925 {
1926 in: "-no-stdlib",
1927 out: false,
1928 },
1929 {
1930 in: "-kotlin-home",
1931 out: false,
1932 },
1933 {
1934 in: "-kotlin-home /some/path",
1935 out: false,
1936 },
1937 {
1938 in: "-include-runtime",
1939 out: false,
1940 },
1941 {
1942 in: "-Xintellij-plugin-root",
1943 out: false,
1944 },
1945}
1946
1947type mockContext struct {
1948 android.ModuleContext
1949 result bool
1950}
1951
1952func (ctx *mockContext) PropertyErrorf(property, format string, args ...interface{}) {
1953 // CheckBadCompilerFlags calls this function when the flag should be rejected
1954 ctx.result = false
1955}
1956
1957func TestCompilerFlags(t *testing.T) {
1958 for _, testCase := range compilerFlagsTestCases {
1959 ctx := &mockContext{result: true}
1960 CheckKotlincFlags(ctx, []string{testCase.in})
1961 if ctx.result != testCase.out {
1962 t.Errorf("incorrect output:")
1963 t.Errorf(" input: %#v", testCase.in)
1964 t.Errorf(" expected: %#v", testCase.out)
1965 t.Errorf(" got: %#v", ctx.result)
1966 }
1967 }
1968}
Jaewoong Jung38e4fb22018-12-12 09:01:34 -08001969
1970// TODO(jungjw): Consider making this more robust by ignoring path order.
1971func checkPatchModuleFlag(t *testing.T, ctx *android.TestContext, moduleName string, expected string) {
Paul Duffin414ea5e2021-03-22 17:31:52 +00001972 variables := ctx.ModuleForTests(moduleName, "android_common").VariablesForTestsRelativeToTop()
Jaewoong Jung38e4fb22018-12-12 09:01:34 -08001973 flags := strings.Split(variables["javacFlags"], " ")
1974 got := ""
1975 for _, flag := range flags {
1976 keyEnd := strings.Index(flag, "=")
1977 if keyEnd > -1 && flag[:keyEnd] == "--patch-module" {
1978 got = flag[keyEnd+1:]
1979 break
1980 }
1981 }
Paul Duffin414ea5e2021-03-22 17:31:52 +00001982 if expected != android.StringPathRelativeToTop(ctx.Config().BuildDir(), got) {
Jaewoong Jung38e4fb22018-12-12 09:01:34 -08001983 t.Errorf("Unexpected patch-module flag for module %q - expected %q, but got %q", moduleName, expected, got)
1984 }
1985}
1986
1987func TestPatchModule(t *testing.T) {
Pete Gillin0c2143e2019-05-02 15:32:11 +01001988 t.Run("Java language level 8", func(t *testing.T) {
Pete Gillin1b3370f2019-10-01 13:57:31 +01001989 // Test with legacy javac -source 1.8 -target 1.8
Pete Gillinbdf5d712019-10-21 14:29:58 +01001990 bp := `
1991 java_library {
1992 name: "foo",
1993 srcs: ["a.java"],
1994 java_version: "1.8",
1995 }
1996
1997 java_library {
1998 name: "bar",
1999 srcs: ["b.java"],
2000 sdk_version: "none",
2001 system_modules: "none",
2002 patch_module: "java.base",
2003 java_version: "1.8",
2004 }
2005
2006 java_library {
2007 name: "baz",
2008 srcs: ["c.java"],
2009 patch_module: "java.base",
2010 java_version: "1.8",
2011 }
2012 `
2013 ctx, _ := testJava(t, bp)
Jaewoong Jung38e4fb22018-12-12 09:01:34 -08002014
2015 checkPatchModuleFlag(t, ctx, "foo", "")
2016 checkPatchModuleFlag(t, ctx, "bar", "")
2017 checkPatchModuleFlag(t, ctx, "baz", "")
2018 })
2019
Pete Gillin0c2143e2019-05-02 15:32:11 +01002020 t.Run("Java language level 9", func(t *testing.T) {
Pete Gillin1b3370f2019-10-01 13:57:31 +01002021 // Test with default javac -source 9 -target 9
Pete Gillinbdf5d712019-10-21 14:29:58 +01002022 bp := `
2023 java_library {
2024 name: "foo",
2025 srcs: ["a.java"],
2026 }
2027
2028 java_library {
2029 name: "bar",
2030 srcs: ["b.java"],
2031 sdk_version: "none",
2032 system_modules: "none",
2033 patch_module: "java.base",
2034 }
2035
2036 java_library {
2037 name: "baz",
Jingwen Chen5136a6e2020-10-30 01:01:35 -04002038 srcs: [
2039 "c.java",
2040 // Tests for b/150878007
2041 "dir/d.java",
2042 "dir2/e.java",
2043 "dir2/f.java",
2044 "nested/dir/g.java"
2045 ],
Pete Gillinbdf5d712019-10-21 14:29:58 +01002046 patch_module: "java.base",
2047 }
2048 `
Pete Gillin1b3370f2019-10-01 13:57:31 +01002049 ctx, _ := testJava(t, bp)
Jaewoong Jung38e4fb22018-12-12 09:01:34 -08002050
2051 checkPatchModuleFlag(t, ctx, "foo", "")
Paul Duffin414ea5e2021-03-22 17:31:52 +00002052 expected := "java.base=.:out/soong"
Jaewoong Jung38e4fb22018-12-12 09:01:34 -08002053 checkPatchModuleFlag(t, ctx, "bar", expected)
Jingwen Chen5136a6e2020-10-30 01:01:35 -04002054 expected = "java.base=" + strings.Join([]string{
Paul Duffin414ea5e2021-03-22 17:31:52 +00002055 ".", "out/soong", "dir", "dir2", "nested", defaultModuleToPath("ext"), defaultModuleToPath("framework")}, ":")
Jaewoong Jung38e4fb22018-12-12 09:01:34 -08002056 checkPatchModuleFlag(t, ctx, "baz", expected)
2057 })
2058}
Paul Duffina7b9f422020-01-10 17:12:18 +00002059
Paul Duffin83a2d962019-11-19 19:44:10 +00002060func TestJavaLibraryWithSystemModules(t *testing.T) {
2061 ctx, _ := testJava(t, `
2062 java_library {
2063 name: "lib-with-source-system-modules",
2064 srcs: [
2065 "a.java",
2066 ],
2067 sdk_version: "none",
2068 system_modules: "source-system-modules",
2069 }
2070
2071 java_library {
2072 name: "source-jar",
2073 srcs: [
2074 "a.java",
2075 ],
2076 }
2077
2078 java_system_modules {
2079 name: "source-system-modules",
2080 libs: ["source-jar"],
2081 }
2082
2083 java_library {
2084 name: "lib-with-prebuilt-system-modules",
2085 srcs: [
2086 "a.java",
2087 ],
2088 sdk_version: "none",
2089 system_modules: "prebuilt-system-modules",
2090 }
2091
2092 java_import {
2093 name: "prebuilt-jar",
2094 jars: ["a.jar"],
2095 }
2096
2097 java_system_modules_import {
2098 name: "prebuilt-system-modules",
2099 libs: ["prebuilt-jar"],
2100 }
2101 `)
2102
2103 checkBootClasspathForSystemModule(t, ctx, "lib-with-source-system-modules", "/source-jar.jar")
2104
2105 checkBootClasspathForSystemModule(t, ctx, "lib-with-prebuilt-system-modules", "/prebuilt-jar.jar")
2106}
2107
2108func checkBootClasspathForSystemModule(t *testing.T, ctx *android.TestContext, moduleName string, expectedSuffix string) {
2109 javacRule := ctx.ModuleForTests(moduleName, "android_common").Rule("javac")
2110 bootClasspath := javacRule.Args["bootClasspath"]
2111 if strings.HasPrefix(bootClasspath, "--system ") && strings.HasSuffix(bootClasspath, expectedSuffix) {
2112 t.Errorf("bootclasspath of %q must start with --system and end with %q, but was %#v.", moduleName, expectedSuffix, bootClasspath)
2113 }
2114}
Jiyong Park19604de2020-03-24 16:44:11 +09002115
2116func TestAidlExportIncludeDirsFromImports(t *testing.T) {
2117 ctx, _ := testJava(t, `
2118 java_library {
2119 name: "foo",
2120 srcs: ["aidl/foo/IFoo.aidl"],
2121 libs: ["bar"],
2122 }
2123
2124 java_import {
2125 name: "bar",
2126 jars: ["a.jar"],
2127 aidl: {
2128 export_include_dirs: ["aidl/bar"],
2129 },
2130 }
2131 `)
2132
2133 aidlCommand := ctx.ModuleForTests("foo", "android_common").Rule("aidl").RuleParams.Command
2134 expectedAidlFlag := "-Iaidl/bar"
2135 if !strings.Contains(aidlCommand, expectedAidlFlag) {
2136 t.Errorf("aidl command %q does not contain %q", aidlCommand, expectedAidlFlag)
2137 }
2138}
Liz Kammerdd849a82020-06-12 16:38:45 -07002139
Jooyung Hane197d8b2021-01-05 10:33:16 +09002140func TestAidlFlagsArePassedToTheAidlCompiler(t *testing.T) {
2141 ctx, _ := testJava(t, `
2142 java_library {
2143 name: "foo",
2144 srcs: ["aidl/foo/IFoo.aidl"],
2145 aidl: { flags: ["-Werror"], },
2146 }
2147 `)
2148
2149 aidlCommand := ctx.ModuleForTests("foo", "android_common").Rule("aidl").RuleParams.Command
2150 expectedAidlFlag := "-Werror"
2151 if !strings.Contains(aidlCommand, expectedAidlFlag) {
2152 t.Errorf("aidl command %q does not contain %q", aidlCommand, expectedAidlFlag)
2153 }
2154}
2155
Liz Kammerdd849a82020-06-12 16:38:45 -07002156func TestDataNativeBinaries(t *testing.T) {
Colin Crossaa255532020-07-03 13:18:24 -07002157 ctx, _ := testJava(t, `
Liz Kammerdd849a82020-06-12 16:38:45 -07002158 java_test_host {
2159 name: "foo",
2160 srcs: ["a.java"],
2161 data_native_bins: ["bin"]
2162 }
2163
2164 python_binary_host {
2165 name: "bin",
2166 srcs: ["bin.py"],
2167 }
2168 `)
2169
2170 buildOS := android.BuildOs.String()
2171
2172 test := ctx.ModuleForTests("foo", buildOS+"_common").Module().(*TestHost)
Colin Crossaa255532020-07-03 13:18:24 -07002173 entries := android.AndroidMkEntriesForTest(t, ctx, test)[0]
Paul Duffin414ea5e2021-03-22 17:31:52 +00002174 expected := []string{"out/soong/.intermediates/bin/" + buildOS + "_x86_64_PY3/bin:bin"}
Liz Kammerdd849a82020-06-12 16:38:45 -07002175 actual := entries.EntryMap["LOCAL_COMPATIBILITY_SUPPORT_FILES"]
Paul Duffin414ea5e2021-03-22 17:31:52 +00002176 android.AssertStringPathsRelativeToTopEquals(t, "LOCAL_COMPATIBILITY_SUPPORT_FILES", ctx.Config(), expected, actual)
Liz Kammerdd849a82020-06-12 16:38:45 -07002177}
Yuexi Ma627263f2021-03-04 13:47:56 -08002178
2179func TestDefaultInstallable(t *testing.T) {
2180 ctx, _ := testJava(t, `
2181 java_test_host {
2182 name: "foo"
2183 }
2184 `)
2185
2186 buildOS := android.BuildOs.String()
2187 module := ctx.ModuleForTests("foo", buildOS+"_common").Module().(*TestHost)
2188 assertDeepEquals(t, "Default installable value should be true.", proptools.BoolPtr(true),
2189 module.properties.Installable)
2190}