blob: f25ce720aa480b900789c315e60273a24962d697 [file] [log] [blame]
Dan Albert4ae5d4b2014-10-31 16:23:08 -07001##############################################
2## Perform configuration steps for sanitizers.
3##############################################
4
Dan Albert27ccb752015-04-16 16:21:02 -07005my_sanitize := $(strip $(LOCAL_SANITIZE))
Vishwath Mohan8dcfdce2017-01-18 17:50:29 -08006my_sanitize_diag := $(strip $(LOCAL_SANITIZE_DIAG))
Dan Albert08cca282014-12-11 18:56:26 -08007
Dan Albert4c401412015-08-19 20:13:33 -07008my_global_sanitize :=
Ivan Lozano4a363732017-06-28 09:11:26 -07009my_global_sanitize_diag :=
Dan Willemsenf0638392018-09-04 22:25:22 -070010ifdef LOCAL_IS_HOST_MODULE
11 ifneq ($($(my_prefix)OS),windows)
12 my_global_sanitize := $(strip $(SANITIZE_HOST))
Dan Albert4c401412015-08-19 20:13:33 -070013
Dan Willemsenf0638392018-09-04 22:25:22 -070014 # SANITIZE_HOST=true is a deprecated way to say SANITIZE_HOST=address.
15 my_global_sanitize := $(subst true,address,$(my_global_sanitize))
Dan Albert4c401412015-08-19 20:13:33 -070016 endif
Dan Willemsenf0638392018-09-04 22:25:22 -070017else
18 my_global_sanitize := $(strip $(SANITIZE_TARGET))
19 my_global_sanitize_diag := $(strip $(SANITIZE_TARGET_DIAG))
Dan Albert4c401412015-08-19 20:13:33 -070020endif
21
Ivan Lozanob4749cb2017-07-21 10:33:32 -070022# Disable global integer_overflow in excluded paths.
23ifneq ($(filter integer_overflow, $(my_global_sanitize)),)
24 combined_exclude_paths := $(INTEGER_OVERFLOW_EXCLUDE_PATHS) \
25 $(PRODUCT_INTEGER_OVERFLOW_EXCLUDE_PATHS)
26
27 ifneq ($(strip $(foreach dir,$(subst $(comma),$(space),$(combined_exclude_paths)),\
28 $(filter $(dir)%,$(LOCAL_PATH)))),)
29 my_global_sanitize := $(filter-out integer_overflow,$(my_global_sanitize))
30 my_global_sanitize_diag := $(filter-out integer_overflow,$(my_global_sanitize_diag))
31 endif
32endif
33
Ivan Lozano702e8bd2018-03-15 14:49:20 -070034# Global integer sanitization doesn't support static modules.
35ifeq ($(filter SHARED_LIBRARIES EXECUTABLES,$(LOCAL_MODULE_CLASS)),)
36 my_global_sanitize := $(filter-out integer_overflow,$(my_global_sanitize))
37 my_global_sanitize_diag := $(filter-out integer_overflow,$(my_global_sanitize_diag))
38endif
39ifeq ($(LOCAL_FORCE_STATIC_EXECUTABLE),true)
40 my_global_sanitize := $(filter-out integer_overflow,$(my_global_sanitize))
41 my_global_sanitize_diag := $(filter-out integer_overflow,$(my_global_sanitize_diag))
42endif
43
Vishwath Mohan23b2d2e2017-10-31 02:25:16 -070044# Disable global CFI in excluded paths
45ifneq ($(filter cfi, $(my_global_sanitize)),)
46 combined_exclude_paths := $(CFI_EXCLUDE_PATHS) \
47 $(PRODUCT_CFI_EXCLUDE_PATHS)
48
49 ifneq ($(strip $(foreach dir,$(subst $(comma),$(space),$(combined_exclude_paths)),\
50 $(filter $(dir)%,$(LOCAL_PATH)))),)
51 my_global_sanitize := $(filter-out cfi,$(my_global_sanitize))
52 my_global_sanitize_diag := $(filter-out cfi,$(my_global_sanitize_diag))
53 endif
54endif
55
Evgenii Stepanov3330b2f2021-01-13 12:14:55 -080056# Disable global memtag_heap in excluded paths
57ifneq ($(filter memtag_heap, $(my_global_sanitize)),)
58 combined_exclude_paths := $(MEMTAG_HEAP_EXCLUDE_PATHS) \
59 $(PRODUCT_MEMTAG_HEAP_EXCLUDE_PATHS)
60
61 ifneq ($(strip $(foreach dir,$(subst $(comma),$(space),$(combined_exclude_paths)),\
62 $(filter $(dir)%,$(LOCAL_PATH)))),)
63 my_global_sanitize := $(filter-out memtag_heap,$(my_global_sanitize))
64 my_global_sanitize_diag := $(filter-out memtag_heap,$(my_global_sanitize_diag))
65 endif
66endif
67
Dan Albert4c401412015-08-19 20:13:33 -070068ifneq ($(my_global_sanitize),)
Evgenii Stepanov71faa192016-05-19 17:45:21 -070069 my_sanitize := $(my_global_sanitize) $(my_sanitize)
Dan Albert4c401412015-08-19 20:13:33 -070070endif
Ivan Lozano4a363732017-06-28 09:11:26 -070071ifneq ($(my_global_sanitize_diag),)
72 my_sanitize_diag := $(my_global_sanitize_diag) $(my_sanitize_diag)
73endif
Dan Albert4c401412015-08-19 20:13:33 -070074
Andreas Gampe6b30d772016-06-27 15:15:31 -070075# The sanitizer specified in the product configuration wins over the previous.
76ifneq ($(SANITIZER.$(TARGET_PRODUCT).$(LOCAL_MODULE).CONFIG),)
77 my_sanitize := $(SANITIZER.$(TARGET_PRODUCT).$(LOCAL_MODULE).CONFIG)
78 ifeq ($(my_sanitize),never)
79 my_sanitize :=
Ivan Lozano4a363732017-06-28 09:11:26 -070080 my_sanitize_diag :=
Andreas Gampe6b30d772016-06-27 15:15:31 -070081 endif
82endif
83
Colin Cross23618422016-11-02 15:05:21 -070084ifndef LOCAL_IS_HOST_MODULE
85 # Add a filter point for 32-bit vs 64-bit sanitization (to lighten the burden)
86 SANITIZE_TARGET_ARCH ?= $(TARGET_ARCH) $(TARGET_2ND_ARCH)
87 ifeq ($(filter $(SANITIZE_TARGET_ARCH),$(TARGET_$(LOCAL_2ND_ARCH_VAR_PREFIX)ARCH)),)
88 my_sanitize :=
Ivan Lozano4a363732017-06-28 09:11:26 -070089 my_sanitize_diag :=
Colin Cross23618422016-11-02 15:05:21 -070090 endif
Andreas Gampecd257402016-06-20 17:36:49 -070091endif
92
Andreas Gampe3d3b0c92016-06-20 17:46:29 -070093# Add a filter point based on module owner (to lighten the burden). The format is a space- or
94# colon-separated list of owner names.
95ifneq (,$(SANITIZE_NEVER_BY_OWNER))
96 ifneq (,$(LOCAL_MODULE_OWNER))
97 ifneq (,$(filter $(LOCAL_MODULE_OWNER),$(subst :, ,$(SANITIZE_NEVER_BY_OWNER))))
98 $(warning Not sanitizing $(LOCAL_MODULE) based on module owner.)
99 my_sanitize :=
Ivan Lozano4a363732017-06-28 09:11:26 -0700100 my_sanitize_diag :=
Andreas Gampe3d3b0c92016-06-20 17:46:29 -0700101 endif
102 endif
103endif
104
Dan Albert08cca282014-12-11 18:56:26 -0800105# Don't apply sanitizers to NDK code.
106ifdef LOCAL_SDK_VERSION
Dan Albert4c401412015-08-19 20:13:33 -0700107 my_sanitize :=
Dan Willemsenf761c0f2016-06-28 16:47:43 -0700108 my_global_sanitize :=
Ivan Lozano4a363732017-06-28 09:11:26 -0700109 my_sanitize_diag :=
Dan Albert27ccb752015-04-16 16:21:02 -0700110endif
111
Dan Albert4c401412015-08-19 20:13:33 -0700112# Never always wins.
113ifeq ($(LOCAL_SANITIZE),never)
Dan Albert08cca282014-12-11 18:56:26 -0800114 my_sanitize :=
Ivan Lozano4a363732017-06-28 09:11:26 -0700115 my_sanitize_diag :=
Dan Albert08cca282014-12-11 18:56:26 -0800116endif
117
Elvis Chien064d91c2021-04-14 17:02:29 +0800118# Enable CFI in included paths.
Vishwath Mohan23b2d2e2017-10-31 02:25:16 -0700119ifeq ($(filter cfi, $(my_sanitize)),)
Elvis Chien064d91c2021-04-14 17:02:29 +0800120 combined_include_paths := $(CFI_INCLUDE_PATHS) \
121 $(PRODUCT_CFI_INCLUDE_PATHS)
122 combined_exclude_paths := $(CFI_EXCLUDE_PATHS) \
123 $(PRODUCT_CFI_EXCLUDE_PATHS)
Vishwath Mohan23b2d2e2017-10-31 02:25:16 -0700124
Elvis Chien064d91c2021-04-14 17:02:29 +0800125 ifneq ($(strip $(foreach dir,$(subst $(comma),$(space),$(combined_include_paths)),\
126 $(filter $(dir)%,$(LOCAL_PATH)))),)
127 ifeq ($(strip $(foreach dir,$(subst $(comma),$(space),$(combined_exclude_paths)),\
128 $(filter $(dir)%,$(LOCAL_PATH)))),)
129 my_sanitize := cfi $(my_sanitize)
Vishwath Mohan6106a4e2018-05-24 18:04:25 -0700130 endif
Vishwath Mohan23b2d2e2017-10-31 02:25:16 -0700131 endif
132endif
133
Evgenii Stepanov3330b2f2021-01-13 12:14:55 -0800134# Enable memtag_heap in included paths (for Arm64 only).
135ifeq ($(filter memtag_heap, $(my_sanitize)),)
136 ifneq ($(filter arm64,$(TARGET_$(LOCAL_2ND_ARCH_VAR_PREFIX)ARCH)),)
137 combined_sync_include_paths := $(MEMTAG_HEAP_SYNC_INCLUDE_PATHS) \
138 $(PRODUCT_MEMTAG_HEAP_SYNC_INCLUDE_PATHS)
139 combined_async_include_paths := $(MEMTAG_HEAP_ASYNC_INCLUDE_PATHS) \
140 $(PRODUCT_MEMTAG_HEAP_ASYNC_INCLUDE_PATHS)
Evgenii Stepanov13bc2272021-04-09 14:52:33 -0700141 combined_exclude_paths := $(MEMTAG_HEAP_EXCLUDE_PATHS) \
142 $(PRODUCT_MEMTAG_HEAP_EXCLUDE_PATHS)
Evgenii Stepanov3330b2f2021-01-13 12:14:55 -0800143
Evgenii Stepanov13bc2272021-04-09 14:52:33 -0700144 ifeq ($(strip $(foreach dir,$(subst $(comma),$(space),$(combined_exclude_paths)),\
145 $(filter $(dir)%,$(LOCAL_PATH)))),)
146 ifneq ($(strip $(foreach dir,$(subst $(comma),$(space),$(combined_sync_include_paths)),\
147 $(filter $(dir)%,$(LOCAL_PATH)))),)
148 my_sanitize := memtag_heap $(my_sanitize)
149 my_sanitize_diag := memtag_heap $(my_sanitize_diag)
150 else ifneq ($(strip $(foreach dir,$(subst $(comma),$(space),$(combined_async_include_paths)),\
151 $(filter $(dir)%,$(LOCAL_PATH)))),)
152 my_sanitize := memtag_heap $(my_sanitize)
153 endif
Evgenii Stepanov3330b2f2021-01-13 12:14:55 -0800154 endif
155 endif
156endif
157
Vishwath Mohan8dcfdce2017-01-18 17:50:29 -0800158# If CFI is disabled globally, remove it from my_sanitize.
Vishwath Mohan45665b42017-01-24 13:20:28 -0800159ifeq ($(strip $(ENABLE_CFI)),false)
Vishwath Mohan8dcfdce2017-01-18 17:50:29 -0800160 my_sanitize := $(filter-out cfi,$(my_sanitize))
161 my_sanitize_diag := $(filter-out cfi,$(my_sanitize_diag))
162endif
163
Florian Mayer1264fcc2022-08-26 16:04:59 -0700164# Also disable CFI and MTE if ASAN is enabled.
Vishwath Mohanc026f6d2017-04-20 07:39:13 -0700165ifneq ($(filter address,$(my_sanitize)),)
166 my_sanitize := $(filter-out cfi,$(my_sanitize))
Florian Mayer1264fcc2022-08-26 16:04:59 -0700167 my_sanitize := $(filter-out memtag_stack,$(my_sanitize))
168 my_sanitize := $(filter-out memtag_heap,$(my_sanitize))
Vishwath Mohanc026f6d2017-04-20 07:39:13 -0700169 my_sanitize_diag := $(filter-out cfi,$(my_sanitize_diag))
170endif
171
Mitch Phillipsb71a8752021-05-19 11:29:02 -0700172# Disable memtag for host targets. Host executables in AndroidMk files are
173# deprecated, but some partners still have them floating around.
174ifdef LOCAL_IS_HOST_MODULE
175 my_sanitize := $(filter-out memtag_heap,$(my_sanitize))
176 my_sanitize_diag := $(filter-out memtag_heap,$(my_sanitize_diag))
177endif
178
Ivan Lozano702e8bd2018-03-15 14:49:20 -0700179# Disable sanitizers which need the UBSan runtime for host targets.
Vishwath Mohan96a130b2017-11-17 11:19:36 -0800180ifdef LOCAL_IS_HOST_MODULE
181 my_sanitize := $(filter-out cfi,$(my_sanitize))
182 my_sanitize_diag := $(filter-out cfi,$(my_sanitize_diag))
Ivan Lozano702e8bd2018-03-15 14:49:20 -0700183 my_sanitize := $(filter-out signed-integer-overflow unsigned-integer-overflow integer_overflow,$(my_sanitize))
184 my_sanitize_diag := $(filter-out signed-integer-overflow unsigned-integer-overflow integer_overflow,$(my_sanitize_diag))
Vishwath Mohan96a130b2017-11-17 11:19:36 -0800185endif
186
Ivan Lozano4a363732017-06-28 09:11:26 -0700187# Support for local sanitize blacklist paths.
188ifneq ($(my_sanitize)$(my_global_sanitize),)
Pirama Arumuga Nainar56558332020-07-30 15:18:07 -0700189 ifneq ($(LOCAL_SANITIZE_BLOCKLIST),)
190 my_cflags += -fsanitize-blacklist=$(LOCAL_PATH)/$(LOCAL_SANITIZE_BLOCKLIST)
191 endif
Ivan Lozano4a363732017-06-28 09:11:26 -0700192endif
193
Ivan Lozanob4749cb2017-07-21 10:33:32 -0700194# Disable integer_overflow if LOCAL_NOSANITIZE=integer.
Ivan Lozano4a363732017-06-28 09:11:26 -0700195ifneq ($(filter integer_overflow, $(my_global_sanitize) $(my_sanitize)),)
196 ifneq ($(filter integer, $(strip $(LOCAL_NOSANITIZE))),)
197 my_sanitize := $(filter-out integer_overflow,$(my_sanitize))
198 my_sanitize_diag := $(filter-out integer_overflow,$(my_sanitize_diag))
199 endif
200endif
201
Evgenii Stepanov42823662016-05-12 13:07:17 -0700202my_nosanitize = $(strip $(LOCAL_NOSANITIZE))
203ifneq ($(my_nosanitize),)
204 my_sanitize := $(filter-out $(my_nosanitize),$(my_sanitize))
205endif
206
Evgenii Stepanov8841a7f2018-07-27 11:54:32 -0700207ifneq ($(filter arm x86 x86_64,$(TARGET_$(LOCAL_2ND_ARCH_VAR_PREFIX)ARCH)),)
208 my_sanitize := $(filter-out hwaddress,$(my_sanitize))
Evgenii Stepanov3330b2f2021-01-13 12:14:55 -0800209 my_sanitize := $(filter-out memtag_heap,$(my_sanitize))
Florian Mayer1264fcc2022-08-26 16:04:59 -0700210 my_sanitize := $(filter-out memtag_stack,$(my_sanitize))
Evgenii Stepanov8841a7f2018-07-27 11:54:32 -0700211endif
212
213ifneq ($(filter hwaddress,$(my_sanitize)),)
214 my_sanitize := $(filter-out address,$(my_sanitize))
Florian Mayer1264fcc2022-08-26 16:04:59 -0700215 my_sanitize := $(filter-out memtag_stack,$(my_sanitize))
216 my_sanitize := $(filter-out memtag_heap,$(my_sanitize))
Evgenii Stepanov8841a7f2018-07-27 11:54:32 -0700217 my_sanitize := $(filter-out thread,$(my_sanitize))
Evgenii Stepanov88a95a32018-12-04 17:06:45 -0800218 my_sanitize := $(filter-out cfi,$(my_sanitize))
Evgenii Stepanov8841a7f2018-07-27 11:54:32 -0700219endif
220
221ifneq ($(filter hwaddress,$(my_sanitize)),)
222 my_shared_libraries += $($(LOCAL_2ND_ARCH_VAR_PREFIX)HWADDRESS_SANITIZER_RUNTIME_LIBRARY)
Evgenii Stepanoved907462018-11-01 15:43:14 -0700223 ifneq ($(filter EXECUTABLES NATIVE_TESTS,$(LOCAL_MODULE_CLASS)),)
Evgenii Stepanov8841a7f2018-07-27 11:54:32 -0700224 ifeq ($(LOCAL_FORCE_STATIC_EXECUTABLE),true)
Ryan Prichardacf8b0f2019-10-21 20:47:53 -0700225 my_static_libraries := $(my_static_libraries) \
226 $($(LOCAL_2ND_ARCH_VAR_PREFIX)HWADDRESS_SANITIZER_STATIC_LIBRARY) \
227 libdl
Evgenii Stepanov8841a7f2018-07-27 11:54:32 -0700228 endif
229 endif
230endif
231
Florian Mayer1264fcc2022-08-26 16:04:59 -0700232ifneq ($(filter memtag_heap memtag_stack,$(my_sanitize)),)
233 ifneq ($(filter memtag_heap,$(my_sanitize_diag)),)
234 my_cflags += -fsanitize-memtag-mode=sync
235 my_sanitize_diag := $(filter-out memtag_heap,$(my_sanitize_diag))
236 else
237 my_cflags += -fsanitize-memtag-mode=async
Evgenii Stepanov3330b2f2021-01-13 12:14:55 -0800238 endif
Florian Mayer1264fcc2022-08-26 16:04:59 -0700239endif
240
241ifneq ($(filter memtag_heap,$(my_sanitize)),)
242 my_cflags += -fsanitize=memtag-heap
Evgenii Stepanov3330b2f2021-01-13 12:14:55 -0800243 my_sanitize := $(filter-out memtag_heap,$(my_sanitize))
244endif
245
Florian Mayer1264fcc2022-08-26 16:04:59 -0700246ifneq ($(filter memtag_stack,$(my_sanitize)),)
247 my_cflags += -fsanitize=memtag-stack
248 my_cflags += -march=armv8a+memtag
249 my_ldflags += -march=armv8a+memtag
250 my_asflags += -march=armv8a+memtag
251 my_sanitize := $(filter-out memtag_stack,$(my_sanitize))
252endif
Evgenii Stepanov3330b2f2021-01-13 12:14:55 -0800253
Dan Alberta6311b72015-07-30 10:17:33 -0700254# TSAN is not supported on 32-bit architectures. For non-multilib cases, make
255# its use an error. For multilib cases, don't use it for the 32-bit case.
256ifneq ($(filter thread,$(my_sanitize)),)
257 ifeq ($(my_32_64_bit_suffix),32)
258 ifeq ($(my_module_multilib),both)
259 my_sanitize := $(filter-out thread,$(my_sanitize))
260 else
261 $(error $(LOCAL_PATH): $(LOCAL_MODULE): TSAN cannot be used for 32-bit modules.)
262 endif
Yabin Cuie77c32e2017-10-19 14:33:58 -0700263 else
264 my_shared_libraries += $(TSAN_RUNTIME_LIBRARY)
Dan Alberta6311b72015-07-30 10:17:33 -0700265 endif
266endif
267
Evgenii Stepanov7dcb8b82016-05-06 18:15:57 -0700268ifneq ($(filter safe-stack,$(my_sanitize)),)
269 ifeq ($(my_32_64_bit_suffix),32)
270 my_sanitize := $(filter-out safe-stack,$(my_sanitize))
271 endif
272endif
273
Kostya Kortchinsky2cfa9972018-06-14 11:02:15 -0700274# Disable Scudo if ASan or TSan is enabled.
Evgenii Stepanov8841a7f2018-07-27 11:54:32 -0700275ifneq ($(filter address thread hwaddress,$(my_sanitize)),)
Kostya Kortchinsky2cfa9972018-06-14 11:02:15 -0700276 my_sanitize := $(filter-out scudo,$(my_sanitize))
277endif
278
Kostya Kortchinsky02732402019-02-01 09:06:42 -0800279# Or if disabled globally.
Anton Hansson8dab0a62019-03-28 15:45:40 +0000280ifeq ($(PRODUCT_DISABLE_SCUDO),true)
Kostya Kortchinsky02732402019-02-01 09:06:42 -0800281 my_sanitize := $(filter-out scudo,$(my_sanitize))
282endif
283
Evgenii Stepanov5adfcb12015-06-25 16:38:25 -0700284# Undefined symbols can occur if a non-sanitized library links
285# sanitized static libraries. That's OK, because the executable
286# always depends on the ASan runtime library, which defines these
287# symbols.
Evgenii Stepanov912b51f2016-05-19 17:49:51 -0700288ifneq ($(filter address thread,$(strip $(SANITIZE_TARGET))),)
Evgenii Stepanov5adfcb12015-06-25 16:38:25 -0700289 ifndef LOCAL_IS_HOST_MODULE
290 ifeq ($(LOCAL_MODULE_CLASS),SHARED_LIBRARIES)
291 ifeq ($(my_sanitize),)
292 my_allow_undefined_symbols := true
293 endif
294 endif
295 endif
296endif
297
Dan Albertb5b2ffe2015-04-16 18:07:07 -0700298ifneq ($(filter default-ub,$(my_sanitize)),)
299 my_sanitize := $(CLANG_DEFAULT_UB_CHECKS)
Dan Albert08cca282014-12-11 18:56:26 -0800300endif
301
Mitch Phillipsee8f4a02019-05-01 14:37:33 -0700302ifneq ($(filter fuzzer,$(my_sanitize)),)
303 # SANITIZE_TARGET='fuzzer' actually means to create the fuzzer coverage
304 # information, not to link against the fuzzer main().
305 my_sanitize := $(filter-out fuzzer,$(my_sanitize))
306 my_sanitize += fuzzer-no-link
Mitch Phillipsd51048a2022-03-02 01:25:22 +0000307
308 # TODO(b/131771163): Disable LTO for fuzzer builds. Note that Cfi causes
309 # dependency on LTO.
310 my_sanitize := $(filter-out cfi,$(my_sanitize))
311 my_cflags += -fno-lto
312 my_ldflags += -fno-lto
Ivan Krasin74b32b82015-09-18 11:54:43 -0700313endif
314
Ivan Lozano4a363732017-06-28 09:11:26 -0700315ifneq ($(filter integer_overflow,$(my_sanitize)),)
Ivan Lozano702e8bd2018-03-15 14:49:20 -0700316 # Respect LOCAL_NOSANITIZE for integer-overflow flags.
317 ifeq ($(filter signed-integer-overflow, $(strip $(LOCAL_NOSANITIZE))),)
318 my_sanitize += signed-integer-overflow
319 endif
320 ifeq ($(filter unsigned-integer-overflow, $(strip $(LOCAL_NOSANITIZE))),)
321 my_sanitize += unsigned-integer-overflow
322 endif
323 my_cflags += $(INTEGER_OVERFLOW_EXTRA_CFLAGS)
Ivan Lozano4a363732017-06-28 09:11:26 -0700324
Ivan Lozano702e8bd2018-03-15 14:49:20 -0700325 # Check for diagnostics mode.
326 ifneq ($(filter integer_overflow,$(my_sanitize_diag)),)
327 ifneq ($(filter SHARED_LIBRARIES EXECUTABLES,$(LOCAL_MODULE_CLASS)),)
328 ifneq ($(LOCAL_FORCE_STATIC_EXECUTABLE),true)
Ivan Lozano911cb992018-02-21 13:41:05 -0800329 my_sanitize_diag += signed-integer-overflow
330 my_sanitize_diag += unsigned-integer-overflow
Ivan Lozano702e8bd2018-03-15 14:49:20 -0700331 else
332 $(call pretty-error,Make cannot apply integer overflow diagnostics to static binary.)
Ivan Lozano4a363732017-06-28 09:11:26 -0700333 endif
Ivan Lozano702e8bd2018-03-15 14:49:20 -0700334 else
335 $(call pretty-error,Make cannot apply integer overflow diagnostics to static library.)
Ivan Lozano4a363732017-06-28 09:11:26 -0700336 endif
337 endif
338 my_sanitize := $(filter-out integer_overflow,$(my_sanitize))
339endif
340
341# Makes sure integer_overflow diagnostics is removed from the diagnostics list
342# even if integer_overflow is not set for some reason.
343ifneq ($(filter integer_overflow,$(my_sanitize_diag)),)
344 my_sanitize_diag := $(filter-out integer_overflow,$(my_sanitize_diag))
345endif
346
Dan Albert08cca282014-12-11 18:56:26 -0800347ifneq ($(my_sanitize),)
Stephen Hinese8119e92015-11-09 16:32:11 -0800348 fsanitize_arg := $(subst $(space),$(comma),$(my_sanitize))
Dan Albert08cca282014-12-11 18:56:26 -0800349 my_cflags += -fsanitize=$(fsanitize_arg)
Evgenii Stepanov9b82b3f2018-08-31 12:57:26 -0700350 my_asflags += -fsanitize=$(fsanitize_arg)
Dan Albert08cca282014-12-11 18:56:26 -0800351
Mitch Phillipsee8f4a02019-05-01 14:37:33 -0700352 # When fuzzing, we wish to crash with diagnostics on any bug.
353 ifneq ($(filter fuzzer-no-link,$(my_sanitize)),)
354 my_cflags += -fno-sanitize-trap=all
355 my_cflags += -fno-sanitize-recover=all
356 my_ldflags += -fsanitize=fuzzer-no-link
357 else ifdef LOCAL_IS_HOST_MODULE
Dan Albertabf4bc92015-06-16 23:27:34 -0700358 my_cflags += -fno-sanitize-recover=all
Dan Albert08cca282014-12-11 18:56:26 -0800359 my_ldflags += -fsanitize=$(fsanitize_arg)
Dan Albertabf4bc92015-06-16 23:27:34 -0700360 else
Evgenii Stepanov71faa192016-05-19 17:45:21 -0700361 my_cflags += -fsanitize-trap=all
362 my_cflags += -ftrap-function=abort
Evgenii Stepanov55f73e62016-05-12 13:07:36 -0700363 ifneq ($(filter address thread,$(my_sanitize)),)
Evgenii Stepanov71faa192016-05-19 17:45:21 -0700364 my_cflags += -fno-sanitize-trap=address,thread
Evgenii Stepanov55f73e62016-05-12 13:07:36 -0700365 my_shared_libraries += libdl
366 endif
Dan Albert08cca282014-12-11 18:56:26 -0800367 endif
368endif
369
Evgenii Stepanov202c7a72016-07-07 10:56:39 -0700370ifneq ($(filter cfi,$(my_sanitize)),)
Evgenii Stepanov81bea1b2017-01-20 14:12:08 -0800371 # __cfi_check needs to be built as Thumb (see the code in linker_cfi.cpp).
372 # LLVM is not set up to do this on a function basis, so force Thumb on the
373 # entire module.
374 LOCAL_ARM_MODE := thumb
Vishwath Mohan5b69c062017-02-14 07:55:37 -0800375 my_cflags += $(CFI_EXTRA_CFLAGS)
Evgenii Stepanov9b82b3f2018-08-31 12:57:26 -0700376 my_asflags += $(CFI_EXTRA_ASFLAGS)
Vishwath Mohan85f72442017-11-01 09:21:20 +0000377 # Only append the default visibility flag if -fvisibility has not already been
378 # set to hidden.
379 ifeq ($(filter -fvisibility=hidden,$(LOCAL_CFLAGS)),)
380 my_cflags += -fvisibility=default
381 endif
Vishwath Mohan5b69c062017-02-14 07:55:37 -0800382 my_ldflags += $(CFI_EXTRA_LDFLAGS)
Evgenii Stepanove1b96f32017-01-23 16:57:38 -0800383 my_arflags += --plugin $(LLVM_PREBUILTS_PATH)/../lib64/LLVMgold.so
Vishwath Mohan85f72442017-11-01 09:21:20 +0000384
385 ifeq ($(LOCAL_FORCE_STATIC_EXECUTABLE),true)
386 my_ldflags := $(filter-out -fsanitize-cfi-cross-dso,$(my_ldflags))
387 my_cflags := $(filter-out -fsanitize-cfi-cross-dso,$(my_cflags))
388 else
389 # Apply the version script to non-static executables
390 my_ldflags += -Wl,--version-script,build/soong/cc/config/cfi_exports.map
391 LOCAL_ADDITIONAL_DEPENDENCIES += build/soong/cc/config/cfi_exports.map
392 endif
Evgenii Stepanov202c7a72016-07-07 10:56:39 -0700393endif
394
Chih-Hung Hsiehad741e62016-03-09 14:54:55 -0800395# If local or global modules need ASAN, add linker flags.
396ifneq ($(filter address,$(my_global_sanitize) $(my_sanitize)),)
Dan Albert4ae5d4b2014-10-31 16:23:08 -0700397 my_ldflags += $(ADDRESS_SANITIZER_CONFIG_EXTRA_LDFLAGS)
398 ifdef LOCAL_IS_HOST_MODULE
Dan Albert08cca282014-12-11 18:56:26 -0800399 # -nodefaultlibs (provided with libc++) prevents the driver from linking
400 # libraries needed with -fsanitize=address. http://b/18650275 (WAI)
Dan Albert1f0d5302015-04-28 14:55:50 -0700401 my_ldflags += -Wl,--no-as-needed
Dan Albert4ae5d4b2014-10-31 16:23:08 -0700402 else
Chih-Hung Hsiehad741e62016-03-09 14:54:55 -0800403 # Add asan libraries unless LOCAL_MODULE is the asan library.
Evgenii Stepanovf0b15e12015-04-24 16:34:47 -0700404 # ASan runtime library must be the first in the link order.
Chih-Hung Hsiehad741e62016-03-09 14:54:55 -0800405 ifeq (,$(filter $(LOCAL_MODULE),$($(LOCAL_2ND_ARCH_VAR_PREFIX)ADDRESS_SANITIZER_RUNTIME_LIBRARY)))
406 my_shared_libraries := $($(LOCAL_2ND_ARCH_VAR_PREFIX)ADDRESS_SANITIZER_RUNTIME_LIBRARY) \
407 $(my_shared_libraries)
408 endif
Chih-Hung Hsiehad741e62016-03-09 14:54:55 -0800409
410 # Do not add unnecessary dependency in shared libraries.
411 ifeq ($(LOCAL_MODULE_CLASS),SHARED_LIBRARIES)
412 my_ldflags += -Wl,--as-needed
413 endif
Ying Wanga05e2222015-08-17 16:13:24 -0700414
Mikhail Naganovaa73cef2018-12-20 15:55:08 -0800415 ifneq ($(filter EXECUTABLES NATIVE_TESTS,$(LOCAL_MODULE_CLASS)),)
Colin Crossd08699e2016-07-17 15:28:07 -0700416 ifneq ($(LOCAL_FORCE_STATIC_EXECUTABLE),true)
417 my_linker := $($(LOCAL_2ND_ARCH_VAR_PREFIX)ADDRESS_SANITIZER_LINKER)
418 # Make sure linker_asan get installed.
Logan Chienc6d2cf82019-01-31 17:07:50 +0800419 $(LOCAL_INSTALLED_MODULE) : | $(PRODUCT_OUT)$($(LOCAL_2ND_ARCH_VAR_PREFIX)ADDRESS_SANITIZER_LINKER_FILE)
Colin Crossd08699e2016-07-17 15:28:07 -0700420 endif
421 endif
Dan Albert08cca282014-12-11 18:56:26 -0800422 endif
423endif
424
Chih-Hung Hsiehad741e62016-03-09 14:54:55 -0800425# If local module needs ASAN, add compiler flags.
426ifneq ($(filter address,$(my_sanitize)),)
427 # Frame pointer based unwinder in ASan requires ARM frame setup.
428 LOCAL_ARM_MODE := arm
429 my_cflags += $(ADDRESS_SANITIZER_CONFIG_EXTRA_CFLAGS)
430 ifndef LOCAL_IS_HOST_MODULE
431 my_cflags += -mllvm -asan-globals=0
432 endif
433endif
434
Evgenii Stepanovaec1ffc2018-08-28 13:52:08 -0700435# If local module needs HWASAN, add compiler flags.
436ifneq ($(filter hwaddress,$(my_sanitize)),)
437 my_cflags += $(HWADDRESS_SANITIZER_CONFIG_EXTRA_CFLAGS)
438endif
439
Dan Willemsen58634e12020-03-06 18:09:06 -0800440# Use minimal diagnostics when integer overflow is enabled; never do it for HOST modules
441ifeq ($(LOCAL_IS_HOST_MODULE),)
Ivan Lozano911cb992018-02-21 13:41:05 -0800442 # Pre-emptively add UBSAN minimal runtime incase a static library dependency requires it
443 ifeq ($(filter STATIC_LIBRARIES,$(LOCAL_MODULE_CLASS)),)
444 ifndef LOCAL_SDK_VERSION
445 my_static_libraries += $($(LOCAL_2ND_ARCH_VAR_PREFIX)UBSAN_MINIMAL_RUNTIME_LIBRARY)
Ivan Lozanoe5081692018-05-11 14:09:36 -0700446 my_ldflags += -Wl,--exclude-libs,$($(LOCAL_2ND_ARCH_VAR_PREFIX)UBSAN_MINIMAL_RUNTIME_LIBRARY).a
Ivan Lozano911cb992018-02-21 13:41:05 -0800447 endif
448 endif
449 ifneq ($(filter unsigned-integer-overflow signed-integer-overflow integer,$(my_sanitize)),)
Kostya Kortchinsky47c10eb2018-10-11 08:56:12 -0700450 ifeq ($(filter unsigned-integer-overflow signed-integer-overflow integer,$(my_sanitize_diag)),)
Ivan Lozano911cb992018-02-21 13:41:05 -0800451 ifeq ($(filter cfi,$(my_sanitize_diag)),)
Mitch Phillipsee8f4a02019-05-01 14:37:33 -0700452 ifeq ($(filter address hwaddress fuzzer-no-link,$(my_sanitize)),)
Ivan Lozano911cb992018-02-21 13:41:05 -0800453 my_cflags += -fsanitize-minimal-runtime
454 my_cflags += -fno-sanitize-trap=integer
455 my_cflags += -fno-sanitize-recover=integer
456 endif
457 endif
458 endif
459 endif
460endif
461
Kostya Kortchinsky47c10eb2018-10-11 08:56:12 -0700462# For Scudo, we opt for the minimal runtime, unless some diagnostics are enabled.
463ifneq ($(filter scudo,$(my_sanitize)),)
464 ifeq ($(filter unsigned-integer-overflow signed-integer-overflow integer cfi,$(my_sanitize_diag)),)
465 my_cflags += -fsanitize-minimal-runtime
466 endif
467 ifneq ($(filter -fsanitize-minimal-runtime,$(my_cflags)),)
468 my_shared_libraries += $($(LOCAL_2ND_ARCH_VAR_PREFIX)SCUDO_MINIMAL_RUNTIME_LIBRARY)
469 else
470 my_shared_libraries += $($(LOCAL_2ND_ARCH_VAR_PREFIX)SCUDO_RUNTIME_LIBRARY)
471 endif
472endif
473
Dan Albert9f176552015-04-28 11:26:45 -0700474ifneq ($(strip $(LOCAL_SANITIZE_RECOVER)),)
475 recover_arg := $(subst $(space),$(comma),$(LOCAL_SANITIZE_RECOVER)),
Dan Albert4111d482015-04-16 18:08:44 -0700476 my_cflags += -fsanitize-recover=$(recover_arg)
477endif
Evgenii Stepanov202c7a72016-07-07 10:56:39 -0700478
Ivan Lozano5fb2de72018-12-12 10:04:34 -0800479ifneq ($(strip $(LOCAL_SANITIZE_NO_RECOVER)),)
480 no_recover_arg := $(subst $(space),$(comma),$(LOCAL_SANITIZE_NO_RECOVER)),
481 my_cflags += -fno-sanitize-recover=$(no_recover_arg)
482endif
483
Vishwath Mohan8dcfdce2017-01-18 17:50:29 -0800484ifneq ($(my_sanitize_diag),)
Vishwath Mohan85f72442017-11-01 09:21:20 +0000485 # TODO(vishwath): Add diagnostic support for static executables once
486 # we switch to clang-4393122 (which adds the static ubsan runtime
487 # that this depends on)
488 ifneq ($(LOCAL_FORCE_STATIC_EXECUTABLE),true)
489 notrap_arg := $(subst $(space),$(comma),$(my_sanitize_diag)),
490 my_cflags += -fno-sanitize-trap=$(notrap_arg)
491 # Diagnostic requires a runtime library, unless ASan or TSan are also enabled.
Evgenii Stepanov8841a7f2018-07-27 11:54:32 -0700492 ifeq ($(filter address thread scudo hwaddress,$(my_sanitize)),)
Vishwath Mohan85f72442017-11-01 09:21:20 +0000493 # Does not have to be the first DT_NEEDED unlike ASan.
494 my_shared_libraries += $($(LOCAL_2ND_ARCH_VAR_PREFIX)UBSAN_RUNTIME_LIBRARY)
495 endif
Evgenii Stepanov202c7a72016-07-07 10:56:39 -0700496 endif
497endif
Chih-Hung Hsieh18710622018-11-17 20:18:08 -0800498
499# http://b/119329758, Android core does not boot up with this sanitizer yet.
500# Previously sanitized modules might not pass new implicit-integer-sign-change check.
501# Disable this check unless it has been explicitly specified.
502ifneq ($(findstring fsanitize,$(my_cflags)),)
503 ifneq ($(findstring integer,$(my_cflags)),)
504 ifeq ($(findstring sanitize=implicit-integer-sign-change,$(my_cflags)),)
505 my_cflags += -fno-sanitize=implicit-integer-sign-change
506 endif
507 endif
508endif
Yabin Cui462c12d2021-01-14 14:05:54 -0800509
510# http://b/177566116, libc++ may crash with this sanitizer.
511# Disable this check unless it has been explicitly specified.
512ifneq ($(findstring fsanitize,$(my_cflags)),)
513 ifneq ($(findstring integer,$(my_cflags)),)
514 ifeq ($(findstring sanitize=unsigned-shift-base,$(my_cflags)),)
515 my_cflags += -fno-sanitize=unsigned-shift-base
516 endif
517 endif
518endif