blob: 587ac677c45b386cbda0582b4342fa4c4d33dadb [file] [log] [blame]
Alex Deymoaea4c1c2015-08-19 20:24:43 -07001//
2// Copyright (C) 2014 The Android Open Source Project
3//
4// Licensed under the Apache License, Version 2.0 (the "License");
5// you may not use this file except in compliance with the License.
6// You may obtain a copy of the License at
7//
8// http://www.apache.org/licenses/LICENSE-2.0
9//
10// Unless required by applicable law or agreed to in writing, software
11// distributed under the License is distributed on an "AS IS" BASIS,
12// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
13// See the License for the specific language governing permissions and
14// limitations under the License.
15//
Alex Deymoc705cc82014-02-19 11:15:00 -080016
Alex Deymo63784a52014-05-28 10:46:14 -070017#include "update_engine/update_manager/chromeos_policy.h"
Alex Deymo0d11c602014-04-23 20:12:20 -070018
Gilad Arnolde1218812014-05-07 12:21:36 -070019#include <algorithm>
Gilad Arnold0adbc942014-05-12 10:35:43 -070020#include <set>
Alex Deymoc705cc82014-02-19 11:15:00 -080021#include <string>
Amin Hassani186ff6a2018-02-27 11:06:03 -080022#include <vector>
Alex Deymoc705cc82014-02-19 11:15:00 -080023
Gilad Arnoldf62a4b82014-05-01 07:41:07 -070024#include <base/logging.h>
Gilad Arnoldb3b05442014-05-30 14:25:05 -070025#include <base/strings/string_util.h>
Gilad Arnoldf62a4b82014-05-01 07:41:07 -070026#include <base/time/time.h>
27
Alex Deymo39910dc2015-11-09 17:04:30 -080028#include "update_engine/common/error_code.h"
Alex Deymoe88e9fe2016-02-03 16:38:00 -080029#include "update_engine/common/error_code_utils.h"
Alex Deymo39910dc2015-11-09 17:04:30 -080030#include "update_engine/common/utils.h"
Alex Deymo63784a52014-05-28 10:46:14 -070031#include "update_engine/update_manager/device_policy_provider.h"
Amin Hassani186ff6a2018-02-27 11:06:03 -080032#include "update_engine/update_manager/enough_slots_ab_updates_policy_impl.h"
33#include "update_engine/update_manager/enterprise_device_policy_impl.h"
34#include "update_engine/update_manager/interactive_update_policy_impl.h"
35#include "update_engine/update_manager/official_build_check_policy_impl.h"
36#include "update_engine/update_manager/out_of_box_experience_policy_impl.h"
Alex Deymo63784a52014-05-28 10:46:14 -070037#include "update_engine/update_manager/policy_utils.h"
38#include "update_engine/update_manager/shill_provider.h"
Adolfo Victoria94ffe132018-06-28 16:14:56 -070039#include "update_engine/update_manager/update_time_restrictions_policy_impl.h"
Gilad Arnoldf62a4b82014-05-01 07:41:07 -070040
Alex Deymo0d11c602014-04-23 20:12:20 -070041using base::Time;
42using base::TimeDelta;
Sen Jiang255e22b2016-05-20 16:15:29 -070043using chromeos_update_engine::ConnectionTethering;
44using chromeos_update_engine::ConnectionType;
Gilad Arnoldb3b05442014-05-30 14:25:05 -070045using chromeos_update_engine::ErrorCode;
Aaron Wood23bd3392017-10-06 14:48:25 -070046using chromeos_update_engine::InstallPlan;
Gilad Arnolddc4bb262014-07-23 10:45:19 -070047using std::get;
Gilad Arnoldf62a4b82014-05-01 07:41:07 -070048using std::min;
Gilad Arnold0adbc942014-05-12 10:35:43 -070049using std::set;
Alex Deymoc705cc82014-02-19 11:15:00 -080050using std::string;
Amin Hassani186ff6a2018-02-27 11:06:03 -080051using std::vector;
Alex Deymoc705cc82014-02-19 11:15:00 -080052
Gilad Arnoldb3b05442014-05-30 14:25:05 -070053namespace {
54
Gilad Arnolddc4bb262014-07-23 10:45:19 -070055// Examines |err_code| and decides whether the URL index needs to be advanced,
56// the error count for the URL incremented, or none of the above. In the first
57// case, returns true; in the second case, increments |*url_num_error_p| and
58// returns false; otherwise just returns false.
Gilad Arnoldb3b05442014-05-30 14:25:05 -070059//
60// TODO(garnold) Adapted from PayloadState::UpdateFailed() (to be retired).
Gilad Arnolddc4bb262014-07-23 10:45:19 -070061bool HandleErrorCode(ErrorCode err_code, int* url_num_error_p) {
Gilad Arnoldb3b05442014-05-30 14:25:05 -070062 err_code = chromeos_update_engine::utils::GetBaseErrorCode(err_code);
63 switch (err_code) {
64 // Errors which are good indicators of a problem with a particular URL or
65 // the protocol used in the URL or entities in the communication channel
66 // (e.g. proxies). We should try the next available URL in the next update
67 // check to quickly recover from these errors.
68 case ErrorCode::kPayloadHashMismatchError:
69 case ErrorCode::kPayloadSizeMismatchError:
70 case ErrorCode::kDownloadPayloadVerificationError:
71 case ErrorCode::kDownloadPayloadPubKeyVerificationError:
72 case ErrorCode::kSignedDeltaPayloadExpectedError:
73 case ErrorCode::kDownloadInvalidMetadataMagicString:
74 case ErrorCode::kDownloadSignatureMissingInManifest:
75 case ErrorCode::kDownloadManifestParseError:
76 case ErrorCode::kDownloadMetadataSignatureError:
77 case ErrorCode::kDownloadMetadataSignatureVerificationError:
78 case ErrorCode::kDownloadMetadataSignatureMismatch:
79 case ErrorCode::kDownloadOperationHashVerificationError:
80 case ErrorCode::kDownloadOperationExecutionError:
81 case ErrorCode::kDownloadOperationHashMismatch:
82 case ErrorCode::kDownloadInvalidMetadataSize:
83 case ErrorCode::kDownloadInvalidMetadataSignature:
84 case ErrorCode::kDownloadOperationHashMissingError:
85 case ErrorCode::kDownloadMetadataSignatureMissingError:
86 case ErrorCode::kPayloadMismatchedType:
87 case ErrorCode::kUnsupportedMajorPayloadVersion:
88 case ErrorCode::kUnsupportedMinorPayloadVersion:
Sen Jiang8e768e92017-06-28 17:13:19 -070089 case ErrorCode::kPayloadTimestampError:
Sen Jiang57f91802017-11-14 17:42:13 -080090 case ErrorCode::kVerityCalculationError:
Gilad Arnoldb3b05442014-05-30 14:25:05 -070091 LOG(INFO) << "Advancing download URL due to error "
Alex Deymoe88e9fe2016-02-03 16:38:00 -080092 << chromeos_update_engine::utils::ErrorCodeToString(err_code)
Gilad Arnoldb3b05442014-05-30 14:25:05 -070093 << " (" << static_cast<int>(err_code) << ")";
Gilad Arnoldb3b05442014-05-30 14:25:05 -070094 return true;
95
96 // Errors which seem to be just transient network/communication related
97 // failures and do not indicate any inherent problem with the URL itself.
98 // So, we should keep the current URL but just increment the
99 // failure count to give it more chances. This way, while we maximize our
100 // chances of downloading from the URLs that appear earlier in the response
101 // (because download from a local server URL that appears earlier in a
102 // response is preferable than downloading from the next URL which could be
Alex Vakulenko072359c2014-07-18 11:41:07 -0700103 // an Internet URL and thus could be more expensive).
Gilad Arnoldb3b05442014-05-30 14:25:05 -0700104 case ErrorCode::kError:
105 case ErrorCode::kDownloadTransferError:
106 case ErrorCode::kDownloadWriteError:
107 case ErrorCode::kDownloadStateInitializationError:
Gilad Arnold684219d2014-07-07 14:54:57 -0700108 case ErrorCode::kOmahaErrorInHTTPResponse: // Aggregate for HTTP errors.
Gilad Arnoldb3b05442014-05-30 14:25:05 -0700109 LOG(INFO) << "Incrementing URL failure count due to error "
Alex Deymoe88e9fe2016-02-03 16:38:00 -0800110 << chromeos_update_engine::utils::ErrorCodeToString(err_code)
Gilad Arnoldb3b05442014-05-30 14:25:05 -0700111 << " (" << static_cast<int>(err_code) << ")";
Gilad Arnolddc4bb262014-07-23 10:45:19 -0700112 *url_num_error_p += 1;
Gilad Arnoldb3b05442014-05-30 14:25:05 -0700113 return false;
114
115 // Errors which are not specific to a URL and hence shouldn't result in
116 // the URL being penalized. This can happen in two cases:
117 // 1. We haven't started downloading anything: These errors don't cost us
118 // anything in terms of actual payload bytes, so we should just do the
119 // regular retries at the next update check.
120 // 2. We have successfully downloaded the payload: In this case, the
121 // payload attempt number would have been incremented and would take care
Alex Vakulenko072359c2014-07-18 11:41:07 -0700122 // of the back-off at the next update check.
Gilad Arnoldb3b05442014-05-30 14:25:05 -0700123 // In either case, there's no need to update URL index or failure count.
124 case ErrorCode::kOmahaRequestError:
125 case ErrorCode::kOmahaResponseHandlerError:
126 case ErrorCode::kPostinstallRunnerError:
127 case ErrorCode::kFilesystemCopierError:
128 case ErrorCode::kInstallDeviceOpenError:
129 case ErrorCode::kKernelDeviceOpenError:
130 case ErrorCode::kDownloadNewPartitionInfoError:
131 case ErrorCode::kNewRootfsVerificationError:
132 case ErrorCode::kNewKernelVerificationError:
133 case ErrorCode::kPostinstallBootedFromFirmwareB:
134 case ErrorCode::kPostinstallFirmwareRONotUpdatable:
135 case ErrorCode::kOmahaRequestEmptyResponseError:
136 case ErrorCode::kOmahaRequestXMLParseError:
137 case ErrorCode::kOmahaResponseInvalid:
138 case ErrorCode::kOmahaUpdateIgnoredPerPolicy:
139 case ErrorCode::kOmahaUpdateDeferredPerPolicy:
Kevin Cernekee2494e282016-03-29 18:03:53 -0700140 case ErrorCode::kNonCriticalUpdateInOOBE:
Gilad Arnoldb3b05442014-05-30 14:25:05 -0700141 case ErrorCode::kOmahaUpdateDeferredForBackoff:
142 case ErrorCode::kPostinstallPowerwashError:
143 case ErrorCode::kUpdateCanceledByChannelChange:
David Zeuthenf3e28012014-08-26 18:23:52 -0400144 case ErrorCode::kOmahaRequestXMLHasEntityDecl:
Allie Woodeb9e6d82015-04-17 13:55:30 -0700145 case ErrorCode::kFilesystemVerifierError:
Alex Deymo1f19dcc2016-02-03 09:22:17 -0800146 case ErrorCode::kUserCanceled:
Weidong Guo421ff332017-04-17 10:08:38 -0700147 case ErrorCode::kOmahaUpdateIgnoredOverCellular:
Sen Jiangfe522822017-10-31 15:14:11 -0700148 case ErrorCode::kUpdatedButNotActive:
Sen Jiang89e24c12018-03-22 18:05:44 -0700149 case ErrorCode::kNoUpdate:
Marton Hunyady199152d2018-05-07 19:08:48 +0200150 case ErrorCode::kRollbackNotPossible:
Amin Hassani80f4d4c2018-05-16 13:34:00 -0700151 case ErrorCode::kFirstActiveOmahaPingSentPersistenceError:
Gilad Arnoldb3b05442014-05-30 14:25:05 -0700152 LOG(INFO) << "Not changing URL index or failure count due to error "
Alex Deymoe88e9fe2016-02-03 16:38:00 -0800153 << chromeos_update_engine::utils::ErrorCodeToString(err_code)
Gilad Arnoldb3b05442014-05-30 14:25:05 -0700154 << " (" << static_cast<int>(err_code) << ")";
155 return false;
156
157 case ErrorCode::kSuccess: // success code
158 case ErrorCode::kUmaReportedMax: // not an error code
159 case ErrorCode::kOmahaRequestHTTPResponseBase: // aggregated already
Alex Deymo1f19dcc2016-02-03 09:22:17 -0800160 case ErrorCode::kDevModeFlag: // not an error code
Gilad Arnoldb3b05442014-05-30 14:25:05 -0700161 case ErrorCode::kResumedFlag: // not an error code
162 case ErrorCode::kTestImageFlag: // not an error code
163 case ErrorCode::kTestOmahaUrlFlag: // not an error code
164 case ErrorCode::kSpecialFlags: // not an error code
165 // These shouldn't happen. Enumerating these explicitly here so that we
166 // can let the compiler warn about new error codes that are added to
167 // action_processor.h but not added here.
168 LOG(WARNING) << "Unexpected error "
Alex Deymoe88e9fe2016-02-03 16:38:00 -0800169 << chromeos_update_engine::utils::ErrorCodeToString(err_code)
Gilad Arnoldb3b05442014-05-30 14:25:05 -0700170 << " (" << static_cast<int>(err_code) << ")";
171 // Note: Not adding a default here so as to let the compiler warn us of
172 // any new enums that were added in the .h but not listed in this switch.
173 }
174 return false;
175}
176
Gilad Arnolddc4bb262014-07-23 10:45:19 -0700177// Checks whether |url| can be used under given download restrictions.
178bool IsUrlUsable(const string& url, bool http_allowed) {
Alex Vakulenko0103c362016-01-20 07:56:15 -0800179 return http_allowed ||
180 !base::StartsWith(url, "http://",
181 base::CompareCase::INSENSITIVE_ASCII);
Gilad Arnoldb3b05442014-05-30 14:25:05 -0700182}
183
184} // namespace
185
Alex Deymo63784a52014-05-28 10:46:14 -0700186namespace chromeos_update_manager {
Alex Deymoc705cc82014-02-19 11:15:00 -0800187
Amin Hassani186ff6a2018-02-27 11:06:03 -0800188const NextUpdateCheckPolicyConstants
189 ChromeOSPolicy::kNextUpdateCheckPolicyConstants = {
190 .timeout_initial_interval = 7 * 60,
191 .timeout_periodic_interval = 45 * 60,
192 .timeout_max_backoff_interval = 4 * 60 * 60,
193 .timeout_regular_fuzz = 10 * 60,
194 .attempt_backoff_max_interval_in_days = 16,
195 .attempt_backoff_fuzz_in_hours = 12,
196};
Alex Deymo14e7dde2015-10-20 14:46:33 -0700197
Gilad Arnold349ac832014-10-06 14:20:28 -0700198const int ChromeOSPolicy::kMaxP2PAttempts = 10;
199const int ChromeOSPolicy::kMaxP2PAttemptsPeriodInSeconds = 5 * 24 * 60 * 60;
Gilad Arnolda2e8eaa2014-09-24 13:12:33 -0700200
Alex Deymo0d11c602014-04-23 20:12:20 -0700201EvalStatus ChromeOSPolicy::UpdateCheckAllowed(
202 EvaluationContext* ec, State* state, string* error,
203 UpdateCheckParams* result) const {
Gilad Arnold42f253b2014-06-25 12:39:17 -0700204 // Set the default return values.
205 result->updates_enabled = true;
206 result->target_channel.clear();
Gilad Arnoldd4b30322014-07-21 15:35:27 -0700207 result->target_version_prefix.clear();
Marton Hunyadyba51c3f2018-04-25 15:18:10 +0200208 result->rollback_allowed = false;
Marton Hunyady0e0e3542018-02-21 18:51:39 +0100209 result->rollback_allowed_milestones = -1;
Amin Hassanied37d682018-04-06 13:22:00 -0700210 result->interactive = false;
Gilad Arnold42f253b2014-06-25 12:39:17 -0700211
Amin Hassani186ff6a2018-02-27 11:06:03 -0800212 EnoughSlotsAbUpdatesPolicyImpl enough_slots_ab_updates_policy;
213 EnterpriseDevicePolicyImpl enterprise_device_policy;
214 OnlyUpdateOfficialBuildsPolicyImpl only_update_official_builds_policy;
215 InteractiveUpdatePolicyImpl interactive_update_policy;
216 OobePolicyImpl oobe_policy;
217 NextUpdateCheckTimePolicyImpl next_update_check_time_policy(
218 kNextUpdateCheckPolicyConstants);
Gilad Arnolda1eabcd2014-07-09 15:42:40 -0700219
Amin Hassani186ff6a2018-02-27 11:06:03 -0800220 vector<Policy const*> policies_to_consult = {
221 // Do not perform any updates if there are not enough slots to do A/B
222 // updates.
223 &enough_slots_ab_updates_policy,
224
225 // Check to see if Enterprise-managed (has DevicePolicy) and/or
226 // Kiosk-mode. If so, then defer to those settings.
227 &enterprise_device_policy,
228
229 // Check to see if an interactive update was requested.
230 &interactive_update_policy,
231
232 // Unofficial builds should not perform periodic update checks.
233 &only_update_official_builds_policy,
234
235 // If OOBE is enabled, wait until it is completed.
236 &oobe_policy,
237
238 // Ensure that periodic update checks are timed properly.
239 &next_update_check_time_policy,
240 };
241
242 // Now that the list of policy implementations, and the order to consult them,
243 // has been setup, consult the policies. If none of the policies make a
244 // definitive decisions about whether or not to check for updates, then allow
245 // the update check to happen.
246 EvalStatus status = ConsultPolicies(policies_to_consult,
247 &Policy::UpdateCheckAllowed,
248 ec,
249 state,
250 error,
251 result);
252 if (EvalStatus::kContinue != status) {
253 return status;
254 } else {
255 // It is time to check for an update.
256 LOG(INFO) << "Allowing update check.";
Gilad Arnoldbfc44f72014-07-09 14:41:39 -0700257 return EvalStatus::kSucceeded;
258 }
Alex Deymoc705cc82014-02-19 11:15:00 -0800259}
260
Aaron Wood23bd3392017-10-06 14:48:25 -0700261EvalStatus ChromeOSPolicy::UpdateCanBeApplied(EvaluationContext* ec,
262 State* state,
263 std::string* error,
264 ErrorCode* result,
265 InstallPlan* install_plan) const {
Adolfo Victoria0dbf1f92018-07-19 14:18:11 -0700266 UpdateTimeRestrictionsPolicyImpl update_time_restrictions_policy;
267 InteractiveUpdatePolicyImpl interactive_update_policy;
268
269 vector<Policy const*> policies_to_consult = {
270 // Check to see if an interactive update has been requested.
271 &interactive_update_policy,
272
273 // Do not apply or download an update if we are inside one of the
274 // restricted times.
275 &update_time_restrictions_policy,
276 };
277
278 EvalStatus status = ConsultPolicies(policies_to_consult,
279 &Policy::UpdateCanBeApplied,
280 ec,
281 state,
282 error,
283 result,
284 install_plan);
285 if (EvalStatus::kContinue != status) {
286 return status;
287 } else {
288 // The update can proceed.
289 LOG(INFO) << "Allowing update to be applied.";
290 *result = ErrorCode::kSuccess;
291 return EvalStatus::kSucceeded;
292 }
Aaron Wood23bd3392017-10-06 14:48:25 -0700293}
294
Gilad Arnoldf62a4b82014-05-01 07:41:07 -0700295EvalStatus ChromeOSPolicy::UpdateCanStart(
296 EvaluationContext* ec,
297 State* state,
298 string* error,
Gilad Arnold42f253b2014-06-25 12:39:17 -0700299 UpdateDownloadParams* result,
Gilad Arnoldd78caf92014-09-24 09:28:14 -0700300 const UpdateState update_state) const {
Gilad Arnolddc4bb262014-07-23 10:45:19 -0700301 // Set the default return values. Note that we set persisted values (backoff,
302 // scattering) to the same values presented in the update state. The reason is
303 // that preemptive returns, such as the case where an update check is due,
304 // should not clear off the said values; rather, it is the deliberate
305 // inference of new values that should cause them to be reset.
Gilad Arnold14a9e702014-10-08 08:09:09 -0700306 result->update_can_start = false;
Gilad Arnoldf62a4b82014-05-01 07:41:07 -0700307 result->cannot_start_reason = UpdateCannotStartReason::kUndefined;
Gilad Arnoldb3b05442014-05-30 14:25:05 -0700308 result->download_url_idx = -1;
Gilad Arnold14a9e702014-10-08 08:09:09 -0700309 result->download_url_allowed = true;
310 result->download_url_num_errors = 0;
Gilad Arnoldb2f99192014-10-07 13:01:52 -0700311 result->p2p_downloading_allowed = false;
312 result->p2p_sharing_allowed = false;
Gilad Arnolddc4bb262014-07-23 10:45:19 -0700313 result->do_increment_failures = false;
314 result->backoff_expiry = update_state.backoff_expiry;
315 result->scatter_wait_period = update_state.scatter_wait_period;
316 result->scatter_check_threshold = update_state.scatter_check_threshold;
Gilad Arnoldf62a4b82014-05-01 07:41:07 -0700317
318 // Make sure that we're not due for an update check.
319 UpdateCheckParams check_result;
320 EvalStatus check_status = UpdateCheckAllowed(ec, state, error, &check_result);
321 if (check_status == EvalStatus::kFailed)
322 return EvalStatus::kFailed;
Gilad Arnold14a9e702014-10-08 08:09:09 -0700323 bool is_check_due = (check_status == EvalStatus::kSucceeded &&
324 check_result.updates_enabled == true);
Gilad Arnoldf62a4b82014-05-01 07:41:07 -0700325
Gilad Arnolddc4bb262014-07-23 10:45:19 -0700326 // Check whether backoff applies, and if not then which URL can be used for
327 // downloading. These require scanning the download error log, and so they are
328 // done together.
329 UpdateBackoffAndDownloadUrlResult backoff_url_result;
330 EvalStatus backoff_url_status = UpdateBackoffAndDownloadUrl(
331 ec, state, error, &backoff_url_result, update_state);
Gilad Arnold14a9e702014-10-08 08:09:09 -0700332 if (backoff_url_status == EvalStatus::kFailed)
333 return EvalStatus::kFailed;
334 result->download_url_idx = backoff_url_result.url_idx;
335 result->download_url_num_errors = backoff_url_result.url_num_errors;
336 result->do_increment_failures = backoff_url_result.do_increment_failures;
337 result->backoff_expiry = backoff_url_result.backoff_expiry;
338 bool is_backoff_active =
339 (backoff_url_status == EvalStatus::kAskMeAgainLater) ||
340 !backoff_url_result.backoff_expiry.is_null();
Gilad Arnolddc4bb262014-07-23 10:45:19 -0700341
Gilad Arnoldf62a4b82014-05-01 07:41:07 -0700342 DevicePolicyProvider* const dp_provider = state->device_policy_provider();
Gilad Arnold14a9e702014-10-08 08:09:09 -0700343 bool is_scattering_active = false;
344 EvalStatus scattering_status = EvalStatus::kSucceeded;
Gilad Arnoldf62a4b82014-05-01 07:41:07 -0700345
346 const bool* device_policy_is_loaded_p = ec->GetValue(
347 dp_provider->var_device_policy_is_loaded());
348 if (device_policy_is_loaded_p && *device_policy_is_loaded_p) {
Gilad Arnold76a11f62014-05-20 09:02:12 -0700349 // Check whether scattering applies to this update attempt. We should not be
350 // scattering if this is an interactive update check, or if OOBE is enabled
351 // but not completed.
352 //
353 // Note: current code further suppresses scattering if a "deadline"
Gilad Arnoldf62a4b82014-05-01 07:41:07 -0700354 // attribute is found in the Omaha response. However, it appears that the
Gilad Arnold76a11f62014-05-20 09:02:12 -0700355 // presence of this attribute is merely indicative of an OOBE update, during
356 // which we suppress scattering anyway.
Gilad Arnold14a9e702014-10-08 08:09:09 -0700357 bool is_scattering_applicable = false;
Gilad Arnolddc4bb262014-07-23 10:45:19 -0700358 result->scatter_wait_period = kZeroInterval;
359 result->scatter_check_threshold = 0;
Amin Hassanied37d682018-04-06 13:22:00 -0700360 if (!update_state.interactive) {
Gilad Arnold76a11f62014-05-20 09:02:12 -0700361 const bool* is_oobe_enabled_p = ec->GetValue(
362 state->config_provider()->var_is_oobe_enabled());
363 if (is_oobe_enabled_p && !(*is_oobe_enabled_p)) {
Gilad Arnold14a9e702014-10-08 08:09:09 -0700364 is_scattering_applicable = true;
Gilad Arnold76a11f62014-05-20 09:02:12 -0700365 } else {
366 const bool* is_oobe_complete_p = ec->GetValue(
Gilad Arnoldb3b05442014-05-30 14:25:05 -0700367 state->system_provider()->var_is_oobe_complete());
Gilad Arnold14a9e702014-10-08 08:09:09 -0700368 is_scattering_applicable = (is_oobe_complete_p && *is_oobe_complete_p);
Gilad Arnold76a11f62014-05-20 09:02:12 -0700369 }
370 }
371
372 // Compute scattering values.
Gilad Arnold14a9e702014-10-08 08:09:09 -0700373 if (is_scattering_applicable) {
Gilad Arnoldf62a4b82014-05-01 07:41:07 -0700374 UpdateScatteringResult scatter_result;
Gilad Arnold14a9e702014-10-08 08:09:09 -0700375 scattering_status = UpdateScattering(ec, state, error, &scatter_result,
376 update_state);
377 if (scattering_status == EvalStatus::kFailed) {
378 return EvalStatus::kFailed;
379 } else {
380 result->scatter_wait_period = scatter_result.wait_period;
381 result->scatter_check_threshold = scatter_result.check_threshold;
382 if (scattering_status == EvalStatus::kAskMeAgainLater ||
383 scatter_result.is_scattering)
384 is_scattering_active = true;
Gilad Arnoldf62a4b82014-05-01 07:41:07 -0700385 }
386 }
Gilad Arnold78ecbfc2014-10-22 14:38:25 -0700387 }
Gilad Arnoldf62a4b82014-05-01 07:41:07 -0700388
Gilad Arnold78ecbfc2014-10-22 14:38:25 -0700389 // Find out whether P2P is globally enabled.
390 bool p2p_enabled;
391 EvalStatus p2p_enabled_status = P2PEnabled(ec, state, error, &p2p_enabled);
392 if (p2p_enabled_status != EvalStatus::kSucceeded)
393 return EvalStatus::kFailed;
394
395 // Is P2P is enabled, consider allowing it for downloading and/or sharing.
396 if (p2p_enabled) {
397 // Sharing via P2P is allowed if not disabled by Omaha.
398 if (update_state.p2p_sharing_disabled) {
399 LOG(INFO) << "Blocked P2P sharing because it is disabled by Omaha.";
Gilad Arnoldb2f99192014-10-07 13:01:52 -0700400 } else {
Gilad Arnold78ecbfc2014-10-22 14:38:25 -0700401 result->p2p_sharing_allowed = true;
Gilad Arnoldef8d0872014-10-03 14:14:06 -0700402 }
Gilad Arnoldf62a4b82014-05-01 07:41:07 -0700403
Gilad Arnold78ecbfc2014-10-22 14:38:25 -0700404 // Downloading via P2P is allowed if not disabled by Omaha, an update is not
405 // interactive, and other limits haven't been reached.
406 if (update_state.p2p_downloading_disabled) {
407 LOG(INFO) << "Blocked P2P downloading because it is disabled by Omaha.";
Amin Hassanied37d682018-04-06 13:22:00 -0700408 } else if (update_state.interactive) {
Gilad Arnold78ecbfc2014-10-22 14:38:25 -0700409 LOG(INFO) << "Blocked P2P downloading because update is interactive.";
Gilad Arnoldb2f99192014-10-07 13:01:52 -0700410 } else if (update_state.p2p_num_attempts >= kMaxP2PAttempts) {
Gilad Arnold78ecbfc2014-10-22 14:38:25 -0700411 LOG(INFO) << "Blocked P2P downloading as it was attempted too many "
412 "times.";
Gilad Arnoldb2f99192014-10-07 13:01:52 -0700413 } else if (!update_state.p2p_first_attempted.is_null() &&
414 ec->IsWallclockTimeGreaterThan(
415 update_state.p2p_first_attempted +
416 TimeDelta::FromSeconds(kMaxP2PAttemptsPeriodInSeconds))) {
Gilad Arnold78ecbfc2014-10-22 14:38:25 -0700417 LOG(INFO) << "Blocked P2P downloading as its usage timespan exceeds "
418 "limit.";
Gilad Arnoldb2f99192014-10-07 13:01:52 -0700419 } else {
Gilad Arnold14a9e702014-10-08 08:09:09 -0700420 // P2P download is allowed; if backoff or scattering are active, be sure
421 // to suppress them, yet prevent any download URL from being used.
Gilad Arnoldb2f99192014-10-07 13:01:52 -0700422 result->p2p_downloading_allowed = true;
Gilad Arnold14a9e702014-10-08 08:09:09 -0700423 if (is_backoff_active || is_scattering_active) {
424 is_backoff_active = is_scattering_active = false;
425 result->download_url_allowed = false;
426 }
Gilad Arnoldb2f99192014-10-07 13:01:52 -0700427 }
Gilad Arnoldf62a4b82014-05-01 07:41:07 -0700428 }
429
Gilad Arnold14a9e702014-10-08 08:09:09 -0700430 // Check for various deterrents.
431 if (is_check_due) {
432 result->cannot_start_reason = UpdateCannotStartReason::kCheckDue;
433 return EvalStatus::kSucceeded;
434 }
435 if (is_backoff_active) {
436 result->cannot_start_reason = UpdateCannotStartReason::kBackoff;
437 return backoff_url_status;
438 }
439 if (is_scattering_active) {
440 result->cannot_start_reason = UpdateCannotStartReason::kScattering;
441 return scattering_status;
442 }
Gilad Arnoldb2f99192014-10-07 13:01:52 -0700443 if (result->download_url_idx < 0 && !result->p2p_downloading_allowed) {
Gilad Arnolddc4bb262014-07-23 10:45:19 -0700444 result->cannot_start_reason = UpdateCannotStartReason::kCannotDownload;
Gilad Arnold14a9e702014-10-08 08:09:09 -0700445 return EvalStatus::kSucceeded;
Gilad Arnoldb3b05442014-05-30 14:25:05 -0700446 }
447
Gilad Arnold14a9e702014-10-08 08:09:09 -0700448 // Update is good to go.
449 result->update_can_start = true;
Gilad Arnoldaf2f6ae2014-04-28 14:14:52 -0700450 return EvalStatus::kSucceeded;
451}
452
Gilad Arnolda8262e22014-06-02 13:54:27 -0700453// TODO(garnold) Logic in this method is based on
454// ConnectionManager::IsUpdateAllowedOver(); be sure to deprecate the latter.
455//
456// TODO(garnold) The current logic generally treats the list of allowed
457// connections coming from the device policy as a whitelist, meaning that it
458// can only be used for enabling connections, but not disable them. Further,
459// certain connection types (like Bluetooth) cannot be enabled even by policy.
460// In effect, the only thing that device policy can change is to enable
461// updates over a cellular network (disabled by default). We may want to
462// revisit this semantics, allowing greater flexibility in defining specific
463// permissions over all types of networks.
Gilad Arnold684219d2014-07-07 14:54:57 -0700464EvalStatus ChromeOSPolicy::UpdateDownloadAllowed(
Gilad Arnolda8262e22014-06-02 13:54:27 -0700465 EvaluationContext* ec,
466 State* state,
467 string* error,
468 bool* result) const {
469 // Get the current connection type.
470 ShillProvider* const shill_provider = state->shill_provider();
471 const ConnectionType* conn_type_p = ec->GetValue(
472 shill_provider->var_conn_type());
473 POLICY_CHECK_VALUE_AND_FAIL(conn_type_p, error);
474 ConnectionType conn_type = *conn_type_p;
475
476 // If we're tethering, treat it as a cellular connection.
477 if (conn_type != ConnectionType::kCellular) {
478 const ConnectionTethering* conn_tethering_p = ec->GetValue(
479 shill_provider->var_conn_tethering());
480 POLICY_CHECK_VALUE_AND_FAIL(conn_tethering_p, error);
481 if (*conn_tethering_p == ConnectionTethering::kConfirmed)
482 conn_type = ConnectionType::kCellular;
483 }
484
485 // By default, we allow updates for all connection types, with exceptions as
486 // noted below. This also determines whether a device policy can override the
487 // default.
488 *result = true;
489 bool device_policy_can_override = false;
490 switch (conn_type) {
491 case ConnectionType::kBluetooth:
492 *result = false;
493 break;
494
495 case ConnectionType::kCellular:
496 *result = false;
497 device_policy_can_override = true;
498 break;
499
500 case ConnectionType::kUnknown:
501 if (error)
502 *error = "Unknown connection type";
503 return EvalStatus::kFailed;
504
505 default:
506 break; // Nothing to do.
507 }
508
509 // If update is allowed, we're done.
510 if (*result)
511 return EvalStatus::kSucceeded;
512
513 // Check whether the device policy specifically allows this connection.
Gilad Arnolda8262e22014-06-02 13:54:27 -0700514 if (device_policy_can_override) {
515 DevicePolicyProvider* const dp_provider = state->device_policy_provider();
516 const bool* device_policy_is_loaded_p = ec->GetValue(
517 dp_provider->var_device_policy_is_loaded());
518 if (device_policy_is_loaded_p && *device_policy_is_loaded_p) {
519 const set<ConnectionType>* allowed_conn_types_p = ec->GetValue(
520 dp_provider->var_allowed_connection_types_for_update());
521 if (allowed_conn_types_p) {
522 if (allowed_conn_types_p->count(conn_type)) {
523 *result = true;
524 return EvalStatus::kSucceeded;
525 }
Gilad Arnold28d6be62014-06-30 14:04:04 -0700526 } else if (conn_type == ConnectionType::kCellular) {
527 // Local user settings can allow updates over cellular iff a policy was
528 // loaded but no allowed connections were specified in it.
529 const bool* update_over_cellular_allowed_p = ec->GetValue(
530 state->updater_provider()->var_cellular_enabled());
531 if (update_over_cellular_allowed_p && *update_over_cellular_allowed_p)
532 *result = true;
Gilad Arnolda8262e22014-06-02 13:54:27 -0700533 }
534 }
535 }
536
Gilad Arnold28d6be62014-06-30 14:04:04 -0700537 return (*result ? EvalStatus::kSucceeded : EvalStatus::kAskMeAgainLater);
Gilad Arnolda8262e22014-06-02 13:54:27 -0700538}
539
Gilad Arnold78ecbfc2014-10-22 14:38:25 -0700540EvalStatus ChromeOSPolicy::P2PEnabled(EvaluationContext* ec,
541 State* state,
Alex Deymo39910dc2015-11-09 17:04:30 -0800542 string* error,
Gilad Arnold78ecbfc2014-10-22 14:38:25 -0700543 bool* result) const {
544 bool enabled = false;
545
546 // Determine whether use of P2P is allowed by policy. Even if P2P is not
547 // explicitly allowed, we allow it if the device is enterprise enrolled (that
548 // is, missing or empty owner string).
549 DevicePolicyProvider* const dp_provider = state->device_policy_provider();
550 const bool* device_policy_is_loaded_p = ec->GetValue(
551 dp_provider->var_device_policy_is_loaded());
552 if (device_policy_is_loaded_p && *device_policy_is_loaded_p) {
553 const bool* policy_au_p2p_enabled_p = ec->GetValue(
554 dp_provider->var_au_p2p_enabled());
555 if (policy_au_p2p_enabled_p) {
556 enabled = *policy_au_p2p_enabled_p;
557 } else {
558 const string* policy_owner_p = ec->GetValue(dp_provider->var_owner());
559 if (!policy_owner_p || policy_owner_p->empty())
560 enabled = true;
561 }
562 }
563
564 // Enable P2P, if so mandated by the updater configuration. This is additive
565 // to whether or not P2P is enabled by device policy.
566 if (!enabled) {
567 const bool* updater_p2p_enabled_p = ec->GetValue(
568 state->updater_provider()->var_p2p_enabled());
569 enabled = updater_p2p_enabled_p && *updater_p2p_enabled_p;
570 }
571
572 *result = enabled;
573 return EvalStatus::kSucceeded;
574}
575
576EvalStatus ChromeOSPolicy::P2PEnabledChanged(EvaluationContext* ec,
577 State* state,
Alex Deymo39910dc2015-11-09 17:04:30 -0800578 string* error,
Gilad Arnold78ecbfc2014-10-22 14:38:25 -0700579 bool* result,
580 bool prev_result) const {
581 EvalStatus status = P2PEnabled(ec, state, error, result);
582 if (status == EvalStatus::kSucceeded && *result == prev_result)
583 return EvalStatus::kAskMeAgainLater;
584 return status;
585}
586
Gilad Arnolddc4bb262014-07-23 10:45:19 -0700587EvalStatus ChromeOSPolicy::UpdateBackoffAndDownloadUrl(
Alex Deymof329b932014-10-30 01:37:48 -0700588 EvaluationContext* ec, State* state, string* error,
Gilad Arnolddc4bb262014-07-23 10:45:19 -0700589 UpdateBackoffAndDownloadUrlResult* result,
590 const UpdateState& update_state) const {
591 // Sanity checks.
592 DCHECK_GE(update_state.download_errors_max, 0);
593
594 // Set default result values.
595 result->do_increment_failures = false;
596 result->backoff_expiry = update_state.backoff_expiry;
597 result->url_idx = -1;
598 result->url_num_errors = 0;
599
600 const bool* is_official_build_p = ec->GetValue(
601 state->system_provider()->var_is_official_build());
602 bool is_official_build = (is_official_build_p ? *is_official_build_p : true);
603
604 // Check whether backoff is enabled.
605 bool may_backoff = false;
606 if (update_state.is_backoff_disabled) {
607 LOG(INFO) << "Backoff disabled by Omaha.";
Amin Hassanied37d682018-04-06 13:22:00 -0700608 } else if (update_state.interactive) {
Gilad Arnolddc4bb262014-07-23 10:45:19 -0700609 LOG(INFO) << "No backoff for interactive updates.";
610 } else if (update_state.is_delta_payload) {
611 LOG(INFO) << "No backoff for delta payloads.";
612 } else if (!is_official_build) {
613 LOG(INFO) << "No backoff for unofficial builds.";
614 } else {
615 may_backoff = true;
Gilad Arnoldb3b05442014-05-30 14:25:05 -0700616 }
617
Gilad Arnolddc4bb262014-07-23 10:45:19 -0700618 // If previous backoff still in effect, block.
619 if (may_backoff && !update_state.backoff_expiry.is_null() &&
620 !ec->IsWallclockTimeGreaterThan(update_state.backoff_expiry)) {
621 LOG(INFO) << "Previous backoff has not expired, waiting.";
622 return EvalStatus::kAskMeAgainLater;
623 }
Gilad Arnoldb3b05442014-05-30 14:25:05 -0700624
625 // Determine whether HTTP downloads are forbidden by policy. This only
626 // applies to official system builds; otherwise, HTTP is always enabled.
627 bool http_allowed = true;
Gilad Arnolddc4bb262014-07-23 10:45:19 -0700628 if (is_official_build) {
Gilad Arnoldb3b05442014-05-30 14:25:05 -0700629 DevicePolicyProvider* const dp_provider = state->device_policy_provider();
630 const bool* device_policy_is_loaded_p = ec->GetValue(
631 dp_provider->var_device_policy_is_loaded());
632 if (device_policy_is_loaded_p && *device_policy_is_loaded_p) {
633 const bool* policy_http_downloads_enabled_p = ec->GetValue(
634 dp_provider->var_http_downloads_enabled());
635 http_allowed = (!policy_http_downloads_enabled_p ||
636 *policy_http_downloads_enabled_p);
637 }
638 }
639
Gilad Arnolddc4bb262014-07-23 10:45:19 -0700640 int url_idx = update_state.last_download_url_idx;
641 if (url_idx < 0)
642 url_idx = -1;
643 bool do_advance_url = false;
644 bool is_failure_occurred = false;
645 Time err_time;
646
647 // Scan the relevant part of the download error log, tracking which URLs are
648 // being used, and accounting the number of errors for each URL. Note that
649 // this process may not traverse all errors provided, as it may decide to bail
650 // out midway depending on the particular errors exhibited, the number of
651 // failures allowed, etc. When this ends, |url_idx| will point to the last URL
652 // used (-1 if starting fresh), |do_advance_url| will determine whether the
653 // URL needs to be advanced, and |err_time| the point in time when the last
654 // reported error occurred. Additionally, if the error log indicates that an
655 // update attempt has failed (abnormal), then |is_failure_occurred| will be
656 // set to true.
657 const int num_urls = update_state.download_urls.size();
658 int prev_url_idx = -1;
659 int url_num_errors = update_state.last_download_url_num_errors;
660 Time prev_err_time;
661 bool is_first = true;
662 for (const auto& err_tuple : update_state.download_errors) {
663 // Do some sanity checks.
664 int used_url_idx = get<0>(err_tuple);
665 if (is_first && url_idx >= 0 && used_url_idx != url_idx) {
666 LOG(WARNING) << "First URL in error log (" << used_url_idx
667 << ") not as expected (" << url_idx << ")";
Gilad Arnoldb3b05442014-05-30 14:25:05 -0700668 }
Gilad Arnolddc4bb262014-07-23 10:45:19 -0700669 is_first = false;
670 url_idx = used_url_idx;
671 if (url_idx < 0 || url_idx >= num_urls) {
672 LOG(ERROR) << "Download error log contains an invalid URL index ("
673 << url_idx << ")";
674 return EvalStatus::kFailed;
675 }
676 err_time = get<2>(err_tuple);
677 if (!(prev_err_time.is_null() || err_time >= prev_err_time)) {
678 // TODO(garnold) Monotonicity cannot really be assumed when dealing with
679 // wallclock-based timestamps. However, we're making a simplifying
680 // assumption so as to keep the policy implementation straightforward, for
681 // now. In general, we should convert all timestamp handling in the
682 // UpdateManager to use monotonic time (instead of wallclock), including
683 // the computation of various expiration times (backoff, scattering, etc).
684 // The client will do whatever conversions necessary when
685 // persisting/retrieving these values across reboots. See chromium:408794.
686 LOG(ERROR) << "Download error timestamps not monotonically increasing.";
687 return EvalStatus::kFailed;
688 }
689 prev_err_time = err_time;
Gilad Arnoldb3b05442014-05-30 14:25:05 -0700690
Gilad Arnolddc4bb262014-07-23 10:45:19 -0700691 // Ignore errors that happened before the last known failed attempt.
692 if (!update_state.failures_last_updated.is_null() &&
693 err_time <= update_state.failures_last_updated)
694 continue;
695
696 if (prev_url_idx >= 0) {
697 if (url_idx < prev_url_idx) {
698 LOG(ERROR) << "The URLs in the download error log have wrapped around ("
699 << prev_url_idx << "->" << url_idx
700 << "). This should not have happened and means that there's "
701 "a bug. To be conservative, we record a failed attempt "
702 "(invalidating the rest of the error log) and resume "
703 "download from the first usable URL.";
704 url_idx = -1;
705 is_failure_occurred = true;
706 break;
707 }
708
709 if (url_idx > prev_url_idx) {
710 url_num_errors = 0;
711 do_advance_url = false;
712 }
713 }
714
715 if (HandleErrorCode(get<1>(err_tuple), &url_num_errors) ||
716 url_num_errors > update_state.download_errors_max)
717 do_advance_url = true;
718
719 prev_url_idx = url_idx;
Gilad Arnoldb3b05442014-05-30 14:25:05 -0700720 }
721
Gilad Arnolddc4bb262014-07-23 10:45:19 -0700722 // If required, advance to the next usable URL. If the URLs wraparound, we
723 // mark an update attempt failure. Also be sure to set the download error
724 // count to zero.
725 if (url_idx < 0 || do_advance_url) {
726 url_num_errors = 0;
727 int start_url_idx = -1;
728 do {
729 if (++url_idx == num_urls) {
730 url_idx = 0;
731 // We only mark failure if an actual advancing of a URL was required.
732 if (do_advance_url)
733 is_failure_occurred = true;
734 }
735
736 if (start_url_idx < 0)
737 start_url_idx = url_idx;
738 else if (url_idx == start_url_idx)
739 url_idx = -1; // No usable URL.
740 } while (url_idx >= 0 &&
741 !IsUrlUsable(update_state.download_urls[url_idx], http_allowed));
742 }
743
744 // If we have a download URL but a failure was observed, compute a new backoff
745 // expiry (if allowed). The backoff period is generally 2 ^ (num_failures - 1)
746 // days, bounded by the size of int and kAttemptBackoffMaxIntervalInDays, and
747 // fuzzed by kAttemptBackoffFuzzInHours hours. Backoff expiry is computed from
748 // the latest recorded time of error.
749 Time backoff_expiry;
750 if (url_idx >= 0 && is_failure_occurred && may_backoff) {
751 CHECK(!err_time.is_null())
752 << "We must have an error timestamp if a failure occurred!";
753 const uint64_t* seed = ec->GetValue(state->random_provider()->var_seed());
754 POLICY_CHECK_VALUE_AND_FAIL(seed, error);
755 PRNG prng(*seed);
Alex Deymof329b932014-10-30 01:37:48 -0700756 int exp = min(update_state.num_failures,
Gilad Arnolddc4bb262014-07-23 10:45:19 -0700757 static_cast<int>(sizeof(int)) * 8 - 2);
Amin Hassani186ff6a2018-02-27 11:06:03 -0800758 TimeDelta backoff_interval = TimeDelta::FromDays(min(
759 1 << exp,
760 kNextUpdateCheckPolicyConstants.attempt_backoff_max_interval_in_days));
761 TimeDelta backoff_fuzz = TimeDelta::FromHours(
762 kNextUpdateCheckPolicyConstants.attempt_backoff_fuzz_in_hours);
763 TimeDelta wait_period = NextUpdateCheckTimePolicyImpl::FuzzedInterval(
764 &prng, backoff_interval.InSeconds(), backoff_fuzz.InSeconds());
Gilad Arnolddc4bb262014-07-23 10:45:19 -0700765 backoff_expiry = err_time + wait_period;
766
767 // If the newly computed backoff already expired, nullify it.
768 if (ec->IsWallclockTimeGreaterThan(backoff_expiry))
769 backoff_expiry = Time();
770 }
771
772 result->do_increment_failures = is_failure_occurred;
773 result->backoff_expiry = backoff_expiry;
Gilad Arnoldb3b05442014-05-30 14:25:05 -0700774 result->url_idx = url_idx;
Gilad Arnolddc4bb262014-07-23 10:45:19 -0700775 result->url_num_errors = url_num_errors;
Gilad Arnoldb3b05442014-05-30 14:25:05 -0700776 return EvalStatus::kSucceeded;
777}
778
Gilad Arnoldf62a4b82014-05-01 07:41:07 -0700779EvalStatus ChromeOSPolicy::UpdateScattering(
780 EvaluationContext* ec,
781 State* state,
782 string* error,
783 UpdateScatteringResult* result,
784 const UpdateState& update_state) const {
785 // Preconditions. These stem from the postconditions and usage contract.
786 DCHECK(update_state.scatter_wait_period >= kZeroInterval);
787 DCHECK_GE(update_state.scatter_check_threshold, 0);
788
789 // Set default result values.
790 result->is_scattering = false;
791 result->wait_period = kZeroInterval;
792 result->check_threshold = 0;
793
794 DevicePolicyProvider* const dp_provider = state->device_policy_provider();
795
796 // Ensure that a device policy is loaded.
797 const bool* device_policy_is_loaded_p = ec->GetValue(
798 dp_provider->var_device_policy_is_loaded());
799 if (!(device_policy_is_loaded_p && *device_policy_is_loaded_p))
800 return EvalStatus::kSucceeded;
801
802 // Is scattering enabled by policy?
803 const TimeDelta* scatter_factor_p = ec->GetValue(
804 dp_provider->var_scatter_factor());
805 if (!scatter_factor_p || *scatter_factor_p == kZeroInterval)
806 return EvalStatus::kSucceeded;
807
808 // Obtain a pseudo-random number generator.
809 const uint64_t* seed = ec->GetValue(state->random_provider()->var_seed());
810 POLICY_CHECK_VALUE_AND_FAIL(seed, error);
811 PRNG prng(*seed);
812
813 // Step 1: Maintain the scattering wait period.
814 //
815 // If no wait period was previously determined, or it no longer fits in the
816 // scatter factor, then generate a new one. Otherwise, keep the one we have.
Gilad Arnoldf62a4b82014-05-01 07:41:07 -0700817 TimeDelta wait_period = update_state.scatter_wait_period;
818 if (wait_period == kZeroInterval || wait_period > *scatter_factor_p) {
819 wait_period = TimeDelta::FromSeconds(
820 prng.RandMinMax(1, scatter_factor_p->InSeconds()));
821 }
822
Gilad Arnolddc4bb262014-07-23 10:45:19 -0700823 // If we surpassed the wait period or the max scatter period associated with
Gilad Arnoldf62a4b82014-05-01 07:41:07 -0700824 // the update, then no wait is needed.
825 Time wait_expires = (update_state.first_seen +
826 min(wait_period, update_state.scatter_wait_period_max));
Gilad Arnolda65fced2014-07-23 09:01:31 -0700827 if (ec->IsWallclockTimeGreaterThan(wait_expires))
Gilad Arnoldf62a4b82014-05-01 07:41:07 -0700828 wait_period = kZeroInterval;
829
830 // Step 2: Maintain the update check threshold count.
831 //
832 // If an update check threshold is not specified then generate a new
833 // one.
834 int check_threshold = update_state.scatter_check_threshold;
835 if (check_threshold == 0) {
836 check_threshold = prng.RandMinMax(
837 update_state.scatter_check_threshold_min,
838 update_state.scatter_check_threshold_max);
839 }
840
841 // If the update check threshold is not within allowed range then nullify it.
842 // TODO(garnold) This is compliant with current logic found in
843 // OmahaRequestAction::IsUpdateCheckCountBasedWaitingSatisfied(). We may want
844 // to change it so that it behaves similarly to the wait period case, namely
845 // if the current value exceeds the maximum, we set a new one within range.
846 if (check_threshold > update_state.scatter_check_threshold_max)
847 check_threshold = 0;
848
849 // If the update check threshold is non-zero and satisfied, then nullify it.
850 if (check_threshold > 0 && update_state.num_checks >= check_threshold)
851 check_threshold = 0;
852
853 bool is_scattering = (wait_period != kZeroInterval || check_threshold);
854 EvalStatus ret = EvalStatus::kSucceeded;
855 if (is_scattering && wait_period == update_state.scatter_wait_period &&
856 check_threshold == update_state.scatter_check_threshold)
857 ret = EvalStatus::kAskMeAgainLater;
858 result->is_scattering = is_scattering;
859 result->wait_period = wait_period;
860 result->check_threshold = check_threshold;
861 return ret;
862}
863
Alex Deymo63784a52014-05-28 10:46:14 -0700864} // namespace chromeos_update_manager