blob: 86a2dc4b9d24d66af309489258b7a0e8fa5e7b08 [file] [log] [blame]
Alex Deymoc705cc82014-02-19 11:15:00 -08001// Copyright (c) 2014 The Chromium OS Authors. All rights reserved.
2// Use of this source code is governed by a BSD-style license that can be
3// found in the LICENSE file.
4
Alex Deymo63784a52014-05-28 10:46:14 -07005#include "update_engine/update_manager/chromeos_policy.h"
Alex Deymo0d11c602014-04-23 20:12:20 -07006
Gilad Arnolde1218812014-05-07 12:21:36 -07007#include <algorithm>
Gilad Arnold0adbc942014-05-12 10:35:43 -07008#include <set>
Alex Deymoc705cc82014-02-19 11:15:00 -08009#include <string>
10
Gilad Arnoldf62a4b82014-05-01 07:41:07 -070011#include <base/logging.h>
Gilad Arnoldb3b05442014-05-30 14:25:05 -070012#include <base/strings/string_util.h>
Gilad Arnoldf62a4b82014-05-01 07:41:07 -070013#include <base/time/time.h>
14
Gilad Arnoldb3b05442014-05-30 14:25:05 -070015#include "update_engine/error_code.h"
Alex Deymo63784a52014-05-28 10:46:14 -070016#include "update_engine/update_manager/device_policy_provider.h"
17#include "update_engine/update_manager/policy_utils.h"
18#include "update_engine/update_manager/shill_provider.h"
Gilad Arnoldb3b05442014-05-30 14:25:05 -070019#include "update_engine/utils.h"
Gilad Arnoldf62a4b82014-05-01 07:41:07 -070020
Alex Deymo0d11c602014-04-23 20:12:20 -070021using base::Time;
22using base::TimeDelta;
Gilad Arnoldb3b05442014-05-30 14:25:05 -070023using chromeos_update_engine::ErrorCode;
Gilad Arnolddc4bb262014-07-23 10:45:19 -070024using std::get;
Gilad Arnoldb3b05442014-05-30 14:25:05 -070025using std::max;
Gilad Arnoldf62a4b82014-05-01 07:41:07 -070026using std::min;
Gilad Arnold0adbc942014-05-12 10:35:43 -070027using std::set;
Alex Deymoc705cc82014-02-19 11:15:00 -080028using std::string;
29
Gilad Arnoldb3b05442014-05-30 14:25:05 -070030namespace {
31
Gilad Arnolddc4bb262014-07-23 10:45:19 -070032// Examines |err_code| and decides whether the URL index needs to be advanced,
33// the error count for the URL incremented, or none of the above. In the first
34// case, returns true; in the second case, increments |*url_num_error_p| and
35// returns false; otherwise just returns false.
Gilad Arnoldb3b05442014-05-30 14:25:05 -070036//
37// TODO(garnold) Adapted from PayloadState::UpdateFailed() (to be retired).
Gilad Arnolddc4bb262014-07-23 10:45:19 -070038bool HandleErrorCode(ErrorCode err_code, int* url_num_error_p) {
Gilad Arnoldb3b05442014-05-30 14:25:05 -070039 err_code = chromeos_update_engine::utils::GetBaseErrorCode(err_code);
40 switch (err_code) {
41 // Errors which are good indicators of a problem with a particular URL or
42 // the protocol used in the URL or entities in the communication channel
43 // (e.g. proxies). We should try the next available URL in the next update
44 // check to quickly recover from these errors.
45 case ErrorCode::kPayloadHashMismatchError:
46 case ErrorCode::kPayloadSizeMismatchError:
47 case ErrorCode::kDownloadPayloadVerificationError:
48 case ErrorCode::kDownloadPayloadPubKeyVerificationError:
49 case ErrorCode::kSignedDeltaPayloadExpectedError:
50 case ErrorCode::kDownloadInvalidMetadataMagicString:
51 case ErrorCode::kDownloadSignatureMissingInManifest:
52 case ErrorCode::kDownloadManifestParseError:
53 case ErrorCode::kDownloadMetadataSignatureError:
54 case ErrorCode::kDownloadMetadataSignatureVerificationError:
55 case ErrorCode::kDownloadMetadataSignatureMismatch:
56 case ErrorCode::kDownloadOperationHashVerificationError:
57 case ErrorCode::kDownloadOperationExecutionError:
58 case ErrorCode::kDownloadOperationHashMismatch:
59 case ErrorCode::kDownloadInvalidMetadataSize:
60 case ErrorCode::kDownloadInvalidMetadataSignature:
61 case ErrorCode::kDownloadOperationHashMissingError:
62 case ErrorCode::kDownloadMetadataSignatureMissingError:
63 case ErrorCode::kPayloadMismatchedType:
64 case ErrorCode::kUnsupportedMajorPayloadVersion:
65 case ErrorCode::kUnsupportedMinorPayloadVersion:
66 LOG(INFO) << "Advancing download URL due to error "
67 << chromeos_update_engine::utils::CodeToString(err_code)
68 << " (" << static_cast<int>(err_code) << ")";
Gilad Arnoldb3b05442014-05-30 14:25:05 -070069 return true;
70
71 // Errors which seem to be just transient network/communication related
72 // failures and do not indicate any inherent problem with the URL itself.
73 // So, we should keep the current URL but just increment the
74 // failure count to give it more chances. This way, while we maximize our
75 // chances of downloading from the URLs that appear earlier in the response
76 // (because download from a local server URL that appears earlier in a
77 // response is preferable than downloading from the next URL which could be
Alex Vakulenko072359c2014-07-18 11:41:07 -070078 // an Internet URL and thus could be more expensive).
Gilad Arnoldb3b05442014-05-30 14:25:05 -070079 case ErrorCode::kError:
80 case ErrorCode::kDownloadTransferError:
81 case ErrorCode::kDownloadWriteError:
82 case ErrorCode::kDownloadStateInitializationError:
Gilad Arnold684219d2014-07-07 14:54:57 -070083 case ErrorCode::kOmahaErrorInHTTPResponse: // Aggregate for HTTP errors.
Gilad Arnoldb3b05442014-05-30 14:25:05 -070084 LOG(INFO) << "Incrementing URL failure count due to error "
85 << chromeos_update_engine::utils::CodeToString(err_code)
86 << " (" << static_cast<int>(err_code) << ")";
Gilad Arnolddc4bb262014-07-23 10:45:19 -070087 *url_num_error_p += 1;
Gilad Arnoldb3b05442014-05-30 14:25:05 -070088 return false;
89
90 // Errors which are not specific to a URL and hence shouldn't result in
91 // the URL being penalized. This can happen in two cases:
92 // 1. We haven't started downloading anything: These errors don't cost us
93 // anything in terms of actual payload bytes, so we should just do the
94 // regular retries at the next update check.
95 // 2. We have successfully downloaded the payload: In this case, the
96 // payload attempt number would have been incremented and would take care
Alex Vakulenko072359c2014-07-18 11:41:07 -070097 // of the back-off at the next update check.
Gilad Arnoldb3b05442014-05-30 14:25:05 -070098 // In either case, there's no need to update URL index or failure count.
99 case ErrorCode::kOmahaRequestError:
100 case ErrorCode::kOmahaResponseHandlerError:
101 case ErrorCode::kPostinstallRunnerError:
102 case ErrorCode::kFilesystemCopierError:
103 case ErrorCode::kInstallDeviceOpenError:
104 case ErrorCode::kKernelDeviceOpenError:
105 case ErrorCode::kDownloadNewPartitionInfoError:
106 case ErrorCode::kNewRootfsVerificationError:
107 case ErrorCode::kNewKernelVerificationError:
108 case ErrorCode::kPostinstallBootedFromFirmwareB:
109 case ErrorCode::kPostinstallFirmwareRONotUpdatable:
110 case ErrorCode::kOmahaRequestEmptyResponseError:
111 case ErrorCode::kOmahaRequestXMLParseError:
112 case ErrorCode::kOmahaResponseInvalid:
113 case ErrorCode::kOmahaUpdateIgnoredPerPolicy:
114 case ErrorCode::kOmahaUpdateDeferredPerPolicy:
115 case ErrorCode::kOmahaUpdateDeferredForBackoff:
116 case ErrorCode::kPostinstallPowerwashError:
117 case ErrorCode::kUpdateCanceledByChannelChange:
David Zeuthenf3e28012014-08-26 18:23:52 -0400118 case ErrorCode::kOmahaRequestXMLHasEntityDecl:
Gilad Arnoldb3b05442014-05-30 14:25:05 -0700119 LOG(INFO) << "Not changing URL index or failure count due to error "
120 << chromeos_update_engine::utils::CodeToString(err_code)
121 << " (" << static_cast<int>(err_code) << ")";
122 return false;
123
124 case ErrorCode::kSuccess: // success code
125 case ErrorCode::kUmaReportedMax: // not an error code
126 case ErrorCode::kOmahaRequestHTTPResponseBase: // aggregated already
127 case ErrorCode::kDevModeFlag: // not an error code
128 case ErrorCode::kResumedFlag: // not an error code
129 case ErrorCode::kTestImageFlag: // not an error code
130 case ErrorCode::kTestOmahaUrlFlag: // not an error code
131 case ErrorCode::kSpecialFlags: // not an error code
132 // These shouldn't happen. Enumerating these explicitly here so that we
133 // can let the compiler warn about new error codes that are added to
134 // action_processor.h but not added here.
135 LOG(WARNING) << "Unexpected error "
136 << chromeos_update_engine::utils::CodeToString(err_code)
137 << " (" << static_cast<int>(err_code) << ")";
138 // Note: Not adding a default here so as to let the compiler warn us of
139 // any new enums that were added in the .h but not listed in this switch.
140 }
141 return false;
142}
143
Gilad Arnolddc4bb262014-07-23 10:45:19 -0700144// Checks whether |url| can be used under given download restrictions.
145bool IsUrlUsable(const string& url, bool http_allowed) {
146 return http_allowed || !StartsWithASCII(url, "http://", false);
Gilad Arnoldb3b05442014-05-30 14:25:05 -0700147}
148
149} // namespace
150
Alex Deymo63784a52014-05-28 10:46:14 -0700151namespace chromeos_update_manager {
Alex Deymoc705cc82014-02-19 11:15:00 -0800152
Gilad Arnolda2e8eaa2014-09-24 13:12:33 -0700153const int ChromeOSPolicy::kTimeoutInitialInterval = 7 * 60;
154const int ChromeOSPolicy::kTimeoutPeriodicInterval = 45 * 60;
155const int ChromeOSPolicy::kTimeoutMaxBackoffInterval = 4 * 60 * 60;
156const int ChromeOSPolicy::kTimeoutRegularFuzz = 10 * 60;
Gilad Arnolddc4bb262014-07-23 10:45:19 -0700157const int ChromeOSPolicy::kAttemptBackoffMaxIntervalInDays = 16;
158const int ChromeOSPolicy::kAttemptBackoffFuzzInHours = 12;
Gilad Arnold349ac832014-10-06 14:20:28 -0700159const int ChromeOSPolicy::kMaxP2PAttempts = 10;
160const int ChromeOSPolicy::kMaxP2PAttemptsPeriodInSeconds = 5 * 24 * 60 * 60;
Gilad Arnolda2e8eaa2014-09-24 13:12:33 -0700161
Alex Deymo0d11c602014-04-23 20:12:20 -0700162EvalStatus ChromeOSPolicy::UpdateCheckAllowed(
163 EvaluationContext* ec, State* state, string* error,
164 UpdateCheckParams* result) const {
Gilad Arnold42f253b2014-06-25 12:39:17 -0700165 // Set the default return values.
166 result->updates_enabled = true;
167 result->target_channel.clear();
Gilad Arnoldd4b30322014-07-21 15:35:27 -0700168 result->target_version_prefix.clear();
Gilad Arnold44dc3bf2014-07-18 23:39:38 -0700169 result->is_interactive = false;
Gilad Arnold42f253b2014-06-25 12:39:17 -0700170
Gilad Arnolda1eabcd2014-07-09 15:42:40 -0700171 DevicePolicyProvider* const dp_provider = state->device_policy_provider();
Gilad Arnold44dc3bf2014-07-18 23:39:38 -0700172 UpdaterProvider* const updater_provider = state->updater_provider();
Gilad Arnolda1eabcd2014-07-09 15:42:40 -0700173 SystemProvider* const system_provider = state->system_provider();
174
Gilad Arnold44dc3bf2014-07-18 23:39:38 -0700175 // Do not perform any updates if booted from removable device. This decision
176 // is final.
Gilad Arnoldbfc44f72014-07-09 14:41:39 -0700177 const bool* is_boot_device_removable_p = ec->GetValue(
Gilad Arnolda1eabcd2014-07-09 15:42:40 -0700178 system_provider->var_is_boot_device_removable());
Gilad Arnoldbfc44f72014-07-09 14:41:39 -0700179 if (is_boot_device_removable_p && *is_boot_device_removable_p) {
Gilad Arnoldec7f9162014-07-15 13:24:46 -0700180 LOG(INFO) << "Booted from removable device, disabling update checks.";
Gilad Arnoldbfc44f72014-07-09 14:41:39 -0700181 result->updates_enabled = false;
182 return EvalStatus::kSucceeded;
183 }
184
Gilad Arnold42f253b2014-06-25 12:39:17 -0700185 const bool* device_policy_is_loaded_p = ec->GetValue(
186 dp_provider->var_device_policy_is_loaded());
187 if (device_policy_is_loaded_p && *device_policy_is_loaded_p) {
188 // Check whether updates are disabled by policy.
189 const bool* update_disabled_p = ec->GetValue(
190 dp_provider->var_update_disabled());
Gilad Arnoldec7f9162014-07-15 13:24:46 -0700191 if (update_disabled_p && *update_disabled_p) {
192 LOG(INFO) << "Updates disabled by policy, blocking update checks.";
Gilad Arnold42f253b2014-06-25 12:39:17 -0700193 return EvalStatus::kAskMeAgainLater;
Gilad Arnoldec7f9162014-07-15 13:24:46 -0700194 }
Gilad Arnold42f253b2014-06-25 12:39:17 -0700195
Gilad Arnoldd4b30322014-07-21 15:35:27 -0700196 // Determine whether a target version prefix is dictated by policy.
197 const string* target_version_prefix_p = ec->GetValue(
198 dp_provider->var_target_version_prefix());
199 if (target_version_prefix_p)
200 result->target_version_prefix = *target_version_prefix_p;
201
Gilad Arnold42f253b2014-06-25 12:39:17 -0700202 // Determine whether a target channel is dictated by policy.
203 const bool* release_channel_delegated_p = ec->GetValue(
204 dp_provider->var_release_channel_delegated());
205 if (release_channel_delegated_p && !(*release_channel_delegated_p)) {
206 const string* release_channel_p = ec->GetValue(
207 dp_provider->var_release_channel());
208 if (release_channel_p)
209 result->target_channel = *release_channel_p;
210 }
211 }
212
Gilad Arnold44dc3bf2014-07-18 23:39:38 -0700213 // First, check to see if an interactive update was requested.
Gilad Arnoldec7f9162014-07-15 13:24:46 -0700214 const UpdateRequestStatus* forced_update_requested_p = ec->GetValue(
215 updater_provider->var_forced_update_requested());
216 if (forced_update_requested_p &&
217 *forced_update_requested_p != UpdateRequestStatus::kNone) {
218 result->is_interactive =
219 (*forced_update_requested_p == UpdateRequestStatus::kInteractive);
220 LOG(INFO) << "Forced update signaled ("
221 << (result->is_interactive ? "interactive" : "periodic")
222 << "), allowing update check.";
Gilad Arnold44dc3bf2014-07-18 23:39:38 -0700223 return EvalStatus::kSucceeded;
224 }
225
226 // The logic thereafter applies to periodic updates. Bear in mind that we
227 // should not return a final "no" if any of these criteria are not satisfied,
228 // because the system may still update due to an interactive update request.
229
230 // Unofficial builds should not perform periodic update checks.
231 const bool* is_official_build_p = ec->GetValue(
232 system_provider->var_is_official_build());
233 if (is_official_build_p && !(*is_official_build_p)) {
Gilad Arnoldec7f9162014-07-15 13:24:46 -0700234 LOG(INFO) << "Unofficial build, blocking periodic update checks.";
Gilad Arnold44dc3bf2014-07-18 23:39:38 -0700235 return EvalStatus::kAskMeAgainLater;
236 }
237
238 // If OOBE is enabled, wait until it is completed.
239 const bool* is_oobe_enabled_p = ec->GetValue(
240 state->config_provider()->var_is_oobe_enabled());
241 if (is_oobe_enabled_p && *is_oobe_enabled_p) {
242 const bool* is_oobe_complete_p = ec->GetValue(
243 system_provider->var_is_oobe_complete());
Gilad Arnoldec7f9162014-07-15 13:24:46 -0700244 if (is_oobe_complete_p && !(*is_oobe_complete_p)) {
245 LOG(INFO) << "OOBE not completed, blocking update checks.";
Gilad Arnold44dc3bf2014-07-18 23:39:38 -0700246 return EvalStatus::kAskMeAgainLater;
Gilad Arnoldec7f9162014-07-15 13:24:46 -0700247 }
Gilad Arnold44dc3bf2014-07-18 23:39:38 -0700248 }
249
250 // Ensure that periodic update checks are timed properly.
Alex Deymo0d11c602014-04-23 20:12:20 -0700251 Time next_update_check;
252 if (NextUpdateCheckTime(ec, state, error, &next_update_check) !=
253 EvalStatus::kSucceeded) {
254 return EvalStatus::kFailed;
255 }
Gilad Arnoldec7f9162014-07-15 13:24:46 -0700256 if (!ec->IsWallclockTimeGreaterThan(next_update_check)) {
257 LOG(INFO) << "Periodic check interval not satisfied, blocking until "
258 << chromeos_update_engine::utils::ToString(next_update_check);
Alex Deymo0d11c602014-04-23 20:12:20 -0700259 return EvalStatus::kAskMeAgainLater;
Gilad Arnoldec7f9162014-07-15 13:24:46 -0700260 }
Alex Deymo0d11c602014-04-23 20:12:20 -0700261
262 // It is time to check for an update.
Gilad Arnoldec7f9162014-07-15 13:24:46 -0700263 LOG(INFO) << "Allowing update check.";
Alex Deymoe636c3c2014-03-11 19:02:08 -0700264 return EvalStatus::kSucceeded;
Alex Deymoc705cc82014-02-19 11:15:00 -0800265}
266
Gilad Arnoldf62a4b82014-05-01 07:41:07 -0700267EvalStatus ChromeOSPolicy::UpdateCanStart(
268 EvaluationContext* ec,
269 State* state,
270 string* error,
Gilad Arnold42f253b2014-06-25 12:39:17 -0700271 UpdateDownloadParams* result,
Gilad Arnoldd78caf92014-09-24 09:28:14 -0700272 const UpdateState update_state) const {
Gilad Arnolddc4bb262014-07-23 10:45:19 -0700273 // Set the default return values. Note that we set persisted values (backoff,
274 // scattering) to the same values presented in the update state. The reason is
275 // that preemptive returns, such as the case where an update check is due,
276 // should not clear off the said values; rather, it is the deliberate
277 // inference of new values that should cause them to be reset.
Gilad Arnoldf62a4b82014-05-01 07:41:07 -0700278 result->update_can_start = true;
Gilad Arnoldf62a4b82014-05-01 07:41:07 -0700279 result->cannot_start_reason = UpdateCannotStartReason::kUndefined;
Gilad Arnoldb3b05442014-05-30 14:25:05 -0700280 result->download_url_idx = -1;
Gilad Arnolddc4bb262014-07-23 10:45:19 -0700281 result->p2p_allowed = false;
282 result->do_increment_failures = false;
283 result->backoff_expiry = update_state.backoff_expiry;
284 result->scatter_wait_period = update_state.scatter_wait_period;
285 result->scatter_check_threshold = update_state.scatter_check_threshold;
Gilad Arnoldf62a4b82014-05-01 07:41:07 -0700286
287 // Make sure that we're not due for an update check.
288 UpdateCheckParams check_result;
289 EvalStatus check_status = UpdateCheckAllowed(ec, state, error, &check_result);
290 if (check_status == EvalStatus::kFailed)
291 return EvalStatus::kFailed;
292 if (check_status == EvalStatus::kSucceeded &&
293 check_result.updates_enabled == true) {
294 result->update_can_start = false;
295 result->cannot_start_reason = UpdateCannotStartReason::kCheckDue;
296 return EvalStatus::kSucceeded;
297 }
298
Gilad Arnolddc4bb262014-07-23 10:45:19 -0700299 // Check whether backoff applies, and if not then which URL can be used for
300 // downloading. These require scanning the download error log, and so they are
301 // done together.
302 UpdateBackoffAndDownloadUrlResult backoff_url_result;
303 EvalStatus backoff_url_status = UpdateBackoffAndDownloadUrl(
304 ec, state, error, &backoff_url_result, update_state);
305 if (backoff_url_status != EvalStatus::kFailed) {
306 result->download_url_idx = backoff_url_result.url_idx;
307 result->download_url_num_errors = backoff_url_result.url_num_errors;
308 result->do_increment_failures = backoff_url_result.do_increment_failures;
309 result->backoff_expiry = backoff_url_result.backoff_expiry;
310 }
311 if (backoff_url_status != EvalStatus::kSucceeded ||
312 !backoff_url_result.backoff_expiry.is_null()) {
313 if (backoff_url_status != EvalStatus::kFailed) {
314 result->update_can_start = false;
315 result->cannot_start_reason = UpdateCannotStartReason::kBackoff;
316 }
317 return backoff_url_status;
318 }
319
Gilad Arnold349ac832014-10-06 14:20:28 -0700320 // Check whether P2P has reached its number of attempts and/or time limits. In
321 // which case, set a flag preventing us from enabling P2P later on.
322 bool is_p2p_blocked = false;
323 if (update_state.p2p_num_attempts >= kMaxP2PAttempts) {
324 is_p2p_blocked = true;
325 LOG(INFO) << "Blocking P2P as it's been attempted too many times.";
326 } else if (!update_state.p2p_first_attempted.is_null()) {
327 Time p2p_expiry = (
328 update_state.p2p_first_attempted +
329 TimeDelta::FromSeconds(kMaxP2PAttemptsPeriodInSeconds));
330 if (ec->IsWallclockTimeGreaterThan(p2p_expiry)) {
331 is_p2p_blocked = true;
332 LOG(INFO) << "Blocking P2P as its usage timespan exceeds the limit.";
333 }
334 }
335
Gilad Arnoldf62a4b82014-05-01 07:41:07 -0700336 DevicePolicyProvider* const dp_provider = state->device_policy_provider();
337
338 const bool* device_policy_is_loaded_p = ec->GetValue(
339 dp_provider->var_device_policy_is_loaded());
340 if (device_policy_is_loaded_p && *device_policy_is_loaded_p) {
Gilad Arnold76a11f62014-05-20 09:02:12 -0700341 // Check whether scattering applies to this update attempt. We should not be
342 // scattering if this is an interactive update check, or if OOBE is enabled
343 // but not completed.
344 //
345 // Note: current code further suppresses scattering if a "deadline"
Gilad Arnoldf62a4b82014-05-01 07:41:07 -0700346 // attribute is found in the Omaha response. However, it appears that the
Gilad Arnold76a11f62014-05-20 09:02:12 -0700347 // presence of this attribute is merely indicative of an OOBE update, during
348 // which we suppress scattering anyway.
349 bool scattering_applies = false;
Gilad Arnolddc4bb262014-07-23 10:45:19 -0700350 result->scatter_wait_period = kZeroInterval;
351 result->scatter_check_threshold = 0;
352 if (!update_state.is_interactive) {
Gilad Arnold76a11f62014-05-20 09:02:12 -0700353 const bool* is_oobe_enabled_p = ec->GetValue(
354 state->config_provider()->var_is_oobe_enabled());
355 if (is_oobe_enabled_p && !(*is_oobe_enabled_p)) {
356 scattering_applies = true;
357 } else {
358 const bool* is_oobe_complete_p = ec->GetValue(
Gilad Arnoldb3b05442014-05-30 14:25:05 -0700359 state->system_provider()->var_is_oobe_complete());
Gilad Arnold76a11f62014-05-20 09:02:12 -0700360 scattering_applies = (is_oobe_complete_p && *is_oobe_complete_p);
361 }
362 }
363
364 // Compute scattering values.
365 if (scattering_applies) {
Gilad Arnoldf62a4b82014-05-01 07:41:07 -0700366 UpdateScatteringResult scatter_result;
367 EvalStatus scattering_status = UpdateScattering(
368 ec, state, error, &scatter_result, update_state);
369 if (scattering_status != EvalStatus::kSucceeded ||
370 scatter_result.is_scattering) {
371 if (scattering_status != EvalStatus::kFailed) {
372 result->update_can_start = false;
373 result->cannot_start_reason = UpdateCannotStartReason::kScattering;
374 result->scatter_wait_period = scatter_result.wait_period;
375 result->scatter_check_threshold = scatter_result.check_threshold;
376 }
377 return scattering_status;
378 }
379 }
380
Gilad Arnoldef8d0872014-10-03 14:14:06 -0700381 // Determine whether use of P2P is allowed by policy. Even if P2P is not
382 // explicitly allowed, we allow it if the device is enterprise enrolled
383 // (that is, missing or empty owner string).
Gilad Arnold349ac832014-10-06 14:20:28 -0700384 if (!is_p2p_blocked) {
385 const bool* policy_au_p2p_enabled_p = ec->GetValue(
386 dp_provider->var_au_p2p_enabled());
387 if (policy_au_p2p_enabled_p) {
388 result->p2p_allowed = *policy_au_p2p_enabled_p;
389 } else {
390 const string* policy_owner_p = ec->GetValue(dp_provider->var_owner());
391 if (!policy_owner_p || policy_owner_p->empty())
392 result->p2p_allowed = true;
393 }
Gilad Arnoldef8d0872014-10-03 14:14:06 -0700394 }
Gilad Arnoldf62a4b82014-05-01 07:41:07 -0700395 }
396
Gilad Arnoldef8d0872014-10-03 14:14:06 -0700397 // Enable P2P, if so mandated by the updater configuration. This is additive
398 // to whether or not P2P is allowed per device policy (see above).
Gilad Arnold349ac832014-10-06 14:20:28 -0700399 if (!(is_p2p_blocked || result->p2p_allowed)) {
Gilad Arnoldf62a4b82014-05-01 07:41:07 -0700400 const bool* updater_p2p_enabled_p = ec->GetValue(
401 state->updater_provider()->var_p2p_enabled());
402 result->p2p_allowed = updater_p2p_enabled_p && *updater_p2p_enabled_p;
403 }
404
Gilad Arnolddc4bb262014-07-23 10:45:19 -0700405 // Store the download URL and failure increment flag. Note that no URL will
406 // only terminate evaluation if no other means of download (such as P2P) are
407 // enabled.
408 if (result->download_url_idx < 0 && !result->p2p_allowed) {
409 result->update_can_start = false;
410 result->cannot_start_reason = UpdateCannotStartReason::kCannotDownload;
Gilad Arnoldb3b05442014-05-30 14:25:05 -0700411 }
412
Gilad Arnoldaf2f6ae2014-04-28 14:14:52 -0700413 return EvalStatus::kSucceeded;
414}
415
Gilad Arnolda8262e22014-06-02 13:54:27 -0700416// TODO(garnold) Logic in this method is based on
417// ConnectionManager::IsUpdateAllowedOver(); be sure to deprecate the latter.
418//
419// TODO(garnold) The current logic generally treats the list of allowed
420// connections coming from the device policy as a whitelist, meaning that it
421// can only be used for enabling connections, but not disable them. Further,
422// certain connection types (like Bluetooth) cannot be enabled even by policy.
423// In effect, the only thing that device policy can change is to enable
424// updates over a cellular network (disabled by default). We may want to
425// revisit this semantics, allowing greater flexibility in defining specific
426// permissions over all types of networks.
Gilad Arnold684219d2014-07-07 14:54:57 -0700427EvalStatus ChromeOSPolicy::UpdateDownloadAllowed(
Gilad Arnolda8262e22014-06-02 13:54:27 -0700428 EvaluationContext* ec,
429 State* state,
430 string* error,
431 bool* result) const {
432 // Get the current connection type.
433 ShillProvider* const shill_provider = state->shill_provider();
434 const ConnectionType* conn_type_p = ec->GetValue(
435 shill_provider->var_conn_type());
436 POLICY_CHECK_VALUE_AND_FAIL(conn_type_p, error);
437 ConnectionType conn_type = *conn_type_p;
438
439 // If we're tethering, treat it as a cellular connection.
440 if (conn_type != ConnectionType::kCellular) {
441 const ConnectionTethering* conn_tethering_p = ec->GetValue(
442 shill_provider->var_conn_tethering());
443 POLICY_CHECK_VALUE_AND_FAIL(conn_tethering_p, error);
444 if (*conn_tethering_p == ConnectionTethering::kConfirmed)
445 conn_type = ConnectionType::kCellular;
446 }
447
448 // By default, we allow updates for all connection types, with exceptions as
449 // noted below. This also determines whether a device policy can override the
450 // default.
451 *result = true;
452 bool device_policy_can_override = false;
453 switch (conn_type) {
454 case ConnectionType::kBluetooth:
455 *result = false;
456 break;
457
458 case ConnectionType::kCellular:
459 *result = false;
460 device_policy_can_override = true;
461 break;
462
463 case ConnectionType::kUnknown:
464 if (error)
465 *error = "Unknown connection type";
466 return EvalStatus::kFailed;
467
468 default:
469 break; // Nothing to do.
470 }
471
472 // If update is allowed, we're done.
473 if (*result)
474 return EvalStatus::kSucceeded;
475
476 // Check whether the device policy specifically allows this connection.
Gilad Arnolda8262e22014-06-02 13:54:27 -0700477 if (device_policy_can_override) {
478 DevicePolicyProvider* const dp_provider = state->device_policy_provider();
479 const bool* device_policy_is_loaded_p = ec->GetValue(
480 dp_provider->var_device_policy_is_loaded());
481 if (device_policy_is_loaded_p && *device_policy_is_loaded_p) {
482 const set<ConnectionType>* allowed_conn_types_p = ec->GetValue(
483 dp_provider->var_allowed_connection_types_for_update());
484 if (allowed_conn_types_p) {
485 if (allowed_conn_types_p->count(conn_type)) {
486 *result = true;
487 return EvalStatus::kSucceeded;
488 }
Gilad Arnold28d6be62014-06-30 14:04:04 -0700489 } else if (conn_type == ConnectionType::kCellular) {
490 // Local user settings can allow updates over cellular iff a policy was
491 // loaded but no allowed connections were specified in it.
492 const bool* update_over_cellular_allowed_p = ec->GetValue(
493 state->updater_provider()->var_cellular_enabled());
494 if (update_over_cellular_allowed_p && *update_over_cellular_allowed_p)
495 *result = true;
Gilad Arnolda8262e22014-06-02 13:54:27 -0700496 }
497 }
498 }
499
Gilad Arnold28d6be62014-06-30 14:04:04 -0700500 return (*result ? EvalStatus::kSucceeded : EvalStatus::kAskMeAgainLater);
Gilad Arnolda8262e22014-06-02 13:54:27 -0700501}
502
Alex Deymo0d11c602014-04-23 20:12:20 -0700503EvalStatus ChromeOSPolicy::NextUpdateCheckTime(EvaluationContext* ec,
504 State* state, string* error,
505 Time* next_update_check) const {
Gilad Arnolda0258a52014-07-10 16:21:19 -0700506 UpdaterProvider* const updater_provider = state->updater_provider();
507
Alex Deymo0d11c602014-04-23 20:12:20 -0700508 // Don't check for updates too often. We limit the update checks to once every
509 // some interval. The interval is kTimeoutInitialInterval the first time and
510 // kTimeoutPeriodicInterval for the subsequent update checks. If the update
511 // check fails, we increase the interval between the update checks
512 // exponentially until kTimeoutMaxBackoffInterval. Finally, to avoid having
513 // many chromebooks running update checks at the exact same time, we add some
514 // fuzz to the interval.
515 const Time* updater_started_time =
Gilad Arnolda0258a52014-07-10 16:21:19 -0700516 ec->GetValue(updater_provider->var_updater_started_time());
Alex Deymo0d11c602014-04-23 20:12:20 -0700517 POLICY_CHECK_VALUE_AND_FAIL(updater_started_time, error);
518
Alex Deymof329b932014-10-30 01:37:48 -0700519 const Time* last_checked_time =
Gilad Arnolda0258a52014-07-10 16:21:19 -0700520 ec->GetValue(updater_provider->var_last_checked_time());
Alex Deymo0d11c602014-04-23 20:12:20 -0700521
522 const uint64_t* seed = ec->GetValue(state->random_provider()->var_seed());
523 POLICY_CHECK_VALUE_AND_FAIL(seed, error);
524
525 PRNG prng(*seed);
526
Gilad Arnold38b14022014-07-09 12:45:56 -0700527 // If this is the first attempt, compute and return an initial value.
Alex Deymo0d11c602014-04-23 20:12:20 -0700528 if (!last_checked_time || *last_checked_time < *updater_started_time) {
Alex Deymo0d11c602014-04-23 20:12:20 -0700529 *next_update_check = *updater_started_time + FuzzedInterval(
530 &prng, kTimeoutInitialInterval, kTimeoutRegularFuzz);
531 return EvalStatus::kSucceeded;
532 }
Gilad Arnold38b14022014-07-09 12:45:56 -0700533
Gilad Arnolda0258a52014-07-10 16:21:19 -0700534 // Check whether the server is enforcing a poll interval; if not, this value
535 // will be zero.
536 const unsigned int* server_dictated_poll_interval = ec->GetValue(
537 updater_provider->var_server_dictated_poll_interval());
538 POLICY_CHECK_VALUE_AND_FAIL(server_dictated_poll_interval, error);
Alex Deymo0d11c602014-04-23 20:12:20 -0700539
Gilad Arnolda0258a52014-07-10 16:21:19 -0700540 int interval = *server_dictated_poll_interval;
541 int fuzz = 0;
542
Alex Vakulenko072359c2014-07-18 11:41:07 -0700543 // If no poll interval was dictated by server compute a back-off period,
Gilad Arnolda0258a52014-07-10 16:21:19 -0700544 // starting from a predetermined base periodic interval and increasing
545 // exponentially by the number of consecutive failed attempts.
546 if (interval == 0) {
547 const unsigned int* consecutive_failed_update_checks = ec->GetValue(
548 updater_provider->var_consecutive_failed_update_checks());
549 POLICY_CHECK_VALUE_AND_FAIL(consecutive_failed_update_checks, error);
550
551 interval = kTimeoutPeriodicInterval;
552 unsigned int num_failures = *consecutive_failed_update_checks;
553 while (interval < kTimeoutMaxBackoffInterval && num_failures) {
554 interval *= 2;
555 num_failures--;
Alex Deymo0d11c602014-04-23 20:12:20 -0700556 }
557 }
558
Alex Vakulenko072359c2014-07-18 11:41:07 -0700559 // We cannot back off longer than the predetermined maximum interval.
Gilad Arnolda0258a52014-07-10 16:21:19 -0700560 if (interval > kTimeoutMaxBackoffInterval)
561 interval = kTimeoutMaxBackoffInterval;
562
Alex Vakulenko072359c2014-07-18 11:41:07 -0700563 // We cannot back off shorter than the predetermined periodic interval. Also,
Gilad Arnolda0258a52014-07-10 16:21:19 -0700564 // in this case set the fuzz to a predetermined regular value.
565 if (interval <= kTimeoutPeriodicInterval) {
566 interval = kTimeoutPeriodicInterval;
567 fuzz = kTimeoutRegularFuzz;
568 }
569
570 // If not otherwise determined, defer to a fuzz of +/-(interval / 2).
Gilad Arnold38b14022014-07-09 12:45:56 -0700571 if (fuzz == 0)
572 fuzz = interval;
573
Alex Deymo0d11c602014-04-23 20:12:20 -0700574 *next_update_check = *last_checked_time + FuzzedInterval(
Gilad Arnold38b14022014-07-09 12:45:56 -0700575 &prng, interval, fuzz);
Alex Deymo0d11c602014-04-23 20:12:20 -0700576 return EvalStatus::kSucceeded;
577}
578
579TimeDelta ChromeOSPolicy::FuzzedInterval(PRNG* prng, int interval, int fuzz) {
Gilad Arnolde1218812014-05-07 12:21:36 -0700580 DCHECK_GE(interval, 0);
581 DCHECK_GE(fuzz, 0);
Alex Deymo0d11c602014-04-23 20:12:20 -0700582 int half_fuzz = fuzz / 2;
Alex Deymo0d11c602014-04-23 20:12:20 -0700583 // This guarantees the output interval is non negative.
Gilad Arnoldb3b05442014-05-30 14:25:05 -0700584 int interval_min = max(interval - half_fuzz, 0);
Gilad Arnolde1218812014-05-07 12:21:36 -0700585 int interval_max = interval + half_fuzz;
586 return TimeDelta::FromSeconds(prng->RandMinMax(interval_min, interval_max));
Alex Deymo0d11c602014-04-23 20:12:20 -0700587}
588
Gilad Arnolddc4bb262014-07-23 10:45:19 -0700589EvalStatus ChromeOSPolicy::UpdateBackoffAndDownloadUrl(
Alex Deymof329b932014-10-30 01:37:48 -0700590 EvaluationContext* ec, State* state, string* error,
Gilad Arnolddc4bb262014-07-23 10:45:19 -0700591 UpdateBackoffAndDownloadUrlResult* result,
592 const UpdateState& update_state) const {
593 // Sanity checks.
594 DCHECK_GE(update_state.download_errors_max, 0);
595
596 // Set default result values.
597 result->do_increment_failures = false;
598 result->backoff_expiry = update_state.backoff_expiry;
599 result->url_idx = -1;
600 result->url_num_errors = 0;
601
602 const bool* is_official_build_p = ec->GetValue(
603 state->system_provider()->var_is_official_build());
604 bool is_official_build = (is_official_build_p ? *is_official_build_p : true);
605
606 // Check whether backoff is enabled.
607 bool may_backoff = false;
608 if (update_state.is_backoff_disabled) {
609 LOG(INFO) << "Backoff disabled by Omaha.";
610 } else if (update_state.is_interactive) {
611 LOG(INFO) << "No backoff for interactive updates.";
612 } else if (update_state.is_delta_payload) {
613 LOG(INFO) << "No backoff for delta payloads.";
614 } else if (!is_official_build) {
615 LOG(INFO) << "No backoff for unofficial builds.";
616 } else {
617 may_backoff = true;
Gilad Arnoldb3b05442014-05-30 14:25:05 -0700618 }
619
Gilad Arnolddc4bb262014-07-23 10:45:19 -0700620 // If previous backoff still in effect, block.
621 if (may_backoff && !update_state.backoff_expiry.is_null() &&
622 !ec->IsWallclockTimeGreaterThan(update_state.backoff_expiry)) {
623 LOG(INFO) << "Previous backoff has not expired, waiting.";
624 return EvalStatus::kAskMeAgainLater;
625 }
Gilad Arnoldb3b05442014-05-30 14:25:05 -0700626
627 // Determine whether HTTP downloads are forbidden by policy. This only
628 // applies to official system builds; otherwise, HTTP is always enabled.
629 bool http_allowed = true;
Gilad Arnolddc4bb262014-07-23 10:45:19 -0700630 if (is_official_build) {
Gilad Arnoldb3b05442014-05-30 14:25:05 -0700631 DevicePolicyProvider* const dp_provider = state->device_policy_provider();
632 const bool* device_policy_is_loaded_p = ec->GetValue(
633 dp_provider->var_device_policy_is_loaded());
634 if (device_policy_is_loaded_p && *device_policy_is_loaded_p) {
635 const bool* policy_http_downloads_enabled_p = ec->GetValue(
636 dp_provider->var_http_downloads_enabled());
637 http_allowed = (!policy_http_downloads_enabled_p ||
638 *policy_http_downloads_enabled_p);
639 }
640 }
641
Gilad Arnolddc4bb262014-07-23 10:45:19 -0700642 int url_idx = update_state.last_download_url_idx;
643 if (url_idx < 0)
644 url_idx = -1;
645 bool do_advance_url = false;
646 bool is_failure_occurred = false;
647 Time err_time;
648
649 // Scan the relevant part of the download error log, tracking which URLs are
650 // being used, and accounting the number of errors for each URL. Note that
651 // this process may not traverse all errors provided, as it may decide to bail
652 // out midway depending on the particular errors exhibited, the number of
653 // failures allowed, etc. When this ends, |url_idx| will point to the last URL
654 // used (-1 if starting fresh), |do_advance_url| will determine whether the
655 // URL needs to be advanced, and |err_time| the point in time when the last
656 // reported error occurred. Additionally, if the error log indicates that an
657 // update attempt has failed (abnormal), then |is_failure_occurred| will be
658 // set to true.
659 const int num_urls = update_state.download_urls.size();
660 int prev_url_idx = -1;
661 int url_num_errors = update_state.last_download_url_num_errors;
662 Time prev_err_time;
663 bool is_first = true;
664 for (const auto& err_tuple : update_state.download_errors) {
665 // Do some sanity checks.
666 int used_url_idx = get<0>(err_tuple);
667 if (is_first && url_idx >= 0 && used_url_idx != url_idx) {
668 LOG(WARNING) << "First URL in error log (" << used_url_idx
669 << ") not as expected (" << url_idx << ")";
Gilad Arnoldb3b05442014-05-30 14:25:05 -0700670 }
Gilad Arnolddc4bb262014-07-23 10:45:19 -0700671 is_first = false;
672 url_idx = used_url_idx;
673 if (url_idx < 0 || url_idx >= num_urls) {
674 LOG(ERROR) << "Download error log contains an invalid URL index ("
675 << url_idx << ")";
676 return EvalStatus::kFailed;
677 }
678 err_time = get<2>(err_tuple);
679 if (!(prev_err_time.is_null() || err_time >= prev_err_time)) {
680 // TODO(garnold) Monotonicity cannot really be assumed when dealing with
681 // wallclock-based timestamps. However, we're making a simplifying
682 // assumption so as to keep the policy implementation straightforward, for
683 // now. In general, we should convert all timestamp handling in the
684 // UpdateManager to use monotonic time (instead of wallclock), including
685 // the computation of various expiration times (backoff, scattering, etc).
686 // The client will do whatever conversions necessary when
687 // persisting/retrieving these values across reboots. See chromium:408794.
688 LOG(ERROR) << "Download error timestamps not monotonically increasing.";
689 return EvalStatus::kFailed;
690 }
691 prev_err_time = err_time;
Gilad Arnoldb3b05442014-05-30 14:25:05 -0700692
Gilad Arnolddc4bb262014-07-23 10:45:19 -0700693 // Ignore errors that happened before the last known failed attempt.
694 if (!update_state.failures_last_updated.is_null() &&
695 err_time <= update_state.failures_last_updated)
696 continue;
697
698 if (prev_url_idx >= 0) {
699 if (url_idx < prev_url_idx) {
700 LOG(ERROR) << "The URLs in the download error log have wrapped around ("
701 << prev_url_idx << "->" << url_idx
702 << "). This should not have happened and means that there's "
703 "a bug. To be conservative, we record a failed attempt "
704 "(invalidating the rest of the error log) and resume "
705 "download from the first usable URL.";
706 url_idx = -1;
707 is_failure_occurred = true;
708 break;
709 }
710
711 if (url_idx > prev_url_idx) {
712 url_num_errors = 0;
713 do_advance_url = false;
714 }
715 }
716
717 if (HandleErrorCode(get<1>(err_tuple), &url_num_errors) ||
718 url_num_errors > update_state.download_errors_max)
719 do_advance_url = true;
720
721 prev_url_idx = url_idx;
Gilad Arnoldb3b05442014-05-30 14:25:05 -0700722 }
723
Gilad Arnolddc4bb262014-07-23 10:45:19 -0700724 // If required, advance to the next usable URL. If the URLs wraparound, we
725 // mark an update attempt failure. Also be sure to set the download error
726 // count to zero.
727 if (url_idx < 0 || do_advance_url) {
728 url_num_errors = 0;
729 int start_url_idx = -1;
730 do {
731 if (++url_idx == num_urls) {
732 url_idx = 0;
733 // We only mark failure if an actual advancing of a URL was required.
734 if (do_advance_url)
735 is_failure_occurred = true;
736 }
737
738 if (start_url_idx < 0)
739 start_url_idx = url_idx;
740 else if (url_idx == start_url_idx)
741 url_idx = -1; // No usable URL.
742 } while (url_idx >= 0 &&
743 !IsUrlUsable(update_state.download_urls[url_idx], http_allowed));
744 }
745
746 // If we have a download URL but a failure was observed, compute a new backoff
747 // expiry (if allowed). The backoff period is generally 2 ^ (num_failures - 1)
748 // days, bounded by the size of int and kAttemptBackoffMaxIntervalInDays, and
749 // fuzzed by kAttemptBackoffFuzzInHours hours. Backoff expiry is computed from
750 // the latest recorded time of error.
751 Time backoff_expiry;
752 if (url_idx >= 0 && is_failure_occurred && may_backoff) {
753 CHECK(!err_time.is_null())
754 << "We must have an error timestamp if a failure occurred!";
755 const uint64_t* seed = ec->GetValue(state->random_provider()->var_seed());
756 POLICY_CHECK_VALUE_AND_FAIL(seed, error);
757 PRNG prng(*seed);
Alex Deymof329b932014-10-30 01:37:48 -0700758 int exp = min(update_state.num_failures,
Gilad Arnolddc4bb262014-07-23 10:45:19 -0700759 static_cast<int>(sizeof(int)) * 8 - 2);
760 TimeDelta backoff_interval = TimeDelta::FromDays(
Alex Deymof329b932014-10-30 01:37:48 -0700761 min(1 << exp, kAttemptBackoffMaxIntervalInDays));
Gilad Arnolddc4bb262014-07-23 10:45:19 -0700762 TimeDelta backoff_fuzz = TimeDelta::FromHours(kAttemptBackoffFuzzInHours);
763 TimeDelta wait_period = FuzzedInterval(&prng, backoff_interval.InSeconds(),
764 backoff_fuzz.InSeconds());
765 backoff_expiry = err_time + wait_period;
766
767 // If the newly computed backoff already expired, nullify it.
768 if (ec->IsWallclockTimeGreaterThan(backoff_expiry))
769 backoff_expiry = Time();
770 }
771
772 result->do_increment_failures = is_failure_occurred;
773 result->backoff_expiry = backoff_expiry;
Gilad Arnoldb3b05442014-05-30 14:25:05 -0700774 result->url_idx = url_idx;
Gilad Arnolddc4bb262014-07-23 10:45:19 -0700775 result->url_num_errors = url_num_errors;
Gilad Arnoldb3b05442014-05-30 14:25:05 -0700776 return EvalStatus::kSucceeded;
777}
778
Gilad Arnoldf62a4b82014-05-01 07:41:07 -0700779EvalStatus ChromeOSPolicy::UpdateScattering(
780 EvaluationContext* ec,
781 State* state,
782 string* error,
783 UpdateScatteringResult* result,
784 const UpdateState& update_state) const {
785 // Preconditions. These stem from the postconditions and usage contract.
786 DCHECK(update_state.scatter_wait_period >= kZeroInterval);
787 DCHECK_GE(update_state.scatter_check_threshold, 0);
788
789 // Set default result values.
790 result->is_scattering = false;
791 result->wait_period = kZeroInterval;
792 result->check_threshold = 0;
793
794 DevicePolicyProvider* const dp_provider = state->device_policy_provider();
795
796 // Ensure that a device policy is loaded.
797 const bool* device_policy_is_loaded_p = ec->GetValue(
798 dp_provider->var_device_policy_is_loaded());
799 if (!(device_policy_is_loaded_p && *device_policy_is_loaded_p))
800 return EvalStatus::kSucceeded;
801
802 // Is scattering enabled by policy?
803 const TimeDelta* scatter_factor_p = ec->GetValue(
804 dp_provider->var_scatter_factor());
805 if (!scatter_factor_p || *scatter_factor_p == kZeroInterval)
806 return EvalStatus::kSucceeded;
807
808 // Obtain a pseudo-random number generator.
809 const uint64_t* seed = ec->GetValue(state->random_provider()->var_seed());
810 POLICY_CHECK_VALUE_AND_FAIL(seed, error);
811 PRNG prng(*seed);
812
813 // Step 1: Maintain the scattering wait period.
814 //
815 // If no wait period was previously determined, or it no longer fits in the
816 // scatter factor, then generate a new one. Otherwise, keep the one we have.
Gilad Arnoldf62a4b82014-05-01 07:41:07 -0700817 TimeDelta wait_period = update_state.scatter_wait_period;
818 if (wait_period == kZeroInterval || wait_period > *scatter_factor_p) {
819 wait_period = TimeDelta::FromSeconds(
820 prng.RandMinMax(1, scatter_factor_p->InSeconds()));
821 }
822
Gilad Arnolddc4bb262014-07-23 10:45:19 -0700823 // If we surpassed the wait period or the max scatter period associated with
Gilad Arnoldf62a4b82014-05-01 07:41:07 -0700824 // the update, then no wait is needed.
825 Time wait_expires = (update_state.first_seen +
826 min(wait_period, update_state.scatter_wait_period_max));
Gilad Arnolda65fced2014-07-23 09:01:31 -0700827 if (ec->IsWallclockTimeGreaterThan(wait_expires))
Gilad Arnoldf62a4b82014-05-01 07:41:07 -0700828 wait_period = kZeroInterval;
829
830 // Step 2: Maintain the update check threshold count.
831 //
832 // If an update check threshold is not specified then generate a new
833 // one.
834 int check_threshold = update_state.scatter_check_threshold;
835 if (check_threshold == 0) {
836 check_threshold = prng.RandMinMax(
837 update_state.scatter_check_threshold_min,
838 update_state.scatter_check_threshold_max);
839 }
840
841 // If the update check threshold is not within allowed range then nullify it.
842 // TODO(garnold) This is compliant with current logic found in
843 // OmahaRequestAction::IsUpdateCheckCountBasedWaitingSatisfied(). We may want
844 // to change it so that it behaves similarly to the wait period case, namely
845 // if the current value exceeds the maximum, we set a new one within range.
846 if (check_threshold > update_state.scatter_check_threshold_max)
847 check_threshold = 0;
848
849 // If the update check threshold is non-zero and satisfied, then nullify it.
850 if (check_threshold > 0 && update_state.num_checks >= check_threshold)
851 check_threshold = 0;
852
853 bool is_scattering = (wait_period != kZeroInterval || check_threshold);
854 EvalStatus ret = EvalStatus::kSucceeded;
855 if (is_scattering && wait_period == update_state.scatter_wait_period &&
856 check_threshold == update_state.scatter_check_threshold)
857 ret = EvalStatus::kAskMeAgainLater;
858 result->is_scattering = is_scattering;
859 result->wait_period = wait_period;
860 result->check_threshold = check_threshold;
861 return ret;
862}
863
Alex Deymo63784a52014-05-28 10:46:14 -0700864} // namespace chromeos_update_manager