blob: 02679531954dc89b4fea10e19e6e320b0f0ebdfc [file] [log] [blame]
Alex Deymoaea4c1c2015-08-19 20:24:43 -07001//
2// Copyright (C) 2012 The Android Open Source Project
3//
4// Licensed under the Apache License, Version 2.0 (the "License");
5// you may not use this file except in compliance with the License.
6// You may obtain a copy of the License at
7//
8// http://www.apache.org/licenses/LICENSE-2.0
9//
10// Unless required by applicable law or agreed to in writing, software
11// distributed under the License is distributed on an "AS IS" BASIS,
12// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
13// See the License for the specific language governing permissions and
14// limitations under the License.
15//
Darin Petkovf42cc1c2010-09-01 09:03:02 -070016
Alex Deymo2c0db7b2014-11-04 12:23:39 -080017#include "update_engine/update_attempter.h"
18
Ben Chan9abb7632014-08-07 00:10:53 -070019#include <stdint.h>
20
Ben Chan02f7c1d2014-10-18 15:18:02 -070021#include <memory>
22
Ben Chan06c76a42014-09-05 08:21:06 -070023#include <base/files/file_util.h>
Alex Deymo0b3db6b2015-08-10 15:19:37 -070024#include <base/message_loop/message_loop.h>
Amin Hassani71818c82018-03-06 13:25:40 -080025#include <brillo/bind_lambda.h>
Alex Vakulenko3f39d5c2015-10-13 09:27:13 -070026#include <brillo/message_loops/base_message_loop.h>
27#include <brillo/message_loops/message_loop.h>
28#include <brillo/message_loops/message_loop_utils.h>
Darin Petkovf42cc1c2010-09-01 09:03:02 -070029#include <gtest/gtest.h>
Patrick Dubroy7fbbe8a2011-08-01 17:28:22 +020030#include <policy/libpolicy.h>
31#include <policy/mock_device_policy.h>
Marton Hunyadye58bddb2018-04-10 20:27:26 +020032#include <policy/mock_libpolicy.h>
Darin Petkovf42cc1c2010-09-01 09:03:02 -070033
Alex Deymo39910dc2015-11-09 17:04:30 -080034#include "update_engine/common/fake_clock.h"
35#include "update_engine/common/fake_prefs.h"
Alex Deymo14fd1ec2016-02-24 22:03:57 -080036#include "update_engine/common/mock_action.h"
37#include "update_engine/common/mock_action_processor.h"
Alex Deymo39910dc2015-11-09 17:04:30 -080038#include "update_engine/common/mock_http_fetcher.h"
39#include "update_engine/common/mock_prefs.h"
40#include "update_engine/common/platform_constants.h"
41#include "update_engine/common/prefs.h"
42#include "update_engine/common/test_utils.h"
43#include "update_engine/common/utils.h"
Gilad Arnold5bb4c902014-04-10 12:32:13 -070044#include "update_engine/fake_system_state.h"
David Zeuthen8f191b22013-08-06 12:27:50 -070045#include "update_engine/mock_p2p_manager.h"
Jay Srinivasan6f6ea002012-12-14 11:26:28 -080046#include "update_engine/mock_payload_state.h"
Aaron Wood9321f502017-09-07 11:18:54 -070047#include "update_engine/mock_service_observer.h"
Alex Deymo39910dc2015-11-09 17:04:30 -080048#include "update_engine/payload_consumer/filesystem_verifier_action.h"
49#include "update_engine/payload_consumer/install_plan.h"
50#include "update_engine/payload_consumer/payload_constants.h"
51#include "update_engine/payload_consumer/postinstall_runner_action.h"
Amin Hassani0882a512018-04-05 16:25:44 -070052#include "update_engine/update_boot_flags_action.h"
Darin Petkovf42cc1c2010-09-01 09:03:02 -070053
David Zeuthen985b1122013-10-09 12:13:15 -070054using base::Time;
55using base::TimeDelta;
Aaron Woodbf5a2522017-10-04 10:58:36 -070056using chromeos_update_manager::EvalStatus;
57using chromeos_update_manager::UpdateCheckParams;
Darin Petkovf42cc1c2010-09-01 09:03:02 -070058using std::string;
Ben Chan02f7c1d2014-10-18 15:18:02 -070059using std::unique_ptr;
Aaron Woodbf5a2522017-10-04 10:58:36 -070060using testing::_;
Darin Petkov36275772010-10-01 11:40:57 -070061using testing::DoAll;
Aaron Wood7f92e2b2017-08-28 14:51:21 -070062using testing::Field;
Darin Petkovf42cc1c2010-09-01 09:03:02 -070063using testing::InSequence;
Darin Petkov2dd01092010-10-08 15:43:05 -070064using testing::Ne;
Darin Petkov9c096d62010-11-17 14:49:04 -080065using testing::NiceMock;
Amin Hassanid3f4bea2018-04-30 14:52:40 -070066using testing::Pointee;
Darin Petkovf42cc1c2010-09-01 09:03:02 -070067using testing::Property;
68using testing::Return;
Gilad Arnold74b5f552014-10-07 08:17:16 -070069using testing::ReturnPointee;
Marton Hunyadye58bddb2018-04-10 20:27:26 +020070using testing::ReturnRef;
Alex Deymo2c0db7b2014-11-04 12:23:39 -080071using testing::SaveArg;
Ben Chan672c1f52017-10-23 15:41:39 -070072using testing::SetArgPointee;
Aaron Woodbf5a2522017-10-04 10:58:36 -070073using update_engine::UpdateAttemptFlags;
Aaron Wood7f92e2b2017-08-28 14:51:21 -070074using update_engine::UpdateEngineStatus;
Christopher Wiley6b6cc1b2015-10-05 17:50:07 -070075using update_engine::UpdateStatus;
Darin Petkovf42cc1c2010-09-01 09:03:02 -070076
77namespace chromeos_update_engine {
78
Marton Hunyadya0302682018-05-16 18:52:13 +020079const char kRollbackVersion[] = "10575.39.2";
80
Darin Petkovf42cc1c2010-09-01 09:03:02 -070081// Test a subclass rather than the main class directly so that we can mock out
Darin Petkovcd1666f2010-09-23 09:53:44 -070082// methods within the class. There're explicit unit tests for the mocked out
Darin Petkovf42cc1c2010-09-01 09:03:02 -070083// methods.
84class UpdateAttempterUnderTest : public UpdateAttempter {
85 public:
Jeffrey Kardatzkecf5f1f12017-10-02 16:08:44 -070086 explicit UpdateAttempterUnderTest(SystemState* system_state)
87 : UpdateAttempter(system_state, nullptr) {}
Gilad Arnoldec7f9162014-07-15 13:24:46 -070088
89 // Wrap the update scheduling method, allowing us to opt out of scheduled
90 // updates for testing purposes.
91 void ScheduleUpdates() override {
92 schedule_updates_called_ = true;
93 if (do_schedule_updates_) {
94 UpdateAttempter::ScheduleUpdates();
95 } else {
96 LOG(INFO) << "[TEST] Update scheduling disabled.";
97 }
98 }
99 void EnableScheduleUpdates() { do_schedule_updates_ = true; }
100 void DisableScheduleUpdates() { do_schedule_updates_ = false; }
101
102 // Indicates whether ScheduleUpdates() was called.
103 bool schedule_updates_called() const { return schedule_updates_called_; }
104
David Pursell02c18642014-11-06 11:26:11 -0800105 // Need to expose forced_omaha_url_ so we can test it.
Alex Deymo60ca1a72015-06-18 18:19:15 -0700106 const string& forced_omaha_url() const { return forced_omaha_url_; }
David Pursell02c18642014-11-06 11:26:11 -0800107
Gilad Arnoldec7f9162014-07-15 13:24:46 -0700108 private:
109 bool schedule_updates_called_ = false;
110 bool do_schedule_updates_ = true;
Darin Petkovf42cc1c2010-09-01 09:03:02 -0700111};
112
113class UpdateAttempterTest : public ::testing::Test {
114 protected:
Jay Srinivasan43488792012-06-19 00:25:31 -0700115 UpdateAttempterTest()
Daniel Erate5f6f252017-04-20 12:09:58 -0600116 : certificate_checker_(fake_system_state_.mock_prefs(),
Alex Deymo33e91e72015-12-01 18:26:08 -0300117 &openssl_wrapper_) {
Gilad Arnold1f847232014-04-07 12:07:49 -0700118 // Override system state members.
Gilad Arnold5bb4c902014-04-10 12:32:13 -0700119 fake_system_state_.set_connection_manager(&mock_connection_manager);
120 fake_system_state_.set_update_attempter(&attempter_);
Alex Deymo60ca1a72015-06-18 18:19:15 -0700121 loop_.SetAsCurrent();
Gilad Arnold1f847232014-04-07 12:07:49 -0700122
Alex Deymo33e91e72015-12-01 18:26:08 -0300123 certificate_checker_.Init();
124
Sen Jiange67bb5b2016-06-20 15:53:56 -0700125 // Finish initializing the attempter.
Gilad Arnold1f847232014-04-07 12:07:49 -0700126 attempter_.Init();
Jay Srinivasan43488792012-06-19 00:25:31 -0700127 }
Gilad Arnoldeff87cc2013-07-22 18:32:09 -0700128
Alex Deymo610277e2014-11-11 21:18:11 -0800129 void SetUp() override {
Alex Vakulenko88b591f2014-08-28 16:48:57 -0700130 EXPECT_NE(nullptr, attempter_.system_state_);
Darin Petkovf42cc1c2010-09-01 09:03:02 -0700131 EXPECT_EQ(0, attempter_.http_response_code_);
Christopher Wiley6b6cc1b2015-10-05 17:50:07 -0700132 EXPECT_EQ(UpdateStatus::IDLE, attempter_.status_);
Darin Petkovf42cc1c2010-09-01 09:03:02 -0700133 EXPECT_EQ(0.0, attempter_.download_progress_);
134 EXPECT_EQ(0, attempter_.last_checked_time_);
135 EXPECT_EQ("0.0.0.0", attempter_.new_version_);
Aaron Wood7f92e2b2017-08-28 14:51:21 -0700136 EXPECT_EQ(0ULL, attempter_.new_payload_size_);
Alex Deymo8427b4a2014-11-05 14:00:32 -0800137 processor_ = new NiceMock<MockActionProcessor>();
Darin Petkovf42cc1c2010-09-01 09:03:02 -0700138 attempter_.processor_.reset(processor_); // Transfers ownership.
Gilad Arnold5bb4c902014-04-10 12:32:13 -0700139 prefs_ = fake_system_state_.mock_prefs();
Gilad Arnold74b5f552014-10-07 08:17:16 -0700140
141 // Set up store/load semantics of P2P properties via the mock PayloadState.
142 actual_using_p2p_for_downloading_ = false;
143 EXPECT_CALL(*fake_system_state_.mock_payload_state(),
144 SetUsingP2PForDownloading(_))
145 .WillRepeatedly(SaveArg<0>(&actual_using_p2p_for_downloading_));
146 EXPECT_CALL(*fake_system_state_.mock_payload_state(),
147 GetUsingP2PForDownloading())
148 .WillRepeatedly(ReturnPointee(&actual_using_p2p_for_downloading_));
149 actual_using_p2p_for_sharing_ = false;
150 EXPECT_CALL(*fake_system_state_.mock_payload_state(),
151 SetUsingP2PForSharing(_))
152 .WillRepeatedly(SaveArg<0>(&actual_using_p2p_for_sharing_));
153 EXPECT_CALL(*fake_system_state_.mock_payload_state(),
154 GetUsingP2PForDownloading())
155 .WillRepeatedly(ReturnPointee(&actual_using_p2p_for_sharing_));
Darin Petkovf42cc1c2010-09-01 09:03:02 -0700156 }
157
Alex Deymo60ca1a72015-06-18 18:19:15 -0700158 public:
159 void ScheduleQuitMainLoop();
Patrick Dubroy7fbbe8a2011-08-01 17:28:22 +0200160
Alex Deymo60ca1a72015-06-18 18:19:15 -0700161 // Callbacks to run the different tests from the main loop.
Darin Petkove6ef2f82011-03-07 17:31:11 -0800162 void UpdateTestStart();
163 void UpdateTestVerify();
Alex Deymo60ca1a72015-06-18 18:19:15 -0700164 void RollbackTestStart(bool enterprise_rollback, bool valid_slot);
Chris Sosa76a29ae2013-07-11 17:59:24 -0700165 void RollbackTestVerify();
Thieu Le116fda32011-04-19 11:01:54 -0700166 void PingOmahaTestStart();
Jay Srinivasan480ddfa2012-06-01 19:15:26 -0700167 void ReadScatterFactorFromPolicyTestStart();
Jay Srinivasan480ddfa2012-06-01 19:15:26 -0700168 void DecrementUpdateCheckCountTestStart();
Jay Srinivasan08fce042012-06-07 16:31:01 -0700169 void NoScatteringDoneDuringManualUpdateTestStart();
David Zeuthen8f191b22013-08-06 12:27:50 -0700170 void P2PNotEnabledStart();
David Zeuthen8f191b22013-08-06 12:27:50 -0700171 void P2PEnabledStart();
David Zeuthen8f191b22013-08-06 12:27:50 -0700172 void P2PEnabledInteractiveStart();
David Zeuthen8f191b22013-08-06 12:27:50 -0700173 void P2PEnabledStartingFailsStart();
David Zeuthen8f191b22013-08-06 12:27:50 -0700174 void P2PEnabledHousekeepingFailsStart();
Marton Hunyadye58bddb2018-04-10 20:27:26 +0200175 void ResetRollbackHappenedStart(bool is_consumer,
176 bool is_policy_available,
177 bool expected_reset);
David Zeuthen8f191b22013-08-06 12:27:50 -0700178
Gilad Arnold74b5f552014-10-07 08:17:16 -0700179 bool actual_using_p2p_for_downloading() {
180 return actual_using_p2p_for_downloading_;
181 }
182 bool actual_using_p2p_for_sharing() {
183 return actual_using_p2p_for_sharing_;
184 }
185
Alex Deymo0b3db6b2015-08-10 15:19:37 -0700186 base::MessageLoopForIO base_loop_;
Alex Vakulenko3f39d5c2015-10-13 09:27:13 -0700187 brillo::BaseMessageLoop loop_{&base_loop_};
Alex Deymo60ca1a72015-06-18 18:19:15 -0700188
Gilad Arnold5bb4c902014-04-10 12:32:13 -0700189 FakeSystemState fake_system_state_;
Jeffrey Kardatzkecf5f1f12017-10-02 16:08:44 -0700190 UpdateAttempterUnderTest attempter_{&fake_system_state_};
Alex Deymo33e91e72015-12-01 18:26:08 -0300191 OpenSSLWrapper openssl_wrapper_;
192 CertificateChecker certificate_checker_;
Alex Deymo30534502015-07-20 15:06:33 -0700193
Alex Deymo8427b4a2014-11-05 14:00:32 -0800194 NiceMock<MockActionProcessor>* processor_;
195 NiceMock<MockPrefs>* prefs_; // Shortcut to fake_system_state_->mock_prefs().
Jay Srinivasan55f50c22013-01-10 19:24:35 -0800196 NiceMock<MockConnectionManager> mock_connection_manager;
Gilad Arnoldeff87cc2013-07-22 18:32:09 -0700197
Gilad Arnold74b5f552014-10-07 08:17:16 -0700198 bool actual_using_p2p_for_downloading_;
199 bool actual_using_p2p_for_sharing_;
Darin Petkovf42cc1c2010-09-01 09:03:02 -0700200};
201
Alex Deymo60ca1a72015-06-18 18:19:15 -0700202void UpdateAttempterTest::ScheduleQuitMainLoop() {
Luis Hector Chavezf1cf3482016-07-19 14:29:19 -0700203 loop_.PostTask(
204 FROM_HERE,
205 base::Bind([](brillo::BaseMessageLoop* loop) { loop->BreakLoop(); },
206 base::Unretained(&loop_)));
Alex Deymo60ca1a72015-06-18 18:19:15 -0700207}
208
Darin Petkov1b003102010-11-30 10:18:36 -0800209TEST_F(UpdateAttempterTest, ActionCompletedDownloadTest) {
Ben Chan02f7c1d2014-10-18 15:18:02 -0700210 unique_ptr<MockHttpFetcher> fetcher(new MockHttpFetcher("", 0, nullptr));
Darin Petkov1b003102010-11-30 10:18:36 -0800211 fetcher->FailTransfer(503); // Sets the HTTP response code.
Amin Hassani7ecda262017-07-11 17:10:50 -0700212 DownloadAction action(prefs_,
213 nullptr,
214 nullptr,
215 nullptr,
216 fetcher.release(),
Amin Hassanied37d682018-04-06 13:22:00 -0700217 false /* interactive */);
Jay Srinivasan6f6ea002012-12-14 11:26:28 -0800218 EXPECT_CALL(*prefs_, GetInt64(kPrefsDeltaUpdateFailures, _)).Times(0);
Alex Vakulenko88b591f2014-08-28 16:48:57 -0700219 attempter_.ActionCompleted(nullptr, &action, ErrorCode::kSuccess);
Christopher Wiley6b6cc1b2015-10-05 17:50:07 -0700220 EXPECT_EQ(UpdateStatus::FINALIZING, attempter_.status());
Aaron Wood9321f502017-09-07 11:18:54 -0700221 EXPECT_EQ(0.0, attempter_.download_progress_);
Alex Vakulenko88b591f2014-08-28 16:48:57 -0700222 ASSERT_EQ(nullptr, attempter_.error_event_.get());
Darin Petkov1b003102010-11-30 10:18:36 -0800223}
224
225TEST_F(UpdateAttempterTest, ActionCompletedErrorTest) {
Alex Deymo8427b4a2014-11-05 14:00:32 -0800226 MockAction action;
227 EXPECT_CALL(action, Type()).WillRepeatedly(Return("MockAction"));
Christopher Wiley6b6cc1b2015-10-05 17:50:07 -0700228 attempter_.status_ = UpdateStatus::DOWNLOADING;
Jay Srinivasan6f6ea002012-12-14 11:26:28 -0800229 EXPECT_CALL(*prefs_, GetInt64(kPrefsDeltaUpdateFailures, _))
Darin Petkov1b003102010-11-30 10:18:36 -0800230 .WillOnce(Return(false));
Alex Vakulenko88b591f2014-08-28 16:48:57 -0700231 attempter_.ActionCompleted(nullptr, &action, ErrorCode::kError);
232 ASSERT_NE(nullptr, attempter_.error_event_.get());
Darin Petkov1b003102010-11-30 10:18:36 -0800233}
234
Aaron Wood9321f502017-09-07 11:18:54 -0700235TEST_F(UpdateAttempterTest, DownloadProgressAccumulationTest) {
236 // Simple test case, where all the values match (nothing was skipped)
237 uint64_t bytes_progressed_1 = 1024 * 1024; // 1MB
238 uint64_t bytes_progressed_2 = 1024 * 1024; // 1MB
239 uint64_t bytes_received_1 = bytes_progressed_1;
240 uint64_t bytes_received_2 = bytes_received_1 + bytes_progressed_2;
241 uint64_t bytes_total = 20 * 1024 * 1024; // 20MB
242
243 double progress_1 =
244 static_cast<double>(bytes_received_1) / static_cast<double>(bytes_total);
245 double progress_2 =
246 static_cast<double>(bytes_received_2) / static_cast<double>(bytes_total);
247
248 EXPECT_EQ(0.0, attempter_.download_progress_);
249 // This is set via inspecting the InstallPlan payloads when the
250 // OmahaResponseAction is completed
251 attempter_.new_payload_size_ = bytes_total;
252 NiceMock<MockServiceObserver> observer;
253 EXPECT_CALL(observer,
Aaron Wood7f92e2b2017-08-28 14:51:21 -0700254 SendStatusUpdate(AllOf(
255 Field(&UpdateEngineStatus::progress, progress_1),
256 Field(&UpdateEngineStatus::status, UpdateStatus::DOWNLOADING),
257 Field(&UpdateEngineStatus::new_size_bytes, bytes_total))));
Aaron Wood9321f502017-09-07 11:18:54 -0700258 EXPECT_CALL(observer,
Aaron Wood7f92e2b2017-08-28 14:51:21 -0700259 SendStatusUpdate(AllOf(
260 Field(&UpdateEngineStatus::progress, progress_2),
261 Field(&UpdateEngineStatus::status, UpdateStatus::DOWNLOADING),
262 Field(&UpdateEngineStatus::new_size_bytes, bytes_total))));
Aaron Wood9321f502017-09-07 11:18:54 -0700263 attempter_.AddObserver(&observer);
264 attempter_.BytesReceived(bytes_progressed_1, bytes_received_1, bytes_total);
265 EXPECT_EQ(progress_1, attempter_.download_progress_);
266 // This iteration validates that a later set of updates to the variables are
267 // properly handled (so that |getStatus()| will return the same progress info
268 // as the callback is receiving.
269 attempter_.BytesReceived(bytes_progressed_2, bytes_received_2, bytes_total);
270 EXPECT_EQ(progress_2, attempter_.download_progress_);
271}
272
273TEST_F(UpdateAttempterTest, ChangeToDownloadingOnReceivedBytesTest) {
274 // The transition into UpdateStatus::DOWNLOADING happens when the
275 // first bytes are received.
276 uint64_t bytes_progressed = 1024 * 1024; // 1MB
277 uint64_t bytes_received = 2 * 1024 * 1024; // 2MB
278 uint64_t bytes_total = 20 * 1024 * 1024; // 300MB
279 attempter_.status_ = UpdateStatus::CHECKING_FOR_UPDATE;
280 // This is set via inspecting the InstallPlan payloads when the
281 // OmahaResponseAction is completed
282 attempter_.new_payload_size_ = bytes_total;
283 EXPECT_EQ(0.0, attempter_.download_progress_);
284 NiceMock<MockServiceObserver> observer;
Aaron Wood7f92e2b2017-08-28 14:51:21 -0700285 EXPECT_CALL(observer,
286 SendStatusUpdate(AllOf(
287 Field(&UpdateEngineStatus::status, UpdateStatus::DOWNLOADING),
288 Field(&UpdateEngineStatus::new_size_bytes, bytes_total))));
Aaron Wood9321f502017-09-07 11:18:54 -0700289 attempter_.AddObserver(&observer);
290 attempter_.BytesReceived(bytes_progressed, bytes_received, bytes_total);
291 EXPECT_EQ(UpdateStatus::DOWNLOADING, attempter_.status_);
292}
293
294TEST_F(UpdateAttempterTest, BroadcastCompleteDownloadTest) {
295 // There is a special case to ensure that at 100% downloaded,
296 // download_progress_ is updated and that value broadcast. This test confirms
297 // that.
298 uint64_t bytes_progressed = 0; // ignored
299 uint64_t bytes_received = 5 * 1024 * 1024; // ignored
300 uint64_t bytes_total = 5 * 1024 * 1024; // 300MB
301 attempter_.status_ = UpdateStatus::DOWNLOADING;
302 attempter_.new_payload_size_ = bytes_total;
303 EXPECT_EQ(0.0, attempter_.download_progress_);
304 NiceMock<MockServiceObserver> observer;
Aaron Wood7f92e2b2017-08-28 14:51:21 -0700305 EXPECT_CALL(observer,
306 SendStatusUpdate(AllOf(
307 Field(&UpdateEngineStatus::progress, 1.0),
308 Field(&UpdateEngineStatus::status, UpdateStatus::DOWNLOADING),
309 Field(&UpdateEngineStatus::new_size_bytes, bytes_total))));
Aaron Wood9321f502017-09-07 11:18:54 -0700310 attempter_.AddObserver(&observer);
311 attempter_.BytesReceived(bytes_progressed, bytes_received, bytes_total);
312 EXPECT_EQ(1.0, attempter_.download_progress_);
313}
314
Darin Petkov1b003102010-11-30 10:18:36 -0800315TEST_F(UpdateAttempterTest, ActionCompletedOmahaRequestTest) {
Ben Chan02f7c1d2014-10-18 15:18:02 -0700316 unique_ptr<MockHttpFetcher> fetcher(new MockHttpFetcher("", 0, nullptr));
Darin Petkov1b003102010-11-30 10:18:36 -0800317 fetcher->FailTransfer(500); // Sets the HTTP response code.
Alex Vakulenko88b591f2014-08-28 16:48:57 -0700318 OmahaRequestAction action(&fake_system_state_, nullptr,
Alex Deymoc1c17b42015-11-23 03:53:15 -0300319 std::move(fetcher), false);
Darin Petkov1b003102010-11-30 10:18:36 -0800320 ObjectCollectorAction<OmahaResponse> collector_action;
321 BondActions(&action, &collector_action);
322 OmahaResponse response;
323 response.poll_interval = 234;
324 action.SetOutputObject(response);
Jay Srinivasan6f6ea002012-12-14 11:26:28 -0800325 EXPECT_CALL(*prefs_, GetInt64(kPrefsDeltaUpdateFailures, _)).Times(0);
Alex Vakulenko88b591f2014-08-28 16:48:57 -0700326 attempter_.ActionCompleted(nullptr, &action, ErrorCode::kSuccess);
Darin Petkov1b003102010-11-30 10:18:36 -0800327 EXPECT_EQ(500, attempter_.http_response_code());
Christopher Wiley6b6cc1b2015-10-05 17:50:07 -0700328 EXPECT_EQ(UpdateStatus::IDLE, attempter_.status());
Alex Deymo80f70ff2016-02-10 16:08:11 -0800329 EXPECT_EQ(234U, attempter_.server_dictated_poll_interval_);
Alex Vakulenko88b591f2014-08-28 16:48:57 -0700330 ASSERT_TRUE(attempter_.error_event_.get() == nullptr);
Darin Petkov1b003102010-11-30 10:18:36 -0800331}
332
Alex Deymo30534502015-07-20 15:06:33 -0700333TEST_F(UpdateAttempterTest, ConstructWithUpdatedMarkerTest) {
Alex Deymo906191f2015-10-12 12:22:44 -0700334 FakePrefs fake_prefs;
335 string boot_id;
336 EXPECT_TRUE(utils::GetBootId(&boot_id));
337 fake_prefs.SetString(kPrefsUpdateCompletedOnBootId, boot_id);
338 fake_system_state_.set_prefs(&fake_prefs);
Sen Jiangaeeb2e02016-06-09 15:00:16 -0700339 attempter_.Init();
340 EXPECT_EQ(UpdateStatus::UPDATED_NEED_REBOOT, attempter_.status());
Darin Petkovf42cc1c2010-09-01 09:03:02 -0700341}
342
343TEST_F(UpdateAttempterTest, GetErrorCodeForActionTest) {
David Zeuthena99981f2013-04-29 13:42:47 -0700344 extern ErrorCode GetErrorCodeForAction(AbstractAction* action,
345 ErrorCode code);
Gilad Arnoldd1c4d2d2014-06-05 14:07:53 -0700346 EXPECT_EQ(ErrorCode::kSuccess,
Alex Vakulenko88b591f2014-08-28 16:48:57 -0700347 GetErrorCodeForAction(nullptr, ErrorCode::kSuccess));
Darin Petkovf42cc1c2010-09-01 09:03:02 -0700348
Gilad Arnold5bb4c902014-04-10 12:32:13 -0700349 FakeSystemState fake_system_state;
Alex Vakulenko88b591f2014-08-28 16:48:57 -0700350 OmahaRequestAction omaha_request_action(&fake_system_state, nullptr,
351 nullptr, false);
Gilad Arnoldd1c4d2d2014-06-05 14:07:53 -0700352 EXPECT_EQ(ErrorCode::kOmahaRequestError,
353 GetErrorCodeForAction(&omaha_request_action, ErrorCode::kError));
Gilad Arnold5bb4c902014-04-10 12:32:13 -0700354 OmahaResponseHandlerAction omaha_response_handler_action(&fake_system_state_);
Gilad Arnoldd1c4d2d2014-06-05 14:07:53 -0700355 EXPECT_EQ(ErrorCode::kOmahaResponseHandlerError,
Darin Petkovf42cc1c2010-09-01 09:03:02 -0700356 GetErrorCodeForAction(&omaha_response_handler_action,
Gilad Arnoldd1c4d2d2014-06-05 14:07:53 -0700357 ErrorCode::kError));
Sen Jiange6e4bb92016-04-05 14:59:12 -0700358 FilesystemVerifierAction filesystem_verifier_action;
Allie Woodeb9e6d82015-04-17 13:55:30 -0700359 EXPECT_EQ(ErrorCode::kFilesystemVerifierError,
360 GetErrorCodeForAction(&filesystem_verifier_action,
Gilad Arnoldd1c4d2d2014-06-05 14:07:53 -0700361 ErrorCode::kError));
Alex Deymob15a0b82015-11-25 20:30:40 -0300362 PostinstallRunnerAction postinstall_runner_action(
Alex Deymofb905d92016-06-03 19:26:58 -0700363 fake_system_state.fake_boot_control(), fake_system_state.fake_hardware());
Gilad Arnoldd1c4d2d2014-06-05 14:07:53 -0700364 EXPECT_EQ(ErrorCode::kPostinstallRunnerError,
Darin Petkovf42cc1c2010-09-01 09:03:02 -0700365 GetErrorCodeForAction(&postinstall_runner_action,
Gilad Arnoldd1c4d2d2014-06-05 14:07:53 -0700366 ErrorCode::kError));
Alex Deymo8427b4a2014-11-05 14:00:32 -0800367 MockAction action_mock;
368 EXPECT_CALL(action_mock, Type()).WillOnce(Return("MockAction"));
Gilad Arnoldd1c4d2d2014-06-05 14:07:53 -0700369 EXPECT_EQ(ErrorCode::kError,
370 GetErrorCodeForAction(&action_mock, ErrorCode::kError));
Darin Petkovf42cc1c2010-09-01 09:03:02 -0700371}
372
Darin Petkov36275772010-10-01 11:40:57 -0700373TEST_F(UpdateAttempterTest, DisableDeltaUpdateIfNeededTest) {
Jay Srinivasanae4697c2013-03-18 17:08:08 -0700374 attempter_.omaha_request_params_->set_delta_okay(true);
Jay Srinivasan6f6ea002012-12-14 11:26:28 -0800375 EXPECT_CALL(*prefs_, GetInt64(kPrefsDeltaUpdateFailures, _))
Darin Petkov36275772010-10-01 11:40:57 -0700376 .WillOnce(Return(false));
377 attempter_.DisableDeltaUpdateIfNeeded();
Jay Srinivasanae4697c2013-03-18 17:08:08 -0700378 EXPECT_TRUE(attempter_.omaha_request_params_->delta_okay());
Jay Srinivasan6f6ea002012-12-14 11:26:28 -0800379 EXPECT_CALL(*prefs_, GetInt64(kPrefsDeltaUpdateFailures, _))
Darin Petkov36275772010-10-01 11:40:57 -0700380 .WillOnce(DoAll(
Ben Chan672c1f52017-10-23 15:41:39 -0700381 SetArgPointee<1>(UpdateAttempter::kMaxDeltaUpdateFailures - 1),
Darin Petkov36275772010-10-01 11:40:57 -0700382 Return(true)));
383 attempter_.DisableDeltaUpdateIfNeeded();
Jay Srinivasanae4697c2013-03-18 17:08:08 -0700384 EXPECT_TRUE(attempter_.omaha_request_params_->delta_okay());
Jay Srinivasan6f6ea002012-12-14 11:26:28 -0800385 EXPECT_CALL(*prefs_, GetInt64(kPrefsDeltaUpdateFailures, _))
Darin Petkov36275772010-10-01 11:40:57 -0700386 .WillOnce(DoAll(
Ben Chan672c1f52017-10-23 15:41:39 -0700387 SetArgPointee<1>(UpdateAttempter::kMaxDeltaUpdateFailures),
Darin Petkov36275772010-10-01 11:40:57 -0700388 Return(true)));
389 attempter_.DisableDeltaUpdateIfNeeded();
Jay Srinivasanae4697c2013-03-18 17:08:08 -0700390 EXPECT_FALSE(attempter_.omaha_request_params_->delta_okay());
Jay Srinivasan6f6ea002012-12-14 11:26:28 -0800391 EXPECT_CALL(*prefs_, GetInt64(_, _)).Times(0);
Darin Petkov36275772010-10-01 11:40:57 -0700392 attempter_.DisableDeltaUpdateIfNeeded();
Jay Srinivasanae4697c2013-03-18 17:08:08 -0700393 EXPECT_FALSE(attempter_.omaha_request_params_->delta_okay());
Darin Petkov36275772010-10-01 11:40:57 -0700394}
395
396TEST_F(UpdateAttempterTest, MarkDeltaUpdateFailureTest) {
Jay Srinivasan6f6ea002012-12-14 11:26:28 -0800397 EXPECT_CALL(*prefs_, GetInt64(kPrefsDeltaUpdateFailures, _))
Darin Petkov36275772010-10-01 11:40:57 -0700398 .WillOnce(Return(false))
Ben Chan672c1f52017-10-23 15:41:39 -0700399 .WillOnce(DoAll(SetArgPointee<1>(-1), Return(true)))
400 .WillOnce(DoAll(SetArgPointee<1>(1), Return(true)))
Darin Petkov36275772010-10-01 11:40:57 -0700401 .WillOnce(DoAll(
Ben Chan672c1f52017-10-23 15:41:39 -0700402 SetArgPointee<1>(UpdateAttempter::kMaxDeltaUpdateFailures),
Darin Petkov36275772010-10-01 11:40:57 -0700403 Return(true)));
Jay Srinivasan6f6ea002012-12-14 11:26:28 -0800404 EXPECT_CALL(*prefs_, SetInt64(Ne(kPrefsDeltaUpdateFailures), _))
Darin Petkov2dd01092010-10-08 15:43:05 -0700405 .WillRepeatedly(Return(true));
Jay Srinivasan6f6ea002012-12-14 11:26:28 -0800406 EXPECT_CALL(*prefs_, SetInt64(kPrefsDeltaUpdateFailures, 1)).Times(2);
Gilad Arnold74b5f552014-10-07 08:17:16 -0700407 EXPECT_CALL(*prefs_, SetInt64(kPrefsDeltaUpdateFailures, 2));
Jay Srinivasan6f6ea002012-12-14 11:26:28 -0800408 EXPECT_CALL(*prefs_, SetInt64(kPrefsDeltaUpdateFailures,
Gilad Arnold74b5f552014-10-07 08:17:16 -0700409 UpdateAttempter::kMaxDeltaUpdateFailures + 1));
Darin Petkov36275772010-10-01 11:40:57 -0700410 for (int i = 0; i < 4; i ++)
411 attempter_.MarkDeltaUpdateFailure();
412}
413
Darin Petkov1b003102010-11-30 10:18:36 -0800414TEST_F(UpdateAttempterTest, ScheduleErrorEventActionNoEventTest) {
415 EXPECT_CALL(*processor_, EnqueueAction(_)).Times(0);
416 EXPECT_CALL(*processor_, StartProcessing()).Times(0);
Gilad Arnold5bb4c902014-04-10 12:32:13 -0700417 EXPECT_CALL(*fake_system_state_.mock_payload_state(), UpdateFailed(_))
Jay Srinivasan6f6ea002012-12-14 11:26:28 -0800418 .Times(0);
419 OmahaResponse response;
Jay Srinivasan53173b92013-05-17 17:13:01 -0700420 string url1 = "http://url1";
Sen Jiang0affc2c2017-02-10 15:55:05 -0800421 response.packages.push_back({.payload_urls = {url1, "https://url"}});
Gilad Arnold5bb4c902014-04-10 12:32:13 -0700422 EXPECT_CALL(*(fake_system_state_.mock_payload_state()), GetCurrentUrl())
Jay Srinivasan53173b92013-05-17 17:13:01 -0700423 .WillRepeatedly(Return(url1));
Gilad Arnold5bb4c902014-04-10 12:32:13 -0700424 fake_system_state_.mock_payload_state()->SetResponse(response);
Darin Petkov1b003102010-11-30 10:18:36 -0800425 attempter_.ScheduleErrorEventAction();
Gilad Arnold5bb4c902014-04-10 12:32:13 -0700426 EXPECT_EQ(url1, fake_system_state_.mock_payload_state()->GetCurrentUrl());
Darin Petkov1b003102010-11-30 10:18:36 -0800427}
428
429TEST_F(UpdateAttempterTest, ScheduleErrorEventActionTest) {
430 EXPECT_CALL(*processor_,
Amin Hassanid3f4bea2018-04-30 14:52:40 -0700431 EnqueueAction(Pointee(Property(
432 &AbstractAction::Type, OmahaRequestAction::StaticType()))));
Gilad Arnold74b5f552014-10-07 08:17:16 -0700433 EXPECT_CALL(*processor_, StartProcessing());
Gilad Arnoldd1c4d2d2014-06-05 14:07:53 -0700434 ErrorCode err = ErrorCode::kError;
Gilad Arnold5bb4c902014-04-10 12:32:13 -0700435 EXPECT_CALL(*fake_system_state_.mock_payload_state(), UpdateFailed(err));
Darin Petkov1b003102010-11-30 10:18:36 -0800436 attempter_.error_event_.reset(new OmahaEvent(OmahaEvent::kTypeUpdateComplete,
437 OmahaEvent::kResultError,
Jay Srinivasan6f6ea002012-12-14 11:26:28 -0800438 err));
Darin Petkov1b003102010-11-30 10:18:36 -0800439 attempter_.ScheduleErrorEventAction();
Christopher Wiley6b6cc1b2015-10-05 17:50:07 -0700440 EXPECT_EQ(UpdateStatus::REPORTING_ERROR_EVENT, attempter_.status());
Darin Petkov1b003102010-11-30 10:18:36 -0800441}
442
Darin Petkove6ef2f82011-03-07 17:31:11 -0800443namespace {
Chris Sosa76a29ae2013-07-11 17:59:24 -0700444// Actions that will be built as part of an update check.
Alex Vakulenkod2779df2014-06-16 13:19:00 -0700445const string kUpdateActionTypes[] = { // NOLINT(runtime/string)
Amin Hassani0882a512018-04-05 16:25:44 -0700446 OmahaRequestAction::StaticType(),
447 OmahaResponseHandlerAction::StaticType(),
448 UpdateBootFlagsAction::StaticType(),
449 OmahaRequestAction::StaticType(),
450 DownloadAction::StaticType(),
451 OmahaRequestAction::StaticType(),
452 FilesystemVerifierAction::StaticType(),
453 PostinstallRunnerAction::StaticType(),
454 OmahaRequestAction::StaticType()};
Chris Sosa76a29ae2013-07-11 17:59:24 -0700455
456// Actions that will be built as part of a user-initiated rollback.
Alex Vakulenkod2779df2014-06-16 13:19:00 -0700457const string kRollbackActionTypes[] = { // NOLINT(runtime/string)
Chris Sosa76a29ae2013-07-11 17:59:24 -0700458 InstallPlanAction::StaticType(),
459 PostinstallRunnerAction::StaticType(),
460};
461
Alex Vakulenkod2779df2014-06-16 13:19:00 -0700462} // namespace
Darin Petkove6ef2f82011-03-07 17:31:11 -0800463
464void UpdateAttempterTest::UpdateTestStart() {
Darin Petkovf42cc1c2010-09-01 09:03:02 -0700465 attempter_.set_http_response_code(200);
Alex Deymo749ecf12014-10-21 20:06:57 -0700466
467 // Expect that the device policy is loaded by the UpdateAttempter at some
468 // point by calling RefreshDevicePolicy.
Igor9fd76b62017-12-11 15:24:18 +0100469 auto device_policy = std::make_unique<policy::MockDevicePolicy>();
Alex Deymo749ecf12014-10-21 20:06:57 -0700470 EXPECT_CALL(*device_policy, LoadPolicy())
471 .Times(testing::AtLeast(1)).WillRepeatedly(Return(true));
Igor9fd76b62017-12-11 15:24:18 +0100472 attempter_.policy_provider_.reset(
473 new policy::PolicyProvider(std::move(device_policy)));
Alex Deymo749ecf12014-10-21 20:06:57 -0700474
475 {
476 InSequence s;
477 for (size_t i = 0; i < arraysize(kUpdateActionTypes); ++i) {
478 EXPECT_CALL(*processor_,
Amin Hassanid3f4bea2018-04-30 14:52:40 -0700479 EnqueueAction(Pointee(
480 Property(&AbstractAction::Type, kUpdateActionTypes[i]))));
Alex Deymo749ecf12014-10-21 20:06:57 -0700481 }
Gilad Arnold74b5f552014-10-07 08:17:16 -0700482 EXPECT_CALL(*processor_, StartProcessing());
Darin Petkovf42cc1c2010-09-01 09:03:02 -0700483 }
Darin Petkovf42cc1c2010-09-01 09:03:02 -0700484
Marton Hunyadyba51c3f2018-04-25 15:18:10 +0200485 attempter_.Update("", "", "", "", false, false, false);
Alex Deymo60ca1a72015-06-18 18:19:15 -0700486 loop_.PostTask(FROM_HERE,
487 base::Bind(&UpdateAttempterTest::UpdateTestVerify,
488 base::Unretained(this)));
Darin Petkove6ef2f82011-03-07 17:31:11 -0800489}
Darin Petkovf42cc1c2010-09-01 09:03:02 -0700490
Darin Petkove6ef2f82011-03-07 17:31:11 -0800491void UpdateAttempterTest::UpdateTestVerify() {
Darin Petkovf42cc1c2010-09-01 09:03:02 -0700492 EXPECT_EQ(0, attempter_.http_response_code());
493 EXPECT_EQ(&attempter_, processor_->delegate());
Christopher Wiley6b6cc1b2015-10-05 17:50:07 -0700494 EXPECT_EQ(UpdateStatus::CHECKING_FOR_UPDATE, attempter_.status());
Alex Deymo60ca1a72015-06-18 18:19:15 -0700495 loop_.BreakLoop();
Darin Petkove6ef2f82011-03-07 17:31:11 -0800496}
497
Chris Sosa28e479c2013-07-12 11:39:53 -0700498void UpdateAttempterTest::RollbackTestStart(
Chris Sosa44b9b7e2014-04-02 13:53:46 -0700499 bool enterprise_rollback, bool valid_slot) {
Chris Sosa76a29ae2013-07-11 17:59:24 -0700500 // Create a device policy so that we can change settings.
Igor9fd76b62017-12-11 15:24:18 +0100501 auto device_policy = std::make_unique<policy::MockDevicePolicy>();
Chris Sosa76a29ae2013-07-11 17:59:24 -0700502 EXPECT_CALL(*device_policy, LoadPolicy()).WillRepeatedly(Return(true));
Igor9fd76b62017-12-11 15:24:18 +0100503 fake_system_state_.set_device_policy(device_policy.get());
504 if (enterprise_rollback) {
505 // We return an empty owner as this is an enterprise.
506 EXPECT_CALL(*device_policy, GetOwner(_)).WillRepeatedly(
507 DoAll(SetArgPointee<0>(string("")),
508 Return(true)));
509 } else {
510 // We return a fake owner as this is an owned consumer device.
511 EXPECT_CALL(*device_policy, GetOwner(_)).WillRepeatedly(
512 DoAll(SetArgPointee<0>(string("fake.mail@fake.com")),
513 Return(true)));
514 }
515
516 attempter_.policy_provider_.reset(
517 new policy::PolicyProvider(std::move(device_policy)));
Chris Sosa76a29ae2013-07-11 17:59:24 -0700518
Alex Deymo763e7db2015-08-27 21:08:08 -0700519 if (valid_slot) {
520 BootControlInterface::Slot rollback_slot = 1;
521 LOG(INFO) << "Test Mark Bootable: "
522 << BootControlInterface::SlotName(rollback_slot);
Alex Deymoe5e5fe92015-10-05 09:28:19 -0700523 fake_system_state_.fake_boot_control()->SetSlotBootable(rollback_slot,
524 true);
Don Garrett6646b442013-11-13 15:29:11 -0800525 }
526
Chris Sosa28e479c2013-07-12 11:39:53 -0700527 bool is_rollback_allowed = false;
Chris Sosa76a29ae2013-07-11 17:59:24 -0700528
Chris Sosad38b1132014-03-25 10:43:59 -0700529 // We only allow rollback on devices that are not enterprise enrolled and
530 // which have a valid slot to rollback to.
531 if (!enterprise_rollback && valid_slot) {
Chris Sosa28e479c2013-07-12 11:39:53 -0700532 is_rollback_allowed = true;
533 }
534
Chris Sosa28e479c2013-07-12 11:39:53 -0700535 if (is_rollback_allowed) {
Chris Sosa76a29ae2013-07-11 17:59:24 -0700536 InSequence s;
537 for (size_t i = 0; i < arraysize(kRollbackActionTypes); ++i) {
538 EXPECT_CALL(*processor_,
Amin Hassanid3f4bea2018-04-30 14:52:40 -0700539 EnqueueAction(Pointee(Property(&AbstractAction::Type,
540 kRollbackActionTypes[i]))));
Chris Sosa76a29ae2013-07-11 17:59:24 -0700541 }
Gilad Arnold74b5f552014-10-07 08:17:16 -0700542 EXPECT_CALL(*processor_, StartProcessing());
Chris Sosa76a29ae2013-07-11 17:59:24 -0700543
Chris Sosa44b9b7e2014-04-02 13:53:46 -0700544 EXPECT_TRUE(attempter_.Rollback(true));
Alex Deymo60ca1a72015-06-18 18:19:15 -0700545 loop_.PostTask(FROM_HERE,
546 base::Bind(&UpdateAttempterTest::RollbackTestVerify,
547 base::Unretained(this)));
Chris Sosa76a29ae2013-07-11 17:59:24 -0700548 } else {
Chris Sosa44b9b7e2014-04-02 13:53:46 -0700549 EXPECT_FALSE(attempter_.Rollback(true));
Alex Deymo60ca1a72015-06-18 18:19:15 -0700550 loop_.BreakLoop();
Chris Sosa76a29ae2013-07-11 17:59:24 -0700551 }
552}
553
554void UpdateAttempterTest::RollbackTestVerify() {
555 // Verifies the actions that were enqueued.
556 EXPECT_EQ(&attempter_, processor_->delegate());
Christopher Wiley6b6cc1b2015-10-05 17:50:07 -0700557 EXPECT_EQ(UpdateStatus::ATTEMPTING_ROLLBACK, attempter_.status());
Amin Hassanid3f4bea2018-04-30 14:52:40 -0700558 EXPECT_EQ(0U, attempter_.install_plan_->partitions.size());
559 EXPECT_EQ(attempter_.install_plan_->powerwash_required, true);
Alex Deymo60ca1a72015-06-18 18:19:15 -0700560 loop_.BreakLoop();
Chris Sosa76a29ae2013-07-11 17:59:24 -0700561}
562
Darin Petkove6ef2f82011-03-07 17:31:11 -0800563TEST_F(UpdateAttempterTest, UpdateTest) {
Alex Deymo461b2592015-07-24 20:10:52 -0700564 UpdateTestStart();
Alex Deymo60ca1a72015-06-18 18:19:15 -0700565 loop_.Run();
Darin Petkovf42cc1c2010-09-01 09:03:02 -0700566}
567
Chris Sosa76a29ae2013-07-11 17:59:24 -0700568TEST_F(UpdateAttempterTest, RollbackTest) {
Alex Deymo60ca1a72015-06-18 18:19:15 -0700569 loop_.PostTask(FROM_HERE,
570 base::Bind(&UpdateAttempterTest::RollbackTestStart,
571 base::Unretained(this),
572 false, true));
573 loop_.Run();
Chris Sosa76a29ae2013-07-11 17:59:24 -0700574}
575
Don Garrett6646b442013-11-13 15:29:11 -0800576TEST_F(UpdateAttempterTest, InvalidSlotRollbackTest) {
Alex Deymo60ca1a72015-06-18 18:19:15 -0700577 loop_.PostTask(FROM_HERE,
578 base::Bind(&UpdateAttempterTest::RollbackTestStart,
579 base::Unretained(this),
580 false, false));
581 loop_.Run();
Don Garrett6646b442013-11-13 15:29:11 -0800582}
583
Chris Sosa76a29ae2013-07-11 17:59:24 -0700584TEST_F(UpdateAttempterTest, EnterpriseRollbackTest) {
Alex Deymo60ca1a72015-06-18 18:19:15 -0700585 loop_.PostTask(FROM_HERE,
586 base::Bind(&UpdateAttempterTest::RollbackTestStart,
587 base::Unretained(this),
588 true, true));
589 loop_.Run();
Chris Sosa76a29ae2013-07-11 17:59:24 -0700590}
591
Thieu Le116fda32011-04-19 11:01:54 -0700592void UpdateAttempterTest::PingOmahaTestStart() {
593 EXPECT_CALL(*processor_,
Amin Hassanid3f4bea2018-04-30 14:52:40 -0700594 EnqueueAction(Pointee(Property(
595 &AbstractAction::Type, OmahaRequestAction::StaticType()))));
Gilad Arnold74b5f552014-10-07 08:17:16 -0700596 EXPECT_CALL(*processor_, StartProcessing());
Thieu Le116fda32011-04-19 11:01:54 -0700597 attempter_.PingOmaha();
Alex Deymo60ca1a72015-06-18 18:19:15 -0700598 ScheduleQuitMainLoop();
Thieu Le116fda32011-04-19 11:01:54 -0700599}
600
601TEST_F(UpdateAttempterTest, PingOmahaTest) {
Gilad Arnoldec7f9162014-07-15 13:24:46 -0700602 EXPECT_FALSE(attempter_.waiting_for_scheduled_check_);
603 EXPECT_FALSE(attempter_.schedule_updates_called());
604 // Disable scheduling of subsequnet checks; we're using the DefaultPolicy in
605 // testing, which is more permissive than we want to handle here.
606 attempter_.DisableScheduleUpdates();
Alex Deymo60ca1a72015-06-18 18:19:15 -0700607 loop_.PostTask(FROM_HERE,
608 base::Bind(&UpdateAttempterTest::PingOmahaTestStart,
609 base::Unretained(this)));
Alex Vakulenko3f39d5c2015-10-13 09:27:13 -0700610 brillo::MessageLoopRunMaxIterations(&loop_, 100);
Christopher Wiley6b6cc1b2015-10-05 17:50:07 -0700611 EXPECT_EQ(UpdateStatus::UPDATED_NEED_REBOOT, attempter_.status());
Gilad Arnoldec7f9162014-07-15 13:24:46 -0700612 EXPECT_TRUE(attempter_.schedule_updates_called());
Thieu Le116fda32011-04-19 11:01:54 -0700613}
614
Darin Petkov18c7bce2011-06-16 14:07:00 -0700615TEST_F(UpdateAttempterTest, CreatePendingErrorEventTest) {
Alex Deymo8427b4a2014-11-05 14:00:32 -0800616 MockAction action;
Gilad Arnoldd1c4d2d2014-06-05 14:07:53 -0700617 const ErrorCode kCode = ErrorCode::kDownloadTransferError;
Darin Petkov18c7bce2011-06-16 14:07:00 -0700618 attempter_.CreatePendingErrorEvent(&action, kCode);
Alex Vakulenko88b591f2014-08-28 16:48:57 -0700619 ASSERT_NE(nullptr, attempter_.error_event_.get());
Darin Petkov18c7bce2011-06-16 14:07:00 -0700620 EXPECT_EQ(OmahaEvent::kTypeUpdateComplete, attempter_.error_event_->type);
621 EXPECT_EQ(OmahaEvent::kResultError, attempter_.error_event_->result);
Gilad Arnoldd1c4d2d2014-06-05 14:07:53 -0700622 EXPECT_EQ(
623 static_cast<ErrorCode>(static_cast<int>(kCode) |
624 static_cast<int>(ErrorCode::kTestOmahaUrlFlag)),
625 attempter_.error_event_->error_code);
Darin Petkov18c7bce2011-06-16 14:07:00 -0700626}
627
628TEST_F(UpdateAttempterTest, CreatePendingErrorEventResumedTest) {
Amin Hassanid3f4bea2018-04-30 14:52:40 -0700629 attempter_.install_plan_.reset(new InstallPlan);
630 attempter_.install_plan_->is_resume = true;
Alex Deymo8427b4a2014-11-05 14:00:32 -0800631 MockAction action;
Gilad Arnoldd1c4d2d2014-06-05 14:07:53 -0700632 const ErrorCode kCode = ErrorCode::kInstallDeviceOpenError;
Darin Petkov18c7bce2011-06-16 14:07:00 -0700633 attempter_.CreatePendingErrorEvent(&action, kCode);
Alex Vakulenko88b591f2014-08-28 16:48:57 -0700634 ASSERT_NE(nullptr, attempter_.error_event_.get());
Darin Petkov18c7bce2011-06-16 14:07:00 -0700635 EXPECT_EQ(OmahaEvent::kTypeUpdateComplete, attempter_.error_event_->type);
636 EXPECT_EQ(OmahaEvent::kResultError, attempter_.error_event_->result);
Gilad Arnoldd1c4d2d2014-06-05 14:07:53 -0700637 EXPECT_EQ(
638 static_cast<ErrorCode>(
639 static_cast<int>(kCode) |
640 static_cast<int>(ErrorCode::kResumedFlag) |
641 static_cast<int>(ErrorCode::kTestOmahaUrlFlag)),
642 attempter_.error_event_->error_code);
Darin Petkov18c7bce2011-06-16 14:07:00 -0700643}
644
David Zeuthen8f191b22013-08-06 12:27:50 -0700645TEST_F(UpdateAttempterTest, P2PNotStartedAtStartupWhenNotEnabled) {
646 MockP2PManager mock_p2p_manager;
Gilad Arnold5bb4c902014-04-10 12:32:13 -0700647 fake_system_state_.set_p2p_manager(&mock_p2p_manager);
David Zeuthen8f191b22013-08-06 12:27:50 -0700648 mock_p2p_manager.fake().SetP2PEnabled(false);
649 EXPECT_CALL(mock_p2p_manager, EnsureP2PRunning()).Times(0);
650 attempter_.UpdateEngineStarted();
651}
652
653TEST_F(UpdateAttempterTest, P2PNotStartedAtStartupWhenEnabledButNotSharing) {
654 MockP2PManager mock_p2p_manager;
Gilad Arnold5bb4c902014-04-10 12:32:13 -0700655 fake_system_state_.set_p2p_manager(&mock_p2p_manager);
David Zeuthen8f191b22013-08-06 12:27:50 -0700656 mock_p2p_manager.fake().SetP2PEnabled(true);
657 EXPECT_CALL(mock_p2p_manager, EnsureP2PRunning()).Times(0);
658 attempter_.UpdateEngineStarted();
659}
660
661TEST_F(UpdateAttempterTest, P2PStartedAtStartupWhenEnabledAndSharing) {
662 MockP2PManager mock_p2p_manager;
Gilad Arnold5bb4c902014-04-10 12:32:13 -0700663 fake_system_state_.set_p2p_manager(&mock_p2p_manager);
David Zeuthen8f191b22013-08-06 12:27:50 -0700664 mock_p2p_manager.fake().SetP2PEnabled(true);
665 mock_p2p_manager.fake().SetCountSharedFilesResult(1);
Gilad Arnold74b5f552014-10-07 08:17:16 -0700666 EXPECT_CALL(mock_p2p_manager, EnsureP2PRunning());
David Zeuthen8f191b22013-08-06 12:27:50 -0700667 attempter_.UpdateEngineStarted();
668}
669
670TEST_F(UpdateAttempterTest, P2PNotEnabled) {
Alex Deymo60ca1a72015-06-18 18:19:15 -0700671 loop_.PostTask(FROM_HERE,
672 base::Bind(&UpdateAttempterTest::P2PNotEnabledStart,
673 base::Unretained(this)));
674 loop_.Run();
David Zeuthen8f191b22013-08-06 12:27:50 -0700675}
Alex Deymo60ca1a72015-06-18 18:19:15 -0700676
David Zeuthen8f191b22013-08-06 12:27:50 -0700677void UpdateAttempterTest::P2PNotEnabledStart() {
678 // If P2P is not enabled, check that we do not attempt housekeeping
679 // and do not convey that p2p is to be used.
680 MockP2PManager mock_p2p_manager;
Gilad Arnold5bb4c902014-04-10 12:32:13 -0700681 fake_system_state_.set_p2p_manager(&mock_p2p_manager);
David Zeuthen8f191b22013-08-06 12:27:50 -0700682 mock_p2p_manager.fake().SetP2PEnabled(false);
683 EXPECT_CALL(mock_p2p_manager, PerformHousekeeping()).Times(0);
Marton Hunyadyba51c3f2018-04-25 15:18:10 +0200684 attempter_.Update("", "", "", "", false, false, false);
Alex Deymo60ca1a72015-06-18 18:19:15 -0700685 EXPECT_FALSE(actual_using_p2p_for_downloading_);
Gilad Arnold74b5f552014-10-07 08:17:16 -0700686 EXPECT_FALSE(actual_using_p2p_for_sharing());
Alex Deymo60ca1a72015-06-18 18:19:15 -0700687 ScheduleQuitMainLoop();
David Zeuthen8f191b22013-08-06 12:27:50 -0700688}
689
690TEST_F(UpdateAttempterTest, P2PEnabledStartingFails) {
Alex Deymo60ca1a72015-06-18 18:19:15 -0700691 loop_.PostTask(FROM_HERE,
692 base::Bind(&UpdateAttempterTest::P2PEnabledStartingFailsStart,
693 base::Unretained(this)));
694 loop_.Run();
David Zeuthen8f191b22013-08-06 12:27:50 -0700695}
Alex Deymo60ca1a72015-06-18 18:19:15 -0700696
David Zeuthen8f191b22013-08-06 12:27:50 -0700697void UpdateAttempterTest::P2PEnabledStartingFailsStart() {
698 // If p2p is enabled, but starting it fails ensure we don't do
699 // any housekeeping and do not convey that p2p should be used.
700 MockP2PManager mock_p2p_manager;
Gilad Arnold5bb4c902014-04-10 12:32:13 -0700701 fake_system_state_.set_p2p_manager(&mock_p2p_manager);
David Zeuthen8f191b22013-08-06 12:27:50 -0700702 mock_p2p_manager.fake().SetP2PEnabled(true);
703 mock_p2p_manager.fake().SetEnsureP2PRunningResult(false);
704 mock_p2p_manager.fake().SetPerformHousekeepingResult(false);
705 EXPECT_CALL(mock_p2p_manager, PerformHousekeeping()).Times(0);
Marton Hunyadyba51c3f2018-04-25 15:18:10 +0200706 attempter_.Update("", "", "", "", false, false, false);
Gilad Arnold74b5f552014-10-07 08:17:16 -0700707 EXPECT_FALSE(actual_using_p2p_for_downloading());
708 EXPECT_FALSE(actual_using_p2p_for_sharing());
Alex Deymo60ca1a72015-06-18 18:19:15 -0700709 ScheduleQuitMainLoop();
David Zeuthen8f191b22013-08-06 12:27:50 -0700710}
711
712TEST_F(UpdateAttempterTest, P2PEnabledHousekeepingFails) {
Alex Deymo60ca1a72015-06-18 18:19:15 -0700713 loop_.PostTask(
714 FROM_HERE,
715 base::Bind(&UpdateAttempterTest::P2PEnabledHousekeepingFailsStart,
716 base::Unretained(this)));
717 loop_.Run();
David Zeuthen8f191b22013-08-06 12:27:50 -0700718}
Alex Deymo60ca1a72015-06-18 18:19:15 -0700719
David Zeuthen8f191b22013-08-06 12:27:50 -0700720void UpdateAttempterTest::P2PEnabledHousekeepingFailsStart() {
721 // If p2p is enabled, starting it works but housekeeping fails, ensure
722 // we do not convey p2p is to be used.
723 MockP2PManager mock_p2p_manager;
Gilad Arnold5bb4c902014-04-10 12:32:13 -0700724 fake_system_state_.set_p2p_manager(&mock_p2p_manager);
David Zeuthen8f191b22013-08-06 12:27:50 -0700725 mock_p2p_manager.fake().SetP2PEnabled(true);
726 mock_p2p_manager.fake().SetEnsureP2PRunningResult(true);
727 mock_p2p_manager.fake().SetPerformHousekeepingResult(false);
Gilad Arnold74b5f552014-10-07 08:17:16 -0700728 EXPECT_CALL(mock_p2p_manager, PerformHousekeeping());
Marton Hunyadyba51c3f2018-04-25 15:18:10 +0200729 attempter_.Update("", "", "", "", false, false, false);
Gilad Arnold74b5f552014-10-07 08:17:16 -0700730 EXPECT_FALSE(actual_using_p2p_for_downloading());
731 EXPECT_FALSE(actual_using_p2p_for_sharing());
Alex Deymo60ca1a72015-06-18 18:19:15 -0700732 ScheduleQuitMainLoop();
David Zeuthen8f191b22013-08-06 12:27:50 -0700733}
734
735TEST_F(UpdateAttempterTest, P2PEnabled) {
Alex Deymo60ca1a72015-06-18 18:19:15 -0700736 loop_.PostTask(FROM_HERE,
737 base::Bind(&UpdateAttempterTest::P2PEnabledStart,
738 base::Unretained(this)));
739 loop_.Run();
David Zeuthen8f191b22013-08-06 12:27:50 -0700740}
Alex Deymo60ca1a72015-06-18 18:19:15 -0700741
David Zeuthen8f191b22013-08-06 12:27:50 -0700742void UpdateAttempterTest::P2PEnabledStart() {
743 MockP2PManager mock_p2p_manager;
Gilad Arnold5bb4c902014-04-10 12:32:13 -0700744 fake_system_state_.set_p2p_manager(&mock_p2p_manager);
David Zeuthen8f191b22013-08-06 12:27:50 -0700745 // If P2P is enabled and starting it works, check that we performed
746 // housekeeping and that we convey p2p should be used.
747 mock_p2p_manager.fake().SetP2PEnabled(true);
748 mock_p2p_manager.fake().SetEnsureP2PRunningResult(true);
749 mock_p2p_manager.fake().SetPerformHousekeepingResult(true);
Gilad Arnold74b5f552014-10-07 08:17:16 -0700750 EXPECT_CALL(mock_p2p_manager, PerformHousekeeping());
Marton Hunyadyba51c3f2018-04-25 15:18:10 +0200751 attempter_.Update("", "", "", "", false, false, false);
Gilad Arnold74b5f552014-10-07 08:17:16 -0700752 EXPECT_TRUE(actual_using_p2p_for_downloading());
753 EXPECT_TRUE(actual_using_p2p_for_sharing());
Alex Deymo60ca1a72015-06-18 18:19:15 -0700754 ScheduleQuitMainLoop();
David Zeuthen8f191b22013-08-06 12:27:50 -0700755}
756
757TEST_F(UpdateAttempterTest, P2PEnabledInteractive) {
Alex Deymo60ca1a72015-06-18 18:19:15 -0700758 loop_.PostTask(FROM_HERE,
759 base::Bind(&UpdateAttempterTest::P2PEnabledInteractiveStart,
760 base::Unretained(this)));
761 loop_.Run();
David Zeuthen8f191b22013-08-06 12:27:50 -0700762}
Alex Deymo60ca1a72015-06-18 18:19:15 -0700763
David Zeuthen8f191b22013-08-06 12:27:50 -0700764void UpdateAttempterTest::P2PEnabledInteractiveStart() {
765 MockP2PManager mock_p2p_manager;
Gilad Arnold5bb4c902014-04-10 12:32:13 -0700766 fake_system_state_.set_p2p_manager(&mock_p2p_manager);
David Zeuthen8f191b22013-08-06 12:27:50 -0700767 // For an interactive check, if P2P is enabled and starting it
768 // works, check that we performed housekeeping and that we convey
769 // p2p should be used for sharing but NOT for downloading.
770 mock_p2p_manager.fake().SetP2PEnabled(true);
771 mock_p2p_manager.fake().SetEnsureP2PRunningResult(true);
772 mock_p2p_manager.fake().SetPerformHousekeepingResult(true);
Gilad Arnold74b5f552014-10-07 08:17:16 -0700773 EXPECT_CALL(mock_p2p_manager, PerformHousekeeping());
Marton Hunyadyba51c3f2018-04-25 15:18:10 +0200774 attempter_.Update("",
775 "",
776 "",
777 "",
778 false,
779 false,
780 /*interactive=*/true);
Gilad Arnold74b5f552014-10-07 08:17:16 -0700781 EXPECT_FALSE(actual_using_p2p_for_downloading());
782 EXPECT_TRUE(actual_using_p2p_for_sharing());
Alex Deymo60ca1a72015-06-18 18:19:15 -0700783 ScheduleQuitMainLoop();
David Zeuthen8f191b22013-08-06 12:27:50 -0700784}
785
Jay Srinivasan480ddfa2012-06-01 19:15:26 -0700786TEST_F(UpdateAttempterTest, ReadScatterFactorFromPolicy) {
Alex Deymo60ca1a72015-06-18 18:19:15 -0700787 loop_.PostTask(
788 FROM_HERE,
789 base::Bind(&UpdateAttempterTest::ReadScatterFactorFromPolicyTestStart,
790 base::Unretained(this)));
791 loop_.Run();
Jay Srinivasan480ddfa2012-06-01 19:15:26 -0700792}
793
794// Tests that the scatter_factor_in_seconds value is properly fetched
795// from the device policy.
796void UpdateAttempterTest::ReadScatterFactorFromPolicyTestStart() {
Ben Chan9abb7632014-08-07 00:10:53 -0700797 int64_t scatter_factor_in_seconds = 36000;
Jay Srinivasan480ddfa2012-06-01 19:15:26 -0700798
Igor9fd76b62017-12-11 15:24:18 +0100799 auto device_policy = std::make_unique<policy::MockDevicePolicy>();
Jay Srinivasan480ddfa2012-06-01 19:15:26 -0700800 EXPECT_CALL(*device_policy, LoadPolicy()).WillRepeatedly(Return(true));
Igor9fd76b62017-12-11 15:24:18 +0100801 fake_system_state_.set_device_policy(device_policy.get());
Jay Srinivasan480ddfa2012-06-01 19:15:26 -0700802
803 EXPECT_CALL(*device_policy, GetScatterFactorInSeconds(_))
804 .WillRepeatedly(DoAll(
Ben Chan672c1f52017-10-23 15:41:39 -0700805 SetArgPointee<0>(scatter_factor_in_seconds),
Jay Srinivasan480ddfa2012-06-01 19:15:26 -0700806 Return(true)));
807
Igor9fd76b62017-12-11 15:24:18 +0100808 attempter_.policy_provider_.reset(
809 new policy::PolicyProvider(std::move(device_policy)));
810
Marton Hunyadyba51c3f2018-04-25 15:18:10 +0200811 attempter_.Update("", "", "", "", false, false, false);
Jay Srinivasan480ddfa2012-06-01 19:15:26 -0700812 EXPECT_EQ(scatter_factor_in_seconds, attempter_.scatter_factor_.InSeconds());
813
Alex Deymo60ca1a72015-06-18 18:19:15 -0700814 ScheduleQuitMainLoop();
Jay Srinivasan480ddfa2012-06-01 19:15:26 -0700815}
816
817TEST_F(UpdateAttempterTest, DecrementUpdateCheckCountTest) {
Alex Deymo60ca1a72015-06-18 18:19:15 -0700818 loop_.PostTask(
819 FROM_HERE,
820 base::Bind(&UpdateAttempterTest::DecrementUpdateCheckCountTestStart,
821 base::Unretained(this)));
822 loop_.Run();
Jay Srinivasan480ddfa2012-06-01 19:15:26 -0700823}
824
825void UpdateAttempterTest::DecrementUpdateCheckCountTestStart() {
826 // Tests that the scatter_factor_in_seconds value is properly fetched
827 // from the device policy and is decremented if value > 0.
Ben Chan9abb7632014-08-07 00:10:53 -0700828 int64_t initial_value = 5;
Alex Deymo2c0db7b2014-11-04 12:23:39 -0800829 FakePrefs fake_prefs;
830 attempter_.prefs_ = &fake_prefs;
Jay Srinivasan480ddfa2012-06-01 19:15:26 -0700831
Gilad Arnold5bb4c902014-04-10 12:32:13 -0700832 fake_system_state_.fake_hardware()->SetIsOOBEComplete(Time::UnixEpoch());
Jay Srinivasan08fce042012-06-07 16:31:01 -0700833
Alex Deymo2c0db7b2014-11-04 12:23:39 -0800834 EXPECT_TRUE(fake_prefs.SetInt64(kPrefsUpdateCheckCount, initial_value));
Jay Srinivasan480ddfa2012-06-01 19:15:26 -0700835
Ben Chan9abb7632014-08-07 00:10:53 -0700836 int64_t scatter_factor_in_seconds = 10;
Jay Srinivasan480ddfa2012-06-01 19:15:26 -0700837
Igor9fd76b62017-12-11 15:24:18 +0100838 auto device_policy = std::make_unique<policy::MockDevicePolicy>();
Jay Srinivasan480ddfa2012-06-01 19:15:26 -0700839 EXPECT_CALL(*device_policy, LoadPolicy()).WillRepeatedly(Return(true));
Igor9fd76b62017-12-11 15:24:18 +0100840 fake_system_state_.set_device_policy(device_policy.get());
Jay Srinivasan480ddfa2012-06-01 19:15:26 -0700841
842 EXPECT_CALL(*device_policy, GetScatterFactorInSeconds(_))
843 .WillRepeatedly(DoAll(
Ben Chan672c1f52017-10-23 15:41:39 -0700844 SetArgPointee<0>(scatter_factor_in_seconds),
Jay Srinivasan480ddfa2012-06-01 19:15:26 -0700845 Return(true)));
846
Igor9fd76b62017-12-11 15:24:18 +0100847 attempter_.policy_provider_.reset(
848 new policy::PolicyProvider(std::move(device_policy)));
849
Marton Hunyadyba51c3f2018-04-25 15:18:10 +0200850 attempter_.Update("", "", "", "", false, false, false);
Jay Srinivasan480ddfa2012-06-01 19:15:26 -0700851 EXPECT_EQ(scatter_factor_in_seconds, attempter_.scatter_factor_.InSeconds());
852
853 // Make sure the file still exists.
Alex Deymo2c0db7b2014-11-04 12:23:39 -0800854 EXPECT_TRUE(fake_prefs.Exists(kPrefsUpdateCheckCount));
Jay Srinivasan480ddfa2012-06-01 19:15:26 -0700855
Ben Chan9abb7632014-08-07 00:10:53 -0700856 int64_t new_value;
Alex Deymo2c0db7b2014-11-04 12:23:39 -0800857 EXPECT_TRUE(fake_prefs.GetInt64(kPrefsUpdateCheckCount, &new_value));
Jay Srinivasan480ddfa2012-06-01 19:15:26 -0700858 EXPECT_EQ(initial_value - 1, new_value);
859
Jay Srinivasanae4697c2013-03-18 17:08:08 -0700860 EXPECT_TRUE(
861 attempter_.omaha_request_params_->update_check_count_wait_enabled());
Jay Srinivasan480ddfa2012-06-01 19:15:26 -0700862
863 // However, if the count is already 0, it's not decremented. Test that.
864 initial_value = 0;
Alex Deymo2c0db7b2014-11-04 12:23:39 -0800865 EXPECT_TRUE(fake_prefs.SetInt64(kPrefsUpdateCheckCount, initial_value));
Marton Hunyadyba51c3f2018-04-25 15:18:10 +0200866 attempter_.Update("", "", "", "", false, false, false);
Alex Deymo2c0db7b2014-11-04 12:23:39 -0800867 EXPECT_TRUE(fake_prefs.Exists(kPrefsUpdateCheckCount));
868 EXPECT_TRUE(fake_prefs.GetInt64(kPrefsUpdateCheckCount, &new_value));
Jay Srinivasan480ddfa2012-06-01 19:15:26 -0700869 EXPECT_EQ(initial_value, new_value);
870
Alex Deymo60ca1a72015-06-18 18:19:15 -0700871 ScheduleQuitMainLoop();
Jay Srinivasan480ddfa2012-06-01 19:15:26 -0700872}
873
Jay Srinivasan08fce042012-06-07 16:31:01 -0700874TEST_F(UpdateAttempterTest, NoScatteringDoneDuringManualUpdateTestStart) {
Alex Deymo60ca1a72015-06-18 18:19:15 -0700875 loop_.PostTask(FROM_HERE, base::Bind(
876 &UpdateAttempterTest::NoScatteringDoneDuringManualUpdateTestStart,
877 base::Unretained(this)));
878 loop_.Run();
Jay Srinivasan08fce042012-06-07 16:31:01 -0700879}
880
881void UpdateAttempterTest::NoScatteringDoneDuringManualUpdateTestStart() {
882 // Tests that no scattering logic is enabled if the update check
883 // is manually done (as opposed to a scheduled update check)
Ben Chan9abb7632014-08-07 00:10:53 -0700884 int64_t initial_value = 8;
Alex Deymo2c0db7b2014-11-04 12:23:39 -0800885 FakePrefs fake_prefs;
886 attempter_.prefs_ = &fake_prefs;
Jay Srinivasan08fce042012-06-07 16:31:01 -0700887
Gilad Arnold5bb4c902014-04-10 12:32:13 -0700888 fake_system_state_.fake_hardware()->SetIsOOBEComplete(Time::UnixEpoch());
Alex Deymo2c0db7b2014-11-04 12:23:39 -0800889 fake_system_state_.set_prefs(&fake_prefs);
Jay Srinivasan08fce042012-06-07 16:31:01 -0700890
Adolfo Victoriad3a1e352018-07-16 11:40:47 -0700891 EXPECT_TRUE(
892 fake_prefs.SetInt64(kPrefsWallClockScatteringWaitPeriod, initial_value));
Alex Deymo2c0db7b2014-11-04 12:23:39 -0800893 EXPECT_TRUE(fake_prefs.SetInt64(kPrefsUpdateCheckCount, initial_value));
Jay Srinivasan08fce042012-06-07 16:31:01 -0700894
895 // make sure scatter_factor is non-zero as scattering is disabled
896 // otherwise.
Ben Chan9abb7632014-08-07 00:10:53 -0700897 int64_t scatter_factor_in_seconds = 50;
Jay Srinivasan08fce042012-06-07 16:31:01 -0700898
Igor9fd76b62017-12-11 15:24:18 +0100899 auto device_policy = std::make_unique<policy::MockDevicePolicy>();
Jay Srinivasan08fce042012-06-07 16:31:01 -0700900 EXPECT_CALL(*device_policy, LoadPolicy()).WillRepeatedly(Return(true));
Igor9fd76b62017-12-11 15:24:18 +0100901 fake_system_state_.set_device_policy(device_policy.get());
Jay Srinivasan08fce042012-06-07 16:31:01 -0700902
903 EXPECT_CALL(*device_policy, GetScatterFactorInSeconds(_))
904 .WillRepeatedly(DoAll(
Ben Chan672c1f52017-10-23 15:41:39 -0700905 SetArgPointee<0>(scatter_factor_in_seconds),
Jay Srinivasan08fce042012-06-07 16:31:01 -0700906 Return(true)));
907
Igor9fd76b62017-12-11 15:24:18 +0100908 attempter_.policy_provider_.reset(
909 new policy::PolicyProvider(std::move(device_policy)));
910
Gilad Arnoldb92f0df2013-01-10 16:32:45 -0800911 // Trigger an interactive check so we can test that scattering is disabled.
Marton Hunyadyba51c3f2018-04-25 15:18:10 +0200912 attempter_.Update("",
913 "",
914 "",
915 "",
916 false,
917 false,
918 /*interactive=*/true);
Jay Srinivasan08fce042012-06-07 16:31:01 -0700919 EXPECT_EQ(scatter_factor_in_seconds, attempter_.scatter_factor_.InSeconds());
920
921 // Make sure scattering is disabled for manual (i.e. user initiated) update
Jay Srinivasan21be0752012-07-25 15:44:56 -0700922 // checks and all artifacts are removed.
Jay Srinivasanae4697c2013-03-18 17:08:08 -0700923 EXPECT_FALSE(
924 attempter_.omaha_request_params_->wall_clock_based_wait_enabled());
Adolfo Victoriad3a1e352018-07-16 11:40:47 -0700925 EXPECT_FALSE(fake_prefs.Exists(kPrefsWallClockScatteringWaitPeriod));
Jay Srinivasanae4697c2013-03-18 17:08:08 -0700926 EXPECT_EQ(0, attempter_.omaha_request_params_->waiting_period().InSeconds());
927 EXPECT_FALSE(
928 attempter_.omaha_request_params_->update_check_count_wait_enabled());
Alex Deymo2c0db7b2014-11-04 12:23:39 -0800929 EXPECT_FALSE(fake_prefs.Exists(kPrefsUpdateCheckCount));
Jay Srinivasan08fce042012-06-07 16:31:01 -0700930
Alex Deymo60ca1a72015-06-18 18:19:15 -0700931 ScheduleQuitMainLoop();
Jay Srinivasan08fce042012-06-07 16:31:01 -0700932}
933
David Zeuthen985b1122013-10-09 12:13:15 -0700934// Checks that we only report daily metrics at most every 24 hours.
935TEST_F(UpdateAttempterTest, ReportDailyMetrics) {
936 FakeClock fake_clock;
Alex Deymo2c0db7b2014-11-04 12:23:39 -0800937 FakePrefs fake_prefs;
David Zeuthen985b1122013-10-09 12:13:15 -0700938
Gilad Arnold5bb4c902014-04-10 12:32:13 -0700939 fake_system_state_.set_clock(&fake_clock);
Alex Deymo2c0db7b2014-11-04 12:23:39 -0800940 fake_system_state_.set_prefs(&fake_prefs);
David Zeuthen985b1122013-10-09 12:13:15 -0700941
942 Time epoch = Time::FromInternalValue(0);
943 fake_clock.SetWallclockTime(epoch);
944
945 // If there is no kPrefsDailyMetricsLastReportedAt state variable,
946 // we should report.
947 EXPECT_TRUE(attempter_.CheckAndReportDailyMetrics());
948 // We should not report again if no time has passed.
949 EXPECT_FALSE(attempter_.CheckAndReportDailyMetrics());
950
951 // We should not report if only 10 hours has passed.
952 fake_clock.SetWallclockTime(epoch + TimeDelta::FromHours(10));
953 EXPECT_FALSE(attempter_.CheckAndReportDailyMetrics());
954
955 // We should not report if only 24 hours - 1 sec has passed.
956 fake_clock.SetWallclockTime(epoch + TimeDelta::FromHours(24) -
957 TimeDelta::FromSeconds(1));
958 EXPECT_FALSE(attempter_.CheckAndReportDailyMetrics());
959
960 // We should report if 24 hours has passed.
961 fake_clock.SetWallclockTime(epoch + TimeDelta::FromHours(24));
962 EXPECT_TRUE(attempter_.CheckAndReportDailyMetrics());
963
964 // But then we should not report again..
965 EXPECT_FALSE(attempter_.CheckAndReportDailyMetrics());
966
967 // .. until another 24 hours has passed
968 fake_clock.SetWallclockTime(epoch + TimeDelta::FromHours(47));
969 EXPECT_FALSE(attempter_.CheckAndReportDailyMetrics());
970 fake_clock.SetWallclockTime(epoch + TimeDelta::FromHours(48));
971 EXPECT_TRUE(attempter_.CheckAndReportDailyMetrics());
972 EXPECT_FALSE(attempter_.CheckAndReportDailyMetrics());
973
974 // .. and another 24 hours
975 fake_clock.SetWallclockTime(epoch + TimeDelta::FromHours(71));
976 EXPECT_FALSE(attempter_.CheckAndReportDailyMetrics());
977 fake_clock.SetWallclockTime(epoch + TimeDelta::FromHours(72));
978 EXPECT_TRUE(attempter_.CheckAndReportDailyMetrics());
979 EXPECT_FALSE(attempter_.CheckAndReportDailyMetrics());
980
981 // If the span between time of reporting and present time is
982 // negative, we report. This is in order to reset the timestamp and
983 // avoid an edge condition whereby a distant point in the future is
984 // in the state variable resulting in us never ever reporting again.
985 fake_clock.SetWallclockTime(epoch + TimeDelta::FromHours(71));
986 EXPECT_TRUE(attempter_.CheckAndReportDailyMetrics());
987 EXPECT_FALSE(attempter_.CheckAndReportDailyMetrics());
988
989 // In this case we should not update until the clock reads 71 + 24 = 95.
990 // Check that.
991 fake_clock.SetWallclockTime(epoch + TimeDelta::FromHours(94));
992 EXPECT_FALSE(attempter_.CheckAndReportDailyMetrics());
993 fake_clock.SetWallclockTime(epoch + TimeDelta::FromHours(95));
994 EXPECT_TRUE(attempter_.CheckAndReportDailyMetrics());
995 EXPECT_FALSE(attempter_.CheckAndReportDailyMetrics());
David Zeuthen985b1122013-10-09 12:13:15 -0700996}
997
David Zeuthen3c55abd2013-10-14 12:48:03 -0700998TEST_F(UpdateAttempterTest, BootTimeInUpdateMarkerFile) {
David Zeuthen3c55abd2013-10-14 12:48:03 -0700999 FakeClock fake_clock;
1000 fake_clock.SetBootTime(Time::FromTimeT(42));
Gilad Arnold5bb4c902014-04-10 12:32:13 -07001001 fake_system_state_.set_clock(&fake_clock);
Alex Deymo906191f2015-10-12 12:22:44 -07001002 FakePrefs fake_prefs;
1003 fake_system_state_.set_prefs(&fake_prefs);
Sen Jiangaeeb2e02016-06-09 15:00:16 -07001004 attempter_.Init();
David Zeuthen3c55abd2013-10-14 12:48:03 -07001005
1006 Time boot_time;
Sen Jiangaeeb2e02016-06-09 15:00:16 -07001007 EXPECT_FALSE(attempter_.GetBootTimeAtUpdate(&boot_time));
David Zeuthen3c55abd2013-10-14 12:48:03 -07001008
Sen Jiangaeeb2e02016-06-09 15:00:16 -07001009 attempter_.WriteUpdateCompletedMarker();
David Zeuthen3c55abd2013-10-14 12:48:03 -07001010
Sen Jiangaeeb2e02016-06-09 15:00:16 -07001011 EXPECT_TRUE(attempter_.GetBootTimeAtUpdate(&boot_time));
David Zeuthen3c55abd2013-10-14 12:48:03 -07001012 EXPECT_EQ(boot_time.ToTimeT(), 42);
1013}
1014
David Pursell02c18642014-11-06 11:26:11 -08001015TEST_F(UpdateAttempterTest, AnyUpdateSourceAllowedUnofficial) {
1016 fake_system_state_.fake_hardware()->SetIsOfficialBuild(false);
1017 EXPECT_TRUE(attempter_.IsAnyUpdateSourceAllowed());
1018}
1019
1020TEST_F(UpdateAttempterTest, AnyUpdateSourceAllowedOfficialDevmode) {
1021 fake_system_state_.fake_hardware()->SetIsOfficialBuild(true);
Sen Jiange67bb5b2016-06-20 15:53:56 -07001022 fake_system_state_.fake_hardware()->SetAreDevFeaturesEnabled(true);
David Pursell02c18642014-11-06 11:26:11 -08001023 EXPECT_TRUE(attempter_.IsAnyUpdateSourceAllowed());
1024}
1025
1026TEST_F(UpdateAttempterTest, AnyUpdateSourceDisallowedOfficialNormal) {
1027 fake_system_state_.fake_hardware()->SetIsOfficialBuild(true);
Sen Jiange67bb5b2016-06-20 15:53:56 -07001028 fake_system_state_.fake_hardware()->SetAreDevFeaturesEnabled(false);
David Pursell02c18642014-11-06 11:26:11 -08001029 EXPECT_FALSE(attempter_.IsAnyUpdateSourceAllowed());
1030}
1031
1032TEST_F(UpdateAttempterTest, CheckForUpdateAUTest) {
1033 fake_system_state_.fake_hardware()->SetIsOfficialBuild(true);
Sen Jiange67bb5b2016-06-20 15:53:56 -07001034 fake_system_state_.fake_hardware()->SetAreDevFeaturesEnabled(false);
Aaron Wood081c0232017-10-19 17:14:58 -07001035 attempter_.CheckForUpdate("", "autest", UpdateAttemptFlags::kNone);
Alex Deymoac41a822015-09-15 20:52:53 -07001036 EXPECT_EQ(constants::kOmahaDefaultAUTestURL, attempter_.forced_omaha_url());
David Pursell02c18642014-11-06 11:26:11 -08001037}
1038
1039TEST_F(UpdateAttempterTest, CheckForUpdateScheduledAUTest) {
1040 fake_system_state_.fake_hardware()->SetIsOfficialBuild(true);
Sen Jiange67bb5b2016-06-20 15:53:56 -07001041 fake_system_state_.fake_hardware()->SetAreDevFeaturesEnabled(false);
Aaron Wood081c0232017-10-19 17:14:58 -07001042 attempter_.CheckForUpdate("", "autest-scheduled", UpdateAttemptFlags::kNone);
Alex Deymoac41a822015-09-15 20:52:53 -07001043 EXPECT_EQ(constants::kOmahaDefaultAUTestURL, attempter_.forced_omaha_url());
David Pursell02c18642014-11-06 11:26:11 -08001044}
1045
Xiyuan Xiac0e8f9a2017-02-22 13:19:35 -08001046TEST_F(UpdateAttempterTest, TargetVersionPrefixSetAndReset) {
Marton Hunyadyba51c3f2018-04-25 15:18:10 +02001047 attempter_.CalculateUpdateParams("", "", "", "1234", false, false, false);
Xiyuan Xiac0e8f9a2017-02-22 13:19:35 -08001048 EXPECT_EQ("1234",
1049 fake_system_state_.request_params()->target_version_prefix());
1050
Marton Hunyadyba51c3f2018-04-25 15:18:10 +02001051 attempter_.CalculateUpdateParams("", "", "", "", false, false, false);
Xiyuan Xiac0e8f9a2017-02-22 13:19:35 -08001052 EXPECT_TRUE(
1053 fake_system_state_.request_params()->target_version_prefix().empty());
1054}
1055
Marton Hunyadyba51c3f2018-04-25 15:18:10 +02001056TEST_F(UpdateAttempterTest, RollbackAllowedSetAndReset) {
1057 attempter_.CalculateUpdateParams("",
1058 "",
1059 "",
1060 "1234",
1061 /*rollback_allowed=*/true,
1062 false,
1063 false);
1064 EXPECT_TRUE(fake_system_state_.request_params()->rollback_allowed());
1065
1066 attempter_.CalculateUpdateParams("",
1067 "",
1068 "",
1069 "1234",
1070 /*rollback_allowed=*/false,
1071 false,
1072 false);
1073 EXPECT_FALSE(fake_system_state_.request_params()->rollback_allowed());
1074}
1075
Aaron Wood23bd3392017-10-06 14:48:25 -07001076TEST_F(UpdateAttempterTest, UpdateDeferredByPolicyTest) {
1077 // Construct an OmahaResponseHandlerAction that has processed an InstallPlan,
1078 // but the update is being deferred by the Policy.
Amin Hassanid3f4bea2018-04-30 14:52:40 -07001079 auto response_action = new OmahaResponseHandlerAction(&fake_system_state_);
Aaron Wood23bd3392017-10-06 14:48:25 -07001080 response_action->install_plan_.version = "a.b.c.d";
1081 response_action->install_plan_.system_version = "b.c.d.e";
1082 response_action->install_plan_.payloads.push_back(
1083 {.size = 1234ULL, .type = InstallPayloadType::kFull});
Aaron Wood23bd3392017-10-06 14:48:25 -07001084 // Inform the UpdateAttempter that the OmahaResponseHandlerAction has
1085 // completed, with the deferred-update error code.
1086 attempter_.ActionCompleted(
1087 nullptr, response_action, ErrorCode::kOmahaUpdateDeferredPerPolicy);
1088 {
1089 UpdateEngineStatus status;
1090 attempter_.GetStatus(&status);
1091 EXPECT_EQ(UpdateStatus::UPDATE_AVAILABLE, status.status);
Amin Hassanid3f4bea2018-04-30 14:52:40 -07001092 EXPECT_TRUE(attempter_.install_plan_);
1093 EXPECT_EQ(attempter_.install_plan_->version, status.new_version);
1094 EXPECT_EQ(attempter_.install_plan_->system_version,
Aaron Wood23bd3392017-10-06 14:48:25 -07001095 status.new_system_version);
Amin Hassanid3f4bea2018-04-30 14:52:40 -07001096 EXPECT_EQ(attempter_.install_plan_->payloads[0].size,
Aaron Wood23bd3392017-10-06 14:48:25 -07001097 status.new_size_bytes);
1098 }
1099 // An "error" event should have been created to tell Omaha that the update is
1100 // being deferred.
1101 EXPECT_TRUE(nullptr != attempter_.error_event_);
1102 EXPECT_EQ(OmahaEvent::kTypeUpdateComplete, attempter_.error_event_->type);
1103 EXPECT_EQ(OmahaEvent::kResultUpdateDeferred, attempter_.error_event_->result);
1104 ErrorCode expected_code = static_cast<ErrorCode>(
1105 static_cast<int>(ErrorCode::kOmahaUpdateDeferredPerPolicy) |
1106 static_cast<int>(ErrorCode::kTestOmahaUrlFlag));
1107 EXPECT_EQ(expected_code, attempter_.error_event_->error_code);
1108 // End the processing
1109 attempter_.ProcessingDone(nullptr, ErrorCode::kOmahaUpdateDeferredPerPolicy);
1110 // Validate the state of the attempter.
1111 {
1112 UpdateEngineStatus status;
1113 attempter_.GetStatus(&status);
1114 EXPECT_EQ(UpdateStatus::REPORTING_ERROR_EVENT, status.status);
1115 EXPECT_EQ(response_action->install_plan_.version, status.new_version);
1116 EXPECT_EQ(response_action->install_plan_.system_version,
1117 status.new_system_version);
1118 EXPECT_EQ(response_action->install_plan_.payloads[0].size,
1119 status.new_size_bytes);
1120 }
1121}
1122
1123TEST_F(UpdateAttempterTest, UpdateIsNotRunningWhenUpdateAvailable) {
1124 EXPECT_FALSE(attempter_.IsUpdateRunningOrScheduled());
1125 // Verify in-progress update with UPDATE_AVAILABLE is running
1126 attempter_.status_ = UpdateStatus::UPDATE_AVAILABLE;
1127 EXPECT_TRUE(attempter_.IsUpdateRunningOrScheduled());
1128}
1129
Aaron Woodbf5a2522017-10-04 10:58:36 -07001130TEST_F(UpdateAttempterTest, UpdateAttemptFlagsCachedAtUpdateStart) {
1131 attempter_.SetUpdateAttemptFlags(UpdateAttemptFlags::kFlagRestrictDownload);
1132
1133 UpdateCheckParams params = {.updates_enabled = true};
1134 attempter_.OnUpdateScheduled(EvalStatus::kSucceeded, params);
1135
1136 EXPECT_EQ(UpdateAttemptFlags::kFlagRestrictDownload,
1137 attempter_.GetCurrentUpdateAttemptFlags());
1138}
1139
Marton Hunyadyba51c3f2018-04-25 15:18:10 +02001140TEST_F(UpdateAttempterTest, RollbackNotAllowed) {
1141 UpdateCheckParams params = {.updates_enabled = true,
1142 .rollback_allowed = false};
1143 attempter_.OnUpdateScheduled(EvalStatus::kSucceeded, params);
1144 EXPECT_FALSE(fake_system_state_.request_params()->rollback_allowed());
1145}
1146
1147TEST_F(UpdateAttempterTest, RollbackAllowed) {
1148 UpdateCheckParams params = {.updates_enabled = true,
1149 .rollback_allowed = true};
1150 attempter_.OnUpdateScheduled(EvalStatus::kSucceeded, params);
1151 EXPECT_TRUE(fake_system_state_.request_params()->rollback_allowed());
1152}
1153
Aaron Wood081c0232017-10-19 17:14:58 -07001154TEST_F(UpdateAttempterTest, InteractiveUpdateUsesPassedRestrictions) {
1155 attempter_.SetUpdateAttemptFlags(UpdateAttemptFlags::kFlagRestrictDownload);
1156
1157 attempter_.CheckForUpdate("", "", UpdateAttemptFlags::kNone);
1158 EXPECT_EQ(UpdateAttemptFlags::kNone,
1159 attempter_.GetCurrentUpdateAttemptFlags());
1160}
1161
1162TEST_F(UpdateAttempterTest, NonInteractiveUpdateUsesSetRestrictions) {
1163 attempter_.SetUpdateAttemptFlags(UpdateAttemptFlags::kNone);
1164
1165 // This tests that when CheckForUpdate() is called with the non-interactive
1166 // flag set, that it doesn't change the current UpdateAttemptFlags.
1167 attempter_.CheckForUpdate("",
1168 "",
1169 UpdateAttemptFlags::kFlagNonInteractive |
1170 UpdateAttemptFlags::kFlagRestrictDownload);
1171 EXPECT_EQ(UpdateAttemptFlags::kNone,
1172 attempter_.GetCurrentUpdateAttemptFlags());
1173}
1174
Marton Hunyadye58bddb2018-04-10 20:27:26 +02001175void UpdateAttempterTest::ResetRollbackHappenedStart(bool is_consumer,
1176 bool is_policy_loaded,
1177 bool expected_reset) {
1178 EXPECT_CALL(*fake_system_state_.mock_payload_state(), GetRollbackHappened())
1179 .WillRepeatedly(Return(true));
1180 auto mock_policy_provider =
1181 std::make_unique<NiceMock<policy::MockPolicyProvider>>();
1182 EXPECT_CALL(*mock_policy_provider, IsConsumerDevice())
1183 .WillRepeatedly(Return(is_consumer));
1184 EXPECT_CALL(*mock_policy_provider, device_policy_is_loaded())
1185 .WillRepeatedly(Return(is_policy_loaded));
1186 const policy::MockDevicePolicy device_policy;
1187 EXPECT_CALL(*mock_policy_provider, GetDevicePolicy())
1188 .WillRepeatedly(ReturnRef(device_policy));
1189 EXPECT_CALL(*fake_system_state_.mock_payload_state(),
1190 SetRollbackHappened(false))
1191 .Times(expected_reset ? 1 : 0);
1192 attempter_.policy_provider_ = std::move(mock_policy_provider);
Marton Hunyadyba51c3f2018-04-25 15:18:10 +02001193 attempter_.Update("", "", "", "", false, false, false);
Marton Hunyadye58bddb2018-04-10 20:27:26 +02001194 ScheduleQuitMainLoop();
1195}
1196
1197TEST_F(UpdateAttempterTest, ResetRollbackHappenedOobe) {
1198 loop_.PostTask(FROM_HERE,
1199 base::Bind(&UpdateAttempterTest::ResetRollbackHappenedStart,
1200 base::Unretained(this),
1201 /*is_consumer=*/false,
1202 /*is_policy_loaded=*/false,
1203 /*expected_reset=*/false));
1204 loop_.Run();
1205}
1206
1207TEST_F(UpdateAttempterTest, ResetRollbackHappenedConsumer) {
1208 loop_.PostTask(FROM_HERE,
1209 base::Bind(&UpdateAttempterTest::ResetRollbackHappenedStart,
1210 base::Unretained(this),
1211 /*is_consumer=*/true,
1212 /*is_policy_loaded=*/false,
1213 /*expected_reset=*/true));
1214 loop_.Run();
1215}
1216
1217TEST_F(UpdateAttempterTest, ResetRollbackHappenedEnterprise) {
1218 loop_.PostTask(FROM_HERE,
1219 base::Bind(&UpdateAttempterTest::ResetRollbackHappenedStart,
1220 base::Unretained(this),
1221 /*is_consumer=*/false,
1222 /*is_policy_loaded=*/true,
1223 /*expected_reset=*/true));
1224 loop_.Run();
1225}
1226
Marton Hunyady199152d2018-05-07 19:08:48 +02001227TEST_F(UpdateAttempterTest, SetRollbackHappenedRollback) {
Amin Hassanid3f4bea2018-04-30 14:52:40 -07001228 attempter_.install_plan_.reset(new InstallPlan);
1229 attempter_.install_plan_->is_rollback = true;
Marton Hunyady199152d2018-05-07 19:08:48 +02001230
1231 EXPECT_CALL(*fake_system_state_.mock_payload_state(),
1232 SetRollbackHappened(true))
1233 .Times(1);
1234 attempter_.ProcessingDone(nullptr, ErrorCode::kSuccess);
1235}
1236
1237TEST_F(UpdateAttempterTest, SetRollbackHappenedNotRollback) {
Amin Hassanid3f4bea2018-04-30 14:52:40 -07001238 attempter_.install_plan_.reset(new InstallPlan);
1239 attempter_.install_plan_->is_rollback = false;
Marton Hunyady199152d2018-05-07 19:08:48 +02001240
1241 EXPECT_CALL(*fake_system_state_.mock_payload_state(),
1242 SetRollbackHappened(true))
1243 .Times(0);
1244 attempter_.ProcessingDone(nullptr, ErrorCode::kSuccess);
1245}
1246
Marton Hunyadya0302682018-05-16 18:52:13 +02001247TEST_F(UpdateAttempterTest, RollbackMetricsRollbackSuccess) {
Amin Hassanid3f4bea2018-04-30 14:52:40 -07001248 attempter_.install_plan_.reset(new InstallPlan);
1249 attempter_.install_plan_->is_rollback = true;
1250 attempter_.install_plan_->version = kRollbackVersion;
Marton Hunyadya0302682018-05-16 18:52:13 +02001251
1252 EXPECT_CALL(*fake_system_state_.mock_metrics_reporter(),
1253 ReportEnterpriseRollbackMetrics(true, kRollbackVersion))
1254 .Times(1);
1255 attempter_.ProcessingDone(nullptr, ErrorCode::kSuccess);
1256}
1257
1258TEST_F(UpdateAttempterTest, RollbackMetricsNotRollbackSuccess) {
Amin Hassanid3f4bea2018-04-30 14:52:40 -07001259 attempter_.install_plan_.reset(new InstallPlan);
1260 attempter_.install_plan_->is_rollback = false;
1261 attempter_.install_plan_->version = kRollbackVersion;
Marton Hunyadya0302682018-05-16 18:52:13 +02001262
1263 EXPECT_CALL(*fake_system_state_.mock_metrics_reporter(),
1264 ReportEnterpriseRollbackMetrics(_, _))
1265 .Times(0);
1266 attempter_.ProcessingDone(nullptr, ErrorCode::kSuccess);
1267}
1268
1269TEST_F(UpdateAttempterTest, RollbackMetricsRollbackFailure) {
Amin Hassanid3f4bea2018-04-30 14:52:40 -07001270 attempter_.install_plan_.reset(new InstallPlan);
1271 attempter_.install_plan_->is_rollback = true;
1272 attempter_.install_plan_->version = kRollbackVersion;
Marton Hunyadya0302682018-05-16 18:52:13 +02001273
1274 EXPECT_CALL(*fake_system_state_.mock_metrics_reporter(),
1275 ReportEnterpriseRollbackMetrics(false, kRollbackVersion))
1276 .Times(1);
1277 MockAction action;
1278 attempter_.CreatePendingErrorEvent(&action, ErrorCode::kRollbackNotPossible);
1279 attempter_.ProcessingDone(nullptr, ErrorCode::kRollbackNotPossible);
1280}
1281
1282TEST_F(UpdateAttempterTest, RollbackMetricsNotRollbackFailure) {
Amin Hassanid3f4bea2018-04-30 14:52:40 -07001283 attempter_.install_plan_.reset(new InstallPlan);
1284 attempter_.install_plan_->is_rollback = false;
1285 attempter_.install_plan_->version = kRollbackVersion;
Marton Hunyadya0302682018-05-16 18:52:13 +02001286
1287 EXPECT_CALL(*fake_system_state_.mock_metrics_reporter(),
1288 ReportEnterpriseRollbackMetrics(_, _))
1289 .Times(0);
1290 MockAction action;
1291 attempter_.CreatePendingErrorEvent(&action, ErrorCode::kRollbackNotPossible);
1292 attempter_.ProcessingDone(nullptr, ErrorCode::kRollbackNotPossible);
1293}
1294
Darin Petkovf42cc1c2010-09-01 09:03:02 -07001295} // namespace chromeos_update_engine