update_engine: Remove all references to glib.
The message loop in production code switched from
chromeos::GlibMessageLoop to chromeos::BaseMessageLoop used in
chromeos::Dameon. This patch moves all the unittests also to use
chromeos::BaseMessageLoop or chromeos::FakeMessageLoop when I/O is not
required.
This patch removes all (now unused) references to glib.
BUG=chromium:499886
TEST=`grep glib[^c] . -R` return no results. Also, unittests work.
Change-Id: Iddfb17def501829d932ed1f70faad3e00268898e
Reviewed-on: https://chromium-review.googlesource.com/292157
Tested-by: Alex Deymo <deymo@chromium.org>
Reviewed-by: Alex Deymo <deymo@chromium.org>
Commit-Queue: Alex Deymo <deymo@chromium.org>
Trybot-Ready: Alex Deymo <deymo@chromium.org>
diff --git a/update_attempter_unittest.cc b/update_attempter_unittest.cc
index 9965def..19f2081 100644
--- a/update_attempter_unittest.cc
+++ b/update_attempter_unittest.cc
@@ -9,10 +9,11 @@
#include <memory>
#include <base/files/file_util.h>
+#include <base/message_loop/message_loop.h>
#include <chromeos/bind_lambda.h>
#include <chromeos/dbus/service_constants.h>
#include <chromeos/make_unique_ptr.h>
-#include <chromeos/message_loops/glib_message_loop.h>
+#include <chromeos/message_loops/base_message_loop.h>
#include <chromeos/message_loops/message_loop.h>
#include <chromeos/message_loops/message_loop_utils.h>
#include <gtest/gtest.h>
@@ -175,9 +176,8 @@
return actual_using_p2p_for_sharing_;
}
- // TODO(deymo): Replace this with a FakeMessageLoop. Some of these tests use a
- // real LibcurlHttpFetcher, which still requires a GlibMessageLoop.
- chromeos::GlibMessageLoop loop_;
+ base::MessageLoopForIO base_loop_;
+ chromeos::BaseMessageLoop loop_{&base_loop_};
FakeSystemState fake_system_state_;
org::chromium::debugdProxyMock debugd_proxy_mock_;