blob: 4af5f8b003d25851d3f5e1d2e26c327d1e3615b8 [file] [log] [blame]
Alex Deymoaea4c1c2015-08-19 20:24:43 -07001//
2// Copyright (C) 2012 The Android Open Source Project
3//
4// Licensed under the Apache License, Version 2.0 (the "License");
5// you may not use this file except in compliance with the License.
6// You may obtain a copy of the License at
7//
8// http://www.apache.org/licenses/LICENSE-2.0
9//
10// Unless required by applicable law or agreed to in writing, software
11// distributed under the License is distributed on an "AS IS" BASIS,
12// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
13// See the License for the specific language governing permissions and
14// limitations under the License.
15//
Darin Petkovf42cc1c2010-09-01 09:03:02 -070016
Alex Deymo2c0db7b2014-11-04 12:23:39 -080017#include "update_engine/update_attempter.h"
18
Ben Chan9abb7632014-08-07 00:10:53 -070019#include <stdint.h>
20
Ben Chan02f7c1d2014-10-18 15:18:02 -070021#include <memory>
22
Ben Chan06c76a42014-09-05 08:21:06 -070023#include <base/files/file_util.h>
Alex Deymo0b3db6b2015-08-10 15:19:37 -070024#include <base/message_loop/message_loop.h>
Amin Hassani71818c82018-03-06 13:25:40 -080025#include <brillo/bind_lambda.h>
Alex Vakulenko3f39d5c2015-10-13 09:27:13 -070026#include <brillo/message_loops/base_message_loop.h>
27#include <brillo/message_loops/message_loop.h>
28#include <brillo/message_loops/message_loop_utils.h>
Darin Petkovf42cc1c2010-09-01 09:03:02 -070029#include <gtest/gtest.h>
Patrick Dubroy7fbbe8a2011-08-01 17:28:22 +020030#include <policy/libpolicy.h>
31#include <policy/mock_device_policy.h>
Marton Hunyadye58bddb2018-04-10 20:27:26 +020032#include <policy/mock_libpolicy.h>
Darin Petkovf42cc1c2010-09-01 09:03:02 -070033
Alex Deymo39910dc2015-11-09 17:04:30 -080034#include "update_engine/common/fake_clock.h"
35#include "update_engine/common/fake_prefs.h"
Alex Deymo14fd1ec2016-02-24 22:03:57 -080036#include "update_engine/common/mock_action.h"
37#include "update_engine/common/mock_action_processor.h"
Alex Deymo39910dc2015-11-09 17:04:30 -080038#include "update_engine/common/mock_http_fetcher.h"
39#include "update_engine/common/mock_prefs.h"
40#include "update_engine/common/platform_constants.h"
41#include "update_engine/common/prefs.h"
42#include "update_engine/common/test_utils.h"
43#include "update_engine/common/utils.h"
Gilad Arnold5bb4c902014-04-10 12:32:13 -070044#include "update_engine/fake_system_state.h"
David Zeuthen8f191b22013-08-06 12:27:50 -070045#include "update_engine/mock_p2p_manager.h"
Jay Srinivasan6f6ea002012-12-14 11:26:28 -080046#include "update_engine/mock_payload_state.h"
Aaron Wood9321f502017-09-07 11:18:54 -070047#include "update_engine/mock_service_observer.h"
Alex Deymo39910dc2015-11-09 17:04:30 -080048#include "update_engine/payload_consumer/filesystem_verifier_action.h"
49#include "update_engine/payload_consumer/install_plan.h"
50#include "update_engine/payload_consumer/payload_constants.h"
51#include "update_engine/payload_consumer/postinstall_runner_action.h"
Darin Petkovf42cc1c2010-09-01 09:03:02 -070052
David Zeuthen985b1122013-10-09 12:13:15 -070053using base::Time;
54using base::TimeDelta;
Aaron Woodbf5a2522017-10-04 10:58:36 -070055using chromeos_update_manager::EvalStatus;
56using chromeos_update_manager::UpdateCheckParams;
Darin Petkovf42cc1c2010-09-01 09:03:02 -070057using std::string;
Ben Chan02f7c1d2014-10-18 15:18:02 -070058using std::unique_ptr;
Aaron Woodbf5a2522017-10-04 10:58:36 -070059using testing::_;
Darin Petkov36275772010-10-01 11:40:57 -070060using testing::DoAll;
Aaron Wood7f92e2b2017-08-28 14:51:21 -070061using testing::Field;
Darin Petkovf42cc1c2010-09-01 09:03:02 -070062using testing::InSequence;
Darin Petkov2dd01092010-10-08 15:43:05 -070063using testing::Ne;
Darin Petkov9c096d62010-11-17 14:49:04 -080064using testing::NiceMock;
Amin Hassanid3f4bea2018-04-30 14:52:40 -070065using testing::Pointee;
Darin Petkovf42cc1c2010-09-01 09:03:02 -070066using testing::Property;
67using testing::Return;
Gilad Arnold74b5f552014-10-07 08:17:16 -070068using testing::ReturnPointee;
Marton Hunyadye58bddb2018-04-10 20:27:26 +020069using testing::ReturnRef;
Alex Deymo2c0db7b2014-11-04 12:23:39 -080070using testing::SaveArg;
Ben Chan672c1f52017-10-23 15:41:39 -070071using testing::SetArgPointee;
Aaron Woodbf5a2522017-10-04 10:58:36 -070072using update_engine::UpdateAttemptFlags;
Aaron Wood7f92e2b2017-08-28 14:51:21 -070073using update_engine::UpdateEngineStatus;
Christopher Wiley6b6cc1b2015-10-05 17:50:07 -070074using update_engine::UpdateStatus;
Darin Petkovf42cc1c2010-09-01 09:03:02 -070075
76namespace chromeos_update_engine {
77
Marton Hunyadya0302682018-05-16 18:52:13 +020078const char kRollbackVersion[] = "10575.39.2";
79
Darin Petkovf42cc1c2010-09-01 09:03:02 -070080// Test a subclass rather than the main class directly so that we can mock out
Darin Petkovcd1666f2010-09-23 09:53:44 -070081// methods within the class. There're explicit unit tests for the mocked out
Darin Petkovf42cc1c2010-09-01 09:03:02 -070082// methods.
83class UpdateAttempterUnderTest : public UpdateAttempter {
84 public:
Jeffrey Kardatzkecf5f1f12017-10-02 16:08:44 -070085 explicit UpdateAttempterUnderTest(SystemState* system_state)
86 : UpdateAttempter(system_state, nullptr) {}
Gilad Arnoldec7f9162014-07-15 13:24:46 -070087
88 // Wrap the update scheduling method, allowing us to opt out of scheduled
89 // updates for testing purposes.
90 void ScheduleUpdates() override {
91 schedule_updates_called_ = true;
92 if (do_schedule_updates_) {
93 UpdateAttempter::ScheduleUpdates();
94 } else {
95 LOG(INFO) << "[TEST] Update scheduling disabled.";
96 }
97 }
98 void EnableScheduleUpdates() { do_schedule_updates_ = true; }
99 void DisableScheduleUpdates() { do_schedule_updates_ = false; }
100
101 // Indicates whether ScheduleUpdates() was called.
102 bool schedule_updates_called() const { return schedule_updates_called_; }
103
David Pursell02c18642014-11-06 11:26:11 -0800104 // Need to expose forced_omaha_url_ so we can test it.
Alex Deymo60ca1a72015-06-18 18:19:15 -0700105 const string& forced_omaha_url() const { return forced_omaha_url_; }
David Pursell02c18642014-11-06 11:26:11 -0800106
Gilad Arnoldec7f9162014-07-15 13:24:46 -0700107 private:
108 bool schedule_updates_called_ = false;
109 bool do_schedule_updates_ = true;
Darin Petkovf42cc1c2010-09-01 09:03:02 -0700110};
111
112class UpdateAttempterTest : public ::testing::Test {
113 protected:
Jay Srinivasan43488792012-06-19 00:25:31 -0700114 UpdateAttempterTest()
Daniel Erate5f6f252017-04-20 12:09:58 -0600115 : certificate_checker_(fake_system_state_.mock_prefs(),
Alex Deymo33e91e72015-12-01 18:26:08 -0300116 &openssl_wrapper_) {
Gilad Arnold1f847232014-04-07 12:07:49 -0700117 // Override system state members.
Gilad Arnold5bb4c902014-04-10 12:32:13 -0700118 fake_system_state_.set_connection_manager(&mock_connection_manager);
119 fake_system_state_.set_update_attempter(&attempter_);
Alex Deymo60ca1a72015-06-18 18:19:15 -0700120 loop_.SetAsCurrent();
Gilad Arnold1f847232014-04-07 12:07:49 -0700121
Alex Deymo33e91e72015-12-01 18:26:08 -0300122 certificate_checker_.Init();
123
Sen Jiange67bb5b2016-06-20 15:53:56 -0700124 // Finish initializing the attempter.
Gilad Arnold1f847232014-04-07 12:07:49 -0700125 attempter_.Init();
Jay Srinivasan43488792012-06-19 00:25:31 -0700126 }
Gilad Arnoldeff87cc2013-07-22 18:32:09 -0700127
Alex Deymo610277e2014-11-11 21:18:11 -0800128 void SetUp() override {
Alex Vakulenko88b591f2014-08-28 16:48:57 -0700129 EXPECT_NE(nullptr, attempter_.system_state_);
Darin Petkovf42cc1c2010-09-01 09:03:02 -0700130 EXPECT_EQ(0, attempter_.http_response_code_);
Christopher Wiley6b6cc1b2015-10-05 17:50:07 -0700131 EXPECT_EQ(UpdateStatus::IDLE, attempter_.status_);
Darin Petkovf42cc1c2010-09-01 09:03:02 -0700132 EXPECT_EQ(0.0, attempter_.download_progress_);
133 EXPECT_EQ(0, attempter_.last_checked_time_);
134 EXPECT_EQ("0.0.0.0", attempter_.new_version_);
Aaron Wood7f92e2b2017-08-28 14:51:21 -0700135 EXPECT_EQ(0ULL, attempter_.new_payload_size_);
Alex Deymo8427b4a2014-11-05 14:00:32 -0800136 processor_ = new NiceMock<MockActionProcessor>();
Darin Petkovf42cc1c2010-09-01 09:03:02 -0700137 attempter_.processor_.reset(processor_); // Transfers ownership.
Gilad Arnold5bb4c902014-04-10 12:32:13 -0700138 prefs_ = fake_system_state_.mock_prefs();
Gilad Arnold74b5f552014-10-07 08:17:16 -0700139
140 // Set up store/load semantics of P2P properties via the mock PayloadState.
141 actual_using_p2p_for_downloading_ = false;
142 EXPECT_CALL(*fake_system_state_.mock_payload_state(),
143 SetUsingP2PForDownloading(_))
144 .WillRepeatedly(SaveArg<0>(&actual_using_p2p_for_downloading_));
145 EXPECT_CALL(*fake_system_state_.mock_payload_state(),
146 GetUsingP2PForDownloading())
147 .WillRepeatedly(ReturnPointee(&actual_using_p2p_for_downloading_));
148 actual_using_p2p_for_sharing_ = false;
149 EXPECT_CALL(*fake_system_state_.mock_payload_state(),
150 SetUsingP2PForSharing(_))
151 .WillRepeatedly(SaveArg<0>(&actual_using_p2p_for_sharing_));
152 EXPECT_CALL(*fake_system_state_.mock_payload_state(),
153 GetUsingP2PForDownloading())
154 .WillRepeatedly(ReturnPointee(&actual_using_p2p_for_sharing_));
Darin Petkovf42cc1c2010-09-01 09:03:02 -0700155 }
156
Alex Deymo60ca1a72015-06-18 18:19:15 -0700157 public:
158 void ScheduleQuitMainLoop();
Patrick Dubroy7fbbe8a2011-08-01 17:28:22 +0200159
Alex Deymo60ca1a72015-06-18 18:19:15 -0700160 // Callbacks to run the different tests from the main loop.
Darin Petkove6ef2f82011-03-07 17:31:11 -0800161 void UpdateTestStart();
162 void UpdateTestVerify();
Alex Deymo60ca1a72015-06-18 18:19:15 -0700163 void RollbackTestStart(bool enterprise_rollback, bool valid_slot);
Chris Sosa76a29ae2013-07-11 17:59:24 -0700164 void RollbackTestVerify();
Thieu Le116fda32011-04-19 11:01:54 -0700165 void PingOmahaTestStart();
Jay Srinivasan480ddfa2012-06-01 19:15:26 -0700166 void ReadScatterFactorFromPolicyTestStart();
Jay Srinivasan480ddfa2012-06-01 19:15:26 -0700167 void DecrementUpdateCheckCountTestStart();
Jay Srinivasan08fce042012-06-07 16:31:01 -0700168 void NoScatteringDoneDuringManualUpdateTestStart();
David Zeuthen8f191b22013-08-06 12:27:50 -0700169 void P2PNotEnabledStart();
David Zeuthen8f191b22013-08-06 12:27:50 -0700170 void P2PEnabledStart();
David Zeuthen8f191b22013-08-06 12:27:50 -0700171 void P2PEnabledInteractiveStart();
David Zeuthen8f191b22013-08-06 12:27:50 -0700172 void P2PEnabledStartingFailsStart();
David Zeuthen8f191b22013-08-06 12:27:50 -0700173 void P2PEnabledHousekeepingFailsStart();
Marton Hunyadye58bddb2018-04-10 20:27:26 +0200174 void ResetRollbackHappenedStart(bool is_consumer,
175 bool is_policy_available,
176 bool expected_reset);
David Zeuthen8f191b22013-08-06 12:27:50 -0700177
Gilad Arnold74b5f552014-10-07 08:17:16 -0700178 bool actual_using_p2p_for_downloading() {
179 return actual_using_p2p_for_downloading_;
180 }
181 bool actual_using_p2p_for_sharing() {
182 return actual_using_p2p_for_sharing_;
183 }
184
Alex Deymo0b3db6b2015-08-10 15:19:37 -0700185 base::MessageLoopForIO base_loop_;
Alex Vakulenko3f39d5c2015-10-13 09:27:13 -0700186 brillo::BaseMessageLoop loop_{&base_loop_};
Alex Deymo60ca1a72015-06-18 18:19:15 -0700187
Gilad Arnold5bb4c902014-04-10 12:32:13 -0700188 FakeSystemState fake_system_state_;
Jeffrey Kardatzkecf5f1f12017-10-02 16:08:44 -0700189 UpdateAttempterUnderTest attempter_{&fake_system_state_};
Alex Deymo33e91e72015-12-01 18:26:08 -0300190 OpenSSLWrapper openssl_wrapper_;
191 CertificateChecker certificate_checker_;
Alex Deymo30534502015-07-20 15:06:33 -0700192
Alex Deymo8427b4a2014-11-05 14:00:32 -0800193 NiceMock<MockActionProcessor>* processor_;
194 NiceMock<MockPrefs>* prefs_; // Shortcut to fake_system_state_->mock_prefs().
Jay Srinivasan55f50c22013-01-10 19:24:35 -0800195 NiceMock<MockConnectionManager> mock_connection_manager;
Gilad Arnoldeff87cc2013-07-22 18:32:09 -0700196
Gilad Arnold74b5f552014-10-07 08:17:16 -0700197 bool actual_using_p2p_for_downloading_;
198 bool actual_using_p2p_for_sharing_;
Darin Petkovf42cc1c2010-09-01 09:03:02 -0700199};
200
Alex Deymo60ca1a72015-06-18 18:19:15 -0700201void UpdateAttempterTest::ScheduleQuitMainLoop() {
Luis Hector Chavezf1cf3482016-07-19 14:29:19 -0700202 loop_.PostTask(
203 FROM_HERE,
204 base::Bind([](brillo::BaseMessageLoop* loop) { loop->BreakLoop(); },
205 base::Unretained(&loop_)));
Alex Deymo60ca1a72015-06-18 18:19:15 -0700206}
207
Darin Petkov1b003102010-11-30 10:18:36 -0800208TEST_F(UpdateAttempterTest, ActionCompletedDownloadTest) {
Ben Chan02f7c1d2014-10-18 15:18:02 -0700209 unique_ptr<MockHttpFetcher> fetcher(new MockHttpFetcher("", 0, nullptr));
Darin Petkov1b003102010-11-30 10:18:36 -0800210 fetcher->FailTransfer(503); // Sets the HTTP response code.
Amin Hassani7ecda262017-07-11 17:10:50 -0700211 DownloadAction action(prefs_,
212 nullptr,
213 nullptr,
214 nullptr,
215 fetcher.release(),
Amin Hassanied37d682018-04-06 13:22:00 -0700216 false /* interactive */);
Jay Srinivasan6f6ea002012-12-14 11:26:28 -0800217 EXPECT_CALL(*prefs_, GetInt64(kPrefsDeltaUpdateFailures, _)).Times(0);
Alex Vakulenko88b591f2014-08-28 16:48:57 -0700218 attempter_.ActionCompleted(nullptr, &action, ErrorCode::kSuccess);
Christopher Wiley6b6cc1b2015-10-05 17:50:07 -0700219 EXPECT_EQ(UpdateStatus::FINALIZING, attempter_.status());
Aaron Wood9321f502017-09-07 11:18:54 -0700220 EXPECT_EQ(0.0, attempter_.download_progress_);
Alex Vakulenko88b591f2014-08-28 16:48:57 -0700221 ASSERT_EQ(nullptr, attempter_.error_event_.get());
Darin Petkov1b003102010-11-30 10:18:36 -0800222}
223
224TEST_F(UpdateAttempterTest, ActionCompletedErrorTest) {
Alex Deymo8427b4a2014-11-05 14:00:32 -0800225 MockAction action;
226 EXPECT_CALL(action, Type()).WillRepeatedly(Return("MockAction"));
Christopher Wiley6b6cc1b2015-10-05 17:50:07 -0700227 attempter_.status_ = UpdateStatus::DOWNLOADING;
Jay Srinivasan6f6ea002012-12-14 11:26:28 -0800228 EXPECT_CALL(*prefs_, GetInt64(kPrefsDeltaUpdateFailures, _))
Darin Petkov1b003102010-11-30 10:18:36 -0800229 .WillOnce(Return(false));
Alex Vakulenko88b591f2014-08-28 16:48:57 -0700230 attempter_.ActionCompleted(nullptr, &action, ErrorCode::kError);
231 ASSERT_NE(nullptr, attempter_.error_event_.get());
Darin Petkov1b003102010-11-30 10:18:36 -0800232}
233
Aaron Wood9321f502017-09-07 11:18:54 -0700234TEST_F(UpdateAttempterTest, DownloadProgressAccumulationTest) {
235 // Simple test case, where all the values match (nothing was skipped)
236 uint64_t bytes_progressed_1 = 1024 * 1024; // 1MB
237 uint64_t bytes_progressed_2 = 1024 * 1024; // 1MB
238 uint64_t bytes_received_1 = bytes_progressed_1;
239 uint64_t bytes_received_2 = bytes_received_1 + bytes_progressed_2;
240 uint64_t bytes_total = 20 * 1024 * 1024; // 20MB
241
242 double progress_1 =
243 static_cast<double>(bytes_received_1) / static_cast<double>(bytes_total);
244 double progress_2 =
245 static_cast<double>(bytes_received_2) / static_cast<double>(bytes_total);
246
247 EXPECT_EQ(0.0, attempter_.download_progress_);
248 // This is set via inspecting the InstallPlan payloads when the
249 // OmahaResponseAction is completed
250 attempter_.new_payload_size_ = bytes_total;
251 NiceMock<MockServiceObserver> observer;
252 EXPECT_CALL(observer,
Aaron Wood7f92e2b2017-08-28 14:51:21 -0700253 SendStatusUpdate(AllOf(
254 Field(&UpdateEngineStatus::progress, progress_1),
255 Field(&UpdateEngineStatus::status, UpdateStatus::DOWNLOADING),
256 Field(&UpdateEngineStatus::new_size_bytes, bytes_total))));
Aaron Wood9321f502017-09-07 11:18:54 -0700257 EXPECT_CALL(observer,
Aaron Wood7f92e2b2017-08-28 14:51:21 -0700258 SendStatusUpdate(AllOf(
259 Field(&UpdateEngineStatus::progress, progress_2),
260 Field(&UpdateEngineStatus::status, UpdateStatus::DOWNLOADING),
261 Field(&UpdateEngineStatus::new_size_bytes, bytes_total))));
Aaron Wood9321f502017-09-07 11:18:54 -0700262 attempter_.AddObserver(&observer);
263 attempter_.BytesReceived(bytes_progressed_1, bytes_received_1, bytes_total);
264 EXPECT_EQ(progress_1, attempter_.download_progress_);
265 // This iteration validates that a later set of updates to the variables are
266 // properly handled (so that |getStatus()| will return the same progress info
267 // as the callback is receiving.
268 attempter_.BytesReceived(bytes_progressed_2, bytes_received_2, bytes_total);
269 EXPECT_EQ(progress_2, attempter_.download_progress_);
270}
271
272TEST_F(UpdateAttempterTest, ChangeToDownloadingOnReceivedBytesTest) {
273 // The transition into UpdateStatus::DOWNLOADING happens when the
274 // first bytes are received.
275 uint64_t bytes_progressed = 1024 * 1024; // 1MB
276 uint64_t bytes_received = 2 * 1024 * 1024; // 2MB
277 uint64_t bytes_total = 20 * 1024 * 1024; // 300MB
278 attempter_.status_ = UpdateStatus::CHECKING_FOR_UPDATE;
279 // This is set via inspecting the InstallPlan payloads when the
280 // OmahaResponseAction is completed
281 attempter_.new_payload_size_ = bytes_total;
282 EXPECT_EQ(0.0, attempter_.download_progress_);
283 NiceMock<MockServiceObserver> observer;
Aaron Wood7f92e2b2017-08-28 14:51:21 -0700284 EXPECT_CALL(observer,
285 SendStatusUpdate(AllOf(
286 Field(&UpdateEngineStatus::status, UpdateStatus::DOWNLOADING),
287 Field(&UpdateEngineStatus::new_size_bytes, bytes_total))));
Aaron Wood9321f502017-09-07 11:18:54 -0700288 attempter_.AddObserver(&observer);
289 attempter_.BytesReceived(bytes_progressed, bytes_received, bytes_total);
290 EXPECT_EQ(UpdateStatus::DOWNLOADING, attempter_.status_);
291}
292
293TEST_F(UpdateAttempterTest, BroadcastCompleteDownloadTest) {
294 // There is a special case to ensure that at 100% downloaded,
295 // download_progress_ is updated and that value broadcast. This test confirms
296 // that.
297 uint64_t bytes_progressed = 0; // ignored
298 uint64_t bytes_received = 5 * 1024 * 1024; // ignored
299 uint64_t bytes_total = 5 * 1024 * 1024; // 300MB
300 attempter_.status_ = UpdateStatus::DOWNLOADING;
301 attempter_.new_payload_size_ = bytes_total;
302 EXPECT_EQ(0.0, attempter_.download_progress_);
303 NiceMock<MockServiceObserver> observer;
Aaron Wood7f92e2b2017-08-28 14:51:21 -0700304 EXPECT_CALL(observer,
305 SendStatusUpdate(AllOf(
306 Field(&UpdateEngineStatus::progress, 1.0),
307 Field(&UpdateEngineStatus::status, UpdateStatus::DOWNLOADING),
308 Field(&UpdateEngineStatus::new_size_bytes, bytes_total))));
Aaron Wood9321f502017-09-07 11:18:54 -0700309 attempter_.AddObserver(&observer);
310 attempter_.BytesReceived(bytes_progressed, bytes_received, bytes_total);
311 EXPECT_EQ(1.0, attempter_.download_progress_);
312}
313
Darin Petkov1b003102010-11-30 10:18:36 -0800314TEST_F(UpdateAttempterTest, ActionCompletedOmahaRequestTest) {
Ben Chan02f7c1d2014-10-18 15:18:02 -0700315 unique_ptr<MockHttpFetcher> fetcher(new MockHttpFetcher("", 0, nullptr));
Darin Petkov1b003102010-11-30 10:18:36 -0800316 fetcher->FailTransfer(500); // Sets the HTTP response code.
Alex Vakulenko88b591f2014-08-28 16:48:57 -0700317 OmahaRequestAction action(&fake_system_state_, nullptr,
Alex Deymoc1c17b42015-11-23 03:53:15 -0300318 std::move(fetcher), false);
Darin Petkov1b003102010-11-30 10:18:36 -0800319 ObjectCollectorAction<OmahaResponse> collector_action;
320 BondActions(&action, &collector_action);
321 OmahaResponse response;
322 response.poll_interval = 234;
323 action.SetOutputObject(response);
Jay Srinivasan6f6ea002012-12-14 11:26:28 -0800324 EXPECT_CALL(*prefs_, GetInt64(kPrefsDeltaUpdateFailures, _)).Times(0);
Alex Vakulenko88b591f2014-08-28 16:48:57 -0700325 attempter_.ActionCompleted(nullptr, &action, ErrorCode::kSuccess);
Darin Petkov1b003102010-11-30 10:18:36 -0800326 EXPECT_EQ(500, attempter_.http_response_code());
Christopher Wiley6b6cc1b2015-10-05 17:50:07 -0700327 EXPECT_EQ(UpdateStatus::IDLE, attempter_.status());
Alex Deymo80f70ff2016-02-10 16:08:11 -0800328 EXPECT_EQ(234U, attempter_.server_dictated_poll_interval_);
Alex Vakulenko88b591f2014-08-28 16:48:57 -0700329 ASSERT_TRUE(attempter_.error_event_.get() == nullptr);
Darin Petkov1b003102010-11-30 10:18:36 -0800330}
331
Alex Deymo30534502015-07-20 15:06:33 -0700332TEST_F(UpdateAttempterTest, ConstructWithUpdatedMarkerTest) {
Alex Deymo906191f2015-10-12 12:22:44 -0700333 FakePrefs fake_prefs;
334 string boot_id;
335 EXPECT_TRUE(utils::GetBootId(&boot_id));
336 fake_prefs.SetString(kPrefsUpdateCompletedOnBootId, boot_id);
337 fake_system_state_.set_prefs(&fake_prefs);
Sen Jiangaeeb2e02016-06-09 15:00:16 -0700338 attempter_.Init();
339 EXPECT_EQ(UpdateStatus::UPDATED_NEED_REBOOT, attempter_.status());
Darin Petkovf42cc1c2010-09-01 09:03:02 -0700340}
341
342TEST_F(UpdateAttempterTest, GetErrorCodeForActionTest) {
David Zeuthena99981f2013-04-29 13:42:47 -0700343 extern ErrorCode GetErrorCodeForAction(AbstractAction* action,
344 ErrorCode code);
Gilad Arnoldd1c4d2d2014-06-05 14:07:53 -0700345 EXPECT_EQ(ErrorCode::kSuccess,
Alex Vakulenko88b591f2014-08-28 16:48:57 -0700346 GetErrorCodeForAction(nullptr, ErrorCode::kSuccess));
Darin Petkovf42cc1c2010-09-01 09:03:02 -0700347
Gilad Arnold5bb4c902014-04-10 12:32:13 -0700348 FakeSystemState fake_system_state;
Alex Vakulenko88b591f2014-08-28 16:48:57 -0700349 OmahaRequestAction omaha_request_action(&fake_system_state, nullptr,
350 nullptr, false);
Gilad Arnoldd1c4d2d2014-06-05 14:07:53 -0700351 EXPECT_EQ(ErrorCode::kOmahaRequestError,
352 GetErrorCodeForAction(&omaha_request_action, ErrorCode::kError));
Gilad Arnold5bb4c902014-04-10 12:32:13 -0700353 OmahaResponseHandlerAction omaha_response_handler_action(&fake_system_state_);
Gilad Arnoldd1c4d2d2014-06-05 14:07:53 -0700354 EXPECT_EQ(ErrorCode::kOmahaResponseHandlerError,
Darin Petkovf42cc1c2010-09-01 09:03:02 -0700355 GetErrorCodeForAction(&omaha_response_handler_action,
Gilad Arnoldd1c4d2d2014-06-05 14:07:53 -0700356 ErrorCode::kError));
Sen Jiange6e4bb92016-04-05 14:59:12 -0700357 FilesystemVerifierAction filesystem_verifier_action;
Allie Woodeb9e6d82015-04-17 13:55:30 -0700358 EXPECT_EQ(ErrorCode::kFilesystemVerifierError,
359 GetErrorCodeForAction(&filesystem_verifier_action,
Gilad Arnoldd1c4d2d2014-06-05 14:07:53 -0700360 ErrorCode::kError));
Alex Deymob15a0b82015-11-25 20:30:40 -0300361 PostinstallRunnerAction postinstall_runner_action(
Alex Deymofb905d92016-06-03 19:26:58 -0700362 fake_system_state.fake_boot_control(), fake_system_state.fake_hardware());
Gilad Arnoldd1c4d2d2014-06-05 14:07:53 -0700363 EXPECT_EQ(ErrorCode::kPostinstallRunnerError,
Darin Petkovf42cc1c2010-09-01 09:03:02 -0700364 GetErrorCodeForAction(&postinstall_runner_action,
Gilad Arnoldd1c4d2d2014-06-05 14:07:53 -0700365 ErrorCode::kError));
Alex Deymo8427b4a2014-11-05 14:00:32 -0800366 MockAction action_mock;
367 EXPECT_CALL(action_mock, Type()).WillOnce(Return("MockAction"));
Gilad Arnoldd1c4d2d2014-06-05 14:07:53 -0700368 EXPECT_EQ(ErrorCode::kError,
369 GetErrorCodeForAction(&action_mock, ErrorCode::kError));
Darin Petkovf42cc1c2010-09-01 09:03:02 -0700370}
371
Darin Petkov36275772010-10-01 11:40:57 -0700372TEST_F(UpdateAttempterTest, DisableDeltaUpdateIfNeededTest) {
Jay Srinivasanae4697c2013-03-18 17:08:08 -0700373 attempter_.omaha_request_params_->set_delta_okay(true);
Jay Srinivasan6f6ea002012-12-14 11:26:28 -0800374 EXPECT_CALL(*prefs_, GetInt64(kPrefsDeltaUpdateFailures, _))
Darin Petkov36275772010-10-01 11:40:57 -0700375 .WillOnce(Return(false));
376 attempter_.DisableDeltaUpdateIfNeeded();
Jay Srinivasanae4697c2013-03-18 17:08:08 -0700377 EXPECT_TRUE(attempter_.omaha_request_params_->delta_okay());
Jay Srinivasan6f6ea002012-12-14 11:26:28 -0800378 EXPECT_CALL(*prefs_, GetInt64(kPrefsDeltaUpdateFailures, _))
Darin Petkov36275772010-10-01 11:40:57 -0700379 .WillOnce(DoAll(
Ben Chan672c1f52017-10-23 15:41:39 -0700380 SetArgPointee<1>(UpdateAttempter::kMaxDeltaUpdateFailures - 1),
Darin Petkov36275772010-10-01 11:40:57 -0700381 Return(true)));
382 attempter_.DisableDeltaUpdateIfNeeded();
Jay Srinivasanae4697c2013-03-18 17:08:08 -0700383 EXPECT_TRUE(attempter_.omaha_request_params_->delta_okay());
Jay Srinivasan6f6ea002012-12-14 11:26:28 -0800384 EXPECT_CALL(*prefs_, GetInt64(kPrefsDeltaUpdateFailures, _))
Darin Petkov36275772010-10-01 11:40:57 -0700385 .WillOnce(DoAll(
Ben Chan672c1f52017-10-23 15:41:39 -0700386 SetArgPointee<1>(UpdateAttempter::kMaxDeltaUpdateFailures),
Darin Petkov36275772010-10-01 11:40:57 -0700387 Return(true)));
388 attempter_.DisableDeltaUpdateIfNeeded();
Jay Srinivasanae4697c2013-03-18 17:08:08 -0700389 EXPECT_FALSE(attempter_.omaha_request_params_->delta_okay());
Jay Srinivasan6f6ea002012-12-14 11:26:28 -0800390 EXPECT_CALL(*prefs_, GetInt64(_, _)).Times(0);
Darin Petkov36275772010-10-01 11:40:57 -0700391 attempter_.DisableDeltaUpdateIfNeeded();
Jay Srinivasanae4697c2013-03-18 17:08:08 -0700392 EXPECT_FALSE(attempter_.omaha_request_params_->delta_okay());
Darin Petkov36275772010-10-01 11:40:57 -0700393}
394
395TEST_F(UpdateAttempterTest, MarkDeltaUpdateFailureTest) {
Jay Srinivasan6f6ea002012-12-14 11:26:28 -0800396 EXPECT_CALL(*prefs_, GetInt64(kPrefsDeltaUpdateFailures, _))
Darin Petkov36275772010-10-01 11:40:57 -0700397 .WillOnce(Return(false))
Ben Chan672c1f52017-10-23 15:41:39 -0700398 .WillOnce(DoAll(SetArgPointee<1>(-1), Return(true)))
399 .WillOnce(DoAll(SetArgPointee<1>(1), Return(true)))
Darin Petkov36275772010-10-01 11:40:57 -0700400 .WillOnce(DoAll(
Ben Chan672c1f52017-10-23 15:41:39 -0700401 SetArgPointee<1>(UpdateAttempter::kMaxDeltaUpdateFailures),
Darin Petkov36275772010-10-01 11:40:57 -0700402 Return(true)));
Jay Srinivasan6f6ea002012-12-14 11:26:28 -0800403 EXPECT_CALL(*prefs_, SetInt64(Ne(kPrefsDeltaUpdateFailures), _))
Darin Petkov2dd01092010-10-08 15:43:05 -0700404 .WillRepeatedly(Return(true));
Jay Srinivasan6f6ea002012-12-14 11:26:28 -0800405 EXPECT_CALL(*prefs_, SetInt64(kPrefsDeltaUpdateFailures, 1)).Times(2);
Gilad Arnold74b5f552014-10-07 08:17:16 -0700406 EXPECT_CALL(*prefs_, SetInt64(kPrefsDeltaUpdateFailures, 2));
Jay Srinivasan6f6ea002012-12-14 11:26:28 -0800407 EXPECT_CALL(*prefs_, SetInt64(kPrefsDeltaUpdateFailures,
Gilad Arnold74b5f552014-10-07 08:17:16 -0700408 UpdateAttempter::kMaxDeltaUpdateFailures + 1));
Darin Petkov36275772010-10-01 11:40:57 -0700409 for (int i = 0; i < 4; i ++)
410 attempter_.MarkDeltaUpdateFailure();
411}
412
Darin Petkov1b003102010-11-30 10:18:36 -0800413TEST_F(UpdateAttempterTest, ScheduleErrorEventActionNoEventTest) {
414 EXPECT_CALL(*processor_, EnqueueAction(_)).Times(0);
415 EXPECT_CALL(*processor_, StartProcessing()).Times(0);
Gilad Arnold5bb4c902014-04-10 12:32:13 -0700416 EXPECT_CALL(*fake_system_state_.mock_payload_state(), UpdateFailed(_))
Jay Srinivasan6f6ea002012-12-14 11:26:28 -0800417 .Times(0);
418 OmahaResponse response;
Jay Srinivasan53173b92013-05-17 17:13:01 -0700419 string url1 = "http://url1";
Sen Jiang0affc2c2017-02-10 15:55:05 -0800420 response.packages.push_back({.payload_urls = {url1, "https://url"}});
Gilad Arnold5bb4c902014-04-10 12:32:13 -0700421 EXPECT_CALL(*(fake_system_state_.mock_payload_state()), GetCurrentUrl())
Jay Srinivasan53173b92013-05-17 17:13:01 -0700422 .WillRepeatedly(Return(url1));
Gilad Arnold5bb4c902014-04-10 12:32:13 -0700423 fake_system_state_.mock_payload_state()->SetResponse(response);
Darin Petkov1b003102010-11-30 10:18:36 -0800424 attempter_.ScheduleErrorEventAction();
Gilad Arnold5bb4c902014-04-10 12:32:13 -0700425 EXPECT_EQ(url1, fake_system_state_.mock_payload_state()->GetCurrentUrl());
Darin Petkov1b003102010-11-30 10:18:36 -0800426}
427
428TEST_F(UpdateAttempterTest, ScheduleErrorEventActionTest) {
429 EXPECT_CALL(*processor_,
Amin Hassanid3f4bea2018-04-30 14:52:40 -0700430 EnqueueAction(Pointee(Property(
431 &AbstractAction::Type, OmahaRequestAction::StaticType()))));
Gilad Arnold74b5f552014-10-07 08:17:16 -0700432 EXPECT_CALL(*processor_, StartProcessing());
Gilad Arnoldd1c4d2d2014-06-05 14:07:53 -0700433 ErrorCode err = ErrorCode::kError;
Gilad Arnold5bb4c902014-04-10 12:32:13 -0700434 EXPECT_CALL(*fake_system_state_.mock_payload_state(), UpdateFailed(err));
Darin Petkov1b003102010-11-30 10:18:36 -0800435 attempter_.error_event_.reset(new OmahaEvent(OmahaEvent::kTypeUpdateComplete,
436 OmahaEvent::kResultError,
Jay Srinivasan6f6ea002012-12-14 11:26:28 -0800437 err));
Darin Petkov1b003102010-11-30 10:18:36 -0800438 attempter_.ScheduleErrorEventAction();
Christopher Wiley6b6cc1b2015-10-05 17:50:07 -0700439 EXPECT_EQ(UpdateStatus::REPORTING_ERROR_EVENT, attempter_.status());
Darin Petkov1b003102010-11-30 10:18:36 -0800440}
441
Darin Petkove6ef2f82011-03-07 17:31:11 -0800442namespace {
Chris Sosa76a29ae2013-07-11 17:59:24 -0700443// Actions that will be built as part of an update check.
Alex Vakulenkod2779df2014-06-16 13:19:00 -0700444const string kUpdateActionTypes[] = { // NOLINT(runtime/string)
Darin Petkove6ef2f82011-03-07 17:31:11 -0800445 OmahaRequestAction::StaticType(),
446 OmahaResponseHandlerAction::StaticType(),
Darin Petkove6ef2f82011-03-07 17:31:11 -0800447 OmahaRequestAction::StaticType(),
448 DownloadAction::StaticType(),
449 OmahaRequestAction::StaticType(),
Allie Woodeb9e6d82015-04-17 13:55:30 -0700450 FilesystemVerifierAction::StaticType(),
Darin Petkove6ef2f82011-03-07 17:31:11 -0800451 PostinstallRunnerAction::StaticType(),
452 OmahaRequestAction::StaticType()
453};
Chris Sosa76a29ae2013-07-11 17:59:24 -0700454
455// Actions that will be built as part of a user-initiated rollback.
Alex Vakulenkod2779df2014-06-16 13:19:00 -0700456const string kRollbackActionTypes[] = { // NOLINT(runtime/string)
Chris Sosa76a29ae2013-07-11 17:59:24 -0700457 InstallPlanAction::StaticType(),
458 PostinstallRunnerAction::StaticType(),
459};
460
Alex Vakulenkod2779df2014-06-16 13:19:00 -0700461} // namespace
Darin Petkove6ef2f82011-03-07 17:31:11 -0800462
463void UpdateAttempterTest::UpdateTestStart() {
Darin Petkovf42cc1c2010-09-01 09:03:02 -0700464 attempter_.set_http_response_code(200);
Alex Deymo749ecf12014-10-21 20:06:57 -0700465
466 // Expect that the device policy is loaded by the UpdateAttempter at some
467 // point by calling RefreshDevicePolicy.
Igor9fd76b62017-12-11 15:24:18 +0100468 auto device_policy = std::make_unique<policy::MockDevicePolicy>();
Alex Deymo749ecf12014-10-21 20:06:57 -0700469 EXPECT_CALL(*device_policy, LoadPolicy())
470 .Times(testing::AtLeast(1)).WillRepeatedly(Return(true));
Igor9fd76b62017-12-11 15:24:18 +0100471 attempter_.policy_provider_.reset(
472 new policy::PolicyProvider(std::move(device_policy)));
Alex Deymo749ecf12014-10-21 20:06:57 -0700473
474 {
475 InSequence s;
476 for (size_t i = 0; i < arraysize(kUpdateActionTypes); ++i) {
477 EXPECT_CALL(*processor_,
Amin Hassanid3f4bea2018-04-30 14:52:40 -0700478 EnqueueAction(Pointee(
479 Property(&AbstractAction::Type, kUpdateActionTypes[i]))));
Alex Deymo749ecf12014-10-21 20:06:57 -0700480 }
Gilad Arnold74b5f552014-10-07 08:17:16 -0700481 EXPECT_CALL(*processor_, StartProcessing());
Darin Petkovf42cc1c2010-09-01 09:03:02 -0700482 }
Darin Petkovf42cc1c2010-09-01 09:03:02 -0700483
Marton Hunyadyba51c3f2018-04-25 15:18:10 +0200484 attempter_.Update("", "", "", "", false, false, false);
Alex Deymo60ca1a72015-06-18 18:19:15 -0700485 loop_.PostTask(FROM_HERE,
486 base::Bind(&UpdateAttempterTest::UpdateTestVerify,
487 base::Unretained(this)));
Darin Petkove6ef2f82011-03-07 17:31:11 -0800488}
Darin Petkovf42cc1c2010-09-01 09:03:02 -0700489
Darin Petkove6ef2f82011-03-07 17:31:11 -0800490void UpdateAttempterTest::UpdateTestVerify() {
Darin Petkovf42cc1c2010-09-01 09:03:02 -0700491 EXPECT_EQ(0, attempter_.http_response_code());
492 EXPECT_EQ(&attempter_, processor_->delegate());
Christopher Wiley6b6cc1b2015-10-05 17:50:07 -0700493 EXPECT_EQ(UpdateStatus::CHECKING_FOR_UPDATE, attempter_.status());
Alex Deymo60ca1a72015-06-18 18:19:15 -0700494 loop_.BreakLoop();
Darin Petkove6ef2f82011-03-07 17:31:11 -0800495}
496
Chris Sosa28e479c2013-07-12 11:39:53 -0700497void UpdateAttempterTest::RollbackTestStart(
Chris Sosa44b9b7e2014-04-02 13:53:46 -0700498 bool enterprise_rollback, bool valid_slot) {
Chris Sosa76a29ae2013-07-11 17:59:24 -0700499 // Create a device policy so that we can change settings.
Igor9fd76b62017-12-11 15:24:18 +0100500 auto device_policy = std::make_unique<policy::MockDevicePolicy>();
Chris Sosa76a29ae2013-07-11 17:59:24 -0700501 EXPECT_CALL(*device_policy, LoadPolicy()).WillRepeatedly(Return(true));
Igor9fd76b62017-12-11 15:24:18 +0100502 fake_system_state_.set_device_policy(device_policy.get());
503 if (enterprise_rollback) {
504 // We return an empty owner as this is an enterprise.
505 EXPECT_CALL(*device_policy, GetOwner(_)).WillRepeatedly(
506 DoAll(SetArgPointee<0>(string("")),
507 Return(true)));
508 } else {
509 // We return a fake owner as this is an owned consumer device.
510 EXPECT_CALL(*device_policy, GetOwner(_)).WillRepeatedly(
511 DoAll(SetArgPointee<0>(string("fake.mail@fake.com")),
512 Return(true)));
513 }
514
515 attempter_.policy_provider_.reset(
516 new policy::PolicyProvider(std::move(device_policy)));
Chris Sosa76a29ae2013-07-11 17:59:24 -0700517
Alex Deymo763e7db2015-08-27 21:08:08 -0700518 if (valid_slot) {
519 BootControlInterface::Slot rollback_slot = 1;
520 LOG(INFO) << "Test Mark Bootable: "
521 << BootControlInterface::SlotName(rollback_slot);
Alex Deymoe5e5fe92015-10-05 09:28:19 -0700522 fake_system_state_.fake_boot_control()->SetSlotBootable(rollback_slot,
523 true);
Don Garrett6646b442013-11-13 15:29:11 -0800524 }
525
Chris Sosa28e479c2013-07-12 11:39:53 -0700526 bool is_rollback_allowed = false;
Chris Sosa76a29ae2013-07-11 17:59:24 -0700527
Chris Sosad38b1132014-03-25 10:43:59 -0700528 // We only allow rollback on devices that are not enterprise enrolled and
529 // which have a valid slot to rollback to.
530 if (!enterprise_rollback && valid_slot) {
Chris Sosa28e479c2013-07-12 11:39:53 -0700531 is_rollback_allowed = true;
532 }
533
Chris Sosa28e479c2013-07-12 11:39:53 -0700534 if (is_rollback_allowed) {
Chris Sosa76a29ae2013-07-11 17:59:24 -0700535 InSequence s;
536 for (size_t i = 0; i < arraysize(kRollbackActionTypes); ++i) {
537 EXPECT_CALL(*processor_,
Amin Hassanid3f4bea2018-04-30 14:52:40 -0700538 EnqueueAction(Pointee(Property(&AbstractAction::Type,
539 kRollbackActionTypes[i]))));
Chris Sosa76a29ae2013-07-11 17:59:24 -0700540 }
Gilad Arnold74b5f552014-10-07 08:17:16 -0700541 EXPECT_CALL(*processor_, StartProcessing());
Chris Sosa76a29ae2013-07-11 17:59:24 -0700542
Chris Sosa44b9b7e2014-04-02 13:53:46 -0700543 EXPECT_TRUE(attempter_.Rollback(true));
Alex Deymo60ca1a72015-06-18 18:19:15 -0700544 loop_.PostTask(FROM_HERE,
545 base::Bind(&UpdateAttempterTest::RollbackTestVerify,
546 base::Unretained(this)));
Chris Sosa76a29ae2013-07-11 17:59:24 -0700547 } else {
Chris Sosa44b9b7e2014-04-02 13:53:46 -0700548 EXPECT_FALSE(attempter_.Rollback(true));
Alex Deymo60ca1a72015-06-18 18:19:15 -0700549 loop_.BreakLoop();
Chris Sosa76a29ae2013-07-11 17:59:24 -0700550 }
551}
552
553void UpdateAttempterTest::RollbackTestVerify() {
554 // Verifies the actions that were enqueued.
555 EXPECT_EQ(&attempter_, processor_->delegate());
Christopher Wiley6b6cc1b2015-10-05 17:50:07 -0700556 EXPECT_EQ(UpdateStatus::ATTEMPTING_ROLLBACK, attempter_.status());
Amin Hassanid3f4bea2018-04-30 14:52:40 -0700557 EXPECT_EQ(0U, attempter_.install_plan_->partitions.size());
558 EXPECT_EQ(attempter_.install_plan_->powerwash_required, true);
Alex Deymo60ca1a72015-06-18 18:19:15 -0700559 loop_.BreakLoop();
Chris Sosa76a29ae2013-07-11 17:59:24 -0700560}
561
Darin Petkove6ef2f82011-03-07 17:31:11 -0800562TEST_F(UpdateAttempterTest, UpdateTest) {
Alex Deymo461b2592015-07-24 20:10:52 -0700563 UpdateTestStart();
Alex Deymo60ca1a72015-06-18 18:19:15 -0700564 loop_.Run();
Darin Petkovf42cc1c2010-09-01 09:03:02 -0700565}
566
Chris Sosa76a29ae2013-07-11 17:59:24 -0700567TEST_F(UpdateAttempterTest, RollbackTest) {
Alex Deymo60ca1a72015-06-18 18:19:15 -0700568 loop_.PostTask(FROM_HERE,
569 base::Bind(&UpdateAttempterTest::RollbackTestStart,
570 base::Unretained(this),
571 false, true));
572 loop_.Run();
Chris Sosa76a29ae2013-07-11 17:59:24 -0700573}
574
Don Garrett6646b442013-11-13 15:29:11 -0800575TEST_F(UpdateAttempterTest, InvalidSlotRollbackTest) {
Alex Deymo60ca1a72015-06-18 18:19:15 -0700576 loop_.PostTask(FROM_HERE,
577 base::Bind(&UpdateAttempterTest::RollbackTestStart,
578 base::Unretained(this),
579 false, false));
580 loop_.Run();
Don Garrett6646b442013-11-13 15:29:11 -0800581}
582
Chris Sosa76a29ae2013-07-11 17:59:24 -0700583TEST_F(UpdateAttempterTest, EnterpriseRollbackTest) {
Alex Deymo60ca1a72015-06-18 18:19:15 -0700584 loop_.PostTask(FROM_HERE,
585 base::Bind(&UpdateAttempterTest::RollbackTestStart,
586 base::Unretained(this),
587 true, true));
588 loop_.Run();
Chris Sosa76a29ae2013-07-11 17:59:24 -0700589}
590
Thieu Le116fda32011-04-19 11:01:54 -0700591void UpdateAttempterTest::PingOmahaTestStart() {
592 EXPECT_CALL(*processor_,
Amin Hassanid3f4bea2018-04-30 14:52:40 -0700593 EnqueueAction(Pointee(Property(
594 &AbstractAction::Type, OmahaRequestAction::StaticType()))));
Gilad Arnold74b5f552014-10-07 08:17:16 -0700595 EXPECT_CALL(*processor_, StartProcessing());
Thieu Le116fda32011-04-19 11:01:54 -0700596 attempter_.PingOmaha();
Alex Deymo60ca1a72015-06-18 18:19:15 -0700597 ScheduleQuitMainLoop();
Thieu Le116fda32011-04-19 11:01:54 -0700598}
599
600TEST_F(UpdateAttempterTest, PingOmahaTest) {
Gilad Arnoldec7f9162014-07-15 13:24:46 -0700601 EXPECT_FALSE(attempter_.waiting_for_scheduled_check_);
602 EXPECT_FALSE(attempter_.schedule_updates_called());
603 // Disable scheduling of subsequnet checks; we're using the DefaultPolicy in
604 // testing, which is more permissive than we want to handle here.
605 attempter_.DisableScheduleUpdates();
Alex Deymo60ca1a72015-06-18 18:19:15 -0700606 loop_.PostTask(FROM_HERE,
607 base::Bind(&UpdateAttempterTest::PingOmahaTestStart,
608 base::Unretained(this)));
Alex Vakulenko3f39d5c2015-10-13 09:27:13 -0700609 brillo::MessageLoopRunMaxIterations(&loop_, 100);
Christopher Wiley6b6cc1b2015-10-05 17:50:07 -0700610 EXPECT_EQ(UpdateStatus::UPDATED_NEED_REBOOT, attempter_.status());
Gilad Arnoldec7f9162014-07-15 13:24:46 -0700611 EXPECT_TRUE(attempter_.schedule_updates_called());
Thieu Le116fda32011-04-19 11:01:54 -0700612}
613
Darin Petkov18c7bce2011-06-16 14:07:00 -0700614TEST_F(UpdateAttempterTest, CreatePendingErrorEventTest) {
Alex Deymo8427b4a2014-11-05 14:00:32 -0800615 MockAction action;
Gilad Arnoldd1c4d2d2014-06-05 14:07:53 -0700616 const ErrorCode kCode = ErrorCode::kDownloadTransferError;
Darin Petkov18c7bce2011-06-16 14:07:00 -0700617 attempter_.CreatePendingErrorEvent(&action, kCode);
Alex Vakulenko88b591f2014-08-28 16:48:57 -0700618 ASSERT_NE(nullptr, attempter_.error_event_.get());
Darin Petkov18c7bce2011-06-16 14:07:00 -0700619 EXPECT_EQ(OmahaEvent::kTypeUpdateComplete, attempter_.error_event_->type);
620 EXPECT_EQ(OmahaEvent::kResultError, attempter_.error_event_->result);
Gilad Arnoldd1c4d2d2014-06-05 14:07:53 -0700621 EXPECT_EQ(
622 static_cast<ErrorCode>(static_cast<int>(kCode) |
623 static_cast<int>(ErrorCode::kTestOmahaUrlFlag)),
624 attempter_.error_event_->error_code);
Darin Petkov18c7bce2011-06-16 14:07:00 -0700625}
626
627TEST_F(UpdateAttempterTest, CreatePendingErrorEventResumedTest) {
Amin Hassanid3f4bea2018-04-30 14:52:40 -0700628 attempter_.install_plan_.reset(new InstallPlan);
629 attempter_.install_plan_->is_resume = true;
Alex Deymo8427b4a2014-11-05 14:00:32 -0800630 MockAction action;
Gilad Arnoldd1c4d2d2014-06-05 14:07:53 -0700631 const ErrorCode kCode = ErrorCode::kInstallDeviceOpenError;
Darin Petkov18c7bce2011-06-16 14:07:00 -0700632 attempter_.CreatePendingErrorEvent(&action, kCode);
Alex Vakulenko88b591f2014-08-28 16:48:57 -0700633 ASSERT_NE(nullptr, attempter_.error_event_.get());
Darin Petkov18c7bce2011-06-16 14:07:00 -0700634 EXPECT_EQ(OmahaEvent::kTypeUpdateComplete, attempter_.error_event_->type);
635 EXPECT_EQ(OmahaEvent::kResultError, attempter_.error_event_->result);
Gilad Arnoldd1c4d2d2014-06-05 14:07:53 -0700636 EXPECT_EQ(
637 static_cast<ErrorCode>(
638 static_cast<int>(kCode) |
639 static_cast<int>(ErrorCode::kResumedFlag) |
640 static_cast<int>(ErrorCode::kTestOmahaUrlFlag)),
641 attempter_.error_event_->error_code);
Darin Petkov18c7bce2011-06-16 14:07:00 -0700642}
643
David Zeuthen8f191b22013-08-06 12:27:50 -0700644TEST_F(UpdateAttempterTest, P2PNotStartedAtStartupWhenNotEnabled) {
645 MockP2PManager mock_p2p_manager;
Gilad Arnold5bb4c902014-04-10 12:32:13 -0700646 fake_system_state_.set_p2p_manager(&mock_p2p_manager);
David Zeuthen8f191b22013-08-06 12:27:50 -0700647 mock_p2p_manager.fake().SetP2PEnabled(false);
648 EXPECT_CALL(mock_p2p_manager, EnsureP2PRunning()).Times(0);
649 attempter_.UpdateEngineStarted();
650}
651
652TEST_F(UpdateAttempterTest, P2PNotStartedAtStartupWhenEnabledButNotSharing) {
653 MockP2PManager mock_p2p_manager;
Gilad Arnold5bb4c902014-04-10 12:32:13 -0700654 fake_system_state_.set_p2p_manager(&mock_p2p_manager);
David Zeuthen8f191b22013-08-06 12:27:50 -0700655 mock_p2p_manager.fake().SetP2PEnabled(true);
656 EXPECT_CALL(mock_p2p_manager, EnsureP2PRunning()).Times(0);
657 attempter_.UpdateEngineStarted();
658}
659
660TEST_F(UpdateAttempterTest, P2PStartedAtStartupWhenEnabledAndSharing) {
661 MockP2PManager mock_p2p_manager;
Gilad Arnold5bb4c902014-04-10 12:32:13 -0700662 fake_system_state_.set_p2p_manager(&mock_p2p_manager);
David Zeuthen8f191b22013-08-06 12:27:50 -0700663 mock_p2p_manager.fake().SetP2PEnabled(true);
664 mock_p2p_manager.fake().SetCountSharedFilesResult(1);
Gilad Arnold74b5f552014-10-07 08:17:16 -0700665 EXPECT_CALL(mock_p2p_manager, EnsureP2PRunning());
David Zeuthen8f191b22013-08-06 12:27:50 -0700666 attempter_.UpdateEngineStarted();
667}
668
669TEST_F(UpdateAttempterTest, P2PNotEnabled) {
Alex Deymo60ca1a72015-06-18 18:19:15 -0700670 loop_.PostTask(FROM_HERE,
671 base::Bind(&UpdateAttempterTest::P2PNotEnabledStart,
672 base::Unretained(this)));
673 loop_.Run();
David Zeuthen8f191b22013-08-06 12:27:50 -0700674}
Alex Deymo60ca1a72015-06-18 18:19:15 -0700675
David Zeuthen8f191b22013-08-06 12:27:50 -0700676void UpdateAttempterTest::P2PNotEnabledStart() {
677 // If P2P is not enabled, check that we do not attempt housekeeping
678 // and do not convey that p2p is to be used.
679 MockP2PManager mock_p2p_manager;
Gilad Arnold5bb4c902014-04-10 12:32:13 -0700680 fake_system_state_.set_p2p_manager(&mock_p2p_manager);
David Zeuthen8f191b22013-08-06 12:27:50 -0700681 mock_p2p_manager.fake().SetP2PEnabled(false);
682 EXPECT_CALL(mock_p2p_manager, PerformHousekeeping()).Times(0);
Marton Hunyadyba51c3f2018-04-25 15:18:10 +0200683 attempter_.Update("", "", "", "", false, false, false);
Alex Deymo60ca1a72015-06-18 18:19:15 -0700684 EXPECT_FALSE(actual_using_p2p_for_downloading_);
Gilad Arnold74b5f552014-10-07 08:17:16 -0700685 EXPECT_FALSE(actual_using_p2p_for_sharing());
Alex Deymo60ca1a72015-06-18 18:19:15 -0700686 ScheduleQuitMainLoop();
David Zeuthen8f191b22013-08-06 12:27:50 -0700687}
688
689TEST_F(UpdateAttempterTest, P2PEnabledStartingFails) {
Alex Deymo60ca1a72015-06-18 18:19:15 -0700690 loop_.PostTask(FROM_HERE,
691 base::Bind(&UpdateAttempterTest::P2PEnabledStartingFailsStart,
692 base::Unretained(this)));
693 loop_.Run();
David Zeuthen8f191b22013-08-06 12:27:50 -0700694}
Alex Deymo60ca1a72015-06-18 18:19:15 -0700695
David Zeuthen8f191b22013-08-06 12:27:50 -0700696void UpdateAttempterTest::P2PEnabledStartingFailsStart() {
697 // If p2p is enabled, but starting it fails ensure we don't do
698 // any housekeeping and do not convey that p2p should be used.
699 MockP2PManager mock_p2p_manager;
Gilad Arnold5bb4c902014-04-10 12:32:13 -0700700 fake_system_state_.set_p2p_manager(&mock_p2p_manager);
David Zeuthen8f191b22013-08-06 12:27:50 -0700701 mock_p2p_manager.fake().SetP2PEnabled(true);
702 mock_p2p_manager.fake().SetEnsureP2PRunningResult(false);
703 mock_p2p_manager.fake().SetPerformHousekeepingResult(false);
704 EXPECT_CALL(mock_p2p_manager, PerformHousekeeping()).Times(0);
Marton Hunyadyba51c3f2018-04-25 15:18:10 +0200705 attempter_.Update("", "", "", "", false, false, false);
Gilad Arnold74b5f552014-10-07 08:17:16 -0700706 EXPECT_FALSE(actual_using_p2p_for_downloading());
707 EXPECT_FALSE(actual_using_p2p_for_sharing());
Alex Deymo60ca1a72015-06-18 18:19:15 -0700708 ScheduleQuitMainLoop();
David Zeuthen8f191b22013-08-06 12:27:50 -0700709}
710
711TEST_F(UpdateAttempterTest, P2PEnabledHousekeepingFails) {
Alex Deymo60ca1a72015-06-18 18:19:15 -0700712 loop_.PostTask(
713 FROM_HERE,
714 base::Bind(&UpdateAttempterTest::P2PEnabledHousekeepingFailsStart,
715 base::Unretained(this)));
716 loop_.Run();
David Zeuthen8f191b22013-08-06 12:27:50 -0700717}
Alex Deymo60ca1a72015-06-18 18:19:15 -0700718
David Zeuthen8f191b22013-08-06 12:27:50 -0700719void UpdateAttempterTest::P2PEnabledHousekeepingFailsStart() {
720 // If p2p is enabled, starting it works but housekeeping fails, ensure
721 // we do not convey p2p is to be used.
722 MockP2PManager mock_p2p_manager;
Gilad Arnold5bb4c902014-04-10 12:32:13 -0700723 fake_system_state_.set_p2p_manager(&mock_p2p_manager);
David Zeuthen8f191b22013-08-06 12:27:50 -0700724 mock_p2p_manager.fake().SetP2PEnabled(true);
725 mock_p2p_manager.fake().SetEnsureP2PRunningResult(true);
726 mock_p2p_manager.fake().SetPerformHousekeepingResult(false);
Gilad Arnold74b5f552014-10-07 08:17:16 -0700727 EXPECT_CALL(mock_p2p_manager, PerformHousekeeping());
Marton Hunyadyba51c3f2018-04-25 15:18:10 +0200728 attempter_.Update("", "", "", "", false, false, false);
Gilad Arnold74b5f552014-10-07 08:17:16 -0700729 EXPECT_FALSE(actual_using_p2p_for_downloading());
730 EXPECT_FALSE(actual_using_p2p_for_sharing());
Alex Deymo60ca1a72015-06-18 18:19:15 -0700731 ScheduleQuitMainLoop();
David Zeuthen8f191b22013-08-06 12:27:50 -0700732}
733
734TEST_F(UpdateAttempterTest, P2PEnabled) {
Alex Deymo60ca1a72015-06-18 18:19:15 -0700735 loop_.PostTask(FROM_HERE,
736 base::Bind(&UpdateAttempterTest::P2PEnabledStart,
737 base::Unretained(this)));
738 loop_.Run();
David Zeuthen8f191b22013-08-06 12:27:50 -0700739}
Alex Deymo60ca1a72015-06-18 18:19:15 -0700740
David Zeuthen8f191b22013-08-06 12:27:50 -0700741void UpdateAttempterTest::P2PEnabledStart() {
742 MockP2PManager mock_p2p_manager;
Gilad Arnold5bb4c902014-04-10 12:32:13 -0700743 fake_system_state_.set_p2p_manager(&mock_p2p_manager);
David Zeuthen8f191b22013-08-06 12:27:50 -0700744 // If P2P is enabled and starting it works, check that we performed
745 // housekeeping and that we convey p2p should be used.
746 mock_p2p_manager.fake().SetP2PEnabled(true);
747 mock_p2p_manager.fake().SetEnsureP2PRunningResult(true);
748 mock_p2p_manager.fake().SetPerformHousekeepingResult(true);
Gilad Arnold74b5f552014-10-07 08:17:16 -0700749 EXPECT_CALL(mock_p2p_manager, PerformHousekeeping());
Marton Hunyadyba51c3f2018-04-25 15:18:10 +0200750 attempter_.Update("", "", "", "", false, false, false);
Gilad Arnold74b5f552014-10-07 08:17:16 -0700751 EXPECT_TRUE(actual_using_p2p_for_downloading());
752 EXPECT_TRUE(actual_using_p2p_for_sharing());
Alex Deymo60ca1a72015-06-18 18:19:15 -0700753 ScheduleQuitMainLoop();
David Zeuthen8f191b22013-08-06 12:27:50 -0700754}
755
756TEST_F(UpdateAttempterTest, P2PEnabledInteractive) {
Alex Deymo60ca1a72015-06-18 18:19:15 -0700757 loop_.PostTask(FROM_HERE,
758 base::Bind(&UpdateAttempterTest::P2PEnabledInteractiveStart,
759 base::Unretained(this)));
760 loop_.Run();
David Zeuthen8f191b22013-08-06 12:27:50 -0700761}
Alex Deymo60ca1a72015-06-18 18:19:15 -0700762
David Zeuthen8f191b22013-08-06 12:27:50 -0700763void UpdateAttempterTest::P2PEnabledInteractiveStart() {
764 MockP2PManager mock_p2p_manager;
Gilad Arnold5bb4c902014-04-10 12:32:13 -0700765 fake_system_state_.set_p2p_manager(&mock_p2p_manager);
David Zeuthen8f191b22013-08-06 12:27:50 -0700766 // For an interactive check, if P2P is enabled and starting it
767 // works, check that we performed housekeeping and that we convey
768 // p2p should be used for sharing but NOT for downloading.
769 mock_p2p_manager.fake().SetP2PEnabled(true);
770 mock_p2p_manager.fake().SetEnsureP2PRunningResult(true);
771 mock_p2p_manager.fake().SetPerformHousekeepingResult(true);
Gilad Arnold74b5f552014-10-07 08:17:16 -0700772 EXPECT_CALL(mock_p2p_manager, PerformHousekeeping());
Marton Hunyadyba51c3f2018-04-25 15:18:10 +0200773 attempter_.Update("",
774 "",
775 "",
776 "",
777 false,
778 false,
779 /*interactive=*/true);
Gilad Arnold74b5f552014-10-07 08:17:16 -0700780 EXPECT_FALSE(actual_using_p2p_for_downloading());
781 EXPECT_TRUE(actual_using_p2p_for_sharing());
Alex Deymo60ca1a72015-06-18 18:19:15 -0700782 ScheduleQuitMainLoop();
David Zeuthen8f191b22013-08-06 12:27:50 -0700783}
784
Jay Srinivasan480ddfa2012-06-01 19:15:26 -0700785TEST_F(UpdateAttempterTest, ReadScatterFactorFromPolicy) {
Alex Deymo60ca1a72015-06-18 18:19:15 -0700786 loop_.PostTask(
787 FROM_HERE,
788 base::Bind(&UpdateAttempterTest::ReadScatterFactorFromPolicyTestStart,
789 base::Unretained(this)));
790 loop_.Run();
Jay Srinivasan480ddfa2012-06-01 19:15:26 -0700791}
792
793// Tests that the scatter_factor_in_seconds value is properly fetched
794// from the device policy.
795void UpdateAttempterTest::ReadScatterFactorFromPolicyTestStart() {
Ben Chan9abb7632014-08-07 00:10:53 -0700796 int64_t scatter_factor_in_seconds = 36000;
Jay Srinivasan480ddfa2012-06-01 19:15:26 -0700797
Igor9fd76b62017-12-11 15:24:18 +0100798 auto device_policy = std::make_unique<policy::MockDevicePolicy>();
Jay Srinivasan480ddfa2012-06-01 19:15:26 -0700799 EXPECT_CALL(*device_policy, LoadPolicy()).WillRepeatedly(Return(true));
Igor9fd76b62017-12-11 15:24:18 +0100800 fake_system_state_.set_device_policy(device_policy.get());
Jay Srinivasan480ddfa2012-06-01 19:15:26 -0700801
802 EXPECT_CALL(*device_policy, GetScatterFactorInSeconds(_))
803 .WillRepeatedly(DoAll(
Ben Chan672c1f52017-10-23 15:41:39 -0700804 SetArgPointee<0>(scatter_factor_in_seconds),
Jay Srinivasan480ddfa2012-06-01 19:15:26 -0700805 Return(true)));
806
Igor9fd76b62017-12-11 15:24:18 +0100807 attempter_.policy_provider_.reset(
808 new policy::PolicyProvider(std::move(device_policy)));
809
Marton Hunyadyba51c3f2018-04-25 15:18:10 +0200810 attempter_.Update("", "", "", "", false, false, false);
Jay Srinivasan480ddfa2012-06-01 19:15:26 -0700811 EXPECT_EQ(scatter_factor_in_seconds, attempter_.scatter_factor_.InSeconds());
812
Alex Deymo60ca1a72015-06-18 18:19:15 -0700813 ScheduleQuitMainLoop();
Jay Srinivasan480ddfa2012-06-01 19:15:26 -0700814}
815
816TEST_F(UpdateAttempterTest, DecrementUpdateCheckCountTest) {
Alex Deymo60ca1a72015-06-18 18:19:15 -0700817 loop_.PostTask(
818 FROM_HERE,
819 base::Bind(&UpdateAttempterTest::DecrementUpdateCheckCountTestStart,
820 base::Unretained(this)));
821 loop_.Run();
Jay Srinivasan480ddfa2012-06-01 19:15:26 -0700822}
823
824void UpdateAttempterTest::DecrementUpdateCheckCountTestStart() {
825 // Tests that the scatter_factor_in_seconds value is properly fetched
826 // from the device policy and is decremented if value > 0.
Ben Chan9abb7632014-08-07 00:10:53 -0700827 int64_t initial_value = 5;
Alex Deymo2c0db7b2014-11-04 12:23:39 -0800828 FakePrefs fake_prefs;
829 attempter_.prefs_ = &fake_prefs;
Jay Srinivasan480ddfa2012-06-01 19:15:26 -0700830
Gilad Arnold5bb4c902014-04-10 12:32:13 -0700831 fake_system_state_.fake_hardware()->SetIsOOBEComplete(Time::UnixEpoch());
Jay Srinivasan08fce042012-06-07 16:31:01 -0700832
Alex Deymo2c0db7b2014-11-04 12:23:39 -0800833 EXPECT_TRUE(fake_prefs.SetInt64(kPrefsUpdateCheckCount, initial_value));
Jay Srinivasan480ddfa2012-06-01 19:15:26 -0700834
Ben Chan9abb7632014-08-07 00:10:53 -0700835 int64_t scatter_factor_in_seconds = 10;
Jay Srinivasan480ddfa2012-06-01 19:15:26 -0700836
Igor9fd76b62017-12-11 15:24:18 +0100837 auto device_policy = std::make_unique<policy::MockDevicePolicy>();
Jay Srinivasan480ddfa2012-06-01 19:15:26 -0700838 EXPECT_CALL(*device_policy, LoadPolicy()).WillRepeatedly(Return(true));
Igor9fd76b62017-12-11 15:24:18 +0100839 fake_system_state_.set_device_policy(device_policy.get());
Jay Srinivasan480ddfa2012-06-01 19:15:26 -0700840
841 EXPECT_CALL(*device_policy, GetScatterFactorInSeconds(_))
842 .WillRepeatedly(DoAll(
Ben Chan672c1f52017-10-23 15:41:39 -0700843 SetArgPointee<0>(scatter_factor_in_seconds),
Jay Srinivasan480ddfa2012-06-01 19:15:26 -0700844 Return(true)));
845
Igor9fd76b62017-12-11 15:24:18 +0100846 attempter_.policy_provider_.reset(
847 new policy::PolicyProvider(std::move(device_policy)));
848
Marton Hunyadyba51c3f2018-04-25 15:18:10 +0200849 attempter_.Update("", "", "", "", false, false, false);
Jay Srinivasan480ddfa2012-06-01 19:15:26 -0700850 EXPECT_EQ(scatter_factor_in_seconds, attempter_.scatter_factor_.InSeconds());
851
852 // Make sure the file still exists.
Alex Deymo2c0db7b2014-11-04 12:23:39 -0800853 EXPECT_TRUE(fake_prefs.Exists(kPrefsUpdateCheckCount));
Jay Srinivasan480ddfa2012-06-01 19:15:26 -0700854
Ben Chan9abb7632014-08-07 00:10:53 -0700855 int64_t new_value;
Alex Deymo2c0db7b2014-11-04 12:23:39 -0800856 EXPECT_TRUE(fake_prefs.GetInt64(kPrefsUpdateCheckCount, &new_value));
Jay Srinivasan480ddfa2012-06-01 19:15:26 -0700857 EXPECT_EQ(initial_value - 1, new_value);
858
Jay Srinivasanae4697c2013-03-18 17:08:08 -0700859 EXPECT_TRUE(
860 attempter_.omaha_request_params_->update_check_count_wait_enabled());
Jay Srinivasan480ddfa2012-06-01 19:15:26 -0700861
862 // However, if the count is already 0, it's not decremented. Test that.
863 initial_value = 0;
Alex Deymo2c0db7b2014-11-04 12:23:39 -0800864 EXPECT_TRUE(fake_prefs.SetInt64(kPrefsUpdateCheckCount, initial_value));
Marton Hunyadyba51c3f2018-04-25 15:18:10 +0200865 attempter_.Update("", "", "", "", false, false, false);
Alex Deymo2c0db7b2014-11-04 12:23:39 -0800866 EXPECT_TRUE(fake_prefs.Exists(kPrefsUpdateCheckCount));
867 EXPECT_TRUE(fake_prefs.GetInt64(kPrefsUpdateCheckCount, &new_value));
Jay Srinivasan480ddfa2012-06-01 19:15:26 -0700868 EXPECT_EQ(initial_value, new_value);
869
Alex Deymo60ca1a72015-06-18 18:19:15 -0700870 ScheduleQuitMainLoop();
Jay Srinivasan480ddfa2012-06-01 19:15:26 -0700871}
872
Jay Srinivasan08fce042012-06-07 16:31:01 -0700873TEST_F(UpdateAttempterTest, NoScatteringDoneDuringManualUpdateTestStart) {
Alex Deymo60ca1a72015-06-18 18:19:15 -0700874 loop_.PostTask(FROM_HERE, base::Bind(
875 &UpdateAttempterTest::NoScatteringDoneDuringManualUpdateTestStart,
876 base::Unretained(this)));
877 loop_.Run();
Jay Srinivasan08fce042012-06-07 16:31:01 -0700878}
879
880void UpdateAttempterTest::NoScatteringDoneDuringManualUpdateTestStart() {
881 // Tests that no scattering logic is enabled if the update check
882 // is manually done (as opposed to a scheduled update check)
Ben Chan9abb7632014-08-07 00:10:53 -0700883 int64_t initial_value = 8;
Alex Deymo2c0db7b2014-11-04 12:23:39 -0800884 FakePrefs fake_prefs;
885 attempter_.prefs_ = &fake_prefs;
Jay Srinivasan08fce042012-06-07 16:31:01 -0700886
Gilad Arnold5bb4c902014-04-10 12:32:13 -0700887 fake_system_state_.fake_hardware()->SetIsOOBEComplete(Time::UnixEpoch());
Alex Deymo2c0db7b2014-11-04 12:23:39 -0800888 fake_system_state_.set_prefs(&fake_prefs);
Jay Srinivasan08fce042012-06-07 16:31:01 -0700889
Adolfo Victoriad3a1e352018-07-16 11:40:47 -0700890 EXPECT_TRUE(
891 fake_prefs.SetInt64(kPrefsWallClockScatteringWaitPeriod, initial_value));
Alex Deymo2c0db7b2014-11-04 12:23:39 -0800892 EXPECT_TRUE(fake_prefs.SetInt64(kPrefsUpdateCheckCount, initial_value));
Jay Srinivasan08fce042012-06-07 16:31:01 -0700893
894 // make sure scatter_factor is non-zero as scattering is disabled
895 // otherwise.
Ben Chan9abb7632014-08-07 00:10:53 -0700896 int64_t scatter_factor_in_seconds = 50;
Jay Srinivasan08fce042012-06-07 16:31:01 -0700897
Igor9fd76b62017-12-11 15:24:18 +0100898 auto device_policy = std::make_unique<policy::MockDevicePolicy>();
Jay Srinivasan08fce042012-06-07 16:31:01 -0700899 EXPECT_CALL(*device_policy, LoadPolicy()).WillRepeatedly(Return(true));
Igor9fd76b62017-12-11 15:24:18 +0100900 fake_system_state_.set_device_policy(device_policy.get());
Jay Srinivasan08fce042012-06-07 16:31:01 -0700901
902 EXPECT_CALL(*device_policy, GetScatterFactorInSeconds(_))
903 .WillRepeatedly(DoAll(
Ben Chan672c1f52017-10-23 15:41:39 -0700904 SetArgPointee<0>(scatter_factor_in_seconds),
Jay Srinivasan08fce042012-06-07 16:31:01 -0700905 Return(true)));
906
Igor9fd76b62017-12-11 15:24:18 +0100907 attempter_.policy_provider_.reset(
908 new policy::PolicyProvider(std::move(device_policy)));
909
Gilad Arnoldb92f0df2013-01-10 16:32:45 -0800910 // Trigger an interactive check so we can test that scattering is disabled.
Marton Hunyadyba51c3f2018-04-25 15:18:10 +0200911 attempter_.Update("",
912 "",
913 "",
914 "",
915 false,
916 false,
917 /*interactive=*/true);
Jay Srinivasan08fce042012-06-07 16:31:01 -0700918 EXPECT_EQ(scatter_factor_in_seconds, attempter_.scatter_factor_.InSeconds());
919
920 // Make sure scattering is disabled for manual (i.e. user initiated) update
Jay Srinivasan21be0752012-07-25 15:44:56 -0700921 // checks and all artifacts are removed.
Jay Srinivasanae4697c2013-03-18 17:08:08 -0700922 EXPECT_FALSE(
923 attempter_.omaha_request_params_->wall_clock_based_wait_enabled());
Adolfo Victoriad3a1e352018-07-16 11:40:47 -0700924 EXPECT_FALSE(fake_prefs.Exists(kPrefsWallClockScatteringWaitPeriod));
Jay Srinivasanae4697c2013-03-18 17:08:08 -0700925 EXPECT_EQ(0, attempter_.omaha_request_params_->waiting_period().InSeconds());
926 EXPECT_FALSE(
927 attempter_.omaha_request_params_->update_check_count_wait_enabled());
Alex Deymo2c0db7b2014-11-04 12:23:39 -0800928 EXPECT_FALSE(fake_prefs.Exists(kPrefsUpdateCheckCount));
Jay Srinivasan08fce042012-06-07 16:31:01 -0700929
Alex Deymo60ca1a72015-06-18 18:19:15 -0700930 ScheduleQuitMainLoop();
Jay Srinivasan08fce042012-06-07 16:31:01 -0700931}
932
David Zeuthen985b1122013-10-09 12:13:15 -0700933// Checks that we only report daily metrics at most every 24 hours.
934TEST_F(UpdateAttempterTest, ReportDailyMetrics) {
935 FakeClock fake_clock;
Alex Deymo2c0db7b2014-11-04 12:23:39 -0800936 FakePrefs fake_prefs;
David Zeuthen985b1122013-10-09 12:13:15 -0700937
Gilad Arnold5bb4c902014-04-10 12:32:13 -0700938 fake_system_state_.set_clock(&fake_clock);
Alex Deymo2c0db7b2014-11-04 12:23:39 -0800939 fake_system_state_.set_prefs(&fake_prefs);
David Zeuthen985b1122013-10-09 12:13:15 -0700940
941 Time epoch = Time::FromInternalValue(0);
942 fake_clock.SetWallclockTime(epoch);
943
944 // If there is no kPrefsDailyMetricsLastReportedAt state variable,
945 // we should report.
946 EXPECT_TRUE(attempter_.CheckAndReportDailyMetrics());
947 // We should not report again if no time has passed.
948 EXPECT_FALSE(attempter_.CheckAndReportDailyMetrics());
949
950 // We should not report if only 10 hours has passed.
951 fake_clock.SetWallclockTime(epoch + TimeDelta::FromHours(10));
952 EXPECT_FALSE(attempter_.CheckAndReportDailyMetrics());
953
954 // We should not report if only 24 hours - 1 sec has passed.
955 fake_clock.SetWallclockTime(epoch + TimeDelta::FromHours(24) -
956 TimeDelta::FromSeconds(1));
957 EXPECT_FALSE(attempter_.CheckAndReportDailyMetrics());
958
959 // We should report if 24 hours has passed.
960 fake_clock.SetWallclockTime(epoch + TimeDelta::FromHours(24));
961 EXPECT_TRUE(attempter_.CheckAndReportDailyMetrics());
962
963 // But then we should not report again..
964 EXPECT_FALSE(attempter_.CheckAndReportDailyMetrics());
965
966 // .. until another 24 hours has passed
967 fake_clock.SetWallclockTime(epoch + TimeDelta::FromHours(47));
968 EXPECT_FALSE(attempter_.CheckAndReportDailyMetrics());
969 fake_clock.SetWallclockTime(epoch + TimeDelta::FromHours(48));
970 EXPECT_TRUE(attempter_.CheckAndReportDailyMetrics());
971 EXPECT_FALSE(attempter_.CheckAndReportDailyMetrics());
972
973 // .. and another 24 hours
974 fake_clock.SetWallclockTime(epoch + TimeDelta::FromHours(71));
975 EXPECT_FALSE(attempter_.CheckAndReportDailyMetrics());
976 fake_clock.SetWallclockTime(epoch + TimeDelta::FromHours(72));
977 EXPECT_TRUE(attempter_.CheckAndReportDailyMetrics());
978 EXPECT_FALSE(attempter_.CheckAndReportDailyMetrics());
979
980 // If the span between time of reporting and present time is
981 // negative, we report. This is in order to reset the timestamp and
982 // avoid an edge condition whereby a distant point in the future is
983 // in the state variable resulting in us never ever reporting again.
984 fake_clock.SetWallclockTime(epoch + TimeDelta::FromHours(71));
985 EXPECT_TRUE(attempter_.CheckAndReportDailyMetrics());
986 EXPECT_FALSE(attempter_.CheckAndReportDailyMetrics());
987
988 // In this case we should not update until the clock reads 71 + 24 = 95.
989 // Check that.
990 fake_clock.SetWallclockTime(epoch + TimeDelta::FromHours(94));
991 EXPECT_FALSE(attempter_.CheckAndReportDailyMetrics());
992 fake_clock.SetWallclockTime(epoch + TimeDelta::FromHours(95));
993 EXPECT_TRUE(attempter_.CheckAndReportDailyMetrics());
994 EXPECT_FALSE(attempter_.CheckAndReportDailyMetrics());
David Zeuthen985b1122013-10-09 12:13:15 -0700995}
996
David Zeuthen3c55abd2013-10-14 12:48:03 -0700997TEST_F(UpdateAttempterTest, BootTimeInUpdateMarkerFile) {
David Zeuthen3c55abd2013-10-14 12:48:03 -0700998 FakeClock fake_clock;
999 fake_clock.SetBootTime(Time::FromTimeT(42));
Gilad Arnold5bb4c902014-04-10 12:32:13 -07001000 fake_system_state_.set_clock(&fake_clock);
Alex Deymo906191f2015-10-12 12:22:44 -07001001 FakePrefs fake_prefs;
1002 fake_system_state_.set_prefs(&fake_prefs);
Sen Jiangaeeb2e02016-06-09 15:00:16 -07001003 attempter_.Init();
David Zeuthen3c55abd2013-10-14 12:48:03 -07001004
1005 Time boot_time;
Sen Jiangaeeb2e02016-06-09 15:00:16 -07001006 EXPECT_FALSE(attempter_.GetBootTimeAtUpdate(&boot_time));
David Zeuthen3c55abd2013-10-14 12:48:03 -07001007
Sen Jiangaeeb2e02016-06-09 15:00:16 -07001008 attempter_.WriteUpdateCompletedMarker();
David Zeuthen3c55abd2013-10-14 12:48:03 -07001009
Sen Jiangaeeb2e02016-06-09 15:00:16 -07001010 EXPECT_TRUE(attempter_.GetBootTimeAtUpdate(&boot_time));
David Zeuthen3c55abd2013-10-14 12:48:03 -07001011 EXPECT_EQ(boot_time.ToTimeT(), 42);
1012}
1013
David Pursell02c18642014-11-06 11:26:11 -08001014TEST_F(UpdateAttempterTest, AnyUpdateSourceAllowedUnofficial) {
1015 fake_system_state_.fake_hardware()->SetIsOfficialBuild(false);
1016 EXPECT_TRUE(attempter_.IsAnyUpdateSourceAllowed());
1017}
1018
1019TEST_F(UpdateAttempterTest, AnyUpdateSourceAllowedOfficialDevmode) {
1020 fake_system_state_.fake_hardware()->SetIsOfficialBuild(true);
Sen Jiange67bb5b2016-06-20 15:53:56 -07001021 fake_system_state_.fake_hardware()->SetAreDevFeaturesEnabled(true);
David Pursell02c18642014-11-06 11:26:11 -08001022 EXPECT_TRUE(attempter_.IsAnyUpdateSourceAllowed());
1023}
1024
1025TEST_F(UpdateAttempterTest, AnyUpdateSourceDisallowedOfficialNormal) {
1026 fake_system_state_.fake_hardware()->SetIsOfficialBuild(true);
Sen Jiange67bb5b2016-06-20 15:53:56 -07001027 fake_system_state_.fake_hardware()->SetAreDevFeaturesEnabled(false);
David Pursell02c18642014-11-06 11:26:11 -08001028 EXPECT_FALSE(attempter_.IsAnyUpdateSourceAllowed());
1029}
1030
1031TEST_F(UpdateAttempterTest, CheckForUpdateAUTest) {
1032 fake_system_state_.fake_hardware()->SetIsOfficialBuild(true);
Sen Jiange67bb5b2016-06-20 15:53:56 -07001033 fake_system_state_.fake_hardware()->SetAreDevFeaturesEnabled(false);
Aaron Wood081c0232017-10-19 17:14:58 -07001034 attempter_.CheckForUpdate("", "autest", UpdateAttemptFlags::kNone);
Alex Deymoac41a822015-09-15 20:52:53 -07001035 EXPECT_EQ(constants::kOmahaDefaultAUTestURL, attempter_.forced_omaha_url());
David Pursell02c18642014-11-06 11:26:11 -08001036}
1037
1038TEST_F(UpdateAttempterTest, CheckForUpdateScheduledAUTest) {
1039 fake_system_state_.fake_hardware()->SetIsOfficialBuild(true);
Sen Jiange67bb5b2016-06-20 15:53:56 -07001040 fake_system_state_.fake_hardware()->SetAreDevFeaturesEnabled(false);
Aaron Wood081c0232017-10-19 17:14:58 -07001041 attempter_.CheckForUpdate("", "autest-scheduled", UpdateAttemptFlags::kNone);
Alex Deymoac41a822015-09-15 20:52:53 -07001042 EXPECT_EQ(constants::kOmahaDefaultAUTestURL, attempter_.forced_omaha_url());
David Pursell02c18642014-11-06 11:26:11 -08001043}
1044
Xiyuan Xiac0e8f9a2017-02-22 13:19:35 -08001045TEST_F(UpdateAttempterTest, TargetVersionPrefixSetAndReset) {
Marton Hunyadyba51c3f2018-04-25 15:18:10 +02001046 attempter_.CalculateUpdateParams("", "", "", "1234", false, false, false);
Xiyuan Xiac0e8f9a2017-02-22 13:19:35 -08001047 EXPECT_EQ("1234",
1048 fake_system_state_.request_params()->target_version_prefix());
1049
Marton Hunyadyba51c3f2018-04-25 15:18:10 +02001050 attempter_.CalculateUpdateParams("", "", "", "", false, false, false);
Xiyuan Xiac0e8f9a2017-02-22 13:19:35 -08001051 EXPECT_TRUE(
1052 fake_system_state_.request_params()->target_version_prefix().empty());
1053}
1054
Marton Hunyadyba51c3f2018-04-25 15:18:10 +02001055TEST_F(UpdateAttempterTest, RollbackAllowedSetAndReset) {
1056 attempter_.CalculateUpdateParams("",
1057 "",
1058 "",
1059 "1234",
1060 /*rollback_allowed=*/true,
1061 false,
1062 false);
1063 EXPECT_TRUE(fake_system_state_.request_params()->rollback_allowed());
1064
1065 attempter_.CalculateUpdateParams("",
1066 "",
1067 "",
1068 "1234",
1069 /*rollback_allowed=*/false,
1070 false,
1071 false);
1072 EXPECT_FALSE(fake_system_state_.request_params()->rollback_allowed());
1073}
1074
Aaron Wood23bd3392017-10-06 14:48:25 -07001075TEST_F(UpdateAttempterTest, UpdateDeferredByPolicyTest) {
1076 // Construct an OmahaResponseHandlerAction that has processed an InstallPlan,
1077 // but the update is being deferred by the Policy.
Amin Hassanid3f4bea2018-04-30 14:52:40 -07001078 auto response_action = new OmahaResponseHandlerAction(&fake_system_state_);
Aaron Wood23bd3392017-10-06 14:48:25 -07001079 response_action->install_plan_.version = "a.b.c.d";
1080 response_action->install_plan_.system_version = "b.c.d.e";
1081 response_action->install_plan_.payloads.push_back(
1082 {.size = 1234ULL, .type = InstallPayloadType::kFull});
Aaron Wood23bd3392017-10-06 14:48:25 -07001083 // Inform the UpdateAttempter that the OmahaResponseHandlerAction has
1084 // completed, with the deferred-update error code.
1085 attempter_.ActionCompleted(
1086 nullptr, response_action, ErrorCode::kOmahaUpdateDeferredPerPolicy);
1087 {
1088 UpdateEngineStatus status;
1089 attempter_.GetStatus(&status);
1090 EXPECT_EQ(UpdateStatus::UPDATE_AVAILABLE, status.status);
Amin Hassanid3f4bea2018-04-30 14:52:40 -07001091 EXPECT_TRUE(attempter_.install_plan_);
1092 EXPECT_EQ(attempter_.install_plan_->version, status.new_version);
1093 EXPECT_EQ(attempter_.install_plan_->system_version,
Aaron Wood23bd3392017-10-06 14:48:25 -07001094 status.new_system_version);
Amin Hassanid3f4bea2018-04-30 14:52:40 -07001095 EXPECT_EQ(attempter_.install_plan_->payloads[0].size,
Aaron Wood23bd3392017-10-06 14:48:25 -07001096 status.new_size_bytes);
1097 }
1098 // An "error" event should have been created to tell Omaha that the update is
1099 // being deferred.
1100 EXPECT_TRUE(nullptr != attempter_.error_event_);
1101 EXPECT_EQ(OmahaEvent::kTypeUpdateComplete, attempter_.error_event_->type);
1102 EXPECT_EQ(OmahaEvent::kResultUpdateDeferred, attempter_.error_event_->result);
1103 ErrorCode expected_code = static_cast<ErrorCode>(
1104 static_cast<int>(ErrorCode::kOmahaUpdateDeferredPerPolicy) |
1105 static_cast<int>(ErrorCode::kTestOmahaUrlFlag));
1106 EXPECT_EQ(expected_code, attempter_.error_event_->error_code);
1107 // End the processing
1108 attempter_.ProcessingDone(nullptr, ErrorCode::kOmahaUpdateDeferredPerPolicy);
1109 // Validate the state of the attempter.
1110 {
1111 UpdateEngineStatus status;
1112 attempter_.GetStatus(&status);
1113 EXPECT_EQ(UpdateStatus::REPORTING_ERROR_EVENT, status.status);
1114 EXPECT_EQ(response_action->install_plan_.version, status.new_version);
1115 EXPECT_EQ(response_action->install_plan_.system_version,
1116 status.new_system_version);
1117 EXPECT_EQ(response_action->install_plan_.payloads[0].size,
1118 status.new_size_bytes);
1119 }
1120}
1121
1122TEST_F(UpdateAttempterTest, UpdateIsNotRunningWhenUpdateAvailable) {
1123 EXPECT_FALSE(attempter_.IsUpdateRunningOrScheduled());
1124 // Verify in-progress update with UPDATE_AVAILABLE is running
1125 attempter_.status_ = UpdateStatus::UPDATE_AVAILABLE;
1126 EXPECT_TRUE(attempter_.IsUpdateRunningOrScheduled());
1127}
1128
Aaron Woodbf5a2522017-10-04 10:58:36 -07001129TEST_F(UpdateAttempterTest, UpdateAttemptFlagsCachedAtUpdateStart) {
1130 attempter_.SetUpdateAttemptFlags(UpdateAttemptFlags::kFlagRestrictDownload);
1131
1132 UpdateCheckParams params = {.updates_enabled = true};
1133 attempter_.OnUpdateScheduled(EvalStatus::kSucceeded, params);
1134
1135 EXPECT_EQ(UpdateAttemptFlags::kFlagRestrictDownload,
1136 attempter_.GetCurrentUpdateAttemptFlags());
1137}
1138
Marton Hunyadyba51c3f2018-04-25 15:18:10 +02001139TEST_F(UpdateAttempterTest, RollbackNotAllowed) {
1140 UpdateCheckParams params = {.updates_enabled = true,
1141 .rollback_allowed = false};
1142 attempter_.OnUpdateScheduled(EvalStatus::kSucceeded, params);
1143 EXPECT_FALSE(fake_system_state_.request_params()->rollback_allowed());
1144}
1145
1146TEST_F(UpdateAttempterTest, RollbackAllowed) {
1147 UpdateCheckParams params = {.updates_enabled = true,
1148 .rollback_allowed = true};
1149 attempter_.OnUpdateScheduled(EvalStatus::kSucceeded, params);
1150 EXPECT_TRUE(fake_system_state_.request_params()->rollback_allowed());
1151}
1152
Aaron Wood081c0232017-10-19 17:14:58 -07001153TEST_F(UpdateAttempterTest, InteractiveUpdateUsesPassedRestrictions) {
1154 attempter_.SetUpdateAttemptFlags(UpdateAttemptFlags::kFlagRestrictDownload);
1155
1156 attempter_.CheckForUpdate("", "", UpdateAttemptFlags::kNone);
1157 EXPECT_EQ(UpdateAttemptFlags::kNone,
1158 attempter_.GetCurrentUpdateAttemptFlags());
1159}
1160
1161TEST_F(UpdateAttempterTest, NonInteractiveUpdateUsesSetRestrictions) {
1162 attempter_.SetUpdateAttemptFlags(UpdateAttemptFlags::kNone);
1163
1164 // This tests that when CheckForUpdate() is called with the non-interactive
1165 // flag set, that it doesn't change the current UpdateAttemptFlags.
1166 attempter_.CheckForUpdate("",
1167 "",
1168 UpdateAttemptFlags::kFlagNonInteractive |
1169 UpdateAttemptFlags::kFlagRestrictDownload);
1170 EXPECT_EQ(UpdateAttemptFlags::kNone,
1171 attempter_.GetCurrentUpdateAttemptFlags());
1172}
1173
Marton Hunyadye58bddb2018-04-10 20:27:26 +02001174void UpdateAttempterTest::ResetRollbackHappenedStart(bool is_consumer,
1175 bool is_policy_loaded,
1176 bool expected_reset) {
1177 EXPECT_CALL(*fake_system_state_.mock_payload_state(), GetRollbackHappened())
1178 .WillRepeatedly(Return(true));
1179 auto mock_policy_provider =
1180 std::make_unique<NiceMock<policy::MockPolicyProvider>>();
1181 EXPECT_CALL(*mock_policy_provider, IsConsumerDevice())
1182 .WillRepeatedly(Return(is_consumer));
1183 EXPECT_CALL(*mock_policy_provider, device_policy_is_loaded())
1184 .WillRepeatedly(Return(is_policy_loaded));
1185 const policy::MockDevicePolicy device_policy;
1186 EXPECT_CALL(*mock_policy_provider, GetDevicePolicy())
1187 .WillRepeatedly(ReturnRef(device_policy));
1188 EXPECT_CALL(*fake_system_state_.mock_payload_state(),
1189 SetRollbackHappened(false))
1190 .Times(expected_reset ? 1 : 0);
1191 attempter_.policy_provider_ = std::move(mock_policy_provider);
Marton Hunyadyba51c3f2018-04-25 15:18:10 +02001192 attempter_.Update("", "", "", "", false, false, false);
Marton Hunyadye58bddb2018-04-10 20:27:26 +02001193 ScheduleQuitMainLoop();
1194}
1195
1196TEST_F(UpdateAttempterTest, ResetRollbackHappenedOobe) {
1197 loop_.PostTask(FROM_HERE,
1198 base::Bind(&UpdateAttempterTest::ResetRollbackHappenedStart,
1199 base::Unretained(this),
1200 /*is_consumer=*/false,
1201 /*is_policy_loaded=*/false,
1202 /*expected_reset=*/false));
1203 loop_.Run();
1204}
1205
1206TEST_F(UpdateAttempterTest, ResetRollbackHappenedConsumer) {
1207 loop_.PostTask(FROM_HERE,
1208 base::Bind(&UpdateAttempterTest::ResetRollbackHappenedStart,
1209 base::Unretained(this),
1210 /*is_consumer=*/true,
1211 /*is_policy_loaded=*/false,
1212 /*expected_reset=*/true));
1213 loop_.Run();
1214}
1215
1216TEST_F(UpdateAttempterTest, ResetRollbackHappenedEnterprise) {
1217 loop_.PostTask(FROM_HERE,
1218 base::Bind(&UpdateAttempterTest::ResetRollbackHappenedStart,
1219 base::Unretained(this),
1220 /*is_consumer=*/false,
1221 /*is_policy_loaded=*/true,
1222 /*expected_reset=*/true));
1223 loop_.Run();
1224}
1225
Marton Hunyady199152d2018-05-07 19:08:48 +02001226TEST_F(UpdateAttempterTest, SetRollbackHappenedRollback) {
Amin Hassanid3f4bea2018-04-30 14:52:40 -07001227 attempter_.install_plan_.reset(new InstallPlan);
1228 attempter_.install_plan_->is_rollback = true;
Marton Hunyady199152d2018-05-07 19:08:48 +02001229
1230 EXPECT_CALL(*fake_system_state_.mock_payload_state(),
1231 SetRollbackHappened(true))
1232 .Times(1);
1233 attempter_.ProcessingDone(nullptr, ErrorCode::kSuccess);
1234}
1235
1236TEST_F(UpdateAttempterTest, SetRollbackHappenedNotRollback) {
Amin Hassanid3f4bea2018-04-30 14:52:40 -07001237 attempter_.install_plan_.reset(new InstallPlan);
1238 attempter_.install_plan_->is_rollback = false;
Marton Hunyady199152d2018-05-07 19:08:48 +02001239
1240 EXPECT_CALL(*fake_system_state_.mock_payload_state(),
1241 SetRollbackHappened(true))
1242 .Times(0);
1243 attempter_.ProcessingDone(nullptr, ErrorCode::kSuccess);
1244}
1245
Marton Hunyadya0302682018-05-16 18:52:13 +02001246TEST_F(UpdateAttempterTest, RollbackMetricsRollbackSuccess) {
Amin Hassanid3f4bea2018-04-30 14:52:40 -07001247 attempter_.install_plan_.reset(new InstallPlan);
1248 attempter_.install_plan_->is_rollback = true;
1249 attempter_.install_plan_->version = kRollbackVersion;
Marton Hunyadya0302682018-05-16 18:52:13 +02001250
1251 EXPECT_CALL(*fake_system_state_.mock_metrics_reporter(),
1252 ReportEnterpriseRollbackMetrics(true, kRollbackVersion))
1253 .Times(1);
1254 attempter_.ProcessingDone(nullptr, ErrorCode::kSuccess);
1255}
1256
1257TEST_F(UpdateAttempterTest, RollbackMetricsNotRollbackSuccess) {
Amin Hassanid3f4bea2018-04-30 14:52:40 -07001258 attempter_.install_plan_.reset(new InstallPlan);
1259 attempter_.install_plan_->is_rollback = false;
1260 attempter_.install_plan_->version = kRollbackVersion;
Marton Hunyadya0302682018-05-16 18:52:13 +02001261
1262 EXPECT_CALL(*fake_system_state_.mock_metrics_reporter(),
1263 ReportEnterpriseRollbackMetrics(_, _))
1264 .Times(0);
1265 attempter_.ProcessingDone(nullptr, ErrorCode::kSuccess);
1266}
1267
1268TEST_F(UpdateAttempterTest, RollbackMetricsRollbackFailure) {
Amin Hassanid3f4bea2018-04-30 14:52:40 -07001269 attempter_.install_plan_.reset(new InstallPlan);
1270 attempter_.install_plan_->is_rollback = true;
1271 attempter_.install_plan_->version = kRollbackVersion;
Marton Hunyadya0302682018-05-16 18:52:13 +02001272
1273 EXPECT_CALL(*fake_system_state_.mock_metrics_reporter(),
1274 ReportEnterpriseRollbackMetrics(false, kRollbackVersion))
1275 .Times(1);
1276 MockAction action;
1277 attempter_.CreatePendingErrorEvent(&action, ErrorCode::kRollbackNotPossible);
1278 attempter_.ProcessingDone(nullptr, ErrorCode::kRollbackNotPossible);
1279}
1280
1281TEST_F(UpdateAttempterTest, RollbackMetricsNotRollbackFailure) {
Amin Hassanid3f4bea2018-04-30 14:52:40 -07001282 attempter_.install_plan_.reset(new InstallPlan);
1283 attempter_.install_plan_->is_rollback = false;
1284 attempter_.install_plan_->version = kRollbackVersion;
Marton Hunyadya0302682018-05-16 18:52:13 +02001285
1286 EXPECT_CALL(*fake_system_state_.mock_metrics_reporter(),
1287 ReportEnterpriseRollbackMetrics(_, _))
1288 .Times(0);
1289 MockAction action;
1290 attempter_.CreatePendingErrorEvent(&action, ErrorCode::kRollbackNotPossible);
1291 attempter_.ProcessingDone(nullptr, ErrorCode::kRollbackNotPossible);
1292}
1293
Darin Petkovf42cc1c2010-09-01 09:03:02 -07001294} // namespace chromeos_update_engine