blob: b53e45234350b07c17d9a093740ac6e117111a66 [file] [log] [blame]
Pierre-Clément Tosia0934c12022-11-25 20:54:11 +00001// Copyright 2022, The Android Open Source Project
2//
3// Licensed under the Apache License, Version 2.0 (the "License");
4// you may not use this file except in compliance with the License.
5// You may obtain a copy of the License at
6//
7// http://www.apache.org/licenses/LICENSE-2.0
8//
9// Unless required by applicable law or agreed to in writing, software
10// distributed under the License is distributed on an "AS IS" BASIS,
11// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
12// See the License for the specific language governing permissions and
13// limitations under the License.
14
15//! High-level FDT functions.
16
Jiyong Parkc5d2ef22023-04-11 01:23:46 +090017use crate::bootargs::BootArgsIterator;
Jaewan Kim52477ae2023-11-21 21:20:52 +090018use crate::device_assignment::{DeviceAssignmentInfo, VmDtbo};
Jiyong Park00ceff32023-03-13 05:43:23 +000019use crate::helpers::GUEST_PAGE_SIZE;
Jiyong Parkc5d2ef22023-04-11 01:23:46 +090020use crate::Box;
Jiyong Park00ceff32023-03-13 05:43:23 +000021use crate::RebootReason;
Jiyong Parke9d87e82023-03-21 19:28:40 +090022use alloc::ffi::CString;
Jiyong Parkc23426b2023-04-10 17:32:27 +090023use alloc::vec::Vec;
Jiyong Park0ee65392023-03-27 20:52:45 +090024use core::cmp::max;
25use core::cmp::min;
Pierre-Clément Tosia0934c12022-11-25 20:54:11 +000026use core::ffi::CStr;
Alice Wangabc7d632023-06-14 09:10:14 +000027use core::fmt;
Jiyong Park9c63cd12023-03-21 17:53:07 +090028use core::mem::size_of;
Pierre-Clément Tosia0934c12022-11-25 20:54:11 +000029use core::ops::Range;
Pierre-Clément Tosi1bf532b2023-11-13 11:06:20 +000030use cstr::cstr;
Jiyong Park00ceff32023-03-13 05:43:23 +000031use fdtpci::PciMemoryFlags;
32use fdtpci::PciRangeType;
33use libfdt::AddressRange;
34use libfdt::CellIterator;
Pierre-Clément Tosi4ba79662023-02-13 11:22:41 +000035use libfdt::Fdt;
36use libfdt::FdtError;
Jiyong Park9c63cd12023-03-21 17:53:07 +090037use libfdt::FdtNode;
Alice Wang56ec45b2023-06-15 08:30:32 +000038use libfdt::FdtNodeMut;
Jiyong Park83316122023-03-21 09:39:39 +090039use log::debug;
Jiyong Park00ceff32023-03-13 05:43:23 +000040use log::error;
Jiyong Parkc23426b2023-04-10 17:32:27 +090041use log::info;
Pierre-Clément Tosia50167b2023-05-02 13:19:29 +000042use log::warn;
Jiyong Park00ceff32023-03-13 05:43:23 +000043use tinyvec::ArrayVec;
Alice Wanga3971062023-06-13 11:48:53 +000044use vmbase::fdt::SwiotlbInfo;
Alice Wang63f4c9e2023-06-12 09:36:43 +000045use vmbase::layout::{crosvm::MEM_START, MAX_VIRT_ADDR};
Alice Wangeacb7382023-06-05 12:53:54 +000046use vmbase::memory::SIZE_4KB;
47use vmbase::util::flatten;
Alice Wang4be4dd02023-06-07 07:50:40 +000048use vmbase::util::RangeExt as _;
Pierre-Clément Tosia0934c12022-11-25 20:54:11 +000049
Alice Wangabc7d632023-06-14 09:10:14 +000050/// An enumeration of errors that can occur during the FDT validation.
51#[derive(Clone, Debug)]
52pub enum FdtValidationError {
53 /// Invalid CPU count.
54 InvalidCpuCount(usize),
55}
56
57impl fmt::Display for FdtValidationError {
58 fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result {
59 match self {
60 Self::InvalidCpuCount(num_cpus) => write!(f, "Invalid CPU count: {num_cpus}"),
61 }
62 }
63}
64
Jiyong Park6a8789a2023-03-21 14:50:59 +090065/// Extract from /config the address range containing the pre-loaded kernel. Absence of /config is
66/// not an error.
67fn read_kernel_range_from(fdt: &Fdt) -> libfdt::Result<Option<Range<usize>>> {
Jiyong Parkb87f3302023-03-21 10:03:11 +090068 let addr = cstr!("kernel-address");
69 let size = cstr!("kernel-size");
Pierre-Clément Tosic3811b82022-11-29 11:24:16 +000070
Jiyong Parkb87f3302023-03-21 10:03:11 +090071 if let Some(config) = fdt.node(cstr!("/config"))? {
Pierre-Clément Tosic3811b82022-11-29 11:24:16 +000072 if let (Some(addr), Some(size)) = (config.getprop_u32(addr)?, config.getprop_u32(size)?) {
73 let addr = addr as usize;
74 let size = size as usize;
75
76 return Ok(Some(addr..(addr + size)));
77 }
78 }
79
80 Ok(None)
81}
82
Jiyong Park6a8789a2023-03-21 14:50:59 +090083/// Extract from /chosen the address range containing the pre-loaded ramdisk. Absence is not an
84/// error as there can be initrd-less VM.
85fn read_initrd_range_from(fdt: &Fdt) -> libfdt::Result<Option<Range<usize>>> {
Jiyong Parkb87f3302023-03-21 10:03:11 +090086 let start = cstr!("linux,initrd-start");
87 let end = cstr!("linux,initrd-end");
Pierre-Clément Tosia0934c12022-11-25 20:54:11 +000088
89 if let Some(chosen) = fdt.chosen()? {
90 if let (Some(start), Some(end)) = (chosen.getprop_u32(start)?, chosen.getprop_u32(end)?) {
91 return Ok(Some((start as usize)..(end as usize)));
92 }
93 }
94
95 Ok(None)
96}
Pierre-Clément Tosidb74cb12022-12-08 13:56:25 +000097
Jiyong Park9c63cd12023-03-21 17:53:07 +090098fn patch_initrd_range(fdt: &mut Fdt, initrd_range: &Range<usize>) -> libfdt::Result<()> {
99 let start = u32::try_from(initrd_range.start).unwrap();
100 let end = u32::try_from(initrd_range.end).unwrap();
101
102 let mut node = fdt.chosen_mut()?.ok_or(FdtError::NotFound)?;
103 node.setprop(cstr!("linux,initrd-start"), &start.to_be_bytes())?;
104 node.setprop(cstr!("linux,initrd-end"), &end.to_be_bytes())?;
105 Ok(())
106}
107
Jiyong Parke9d87e82023-03-21 19:28:40 +0900108fn read_bootargs_from(fdt: &Fdt) -> libfdt::Result<Option<CString>> {
109 if let Some(chosen) = fdt.chosen()? {
110 if let Some(bootargs) = chosen.getprop_str(cstr!("bootargs"))? {
111 // We need to copy the string to heap because the original fdt will be invalidated
112 // by the templated DT
113 let copy = CString::new(bootargs.to_bytes()).map_err(|_| FdtError::BadValue)?;
114 return Ok(Some(copy));
115 }
116 }
117 Ok(None)
118}
119
120fn patch_bootargs(fdt: &mut Fdt, bootargs: &CStr) -> libfdt::Result<()> {
121 let mut node = fdt.chosen_mut()?.ok_or(FdtError::NotFound)?;
Jiyong Parkc5d2ef22023-04-11 01:23:46 +0900122 // This function is called before the verification is done. So, we just copy the bootargs to
123 // the new FDT unmodified. This will be filtered again in the modify_for_next_stage function
124 // if the VM is not debuggable.
Jiyong Parke9d87e82023-03-21 19:28:40 +0900125 node.setprop(cstr!("bootargs"), bootargs.to_bytes_with_nul())
126}
127
Alice Wang0d527472023-06-13 14:55:38 +0000128/// Reads and validates the memory range in the DT.
129///
130/// Only one memory range is expected with the crosvm setup for now.
131fn read_and_validate_memory_range(fdt: &Fdt) -> Result<Range<usize>, RebootReason> {
132 let mut memory = fdt.memory().map_err(|e| {
133 error!("Failed to read memory range from DT: {e}");
134 RebootReason::InvalidFdt
135 })?;
136 let range = memory.next().ok_or_else(|| {
137 error!("The /memory node in the DT contains no range.");
138 RebootReason::InvalidFdt
139 })?;
140 if memory.next().is_some() {
141 warn!(
142 "The /memory node in the DT contains more than one memory range, \
143 while only one is expected."
144 );
145 }
Jiyong Park6a8789a2023-03-21 14:50:59 +0900146 let base = range.start;
Alice Wange243d462023-06-06 15:18:12 +0000147 if base != MEM_START {
148 error!("Memory base address {:#x} is not {:#x}", base, MEM_START);
Jiyong Park00ceff32023-03-13 05:43:23 +0000149 return Err(RebootReason::InvalidFdt);
150 }
151
Jiyong Park6a8789a2023-03-21 14:50:59 +0900152 let size = range.len();
Jiyong Park00ceff32023-03-13 05:43:23 +0000153 if size % GUEST_PAGE_SIZE != 0 {
154 error!("Memory size {:#x} is not a multiple of page size {:#x}", size, GUEST_PAGE_SIZE);
155 return Err(RebootReason::InvalidFdt);
156 }
Jiyong Park00ceff32023-03-13 05:43:23 +0000157
Jiyong Park6a8789a2023-03-21 14:50:59 +0900158 if size == 0 {
159 error!("Memory size is 0");
160 return Err(RebootReason::InvalidFdt);
161 }
Alice Wang0d527472023-06-13 14:55:38 +0000162 Ok(range)
Jiyong Park00ceff32023-03-13 05:43:23 +0000163}
164
Jiyong Park9c63cd12023-03-21 17:53:07 +0900165fn patch_memory_range(fdt: &mut Fdt, memory_range: &Range<usize>) -> libfdt::Result<()> {
166 let size = memory_range.len() as u64;
Jiyong Park0ee65392023-03-27 20:52:45 +0900167 fdt.node_mut(cstr!("/memory"))?
168 .ok_or(FdtError::NotFound)?
Alice Wange243d462023-06-06 15:18:12 +0000169 .setprop_inplace(cstr!("reg"), flatten(&[MEM_START.to_be_bytes(), size.to_be_bytes()]))
Jiyong Park9c63cd12023-03-21 17:53:07 +0900170}
171
Jiyong Park6a8789a2023-03-21 14:50:59 +0900172/// Read the number of CPUs from DT
173fn read_num_cpus_from(fdt: &Fdt) -> libfdt::Result<usize> {
174 Ok(fdt.compatible_nodes(cstr!("arm,arm-v8"))?.count())
175}
176
177/// Validate number of CPUs
Alice Wangabc7d632023-06-14 09:10:14 +0000178fn validate_num_cpus(num_cpus: usize) -> Result<(), FdtValidationError> {
179 if num_cpus == 0 || DeviceTreeInfo::gic_patched_size(num_cpus).is_none() {
180 Err(FdtValidationError::InvalidCpuCount(num_cpus))
181 } else {
182 Ok(())
Jiyong Park6a8789a2023-03-21 14:50:59 +0900183 }
Jiyong Park9c63cd12023-03-21 17:53:07 +0900184}
185
186/// Patch DT by keeping `num_cpus` number of arm,arm-v8 compatible nodes, and pruning the rest.
187fn patch_num_cpus(fdt: &mut Fdt, num_cpus: usize) -> libfdt::Result<()> {
188 let cpu = cstr!("arm,arm-v8");
189 let mut next = fdt.root_mut()?.next_compatible(cpu)?;
190 for _ in 0..num_cpus {
191 next = if let Some(current) = next {
192 current.next_compatible(cpu)?
193 } else {
194 return Err(FdtError::NoSpace);
195 };
196 }
197 while let Some(current) = next {
198 next = current.delete_and_next_compatible(cpu)?;
199 }
Jiyong Park6a8789a2023-03-21 14:50:59 +0900200 Ok(())
Jiyong Park00ceff32023-03-13 05:43:23 +0000201}
202
Seungjae Yoo192e99c2023-12-15 16:42:39 +0900203fn read_vendor_hashtree_descriptor_root_digest_from(fdt: &Fdt) -> libfdt::Result<Option<Vec<u8>>> {
Seungjae Yooed67fd52023-11-29 18:54:36 +0900204 if let Some(avf_node) = fdt.node(cstr!("/avf"))? {
Seungjae Yoo192e99c2023-12-15 16:42:39 +0900205 if let Some(vendor_hashtree_descriptor_root_digest) =
206 avf_node.getprop(cstr!("vendor_hashtree_descriptor_root_digest"))?
207 {
208 return Ok(Some(vendor_hashtree_descriptor_root_digest.to_vec()));
Seungjae Yooed67fd52023-11-29 18:54:36 +0900209 }
210 }
211 Ok(None)
212}
213
Seungjae Yoo192e99c2023-12-15 16:42:39 +0900214fn patch_vendor_hashtree_descriptor_root_digest(
215 fdt: &mut Fdt,
216 vendor_hashtree_descriptor_root_digest: &[u8],
217) -> libfdt::Result<()> {
Seungjae Yooed67fd52023-11-29 18:54:36 +0900218 let mut root_node = fdt.root_mut()?;
219 let mut avf_node = root_node.add_subnode(cstr!("/avf"))?;
Seungjae Yoo192e99c2023-12-15 16:42:39 +0900220 avf_node.setprop(
221 cstr!("vendor_hashtree_descriptor_root_digest"),
222 vendor_hashtree_descriptor_root_digest,
223 )?;
Seungjae Yooed67fd52023-11-29 18:54:36 +0900224 Ok(())
225}
226
Jiyong Park00ceff32023-03-13 05:43:23 +0000227#[derive(Debug)]
Jiyong Park00ceff32023-03-13 05:43:23 +0000228struct PciInfo {
Jiyong Park6a8789a2023-03-21 14:50:59 +0900229 ranges: [PciAddrRange; 2],
230 irq_masks: ArrayVec<[PciIrqMask; PciInfo::MAX_IRQS]>,
231 irq_maps: ArrayVec<[PciIrqMap; PciInfo::MAX_IRQS]>,
Jiyong Park00ceff32023-03-13 05:43:23 +0000232}
233
Jiyong Park6a8789a2023-03-21 14:50:59 +0900234impl PciInfo {
235 const IRQ_MASK_CELLS: usize = 4;
236 const IRQ_MAP_CELLS: usize = 10;
Nikita Ioffe85d80262023-07-12 17:34:07 +0100237 const MAX_IRQS: usize = 10;
Jiyong Park00ceff32023-03-13 05:43:23 +0000238}
239
Jiyong Park6a8789a2023-03-21 14:50:59 +0900240type PciAddrRange = AddressRange<(u32, u64), u64, u64>;
241type PciIrqMask = [u32; PciInfo::IRQ_MASK_CELLS];
242type PciIrqMap = [u32; PciInfo::IRQ_MAP_CELLS];
Jiyong Park00ceff32023-03-13 05:43:23 +0000243
244/// Iterator that takes N cells as a chunk
245struct CellChunkIterator<'a, const N: usize> {
246 cells: CellIterator<'a>,
247}
248
249impl<'a, const N: usize> CellChunkIterator<'a, N> {
250 fn new(cells: CellIterator<'a>) -> Self {
251 Self { cells }
252 }
253}
254
255impl<'a, const N: usize> Iterator for CellChunkIterator<'a, N> {
256 type Item = [u32; N];
257 fn next(&mut self) -> Option<Self::Item> {
258 let mut ret: Self::Item = [0; N];
259 for i in ret.iter_mut() {
260 *i = self.cells.next()?;
261 }
262 Some(ret)
263 }
264}
265
Jiyong Park6a8789a2023-03-21 14:50:59 +0900266/// Read pci host controller ranges, irq maps, and irq map masks from DT
267fn read_pci_info_from(fdt: &Fdt) -> libfdt::Result<PciInfo> {
268 let node =
269 fdt.compatible_nodes(cstr!("pci-host-cam-generic"))?.next().ok_or(FdtError::NotFound)?;
270
271 let mut ranges = node.ranges::<(u32, u64), u64, u64>()?.ok_or(FdtError::NotFound)?;
272 let range0 = ranges.next().ok_or(FdtError::NotFound)?;
273 let range1 = ranges.next().ok_or(FdtError::NotFound)?;
274
275 let irq_masks = node.getprop_cells(cstr!("interrupt-map-mask"))?.ok_or(FdtError::NotFound)?;
Pierre-Clément Tosiaa0f6552023-07-12 14:49:35 +0000276 let mut chunks = CellChunkIterator::<{ PciInfo::IRQ_MASK_CELLS }>::new(irq_masks);
277 let irq_masks = (&mut chunks).take(PciInfo::MAX_IRQS).collect();
278
279 if chunks.next().is_some() {
280 warn!("Input DT has more than {} PCI entries!", PciInfo::MAX_IRQS);
281 return Err(FdtError::NoSpace);
282 }
Jiyong Park6a8789a2023-03-21 14:50:59 +0900283
284 let irq_maps = node.getprop_cells(cstr!("interrupt-map"))?.ok_or(FdtError::NotFound)?;
Pierre-Clément Tosiaa0f6552023-07-12 14:49:35 +0000285 let mut chunks = CellChunkIterator::<{ PciInfo::IRQ_MAP_CELLS }>::new(irq_maps);
286 let irq_maps = (&mut chunks).take(PciInfo::MAX_IRQS).collect();
287
288 if chunks.next().is_some() {
289 warn!("Input DT has more than {} PCI entries!", PciInfo::MAX_IRQS);
290 return Err(FdtError::NoSpace);
291 }
Jiyong Park6a8789a2023-03-21 14:50:59 +0900292
293 Ok(PciInfo { ranges: [range0, range1], irq_masks, irq_maps })
294}
295
Jiyong Park0ee65392023-03-27 20:52:45 +0900296fn validate_pci_info(pci_info: &PciInfo, memory_range: &Range<usize>) -> Result<(), RebootReason> {
Jiyong Park6a8789a2023-03-21 14:50:59 +0900297 for range in pci_info.ranges.iter() {
Jiyong Park0ee65392023-03-27 20:52:45 +0900298 validate_pci_addr_range(range, memory_range)?;
Jiyong Park6a8789a2023-03-21 14:50:59 +0900299 }
300 for irq_mask in pci_info.irq_masks.iter() {
301 validate_pci_irq_mask(irq_mask)?;
302 }
303 for (idx, irq_map) in pci_info.irq_maps.iter().enumerate() {
304 validate_pci_irq_map(irq_map, idx)?;
305 }
306 Ok(())
307}
308
Jiyong Park0ee65392023-03-27 20:52:45 +0900309fn validate_pci_addr_range(
310 range: &PciAddrRange,
311 memory_range: &Range<usize>,
312) -> Result<(), RebootReason> {
Jiyong Park6a8789a2023-03-21 14:50:59 +0900313 let mem_flags = PciMemoryFlags(range.addr.0);
314 let range_type = mem_flags.range_type();
315 let prefetchable = mem_flags.prefetchable();
316 let bus_addr = range.addr.1;
317 let cpu_addr = range.parent_addr;
318 let size = range.size;
319
320 if range_type != PciRangeType::Memory64 {
321 error!("Invalid range type {:?} for bus address {:#x} in PCI node", range_type, bus_addr);
322 return Err(RebootReason::InvalidFdt);
323 }
324 if prefetchable {
325 error!("PCI bus address {:#x} in PCI node is prefetchable", bus_addr);
326 return Err(RebootReason::InvalidFdt);
327 }
328 // Enforce ID bus-to-cpu mappings, as used by crosvm.
329 if bus_addr != cpu_addr {
330 error!("PCI bus address: {:#x} is different from CPU address: {:#x}", bus_addr, cpu_addr);
331 return Err(RebootReason::InvalidFdt);
332 }
333
Jiyong Park0ee65392023-03-27 20:52:45 +0900334 let Some(bus_end) = bus_addr.checked_add(size) else {
335 error!("PCI address range size {:#x} overflows", size);
336 return Err(RebootReason::InvalidFdt);
337 };
Alice Wang63f4c9e2023-06-12 09:36:43 +0000338 if bus_end > MAX_VIRT_ADDR.try_into().unwrap() {
Jiyong Park0ee65392023-03-27 20:52:45 +0900339 error!("PCI address end {:#x} is outside of translatable range", bus_end);
340 return Err(RebootReason::InvalidFdt);
341 }
342
343 let memory_start = memory_range.start.try_into().unwrap();
344 let memory_end = memory_range.end.try_into().unwrap();
345
346 if max(bus_addr, memory_start) < min(bus_end, memory_end) {
347 error!(
348 "PCI address range {:#x}-{:#x} overlaps with main memory range {:#x}-{:#x}",
349 bus_addr, bus_end, memory_start, memory_end
350 );
Jiyong Park6a8789a2023-03-21 14:50:59 +0900351 return Err(RebootReason::InvalidFdt);
352 }
353
354 Ok(())
355}
356
357fn validate_pci_irq_mask(irq_mask: &PciIrqMask) -> Result<(), RebootReason> {
Jiyong Park00ceff32023-03-13 05:43:23 +0000358 const IRQ_MASK_ADDR_HI: u32 = 0xf800;
359 const IRQ_MASK_ADDR_ME: u32 = 0x0;
360 const IRQ_MASK_ADDR_LO: u32 = 0x0;
361 const IRQ_MASK_ANY_IRQ: u32 = 0x7;
Jiyong Park6a8789a2023-03-21 14:50:59 +0900362 const EXPECTED: PciIrqMask =
Jiyong Park00ceff32023-03-13 05:43:23 +0000363 [IRQ_MASK_ADDR_HI, IRQ_MASK_ADDR_ME, IRQ_MASK_ADDR_LO, IRQ_MASK_ANY_IRQ];
Jiyong Park6a8789a2023-03-21 14:50:59 +0900364 if *irq_mask != EXPECTED {
365 error!("Invalid PCI irq mask {:#?}", irq_mask);
366 return Err(RebootReason::InvalidFdt);
Jiyong Park00ceff32023-03-13 05:43:23 +0000367 }
Jiyong Park6a8789a2023-03-21 14:50:59 +0900368 Ok(())
Jiyong Park00ceff32023-03-13 05:43:23 +0000369}
370
Jiyong Park6a8789a2023-03-21 14:50:59 +0900371fn validate_pci_irq_map(irq_map: &PciIrqMap, idx: usize) -> Result<(), RebootReason> {
Jiyong Park00ceff32023-03-13 05:43:23 +0000372 const PCI_DEVICE_IDX: usize = 11;
373 const PCI_IRQ_ADDR_ME: u32 = 0;
374 const PCI_IRQ_ADDR_LO: u32 = 0;
375 const PCI_IRQ_INTC: u32 = 1;
376 const AARCH64_IRQ_BASE: u32 = 4; // from external/crosvm/aarch64/src/lib.rs
377 const GIC_SPI: u32 = 0;
378 const IRQ_TYPE_LEVEL_HIGH: u32 = 4;
379
Jiyong Park6a8789a2023-03-21 14:50:59 +0900380 let pci_addr = (irq_map[0], irq_map[1], irq_map[2]);
381 let pci_irq_number = irq_map[3];
382 let _controller_phandle = irq_map[4]; // skipped.
383 let gic_addr = (irq_map[5], irq_map[6]); // address-cells is <2> for GIC
384 // interrupt-cells is <3> for GIC
385 let gic_peripheral_interrupt_type = irq_map[7];
386 let gic_irq_number = irq_map[8];
387 let gic_irq_type = irq_map[9];
Jiyong Park00ceff32023-03-13 05:43:23 +0000388
Jiyong Park6a8789a2023-03-21 14:50:59 +0900389 let phys_hi: u32 = (0x1 << PCI_DEVICE_IDX) * (idx + 1) as u32;
390 let expected_pci_addr = (phys_hi, PCI_IRQ_ADDR_ME, PCI_IRQ_ADDR_LO);
Jiyong Park00ceff32023-03-13 05:43:23 +0000391
Jiyong Park6a8789a2023-03-21 14:50:59 +0900392 if pci_addr != expected_pci_addr {
393 error!("PCI device address {:#x} {:#x} {:#x} in interrupt-map is different from expected address \
394 {:#x} {:#x} {:#x}",
395 pci_addr.0, pci_addr.1, pci_addr.2, expected_pci_addr.0, expected_pci_addr.1, expected_pci_addr.2);
396 return Err(RebootReason::InvalidFdt);
397 }
Jiyong Park00ceff32023-03-13 05:43:23 +0000398
Jiyong Park6a8789a2023-03-21 14:50:59 +0900399 if pci_irq_number != PCI_IRQ_INTC {
400 error!(
401 "PCI INT# {:#x} in interrupt-map is different from expected value {:#x}",
402 pci_irq_number, PCI_IRQ_INTC
403 );
404 return Err(RebootReason::InvalidFdt);
405 }
Jiyong Park00ceff32023-03-13 05:43:23 +0000406
Jiyong Park6a8789a2023-03-21 14:50:59 +0900407 if gic_addr != (0, 0) {
408 error!(
409 "GIC address {:#x} {:#x} in interrupt-map is different from expected address \
410 {:#x} {:#x}",
411 gic_addr.0, gic_addr.1, 0, 0
412 );
413 return Err(RebootReason::InvalidFdt);
414 }
415
416 if gic_peripheral_interrupt_type != GIC_SPI {
417 error!("GIC peripheral interrupt type {:#x} in interrupt-map is different from expected value \
418 {:#x}", gic_peripheral_interrupt_type, GIC_SPI);
419 return Err(RebootReason::InvalidFdt);
420 }
421
422 let irq_nr: u32 = AARCH64_IRQ_BASE + (idx as u32);
423 if gic_irq_number != irq_nr {
424 error!(
425 "GIC irq number {:#x} in interrupt-map is unexpected. Expected {:#x}",
426 gic_irq_number, irq_nr
427 );
428 return Err(RebootReason::InvalidFdt);
429 }
430
431 if gic_irq_type != IRQ_TYPE_LEVEL_HIGH {
432 error!(
433 "IRQ type in {:#x} is invalid. Must be LEVEL_HIGH {:#x}",
434 gic_irq_type, IRQ_TYPE_LEVEL_HIGH
435 );
436 return Err(RebootReason::InvalidFdt);
Jiyong Park00ceff32023-03-13 05:43:23 +0000437 }
438 Ok(())
439}
440
Jiyong Park9c63cd12023-03-21 17:53:07 +0900441fn patch_pci_info(fdt: &mut Fdt, pci_info: &PciInfo) -> libfdt::Result<()> {
442 let mut node = fdt
443 .root_mut()?
444 .next_compatible(cstr!("pci-host-cam-generic"))?
445 .ok_or(FdtError::NotFound)?;
446
447 let irq_masks_size = pci_info.irq_masks.len() * size_of::<PciIrqMask>();
448 node.trimprop(cstr!("interrupt-map-mask"), irq_masks_size)?;
449
450 let irq_maps_size = pci_info.irq_maps.len() * size_of::<PciIrqMap>();
451 node.trimprop(cstr!("interrupt-map"), irq_maps_size)?;
452
453 node.setprop_inplace(
454 cstr!("ranges"),
455 flatten(&[pci_info.ranges[0].to_cells(), pci_info.ranges[1].to_cells()]),
456 )
457}
458
Jiyong Park00ceff32023-03-13 05:43:23 +0000459#[derive(Default, Debug)]
Jiyong Park6a8789a2023-03-21 14:50:59 +0900460struct SerialInfo {
461 addrs: ArrayVec<[u64; Self::MAX_SERIALS]>,
Jiyong Park00ceff32023-03-13 05:43:23 +0000462}
463
464impl SerialInfo {
Jiyong Park6a8789a2023-03-21 14:50:59 +0900465 const MAX_SERIALS: usize = 4;
Jiyong Park00ceff32023-03-13 05:43:23 +0000466}
467
Jiyong Park6a8789a2023-03-21 14:50:59 +0900468fn read_serial_info_from(fdt: &Fdt) -> libfdt::Result<SerialInfo> {
469 let mut addrs: ArrayVec<[u64; SerialInfo::MAX_SERIALS]> = Default::default();
470 for node in fdt.compatible_nodes(cstr!("ns16550a"))?.take(SerialInfo::MAX_SERIALS) {
Alice Wang6ff2d0c2023-09-19 15:28:43 +0000471 let reg = node.first_reg()?;
Jiyong Park6a8789a2023-03-21 14:50:59 +0900472 addrs.push(reg.addr);
Jiyong Park00ceff32023-03-13 05:43:23 +0000473 }
Jiyong Park6a8789a2023-03-21 14:50:59 +0900474 Ok(SerialInfo { addrs })
Jiyong Park00ceff32023-03-13 05:43:23 +0000475}
476
Jiyong Park9c63cd12023-03-21 17:53:07 +0900477/// Patch the DT by deleting the ns16550a compatible nodes whose address are unknown
478fn patch_serial_info(fdt: &mut Fdt, serial_info: &SerialInfo) -> libfdt::Result<()> {
479 let name = cstr!("ns16550a");
480 let mut next = fdt.root_mut()?.next_compatible(name);
481 while let Some(current) = next? {
482 let reg = FdtNode::from_mut(&current)
483 .reg()?
484 .ok_or(FdtError::NotFound)?
485 .next()
486 .ok_or(FdtError::NotFound)?;
487 next = if !serial_info.addrs.contains(&reg.addr) {
488 current.delete_and_next_compatible(name)
489 } else {
490 current.next_compatible(name)
491 }
492 }
493 Ok(())
494}
495
Srivatsa Vaddagiri2df297f2023-04-12 03:11:05 -0700496fn validate_swiotlb_info(
497 swiotlb_info: &SwiotlbInfo,
498 memory: &Range<usize>,
499) -> Result<(), RebootReason> {
Jiyong Park6a8789a2023-03-21 14:50:59 +0900500 let size = swiotlb_info.size;
501 let align = swiotlb_info.align;
Jiyong Park00ceff32023-03-13 05:43:23 +0000502
Srivatsa Vaddagiri2df297f2023-04-12 03:11:05 -0700503 if size == 0 || (size % GUEST_PAGE_SIZE) != 0 {
Jiyong Park00ceff32023-03-13 05:43:23 +0000504 error!("Invalid swiotlb size {:#x}", size);
505 return Err(RebootReason::InvalidFdt);
506 }
507
Pierre-Clément Tosibe3a97b2023-05-19 14:56:23 +0000508 if let Some(align) = align.filter(|&a| a % GUEST_PAGE_SIZE != 0) {
Jiyong Park00ceff32023-03-13 05:43:23 +0000509 error!("Invalid swiotlb alignment {:#x}", align);
510 return Err(RebootReason::InvalidFdt);
511 }
Srivatsa Vaddagiri2df297f2023-04-12 03:11:05 -0700512
Alice Wang9cfbfd62023-06-14 11:19:03 +0000513 if let Some(addr) = swiotlb_info.addr {
514 if addr.checked_add(size).is_none() {
515 error!("Invalid swiotlb range: addr:{addr:#x} size:{size:#x}");
516 return Err(RebootReason::InvalidFdt);
517 }
518 }
Srivatsa Vaddagiri2df297f2023-04-12 03:11:05 -0700519 if let Some(range) = swiotlb_info.fixed_range() {
520 if !range.is_within(memory) {
521 error!("swiotlb range {range:#x?} not part of memory range {memory:#x?}");
522 return Err(RebootReason::InvalidFdt);
523 }
524 }
525
Jiyong Park6a8789a2023-03-21 14:50:59 +0900526 Ok(())
Jiyong Park00ceff32023-03-13 05:43:23 +0000527}
528
Jiyong Park9c63cd12023-03-21 17:53:07 +0900529fn patch_swiotlb_info(fdt: &mut Fdt, swiotlb_info: &SwiotlbInfo) -> libfdt::Result<()> {
530 let mut node =
531 fdt.root_mut()?.next_compatible(cstr!("restricted-dma-pool"))?.ok_or(FdtError::NotFound)?;
Srivatsa Vaddagiri2df297f2023-04-12 03:11:05 -0700532
533 if let Some(range) = swiotlb_info.fixed_range() {
Pierre-Clément Tosic27c4272023-05-19 15:46:26 +0000534 node.setprop_addrrange_inplace(
Srivatsa Vaddagiri2df297f2023-04-12 03:11:05 -0700535 cstr!("reg"),
536 range.start.try_into().unwrap(),
537 range.len().try_into().unwrap(),
538 )?;
Pierre-Clément Tosibe3a97b2023-05-19 14:56:23 +0000539 node.nop_property(cstr!("size"))?;
540 node.nop_property(cstr!("alignment"))?;
Srivatsa Vaddagiri2df297f2023-04-12 03:11:05 -0700541 } else {
Pierre-Clément Tosic27c4272023-05-19 15:46:26 +0000542 node.nop_property(cstr!("reg"))?;
Srivatsa Vaddagiri2df297f2023-04-12 03:11:05 -0700543 node.setprop_inplace(cstr!("size"), &swiotlb_info.size.to_be_bytes())?;
Pierre-Clément Tosibe3a97b2023-05-19 14:56:23 +0000544 node.setprop_inplace(cstr!("alignment"), &swiotlb_info.align.unwrap().to_be_bytes())?;
Srivatsa Vaddagiri2df297f2023-04-12 03:11:05 -0700545 }
546
Jiyong Park9c63cd12023-03-21 17:53:07 +0900547 Ok(())
548}
549
550fn patch_gic(fdt: &mut Fdt, num_cpus: usize) -> libfdt::Result<()> {
551 let node = fdt.compatible_nodes(cstr!("arm,gic-v3"))?.next().ok_or(FdtError::NotFound)?;
552 let mut ranges = node.reg()?.ok_or(FdtError::NotFound)?;
553 let range0 = ranges.next().ok_or(FdtError::NotFound)?;
554 let mut range1 = ranges.next().ok_or(FdtError::NotFound)?;
555
556 let addr = range0.addr;
Alice Wangabc7d632023-06-14 09:10:14 +0000557 // `validate_num_cpus()` checked that this wouldn't panic
558 let size = u64::try_from(DeviceTreeInfo::gic_patched_size(num_cpus).unwrap()).unwrap();
Jiyong Park9c63cd12023-03-21 17:53:07 +0900559
560 // range1 is just below range0
561 range1.addr = addr - size;
562 range1.size = Some(size);
563
564 let range0 = range0.to_cells();
565 let range1 = range1.to_cells();
566 let value = [
567 range0.0, // addr
568 range0.1.unwrap(), //size
569 range1.0, // addr
570 range1.1.unwrap(), //size
571 ];
572
573 let mut node =
574 fdt.root_mut()?.next_compatible(cstr!("arm,gic-v3"))?.ok_or(FdtError::NotFound)?;
575 node.setprop_inplace(cstr!("reg"), flatten(&value))
576}
577
578fn patch_timer(fdt: &mut Fdt, num_cpus: usize) -> libfdt::Result<()> {
579 const NUM_INTERRUPTS: usize = 4;
580 const CELLS_PER_INTERRUPT: usize = 3;
581 let node = fdt.compatible_nodes(cstr!("arm,armv8-timer"))?.next().ok_or(FdtError::NotFound)?;
582 let interrupts = node.getprop_cells(cstr!("interrupts"))?.ok_or(FdtError::NotFound)?;
583 let mut value: ArrayVec<[u32; NUM_INTERRUPTS * CELLS_PER_INTERRUPT]> =
584 interrupts.take(NUM_INTERRUPTS * CELLS_PER_INTERRUPT).collect();
585
586 let num_cpus: u32 = num_cpus.try_into().unwrap();
587 let cpu_mask: u32 = (((0x1 << num_cpus) - 1) & 0xff) << 8;
588 for v in value.iter_mut().skip(2).step_by(CELLS_PER_INTERRUPT) {
589 *v |= cpu_mask;
590 }
591 for v in value.iter_mut() {
592 *v = v.to_be();
593 }
594
Andrew Walbran20bb4e42023-07-07 13:55:55 +0100595 // SAFETY: array size is the same
Jiyong Park9c63cd12023-03-21 17:53:07 +0900596 let value = unsafe {
597 core::mem::transmute::<
598 [u32; NUM_INTERRUPTS * CELLS_PER_INTERRUPT],
599 [u8; NUM_INTERRUPTS * CELLS_PER_INTERRUPT * size_of::<u32>()],
600 >(value.into_inner())
601 };
602
603 let mut node =
604 fdt.root_mut()?.next_compatible(cstr!("arm,armv8-timer"))?.ok_or(FdtError::NotFound)?;
605 node.setprop_inplace(cstr!("interrupts"), value.as_slice())
606}
607
Jiyong Park00ceff32023-03-13 05:43:23 +0000608#[derive(Debug)]
Jiyong Park6a8789a2023-03-21 14:50:59 +0900609pub struct DeviceTreeInfo {
610 pub kernel_range: Option<Range<usize>>,
611 pub initrd_range: Option<Range<usize>>,
612 pub memory_range: Range<usize>,
Jiyong Parke9d87e82023-03-21 19:28:40 +0900613 bootargs: Option<CString>,
Jiyong Park6a8789a2023-03-21 14:50:59 +0900614 num_cpus: usize,
Jiyong Park00ceff32023-03-13 05:43:23 +0000615 pci_info: PciInfo,
616 serial_info: SerialInfo,
Srivatsa Vaddagiri37713ec2023-04-20 04:04:08 -0700617 pub swiotlb_info: SwiotlbInfo,
Jaewan Kimc6e023b2023-10-12 15:11:05 +0900618 device_assignment: Option<DeviceAssignmentInfo>,
Seungjae Yoo192e99c2023-12-15 16:42:39 +0900619 vendor_hashtree_descriptor_root_digest: Option<Vec<u8>>,
Jiyong Park00ceff32023-03-13 05:43:23 +0000620}
621
622impl DeviceTreeInfo {
Alice Wangabc7d632023-06-14 09:10:14 +0000623 fn gic_patched_size(num_cpus: usize) -> Option<usize> {
624 const GIC_REDIST_SIZE_PER_CPU: usize = 32 * SIZE_4KB;
625
626 GIC_REDIST_SIZE_PER_CPU.checked_mul(num_cpus)
627 }
Jiyong Park00ceff32023-03-13 05:43:23 +0000628}
629
Jaewan Kimc6e023b2023-10-12 15:11:05 +0900630pub fn sanitize_device_tree(
631 fdt: &mut [u8],
632 vm_dtbo: Option<&mut [u8]>,
633) -> Result<DeviceTreeInfo, RebootReason> {
634 let fdt = Fdt::from_mut_slice(fdt).map_err(|e| {
635 error!("Failed to load FDT: {e}");
636 RebootReason::InvalidFdt
637 })?;
638
639 let vm_dtbo = match vm_dtbo {
640 Some(vm_dtbo) => Some(VmDtbo::from_mut_slice(vm_dtbo).map_err(|e| {
641 error!("Failed to load VM DTBO: {e}");
642 RebootReason::InvalidFdt
643 })?),
644 None => None,
645 };
646
647 let info = parse_device_tree(fdt, vm_dtbo.as_deref())?;
Jiyong Park83316122023-03-21 09:39:39 +0900648
Jiyong Parke9d87e82023-03-21 19:28:40 +0900649 fdt.copy_from_slice(pvmfw_fdt_template::RAW).map_err(|e| {
650 error!("Failed to instantiate FDT from the template DT: {e}");
651 RebootReason::InvalidFdt
652 })?;
653
Jaewan Kim9220e852023-12-01 10:58:40 +0900654 fdt.unpack().map_err(|e| {
655 error!("Failed to unpack DT for patching: {e}");
656 RebootReason::InvalidFdt
657 })?;
658
Jaewan Kimc6e023b2023-10-12 15:11:05 +0900659 if let Some(device_assignment_info) = &info.device_assignment {
660 let vm_dtbo = vm_dtbo.unwrap();
661 device_assignment_info.filter(vm_dtbo).map_err(|e| {
662 error!("Failed to filter VM DTBO: {e}");
663 RebootReason::InvalidFdt
664 })?;
665 // SAFETY: Damaged VM DTBO isn't used in this API after this unsafe block.
666 // VM DTBO can't be reused in any way as Fdt nor VmDtbo outside of this API because
667 // it can only be instantiated after validation.
668 unsafe {
669 fdt.apply_overlay(vm_dtbo.as_mut()).map_err(|e| {
670 error!("Failed to apply filtered VM DTBO: {e}");
671 RebootReason::InvalidFdt
672 })?;
673 }
674 }
675
Jiyong Park9c63cd12023-03-21 17:53:07 +0900676 patch_device_tree(fdt, &info)?;
Jaewan Kimc6e023b2023-10-12 15:11:05 +0900677
Jaewan Kim19b984f2023-12-04 15:16:50 +0900678 // TODO(b/317201360): Ensure no overlapping in <reg> among devices
679
Jaewan Kim9220e852023-12-01 10:58:40 +0900680 fdt.pack().map_err(|e| {
681 error!("Failed to unpack DT after patching: {e}");
682 RebootReason::InvalidFdt
683 })?;
684
Jiyong Park6a8789a2023-03-21 14:50:59 +0900685 Ok(info)
Jiyong Park83316122023-03-21 09:39:39 +0900686}
687
Jaewan Kimc6e023b2023-10-12 15:11:05 +0900688fn parse_device_tree(fdt: &Fdt, vm_dtbo: Option<&VmDtbo>) -> Result<DeviceTreeInfo, RebootReason> {
Jiyong Park6a8789a2023-03-21 14:50:59 +0900689 let kernel_range = read_kernel_range_from(fdt).map_err(|e| {
690 error!("Failed to read kernel range from DT: {e}");
691 RebootReason::InvalidFdt
692 })?;
693
694 let initrd_range = read_initrd_range_from(fdt).map_err(|e| {
695 error!("Failed to read initrd range from DT: {e}");
696 RebootReason::InvalidFdt
697 })?;
698
Alice Wang0d527472023-06-13 14:55:38 +0000699 let memory_range = read_and_validate_memory_range(fdt)?;
Jiyong Park6a8789a2023-03-21 14:50:59 +0900700
Jiyong Parke9d87e82023-03-21 19:28:40 +0900701 let bootargs = read_bootargs_from(fdt).map_err(|e| {
702 error!("Failed to read bootargs from DT: {e}");
703 RebootReason::InvalidFdt
704 })?;
705
Jiyong Park6a8789a2023-03-21 14:50:59 +0900706 let num_cpus = read_num_cpus_from(fdt).map_err(|e| {
707 error!("Failed to read num cpus from DT: {e}");
708 RebootReason::InvalidFdt
709 })?;
Alice Wangabc7d632023-06-14 09:10:14 +0000710 validate_num_cpus(num_cpus).map_err(|e| {
711 error!("Failed to validate num cpus from DT: {e}");
712 RebootReason::InvalidFdt
713 })?;
Jiyong Park6a8789a2023-03-21 14:50:59 +0900714
715 let pci_info = read_pci_info_from(fdt).map_err(|e| {
716 error!("Failed to read pci info from DT: {e}");
717 RebootReason::InvalidFdt
718 })?;
Jiyong Park0ee65392023-03-27 20:52:45 +0900719 validate_pci_info(&pci_info, &memory_range)?;
Jiyong Park6a8789a2023-03-21 14:50:59 +0900720
721 let serial_info = read_serial_info_from(fdt).map_err(|e| {
722 error!("Failed to read serial info from DT: {e}");
723 RebootReason::InvalidFdt
724 })?;
725
Alice Wang9cfbfd62023-06-14 11:19:03 +0000726 let swiotlb_info = SwiotlbInfo::new_from_fdt(fdt).map_err(|e| {
Jiyong Park6a8789a2023-03-21 14:50:59 +0900727 error!("Failed to read swiotlb info from DT: {e}");
728 RebootReason::InvalidFdt
729 })?;
Srivatsa Vaddagiri2df297f2023-04-12 03:11:05 -0700730 validate_swiotlb_info(&swiotlb_info, &memory_range)?;
Jiyong Park6a8789a2023-03-21 14:50:59 +0900731
Jaewan Kimc6e023b2023-10-12 15:11:05 +0900732 let device_assignment = match vm_dtbo {
Jaewan Kim52477ae2023-11-21 21:20:52 +0900733 Some(vm_dtbo) => {
734 if let Some(hypervisor) = hyp::get_device_assigner() {
735 DeviceAssignmentInfo::parse(fdt, vm_dtbo, hypervisor).map_err(|e| {
736 error!("Failed to parse device assignment from DT and VM DTBO: {e}");
737 RebootReason::InvalidFdt
738 })?
739 } else {
740 warn!(
741 "Device assignment is ignored because device assigning hypervisor is missing"
742 );
743 None
744 }
745 }
Jaewan Kimc6e023b2023-10-12 15:11:05 +0900746 None => None,
747 };
748
Seungjae Yooed67fd52023-11-29 18:54:36 +0900749 // TODO(b/285854379) : A temporary solution lives. This is for enabling
750 // microdroid vendor partition for non-protected VM as well. When passing
Seungjae Yoo192e99c2023-12-15 16:42:39 +0900751 // DT path containing vendor_hashtree_descriptor_root_digest via fstab, init
752 // stage will check if vendor_hashtree_descriptor_root_digest exists in the
753 // init stage, regardless the protection. Adding this temporary solution
754 // will prevent fatal in init stage for protected VM. However, this data is
755 // not trustable without validating root digest of vendor hashtree
756 // descriptor comes from ABL.
757 let vendor_hashtree_descriptor_root_digest =
758 read_vendor_hashtree_descriptor_root_digest_from(fdt).map_err(|e| {
759 error!("Failed to read vendor_hashtree_descriptor_root_digest from DT: {e}");
760 RebootReason::InvalidFdt
761 })?;
Seungjae Yooed67fd52023-11-29 18:54:36 +0900762
Jiyong Park00ceff32023-03-13 05:43:23 +0000763 Ok(DeviceTreeInfo {
Jiyong Park6a8789a2023-03-21 14:50:59 +0900764 kernel_range,
765 initrd_range,
766 memory_range,
Jiyong Parke9d87e82023-03-21 19:28:40 +0900767 bootargs,
Jiyong Park6a8789a2023-03-21 14:50:59 +0900768 num_cpus,
769 pci_info,
770 serial_info,
771 swiotlb_info,
Jaewan Kimc6e023b2023-10-12 15:11:05 +0900772 device_assignment,
Seungjae Yoo192e99c2023-12-15 16:42:39 +0900773 vendor_hashtree_descriptor_root_digest,
Jiyong Park00ceff32023-03-13 05:43:23 +0000774 })
775}
776
Jiyong Park9c63cd12023-03-21 17:53:07 +0900777fn patch_device_tree(fdt: &mut Fdt, info: &DeviceTreeInfo) -> Result<(), RebootReason> {
778 if let Some(initrd_range) = &info.initrd_range {
779 patch_initrd_range(fdt, initrd_range).map_err(|e| {
780 error!("Failed to patch initrd range to DT: {e}");
781 RebootReason::InvalidFdt
782 })?;
783 }
784 patch_memory_range(fdt, &info.memory_range).map_err(|e| {
785 error!("Failed to patch memory range to DT: {e}");
786 RebootReason::InvalidFdt
787 })?;
Jiyong Parke9d87e82023-03-21 19:28:40 +0900788 if let Some(bootargs) = &info.bootargs {
789 patch_bootargs(fdt, bootargs.as_c_str()).map_err(|e| {
790 error!("Failed to patch bootargs to DT: {e}");
791 RebootReason::InvalidFdt
792 })?;
793 }
Jiyong Park9c63cd12023-03-21 17:53:07 +0900794 patch_num_cpus(fdt, info.num_cpus).map_err(|e| {
795 error!("Failed to patch cpus to DT: {e}");
796 RebootReason::InvalidFdt
797 })?;
798 patch_pci_info(fdt, &info.pci_info).map_err(|e| {
799 error!("Failed to patch pci info to DT: {e}");
800 RebootReason::InvalidFdt
801 })?;
802 patch_serial_info(fdt, &info.serial_info).map_err(|e| {
803 error!("Failed to patch serial info to DT: {e}");
804 RebootReason::InvalidFdt
805 })?;
806 patch_swiotlb_info(fdt, &info.swiotlb_info).map_err(|e| {
807 error!("Failed to patch swiotlb info to DT: {e}");
808 RebootReason::InvalidFdt
809 })?;
810 patch_gic(fdt, info.num_cpus).map_err(|e| {
811 error!("Failed to patch gic info to DT: {e}");
812 RebootReason::InvalidFdt
813 })?;
814 patch_timer(fdt, info.num_cpus).map_err(|e| {
815 error!("Failed to patch timer info to DT: {e}");
816 RebootReason::InvalidFdt
817 })?;
Jaewan Kimc6e023b2023-10-12 15:11:05 +0900818 if let Some(device_assignment) = &info.device_assignment {
819 // Note: We patch values after VM DTBO is overlaid because patch may require more space
820 // then VM DTBO's underlying slice is allocated.
821 device_assignment.patch(fdt).map_err(|e| {
822 error!("Failed to patch device assignment info to DT: {e}");
823 RebootReason::InvalidFdt
824 })?;
825 }
Seungjae Yoo192e99c2023-12-15 16:42:39 +0900826 if let Some(vendor_hashtree_descriptor_root_digest) =
827 &info.vendor_hashtree_descriptor_root_digest
828 {
829 patch_vendor_hashtree_descriptor_root_digest(fdt, vendor_hashtree_descriptor_root_digest)
830 .map_err(|e| {
831 error!("Failed to patch vendor_hashtree_descriptor_root_digest to DT: {e}");
Seungjae Yooed67fd52023-11-29 18:54:36 +0900832 RebootReason::InvalidFdt
833 })?;
834 }
Jiyong Parke9d87e82023-03-21 19:28:40 +0900835
Jiyong Park9c63cd12023-03-21 17:53:07 +0900836 Ok(())
837}
838
Pierre-Clément Tosi4ba79662023-02-13 11:22:41 +0000839/// Modifies the input DT according to the fields of the configuration.
840pub fn modify_for_next_stage(
841 fdt: &mut Fdt,
842 bcc: &[u8],
843 new_instance: bool,
844 strict_boot: bool,
Alan Stokes65618332023-12-15 14:09:25 +0000845 debug_policy: Option<&[u8]>,
Jiyong Parkc5d2ef22023-04-11 01:23:46 +0900846 debuggable: bool,
Pierre-Clément Tosi80251972023-07-12 12:51:12 +0000847 kaslr_seed: u64,
Pierre-Clément Tosi4ba79662023-02-13 11:22:41 +0000848) -> libfdt::Result<()> {
Pierre-Clément Tosieb887ac2023-05-02 13:33:37 +0000849 if let Some(debug_policy) = debug_policy {
850 let backup = Vec::from(fdt.as_slice());
851 fdt.unpack()?;
852 let backup_fdt = Fdt::from_slice(backup.as_slice()).unwrap();
853 if apply_debug_policy(fdt, backup_fdt, debug_policy)? {
854 info!("Debug policy applied.");
855 } else {
856 // apply_debug_policy restored fdt to backup_fdt so unpack it again.
857 fdt.unpack()?;
858 }
859 } else {
860 info!("No debug policy found.");
861 fdt.unpack()?;
862 }
Pierre-Clément Tosidb74cb12022-12-08 13:56:25 +0000863
Jiyong Parke9d87e82023-03-21 19:28:40 +0900864 patch_dice_node(fdt, bcc.as_ptr() as usize, bcc.len())?;
Pierre-Clément Tosi4ba79662023-02-13 11:22:41 +0000865
Alice Wang56ec45b2023-06-15 08:30:32 +0000866 if let Some(mut chosen) = fdt.chosen_mut()? {
867 empty_or_delete_prop(&mut chosen, cstr!("avf,strict-boot"), strict_boot)?;
868 empty_or_delete_prop(&mut chosen, cstr!("avf,new-instance"), new_instance)?;
Pierre-Clément Tosi80251972023-07-12 12:51:12 +0000869 chosen.setprop_inplace(cstr!("kaslr-seed"), &kaslr_seed.to_be_bytes())?;
Alice Wang56ec45b2023-06-15 08:30:32 +0000870 };
Jiyong Park32f37ef2023-05-17 16:15:58 +0900871 if !debuggable {
Jiyong Parkc5d2ef22023-04-11 01:23:46 +0900872 if let Some(bootargs) = read_bootargs_from(fdt)? {
873 filter_out_dangerous_bootargs(fdt, &bootargs)?;
874 }
875 }
876
Pierre-Clément Tosi4ba79662023-02-13 11:22:41 +0000877 fdt.pack()?;
878
879 Ok(())
880}
881
Jiyong Parke9d87e82023-03-21 19:28:40 +0900882/// Patch the "google,open-dice"-compatible reserved-memory node to point to the bcc range
883fn patch_dice_node(fdt: &mut Fdt, addr: usize, size: usize) -> libfdt::Result<()> {
Pierre-Clément Tosidb74cb12022-12-08 13:56:25 +0000884 // We reject DTs with missing reserved-memory node as validation should have checked that the
885 // "swiotlb" subnode (compatible = "restricted-dma-pool") was present.
Jiyong Parke9d87e82023-03-21 19:28:40 +0900886 let node = fdt.node_mut(cstr!("/reserved-memory"))?.ok_or(libfdt::FdtError::NotFound)?;
Pierre-Clément Tosidb74cb12022-12-08 13:56:25 +0000887
Jiyong Parke9d87e82023-03-21 19:28:40 +0900888 let mut node = node.next_compatible(cstr!("google,open-dice"))?.ok_or(FdtError::NotFound)?;
Pierre-Clément Tosidb74cb12022-12-08 13:56:25 +0000889
Jiyong Parke9d87e82023-03-21 19:28:40 +0900890 let addr: u64 = addr.try_into().unwrap();
891 let size: u64 = size.try_into().unwrap();
892 node.setprop_inplace(cstr!("reg"), flatten(&[addr.to_be_bytes(), size.to_be_bytes()]))
Pierre-Clément Tosi4ba79662023-02-13 11:22:41 +0000893}
894
Alice Wang56ec45b2023-06-15 08:30:32 +0000895fn empty_or_delete_prop(
896 fdt_node: &mut FdtNodeMut,
897 prop_name: &CStr,
898 keep_prop: bool,
899) -> libfdt::Result<()> {
900 if keep_prop {
901 fdt_node.setprop_empty(prop_name)
Pierre-Clément Tosi4ba79662023-02-13 11:22:41 +0000902 } else {
Alice Wang56ec45b2023-06-15 08:30:32 +0000903 fdt_node
904 .delprop(prop_name)
905 .or_else(|e| if e == FdtError::NotFound { Ok(()) } else { Err(e) })
Pierre-Clément Tosi4ba79662023-02-13 11:22:41 +0000906 }
Pierre-Clément Tosidb74cb12022-12-08 13:56:25 +0000907}
Jiyong Parkc23426b2023-04-10 17:32:27 +0900908
Pierre-Clément Tosia50167b2023-05-02 13:19:29 +0000909/// Apply the debug policy overlay to the guest DT.
910///
911/// Returns Ok(true) on success, Ok(false) on recovered failure and Err(_) on corruption of the DT.
Pierre-Clément Tosieb887ac2023-05-02 13:33:37 +0000912fn apply_debug_policy(
913 fdt: &mut Fdt,
914 backup_fdt: &Fdt,
915 debug_policy: &[u8],
916) -> libfdt::Result<bool> {
Pierre-Clément Tosia50167b2023-05-02 13:19:29 +0000917 let mut debug_policy = Vec::from(debug_policy);
918 let overlay = match Fdt::from_mut_slice(debug_policy.as_mut_slice()) {
Jiyong Parkc23426b2023-04-10 17:32:27 +0900919 Ok(overlay) => overlay,
920 Err(e) => {
Pierre-Clément Tosia50167b2023-05-02 13:19:29 +0000921 warn!("Corrupted debug policy found: {e}. Not applying.");
922 return Ok(false);
Jiyong Parkc23426b2023-04-10 17:32:27 +0900923 }
924 };
Jiyong Parkc23426b2023-04-10 17:32:27 +0900925
Andrew Walbran20bb4e42023-07-07 13:55:55 +0100926 // SAFETY: on failure, the corrupted DT is restored using the backup.
Jiyong Parkc23426b2023-04-10 17:32:27 +0900927 if let Err(e) = unsafe { fdt.apply_overlay(overlay) } {
Pierre-Clément Tosia50167b2023-05-02 13:19:29 +0000928 warn!("Failed to apply debug policy: {e}. Recovering...");
Jiyong Parkc23426b2023-04-10 17:32:27 +0900929 fdt.copy_from_slice(backup_fdt.as_slice())?;
Jiyong Parkc23426b2023-04-10 17:32:27 +0900930 // A successful restoration is considered success because an invalid debug policy
931 // shouldn't DOS the pvmfw
Pierre-Clément Tosia50167b2023-05-02 13:19:29 +0000932 Ok(false)
933 } else {
934 Ok(true)
Jiyong Parkc23426b2023-04-10 17:32:27 +0900935 }
Jiyong Parkc23426b2023-04-10 17:32:27 +0900936}
Jiyong Parkc5d2ef22023-04-11 01:23:46 +0900937
Pierre-Clément Tosi1fbc2e92023-05-02 17:28:17 +0000938fn has_common_debug_policy(fdt: &Fdt, debug_feature_name: &CStr) -> libfdt::Result<bool> {
Jiyong Parkc5d2ef22023-04-11 01:23:46 +0900939 if let Some(node) = fdt.node(cstr!("/avf/guest/common"))? {
940 if let Some(value) = node.getprop_u32(debug_feature_name)? {
941 return Ok(value == 1);
942 }
943 }
944 Ok(false) // if the policy doesn't exist or not 1, don't enable the debug feature
945}
946
947fn filter_out_dangerous_bootargs(fdt: &mut Fdt, bootargs: &CStr) -> libfdt::Result<()> {
Pierre-Clément Tosi1fbc2e92023-05-02 17:28:17 +0000948 let has_crashkernel = has_common_debug_policy(fdt, cstr!("ramdump"))?;
949 let has_console = has_common_debug_policy(fdt, cstr!("log"))?;
Jiyong Parkc5d2ef22023-04-11 01:23:46 +0900950
951 let accepted: &[(&str, Box<dyn Fn(Option<&str>) -> bool>)] = &[
952 ("panic", Box::new(|v| if let Some(v) = v { v == "=-1" } else { false })),
953 ("crashkernel", Box::new(|_| has_crashkernel)),
954 ("console", Box::new(|_| has_console)),
955 ];
956
957 // parse and filter out unwanted
958 let mut filtered = Vec::new();
959 for arg in BootArgsIterator::new(bootargs).map_err(|e| {
960 info!("Invalid bootarg: {e}");
961 FdtError::BadValue
962 })? {
963 match accepted.iter().find(|&t| t.0 == arg.name()) {
964 Some((_, pred)) if pred(arg.value()) => filtered.push(arg),
965 _ => debug!("Rejected bootarg {}", arg.as_ref()),
966 }
967 }
968
969 // flatten into a new C-string
970 let mut new_bootargs = Vec::new();
971 for (i, arg) in filtered.iter().enumerate() {
972 if i != 0 {
973 new_bootargs.push(b' '); // separator
974 }
975 new_bootargs.extend_from_slice(arg.as_ref().as_bytes());
976 }
977 new_bootargs.push(b'\0');
978
979 let mut node = fdt.chosen_mut()?.ok_or(FdtError::NotFound)?;
980 node.setprop(cstr!("bootargs"), new_bootargs.as_slice())
981}