blob: a32bc2b6ceb3a3a70424b3e8222b17741863f61a [file] [log] [blame]
David Sodman0c69cad2017-08-21 12:12:51 -07001/*
2 * Copyright (C) 2017 The Android Open Source Project
3 *
4 * Licensed under the Apache License, Version 2.0 (the "License");
5 * you may not use this file except in compliance with the License.
6 * You may obtain a copy of the License at
7 *
8 * http://www.apache.org/licenses/LICENSE-2.0
9 *
10 * Unless required by applicable law or agreed to in writing, software
11 * distributed under the License is distributed on an "AS IS" BASIS,
12 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
13 * See the License for the specific language governing permissions and
14 * limitations under the License.
15 */
16
Ady Abrahamb0dbdaa2020-01-06 16:19:42 -080017// TODO(b/129481165): remove the #pragma below and fix conversion issues
18#pragma clang diagnostic push
19#pragma clang diagnostic ignored "-Wconversion"
20
David Sodman0c69cad2017-08-21 12:12:51 -070021//#define LOG_NDEBUG 0
22#undef LOG_TAG
23#define LOG_TAG "BufferLayer"
24#define ATRACE_TAG ATRACE_TAG_GRAPHICS
25
Alec Mourie60041e2019-06-14 18:59:51 -070026#include "BufferLayer.h"
Lloyd Piquefeb73d72018-12-04 17:23:44 -080027
28#include <compositionengine/CompositionEngine.h>
Lloyd Piquef5275482019-01-29 18:42:42 -080029#include <compositionengine/LayerFECompositionState.h>
Lloyd Pique37c2c9b2018-12-04 17:25:10 -080030#include <compositionengine/OutputLayer.h>
31#include <compositionengine/impl/OutputLayerCompositionState.h>
Lloyd Piquefeb73d72018-12-04 17:23:44 -080032#include <cutils/compiler.h>
33#include <cutils/native_handle.h>
34#include <cutils/properties.h>
35#include <gui/BufferItem.h>
36#include <gui/BufferQueue.h>
chaviwf83ce182019-09-12 14:43:08 -070037#include <gui/GLConsumer.h>
Lloyd Piquefeb73d72018-12-04 17:23:44 -080038#include <gui/LayerDebugInfo.h>
39#include <gui/Surface.h>
40#include <renderengine/RenderEngine.h>
41#include <ui/DebugUtils.h>
42#include <utils/Errors.h>
43#include <utils/Log.h>
44#include <utils/NativeHandle.h>
45#include <utils/StopWatch.h>
46#include <utils/Trace.h>
47
Alec Mourie60041e2019-06-14 18:59:51 -070048#include <cmath>
49#include <cstdlib>
50#include <mutex>
51#include <sstream>
52
David Sodman0c69cad2017-08-21 12:12:51 -070053#include "Colorizer.h"
54#include "DisplayDevice.h"
Mikael Pessa90092f42019-08-26 17:22:04 -070055#include "FrameTracer/FrameTracer.h"
David Sodman0c69cad2017-08-21 12:12:51 -070056#include "LayerRejecter.h"
Yiwei Zhang7e666a52018-11-15 13:33:42 -080057#include "TimeStats/TimeStats.h"
58
David Sodman0c69cad2017-08-21 12:12:51 -070059namespace android {
60
Peiyong Lin1a70eca2019-11-15 09:33:33 -080061static constexpr float defaultMaxMasteringLuminance = 1000.0;
62static constexpr float defaultMaxContentLuminance = 1000.0;
63
Lloyd Pique42ab75e2018-09-12 20:46:03 -070064BufferLayer::BufferLayer(const LayerCreationArgs& args)
Lloyd Piquefeb73d72018-12-04 17:23:44 -080065 : Layer(args),
chaviwb4c6e582019-08-16 14:35:07 -070066 mTextureName(args.textureName),
Lloyd Piquede196652020-01-22 17:29:58 -080067 mCompositionState{mFlinger->getCompositionEngine().createLayerFECompositionState()} {
Dominik Laskowski87a07e42019-10-10 20:38:02 -070068 ALOGV("Creating Layer %s", getDebugName());
David Sodman0c69cad2017-08-21 12:12:51 -070069
Lloyd Pique42ab75e2018-09-12 20:46:03 -070070 mPremultipliedAlpha = !(args.flags & ISurfaceComposerClient::eNonPremultiplied);
David Sodman0c69cad2017-08-21 12:12:51 -070071
Lloyd Pique42ab75e2018-09-12 20:46:03 -070072 mPotentialCursor = args.flags & ISurfaceComposerClient::eCursorWindow;
73 mProtectedByApp = args.flags & ISurfaceComposerClient::eProtectedByApp;
David Sodman0c69cad2017-08-21 12:12:51 -070074}
75
76BufferLayer::~BufferLayer() {
chaviwb4c6e582019-08-16 14:35:07 -070077 if (!isClone()) {
78 // The original layer and the clone layer share the same texture. Therefore, only one of
79 // the layers, in this case the original layer, needs to handle the deletion. The original
80 // layer and the clone should be removed at the same time so there shouldn't be any issue
81 // with the clone layer trying to use the deleted texture.
82 mFlinger->deleteTextureAsync(mTextureName);
83 }
Yiwei Zhang1a88c402019-11-18 10:43:58 -080084 const int32_t layerId = getSequence();
85 mFlinger->mTimeStats->onDestroy(layerId);
86 mFlinger->mFrameTracer->onDestroy(layerId);
David Sodman0c69cad2017-08-21 12:12:51 -070087}
88
David Sodmaneb085e02017-10-05 18:49:04 -070089void BufferLayer::useSurfaceDamage() {
90 if (mFlinger->mForceFullDamage) {
91 surfaceDamageRegion = Region::INVALID_REGION;
92 } else {
chaviw4244e032019-09-04 11:27:49 -070093 surfaceDamageRegion = mBufferInfo.mSurfaceDamage;
David Sodmaneb085e02017-10-05 18:49:04 -070094 }
95}
96
97void BufferLayer::useEmptyDamage() {
98 surfaceDamageRegion.clear();
99}
100
Marissa Wallfd668622018-05-10 10:21:13 -0700101bool BufferLayer::isOpaque(const Layer::State& s) const {
102 // if we don't have a buffer or sidebandStream yet, we're translucent regardless of the
103 // layer's opaque flag.
chaviwd62d3062019-09-04 14:48:02 -0700104 if ((mSidebandStream == nullptr) && (mBufferInfo.mBuffer == nullptr)) {
Marissa Wallfd668622018-05-10 10:21:13 -0700105 return false;
106 }
107
108 // if the layer has the opaque flag, then we're always opaque,
109 // otherwise we use the current buffer's format.
110 return ((s.flags & layer_state_t::eLayerOpaque) != 0) || getOpacityForFormat(getPixelFormat());
David Sodman0c69cad2017-08-21 12:12:51 -0700111}
112
113bool BufferLayer::isVisible() const {
Dominik Laskowskif7a09ed2019-10-07 13:54:18 -0700114 return !isHiddenByPolicy() && getAlpha() > 0.0f &&
chaviwd62d3062019-09-04 14:48:02 -0700115 (mBufferInfo.mBuffer != nullptr || mSidebandStream != nullptr);
David Sodman0c69cad2017-08-21 12:12:51 -0700116}
117
118bool BufferLayer::isFixedSize() const {
119 return getEffectiveScalingMode() != NATIVE_WINDOW_SCALING_MODE_FREEZE;
120}
121
Lloyd Piquea83776c2019-01-29 18:42:32 -0800122bool BufferLayer::usesSourceCrop() const {
123 return true;
124}
125
David Sodman0c69cad2017-08-21 12:12:51 -0700126static constexpr mat4 inverseOrientation(uint32_t transform) {
David Sodman41fdfc92017-11-06 16:09:56 -0800127 const mat4 flipH(-1, 0, 0, 0, 0, 1, 0, 0, 0, 0, 1, 0, 1, 0, 0, 1);
128 const mat4 flipV(1, 0, 0, 0, 0, -1, 0, 0, 0, 0, 1, 0, 0, 1, 0, 1);
129 const mat4 rot90(0, 1, 0, 0, -1, 0, 0, 0, 0, 0, 1, 0, 1, 0, 0, 1);
David Sodman0c69cad2017-08-21 12:12:51 -0700130 mat4 tr;
131
132 if (transform & NATIVE_WINDOW_TRANSFORM_ROT_90) {
133 tr = tr * rot90;
134 }
135 if (transform & NATIVE_WINDOW_TRANSFORM_FLIP_H) {
136 tr = tr * flipH;
137 }
138 if (transform & NATIVE_WINDOW_TRANSFORM_FLIP_V) {
139 tr = tr * flipV;
140 }
141 return inverse(tr);
142}
143
Vishnu Nair9b079a22020-01-21 14:36:08 -0800144std::optional<compositionengine::LayerFE::LayerSettings> BufferLayer::prepareClientComposition(
Lloyd Piquef16688f2019-02-19 17:47:57 -0800145 compositionengine::LayerFE::ClientCompositionTargetSettings& targetSettings) {
David Sodman0c69cad2017-08-21 12:12:51 -0700146 ATRACE_CALL();
Lloyd Piquef16688f2019-02-19 17:47:57 -0800147
Vishnu Nair9b079a22020-01-21 14:36:08 -0800148 std::optional<compositionengine::LayerFE::LayerSettings> result =
149 Layer::prepareClientComposition(targetSettings);
Lloyd Piquef16688f2019-02-19 17:47:57 -0800150 if (!result) {
151 return result;
152 }
153
chaviwd62d3062019-09-04 14:48:02 -0700154 if (CC_UNLIKELY(mBufferInfo.mBuffer == 0)) {
David Sodman0c69cad2017-08-21 12:12:51 -0700155 // the texture has not been created yet, this Layer has
156 // in fact never been drawn into. This happens frequently with
157 // SurfaceView because the WindowManager can't know when the client
158 // has drawn the first time.
159
160 // If there is nothing under us, we paint the screen in black, otherwise
161 // we just skip this update.
162
163 // figure out if there is something below us
164 Region under;
165 bool finished = false;
166 mFlinger->mDrawingState.traverseInZOrder([&](Layer* layer) {
167 if (finished || layer == static_cast<BufferLayer const*>(this)) {
168 finished = true;
169 return;
170 }
Lloyd Piquea2468662019-03-07 21:31:06 -0800171
172 under.orSelf(layer->getScreenBounds());
David Sodman0c69cad2017-08-21 12:12:51 -0700173 });
174 // if not everything below us is covered, we plug the holes!
Lloyd Piquef16688f2019-02-19 17:47:57 -0800175 Region holes(targetSettings.clip.subtract(under));
David Sodman0c69cad2017-08-21 12:12:51 -0700176 if (!holes.isEmpty()) {
Lloyd Piquef16688f2019-02-19 17:47:57 -0800177 targetSettings.clearRegion.orSelf(holes);
David Sodman0c69cad2017-08-21 12:12:51 -0700178 }
Lloyd Piquef16688f2019-02-19 17:47:57 -0800179 return std::nullopt;
David Sodman0c69cad2017-08-21 12:12:51 -0700180 }
Lloyd Pique688abd42019-02-15 15:42:24 -0800181 bool blackOutLayer = (isProtected() && !targetSettings.supportsProtectedContent) ||
Lloyd Piquef16688f2019-02-19 17:47:57 -0800182 (isSecure() && !targetSettings.isSecure);
Lloyd Piquede196652020-01-22 17:29:58 -0800183 compositionengine::LayerFE::LayerSettings& layer = *result;
Vishnu Nairb87d94f2020-02-13 09:17:36 -0800184 if (blackOutLayer) {
185 prepareClearClientComposition(layer, true /* blackout */);
186 return layer;
David Sodman0c69cad2017-08-21 12:12:51 -0700187 }
Alec Mourie7d1d4a2019-02-05 01:13:46 +0000188
Vishnu Nairb87d94f2020-02-13 09:17:36 -0800189 const State& s(getDrawingState());
190 layer.source.buffer.buffer = mBufferInfo.mBuffer;
191 layer.source.buffer.isOpaque = isOpaque(s);
192 layer.source.buffer.fence = mBufferInfo.mFence;
193 layer.source.buffer.textureName = mTextureName;
194 layer.source.buffer.usePremultipliedAlpha = getPremultipledAlpha();
195 layer.source.buffer.isY410BT2020 = isHdrY410();
196 bool hasSmpte2086 = mBufferInfo.mHdrMetadata.validTypes & HdrMetadata::SMPTE2086;
197 bool hasCta861_3 = mBufferInfo.mHdrMetadata.validTypes & HdrMetadata::CTA861_3;
198 layer.source.buffer.maxMasteringLuminance = hasSmpte2086
199 ? mBufferInfo.mHdrMetadata.smpte2086.maxLuminance
200 : defaultMaxMasteringLuminance;
201 layer.source.buffer.maxContentLuminance = hasCta861_3
202 ? mBufferInfo.mHdrMetadata.cta8613.maxContentLightLevel
203 : defaultMaxContentLuminance;
204 layer.frameNumber = mCurrentFrameNumber;
205 layer.bufferId = mBufferInfo.mBuffer ? mBufferInfo.mBuffer->getId() : 0;
206
207 // TODO: we could be more subtle with isFixedSize()
208 const bool useFiltering = targetSettings.needsFiltering || mNeedsFiltering || isFixedSize();
209
210 // Query the texture matrix given our current filtering mode.
211 float textureMatrix[16];
212 getDrawingTransformMatrix(useFiltering, textureMatrix);
213
214 if (getTransformToDisplayInverse()) {
215 /*
216 * the code below applies the primary display's inverse transform to
217 * the texture transform
218 */
219 uint32_t transform = DisplayDevice::getPrimaryDisplayRotationFlags();
220 mat4 tr = inverseOrientation(transform);
221
222 /**
223 * TODO(b/36727915): This is basically a hack.
224 *
225 * Ensure that regardless of the parent transformation,
226 * this buffer is always transformed from native display
227 * orientation to display orientation. For example, in the case
228 * of a camera where the buffer remains in native orientation,
229 * we want the pixels to always be upright.
230 */
231 sp<Layer> p = mDrawingParent.promote();
232 if (p != nullptr) {
233 const auto parentTransform = p->getTransform();
234 tr = tr * inverseOrientation(parentTransform.getOrientation());
235 }
236
237 // and finally apply it to the original texture matrix
238 const mat4 texTransform(mat4(static_cast<const float*>(textureMatrix)) * tr);
239 memcpy(textureMatrix, texTransform.asArray(), sizeof(textureMatrix));
240 }
241
242 const Rect win{getBounds()};
243 float bufferWidth = getBufferSize(s).getWidth();
244 float bufferHeight = getBufferSize(s).getHeight();
245
246 // BufferStateLayers can have a "buffer size" of [0, 0, -1, -1] when no display frame has
247 // been set and there is no parent layer bounds. In that case, the scale is meaningless so
248 // ignore them.
249 if (!getBufferSize(s).isValid()) {
250 bufferWidth = float(win.right) - float(win.left);
251 bufferHeight = float(win.bottom) - float(win.top);
252 }
253
254 const float scaleHeight = (float(win.bottom) - float(win.top)) / bufferHeight;
255 const float scaleWidth = (float(win.right) - float(win.left)) / bufferWidth;
256 const float translateY = float(win.top) / bufferHeight;
257 const float translateX = float(win.left) / bufferWidth;
258
259 // Flip y-coordinates because GLConsumer expects OpenGL convention.
260 mat4 tr = mat4::translate(vec4(.5, .5, 0, 1)) * mat4::scale(vec4(1, -1, 1, 1)) *
261 mat4::translate(vec4(-.5, -.5, 0, 1)) *
262 mat4::translate(vec4(translateX, translateY, 0, 1)) *
263 mat4::scale(vec4(scaleWidth, scaleHeight, 1.0, 1.0));
264
265 layer.source.buffer.useTextureFiltering = useFiltering;
266 layer.source.buffer.textureTransform = mat4(static_cast<const float*>(textureMatrix)) * tr;
267
Vishnu Nair9b079a22020-01-21 14:36:08 -0800268 return layer;
David Sodman0c69cad2017-08-21 12:12:51 -0700269}
270
Marissa Wallfd668622018-05-10 10:21:13 -0700271bool BufferLayer::isHdrY410() const {
272 // pixel format is HDR Y410 masquerading as RGBA_1010102
chaviw4244e032019-09-04 11:27:49 -0700273 return (mBufferInfo.mDataspace == ui::Dataspace::BT2020_ITU_PQ &&
274 mBufferInfo.mApi == NATIVE_WINDOW_API_MEDIA &&
chaviwdebadb82020-03-26 14:57:24 -0700275 mBufferInfo.mPixelFormat == HAL_PIXEL_FORMAT_RGBA_1010102);
David Sodmaneb085e02017-10-05 18:49:04 -0700276}
277
Lloyd Piquede196652020-01-22 17:29:58 -0800278sp<compositionengine::LayerFE> BufferLayer::getCompositionEngineLayerFE() const {
279 return asLayerFE();
280}
281
282compositionengine::LayerFECompositionState* BufferLayer::editCompositionState() {
283 return mCompositionState.get();
284}
285
286const compositionengine::LayerFECompositionState* BufferLayer::getCompositionState() const {
287 return mCompositionState.get();
288}
289
290void BufferLayer::preparePerFrameCompositionState() {
291 Layer::preparePerFrameCompositionState();
David Sodman0c69cad2017-08-21 12:12:51 -0700292
293 // Sideband layers
Lloyd Piquede196652020-01-22 17:29:58 -0800294 auto* compositionState = editCompositionState();
295 if (compositionState->sidebandStream.get()) {
296 compositionState->compositionType = Hwc2::IComposerClient::Composition::SIDEBAND;
David Sodman15094112018-10-11 09:39:37 -0700297 } else {
Lloyd Piquef5275482019-01-29 18:42:42 -0800298 // Normal buffer layers
Lloyd Piquede196652020-01-22 17:29:58 -0800299 compositionState->hdrMetadata = mBufferInfo.mHdrMetadata;
300 compositionState->compositionType = mPotentialCursor
Lloyd Piquef5275482019-01-29 18:42:42 -0800301 ? Hwc2::IComposerClient::Composition::CURSOR
302 : Hwc2::IComposerClient::Composition::DEVICE;
David Sodman0c69cad2017-08-21 12:12:51 -0700303 }
David Sodman0c69cad2017-08-21 12:12:51 -0700304}
305
Marissa Wallfd668622018-05-10 10:21:13 -0700306bool BufferLayer::onPreComposition(nsecs_t refreshStartTime) {
chaviwd62d3062019-09-04 14:48:02 -0700307 if (mBufferInfo.mBuffer != nullptr) {
Marissa Wallfd668622018-05-10 10:21:13 -0700308 Mutex::Autolock lock(mFrameEventHistoryMutex);
309 mFrameEventHistory.addPreComposition(mCurrentFrameNumber, refreshStartTime);
David Sodman0c69cad2017-08-21 12:12:51 -0700310 }
Marissa Wallfd668622018-05-10 10:21:13 -0700311 mRefreshPending = false;
312 return hasReadyFrame();
David Sodman0c69cad2017-08-21 12:12:51 -0700313}
314
Adithya Srinivasanb69e0762019-11-11 18:39:53 -0800315bool BufferLayer::onPostComposition(sp<const DisplayDevice> displayDevice,
Dominik Laskowski075d3172018-05-24 15:50:06 -0700316 const std::shared_ptr<FenceTime>& glDoneFence,
Marissa Wallfd668622018-05-10 10:21:13 -0700317 const std::shared_ptr<FenceTime>& presentFence,
318 const CompositorTiming& compositorTiming) {
319 // mFrameLatencyNeeded is true when a new frame was latched for the
320 // composition.
chaviw74b03172019-08-19 11:09:03 -0700321 if (!mBufferInfo.mFrameLatencyNeeded) return false;
Marissa Wallfd668622018-05-10 10:21:13 -0700322
323 // Update mFrameEventHistory.
Dan Stoza436ccf32018-06-21 12:10:12 -0700324 {
Marissa Wallfd668622018-05-10 10:21:13 -0700325 Mutex::Autolock lock(mFrameEventHistoryMutex);
326 mFrameEventHistory.addPostComposition(mCurrentFrameNumber, glDoneFence, presentFence,
327 compositorTiming);
Valerie Hau93d5a5e2020-02-13 14:50:01 -0800328 finalizeFrameEventHistory(glDoneFence, compositorTiming);
David Sodman0c69cad2017-08-21 12:12:51 -0700329 }
330
Marissa Wallfd668622018-05-10 10:21:13 -0700331 // Update mFrameTracker.
chaviw4244e032019-09-04 11:27:49 -0700332 nsecs_t desiredPresentTime = mBufferInfo.mDesiredPresentTime;
Marissa Wallfd668622018-05-10 10:21:13 -0700333 mFrameTracker.setDesiredPresentTime(desiredPresentTime);
334
Yiwei Zhang1a88c402019-11-18 10:43:58 -0800335 const int32_t layerId = getSequence();
336 mFlinger->mTimeStats->setDesiredTime(layerId, mCurrentFrameNumber, desiredPresentTime);
Marissa Wallfd668622018-05-10 10:21:13 -0700337
Adithya Srinivasanb69e0762019-11-11 18:39:53 -0800338 const auto outputLayer = findOutputLayerForDisplay(displayDevice);
339 if (outputLayer && outputLayer->requiresClientComposition()) {
340 nsecs_t clientCompositionTimestamp = outputLayer->getState().clientCompositionTimestamp;
341 mFlinger->mFrameTracer->traceTimestamp(layerId, getCurrentBufferId(), mCurrentFrameNumber,
342 clientCompositionTimestamp,
343 FrameTracer::FrameEvent::FALLBACK_COMPOSITION);
344 }
345
chaviw4244e032019-09-04 11:27:49 -0700346 std::shared_ptr<FenceTime> frameReadyFence = mBufferInfo.mFenceTime;
Marissa Wallfd668622018-05-10 10:21:13 -0700347 if (frameReadyFence->isValid()) {
348 mFrameTracker.setFrameReadyFence(std::move(frameReadyFence));
349 } else {
350 // There was no fence for this frame, so assume that it was ready
351 // to be presented at the desired present time.
352 mFrameTracker.setFrameReadyTime(desiredPresentTime);
Dominik Laskowski45de9bd2018-06-11 17:44:10 -0700353 }
Marissa Wallfd668622018-05-10 10:21:13 -0700354
Adithya Srinivasanb69e0762019-11-11 18:39:53 -0800355 const auto displayId = displayDevice->getId();
Marissa Wallfd668622018-05-10 10:21:13 -0700356 if (presentFence->isValid()) {
Yiwei Zhang1a88c402019-11-18 10:43:58 -0800357 mFlinger->mTimeStats->setPresentFence(layerId, mCurrentFrameNumber, presentFence);
358 mFlinger->mFrameTracer->traceFence(layerId, getCurrentBufferId(), mCurrentFrameNumber,
Mikael Pessa90092f42019-08-26 17:22:04 -0700359 presentFence, FrameTracer::FrameEvent::PRESENT_FENCE);
Marissa Wallfd668622018-05-10 10:21:13 -0700360 mFrameTracker.setActualPresentFence(std::shared_ptr<FenceTime>(presentFence));
Dominik Laskowski075d3172018-05-24 15:50:06 -0700361 } else if (displayId && mFlinger->getHwComposer().isConnected(*displayId)) {
Marissa Wallfd668622018-05-10 10:21:13 -0700362 // The HWC doesn't support present fences, so use the refresh
363 // timestamp instead.
Dominik Laskowski075d3172018-05-24 15:50:06 -0700364 const nsecs_t actualPresentTime = mFlinger->getHwComposer().getRefreshTimestamp(*displayId);
Yiwei Zhang1a88c402019-11-18 10:43:58 -0800365 mFlinger->mTimeStats->setPresentTime(layerId, mCurrentFrameNumber, actualPresentTime);
366 mFlinger->mFrameTracer->traceTimestamp(layerId, getCurrentBufferId(), mCurrentFrameNumber,
Mikael Pessa90092f42019-08-26 17:22:04 -0700367 actualPresentTime,
368 FrameTracer::FrameEvent::PRESENT_FENCE);
Marissa Wallfd668622018-05-10 10:21:13 -0700369 mFrameTracker.setActualPresentTime(actualPresentTime);
370 }
371
372 mFrameTracker.advanceFrame();
chaviw74b03172019-08-19 11:09:03 -0700373 mBufferInfo.mFrameLatencyNeeded = false;
Marissa Wallfd668622018-05-10 10:21:13 -0700374 return true;
David Sodman0c69cad2017-08-21 12:12:51 -0700375}
376
chaviwdebadb82020-03-26 14:57:24 -0700377void BufferLayer::gatherBufferInfo() {
378 mBufferInfo.mPixelFormat =
379 !mBufferInfo.mBuffer ? PIXEL_FORMAT_NONE : mBufferInfo.mBuffer->format;
380 mBufferInfo.mFrameLatencyNeeded = true;
381}
382
Dominik Laskowskia8955dd2019-07-10 10:19:09 -0700383bool BufferLayer::latchBuffer(bool& recomputeVisibleRegions, nsecs_t latchTime,
384 nsecs_t expectedPresentTime) {
Marissa Wallfd668622018-05-10 10:21:13 -0700385 ATRACE_CALL();
David Sodman0c69cad2017-08-21 12:12:51 -0700386
Vishnu Nair6194e2e2019-02-06 12:58:39 -0800387 bool refreshRequired = latchSidebandStream(recomputeVisibleRegions);
David Sodman0c69cad2017-08-21 12:12:51 -0700388
Vishnu Nair6194e2e2019-02-06 12:58:39 -0800389 if (refreshRequired) {
390 return refreshRequired;
David Sodman0c69cad2017-08-21 12:12:51 -0700391 }
392
Marissa Wallfd668622018-05-10 10:21:13 -0700393 if (!hasReadyFrame()) {
Vishnu Nair6194e2e2019-02-06 12:58:39 -0800394 return false;
David Sodman0c69cad2017-08-21 12:12:51 -0700395 }
David Sodman0c69cad2017-08-21 12:12:51 -0700396
Marissa Wallfd668622018-05-10 10:21:13 -0700397 // if we've already called updateTexImage() without going through
398 // a composition step, we have to skip this layer at this point
399 // because we cannot call updateTeximage() without a corresponding
400 // compositionComplete() call.
401 // we'll trigger an update in onPreComposition().
402 if (mRefreshPending) {
Vishnu Nair6194e2e2019-02-06 12:58:39 -0800403 return false;
Marissa Wallfd668622018-05-10 10:21:13 -0700404 }
405
406 // If the head buffer's acquire fence hasn't signaled yet, return and
407 // try again later
408 if (!fenceHasSignaled()) {
Ady Abraham09bd3922019-04-08 10:44:56 -0700409 ATRACE_NAME("!fenceHasSignaled()");
David Sodman0c69cad2017-08-21 12:12:51 -0700410 mFlinger->signalLayerUpdate();
Vishnu Nair6194e2e2019-02-06 12:58:39 -0800411 return false;
Marissa Wallfd668622018-05-10 10:21:13 -0700412 }
413
414 // Capture the old state of the layer for comparisons later
415 const State& s(getDrawingState());
416 const bool oldOpacity = isOpaque(s);
chaviwd62d3062019-09-04 14:48:02 -0700417
418 BufferInfo oldBufferInfo = mBufferInfo;
Marissa Wallfd668622018-05-10 10:21:13 -0700419
Dominik Laskowskia8955dd2019-07-10 10:19:09 -0700420 if (!allTransactionsSignaled(expectedPresentTime)) {
Marissa Wallebb486e2019-05-15 14:08:08 -0700421 mFlinger->setTransactionFlags(eTraversalNeeded);
Vishnu Nair6194e2e2019-02-06 12:58:39 -0800422 return false;
Marissa Wallfd668622018-05-10 10:21:13 -0700423 }
424
Dominik Laskowskia8955dd2019-07-10 10:19:09 -0700425 status_t err = updateTexImage(recomputeVisibleRegions, latchTime, expectedPresentTime);
Marissa Wallfd668622018-05-10 10:21:13 -0700426 if (err != NO_ERROR) {
Vishnu Nair6194e2e2019-02-06 12:58:39 -0800427 return false;
Marissa Wallfd668622018-05-10 10:21:13 -0700428 }
429
430 err = updateActiveBuffer();
431 if (err != NO_ERROR) {
Vishnu Nair6194e2e2019-02-06 12:58:39 -0800432 return false;
Marissa Wallfd668622018-05-10 10:21:13 -0700433 }
434
Marissa Wallfd668622018-05-10 10:21:13 -0700435 err = updateFrameNumber(latchTime);
436 if (err != NO_ERROR) {
Vishnu Nair6194e2e2019-02-06 12:58:39 -0800437 return false;
Marissa Wallfd668622018-05-10 10:21:13 -0700438 }
439
chaviw4244e032019-09-04 11:27:49 -0700440 gatherBufferInfo();
441
Marissa Wallfd668622018-05-10 10:21:13 -0700442 mRefreshPending = true;
chaviwd62d3062019-09-04 14:48:02 -0700443 if (oldBufferInfo.mBuffer == nullptr) {
Marissa Wallfd668622018-05-10 10:21:13 -0700444 // the first time we receive a buffer, we need to trigger a
445 // geometry invalidation.
446 recomputeVisibleRegions = true;
447 }
448
chaviw4244e032019-09-04 11:27:49 -0700449 if ((mBufferInfo.mCrop != oldBufferInfo.mCrop) ||
450 (mBufferInfo.mTransform != oldBufferInfo.mTransform) ||
451 (mBufferInfo.mScaleMode != oldBufferInfo.mScaleMode) ||
452 (mBufferInfo.mTransformToDisplayInverse != oldBufferInfo.mTransformToDisplayInverse)) {
Marissa Wallfd668622018-05-10 10:21:13 -0700453 recomputeVisibleRegions = true;
454 }
455
chaviwd62d3062019-09-04 14:48:02 -0700456 if (oldBufferInfo.mBuffer != nullptr) {
457 uint32_t bufWidth = mBufferInfo.mBuffer->getWidth();
458 uint32_t bufHeight = mBufferInfo.mBuffer->getHeight();
459 if (bufWidth != uint32_t(oldBufferInfo.mBuffer->width) ||
460 bufHeight != uint32_t(oldBufferInfo.mBuffer->height)) {
Marissa Wallfd668622018-05-10 10:21:13 -0700461 recomputeVisibleRegions = true;
462 }
463 }
464
465 if (oldOpacity != isOpaque(s)) {
466 recomputeVisibleRegions = true;
467 }
468
469 // Remove any sync points corresponding to the buffer which was just
470 // latched
471 {
472 Mutex::Autolock lock(mLocalSyncPointMutex);
473 auto point = mLocalSyncPoints.begin();
474 while (point != mLocalSyncPoints.end()) {
475 if (!(*point)->frameIsAvailable() || !(*point)->transactionIsApplied()) {
476 // This sync point must have been added since we started
477 // latching. Don't drop it yet.
478 ++point;
479 continue;
480 }
481
482 if ((*point)->getFrameNumber() <= mCurrentFrameNumber) {
Alec Mourie60041e2019-06-14 18:59:51 -0700483 std::stringstream ss;
484 ss << "Dropping sync point " << (*point)->getFrameNumber();
485 ATRACE_NAME(ss.str().c_str());
Marissa Wallfd668622018-05-10 10:21:13 -0700486 point = mLocalSyncPoints.erase(point);
487 } else {
488 ++point;
489 }
490 }
491 }
492
Robert Carra1257842020-01-31 13:48:28 -0800493 if (recomputeVisibleRegions == true) {
494 maybeDirtyInput();
495 }
496
Vishnu Nair6194e2e2019-02-06 12:58:39 -0800497 return true;
Marissa Wallfd668622018-05-10 10:21:13 -0700498}
499
500// transaction
Dominik Laskowskia8955dd2019-07-10 10:19:09 -0700501void BufferLayer::notifyAvailableFrames(nsecs_t expectedPresentTime) {
502 const auto headFrameNumber = getHeadFrameNumber(expectedPresentTime);
Ady Abrahamcd1580c2019-04-29 15:40:03 -0700503 const bool headFenceSignaled = fenceHasSignaled();
Dominik Laskowskia8955dd2019-07-10 10:19:09 -0700504 const bool presentTimeIsCurrent = framePresentTimeIsCurrent(expectedPresentTime);
Marissa Wallfd668622018-05-10 10:21:13 -0700505 Mutex::Autolock lock(mLocalSyncPointMutex);
506 for (auto& point : mLocalSyncPoints) {
Ady Abrahamcd1580c2019-04-29 15:40:03 -0700507 if (headFrameNumber >= point->getFrameNumber() && headFenceSignaled &&
508 presentTimeIsCurrent) {
Marissa Wallfd668622018-05-10 10:21:13 -0700509 point->setFrameAvailable();
chaviw43cb3cb2019-05-31 15:23:41 -0700510 sp<Layer> requestedSyncLayer = point->getRequestedSyncLayer();
511 if (requestedSyncLayer) {
512 // Need to update the transaction flag to ensure the layer's pending transaction
513 // gets applied.
514 requestedSyncLayer->setTransactionFlags(eTransactionNeeded);
515 }
Marissa Wallfd668622018-05-10 10:21:13 -0700516 }
David Sodman0c69cad2017-08-21 12:12:51 -0700517 }
518}
519
Marissa Wallfd668622018-05-10 10:21:13 -0700520bool BufferLayer::hasReadyFrame() const {
Marissa Wall024a1912018-08-13 13:55:35 -0700521 return hasFrameUpdate() || getSidebandStreamChanged() || getAutoRefresh();
Marissa Wallfd668622018-05-10 10:21:13 -0700522}
523
524uint32_t BufferLayer::getEffectiveScalingMode() const {
525 if (mOverrideScalingMode >= 0) {
526 return mOverrideScalingMode;
527 }
528
chaviw4244e032019-09-04 11:27:49 -0700529 return mBufferInfo.mScaleMode;
Marissa Wallfd668622018-05-10 10:21:13 -0700530}
531
532bool BufferLayer::isProtected() const {
chaviwd62d3062019-09-04 14:48:02 -0700533 const sp<GraphicBuffer>& buffer(mBufferInfo.mBuffer);
Marissa Wallfd668622018-05-10 10:21:13 -0700534 return (buffer != 0) && (buffer->getUsage() & GRALLOC_USAGE_PROTECTED);
535}
536
537bool BufferLayer::latchUnsignaledBuffers() {
538 static bool propertyLoaded = false;
539 static bool latch = false;
540 static std::mutex mutex;
541 std::lock_guard<std::mutex> lock(mutex);
542 if (!propertyLoaded) {
543 char value[PROPERTY_VALUE_MAX] = {};
544 property_get("debug.sf.latch_unsignaled", value, "0");
545 latch = atoi(value);
546 propertyLoaded = true;
547 }
548 return latch;
549}
550
551// h/w composer set-up
Dominik Laskowskia8955dd2019-07-10 10:19:09 -0700552bool BufferLayer::allTransactionsSignaled(nsecs_t expectedPresentTime) {
553 const auto headFrameNumber = getHeadFrameNumber(expectedPresentTime);
Marissa Wallfd668622018-05-10 10:21:13 -0700554 bool matchingFramesFound = false;
555 bool allTransactionsApplied = true;
556 Mutex::Autolock lock(mLocalSyncPointMutex);
557
558 for (auto& point : mLocalSyncPoints) {
559 if (point->getFrameNumber() > headFrameNumber) {
560 break;
561 }
562 matchingFramesFound = true;
563
564 if (!point->frameIsAvailable()) {
565 // We haven't notified the remote layer that the frame for
566 // this point is available yet. Notify it now, and then
567 // abort this attempt to latch.
568 point->setFrameAvailable();
569 allTransactionsApplied = false;
570 break;
571 }
572
573 allTransactionsApplied = allTransactionsApplied && point->transactionIsApplied();
574 }
575 return !matchingFramesFound || allTransactionsApplied;
David Sodman0c69cad2017-08-21 12:12:51 -0700576}
577
578// As documented in libhardware header, formats in the range
579// 0x100 - 0x1FF are specific to the HAL implementation, and
580// are known to have no alpha channel
581// TODO: move definition for device-specific range into
582// hardware.h, instead of using hard-coded values here.
583#define HARDWARE_IS_DEVICE_FORMAT(f) ((f) >= 0x100 && (f) <= 0x1FF)
584
585bool BufferLayer::getOpacityForFormat(uint32_t format) {
586 if (HARDWARE_IS_DEVICE_FORMAT(format)) {
587 return true;
588 }
589 switch (format) {
590 case HAL_PIXEL_FORMAT_RGBA_8888:
591 case HAL_PIXEL_FORMAT_BGRA_8888:
592 case HAL_PIXEL_FORMAT_RGBA_FP16:
593 case HAL_PIXEL_FORMAT_RGBA_1010102:
594 return false;
595 }
596 // in all other case, we have no blending (also for unknown formats)
597 return true;
598}
599
Lloyd Pique37c2c9b2018-12-04 17:25:10 -0800600bool BufferLayer::needsFiltering(const sp<const DisplayDevice>& displayDevice) const {
Lloyd Piquef16688f2019-02-19 17:47:57 -0800601 // If we are not capturing based on the state of a known display device,
602 // just return false.
Lloyd Pique37c2c9b2018-12-04 17:25:10 -0800603 if (displayDevice == nullptr) {
Lloyd Piquef16688f2019-02-19 17:47:57 -0800604 return false;
Lloyd Pique37c2c9b2018-12-04 17:25:10 -0800605 }
606
607 const auto outputLayer = findOutputLayerForDisplay(displayDevice);
608 if (outputLayer == nullptr) {
Lloyd Piquef16688f2019-02-19 17:47:57 -0800609 return false;
Lloyd Pique37c2c9b2018-12-04 17:25:10 -0800610 }
611
Lloyd Piquef16688f2019-02-19 17:47:57 -0800612 // We need filtering if the sourceCrop rectangle size does not match the
613 // displayframe rectangle size (not a 1:1 render)
Lloyd Pique37c2c9b2018-12-04 17:25:10 -0800614 const auto& compositionState = outputLayer->getState();
615 const auto displayFrame = compositionState.displayFrame;
616 const auto sourceCrop = compositionState.sourceCrop;
Lloyd Piquef16688f2019-02-19 17:47:57 -0800617 return sourceCrop.getHeight() != displayFrame.getHeight() ||
Peiyong Linc2020ca2019-01-10 11:36:12 -0800618 sourceCrop.getWidth() != displayFrame.getWidth();
Chia-I Wu692e0832018-06-05 15:46:58 -0700619}
620
Dominik Laskowskia8955dd2019-07-10 10:19:09 -0700621uint64_t BufferLayer::getHeadFrameNumber(nsecs_t expectedPresentTime) const {
Lloyd Pique0449b0f2018-12-20 16:23:45 -0800622 if (hasFrameUpdate()) {
Dominik Laskowskia8955dd2019-07-10 10:19:09 -0700623 return getFrameNumber(expectedPresentTime);
David Sodman0c69cad2017-08-21 12:12:51 -0700624 } else {
625 return mCurrentFrameNumber;
626 }
627}
628
Vishnu Nair60356342018-11-13 13:00:45 -0800629Rect BufferLayer::getBufferSize(const State& s) const {
630 // If we have a sideband stream, or we are scaling the buffer then return the layer size since
631 // we cannot determine the buffer size.
632 if ((s.sidebandStream != nullptr) ||
633 (getEffectiveScalingMode() != NATIVE_WINDOW_SCALING_MODE_FREEZE)) {
634 return Rect(getActiveWidth(s), getActiveHeight(s));
635 }
636
chaviwd62d3062019-09-04 14:48:02 -0700637 if (mBufferInfo.mBuffer == nullptr) {
Vishnu Nair60356342018-11-13 13:00:45 -0800638 return Rect::INVALID_RECT;
639 }
640
chaviwd62d3062019-09-04 14:48:02 -0700641 uint32_t bufWidth = mBufferInfo.mBuffer->getWidth();
642 uint32_t bufHeight = mBufferInfo.mBuffer->getHeight();
Vishnu Nair60356342018-11-13 13:00:45 -0800643
644 // Undo any transformations on the buffer and return the result.
chaviw4244e032019-09-04 11:27:49 -0700645 if (mBufferInfo.mTransform & ui::Transform::ROT_90) {
Vishnu Nair60356342018-11-13 13:00:45 -0800646 std::swap(bufWidth, bufHeight);
647 }
648
Lloyd Pique0449b0f2018-12-20 16:23:45 -0800649 if (getTransformToDisplayInverse()) {
Dominik Laskowski718f9602019-11-09 20:01:35 -0800650 uint32_t invTransform = DisplayDevice::getPrimaryDisplayRotationFlags();
Vishnu Nair60356342018-11-13 13:00:45 -0800651 if (invTransform & ui::Transform::ROT_90) {
652 std::swap(bufWidth, bufHeight);
653 }
654 }
655
656 return Rect(bufWidth, bufHeight);
657}
658
Vishnu Nair4351ad52019-02-11 14:13:02 -0800659FloatRect BufferLayer::computeSourceBounds(const FloatRect& parentBounds) const {
660 const State& s(getDrawingState());
661
662 // If we have a sideband stream, or we are scaling the buffer then return the layer size since
663 // we cannot determine the buffer size.
664 if ((s.sidebandStream != nullptr) ||
665 (getEffectiveScalingMode() != NATIVE_WINDOW_SCALING_MODE_FREEZE)) {
666 return FloatRect(0, 0, getActiveWidth(s), getActiveHeight(s));
667 }
668
chaviwd62d3062019-09-04 14:48:02 -0700669 if (mBufferInfo.mBuffer == nullptr) {
Vishnu Nair4351ad52019-02-11 14:13:02 -0800670 return parentBounds;
671 }
672
chaviwd62d3062019-09-04 14:48:02 -0700673 uint32_t bufWidth = mBufferInfo.mBuffer->getWidth();
674 uint32_t bufHeight = mBufferInfo.mBuffer->getHeight();
Vishnu Nair4351ad52019-02-11 14:13:02 -0800675
676 // Undo any transformations on the buffer and return the result.
chaviw4244e032019-09-04 11:27:49 -0700677 if (mBufferInfo.mTransform & ui::Transform::ROT_90) {
Vishnu Nair4351ad52019-02-11 14:13:02 -0800678 std::swap(bufWidth, bufHeight);
679 }
680
681 if (getTransformToDisplayInverse()) {
Dominik Laskowski718f9602019-11-09 20:01:35 -0800682 uint32_t invTransform = DisplayDevice::getPrimaryDisplayRotationFlags();
Vishnu Nair4351ad52019-02-11 14:13:02 -0800683 if (invTransform & ui::Transform::ROT_90) {
684 std::swap(bufWidth, bufHeight);
685 }
686 }
687
688 return FloatRect(0, 0, bufWidth, bufHeight);
689}
690
chaviw49a108c2019-08-12 11:23:06 -0700691void BufferLayer::latchAndReleaseBuffer() {
692 mRefreshPending = false;
693 if (hasReadyFrame()) {
694 bool ignored = false;
695 latchBuffer(ignored, systemTime(), 0 /* expectedPresentTime */);
696 }
697 releasePendingBuffer(systemTime());
698}
699
chaviw4244e032019-09-04 11:27:49 -0700700PixelFormat BufferLayer::getPixelFormat() const {
701 return mBufferInfo.mPixelFormat;
702}
703
704bool BufferLayer::getTransformToDisplayInverse() const {
705 return mBufferInfo.mTransformToDisplayInverse;
706}
707
708Rect BufferLayer::getBufferCrop() const {
709 // this is the crop rectangle that applies to the buffer
710 // itself (as opposed to the window)
711 if (!mBufferInfo.mCrop.isEmpty()) {
712 // if the buffer crop is defined, we use that
713 return mBufferInfo.mCrop;
chaviwd62d3062019-09-04 14:48:02 -0700714 } else if (mBufferInfo.mBuffer != nullptr) {
chaviw4244e032019-09-04 11:27:49 -0700715 // otherwise we use the whole buffer
chaviwd62d3062019-09-04 14:48:02 -0700716 return mBufferInfo.mBuffer->getBounds();
chaviw4244e032019-09-04 11:27:49 -0700717 } else {
718 // if we don't have a buffer yet, we use an empty/invalid crop
719 return Rect();
720 }
721}
722
723uint32_t BufferLayer::getBufferTransform() const {
724 return mBufferInfo.mTransform;
725}
726
727ui::Dataspace BufferLayer::getDataSpace() const {
728 return mBufferInfo.mDataspace;
729}
730
731ui::Dataspace BufferLayer::translateDataspace(ui::Dataspace dataspace) {
732 ui::Dataspace updatedDataspace = dataspace;
733 // translate legacy dataspaces to modern dataspaces
734 switch (dataspace) {
735 case ui::Dataspace::SRGB:
736 updatedDataspace = ui::Dataspace::V0_SRGB;
737 break;
738 case ui::Dataspace::SRGB_LINEAR:
739 updatedDataspace = ui::Dataspace::V0_SRGB_LINEAR;
740 break;
741 case ui::Dataspace::JFIF:
742 updatedDataspace = ui::Dataspace::V0_JFIF;
743 break;
744 case ui::Dataspace::BT601_625:
745 updatedDataspace = ui::Dataspace::V0_BT601_625;
746 break;
747 case ui::Dataspace::BT601_525:
748 updatedDataspace = ui::Dataspace::V0_BT601_525;
749 break;
750 case ui::Dataspace::BT709:
751 updatedDataspace = ui::Dataspace::V0_BT709;
752 break;
753 default:
754 break;
755 }
756
757 return updatedDataspace;
758}
759
chaviwd62d3062019-09-04 14:48:02 -0700760sp<GraphicBuffer> BufferLayer::getBuffer() const {
761 return mBufferInfo.mBuffer;
762}
763
chaviwf83ce182019-09-12 14:43:08 -0700764void BufferLayer::getDrawingTransformMatrix(bool filteringEnabled, float outMatrix[16]) {
765 GLConsumer::computeTransformMatrix(outMatrix, mBufferInfo.mBuffer, mBufferInfo.mCrop,
766 mBufferInfo.mTransform, filteringEnabled);
767}
768
chaviwb4c6e582019-08-16 14:35:07 -0700769void BufferLayer::setInitialValuesForClone(const sp<Layer>& clonedFrom) {
770 Layer::setInitialValuesForClone(clonedFrom);
771
772 sp<BufferLayer> bufferClonedFrom = static_cast<BufferLayer*>(clonedFrom.get());
773 mPremultipliedAlpha = bufferClonedFrom->mPremultipliedAlpha;
774 mPotentialCursor = bufferClonedFrom->mPotentialCursor;
775 mProtectedByApp = bufferClonedFrom->mProtectedByApp;
chaviw74b03172019-08-19 11:09:03 -0700776
777 updateCloneBufferInfo();
778}
779
780void BufferLayer::updateCloneBufferInfo() {
781 if (!isClone() || !isClonedFromAlive()) {
782 return;
783 }
784
785 sp<BufferLayer> clonedFrom = static_cast<BufferLayer*>(getClonedFrom().get());
786 mBufferInfo = clonedFrom->mBufferInfo;
787 mSidebandStream = clonedFrom->mSidebandStream;
788 surfaceDamageRegion = clonedFrom->surfaceDamageRegion;
789 mCurrentFrameNumber = clonedFrom->mCurrentFrameNumber.load();
790 mPreviousFrameNumber = clonedFrom->mPreviousFrameNumber;
791
792 // After buffer info is updated, the drawingState from the real layer needs to be copied into
793 // the cloned. This is because some properties of drawingState can change when latchBuffer is
chaviwaf87b3e2019-10-01 16:59:28 -0700794 // called. However, copying the drawingState would also overwrite the cloned layer's relatives
795 // and touchableRegionCrop. Therefore, temporarily store the relatives so they can be set in
796 // the cloned drawingState again.
chaviw74b03172019-08-19 11:09:03 -0700797 wp<Layer> tmpZOrderRelativeOf = mDrawingState.zOrderRelativeOf;
798 SortedVector<wp<Layer>> tmpZOrderRelatives = mDrawingState.zOrderRelatives;
chaviwaf87b3e2019-10-01 16:59:28 -0700799 wp<Layer> tmpTouchableRegionCrop = mDrawingState.touchableRegionCrop;
800 InputWindowInfo tmpInputInfo = mDrawingState.inputInfo;
801
chaviw74b03172019-08-19 11:09:03 -0700802 mDrawingState = clonedFrom->mDrawingState;
chaviwaf87b3e2019-10-01 16:59:28 -0700803
804 mDrawingState.touchableRegionCrop = tmpTouchableRegionCrop;
chaviw74b03172019-08-19 11:09:03 -0700805 mDrawingState.zOrderRelativeOf = tmpZOrderRelativeOf;
806 mDrawingState.zOrderRelatives = tmpZOrderRelatives;
chaviwaf87b3e2019-10-01 16:59:28 -0700807 mDrawingState.inputInfo = tmpInputInfo;
chaviwb4c6e582019-08-16 14:35:07 -0700808}
809
David Sodman0c69cad2017-08-21 12:12:51 -0700810} // namespace android
811
812#if defined(__gl_h_)
813#error "don't include gl/gl.h in this file"
814#endif
815
816#if defined(__gl2_h_)
817#error "don't include gl2/gl2.h in this file"
818#endif
Ady Abrahamb0dbdaa2020-01-06 16:19:42 -0800819
820// TODO(b/129481165): remove the #pragma below and fix conversion issues
821#pragma clang diagnostic pop // ignored "-Wconversion"