Kevin DuBois | 305bef1 | 2019-10-09 13:23:27 -0700 | [diff] [blame] | 1 | /* |
| 2 | * Copyright 2019 The Android Open Source Project |
| 3 | * |
| 4 | * Licensed under the Apache License, Version 2.0 (the "License"); |
| 5 | * you may not use this file except in compliance with the License. |
| 6 | * You may obtain a copy of the License at |
| 7 | * |
| 8 | * http://www.apache.org/licenses/LICENSE-2.0 |
| 9 | * |
| 10 | * Unless required by applicable law or agreed to in writing, software |
| 11 | * distributed under the License is distributed on an "AS IS" BASIS, |
| 12 | * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. |
| 13 | * See the License for the specific language governing permissions and |
| 14 | * limitations under the License. |
| 15 | */ |
| 16 | |
| 17 | #define ATRACE_TAG ATRACE_TAG_GRAPHICS |
Dominik Laskowski | 62eff35 | 2021-12-06 09:59:41 -0800 | [diff] [blame] | 18 | |
Kevin DuBois | 305bef1 | 2019-10-09 13:23:27 -0700 | [diff] [blame] | 19 | #include <vector> |
| 20 | |
Dominik Laskowski | 62eff35 | 2021-12-06 09:59:41 -0800 | [diff] [blame] | 21 | #include <android-base/stringprintf.h> |
| 22 | #include <ftl/concat.h> |
| 23 | #include <utils/Trace.h> |
Leon Scroggins III | 0773813 | 2023-04-24 11:43:53 -0400 | [diff] [blame] | 24 | #include <log/log_main.h> |
Dominik Laskowski | 62eff35 | 2021-12-06 09:59:41 -0800 | [diff] [blame] | 25 | |
Dominik Laskowski | 4e0d20d | 2021-12-06 11:31:02 -0800 | [diff] [blame] | 26 | #include <scheduler/TimeKeeper.h> |
| 27 | |
Alec Mouri | 9b133ca | 2023-11-14 19:00:01 +0000 | [diff] [blame] | 28 | #include <common/FlagManager.h> |
Kevin DuBois | e4f27a8 | 2019-11-12 11:41:41 -0800 | [diff] [blame] | 29 | #include "VSyncDispatchTimerQueue.h" |
Kevin DuBois | 305bef1 | 2019-10-09 13:23:27 -0700 | [diff] [blame] | 30 | #include "VSyncTracker.h" |
| 31 | |
Leon Scroggins III | 0773813 | 2023-04-24 11:43:53 -0400 | [diff] [blame] | 32 | #undef LOG_TAG |
| 33 | #define LOG_TAG "VSyncDispatch" |
| 34 | |
Kevin DuBois | 305bef1 | 2019-10-09 13:23:27 -0700 | [diff] [blame] | 35 | namespace android::scheduler { |
Dominik Laskowski | 62eff35 | 2021-12-06 09:59:41 -0800 | [diff] [blame] | 36 | |
Ady Abraham | 5e7371c | 2020-03-24 14:47:24 -0700 | [diff] [blame] | 37 | using base::StringAppendF; |
Kevin DuBois | 305bef1 | 2019-10-09 13:23:27 -0700 | [diff] [blame] | 38 | |
Ady Abraham | b5d3afa | 2021-05-07 11:22:23 -0700 | [diff] [blame] | 39 | namespace { |
Dominik Laskowski | 4e0d20d | 2021-12-06 11:31:02 -0800 | [diff] [blame] | 40 | |
Ady Abraham | b0d3d98 | 2023-10-30 11:29:51 -0700 | [diff] [blame] | 41 | nsecs_t getExpectedCallbackTime(nsecs_t nextVsyncTime, |
Ady Abraham | b5d3afa | 2021-05-07 11:22:23 -0700 | [diff] [blame] | 42 | const VSyncDispatch::ScheduleTiming& timing) { |
Ady Abraham | b0d3d98 | 2023-10-30 11:29:51 -0700 | [diff] [blame] | 43 | return nextVsyncTime - timing.readyDuration - timing.workDuration; |
Ady Abraham | b5d3afa | 2021-05-07 11:22:23 -0700 | [diff] [blame] | 44 | } |
| 45 | |
Ady Abraham | b5d3afa | 2021-05-07 11:22:23 -0700 | [diff] [blame] | 46 | } // namespace |
| 47 | |
Kevin DuBois | e4f27a8 | 2019-11-12 11:41:41 -0800 | [diff] [blame] | 48 | VSyncDispatch::~VSyncDispatch() = default; |
Kevin DuBois | 305bef1 | 2019-10-09 13:23:27 -0700 | [diff] [blame] | 49 | VSyncTracker::~VSyncTracker() = default; |
Kevin DuBois | 305bef1 | 2019-10-09 13:23:27 -0700 | [diff] [blame] | 50 | |
Dominik Laskowski | 4e0d20d | 2021-12-06 11:31:02 -0800 | [diff] [blame] | 51 | VSyncDispatchTimerQueueEntry::VSyncDispatchTimerQueueEntry(std::string name, |
| 52 | VSyncDispatch::Callback callback, |
Kevin DuBois | c94ca83 | 2019-11-26 12:56:24 -0800 | [diff] [blame] | 53 | nsecs_t minVsyncDistance) |
Dominik Laskowski | 4e0d20d | 2021-12-06 11:31:02 -0800 | [diff] [blame] | 54 | : mName(std::move(name)), |
| 55 | mCallback(std::move(callback)), |
Kevin DuBois | c94ca83 | 2019-11-26 12:56:24 -0800 | [diff] [blame] | 56 | mMinVsyncDistance(minVsyncDistance) {} |
Kevin DuBois | 305bef1 | 2019-10-09 13:23:27 -0700 | [diff] [blame] | 57 | |
Kevin DuBois | e4f27a8 | 2019-11-12 11:41:41 -0800 | [diff] [blame] | 58 | std::optional<nsecs_t> VSyncDispatchTimerQueueEntry::lastExecutedVsyncTarget() const { |
Kevin DuBois | 305bef1 | 2019-10-09 13:23:27 -0700 | [diff] [blame] | 59 | return mLastDispatchTime; |
| 60 | } |
| 61 | |
Kevin DuBois | e4f27a8 | 2019-11-12 11:41:41 -0800 | [diff] [blame] | 62 | std::string_view VSyncDispatchTimerQueueEntry::name() const { |
Kevin DuBois | 305bef1 | 2019-10-09 13:23:27 -0700 | [diff] [blame] | 63 | return mName; |
| 64 | } |
| 65 | |
Kevin DuBois | e4f27a8 | 2019-11-12 11:41:41 -0800 | [diff] [blame] | 66 | std::optional<nsecs_t> VSyncDispatchTimerQueueEntry::wakeupTime() const { |
Kevin DuBois | 305bef1 | 2019-10-09 13:23:27 -0700 | [diff] [blame] | 67 | if (!mArmedInfo) { |
| 68 | return {}; |
| 69 | } |
| 70 | return {mArmedInfo->mActualWakeupTime}; |
| 71 | } |
| 72 | |
Ady Abraham | 9c53ee7 | 2020-07-22 21:16:18 -0700 | [diff] [blame] | 73 | std::optional<nsecs_t> VSyncDispatchTimerQueueEntry::readyTime() const { |
| 74 | if (!mArmedInfo) { |
| 75 | return {}; |
| 76 | } |
| 77 | return {mArmedInfo->mActualReadyTime}; |
| 78 | } |
| 79 | |
Kevin DuBois | ecb1f0d | 2019-12-12 10:47:41 -0800 | [diff] [blame] | 80 | std::optional<nsecs_t> VSyncDispatchTimerQueueEntry::targetVsync() const { |
| 81 | if (!mArmedInfo) { |
| 82 | return {}; |
| 83 | } |
| 84 | return {mArmedInfo->mActualVsyncTime}; |
| 85 | } |
| 86 | |
Ady Abraham | 9c53ee7 | 2020-07-22 21:16:18 -0700 | [diff] [blame] | 87 | ScheduleResult VSyncDispatchTimerQueueEntry::schedule(VSyncDispatch::ScheduleTiming timing, |
Kevin DuBois | 2311b1a | 2019-11-18 16:19:08 -0800 | [diff] [blame] | 88 | VSyncTracker& tracker, nsecs_t now) { |
Ady Abraham | 4335afd | 2023-12-18 19:10:47 -0800 | [diff] [blame] | 89 | auto nextVsyncTime = |
| 90 | tracker.nextAnticipatedVSyncTimeFrom(std::max(timing.lastVsync, |
| 91 | now + timing.workDuration + |
| 92 | timing.readyDuration), |
| 93 | timing.lastVsync); |
Ady Abraham | 69b9e62 | 2021-07-19 12:24:31 -0700 | [diff] [blame] | 94 | auto nextWakeupTime = nextVsyncTime - timing.workDuration - timing.readyDuration; |
Kevin DuBois | c94ca83 | 2019-11-26 12:56:24 -0800 | [diff] [blame] | 95 | |
| 96 | bool const wouldSkipAVsyncTarget = |
| 97 | mArmedInfo && (nextVsyncTime > (mArmedInfo->mActualVsyncTime + mMinVsyncDistance)); |
Ady Abraham | 69b9e62 | 2021-07-19 12:24:31 -0700 | [diff] [blame] | 98 | bool const wouldSkipAWakeup = |
| 99 | mArmedInfo && ((nextWakeupTime > (mArmedInfo->mActualWakeupTime + mMinVsyncDistance))); |
Ady Abraham | bf55489 | 2024-02-14 18:18:21 +0000 | [diff] [blame] | 100 | if (FlagManager::getInstance().dont_skip_on_early_ro()) { |
Ady Abraham | 529bd9f | 2023-10-05 14:55:30 -0700 | [diff] [blame] | 101 | if (wouldSkipAVsyncTarget || wouldSkipAWakeup) { |
Ady Abraham | b0d3d98 | 2023-10-30 11:29:51 -0700 | [diff] [blame] | 102 | nextVsyncTime = mArmedInfo->mActualVsyncTime; |
| 103 | } else { |
| 104 | nextVsyncTime = adjustVsyncIfNeeded(tracker, nextVsyncTime); |
Ady Abraham | 529bd9f | 2023-10-05 14:55:30 -0700 | [diff] [blame] | 105 | } |
Ady Abraham | b0d3d98 | 2023-10-30 11:29:51 -0700 | [diff] [blame] | 106 | nextWakeupTime = std::max(now, nextVsyncTime - timing.workDuration - timing.readyDuration); |
Ady Abraham | 529bd9f | 2023-10-05 14:55:30 -0700 | [diff] [blame] | 107 | } else { |
| 108 | if (wouldSkipAVsyncTarget && wouldSkipAWakeup) { |
Ady Abraham | b0d3d98 | 2023-10-30 11:29:51 -0700 | [diff] [blame] | 109 | return getExpectedCallbackTime(nextVsyncTime, timing); |
Ady Abraham | 529bd9f | 2023-10-05 14:55:30 -0700 | [diff] [blame] | 110 | } |
Ady Abraham | b0d3d98 | 2023-10-30 11:29:51 -0700 | [diff] [blame] | 111 | nextVsyncTime = adjustVsyncIfNeeded(tracker, nextVsyncTime); |
| 112 | nextWakeupTime = nextVsyncTime - timing.workDuration - timing.readyDuration; |
Kevin DuBois | c94ca83 | 2019-11-26 12:56:24 -0800 | [diff] [blame] | 113 | } |
| 114 | |
Ady Abraham | 9c53ee7 | 2020-07-22 21:16:18 -0700 | [diff] [blame] | 115 | auto const nextReadyTime = nextVsyncTime - timing.readyDuration; |
| 116 | mScheduleTiming = timing; |
| 117 | mArmedInfo = {nextWakeupTime, nextVsyncTime, nextReadyTime}; |
Ady Abraham | b0d3d98 | 2023-10-30 11:29:51 -0700 | [diff] [blame] | 118 | return nextWakeupTime; |
Kevin DuBois | 305bef1 | 2019-10-09 13:23:27 -0700 | [diff] [blame] | 119 | } |
| 120 | |
Ady Abraham | da8af4c | 2024-02-14 00:24:34 +0000 | [diff] [blame^] | 121 | nsecs_t VSyncDispatchTimerQueueEntry::addPendingWorkloadUpdate( |
| 122 | VSyncTracker& tracker, nsecs_t now, VSyncDispatch::ScheduleTiming timing) { |
Ady Abraham | 9c53ee7 | 2020-07-22 21:16:18 -0700 | [diff] [blame] | 123 | mWorkloadUpdateInfo = timing; |
Ady Abraham | da8af4c | 2024-02-14 00:24:34 +0000 | [diff] [blame^] | 124 | const auto armedInfo = update(tracker, now, timing, mArmedInfo); |
| 125 | return armedInfo.mActualWakeupTime; |
Kevin DuBois | 5c18c1c | 2020-05-27 15:50:50 -0700 | [diff] [blame] | 126 | } |
| 127 | |
| 128 | bool VSyncDispatchTimerQueueEntry::hasPendingWorkloadUpdate() const { |
| 129 | return mWorkloadUpdateInfo.has_value(); |
| 130 | } |
| 131 | |
Ady Abraham | 3fcfd8b | 2022-07-12 12:31:00 -0700 | [diff] [blame] | 132 | nsecs_t VSyncDispatchTimerQueueEntry::adjustVsyncIfNeeded(VSyncTracker& tracker, |
| 133 | nsecs_t nextVsyncTime) const { |
| 134 | bool const alreadyDispatchedForVsync = mLastDispatchTime && |
| 135 | ((*mLastDispatchTime + mMinVsyncDistance) >= nextVsyncTime && |
| 136 | (*mLastDispatchTime - mMinVsyncDistance) <= nextVsyncTime); |
| 137 | const nsecs_t currentPeriod = tracker.currentPeriod(); |
| 138 | bool const nextVsyncTooClose = mLastDispatchTime && |
| 139 | (nextVsyncTime - *mLastDispatchTime + mMinVsyncDistance) <= currentPeriod; |
| 140 | if (alreadyDispatchedForVsync) { |
Ady Abraham | 4335afd | 2023-12-18 19:10:47 -0800 | [diff] [blame] | 141 | return tracker.nextAnticipatedVSyncTimeFrom(*mLastDispatchTime + mMinVsyncDistance, |
| 142 | *mLastDispatchTime); |
Ady Abraham | 3fcfd8b | 2022-07-12 12:31:00 -0700 | [diff] [blame] | 143 | } |
| 144 | |
| 145 | if (nextVsyncTooClose) { |
Ady Abraham | 4335afd | 2023-12-18 19:10:47 -0800 | [diff] [blame] | 146 | return tracker.nextAnticipatedVSyncTimeFrom(*mLastDispatchTime + currentPeriod, |
| 147 | *mLastDispatchTime + currentPeriod); |
Ady Abraham | 3fcfd8b | 2022-07-12 12:31:00 -0700 | [diff] [blame] | 148 | } |
| 149 | |
| 150 | return nextVsyncTime; |
| 151 | } |
| 152 | |
Ady Abraham | da8af4c | 2024-02-14 00:24:34 +0000 | [diff] [blame^] | 153 | auto VSyncDispatchTimerQueueEntry::update(VSyncTracker& tracker, nsecs_t now, |
| 154 | VSyncDispatch::ScheduleTiming timing, |
| 155 | std::optional<ArmingInfo> armedInfo) const -> ArmingInfo { |
| 156 | const auto earliestReadyBy = now + timing.workDuration + timing.readyDuration; |
| 157 | const auto earliestVsync = std::max(earliestReadyBy, timing.lastVsync); |
| 158 | |
| 159 | const auto nextVsyncTime = |
| 160 | adjustVsyncIfNeeded(tracker, /*nextVsyncTime*/ |
| 161 | tracker.nextAnticipatedVSyncTimeFrom(earliestVsync, |
| 162 | timing.lastVsync)); |
| 163 | const auto nextReadyTime = nextVsyncTime - timing.readyDuration; |
| 164 | const auto nextWakeupTime = nextReadyTime - timing.workDuration; |
| 165 | |
| 166 | bool const wouldSkipAVsyncTarget = |
| 167 | armedInfo && (nextVsyncTime > (armedInfo->mActualVsyncTime + mMinVsyncDistance)); |
| 168 | bool const wouldSkipAWakeup = |
| 169 | armedInfo && (nextWakeupTime > (armedInfo->mActualWakeupTime + mMinVsyncDistance)); |
| 170 | if (FlagManager::getInstance().dont_skip_on_early_ro() && |
| 171 | (wouldSkipAVsyncTarget || wouldSkipAWakeup)) { |
| 172 | return *armedInfo; |
| 173 | } |
| 174 | |
| 175 | return ArmingInfo{nextWakeupTime, nextVsyncTime, nextReadyTime}; |
| 176 | } |
| 177 | |
Kevin DuBois | e4f27a8 | 2019-11-12 11:41:41 -0800 | [diff] [blame] | 178 | void VSyncDispatchTimerQueueEntry::update(VSyncTracker& tracker, nsecs_t now) { |
Kevin DuBois | 5c18c1c | 2020-05-27 15:50:50 -0700 | [diff] [blame] | 179 | if (!mArmedInfo && !mWorkloadUpdateInfo) { |
Kevin DuBois | 305bef1 | 2019-10-09 13:23:27 -0700 | [diff] [blame] | 180 | return; |
| 181 | } |
Kevin DuBois | 5c18c1c | 2020-05-27 15:50:50 -0700 | [diff] [blame] | 182 | |
| 183 | if (mWorkloadUpdateInfo) { |
Ady Abraham | 9c53ee7 | 2020-07-22 21:16:18 -0700 | [diff] [blame] | 184 | mScheduleTiming = *mWorkloadUpdateInfo; |
Kevin DuBois | 5c18c1c | 2020-05-27 15:50:50 -0700 | [diff] [blame] | 185 | mWorkloadUpdateInfo.reset(); |
| 186 | } |
| 187 | |
Ady Abraham | da8af4c | 2024-02-14 00:24:34 +0000 | [diff] [blame^] | 188 | mArmedInfo = update(tracker, now, mScheduleTiming, mArmedInfo); |
Kevin DuBois | 305bef1 | 2019-10-09 13:23:27 -0700 | [diff] [blame] | 189 | } |
| 190 | |
Kevin DuBois | e4f27a8 | 2019-11-12 11:41:41 -0800 | [diff] [blame] | 191 | void VSyncDispatchTimerQueueEntry::disarm() { |
Kevin DuBois | 305bef1 | 2019-10-09 13:23:27 -0700 | [diff] [blame] | 192 | mArmedInfo.reset(); |
| 193 | } |
| 194 | |
Kevin DuBois | e4f27a8 | 2019-11-12 11:41:41 -0800 | [diff] [blame] | 195 | nsecs_t VSyncDispatchTimerQueueEntry::executing() { |
Kevin DuBois | 305bef1 | 2019-10-09 13:23:27 -0700 | [diff] [blame] | 196 | mLastDispatchTime = mArmedInfo->mActualVsyncTime; |
| 197 | disarm(); |
| 198 | return *mLastDispatchTime; |
| 199 | } |
| 200 | |
Ady Abraham | 9c53ee7 | 2020-07-22 21:16:18 -0700 | [diff] [blame] | 201 | void VSyncDispatchTimerQueueEntry::callback(nsecs_t vsyncTimestamp, nsecs_t wakeupTimestamp, |
| 202 | nsecs_t deadlineTimestamp) { |
Kevin DuBois | 305bef1 | 2019-10-09 13:23:27 -0700 | [diff] [blame] | 203 | { |
| 204 | std::lock_guard<std::mutex> lk(mRunningMutex); |
| 205 | mRunning = true; |
| 206 | } |
| 207 | |
Ady Abraham | 9c53ee7 | 2020-07-22 21:16:18 -0700 | [diff] [blame] | 208 | mCallback(vsyncTimestamp, wakeupTimestamp, deadlineTimestamp); |
Kevin DuBois | 305bef1 | 2019-10-09 13:23:27 -0700 | [diff] [blame] | 209 | |
| 210 | std::lock_guard<std::mutex> lk(mRunningMutex); |
| 211 | mRunning = false; |
| 212 | mCv.notify_all(); |
| 213 | } |
| 214 | |
Kevin DuBois | e4f27a8 | 2019-11-12 11:41:41 -0800 | [diff] [blame] | 215 | void VSyncDispatchTimerQueueEntry::ensureNotRunning() { |
Kevin DuBois | 305bef1 | 2019-10-09 13:23:27 -0700 | [diff] [blame] | 216 | std::unique_lock<std::mutex> lk(mRunningMutex); |
| 217 | mCv.wait(lk, [this]() REQUIRES(mRunningMutex) { return !mRunning; }); |
| 218 | } |
| 219 | |
Ady Abraham | 5e7371c | 2020-03-24 14:47:24 -0700 | [diff] [blame] | 220 | void VSyncDispatchTimerQueueEntry::dump(std::string& result) const { |
| 221 | std::lock_guard<std::mutex> lk(mRunningMutex); |
| 222 | std::string armedInfo; |
| 223 | if (mArmedInfo) { |
Ady Abraham | 9c53ee7 | 2020-07-22 21:16:18 -0700 | [diff] [blame] | 224 | StringAppendF(&armedInfo, |
| 225 | "[wake up in %.2fms deadline in %.2fms for vsync %.2fms from now]", |
Ady Abraham | 5e7371c | 2020-03-24 14:47:24 -0700 | [diff] [blame] | 226 | (mArmedInfo->mActualWakeupTime - systemTime()) / 1e6f, |
Ady Abraham | 9c53ee7 | 2020-07-22 21:16:18 -0700 | [diff] [blame] | 227 | (mArmedInfo->mActualReadyTime - systemTime()) / 1e6f, |
Ady Abraham | 5e7371c | 2020-03-24 14:47:24 -0700 | [diff] [blame] | 228 | (mArmedInfo->mActualVsyncTime - systemTime()) / 1e6f); |
| 229 | } |
| 230 | |
| 231 | StringAppendF(&result, "\t\t%s: %s %s\n", mName.c_str(), |
| 232 | mRunning ? "(in callback function)" : "", armedInfo.c_str()); |
Ady Abraham | 9c53ee7 | 2020-07-22 21:16:18 -0700 | [diff] [blame] | 233 | StringAppendF(&result, |
Ady Abraham | 4335afd | 2023-12-18 19:10:47 -0800 | [diff] [blame] | 234 | "\t\t\tworkDuration: %.2fms readyDuration: %.2fms lastVsync: %.2fms relative " |
Ady Abraham | 9c53ee7 | 2020-07-22 21:16:18 -0700 | [diff] [blame] | 235 | "to now\n", |
| 236 | mScheduleTiming.workDuration / 1e6f, mScheduleTiming.readyDuration / 1e6f, |
Ady Abraham | 4335afd | 2023-12-18 19:10:47 -0800 | [diff] [blame] | 237 | (mScheduleTiming.lastVsync - systemTime()) / 1e6f); |
Ady Abraham | 5e7371c | 2020-03-24 14:47:24 -0700 | [diff] [blame] | 238 | |
| 239 | if (mLastDispatchTime) { |
| 240 | StringAppendF(&result, "\t\t\tmLastDispatchTime: %.2fms ago\n", |
| 241 | (systemTime() - *mLastDispatchTime) / 1e6f); |
| 242 | } else { |
| 243 | StringAppendF(&result, "\t\t\tmLastDispatchTime unknown\n"); |
| 244 | } |
| 245 | } |
| 246 | |
Kevin DuBois | e4f27a8 | 2019-11-12 11:41:41 -0800 | [diff] [blame] | 247 | VSyncDispatchTimerQueue::VSyncDispatchTimerQueue(std::unique_ptr<TimeKeeper> tk, |
Leon Scroggins III | 6738862 | 2023-02-06 20:36:20 -0500 | [diff] [blame] | 248 | VsyncSchedule::TrackerPtr tracker, |
| 249 | nsecs_t timerSlack, nsecs_t minVsyncDistance) |
Kevin DuBois | c94ca83 | 2019-11-26 12:56:24 -0800 | [diff] [blame] | 250 | : mTimeKeeper(std::move(tk)), |
Leon Scroggins III | 6738862 | 2023-02-06 20:36:20 -0500 | [diff] [blame] | 251 | mTracker(std::move(tracker)), |
Kevin DuBois | c94ca83 | 2019-11-26 12:56:24 -0800 | [diff] [blame] | 252 | mTimerSlack(timerSlack), |
| 253 | mMinVsyncDistance(minVsyncDistance) {} |
Kevin DuBois | 305bef1 | 2019-10-09 13:23:27 -0700 | [diff] [blame] | 254 | |
Kevin DuBois | e4f27a8 | 2019-11-12 11:41:41 -0800 | [diff] [blame] | 255 | VSyncDispatchTimerQueue::~VSyncDispatchTimerQueue() { |
Ady Abraham | 8cb2188 | 2020-08-26 18:22:05 -0700 | [diff] [blame] | 256 | std::lock_guard lock(mMutex); |
en.liu | 07e0e29 | 2023-07-05 19:01:52 +0800 | [diff] [blame] | 257 | mRunning = false; |
Kevin DuBois | 305bef1 | 2019-10-09 13:23:27 -0700 | [diff] [blame] | 258 | cancelTimer(); |
Leon Scroggins III | 0773813 | 2023-04-24 11:43:53 -0400 | [diff] [blame] | 259 | for (auto& [_, entry] : mCallbacks) { |
| 260 | ALOGE("Forgot to unregister a callback on VSyncDispatch!"); |
| 261 | entry->ensureNotRunning(); |
| 262 | } |
Kevin DuBois | 305bef1 | 2019-10-09 13:23:27 -0700 | [diff] [blame] | 263 | } |
| 264 | |
Kevin DuBois | e4f27a8 | 2019-11-12 11:41:41 -0800 | [diff] [blame] | 265 | void VSyncDispatchTimerQueue::cancelTimer() { |
Kevin DuBois | 305bef1 | 2019-10-09 13:23:27 -0700 | [diff] [blame] | 266 | mIntendedWakeupTime = kInvalidTime; |
| 267 | mTimeKeeper->alarmCancel(); |
| 268 | } |
| 269 | |
Ady Abraham | b491c90 | 2020-08-15 15:47:56 -0700 | [diff] [blame] | 270 | void VSyncDispatchTimerQueue::setTimer(nsecs_t targetTime, nsecs_t /*now*/) { |
Kevin DuBois | 305bef1 | 2019-10-09 13:23:27 -0700 | [diff] [blame] | 271 | mIntendedWakeupTime = targetTime; |
Ady Abraham | b491c90 | 2020-08-15 15:47:56 -0700 | [diff] [blame] | 272 | mTimeKeeper->alarmAt(std::bind(&VSyncDispatchTimerQueue::timerCallback, this), |
| 273 | mIntendedWakeupTime); |
Ady Abraham | 7539872 | 2020-04-07 14:08:45 -0700 | [diff] [blame] | 274 | mLastTimerSchedule = mTimeKeeper->now(); |
Kevin DuBois | 305bef1 | 2019-10-09 13:23:27 -0700 | [diff] [blame] | 275 | } |
| 276 | |
Kevin DuBois | e4f27a8 | 2019-11-12 11:41:41 -0800 | [diff] [blame] | 277 | void VSyncDispatchTimerQueue::rearmTimer(nsecs_t now) { |
Dominik Laskowski | 0f3e5b9 | 2023-11-17 18:03:41 -0500 | [diff] [blame] | 278 | rearmTimerSkippingUpdateFor(now, mCallbacks.cend()); |
Kevin DuBois | 305bef1 | 2019-10-09 13:23:27 -0700 | [diff] [blame] | 279 | } |
| 280 | |
Kevin DuBois | e4f27a8 | 2019-11-12 11:41:41 -0800 | [diff] [blame] | 281 | void VSyncDispatchTimerQueue::rearmTimerSkippingUpdateFor( |
Dominik Laskowski | 0f3e5b9 | 2023-11-17 18:03:41 -0500 | [diff] [blame] | 282 | nsecs_t now, CallbackMap::const_iterator skipUpdateIt) { |
Kevin DuBois | 305bef1 | 2019-10-09 13:23:27 -0700 | [diff] [blame] | 283 | std::optional<nsecs_t> min; |
Kevin DuBois | ecb1f0d | 2019-12-12 10:47:41 -0800 | [diff] [blame] | 284 | std::optional<nsecs_t> targetVsync; |
| 285 | std::optional<std::string_view> nextWakeupName; |
Dominik Laskowski | 0f3e5b9 | 2023-11-17 18:03:41 -0500 | [diff] [blame] | 286 | for (auto it = mCallbacks.cbegin(); it != mCallbacks.cend(); ++it) { |
Kevin DuBois | 305bef1 | 2019-10-09 13:23:27 -0700 | [diff] [blame] | 287 | auto& callback = it->second; |
Kevin DuBois | 5c18c1c | 2020-05-27 15:50:50 -0700 | [diff] [blame] | 288 | if (!callback->wakeupTime() && !callback->hasPendingWorkloadUpdate()) { |
Kevin DuBois | 305bef1 | 2019-10-09 13:23:27 -0700 | [diff] [blame] | 289 | continue; |
| 290 | } |
| 291 | |
| 292 | if (it != skipUpdateIt) { |
Leon Scroggins III | 6738862 | 2023-02-06 20:36:20 -0500 | [diff] [blame] | 293 | callback->update(*mTracker, now); |
Kevin DuBois | 305bef1 | 2019-10-09 13:23:27 -0700 | [diff] [blame] | 294 | } |
| 295 | auto const wakeupTime = *callback->wakeupTime(); |
Dominik Laskowski | 62eff35 | 2021-12-06 09:59:41 -0800 | [diff] [blame] | 296 | if (!min || *min > wakeupTime) { |
Kevin DuBois | ecb1f0d | 2019-12-12 10:47:41 -0800 | [diff] [blame] | 297 | nextWakeupName = callback->name(); |
Kevin DuBois | 305bef1 | 2019-10-09 13:23:27 -0700 | [diff] [blame] | 298 | min = wakeupTime; |
Kevin DuBois | ecb1f0d | 2019-12-12 10:47:41 -0800 | [diff] [blame] | 299 | targetVsync = callback->targetVsync(); |
Kevin DuBois | 305bef1 | 2019-10-09 13:23:27 -0700 | [diff] [blame] | 300 | } |
| 301 | } |
| 302 | |
Dominik Laskowski | 62eff35 | 2021-12-06 09:59:41 -0800 | [diff] [blame] | 303 | if (min && min < mIntendedWakeupTime) { |
| 304 | if (ATRACE_ENABLED() && nextWakeupName && targetVsync) { |
| 305 | ftl::Concat trace(ftl::truncated<5>(*nextWakeupName), " alarm in ", ns2us(*min - now), |
| 306 | "us; VSYNC in ", ns2us(*targetVsync - now), "us"); |
| 307 | ATRACE_NAME(trace.c_str()); |
Kevin DuBois | ecb1f0d | 2019-12-12 10:47:41 -0800 | [diff] [blame] | 308 | } |
Kevin DuBois | 305bef1 | 2019-10-09 13:23:27 -0700 | [diff] [blame] | 309 | setTimer(*min, now); |
| 310 | } else { |
Kevin DuBois | ecb1f0d | 2019-12-12 10:47:41 -0800 | [diff] [blame] | 311 | ATRACE_NAME("cancel timer"); |
Kevin DuBois | 305bef1 | 2019-10-09 13:23:27 -0700 | [diff] [blame] | 312 | cancelTimer(); |
| 313 | } |
| 314 | } |
| 315 | |
Kevin DuBois | e4f27a8 | 2019-11-12 11:41:41 -0800 | [diff] [blame] | 316 | void VSyncDispatchTimerQueue::timerCallback() { |
Kevin DuBois | 305bef1 | 2019-10-09 13:23:27 -0700 | [diff] [blame] | 317 | struct Invocation { |
Kevin DuBois | e4f27a8 | 2019-11-12 11:41:41 -0800 | [diff] [blame] | 318 | std::shared_ptr<VSyncDispatchTimerQueueEntry> callback; |
Kevin DuBois | 2968afc | 2020-01-14 09:48:50 -0800 | [diff] [blame] | 319 | nsecs_t vsyncTimestamp; |
| 320 | nsecs_t wakeupTimestamp; |
Ady Abraham | 9c53ee7 | 2020-07-22 21:16:18 -0700 | [diff] [blame] | 321 | nsecs_t deadlineTimestamp; |
Kevin DuBois | 305bef1 | 2019-10-09 13:23:27 -0700 | [diff] [blame] | 322 | }; |
| 323 | std::vector<Invocation> invocations; |
| 324 | { |
Ady Abraham | 8cb2188 | 2020-08-26 18:22:05 -0700 | [diff] [blame] | 325 | std::lock_guard lock(mMutex); |
en.liu | 07e0e29 | 2023-07-05 19:01:52 +0800 | [diff] [blame] | 326 | if (!mRunning) { |
| 327 | ALOGD("TimerQueue is not running. Skipping callback."); |
| 328 | return; |
| 329 | } |
Kevin DuBois | f947783 | 2020-07-16 10:21:36 -0700 | [diff] [blame] | 330 | auto const now = mTimeKeeper->now(); |
| 331 | mLastTimerCallback = now; |
Kevin DuBois | 305bef1 | 2019-10-09 13:23:27 -0700 | [diff] [blame] | 332 | for (auto it = mCallbacks.begin(); it != mCallbacks.end(); it++) { |
| 333 | auto& callback = it->second; |
| 334 | auto const wakeupTime = callback->wakeupTime(); |
| 335 | if (!wakeupTime) { |
| 336 | continue; |
| 337 | } |
| 338 | |
Ady Abraham | 9c53ee7 | 2020-07-22 21:16:18 -0700 | [diff] [blame] | 339 | auto const readyTime = callback->readyTime(); |
| 340 | |
Kevin DuBois | f947783 | 2020-07-16 10:21:36 -0700 | [diff] [blame] | 341 | auto const lagAllowance = std::max(now - mIntendedWakeupTime, static_cast<nsecs_t>(0)); |
| 342 | if (*wakeupTime < mIntendedWakeupTime + mTimerSlack + lagAllowance) { |
Kevin DuBois | 305bef1 | 2019-10-09 13:23:27 -0700 | [diff] [blame] | 343 | callback->executing(); |
Ady Abraham | 9c53ee7 | 2020-07-22 21:16:18 -0700 | [diff] [blame] | 344 | invocations.emplace_back(Invocation{callback, *callback->lastExecutedVsyncTarget(), |
| 345 | *wakeupTime, *readyTime}); |
Kevin DuBois | 305bef1 | 2019-10-09 13:23:27 -0700 | [diff] [blame] | 346 | } |
| 347 | } |
| 348 | |
| 349 | mIntendedWakeupTime = kInvalidTime; |
| 350 | rearmTimer(mTimeKeeper->now()); |
| 351 | } |
| 352 | |
| 353 | for (auto const& invocation : invocations) { |
Ady Abraham | 9c53ee7 | 2020-07-22 21:16:18 -0700 | [diff] [blame] | 354 | invocation.callback->callback(invocation.vsyncTimestamp, invocation.wakeupTimestamp, |
| 355 | invocation.deadlineTimestamp); |
Kevin DuBois | 305bef1 | 2019-10-09 13:23:27 -0700 | [diff] [blame] | 356 | } |
| 357 | } |
| 358 | |
Kevin DuBois | e4f27a8 | 2019-11-12 11:41:41 -0800 | [diff] [blame] | 359 | VSyncDispatchTimerQueue::CallbackToken VSyncDispatchTimerQueue::registerCallback( |
Dominik Laskowski | 4e0d20d | 2021-12-06 11:31:02 -0800 | [diff] [blame] | 360 | Callback callback, std::string callbackName) { |
Ady Abraham | 8cb2188 | 2020-08-26 18:22:05 -0700 | [diff] [blame] | 361 | std::lock_guard lock(mMutex); |
Dominik Laskowski | 0f3e5b9 | 2023-11-17 18:03:41 -0500 | [diff] [blame] | 362 | return mCallbacks |
Dominik Laskowski | 43baf90 | 2023-11-17 18:13:11 -0500 | [diff] [blame] | 363 | .try_emplace(++mCallbackToken, |
Dominik Laskowski | 0f3e5b9 | 2023-11-17 18:03:41 -0500 | [diff] [blame] | 364 | std::make_shared<VSyncDispatchTimerQueueEntry>(std::move(callbackName), |
| 365 | std::move(callback), |
| 366 | mMinVsyncDistance)) |
| 367 | .first->first; |
Kevin DuBois | 305bef1 | 2019-10-09 13:23:27 -0700 | [diff] [blame] | 368 | } |
| 369 | |
Kevin DuBois | e4f27a8 | 2019-11-12 11:41:41 -0800 | [diff] [blame] | 370 | void VSyncDispatchTimerQueue::unregisterCallback(CallbackToken token) { |
| 371 | std::shared_ptr<VSyncDispatchTimerQueueEntry> entry = nullptr; |
Kevin DuBois | 305bef1 | 2019-10-09 13:23:27 -0700 | [diff] [blame] | 372 | { |
Ady Abraham | 8cb2188 | 2020-08-26 18:22:05 -0700 | [diff] [blame] | 373 | std::lock_guard lock(mMutex); |
Kevin DuBois | 305bef1 | 2019-10-09 13:23:27 -0700 | [diff] [blame] | 374 | auto it = mCallbacks.find(token); |
| 375 | if (it != mCallbacks.end()) { |
| 376 | entry = it->second; |
Dominik Laskowski | 0f3e5b9 | 2023-11-17 18:03:41 -0500 | [diff] [blame] | 377 | mCallbacks.erase(it->first); |
Kevin DuBois | 305bef1 | 2019-10-09 13:23:27 -0700 | [diff] [blame] | 378 | } |
| 379 | } |
| 380 | |
| 381 | if (entry) { |
| 382 | entry->ensureNotRunning(); |
| 383 | } |
| 384 | } |
| 385 | |
Ady Abraham | 9c53ee7 | 2020-07-22 21:16:18 -0700 | [diff] [blame] | 386 | ScheduleResult VSyncDispatchTimerQueue::schedule(CallbackToken token, |
| 387 | ScheduleTiming scheduleTiming) { |
Ady Abraham | 011f8ba | 2022-11-22 15:09:07 -0800 | [diff] [blame] | 388 | std::lock_guard lock(mMutex); |
| 389 | return scheduleLocked(token, scheduleTiming); |
| 390 | } |
Kevin DuBois | 305bef1 | 2019-10-09 13:23:27 -0700 | [diff] [blame] | 391 | |
Ady Abraham | 011f8ba | 2022-11-22 15:09:07 -0800 | [diff] [blame] | 392 | ScheduleResult VSyncDispatchTimerQueue::scheduleLocked(CallbackToken token, |
| 393 | ScheduleTiming scheduleTiming) { |
| 394 | auto it = mCallbacks.find(token); |
| 395 | if (it == mCallbacks.end()) { |
| 396 | return {}; |
| 397 | } |
| 398 | auto& callback = it->second; |
| 399 | auto const now = mTimeKeeper->now(); |
Kevin DuBois | 5c18c1c | 2020-05-27 15:50:50 -0700 | [diff] [blame] | 400 | |
Ady Abraham | 011f8ba | 2022-11-22 15:09:07 -0800 | [diff] [blame] | 401 | /* If the timer thread will run soon, we'll apply this work update via the callback |
| 402 | * timer recalculation to avoid cancelling a callback that is about to fire. */ |
| 403 | auto const rearmImminent = now > mIntendedWakeupTime; |
| 404 | if (CC_UNLIKELY(rearmImminent)) { |
Ady Abraham | da8af4c | 2024-02-14 00:24:34 +0000 | [diff] [blame^] | 405 | return callback->addPendingWorkloadUpdate(*mTracker, now, scheduleTiming); |
Ady Abraham | 011f8ba | 2022-11-22 15:09:07 -0800 | [diff] [blame] | 406 | } |
Kevin DuBois | 5c18c1c | 2020-05-27 15:50:50 -0700 | [diff] [blame] | 407 | |
Leon Scroggins III | 6738862 | 2023-02-06 20:36:20 -0500 | [diff] [blame] | 408 | const ScheduleResult result = callback->schedule(scheduleTiming, *mTracker, now); |
Ady Abraham | 011f8ba | 2022-11-22 15:09:07 -0800 | [diff] [blame] | 409 | if (!result.has_value()) { |
| 410 | return {}; |
| 411 | } |
Kevin DuBois | 305bef1 | 2019-10-09 13:23:27 -0700 | [diff] [blame] | 412 | |
Ady Abraham | 011f8ba | 2022-11-22 15:09:07 -0800 | [diff] [blame] | 413 | if (callback->wakeupTime() < mIntendedWakeupTime - mTimerSlack) { |
| 414 | rearmTimerSkippingUpdateFor(now, it); |
Kevin DuBois | 305bef1 | 2019-10-09 13:23:27 -0700 | [diff] [blame] | 415 | } |
| 416 | |
| 417 | return result; |
| 418 | } |
| 419 | |
Ady Abraham | 011f8ba | 2022-11-22 15:09:07 -0800 | [diff] [blame] | 420 | ScheduleResult VSyncDispatchTimerQueue::update(CallbackToken token, ScheduleTiming scheduleTiming) { |
| 421 | std::lock_guard lock(mMutex); |
| 422 | const auto it = mCallbacks.find(token); |
| 423 | if (it == mCallbacks.end()) { |
| 424 | return {}; |
| 425 | } |
| 426 | |
| 427 | auto& callback = it->second; |
| 428 | if (!callback->targetVsync().has_value()) { |
| 429 | return {}; |
| 430 | } |
| 431 | |
| 432 | return scheduleLocked(token, scheduleTiming); |
| 433 | } |
| 434 | |
Kevin DuBois | e4f27a8 | 2019-11-12 11:41:41 -0800 | [diff] [blame] | 435 | CancelResult VSyncDispatchTimerQueue::cancel(CallbackToken token) { |
Ady Abraham | 8cb2188 | 2020-08-26 18:22:05 -0700 | [diff] [blame] | 436 | std::lock_guard lock(mMutex); |
Kevin DuBois | 305bef1 | 2019-10-09 13:23:27 -0700 | [diff] [blame] | 437 | |
| 438 | auto it = mCallbacks.find(token); |
| 439 | if (it == mCallbacks.end()) { |
| 440 | return CancelResult::Error; |
| 441 | } |
| 442 | auto& callback = it->second; |
| 443 | |
Kevin DuBois | b340b73 | 2020-06-16 09:07:35 -0700 | [diff] [blame] | 444 | auto const wakeupTime = callback->wakeupTime(); |
| 445 | if (wakeupTime) { |
Kevin DuBois | 305bef1 | 2019-10-09 13:23:27 -0700 | [diff] [blame] | 446 | callback->disarm(); |
Kevin DuBois | b340b73 | 2020-06-16 09:07:35 -0700 | [diff] [blame] | 447 | |
| 448 | if (*wakeupTime == mIntendedWakeupTime) { |
| 449 | mIntendedWakeupTime = kInvalidTime; |
| 450 | rearmTimer(mTimeKeeper->now()); |
| 451 | } |
Kevin DuBois | 305bef1 | 2019-10-09 13:23:27 -0700 | [diff] [blame] | 452 | return CancelResult::Cancelled; |
| 453 | } |
| 454 | return CancelResult::TooLate; |
| 455 | } |
| 456 | |
Ady Abraham | 5e7371c | 2020-03-24 14:47:24 -0700 | [diff] [blame] | 457 | void VSyncDispatchTimerQueue::dump(std::string& result) const { |
Ady Abraham | 8cb2188 | 2020-08-26 18:22:05 -0700 | [diff] [blame] | 458 | std::lock_guard lock(mMutex); |
Ady Abraham | 7539872 | 2020-04-07 14:08:45 -0700 | [diff] [blame] | 459 | StringAppendF(&result, "\tTimer:\n"); |
| 460 | mTimeKeeper->dump(result); |
Ady Abraham | 5e7371c | 2020-03-24 14:47:24 -0700 | [diff] [blame] | 461 | StringAppendF(&result, "\tmTimerSlack: %.2fms mMinVsyncDistance: %.2fms\n", mTimerSlack / 1e6f, |
| 462 | mMinVsyncDistance / 1e6f); |
| 463 | StringAppendF(&result, "\tmIntendedWakeupTime: %.2fms from now\n", |
Ady Abraham | 7539872 | 2020-04-07 14:08:45 -0700 | [diff] [blame] | 464 | (mIntendedWakeupTime - mTimeKeeper->now()) / 1e6f); |
| 465 | StringAppendF(&result, "\tmLastTimerCallback: %.2fms ago mLastTimerSchedule: %.2fms ago\n", |
| 466 | (mTimeKeeper->now() - mLastTimerCallback) / 1e6f, |
| 467 | (mTimeKeeper->now() - mLastTimerSchedule) / 1e6f); |
Ady Abraham | 5e7371c | 2020-03-24 14:47:24 -0700 | [diff] [blame] | 468 | StringAppendF(&result, "\tCallbacks:\n"); |
| 469 | for (const auto& [token, entry] : mCallbacks) { |
| 470 | entry->dump(result); |
| 471 | } |
| 472 | } |
| 473 | |
Leon Scroggins III | 6738862 | 2023-02-06 20:36:20 -0500 | [diff] [blame] | 474 | VSyncCallbackRegistration::VSyncCallbackRegistration(std::shared_ptr<VSyncDispatch> dispatch, |
Dominik Laskowski | 4e0d20d | 2021-12-06 11:31:02 -0800 | [diff] [blame] | 475 | VSyncDispatch::Callback callback, |
| 476 | std::string callbackName) |
Leon Scroggins III | 6738862 | 2023-02-06 20:36:20 -0500 | [diff] [blame] | 477 | : mDispatch(std::move(dispatch)), |
Leon Scroggins III | 6c440ae | 2023-04-21 15:01:03 -0400 | [diff] [blame] | 478 | mToken(mDispatch->registerCallback(std::move(callback), std::move(callbackName))) {} |
Kevin DuBois | 305bef1 | 2019-10-09 13:23:27 -0700 | [diff] [blame] | 479 | |
| 480 | VSyncCallbackRegistration::VSyncCallbackRegistration(VSyncCallbackRegistration&& other) |
Leon Scroggins III | 6c440ae | 2023-04-21 15:01:03 -0400 | [diff] [blame] | 481 | : mDispatch(std::move(other.mDispatch)), mToken(std::exchange(other.mToken, std::nullopt)) {} |
Kevin DuBois | 305bef1 | 2019-10-09 13:23:27 -0700 | [diff] [blame] | 482 | |
| 483 | VSyncCallbackRegistration& VSyncCallbackRegistration::operator=(VSyncCallbackRegistration&& other) { |
Leon Scroggins III | 6c440ae | 2023-04-21 15:01:03 -0400 | [diff] [blame] | 484 | if (this == &other) return *this; |
| 485 | if (mToken) { |
| 486 | mDispatch->unregisterCallback(*mToken); |
| 487 | } |
Kevin DuBois | 305bef1 | 2019-10-09 13:23:27 -0700 | [diff] [blame] | 488 | mDispatch = std::move(other.mDispatch); |
Leon Scroggins III | 6c440ae | 2023-04-21 15:01:03 -0400 | [diff] [blame] | 489 | mToken = std::exchange(other.mToken, std::nullopt); |
Kevin DuBois | 305bef1 | 2019-10-09 13:23:27 -0700 | [diff] [blame] | 490 | return *this; |
| 491 | } |
| 492 | |
| 493 | VSyncCallbackRegistration::~VSyncCallbackRegistration() { |
Leon Scroggins III | 6c440ae | 2023-04-21 15:01:03 -0400 | [diff] [blame] | 494 | if (mToken) mDispatch->unregisterCallback(*mToken); |
Kevin DuBois | 305bef1 | 2019-10-09 13:23:27 -0700 | [diff] [blame] | 495 | } |
| 496 | |
Ady Abraham | 9c53ee7 | 2020-07-22 21:16:18 -0700 | [diff] [blame] | 497 | ScheduleResult VSyncCallbackRegistration::schedule(VSyncDispatch::ScheduleTiming scheduleTiming) { |
Leon Scroggins III | 6c440ae | 2023-04-21 15:01:03 -0400 | [diff] [blame] | 498 | if (!mToken) { |
Ady Abraham | b5d3afa | 2021-05-07 11:22:23 -0700 | [diff] [blame] | 499 | return std::nullopt; |
Kevin DuBois | c94ca83 | 2019-11-26 12:56:24 -0800 | [diff] [blame] | 500 | } |
Leon Scroggins III | 6c440ae | 2023-04-21 15:01:03 -0400 | [diff] [blame] | 501 | return mDispatch->schedule(*mToken, scheduleTiming); |
Kevin DuBois | 305bef1 | 2019-10-09 13:23:27 -0700 | [diff] [blame] | 502 | } |
| 503 | |
Ady Abraham | 011f8ba | 2022-11-22 15:09:07 -0800 | [diff] [blame] | 504 | ScheduleResult VSyncCallbackRegistration::update(VSyncDispatch::ScheduleTiming scheduleTiming) { |
Leon Scroggins III | 6c440ae | 2023-04-21 15:01:03 -0400 | [diff] [blame] | 505 | if (!mToken) { |
Ady Abraham | 011f8ba | 2022-11-22 15:09:07 -0800 | [diff] [blame] | 506 | return std::nullopt; |
| 507 | } |
Leon Scroggins III | 6c440ae | 2023-04-21 15:01:03 -0400 | [diff] [blame] | 508 | return mDispatch->update(*mToken, scheduleTiming); |
Ady Abraham | 011f8ba | 2022-11-22 15:09:07 -0800 | [diff] [blame] | 509 | } |
| 510 | |
Kevin DuBois | 305bef1 | 2019-10-09 13:23:27 -0700 | [diff] [blame] | 511 | CancelResult VSyncCallbackRegistration::cancel() { |
Leon Scroggins III | 6c440ae | 2023-04-21 15:01:03 -0400 | [diff] [blame] | 512 | if (!mToken) { |
Kevin DuBois | c94ca83 | 2019-11-26 12:56:24 -0800 | [diff] [blame] | 513 | return CancelResult::Error; |
| 514 | } |
Leon Scroggins III | 6c440ae | 2023-04-21 15:01:03 -0400 | [diff] [blame] | 515 | return mDispatch->cancel(*mToken); |
Kevin DuBois | 305bef1 | 2019-10-09 13:23:27 -0700 | [diff] [blame] | 516 | } |
| 517 | |
| 518 | } // namespace android::scheduler |