Kevin DuBois | 305bef1 | 2019-10-09 13:23:27 -0700 | [diff] [blame] | 1 | /* |
| 2 | * Copyright 2019 The Android Open Source Project |
| 3 | * |
| 4 | * Licensed under the Apache License, Version 2.0 (the "License"); |
| 5 | * you may not use this file except in compliance with the License. |
| 6 | * You may obtain a copy of the License at |
| 7 | * |
| 8 | * http://www.apache.org/licenses/LICENSE-2.0 |
| 9 | * |
| 10 | * Unless required by applicable law or agreed to in writing, software |
| 11 | * distributed under the License is distributed on an "AS IS" BASIS, |
| 12 | * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. |
| 13 | * See the License for the specific language governing permissions and |
| 14 | * limitations under the License. |
| 15 | */ |
| 16 | |
| 17 | #define ATRACE_TAG ATRACE_TAG_GRAPHICS |
Dominik Laskowski | 62eff35 | 2021-12-06 09:59:41 -0800 | [diff] [blame] | 18 | |
Kevin DuBois | 305bef1 | 2019-10-09 13:23:27 -0700 | [diff] [blame] | 19 | #include <vector> |
| 20 | |
Dominik Laskowski | 62eff35 | 2021-12-06 09:59:41 -0800 | [diff] [blame] | 21 | #include <android-base/stringprintf.h> |
| 22 | #include <ftl/concat.h> |
| 23 | #include <utils/Trace.h> |
Leon Scroggins III | 0773813 | 2023-04-24 11:43:53 -0400 | [diff] [blame] | 24 | #include <log/log_main.h> |
Dominik Laskowski | 62eff35 | 2021-12-06 09:59:41 -0800 | [diff] [blame] | 25 | |
Dominik Laskowski | 4e0d20d | 2021-12-06 11:31:02 -0800 | [diff] [blame] | 26 | #include <scheduler/TimeKeeper.h> |
| 27 | |
Alec Mouri | 9b133ca | 2023-11-14 19:00:01 +0000 | [diff] [blame] | 28 | #include <common/FlagManager.h> |
Kevin DuBois | e4f27a8 | 2019-11-12 11:41:41 -0800 | [diff] [blame] | 29 | #include "VSyncDispatchTimerQueue.h" |
Kevin DuBois | 305bef1 | 2019-10-09 13:23:27 -0700 | [diff] [blame] | 30 | #include "VSyncTracker.h" |
| 31 | |
Leon Scroggins III | 0773813 | 2023-04-24 11:43:53 -0400 | [diff] [blame] | 32 | #undef LOG_TAG |
| 33 | #define LOG_TAG "VSyncDispatch" |
| 34 | |
Kevin DuBois | 305bef1 | 2019-10-09 13:23:27 -0700 | [diff] [blame] | 35 | namespace android::scheduler { |
Dominik Laskowski | 62eff35 | 2021-12-06 09:59:41 -0800 | [diff] [blame] | 36 | |
Ady Abraham | 5e7371c | 2020-03-24 14:47:24 -0700 | [diff] [blame] | 37 | using base::StringAppendF; |
Kevin DuBois | 305bef1 | 2019-10-09 13:23:27 -0700 | [diff] [blame] | 38 | |
Ady Abraham | b5d3afa | 2021-05-07 11:22:23 -0700 | [diff] [blame] | 39 | namespace { |
Dominik Laskowski | 4e0d20d | 2021-12-06 11:31:02 -0800 | [diff] [blame] | 40 | |
Ady Abraham | b0d3d98 | 2023-10-30 11:29:51 -0700 | [diff] [blame] | 41 | nsecs_t getExpectedCallbackTime(nsecs_t nextVsyncTime, |
Ady Abraham | b5d3afa | 2021-05-07 11:22:23 -0700 | [diff] [blame] | 42 | const VSyncDispatch::ScheduleTiming& timing) { |
Ady Abraham | b0d3d98 | 2023-10-30 11:29:51 -0700 | [diff] [blame] | 43 | return nextVsyncTime - timing.readyDuration - timing.workDuration; |
Ady Abraham | b5d3afa | 2021-05-07 11:22:23 -0700 | [diff] [blame] | 44 | } |
| 45 | |
| 46 | nsecs_t getExpectedCallbackTime(VSyncTracker& tracker, nsecs_t now, |
| 47 | const VSyncDispatch::ScheduleTiming& timing) { |
Ady Abraham | 4335afd | 2023-12-18 19:10:47 -0800 | [diff] [blame^] | 48 | const auto nextVsyncTime = |
| 49 | tracker.nextAnticipatedVSyncTimeFrom(std::max(timing.lastVsync, |
| 50 | now + timing.workDuration + |
| 51 | timing.readyDuration), |
| 52 | timing.lastVsync); |
Ady Abraham | b0d3d98 | 2023-10-30 11:29:51 -0700 | [diff] [blame] | 53 | return getExpectedCallbackTime(nextVsyncTime, timing); |
Ady Abraham | b5d3afa | 2021-05-07 11:22:23 -0700 | [diff] [blame] | 54 | } |
Dominik Laskowski | 4e0d20d | 2021-12-06 11:31:02 -0800 | [diff] [blame] | 55 | |
Ady Abraham | b5d3afa | 2021-05-07 11:22:23 -0700 | [diff] [blame] | 56 | } // namespace |
| 57 | |
Kevin DuBois | e4f27a8 | 2019-11-12 11:41:41 -0800 | [diff] [blame] | 58 | VSyncDispatch::~VSyncDispatch() = default; |
Kevin DuBois | 305bef1 | 2019-10-09 13:23:27 -0700 | [diff] [blame] | 59 | VSyncTracker::~VSyncTracker() = default; |
Kevin DuBois | 305bef1 | 2019-10-09 13:23:27 -0700 | [diff] [blame] | 60 | |
Dominik Laskowski | 4e0d20d | 2021-12-06 11:31:02 -0800 | [diff] [blame] | 61 | VSyncDispatchTimerQueueEntry::VSyncDispatchTimerQueueEntry(std::string name, |
| 62 | VSyncDispatch::Callback callback, |
Kevin DuBois | c94ca83 | 2019-11-26 12:56:24 -0800 | [diff] [blame] | 63 | nsecs_t minVsyncDistance) |
Dominik Laskowski | 4e0d20d | 2021-12-06 11:31:02 -0800 | [diff] [blame] | 64 | : mName(std::move(name)), |
| 65 | mCallback(std::move(callback)), |
Kevin DuBois | c94ca83 | 2019-11-26 12:56:24 -0800 | [diff] [blame] | 66 | mMinVsyncDistance(minVsyncDistance) {} |
Kevin DuBois | 305bef1 | 2019-10-09 13:23:27 -0700 | [diff] [blame] | 67 | |
Kevin DuBois | e4f27a8 | 2019-11-12 11:41:41 -0800 | [diff] [blame] | 68 | std::optional<nsecs_t> VSyncDispatchTimerQueueEntry::lastExecutedVsyncTarget() const { |
Kevin DuBois | 305bef1 | 2019-10-09 13:23:27 -0700 | [diff] [blame] | 69 | return mLastDispatchTime; |
| 70 | } |
| 71 | |
Kevin DuBois | e4f27a8 | 2019-11-12 11:41:41 -0800 | [diff] [blame] | 72 | std::string_view VSyncDispatchTimerQueueEntry::name() const { |
Kevin DuBois | 305bef1 | 2019-10-09 13:23:27 -0700 | [diff] [blame] | 73 | return mName; |
| 74 | } |
| 75 | |
Kevin DuBois | e4f27a8 | 2019-11-12 11:41:41 -0800 | [diff] [blame] | 76 | std::optional<nsecs_t> VSyncDispatchTimerQueueEntry::wakeupTime() const { |
Kevin DuBois | 305bef1 | 2019-10-09 13:23:27 -0700 | [diff] [blame] | 77 | if (!mArmedInfo) { |
| 78 | return {}; |
| 79 | } |
| 80 | return {mArmedInfo->mActualWakeupTime}; |
| 81 | } |
| 82 | |
Ady Abraham | 9c53ee7 | 2020-07-22 21:16:18 -0700 | [diff] [blame] | 83 | std::optional<nsecs_t> VSyncDispatchTimerQueueEntry::readyTime() const { |
| 84 | if (!mArmedInfo) { |
| 85 | return {}; |
| 86 | } |
| 87 | return {mArmedInfo->mActualReadyTime}; |
| 88 | } |
| 89 | |
Kevin DuBois | ecb1f0d | 2019-12-12 10:47:41 -0800 | [diff] [blame] | 90 | std::optional<nsecs_t> VSyncDispatchTimerQueueEntry::targetVsync() const { |
| 91 | if (!mArmedInfo) { |
| 92 | return {}; |
| 93 | } |
| 94 | return {mArmedInfo->mActualVsyncTime}; |
| 95 | } |
| 96 | |
Ady Abraham | 9c53ee7 | 2020-07-22 21:16:18 -0700 | [diff] [blame] | 97 | ScheduleResult VSyncDispatchTimerQueueEntry::schedule(VSyncDispatch::ScheduleTiming timing, |
Kevin DuBois | 2311b1a | 2019-11-18 16:19:08 -0800 | [diff] [blame] | 98 | VSyncTracker& tracker, nsecs_t now) { |
Ady Abraham | 4335afd | 2023-12-18 19:10:47 -0800 | [diff] [blame^] | 99 | auto nextVsyncTime = |
| 100 | tracker.nextAnticipatedVSyncTimeFrom(std::max(timing.lastVsync, |
| 101 | now + timing.workDuration + |
| 102 | timing.readyDuration), |
| 103 | timing.lastVsync); |
Ady Abraham | 69b9e62 | 2021-07-19 12:24:31 -0700 | [diff] [blame] | 104 | auto nextWakeupTime = nextVsyncTime - timing.workDuration - timing.readyDuration; |
Kevin DuBois | c94ca83 | 2019-11-26 12:56:24 -0800 | [diff] [blame] | 105 | |
| 106 | bool const wouldSkipAVsyncTarget = |
| 107 | mArmedInfo && (nextVsyncTime > (mArmedInfo->mActualVsyncTime + mMinVsyncDistance)); |
Ady Abraham | 69b9e62 | 2021-07-19 12:24:31 -0700 | [diff] [blame] | 108 | bool const wouldSkipAWakeup = |
| 109 | mArmedInfo && ((nextWakeupTime > (mArmedInfo->mActualWakeupTime + mMinVsyncDistance))); |
Ady Abraham | d6d8016 | 2023-10-23 12:57:41 -0700 | [diff] [blame] | 110 | if (FlagManager::getInstance().dont_skip_on_early()) { |
Ady Abraham | 529bd9f | 2023-10-05 14:55:30 -0700 | [diff] [blame] | 111 | if (wouldSkipAVsyncTarget || wouldSkipAWakeup) { |
Ady Abraham | b0d3d98 | 2023-10-30 11:29:51 -0700 | [diff] [blame] | 112 | nextVsyncTime = mArmedInfo->mActualVsyncTime; |
| 113 | } else { |
| 114 | nextVsyncTime = adjustVsyncIfNeeded(tracker, nextVsyncTime); |
Ady Abraham | 529bd9f | 2023-10-05 14:55:30 -0700 | [diff] [blame] | 115 | } |
Ady Abraham | b0d3d98 | 2023-10-30 11:29:51 -0700 | [diff] [blame] | 116 | nextWakeupTime = std::max(now, nextVsyncTime - timing.workDuration - timing.readyDuration); |
Ady Abraham | 529bd9f | 2023-10-05 14:55:30 -0700 | [diff] [blame] | 117 | } else { |
| 118 | if (wouldSkipAVsyncTarget && wouldSkipAWakeup) { |
Ady Abraham | b0d3d98 | 2023-10-30 11:29:51 -0700 | [diff] [blame] | 119 | return getExpectedCallbackTime(nextVsyncTime, timing); |
Ady Abraham | 529bd9f | 2023-10-05 14:55:30 -0700 | [diff] [blame] | 120 | } |
Ady Abraham | b0d3d98 | 2023-10-30 11:29:51 -0700 | [diff] [blame] | 121 | nextVsyncTime = adjustVsyncIfNeeded(tracker, nextVsyncTime); |
| 122 | nextWakeupTime = nextVsyncTime - timing.workDuration - timing.readyDuration; |
Kevin DuBois | c94ca83 | 2019-11-26 12:56:24 -0800 | [diff] [blame] | 123 | } |
| 124 | |
Ady Abraham | 9c53ee7 | 2020-07-22 21:16:18 -0700 | [diff] [blame] | 125 | auto const nextReadyTime = nextVsyncTime - timing.readyDuration; |
| 126 | mScheduleTiming = timing; |
| 127 | mArmedInfo = {nextWakeupTime, nextVsyncTime, nextReadyTime}; |
Ady Abraham | b0d3d98 | 2023-10-30 11:29:51 -0700 | [diff] [blame] | 128 | return nextWakeupTime; |
Kevin DuBois | 305bef1 | 2019-10-09 13:23:27 -0700 | [diff] [blame] | 129 | } |
| 130 | |
Ady Abraham | 9c53ee7 | 2020-07-22 21:16:18 -0700 | [diff] [blame] | 131 | void VSyncDispatchTimerQueueEntry::addPendingWorkloadUpdate(VSyncDispatch::ScheduleTiming timing) { |
| 132 | mWorkloadUpdateInfo = timing; |
Kevin DuBois | 5c18c1c | 2020-05-27 15:50:50 -0700 | [diff] [blame] | 133 | } |
| 134 | |
| 135 | bool VSyncDispatchTimerQueueEntry::hasPendingWorkloadUpdate() const { |
| 136 | return mWorkloadUpdateInfo.has_value(); |
| 137 | } |
| 138 | |
Ady Abraham | 3fcfd8b | 2022-07-12 12:31:00 -0700 | [diff] [blame] | 139 | nsecs_t VSyncDispatchTimerQueueEntry::adjustVsyncIfNeeded(VSyncTracker& tracker, |
| 140 | nsecs_t nextVsyncTime) const { |
| 141 | bool const alreadyDispatchedForVsync = mLastDispatchTime && |
| 142 | ((*mLastDispatchTime + mMinVsyncDistance) >= nextVsyncTime && |
| 143 | (*mLastDispatchTime - mMinVsyncDistance) <= nextVsyncTime); |
| 144 | const nsecs_t currentPeriod = tracker.currentPeriod(); |
| 145 | bool const nextVsyncTooClose = mLastDispatchTime && |
| 146 | (nextVsyncTime - *mLastDispatchTime + mMinVsyncDistance) <= currentPeriod; |
| 147 | if (alreadyDispatchedForVsync) { |
Ady Abraham | 4335afd | 2023-12-18 19:10:47 -0800 | [diff] [blame^] | 148 | return tracker.nextAnticipatedVSyncTimeFrom(*mLastDispatchTime + mMinVsyncDistance, |
| 149 | *mLastDispatchTime); |
Ady Abraham | 3fcfd8b | 2022-07-12 12:31:00 -0700 | [diff] [blame] | 150 | } |
| 151 | |
| 152 | if (nextVsyncTooClose) { |
Ady Abraham | 4335afd | 2023-12-18 19:10:47 -0800 | [diff] [blame^] | 153 | return tracker.nextAnticipatedVSyncTimeFrom(*mLastDispatchTime + currentPeriod, |
| 154 | *mLastDispatchTime + currentPeriod); |
Ady Abraham | 3fcfd8b | 2022-07-12 12:31:00 -0700 | [diff] [blame] | 155 | } |
| 156 | |
| 157 | return nextVsyncTime; |
| 158 | } |
| 159 | |
Kevin DuBois | e4f27a8 | 2019-11-12 11:41:41 -0800 | [diff] [blame] | 160 | void VSyncDispatchTimerQueueEntry::update(VSyncTracker& tracker, nsecs_t now) { |
Kevin DuBois | 5c18c1c | 2020-05-27 15:50:50 -0700 | [diff] [blame] | 161 | if (!mArmedInfo && !mWorkloadUpdateInfo) { |
Kevin DuBois | 305bef1 | 2019-10-09 13:23:27 -0700 | [diff] [blame] | 162 | return; |
| 163 | } |
Kevin DuBois | 5c18c1c | 2020-05-27 15:50:50 -0700 | [diff] [blame] | 164 | |
| 165 | if (mWorkloadUpdateInfo) { |
Ady Abraham | 9c53ee7 | 2020-07-22 21:16:18 -0700 | [diff] [blame] | 166 | mScheduleTiming = *mWorkloadUpdateInfo; |
Kevin DuBois | 5c18c1c | 2020-05-27 15:50:50 -0700 | [diff] [blame] | 167 | mWorkloadUpdateInfo.reset(); |
| 168 | } |
| 169 | |
Ady Abraham | 9c53ee7 | 2020-07-22 21:16:18 -0700 | [diff] [blame] | 170 | const auto earliestReadyBy = now + mScheduleTiming.workDuration + mScheduleTiming.readyDuration; |
Ady Abraham | 4335afd | 2023-12-18 19:10:47 -0800 | [diff] [blame^] | 171 | const auto earliestVsync = std::max(earliestReadyBy, mScheduleTiming.lastVsync); |
Ady Abraham | 9c53ee7 | 2020-07-22 21:16:18 -0700 | [diff] [blame] | 172 | |
Ady Abraham | 3fcfd8b | 2022-07-12 12:31:00 -0700 | [diff] [blame] | 173 | const auto nextVsyncTime = |
| 174 | adjustVsyncIfNeeded(tracker, /*nextVsyncTime*/ |
Ady Abraham | 4335afd | 2023-12-18 19:10:47 -0800 | [diff] [blame^] | 175 | tracker.nextAnticipatedVSyncTimeFrom(earliestVsync, |
| 176 | mScheduleTiming.lastVsync)); |
Ady Abraham | 9c53ee7 | 2020-07-22 21:16:18 -0700 | [diff] [blame] | 177 | const auto nextReadyTime = nextVsyncTime - mScheduleTiming.readyDuration; |
| 178 | const auto nextWakeupTime = nextReadyTime - mScheduleTiming.workDuration; |
| 179 | |
| 180 | mArmedInfo = {nextWakeupTime, nextVsyncTime, nextReadyTime}; |
Kevin DuBois | 305bef1 | 2019-10-09 13:23:27 -0700 | [diff] [blame] | 181 | } |
| 182 | |
Kevin DuBois | e4f27a8 | 2019-11-12 11:41:41 -0800 | [diff] [blame] | 183 | void VSyncDispatchTimerQueueEntry::disarm() { |
Kevin DuBois | 305bef1 | 2019-10-09 13:23:27 -0700 | [diff] [blame] | 184 | mArmedInfo.reset(); |
| 185 | } |
| 186 | |
Kevin DuBois | e4f27a8 | 2019-11-12 11:41:41 -0800 | [diff] [blame] | 187 | nsecs_t VSyncDispatchTimerQueueEntry::executing() { |
Kevin DuBois | 305bef1 | 2019-10-09 13:23:27 -0700 | [diff] [blame] | 188 | mLastDispatchTime = mArmedInfo->mActualVsyncTime; |
| 189 | disarm(); |
| 190 | return *mLastDispatchTime; |
| 191 | } |
| 192 | |
Ady Abraham | 9c53ee7 | 2020-07-22 21:16:18 -0700 | [diff] [blame] | 193 | void VSyncDispatchTimerQueueEntry::callback(nsecs_t vsyncTimestamp, nsecs_t wakeupTimestamp, |
| 194 | nsecs_t deadlineTimestamp) { |
Kevin DuBois | 305bef1 | 2019-10-09 13:23:27 -0700 | [diff] [blame] | 195 | { |
| 196 | std::lock_guard<std::mutex> lk(mRunningMutex); |
| 197 | mRunning = true; |
| 198 | } |
| 199 | |
Ady Abraham | 9c53ee7 | 2020-07-22 21:16:18 -0700 | [diff] [blame] | 200 | mCallback(vsyncTimestamp, wakeupTimestamp, deadlineTimestamp); |
Kevin DuBois | 305bef1 | 2019-10-09 13:23:27 -0700 | [diff] [blame] | 201 | |
| 202 | std::lock_guard<std::mutex> lk(mRunningMutex); |
| 203 | mRunning = false; |
| 204 | mCv.notify_all(); |
| 205 | } |
| 206 | |
Kevin DuBois | e4f27a8 | 2019-11-12 11:41:41 -0800 | [diff] [blame] | 207 | void VSyncDispatchTimerQueueEntry::ensureNotRunning() { |
Kevin DuBois | 305bef1 | 2019-10-09 13:23:27 -0700 | [diff] [blame] | 208 | std::unique_lock<std::mutex> lk(mRunningMutex); |
| 209 | mCv.wait(lk, [this]() REQUIRES(mRunningMutex) { return !mRunning; }); |
| 210 | } |
| 211 | |
Ady Abraham | 5e7371c | 2020-03-24 14:47:24 -0700 | [diff] [blame] | 212 | void VSyncDispatchTimerQueueEntry::dump(std::string& result) const { |
| 213 | std::lock_guard<std::mutex> lk(mRunningMutex); |
| 214 | std::string armedInfo; |
| 215 | if (mArmedInfo) { |
Ady Abraham | 9c53ee7 | 2020-07-22 21:16:18 -0700 | [diff] [blame] | 216 | StringAppendF(&armedInfo, |
| 217 | "[wake up in %.2fms deadline in %.2fms for vsync %.2fms from now]", |
Ady Abraham | 5e7371c | 2020-03-24 14:47:24 -0700 | [diff] [blame] | 218 | (mArmedInfo->mActualWakeupTime - systemTime()) / 1e6f, |
Ady Abraham | 9c53ee7 | 2020-07-22 21:16:18 -0700 | [diff] [blame] | 219 | (mArmedInfo->mActualReadyTime - systemTime()) / 1e6f, |
Ady Abraham | 5e7371c | 2020-03-24 14:47:24 -0700 | [diff] [blame] | 220 | (mArmedInfo->mActualVsyncTime - systemTime()) / 1e6f); |
| 221 | } |
| 222 | |
| 223 | StringAppendF(&result, "\t\t%s: %s %s\n", mName.c_str(), |
| 224 | mRunning ? "(in callback function)" : "", armedInfo.c_str()); |
Ady Abraham | 9c53ee7 | 2020-07-22 21:16:18 -0700 | [diff] [blame] | 225 | StringAppendF(&result, |
Ady Abraham | 4335afd | 2023-12-18 19:10:47 -0800 | [diff] [blame^] | 226 | "\t\t\tworkDuration: %.2fms readyDuration: %.2fms lastVsync: %.2fms relative " |
Ady Abraham | 9c53ee7 | 2020-07-22 21:16:18 -0700 | [diff] [blame] | 227 | "to now\n", |
| 228 | mScheduleTiming.workDuration / 1e6f, mScheduleTiming.readyDuration / 1e6f, |
Ady Abraham | 4335afd | 2023-12-18 19:10:47 -0800 | [diff] [blame^] | 229 | (mScheduleTiming.lastVsync - systemTime()) / 1e6f); |
Ady Abraham | 5e7371c | 2020-03-24 14:47:24 -0700 | [diff] [blame] | 230 | |
| 231 | if (mLastDispatchTime) { |
| 232 | StringAppendF(&result, "\t\t\tmLastDispatchTime: %.2fms ago\n", |
| 233 | (systemTime() - *mLastDispatchTime) / 1e6f); |
| 234 | } else { |
| 235 | StringAppendF(&result, "\t\t\tmLastDispatchTime unknown\n"); |
| 236 | } |
| 237 | } |
| 238 | |
Kevin DuBois | e4f27a8 | 2019-11-12 11:41:41 -0800 | [diff] [blame] | 239 | VSyncDispatchTimerQueue::VSyncDispatchTimerQueue(std::unique_ptr<TimeKeeper> tk, |
Leon Scroggins III | 6738862 | 2023-02-06 20:36:20 -0500 | [diff] [blame] | 240 | VsyncSchedule::TrackerPtr tracker, |
| 241 | nsecs_t timerSlack, nsecs_t minVsyncDistance) |
Kevin DuBois | c94ca83 | 2019-11-26 12:56:24 -0800 | [diff] [blame] | 242 | : mTimeKeeper(std::move(tk)), |
Leon Scroggins III | 6738862 | 2023-02-06 20:36:20 -0500 | [diff] [blame] | 243 | mTracker(std::move(tracker)), |
Kevin DuBois | c94ca83 | 2019-11-26 12:56:24 -0800 | [diff] [blame] | 244 | mTimerSlack(timerSlack), |
| 245 | mMinVsyncDistance(minVsyncDistance) {} |
Kevin DuBois | 305bef1 | 2019-10-09 13:23:27 -0700 | [diff] [blame] | 246 | |
Kevin DuBois | e4f27a8 | 2019-11-12 11:41:41 -0800 | [diff] [blame] | 247 | VSyncDispatchTimerQueue::~VSyncDispatchTimerQueue() { |
Ady Abraham | 8cb2188 | 2020-08-26 18:22:05 -0700 | [diff] [blame] | 248 | std::lock_guard lock(mMutex); |
Kevin DuBois | 305bef1 | 2019-10-09 13:23:27 -0700 | [diff] [blame] | 249 | cancelTimer(); |
Leon Scroggins III | 0773813 | 2023-04-24 11:43:53 -0400 | [diff] [blame] | 250 | for (auto& [_, entry] : mCallbacks) { |
| 251 | ALOGE("Forgot to unregister a callback on VSyncDispatch!"); |
| 252 | entry->ensureNotRunning(); |
| 253 | } |
Kevin DuBois | 305bef1 | 2019-10-09 13:23:27 -0700 | [diff] [blame] | 254 | } |
| 255 | |
Kevin DuBois | e4f27a8 | 2019-11-12 11:41:41 -0800 | [diff] [blame] | 256 | void VSyncDispatchTimerQueue::cancelTimer() { |
Kevin DuBois | 305bef1 | 2019-10-09 13:23:27 -0700 | [diff] [blame] | 257 | mIntendedWakeupTime = kInvalidTime; |
| 258 | mTimeKeeper->alarmCancel(); |
| 259 | } |
| 260 | |
Ady Abraham | b491c90 | 2020-08-15 15:47:56 -0700 | [diff] [blame] | 261 | void VSyncDispatchTimerQueue::setTimer(nsecs_t targetTime, nsecs_t /*now*/) { |
Kevin DuBois | 305bef1 | 2019-10-09 13:23:27 -0700 | [diff] [blame] | 262 | mIntendedWakeupTime = targetTime; |
Ady Abraham | b491c90 | 2020-08-15 15:47:56 -0700 | [diff] [blame] | 263 | mTimeKeeper->alarmAt(std::bind(&VSyncDispatchTimerQueue::timerCallback, this), |
| 264 | mIntendedWakeupTime); |
Ady Abraham | 7539872 | 2020-04-07 14:08:45 -0700 | [diff] [blame] | 265 | mLastTimerSchedule = mTimeKeeper->now(); |
Kevin DuBois | 305bef1 | 2019-10-09 13:23:27 -0700 | [diff] [blame] | 266 | } |
| 267 | |
Kevin DuBois | e4f27a8 | 2019-11-12 11:41:41 -0800 | [diff] [blame] | 268 | void VSyncDispatchTimerQueue::rearmTimer(nsecs_t now) { |
Kevin DuBois | 305bef1 | 2019-10-09 13:23:27 -0700 | [diff] [blame] | 269 | rearmTimerSkippingUpdateFor(now, mCallbacks.end()); |
| 270 | } |
| 271 | |
Kevin DuBois | e4f27a8 | 2019-11-12 11:41:41 -0800 | [diff] [blame] | 272 | void VSyncDispatchTimerQueue::rearmTimerSkippingUpdateFor( |
| 273 | nsecs_t now, CallbackMap::iterator const& skipUpdateIt) { |
Kevin DuBois | 305bef1 | 2019-10-09 13:23:27 -0700 | [diff] [blame] | 274 | std::optional<nsecs_t> min; |
Kevin DuBois | ecb1f0d | 2019-12-12 10:47:41 -0800 | [diff] [blame] | 275 | std::optional<nsecs_t> targetVsync; |
| 276 | std::optional<std::string_view> nextWakeupName; |
Kevin DuBois | 305bef1 | 2019-10-09 13:23:27 -0700 | [diff] [blame] | 277 | for (auto it = mCallbacks.begin(); it != mCallbacks.end(); it++) { |
| 278 | auto& callback = it->second; |
Kevin DuBois | 5c18c1c | 2020-05-27 15:50:50 -0700 | [diff] [blame] | 279 | if (!callback->wakeupTime() && !callback->hasPendingWorkloadUpdate()) { |
Kevin DuBois | 305bef1 | 2019-10-09 13:23:27 -0700 | [diff] [blame] | 280 | continue; |
| 281 | } |
| 282 | |
| 283 | if (it != skipUpdateIt) { |
Leon Scroggins III | 6738862 | 2023-02-06 20:36:20 -0500 | [diff] [blame] | 284 | callback->update(*mTracker, now); |
Kevin DuBois | 305bef1 | 2019-10-09 13:23:27 -0700 | [diff] [blame] | 285 | } |
| 286 | auto const wakeupTime = *callback->wakeupTime(); |
Dominik Laskowski | 62eff35 | 2021-12-06 09:59:41 -0800 | [diff] [blame] | 287 | if (!min || *min > wakeupTime) { |
Kevin DuBois | ecb1f0d | 2019-12-12 10:47:41 -0800 | [diff] [blame] | 288 | nextWakeupName = callback->name(); |
Kevin DuBois | 305bef1 | 2019-10-09 13:23:27 -0700 | [diff] [blame] | 289 | min = wakeupTime; |
Kevin DuBois | ecb1f0d | 2019-12-12 10:47:41 -0800 | [diff] [blame] | 290 | targetVsync = callback->targetVsync(); |
Kevin DuBois | 305bef1 | 2019-10-09 13:23:27 -0700 | [diff] [blame] | 291 | } |
| 292 | } |
| 293 | |
Dominik Laskowski | 62eff35 | 2021-12-06 09:59:41 -0800 | [diff] [blame] | 294 | if (min && min < mIntendedWakeupTime) { |
| 295 | if (ATRACE_ENABLED() && nextWakeupName && targetVsync) { |
| 296 | ftl::Concat trace(ftl::truncated<5>(*nextWakeupName), " alarm in ", ns2us(*min - now), |
| 297 | "us; VSYNC in ", ns2us(*targetVsync - now), "us"); |
| 298 | ATRACE_NAME(trace.c_str()); |
Kevin DuBois | ecb1f0d | 2019-12-12 10:47:41 -0800 | [diff] [blame] | 299 | } |
Kevin DuBois | 305bef1 | 2019-10-09 13:23:27 -0700 | [diff] [blame] | 300 | setTimer(*min, now); |
| 301 | } else { |
Kevin DuBois | ecb1f0d | 2019-12-12 10:47:41 -0800 | [diff] [blame] | 302 | ATRACE_NAME("cancel timer"); |
Kevin DuBois | 305bef1 | 2019-10-09 13:23:27 -0700 | [diff] [blame] | 303 | cancelTimer(); |
| 304 | } |
| 305 | } |
| 306 | |
Kevin DuBois | e4f27a8 | 2019-11-12 11:41:41 -0800 | [diff] [blame] | 307 | void VSyncDispatchTimerQueue::timerCallback() { |
Kevin DuBois | 305bef1 | 2019-10-09 13:23:27 -0700 | [diff] [blame] | 308 | struct Invocation { |
Kevin DuBois | e4f27a8 | 2019-11-12 11:41:41 -0800 | [diff] [blame] | 309 | std::shared_ptr<VSyncDispatchTimerQueueEntry> callback; |
Kevin DuBois | 2968afc | 2020-01-14 09:48:50 -0800 | [diff] [blame] | 310 | nsecs_t vsyncTimestamp; |
| 311 | nsecs_t wakeupTimestamp; |
Ady Abraham | 9c53ee7 | 2020-07-22 21:16:18 -0700 | [diff] [blame] | 312 | nsecs_t deadlineTimestamp; |
Kevin DuBois | 305bef1 | 2019-10-09 13:23:27 -0700 | [diff] [blame] | 313 | }; |
| 314 | std::vector<Invocation> invocations; |
| 315 | { |
Ady Abraham | 8cb2188 | 2020-08-26 18:22:05 -0700 | [diff] [blame] | 316 | std::lock_guard lock(mMutex); |
Kevin DuBois | f947783 | 2020-07-16 10:21:36 -0700 | [diff] [blame] | 317 | auto const now = mTimeKeeper->now(); |
| 318 | mLastTimerCallback = now; |
Kevin DuBois | 305bef1 | 2019-10-09 13:23:27 -0700 | [diff] [blame] | 319 | for (auto it = mCallbacks.begin(); it != mCallbacks.end(); it++) { |
| 320 | auto& callback = it->second; |
| 321 | auto const wakeupTime = callback->wakeupTime(); |
| 322 | if (!wakeupTime) { |
| 323 | continue; |
| 324 | } |
| 325 | |
Ady Abraham | 9c53ee7 | 2020-07-22 21:16:18 -0700 | [diff] [blame] | 326 | auto const readyTime = callback->readyTime(); |
| 327 | |
Kevin DuBois | f947783 | 2020-07-16 10:21:36 -0700 | [diff] [blame] | 328 | auto const lagAllowance = std::max(now - mIntendedWakeupTime, static_cast<nsecs_t>(0)); |
| 329 | if (*wakeupTime < mIntendedWakeupTime + mTimerSlack + lagAllowance) { |
Kevin DuBois | 305bef1 | 2019-10-09 13:23:27 -0700 | [diff] [blame] | 330 | callback->executing(); |
Ady Abraham | 9c53ee7 | 2020-07-22 21:16:18 -0700 | [diff] [blame] | 331 | invocations.emplace_back(Invocation{callback, *callback->lastExecutedVsyncTarget(), |
| 332 | *wakeupTime, *readyTime}); |
Kevin DuBois | 305bef1 | 2019-10-09 13:23:27 -0700 | [diff] [blame] | 333 | } |
| 334 | } |
| 335 | |
| 336 | mIntendedWakeupTime = kInvalidTime; |
| 337 | rearmTimer(mTimeKeeper->now()); |
| 338 | } |
| 339 | |
| 340 | for (auto const& invocation : invocations) { |
Ady Abraham | 9c53ee7 | 2020-07-22 21:16:18 -0700 | [diff] [blame] | 341 | invocation.callback->callback(invocation.vsyncTimestamp, invocation.wakeupTimestamp, |
| 342 | invocation.deadlineTimestamp); |
Kevin DuBois | 305bef1 | 2019-10-09 13:23:27 -0700 | [diff] [blame] | 343 | } |
| 344 | } |
| 345 | |
Kevin DuBois | e4f27a8 | 2019-11-12 11:41:41 -0800 | [diff] [blame] | 346 | VSyncDispatchTimerQueue::CallbackToken VSyncDispatchTimerQueue::registerCallback( |
Dominik Laskowski | 4e0d20d | 2021-12-06 11:31:02 -0800 | [diff] [blame] | 347 | Callback callback, std::string callbackName) { |
Ady Abraham | 8cb2188 | 2020-08-26 18:22:05 -0700 | [diff] [blame] | 348 | std::lock_guard lock(mMutex); |
Kevin DuBois | 305bef1 | 2019-10-09 13:23:27 -0700 | [diff] [blame] | 349 | return CallbackToken{ |
| 350 | mCallbacks |
| 351 | .emplace(++mCallbackToken, |
Dominik Laskowski | 4e0d20d | 2021-12-06 11:31:02 -0800 | [diff] [blame] | 352 | std::make_shared<VSyncDispatchTimerQueueEntry>(std::move(callbackName), |
| 353 | std::move(callback), |
Kevin DuBois | c94ca83 | 2019-11-26 12:56:24 -0800 | [diff] [blame] | 354 | mMinVsyncDistance)) |
Kevin DuBois | 305bef1 | 2019-10-09 13:23:27 -0700 | [diff] [blame] | 355 | .first->first}; |
| 356 | } |
| 357 | |
Kevin DuBois | e4f27a8 | 2019-11-12 11:41:41 -0800 | [diff] [blame] | 358 | void VSyncDispatchTimerQueue::unregisterCallback(CallbackToken token) { |
| 359 | std::shared_ptr<VSyncDispatchTimerQueueEntry> entry = nullptr; |
Kevin DuBois | 305bef1 | 2019-10-09 13:23:27 -0700 | [diff] [blame] | 360 | { |
Ady Abraham | 8cb2188 | 2020-08-26 18:22:05 -0700 | [diff] [blame] | 361 | std::lock_guard lock(mMutex); |
Kevin DuBois | 305bef1 | 2019-10-09 13:23:27 -0700 | [diff] [blame] | 362 | auto it = mCallbacks.find(token); |
| 363 | if (it != mCallbacks.end()) { |
| 364 | entry = it->second; |
| 365 | mCallbacks.erase(it); |
| 366 | } |
| 367 | } |
| 368 | |
| 369 | if (entry) { |
| 370 | entry->ensureNotRunning(); |
| 371 | } |
| 372 | } |
| 373 | |
Ady Abraham | 9c53ee7 | 2020-07-22 21:16:18 -0700 | [diff] [blame] | 374 | ScheduleResult VSyncDispatchTimerQueue::schedule(CallbackToken token, |
| 375 | ScheduleTiming scheduleTiming) { |
Ady Abraham | 011f8ba | 2022-11-22 15:09:07 -0800 | [diff] [blame] | 376 | std::lock_guard lock(mMutex); |
| 377 | return scheduleLocked(token, scheduleTiming); |
| 378 | } |
Kevin DuBois | 305bef1 | 2019-10-09 13:23:27 -0700 | [diff] [blame] | 379 | |
Ady Abraham | 011f8ba | 2022-11-22 15:09:07 -0800 | [diff] [blame] | 380 | ScheduleResult VSyncDispatchTimerQueue::scheduleLocked(CallbackToken token, |
| 381 | ScheduleTiming scheduleTiming) { |
| 382 | auto it = mCallbacks.find(token); |
| 383 | if (it == mCallbacks.end()) { |
| 384 | return {}; |
| 385 | } |
| 386 | auto& callback = it->second; |
| 387 | auto const now = mTimeKeeper->now(); |
Kevin DuBois | 5c18c1c | 2020-05-27 15:50:50 -0700 | [diff] [blame] | 388 | |
Ady Abraham | 011f8ba | 2022-11-22 15:09:07 -0800 | [diff] [blame] | 389 | /* If the timer thread will run soon, we'll apply this work update via the callback |
| 390 | * timer recalculation to avoid cancelling a callback that is about to fire. */ |
| 391 | auto const rearmImminent = now > mIntendedWakeupTime; |
| 392 | if (CC_UNLIKELY(rearmImminent)) { |
| 393 | callback->addPendingWorkloadUpdate(scheduleTiming); |
Leon Scroggins III | 6738862 | 2023-02-06 20:36:20 -0500 | [diff] [blame] | 394 | return getExpectedCallbackTime(*mTracker, now, scheduleTiming); |
Ady Abraham | 011f8ba | 2022-11-22 15:09:07 -0800 | [diff] [blame] | 395 | } |
Kevin DuBois | 5c18c1c | 2020-05-27 15:50:50 -0700 | [diff] [blame] | 396 | |
Leon Scroggins III | 6738862 | 2023-02-06 20:36:20 -0500 | [diff] [blame] | 397 | const ScheduleResult result = callback->schedule(scheduleTiming, *mTracker, now); |
Ady Abraham | 011f8ba | 2022-11-22 15:09:07 -0800 | [diff] [blame] | 398 | if (!result.has_value()) { |
| 399 | return {}; |
| 400 | } |
Kevin DuBois | 305bef1 | 2019-10-09 13:23:27 -0700 | [diff] [blame] | 401 | |
Ady Abraham | 011f8ba | 2022-11-22 15:09:07 -0800 | [diff] [blame] | 402 | if (callback->wakeupTime() < mIntendedWakeupTime - mTimerSlack) { |
| 403 | rearmTimerSkippingUpdateFor(now, it); |
Kevin DuBois | 305bef1 | 2019-10-09 13:23:27 -0700 | [diff] [blame] | 404 | } |
| 405 | |
| 406 | return result; |
| 407 | } |
| 408 | |
Ady Abraham | 011f8ba | 2022-11-22 15:09:07 -0800 | [diff] [blame] | 409 | ScheduleResult VSyncDispatchTimerQueue::update(CallbackToken token, ScheduleTiming scheduleTiming) { |
| 410 | std::lock_guard lock(mMutex); |
| 411 | const auto it = mCallbacks.find(token); |
| 412 | if (it == mCallbacks.end()) { |
| 413 | return {}; |
| 414 | } |
| 415 | |
| 416 | auto& callback = it->second; |
| 417 | if (!callback->targetVsync().has_value()) { |
| 418 | return {}; |
| 419 | } |
| 420 | |
| 421 | return scheduleLocked(token, scheduleTiming); |
| 422 | } |
| 423 | |
Kevin DuBois | e4f27a8 | 2019-11-12 11:41:41 -0800 | [diff] [blame] | 424 | CancelResult VSyncDispatchTimerQueue::cancel(CallbackToken token) { |
Ady Abraham | 8cb2188 | 2020-08-26 18:22:05 -0700 | [diff] [blame] | 425 | std::lock_guard lock(mMutex); |
Kevin DuBois | 305bef1 | 2019-10-09 13:23:27 -0700 | [diff] [blame] | 426 | |
| 427 | auto it = mCallbacks.find(token); |
| 428 | if (it == mCallbacks.end()) { |
| 429 | return CancelResult::Error; |
| 430 | } |
| 431 | auto& callback = it->second; |
| 432 | |
Kevin DuBois | b340b73 | 2020-06-16 09:07:35 -0700 | [diff] [blame] | 433 | auto const wakeupTime = callback->wakeupTime(); |
| 434 | if (wakeupTime) { |
Kevin DuBois | 305bef1 | 2019-10-09 13:23:27 -0700 | [diff] [blame] | 435 | callback->disarm(); |
Kevin DuBois | b340b73 | 2020-06-16 09:07:35 -0700 | [diff] [blame] | 436 | |
| 437 | if (*wakeupTime == mIntendedWakeupTime) { |
| 438 | mIntendedWakeupTime = kInvalidTime; |
| 439 | rearmTimer(mTimeKeeper->now()); |
| 440 | } |
Kevin DuBois | 305bef1 | 2019-10-09 13:23:27 -0700 | [diff] [blame] | 441 | return CancelResult::Cancelled; |
| 442 | } |
| 443 | return CancelResult::TooLate; |
| 444 | } |
| 445 | |
Ady Abraham | 5e7371c | 2020-03-24 14:47:24 -0700 | [diff] [blame] | 446 | void VSyncDispatchTimerQueue::dump(std::string& result) const { |
Ady Abraham | 8cb2188 | 2020-08-26 18:22:05 -0700 | [diff] [blame] | 447 | std::lock_guard lock(mMutex); |
Ady Abraham | 7539872 | 2020-04-07 14:08:45 -0700 | [diff] [blame] | 448 | StringAppendF(&result, "\tTimer:\n"); |
| 449 | mTimeKeeper->dump(result); |
Ady Abraham | 5e7371c | 2020-03-24 14:47:24 -0700 | [diff] [blame] | 450 | StringAppendF(&result, "\tmTimerSlack: %.2fms mMinVsyncDistance: %.2fms\n", mTimerSlack / 1e6f, |
| 451 | mMinVsyncDistance / 1e6f); |
| 452 | StringAppendF(&result, "\tmIntendedWakeupTime: %.2fms from now\n", |
Ady Abraham | 7539872 | 2020-04-07 14:08:45 -0700 | [diff] [blame] | 453 | (mIntendedWakeupTime - mTimeKeeper->now()) / 1e6f); |
| 454 | StringAppendF(&result, "\tmLastTimerCallback: %.2fms ago mLastTimerSchedule: %.2fms ago\n", |
| 455 | (mTimeKeeper->now() - mLastTimerCallback) / 1e6f, |
| 456 | (mTimeKeeper->now() - mLastTimerSchedule) / 1e6f); |
Ady Abraham | 5e7371c | 2020-03-24 14:47:24 -0700 | [diff] [blame] | 457 | StringAppendF(&result, "\tCallbacks:\n"); |
| 458 | for (const auto& [token, entry] : mCallbacks) { |
| 459 | entry->dump(result); |
| 460 | } |
| 461 | } |
| 462 | |
Leon Scroggins III | 6738862 | 2023-02-06 20:36:20 -0500 | [diff] [blame] | 463 | VSyncCallbackRegistration::VSyncCallbackRegistration(std::shared_ptr<VSyncDispatch> dispatch, |
Dominik Laskowski | 4e0d20d | 2021-12-06 11:31:02 -0800 | [diff] [blame] | 464 | VSyncDispatch::Callback callback, |
| 465 | std::string callbackName) |
Leon Scroggins III | 6738862 | 2023-02-06 20:36:20 -0500 | [diff] [blame] | 466 | : mDispatch(std::move(dispatch)), |
Leon Scroggins III | 6c440ae | 2023-04-21 15:01:03 -0400 | [diff] [blame] | 467 | mToken(mDispatch->registerCallback(std::move(callback), std::move(callbackName))) {} |
Kevin DuBois | 305bef1 | 2019-10-09 13:23:27 -0700 | [diff] [blame] | 468 | |
| 469 | VSyncCallbackRegistration::VSyncCallbackRegistration(VSyncCallbackRegistration&& other) |
Leon Scroggins III | 6c440ae | 2023-04-21 15:01:03 -0400 | [diff] [blame] | 470 | : mDispatch(std::move(other.mDispatch)), mToken(std::exchange(other.mToken, std::nullopt)) {} |
Kevin DuBois | 305bef1 | 2019-10-09 13:23:27 -0700 | [diff] [blame] | 471 | |
| 472 | VSyncCallbackRegistration& VSyncCallbackRegistration::operator=(VSyncCallbackRegistration&& other) { |
Leon Scroggins III | 6c440ae | 2023-04-21 15:01:03 -0400 | [diff] [blame] | 473 | if (this == &other) return *this; |
| 474 | if (mToken) { |
| 475 | mDispatch->unregisterCallback(*mToken); |
| 476 | } |
Kevin DuBois | 305bef1 | 2019-10-09 13:23:27 -0700 | [diff] [blame] | 477 | mDispatch = std::move(other.mDispatch); |
Leon Scroggins III | 6c440ae | 2023-04-21 15:01:03 -0400 | [diff] [blame] | 478 | mToken = std::exchange(other.mToken, std::nullopt); |
Kevin DuBois | 305bef1 | 2019-10-09 13:23:27 -0700 | [diff] [blame] | 479 | return *this; |
| 480 | } |
| 481 | |
| 482 | VSyncCallbackRegistration::~VSyncCallbackRegistration() { |
Leon Scroggins III | 6c440ae | 2023-04-21 15:01:03 -0400 | [diff] [blame] | 483 | if (mToken) mDispatch->unregisterCallback(*mToken); |
Kevin DuBois | 305bef1 | 2019-10-09 13:23:27 -0700 | [diff] [blame] | 484 | } |
| 485 | |
Ady Abraham | 9c53ee7 | 2020-07-22 21:16:18 -0700 | [diff] [blame] | 486 | ScheduleResult VSyncCallbackRegistration::schedule(VSyncDispatch::ScheduleTiming scheduleTiming) { |
Leon Scroggins III | 6c440ae | 2023-04-21 15:01:03 -0400 | [diff] [blame] | 487 | if (!mToken) { |
Ady Abraham | b5d3afa | 2021-05-07 11:22:23 -0700 | [diff] [blame] | 488 | return std::nullopt; |
Kevin DuBois | c94ca83 | 2019-11-26 12:56:24 -0800 | [diff] [blame] | 489 | } |
Leon Scroggins III | 6c440ae | 2023-04-21 15:01:03 -0400 | [diff] [blame] | 490 | return mDispatch->schedule(*mToken, scheduleTiming); |
Kevin DuBois | 305bef1 | 2019-10-09 13:23:27 -0700 | [diff] [blame] | 491 | } |
| 492 | |
Ady Abraham | 011f8ba | 2022-11-22 15:09:07 -0800 | [diff] [blame] | 493 | ScheduleResult VSyncCallbackRegistration::update(VSyncDispatch::ScheduleTiming scheduleTiming) { |
Leon Scroggins III | 6c440ae | 2023-04-21 15:01:03 -0400 | [diff] [blame] | 494 | if (!mToken) { |
Ady Abraham | 011f8ba | 2022-11-22 15:09:07 -0800 | [diff] [blame] | 495 | return std::nullopt; |
| 496 | } |
Leon Scroggins III | 6c440ae | 2023-04-21 15:01:03 -0400 | [diff] [blame] | 497 | return mDispatch->update(*mToken, scheduleTiming); |
Ady Abraham | 011f8ba | 2022-11-22 15:09:07 -0800 | [diff] [blame] | 498 | } |
| 499 | |
Kevin DuBois | 305bef1 | 2019-10-09 13:23:27 -0700 | [diff] [blame] | 500 | CancelResult VSyncCallbackRegistration::cancel() { |
Leon Scroggins III | 6c440ae | 2023-04-21 15:01:03 -0400 | [diff] [blame] | 501 | if (!mToken) { |
Kevin DuBois | c94ca83 | 2019-11-26 12:56:24 -0800 | [diff] [blame] | 502 | return CancelResult::Error; |
| 503 | } |
Leon Scroggins III | 6c440ae | 2023-04-21 15:01:03 -0400 | [diff] [blame] | 504 | return mDispatch->cancel(*mToken); |
Kevin DuBois | 305bef1 | 2019-10-09 13:23:27 -0700 | [diff] [blame] | 505 | } |
| 506 | |
| 507 | } // namespace android::scheduler |