blob: fba32613883ca6eaa61689618e91781597b360bf [file] [log] [blame]
Jesse Hall99c7dbb2013-03-14 14:29:29 -07001/*
2 * Copyright 2013 The Android Open Source Project
3 *
4 * Licensed under the Apache License, Version 2.0 (the "License");
5 * you may not use this file except in compliance with the License.
6 * You may obtain a copy of the License at
7 *
8 * http://www.apache.org/licenses/LICENSE-2.0
9 *
10 * Unless required by applicable law or agreed to in writing, software
11 * distributed under the License is distributed on an "AS IS" BASIS,
12 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
13 * See the License for the specific language governing permissions and
14 * limitations under the License.
15 */
16
Ady Abrahamb0dbdaa2020-01-06 16:19:42 -080017// TODO(b/129481165): remove the #pragma below and fix conversion issues
18#pragma clang diagnostic push
19#pragma clang diagnostic ignored "-Wconversion"
20
Jesse Hall38efe862013-04-06 23:12:29 -070021// #define LOG_NDEBUG 0
Jesse Hall99c7dbb2013-03-14 14:29:29 -070022#include "VirtualDisplaySurface.h"
Mathias Agopiancb496ac2017-05-22 14:21:00 -070023
24#include <inttypes.h>
25
Jesse Hall38efe862013-04-06 23:12:29 -070026#include "HWComposer.h"
Fabien Sanglarda34ed632017-03-14 11:43:52 -070027#include "SurfaceFlinger.h"
Jesse Hall99c7dbb2013-03-14 14:29:29 -070028
Dan Stoza11611f92015-03-12 15:12:44 -070029#include <gui/BufferItem.h>
Mathias Agopiana9347642017-02-13 16:42:28 -080030#include <gui/BufferQueue.h>
Pablo Ceballosf133d002015-10-23 12:10:13 -070031#include <gui/IProducerListener.h>
Mathias Agopian6a3c05b2017-04-27 20:06:55 -070032#include <system/window.h>
Dan Stoza11611f92015-03-12 15:12:44 -070033
Jesse Hall99c7dbb2013-03-14 14:29:29 -070034// ---------------------------------------------------------------------------
35namespace android {
36// ---------------------------------------------------------------------------
37
Jesse Hall24cd98e2014-07-13 14:37:16 -070038#define VDS_LOGE(msg, ...) ALOGE("[%s] " msg, \
Dominik Laskowskibf170d92018-04-19 15:08:05 -070039 mDisplayName.c_str(), ##__VA_ARGS__)
Jesse Hall24cd98e2014-07-13 14:37:16 -070040#define VDS_LOGW_IF(cond, msg, ...) ALOGW_IF(cond, "[%s] " msg, \
Dominik Laskowskibf170d92018-04-19 15:08:05 -070041 mDisplayName.c_str(), ##__VA_ARGS__)
Jesse Hall24cd98e2014-07-13 14:37:16 -070042#define VDS_LOGV(msg, ...) ALOGV("[%s] " msg, \
Dominik Laskowskibf170d92018-04-19 15:08:05 -070043 mDisplayName.c_str(), ##__VA_ARGS__)
Jesse Hall38efe862013-04-06 23:12:29 -070044
Lloyd Pique542307f2018-10-19 13:24:08 -070045static const char* dbgCompositionTypeStr(compositionengine::DisplaySurface::CompositionType type) {
Jesse Hall38efe862013-04-06 23:12:29 -070046 switch (type) {
Lloyd Pique542307f2018-10-19 13:24:08 -070047 case compositionengine::DisplaySurface::COMPOSITION_UNKNOWN:
48 return "UNKNOWN";
Peiyong Linf3ffc4e2019-12-13 00:46:24 -080049 case compositionengine::DisplaySurface::COMPOSITION_GPU:
50 return "GPU";
Lloyd Pique542307f2018-10-19 13:24:08 -070051 case compositionengine::DisplaySurface::COMPOSITION_HWC:
52 return "HWC";
53 case compositionengine::DisplaySurface::COMPOSITION_MIXED:
54 return "MIXED";
Peiyong Linf3ffc4e2019-12-13 00:46:24 -080055 default:
56 return "<INVALID>";
Jesse Hall38efe862013-04-06 23:12:29 -070057 }
58}
59
Dominik Laskowski075d3172018-05-24 15:50:06 -070060VirtualDisplaySurface::VirtualDisplaySurface(HWComposer& hwc,
61 const std::optional<DisplayId>& displayId,
62 const sp<IGraphicBufferProducer>& sink,
63 const sp<IGraphicBufferProducer>& bqProducer,
64 const sp<IGraphicBufferConsumer>& bqConsumer,
65 const std::string& name)
66 : ConsumerBase(bqConsumer),
67 mHwc(hwc),
68 mDisplayId(displayId),
69 mDisplayName(name),
70 mSource{},
71 mDefaultOutputFormat(HAL_PIXEL_FORMAT_IMPLEMENTATION_DEFINED),
72 mOutputFormat(HAL_PIXEL_FORMAT_IMPLEMENTATION_DEFINED),
73 mOutputUsage(GRALLOC_USAGE_HW_COMPOSER),
74 mProducerSlotSource(0),
75 mProducerBuffers(),
76 mQueueBufferOutput(),
77 mSinkBufferWidth(0),
78 mSinkBufferHeight(0),
79 mCompositionType(COMPOSITION_UNKNOWN),
80 mFbFence(Fence::NO_FENCE),
81 mOutputFence(Fence::NO_FENCE),
82 mFbProducerSlot(BufferQueue::INVALID_BUFFER_SLOT),
83 mOutputProducerSlot(BufferQueue::INVALID_BUFFER_SLOT),
84 mDbgState(DBG_STATE_IDLE),
85 mDbgLastCompositionType(COMPOSITION_UNKNOWN),
86 mMustRecompose(false),
87 mForceHwcCopy(SurfaceFlinger::useHwcForRgbToYuv) {
Jesse Hall38efe862013-04-06 23:12:29 -070088 mSource[SOURCE_SINK] = sink;
Dan Stozab9b08832014-03-13 11:55:57 -070089 mSource[SOURCE_SCRATCH] = bqProducer;
Jesse Hall38efe862013-04-06 23:12:29 -070090
91 resetPerFrameState();
92
93 int sinkWidth, sinkHeight;
Jesse Hall497ba0e2013-11-04 16:43:03 -080094 sink->query(NATIVE_WINDOW_WIDTH, &sinkWidth);
95 sink->query(NATIVE_WINDOW_HEIGHT, &sinkHeight);
Michael Lentine47e45402014-07-18 15:34:25 -070096 mSinkBufferWidth = sinkWidth;
97 mSinkBufferHeight = sinkHeight;
Jesse Hall497ba0e2013-11-04 16:43:03 -080098
99 // Pick the buffer format to request from the sink when not rendering to it
Peiyong Linf3ffc4e2019-12-13 00:46:24 -0800100 // with GPU. If the consumer needs CPU access, use the default format
Jesse Hall497ba0e2013-11-04 16:43:03 -0800101 // set by the consumer. Otherwise allow gralloc to decide the format based
102 // on usage bits.
103 int sinkUsage;
104 sink->query(NATIVE_WINDOW_CONSUMER_USAGE_BITS, &sinkUsage);
105 if (sinkUsage & (GRALLOC_USAGE_SW_READ_MASK | GRALLOC_USAGE_SW_WRITE_MASK)) {
106 int sinkFormat;
107 sink->query(NATIVE_WINDOW_FORMAT, &sinkFormat);
108 mDefaultOutputFormat = sinkFormat;
109 } else {
110 mDefaultOutputFormat = HAL_PIXEL_FORMAT_IMPLEMENTATION_DEFINED;
111 }
112 mOutputFormat = mDefaultOutputFormat;
Jesse Hall38efe862013-04-06 23:12:29 -0700113
Dominik Laskowskibf170d92018-04-19 15:08:05 -0700114 ConsumerBase::mName = String8::format("VDS: %s", mDisplayName.c_str());
Mathias Agopiandb89edc2013-08-02 01:40:18 -0700115 mConsumer->setConsumerName(ConsumerBase::mName);
116 mConsumer->setConsumerUsageBits(GRALLOC_USAGE_HW_COMPOSER);
117 mConsumer->setDefaultBufferSize(sinkWidth, sinkHeight);
Pablo Ceballos567dbbb2015-08-26 18:59:08 -0700118 sink->setAsyncMode(true);
Alec Mouri8d4f90a2018-11-14 22:33:24 +0000119 IGraphicBufferProducer::QueueBufferOutput output;
120 mSource[SOURCE_SCRATCH]->connect(nullptr, NATIVE_WINDOW_API_EGL, false, &output);
Jesse Hallffe1f192013-03-22 15:13:48 -0700121}
Jesse Hall99c7dbb2013-03-14 14:29:29 -0700122
123VirtualDisplaySurface::~VirtualDisplaySurface() {
Pablo Ceballosf133d002015-10-23 12:10:13 -0700124 mSource[SOURCE_SCRATCH]->disconnect(NATIVE_WINDOW_API_EGL);
Jesse Hall99c7dbb2013-03-14 14:29:29 -0700125}
126
Dan Stoza71433162014-02-04 16:22:36 -0800127status_t VirtualDisplaySurface::beginFrame(bool mustRecompose) {
Dominik Laskowski075d3172018-05-24 15:50:06 -0700128 if (!mDisplayId) {
Jesse Hall38efe862013-04-06 23:12:29 -0700129 return NO_ERROR;
Dominik Laskowski075d3172018-05-24 15:50:06 -0700130 }
Jesse Hall38efe862013-04-06 23:12:29 -0700131
Dan Stoza71433162014-02-04 16:22:36 -0800132 mMustRecompose = mustRecompose;
133
Jesse Hall38efe862013-04-06 23:12:29 -0700134 VDS_LOGW_IF(mDbgState != DBG_STATE_IDLE,
Jesse Hall028dc8f2013-08-20 16:35:32 -0700135 "Unexpected beginFrame() in %s state", dbgStateStr());
136 mDbgState = DBG_STATE_BEGUN;
137
Jesse Hall028dc8f2013-08-20 16:35:32 -0700138 return refreshOutputBuffer();
139}
140
141status_t VirtualDisplaySurface::prepareFrame(CompositionType compositionType) {
Dominik Laskowski075d3172018-05-24 15:50:06 -0700142 if (!mDisplayId) {
Jesse Hall028dc8f2013-08-20 16:35:32 -0700143 return NO_ERROR;
Dominik Laskowski075d3172018-05-24 15:50:06 -0700144 }
Jesse Hall028dc8f2013-08-20 16:35:32 -0700145
146 VDS_LOGW_IF(mDbgState != DBG_STATE_BEGUN,
Jesse Hall38efe862013-04-06 23:12:29 -0700147 "Unexpected prepareFrame() in %s state", dbgStateStr());
148 mDbgState = DBG_STATE_PREPARED;
149
150 mCompositionType = compositionType;
Peiyong Linf3ffc4e2019-12-13 00:46:24 -0800151 if (mForceHwcCopy && mCompositionType == COMPOSITION_GPU) {
Naseer Ahmed6a968462013-10-04 16:15:22 -0400152 // Some hardware can do RGB->YUV conversion more efficiently in hardware
153 // controlled by HWC than in hardware controlled by the video encoder.
Peiyong Linf3ffc4e2019-12-13 00:46:24 -0800154 // Forcing GPU-composed frames to go through an extra copy by the HWC
Naseer Ahmed6a968462013-10-04 16:15:22 -0400155 // allows the format conversion to happen there, rather than passing RGB
156 // directly to the consumer.
157 //
158 // On the other hand, when the consumer prefers RGB or can consume RGB
159 // inexpensively, this forces an unnecessary copy.
160 mCompositionType = COMPOSITION_MIXED;
161 }
162
Jesse Hall38efe862013-04-06 23:12:29 -0700163 if (mCompositionType != mDbgLastCompositionType) {
164 VDS_LOGV("prepareFrame: composition type changed to %s",
165 dbgCompositionTypeStr(mCompositionType));
166 mDbgLastCompositionType = mCompositionType;
167 }
168
Peiyong Linf3ffc4e2019-12-13 00:46:24 -0800169 if (mCompositionType != COMPOSITION_GPU &&
170 (mOutputFormat != mDefaultOutputFormat || mOutputUsage != GRALLOC_USAGE_HW_COMPOSER)) {
171 // We must have just switched from GPU-only to MIXED or HWC
172 // composition. Stop using the format and usage requested by the GPU
Jesse Hall1e27ba22013-09-27 09:05:09 -0700173 // driver; they may be suboptimal when HWC is writing to the output
174 // buffer. For example, if the output is going to a video encoder, and
175 // HWC can write directly to YUV, some hardware can skip a
176 // memory-to-memory RGB-to-YUV conversion step.
177 //
Peiyong Linf3ffc4e2019-12-13 00:46:24 -0800178 // If we just switched *to* GPU-only mode, we'll change the
179 // format/usage and get a new buffer when the GPU driver calls
Jesse Hall1e27ba22013-09-27 09:05:09 -0700180 // dequeueBuffer().
Jesse Hall497ba0e2013-11-04 16:43:03 -0800181 mOutputFormat = mDefaultOutputFormat;
Jesse Hall1e27ba22013-09-27 09:05:09 -0700182 mOutputUsage = GRALLOC_USAGE_HW_COMPOSER;
183 refreshOutputBuffer();
184 }
185
Jesse Hall38efe862013-04-06 23:12:29 -0700186 return NO_ERROR;
Jesse Hall99c7dbb2013-03-14 14:29:29 -0700187}
188
Jesse Hall99c7dbb2013-03-14 14:29:29 -0700189status_t VirtualDisplaySurface::advanceFrame() {
Dominik Laskowski075d3172018-05-24 15:50:06 -0700190 if (!mDisplayId) {
Jesse Hall38efe862013-04-06 23:12:29 -0700191 return NO_ERROR;
Dominik Laskowski075d3172018-05-24 15:50:06 -0700192 }
Jesse Hall38efe862013-04-06 23:12:29 -0700193
194 if (mCompositionType == COMPOSITION_HWC) {
195 VDS_LOGW_IF(mDbgState != DBG_STATE_PREPARED,
196 "Unexpected advanceFrame() in %s state on HWC frame",
197 dbgStateStr());
198 } else {
Peiyong Linf3ffc4e2019-12-13 00:46:24 -0800199 VDS_LOGW_IF(mDbgState != DBG_STATE_GPU_DONE,
200 "Unexpected advanceFrame() in %s state on GPU/MIXED frame", dbgStateStr());
Jesse Hall38efe862013-04-06 23:12:29 -0700201 }
202 mDbgState = DBG_STATE_HWC;
203
Jesse Hall14e8b012013-11-07 12:28:26 -0800204 if (mOutputProducerSlot < 0 ||
205 (mCompositionType != COMPOSITION_HWC && mFbProducerSlot < 0)) {
Jesse Hall38efe862013-04-06 23:12:29 -0700206 // Last chance bailout if something bad happened earlier. For example,
Peiyong Linf3ffc4e2019-12-13 00:46:24 -0800207 // in a graphics API configuration, if the sink disappears then dequeueBuffer
208 // will fail, the GPU driver won't queue a buffer, but SurfaceFlinger
Jesse Hall38efe862013-04-06 23:12:29 -0700209 // will soldier on. So we end up here without a buffer. There should
210 // be lots of scary messages in the log just before this.
211 VDS_LOGE("advanceFrame: no buffer, bailing out");
212 return NO_MEMORY;
213 }
214
Jesse Hall14e8b012013-11-07 12:28:26 -0800215 sp<GraphicBuffer> fbBuffer = mFbProducerSlot >= 0 ?
Peiyong Lin566a3b42018-01-09 18:22:43 -0800216 mProducerBuffers[mFbProducerSlot] : sp<GraphicBuffer>(nullptr);
Jesse Hall38efe862013-04-06 23:12:29 -0700217 sp<GraphicBuffer> outBuffer = mProducerBuffers[mOutputProducerSlot];
218 VDS_LOGV("advanceFrame: fb=%d(%p) out=%d(%p)",
219 mFbProducerSlot, fbBuffer.get(),
220 mOutputProducerSlot, outBuffer.get());
221
Jesse Hallb716e572013-10-01 17:25:20 -0700222 // At this point we know the output buffer acquire fence,
223 // so update HWC state with it.
Dominik Laskowski075d3172018-05-24 15:50:06 -0700224 mHwc.setOutputBuffer(*mDisplayId, mOutputFence, outBuffer);
Jesse Hallb716e572013-10-01 17:25:20 -0700225
Jesse Hall14e8b012013-11-07 12:28:26 -0800226 status_t result = NO_ERROR;
Peiyong Lin566a3b42018-01-09 18:22:43 -0800227 if (fbBuffer != nullptr) {
Chia-I Wu06d63de2017-01-04 14:58:51 +0800228 uint32_t hwcSlot = 0;
229 sp<GraphicBuffer> hwcBuffer;
Valerie Hau13f0d1a2019-03-22 10:35:42 -0700230 mHwcBufferCache.getHwcBuffer(mFbProducerSlot, fbBuffer, &hwcSlot, &hwcBuffer);
Chia-I Wu06d63de2017-01-04 14:58:51 +0800231
Dan Stoza9e56aa02015-11-02 13:00:03 -0800232 // TODO: Correctly propagate the dataspace from GL composition
Dominik Laskowski075d3172018-05-24 15:50:06 -0700233 result = mHwc.setClientTarget(*mDisplayId, hwcSlot, mFbFence, hwcBuffer,
234 ui::Dataspace::UNKNOWN);
Jesse Hall14e8b012013-11-07 12:28:26 -0800235 }
236
237 return result;
Jesse Hall99c7dbb2013-03-14 14:29:29 -0700238}
239
Jesse Hall851cfe82013-03-20 13:44:00 -0700240void VirtualDisplaySurface::onFrameCommitted() {
Dominik Laskowski075d3172018-05-24 15:50:06 -0700241 if (!mDisplayId) {
Jesse Hall38efe862013-04-06 23:12:29 -0700242 return;
Dominik Laskowski075d3172018-05-24 15:50:06 -0700243 }
Jesse Hall38efe862013-04-06 23:12:29 -0700244
245 VDS_LOGW_IF(mDbgState != DBG_STATE_HWC,
246 "Unexpected onFrameCommitted() in %s state", dbgStateStr());
247 mDbgState = DBG_STATE_IDLE;
248
Dominik Laskowski075d3172018-05-24 15:50:06 -0700249 sp<Fence> retireFence = mHwc.getPresentFence(*mDisplayId);
Jesse Hall38efe862013-04-06 23:12:29 -0700250 if (mCompositionType == COMPOSITION_MIXED && mFbProducerSlot >= 0) {
251 // release the scratch buffer back to the pool
252 Mutex::Autolock lock(mMutex);
253 int sslot = mapProducer2SourceSlot(SOURCE_SCRATCH, mFbProducerSlot);
254 VDS_LOGV("onFrameCommitted: release scratch sslot=%d", sslot);
Dan Stoza9e56aa02015-11-02 13:00:03 -0800255 addReleaseFenceLocked(sslot, mProducerBuffers[mFbProducerSlot],
256 retireFence);
Chia-I Wu1e24cce2017-11-10 10:36:01 -0800257 releaseBufferLocked(sslot, mProducerBuffers[mFbProducerSlot]);
Jesse Hall38efe862013-04-06 23:12:29 -0700258 }
259
260 if (mOutputProducerSlot >= 0) {
261 int sslot = mapProducer2SourceSlot(SOURCE_SINK, mOutputProducerSlot);
262 QueueBufferOutput qbo;
Jesse Hall38efe862013-04-06 23:12:29 -0700263 VDS_LOGV("onFrameCommitted: queue sink sslot=%d", sslot);
Dan Stoza71433162014-02-04 16:22:36 -0800264 if (mMustRecompose) {
265 status_t result = mSource[SOURCE_SINK]->queueBuffer(sslot,
266 QueueBufferInput(
267 systemTime(), false /* isAutoTimestamp */,
Eino-Ville Talvala82c6bcc2015-02-19 16:10:43 -0800268 HAL_DATASPACE_UNKNOWN,
Dan Stoza71433162014-02-04 16:22:36 -0800269 Rect(mSinkBufferWidth, mSinkBufferHeight),
270 NATIVE_WINDOW_SCALING_MODE_FREEZE, 0 /* transform */,
Dan Stoza9e56aa02015-11-02 13:00:03 -0800271 retireFence),
Dan Stoza71433162014-02-04 16:22:36 -0800272 &qbo);
273 if (result == NO_ERROR) {
Brian Anderson3d4039d2016-09-23 16:31:30 -0700274 updateQueueBufferOutput(std::move(qbo));
Dan Stoza71433162014-02-04 16:22:36 -0800275 }
276 } else {
277 // If the surface hadn't actually been updated, then we only went
278 // through the motions of updating the display to keep our state
279 // machine happy. We cancel the buffer to avoid triggering another
280 // re-composition and causing an infinite loop.
Dan Stoza9e56aa02015-11-02 13:00:03 -0800281 mSource[SOURCE_SINK]->cancelBuffer(sslot, retireFence);
Jesse Hall38efe862013-04-06 23:12:29 -0700282 }
283 }
284
285 resetPerFrameState();
Jesse Hall99c7dbb2013-03-14 14:29:29 -0700286}
287
Dan Stoza01049c82014-11-11 10:32:31 -0800288void VirtualDisplaySurface::dumpAsString(String8& /* result */) const {
Jesse Hall99c7dbb2013-03-14 14:29:29 -0700289}
290
Michael Lentine47e45402014-07-18 15:34:25 -0700291void VirtualDisplaySurface::resizeBuffers(const uint32_t w, const uint32_t h) {
Brian Andersonbaaad322016-07-22 15:55:13 -0700292 mQueueBufferOutput.width = w;
293 mQueueBufferOutput.height = h;
Michael Lentine47e45402014-07-18 15:34:25 -0700294 mSinkBufferWidth = w;
295 mSinkBufferHeight = h;
296}
297
Dan Stoza9e56aa02015-11-02 13:00:03 -0800298const sp<Fence>& VirtualDisplaySurface::getClientTargetAcquireFence() const {
299 return mFbFence;
300}
Dan Stoza9e56aa02015-11-02 13:00:03 -0800301
Jesse Hall38efe862013-04-06 23:12:29 -0700302status_t VirtualDisplaySurface::requestBuffer(int pslot,
303 sp<GraphicBuffer>* outBuf) {
Dominik Laskowski075d3172018-05-24 15:50:06 -0700304 if (!mDisplayId) {
Michael Lentine47e45402014-07-18 15:34:25 -0700305 return mSource[SOURCE_SINK]->requestBuffer(pslot, outBuf);
Dominik Laskowski075d3172018-05-24 15:50:06 -0700306 }
Michael Lentine47e45402014-07-18 15:34:25 -0700307
Peiyong Linf3ffc4e2019-12-13 00:46:24 -0800308 VDS_LOGW_IF(mDbgState != DBG_STATE_GPU, "Unexpected requestBuffer pslot=%d in %s state", pslot,
309 dbgStateStr());
Jesse Hall38efe862013-04-06 23:12:29 -0700310
311 *outBuf = mProducerBuffers[pslot];
312 return NO_ERROR;
313}
314
Pablo Ceballosfa455352015-08-12 17:47:47 -0700315status_t VirtualDisplaySurface::setMaxDequeuedBufferCount(
316 int maxDequeuedBuffers) {
317 return mSource[SOURCE_SINK]->setMaxDequeuedBufferCount(maxDequeuedBuffers);
318}
319
320status_t VirtualDisplaySurface::setAsyncMode(bool async) {
321 return mSource[SOURCE_SINK]->setAsyncMode(async);
322}
323
Jesse Hall38efe862013-04-06 23:12:29 -0700324status_t VirtualDisplaySurface::dequeueBuffer(Source source,
Mathias Agopiancb496ac2017-05-22 14:21:00 -0700325 PixelFormat format, uint64_t usage, int* sslot, sp<Fence>* fence) {
Dominik Laskowski075d3172018-05-24 15:50:06 -0700326 LOG_FATAL_IF(!mDisplayId);
Jesse Hall8db92552013-08-29 16:03:50 -0700327
Ian Elliotta2eb34c2017-07-18 11:05:49 -0600328 status_t result =
329 mSource[source]->dequeueBuffer(sslot, fence, mSinkBufferWidth, mSinkBufferHeight,
330 format, usage, nullptr, nullptr);
Jesse Hall38efe862013-04-06 23:12:29 -0700331 if (result < 0)
332 return result;
333 int pslot = mapSource2ProducerSlot(source, *sslot);
334 VDS_LOGV("dequeueBuffer(%s): sslot=%d pslot=%d result=%d",
335 dbgSourceStr(source), *sslot, pslot, result);
Dan Stozafebd4f42014-04-09 16:14:51 -0700336 uint64_t sourceBit = static_cast<uint64_t>(source) << pslot;
Jesse Hall38efe862013-04-06 23:12:29 -0700337
Dan Stozafebd4f42014-04-09 16:14:51 -0700338 if ((mProducerSlotSource & (1ULL << pslot)) != sourceBit) {
Jesse Hall38efe862013-04-06 23:12:29 -0700339 // This slot was previously dequeued from the other source; must
340 // re-request the buffer.
341 result |= BUFFER_NEEDS_REALLOCATION;
Dan Stozafebd4f42014-04-09 16:14:51 -0700342 mProducerSlotSource &= ~(1ULL << pslot);
Jesse Hall38efe862013-04-06 23:12:29 -0700343 mProducerSlotSource |= sourceBit;
344 }
345
346 if (result & RELEASE_ALL_BUFFERS) {
347 for (uint32_t i = 0; i < BufferQueue::NUM_BUFFER_SLOTS; i++) {
Dan Stozafebd4f42014-04-09 16:14:51 -0700348 if ((mProducerSlotSource & (1ULL << i)) == sourceBit)
Jesse Hall38efe862013-04-06 23:12:29 -0700349 mProducerBuffers[i].clear();
350 }
351 }
352 if (result & BUFFER_NEEDS_REALLOCATION) {
Jesse Hall0b63cd12014-04-29 16:14:14 -0700353 result = mSource[source]->requestBuffer(*sslot, &mProducerBuffers[pslot]);
354 if (result < 0) {
355 mProducerBuffers[pslot].clear();
356 mSource[source]->cancelBuffer(*sslot, *fence);
357 return result;
358 }
Mathias Agopiancb496ac2017-05-22 14:21:00 -0700359 VDS_LOGV("dequeueBuffer(%s): buffers[%d]=%p fmt=%d usage=%#" PRIx64,
Jesse Hall497ba0e2013-11-04 16:43:03 -0800360 dbgSourceStr(source), pslot, mProducerBuffers[pslot].get(),
361 mProducerBuffers[pslot]->getPixelFormat(),
362 mProducerBuffers[pslot]->getUsage());
Jesse Hall38efe862013-04-06 23:12:29 -0700363 }
364
365 return result;
366}
367
Ian Elliotta2eb34c2017-07-18 11:05:49 -0600368status_t VirtualDisplaySurface::dequeueBuffer(int* pslot, sp<Fence>* fence, uint32_t w, uint32_t h,
369 PixelFormat format, uint64_t usage,
370 uint64_t* outBufferAge,
371 FrameEventHistoryDelta* outTimestamps) {
Dominik Laskowski075d3172018-05-24 15:50:06 -0700372 if (!mDisplayId) {
Ian Elliotta2eb34c2017-07-18 11:05:49 -0600373 return mSource[SOURCE_SINK]->dequeueBuffer(pslot, fence, w, h, format, usage, outBufferAge,
374 outTimestamps);
Brian Anderson7c3ba8a2016-07-25 12:48:08 -0700375 }
Michael Lentine47e45402014-07-18 15:34:25 -0700376
Jesse Hall38efe862013-04-06 23:12:29 -0700377 VDS_LOGW_IF(mDbgState != DBG_STATE_PREPARED,
378 "Unexpected dequeueBuffer() in %s state", dbgStateStr());
Peiyong Linf3ffc4e2019-12-13 00:46:24 -0800379 mDbgState = DBG_STATE_GPU;
Jesse Hall38efe862013-04-06 23:12:29 -0700380
Mathias Agopiancb496ac2017-05-22 14:21:00 -0700381 VDS_LOGV("dequeueBuffer %dx%d fmt=%d usage=%#" PRIx64, w, h, format, usage);
Jesse Hall38efe862013-04-06 23:12:29 -0700382
Jesse Hall028dc8f2013-08-20 16:35:32 -0700383 status_t result = NO_ERROR;
Jesse Hall38efe862013-04-06 23:12:29 -0700384 Source source = fbSourceForCompositionType(mCompositionType);
Jesse Hall028dc8f2013-08-20 16:35:32 -0700385
Jesse Hall38efe862013-04-06 23:12:29 -0700386 if (source == SOURCE_SINK) {
Mathias Agopian6da15f42013-09-25 20:40:07 -0700387
388 if (mOutputProducerSlot < 0) {
389 // Last chance bailout if something bad happened earlier. For example,
Peiyong Linf3ffc4e2019-12-13 00:46:24 -0800390 // in a graphics API configuration, if the sink disappears then dequeueBuffer
391 // will fail, the GPU driver won't queue a buffer, but SurfaceFlinger
Mathias Agopian6da15f42013-09-25 20:40:07 -0700392 // will soldier on. So we end up here without a buffer. There should
393 // be lots of scary messages in the log just before this.
394 VDS_LOGE("dequeueBuffer: no buffer, bailing out");
395 return NO_MEMORY;
396 }
397
Peiyong Linf3ffc4e2019-12-13 00:46:24 -0800398 // We already dequeued the output buffer. If the GPU driver wants
Jesse Hall028dc8f2013-08-20 16:35:32 -0700399 // something incompatible, we have to cancel and get a new one. This
400 // will mean that HWC will see a different output buffer between
Peiyong Linf3ffc4e2019-12-13 00:46:24 -0800401 // prepare and set, but since we're in GPU-only mode already it
Jesse Hall028dc8f2013-08-20 16:35:32 -0700402 // shouldn't matter.
403
Jesse Hall1e27ba22013-09-27 09:05:09 -0700404 usage |= GRALLOC_USAGE_HW_COMPOSER;
Jesse Hall028dc8f2013-08-20 16:35:32 -0700405 const sp<GraphicBuffer>& buf = mProducerBuffers[mOutputProducerSlot];
Jesse Hall1e27ba22013-09-27 09:05:09 -0700406 if ((usage & ~buf->getUsage()) != 0 ||
Dan Stoza3be1c6b2014-11-18 10:24:03 -0800407 (format != 0 && format != buf->getPixelFormat()) ||
Jesse Hall028dc8f2013-08-20 16:35:32 -0700408 (w != 0 && w != mSinkBufferWidth) ||
409 (h != 0 && h != mSinkBufferHeight)) {
Jesse Hall1e27ba22013-09-27 09:05:09 -0700410 VDS_LOGV("dequeueBuffer: dequeueing new output buffer: "
Mathias Agopiancb496ac2017-05-22 14:21:00 -0700411 "want %dx%d fmt=%d use=%#" PRIx64 ", "
412 "have %dx%d fmt=%d use=%#" PRIx64,
Jesse Hall1e27ba22013-09-27 09:05:09 -0700413 w, h, format, usage,
414 mSinkBufferWidth, mSinkBufferHeight,
415 buf->getPixelFormat(), buf->getUsage());
416 mOutputFormat = format;
417 mOutputUsage = usage;
Jesse Hall028dc8f2013-08-20 16:35:32 -0700418 result = refreshOutputBuffer();
419 if (result < 0)
420 return result;
421 }
Jesse Hall38efe862013-04-06 23:12:29 -0700422 }
423
Jesse Hall028dc8f2013-08-20 16:35:32 -0700424 if (source == SOURCE_SINK) {
425 *pslot = mOutputProducerSlot;
426 *fence = mOutputFence;
427 } else {
428 int sslot;
Jesse Hall1e27ba22013-09-27 09:05:09 -0700429 result = dequeueBuffer(source, format, usage, &sslot, fence);
Jesse Hall028dc8f2013-08-20 16:35:32 -0700430 if (result >= 0) {
431 *pslot = mapSource2ProducerSlot(source, sslot);
432 }
Jesse Hall38efe862013-04-06 23:12:29 -0700433 }
Ian Elliotta2eb34c2017-07-18 11:05:49 -0600434 if (outBufferAge) {
435 *outBufferAge = 0;
436 }
Jesse Hall38efe862013-04-06 23:12:29 -0700437 return result;
438}
439
Dan Stoza88a459a2014-03-12 09:34:36 -0700440status_t VirtualDisplaySurface::detachBuffer(int /* slot */) {
441 VDS_LOGE("detachBuffer is not available for VirtualDisplaySurface");
442 return INVALID_OPERATION;
Dan Stoza9f3053d2014-03-06 15:14:33 -0800443}
444
Dan Stozad9822a32014-03-28 15:25:31 -0700445status_t VirtualDisplaySurface::detachNextBuffer(
446 sp<GraphicBuffer>* /* outBuffer */, sp<Fence>* /* outFence */) {
447 VDS_LOGE("detachNextBuffer is not available for VirtualDisplaySurface");
448 return INVALID_OPERATION;
449}
450
Dan Stoza88a459a2014-03-12 09:34:36 -0700451status_t VirtualDisplaySurface::attachBuffer(int* /* outSlot */,
452 const sp<GraphicBuffer>& /* buffer */) {
453 VDS_LOGE("attachBuffer is not available for VirtualDisplaySurface");
454 return INVALID_OPERATION;
Dan Stoza9f3053d2014-03-06 15:14:33 -0800455}
456
Jesse Hall38efe862013-04-06 23:12:29 -0700457status_t VirtualDisplaySurface::queueBuffer(int pslot,
458 const QueueBufferInput& input, QueueBufferOutput* output) {
Dominik Laskowski075d3172018-05-24 15:50:06 -0700459 if (!mDisplayId) {
Michael Lentine47e45402014-07-18 15:34:25 -0700460 return mSource[SOURCE_SINK]->queueBuffer(pslot, input, output);
Dominik Laskowski075d3172018-05-24 15:50:06 -0700461 }
Michael Lentine47e45402014-07-18 15:34:25 -0700462
Peiyong Linf3ffc4e2019-12-13 00:46:24 -0800463 VDS_LOGW_IF(mDbgState != DBG_STATE_GPU, "Unexpected queueBuffer(pslot=%d) in %s state", pslot,
464 dbgStateStr());
465 mDbgState = DBG_STATE_GPU_DONE;
Jesse Hall38efe862013-04-06 23:12:29 -0700466
467 VDS_LOGV("queueBuffer pslot=%d", pslot);
468
469 status_t result;
470 if (mCompositionType == COMPOSITION_MIXED) {
471 // Queue the buffer back into the scratch pool
472 QueueBufferOutput scratchQBO;
473 int sslot = mapProducer2SourceSlot(SOURCE_SCRATCH, pslot);
Mathias Agopiandb89edc2013-08-02 01:40:18 -0700474 result = mSource[SOURCE_SCRATCH]->queueBuffer(sslot, input, &scratchQBO);
Jesse Hall38efe862013-04-06 23:12:29 -0700475 if (result != NO_ERROR)
476 return result;
477
478 // Now acquire the buffer from the scratch pool -- should be the same
479 // slot and fence as we just queued.
480 Mutex::Autolock lock(mMutex);
Dan Stoza11611f92015-03-12 15:12:44 -0700481 BufferItem item;
Jesse Hallbce76112013-07-16 13:46:20 -0700482 result = acquireBufferLocked(&item, 0);
Jesse Hall38efe862013-04-06 23:12:29 -0700483 if (result != NO_ERROR)
484 return result;
Pablo Ceballos47650f42015-08-04 16:38:17 -0700485 VDS_LOGW_IF(item.mSlot != sslot,
Jesse Hall38efe862013-04-06 23:12:29 -0700486 "queueBuffer: acquired sslot %d from SCRATCH after queueing sslot %d",
Pablo Ceballos47650f42015-08-04 16:38:17 -0700487 item.mSlot, sslot);
488 mFbProducerSlot = mapSource2ProducerSlot(SOURCE_SCRATCH, item.mSlot);
489 mFbFence = mSlots[item.mSlot].mFence;
Jesse Hall38efe862013-04-06 23:12:29 -0700490
491 } else {
Peiyong Linf3ffc4e2019-12-13 00:46:24 -0800492 LOG_FATAL_IF(mCompositionType != COMPOSITION_GPU,
493 "Unexpected queueBuffer in state %s for compositionType %s", dbgStateStr(),
494 dbgCompositionTypeStr(mCompositionType));
Jesse Hall38efe862013-04-06 23:12:29 -0700495
Peiyong Linf3ffc4e2019-12-13 00:46:24 -0800496 // Extract the GPU release fence for HWC to acquire
Jesse Hall38efe862013-04-06 23:12:29 -0700497 int64_t timestamp;
Andy McFadden3c256212013-08-16 14:55:39 -0700498 bool isAutoTimestamp;
Eino-Ville Talvala82c6bcc2015-02-19 16:10:43 -0800499 android_dataspace dataSpace;
Jesse Hall38efe862013-04-06 23:12:29 -0700500 Rect crop;
501 int scalingMode;
502 uint32_t transform;
Eino-Ville Talvala82c6bcc2015-02-19 16:10:43 -0800503 input.deflate(&timestamp, &isAutoTimestamp, &dataSpace, &crop,
Pablo Ceballos567dbbb2015-08-26 18:59:08 -0700504 &scalingMode, &transform, &mFbFence);
Jesse Hall38efe862013-04-06 23:12:29 -0700505
506 mFbProducerSlot = pslot;
Jesse Hall028dc8f2013-08-20 16:35:32 -0700507 mOutputFence = mFbFence;
Jesse Hall38efe862013-04-06 23:12:29 -0700508 }
509
Brian Anderson3d4039d2016-09-23 16:31:30 -0700510 // This moves the frame timestamps and keeps a copy of all other fields.
511 *output = std::move(mQueueBufferOutput);
Jesse Hall38efe862013-04-06 23:12:29 -0700512 return NO_ERROR;
513}
514
Pablo Ceballos583b1b32015-09-03 18:23:52 -0700515status_t VirtualDisplaySurface::cancelBuffer(int pslot,
516 const sp<Fence>& fence) {
Dominik Laskowski075d3172018-05-24 15:50:06 -0700517 if (!mDisplayId) {
Michael Lentinefd9d1832014-07-30 15:39:17 -0700518 return mSource[SOURCE_SINK]->cancelBuffer(mapProducer2SourceSlot(SOURCE_SINK, pslot), fence);
Dominik Laskowski075d3172018-05-24 15:50:06 -0700519 }
Michael Lentine47e45402014-07-18 15:34:25 -0700520
Peiyong Linf3ffc4e2019-12-13 00:46:24 -0800521 VDS_LOGW_IF(mDbgState != DBG_STATE_GPU, "Unexpected cancelBuffer(pslot=%d) in %s state", pslot,
522 dbgStateStr());
Jesse Hall38efe862013-04-06 23:12:29 -0700523 VDS_LOGV("cancelBuffer pslot=%d", pslot);
524 Source source = fbSourceForCompositionType(mCompositionType);
525 return mSource[source]->cancelBuffer(
526 mapProducer2SourceSlot(source, pslot), fence);
527}
528
529int VirtualDisplaySurface::query(int what, int* value) {
Michael Lentine47e45402014-07-18 15:34:25 -0700530 switch (what) {
531 case NATIVE_WINDOW_WIDTH:
532 *value = mSinkBufferWidth;
533 break;
534 case NATIVE_WINDOW_HEIGHT:
535 *value = mSinkBufferHeight;
536 break;
537 default:
538 return mSource[SOURCE_SINK]->query(what, value);
539 }
540 return NO_ERROR;
Jesse Hall38efe862013-04-06 23:12:29 -0700541}
542
Dan Stozaf0eaf252014-03-21 13:05:51 -0700543status_t VirtualDisplaySurface::connect(const sp<IProducerListener>& listener,
Mathias Agopian365857d2013-09-11 19:35:45 -0700544 int api, bool producerControlledByApp,
Mathias Agopian595264f2013-07-16 22:56:09 -0700545 QueueBufferOutput* output) {
Jesse Hall38efe862013-04-06 23:12:29 -0700546 QueueBufferOutput qbo;
Dan Stozaf0eaf252014-03-21 13:05:51 -0700547 status_t result = mSource[SOURCE_SINK]->connect(listener, api,
548 producerControlledByApp, &qbo);
Jesse Hall38efe862013-04-06 23:12:29 -0700549 if (result == NO_ERROR) {
Brian Anderson3d4039d2016-09-23 16:31:30 -0700550 updateQueueBufferOutput(std::move(qbo));
551 // This moves the frame timestamps and keeps a copy of all other fields.
552 *output = std::move(mQueueBufferOutput);
Jesse Hall38efe862013-04-06 23:12:29 -0700553 }
554 return result;
555}
556
Robert Carr97b9c862016-09-08 13:54:35 -0700557status_t VirtualDisplaySurface::disconnect(int api, DisconnectMode mode) {
558 return mSource[SOURCE_SINK]->disconnect(api, mode);
Jesse Hall38efe862013-04-06 23:12:29 -0700559}
560
Jesse Hall399184a2014-03-03 15:42:54 -0800561status_t VirtualDisplaySurface::setSidebandStream(const sp<NativeHandle>& /*stream*/) {
562 return INVALID_OPERATION;
563}
564
Pablo Ceballos567dbbb2015-08-26 18:59:08 -0700565void VirtualDisplaySurface::allocateBuffers(uint32_t /* width */,
Mathias Agopiancb496ac2017-05-22 14:21:00 -0700566 uint32_t /* height */, PixelFormat /* format */, uint64_t /* usage */) {
Dan Stoza29a3e902014-06-20 13:13:57 -0700567 // TODO: Should we actually allocate buffers for a virtual display?
568}
569
Dan Stoza9de72932015-04-16 17:28:43 -0700570status_t VirtualDisplaySurface::allowAllocation(bool /* allow */) {
571 return INVALID_OPERATION;
572}
573
Dan Stoza812ed062015-06-02 15:45:22 -0700574status_t VirtualDisplaySurface::setGenerationNumber(uint32_t /* generation */) {
575 ALOGE("setGenerationNumber not supported on VirtualDisplaySurface");
576 return INVALID_OPERATION;
577}
578
Dan Stozac6f30bd2015-06-08 09:32:50 -0700579String8 VirtualDisplaySurface::getConsumerName() const {
580 return String8("VirtualDisplaySurface");
581}
582
Pablo Ceballos3559fbf2016-03-17 15:50:23 -0700583status_t VirtualDisplaySurface::setSharedBufferMode(bool /*sharedBufferMode*/) {
584 ALOGE("setSharedBufferMode not supported on VirtualDisplaySurface");
Pablo Ceballosff95aab2016-01-13 17:09:58 -0800585 return INVALID_OPERATION;
586}
587
588status_t VirtualDisplaySurface::setAutoRefresh(bool /*autoRefresh*/) {
589 ALOGE("setAutoRefresh not supported on VirtualDisplaySurface");
590 return INVALID_OPERATION;
Pablo Ceballosccdfd602015-10-07 15:05:45 -0700591}
592
Dan Stoza127fc632015-06-30 13:43:32 -0700593status_t VirtualDisplaySurface::setDequeueTimeout(nsecs_t /* timeout */) {
594 ALOGE("setDequeueTimeout not supported on VirtualDisplaySurface");
595 return INVALID_OPERATION;
596}
597
Dan Stoza50101d02016-04-07 16:53:23 -0700598status_t VirtualDisplaySurface::getLastQueuedBuffer(
John Reck1a61da52016-04-28 13:18:15 -0700599 sp<GraphicBuffer>* /*outBuffer*/, sp<Fence>* /*outFence*/,
600 float[16] /* outTransformMatrix*/) {
Dan Stoza50101d02016-04-07 16:53:23 -0700601 ALOGE("getLastQueuedBuffer not supported on VirtualDisplaySurface");
602 return INVALID_OPERATION;
603}
604
Pablo Ceballos8e3e92b2016-06-27 17:56:53 -0700605status_t VirtualDisplaySurface::getUniqueId(uint64_t* /*outId*/) const {
606 ALOGE("getUniqueId not supported on VirtualDisplaySurface");
607 return INVALID_OPERATION;
608}
609
Chia-I Wue2786ea2017-08-07 10:36:08 -0700610status_t VirtualDisplaySurface::getConsumerUsage(uint64_t* outUsage) const {
611 return mSource[SOURCE_SINK]->getConsumerUsage(outUsage);
612}
613
Jesse Hall38efe862013-04-06 23:12:29 -0700614void VirtualDisplaySurface::updateQueueBufferOutput(
Brian Anderson3d4039d2016-09-23 16:31:30 -0700615 QueueBufferOutput&& qbo) {
616 mQueueBufferOutput = std::move(qbo);
Brian Andersonbaaad322016-07-22 15:55:13 -0700617 mQueueBufferOutput.transformHint = 0;
Jesse Hall38efe862013-04-06 23:12:29 -0700618}
619
620void VirtualDisplaySurface::resetPerFrameState() {
621 mCompositionType = COMPOSITION_UNKNOWN;
mayank parsharb988f852014-01-10 10:27:45 +0530622 mFbFence = Fence::NO_FENCE;
Jesse Hall028dc8f2013-08-20 16:35:32 -0700623 mOutputFence = Fence::NO_FENCE;
Jesse Hall38efe862013-04-06 23:12:29 -0700624 mOutputProducerSlot = -1;
mayank parsharfdfde882014-01-23 15:08:31 +0530625 mFbProducerSlot = -1;
Jesse Hall38efe862013-04-06 23:12:29 -0700626}
627
Jesse Hall028dc8f2013-08-20 16:35:32 -0700628status_t VirtualDisplaySurface::refreshOutputBuffer() {
Dominik Laskowski075d3172018-05-24 15:50:06 -0700629 LOG_FATAL_IF(!mDisplayId);
630
Jesse Hall028dc8f2013-08-20 16:35:32 -0700631 if (mOutputProducerSlot >= 0) {
632 mSource[SOURCE_SINK]->cancelBuffer(
633 mapProducer2SourceSlot(SOURCE_SINK, mOutputProducerSlot),
634 mOutputFence);
635 }
636
637 int sslot;
Jesse Hall1e27ba22013-09-27 09:05:09 -0700638 status_t result = dequeueBuffer(SOURCE_SINK, mOutputFormat, mOutputUsage,
639 &sslot, &mOutputFence);
Jesse Hall028dc8f2013-08-20 16:35:32 -0700640 if (result < 0)
641 return result;
642 mOutputProducerSlot = mapSource2ProducerSlot(SOURCE_SINK, sslot);
643
Peiyong Linf3ffc4e2019-12-13 00:46:24 -0800644 // On GPU-only frames, we don't have the right output buffer acquire fence
645 // until after GPU calls queueBuffer(). So here we just set the buffer
Jesse Hallb716e572013-10-01 17:25:20 -0700646 // (for use in HWC prepare) but not the fence; we'll call this again with
647 // the proper fence once we have it.
Dominik Laskowski075d3172018-05-24 15:50:06 -0700648 result = mHwc.setOutputBuffer(*mDisplayId, Fence::NO_FENCE,
649 mProducerBuffers[mOutputProducerSlot]);
Jesse Hall028dc8f2013-08-20 16:35:32 -0700650
651 return result;
652}
653
Jesse Hall38efe862013-04-06 23:12:29 -0700654// This slot mapping function is its own inverse, so two copies are unnecessary.
655// Both are kept to make the intent clear where the function is called, and for
656// the (unlikely) chance that we switch to a different mapping function.
657int VirtualDisplaySurface::mapSource2ProducerSlot(Source source, int sslot) {
658 if (source == SOURCE_SCRATCH) {
659 return BufferQueue::NUM_BUFFER_SLOTS - sslot - 1;
660 } else {
661 return sslot;
662 }
663}
664int VirtualDisplaySurface::mapProducer2SourceSlot(Source source, int pslot) {
665 return mapSource2ProducerSlot(source, pslot);
666}
667
668VirtualDisplaySurface::Source
669VirtualDisplaySurface::fbSourceForCompositionType(CompositionType type) {
670 return type == COMPOSITION_MIXED ? SOURCE_SCRATCH : SOURCE_SINK;
671}
672
673const char* VirtualDisplaySurface::dbgStateStr() const {
674 switch (mDbgState) {
Peiyong Linf3ffc4e2019-12-13 00:46:24 -0800675 case DBG_STATE_IDLE:
676 return "IDLE";
677 case DBG_STATE_PREPARED:
678 return "PREPARED";
679 case DBG_STATE_GPU:
680 return "GPU";
681 case DBG_STATE_GPU_DONE:
682 return "GPU_DONE";
683 case DBG_STATE_HWC:
684 return "HWC";
685 default:
686 return "INVALID";
Jesse Hall38efe862013-04-06 23:12:29 -0700687 }
688}
689
690const char* VirtualDisplaySurface::dbgSourceStr(Source s) {
691 switch (s) {
692 case SOURCE_SINK: return "SINK";
693 case SOURCE_SCRATCH: return "SCRATCH";
694 default: return "INVALID";
695 }
696}
697
Jesse Hall99c7dbb2013-03-14 14:29:29 -0700698// ---------------------------------------------------------------------------
699} // namespace android
700// ---------------------------------------------------------------------------
Ady Abrahamb0dbdaa2020-01-06 16:19:42 -0800701
702// TODO(b/129481165): remove the #pragma below and fix conversion issues
703#pragma clang diagnostic pop // ignored "-Wconversion"