blob: 5cf046033d6073f67fbf31408a4850f89dd41810 [file] [log] [blame]
Marissa Wall61c58622018-07-18 10:12:20 -07001/*
2 * Copyright (C) 2017 The Android Open Source Project
3 *
4 * Licensed under the Apache License, Version 2.0 (the "License");
5 * you may not use this file except in compliance with the License.
6 * You may obtain a copy of the License at
7 *
8 * http://www.apache.org/licenses/LICENSE-2.0
9 *
10 * Unless required by applicable law or agreed to in writing, software
11 * distributed under the License is distributed on an "AS IS" BASIS,
12 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
13 * See the License for the specific language governing permissions and
14 * limitations under the License.
15 */
16
Ady Abrahamb0dbdaa2020-01-06 16:19:42 -080017// TODO(b/129481165): remove the #pragma below and fix conversion issues
18#pragma clang diagnostic push
19#pragma clang diagnostic ignored "-Wconversion"
20
Marissa Wall61c58622018-07-18 10:12:20 -070021//#define LOG_NDEBUG 0
22#undef LOG_TAG
23#define LOG_TAG "BufferStateLayer"
24#define ATRACE_TAG ATRACE_TAG_GRAPHICS
25
Lloyd Pique9755fb72019-03-26 14:44:40 -070026#include "BufferStateLayer.h"
27
Lloyd Pique37c2c9b2018-12-04 17:25:10 -080028#include <limits>
Marissa Wall61c58622018-07-18 10:12:20 -070029
Lloyd Pique9755fb72019-03-26 14:44:40 -070030#include <compositionengine/LayerFECompositionState.h>
Marissa Wall947d34e2019-03-29 14:03:53 -070031#include <gui/BufferQueue.h>
Marissa Wall61c58622018-07-18 10:12:20 -070032#include <private/gui/SyncFeatures.h>
Peiyong Lincbc184f2018-08-22 13:24:10 -070033#include <renderengine/Image.h>
Marissa Wall61c58622018-07-18 10:12:20 -070034
Vishnu Nairfa247b12020-02-11 08:58:26 -080035#include "EffectLayer.h"
Lloyd Pique37c2c9b2018-12-04 17:25:10 -080036#include "TimeStats/TimeStats.h"
Valerie Hau0bc09152018-12-20 07:42:47 -080037
Marissa Wall61c58622018-07-18 10:12:20 -070038namespace android {
39
Lloyd Pique42ab75e2018-09-12 20:46:03 -070040// clang-format off
41const std::array<float, 16> BufferStateLayer::IDENTITY_MATRIX{
42 1, 0, 0, 0,
43 0, 1, 0, 0,
44 0, 0, 1, 0,
45 0, 0, 0, 1
46};
47// clang-format on
Marissa Wall61c58622018-07-18 10:12:20 -070048
Marissa Wall947d34e2019-03-29 14:03:53 -070049BufferStateLayer::BufferStateLayer(const LayerCreationArgs& args)
50 : BufferLayer(args), mHwcSlotGenerator(new HwcSlotGenerator()) {
Marissa Wall3ff826c2019-02-07 11:58:25 -080051 mCurrentState.dataspace = ui::Dataspace::V0_SRGB;
Vishnu Nair60356342018-11-13 13:00:45 -080052}
Marissa Wall61c58622018-07-18 10:12:20 -070053
Alec Mouri4545a8a2019-08-08 20:05:32 -070054BufferStateLayer::~BufferStateLayer() {
chaviwb4c6e582019-08-16 14:35:07 -070055 // The original layer and the clone layer share the same texture and buffer. Therefore, only
56 // one of the layers, in this case the original layer, needs to handle the deletion. The
57 // original layer and the clone should be removed at the same time so there shouldn't be any
58 // issue with the clone layer trying to use the texture.
59 if (mBufferInfo.mBuffer != nullptr && !isClone()) {
chaviwd62d3062019-09-04 14:48:02 -070060 // Ensure that mBuffer is uncached from RenderEngine here, as
Alec Mouri4545a8a2019-08-08 20:05:32 -070061 // RenderEngine may have been using the buffer as an external texture
62 // after the client uncached the buffer.
63 auto& engine(mFlinger->getRenderEngine());
chaviwd62d3062019-09-04 14:48:02 -070064 engine.unbindExternalTextureBuffer(mBufferInfo.mBuffer->getId());
Alec Mouri4545a8a2019-08-08 20:05:32 -070065 }
66}
67
Robert Carr8d958532020-11-10 14:09:16 -080068status_t BufferStateLayer::addReleaseFence(const sp<CallbackHandle>& ch,
69 const sp<Fence>& fence) {
70 if (ch == nullptr) {
71 return OK;
72 }
73 if (!ch->previousReleaseFence.get()) {
74 ch->previousReleaseFence = fence;
75 return OK;
76 }
77
78 // Below logic is lifted from ConsumerBase.cpp:
79 // Check status of fences first because merging is expensive.
80 // Merging an invalid fence with any other fence results in an
81 // invalid fence.
82 auto currentStatus = ch->previousReleaseFence->getStatus();
83 if (currentStatus == Fence::Status::Invalid) {
84 ALOGE("Existing fence has invalid state, layer: %s", mName.c_str());
85 return BAD_VALUE;
86 }
87
88 auto incomingStatus = fence->getStatus();
89 if (incomingStatus == Fence::Status::Invalid) {
90 ALOGE("New fence has invalid state, layer: %s", mName.c_str());
91 ch->previousReleaseFence = fence;
92 return BAD_VALUE;
93 }
94
95 // If both fences are signaled or both are unsignaled, we need to merge
96 // them to get an accurate timestamp.
97 if (currentStatus == incomingStatus) {
98 char fenceName[32] = {};
99 snprintf(fenceName, 32, "%.28s", mName.c_str());
100 sp<Fence> mergedFence = Fence::merge(
101 fenceName, ch->previousReleaseFence, fence);
102 if (!mergedFence.get()) {
103 ALOGE("failed to merge release fences, layer: %s", mName.c_str());
104 // synchronization is broken, the best we can do is hope fences
105 // signal in order so the new fence will act like a union
106 ch->previousReleaseFence = fence;
107 return BAD_VALUE;
108 }
109 ch->previousReleaseFence = mergedFence;
110 } else if (incomingStatus == Fence::Status::Unsignaled) {
111 // If one fence has signaled and the other hasn't, the unsignaled
112 // fence will approximately correspond with the correct timestamp.
113 // There's a small race if both fences signal at about the same time
114 // and their statuses are retrieved with unfortunate timing. However,
115 // by this point, they will have both signaled and only the timestamp
116 // will be slightly off; any dependencies after this point will
117 // already have been met.
118 ch->previousReleaseFence = fence;
119 }
120 // else if (currentStatus == Fence::Status::Unsignaled) is a no-op.
121
122 return OK;
123}
124
Marissa Wall61c58622018-07-18 10:12:20 -0700125// -----------------------------------------------------------------------
126// Interface implementation for Layer
127// -----------------------------------------------------------------------
Marissa Wallfda30bb2018-10-12 11:34:28 -0700128void BufferStateLayer::onLayerDisplayed(const sp<Fence>& releaseFence) {
Robert Carr8d958532020-11-10 14:09:16 -0800129 if (!releaseFence->isValid()) {
130 return;
131 }
Marissa Wall5a68a772018-12-22 17:43:42 -0800132 // The previous release fence notifies the client that SurfaceFlinger is done with the previous
133 // buffer that was presented on this layer. The first transaction that came in this frame that
134 // replaced the previous buffer on this layer needs this release fence, because the fence will
135 // let the client know when that previous buffer is removed from the screen.
136 //
137 // Every other transaction on this layer does not need a release fence because no other
138 // Transactions that were set on this layer this frame are going to have their preceeding buffer
139 // removed from the display this frame.
140 //
141 // For example, if we have 3 transactions this frame. The first transaction doesn't contain a
142 // buffer so it doesn't need a previous release fence because the layer still needs the previous
143 // buffer. The second transaction contains a buffer so it needs a previous release fence because
144 // the previous buffer will be released this frame. The third transaction also contains a
145 // buffer. It replaces the buffer in the second transaction. The buffer in the second
146 // transaction will now no longer be presented so it is released immediately and the third
147 // transaction doesn't need a previous release fence.
Robert Carr8d958532020-11-10 14:09:16 -0800148 sp<CallbackHandle> ch;
Marissa Wall5a68a772018-12-22 17:43:42 -0800149 for (auto& handle : mDrawingState.callbackHandles) {
150 if (handle->releasePreviousBuffer) {
Robert Carr8d958532020-11-10 14:09:16 -0800151 ch = handle;
Marissa Wall5a68a772018-12-22 17:43:42 -0800152 break;
153 }
154 }
Robert Carr8d958532020-11-10 14:09:16 -0800155 auto status = addReleaseFence(ch, releaseFence);
156 if (status != OK) {
157 ALOGE("Failed to add release fence for layer %s", getName().c_str());
158 }
Mikael Pessa2e1608f2019-07-19 11:25:35 -0700159
Valerie Haubf784642020-01-29 07:25:23 -0800160 mPreviousReleaseFence = releaseFence;
161
Mikael Pessa2e1608f2019-07-19 11:25:35 -0700162 // Prevent tracing the same release multiple times.
163 if (mPreviousFrameNumber != mPreviousReleasedFrameNumber) {
Mikael Pessa2e1608f2019-07-19 11:25:35 -0700164 mPreviousReleasedFrameNumber = mPreviousFrameNumber;
165 }
Marissa Wall61c58622018-07-18 10:12:20 -0700166}
167
Jorim Jaggi9c03b502020-11-24 23:51:31 +0100168void BufferStateLayer::onSurfaceFrameCreated(
169 const std::shared_ptr<frametimeline::SurfaceFrame>& surfaceFrame) {
170 mPendingJankClassifications.emplace_back(surfaceFrame);
171}
172
Valerie Haubf784642020-01-29 07:25:23 -0800173void BufferStateLayer::releasePendingBuffer(nsecs_t dequeueReadyTime) {
Valerie Hau32cdc1f2019-10-21 14:45:54 -0700174 for (const auto& handle : mDrawingState.callbackHandles) {
175 handle->transformHint = mTransformHint;
Valerie Hau871d6352020-01-29 08:44:02 -0800176 handle->dequeueReadyTime = dequeueReadyTime;
Valerie Hau32cdc1f2019-10-21 14:45:54 -0700177 }
178
Jorim Jaggi9c03b502020-11-24 23:51:31 +0100179 std::vector<JankData> jankData;
180 jankData.reserve(mPendingJankClassifications.size());
181 while (!mPendingJankClassifications.empty()
182 && mPendingJankClassifications.front()->getJankType()) {
183 std::shared_ptr<frametimeline::SurfaceFrame> surfaceFrame =
184 mPendingJankClassifications.front();
185 mPendingJankClassifications.pop_front();
186 jankData.emplace_back(
187 JankData(surfaceFrame->getToken(), surfaceFrame->getJankType().value()));
188 }
189
Marissa Wallefb71af2019-06-27 14:45:53 -0700190 mFlinger->getTransactionCompletedThread().finalizePendingCallbackHandles(
Jorim Jaggi9c03b502020-11-24 23:51:31 +0100191 mDrawingState.callbackHandles, jankData);
Marissa Wall5a68a772018-12-22 17:43:42 -0800192
193 mDrawingState.callbackHandles = {};
Valerie Haubf784642020-01-29 07:25:23 -0800194
195 const sp<Fence>& releaseFence(mPreviousReleaseFence);
196 std::shared_ptr<FenceTime> releaseFenceTime = std::make_shared<FenceTime>(releaseFence);
197 {
198 Mutex::Autolock lock(mFrameEventHistoryMutex);
199 if (mPreviousFrameNumber != 0) {
200 mFrameEventHistory.addRelease(mPreviousFrameNumber, dequeueReadyTime,
201 std::move(releaseFenceTime));
202 }
203 }
Marissa Wall61c58622018-07-18 10:12:20 -0700204}
205
Valerie Hau871d6352020-01-29 08:44:02 -0800206void BufferStateLayer::finalizeFrameEventHistory(const std::shared_ptr<FenceTime>& glDoneFence,
207 const CompositorTiming& compositorTiming) {
208 for (const auto& handle : mDrawingState.callbackHandles) {
209 handle->gpuCompositionDoneFence = glDoneFence;
210 handle->compositorTiming = compositorTiming;
211 }
212}
213
Ana Krulec010d2192018-10-08 06:29:54 -0700214bool BufferStateLayer::shouldPresentNow(nsecs_t /*expectedPresentTime*/) const {
Marissa Wall61c58622018-07-18 10:12:20 -0700215 if (getSidebandStreamChanged() || getAutoRefresh()) {
216 return true;
217 }
218
Marissa Wall024a1912018-08-13 13:55:35 -0700219 return hasFrameUpdate();
Marissa Wall61c58622018-07-18 10:12:20 -0700220}
221
Marissa Walle2ffb422018-10-12 11:33:52 -0700222bool BufferStateLayer::willPresentCurrentTransaction() const {
223 // Returns true if the most recent Transaction applied to CurrentState will be presented.
Robert Carr321e83c2019-08-19 15:49:30 -0700224 return (getSidebandStreamChanged() || getAutoRefresh() ||
Valerie Hauaa194562019-02-05 16:21:38 -0800225 (mCurrentState.modified &&
Robert Carr321e83c2019-08-19 15:49:30 -0700226 (mCurrentState.buffer != nullptr || mCurrentState.bgColorLayer != nullptr))) &&
227 !mLayerDetached;
Marissa Wall61c58622018-07-18 10:12:20 -0700228}
229
Valerie Hau3282b3c2020-02-03 15:37:27 -0800230/* TODO: vhau uncomment once deferred transaction migration complete in
231 * WindowManager
Lloyd Pique0449b0f2018-12-20 16:23:45 -0800232void BufferStateLayer::pushPendingState() {
233 if (!mCurrentState.modified) {
Marissa Wall61c58622018-07-18 10:12:20 -0700234 return;
235 }
Lloyd Pique0449b0f2018-12-20 16:23:45 -0800236 mPendingStates.push_back(mCurrentState);
Dominik Laskowski87a07e42019-10-10 20:38:02 -0700237 ATRACE_INT(mTransactionName.c_str(), mPendingStates.size());
Marissa Wall61c58622018-07-18 10:12:20 -0700238}
Valerie Hau3282b3c2020-02-03 15:37:27 -0800239*/
Marissa Wall61c58622018-07-18 10:12:20 -0700240
241bool BufferStateLayer::applyPendingStates(Layer::State* stateToCommit) {
Valerie Hau3282b3c2020-02-03 15:37:27 -0800242 mCurrentStateModified = mCurrentState.modified;
243 bool stateUpdateAvailable = Layer::applyPendingStates(stateToCommit);
Ady Abraham22c7b5c2020-09-22 19:33:40 -0700244 if (stateUpdateAvailable && mCallbackHandleAcquireTime != -1) {
Ady Abraham7f8a1e62020-09-28 16:09:35 -0700245 // Update the acquire fence time if we have a buffer
246 mSurfaceFrame->setAcquireFenceTime(mCallbackHandleAcquireTime);
Ady Abraham22c7b5c2020-09-22 19:33:40 -0700247 }
Valerie Hau3282b3c2020-02-03 15:37:27 -0800248 mCurrentStateModified = stateUpdateAvailable && mCurrentStateModified;
Lloyd Pique0449b0f2018-12-20 16:23:45 -0800249 mCurrentState.modified = false;
Marissa Wall61c58622018-07-18 10:12:20 -0700250 return stateUpdateAvailable;
251}
252
Marissa Wall861616d2018-10-22 12:52:23 -0700253// Crop that applies to the window
254Rect BufferStateLayer::getCrop(const Layer::State& /*s*/) const {
255 return Rect::INVALID_RECT;
Marissa Wall61c58622018-07-18 10:12:20 -0700256}
257
258bool BufferStateLayer::setTransform(uint32_t transform) {
Lloyd Pique0449b0f2018-12-20 16:23:45 -0800259 if (mCurrentState.transform == transform) return false;
Lloyd Pique0449b0f2018-12-20 16:23:45 -0800260 mCurrentState.transform = transform;
261 mCurrentState.modified = true;
Marissa Wall61c58622018-07-18 10:12:20 -0700262 setTransactionFlags(eTransactionNeeded);
263 return true;
264}
265
266bool BufferStateLayer::setTransformToDisplayInverse(bool transformToDisplayInverse) {
Lloyd Pique0449b0f2018-12-20 16:23:45 -0800267 if (mCurrentState.transformToDisplayInverse == transformToDisplayInverse) return false;
268 mCurrentState.sequence++;
269 mCurrentState.transformToDisplayInverse = transformToDisplayInverse;
270 mCurrentState.modified = true;
Marissa Wall61c58622018-07-18 10:12:20 -0700271 setTransactionFlags(eTransactionNeeded);
272 return true;
273}
274
275bool BufferStateLayer::setCrop(const Rect& crop) {
Marissa Wall290ad082019-03-06 13:23:47 -0800276 Rect c = crop;
277 if (c.left < 0) {
278 c.left = 0;
279 }
280 if (c.top < 0) {
281 c.top = 0;
282 }
283 // If the width and/or height are < 0, make it [0, 0, -1, -1] so the equality comparision below
284 // treats all invalid rectangles the same.
285 if (!c.isValid()) {
286 c.makeInvalid();
287 }
288
289 if (mCurrentState.crop == c) return false;
Marissa Wall290ad082019-03-06 13:23:47 -0800290 mCurrentState.crop = c;
Lloyd Pique0449b0f2018-12-20 16:23:45 -0800291 mCurrentState.modified = true;
Marissa Wall61c58622018-07-18 10:12:20 -0700292 setTransactionFlags(eTransactionNeeded);
293 return true;
294}
295
Marissa Wall861616d2018-10-22 12:52:23 -0700296bool BufferStateLayer::setFrame(const Rect& frame) {
297 int x = frame.left;
298 int y = frame.top;
299 int w = frame.getWidth();
300 int h = frame.getHeight();
301
Marissa Wall0f3242d2018-12-20 15:10:22 -0800302 if (x < 0) {
303 x = 0;
304 w = frame.right;
305 }
306
307 if (y < 0) {
308 y = 0;
309 h = frame.bottom;
310 }
311
Lloyd Pique0449b0f2018-12-20 16:23:45 -0800312 if (mCurrentState.active.transform.tx() == x && mCurrentState.active.transform.ty() == y &&
313 mCurrentState.active.w == w && mCurrentState.active.h == h) {
Marissa Wall861616d2018-10-22 12:52:23 -0700314 return false;
315 }
316
317 if (!frame.isValid()) {
318 x = y = w = h = 0;
319 }
Lloyd Pique0449b0f2018-12-20 16:23:45 -0800320 mCurrentState.active.transform.set(x, y);
321 mCurrentState.active.w = w;
322 mCurrentState.active.h = h;
Marissa Wall861616d2018-10-22 12:52:23 -0700323
Lloyd Pique0449b0f2018-12-20 16:23:45 -0800324 mCurrentState.sequence++;
325 mCurrentState.modified = true;
Marissa Wall861616d2018-10-22 12:52:23 -0700326 setTransactionFlags(eTransactionNeeded);
327 return true;
328}
329
Valerie Hau871d6352020-01-29 08:44:02 -0800330bool BufferStateLayer::addFrameEvent(const sp<Fence>& acquireFence, nsecs_t postedTime,
331 nsecs_t desiredPresentTime) {
Valerie Haubf784642020-01-29 07:25:23 -0800332 Mutex::Autolock lock(mFrameEventHistoryMutex);
333 mAcquireTimeline.updateSignalTimes();
334 std::shared_ptr<FenceTime> acquireFenceTime =
335 std::make_shared<FenceTime>((acquireFence ? acquireFence : Fence::NO_FENCE));
336 NewFrameEventsEntry newTimestamps = {mCurrentState.frameNumber, postedTime, desiredPresentTime,
337 acquireFenceTime};
Valerie Hau871d6352020-01-29 08:44:02 -0800338 mFrameEventHistory.setProducerWantsEvents();
Valerie Haubf784642020-01-29 07:25:23 -0800339 mFrameEventHistory.addQueue(newTimestamps);
340 return true;
341}
342
343bool BufferStateLayer::setBuffer(const sp<GraphicBuffer>& buffer, const sp<Fence>& acquireFence,
344 nsecs_t postTime, nsecs_t desiredPresentTime,
Vishnu Nair6b7c5c92020-09-29 17:27:05 -0700345 const client_cache_t& clientCacheId, uint64_t frameNumber) {
Robert Carr0c1966e2020-10-19 12:12:08 -0700346 ATRACE_CALL();
347
Lloyd Pique0449b0f2018-12-20 16:23:45 -0800348 if (mCurrentState.buffer) {
Marissa Wallfda30bb2018-10-12 11:34:28 -0700349 mReleasePreviousBuffer = true;
350 }
351
Vishnu Nair6b7c5c92020-09-29 17:27:05 -0700352 mCurrentState.frameNumber = frameNumber;
Valerie Hau2f54d642020-01-22 09:37:03 -0800353
Lloyd Pique0449b0f2018-12-20 16:23:45 -0800354 mCurrentState.buffer = buffer;
Marissa Wall947d34e2019-03-29 14:03:53 -0700355 mCurrentState.clientCacheId = clientCacheId;
Lloyd Pique0449b0f2018-12-20 16:23:45 -0800356 mCurrentState.modified = true;
Marissa Wall61c58622018-07-18 10:12:20 -0700357 setTransactionFlags(eTransactionNeeded);
Ady Abraham09bd3922019-04-08 10:44:56 -0700358
Yiwei Zhang1a88c402019-11-18 10:43:58 -0800359 const int32_t layerId = getSequence();
Valerie Hau134651a2020-01-28 16:21:22 -0800360 mFlinger->mTimeStats->setPostTime(layerId, mCurrentState.frameNumber, getName().c_str(),
Alec Mouri9a29e672020-09-14 12:39:14 -0700361 mOwnerUid, postTime);
Valerie Hau871d6352020-01-29 08:44:02 -0800362 desiredPresentTime = desiredPresentTime <= 0 ? 0 : desiredPresentTime;
chaviwfa67b552019-08-12 16:51:55 -0700363 mCurrentState.desiredPresentTime = desiredPresentTime;
Ady Abraham09bd3922019-04-08 10:44:56 -0700364
Ady Abraham5def7332020-05-29 16:13:47 -0700365 mFlinger->mScheduler->recordLayerHistory(this, desiredPresentTime,
366 LayerHistory::LayerUpdateType::Buffer);
Ady Abraham09bd3922019-04-08 10:44:56 -0700367
Valerie Hau871d6352020-01-29 08:44:02 -0800368 addFrameEvent(acquireFence, postTime, desiredPresentTime);
Marissa Wall61c58622018-07-18 10:12:20 -0700369 return true;
370}
371
372bool BufferStateLayer::setAcquireFence(const sp<Fence>& fence) {
Marissa Wallfda30bb2018-10-12 11:34:28 -0700373 // The acquire fences of BufferStateLayers have already signaled before they are set
374 mCallbackHandleAcquireTime = fence->getSignalTime();
375
Lloyd Pique0449b0f2018-12-20 16:23:45 -0800376 mCurrentState.acquireFence = fence;
377 mCurrentState.modified = true;
Marissa Wall61c58622018-07-18 10:12:20 -0700378 setTransactionFlags(eTransactionNeeded);
379 return true;
380}
381
382bool BufferStateLayer::setDataspace(ui::Dataspace dataspace) {
Lloyd Pique0449b0f2018-12-20 16:23:45 -0800383 if (mCurrentState.dataspace == dataspace) return false;
Lloyd Pique0449b0f2018-12-20 16:23:45 -0800384 mCurrentState.dataspace = dataspace;
385 mCurrentState.modified = true;
Marissa Wall61c58622018-07-18 10:12:20 -0700386 setTransactionFlags(eTransactionNeeded);
387 return true;
388}
389
390bool BufferStateLayer::setHdrMetadata(const HdrMetadata& hdrMetadata) {
Lloyd Pique0449b0f2018-12-20 16:23:45 -0800391 if (mCurrentState.hdrMetadata == hdrMetadata) return false;
Lloyd Pique0449b0f2018-12-20 16:23:45 -0800392 mCurrentState.hdrMetadata = hdrMetadata;
393 mCurrentState.modified = true;
Marissa Wall61c58622018-07-18 10:12:20 -0700394 setTransactionFlags(eTransactionNeeded);
395 return true;
396}
397
398bool BufferStateLayer::setSurfaceDamageRegion(const Region& surfaceDamage) {
Lloyd Pique0449b0f2018-12-20 16:23:45 -0800399 mCurrentState.surfaceDamageRegion = surfaceDamage;
400 mCurrentState.modified = true;
Marissa Wall61c58622018-07-18 10:12:20 -0700401 setTransactionFlags(eTransactionNeeded);
402 return true;
403}
404
405bool BufferStateLayer::setApi(int32_t api) {
Lloyd Pique0449b0f2018-12-20 16:23:45 -0800406 if (mCurrentState.api == api) return false;
Lloyd Pique0449b0f2018-12-20 16:23:45 -0800407 mCurrentState.api = api;
408 mCurrentState.modified = true;
Marissa Wall61c58622018-07-18 10:12:20 -0700409 setTransactionFlags(eTransactionNeeded);
410 return true;
411}
412
413bool BufferStateLayer::setSidebandStream(const sp<NativeHandle>& sidebandStream) {
Lloyd Pique0449b0f2018-12-20 16:23:45 -0800414 if (mCurrentState.sidebandStream == sidebandStream) return false;
Lloyd Pique0449b0f2018-12-20 16:23:45 -0800415 mCurrentState.sidebandStream = sidebandStream;
416 mCurrentState.modified = true;
Marissa Wall61c58622018-07-18 10:12:20 -0700417 setTransactionFlags(eTransactionNeeded);
418
419 if (!mSidebandStreamChanged.exchange(true)) {
420 // mSidebandStreamChanged was false
421 mFlinger->signalLayerUpdate();
422 }
423 return true;
424}
425
Marissa Walle2ffb422018-10-12 11:33:52 -0700426bool BufferStateLayer::setTransactionCompletedListeners(
427 const std::vector<sp<CallbackHandle>>& handles) {
Marissa Wallfda30bb2018-10-12 11:34:28 -0700428 // If there is no handle, we will not send a callback so reset mReleasePreviousBuffer and return
Marissa Walle2ffb422018-10-12 11:33:52 -0700429 if (handles.empty()) {
Marissa Wallfda30bb2018-10-12 11:34:28 -0700430 mReleasePreviousBuffer = false;
Marissa Walle2ffb422018-10-12 11:33:52 -0700431 return false;
432 }
433
434 const bool willPresent = willPresentCurrentTransaction();
435
436 for (const auto& handle : handles) {
Marissa Wallfda30bb2018-10-12 11:34:28 -0700437 // If this transaction set a buffer on this layer, release its previous buffer
438 handle->releasePreviousBuffer = mReleasePreviousBuffer;
439
Marissa Walle2ffb422018-10-12 11:33:52 -0700440 // If this layer will be presented in this frame
441 if (willPresent) {
Marissa Wallfda30bb2018-10-12 11:34:28 -0700442 // If this transaction set an acquire fence on this layer, set its acquire time
443 handle->acquireTime = mCallbackHandleAcquireTime;
444
Marissa Walle2ffb422018-10-12 11:33:52 -0700445 // Notify the transaction completed thread that there is a pending latched callback
446 // handle
Marissa Wall5a68a772018-12-22 17:43:42 -0800447 mFlinger->getTransactionCompletedThread().registerPendingCallbackHandle(handle);
Marissa Walle2ffb422018-10-12 11:33:52 -0700448
449 // Store so latched time and release fence can be set
Lloyd Pique0449b0f2018-12-20 16:23:45 -0800450 mCurrentState.callbackHandles.push_back(handle);
Marissa Walle2ffb422018-10-12 11:33:52 -0700451
452 } else { // If this layer will NOT need to be relatched and presented this frame
453 // Notify the transaction completed thread this handle is done
Marissa Wallefb71af2019-06-27 14:45:53 -0700454 mFlinger->getTransactionCompletedThread().registerUnpresentedCallbackHandle(handle);
Marissa Walle2ffb422018-10-12 11:33:52 -0700455 }
456 }
457
Marissa Wallfda30bb2018-10-12 11:34:28 -0700458 mReleasePreviousBuffer = false;
459 mCallbackHandleAcquireTime = -1;
460
Marissa Walle2ffb422018-10-12 11:33:52 -0700461 return willPresent;
462}
463
Valerie Hau7618b232020-01-09 16:03:08 -0800464void BufferStateLayer::forceSendCallbacks() {
465 mFlinger->getTransactionCompletedThread().finalizePendingCallbackHandles(
Jorim Jaggi9c03b502020-11-24 23:51:31 +0100466 mCurrentState.callbackHandles, std::vector<JankData>());
Valerie Hau7618b232020-01-09 16:03:08 -0800467}
468
Marissa Wall61c58622018-07-18 10:12:20 -0700469bool BufferStateLayer::setTransparentRegionHint(const Region& transparent) {
Lloyd Pique0449b0f2018-12-20 16:23:45 -0800470 mCurrentState.transparentRegionHint = transparent;
471 mCurrentState.modified = true;
Marissa Wall61c58622018-07-18 10:12:20 -0700472 setTransactionFlags(eTransactionNeeded);
473 return true;
474}
475
Marissa Wall861616d2018-10-22 12:52:23 -0700476Rect BufferStateLayer::getBufferSize(const State& s) const {
477 // for buffer state layers we use the display frame size as the buffer size.
478 if (getActiveWidth(s) < UINT32_MAX && getActiveHeight(s) < UINT32_MAX) {
479 return Rect(getActiveWidth(s), getActiveHeight(s));
Marissa Wall61c58622018-07-18 10:12:20 -0700480 }
481
Marissa Wall861616d2018-10-22 12:52:23 -0700482 // if the display frame is not defined, use the parent bounds as the buffer size.
483 const auto& p = mDrawingParent.promote();
484 if (p != nullptr) {
Vishnu Nair4351ad52019-02-11 14:13:02 -0800485 Rect parentBounds = Rect(p->getBounds(Region()));
Marissa Wall861616d2018-10-22 12:52:23 -0700486 if (!parentBounds.isEmpty()) {
487 return parentBounds;
488 }
489 }
490
Marissa Wall861616d2018-10-22 12:52:23 -0700491 return Rect::INVALID_RECT;
Marissa Wall61c58622018-07-18 10:12:20 -0700492}
Vishnu Nair4351ad52019-02-11 14:13:02 -0800493
494FloatRect BufferStateLayer::computeSourceBounds(const FloatRect& parentBounds) const {
495 const State& s(getDrawingState());
496 // for buffer state layers we use the display frame size as the buffer size.
497 if (getActiveWidth(s) < UINT32_MAX && getActiveHeight(s) < UINT32_MAX) {
498 return FloatRect(0, 0, getActiveWidth(s), getActiveHeight(s));
499 }
500
501 // if the display frame is not defined, use the parent bounds as the buffer size.
502 return parentBounds;
503}
504
Marissa Wall61c58622018-07-18 10:12:20 -0700505// -----------------------------------------------------------------------
506
507// -----------------------------------------------------------------------
508// Interface implementation for BufferLayer
509// -----------------------------------------------------------------------
510bool BufferStateLayer::fenceHasSignaled() const {
Alec Mouri91f6df32020-01-30 08:48:58 -0800511 const bool fenceSignaled =
512 getDrawingState().acquireFence->getStatus() == Fence::Status::Signaled;
513 if (!fenceSignaled) {
514 mFlinger->mTimeStats->incrementLatchSkipped(getSequence(),
515 TimeStats::LatchSkipReason::LateAcquire);
516 }
517
518 return fenceSignaled;
Marissa Wall61c58622018-07-18 10:12:20 -0700519}
520
Dominik Laskowskia8955dd2019-07-10 10:19:09 -0700521bool BufferStateLayer::framePresentTimeIsCurrent(nsecs_t expectedPresentTime) const {
Ady Abrahamcd1580c2019-04-29 15:40:03 -0700522 if (!hasFrameUpdate() || isRemovedFromCurrentState()) {
523 return true;
524 }
525
chaviwfa67b552019-08-12 16:51:55 -0700526 return mCurrentState.desiredPresentTime <= expectedPresentTime;
Ady Abrahamcd1580c2019-04-29 15:40:03 -0700527}
528
Valerie Hau871d6352020-01-29 08:44:02 -0800529bool BufferStateLayer::onPreComposition(nsecs_t refreshStartTime) {
530 for (const auto& handle : mDrawingState.callbackHandles) {
531 handle->refreshStartTime = refreshStartTime;
532 }
533 return BufferLayer::onPreComposition(refreshStartTime);
534}
535
Dominik Laskowskia8955dd2019-07-10 10:19:09 -0700536uint64_t BufferStateLayer::getFrameNumber(nsecs_t /*expectedPresentTime*/) const {
Valerie Hau134651a2020-01-28 16:21:22 -0800537 return mDrawingState.frameNumber;
Marissa Wall61c58622018-07-18 10:12:20 -0700538}
539
Robert Carrfe1209c2020-02-11 12:25:35 -0800540/**
541 * This is the frameNumber used for deferred transaction signalling. We need to use this because
542 * of cases where we defer a transaction for a surface to itself. In the BLAST world this
543 * may not make a huge amount of sense (Why not just merge the Buffer transaction with the
544 * deferred transaction?) but this is an important legacy use case, for example moving
545 * a window at the same time it draws makes use of this kind of technique. So anyway
546 * imagine we have something like this:
547 *
548 * Transaction { // containing
549 * Buffer -> frameNumber = 2
550 * DeferTransactionUntil -> frameNumber = 2
551 * Random other stuff
552 * }
553 * Now imagine getHeadFrameNumber returned mDrawingState.mFrameNumber (or mCurrentFrameNumber).
554 * Prior to doTransaction SurfaceFlinger will call notifyAvailableFrames, but because we
555 * haven't swapped mCurrentState to mDrawingState yet we will think the sync point
556 * is not ready. So we will return false from applyPendingState and not swap
557 * current state to drawing state. But because we don't swap current state
558 * to drawing state the number will never update and we will be stuck. This way
559 * we can see we need to return the frame number for the buffer we are about
560 * to apply.
561 */
562uint64_t BufferStateLayer::getHeadFrameNumber(nsecs_t /* expectedPresentTime */) const {
563 return mCurrentState.frameNumber;
564}
565
Vishnu Naircf26a0a2020-11-13 12:56:20 -0800566void BufferStateLayer::setAutoRefresh(bool autoRefresh) {
567 if (!mAutoRefresh.exchange(autoRefresh)) {
568 mFlinger->signalLayerUpdate();
569 }
Marissa Wall61c58622018-07-18 10:12:20 -0700570}
571
Vishnu Nair6194e2e2019-02-06 12:58:39 -0800572bool BufferStateLayer::latchSidebandStream(bool& recomputeVisibleRegions) {
Marissa Wall61c58622018-07-18 10:12:20 -0700573 if (mSidebandStreamChanged.exchange(false)) {
574 const State& s(getDrawingState());
575 // mSidebandStreamChanged was true
Lloyd Pique0b785d82018-12-04 17:25:27 -0800576 mSidebandStream = s.sidebandStream;
Lloyd Piquede196652020-01-22 17:29:58 -0800577 editCompositionState()->sidebandStream = mSidebandStream;
Lloyd Pique0b785d82018-12-04 17:25:27 -0800578 if (mSidebandStream != nullptr) {
Marissa Wall61c58622018-07-18 10:12:20 -0700579 setTransactionFlags(eTransactionNeeded);
580 mFlinger->setTransactionFlags(eTraversalNeeded);
581 }
582 recomputeVisibleRegions = true;
583
Vishnu Nair6194e2e2019-02-06 12:58:39 -0800584 return true;
Marissa Wall61c58622018-07-18 10:12:20 -0700585 }
Vishnu Nair6194e2e2019-02-06 12:58:39 -0800586 return false;
Marissa Wall61c58622018-07-18 10:12:20 -0700587}
588
Lloyd Pique0449b0f2018-12-20 16:23:45 -0800589bool BufferStateLayer::hasFrameUpdate() const {
Valerie Hauaa194562019-02-05 16:21:38 -0800590 const State& c(getCurrentState());
591 return mCurrentStateModified && (c.buffer != nullptr || c.bgColorLayer != nullptr);
Marissa Wall61c58622018-07-18 10:12:20 -0700592}
593
Dominik Laskowskia8955dd2019-07-10 10:19:09 -0700594status_t BufferStateLayer::updateTexImage(bool& /*recomputeVisibleRegions*/, nsecs_t latchTime,
595 nsecs_t /*expectedPresentTime*/) {
Marissa Wall61c58622018-07-18 10:12:20 -0700596 const State& s(getDrawingState());
597
598 if (!s.buffer) {
Valerie Hauaa194562019-02-05 16:21:38 -0800599 if (s.bgColorLayer) {
600 for (auto& handle : mDrawingState.callbackHandles) {
601 handle->latchTime = latchTime;
602 }
603 }
Marissa Wall61c58622018-07-18 10:12:20 -0700604 return NO_ERROR;
605 }
606
Marissa Wall5a68a772018-12-22 17:43:42 -0800607 for (auto& handle : mDrawingState.callbackHandles) {
608 handle->latchTime = latchTime;
Valerie Hau871d6352020-01-29 08:44:02 -0800609 handle->frameNumber = mDrawingState.frameNumber;
Marissa Wall5a68a772018-12-22 17:43:42 -0800610 }
Marissa Walle2ffb422018-10-12 11:33:52 -0700611
Vishnu Nairea0de002020-11-17 17:42:37 -0800612 const int32_t layerId = getSequence();
Valerie Hau134651a2020-01-28 16:21:22 -0800613 mFlinger->mTimeStats->setAcquireFence(layerId, mDrawingState.frameNumber,
chaviw95631e32020-06-09 13:43:32 -0700614 std::make_shared<FenceTime>(mDrawingState.acquireFence));
Valerie Hau134651a2020-01-28 16:21:22 -0800615 mFlinger->mTimeStats->setLatchTime(layerId, mDrawingState.frameNumber, latchTime);
Marissa Wall61c58622018-07-18 10:12:20 -0700616
Marissa Wall16c112d2019-03-20 13:21:13 -0700617 mCurrentStateModified = false;
618
Marissa Wall61c58622018-07-18 10:12:20 -0700619 return NO_ERROR;
620}
621
622status_t BufferStateLayer::updateActiveBuffer() {
623 const State& s(getDrawingState());
624
625 if (s.buffer == nullptr) {
626 return BAD_VALUE;
627 }
628
Mikael Pessa2e1608f2019-07-19 11:25:35 -0700629 mPreviousBufferId = getCurrentBufferId();
chaviwd62d3062019-09-04 14:48:02 -0700630 mBufferInfo.mBuffer = s.buffer;
631 mBufferInfo.mFence = s.acquireFence;
Marissa Wall61c58622018-07-18 10:12:20 -0700632
633 return NO_ERROR;
634}
635
Valerie Haubf784642020-01-29 07:25:23 -0800636status_t BufferStateLayer::updateFrameNumber(nsecs_t latchTime) {
Marissa Wall61c58622018-07-18 10:12:20 -0700637 // TODO(marissaw): support frame history events
Mikael Pessa2e1608f2019-07-19 11:25:35 -0700638 mPreviousFrameNumber = mCurrentFrameNumber;
Valerie Hau134651a2020-01-28 16:21:22 -0800639 mCurrentFrameNumber = mDrawingState.frameNumber;
Valerie Haubf784642020-01-29 07:25:23 -0800640 {
641 Mutex::Autolock lock(mFrameEventHistoryMutex);
642 mFrameEventHistory.addLatch(mCurrentFrameNumber, latchTime);
643 }
Marissa Wall61c58622018-07-18 10:12:20 -0700644 return NO_ERROR;
645}
646
Marissa Wall947d34e2019-03-29 14:03:53 -0700647void BufferStateLayer::HwcSlotGenerator::bufferErased(const client_cache_t& clientCacheId) {
648 std::lock_guard lock(mMutex);
649 if (!clientCacheId.isValid()) {
650 ALOGE("invalid process, failed to erase buffer");
651 return;
652 }
653 eraseBufferLocked(clientCacheId);
654}
655
656uint32_t BufferStateLayer::HwcSlotGenerator::getHwcCacheSlot(const client_cache_t& clientCacheId) {
657 std::lock_guard<std::mutex> lock(mMutex);
658 auto itr = mCachedBuffers.find(clientCacheId);
659 if (itr == mCachedBuffers.end()) {
660 return addCachedBuffer(clientCacheId);
661 }
662 auto& [hwcCacheSlot, counter] = itr->second;
663 counter = mCounter++;
664 return hwcCacheSlot;
665}
666
667uint32_t BufferStateLayer::HwcSlotGenerator::addCachedBuffer(const client_cache_t& clientCacheId)
668 REQUIRES(mMutex) {
669 if (!clientCacheId.isValid()) {
670 ALOGE("invalid process, returning invalid slot");
671 return BufferQueue::INVALID_BUFFER_SLOT;
672 }
673
674 ClientCache::getInstance().registerErasedRecipient(clientCacheId, wp<ErasedRecipient>(this));
675
676 uint32_t hwcCacheSlot = getFreeHwcCacheSlot();
677 mCachedBuffers[clientCacheId] = {hwcCacheSlot, mCounter++};
678 return hwcCacheSlot;
679}
680
681uint32_t BufferStateLayer::HwcSlotGenerator::getFreeHwcCacheSlot() REQUIRES(mMutex) {
682 if (mFreeHwcCacheSlots.empty()) {
683 evictLeastRecentlyUsed();
684 }
685
686 uint32_t hwcCacheSlot = mFreeHwcCacheSlots.top();
687 mFreeHwcCacheSlots.pop();
688 return hwcCacheSlot;
689}
690
691void BufferStateLayer::HwcSlotGenerator::evictLeastRecentlyUsed() REQUIRES(mMutex) {
692 uint64_t minCounter = UINT_MAX;
693 client_cache_t minClientCacheId = {};
694 for (const auto& [clientCacheId, slotCounter] : mCachedBuffers) {
695 const auto& [hwcCacheSlot, counter] = slotCounter;
696 if (counter < minCounter) {
697 minCounter = counter;
698 minClientCacheId = clientCacheId;
699 }
700 }
701 eraseBufferLocked(minClientCacheId);
702
703 ClientCache::getInstance().unregisterErasedRecipient(minClientCacheId, this);
704}
705
706void BufferStateLayer::HwcSlotGenerator::eraseBufferLocked(const client_cache_t& clientCacheId)
707 REQUIRES(mMutex) {
708 auto itr = mCachedBuffers.find(clientCacheId);
709 if (itr == mCachedBuffers.end()) {
710 return;
711 }
712 auto& [hwcCacheSlot, counter] = itr->second;
713
714 // TODO send to hwc cache and resources
715
716 mFreeHwcCacheSlots.push(hwcCacheSlot);
717 mCachedBuffers.erase(clientCacheId);
718}
chaviw4244e032019-09-04 11:27:49 -0700719
720void BufferStateLayer::gatherBufferInfo() {
chaviwdebadb82020-03-26 14:57:24 -0700721 BufferLayer::gatherBufferInfo();
chaviw4244e032019-09-04 11:27:49 -0700722
chaviwdebadb82020-03-26 14:57:24 -0700723 const State& s(getDrawingState());
chaviw4244e032019-09-04 11:27:49 -0700724 mBufferInfo.mDesiredPresentTime = s.desiredPresentTime;
725 mBufferInfo.mFenceTime = std::make_shared<FenceTime>(s.acquireFence);
726 mBufferInfo.mFence = s.acquireFence;
chaviw4244e032019-09-04 11:27:49 -0700727 mBufferInfo.mTransform = s.transform;
728 mBufferInfo.mDataspace = translateDataspace(s.dataspace);
729 mBufferInfo.mCrop = computeCrop(s);
730 mBufferInfo.mScaleMode = NATIVE_WINDOW_SCALING_MODE_SCALE_TO_WINDOW;
731 mBufferInfo.mSurfaceDamage = s.surfaceDamageRegion;
732 mBufferInfo.mHdrMetadata = s.hdrMetadata;
733 mBufferInfo.mApi = s.api;
chaviw4244e032019-09-04 11:27:49 -0700734 mBufferInfo.mTransformToDisplayInverse = s.transformToDisplayInverse;
chaviwf83ce182019-09-12 14:43:08 -0700735 mBufferInfo.mBufferSlot = mHwcSlotGenerator->getHwcCacheSlot(s.clientCacheId);
chaviw4244e032019-09-04 11:27:49 -0700736}
737
Robert Carr916b0362020-10-06 13:53:03 -0700738uint32_t BufferStateLayer::getEffectiveScalingMode() const {
739 return NATIVE_WINDOW_SCALING_MODE_SCALE_TO_WINDOW;
740}
741
chaviw4244e032019-09-04 11:27:49 -0700742Rect BufferStateLayer::computeCrop(const State& s) {
743 if (s.crop.isEmpty() && s.buffer) {
744 return s.buffer->getBounds();
745 } else if (s.buffer) {
746 Rect crop = s.crop;
747 crop.left = std::max(crop.left, 0);
748 crop.top = std::max(crop.top, 0);
749 uint32_t bufferWidth = s.buffer->getWidth();
750 uint32_t bufferHeight = s.buffer->getHeight();
751 if (bufferHeight <= std::numeric_limits<int32_t>::max() &&
752 bufferWidth <= std::numeric_limits<int32_t>::max()) {
753 crop.right = std::min(crop.right, static_cast<int32_t>(bufferWidth));
754 crop.bottom = std::min(crop.bottom, static_cast<int32_t>(bufferHeight));
755 }
756 if (!crop.isValid()) {
757 // Crop rect is out of bounds, return whole buffer
758 return s.buffer->getBounds();
759 }
760 return crop;
761 }
762 return s.crop;
763}
764
chaviwb4c6e582019-08-16 14:35:07 -0700765sp<Layer> BufferStateLayer::createClone() {
Dominik Laskowski87a07e42019-10-10 20:38:02 -0700766 LayerCreationArgs args(mFlinger.get(), nullptr, mName + " (Mirror)", 0, 0, 0, LayerMetadata());
chaviwb4c6e582019-08-16 14:35:07 -0700767 args.textureName = mTextureName;
Lloyd Pique1c3a5eb2019-10-03 13:07:08 -0700768 sp<BufferStateLayer> layer = mFlinger->getFactory().createBufferStateLayer(args);
chaviwb4c6e582019-08-16 14:35:07 -0700769 layer->mHwcSlotGenerator = mHwcSlotGenerator;
770 layer->setInitialValuesForClone(this);
771 return layer;
772}
Valerie Hau92bf5482020-02-10 09:49:08 -0800773
774Layer::RoundedCornerState BufferStateLayer::getRoundedCornerState() const {
775 const auto& p = mDrawingParent.promote();
776 if (p != nullptr) {
777 RoundedCornerState parentState = p->getRoundedCornerState();
778 if (parentState.radius > 0) {
779 ui::Transform t = getActiveTransform(getDrawingState());
780 t = t.inverse();
781 parentState.cropRect = t.transform(parentState.cropRect);
782 // The rounded corners shader only accepts 1 corner radius for performance reasons,
783 // but a transform matrix can define horizontal and vertical scales.
784 // Let's take the average between both of them and pass into the shader, practically we
785 // never do this type of transformation on windows anyway.
786 parentState.radius *= (t[0][0] + t[1][1]) / 2.0f;
787 return parentState;
788 }
789 }
790 const float radius = getDrawingState().cornerRadius;
791 const State& s(getDrawingState());
792 if (radius <= 0 || (getActiveWidth(s) == UINT32_MAX && getActiveHeight(s) == UINT32_MAX))
793 return RoundedCornerState();
794 return RoundedCornerState(FloatRect(static_cast<float>(s.active.transform.tx()),
795 static_cast<float>(s.active.transform.ty()),
796 static_cast<float>(s.active.transform.tx() + s.active.w),
797 static_cast<float>(s.active.transform.ty() + s.active.h)),
798 radius);
799}
Vishnu Naire7f79c52020-10-29 14:45:03 -0700800
801bool BufferStateLayer::bufferNeedsFiltering() const {
802 const State& s(getDrawingState());
803 if (!s.buffer) {
804 return false;
805 }
806
807 uint32_t bufferWidth = s.buffer->width;
808 uint32_t bufferHeight = s.buffer->height;
809
810 // Undo any transformations on the buffer and return the result.
811 if (s.transform & ui::Transform::ROT_90) {
812 std::swap(bufferWidth, bufferHeight);
813 }
814
815 if (s.transformToDisplayInverse) {
816 uint32_t invTransform = DisplayDevice::getPrimaryDisplayRotationFlags();
817 if (invTransform & ui::Transform::ROT_90) {
818 std::swap(bufferWidth, bufferHeight);
819 }
820 }
821
822 const Rect layerSize{getBounds()};
823 return layerSize.width() != bufferWidth || layerSize.height() != bufferHeight;
824}
Marissa Wall61c58622018-07-18 10:12:20 -0700825} // namespace android
Ady Abrahamb0dbdaa2020-01-06 16:19:42 -0800826
827// TODO(b/129481165): remove the #pragma below and fix conversion issues
828#pragma clang diagnostic pop // ignored "-Wconversion"