blob: 9fd687c6e79653d20c26baf73bd494a3614d55bb [file] [log] [blame]
Adithya Srinivasanf279e042020-08-17 14:56:27 -07001/*
2 * Copyright 2020 The Android Open Source Project
3 *
4 * Licensed under the Apache License, Version 2.0 (the "License");
5 * you may not use this file except in compliance with the License.
6 * You may obtain a copy of the License at
7 *
8 * http://www.apache.org/licenses/LICENSE-2.0
9 *
10 * Unless required by applicable law or agreed to in writing, software
11 * distributed under the License is distributed on an "AS IS" BASIS,
12 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
13 * See the License for the specific language governing permissions and
14 * limitations under the License.
15 */
16
Ady Abraham3db8a3c2023-11-20 17:53:47 -080017#include <common/test/FlagUtils.h>
Sally Qif5721252023-11-17 11:14:53 -080018#include "com_android_graphics_surfaceflinger_flags.h"
Alec Mouri9a29e672020-09-14 12:39:14 -070019#include "gmock/gmock-spec-builders.h"
20#include "mock/MockTimeStats.h"
Adithya Srinivasanf279e042020-08-17 14:56:27 -070021#undef LOG_TAG
22#define LOG_TAG "LibSurfaceFlingerUnittests"
23
24#include <FrameTimeline/FrameTimeline.h>
25#include <gtest/gtest.h>
26#include <log/log.h>
Adithya Srinivasan01189672020-10-20 14:23:05 -070027#include <perfetto/trace/trace.pb.h>
Adithya Srinivasanf279e042020-08-17 14:56:27 -070028#include <cinttypes>
29
30using namespace std::chrono_literals;
Alec Mouri363faf02021-01-29 16:34:55 -080031using testing::_;
Adithya Srinivasan9b2ca3e2020-11-10 10:14:17 -080032using testing::AtLeast;
Alec Mouri9a29e672020-09-14 12:39:14 -070033using testing::Contains;
Adithya Srinivasan01189672020-10-20 14:23:05 -070034using FrameTimelineEvent = perfetto::protos::FrameTimelineEvent;
Adithya Srinivasan05bd2d12021-01-11 18:49:58 +000035using ProtoExpectedDisplayFrameStart =
36 perfetto::protos::FrameTimelineEvent_ExpectedDisplayFrameStart;
37using ProtoExpectedSurfaceFrameStart =
38 perfetto::protos::FrameTimelineEvent_ExpectedSurfaceFrameStart;
39using ProtoActualDisplayFrameStart = perfetto::protos::FrameTimelineEvent_ActualDisplayFrameStart;
40using ProtoActualSurfaceFrameStart = perfetto::protos::FrameTimelineEvent_ActualSurfaceFrameStart;
41using ProtoFrameEnd = perfetto::protos::FrameTimelineEvent_FrameEnd;
Adithya Srinivasan01189672020-10-20 14:23:05 -070042using ProtoPresentType = perfetto::protos::FrameTimelineEvent_PresentType;
43using ProtoJankType = perfetto::protos::FrameTimelineEvent_JankType;
Ying Wei96eb5352023-11-21 17:37:21 +000044using ProtoJankSeverityType = perfetto::protos::FrameTimelineEvent_JankSeverityType;
Adithya Srinivasan78e58af2021-02-25 00:08:08 +000045using ProtoPredictionType = perfetto::protos::FrameTimelineEvent_PredictionType;
Alec Mouri9a29e672020-09-14 12:39:14 -070046
Adithya Srinivasanf279e042020-08-17 14:56:27 -070047namespace android::frametimeline {
48
Ady Abraham57a8ab42023-01-26 15:28:19 -080049static const std::string sLayerNameOne = "layer1";
50static const std::string sLayerNameTwo = "layer2";
51
52constexpr const uid_t sUidOne = 0;
53constexpr pid_t sPidOne = 10;
54constexpr pid_t sPidTwo = 20;
55constexpr int32_t sInputEventId = 5;
56constexpr int32_t sLayerIdOne = 1;
57constexpr int32_t sLayerIdTwo = 2;
58constexpr GameMode sGameMode = GameMode::Unsupported;
Pascal Muetschardac7bcd92023-10-03 15:05:36 +020059constexpr Fps RR_11 = Fps::fromPeriodNsecs(11);
60constexpr Fps RR_30 = Fps::fromPeriodNsecs(30);
Ady Abraham57a8ab42023-01-26 15:28:19 -080061
Adithya Srinivasanf279e042020-08-17 14:56:27 -070062class FrameTimelineTest : public testing::Test {
63public:
64 FrameTimelineTest() {
65 const ::testing::TestInfo* const test_info =
66 ::testing::UnitTest::GetInstance()->current_test_info();
67 ALOGD("**** Setting up for %s.%s\n", test_info->test_case_name(), test_info->name());
68 }
69
70 ~FrameTimelineTest() {
71 const ::testing::TestInfo* const test_info =
72 ::testing::UnitTest::GetInstance()->current_test_info();
73 ALOGD("**** Tearing down after %s.%s\n", test_info->test_case_name(), test_info->name());
74 }
75
Adithya Srinivasan01189672020-10-20 14:23:05 -070076 static void SetUpTestSuite() {
77 // Need to initialize tracing in process for testing, and only once per test suite.
78 perfetto::TracingInitArgs args;
79 args.backends = perfetto::kInProcessBackend;
80 perfetto::Tracing::Initialize(args);
81 }
82
Adithya Srinivasanf279e042020-08-17 14:56:27 -070083 void SetUp() override {
Ady Abraham57f8e182022-03-08 15:54:33 -080084 constexpr bool kUseBootTimeClock = true;
Alec Mouri9a29e672020-09-14 12:39:14 -070085 mTimeStats = std::make_shared<mock::TimeStats>();
Adithya Srinivasan05bd2d12021-01-11 18:49:58 +000086 mFrameTimeline = std::make_unique<impl::FrameTimeline>(mTimeStats, kSurfaceFlingerPid,
Ady Abraham57f8e182022-03-08 15:54:33 -080087 kTestThresholds, !kUseBootTimeClock);
Adithya Srinivasan01189672020-10-20 14:23:05 -070088 mFrameTimeline->registerDataSource();
Adithya Srinivasanf279e042020-08-17 14:56:27 -070089 mTokenManager = &mFrameTimeline->mTokenManager;
Adithya Srinivasan05bd2d12021-01-11 18:49:58 +000090 mTraceCookieCounter = &mFrameTimeline->mTraceCookieCounter;
Adithya Srinivasan2d736322020-10-01 16:53:48 -070091 maxDisplayFrames = &mFrameTimeline->mMaxDisplayFrames;
Adithya Srinivasanbed4c4f2021-05-03 20:24:46 +000092 maxTokens = mTokenManager->kMaxTokens;
Adithya Srinivasanf279e042020-08-17 14:56:27 -070093 }
94
Adithya Srinivasan01189672020-10-20 14:23:05 -070095 // Each tracing session can be used for a single block of Start -> Stop.
96 static std::unique_ptr<perfetto::TracingSession> getTracingSessionForTest() {
97 perfetto::TraceConfig cfg;
98 cfg.set_duration_ms(500);
99 cfg.add_buffers()->set_size_kb(1024);
100 auto* ds_cfg = cfg.add_data_sources()->mutable_config();
101 ds_cfg->set_name(impl::FrameTimeline::kFrameTimelineDataSource);
102
103 auto tracingSession = perfetto::Tracing::NewTrace(perfetto::kInProcessBackend);
104 tracingSession->Setup(cfg);
105 return tracingSession;
106 }
107
108 std::vector<perfetto::protos::TracePacket> readFrameTimelinePacketsBlocking(
109 perfetto::TracingSession* tracingSession) {
110 std::vector<char> raw_trace = tracingSession->ReadTraceBlocking();
111 perfetto::protos::Trace trace;
112 EXPECT_TRUE(trace.ParseFromArray(raw_trace.data(), int(raw_trace.size())));
113
114 std::vector<perfetto::protos::TracePacket> packets;
115 for (const auto& packet : trace.packet()) {
116 if (!packet.has_frame_timeline_event()) {
117 continue;
118 }
119 packets.emplace_back(packet);
120 }
121 return packets;
122 }
123
Ady Abraham57a8ab42023-01-26 15:28:19 -0800124 void addEmptySurfaceFrame() {
125 auto surfaceFrame =
126 mFrameTimeline->createSurfaceFrameForToken({}, sPidOne, sUidOne, sLayerIdOne,
127 sLayerNameOne, sLayerNameOne,
128 /*isBuffer*/ false, sGameMode);
129 mFrameTimeline->addSurfaceFrame(std::move(surfaceFrame));
130 }
131
Adithya Srinivasan01189672020-10-20 14:23:05 -0700132 void addEmptyDisplayFrame() {
133 auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE);
Adithya Srinivasan061c14c2021-02-11 01:19:47 +0000134 // Trigger a flushPresentFence by calling setSfPresent for the next frame
Adithya Srinivasan01189672020-10-20 14:23:05 -0700135 mFrameTimeline->setSfPresent(2500, presentFence1);
136 }
137
Adithya Srinivasanbed4c4f2021-05-03 20:24:46 +0000138 void flushTokens() {
139 for (size_t i = 0; i < maxTokens; i++) {
140 mTokenManager->generateTokenForPredictions({});
141 }
142 EXPECT_EQ(getPredictions().size(), maxTokens);
Adithya Srinivasanf279e042020-08-17 14:56:27 -0700143 }
144
145 SurfaceFrame& getSurfaceFrame(size_t displayFrameIdx, size_t surfaceFrameIdx) {
146 std::lock_guard<std::mutex> lock(mFrameTimeline->mMutex);
Adithya Srinivasan9b2ca3e2020-11-10 10:14:17 -0800147 return *(mFrameTimeline->mDisplayFrames[displayFrameIdx]
148 ->getSurfaceFrames()[surfaceFrameIdx]);
Adithya Srinivasanf279e042020-08-17 14:56:27 -0700149 }
150
151 std::shared_ptr<impl::FrameTimeline::DisplayFrame> getDisplayFrame(size_t idx) {
152 std::lock_guard<std::mutex> lock(mFrameTimeline->mMutex);
153 return mFrameTimeline->mDisplayFrames[idx];
154 }
155
156 static bool compareTimelineItems(const TimelineItem& a, const TimelineItem& b) {
157 return a.startTime == b.startTime && a.endTime == b.endTime &&
158 a.presentTime == b.presentTime;
159 }
160
Adithya Srinivasanbed4c4f2021-05-03 20:24:46 +0000161 const std::map<int64_t, TimelineItem>& getPredictions() const {
Adithya Srinivasanf279e042020-08-17 14:56:27 -0700162 return mTokenManager->mPredictions;
163 }
164
Adithya Srinivasan05bd2d12021-01-11 18:49:58 +0000165 uint32_t getNumberOfDisplayFrames() const {
Adithya Srinivasan2d736322020-10-01 16:53:48 -0700166 std::lock_guard<std::mutex> lock(mFrameTimeline->mMutex);
167 return static_cast<uint32_t>(mFrameTimeline->mDisplayFrames.size());
168 }
169
Adithya Srinivasan05bd2d12021-01-11 18:49:58 +0000170 int64_t snoopCurrentTraceCookie() const { return mTraceCookieCounter->mTraceCookie; }
171
172 void flushTrace() {
173 using FrameTimelineDataSource = impl::FrameTimeline::FrameTimelineDataSource;
174 FrameTimelineDataSource::Trace(
175 [&](FrameTimelineDataSource::TraceContext ctx) { ctx.Flush(); });
176 }
177
Alec Mouri9a29e672020-09-14 12:39:14 -0700178 std::shared_ptr<mock::TimeStats> mTimeStats;
Adithya Srinivasanf279e042020-08-17 14:56:27 -0700179 std::unique_ptr<impl::FrameTimeline> mFrameTimeline;
180 impl::TokenManager* mTokenManager;
Adithya Srinivasan05bd2d12021-01-11 18:49:58 +0000181 TraceCookieCounter* mTraceCookieCounter;
Adithya Srinivasanf279e042020-08-17 14:56:27 -0700182 FenceToFenceTimeMap fenceFactory;
Adithya Srinivasan2d736322020-10-01 16:53:48 -0700183 uint32_t* maxDisplayFrames;
Adithya Srinivasanbed4c4f2021-05-03 20:24:46 +0000184 size_t maxTokens;
Adithya Srinivasan05bd2d12021-01-11 18:49:58 +0000185 static constexpr pid_t kSurfaceFlingerPid = 666;
Adithya Srinivasanead17162021-02-18 02:17:37 +0000186 static constexpr nsecs_t kPresentThreshold = std::chrono::nanoseconds(2ns).count();
Adithya Srinivasan54996e22021-06-25 22:26:45 +0000187 static constexpr nsecs_t kDeadlineThreshold = std::chrono::nanoseconds(0ns).count();
Adithya Srinivasanead17162021-02-18 02:17:37 +0000188 static constexpr nsecs_t kStartThreshold = std::chrono::nanoseconds(2ns).count();
Adithya Srinivasan9b2ca3e2020-11-10 10:14:17 -0800189 static constexpr JankClassificationThresholds kTestThresholds{kPresentThreshold,
190 kDeadlineThreshold,
191 kStartThreshold};
Adithya Srinivasanf279e042020-08-17 14:56:27 -0700192};
193
194TEST_F(FrameTimelineTest, tokenManagerRemovesStalePredictions) {
195 int64_t token1 = mTokenManager->generateTokenForPredictions({0, 0, 0});
Siarhei Vishniakoufc434ac2021-01-13 10:28:00 -1000196 EXPECT_EQ(getPredictions().size(), 1u);
Adithya Srinivasanbed4c4f2021-05-03 20:24:46 +0000197 flushTokens();
Adithya Srinivasanf279e042020-08-17 14:56:27 -0700198 int64_t token2 = mTokenManager->generateTokenForPredictions({10, 20, 30});
199 std::optional<TimelineItem> predictions = mTokenManager->getPredictionsForToken(token1);
200
201 // token1 should have expired
Adithya Srinivasanf279e042020-08-17 14:56:27 -0700202 EXPECT_EQ(predictions.has_value(), false);
203
204 predictions = mTokenManager->getPredictionsForToken(token2);
205 EXPECT_EQ(compareTimelineItems(*predictions, TimelineItem(10, 20, 30)), true);
206}
207
Adithya Srinivasan9febda82020-10-19 10:49:41 -0700208TEST_F(FrameTimelineTest, createSurfaceFrameForToken_getOwnerPidReturnsCorrectPid) {
Alec Mouriadebf5c2021-01-05 12:57:36 -0800209 auto surfaceFrame1 =
210 mFrameTimeline->createSurfaceFrameForToken({}, sPidOne, sUidOne, sLayerIdOne,
Adithya Srinivasan785addd2021-03-09 00:38:00 +0000211 sLayerNameOne, sLayerNameOne,
Adithya Srinivasan58069dc2021-06-04 20:37:02 +0000212 /*isBuffer*/ true, sGameMode);
Alec Mouriadebf5c2021-01-05 12:57:36 -0800213 auto surfaceFrame2 =
214 mFrameTimeline->createSurfaceFrameForToken({}, sPidTwo, sUidOne, sLayerIdOne,
Adithya Srinivasan785addd2021-03-09 00:38:00 +0000215 sLayerNameOne, sLayerNameOne,
Adithya Srinivasan58069dc2021-06-04 20:37:02 +0000216 /*isBuffer*/ true, sGameMode);
Adithya Srinivasan9febda82020-10-19 10:49:41 -0700217 EXPECT_EQ(surfaceFrame1->getOwnerPid(), sPidOne);
218 EXPECT_EQ(surfaceFrame2->getOwnerPid(), sPidTwo);
219}
220
Adithya Srinivasanf279e042020-08-17 14:56:27 -0700221TEST_F(FrameTimelineTest, createSurfaceFrameForToken_noToken) {
Alec Mouriadebf5c2021-01-05 12:57:36 -0800222 auto surfaceFrame =
223 mFrameTimeline->createSurfaceFrameForToken({}, sPidOne, sUidOne, sLayerIdOne,
Adithya Srinivasan785addd2021-03-09 00:38:00 +0000224 sLayerNameOne, sLayerNameOne,
Adithya Srinivasan58069dc2021-06-04 20:37:02 +0000225 /*isBuffer*/ true, sGameMode);
Adithya Srinivasanf279e042020-08-17 14:56:27 -0700226 EXPECT_EQ(surfaceFrame->getPredictionState(), PredictionState::None);
227}
228
229TEST_F(FrameTimelineTest, createSurfaceFrameForToken_expiredToken) {
230 int64_t token1 = mTokenManager->generateTokenForPredictions({0, 0, 0});
Adithya Srinivasanbed4c4f2021-05-03 20:24:46 +0000231 flushTokens();
Huihong Luo3bdef862022-03-03 11:57:19 -0800232 FrameTimelineInfo ftInfo;
233 ftInfo.vsyncId = token1;
234 ftInfo.inputEventId = sInputEventId;
Siarhei Vishniakoufc434ac2021-01-13 10:28:00 -1000235 auto surfaceFrame =
Huihong Luo3bdef862022-03-03 11:57:19 -0800236 mFrameTimeline->createSurfaceFrameForToken(ftInfo, sPidOne, sUidOne, sLayerIdOne,
237 sLayerNameOne, sLayerNameOne,
Adithya Srinivasan58069dc2021-06-04 20:37:02 +0000238 /*isBuffer*/ true, sGameMode);
Adithya Srinivasanf279e042020-08-17 14:56:27 -0700239
240 EXPECT_EQ(surfaceFrame->getPredictionState(), PredictionState::Expired);
241}
242
243TEST_F(FrameTimelineTest, createSurfaceFrameForToken_validToken) {
244 int64_t token1 = mTokenManager->generateTokenForPredictions({10, 20, 30});
Huihong Luo3bdef862022-03-03 11:57:19 -0800245 FrameTimelineInfo ftInfo;
246 ftInfo.vsyncId = token1;
247 ftInfo.inputEventId = sInputEventId;
Siarhei Vishniakoufc434ac2021-01-13 10:28:00 -1000248 auto surfaceFrame =
Huihong Luo3bdef862022-03-03 11:57:19 -0800249 mFrameTimeline->createSurfaceFrameForToken(ftInfo, sPidOne, sUidOne, sLayerIdOne,
250 sLayerNameOne, sLayerNameOne,
Adithya Srinivasan58069dc2021-06-04 20:37:02 +0000251 /*isBuffer*/ true, sGameMode);
Adithya Srinivasanf279e042020-08-17 14:56:27 -0700252
253 EXPECT_EQ(surfaceFrame->getPredictionState(), PredictionState::Valid);
254 EXPECT_EQ(compareTimelineItems(surfaceFrame->getPredictions(), TimelineItem(10, 20, 30)), true);
255}
256
Siarhei Vishniakoufc434ac2021-01-13 10:28:00 -1000257TEST_F(FrameTimelineTest, createSurfaceFrameForToken_validInputEventId) {
258 int64_t token1 = mTokenManager->generateTokenForPredictions({10, 20, 30});
259 constexpr int32_t inputEventId = 1;
Huihong Luo3bdef862022-03-03 11:57:19 -0800260 FrameTimelineInfo ftInfo;
261 ftInfo.vsyncId = token1;
262 ftInfo.inputEventId = inputEventId;
Siarhei Vishniakoufc434ac2021-01-13 10:28:00 -1000263 auto surfaceFrame =
Huihong Luo3bdef862022-03-03 11:57:19 -0800264 mFrameTimeline->createSurfaceFrameForToken(ftInfo, sPidOne, sUidOne, sLayerIdOne,
265 sLayerNameOne, sLayerNameOne,
Adithya Srinivasan58069dc2021-06-04 20:37:02 +0000266 /*isBuffer*/ true, sGameMode);
Siarhei Vishniakoufc434ac2021-01-13 10:28:00 -1000267
268 EXPECT_EQ(inputEventId, surfaceFrame->getInputEventId());
269}
270
Adithya Srinivasanf279e042020-08-17 14:56:27 -0700271TEST_F(FrameTimelineTest, presentFenceSignaled_droppedFramesNotUpdated) {
272 auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE);
Adithya Srinivasanf279e042020-08-17 14:56:27 -0700273 int64_t token1 = mTokenManager->generateTokenForPredictions({10, 20, 30});
Huihong Luo3bdef862022-03-03 11:57:19 -0800274 FrameTimelineInfo ftInfo;
275 ftInfo.vsyncId = token1;
276 ftInfo.inputEventId = sInputEventId;
Siarhei Vishniakoufc434ac2021-01-13 10:28:00 -1000277 auto surfaceFrame1 =
Huihong Luo3bdef862022-03-03 11:57:19 -0800278 mFrameTimeline->createSurfaceFrameForToken(ftInfo, sPidOne, sUidOne, sLayerIdOne,
279 sLayerNameOne, sLayerNameOne,
Adithya Srinivasan58069dc2021-06-04 20:37:02 +0000280 /*isBuffer*/ true, sGameMode);
Adithya Srinivasanf279e042020-08-17 14:56:27 -0700281
282 // Set up the display frame
Pascal Muetschardac7bcd92023-10-03 15:05:36 +0200283 mFrameTimeline->setSfWakeUp(token1, 20, RR_11, RR_11);
Adithya Srinivasan061c14c2021-02-11 01:19:47 +0000284 surfaceFrame1->setDropTime(12);
Adithya Srinivasan9b2ca3e2020-11-10 10:14:17 -0800285 surfaceFrame1->setPresentState(SurfaceFrame::PresentState::Dropped);
286 mFrameTimeline->addSurfaceFrame(surfaceFrame1);
Adithya Srinivasanf279e042020-08-17 14:56:27 -0700287 mFrameTimeline->setSfPresent(25, presentFence1);
288 presentFence1->signalForTest(30);
289
Adithya Srinivasan061c14c2021-02-11 01:19:47 +0000290 addEmptyDisplayFrame();
Adithya Srinivasanf279e042020-08-17 14:56:27 -0700291
292 auto& droppedSurfaceFrame = getSurfaceFrame(0, 0);
293 EXPECT_EQ(droppedSurfaceFrame.getPresentState(), SurfaceFrame::PresentState::Dropped);
Adithya Srinivasan061c14c2021-02-11 01:19:47 +0000294 EXPECT_EQ(0u, droppedSurfaceFrame.getActuals().endTime);
295 EXPECT_EQ(12u, droppedSurfaceFrame.getDropTime());
Adithya Srinivasanf279e042020-08-17 14:56:27 -0700296 EXPECT_EQ(droppedSurfaceFrame.getActuals().presentTime, 0);
297}
298
299TEST_F(FrameTimelineTest, presentFenceSignaled_presentedFramesUpdated) {
Adithya Srinivasan9b2ca3e2020-11-10 10:14:17 -0800300 // Layer specific increment
Alec Mouri363faf02021-01-29 16:34:55 -0800301 EXPECT_CALL(*mTimeStats, incrementJankyFrames(_)).Times(2);
Adithya Srinivasanf279e042020-08-17 14:56:27 -0700302 auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE);
303 int64_t surfaceFrameToken1 = mTokenManager->generateTokenForPredictions({10, 20, 30});
Adithya Srinivasanf279e042020-08-17 14:56:27 -0700304 int64_t sfToken1 = mTokenManager->generateTokenForPredictions({22, 26, 30});
Huihong Luo3bdef862022-03-03 11:57:19 -0800305 FrameTimelineInfo ftInfo;
306 ftInfo.vsyncId = surfaceFrameToken1;
307 ftInfo.inputEventId = sInputEventId;
Alec Mouri9a29e672020-09-14 12:39:14 -0700308 auto surfaceFrame1 =
Huihong Luo3bdef862022-03-03 11:57:19 -0800309 mFrameTimeline->createSurfaceFrameForToken(ftInfo, sPidOne, sUidOne, sLayerIdOne,
310 sLayerNameOne, sLayerNameOne,
311 /*isBuffer*/ true, sGameMode);
Alec Mouri9a29e672020-09-14 12:39:14 -0700312 auto surfaceFrame2 =
Huihong Luo3bdef862022-03-03 11:57:19 -0800313 mFrameTimeline->createSurfaceFrameForToken(ftInfo, sPidOne, sUidOne, sLayerIdTwo,
314 sLayerNameTwo, sLayerNameTwo,
315 /*isBuffer*/ true, sGameMode);
Pascal Muetschardac7bcd92023-10-03 15:05:36 +0200316 mFrameTimeline->setSfWakeUp(sfToken1, 22, RR_11, RR_11);
Adithya Srinivasan9b2ca3e2020-11-10 10:14:17 -0800317 surfaceFrame1->setPresentState(SurfaceFrame::PresentState::Presented);
318 mFrameTimeline->addSurfaceFrame(surfaceFrame1);
319 surfaceFrame2->setPresentState(SurfaceFrame::PresentState::Presented);
320 mFrameTimeline->addSurfaceFrame(surfaceFrame2);
Adithya Srinivasanf279e042020-08-17 14:56:27 -0700321 mFrameTimeline->setSfPresent(26, presentFence1);
322 auto displayFrame = getDisplayFrame(0);
Adithya Srinivasan9b2ca3e2020-11-10 10:14:17 -0800323 auto& presentedSurfaceFrame1 = getSurfaceFrame(0, 0);
324 auto& presentedSurfaceFrame2 = getSurfaceFrame(0, 1);
Adithya Srinivasanf279e042020-08-17 14:56:27 -0700325 presentFence1->signalForTest(42);
326
327 // Fences haven't been flushed yet, so it should be 0
Adithya Srinivasan9b2ca3e2020-11-10 10:14:17 -0800328 EXPECT_EQ(displayFrame->getActuals().presentTime, 0);
Adithya Srinivasanf279e042020-08-17 14:56:27 -0700329 EXPECT_EQ(presentedSurfaceFrame1.getActuals().presentTime, 0);
330 EXPECT_EQ(presentedSurfaceFrame2.getActuals().presentTime, 0);
331
Adithya Srinivasan061c14c2021-02-11 01:19:47 +0000332 addEmptyDisplayFrame();
Adithya Srinivasanf279e042020-08-17 14:56:27 -0700333
334 // Fences have flushed, so the present timestamps should be updated
Adithya Srinivasan9b2ca3e2020-11-10 10:14:17 -0800335 EXPECT_EQ(displayFrame->getActuals().presentTime, 42);
Adithya Srinivasanf279e042020-08-17 14:56:27 -0700336 EXPECT_EQ(presentedSurfaceFrame1.getActuals().presentTime, 42);
337 EXPECT_EQ(presentedSurfaceFrame2.getActuals().presentTime, 42);
Jorim Jaggi9c03b502020-11-24 23:51:31 +0100338 EXPECT_NE(surfaceFrame1->getJankType(), std::nullopt);
Ying Wei96eb5352023-11-21 17:37:21 +0000339 EXPECT_NE(surfaceFrame1->getJankSeverityType(), std::nullopt);
Jorim Jaggi9c03b502020-11-24 23:51:31 +0100340 EXPECT_NE(surfaceFrame2->getJankType(), std::nullopt);
Ying Wei96eb5352023-11-21 17:37:21 +0000341 EXPECT_NE(surfaceFrame2->getJankSeverityType(), std::nullopt);
Adithya Srinivasanf279e042020-08-17 14:56:27 -0700342}
343
Ady Abraham14beed72024-05-15 17:16:45 -0700344TEST_F(FrameTimelineTest, displayFrameSkippedComposition) {
345 // Layer specific increment
346 EXPECT_CALL(*mTimeStats, incrementJankyFrames(_)).Times(1);
347 auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE);
348 int64_t surfaceFrameToken1 = mTokenManager->generateTokenForPredictions({10, 20, 30});
349 int64_t sfToken1 = mTokenManager->generateTokenForPredictions({22, 26, 30});
350 FrameTimelineInfo ftInfo;
351 ftInfo.vsyncId = surfaceFrameToken1;
352 ftInfo.inputEventId = sInputEventId;
353 auto surfaceFrame1 =
354 mFrameTimeline->createSurfaceFrameForToken(ftInfo, sPidOne, sUidOne, sLayerIdOne,
355 sLayerNameOne, sLayerNameOne,
356 /*isBuffer*/ true, sGameMode);
357 auto surfaceFrame2 =
358 mFrameTimeline->createSurfaceFrameForToken(ftInfo, sPidOne, sUidOne, sLayerIdTwo,
359 sLayerNameTwo, sLayerNameTwo,
360 /*isBuffer*/ true, sGameMode);
361
362 mFrameTimeline->setSfWakeUp(sfToken1, 22, RR_11, RR_11);
363 surfaceFrame1->setPresentState(SurfaceFrame::PresentState::Presented);
364 mFrameTimeline->addSurfaceFrame(surfaceFrame1);
365 mFrameTimeline->onCommitNotComposited();
366
367 EXPECT_EQ(surfaceFrame1->getActuals().presentTime, 30);
368 ASSERT_NE(surfaceFrame1->getJankType(), std::nullopt);
369 EXPECT_EQ(*surfaceFrame1->getJankType(), JankType::None);
370 ASSERT_NE(surfaceFrame1->getJankSeverityType(), std::nullopt);
371 EXPECT_EQ(*surfaceFrame1->getJankSeverityType(), JankSeverityType::None);
372
373 mFrameTimeline->setSfWakeUp(sfToken1, 22, RR_11, RR_11);
374 surfaceFrame2->setPresentState(SurfaceFrame::PresentState::Presented);
375 mFrameTimeline->addSurfaceFrame(surfaceFrame2);
376 mFrameTimeline->setSfPresent(26, presentFence1);
377
378 auto displayFrame = getDisplayFrame(0);
379 auto& presentedSurfaceFrame2 = getSurfaceFrame(0, 0);
380 presentFence1->signalForTest(42);
381
382 // Fences haven't been flushed yet, so it should be 0
383 EXPECT_EQ(displayFrame->getActuals().presentTime, 0);
384 EXPECT_EQ(presentedSurfaceFrame2.getActuals().presentTime, 0);
385
386 addEmptyDisplayFrame();
387
388 // Fences have flushed, so the present timestamps should be updated
389 EXPECT_EQ(displayFrame->getActuals().presentTime, 42);
390 EXPECT_EQ(presentedSurfaceFrame2.getActuals().presentTime, 42);
391 EXPECT_NE(surfaceFrame2->getJankType(), std::nullopt);
392 EXPECT_NE(surfaceFrame2->getJankSeverityType(), std::nullopt);
393}
394
Adithya Srinivasanf279e042020-08-17 14:56:27 -0700395TEST_F(FrameTimelineTest, displayFramesSlidingWindowMovesAfterLimit) {
396 // Insert kMaxDisplayFrames' count of DisplayFrames to fill the deque
397 int frameTimeFactor = 0;
Adithya Srinivasan9b2ca3e2020-11-10 10:14:17 -0800398 // Layer specific increment
Alec Mouri363faf02021-01-29 16:34:55 -0800399 EXPECT_CALL(*mTimeStats, incrementJankyFrames(_))
Adithya Srinivasan9b2ca3e2020-11-10 10:14:17 -0800400 .Times(static_cast<int32_t>(*maxDisplayFrames));
Adithya Srinivasan2d736322020-10-01 16:53:48 -0700401 for (size_t i = 0; i < *maxDisplayFrames; i++) {
Adithya Srinivasanf279e042020-08-17 14:56:27 -0700402 auto presentFence = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE);
403 int64_t surfaceFrameToken = mTokenManager->generateTokenForPredictions(
404 {10 + frameTimeFactor, 20 + frameTimeFactor, 30 + frameTimeFactor});
405 int64_t sfToken = mTokenManager->generateTokenForPredictions(
406 {22 + frameTimeFactor, 26 + frameTimeFactor, 30 + frameTimeFactor});
Huihong Luo3bdef862022-03-03 11:57:19 -0800407 FrameTimelineInfo ftInfo;
408 ftInfo.vsyncId = surfaceFrameToken;
409 ftInfo.inputEventId = sInputEventId;
Alec Mouri9a29e672020-09-14 12:39:14 -0700410 auto surfaceFrame =
Huihong Luo3bdef862022-03-03 11:57:19 -0800411 mFrameTimeline->createSurfaceFrameForToken(ftInfo, sPidOne, sUidOne, sLayerIdOne,
Adithya Srinivasan785addd2021-03-09 00:38:00 +0000412 sLayerNameOne, sLayerNameOne,
Adithya Srinivasan58069dc2021-06-04 20:37:02 +0000413 /*isBuffer*/ true, sGameMode);
Pascal Muetschardac7bcd92023-10-03 15:05:36 +0200414 mFrameTimeline->setSfWakeUp(sfToken, 22 + frameTimeFactor, RR_11, RR_11);
Adithya Srinivasan9b2ca3e2020-11-10 10:14:17 -0800415 surfaceFrame->setPresentState(SurfaceFrame::PresentState::Presented);
416 mFrameTimeline->addSurfaceFrame(surfaceFrame);
Adithya Srinivasanf279e042020-08-17 14:56:27 -0700417 mFrameTimeline->setSfPresent(27 + frameTimeFactor, presentFence);
418 presentFence->signalForTest(32 + frameTimeFactor);
419 frameTimeFactor += 30;
420 }
421 auto displayFrame0 = getDisplayFrame(0);
422
423 // The 0th Display Frame should have actuals 22, 27, 32
Adithya Srinivasan9b2ca3e2020-11-10 10:14:17 -0800424 EXPECT_EQ(compareTimelineItems(displayFrame0->getActuals(), TimelineItem(22, 27, 32)), true);
Adithya Srinivasanf279e042020-08-17 14:56:27 -0700425
426 // Add one more display frame
427 auto presentFence = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE);
428 int64_t surfaceFrameToken = mTokenManager->generateTokenForPredictions(
429 {10 + frameTimeFactor, 20 + frameTimeFactor, 30 + frameTimeFactor});
430 int64_t sfToken = mTokenManager->generateTokenForPredictions(
431 {22 + frameTimeFactor, 26 + frameTimeFactor, 30 + frameTimeFactor});
Huihong Luo3bdef862022-03-03 11:57:19 -0800432 FrameTimelineInfo ftInfo;
433 ftInfo.vsyncId = surfaceFrameToken;
434 ftInfo.inputEventId = sInputEventId;
Alec Mouri9a29e672020-09-14 12:39:14 -0700435 auto surfaceFrame =
Huihong Luo3bdef862022-03-03 11:57:19 -0800436 mFrameTimeline->createSurfaceFrameForToken(ftInfo, sPidOne, sUidOne, sLayerIdOne,
437 sLayerNameOne, sLayerNameOne,
438 /*isBuffer*/ true, sGameMode);
Pascal Muetschardac7bcd92023-10-03 15:05:36 +0200439 mFrameTimeline->setSfWakeUp(sfToken, 22 + frameTimeFactor, RR_11, RR_11);
Adithya Srinivasan9b2ca3e2020-11-10 10:14:17 -0800440 surfaceFrame->setPresentState(SurfaceFrame::PresentState::Presented);
441 mFrameTimeline->addSurfaceFrame(surfaceFrame);
Adithya Srinivasanf279e042020-08-17 14:56:27 -0700442 mFrameTimeline->setSfPresent(27 + frameTimeFactor, presentFence);
443 presentFence->signalForTest(32 + frameTimeFactor);
444 displayFrame0 = getDisplayFrame(0);
445
446 // The window should have slided by 1 now and the previous 0th display frame
447 // should have been removed from the deque
Adithya Srinivasan9b2ca3e2020-11-10 10:14:17 -0800448 EXPECT_EQ(compareTimelineItems(displayFrame0->getActuals(), TimelineItem(52, 57, 62)), true);
Adithya Srinivasanf279e042020-08-17 14:56:27 -0700449}
450
Ady Abraham7f8a1e62020-09-28 16:09:35 -0700451TEST_F(FrameTimelineTest, surfaceFrameEndTimeAcquireFenceAfterQueue) {
Adithya Srinivasan58069dc2021-06-04 20:37:02 +0000452 auto surfaceFrame = mFrameTimeline->createSurfaceFrameForToken({}, sPidOne, 0, sLayerIdOne,
453 "acquireFenceAfterQueue",
454 "acquireFenceAfterQueue",
455 /*isBuffer*/ true, sGameMode);
Ady Abraham7f8a1e62020-09-28 16:09:35 -0700456 surfaceFrame->setActualQueueTime(123);
457 surfaceFrame->setAcquireFenceTime(456);
458 EXPECT_EQ(surfaceFrame->getActuals().endTime, 456);
459}
460
461TEST_F(FrameTimelineTest, surfaceFrameEndTimeAcquireFenceBeforeQueue) {
Adithya Srinivasan58069dc2021-06-04 20:37:02 +0000462 auto surfaceFrame = mFrameTimeline->createSurfaceFrameForToken({}, sPidOne, 0, sLayerIdOne,
463 "acquireFenceAfterQueue",
464 "acquireFenceAfterQueue",
465 /*isBuffer*/ true, sGameMode);
Ady Abraham7f8a1e62020-09-28 16:09:35 -0700466 surfaceFrame->setActualQueueTime(456);
467 surfaceFrame->setAcquireFenceTime(123);
468 EXPECT_EQ(surfaceFrame->getActuals().endTime, 456);
469}
470
Adithya Srinivasan2d736322020-10-01 16:53:48 -0700471TEST_F(FrameTimelineTest, setMaxDisplayFramesSetsSizeProperly) {
472 auto presentFence = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE);
473 presentFence->signalForTest(2);
474
475 // Size shouldn't exceed maxDisplayFrames - 64
476 for (size_t i = 0; i < *maxDisplayFrames + 10; i++) {
Adithya Srinivasan9febda82020-10-19 10:49:41 -0700477 auto surfaceFrame =
Alec Mouriadebf5c2021-01-05 12:57:36 -0800478 mFrameTimeline->createSurfaceFrameForToken({}, sPidOne, sUidOne, sLayerIdOne,
Adithya Srinivasan785addd2021-03-09 00:38:00 +0000479 sLayerNameOne, sLayerNameOne,
Adithya Srinivasan58069dc2021-06-04 20:37:02 +0000480 /*isBuffer*/ true, sGameMode);
Adithya Srinivasan2d736322020-10-01 16:53:48 -0700481 int64_t sfToken = mTokenManager->generateTokenForPredictions({22, 26, 30});
Pascal Muetschardac7bcd92023-10-03 15:05:36 +0200482 mFrameTimeline->setSfWakeUp(sfToken, 22, RR_11, RR_11);
Adithya Srinivasan9b2ca3e2020-11-10 10:14:17 -0800483 surfaceFrame->setPresentState(SurfaceFrame::PresentState::Presented);
484 mFrameTimeline->addSurfaceFrame(surfaceFrame);
Adithya Srinivasan2d736322020-10-01 16:53:48 -0700485 mFrameTimeline->setSfPresent(27, presentFence);
486 }
487 EXPECT_EQ(getNumberOfDisplayFrames(), *maxDisplayFrames);
488
489 // Increase the size to 256
490 mFrameTimeline->setMaxDisplayFrames(256);
Siarhei Vishniakoufc434ac2021-01-13 10:28:00 -1000491 EXPECT_EQ(*maxDisplayFrames, 256u);
Adithya Srinivasan2d736322020-10-01 16:53:48 -0700492
493 for (size_t i = 0; i < *maxDisplayFrames + 10; i++) {
Adithya Srinivasan9febda82020-10-19 10:49:41 -0700494 auto surfaceFrame =
Alec Mouriadebf5c2021-01-05 12:57:36 -0800495 mFrameTimeline->createSurfaceFrameForToken({}, sPidOne, sUidOne, sLayerIdOne,
Adithya Srinivasan785addd2021-03-09 00:38:00 +0000496 sLayerNameOne, sLayerNameOne,
Adithya Srinivasan58069dc2021-06-04 20:37:02 +0000497 /*isBuffer*/ true, sGameMode);
Adithya Srinivasan2d736322020-10-01 16:53:48 -0700498 int64_t sfToken = mTokenManager->generateTokenForPredictions({22, 26, 30});
Pascal Muetschardac7bcd92023-10-03 15:05:36 +0200499 mFrameTimeline->setSfWakeUp(sfToken, 22, RR_11, RR_11);
Adithya Srinivasan9b2ca3e2020-11-10 10:14:17 -0800500 surfaceFrame->setPresentState(SurfaceFrame::PresentState::Presented);
501 mFrameTimeline->addSurfaceFrame(surfaceFrame);
Adithya Srinivasan2d736322020-10-01 16:53:48 -0700502 mFrameTimeline->setSfPresent(27, presentFence);
503 }
504 EXPECT_EQ(getNumberOfDisplayFrames(), *maxDisplayFrames);
505
506 // Shrink the size to 128
507 mFrameTimeline->setMaxDisplayFrames(128);
Siarhei Vishniakoufc434ac2021-01-13 10:28:00 -1000508 EXPECT_EQ(*maxDisplayFrames, 128u);
Adithya Srinivasan2d736322020-10-01 16:53:48 -0700509
510 for (size_t i = 0; i < *maxDisplayFrames + 10; i++) {
Adithya Srinivasan9febda82020-10-19 10:49:41 -0700511 auto surfaceFrame =
Alec Mouriadebf5c2021-01-05 12:57:36 -0800512 mFrameTimeline->createSurfaceFrameForToken({}, sPidOne, sUidOne, sLayerIdOne,
Adithya Srinivasan785addd2021-03-09 00:38:00 +0000513 sLayerNameOne, sLayerNameOne,
Adithya Srinivasan58069dc2021-06-04 20:37:02 +0000514 /*isBuffer*/ true, sGameMode);
Adithya Srinivasan2d736322020-10-01 16:53:48 -0700515 int64_t sfToken = mTokenManager->generateTokenForPredictions({22, 26, 30});
Pascal Muetschardac7bcd92023-10-03 15:05:36 +0200516 mFrameTimeline->setSfWakeUp(sfToken, 22, RR_11, RR_11);
Adithya Srinivasan9b2ca3e2020-11-10 10:14:17 -0800517 surfaceFrame->setPresentState(SurfaceFrame::PresentState::Presented);
518 mFrameTimeline->addSurfaceFrame(surfaceFrame);
Adithya Srinivasan2d736322020-10-01 16:53:48 -0700519 mFrameTimeline->setSfPresent(27, presentFence);
520 }
521 EXPECT_EQ(getNumberOfDisplayFrames(), *maxDisplayFrames);
522}
Alec Mouri9a29e672020-09-14 12:39:14 -0700523
Adithya Srinivasan7c4ac7a2021-03-08 23:48:03 +0000524TEST_F(FrameTimelineTest, presentFenceSignaled_invalidSignalTime) {
Pascal Muetschardac7bcd92023-10-03 15:05:36 +0200525 Fps refreshRate = RR_11;
Adithya Srinivasan7c4ac7a2021-03-08 23:48:03 +0000526
527 auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE);
528 int64_t surfaceFrameToken1 = mTokenManager->generateTokenForPredictions({10, 20, 60});
529 int64_t sfToken1 = mTokenManager->generateTokenForPredictions({52, 60, 60});
Huihong Luo3bdef862022-03-03 11:57:19 -0800530 FrameTimelineInfo ftInfo;
531 ftInfo.vsyncId = surfaceFrameToken1;
532 ftInfo.inputEventId = sInputEventId;
Adithya Srinivasan7c4ac7a2021-03-08 23:48:03 +0000533
534 auto surfaceFrame1 =
Huihong Luo3bdef862022-03-03 11:57:19 -0800535 mFrameTimeline->createSurfaceFrameForToken(ftInfo, sPidOne, sUidOne, sLayerIdOne,
536 sLayerNameOne, sLayerNameOne,
537 /*isBuffer*/ true, sGameMode);
Pascal Muetschardac7bcd92023-10-03 15:05:36 +0200538 mFrameTimeline->setSfWakeUp(sfToken1, 52, refreshRate, refreshRate);
Adithya Srinivasan7c4ac7a2021-03-08 23:48:03 +0000539 surfaceFrame1->setAcquireFenceTime(20);
540 surfaceFrame1->setPresentState(SurfaceFrame::PresentState::Presented);
541 mFrameTimeline->addSurfaceFrame(surfaceFrame1);
542
543 mFrameTimeline->setSfPresent(59, presentFence1);
544 presentFence1->signalForTest(-1);
545 addEmptyDisplayFrame();
546
547 auto displayFrame0 = getDisplayFrame(0);
Ady Abrahamfcb16862022-10-10 14:35:21 -0700548 EXPECT_EQ(displayFrame0->getActuals().presentTime, 59);
Ady Abrahamb1e10d12023-03-13 15:23:54 -0700549 EXPECT_EQ(displayFrame0->getJankType(), JankType::Unknown | JankType::DisplayHAL);
Ying Wei96eb5352023-11-21 17:37:21 +0000550 EXPECT_EQ(displayFrame0->getJankSeverityType(), JankSeverityType::Unknown);
Adithya Srinivasan7c4ac7a2021-03-08 23:48:03 +0000551 EXPECT_EQ(surfaceFrame1->getActuals().presentTime, -1);
552 EXPECT_EQ(surfaceFrame1->getJankType(), JankType::Unknown);
Ying Wei96eb5352023-11-21 17:37:21 +0000553 EXPECT_EQ(surfaceFrame1->getJankSeverityType(), JankSeverityType::Unknown);
Adithya Srinivasan7c4ac7a2021-03-08 23:48:03 +0000554}
555
Adithya Srinivasan9b2ca3e2020-11-10 10:14:17 -0800556// Tests related to TimeStats
Adithya Srinivasan7c4ac7a2021-03-08 23:48:03 +0000557TEST_F(FrameTimelineTest, presentFenceSignaled_doesNotReportForInvalidTokens) {
Pascal Muetschardac7bcd92023-10-03 15:05:36 +0200558 Fps refreshRate = RR_11;
Adithya Srinivasan7c4ac7a2021-03-08 23:48:03 +0000559 EXPECT_CALL(*mTimeStats, incrementJankyFrames(_)).Times(0);
560 auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE);
561 int64_t surfaceFrameToken1 = -1;
562 int64_t sfToken1 = -1;
Huihong Luo3bdef862022-03-03 11:57:19 -0800563 FrameTimelineInfo ftInfo;
564 ftInfo.vsyncId = surfaceFrameToken1;
565 ftInfo.inputEventId = sInputEventId;
Adithya Srinivasan7c4ac7a2021-03-08 23:48:03 +0000566
567 auto surfaceFrame1 =
Huihong Luo3bdef862022-03-03 11:57:19 -0800568 mFrameTimeline->createSurfaceFrameForToken(ftInfo, sPidOne, sUidOne, sLayerIdOne,
569 sLayerNameOne, sLayerNameOne,
570 /*isBuffer*/ true, sGameMode);
Pascal Muetschardac7bcd92023-10-03 15:05:36 +0200571 mFrameTimeline->setSfWakeUp(sfToken1, 52, refreshRate, refreshRate);
Adithya Srinivasan7c4ac7a2021-03-08 23:48:03 +0000572 surfaceFrame1->setAcquireFenceTime(20);
573 surfaceFrame1->setPresentState(SurfaceFrame::PresentState::Presented);
574 mFrameTimeline->addSurfaceFrame(surfaceFrame1);
575 presentFence1->signalForTest(70);
576
577 mFrameTimeline->setSfPresent(59, presentFence1);
578}
579
Alec Mouri9a29e672020-09-14 12:39:14 -0700580TEST_F(FrameTimelineTest, presentFenceSignaled_reportsLongSfCpu) {
Pascal Muetschardac7bcd92023-10-03 15:05:36 +0200581 Fps refreshRate = RR_11;
Alec Mouri9a29e672020-09-14 12:39:14 -0700582 EXPECT_CALL(*mTimeStats,
Alec Mouri363faf02021-01-29 16:34:55 -0800583 incrementJankyFrames(
584 TimeStats::JankyFramesInfo{refreshRate, std::nullopt, sUidOne,
Adithya Srinivasan58069dc2021-06-04 20:37:02 +0000585 sLayerNameOne, sGameMode,
Adithya Srinivasan939cd4d2021-02-23 06:18:13 +0000586 JankType::SurfaceFlingerCpuDeadlineMissed, 2, 10,
Alec Mouri363faf02021-01-29 16:34:55 -0800587 0}));
Alec Mouri9a29e672020-09-14 12:39:14 -0700588 auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE);
Adithya Srinivasan939cd4d2021-02-23 06:18:13 +0000589 int64_t surfaceFrameToken1 = mTokenManager->generateTokenForPredictions({10, 20, 60});
590 int64_t sfToken1 = mTokenManager->generateTokenForPredictions({52, 60, 60});
Huihong Luo3bdef862022-03-03 11:57:19 -0800591 FrameTimelineInfo ftInfo;
592 ftInfo.vsyncId = surfaceFrameToken1;
593 ftInfo.inputEventId = sInputEventId;
Adithya Srinivasan939cd4d2021-02-23 06:18:13 +0000594
Alec Mouri9a29e672020-09-14 12:39:14 -0700595 auto surfaceFrame1 =
Huihong Luo3bdef862022-03-03 11:57:19 -0800596 mFrameTimeline->createSurfaceFrameForToken(ftInfo, sPidOne, sUidOne, sLayerIdOne,
597 sLayerNameOne, sLayerNameOne,
598 /*isBuffer*/ true, sGameMode);
Pascal Muetschardac7bcd92023-10-03 15:05:36 +0200599 mFrameTimeline->setSfWakeUp(sfToken1, 52, refreshRate, refreshRate);
Adithya Srinivasan939cd4d2021-02-23 06:18:13 +0000600 surfaceFrame1->setAcquireFenceTime(20);
Adithya Srinivasan9b2ca3e2020-11-10 10:14:17 -0800601 surfaceFrame1->setPresentState(SurfaceFrame::PresentState::Presented);
602 mFrameTimeline->addSurfaceFrame(surfaceFrame1);
Adithya Srinivasan939cd4d2021-02-23 06:18:13 +0000603 presentFence1->signalForTest(70);
Alec Mouri9a29e672020-09-14 12:39:14 -0700604
Adithya Srinivasan82eef322021-04-10 00:06:04 +0000605 mFrameTimeline->setSfPresent(62, presentFence1);
Alec Mouri9a29e672020-09-14 12:39:14 -0700606}
607
Adithya Srinivasan36b01af2021-04-07 22:29:47 +0000608TEST_F(FrameTimelineTest, presentFenceSignaled_reportsLongSfGpu) {
Pascal Muetschardac7bcd92023-10-03 15:05:36 +0200609 Fps refreshRate = RR_11;
Adithya Srinivasan36b01af2021-04-07 22:29:47 +0000610 EXPECT_CALL(*mTimeStats,
611 incrementJankyFrames(
612 TimeStats::JankyFramesInfo{refreshRate, std::nullopt, sUidOne,
Adithya Srinivasan58069dc2021-06-04 20:37:02 +0000613 sLayerNameOne, sGameMode,
Adithya Srinivasan36b01af2021-04-07 22:29:47 +0000614 JankType::SurfaceFlingerGpuDeadlineMissed, 4, 10,
615 0}));
616 auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE);
617 auto gpuFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE);
618 int64_t surfaceFrameToken1 = mTokenManager->generateTokenForPredictions({10, 20, 60});
619 int64_t sfToken1 = mTokenManager->generateTokenForPredictions({52, 60, 60});
Huihong Luo3bdef862022-03-03 11:57:19 -0800620 FrameTimelineInfo ftInfo;
621 ftInfo.vsyncId = surfaceFrameToken1;
622 ftInfo.inputEventId = sInputEventId;
Adithya Srinivasan36b01af2021-04-07 22:29:47 +0000623
624 auto surfaceFrame1 =
Huihong Luo3bdef862022-03-03 11:57:19 -0800625 mFrameTimeline->createSurfaceFrameForToken(ftInfo, sPidOne, sUidOne, sLayerIdOne,
626 sLayerNameOne, sLayerNameOne,
627 /*isBuffer*/ true, sGameMode);
Pascal Muetschardac7bcd92023-10-03 15:05:36 +0200628 mFrameTimeline->setSfWakeUp(sfToken1, 52, refreshRate, refreshRate);
Adithya Srinivasan36b01af2021-04-07 22:29:47 +0000629 surfaceFrame1->setAcquireFenceTime(20);
630 surfaceFrame1->setPresentState(SurfaceFrame::PresentState::Presented);
631 mFrameTimeline->addSurfaceFrame(surfaceFrame1);
632 gpuFence1->signalForTest(64);
633 presentFence1->signalForTest(70);
634
635 mFrameTimeline->setSfPresent(59, presentFence1, gpuFence1);
636}
637
Alec Mouri9a29e672020-09-14 12:39:14 -0700638TEST_F(FrameTimelineTest, presentFenceSignaled_reportsDisplayMiss) {
Pascal Muetschardac7bcd92023-10-03 15:05:36 +0200639 Fps refreshRate = RR_30;
Alec Mouri9a29e672020-09-14 12:39:14 -0700640 EXPECT_CALL(*mTimeStats,
Alec Mouri363faf02021-01-29 16:34:55 -0800641 incrementJankyFrames(TimeStats::JankyFramesInfo{refreshRate, std::nullopt, sUidOne,
Adithya Srinivasan58069dc2021-06-04 20:37:02 +0000642 sLayerNameOne, sGameMode,
643 JankType::DisplayHAL, -4, 0, 0}));
Adithya Srinivasan9b2ca3e2020-11-10 10:14:17 -0800644
Alec Mouri9a29e672020-09-14 12:39:14 -0700645 auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE);
Adithya Srinivasan939cd4d2021-02-23 06:18:13 +0000646 int64_t surfaceFrameToken1 = mTokenManager->generateTokenForPredictions({10, 20, 60});
647 int64_t sfToken1 = mTokenManager->generateTokenForPredictions({52, 60, 60});
Huihong Luo3bdef862022-03-03 11:57:19 -0800648 FrameTimelineInfo ftInfo;
649 ftInfo.vsyncId = surfaceFrameToken1;
650 ftInfo.inputEventId = sInputEventId;
Adithya Srinivasan939cd4d2021-02-23 06:18:13 +0000651
Alec Mouri9a29e672020-09-14 12:39:14 -0700652 auto surfaceFrame1 =
Huihong Luo3bdef862022-03-03 11:57:19 -0800653 mFrameTimeline->createSurfaceFrameForToken(ftInfo, sPidOne, sUidOne, sLayerIdOne,
654 sLayerNameOne, sLayerNameOne,
655 /*isBuffer*/ true, sGameMode);
Pascal Muetschardac7bcd92023-10-03 15:05:36 +0200656 mFrameTimeline->setSfWakeUp(sfToken1, 52, refreshRate, refreshRate);
Adithya Srinivasan9b2ca3e2020-11-10 10:14:17 -0800657 surfaceFrame1->setPresentState(SurfaceFrame::PresentState::Presented);
Adithya Srinivasan939cd4d2021-02-23 06:18:13 +0000658 surfaceFrame1->setAcquireFenceTime(20);
Adithya Srinivasan9b2ca3e2020-11-10 10:14:17 -0800659 mFrameTimeline->addSurfaceFrame(surfaceFrame1);
Adithya Srinivasan939cd4d2021-02-23 06:18:13 +0000660 presentFence1->signalForTest(90);
661 mFrameTimeline->setSfPresent(56, presentFence1);
Adithya Srinivasan9b2ca3e2020-11-10 10:14:17 -0800662 EXPECT_EQ(surfaceFrame1->getJankType(), JankType::DisplayHAL);
Ying Wei96eb5352023-11-21 17:37:21 +0000663 EXPECT_EQ(surfaceFrame1->getJankSeverityType(), JankSeverityType::Full);
Alec Mouri9a29e672020-09-14 12:39:14 -0700664}
665
666TEST_F(FrameTimelineTest, presentFenceSignaled_reportsAppMiss) {
Dominik Laskowski6eab42d2021-09-13 14:34:13 -0700667 Fps refreshRate = 11_Hz;
Alec Mouri9a29e672020-09-14 12:39:14 -0700668 EXPECT_CALL(*mTimeStats,
Adithya Srinivasan939cd4d2021-02-23 06:18:13 +0000669 incrementJankyFrames(TimeStats::JankyFramesInfo{refreshRate, std::nullopt, sUidOne,
Adithya Srinivasan58069dc2021-06-04 20:37:02 +0000670 sLayerNameOne, sGameMode,
Adithya Srinivasan82eef322021-04-10 00:06:04 +0000671 JankType::AppDeadlineMissed, -4, 0,
Adithya Srinivasan939cd4d2021-02-23 06:18:13 +0000672 25}));
Alec Mouri9a29e672020-09-14 12:39:14 -0700673 auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE);
Adithya Srinivasan939cd4d2021-02-23 06:18:13 +0000674 int64_t surfaceFrameToken1 = mTokenManager->generateTokenForPredictions({10, 20, 60});
675 int64_t sfToken1 = mTokenManager->generateTokenForPredictions({82, 90, 90});
Huihong Luo3bdef862022-03-03 11:57:19 -0800676 FrameTimelineInfo ftInfo;
677 ftInfo.vsyncId = surfaceFrameToken1;
678 ftInfo.inputEventId = sInputEventId;
Adithya Srinivasan939cd4d2021-02-23 06:18:13 +0000679
Alec Mouri9a29e672020-09-14 12:39:14 -0700680 auto surfaceFrame1 =
Huihong Luo3bdef862022-03-03 11:57:19 -0800681 mFrameTimeline->createSurfaceFrameForToken(ftInfo, sPidOne, sUidOne, sLayerIdOne,
682 sLayerNameOne, sLayerNameOne,
683 /*isBuffer*/ true, sGameMode);
Adithya Srinivasan939cd4d2021-02-23 06:18:13 +0000684 surfaceFrame1->setAcquireFenceTime(45);
Pascal Muetschardac7bcd92023-10-03 15:05:36 +0200685 mFrameTimeline->setSfWakeUp(sfToken1, 52, refreshRate, refreshRate);
Alec Mouri9a29e672020-09-14 12:39:14 -0700686
Adithya Srinivasan9b2ca3e2020-11-10 10:14:17 -0800687 surfaceFrame1->setPresentState(SurfaceFrame::PresentState::Presented);
688 mFrameTimeline->addSurfaceFrame(surfaceFrame1);
Adithya Srinivasan939cd4d2021-02-23 06:18:13 +0000689 presentFence1->signalForTest(90);
690 mFrameTimeline->setSfPresent(86, presentFence1);
Jorim Jaggi9c03b502020-11-24 23:51:31 +0100691
Adithya Srinivasan9b2ca3e2020-11-10 10:14:17 -0800692 EXPECT_EQ(surfaceFrame1->getJankType(), JankType::AppDeadlineMissed);
Ying Wei96eb5352023-11-21 17:37:21 +0000693 EXPECT_EQ(surfaceFrame1->getJankSeverityType(), JankSeverityType::Partial);
Alec Mouri9a29e672020-09-14 12:39:14 -0700694}
695
Adithya Srinivasanead17162021-02-18 02:17:37 +0000696TEST_F(FrameTimelineTest, presentFenceSignaled_reportsSfScheduling) {
Adithya Srinivasan939cd4d2021-02-23 06:18:13 +0000697 Fps refreshRate = Fps::fromPeriodNsecs(32);
Adithya Srinivasanead17162021-02-18 02:17:37 +0000698 EXPECT_CALL(*mTimeStats,
Adithya Srinivasan939cd4d2021-02-23 06:18:13 +0000699 incrementJankyFrames(TimeStats::JankyFramesInfo{refreshRate, std::nullopt, sUidOne,
Adithya Srinivasan58069dc2021-06-04 20:37:02 +0000700 sLayerNameOne, sGameMode,
Adithya Srinivasan939cd4d2021-02-23 06:18:13 +0000701 JankType::SurfaceFlingerScheduling,
Adithya Srinivasan82eef322021-04-10 00:06:04 +0000702 -4, 0, -10}));
Adithya Srinivasanead17162021-02-18 02:17:37 +0000703 auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE);
Adithya Srinivasan939cd4d2021-02-23 06:18:13 +0000704 int64_t surfaceFrameToken1 = mTokenManager->generateTokenForPredictions({40, 60, 92});
705 int64_t sfToken1 = mTokenManager->generateTokenForPredictions({52, 60, 60});
Huihong Luo3bdef862022-03-03 11:57:19 -0800706 FrameTimelineInfo ftInfo;
707 ftInfo.vsyncId = surfaceFrameToken1;
708 ftInfo.inputEventId = sInputEventId;
Adithya Srinivasan939cd4d2021-02-23 06:18:13 +0000709
Adithya Srinivasanead17162021-02-18 02:17:37 +0000710 auto surfaceFrame1 =
Huihong Luo3bdef862022-03-03 11:57:19 -0800711 mFrameTimeline->createSurfaceFrameForToken(ftInfo, sPidOne, sUidOne, sLayerIdOne,
712 sLayerNameOne, sLayerNameOne,
713 /*isBuffer*/ true, sGameMode);
Adithya Srinivasan939cd4d2021-02-23 06:18:13 +0000714 surfaceFrame1->setAcquireFenceTime(50);
Pascal Muetschardac7bcd92023-10-03 15:05:36 +0200715 mFrameTimeline->setSfWakeUp(sfToken1, 52, refreshRate, refreshRate);
Adithya Srinivasanead17162021-02-18 02:17:37 +0000716
717 surfaceFrame1->setPresentState(SurfaceFrame::PresentState::Presented);
718 mFrameTimeline->addSurfaceFrame(surfaceFrame1);
Adithya Srinivasan939cd4d2021-02-23 06:18:13 +0000719 presentFence1->signalForTest(60);
720 mFrameTimeline->setSfPresent(56, presentFence1);
Adithya Srinivasanead17162021-02-18 02:17:37 +0000721
722 EXPECT_EQ(surfaceFrame1->getJankType(), JankType::SurfaceFlingerScheduling);
Ying Wei96eb5352023-11-21 17:37:21 +0000723 EXPECT_EQ(surfaceFrame1->getJankSeverityType(), JankSeverityType::Full);
Adithya Srinivasanead17162021-02-18 02:17:37 +0000724}
725
726TEST_F(FrameTimelineTest, presentFenceSignaled_reportsSfPredictionError) {
Adithya Srinivasan939cd4d2021-02-23 06:18:13 +0000727 Fps refreshRate = Fps::fromPeriodNsecs(16);
Adithya Srinivasanead17162021-02-18 02:17:37 +0000728 EXPECT_CALL(*mTimeStats,
Adithya Srinivasan939cd4d2021-02-23 06:18:13 +0000729 incrementJankyFrames(TimeStats::JankyFramesInfo{refreshRate, std::nullopt, sUidOne,
Adithya Srinivasan58069dc2021-06-04 20:37:02 +0000730 sLayerNameOne, sGameMode,
Adithya Srinivasan82eef322021-04-10 00:06:04 +0000731 JankType::PredictionError, -4, 5,
Adithya Srinivasan939cd4d2021-02-23 06:18:13 +0000732 0}));
Adithya Srinivasanead17162021-02-18 02:17:37 +0000733 auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE);
Adithya Srinivasan939cd4d2021-02-23 06:18:13 +0000734 int64_t surfaceFrameToken1 = mTokenManager->generateTokenForPredictions({30, 40, 60});
735 int64_t sfToken1 = mTokenManager->generateTokenForPredictions({52, 60, 60});
Huihong Luo3bdef862022-03-03 11:57:19 -0800736 FrameTimelineInfo ftInfo;
737 ftInfo.vsyncId = surfaceFrameToken1;
738 ftInfo.inputEventId = sInputEventId;
Adithya Srinivasan939cd4d2021-02-23 06:18:13 +0000739
Adithya Srinivasanead17162021-02-18 02:17:37 +0000740 auto surfaceFrame1 =
Huihong Luo3bdef862022-03-03 11:57:19 -0800741 mFrameTimeline->createSurfaceFrameForToken(ftInfo, sPidOne, sUidOne, sLayerIdOne,
742 sLayerNameOne, sLayerNameOne,
743 /*isBuffer*/ true, sGameMode);
Adithya Srinivasan939cd4d2021-02-23 06:18:13 +0000744 surfaceFrame1->setAcquireFenceTime(40);
Pascal Muetschardac7bcd92023-10-03 15:05:36 +0200745 mFrameTimeline->setSfWakeUp(sfToken1, 52, refreshRate, refreshRate);
Adithya Srinivasanead17162021-02-18 02:17:37 +0000746
747 surfaceFrame1->setPresentState(SurfaceFrame::PresentState::Presented);
748 mFrameTimeline->addSurfaceFrame(surfaceFrame1);
Adithya Srinivasan939cd4d2021-02-23 06:18:13 +0000749 presentFence1->signalForTest(65);
750 mFrameTimeline->setSfPresent(56, presentFence1);
Adithya Srinivasanead17162021-02-18 02:17:37 +0000751
752 EXPECT_EQ(surfaceFrame1->getJankType(), JankType::PredictionError);
Ying Wei96eb5352023-11-21 17:37:21 +0000753 EXPECT_EQ(surfaceFrame1->getJankSeverityType(), JankSeverityType::Partial);
Adithya Srinivasanead17162021-02-18 02:17:37 +0000754}
755
756TEST_F(FrameTimelineTest, presentFenceSignaled_reportsAppBufferStuffing) {
Adithya Srinivasan939cd4d2021-02-23 06:18:13 +0000757 Fps refreshRate = Fps::fromPeriodNsecs(32);
Adithya Srinivasanead17162021-02-18 02:17:37 +0000758 EXPECT_CALL(*mTimeStats,
Adithya Srinivasan939cd4d2021-02-23 06:18:13 +0000759 incrementJankyFrames(TimeStats::JankyFramesInfo{refreshRate, std::nullopt, sUidOne,
Adithya Srinivasan58069dc2021-06-04 20:37:02 +0000760 sLayerNameOne, sGameMode,
Adithya Srinivasan82eef322021-04-10 00:06:04 +0000761 JankType::BufferStuffing, -4, 0,
Adithya Srinivasan939cd4d2021-02-23 06:18:13 +0000762 0}));
Adithya Srinivasanead17162021-02-18 02:17:37 +0000763 auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE);
Adithya Srinivasan939cd4d2021-02-23 06:18:13 +0000764 int64_t surfaceFrameToken1 = mTokenManager->generateTokenForPredictions({30, 40, 58});
765 int64_t sfToken1 = mTokenManager->generateTokenForPredictions({82, 90, 90});
Huihong Luo3bdef862022-03-03 11:57:19 -0800766 FrameTimelineInfo ftInfo;
767 ftInfo.vsyncId = surfaceFrameToken1;
768 ftInfo.inputEventId = sInputEventId;
Adithya Srinivasan939cd4d2021-02-23 06:18:13 +0000769
Adithya Srinivasanead17162021-02-18 02:17:37 +0000770 auto surfaceFrame1 =
Huihong Luo3bdef862022-03-03 11:57:19 -0800771 mFrameTimeline->createSurfaceFrameForToken(ftInfo, sPidOne, sUidOne, sLayerIdOne,
772 sLayerNameOne, sLayerNameOne,
773 /*isBuffer*/ true, sGameMode);
Adithya Srinivasan939cd4d2021-02-23 06:18:13 +0000774 surfaceFrame1->setAcquireFenceTime(40);
Pascal Muetschardac7bcd92023-10-03 15:05:36 +0200775 mFrameTimeline->setSfWakeUp(sfToken1, 82, refreshRate, refreshRate);
Adithya Srinivasanead17162021-02-18 02:17:37 +0000776
777 surfaceFrame1->setPresentState(SurfaceFrame::PresentState::Presented,
Adithya Srinivasan939cd4d2021-02-23 06:18:13 +0000778 /*previousLatchTime*/ 56);
Adithya Srinivasanead17162021-02-18 02:17:37 +0000779 mFrameTimeline->addSurfaceFrame(surfaceFrame1);
Adithya Srinivasan939cd4d2021-02-23 06:18:13 +0000780 presentFence1->signalForTest(90);
781 mFrameTimeline->setSfPresent(86, presentFence1);
Adithya Srinivasanead17162021-02-18 02:17:37 +0000782
Adithya Srinivasan939cd4d2021-02-23 06:18:13 +0000783 EXPECT_EQ(surfaceFrame1->getJankType(), JankType::BufferStuffing);
Ying Wei96eb5352023-11-21 17:37:21 +0000784 EXPECT_EQ(surfaceFrame1->getJankSeverityType(), JankSeverityType::Full);
Adithya Srinivasanead17162021-02-18 02:17:37 +0000785}
786
Alec Mouri363faf02021-01-29 16:34:55 -0800787TEST_F(FrameTimelineTest, presentFenceSignaled_reportsAppMissWithRenderRate) {
Pascal Muetschardac7bcd92023-10-03 15:05:36 +0200788 Fps refreshRate = RR_11;
789 Fps renderRate = RR_30;
Alec Mouri363faf02021-01-29 16:34:55 -0800790 EXPECT_CALL(*mTimeStats,
Adithya Srinivasan58069dc2021-06-04 20:37:02 +0000791 incrementJankyFrames(TimeStats::JankyFramesInfo{refreshRate, renderRate, sUidOne,
792 sLayerNameOne, sGameMode,
793 JankType::AppDeadlineMissed, -4, 0,
794 25}));
Alec Mouri363faf02021-01-29 16:34:55 -0800795 auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE);
Adithya Srinivasan939cd4d2021-02-23 06:18:13 +0000796 int64_t surfaceFrameToken1 = mTokenManager->generateTokenForPredictions({10, 20, 60});
797 int64_t sfToken1 = mTokenManager->generateTokenForPredictions({82, 90, 90});
Huihong Luo3bdef862022-03-03 11:57:19 -0800798 FrameTimelineInfo ftInfo;
799 ftInfo.vsyncId = surfaceFrameToken1;
800 ftInfo.inputEventId = sInputEventId;
Adithya Srinivasan939cd4d2021-02-23 06:18:13 +0000801
Alec Mouri363faf02021-01-29 16:34:55 -0800802 auto surfaceFrame1 =
Huihong Luo3bdef862022-03-03 11:57:19 -0800803 mFrameTimeline->createSurfaceFrameForToken(ftInfo, sPidOne, sUidOne, sLayerIdOne,
804 sLayerNameOne, sLayerNameOne,
805 /*isBuffer*/ true, sGameMode);
Adithya Srinivasan939cd4d2021-02-23 06:18:13 +0000806 surfaceFrame1->setAcquireFenceTime(45);
Pascal Muetschardac7bcd92023-10-03 15:05:36 +0200807 mFrameTimeline->setSfWakeUp(sfToken1, 52, refreshRate, refreshRate);
Alec Mouri363faf02021-01-29 16:34:55 -0800808
809 surfaceFrame1->setPresentState(SurfaceFrame::PresentState::Presented);
810 surfaceFrame1->setRenderRate(renderRate);
811 mFrameTimeline->addSurfaceFrame(surfaceFrame1);
Adithya Srinivasan939cd4d2021-02-23 06:18:13 +0000812 presentFence1->signalForTest(90);
813 mFrameTimeline->setSfPresent(86, presentFence1);
Alec Mouri363faf02021-01-29 16:34:55 -0800814
815 EXPECT_EQ(surfaceFrame1->getJankType(), JankType::AppDeadlineMissed);
Ying Wei96eb5352023-11-21 17:37:21 +0000816 EXPECT_EQ(surfaceFrame1->getJankSeverityType(), JankSeverityType::Full);
Alec Mouri363faf02021-01-29 16:34:55 -0800817}
818
Adithya Srinivasan115ac692021-03-06 01:21:30 +0000819TEST_F(FrameTimelineTest, presentFenceSignaled_displayFramePredictionExpiredPresentsSurfaceFrame) {
Pascal Muetschardac7bcd92023-10-03 15:05:36 +0200820 Fps refreshRate = RR_11;
821 Fps renderRate = RR_30;
Adithya Srinivasan115ac692021-03-06 01:21:30 +0000822
823 EXPECT_CALL(*mTimeStats,
Adithya Srinivasan8a945502021-03-19 19:12:32 +0000824 incrementJankyFrames(
825 TimeStats::JankyFramesInfo{refreshRate, renderRate, sUidOne, sLayerNameOne,
Adithya Srinivasan58069dc2021-06-04 20:37:02 +0000826 sGameMode,
Adithya Srinivasan8a945502021-03-19 19:12:32 +0000827 JankType::Unknown | JankType::AppDeadlineMissed,
Adithya Srinivasande272452021-04-10 00:21:00 +0000828 0, 0, 25}));
Adithya Srinivasan115ac692021-03-06 01:21:30 +0000829 auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE);
830 int64_t surfaceFrameToken1 = mTokenManager->generateTokenForPredictions({10, 20, 60});
831 int64_t sfToken1 = mTokenManager->generateTokenForPredictions({82, 90, 90});
Huihong Luo3bdef862022-03-03 11:57:19 -0800832 FrameTimelineInfo ftInfo;
833 ftInfo.vsyncId = surfaceFrameToken1;
834 ftInfo.inputEventId = sInputEventId;
Adithya Srinivasan115ac692021-03-06 01:21:30 +0000835
836 auto surfaceFrame1 =
Huihong Luo3bdef862022-03-03 11:57:19 -0800837 mFrameTimeline->createSurfaceFrameForToken(ftInfo, sPidOne, sUidOne, sLayerIdOne,
838 sLayerNameOne, sLayerNameOne,
839 /*isBuffer*/ true, sGameMode);
Adithya Srinivasan115ac692021-03-06 01:21:30 +0000840 surfaceFrame1->setAcquireFenceTime(45);
841 // Trigger a prediction expiry
Adithya Srinivasanbed4c4f2021-05-03 20:24:46 +0000842 flushTokens();
Pascal Muetschardac7bcd92023-10-03 15:05:36 +0200843 mFrameTimeline->setSfWakeUp(sfToken1, 52, refreshRate, refreshRate);
Adithya Srinivasan115ac692021-03-06 01:21:30 +0000844
845 surfaceFrame1->setPresentState(SurfaceFrame::PresentState::Presented);
846 surfaceFrame1->setRenderRate(renderRate);
847 mFrameTimeline->addSurfaceFrame(surfaceFrame1);
848 presentFence1->signalForTest(90);
849 mFrameTimeline->setSfPresent(86, presentFence1);
850
851 auto displayFrame = getDisplayFrame(0);
852 EXPECT_EQ(displayFrame->getJankType(), JankType::Unknown);
Ying Wei96eb5352023-11-21 17:37:21 +0000853 EXPECT_EQ(displayFrame->getJankSeverityType(), JankSeverityType::Unknown);
Adithya Srinivasan115ac692021-03-06 01:21:30 +0000854 EXPECT_EQ(displayFrame->getFrameStartMetadata(), FrameStartMetadata::UnknownStart);
855 EXPECT_EQ(displayFrame->getFrameReadyMetadata(), FrameReadyMetadata::UnknownFinish);
856 EXPECT_EQ(displayFrame->getFramePresentMetadata(), FramePresentMetadata::UnknownPresent);
857
858 EXPECT_EQ(surfaceFrame1->getActuals().presentTime, 90);
Adithya Srinivasan8a945502021-03-19 19:12:32 +0000859 EXPECT_EQ(surfaceFrame1->getJankType(), JankType::Unknown | JankType::AppDeadlineMissed);
Ying Wei96eb5352023-11-21 17:37:21 +0000860 EXPECT_EQ(surfaceFrame1->getJankSeverityType(), JankSeverityType::Full);
Adithya Srinivasan115ac692021-03-06 01:21:30 +0000861}
862
Adithya Srinivasan01189672020-10-20 14:23:05 -0700863/*
864 * Tracing Tests
865 *
866 * Trace packets are flushed all the way only when the next packet is traced.
867 * For example: trace<Display/Surface>Frame() will create a TracePacket but not flush it. Only when
868 * another TracePacket is created, the previous one is guaranteed to be flushed. The following tests
869 * will have additional empty frames created for this reason.
870 */
871TEST_F(FrameTimelineTest, tracing_noPacketsSentWithoutTraceStart) {
872 auto tracingSession = getTracingSessionForTest();
873 auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE);
Adithya Srinivasan01189672020-10-20 14:23:05 -0700874 int64_t token1 = mTokenManager->generateTokenForPredictions({10, 20, 30});
Huihong Luo3bdef862022-03-03 11:57:19 -0800875 FrameTimelineInfo ftInfo;
876 ftInfo.vsyncId = token1;
877 ftInfo.inputEventId = sInputEventId;
Siarhei Vishniakoufc434ac2021-01-13 10:28:00 -1000878 auto surfaceFrame1 =
Huihong Luo3bdef862022-03-03 11:57:19 -0800879 mFrameTimeline->createSurfaceFrameForToken(ftInfo, sPidOne, sUidOne, sLayerIdOne,
880 sLayerNameOne, sLayerNameOne,
Adithya Srinivasan58069dc2021-06-04 20:37:02 +0000881 /*isBuffer*/ true, sGameMode);
Adithya Srinivasan01189672020-10-20 14:23:05 -0700882
883 // Set up the display frame
Pascal Muetschardac7bcd92023-10-03 15:05:36 +0200884 mFrameTimeline->setSfWakeUp(token1, 20, RR_11, RR_11);
Adithya Srinivasan9b2ca3e2020-11-10 10:14:17 -0800885 surfaceFrame1->setPresentState(SurfaceFrame::PresentState::Dropped);
886 mFrameTimeline->addSurfaceFrame(surfaceFrame1);
Adithya Srinivasan01189672020-10-20 14:23:05 -0700887 mFrameTimeline->setSfPresent(25, presentFence1);
888 presentFence1->signalForTest(30);
889
Adithya Srinivasan061c14c2021-02-11 01:19:47 +0000890 addEmptyDisplayFrame();
Adithya Srinivasan01189672020-10-20 14:23:05 -0700891
892 auto packets = readFrameTimelinePacketsBlocking(tracingSession.get());
Siarhei Vishniakoufc434ac2021-01-13 10:28:00 -1000893 EXPECT_EQ(packets.size(), 0u);
Adithya Srinivasan01189672020-10-20 14:23:05 -0700894}
895
896TEST_F(FrameTimelineTest, tracing_sanityTest) {
897 auto tracingSession = getTracingSessionForTest();
Adithya Srinivasan9b2ca3e2020-11-10 10:14:17 -0800898 // Layer specific increment
Alec Mouri363faf02021-01-29 16:34:55 -0800899 EXPECT_CALL(*mTimeStats, incrementJankyFrames(_));
Adithya Srinivasan01189672020-10-20 14:23:05 -0700900 auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE);
Adithya Srinivasan01189672020-10-20 14:23:05 -0700901
902 tracingSession->StartBlocking();
903 int64_t token1 = mTokenManager->generateTokenForPredictions({10, 20, 30});
904 int64_t token2 = mTokenManager->generateTokenForPredictions({40, 50, 60});
Huihong Luo3bdef862022-03-03 11:57:19 -0800905 FrameTimelineInfo ftInfo;
906 ftInfo.vsyncId = token1;
907 ftInfo.inputEventId = sInputEventId;
Siarhei Vishniakoufc434ac2021-01-13 10:28:00 -1000908 auto surfaceFrame1 =
Huihong Luo3bdef862022-03-03 11:57:19 -0800909 mFrameTimeline->createSurfaceFrameForToken(ftInfo, sPidOne, sUidOne, sLayerIdOne,
910 sLayerNameOne, sLayerNameOne,
Adithya Srinivasan58069dc2021-06-04 20:37:02 +0000911 /*isBuffer*/ true, sGameMode);
Adithya Srinivasan01189672020-10-20 14:23:05 -0700912
913 // Set up the display frame
Pascal Muetschardac7bcd92023-10-03 15:05:36 +0200914 mFrameTimeline->setSfWakeUp(token2, 20, RR_11, RR_11);
Adithya Srinivasan9b2ca3e2020-11-10 10:14:17 -0800915 surfaceFrame1->setPresentState(SurfaceFrame::PresentState::Presented);
916 mFrameTimeline->addSurfaceFrame(surfaceFrame1);
Adithya Srinivasan01189672020-10-20 14:23:05 -0700917 mFrameTimeline->setSfPresent(25, presentFence1);
918 presentFence1->signalForTest(30);
919
Adithya Srinivasan061c14c2021-02-11 01:19:47 +0000920 addEmptyDisplayFrame();
Adithya Srinivasan05bd2d12021-01-11 18:49:58 +0000921 flushTrace();
Adithya Srinivasan01189672020-10-20 14:23:05 -0700922 tracingSession->StopBlocking();
923
924 auto packets = readFrameTimelinePacketsBlocking(tracingSession.get());
Adithya Srinivasan05bd2d12021-01-11 18:49:58 +0000925 // Display Frame 1 has 8 packets - 4 from DisplayFrame and 4 from SurfaceFrame.
Siarhei Vishniakoufc434ac2021-01-13 10:28:00 -1000926 EXPECT_EQ(packets.size(), 8u);
Adithya Srinivasan01189672020-10-20 14:23:05 -0700927}
928
929TEST_F(FrameTimelineTest, traceDisplayFrame_invalidTokenDoesNotEmitTracePacket) {
930 auto tracingSession = getTracingSessionForTest();
931 auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE);
Adithya Srinivasan01189672020-10-20 14:23:05 -0700932
933 tracingSession->StartBlocking();
Adithya Srinivasan01189672020-10-20 14:23:05 -0700934
935 // Set up the display frame
Pascal Muetschardac7bcd92023-10-03 15:05:36 +0200936 mFrameTimeline->setSfWakeUp(-1, 20, RR_11, RR_11);
Adithya Srinivasan01189672020-10-20 14:23:05 -0700937 mFrameTimeline->setSfPresent(25, presentFence1);
938 presentFence1->signalForTest(30);
939
Adithya Srinivasan061c14c2021-02-11 01:19:47 +0000940 addEmptyDisplayFrame();
Adithya Srinivasan05bd2d12021-01-11 18:49:58 +0000941 flushTrace();
Adithya Srinivasan01189672020-10-20 14:23:05 -0700942 tracingSession->StopBlocking();
943
944 auto packets = readFrameTimelinePacketsBlocking(tracingSession.get());
Siarhei Vishniakoufc434ac2021-01-13 10:28:00 -1000945 EXPECT_EQ(packets.size(), 0u);
Adithya Srinivasan01189672020-10-20 14:23:05 -0700946}
947
948TEST_F(FrameTimelineTest, traceSurfaceFrame_invalidTokenDoesNotEmitTracePacket) {
949 auto tracingSession = getTracingSessionForTest();
950 auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE);
Adithya Srinivasan01189672020-10-20 14:23:05 -0700951
952 tracingSession->StartBlocking();
953 int64_t token1 = mTokenManager->generateTokenForPredictions({10, 20, 30});
Alec Mouriadebf5c2021-01-05 12:57:36 -0800954 auto surfaceFrame1 =
955 mFrameTimeline->createSurfaceFrameForToken({}, sPidOne, sUidOne, sLayerIdOne,
Adithya Srinivasan785addd2021-03-09 00:38:00 +0000956 sLayerNameOne, sLayerNameOne,
Adithya Srinivasan58069dc2021-06-04 20:37:02 +0000957 /*isBuffer*/ true, sGameMode);
Adithya Srinivasan01189672020-10-20 14:23:05 -0700958
959 // Set up the display frame
Pascal Muetschardac7bcd92023-10-03 15:05:36 +0200960 mFrameTimeline->setSfWakeUp(token1, 20, RR_11, RR_11);
Adithya Srinivasan9b2ca3e2020-11-10 10:14:17 -0800961 surfaceFrame1->setPresentState(SurfaceFrame::PresentState::Dropped);
962 mFrameTimeline->addSurfaceFrame(surfaceFrame1);
Adithya Srinivasan01189672020-10-20 14:23:05 -0700963 mFrameTimeline->setSfPresent(25, presentFence1);
964 presentFence1->signalForTest(30);
965
Adithya Srinivasan061c14c2021-02-11 01:19:47 +0000966 addEmptyDisplayFrame();
Adithya Srinivasan05bd2d12021-01-11 18:49:58 +0000967 flushTrace();
Adithya Srinivasan01189672020-10-20 14:23:05 -0700968 tracingSession->StopBlocking();
969
970 auto packets = readFrameTimelinePacketsBlocking(tracingSession.get());
Adithya Srinivasan05bd2d12021-01-11 18:49:58 +0000971 // Display Frame 1 has 4 packets (SurfaceFrame shouldn't be traced since it has an invalid
972 // token).
Siarhei Vishniakoufc434ac2021-01-13 10:28:00 -1000973 EXPECT_EQ(packets.size(), 4u);
Adithya Srinivasan01189672020-10-20 14:23:05 -0700974}
975
Adithya Srinivasan061c14c2021-02-11 01:19:47 +0000976ProtoExpectedDisplayFrameStart createProtoExpectedDisplayFrameStart(int64_t cookie, int64_t token,
977 pid_t pid) {
978 ProtoExpectedDisplayFrameStart proto;
979 proto.set_cookie(cookie);
980 proto.set_token(token);
981 proto.set_pid(pid);
982 return proto;
983}
984
985ProtoActualDisplayFrameStart createProtoActualDisplayFrameStart(
986 int64_t cookie, int64_t token, pid_t pid, ProtoPresentType presentType, bool onTimeFinish,
Ying Wei96eb5352023-11-21 17:37:21 +0000987 bool gpuComposition, ProtoJankType jankType, ProtoJankSeverityType jankSeverityType,
988 ProtoPredictionType predictionType) {
Adithya Srinivasan061c14c2021-02-11 01:19:47 +0000989 ProtoActualDisplayFrameStart proto;
990 proto.set_cookie(cookie);
991 proto.set_token(token);
992 proto.set_pid(pid);
993 proto.set_present_type(presentType);
994 proto.set_on_time_finish(onTimeFinish);
995 proto.set_gpu_composition(gpuComposition);
996 proto.set_jank_type(jankType);
Ying Wei96eb5352023-11-21 17:37:21 +0000997 proto.set_jank_severity_type(jankSeverityType);
Adithya Srinivasan78e58af2021-02-25 00:08:08 +0000998 proto.set_prediction_type(predictionType);
Adithya Srinivasan061c14c2021-02-11 01:19:47 +0000999 return proto;
1000}
1001
1002ProtoExpectedSurfaceFrameStart createProtoExpectedSurfaceFrameStart(int64_t cookie, int64_t token,
1003 int64_t displayFrameToken,
1004 pid_t pid,
1005 std::string layerName) {
1006 ProtoExpectedSurfaceFrameStart proto;
1007 proto.set_cookie(cookie);
1008 proto.set_token(token);
1009 proto.set_display_frame_token(displayFrameToken);
1010 proto.set_pid(pid);
1011 proto.set_layer_name(layerName);
1012 return proto;
1013}
1014
1015ProtoActualSurfaceFrameStart createProtoActualSurfaceFrameStart(
1016 int64_t cookie, int64_t token, int64_t displayFrameToken, pid_t pid, std::string layerName,
1017 ProtoPresentType presentType, bool onTimeFinish, bool gpuComposition,
Ying Wei96eb5352023-11-21 17:37:21 +00001018 ProtoJankType jankType, ProtoJankSeverityType jankSeverityType,
1019 ProtoPredictionType predictionType, bool isBuffer) {
Adithya Srinivasan061c14c2021-02-11 01:19:47 +00001020 ProtoActualSurfaceFrameStart proto;
1021 proto.set_cookie(cookie);
1022 proto.set_token(token);
1023 proto.set_display_frame_token(displayFrameToken);
1024 proto.set_pid(pid);
1025 proto.set_layer_name(layerName);
1026 proto.set_present_type(presentType);
1027 proto.set_on_time_finish(onTimeFinish);
1028 proto.set_gpu_composition(gpuComposition);
1029 proto.set_jank_type(jankType);
Ying Wei96eb5352023-11-21 17:37:21 +00001030 proto.set_jank_severity_type(jankSeverityType);
Adithya Srinivasan78e58af2021-02-25 00:08:08 +00001031 proto.set_prediction_type(predictionType);
Adithya Srinivasan1f9450c2021-06-10 22:39:19 +00001032 proto.set_is_buffer(isBuffer);
Adithya Srinivasan061c14c2021-02-11 01:19:47 +00001033 return proto;
1034}
1035
1036ProtoFrameEnd createProtoFrameEnd(int64_t cookie) {
1037 ProtoFrameEnd proto;
1038 proto.set_cookie(cookie);
1039 return proto;
1040}
1041
Adithya Srinivasan05bd2d12021-01-11 18:49:58 +00001042void validateTraceEvent(const ProtoExpectedDisplayFrameStart& received,
1043 const ProtoExpectedDisplayFrameStart& source) {
1044 ASSERT_TRUE(received.has_cookie());
1045 EXPECT_EQ(received.cookie(), source.cookie());
1046
Adithya Srinivasan01189672020-10-20 14:23:05 -07001047 ASSERT_TRUE(received.has_token());
1048 EXPECT_EQ(received.token(), source.token());
1049
Adithya Srinivasan05bd2d12021-01-11 18:49:58 +00001050 ASSERT_TRUE(received.has_pid());
1051 EXPECT_EQ(received.pid(), source.pid());
1052}
1053
1054void validateTraceEvent(const ProtoActualDisplayFrameStart& received,
1055 const ProtoActualDisplayFrameStart& source) {
1056 ASSERT_TRUE(received.has_cookie());
1057 EXPECT_EQ(received.cookie(), source.cookie());
1058
1059 ASSERT_TRUE(received.has_token());
1060 EXPECT_EQ(received.token(), source.token());
1061
1062 ASSERT_TRUE(received.has_pid());
1063 EXPECT_EQ(received.pid(), source.pid());
1064
Adithya Srinivasan01189672020-10-20 14:23:05 -07001065 ASSERT_TRUE(received.has_present_type());
1066 EXPECT_EQ(received.present_type(), source.present_type());
1067 ASSERT_TRUE(received.has_on_time_finish());
1068 EXPECT_EQ(received.on_time_finish(), source.on_time_finish());
1069 ASSERT_TRUE(received.has_gpu_composition());
1070 EXPECT_EQ(received.gpu_composition(), source.gpu_composition());
1071 ASSERT_TRUE(received.has_jank_type());
1072 EXPECT_EQ(received.jank_type(), source.jank_type());
Ying Wei96eb5352023-11-21 17:37:21 +00001073 ASSERT_TRUE(received.has_jank_severity_type());
1074 EXPECT_EQ(received.jank_severity_type(), source.jank_severity_type());
Adithya Srinivasan78e58af2021-02-25 00:08:08 +00001075 ASSERT_TRUE(received.has_prediction_type());
1076 EXPECT_EQ(received.prediction_type(), source.prediction_type());
Adithya Srinivasan01189672020-10-20 14:23:05 -07001077}
1078
Adithya Srinivasan05bd2d12021-01-11 18:49:58 +00001079void validateTraceEvent(const ProtoExpectedSurfaceFrameStart& received,
1080 const ProtoExpectedSurfaceFrameStart& source) {
1081 ASSERT_TRUE(received.has_cookie());
1082 EXPECT_EQ(received.cookie(), source.cookie());
1083
Adithya Srinivasan01189672020-10-20 14:23:05 -07001084 ASSERT_TRUE(received.has_token());
1085 EXPECT_EQ(received.token(), source.token());
1086
1087 ASSERT_TRUE(received.has_display_frame_token());
1088 EXPECT_EQ(received.display_frame_token(), source.display_frame_token());
1089
Adithya Srinivasan05bd2d12021-01-11 18:49:58 +00001090 ASSERT_TRUE(received.has_pid());
1091 EXPECT_EQ(received.pid(), source.pid());
1092
1093 ASSERT_TRUE(received.has_layer_name());
1094 EXPECT_EQ(received.layer_name(), source.layer_name());
1095}
1096
1097void validateTraceEvent(const ProtoActualSurfaceFrameStart& received,
1098 const ProtoActualSurfaceFrameStart& source) {
1099 ASSERT_TRUE(received.has_cookie());
1100 EXPECT_EQ(received.cookie(), source.cookie());
1101
1102 ASSERT_TRUE(received.has_token());
1103 EXPECT_EQ(received.token(), source.token());
1104
1105 ASSERT_TRUE(received.has_display_frame_token());
1106 EXPECT_EQ(received.display_frame_token(), source.display_frame_token());
1107
1108 ASSERT_TRUE(received.has_pid());
1109 EXPECT_EQ(received.pid(), source.pid());
1110
1111 ASSERT_TRUE(received.has_layer_name());
1112 EXPECT_EQ(received.layer_name(), source.layer_name());
1113
Adithya Srinivasan01189672020-10-20 14:23:05 -07001114 ASSERT_TRUE(received.has_present_type());
1115 EXPECT_EQ(received.present_type(), source.present_type());
1116 ASSERT_TRUE(received.has_on_time_finish());
1117 EXPECT_EQ(received.on_time_finish(), source.on_time_finish());
1118 ASSERT_TRUE(received.has_gpu_composition());
1119 EXPECT_EQ(received.gpu_composition(), source.gpu_composition());
1120 ASSERT_TRUE(received.has_jank_type());
1121 EXPECT_EQ(received.jank_type(), source.jank_type());
Ying Wei96eb5352023-11-21 17:37:21 +00001122 ASSERT_TRUE(received.has_jank_severity_type());
1123 EXPECT_EQ(received.jank_severity_type(), source.jank_severity_type());
Adithya Srinivasan78e58af2021-02-25 00:08:08 +00001124 ASSERT_TRUE(received.has_prediction_type());
1125 EXPECT_EQ(received.prediction_type(), source.prediction_type());
Adithya Srinivasan1f9450c2021-06-10 22:39:19 +00001126 ASSERT_TRUE(received.has_is_buffer());
1127 EXPECT_EQ(received.is_buffer(), source.is_buffer());
Adithya Srinivasan05bd2d12021-01-11 18:49:58 +00001128}
Adithya Srinivasan01189672020-10-20 14:23:05 -07001129
Adithya Srinivasan05bd2d12021-01-11 18:49:58 +00001130void validateTraceEvent(const ProtoFrameEnd& received, const ProtoFrameEnd& source) {
1131 ASSERT_TRUE(received.has_cookie());
1132 EXPECT_EQ(received.cookie(), source.cookie());
Adithya Srinivasan01189672020-10-20 14:23:05 -07001133}
1134
Sally Qiaa107742023-09-29 14:53:14 -07001135TEST_F(FrameTimelineTest, traceDisplayFrameSkipped) {
Sally Qif5721252023-11-17 11:14:53 -08001136 SET_FLAG_FOR_TEST(com::android::graphics::surfaceflinger::flags::add_sf_skipped_frames_to_trace,
1137 true);
1138
Sally Qiaa107742023-09-29 14:53:14 -07001139 // setup 2 display frames
1140 // DF 1: [22,40] -> [5, 40]
1141 // DF : [36, 70] (Skipped one, added by the trace)
1142 // DF 2: [82, 100] -> SF [25, 70]
1143 auto tracingSession = getTracingSessionForTest();
1144 tracingSession->StartBlocking();
1145 int64_t sfToken1 = mTokenManager->generateTokenForPredictions({22, 30, 40});
1146 int64_t sfToken2 = mTokenManager->generateTokenForPredictions({82, 90, 100});
1147 int64_t surfaceFrameToken1 = mTokenManager->generateTokenForPredictions({5, 16, 40});
1148 int64_t surfaceFrameToken2 = mTokenManager->generateTokenForPredictions({25, 36, 70});
1149 auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE);
1150
1151 int64_t traceCookie = snoopCurrentTraceCookie();
1152
1153 // set up 1st display frame
1154 FrameTimelineInfo ftInfo1;
1155 ftInfo1.vsyncId = surfaceFrameToken1;
1156 ftInfo1.inputEventId = sInputEventId;
1157 auto surfaceFrame1 =
1158 mFrameTimeline->createSurfaceFrameForToken(ftInfo1, sPidOne, sUidOne, sLayerIdOne,
1159 sLayerNameOne, sLayerNameOne,
1160 /*isBuffer*/ true, sGameMode);
1161 surfaceFrame1->setAcquireFenceTime(16);
1162 mFrameTimeline->setSfWakeUp(sfToken1, 22, RR_11, RR_30);
1163 surfaceFrame1->setPresentState(SurfaceFrame::PresentState::Presented);
1164 mFrameTimeline->addSurfaceFrame(surfaceFrame1);
1165 mFrameTimeline->setSfPresent(30, presentFence1);
1166 presentFence1->signalForTest(40);
1167
1168 // Trigger a flush by finalizing the next DisplayFrame
1169 auto presentFence2 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE);
1170 FrameTimelineInfo ftInfo2;
1171 ftInfo2.vsyncId = surfaceFrameToken2;
1172 ftInfo2.inputEventId = sInputEventId;
1173 auto surfaceFrame2 =
1174 mFrameTimeline->createSurfaceFrameForToken(ftInfo2, sPidOne, sUidOne, sLayerIdOne,
1175 sLayerNameOne, sLayerNameOne,
1176 /*isBuffer*/ true, sGameMode);
1177
1178 // set up 2nd display frame
1179 surfaceFrame2->setAcquireFenceTime(36);
1180 mFrameTimeline->setSfWakeUp(sfToken2, 82, RR_11, RR_30);
1181 surfaceFrame2->setPresentState(SurfaceFrame::PresentState::Presented);
1182 mFrameTimeline->addSurfaceFrame(surfaceFrame2);
1183 mFrameTimeline->setSfPresent(90, presentFence2);
1184 presentFence2->signalForTest(100);
1185
1186 // the token of skipped Display Frame
1187 auto protoSkippedActualDisplayFrameStart =
1188 createProtoActualDisplayFrameStart(traceCookie + 9, 0, kSurfaceFlingerPid,
1189 FrameTimelineEvent::PRESENT_DROPPED, true, false,
1190 FrameTimelineEvent::JANK_DROPPED,
Ying Wei96eb5352023-11-21 17:37:21 +00001191 FrameTimelineEvent::SEVERITY_NONE,
Sally Qiaa107742023-09-29 14:53:14 -07001192 FrameTimelineEvent::PREDICTION_VALID);
1193 auto protoSkippedActualDisplayFrameEnd = createProtoFrameEnd(traceCookie + 9);
1194
1195 // Trigger a flush by finalizing the next DisplayFrame
1196 addEmptyDisplayFrame();
1197 flushTrace();
1198 tracingSession->StopBlocking();
1199
1200 auto packets = readFrameTimelinePacketsBlocking(tracingSession.get());
1201 // 8 Valid Display Frames + 8 Valid Surface Frames + 2 Skipped Display Frames
1202 EXPECT_EQ(packets.size(), 18u);
1203
1204 // Packet - 16: Actual skipped Display Frame Start
1205 // the timestamp should be equal to the 2nd expected surface frame's end time
1206 const auto& packet16 = packets[16];
1207 ASSERT_TRUE(packet16.has_timestamp());
1208 EXPECT_EQ(packet16.timestamp(), 36u);
1209 ASSERT_TRUE(packet16.has_frame_timeline_event());
1210
1211 const auto& event16 = packet16.frame_timeline_event();
1212 const auto& actualSkippedDisplayFrameStart = event16.actual_display_frame_start();
1213 validateTraceEvent(actualSkippedDisplayFrameStart, protoSkippedActualDisplayFrameStart);
1214
1215 // Packet - 17: Actual skipped Display Frame End
1216 // the timestamp should be equal to the 2nd expected surface frame's present time
1217 const auto& packet17 = packets[17];
1218 ASSERT_TRUE(packet17.has_timestamp());
1219 EXPECT_EQ(packet17.timestamp(), 70u);
1220 ASSERT_TRUE(packet17.has_frame_timeline_event());
1221
1222 const auto& event17 = packet17.frame_timeline_event();
1223 const auto& actualSkippedDisplayFrameEnd = event17.frame_end();
1224 validateTraceEvent(actualSkippedDisplayFrameEnd, protoSkippedActualDisplayFrameEnd);
1225}
1226
Adithya Srinivasan01189672020-10-20 14:23:05 -07001227TEST_F(FrameTimelineTest, traceDisplayFrame_emitsValidTracePacket) {
1228 auto tracingSession = getTracingSessionForTest();
1229 auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE);
Adithya Srinivasan01189672020-10-20 14:23:05 -07001230
1231 tracingSession->StartBlocking();
Ady Abraham57a8ab42023-01-26 15:28:19 -08001232
1233 // Add an empty surface frame so that display frame would get traced.
1234 addEmptySurfaceFrame();
Adithya Srinivasan939cd4d2021-02-23 06:18:13 +00001235 int64_t displayFrameToken1 = mTokenManager->generateTokenForPredictions({10, 30, 30});
Adithya Srinivasan01189672020-10-20 14:23:05 -07001236
1237 // Set up the display frame
Pascal Muetschardac7bcd92023-10-03 15:05:36 +02001238 mFrameTimeline->setSfWakeUp(displayFrameToken1, 20, RR_11, RR_11);
Adithya Srinivasan01189672020-10-20 14:23:05 -07001239 mFrameTimeline->setSfPresent(26, presentFence1);
1240 presentFence1->signalForTest(31);
1241
Adithya Srinivasan05bd2d12021-01-11 18:49:58 +00001242 int64_t traceCookie = snoopCurrentTraceCookie();
Adithya Srinivasan061c14c2021-02-11 01:19:47 +00001243 auto protoExpectedDisplayFrameStart =
1244 createProtoExpectedDisplayFrameStart(traceCookie + 1, displayFrameToken1,
1245 kSurfaceFlingerPid);
1246 auto protoExpectedDisplayFrameEnd = createProtoFrameEnd(traceCookie + 1);
1247 auto protoActualDisplayFrameStart =
1248 createProtoActualDisplayFrameStart(traceCookie + 2, displayFrameToken1,
1249 kSurfaceFlingerPid,
1250 FrameTimelineEvent::PRESENT_ON_TIME, true, false,
Adithya Srinivasan78e58af2021-02-25 00:08:08 +00001251 FrameTimelineEvent::JANK_NONE,
Ying Wei96eb5352023-11-21 17:37:21 +00001252 FrameTimelineEvent::SEVERITY_NONE,
Adithya Srinivasan78e58af2021-02-25 00:08:08 +00001253 FrameTimelineEvent::PREDICTION_VALID);
Adithya Srinivasan061c14c2021-02-11 01:19:47 +00001254 auto protoActualDisplayFrameEnd = createProtoFrameEnd(traceCookie + 2);
Adithya Srinivasan05bd2d12021-01-11 18:49:58 +00001255
Adithya Srinivasan061c14c2021-02-11 01:19:47 +00001256 addEmptyDisplayFrame();
Adithya Srinivasan05bd2d12021-01-11 18:49:58 +00001257 flushTrace();
Adithya Srinivasan01189672020-10-20 14:23:05 -07001258 tracingSession->StopBlocking();
1259
1260 auto packets = readFrameTimelinePacketsBlocking(tracingSession.get());
Siarhei Vishniakoufc434ac2021-01-13 10:28:00 -10001261 EXPECT_EQ(packets.size(), 4u);
Adithya Srinivasan01189672020-10-20 14:23:05 -07001262
Adithya Srinivasan05bd2d12021-01-11 18:49:58 +00001263 // Packet - 0 : ExpectedDisplayFrameStart
1264 const auto& packet0 = packets[0];
1265 ASSERT_TRUE(packet0.has_timestamp());
Siarhei Vishniakoufc434ac2021-01-13 10:28:00 -10001266 EXPECT_EQ(packet0.timestamp(), 10u);
Adithya Srinivasan05bd2d12021-01-11 18:49:58 +00001267 ASSERT_TRUE(packet0.has_frame_timeline_event());
Adithya Srinivasan01189672020-10-20 14:23:05 -07001268
Adithya Srinivasan05bd2d12021-01-11 18:49:58 +00001269 const auto& event0 = packet0.frame_timeline_event();
1270 ASSERT_TRUE(event0.has_expected_display_frame_start());
1271 const auto& expectedDisplayFrameStart = event0.expected_display_frame_start();
1272 validateTraceEvent(expectedDisplayFrameStart, protoExpectedDisplayFrameStart);
1273
1274 // Packet - 1 : FrameEnd (ExpectedDisplayFrame)
1275 const auto& packet1 = packets[1];
1276 ASSERT_TRUE(packet1.has_timestamp());
Adithya Srinivasan939cd4d2021-02-23 06:18:13 +00001277 EXPECT_EQ(packet1.timestamp(), 30u);
Adithya Srinivasan05bd2d12021-01-11 18:49:58 +00001278 ASSERT_TRUE(packet1.has_frame_timeline_event());
1279
1280 const auto& event1 = packet1.frame_timeline_event();
1281 ASSERT_TRUE(event1.has_frame_end());
1282 const auto& expectedDisplayFrameEnd = event1.frame_end();
1283 validateTraceEvent(expectedDisplayFrameEnd, protoExpectedDisplayFrameEnd);
1284
1285 // Packet - 2 : ActualDisplayFrameStart
1286 const auto& packet2 = packets[2];
1287 ASSERT_TRUE(packet2.has_timestamp());
Siarhei Vishniakoufc434ac2021-01-13 10:28:00 -10001288 EXPECT_EQ(packet2.timestamp(), 20u);
Adithya Srinivasan05bd2d12021-01-11 18:49:58 +00001289 ASSERT_TRUE(packet2.has_frame_timeline_event());
1290
1291 const auto& event2 = packet2.frame_timeline_event();
1292 ASSERT_TRUE(event2.has_actual_display_frame_start());
1293 const auto& actualDisplayFrameStart = event2.actual_display_frame_start();
1294 validateTraceEvent(actualDisplayFrameStart, protoActualDisplayFrameStart);
1295
1296 // Packet - 3 : FrameEnd (ActualDisplayFrame)
1297 const auto& packet3 = packets[3];
1298 ASSERT_TRUE(packet3.has_timestamp());
Adithya Srinivasan1a971632021-02-26 23:10:29 +00001299 EXPECT_EQ(packet3.timestamp(), 31u);
Adithya Srinivasan05bd2d12021-01-11 18:49:58 +00001300 ASSERT_TRUE(packet3.has_frame_timeline_event());
1301
1302 const auto& event3 = packet3.frame_timeline_event();
1303 ASSERT_TRUE(event3.has_frame_end());
1304 const auto& actualDisplayFrameEnd = event3.frame_end();
1305 validateTraceEvent(actualDisplayFrameEnd, protoActualDisplayFrameEnd);
Adithya Srinivasan01189672020-10-20 14:23:05 -07001306}
1307
Adithya Srinivasan061c14c2021-02-11 01:19:47 +00001308TEST_F(FrameTimelineTest, traceDisplayFrame_predictionExpiredDoesNotTraceExpectedTimeline) {
1309 auto tracingSession = getTracingSessionForTest();
1310 auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE);
1311
1312 tracingSession->StartBlocking();
1313 int64_t displayFrameToken1 = mTokenManager->generateTokenForPredictions({10, 25, 30});
1314 // Flush the token so that it would expire
Adithya Srinivasanbed4c4f2021-05-03 20:24:46 +00001315 flushTokens();
Adithya Srinivasan061c14c2021-02-11 01:19:47 +00001316
Ady Abraham57a8ab42023-01-26 15:28:19 -08001317 // Add an empty surface frame so that display frame would get traced.
1318 addEmptySurfaceFrame();
1319
Adithya Srinivasan061c14c2021-02-11 01:19:47 +00001320 // Set up the display frame
Pascal Muetschardac7bcd92023-10-03 15:05:36 +02001321 mFrameTimeline->setSfWakeUp(displayFrameToken1, 20, RR_11, RR_11);
Adithya Srinivasan061c14c2021-02-11 01:19:47 +00001322 mFrameTimeline->setSfPresent(26, presentFence1);
1323 presentFence1->signalForTest(31);
1324
1325 int64_t traceCookie = snoopCurrentTraceCookie();
1326
1327 auto protoActualDisplayFrameStart =
1328 createProtoActualDisplayFrameStart(traceCookie + 1, displayFrameToken1,
1329 kSurfaceFlingerPid,
1330 FrameTimelineEvent::PRESENT_UNSPECIFIED, false,
Adithya Srinivasan78e58af2021-02-25 00:08:08 +00001331 false, FrameTimelineEvent::JANK_UNKNOWN,
Ying Wei96eb5352023-11-21 17:37:21 +00001332 FrameTimelineEvent::SEVERITY_UNKNOWN,
Adithya Srinivasan78e58af2021-02-25 00:08:08 +00001333 FrameTimelineEvent::PREDICTION_EXPIRED);
Adithya Srinivasan061c14c2021-02-11 01:19:47 +00001334 auto protoActualDisplayFrameEnd = createProtoFrameEnd(traceCookie + 1);
1335
1336 addEmptyDisplayFrame();
1337 flushTrace();
1338 tracingSession->StopBlocking();
1339
1340 auto packets = readFrameTimelinePacketsBlocking(tracingSession.get());
1341 // Only actual timeline packets should be in the trace
1342 EXPECT_EQ(packets.size(), 2u);
1343
1344 // Packet - 0 : ActualDisplayFrameStart
1345 const auto& packet0 = packets[0];
1346 ASSERT_TRUE(packet0.has_timestamp());
1347 EXPECT_EQ(packet0.timestamp(), 20u);
1348 ASSERT_TRUE(packet0.has_frame_timeline_event());
1349
1350 const auto& event0 = packet0.frame_timeline_event();
1351 ASSERT_TRUE(event0.has_actual_display_frame_start());
1352 const auto& actualDisplayFrameStart = event0.actual_display_frame_start();
1353 validateTraceEvent(actualDisplayFrameStart, protoActualDisplayFrameStart);
1354
1355 // Packet - 1 : FrameEnd (ActualDisplayFrame)
1356 const auto& packet1 = packets[1];
1357 ASSERT_TRUE(packet1.has_timestamp());
Adithya Srinivasan1a971632021-02-26 23:10:29 +00001358 EXPECT_EQ(packet1.timestamp(), 31u);
Adithya Srinivasan061c14c2021-02-11 01:19:47 +00001359 ASSERT_TRUE(packet1.has_frame_timeline_event());
1360
1361 const auto& event1 = packet1.frame_timeline_event();
1362 ASSERT_TRUE(event1.has_frame_end());
1363 const auto& actualDisplayFrameEnd = event1.frame_end();
1364 validateTraceEvent(actualDisplayFrameEnd, protoActualDisplayFrameEnd);
1365}
1366
Adithya Srinivasan01189672020-10-20 14:23:05 -07001367TEST_F(FrameTimelineTest, traceSurfaceFrame_emitsValidTracePacket) {
1368 auto tracingSession = getTracingSessionForTest();
Adithya Srinivasan9b2ca3e2020-11-10 10:14:17 -08001369 // Layer specific increment
Edgar Arriaga631e4252023-03-02 02:11:24 +00001370 EXPECT_CALL(*mTimeStats, incrementJankyFrames(_)).Times(2);
Adithya Srinivasan01189672020-10-20 14:23:05 -07001371 auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE);
1372 auto presentFence2 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE);
1373
1374 tracingSession->StartBlocking();
1375 int64_t surfaceFrameToken = mTokenManager->generateTokenForPredictions({10, 25, 40});
1376 int64_t displayFrameToken1 = mTokenManager->generateTokenForPredictions({30, 35, 40});
Adithya Srinivasan01189672020-10-20 14:23:05 -07001377
Huihong Luo3bdef862022-03-03 11:57:19 -08001378 FrameTimelineInfo ftInfo;
1379 ftInfo.vsyncId = surfaceFrameToken;
1380 ftInfo.inputEventId = sInputEventId;
1381
Adithya Srinivasan01189672020-10-20 14:23:05 -07001382 auto surfaceFrame1 =
Huihong Luo3bdef862022-03-03 11:57:19 -08001383 mFrameTimeline->createSurfaceFrameForToken(ftInfo, sPidOne, sUidOne, sLayerIdOne,
1384 sLayerNameOne, sLayerNameOne,
1385 /*isBuffer*/ true, sGameMode);
Adithya Srinivasan061c14c2021-02-11 01:19:47 +00001386 auto surfaceFrame2 =
Huihong Luo3bdef862022-03-03 11:57:19 -08001387 mFrameTimeline->createSurfaceFrameForToken(ftInfo, sPidOne, sUidOne, sLayerIdOne,
1388 sLayerNameOne, sLayerNameOne,
1389 /*isBuffer*/ true, sGameMode);
Adithya Srinivasan061c14c2021-02-11 01:19:47 +00001390 surfaceFrame1->setActualQueueTime(10);
1391 surfaceFrame1->setDropTime(15);
1392
1393 surfaceFrame2->setActualQueueTime(15);
1394 surfaceFrame2->setAcquireFenceTime(20);
Adithya Srinivasan01189672020-10-20 14:23:05 -07001395
Adithya Srinivasan05bd2d12021-01-11 18:49:58 +00001396 // First 2 cookies will be used by the DisplayFrame
1397 int64_t traceCookie = snoopCurrentTraceCookie() + 2;
1398
Adithya Srinivasan061c14c2021-02-11 01:19:47 +00001399 auto protoDroppedSurfaceFrameExpectedStart =
1400 createProtoExpectedSurfaceFrameStart(traceCookie + 1, surfaceFrameToken,
1401 displayFrameToken1, sPidOne, sLayerNameOne);
1402 auto protoDroppedSurfaceFrameExpectedEnd = createProtoFrameEnd(traceCookie + 1);
1403 auto protoDroppedSurfaceFrameActualStart =
1404 createProtoActualSurfaceFrameStart(traceCookie + 2, surfaceFrameToken,
1405 displayFrameToken1, sPidOne, sLayerNameOne,
Edgar Arriaga631e4252023-03-02 02:11:24 +00001406 FrameTimelineEvent::PRESENT_DROPPED, true, false,
1407 FrameTimelineEvent::JANK_DROPPED,
Ying Wei96eb5352023-11-21 17:37:21 +00001408 FrameTimelineEvent::SEVERITY_UNKNOWN,
Adithya Srinivasan1f9450c2021-06-10 22:39:19 +00001409 FrameTimelineEvent::PREDICTION_VALID, true);
Adithya Srinivasan061c14c2021-02-11 01:19:47 +00001410 auto protoDroppedSurfaceFrameActualEnd = createProtoFrameEnd(traceCookie + 2);
Adithya Srinivasan05bd2d12021-01-11 18:49:58 +00001411
Adithya Srinivasan061c14c2021-02-11 01:19:47 +00001412 auto protoPresentedSurfaceFrameExpectedStart =
1413 createProtoExpectedSurfaceFrameStart(traceCookie + 3, surfaceFrameToken,
1414 displayFrameToken1, sPidOne, sLayerNameOne);
1415 auto protoPresentedSurfaceFrameExpectedEnd = createProtoFrameEnd(traceCookie + 3);
1416 auto protoPresentedSurfaceFrameActualStart =
1417 createProtoActualSurfaceFrameStart(traceCookie + 4, surfaceFrameToken,
1418 displayFrameToken1, sPidOne, sLayerNameOne,
1419 FrameTimelineEvent::PRESENT_ON_TIME, true, false,
Adithya Srinivasan78e58af2021-02-25 00:08:08 +00001420 FrameTimelineEvent::JANK_NONE,
Ying Wei96eb5352023-11-21 17:37:21 +00001421 FrameTimelineEvent::SEVERITY_NONE,
Adithya Srinivasan1f9450c2021-06-10 22:39:19 +00001422 FrameTimelineEvent::PREDICTION_VALID, true);
Adithya Srinivasan061c14c2021-02-11 01:19:47 +00001423 auto protoPresentedSurfaceFrameActualEnd = createProtoFrameEnd(traceCookie + 4);
Adithya Srinivasan01189672020-10-20 14:23:05 -07001424
1425 // Set up the display frame
Pascal Muetschardac7bcd92023-10-03 15:05:36 +02001426 mFrameTimeline->setSfWakeUp(displayFrameToken1, 20, RR_11, RR_11);
Adithya Srinivasan061c14c2021-02-11 01:19:47 +00001427 surfaceFrame1->setPresentState(SurfaceFrame::PresentState::Dropped);
1428 surfaceFrame2->setPresentState(SurfaceFrame::PresentState::Presented);
Adithya Srinivasan9b2ca3e2020-11-10 10:14:17 -08001429 mFrameTimeline->addSurfaceFrame(surfaceFrame1);
Adithya Srinivasan061c14c2021-02-11 01:19:47 +00001430 mFrameTimeline->addSurfaceFrame(surfaceFrame2);
Adithya Srinivasan01189672020-10-20 14:23:05 -07001431 mFrameTimeline->setSfPresent(26, presentFence1);
Adithya Srinivasan9b2ca3e2020-11-10 10:14:17 -08001432 presentFence1->signalForTest(40);
Adithya Srinivasan01189672020-10-20 14:23:05 -07001433
Adithya Srinivasan061c14c2021-02-11 01:19:47 +00001434 addEmptyDisplayFrame();
Adithya Srinivasan05bd2d12021-01-11 18:49:58 +00001435 flushTrace();
Adithya Srinivasan01189672020-10-20 14:23:05 -07001436 tracingSession->StopBlocking();
1437
1438 auto packets = readFrameTimelinePacketsBlocking(tracingSession.get());
Adithya Srinivasan061c14c2021-02-11 01:19:47 +00001439 // 4 DisplayFrame + 4 DroppedSurfaceFrame + 4 PresentedSurfaceFrame
1440 EXPECT_EQ(packets.size(), 12u);
Adithya Srinivasan01189672020-10-20 14:23:05 -07001441
Adithya Srinivasan061c14c2021-02-11 01:19:47 +00001442 // Packet - 4 : ExpectedSurfaceFrameStart1
Adithya Srinivasan05bd2d12021-01-11 18:49:58 +00001443 const auto& packet4 = packets[4];
1444 ASSERT_TRUE(packet4.has_timestamp());
Siarhei Vishniakoufc434ac2021-01-13 10:28:00 -10001445 EXPECT_EQ(packet4.timestamp(), 10u);
Adithya Srinivasan05bd2d12021-01-11 18:49:58 +00001446 ASSERT_TRUE(packet4.has_frame_timeline_event());
Adithya Srinivasan01189672020-10-20 14:23:05 -07001447
Adithya Srinivasan05bd2d12021-01-11 18:49:58 +00001448 const auto& event4 = packet4.frame_timeline_event();
1449 ASSERT_TRUE(event4.has_expected_surface_frame_start());
Adithya Srinivasan061c14c2021-02-11 01:19:47 +00001450 const auto& expectedSurfaceFrameStart1 = event4.expected_surface_frame_start();
1451 validateTraceEvent(expectedSurfaceFrameStart1, protoDroppedSurfaceFrameExpectedStart);
Adithya Srinivasan05bd2d12021-01-11 18:49:58 +00001452
Adithya Srinivasan061c14c2021-02-11 01:19:47 +00001453 // Packet - 5 : FrameEnd (ExpectedSurfaceFrame1)
Adithya Srinivasan05bd2d12021-01-11 18:49:58 +00001454 const auto& packet5 = packets[5];
1455 ASSERT_TRUE(packet5.has_timestamp());
Siarhei Vishniakoufc434ac2021-01-13 10:28:00 -10001456 EXPECT_EQ(packet5.timestamp(), 25u);
Adithya Srinivasan05bd2d12021-01-11 18:49:58 +00001457 ASSERT_TRUE(packet5.has_frame_timeline_event());
1458
1459 const auto& event5 = packet5.frame_timeline_event();
1460 ASSERT_TRUE(event5.has_frame_end());
Adithya Srinivasan061c14c2021-02-11 01:19:47 +00001461 const auto& expectedSurfaceFrameEnd1 = event5.frame_end();
1462 validateTraceEvent(expectedSurfaceFrameEnd1, protoDroppedSurfaceFrameExpectedEnd);
Adithya Srinivasan05bd2d12021-01-11 18:49:58 +00001463
Adithya Srinivasan061c14c2021-02-11 01:19:47 +00001464 // Packet - 6 : ActualSurfaceFrameStart1
Adithya Srinivasan05bd2d12021-01-11 18:49:58 +00001465 const auto& packet6 = packets[6];
1466 ASSERT_TRUE(packet6.has_timestamp());
Siarhei Vishniakoufc434ac2021-01-13 10:28:00 -10001467 EXPECT_EQ(packet6.timestamp(), 10u);
Adithya Srinivasan05bd2d12021-01-11 18:49:58 +00001468 ASSERT_TRUE(packet6.has_frame_timeline_event());
1469
1470 const auto& event6 = packet6.frame_timeline_event();
1471 ASSERT_TRUE(event6.has_actual_surface_frame_start());
Adithya Srinivasan061c14c2021-02-11 01:19:47 +00001472 const auto& actualSurfaceFrameStart1 = event6.actual_surface_frame_start();
1473 validateTraceEvent(actualSurfaceFrameStart1, protoDroppedSurfaceFrameActualStart);
Adithya Srinivasan05bd2d12021-01-11 18:49:58 +00001474
Adithya Srinivasan061c14c2021-02-11 01:19:47 +00001475 // Packet - 7 : FrameEnd (ActualSurfaceFrame1)
Adithya Srinivasan05bd2d12021-01-11 18:49:58 +00001476 const auto& packet7 = packets[7];
1477 ASSERT_TRUE(packet7.has_timestamp());
Adithya Srinivasan061c14c2021-02-11 01:19:47 +00001478 EXPECT_EQ(packet7.timestamp(), 15u);
Adithya Srinivasan05bd2d12021-01-11 18:49:58 +00001479 ASSERT_TRUE(packet7.has_frame_timeline_event());
1480
1481 const auto& event7 = packet7.frame_timeline_event();
1482 ASSERT_TRUE(event7.has_frame_end());
Adithya Srinivasan061c14c2021-02-11 01:19:47 +00001483 const auto& actualSurfaceFrameEnd1 = event7.frame_end();
1484 validateTraceEvent(actualSurfaceFrameEnd1, protoDroppedSurfaceFrameActualEnd);
1485
1486 // Packet - 8 : ExpectedSurfaceFrameStart2
1487 const auto& packet8 = packets[8];
1488 ASSERT_TRUE(packet8.has_timestamp());
1489 EXPECT_EQ(packet8.timestamp(), 10u);
1490 ASSERT_TRUE(packet8.has_frame_timeline_event());
1491
1492 const auto& event8 = packet8.frame_timeline_event();
1493 ASSERT_TRUE(event8.has_expected_surface_frame_start());
1494 const auto& expectedSurfaceFrameStart2 = event8.expected_surface_frame_start();
1495 validateTraceEvent(expectedSurfaceFrameStart2, protoPresentedSurfaceFrameExpectedStart);
1496
1497 // Packet - 9 : FrameEnd (ExpectedSurfaceFrame2)
1498 const auto& packet9 = packets[9];
1499 ASSERT_TRUE(packet9.has_timestamp());
1500 EXPECT_EQ(packet9.timestamp(), 25u);
1501 ASSERT_TRUE(packet9.has_frame_timeline_event());
1502
1503 const auto& event9 = packet9.frame_timeline_event();
1504 ASSERT_TRUE(event9.has_frame_end());
1505 const auto& expectedSurfaceFrameEnd2 = event9.frame_end();
1506 validateTraceEvent(expectedSurfaceFrameEnd2, protoPresentedSurfaceFrameExpectedEnd);
1507
1508 // Packet - 10 : ActualSurfaceFrameStart2
1509 const auto& packet10 = packets[10];
1510 ASSERT_TRUE(packet10.has_timestamp());
1511 EXPECT_EQ(packet10.timestamp(), 10u);
1512 ASSERT_TRUE(packet10.has_frame_timeline_event());
1513
1514 const auto& event10 = packet10.frame_timeline_event();
1515 ASSERT_TRUE(event10.has_actual_surface_frame_start());
1516 const auto& actualSurfaceFrameStart2 = event10.actual_surface_frame_start();
1517 validateTraceEvent(actualSurfaceFrameStart2, protoPresentedSurfaceFrameActualStart);
1518
1519 // Packet - 11 : FrameEnd (ActualSurfaceFrame2)
1520 const auto& packet11 = packets[11];
1521 ASSERT_TRUE(packet11.has_timestamp());
1522 EXPECT_EQ(packet11.timestamp(), 20u);
1523 ASSERT_TRUE(packet11.has_frame_timeline_event());
1524
1525 const auto& event11 = packet11.frame_timeline_event();
1526 ASSERT_TRUE(event11.has_frame_end());
1527 const auto& actualSurfaceFrameEnd2 = event11.frame_end();
1528 validateTraceEvent(actualSurfaceFrameEnd2, protoPresentedSurfaceFrameActualEnd);
1529}
1530
Ady Abrahame43ff722022-02-15 14:44:25 -08001531TEST_F(FrameTimelineTest, traceSurfaceFrame_predictionExpiredIsAppMissedDeadline) {
Adithya Srinivasan061c14c2021-02-11 01:19:47 +00001532 auto tracingSession = getTracingSessionForTest();
1533 auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE);
1534
1535 tracingSession->StartBlocking();
Adithya Srinivasan939cd4d2021-02-23 06:18:13 +00001536 constexpr nsecs_t appStartTime = std::chrono::nanoseconds(10ms).count();
1537 constexpr nsecs_t appEndTime = std::chrono::nanoseconds(20ms).count();
1538 constexpr nsecs_t appPresentTime = std::chrono::nanoseconds(30ms).count();
Adithya Srinivasan061c14c2021-02-11 01:19:47 +00001539 int64_t surfaceFrameToken =
1540 mTokenManager->generateTokenForPredictions({appStartTime, appEndTime, appPresentTime});
1541
1542 // Flush the token so that it would expire
Adithya Srinivasanbed4c4f2021-05-03 20:24:46 +00001543 flushTokens();
Huihong Luo3bdef862022-03-03 11:57:19 -08001544 FrameTimelineInfo ftInfo;
1545 ftInfo.vsyncId = surfaceFrameToken;
1546 ftInfo.inputEventId = 0;
Adithya Srinivasan061c14c2021-02-11 01:19:47 +00001547 auto surfaceFrame1 =
Huihong Luo3bdef862022-03-03 11:57:19 -08001548 mFrameTimeline->createSurfaceFrameForToken(ftInfo, sPidOne, sUidOne, sLayerIdOne,
1549 sLayerNameOne, sLayerNameOne,
1550 /*isBuffer*/ true, sGameMode);
Adithya Srinivasan061c14c2021-02-11 01:19:47 +00001551 surfaceFrame1->setActualQueueTime(appEndTime);
1552 surfaceFrame1->setAcquireFenceTime(appEndTime);
1553
Adithya Srinivasan939cd4d2021-02-23 06:18:13 +00001554 constexpr nsecs_t sfStartTime = std::chrono::nanoseconds(20ms).count();
1555 constexpr nsecs_t sfEndTime = std::chrono::nanoseconds(30ms).count();
1556 constexpr nsecs_t sfPresentTime = std::chrono::nanoseconds(30ms).count();
Adithya Srinivasan061c14c2021-02-11 01:19:47 +00001557 int64_t displayFrameToken =
1558 mTokenManager->generateTokenForPredictions({sfStartTime, sfEndTime, sfPresentTime});
1559
1560 // First 2 cookies will be used by the DisplayFrame
1561 int64_t traceCookie = snoopCurrentTraceCookie() + 2;
1562
1563 auto protoActualSurfaceFrameStart =
1564 createProtoActualSurfaceFrameStart(traceCookie + 1, surfaceFrameToken,
1565 displayFrameToken, sPidOne, sLayerNameOne,
1566 FrameTimelineEvent::PRESENT_UNSPECIFIED, false,
Ady Abrahame43ff722022-02-15 14:44:25 -08001567 false, FrameTimelineEvent::JANK_APP_DEADLINE_MISSED,
Ying Wei96eb5352023-11-21 17:37:21 +00001568 FrameTimelineEvent::SEVERITY_UNKNOWN,
Adithya Srinivasan1f9450c2021-06-10 22:39:19 +00001569 FrameTimelineEvent::PREDICTION_EXPIRED, true);
Adithya Srinivasan061c14c2021-02-11 01:19:47 +00001570 auto protoActualSurfaceFrameEnd = createProtoFrameEnd(traceCookie + 1);
1571
1572 // Set up the display frame
Pascal Muetschardac7bcd92023-10-03 15:05:36 +02001573 mFrameTimeline->setSfWakeUp(displayFrameToken, sfStartTime, RR_11, RR_11);
Adithya Srinivasan061c14c2021-02-11 01:19:47 +00001574 surfaceFrame1->setPresentState(SurfaceFrame::PresentState::Presented);
1575 mFrameTimeline->addSurfaceFrame(surfaceFrame1);
1576 mFrameTimeline->setSfPresent(sfEndTime, presentFence1);
1577 presentFence1->signalForTest(sfPresentTime);
1578
1579 addEmptyDisplayFrame();
1580 flushTrace();
1581 tracingSession->StopBlocking();
1582
1583 auto packets = readFrameTimelinePacketsBlocking(tracingSession.get());
1584 // Display Frame 4 packets + SurfaceFrame 2 packets
1585 ASSERT_EQ(packets.size(), 6u);
1586
1587 // Packet - 4 : ActualSurfaceFrameStart
1588 const auto& packet4 = packets[4];
1589 ASSERT_TRUE(packet4.has_timestamp());
1590 EXPECT_EQ(packet4.timestamp(),
1591 static_cast<uint64_t>(appEndTime - SurfaceFrame::kPredictionExpiredStartTimeDelta));
1592 ASSERT_TRUE(packet4.has_frame_timeline_event());
1593
1594 const auto& event4 = packet4.frame_timeline_event();
1595 ASSERT_TRUE(event4.has_actual_surface_frame_start());
1596 const auto& actualSurfaceFrameStart = event4.actual_surface_frame_start();
1597 validateTraceEvent(actualSurfaceFrameStart, protoActualSurfaceFrameStart);
1598
1599 // Packet - 5 : FrameEnd (ActualSurfaceFrame)
1600 const auto& packet5 = packets[5];
1601 ASSERT_TRUE(packet5.has_timestamp());
1602 EXPECT_EQ(packet5.timestamp(), static_cast<uint64_t>(appEndTime));
1603 ASSERT_TRUE(packet5.has_frame_timeline_event());
1604
1605 const auto& event5 = packet5.frame_timeline_event();
1606 ASSERT_TRUE(event5.has_frame_end());
1607 const auto& actualSurfaceFrameEnd = event5.frame_end();
Adithya Srinivasan05bd2d12021-01-11 18:49:58 +00001608 validateTraceEvent(actualSurfaceFrameEnd, protoActualSurfaceFrameEnd);
Adithya Srinivasan01189672020-10-20 14:23:05 -07001609}
1610
Adithya Srinivasanb2283c32021-04-21 21:31:56 +00001611TEST_F(FrameTimelineTest, traceSurfaceFrame_predictionExpiredDroppedFramesTracedProperly) {
1612 auto tracingSession = getTracingSessionForTest();
1613 auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE);
1614
1615 tracingSession->StartBlocking();
1616 constexpr nsecs_t appStartTime = std::chrono::nanoseconds(10ms).count();
1617 constexpr nsecs_t appEndTime = std::chrono::nanoseconds(20ms).count();
1618 constexpr nsecs_t appPresentTime = std::chrono::nanoseconds(30ms).count();
1619 int64_t surfaceFrameToken =
1620 mTokenManager->generateTokenForPredictions({appStartTime, appEndTime, appPresentTime});
1621
1622 // Flush the token so that it would expire
Adithya Srinivasanbed4c4f2021-05-03 20:24:46 +00001623 flushTokens();
Huihong Luo3bdef862022-03-03 11:57:19 -08001624 FrameTimelineInfo ftInfo;
1625 ftInfo.vsyncId = surfaceFrameToken;
1626 ftInfo.inputEventId = 0;
Adithya Srinivasanb2283c32021-04-21 21:31:56 +00001627 auto surfaceFrame1 =
Huihong Luo3bdef862022-03-03 11:57:19 -08001628 mFrameTimeline->createSurfaceFrameForToken(ftInfo, sPidOne, sUidOne, sLayerIdOne,
1629 sLayerNameOne, sLayerNameOne,
1630 /*isBuffer*/ true, sGameMode);
Adithya Srinivasanb2283c32021-04-21 21:31:56 +00001631
1632 constexpr nsecs_t sfStartTime = std::chrono::nanoseconds(22ms).count();
1633 constexpr nsecs_t sfEndTime = std::chrono::nanoseconds(30ms).count();
1634 constexpr nsecs_t sfPresentTime = std::chrono::nanoseconds(30ms).count();
1635 int64_t displayFrameToken =
1636 mTokenManager->generateTokenForPredictions({sfStartTime, sfEndTime, sfPresentTime});
1637
1638 // First 2 cookies will be used by the DisplayFrame
1639 int64_t traceCookie = snoopCurrentTraceCookie() + 2;
1640
1641 auto protoActualSurfaceFrameStart =
1642 createProtoActualSurfaceFrameStart(traceCookie + 1, surfaceFrameToken,
1643 displayFrameToken, sPidOne, sLayerNameOne,
1644 FrameTimelineEvent::PRESENT_DROPPED, false, false,
Edgar Arriaga631e4252023-03-02 02:11:24 +00001645 FrameTimelineEvent::JANK_DROPPED,
Ying Wei96eb5352023-11-21 17:37:21 +00001646 FrameTimelineEvent::SEVERITY_UNKNOWN,
Adithya Srinivasan1f9450c2021-06-10 22:39:19 +00001647 FrameTimelineEvent::PREDICTION_EXPIRED, true);
Adithya Srinivasanb2283c32021-04-21 21:31:56 +00001648 auto protoActualSurfaceFrameEnd = createProtoFrameEnd(traceCookie + 1);
1649
1650 // Set up the display frame
Pascal Muetschardac7bcd92023-10-03 15:05:36 +02001651 mFrameTimeline->setSfWakeUp(displayFrameToken, sfStartTime, RR_11, RR_11);
Adithya Srinivasanb2283c32021-04-21 21:31:56 +00001652 surfaceFrame1->setDropTime(sfStartTime);
1653 surfaceFrame1->setPresentState(SurfaceFrame::PresentState::Dropped);
1654 mFrameTimeline->addSurfaceFrame(surfaceFrame1);
1655 mFrameTimeline->setSfPresent(sfEndTime, presentFence1);
1656 presentFence1->signalForTest(sfPresentTime);
1657
1658 addEmptyDisplayFrame();
1659 flushTrace();
1660 tracingSession->StopBlocking();
1661
1662 auto packets = readFrameTimelinePacketsBlocking(tracingSession.get());
1663 // Display Frame 4 packets + SurfaceFrame 2 packets
1664 ASSERT_EQ(packets.size(), 6u);
1665
1666 // Packet - 4 : ActualSurfaceFrameStart
1667 const auto& packet4 = packets[4];
1668 ASSERT_TRUE(packet4.has_timestamp());
1669 EXPECT_EQ(packet4.timestamp(),
1670 static_cast<uint64_t>(sfStartTime - SurfaceFrame::kPredictionExpiredStartTimeDelta));
1671 ASSERT_TRUE(packet4.has_frame_timeline_event());
1672
1673 const auto& event4 = packet4.frame_timeline_event();
1674 ASSERT_TRUE(event4.has_actual_surface_frame_start());
1675 const auto& actualSurfaceFrameStart = event4.actual_surface_frame_start();
1676 validateTraceEvent(actualSurfaceFrameStart, protoActualSurfaceFrameStart);
1677
1678 // Packet - 5 : FrameEnd (ActualSurfaceFrame)
1679 const auto& packet5 = packets[5];
1680 ASSERT_TRUE(packet5.has_timestamp());
1681 EXPECT_EQ(packet5.timestamp(), static_cast<uint64_t>(sfStartTime));
1682 ASSERT_TRUE(packet5.has_frame_timeline_event());
1683
1684 const auto& event5 = packet5.frame_timeline_event();
1685 ASSERT_TRUE(event5.has_frame_end());
1686 const auto& actualSurfaceFrameEnd = event5.frame_end();
1687 validateTraceEvent(actualSurfaceFrameEnd, protoActualSurfaceFrameEnd);
1688}
1689
Adithya Srinivasan9b2ca3e2020-11-10 10:14:17 -08001690// Tests for Jank classification
1691TEST_F(FrameTimelineTest, jankClassification_presentOnTimeDoesNotClassify) {
Adithya Srinivasan9b2ca3e2020-11-10 10:14:17 -08001692 // Layer specific increment
Alec Mouri363faf02021-01-29 16:34:55 -08001693 EXPECT_CALL(*mTimeStats, incrementJankyFrames(_));
Adithya Srinivasan9b2ca3e2020-11-10 10:14:17 -08001694 auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE);
1695 int64_t surfaceFrameToken = mTokenManager->generateTokenForPredictions({10, 20, 30});
Adithya Srinivasan939cd4d2021-02-23 06:18:13 +00001696 int64_t sfToken1 = mTokenManager->generateTokenForPredictions({22, 30, 30});
Huihong Luo3bdef862022-03-03 11:57:19 -08001697 FrameTimelineInfo ftInfo;
1698 ftInfo.vsyncId = surfaceFrameToken;
1699 ftInfo.inputEventId = sInputEventId;
Adithya Srinivasan9b2ca3e2020-11-10 10:14:17 -08001700 auto surfaceFrame =
Huihong Luo3bdef862022-03-03 11:57:19 -08001701 mFrameTimeline->createSurfaceFrameForToken(ftInfo, sPidOne, sUidOne, sLayerIdOne,
1702 sLayerNameOne, sLayerNameOne,
1703 /*isBuffer*/ true, sGameMode);
Pascal Muetschardac7bcd92023-10-03 15:05:36 +02001704 mFrameTimeline->setSfWakeUp(sfToken1, 22, RR_11, RR_11);
Adithya Srinivasan9b2ca3e2020-11-10 10:14:17 -08001705 surfaceFrame->setPresentState(SurfaceFrame::PresentState::Presented);
1706 mFrameTimeline->addSurfaceFrame(surfaceFrame);
1707 mFrameTimeline->setSfPresent(26, presentFence1);
1708 auto displayFrame = getDisplayFrame(0);
1709 auto& presentedSurfaceFrame = getSurfaceFrame(0, 0);
1710 presentFence1->signalForTest(29);
1711
1712 // Fences haven't been flushed yet, so it should be 0
1713 EXPECT_EQ(displayFrame->getActuals().presentTime, 0);
1714 EXPECT_EQ(presentedSurfaceFrame.getActuals().presentTime, 0);
1715
1716 addEmptyDisplayFrame();
1717 displayFrame = getDisplayFrame(0);
1718
1719 // Fences have flushed, so the present timestamps should be updated
1720 EXPECT_EQ(displayFrame->getActuals().presentTime, 29);
1721 EXPECT_EQ(presentedSurfaceFrame.getActuals().presentTime, 29);
1722 EXPECT_EQ(displayFrame->getFramePresentMetadata(), FramePresentMetadata::OnTimePresent);
1723 EXPECT_EQ(displayFrame->getFrameReadyMetadata(), FrameReadyMetadata::OnTimeFinish);
1724 EXPECT_EQ(displayFrame->getJankType(), JankType::None);
Ying Wei96eb5352023-11-21 17:37:21 +00001725 EXPECT_EQ(displayFrame->getJankSeverityType(), JankSeverityType::None);
Adithya Srinivasan9b2ca3e2020-11-10 10:14:17 -08001726}
1727
1728TEST_F(FrameTimelineTest, jankClassification_displayFrameOnTimeFinishEarlyPresent) {
Pascal Muetschardac7bcd92023-10-03 15:05:36 +02001729 Fps vsyncRate = RR_11;
Adithya Srinivasan9b2ca3e2020-11-10 10:14:17 -08001730 auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE);
Adithya Srinivasan939cd4d2021-02-23 06:18:13 +00001731 int64_t sfToken1 = mTokenManager->generateTokenForPredictions({22, 30, 40});
1732 int64_t sfToken2 = mTokenManager->generateTokenForPredictions({52, 60, 70});
Pascal Muetschardac7bcd92023-10-03 15:05:36 +02001733 mFrameTimeline->setSfWakeUp(sfToken1, 22, vsyncRate, vsyncRate);
Adithya Srinivasan9b2ca3e2020-11-10 10:14:17 -08001734 mFrameTimeline->setSfPresent(26, presentFence1);
1735 auto displayFrame = getDisplayFrame(0);
1736 presentFence1->signalForTest(30);
1737
1738 // Fences for the first frame haven't been flushed yet, so it should be 0
1739 EXPECT_EQ(displayFrame->getActuals().presentTime, 0);
1740
1741 // Trigger a flush by finalizing the next DisplayFrame
1742 auto presentFence2 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE);
Pascal Muetschardac7bcd92023-10-03 15:05:36 +02001743 mFrameTimeline->setSfWakeUp(sfToken2, 52, vsyncRate, vsyncRate);
Adithya Srinivasan9b2ca3e2020-11-10 10:14:17 -08001744 mFrameTimeline->setSfPresent(56, presentFence2);
1745 displayFrame = getDisplayFrame(0);
1746
1747 // Fences for the first frame have flushed, so the present timestamps should be updated
1748 EXPECT_EQ(displayFrame->getActuals().presentTime, 30);
1749 EXPECT_EQ(displayFrame->getFramePresentMetadata(), FramePresentMetadata::EarlyPresent);
1750 EXPECT_EQ(displayFrame->getFrameReadyMetadata(), FrameReadyMetadata::OnTimeFinish);
1751 EXPECT_EQ(displayFrame->getJankType(), JankType::SurfaceFlingerScheduling);
Ying Wei96eb5352023-11-21 17:37:21 +00001752 EXPECT_EQ(displayFrame->getJankSeverityType(), JankSeverityType::Partial);
Adithya Srinivasan9b2ca3e2020-11-10 10:14:17 -08001753
1754 // Fences for the second frame haven't been flushed yet, so it should be 0
1755 auto displayFrame2 = getDisplayFrame(1);
1756 presentFence2->signalForTest(65);
1757 EXPECT_EQ(displayFrame2->getActuals().presentTime, 0);
Adithya Srinivasan9b2ca3e2020-11-10 10:14:17 -08001758 addEmptyDisplayFrame();
1759 displayFrame2 = getDisplayFrame(1);
1760
1761 // Fences for the second frame have flushed, so the present timestamps should be updated
1762 EXPECT_EQ(displayFrame2->getActuals().presentTime, 65);
1763 EXPECT_EQ(displayFrame2->getFramePresentMetadata(), FramePresentMetadata::EarlyPresent);
1764 EXPECT_EQ(displayFrame2->getFrameReadyMetadata(), FrameReadyMetadata::OnTimeFinish);
1765 EXPECT_EQ(displayFrame2->getJankType(), JankType::PredictionError);
Ying Wei96eb5352023-11-21 17:37:21 +00001766 EXPECT_EQ(displayFrame->getJankSeverityType(), JankSeverityType::Partial);
Adithya Srinivasan9b2ca3e2020-11-10 10:14:17 -08001767}
1768
1769TEST_F(FrameTimelineTest, jankClassification_displayFrameOnTimeFinishLatePresent) {
Pascal Muetschardac7bcd92023-10-03 15:05:36 +02001770 Fps vsyncRate = RR_11;
Adithya Srinivasan9b2ca3e2020-11-10 10:14:17 -08001771 auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE);
Adithya Srinivasan939cd4d2021-02-23 06:18:13 +00001772 int64_t sfToken1 = mTokenManager->generateTokenForPredictions({22, 30, 40});
1773 int64_t sfToken2 = mTokenManager->generateTokenForPredictions({52, 60, 70});
Pascal Muetschardac7bcd92023-10-03 15:05:36 +02001774 mFrameTimeline->setSfWakeUp(sfToken1, 22, vsyncRate, vsyncRate);
Adithya Srinivasan9b2ca3e2020-11-10 10:14:17 -08001775 mFrameTimeline->setSfPresent(26, presentFence1);
1776 auto displayFrame = getDisplayFrame(0);
1777 presentFence1->signalForTest(50);
1778
1779 // Fences for the first frame haven't been flushed yet, so it should be 0
1780 EXPECT_EQ(displayFrame->getActuals().presentTime, 0);
1781
1782 // Trigger a flush by finalizing the next DisplayFrame
1783 auto presentFence2 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE);
Pascal Muetschardac7bcd92023-10-03 15:05:36 +02001784 mFrameTimeline->setSfWakeUp(sfToken2, 52, vsyncRate, vsyncRate);
Adithya Srinivasan9b2ca3e2020-11-10 10:14:17 -08001785 mFrameTimeline->setSfPresent(56, presentFence2);
1786 displayFrame = getDisplayFrame(0);
1787
1788 // Fences for the first frame have flushed, so the present timestamps should be updated
1789 EXPECT_EQ(displayFrame->getActuals().presentTime, 50);
1790 EXPECT_EQ(displayFrame->getFramePresentMetadata(), FramePresentMetadata::LatePresent);
1791 EXPECT_EQ(displayFrame->getFrameReadyMetadata(), FrameReadyMetadata::OnTimeFinish);
1792 EXPECT_EQ(displayFrame->getJankType(), JankType::DisplayHAL);
Ying Wei96eb5352023-11-21 17:37:21 +00001793 EXPECT_EQ(displayFrame->getJankSeverityType(), JankSeverityType::Partial);
Adithya Srinivasan9b2ca3e2020-11-10 10:14:17 -08001794
1795 // Fences for the second frame haven't been flushed yet, so it should be 0
1796 auto displayFrame2 = getDisplayFrame(1);
1797 presentFence2->signalForTest(75);
1798 EXPECT_EQ(displayFrame2->getActuals().presentTime, 0);
1799
1800 addEmptyDisplayFrame();
1801 displayFrame2 = getDisplayFrame(1);
1802
1803 // Fences for the second frame have flushed, so the present timestamps should be updated
1804 EXPECT_EQ(displayFrame2->getActuals().presentTime, 75);
1805 EXPECT_EQ(displayFrame2->getFramePresentMetadata(), FramePresentMetadata::LatePresent);
1806 EXPECT_EQ(displayFrame2->getFrameReadyMetadata(), FrameReadyMetadata::OnTimeFinish);
1807 EXPECT_EQ(displayFrame2->getJankType(), JankType::PredictionError);
Ying Wei96eb5352023-11-21 17:37:21 +00001808 EXPECT_EQ(displayFrame->getJankSeverityType(), JankSeverityType::Partial);
Adithya Srinivasan9b2ca3e2020-11-10 10:14:17 -08001809}
1810
1811TEST_F(FrameTimelineTest, jankClassification_displayFrameLateFinishEarlyPresent) {
Adithya Srinivasan9b2ca3e2020-11-10 10:14:17 -08001812 auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE);
1813 int64_t sfToken1 = mTokenManager->generateTokenForPredictions({12, 18, 40});
Pascal Muetschardac7bcd92023-10-03 15:05:36 +02001814 mFrameTimeline->setSfWakeUp(sfToken1, 12, RR_11, RR_11);
Adithya Srinivasan9b2ca3e2020-11-10 10:14:17 -08001815
1816 mFrameTimeline->setSfPresent(22, presentFence1);
1817 auto displayFrame = getDisplayFrame(0);
1818 presentFence1->signalForTest(28);
1819
1820 // Fences haven't been flushed yet, so it should be 0
1821 EXPECT_EQ(displayFrame->getActuals().presentTime, 0);
1822
1823 addEmptyDisplayFrame();
1824 displayFrame = getDisplayFrame(0);
1825
1826 // Fences have flushed, so the present timestamps should be updated
1827 EXPECT_EQ(displayFrame->getActuals().presentTime, 28);
1828 EXPECT_EQ(displayFrame->getFramePresentMetadata(), FramePresentMetadata::EarlyPresent);
1829 EXPECT_EQ(displayFrame->getFrameReadyMetadata(), FrameReadyMetadata::LateFinish);
1830 EXPECT_EQ(displayFrame->getJankType(), JankType::SurfaceFlingerScheduling);
Ying Wei96eb5352023-11-21 17:37:21 +00001831 EXPECT_EQ(displayFrame->getJankSeverityType(), JankSeverityType::Full);
Adithya Srinivasan9b2ca3e2020-11-10 10:14:17 -08001832}
1833
1834TEST_F(FrameTimelineTest, jankClassification_displayFrameLateFinishLatePresent) {
Adithya Srinivasan36b01af2021-04-07 22:29:47 +00001835 /*
1836 * Case 1 - cpu time > vsync period but combined time > deadline > deadline -> cpudeadlinemissed
1837 * Case 2 - cpu time < vsync period but combined time > deadline -> gpudeadlinemissed
Adithya Srinivasan57dc81d2021-04-14 17:31:41 +00001838 * Case 3 - previous frame ran longer -> sf_stuffing
1839 * Case 4 - Long cpu under SF stuffing -> cpudeadlinemissed
Adithya Srinivasan36b01af2021-04-07 22:29:47 +00001840 */
Adithya Srinivasan9b2ca3e2020-11-10 10:14:17 -08001841 auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE);
Adithya Srinivasan36b01af2021-04-07 22:29:47 +00001842 auto presentFence2 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE);
Adithya Srinivasan57dc81d2021-04-14 17:31:41 +00001843 auto presentFence3 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE);
1844 auto presentFence4 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE);
Adithya Srinivasan36b01af2021-04-07 22:29:47 +00001845 auto gpuFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE);
1846 auto gpuFence2 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE);
Adithya Srinivasan57dc81d2021-04-14 17:31:41 +00001847 auto gpuFence3 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE);
1848 auto gpuFence4 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE);
Adithya Srinivasan9b2ca3e2020-11-10 10:14:17 -08001849 int64_t sfToken1 = mTokenManager->generateTokenForPredictions({22, 26, 40});
Adithya Srinivasan36b01af2021-04-07 22:29:47 +00001850 int64_t sfToken2 = mTokenManager->generateTokenForPredictions({52, 60, 60});
Adithya Srinivasan57dc81d2021-04-14 17:31:41 +00001851 int64_t sfToken3 = mTokenManager->generateTokenForPredictions({82, 90, 90});
1852 int64_t sfToken4 = mTokenManager->generateTokenForPredictions({112, 120, 120});
1853
Adithya Srinivasan36b01af2021-04-07 22:29:47 +00001854 // case 1 - cpu time = 33 - 12 = 21, vsync period = 11
Pascal Muetschardac7bcd92023-10-03 15:05:36 +02001855 mFrameTimeline->setSfWakeUp(sfToken1, 12, RR_11, RR_11);
Adithya Srinivasan36b01af2021-04-07 22:29:47 +00001856 mFrameTimeline->setSfPresent(33, presentFence1, gpuFence1);
1857 auto displayFrame0 = getDisplayFrame(0);
1858 gpuFence1->signalForTest(36);
Adithya Srinivasan9b2ca3e2020-11-10 10:14:17 -08001859 presentFence1->signalForTest(52);
1860
1861 // Fences haven't been flushed yet, so it should be 0
Adithya Srinivasan36b01af2021-04-07 22:29:47 +00001862 EXPECT_EQ(displayFrame0->getActuals().presentTime, 0);
1863
Adithya Srinivasan57dc81d2021-04-14 17:31:41 +00001864 // case 2 - cpu time = 56 - 52 = 4, vsync period = 30
Pascal Muetschardac7bcd92023-10-03 15:05:36 +02001865 mFrameTimeline->setSfWakeUp(sfToken2, 52, RR_30, RR_30);
Adithya Srinivasan36b01af2021-04-07 22:29:47 +00001866 mFrameTimeline->setSfPresent(56, presentFence2, gpuFence2);
1867 auto displayFrame1 = getDisplayFrame(1);
Adithya Srinivasan57dc81d2021-04-14 17:31:41 +00001868 gpuFence2->signalForTest(76);
1869 presentFence2->signalForTest(90);
Adithya Srinivasan36b01af2021-04-07 22:29:47 +00001870
1871 EXPECT_EQ(displayFrame1->getActuals().presentTime, 0);
1872 // Fences have flushed for first displayFrame, so the present timestamps should be updated
1873 EXPECT_EQ(displayFrame0->getActuals().presentTime, 52);
1874 EXPECT_EQ(displayFrame0->getFramePresentMetadata(), FramePresentMetadata::LatePresent);
1875 EXPECT_EQ(displayFrame0->getFrameReadyMetadata(), FrameReadyMetadata::LateFinish);
Rachel Lee94917b32022-03-18 17:52:09 -07001876 EXPECT_EQ(displayFrame0->getJankType(), JankType::SurfaceFlingerGpuDeadlineMissed);
Ying Wei96eb5352023-11-21 17:37:21 +00001877 EXPECT_EQ(displayFrame0->getJankSeverityType(), JankSeverityType::Full);
Adithya Srinivasan9b2ca3e2020-11-10 10:14:17 -08001878
Adithya Srinivasan57dc81d2021-04-14 17:31:41 +00001879 // case 3 - cpu time = 86 - 82 = 4, vsync period = 30
Pascal Muetschardac7bcd92023-10-03 15:05:36 +02001880 mFrameTimeline->setSfWakeUp(sfToken3, 106, RR_30, RR_30);
Adithya Srinivasan57dc81d2021-04-14 17:31:41 +00001881 mFrameTimeline->setSfPresent(112, presentFence3, gpuFence3);
1882 auto displayFrame2 = getDisplayFrame(2);
1883 gpuFence3->signalForTest(116);
1884 presentFence3->signalForTest(120);
Adithya Srinivasan9b2ca3e2020-11-10 10:14:17 -08001885
Adithya Srinivasan57dc81d2021-04-14 17:31:41 +00001886 EXPECT_EQ(displayFrame2->getActuals().presentTime, 0);
Adithya Srinivasan36b01af2021-04-07 22:29:47 +00001887 // Fences have flushed for second displayFrame, so the present timestamps should be updated
Adithya Srinivasan57dc81d2021-04-14 17:31:41 +00001888 EXPECT_EQ(displayFrame1->getActuals().presentTime, 90);
Adithya Srinivasan36b01af2021-04-07 22:29:47 +00001889 EXPECT_EQ(displayFrame1->getFramePresentMetadata(), FramePresentMetadata::LatePresent);
1890 EXPECT_EQ(displayFrame1->getFrameReadyMetadata(), FrameReadyMetadata::LateFinish);
1891 EXPECT_EQ(displayFrame1->getJankType(), JankType::SurfaceFlingerGpuDeadlineMissed);
Ying Wei96eb5352023-11-21 17:37:21 +00001892 EXPECT_EQ(displayFrame1->getJankSeverityType(), JankSeverityType::Full);
Adithya Srinivasan9b2ca3e2020-11-10 10:14:17 -08001893
Adithya Srinivasan57dc81d2021-04-14 17:31:41 +00001894 // case 4 - cpu time = 86 - 82 = 4, vsync period = 30
Pascal Muetschardac7bcd92023-10-03 15:05:36 +02001895 mFrameTimeline->setSfWakeUp(sfToken4, 120, RR_30, RR_30);
Adithya Srinivasan57dc81d2021-04-14 17:31:41 +00001896 mFrameTimeline->setSfPresent(140, presentFence4, gpuFence4);
1897 auto displayFrame3 = getDisplayFrame(3);
1898 gpuFence4->signalForTest(156);
1899 presentFence4->signalForTest(180);
Adithya Srinivasan939cd4d2021-02-23 06:18:13 +00001900
Adithya Srinivasan57dc81d2021-04-14 17:31:41 +00001901 EXPECT_EQ(displayFrame3->getActuals().presentTime, 0);
1902 // Fences have flushed for third displayFrame, so the present timestamps should be updated
1903 EXPECT_EQ(displayFrame2->getActuals().presentTime, 120);
1904 EXPECT_EQ(displayFrame2->getFramePresentMetadata(), FramePresentMetadata::LatePresent);
1905 EXPECT_EQ(displayFrame2->getFrameReadyMetadata(), FrameReadyMetadata::LateFinish);
1906 EXPECT_EQ(displayFrame2->getJankType(), JankType::SurfaceFlingerStuffing);
Ying Wei96eb5352023-11-21 17:37:21 +00001907 EXPECT_EQ(displayFrame2->getJankSeverityType(), JankSeverityType::Full);
Adithya Srinivasan939cd4d2021-02-23 06:18:13 +00001908
1909 addEmptyDisplayFrame();
Adithya Srinivasan939cd4d2021-02-23 06:18:13 +00001910
Adithya Srinivasan57dc81d2021-04-14 17:31:41 +00001911 // Fences have flushed for third displayFrame, so the present timestamps should be updated
1912 EXPECT_EQ(displayFrame3->getActuals().presentTime, 180);
1913 EXPECT_EQ(displayFrame3->getFramePresentMetadata(), FramePresentMetadata::LatePresent);
1914 EXPECT_EQ(displayFrame3->getFrameReadyMetadata(), FrameReadyMetadata::LateFinish);
1915 EXPECT_EQ(displayFrame3->getJankType(), JankType::SurfaceFlingerGpuDeadlineMissed);
Ying Wei96eb5352023-11-21 17:37:21 +00001916 EXPECT_EQ(displayFrame3->getJankSeverityType(), JankSeverityType::Full);
Adithya Srinivasan939cd4d2021-02-23 06:18:13 +00001917}
1918
Adithya Srinivasan9b2ca3e2020-11-10 10:14:17 -08001919TEST_F(FrameTimelineTest, jankClassification_surfaceFrameOnTimeFinishEarlyPresent) {
Alec Mouri363faf02021-01-29 16:34:55 -08001920 EXPECT_CALL(*mTimeStats, incrementJankyFrames(_));
Adithya Srinivasan9b2ca3e2020-11-10 10:14:17 -08001921 auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE);
Adithya Srinivasan939cd4d2021-02-23 06:18:13 +00001922 int64_t sfToken1 = mTokenManager->generateTokenForPredictions({22, 30, 40});
1923 int64_t sfToken2 = mTokenManager->generateTokenForPredictions({52, 60, 70});
Adithya Srinivasan9b2ca3e2020-11-10 10:14:17 -08001924 int64_t surfaceFrameToken1 = mTokenManager->generateTokenForPredictions({5, 16, 40});
1925 int64_t surfaceFrameToken2 = mTokenManager->generateTokenForPredictions({25, 36, 70});
Huihong Luo3bdef862022-03-03 11:57:19 -08001926 FrameTimelineInfo ftInfo;
1927 ftInfo.vsyncId = surfaceFrameToken1;
1928 ftInfo.inputEventId = sInputEventId;
Adithya Srinivasan9b2ca3e2020-11-10 10:14:17 -08001929 auto surfaceFrame1 =
Huihong Luo3bdef862022-03-03 11:57:19 -08001930 mFrameTimeline->createSurfaceFrameForToken(ftInfo, sPidOne, sUidOne, sLayerIdOne,
1931 sLayerNameOne, sLayerNameOne,
1932 /*isBuffer*/ true, sGameMode);
Adithya Srinivasan9b2ca3e2020-11-10 10:14:17 -08001933 surfaceFrame1->setAcquireFenceTime(16);
Pascal Muetschardac7bcd92023-10-03 15:05:36 +02001934 mFrameTimeline->setSfWakeUp(sfToken1, 22, RR_11, RR_11);
Adithya Srinivasan9b2ca3e2020-11-10 10:14:17 -08001935 surfaceFrame1->setPresentState(SurfaceFrame::PresentState::Presented);
1936 mFrameTimeline->addSurfaceFrame(surfaceFrame1);
Adithya Srinivasan939cd4d2021-02-23 06:18:13 +00001937 mFrameTimeline->setSfPresent(27, presentFence1);
Adithya Srinivasan9b2ca3e2020-11-10 10:14:17 -08001938 auto displayFrame1 = getDisplayFrame(0);
1939 auto& presentedSurfaceFrame1 = getSurfaceFrame(0, 0);
1940 presentFence1->signalForTest(30);
1941
1942 // Fences for the first frame haven't been flushed yet, so it should be 0
1943 EXPECT_EQ(displayFrame1->getActuals().presentTime, 0);
1944 auto actuals1 = presentedSurfaceFrame1.getActuals();
1945 EXPECT_EQ(actuals1.presentTime, 0);
1946
1947 // Trigger a flush by finalizing the next DisplayFrame
1948 auto presentFence2 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE);
Huihong Luo3bdef862022-03-03 11:57:19 -08001949 FrameTimelineInfo ftInfo2;
1950 ftInfo2.vsyncId = surfaceFrameToken2;
1951 ftInfo2.inputEventId = sInputEventId;
Adithya Srinivasan9b2ca3e2020-11-10 10:14:17 -08001952 auto surfaceFrame2 =
Huihong Luo3bdef862022-03-03 11:57:19 -08001953 mFrameTimeline->createSurfaceFrameForToken(ftInfo2, sPidOne, sUidOne, sLayerIdOne,
1954 sLayerNameOne, sLayerNameOne,
1955 /*isBuffer*/ true, sGameMode);
Adithya Srinivasan9b2ca3e2020-11-10 10:14:17 -08001956 surfaceFrame2->setAcquireFenceTime(36);
Pascal Muetschardac7bcd92023-10-03 15:05:36 +02001957 mFrameTimeline->setSfWakeUp(sfToken2, 52, RR_11, RR_11);
Adithya Srinivasan9b2ca3e2020-11-10 10:14:17 -08001958 surfaceFrame2->setPresentState(SurfaceFrame::PresentState::Presented);
1959 mFrameTimeline->addSurfaceFrame(surfaceFrame2);
Adithya Srinivasan939cd4d2021-02-23 06:18:13 +00001960 mFrameTimeline->setSfPresent(57, presentFence2);
Adithya Srinivasan9b2ca3e2020-11-10 10:14:17 -08001961 auto displayFrame2 = getDisplayFrame(1);
1962 auto& presentedSurfaceFrame2 = getSurfaceFrame(1, 0);
1963
1964 // Fences for the first frame have flushed, so the present timestamps should be updated
1965 EXPECT_EQ(displayFrame1->getActuals().presentTime, 30);
1966 EXPECT_EQ(displayFrame1->getFramePresentMetadata(), FramePresentMetadata::EarlyPresent);
1967 EXPECT_EQ(displayFrame1->getFrameReadyMetadata(), FrameReadyMetadata::OnTimeFinish);
1968 EXPECT_EQ(displayFrame1->getJankType(), JankType::SurfaceFlingerScheduling);
Ying Wei96eb5352023-11-21 17:37:21 +00001969 EXPECT_EQ(displayFrame1->getJankSeverityType(), JankSeverityType::Partial);
Adithya Srinivasan9b2ca3e2020-11-10 10:14:17 -08001970
1971 actuals1 = presentedSurfaceFrame1.getActuals();
1972 EXPECT_EQ(actuals1.presentTime, 30);
1973 EXPECT_EQ(presentedSurfaceFrame1.getFramePresentMetadata(), FramePresentMetadata::EarlyPresent);
1974 EXPECT_EQ(presentedSurfaceFrame1.getFrameReadyMetadata(), FrameReadyMetadata::OnTimeFinish);
1975 EXPECT_EQ(presentedSurfaceFrame1.getJankType(), JankType::SurfaceFlingerScheduling);
Ying Wei96eb5352023-11-21 17:37:21 +00001976 EXPECT_EQ(presentedSurfaceFrame1.getJankSeverityType(), JankSeverityType::Partial);
Adithya Srinivasan9b2ca3e2020-11-10 10:14:17 -08001977
1978 // Fences for the second frame haven't been flushed yet, so it should be 0
1979 presentFence2->signalForTest(65);
1980 EXPECT_EQ(displayFrame2->getActuals().presentTime, 0);
1981 auto actuals2 = presentedSurfaceFrame2.getActuals();
1982 EXPECT_EQ(actuals2.presentTime, 0);
1983
Alec Mouri363faf02021-01-29 16:34:55 -08001984 ::testing::Mock::VerifyAndClearExpectations(mTimeStats.get());
1985
1986 EXPECT_CALL(*mTimeStats,
Pascal Muetschardac7bcd92023-10-03 15:05:36 +02001987 incrementJankyFrames(TimeStats::JankyFramesInfo{RR_11, std::nullopt, sUidOne,
1988 sLayerNameOne, sGameMode,
1989 JankType::PredictionError, -3, 5,
1990 0}));
Alec Mouri363faf02021-01-29 16:34:55 -08001991
Adithya Srinivasan9b2ca3e2020-11-10 10:14:17 -08001992 addEmptyDisplayFrame();
1993
1994 // Fences for the second frame have flushed, so the present timestamps should be updated
1995 EXPECT_EQ(displayFrame2->getActuals().presentTime, 65);
1996 EXPECT_EQ(displayFrame2->getFramePresentMetadata(), FramePresentMetadata::EarlyPresent);
1997 EXPECT_EQ(displayFrame2->getFrameReadyMetadata(), FrameReadyMetadata::OnTimeFinish);
1998 EXPECT_EQ(displayFrame2->getJankType(), JankType::PredictionError);
Ying Wei96eb5352023-11-21 17:37:21 +00001999 EXPECT_EQ(displayFrame2->getJankSeverityType(), JankSeverityType::Partial);
Adithya Srinivasan9b2ca3e2020-11-10 10:14:17 -08002000
2001 actuals2 = presentedSurfaceFrame2.getActuals();
2002 EXPECT_EQ(actuals2.presentTime, 65);
2003 EXPECT_EQ(presentedSurfaceFrame2.getFramePresentMetadata(), FramePresentMetadata::EarlyPresent);
2004 EXPECT_EQ(presentedSurfaceFrame2.getFrameReadyMetadata(), FrameReadyMetadata::OnTimeFinish);
2005 EXPECT_EQ(presentedSurfaceFrame2.getJankType(), JankType::PredictionError);
Ying Wei96eb5352023-11-21 17:37:21 +00002006 EXPECT_EQ(presentedSurfaceFrame2.getJankSeverityType(), JankSeverityType::Partial);
Adithya Srinivasan9b2ca3e2020-11-10 10:14:17 -08002007}
2008
2009TEST_F(FrameTimelineTest, jankClassification_surfaceFrameOnTimeFinishLatePresent) {
Alec Mouri363faf02021-01-29 16:34:55 -08002010 EXPECT_CALL(*mTimeStats, incrementJankyFrames(_));
Adithya Srinivasan9b2ca3e2020-11-10 10:14:17 -08002011 auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE);
Adithya Srinivasan939cd4d2021-02-23 06:18:13 +00002012 int64_t sfToken1 = mTokenManager->generateTokenForPredictions({22, 30, 40});
2013 int64_t sfToken2 = mTokenManager->generateTokenForPredictions({52, 60, 70});
Adithya Srinivasan9b2ca3e2020-11-10 10:14:17 -08002014 int64_t surfaceFrameToken1 = mTokenManager->generateTokenForPredictions({5, 16, 40});
2015 int64_t surfaceFrameToken2 = mTokenManager->generateTokenForPredictions({25, 36, 70});
Huihong Luo3bdef862022-03-03 11:57:19 -08002016 FrameTimelineInfo ftInfo;
2017 ftInfo.vsyncId = surfaceFrameToken1;
2018 ftInfo.inputEventId = sInputEventId;
Adithya Srinivasan9b2ca3e2020-11-10 10:14:17 -08002019 auto surfaceFrame1 =
Huihong Luo3bdef862022-03-03 11:57:19 -08002020 mFrameTimeline->createSurfaceFrameForToken(ftInfo, sPidOne, sUidOne, sLayerIdOne,
2021 sLayerNameOne, sLayerNameOne,
2022 /*isBuffer*/ true, sGameMode);
Adithya Srinivasan9b2ca3e2020-11-10 10:14:17 -08002023 surfaceFrame1->setAcquireFenceTime(16);
Pascal Muetschardac7bcd92023-10-03 15:05:36 +02002024 mFrameTimeline->setSfWakeUp(sfToken1, 22, RR_11, RR_11);
Adithya Srinivasan9b2ca3e2020-11-10 10:14:17 -08002025 surfaceFrame1->setPresentState(SurfaceFrame::PresentState::Presented);
2026 mFrameTimeline->addSurfaceFrame(surfaceFrame1);
2027 mFrameTimeline->setSfPresent(26, presentFence1);
2028 auto displayFrame1 = getDisplayFrame(0);
2029 auto& presentedSurfaceFrame1 = getSurfaceFrame(0, 0);
2030 presentFence1->signalForTest(50);
2031
2032 // Fences for the first frame haven't been flushed yet, so it should be 0
2033 EXPECT_EQ(displayFrame1->getActuals().presentTime, 0);
2034 auto actuals1 = presentedSurfaceFrame1.getActuals();
2035 EXPECT_EQ(actuals1.presentTime, 0);
2036
2037 // Trigger a flush by finalizing the next DisplayFrame
2038 auto presentFence2 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE);
Huihong Luo3bdef862022-03-03 11:57:19 -08002039 FrameTimelineInfo ftInfo2;
2040 ftInfo2.vsyncId = surfaceFrameToken2;
2041 ftInfo2.inputEventId = sInputEventId;
Adithya Srinivasan9b2ca3e2020-11-10 10:14:17 -08002042 auto surfaceFrame2 =
Huihong Luo3bdef862022-03-03 11:57:19 -08002043 mFrameTimeline->createSurfaceFrameForToken(ftInfo2, sPidOne, sUidOne, sLayerIdOne,
2044 sLayerNameOne, sLayerNameOne,
2045 /*isBuffer*/ true, sGameMode);
Adithya Srinivasan9b2ca3e2020-11-10 10:14:17 -08002046 surfaceFrame2->setAcquireFenceTime(36);
Pascal Muetschardac7bcd92023-10-03 15:05:36 +02002047 mFrameTimeline->setSfWakeUp(sfToken2, 52, RR_11, RR_11);
Adithya Srinivasan9b2ca3e2020-11-10 10:14:17 -08002048 surfaceFrame2->setPresentState(SurfaceFrame::PresentState::Presented);
2049 mFrameTimeline->addSurfaceFrame(surfaceFrame2);
Adithya Srinivasan939cd4d2021-02-23 06:18:13 +00002050 mFrameTimeline->setSfPresent(57, presentFence2);
Adithya Srinivasan9b2ca3e2020-11-10 10:14:17 -08002051 auto displayFrame2 = getDisplayFrame(1);
2052 auto& presentedSurfaceFrame2 = getSurfaceFrame(1, 0);
2053
2054 // Fences for the first frame have flushed, so the present timestamps should be updated
2055 EXPECT_EQ(displayFrame1->getActuals().presentTime, 50);
2056 EXPECT_EQ(displayFrame1->getFramePresentMetadata(), FramePresentMetadata::LatePresent);
2057 EXPECT_EQ(displayFrame1->getFrameReadyMetadata(), FrameReadyMetadata::OnTimeFinish);
2058 EXPECT_EQ(displayFrame1->getJankType(), JankType::DisplayHAL);
Ying Wei96eb5352023-11-21 17:37:21 +00002059 EXPECT_EQ(displayFrame1->getJankSeverityType(), JankSeverityType::Partial);
Adithya Srinivasan9b2ca3e2020-11-10 10:14:17 -08002060
2061 actuals1 = presentedSurfaceFrame1.getActuals();
2062 EXPECT_EQ(actuals1.presentTime, 50);
2063 EXPECT_EQ(presentedSurfaceFrame1.getFramePresentMetadata(), FramePresentMetadata::LatePresent);
2064 EXPECT_EQ(presentedSurfaceFrame1.getFrameReadyMetadata(), FrameReadyMetadata::OnTimeFinish);
2065 EXPECT_EQ(presentedSurfaceFrame1.getJankType(), JankType::DisplayHAL);
Ying Wei96eb5352023-11-21 17:37:21 +00002066 EXPECT_EQ(presentedSurfaceFrame1.getJankSeverityType(), JankSeverityType::Partial);
Adithya Srinivasan9b2ca3e2020-11-10 10:14:17 -08002067
2068 // Fences for the second frame haven't been flushed yet, so it should be 0
2069 presentFence2->signalForTest(86);
2070 EXPECT_EQ(displayFrame2->getActuals().presentTime, 0);
2071 auto actuals2 = presentedSurfaceFrame2.getActuals();
2072 EXPECT_EQ(actuals2.presentTime, 0);
2073
Alec Mouri363faf02021-01-29 16:34:55 -08002074 ::testing::Mock::VerifyAndClearExpectations(mTimeStats.get());
2075
2076 EXPECT_CALL(*mTimeStats,
Pascal Muetschardac7bcd92023-10-03 15:05:36 +02002077 incrementJankyFrames(TimeStats::JankyFramesInfo{RR_11, std::nullopt, sUidOne,
2078 sLayerNameOne, sGameMode,
2079 JankType::PredictionError, -3, 5,
2080 0}));
Alec Mouri363faf02021-01-29 16:34:55 -08002081
Adithya Srinivasan9b2ca3e2020-11-10 10:14:17 -08002082 addEmptyDisplayFrame();
2083
2084 // Fences for the second frame have flushed, so the present timestamps should be updated
2085 EXPECT_EQ(displayFrame2->getActuals().presentTime, 86);
2086 EXPECT_EQ(displayFrame2->getFramePresentMetadata(), FramePresentMetadata::LatePresent);
2087 EXPECT_EQ(displayFrame2->getFrameReadyMetadata(), FrameReadyMetadata::OnTimeFinish);
2088 EXPECT_EQ(displayFrame2->getJankType(), JankType::PredictionError);
Ying Wei96eb5352023-11-21 17:37:21 +00002089 EXPECT_EQ(displayFrame2->getJankSeverityType(), JankSeverityType::Full);
Adithya Srinivasan9b2ca3e2020-11-10 10:14:17 -08002090
2091 actuals2 = presentedSurfaceFrame2.getActuals();
2092 EXPECT_EQ(actuals2.presentTime, 86);
2093 EXPECT_EQ(presentedSurfaceFrame2.getFramePresentMetadata(), FramePresentMetadata::LatePresent);
2094 EXPECT_EQ(presentedSurfaceFrame2.getFrameReadyMetadata(), FrameReadyMetadata::OnTimeFinish);
2095 EXPECT_EQ(presentedSurfaceFrame2.getJankType(), JankType::PredictionError);
Ying Wei96eb5352023-11-21 17:37:21 +00002096 EXPECT_EQ(presentedSurfaceFrame2.getJankSeverityType(), JankSeverityType::Full);
Adithya Srinivasan9b2ca3e2020-11-10 10:14:17 -08002097}
2098
2099TEST_F(FrameTimelineTest, jankClassification_surfaceFrameLateFinishEarlyPresent) {
Alec Mouri363faf02021-01-29 16:34:55 -08002100 EXPECT_CALL(*mTimeStats, incrementJankyFrames(_));
Alec Mouri7d436ec2021-01-27 20:40:50 -08002101
Adithya Srinivasan9b2ca3e2020-11-10 10:14:17 -08002102 auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE);
Adithya Srinivasan939cd4d2021-02-23 06:18:13 +00002103 int64_t sfToken1 = mTokenManager->generateTokenForPredictions({42, 50, 50});
Adithya Srinivasan9b2ca3e2020-11-10 10:14:17 -08002104 int64_t surfaceFrameToken1 = mTokenManager->generateTokenForPredictions({5, 26, 60});
Huihong Luo3bdef862022-03-03 11:57:19 -08002105 FrameTimelineInfo ftInfo;
2106 ftInfo.vsyncId = surfaceFrameToken1;
2107 ftInfo.inputEventId = sInputEventId;
Adithya Srinivasan9b2ca3e2020-11-10 10:14:17 -08002108 auto surfaceFrame1 =
Huihong Luo3bdef862022-03-03 11:57:19 -08002109 mFrameTimeline->createSurfaceFrameForToken(ftInfo, sPidOne, sUidOne, sLayerIdOne,
2110 sLayerNameOne, sLayerNameOne,
2111 /*isBuffer*/ true, sGameMode);
Adithya Srinivasan9b2ca3e2020-11-10 10:14:17 -08002112 surfaceFrame1->setAcquireFenceTime(40);
Pascal Muetschardac7bcd92023-10-03 15:05:36 +02002113 mFrameTimeline->setSfWakeUp(sfToken1, 42, RR_11, RR_11);
Adithya Srinivasan9b2ca3e2020-11-10 10:14:17 -08002114 surfaceFrame1->setPresentState(SurfaceFrame::PresentState::Presented);
2115 mFrameTimeline->addSurfaceFrame(surfaceFrame1);
2116 mFrameTimeline->setSfPresent(46, presentFence1);
2117 auto displayFrame1 = getDisplayFrame(0);
2118 auto& presentedSurfaceFrame1 = getSurfaceFrame(0, 0);
2119 presentFence1->signalForTest(50);
2120
2121 // Fences for the first frame haven't been flushed yet, so it should be 0
2122 EXPECT_EQ(displayFrame1->getActuals().presentTime, 0);
2123 auto actuals1 = presentedSurfaceFrame1.getActuals();
2124 EXPECT_EQ(actuals1.presentTime, 0);
2125
2126 addEmptyDisplayFrame();
2127
2128 // Fences for the first frame have flushed, so the present timestamps should be updated
2129 EXPECT_EQ(displayFrame1->getActuals().presentTime, 50);
2130 EXPECT_EQ(displayFrame1->getFramePresentMetadata(), FramePresentMetadata::OnTimePresent);
2131 EXPECT_EQ(displayFrame1->getFrameReadyMetadata(), FrameReadyMetadata::OnTimeFinish);
2132 EXPECT_EQ(displayFrame1->getJankType(), JankType::None);
Ying Wei96eb5352023-11-21 17:37:21 +00002133 EXPECT_EQ(displayFrame1->getJankSeverityType(), JankSeverityType::None);
Adithya Srinivasan9b2ca3e2020-11-10 10:14:17 -08002134
2135 actuals1 = presentedSurfaceFrame1.getActuals();
2136 EXPECT_EQ(actuals1.presentTime, 50);
2137 EXPECT_EQ(presentedSurfaceFrame1.getFramePresentMetadata(), FramePresentMetadata::EarlyPresent);
2138 EXPECT_EQ(presentedSurfaceFrame1.getFrameReadyMetadata(), FrameReadyMetadata::LateFinish);
2139 EXPECT_EQ(presentedSurfaceFrame1.getJankType(), JankType::Unknown);
Ying Wei96eb5352023-11-21 17:37:21 +00002140 EXPECT_EQ(presentedSurfaceFrame1.getJankSeverityType(), JankSeverityType::Partial);
Adithya Srinivasan9b2ca3e2020-11-10 10:14:17 -08002141}
2142
2143TEST_F(FrameTimelineTest, jankClassification_surfaceFrameLateFinishLatePresent) {
Adithya Srinivasan8a945502021-03-19 19:12:32 +00002144 // First frame - DisplayFrame is not janky. This should classify the SurfaceFrame as only
Adithya Srinivasan9b2ca3e2020-11-10 10:14:17 -08002145 // AppDeadlineMissed. Second frame - DisplayFrame is janky. This should propagate DisplayFrame's
Adithya Srinivasan8a945502021-03-19 19:12:32 +00002146 // jank to the SurfaceFrame along with AppDeadlineMissed.
Adithya Srinivasan9b2ca3e2020-11-10 10:14:17 -08002147
Alec Mouri363faf02021-01-29 16:34:55 -08002148 EXPECT_CALL(*mTimeStats, incrementJankyFrames(_)).Times(2);
Adithya Srinivasan9b2ca3e2020-11-10 10:14:17 -08002149 auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE);
Adithya Srinivasan939cd4d2021-02-23 06:18:13 +00002150 int64_t sfToken1 = mTokenManager->generateTokenForPredictions({32, 40, 40});
2151 int64_t sfToken2 = mTokenManager->generateTokenForPredictions({42, 50, 50});
Adithya Srinivasan9b2ca3e2020-11-10 10:14:17 -08002152 int64_t surfaceFrameToken1 = mTokenManager->generateTokenForPredictions({5, 16, 30});
2153 int64_t surfaceFrameToken2 = mTokenManager->generateTokenForPredictions({25, 36, 50});
Huihong Luo3bdef862022-03-03 11:57:19 -08002154 FrameTimelineInfo ftInfo;
2155 ftInfo.vsyncId = surfaceFrameToken1;
2156 ftInfo.inputEventId = sInputEventId;
Adithya Srinivasan9b2ca3e2020-11-10 10:14:17 -08002157 auto surfaceFrame1 =
Huihong Luo3bdef862022-03-03 11:57:19 -08002158 mFrameTimeline->createSurfaceFrameForToken(ftInfo, sPidOne, sUidOne, sLayerIdOne,
2159 sLayerNameOne, sLayerNameOne,
2160 /*isBuffer*/ true, sGameMode);
Adithya Srinivasan9b2ca3e2020-11-10 10:14:17 -08002161 surfaceFrame1->setAcquireFenceTime(26);
Pascal Muetschardac7bcd92023-10-03 15:05:36 +02002162 mFrameTimeline->setSfWakeUp(sfToken1, 32, RR_11, RR_11);
Adithya Srinivasan9b2ca3e2020-11-10 10:14:17 -08002163 surfaceFrame1->setPresentState(SurfaceFrame::PresentState::Presented);
2164 mFrameTimeline->addSurfaceFrame(surfaceFrame1);
2165 mFrameTimeline->setSfPresent(36, presentFence1);
2166 auto displayFrame1 = getDisplayFrame(0);
2167 auto& presentedSurfaceFrame1 = getSurfaceFrame(0, 0);
2168 presentFence1->signalForTest(40);
2169
2170 // Fences for the first frame haven't been flushed yet, so it should be 0
2171 EXPECT_EQ(displayFrame1->getActuals().presentTime, 0);
2172 auto actuals1 = presentedSurfaceFrame1.getActuals();
2173 EXPECT_EQ(actuals1.presentTime, 0);
2174
2175 // Trigger a flush by finalizing the next DisplayFrame
2176 auto presentFence2 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE);
Huihong Luo3bdef862022-03-03 11:57:19 -08002177 FrameTimelineInfo ftInfo2;
2178 ftInfo2.vsyncId = surfaceFrameToken2;
2179 ftInfo2.inputEventId = sInputEventId;
Adithya Srinivasan9b2ca3e2020-11-10 10:14:17 -08002180 auto surfaceFrame2 =
Huihong Luo3bdef862022-03-03 11:57:19 -08002181 mFrameTimeline->createSurfaceFrameForToken(ftInfo2, sPidOne, sUidOne, sLayerIdOne,
2182 sLayerNameOne, sLayerNameOne,
2183 /*isBuffer*/ true, sGameMode);
Adithya Srinivasan9b2ca3e2020-11-10 10:14:17 -08002184 surfaceFrame2->setAcquireFenceTime(40);
Pascal Muetschardac7bcd92023-10-03 15:05:36 +02002185 mFrameTimeline->setSfWakeUp(sfToken2, 43, RR_11, RR_11);
Adithya Srinivasan9b2ca3e2020-11-10 10:14:17 -08002186 surfaceFrame2->setPresentState(SurfaceFrame::PresentState::Presented);
2187 mFrameTimeline->addSurfaceFrame(surfaceFrame2);
2188 mFrameTimeline->setSfPresent(56, presentFence2);
2189 auto displayFrame2 = getDisplayFrame(1);
2190 auto& presentedSurfaceFrame2 = getSurfaceFrame(1, 0);
2191
2192 // Fences for the first frame have flushed, so the present timestamps should be updated
2193 EXPECT_EQ(displayFrame1->getActuals().presentTime, 40);
2194 EXPECT_EQ(displayFrame1->getFramePresentMetadata(), FramePresentMetadata::OnTimePresent);
2195 EXPECT_EQ(displayFrame1->getFrameReadyMetadata(), FrameReadyMetadata::OnTimeFinish);
2196 EXPECT_EQ(displayFrame1->getJankType(), JankType::None);
Ying Wei96eb5352023-11-21 17:37:21 +00002197 EXPECT_EQ(displayFrame1->getJankSeverityType(), JankSeverityType::None);
Adithya Srinivasan9b2ca3e2020-11-10 10:14:17 -08002198
2199 actuals1 = presentedSurfaceFrame1.getActuals();
2200 EXPECT_EQ(actuals1.presentTime, 40);
2201 EXPECT_EQ(presentedSurfaceFrame1.getFramePresentMetadata(), FramePresentMetadata::LatePresent);
2202 EXPECT_EQ(presentedSurfaceFrame1.getFrameReadyMetadata(), FrameReadyMetadata::LateFinish);
2203 EXPECT_EQ(presentedSurfaceFrame1.getJankType(), JankType::AppDeadlineMissed);
Ying Wei96eb5352023-11-21 17:37:21 +00002204 EXPECT_EQ(presentedSurfaceFrame1.getJankSeverityType(), JankSeverityType::Partial);
Adithya Srinivasan9b2ca3e2020-11-10 10:14:17 -08002205
2206 // Fences for the second frame haven't been flushed yet, so it should be 0
2207 presentFence2->signalForTest(60);
2208 EXPECT_EQ(displayFrame2->getActuals().presentTime, 0);
2209 auto actuals2 = presentedSurfaceFrame2.getActuals();
2210 EXPECT_EQ(actuals2.presentTime, 0);
2211
2212 addEmptyDisplayFrame();
2213
2214 // Fences for the second frame have flushed, so the present timestamps should be updated
2215 EXPECT_EQ(displayFrame2->getActuals().presentTime, 60);
2216 EXPECT_EQ(displayFrame2->getFramePresentMetadata(), FramePresentMetadata::LatePresent);
2217 EXPECT_EQ(displayFrame2->getFrameReadyMetadata(), FrameReadyMetadata::LateFinish);
2218 EXPECT_EQ(displayFrame2->getJankType(), JankType::SurfaceFlingerCpuDeadlineMissed);
Ying Wei96eb5352023-11-21 17:37:21 +00002219 EXPECT_EQ(displayFrame2->getJankSeverityType(), JankSeverityType::Partial);
Adithya Srinivasan9b2ca3e2020-11-10 10:14:17 -08002220
2221 actuals2 = presentedSurfaceFrame2.getActuals();
2222 EXPECT_EQ(actuals2.presentTime, 60);
2223 EXPECT_EQ(presentedSurfaceFrame2.getFramePresentMetadata(), FramePresentMetadata::LatePresent);
2224 EXPECT_EQ(presentedSurfaceFrame2.getFrameReadyMetadata(), FrameReadyMetadata::LateFinish);
Adithya Srinivasan8a945502021-03-19 19:12:32 +00002225 EXPECT_EQ(presentedSurfaceFrame2.getJankType(),
2226 JankType::SurfaceFlingerCpuDeadlineMissed | JankType::AppDeadlineMissed);
Ying Wei96eb5352023-11-21 17:37:21 +00002227 EXPECT_EQ(presentedSurfaceFrame2.getJankSeverityType(), JankSeverityType::Partial);
Adithya Srinivasan9b2ca3e2020-11-10 10:14:17 -08002228}
2229
2230TEST_F(FrameTimelineTest, jankClassification_multiJankBufferStuffingAndAppDeadlineMissed) {
Adithya Srinivasan9b2ca3e2020-11-10 10:14:17 -08002231 // Layer specific increment
Alec Mouri363faf02021-01-29 16:34:55 -08002232 EXPECT_CALL(*mTimeStats, incrementJankyFrames(_)).Times(2);
Adithya Srinivasan9b2ca3e2020-11-10 10:14:17 -08002233 auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE);
2234 int64_t surfaceFrameToken1 = mTokenManager->generateTokenForPredictions({10, 20, 30});
2235 int64_t surfaceFrameToken2 = mTokenManager->generateTokenForPredictions({40, 50, 60});
2236
Adithya Srinivasan939cd4d2021-02-23 06:18:13 +00002237 int64_t sfToken1 = mTokenManager->generateTokenForPredictions({52, 60, 60});
2238 int64_t sfToken2 = mTokenManager->generateTokenForPredictions({112, 120, 120});
Huihong Luo3bdef862022-03-03 11:57:19 -08002239 FrameTimelineInfo ftInfo;
2240 ftInfo.vsyncId = surfaceFrameToken1;
2241 ftInfo.inputEventId = sInputEventId;
Adithya Srinivasan9b2ca3e2020-11-10 10:14:17 -08002242 auto surfaceFrame1 =
Huihong Luo3bdef862022-03-03 11:57:19 -08002243 mFrameTimeline->createSurfaceFrameForToken(ftInfo, sPidOne, sUidOne, sLayerIdOne,
2244 sLayerNameOne, sLayerNameOne,
2245 /*isBuffer*/ true, sGameMode);
Adithya Srinivasan9b2ca3e2020-11-10 10:14:17 -08002246 surfaceFrame1->setAcquireFenceTime(50);
Pascal Muetschardac7bcd92023-10-03 15:05:36 +02002247 mFrameTimeline->setSfWakeUp(sfToken1, 52, RR_30, RR_30);
Adithya Srinivasan9b2ca3e2020-11-10 10:14:17 -08002248 surfaceFrame1->setPresentState(SurfaceFrame::PresentState::Presented);
2249 mFrameTimeline->addSurfaceFrame(surfaceFrame1);
2250 mFrameTimeline->setSfPresent(56, presentFence1);
2251 auto displayFrame1 = getDisplayFrame(0);
2252 auto& presentedSurfaceFrame1 = getSurfaceFrame(0, 0);
2253 presentFence1->signalForTest(60);
2254
2255 // Fences for the first frame haven't been flushed yet, so it should be 0
2256 EXPECT_EQ(displayFrame1->getActuals().presentTime, 0);
2257 auto actuals1 = presentedSurfaceFrame1.getActuals();
2258 EXPECT_EQ(actuals1.presentTime, 0);
2259
2260 // Trigger a flush by finalizing the next DisplayFrame
2261 auto presentFence2 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE);
Huihong Luo3bdef862022-03-03 11:57:19 -08002262 FrameTimelineInfo ftInfo2;
2263 ftInfo2.vsyncId = surfaceFrameToken2;
2264 ftInfo2.inputEventId = sInputEventId;
Adithya Srinivasan9b2ca3e2020-11-10 10:14:17 -08002265 auto surfaceFrame2 =
Huihong Luo3bdef862022-03-03 11:57:19 -08002266 mFrameTimeline->createSurfaceFrameForToken(ftInfo2, sPidOne, sUidOne, sLayerIdOne,
2267 sLayerNameOne, sLayerNameOne,
2268 /*isBuffer*/ true, sGameMode);
Adithya Srinivasan9b2ca3e2020-11-10 10:14:17 -08002269 surfaceFrame2->setAcquireFenceTime(84);
Pascal Muetschardac7bcd92023-10-03 15:05:36 +02002270 mFrameTimeline->setSfWakeUp(sfToken2, 112, RR_30, RR_30);
Adithya Srinivasan9b2ca3e2020-11-10 10:14:17 -08002271 surfaceFrame2->setPresentState(SurfaceFrame::PresentState::Presented, 54);
2272 mFrameTimeline->addSurfaceFrame(surfaceFrame2);
2273 mFrameTimeline->setSfPresent(116, presentFence2);
2274 auto displayFrame2 = getDisplayFrame(1);
2275 auto& presentedSurfaceFrame2 = getSurfaceFrame(1, 0);
2276 presentFence2->signalForTest(120);
2277
2278 // Fences for the first frame have flushed, so the present timestamps should be updated
2279 EXPECT_EQ(displayFrame1->getActuals().presentTime, 60);
2280 actuals1 = presentedSurfaceFrame1.getActuals();
2281 EXPECT_EQ(actuals1.endTime, 50);
2282 EXPECT_EQ(actuals1.presentTime, 60);
2283
2284 EXPECT_EQ(displayFrame1->getFramePresentMetadata(), FramePresentMetadata::OnTimePresent);
2285 EXPECT_EQ(displayFrame1->getFrameReadyMetadata(), FrameReadyMetadata::OnTimeFinish);
2286 EXPECT_EQ(displayFrame1->getJankType(), JankType::None);
Ying Wei96eb5352023-11-21 17:37:21 +00002287 EXPECT_EQ(displayFrame1->getJankSeverityType(), JankSeverityType::None);
Adithya Srinivasan9b2ca3e2020-11-10 10:14:17 -08002288
2289 EXPECT_EQ(presentedSurfaceFrame1.getFramePresentMetadata(), FramePresentMetadata::LatePresent);
2290 EXPECT_EQ(presentedSurfaceFrame1.getFrameReadyMetadata(), FrameReadyMetadata::LateFinish);
2291 EXPECT_EQ(presentedSurfaceFrame1.getJankType(), JankType::AppDeadlineMissed);
Ying Wei96eb5352023-11-21 17:37:21 +00002292 EXPECT_EQ(presentedSurfaceFrame1.getJankSeverityType(), JankSeverityType::Full);
Adithya Srinivasan9b2ca3e2020-11-10 10:14:17 -08002293
2294 // Fences for the second frame haven't been flushed yet, so it should be 0
2295 EXPECT_EQ(displayFrame2->getActuals().presentTime, 0);
2296 auto actuals2 = presentedSurfaceFrame2.getActuals();
2297 EXPECT_EQ(actuals2.presentTime, 0);
2298
2299 addEmptyDisplayFrame();
2300
2301 // Fences for the second frame have flushed, so the present timestamps should be updated
2302 EXPECT_EQ(displayFrame2->getActuals().presentTime, 120);
2303 actuals2 = presentedSurfaceFrame2.getActuals();
2304 EXPECT_EQ(actuals2.presentTime, 120);
2305
2306 EXPECT_EQ(displayFrame2->getFramePresentMetadata(), FramePresentMetadata::OnTimePresent);
2307 EXPECT_EQ(displayFrame2->getFrameReadyMetadata(), FrameReadyMetadata::OnTimeFinish);
2308 EXPECT_EQ(displayFrame2->getJankType(), JankType::None);
Ying Wei96eb5352023-11-21 17:37:21 +00002309 EXPECT_EQ(displayFrame2->getJankSeverityType(), JankSeverityType::None);
Adithya Srinivasan9b2ca3e2020-11-10 10:14:17 -08002310
2311 EXPECT_EQ(presentedSurfaceFrame2.getFramePresentMetadata(), FramePresentMetadata::LatePresent);
2312 EXPECT_EQ(presentedSurfaceFrame2.getFrameReadyMetadata(), FrameReadyMetadata::LateFinish);
2313 EXPECT_EQ(presentedSurfaceFrame2.getJankType(),
2314 JankType::AppDeadlineMissed | JankType::BufferStuffing);
Ying Wei96eb5352023-11-21 17:37:21 +00002315 EXPECT_EQ(presentedSurfaceFrame2.getJankSeverityType(), JankSeverityType::Full);
Adithya Srinivasan9b2ca3e2020-11-10 10:14:17 -08002316}
Alec Mouriadebf5c2021-01-05 12:57:36 -08002317
Adithya Srinivasan939cd4d2021-02-23 06:18:13 +00002318TEST_F(FrameTimelineTest, jankClassification_appDeadlineAdjustedForBufferStuffing) {
2319 // Layer specific increment
2320 EXPECT_CALL(*mTimeStats, incrementJankyFrames(_)).Times(2);
2321 auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE);
2322 int64_t surfaceFrameToken1 = mTokenManager->generateTokenForPredictions({10, 20, 30});
2323 int64_t surfaceFrameToken2 = mTokenManager->generateTokenForPredictions({40, 50, 60});
2324
2325 int64_t sfToken1 = mTokenManager->generateTokenForPredictions({52, 60, 60});
2326 int64_t sfToken2 = mTokenManager->generateTokenForPredictions({82, 90, 90});
Huihong Luo3bdef862022-03-03 11:57:19 -08002327 FrameTimelineInfo ftInfo;
2328 ftInfo.vsyncId = surfaceFrameToken1;
2329 ftInfo.inputEventId = sInputEventId;
Adithya Srinivasan939cd4d2021-02-23 06:18:13 +00002330 auto surfaceFrame1 =
Huihong Luo3bdef862022-03-03 11:57:19 -08002331 mFrameTimeline->createSurfaceFrameForToken(ftInfo, sPidOne, sUidOne, sLayerIdOne,
2332 sLayerNameOne, sLayerNameOne,
2333 /*isBuffer*/ true, sGameMode);
Adithya Srinivasan939cd4d2021-02-23 06:18:13 +00002334 surfaceFrame1->setAcquireFenceTime(50);
Pascal Muetschardac7bcd92023-10-03 15:05:36 +02002335 mFrameTimeline->setSfWakeUp(sfToken1, 52, RR_30, RR_30);
Adithya Srinivasan939cd4d2021-02-23 06:18:13 +00002336 surfaceFrame1->setPresentState(SurfaceFrame::PresentState::Presented);
2337 mFrameTimeline->addSurfaceFrame(surfaceFrame1);
2338 mFrameTimeline->setSfPresent(56, presentFence1);
2339 auto displayFrame1 = getDisplayFrame(0);
2340 auto& presentedSurfaceFrame1 = getSurfaceFrame(0, 0);
2341 presentFence1->signalForTest(60);
2342
2343 // Fences for the first frame haven't been flushed yet, so it should be 0
2344 EXPECT_EQ(displayFrame1->getActuals().presentTime, 0);
2345 auto actuals1 = presentedSurfaceFrame1.getActuals();
2346 EXPECT_EQ(actuals1.presentTime, 0);
2347
2348 // Trigger a flush by finalizing the next DisplayFrame
2349 auto presentFence2 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE);
Huihong Luo3bdef862022-03-03 11:57:19 -08002350 FrameTimelineInfo ftInfo2;
2351 ftInfo2.vsyncId = surfaceFrameToken2;
2352 ftInfo2.inputEventId = sInputEventId;
Adithya Srinivasan939cd4d2021-02-23 06:18:13 +00002353 auto surfaceFrame2 =
Huihong Luo3bdef862022-03-03 11:57:19 -08002354 mFrameTimeline->createSurfaceFrameForToken(ftInfo2, sPidOne, sUidOne, sLayerIdOne,
2355 sLayerNameOne, sLayerNameOne,
2356 /*isBuffer*/ true, sGameMode);
Adithya Srinivasan939cd4d2021-02-23 06:18:13 +00002357 surfaceFrame2->setAcquireFenceTime(80);
Pascal Muetschardac7bcd92023-10-03 15:05:36 +02002358 mFrameTimeline->setSfWakeUp(sfToken2, 82, RR_30, RR_30);
Adithya Srinivasan939cd4d2021-02-23 06:18:13 +00002359 // Setting previous latch time to 54, adjusted deadline will be 54 + vsyncTime(30) = 84
2360 surfaceFrame2->setPresentState(SurfaceFrame::PresentState::Presented, 54);
2361 mFrameTimeline->addSurfaceFrame(surfaceFrame2);
2362 mFrameTimeline->setSfPresent(86, presentFence2);
2363 auto displayFrame2 = getDisplayFrame(1);
2364 auto& presentedSurfaceFrame2 = getSurfaceFrame(1, 0);
2365 presentFence2->signalForTest(90);
2366
2367 // Fences for the first frame have flushed, so the present timestamps should be updated
2368 EXPECT_EQ(displayFrame1->getActuals().presentTime, 60);
2369 actuals1 = presentedSurfaceFrame1.getActuals();
2370 EXPECT_EQ(actuals1.endTime, 50);
2371 EXPECT_EQ(actuals1.presentTime, 60);
2372
2373 EXPECT_EQ(displayFrame1->getFramePresentMetadata(), FramePresentMetadata::OnTimePresent);
2374 EXPECT_EQ(displayFrame1->getFrameReadyMetadata(), FrameReadyMetadata::OnTimeFinish);
2375 EXPECT_EQ(displayFrame1->getJankType(), JankType::None);
Ying Wei96eb5352023-11-21 17:37:21 +00002376 EXPECT_EQ(displayFrame1->getJankSeverityType(), JankSeverityType::None);
Adithya Srinivasan939cd4d2021-02-23 06:18:13 +00002377
2378 EXPECT_EQ(presentedSurfaceFrame1.getFramePresentMetadata(), FramePresentMetadata::LatePresent);
2379 EXPECT_EQ(presentedSurfaceFrame1.getFrameReadyMetadata(), FrameReadyMetadata::LateFinish);
2380 EXPECT_EQ(presentedSurfaceFrame1.getJankType(), JankType::AppDeadlineMissed);
Ying Wei96eb5352023-11-21 17:37:21 +00002381 EXPECT_EQ(presentedSurfaceFrame1.getJankSeverityType(), JankSeverityType::Full);
Adithya Srinivasan939cd4d2021-02-23 06:18:13 +00002382
2383 // Fences for the second frame haven't been flushed yet, so it should be 0
2384 EXPECT_EQ(displayFrame2->getActuals().presentTime, 0);
2385 auto actuals2 = presentedSurfaceFrame2.getActuals();
2386 EXPECT_EQ(actuals2.presentTime, 0);
2387
2388 addEmptyDisplayFrame();
2389
2390 // Fences for the second frame have flushed, so the present timestamps should be updated
2391 EXPECT_EQ(displayFrame2->getActuals().presentTime, 90);
2392 actuals2 = presentedSurfaceFrame2.getActuals();
2393 EXPECT_EQ(actuals2.presentTime, 90);
2394
2395 EXPECT_EQ(displayFrame2->getFramePresentMetadata(), FramePresentMetadata::OnTimePresent);
2396 EXPECT_EQ(displayFrame2->getFrameReadyMetadata(), FrameReadyMetadata::OnTimeFinish);
2397 EXPECT_EQ(displayFrame2->getJankType(), JankType::None);
Ying Wei96eb5352023-11-21 17:37:21 +00002398 EXPECT_EQ(displayFrame2->getJankSeverityType(), JankSeverityType::None);
Adithya Srinivasan939cd4d2021-02-23 06:18:13 +00002399
2400 EXPECT_EQ(presentedSurfaceFrame2.getFramePresentMetadata(), FramePresentMetadata::LatePresent);
2401 EXPECT_EQ(presentedSurfaceFrame2.getFrameReadyMetadata(), FrameReadyMetadata::OnTimeFinish);
2402 EXPECT_EQ(presentedSurfaceFrame2.getJankType(), JankType::BufferStuffing);
Ying Wei96eb5352023-11-21 17:37:21 +00002403 EXPECT_EQ(presentedSurfaceFrame2.getJankSeverityType(), JankSeverityType::Full);
Adithya Srinivasan939cd4d2021-02-23 06:18:13 +00002404}
2405
Rachel Lee94917b32022-03-18 17:52:09 -07002406TEST_F(FrameTimelineTest, jankClassification_displayFrameLateFinishLatePresent_GpuAndCpuMiss) {
2407 auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE);
2408 auto presentFence2 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE);
2409 auto gpuFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE);
2410 int64_t sfToken1 = mTokenManager->generateTokenForPredictions({22, 26, 40});
2411 int64_t sfToken2 = mTokenManager->generateTokenForPredictions({52, 60, 60});
2412
2413 // Case 1: cpu time = 33 - 12 = 21, vsync period = 11
Pascal Muetschardac7bcd92023-10-03 15:05:36 +02002414 mFrameTimeline->setSfWakeUp(sfToken1, 12, RR_11, RR_11);
Rachel Lee94917b32022-03-18 17:52:09 -07002415 mFrameTimeline->setSfPresent(33, presentFence1, gpuFence1);
2416 auto displayFrame = getDisplayFrame(0);
2417 gpuFence1->signalForTest(36);
2418 presentFence1->signalForTest(52);
2419
2420 // Fences haven't been flushed yet, so it should be 0
2421 EXPECT_EQ(displayFrame->getActuals().presentTime, 0);
2422
2423 addEmptyDisplayFrame();
2424 displayFrame = getDisplayFrame(0);
2425
2426 // Fences have flushed, so the present timestamps should be updated
2427 EXPECT_EQ(displayFrame->getActuals().presentTime, 52);
2428 EXPECT_EQ(displayFrame->getFramePresentMetadata(), FramePresentMetadata::LatePresent);
2429 EXPECT_EQ(displayFrame->getFrameReadyMetadata(), FrameReadyMetadata::LateFinish);
2430 EXPECT_EQ(displayFrame->getJankType(), JankType::SurfaceFlingerGpuDeadlineMissed);
Ying Wei96eb5352023-11-21 17:37:21 +00002431 EXPECT_EQ(displayFrame->getJankSeverityType(), JankSeverityType::Full);
Rachel Lee94917b32022-03-18 17:52:09 -07002432
2433 // Case 2: No GPU fence so it will not use GPU composition.
Pascal Muetschardac7bcd92023-10-03 15:05:36 +02002434 mFrameTimeline->setSfWakeUp(sfToken2, 52, RR_30, RR_30);
Rachel Lee94917b32022-03-18 17:52:09 -07002435 mFrameTimeline->setSfPresent(66, presentFence2);
2436 auto displayFrame2 = getDisplayFrame(2); // 2 because of previous empty frame
2437 presentFence2->signalForTest(90);
2438
2439 // Fences for the frame haven't been flushed yet, so it should be 0
2440 EXPECT_EQ(displayFrame2->getActuals().presentTime, 0);
2441
2442 addEmptyDisplayFrame();
2443
2444 // Fences have flushed, so the present timestamps should be updated
2445 EXPECT_EQ(displayFrame2->getActuals().presentTime, 90);
2446 EXPECT_EQ(displayFrame2->getFramePresentMetadata(), FramePresentMetadata::LatePresent);
2447 EXPECT_EQ(displayFrame2->getFrameReadyMetadata(), FrameReadyMetadata::LateFinish);
2448 EXPECT_EQ(displayFrame2->getJankType(), JankType::SurfaceFlingerCpuDeadlineMissed);
Ying Wei96eb5352023-11-21 17:37:21 +00002449 EXPECT_EQ(displayFrame2->getJankSeverityType(), JankSeverityType::Full);
Rachel Lee94917b32022-03-18 17:52:09 -07002450}
2451
Ady Abrahamfcb16862022-10-10 14:35:21 -07002452TEST_F(FrameTimelineTest, jankClassification_presentFenceError) {
2453 auto erroneousPresentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE);
2454 auto erroneousPresentFence2 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE);
2455 auto validPresentFence = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE);
2456 int64_t sfToken1 = mTokenManager->generateTokenForPredictions({22, 26, 40});
2457 int64_t sfToken2 = mTokenManager->generateTokenForPredictions({52, 60, 60});
2458 int64_t sfToken3 = mTokenManager->generateTokenForPredictions({72, 80, 80});
2459
Pascal Muetschardac7bcd92023-10-03 15:05:36 +02002460 mFrameTimeline->setSfWakeUp(sfToken1, 22, RR_11, RR_11);
Ady Abrahamfcb16862022-10-10 14:35:21 -07002461 mFrameTimeline->setSfPresent(26, erroneousPresentFence1);
2462
Pascal Muetschardac7bcd92023-10-03 15:05:36 +02002463 mFrameTimeline->setSfWakeUp(sfToken2, 52, RR_11, RR_11);
Ady Abrahamfcb16862022-10-10 14:35:21 -07002464 mFrameTimeline->setSfPresent(60, erroneousPresentFence2);
2465
Pascal Muetschardac7bcd92023-10-03 15:05:36 +02002466 mFrameTimeline->setSfWakeUp(sfToken3, 72, RR_11, RR_11);
Ady Abrahamfcb16862022-10-10 14:35:21 -07002467 mFrameTimeline->setSfPresent(80, validPresentFence);
2468
Ady Abrahamb1e10d12023-03-13 15:23:54 -07002469 erroneousPresentFence2->signalForTest(2);
Ady Abrahamfcb16862022-10-10 14:35:21 -07002470 validPresentFence->signalForTest(80);
2471
2472 addEmptyDisplayFrame();
2473
2474 {
2475 auto displayFrame = getDisplayFrame(0);
2476 EXPECT_EQ(displayFrame->getActuals().presentTime, 26);
2477 EXPECT_EQ(displayFrame->getFramePresentMetadata(), FramePresentMetadata::UnknownPresent);
2478 EXPECT_EQ(displayFrame->getFrameReadyMetadata(), FrameReadyMetadata::UnknownFinish);
Ady Abrahamb1e10d12023-03-13 15:23:54 -07002479 EXPECT_EQ(displayFrame->getJankType(), JankType::Unknown | JankType::DisplayHAL);
Ying Wei96eb5352023-11-21 17:37:21 +00002480 EXPECT_EQ(displayFrame->getJankSeverityType(), JankSeverityType::Unknown);
Ady Abrahamfcb16862022-10-10 14:35:21 -07002481 }
2482 {
2483 auto displayFrame = getDisplayFrame(1);
2484 EXPECT_EQ(displayFrame->getActuals().presentTime, 60);
2485 EXPECT_EQ(displayFrame->getFramePresentMetadata(), FramePresentMetadata::UnknownPresent);
2486 EXPECT_EQ(displayFrame->getFrameReadyMetadata(), FrameReadyMetadata::UnknownFinish);
Ady Abrahamb1e10d12023-03-13 15:23:54 -07002487 EXPECT_EQ(displayFrame->getJankType(), JankType::Unknown | JankType::DisplayHAL);
Ying Wei96eb5352023-11-21 17:37:21 +00002488 EXPECT_EQ(displayFrame->getJankSeverityType(), JankSeverityType::Unknown);
Ady Abrahamfcb16862022-10-10 14:35:21 -07002489 }
2490 {
2491 auto displayFrame = getDisplayFrame(2);
2492 EXPECT_EQ(displayFrame->getActuals().presentTime, 80);
2493 EXPECT_EQ(displayFrame->getFramePresentMetadata(), FramePresentMetadata::OnTimePresent);
2494 EXPECT_EQ(displayFrame->getFrameReadyMetadata(), FrameReadyMetadata::OnTimeFinish);
2495 EXPECT_EQ(displayFrame->getJankType(), JankType::None);
Ying Wei96eb5352023-11-21 17:37:21 +00002496 EXPECT_EQ(displayFrame->getJankSeverityType(), JankSeverityType::None);
Ady Abrahamfcb16862022-10-10 14:35:21 -07002497 }
2498}
2499
Alec Mouriadebf5c2021-01-05 12:57:36 -08002500TEST_F(FrameTimelineTest, computeFps_noLayerIds_returnsZero) {
2501 EXPECT_EQ(mFrameTimeline->computeFps({}), 0.0f);
2502}
2503
2504TEST_F(FrameTimelineTest, computeFps_singleDisplayFrame_returnsZero) {
Adithya Srinivasan939cd4d2021-02-23 06:18:13 +00002505 const auto oneHundredMs = std::chrono::nanoseconds(100ms).count();
Alec Mouriadebf5c2021-01-05 12:57:36 -08002506
2507 auto surfaceFrame1 =
2508 mFrameTimeline->createSurfaceFrameForToken(FrameTimelineInfo(), sPidOne, sUidOne,
Adithya Srinivasan785addd2021-03-09 00:38:00 +00002509 sLayerIdOne, sLayerNameOne, sLayerNameOne,
Adithya Srinivasan58069dc2021-06-04 20:37:02 +00002510 /*isBuffer*/ true, sGameMode);
Alec Mouriadebf5c2021-01-05 12:57:36 -08002511 auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE);
2512 surfaceFrame1->setPresentState(SurfaceFrame::PresentState::Presented);
2513 mFrameTimeline->addSurfaceFrame(surfaceFrame1);
2514 presentFence1->signalForTest(oneHundredMs);
2515 mFrameTimeline->setSfPresent(oneHundredMs, presentFence1);
2516
2517 EXPECT_EQ(mFrameTimeline->computeFps({sLayerIdOne}), 0.0f);
2518}
2519
2520TEST_F(FrameTimelineTest, computeFps_twoDisplayFrames_oneLayer) {
Adithya Srinivasan939cd4d2021-02-23 06:18:13 +00002521 const auto oneHundredMs = std::chrono::nanoseconds(100ms).count();
2522 const auto twoHundredMs = std::chrono::nanoseconds(200ms).count();
Alec Mouriadebf5c2021-01-05 12:57:36 -08002523 auto surfaceFrame1 =
2524 mFrameTimeline->createSurfaceFrameForToken(FrameTimelineInfo(), sPidOne, sUidOne,
Adithya Srinivasan785addd2021-03-09 00:38:00 +00002525 sLayerIdOne, sLayerNameOne, sLayerNameOne,
Adithya Srinivasan58069dc2021-06-04 20:37:02 +00002526 /*isBuffer*/ true, sGameMode);
Alec Mouriadebf5c2021-01-05 12:57:36 -08002527 auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE);
2528 surfaceFrame1->setPresentState(SurfaceFrame::PresentState::Presented);
2529 mFrameTimeline->addSurfaceFrame(surfaceFrame1);
2530 presentFence1->signalForTest(oneHundredMs);
2531 mFrameTimeline->setSfPresent(oneHundredMs, presentFence1);
2532
2533 auto surfaceFrame2 =
2534 mFrameTimeline->createSurfaceFrameForToken(FrameTimelineInfo(), sPidOne, sUidOne,
Adithya Srinivasan785addd2021-03-09 00:38:00 +00002535 sLayerIdOne, sLayerNameOne, sLayerNameOne,
Adithya Srinivasan58069dc2021-06-04 20:37:02 +00002536 /*isBuffer*/ true, sGameMode);
Alec Mouriadebf5c2021-01-05 12:57:36 -08002537 auto presentFence2 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE);
2538 surfaceFrame2->setPresentState(SurfaceFrame::PresentState::Presented);
2539 mFrameTimeline->addSurfaceFrame(surfaceFrame2);
2540 presentFence2->signalForTest(twoHundredMs);
2541 mFrameTimeline->setSfPresent(twoHundredMs, presentFence2);
2542
2543 EXPECT_EQ(mFrameTimeline->computeFps({sLayerIdOne}), 10.0);
2544}
2545
2546TEST_F(FrameTimelineTest, computeFps_twoDisplayFrames_twoLayers) {
Adithya Srinivasan939cd4d2021-02-23 06:18:13 +00002547 const auto oneHundredMs = std::chrono::nanoseconds(100ms).count();
2548 const auto twoHundredMs = std::chrono::nanoseconds(200ms).count();
Alec Mouriadebf5c2021-01-05 12:57:36 -08002549 auto surfaceFrame1 =
2550 mFrameTimeline->createSurfaceFrameForToken(FrameTimelineInfo(), sPidOne, sUidOne,
Adithya Srinivasan785addd2021-03-09 00:38:00 +00002551 sLayerIdOne, sLayerNameOne, sLayerNameOne,
Adithya Srinivasan58069dc2021-06-04 20:37:02 +00002552 /*isBuffer*/ true, sGameMode);
Alec Mouriadebf5c2021-01-05 12:57:36 -08002553 auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE);
2554 surfaceFrame1->setPresentState(SurfaceFrame::PresentState::Presented);
2555 mFrameTimeline->addSurfaceFrame(surfaceFrame1);
2556 presentFence1->signalForTest(oneHundredMs);
2557 mFrameTimeline->setSfPresent(oneHundredMs, presentFence1);
2558
2559 auto surfaceFrame2 =
2560 mFrameTimeline->createSurfaceFrameForToken(FrameTimelineInfo(), sPidOne, sUidOne,
Adithya Srinivasan785addd2021-03-09 00:38:00 +00002561 sLayerIdTwo, sLayerNameTwo, sLayerNameTwo,
Adithya Srinivasan58069dc2021-06-04 20:37:02 +00002562 /*isBuffer*/ true, sGameMode);
Alec Mouriadebf5c2021-01-05 12:57:36 -08002563 auto presentFence2 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE);
2564 surfaceFrame2->setPresentState(SurfaceFrame::PresentState::Presented);
2565 mFrameTimeline->addSurfaceFrame(surfaceFrame2);
2566 presentFence2->signalForTest(twoHundredMs);
2567 mFrameTimeline->setSfPresent(twoHundredMs, presentFence2);
2568
2569 EXPECT_EQ(mFrameTimeline->computeFps({sLayerIdOne, sLayerIdTwo}), 10.0f);
2570}
2571
2572TEST_F(FrameTimelineTest, computeFps_filtersOutLayers) {
Adithya Srinivasan939cd4d2021-02-23 06:18:13 +00002573 const auto oneHundredMs = std::chrono::nanoseconds(100ms).count();
2574 const auto twoHundredMs = std::chrono::nanoseconds(200ms).count();
Alec Mouriadebf5c2021-01-05 12:57:36 -08002575 auto surfaceFrame1 =
2576 mFrameTimeline->createSurfaceFrameForToken(FrameTimelineInfo(), sPidOne, sUidOne,
Adithya Srinivasan785addd2021-03-09 00:38:00 +00002577 sLayerIdOne, sLayerNameOne, sLayerNameOne,
Adithya Srinivasan58069dc2021-06-04 20:37:02 +00002578 /*isBuffer*/ true, sGameMode);
Alec Mouriadebf5c2021-01-05 12:57:36 -08002579 auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE);
2580 surfaceFrame1->setPresentState(SurfaceFrame::PresentState::Presented);
2581 mFrameTimeline->addSurfaceFrame(surfaceFrame1);
2582 presentFence1->signalForTest(oneHundredMs);
2583 mFrameTimeline->setSfPresent(oneHundredMs, presentFence1);
2584
2585 auto surfaceFrame2 =
2586 mFrameTimeline->createSurfaceFrameForToken(FrameTimelineInfo(), sPidOne, sUidOne,
Adithya Srinivasan785addd2021-03-09 00:38:00 +00002587 sLayerIdTwo, sLayerNameTwo, sLayerNameTwo,
Adithya Srinivasan58069dc2021-06-04 20:37:02 +00002588 /*isBuffer*/ true, sGameMode);
Alec Mouriadebf5c2021-01-05 12:57:36 -08002589 auto presentFence2 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE);
2590 surfaceFrame2->setPresentState(SurfaceFrame::PresentState::Presented);
2591 mFrameTimeline->addSurfaceFrame(surfaceFrame2);
2592 presentFence2->signalForTest(twoHundredMs);
2593 mFrameTimeline->setSfPresent(twoHundredMs, presentFence2);
2594
2595 EXPECT_EQ(mFrameTimeline->computeFps({sLayerIdOne}), 0.0f);
2596}
2597
2598TEST_F(FrameTimelineTest, computeFps_averagesOverMultipleFrames) {
Adithya Srinivasan939cd4d2021-02-23 06:18:13 +00002599 const auto oneHundredMs = std::chrono::nanoseconds(100ms).count();
2600 const auto twoHundredMs = std::chrono::nanoseconds(200ms).count();
2601 const auto threeHundredMs = std::chrono::nanoseconds(300ms).count();
2602 const auto fiveHundredMs = std::chrono::nanoseconds(500ms).count();
2603 const auto sixHundredMs = std::chrono::nanoseconds(600ms).count();
Alec Mouriadebf5c2021-01-05 12:57:36 -08002604 auto surfaceFrame1 =
2605 mFrameTimeline->createSurfaceFrameForToken(FrameTimelineInfo(), sPidOne, sUidOne,
Adithya Srinivasan785addd2021-03-09 00:38:00 +00002606 sLayerIdOne, sLayerNameOne, sLayerNameOne,
Adithya Srinivasan58069dc2021-06-04 20:37:02 +00002607 /*isBuffer*/ true, sGameMode);
Alec Mouriadebf5c2021-01-05 12:57:36 -08002608 auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE);
2609 surfaceFrame1->setPresentState(SurfaceFrame::PresentState::Presented);
2610 mFrameTimeline->addSurfaceFrame(surfaceFrame1);
2611 presentFence1->signalForTest(oneHundredMs);
2612 mFrameTimeline->setSfPresent(oneHundredMs, presentFence1);
2613
2614 auto surfaceFrame2 =
2615 mFrameTimeline->createSurfaceFrameForToken(FrameTimelineInfo(), sPidOne, sUidOne,
Adithya Srinivasan785addd2021-03-09 00:38:00 +00002616 sLayerIdOne, sLayerNameOne, sLayerNameOne,
Adithya Srinivasan58069dc2021-06-04 20:37:02 +00002617 /*isBuffer*/ true, sGameMode);
Alec Mouriadebf5c2021-01-05 12:57:36 -08002618 auto presentFence2 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE);
2619 surfaceFrame2->setPresentState(SurfaceFrame::PresentState::Presented);
2620 mFrameTimeline->addSurfaceFrame(surfaceFrame2);
2621 presentFence2->signalForTest(twoHundredMs);
2622 mFrameTimeline->setSfPresent(twoHundredMs, presentFence2);
2623
2624 auto surfaceFrame3 =
2625 mFrameTimeline->createSurfaceFrameForToken(FrameTimelineInfo(), sPidOne, sUidOne,
Adithya Srinivasan785addd2021-03-09 00:38:00 +00002626 sLayerIdTwo, sLayerNameTwo, sLayerNameTwo,
Adithya Srinivasan58069dc2021-06-04 20:37:02 +00002627 /*isBuffer*/ true, sGameMode);
Alec Mouriadebf5c2021-01-05 12:57:36 -08002628 auto presentFence3 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE);
2629 surfaceFrame3->setPresentState(SurfaceFrame::PresentState::Presented);
2630 mFrameTimeline->addSurfaceFrame(surfaceFrame3);
2631 presentFence3->signalForTest(threeHundredMs);
2632 mFrameTimeline->setSfPresent(threeHundredMs, presentFence3);
2633
2634 auto surfaceFrame4 =
2635 mFrameTimeline->createSurfaceFrameForToken(FrameTimelineInfo(), sPidOne, sUidOne,
Adithya Srinivasan785addd2021-03-09 00:38:00 +00002636 sLayerIdOne, sLayerNameOne, sLayerNameOne,
Adithya Srinivasan58069dc2021-06-04 20:37:02 +00002637 /*isBuffer*/ true, sGameMode);
Alec Mouriadebf5c2021-01-05 12:57:36 -08002638 auto presentFence4 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE);
2639 surfaceFrame4->setPresentState(SurfaceFrame::PresentState::Presented);
2640 mFrameTimeline->addSurfaceFrame(surfaceFrame4);
2641 presentFence4->signalForTest(fiveHundredMs);
2642 mFrameTimeline->setSfPresent(fiveHundredMs, presentFence4);
2643
2644 auto surfaceFrame5 =
2645 mFrameTimeline->createSurfaceFrameForToken(FrameTimelineInfo(), sPidOne, sUidOne,
Adithya Srinivasan785addd2021-03-09 00:38:00 +00002646 sLayerIdOne, sLayerNameOne, sLayerNameOne,
Adithya Srinivasan58069dc2021-06-04 20:37:02 +00002647 /*isBuffer*/ true, sGameMode);
Alec Mouriadebf5c2021-01-05 12:57:36 -08002648 auto presentFence5 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE);
2649 // Dropped frames will be excluded from fps computation
2650 surfaceFrame5->setPresentState(SurfaceFrame::PresentState::Dropped);
2651 mFrameTimeline->addSurfaceFrame(surfaceFrame5);
2652 presentFence5->signalForTest(sixHundredMs);
2653 mFrameTimeline->setSfPresent(sixHundredMs, presentFence5);
2654
2655 EXPECT_EQ(mFrameTimeline->computeFps({sLayerIdOne}), 5.0f);
2656}
2657
ramindaniea2bb822022-06-27 19:52:10 +00002658TEST_F(FrameTimelineTest, getMinTime) {
2659 // Use SurfaceFrame::getBaseTime to test the getMinTime.
2660 FrameTimelineInfo ftInfo;
2661
2662 // Valid prediction state test.
2663 ftInfo.vsyncId = 0L;
2664 mTokenManager->generateTokenForPredictions({10});
2665 auto surfaceFrame =
2666 mFrameTimeline->createSurfaceFrameForToken(ftInfo, sPidOne, sUidOne, sLayerIdOne,
2667 sLayerNameOne, sLayerNameOne,
2668 /*isBuffer*/ true, sGameMode);
2669 ASSERT_EQ(surfaceFrame->getBaseTime(), 10);
2670
2671 // Test prediction state which is not valid.
2672 ftInfo.vsyncId = FrameTimelineInfo::INVALID_VSYNC_ID;
2673 surfaceFrame = mFrameTimeline->createSurfaceFrameForToken(ftInfo, sPidOne, sUidOne, sLayerIdOne,
2674 sLayerNameOne, sLayerNameOne,
2675 /*isBuffer*/ true, sGameMode);
2676 // Start time test.
2677 surfaceFrame->setActualStartTime(200);
2678 ASSERT_EQ(surfaceFrame->getBaseTime(), 200);
2679
2680 // End time test.
2681 surfaceFrame->setAcquireFenceTime(100);
2682 ASSERT_EQ(surfaceFrame->getBaseTime(), 100);
2683
2684 // Present time test.
2685 auto presentFence = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE);
2686 surfaceFrame->setPresentState(SurfaceFrame::PresentState::Presented);
2687 mFrameTimeline->addSurfaceFrame(surfaceFrame);
2688 presentFence->signalForTest(std::chrono::nanoseconds(50ns).count());
2689 mFrameTimeline->setSfPresent(50, presentFence);
2690 ASSERT_EQ(surfaceFrame->getBaseTime(), 50);
2691}
Pascal Muetschardac7bcd92023-10-03 15:05:36 +02002692
2693TEST_F(FrameTimelineTest, surfaceFrameRenderRateUsingDisplayRate) {
2694 auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE);
2695 int64_t token1 = mTokenManager->generateTokenForPredictions({10, 20, 30});
2696 FrameTimelineInfo ftInfo;
2697 ftInfo.vsyncId = token1;
2698 ftInfo.inputEventId = sInputEventId;
2699 auto surfaceFrame =
2700 mFrameTimeline->createSurfaceFrameForToken(ftInfo, sPidOne, sUidOne, sLayerIdOne,
2701 sLayerNameOne, sLayerNameOne,
2702 /*isBuffer*/ true, sGameMode);
2703
2704 mFrameTimeline->setSfWakeUp(token1, 20, RR_30, RR_11);
2705 surfaceFrame->setPresentState(SurfaceFrame::PresentState::Presented);
2706 mFrameTimeline->addSurfaceFrame(surfaceFrame);
2707 presentFence1->signalForTest(std::chrono::nanoseconds(50ns).count());
2708 mFrameTimeline->setSfPresent(50, presentFence1);
2709
2710 EXPECT_EQ(surfaceFrame->getRenderRate().getPeriodNsecs(), 11);
2711}
2712
2713TEST_F(FrameTimelineTest, surfaceFrameRenderRateUsingAppFrameRate) {
2714 auto presentFence1 = fenceFactory.createFenceTimeForTest(Fence::NO_FENCE);
2715 int64_t token1 = mTokenManager->generateTokenForPredictions({10, 20, 30});
2716 FrameTimelineInfo ftInfo;
2717 ftInfo.vsyncId = token1;
2718 ftInfo.inputEventId = sInputEventId;
2719 auto surfaceFrame =
2720 mFrameTimeline->createSurfaceFrameForToken(ftInfo, sPidOne, sUidOne, sLayerIdOne,
2721 sLayerNameOne, sLayerNameOne,
2722 /*isBuffer*/ true, sGameMode);
2723 surfaceFrame->setRenderRate(RR_30);
2724 mFrameTimeline->setSfWakeUp(token1, 20, RR_11, RR_11);
2725 surfaceFrame->setPresentState(SurfaceFrame::PresentState::Presented);
2726 mFrameTimeline->addSurfaceFrame(surfaceFrame);
2727 presentFence1->signalForTest(std::chrono::nanoseconds(50ns).count());
2728 mFrameTimeline->setSfPresent(50, presentFence1);
2729
2730 EXPECT_EQ(surfaceFrame->getRenderRate().getPeriodNsecs(), 30);
2731}
Adithya Srinivasanf279e042020-08-17 14:56:27 -07002732} // namespace android::frametimeline