Alec Mouri | 0a1cc96 | 2019-03-14 12:33:02 -0700 | [diff] [blame] | 1 | /* |
| 2 | * Copyright 2019 The Android Open Source Project |
| 3 | * |
| 4 | * Licensed under the Apache License, Version 2.0 (the "License"); |
| 5 | * you may not use this file except in compliance with the License. |
| 6 | * You may obtain a copy of the License at |
| 7 | * |
| 8 | * http://www.apache.org/licenses/LICENSE-2.0 |
| 9 | * |
| 10 | * Unless required by applicable law or agreed to in writing, software |
| 11 | * distributed under the License is distributed on an "AS IS" BASIS, |
| 12 | * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. |
| 13 | * See the License for the specific language governing permissions and |
| 14 | * limitations under the License. |
| 15 | */ |
| 16 | |
Marin Shalamanov | bed7fd3 | 2020-12-21 20:02:20 +0100 | [diff] [blame] | 17 | // TODO(b/129481165): remove the #pragma below and fix conversion issues |
| 18 | #pragma clang diagnostic push |
| 19 | #pragma clang diagnostic ignored "-Wextra" |
| 20 | |
Alec Mouri | 0a1cc96 | 2019-03-14 12:33:02 -0700 | [diff] [blame] | 21 | #undef LOG_TAG |
| 22 | #define LOG_TAG "SchedulerUnittests" |
| 23 | |
| 24 | #include <gmock/gmock.h> |
| 25 | #include <log/log.h> |
| 26 | #include <thread> |
| 27 | |
Marin Shalamanov | 3ea1d60 | 2020-12-16 19:59:39 +0100 | [diff] [blame] | 28 | #include <ui/Size.h> |
| 29 | |
Ady Abraham | 6fb599b | 2020-03-05 13:48:22 -0800 | [diff] [blame] | 30 | #include "../../Scheduler/RefreshRateConfigs.h" |
Alec Mouri | 0a1cc96 | 2019-03-14 12:33:02 -0700 | [diff] [blame] | 31 | #include "DisplayHardware/HWC2.h" |
| 32 | #include "Scheduler/RefreshRateConfigs.h" |
Alec Mouri | 0a1cc96 | 2019-03-14 12:33:02 -0700 | [diff] [blame] | 33 | |
| 34 | using namespace std::chrono_literals; |
Alec Mouri | 0a1cc96 | 2019-03-14 12:33:02 -0700 | [diff] [blame] | 35 | |
| 36 | namespace android { |
Marin Shalamanov | e8a663d | 2020-11-24 17:48:00 +0100 | [diff] [blame] | 37 | |
Alec Mouri | 0a1cc96 | 2019-03-14 12:33:02 -0700 | [diff] [blame] | 38 | namespace scheduler { |
| 39 | |
Peiyong Lin | e9d809e | 2020-04-14 13:10:48 -0700 | [diff] [blame] | 40 | namespace hal = android::hardware::graphics::composer::hal; |
| 41 | |
Alec Mouri | 0a1cc96 | 2019-03-14 12:33:02 -0700 | [diff] [blame] | 42 | using RefreshRate = RefreshRateConfigs::RefreshRate; |
Ady Abraham | 8a82ba6 | 2020-01-17 12:43:17 -0800 | [diff] [blame] | 43 | using LayerVoteType = RefreshRateConfigs::LayerVoteType; |
| 44 | using LayerRequirement = RefreshRateConfigs::LayerRequirement; |
Alec Mouri | 0a1cc96 | 2019-03-14 12:33:02 -0700 | [diff] [blame] | 45 | |
| 46 | class RefreshRateConfigsTest : public testing::Test { |
| 47 | protected: |
Marin Shalamanov | 4c7831e | 2021-06-08 20:44:06 +0200 | [diff] [blame] | 48 | using GetBestRefreshRateInvocation = RefreshRateConfigs::GetBestRefreshRateInvocation; |
| 49 | |
Alec Mouri | 0a1cc96 | 2019-03-14 12:33:02 -0700 | [diff] [blame] | 50 | RefreshRateConfigsTest(); |
| 51 | ~RefreshRateConfigsTest(); |
Ady Abraham | abc2760 | 2020-04-08 17:20:29 -0700 | [diff] [blame] | 52 | |
Marin Shalamanov | 4c7831e | 2021-06-08 20:44:06 +0200 | [diff] [blame] | 53 | RefreshRate createRefreshRate(DisplayModePtr displayMode) { |
Ady Abraham | 6b7ad65 | 2021-06-23 17:34:57 -0700 | [diff] [blame] | 54 | return {displayMode, RefreshRate::ConstructorTag(0)}; |
Marin Shalamanov | 4c7831e | 2021-06-08 20:44:06 +0200 | [diff] [blame] | 55 | } |
| 56 | |
Marin Shalamanov | e8a663d | 2020-11-24 17:48:00 +0100 | [diff] [blame] | 57 | Fps findClosestKnownFrameRate(const RefreshRateConfigs& refreshRateConfigs, Fps frameRate) { |
Ady Abraham | b1b9d41 | 2020-06-01 19:53:52 -0700 | [diff] [blame] | 58 | return refreshRateConfigs.findClosestKnownFrameRate(frameRate); |
| 59 | } |
| 60 | |
Marin Shalamanov | e8a663d | 2020-11-24 17:48:00 +0100 | [diff] [blame] | 61 | std::vector<Fps> getKnownFrameRate(const RefreshRateConfigs& refreshRateConfigs) { |
Ady Abraham | b1b9d41 | 2020-06-01 19:53:52 -0700 | [diff] [blame] | 62 | return refreshRateConfigs.mKnownFrameRates; |
| 63 | } |
| 64 | |
Marin Shalamanov | eadf2e7 | 2020-12-10 15:35:28 +0100 | [diff] [blame] | 65 | RefreshRate getMinRefreshRateByPolicy(const RefreshRateConfigs& refreshRateConfigs) { |
| 66 | std::lock_guard lock(refreshRateConfigs.mLock); |
| 67 | return refreshRateConfigs.getMinRefreshRateByPolicyLocked(); |
| 68 | } |
| 69 | |
| 70 | RefreshRate getMinSupportedRefreshRate(const RefreshRateConfigs& refreshRateConfigs) { |
| 71 | std::lock_guard lock(refreshRateConfigs.mLock); |
| 72 | return *refreshRateConfigs.mMinSupportedRefreshRate; |
| 73 | } |
| 74 | |
| 75 | RefreshRate getMaxSupportedRefreshRate(const RefreshRateConfigs& refreshRateConfigs) { |
| 76 | std::lock_guard lock(refreshRateConfigs.mLock); |
| 77 | return *refreshRateConfigs.mMaxSupportedRefreshRate; |
| 78 | } |
| 79 | |
Marin Shalamanov | 4c7831e | 2021-06-08 20:44:06 +0200 | [diff] [blame] | 80 | void setLastBestRefreshRateInvocation(RefreshRateConfigs& refreshRateConfigs, |
| 81 | const GetBestRefreshRateInvocation& invocation) { |
| 82 | std::lock_guard lock(refreshRateConfigs.mLock); |
| 83 | refreshRateConfigs.lastBestRefreshRateInvocation.emplace( |
| 84 | GetBestRefreshRateInvocation(invocation)); |
| 85 | } |
| 86 | |
| 87 | std::optional<GetBestRefreshRateInvocation> getLastBestRefreshRateInvocation( |
| 88 | const RefreshRateConfigs& refreshRateConfigs) { |
| 89 | std::lock_guard lock(refreshRateConfigs.mLock); |
| 90 | return refreshRateConfigs.lastBestRefreshRateInvocation; |
| 91 | } |
| 92 | |
Ady Abraham | abc2760 | 2020-04-08 17:20:29 -0700 | [diff] [blame] | 93 | // Test config IDs |
Marin Shalamanov | 23c4420 | 2020-12-22 19:09:20 +0100 | [diff] [blame] | 94 | static inline const DisplayModeId HWC_CONFIG_ID_60 = DisplayModeId(0); |
| 95 | static inline const DisplayModeId HWC_CONFIG_ID_90 = DisplayModeId(1); |
| 96 | static inline const DisplayModeId HWC_CONFIG_ID_72 = DisplayModeId(2); |
| 97 | static inline const DisplayModeId HWC_CONFIG_ID_120 = DisplayModeId(3); |
| 98 | static inline const DisplayModeId HWC_CONFIG_ID_30 = DisplayModeId(4); |
| 99 | static inline const DisplayModeId HWC_CONFIG_ID_25 = DisplayModeId(5); |
| 100 | static inline const DisplayModeId HWC_CONFIG_ID_50 = DisplayModeId(6); |
Marin Shalamanov | 15a0fc6 | 2021-08-16 18:20:21 +0200 | [diff] [blame^] | 101 | static inline const DisplayModeId HWC_CONFIG_ID_24 = DisplayModeId(7); |
| 102 | static inline const DisplayModeId HWC_CONFIG_ID_24_FRAC = DisplayModeId(8); |
| 103 | static inline const DisplayModeId HWC_CONFIG_ID_30_FRAC = DisplayModeId(9); |
| 104 | static inline const DisplayModeId HWC_CONFIG_ID_60_FRAC = DisplayModeId(10); |
Ady Abraham | abc2760 | 2020-04-08 17:20:29 -0700 | [diff] [blame] | 105 | |
| 106 | // Test configs |
Marin Shalamanov | a7fe304 | 2021-01-29 21:02:08 +0100 | [diff] [blame] | 107 | DisplayModePtr mConfig60 = createDisplayMode(HWC_CONFIG_ID_60, 0, Fps(60.0f).getPeriodNsecs()); |
Marin Shalamanov | 15a0fc6 | 2021-08-16 18:20:21 +0200 | [diff] [blame^] | 108 | DisplayModePtr mConfig60Frac = |
| 109 | createDisplayMode(HWC_CONFIG_ID_60_FRAC, 0, Fps(59.94f).getPeriodNsecs()); |
Marin Shalamanov | a7fe304 | 2021-01-29 21:02:08 +0100 | [diff] [blame] | 110 | DisplayModePtr mConfig90 = createDisplayMode(HWC_CONFIG_ID_90, 0, Fps(90.0f).getPeriodNsecs()); |
Marin Shalamanov | 3ea1d60 | 2020-12-16 19:59:39 +0100 | [diff] [blame] | 111 | DisplayModePtr mConfig90DifferentGroup = |
Marin Shalamanov | a7fe304 | 2021-01-29 21:02:08 +0100 | [diff] [blame] | 112 | createDisplayMode(HWC_CONFIG_ID_90, 1, Fps(90.0f).getPeriodNsecs()); |
Marin Shalamanov | 3ea1d60 | 2020-12-16 19:59:39 +0100 | [diff] [blame] | 113 | DisplayModePtr mConfig90DifferentResolution = |
Marin Shalamanov | a7fe304 | 2021-01-29 21:02:08 +0100 | [diff] [blame] | 114 | createDisplayMode(HWC_CONFIG_ID_90, 0, Fps(90.0f).getPeriodNsecs(), ui::Size(111, 222)); |
| 115 | DisplayModePtr mConfig72 = createDisplayMode(HWC_CONFIG_ID_72, 0, Fps(72.0f).getPeriodNsecs()); |
Marin Shalamanov | 3ea1d60 | 2020-12-16 19:59:39 +0100 | [diff] [blame] | 116 | DisplayModePtr mConfig72DifferentGroup = |
Marin Shalamanov | a7fe304 | 2021-01-29 21:02:08 +0100 | [diff] [blame] | 117 | createDisplayMode(HWC_CONFIG_ID_72, 1, Fps(72.0f).getPeriodNsecs()); |
| 118 | DisplayModePtr mConfig120 = |
| 119 | createDisplayMode(HWC_CONFIG_ID_120, 0, Fps(120.0f).getPeriodNsecs()); |
Marin Shalamanov | 3ea1d60 | 2020-12-16 19:59:39 +0100 | [diff] [blame] | 120 | DisplayModePtr mConfig120DifferentGroup = |
Marin Shalamanov | a7fe304 | 2021-01-29 21:02:08 +0100 | [diff] [blame] | 121 | createDisplayMode(HWC_CONFIG_ID_120, 1, Fps(120.0f).getPeriodNsecs()); |
| 122 | DisplayModePtr mConfig30 = createDisplayMode(HWC_CONFIG_ID_30, 0, Fps(30.0f).getPeriodNsecs()); |
Marin Shalamanov | 3ea1d60 | 2020-12-16 19:59:39 +0100 | [diff] [blame] | 123 | DisplayModePtr mConfig30DifferentGroup = |
Marin Shalamanov | a7fe304 | 2021-01-29 21:02:08 +0100 | [diff] [blame] | 124 | createDisplayMode(HWC_CONFIG_ID_30, 1, Fps(30.0f).getPeriodNsecs()); |
Marin Shalamanov | 15a0fc6 | 2021-08-16 18:20:21 +0200 | [diff] [blame^] | 125 | DisplayModePtr mConfig30Frac = |
| 126 | createDisplayMode(HWC_CONFIG_ID_30_FRAC, 0, Fps(29.97f).getPeriodNsecs()); |
| 127 | DisplayModePtr mConfig25 = createDisplayMode(HWC_CONFIG_ID_25, 0, Fps(25.0f).getPeriodNsecs()); |
Marin Shalamanov | 3ea1d60 | 2020-12-16 19:59:39 +0100 | [diff] [blame] | 128 | DisplayModePtr mConfig25DifferentGroup = |
Marin Shalamanov | a7fe304 | 2021-01-29 21:02:08 +0100 | [diff] [blame] | 129 | createDisplayMode(HWC_CONFIG_ID_25, 1, Fps(25.0f).getPeriodNsecs()); |
| 130 | DisplayModePtr mConfig50 = createDisplayMode(HWC_CONFIG_ID_50, 0, Fps(50.0f).getPeriodNsecs()); |
Marin Shalamanov | 15a0fc6 | 2021-08-16 18:20:21 +0200 | [diff] [blame^] | 131 | DisplayModePtr mConfig24 = createDisplayMode(HWC_CONFIG_ID_24, 0, Fps(24.0f).getPeriodNsecs()); |
| 132 | DisplayModePtr mConfig24Frac = |
| 133 | createDisplayMode(HWC_CONFIG_ID_24_FRAC, 0, Fps(23.976f).getPeriodNsecs()); |
Ady Abraham | abc2760 | 2020-04-08 17:20:29 -0700 | [diff] [blame] | 134 | |
| 135 | // Test device configurations |
Marin Shalamanov | 4608442 | 2020-10-13 12:33:42 +0200 | [diff] [blame] | 136 | // The positions of the configs in the arrays below MUST match their IDs. For example, |
| 137 | // the first config should always be 60Hz, the second 90Hz etc. |
Marin Shalamanov | 3ea1d60 | 2020-12-16 19:59:39 +0100 | [diff] [blame] | 138 | DisplayModes m60OnlyConfigDevice = {mConfig60}; |
| 139 | DisplayModes m60_90Device = {mConfig60, mConfig90}; |
| 140 | DisplayModes m60_90DeviceWithDifferentGroups = {mConfig60, mConfig90DifferentGroup}; |
| 141 | DisplayModes m60_90DeviceWithDifferentResolutions = {mConfig60, mConfig90DifferentResolution}; |
| 142 | DisplayModes m60_72_90Device = {mConfig60, mConfig90, mConfig72}; |
| 143 | DisplayModes m60_90_72_120Device = {mConfig60, mConfig90, mConfig72, mConfig120}; |
| 144 | DisplayModes m30_60_72_90_120Device = {mConfig60, mConfig90, mConfig72, mConfig120, mConfig30}; |
| 145 | DisplayModes m30_60Device = {mConfig60, mConfig90DifferentGroup, mConfig72DifferentGroup, |
| 146 | mConfig120DifferentGroup, mConfig30}; |
| 147 | DisplayModes m30_60_72_90Device = {mConfig60, mConfig90, mConfig72, mConfig120DifferentGroup, |
| 148 | mConfig30}; |
| 149 | DisplayModes m30_60_90Device = {mConfig60, mConfig90, mConfig72DifferentGroup, |
| 150 | mConfig120DifferentGroup, mConfig30}; |
| 151 | DisplayModes m25_30_50_60Device = {mConfig60, |
| 152 | mConfig90, |
| 153 | mConfig72DifferentGroup, |
| 154 | mConfig120DifferentGroup, |
| 155 | mConfig30DifferentGroup, |
| 156 | mConfig25DifferentGroup, |
| 157 | mConfig50}; |
Ady Abraham | 5e4e983 | 2021-06-14 13:40:56 -0700 | [diff] [blame] | 158 | DisplayModes m60_120Device = {mConfig60, mConfig120}; |
Ady Abraham | abc2760 | 2020-04-08 17:20:29 -0700 | [diff] [blame] | 159 | |
Marin Shalamanov | 15a0fc6 | 2021-08-16 18:20:21 +0200 | [diff] [blame^] | 160 | // This is a typical TV configuration. |
| 161 | DisplayModes m24_25_30_50_60WithFracDevice = {mConfig24, mConfig24Frac, mConfig25, |
| 162 | mConfig30, mConfig30Frac, mConfig50, |
| 163 | mConfig60, mConfig60Frac}; |
| 164 | |
Ady Abraham | abc2760 | 2020-04-08 17:20:29 -0700 | [diff] [blame] | 165 | // Expected RefreshRate objects |
Ady Abraham | 6b7ad65 | 2021-06-23 17:34:57 -0700 | [diff] [blame] | 166 | RefreshRate mExpected60Config = {mConfig60, RefreshRate::ConstructorTag(0)}; |
| 167 | RefreshRate mExpectedAlmost60Config = {createDisplayMode(HWC_CONFIG_ID_60, 0, 16666665), |
| 168 | RefreshRate::ConstructorTag(0)}; |
| 169 | RefreshRate mExpected90Config = {mConfig90, RefreshRate::ConstructorTag(0)}; |
| 170 | RefreshRate mExpected90DifferentGroupConfig = {mConfig90DifferentGroup, |
| 171 | RefreshRate::ConstructorTag(0)}; |
| 172 | RefreshRate mExpected90DifferentResolutionConfig = {mConfig90DifferentResolution, |
Ady Abraham | abc2760 | 2020-04-08 17:20:29 -0700 | [diff] [blame] | 173 | RefreshRate::ConstructorTag(0)}; |
Ady Abraham | 6b7ad65 | 2021-06-23 17:34:57 -0700 | [diff] [blame] | 174 | RefreshRate mExpected72Config = {mConfig72, RefreshRate::ConstructorTag(0)}; |
| 175 | RefreshRate mExpected30Config = {mConfig30, RefreshRate::ConstructorTag(0)}; |
| 176 | RefreshRate mExpected120Config = {mConfig120, RefreshRate::ConstructorTag(0)}; |
rnlee | 3bd61066 | 2021-06-23 16:27:57 -0700 | [diff] [blame] | 177 | |
Ady Abraham | abc2760 | 2020-04-08 17:20:29 -0700 | [diff] [blame] | 178 | private: |
Marin Shalamanov | a7fe304 | 2021-01-29 21:02:08 +0100 | [diff] [blame] | 179 | DisplayModePtr createDisplayMode(DisplayModeId modeId, int32_t group, int64_t vsyncPeriod, |
| 180 | ui::Size resolution = ui::Size()); |
Alec Mouri | 0a1cc96 | 2019-03-14 12:33:02 -0700 | [diff] [blame] | 181 | }; |
| 182 | |
Marin Shalamanov | 3ea1d60 | 2020-12-16 19:59:39 +0100 | [diff] [blame] | 183 | using Builder = DisplayMode::Builder; |
Ady Abraham | abc2760 | 2020-04-08 17:20:29 -0700 | [diff] [blame] | 184 | |
Alec Mouri | 0a1cc96 | 2019-03-14 12:33:02 -0700 | [diff] [blame] | 185 | RefreshRateConfigsTest::RefreshRateConfigsTest() { |
| 186 | const ::testing::TestInfo* const test_info = |
| 187 | ::testing::UnitTest::GetInstance()->current_test_info(); |
| 188 | ALOGD("**** Setting up for %s.%s\n", test_info->test_case_name(), test_info->name()); |
| 189 | } |
| 190 | |
| 191 | RefreshRateConfigsTest::~RefreshRateConfigsTest() { |
| 192 | const ::testing::TestInfo* const test_info = |
| 193 | ::testing::UnitTest::GetInstance()->current_test_info(); |
| 194 | ALOGD("**** Tearing down after %s.%s\n", test_info->test_case_name(), test_info->name()); |
| 195 | } |
| 196 | |
Marin Shalamanov | a7fe304 | 2021-01-29 21:02:08 +0100 | [diff] [blame] | 197 | DisplayModePtr RefreshRateConfigsTest::createDisplayMode(DisplayModeId modeId, int32_t group, |
| 198 | int64_t vsyncPeriod, ui::Size resolution) { |
| 199 | return DisplayMode::Builder(hal::HWConfigId(modeId.value())) |
| 200 | .setId(modeId) |
Ady Abraham | 5e7ee86 | 2021-06-23 17:43:41 -0700 | [diff] [blame] | 201 | .setPhysicalDisplayId(PhysicalDisplayId::fromPort(0)) |
Ady Abraham | abc2760 | 2020-04-08 17:20:29 -0700 | [diff] [blame] | 202 | .setVsyncPeriod(int32_t(vsyncPeriod)) |
Marin Shalamanov | a7fe304 | 2021-01-29 21:02:08 +0100 | [diff] [blame] | 203 | .setGroup(group) |
Marin Shalamanov | 3ea1d60 | 2020-12-16 19:59:39 +0100 | [diff] [blame] | 204 | .setHeight(resolution.height) |
| 205 | .setWidth(resolution.width) |
Ady Abraham | abc2760 | 2020-04-08 17:20:29 -0700 | [diff] [blame] | 206 | .build(); |
| 207 | } |
| 208 | |
Alec Mouri | 0a1cc96 | 2019-03-14 12:33:02 -0700 | [diff] [blame] | 209 | namespace { |
| 210 | /* ------------------------------------------------------------------------ |
| 211 | * Test cases |
| 212 | */ |
Ady Abraham | 2139f73 | 2019-11-13 18:56:40 -0800 | [diff] [blame] | 213 | TEST_F(RefreshRateConfigsTest, oneDeviceConfig_SwitchingSupported) { |
Steven Thomas | 2bbaabe | 2019-08-28 16:08:35 -0700 | [diff] [blame] | 214 | auto refreshRateConfigs = |
Ady Abraham | abc2760 | 2020-04-08 17:20:29 -0700 | [diff] [blame] | 215 | std::make_unique<RefreshRateConfigs>(m60OnlyConfigDevice, |
| 216 | /*currentConfigId=*/HWC_CONFIG_ID_60); |
Alec Mouri | 0a1cc96 | 2019-03-14 12:33:02 -0700 | [diff] [blame] | 217 | } |
| 218 | |
Ana Krulec | ed3a8cc | 2019-11-14 00:55:07 +0100 | [diff] [blame] | 219 | TEST_F(RefreshRateConfigsTest, invalidPolicy) { |
Ana Krulec | ed3a8cc | 2019-11-14 00:55:07 +0100 | [diff] [blame] | 220 | auto refreshRateConfigs = |
Ady Abraham | abc2760 | 2020-04-08 17:20:29 -0700 | [diff] [blame] | 221 | std::make_unique<RefreshRateConfigs>(m60OnlyConfigDevice, |
| 222 | /*currentConfigId=*/HWC_CONFIG_ID_60); |
Marin Shalamanov | 23c4420 | 2020-12-22 19:09:20 +0100 | [diff] [blame] | 223 | ASSERT_LT(refreshRateConfigs->setDisplayManagerPolicy({DisplayModeId(10), {Fps(60), Fps(60)}}), |
Marin Shalamanov | e8a663d | 2020-11-24 17:48:00 +0100 | [diff] [blame] | 224 | 0); |
| 225 | ASSERT_LT(refreshRateConfigs->setDisplayManagerPolicy({HWC_CONFIG_ID_60, {Fps(20), Fps(40)}}), |
| 226 | 0); |
Ana Krulec | ed3a8cc | 2019-11-14 00:55:07 +0100 | [diff] [blame] | 227 | } |
| 228 | |
Steven Thomas | 2bbaabe | 2019-08-28 16:08:35 -0700 | [diff] [blame] | 229 | TEST_F(RefreshRateConfigsTest, twoDeviceConfigs_storesFullRefreshRateMap) { |
Steven Thomas | 2bbaabe | 2019-08-28 16:08:35 -0700 | [diff] [blame] | 230 | auto refreshRateConfigs = |
Ady Abraham | abc2760 | 2020-04-08 17:20:29 -0700 | [diff] [blame] | 231 | std::make_unique<RefreshRateConfigs>(m60_90Device, |
| 232 | /*currentConfigId=*/HWC_CONFIG_ID_60); |
Alec Mouri | 0a1cc96 | 2019-03-14 12:33:02 -0700 | [diff] [blame] | 233 | |
Marin Shalamanov | eadf2e7 | 2020-12-10 15:35:28 +0100 | [diff] [blame] | 234 | const auto& minRate = getMinSupportedRefreshRate(*refreshRateConfigs); |
| 235 | const auto& performanceRate = getMaxSupportedRefreshRate(*refreshRateConfigs); |
Alec Mouri | 0a1cc96 | 2019-03-14 12:33:02 -0700 | [diff] [blame] | 236 | |
Ady Abraham | abc2760 | 2020-04-08 17:20:29 -0700 | [diff] [blame] | 237 | ASSERT_EQ(mExpected60Config, minRate); |
| 238 | ASSERT_EQ(mExpected90Config, performanceRate); |
Ady Abraham | 2139f73 | 2019-11-13 18:56:40 -0800 | [diff] [blame] | 239 | |
Marin Shalamanov | eadf2e7 | 2020-12-10 15:35:28 +0100 | [diff] [blame] | 240 | const auto& minRateByPolicy = getMinRefreshRateByPolicy(*refreshRateConfigs); |
Ady Abraham | 2e1dd89 | 2020-03-05 13:48:36 -0800 | [diff] [blame] | 241 | const auto& performanceRateByPolicy = refreshRateConfigs->getMaxRefreshRateByPolicy(); |
Ady Abraham | 2139f73 | 2019-11-13 18:56:40 -0800 | [diff] [blame] | 242 | ASSERT_EQ(minRateByPolicy, minRate); |
| 243 | ASSERT_EQ(performanceRateByPolicy, performanceRate); |
Alec Mouri | 0a1cc96 | 2019-03-14 12:33:02 -0700 | [diff] [blame] | 244 | } |
Ady Abraham | 2139f73 | 2019-11-13 18:56:40 -0800 | [diff] [blame] | 245 | |
| 246 | TEST_F(RefreshRateConfigsTest, twoDeviceConfigs_storesFullRefreshRateMap_differentGroups) { |
Ady Abraham | 2139f73 | 2019-11-13 18:56:40 -0800 | [diff] [blame] | 247 | auto refreshRateConfigs = |
Ady Abraham | abc2760 | 2020-04-08 17:20:29 -0700 | [diff] [blame] | 248 | std::make_unique<RefreshRateConfigs>(m60_90DeviceWithDifferentGroups, |
| 249 | /*currentConfigId=*/HWC_CONFIG_ID_60); |
Ady Abraham | 2139f73 | 2019-11-13 18:56:40 -0800 | [diff] [blame] | 250 | |
Marin Shalamanov | eadf2e7 | 2020-12-10 15:35:28 +0100 | [diff] [blame] | 251 | const auto& minRate = getMinRefreshRateByPolicy(*refreshRateConfigs); |
| 252 | const auto& performanceRate = getMaxSupportedRefreshRate(*refreshRateConfigs); |
| 253 | const auto& minRate60 = getMinRefreshRateByPolicy(*refreshRateConfigs); |
Ady Abraham | 2e1dd89 | 2020-03-05 13:48:36 -0800 | [diff] [blame] | 254 | const auto& performanceRate60 = refreshRateConfigs->getMaxRefreshRateByPolicy(); |
Ady Abraham | 2139f73 | 2019-11-13 18:56:40 -0800 | [diff] [blame] | 255 | |
Ady Abraham | abc2760 | 2020-04-08 17:20:29 -0700 | [diff] [blame] | 256 | ASSERT_EQ(mExpected60Config, minRate); |
| 257 | ASSERT_EQ(mExpected60Config, minRate60); |
| 258 | ASSERT_EQ(mExpected60Config, performanceRate60); |
Ady Abraham | 2139f73 | 2019-11-13 18:56:40 -0800 | [diff] [blame] | 259 | |
Marin Shalamanov | e8a663d | 2020-11-24 17:48:00 +0100 | [diff] [blame] | 260 | ASSERT_GE(refreshRateConfigs->setDisplayManagerPolicy({HWC_CONFIG_ID_90, {Fps(60), Fps(90)}}), |
| 261 | 0); |
Marin Shalamanov | a7fe304 | 2021-01-29 21:02:08 +0100 | [diff] [blame] | 262 | refreshRateConfigs->setCurrentModeId(HWC_CONFIG_ID_90); |
Ady Abraham | 2139f73 | 2019-11-13 18:56:40 -0800 | [diff] [blame] | 263 | |
Marin Shalamanov | eadf2e7 | 2020-12-10 15:35:28 +0100 | [diff] [blame] | 264 | const auto& minRate90 = getMinRefreshRateByPolicy(*refreshRateConfigs); |
Ady Abraham | 2e1dd89 | 2020-03-05 13:48:36 -0800 | [diff] [blame] | 265 | const auto& performanceRate90 = refreshRateConfigs->getMaxRefreshRateByPolicy(); |
Ady Abraham | 2139f73 | 2019-11-13 18:56:40 -0800 | [diff] [blame] | 266 | |
Ady Abraham | abc2760 | 2020-04-08 17:20:29 -0700 | [diff] [blame] | 267 | ASSERT_EQ(mExpected90DifferentGroupConfig, performanceRate); |
| 268 | ASSERT_EQ(mExpected90DifferentGroupConfig, minRate90); |
| 269 | ASSERT_EQ(mExpected90DifferentGroupConfig, performanceRate90); |
| 270 | } |
| 271 | |
| 272 | TEST_F(RefreshRateConfigsTest, twoDeviceConfigs_storesFullRefreshRateMap_differentResolutions) { |
| 273 | auto refreshRateConfigs = |
| 274 | std::make_unique<RefreshRateConfigs>(m60_90DeviceWithDifferentResolutions, |
| 275 | /*currentConfigId=*/HWC_CONFIG_ID_60); |
| 276 | |
Marin Shalamanov | eadf2e7 | 2020-12-10 15:35:28 +0100 | [diff] [blame] | 277 | const auto& minRate = getMinRefreshRateByPolicy(*refreshRateConfigs); |
| 278 | const auto& performanceRate = getMaxSupportedRefreshRate(*refreshRateConfigs); |
| 279 | const auto& minRate60 = getMinRefreshRateByPolicy(*refreshRateConfigs); |
Ady Abraham | abc2760 | 2020-04-08 17:20:29 -0700 | [diff] [blame] | 280 | const auto& performanceRate60 = refreshRateConfigs->getMaxRefreshRateByPolicy(); |
| 281 | |
| 282 | ASSERT_EQ(mExpected60Config, minRate); |
| 283 | ASSERT_EQ(mExpected60Config, minRate60); |
| 284 | ASSERT_EQ(mExpected60Config, performanceRate60); |
| 285 | |
Marin Shalamanov | e8a663d | 2020-11-24 17:48:00 +0100 | [diff] [blame] | 286 | ASSERT_GE(refreshRateConfigs->setDisplayManagerPolicy({HWC_CONFIG_ID_90, {Fps(60), Fps(90)}}), |
| 287 | 0); |
Marin Shalamanov | a7fe304 | 2021-01-29 21:02:08 +0100 | [diff] [blame] | 288 | refreshRateConfigs->setCurrentModeId(HWC_CONFIG_ID_90); |
Ady Abraham | abc2760 | 2020-04-08 17:20:29 -0700 | [diff] [blame] | 289 | |
Marin Shalamanov | eadf2e7 | 2020-12-10 15:35:28 +0100 | [diff] [blame] | 290 | const auto& minRate90 = getMinRefreshRateByPolicy(*refreshRateConfigs); |
Ady Abraham | abc2760 | 2020-04-08 17:20:29 -0700 | [diff] [blame] | 291 | const auto& performanceRate90 = refreshRateConfigs->getMaxRefreshRateByPolicy(); |
| 292 | |
| 293 | ASSERT_EQ(mExpected90DifferentResolutionConfig, performanceRate); |
| 294 | ASSERT_EQ(mExpected90DifferentResolutionConfig, minRate90); |
| 295 | ASSERT_EQ(mExpected90DifferentResolutionConfig, performanceRate90); |
Ady Abraham | 2139f73 | 2019-11-13 18:56:40 -0800 | [diff] [blame] | 296 | } |
| 297 | |
| 298 | TEST_F(RefreshRateConfigsTest, twoDeviceConfigs_policyChange) { |
Ady Abraham | 2139f73 | 2019-11-13 18:56:40 -0800 | [diff] [blame] | 299 | auto refreshRateConfigs = |
Ady Abraham | abc2760 | 2020-04-08 17:20:29 -0700 | [diff] [blame] | 300 | std::make_unique<RefreshRateConfigs>(m60_90Device, |
| 301 | /*currentConfigId=*/HWC_CONFIG_ID_60); |
Ana Krulec | 3f6a206 | 2020-01-23 15:48:01 -0800 | [diff] [blame] | 302 | |
Marin Shalamanov | eadf2e7 | 2020-12-10 15:35:28 +0100 | [diff] [blame] | 303 | auto minRate = getMinRefreshRateByPolicy(*refreshRateConfigs); |
| 304 | auto performanceRate = refreshRateConfigs->getMaxRefreshRateByPolicy(); |
Ady Abraham | 2139f73 | 2019-11-13 18:56:40 -0800 | [diff] [blame] | 305 | |
Ady Abraham | abc2760 | 2020-04-08 17:20:29 -0700 | [diff] [blame] | 306 | ASSERT_EQ(mExpected60Config, minRate); |
| 307 | ASSERT_EQ(mExpected90Config, performanceRate); |
Ady Abraham | 2139f73 | 2019-11-13 18:56:40 -0800 | [diff] [blame] | 308 | |
Marin Shalamanov | e8a663d | 2020-11-24 17:48:00 +0100 | [diff] [blame] | 309 | ASSERT_GE(refreshRateConfigs->setDisplayManagerPolicy({HWC_CONFIG_ID_60, {Fps(60), Fps(60)}}), |
| 310 | 0); |
Ady Abraham | 2139f73 | 2019-11-13 18:56:40 -0800 | [diff] [blame] | 311 | |
Marin Shalamanov | eadf2e7 | 2020-12-10 15:35:28 +0100 | [diff] [blame] | 312 | auto minRate60 = getMinRefreshRateByPolicy(*refreshRateConfigs); |
| 313 | auto performanceRate60 = refreshRateConfigs->getMaxRefreshRateByPolicy(); |
Ady Abraham | abc2760 | 2020-04-08 17:20:29 -0700 | [diff] [blame] | 314 | ASSERT_EQ(mExpected60Config, minRate60); |
| 315 | ASSERT_EQ(mExpected60Config, performanceRate60); |
Ady Abraham | 2139f73 | 2019-11-13 18:56:40 -0800 | [diff] [blame] | 316 | } |
| 317 | |
| 318 | TEST_F(RefreshRateConfigsTest, twoDeviceConfigs_getCurrentRefreshRate) { |
Ady Abraham | 2139f73 | 2019-11-13 18:56:40 -0800 | [diff] [blame] | 319 | auto refreshRateConfigs = |
Ady Abraham | abc2760 | 2020-04-08 17:20:29 -0700 | [diff] [blame] | 320 | std::make_unique<RefreshRateConfigs>(m60_90Device, |
| 321 | /*currentConfigId=*/HWC_CONFIG_ID_60); |
Ady Abraham | 2139f73 | 2019-11-13 18:56:40 -0800 | [diff] [blame] | 322 | { |
Marin Shalamanov | eadf2e7 | 2020-12-10 15:35:28 +0100 | [diff] [blame] | 323 | auto current = refreshRateConfigs->getCurrentRefreshRate(); |
Marin Shalamanov | a7fe304 | 2021-01-29 21:02:08 +0100 | [diff] [blame] | 324 | EXPECT_EQ(current.getModeId(), HWC_CONFIG_ID_60); |
Ady Abraham | 2139f73 | 2019-11-13 18:56:40 -0800 | [diff] [blame] | 325 | } |
| 326 | |
Marin Shalamanov | a7fe304 | 2021-01-29 21:02:08 +0100 | [diff] [blame] | 327 | refreshRateConfigs->setCurrentModeId(HWC_CONFIG_ID_90); |
Ady Abraham | 2139f73 | 2019-11-13 18:56:40 -0800 | [diff] [blame] | 328 | { |
Marin Shalamanov | eadf2e7 | 2020-12-10 15:35:28 +0100 | [diff] [blame] | 329 | auto current = refreshRateConfigs->getCurrentRefreshRate(); |
Marin Shalamanov | a7fe304 | 2021-01-29 21:02:08 +0100 | [diff] [blame] | 330 | EXPECT_EQ(current.getModeId(), HWC_CONFIG_ID_90); |
Ady Abraham | 2139f73 | 2019-11-13 18:56:40 -0800 | [diff] [blame] | 331 | } |
| 332 | |
Marin Shalamanov | e8a663d | 2020-11-24 17:48:00 +0100 | [diff] [blame] | 333 | ASSERT_GE(refreshRateConfigs->setDisplayManagerPolicy({HWC_CONFIG_ID_90, {Fps(90), Fps(90)}}), |
| 334 | 0); |
Ady Abraham | 2139f73 | 2019-11-13 18:56:40 -0800 | [diff] [blame] | 335 | { |
Marin Shalamanov | eadf2e7 | 2020-12-10 15:35:28 +0100 | [diff] [blame] | 336 | auto current = refreshRateConfigs->getCurrentRefreshRate(); |
Marin Shalamanov | a7fe304 | 2021-01-29 21:02:08 +0100 | [diff] [blame] | 337 | EXPECT_EQ(current.getModeId(), HWC_CONFIG_ID_90); |
Ady Abraham | 2139f73 | 2019-11-13 18:56:40 -0800 | [diff] [blame] | 338 | } |
| 339 | } |
| 340 | |
Steven Thomas | bb37432 | 2020-04-28 22:47:16 -0700 | [diff] [blame] | 341 | TEST_F(RefreshRateConfigsTest, getBestRefreshRate_noLayers) { |
Ady Abraham | abc2760 | 2020-04-08 17:20:29 -0700 | [diff] [blame] | 342 | auto refreshRateConfigs = |
| 343 | std::make_unique<RefreshRateConfigs>(m60_72_90Device, /*currentConfigId=*/ |
| 344 | HWC_CONFIG_ID_72); |
Ana Krulec | 3d367c8 | 2020-02-25 15:02:01 -0800 | [diff] [blame] | 345 | |
Steven Thomas | debafed | 2020-05-18 17:30:35 -0700 | [diff] [blame] | 346 | // If there are no layers we select the default frame rate, which is the max of the primary |
| 347 | // range. |
Ana Krulec | 3d367c8 | 2020-02-25 15:02:01 -0800 | [diff] [blame] | 348 | auto layers = std::vector<LayerRequirement>{}; |
Steven Thomas | debafed | 2020-05-18 17:30:35 -0700 | [diff] [blame] | 349 | EXPECT_EQ(mExpected90Config, |
Ady Abraham | dfd6216 | 2020-06-10 16:11:56 -0700 | [diff] [blame] | 350 | refreshRateConfigs->getBestRefreshRate(layers, {.touch = false, .idle = false})); |
Ana Krulec | 3d367c8 | 2020-02-25 15:02:01 -0800 | [diff] [blame] | 351 | |
Marin Shalamanov | e8a663d | 2020-11-24 17:48:00 +0100 | [diff] [blame] | 352 | ASSERT_GE(refreshRateConfigs->setDisplayManagerPolicy({HWC_CONFIG_ID_60, {Fps(60), Fps(60)}}), |
| 353 | 0); |
Ady Abraham | abc2760 | 2020-04-08 17:20:29 -0700 | [diff] [blame] | 354 | EXPECT_EQ(mExpected60Config, |
Ady Abraham | dfd6216 | 2020-06-10 16:11:56 -0700 | [diff] [blame] | 355 | refreshRateConfigs->getBestRefreshRate(layers, {.touch = false, .idle = false})); |
Ana Krulec | 3d367c8 | 2020-02-25 15:02:01 -0800 | [diff] [blame] | 356 | } |
| 357 | |
Steven Thomas | bb37432 | 2020-04-28 22:47:16 -0700 | [diff] [blame] | 358 | TEST_F(RefreshRateConfigsTest, getBestRefreshRate_60_90) { |
Ady Abraham | 8a82ba6 | 2020-01-17 12:43:17 -0800 | [diff] [blame] | 359 | auto refreshRateConfigs = |
Ady Abraham | abc2760 | 2020-04-08 17:20:29 -0700 | [diff] [blame] | 360 | std::make_unique<RefreshRateConfigs>(m60_90Device, |
| 361 | /*currentConfigId=*/HWC_CONFIG_ID_60); |
Ady Abraham | 8a82ba6 | 2020-01-17 12:43:17 -0800 | [diff] [blame] | 362 | |
| 363 | auto layers = std::vector<LayerRequirement>{LayerRequirement{.weight = 1.0f}}; |
| 364 | auto& lr = layers[0]; |
| 365 | |
| 366 | lr.vote = LayerVoteType::Min; |
Ady Abraham | 4ccdcb4 | 2020-02-11 17:34:34 -0800 | [diff] [blame] | 367 | lr.name = "Min"; |
Ady Abraham | abc2760 | 2020-04-08 17:20:29 -0700 | [diff] [blame] | 368 | EXPECT_EQ(mExpected60Config, |
Ady Abraham | dfd6216 | 2020-06-10 16:11:56 -0700 | [diff] [blame] | 369 | refreshRateConfigs->getBestRefreshRate(layers, {.touch = false, .idle = false})); |
Ady Abraham | 8a82ba6 | 2020-01-17 12:43:17 -0800 | [diff] [blame] | 370 | |
| 371 | lr.vote = LayerVoteType::Max; |
Ady Abraham | 4ccdcb4 | 2020-02-11 17:34:34 -0800 | [diff] [blame] | 372 | lr.name = "Max"; |
Ady Abraham | abc2760 | 2020-04-08 17:20:29 -0700 | [diff] [blame] | 373 | EXPECT_EQ(mExpected90Config, |
Ady Abraham | dfd6216 | 2020-06-10 16:11:56 -0700 | [diff] [blame] | 374 | refreshRateConfigs->getBestRefreshRate(layers, {.touch = false, .idle = false})); |
Ady Abraham | 8a82ba6 | 2020-01-17 12:43:17 -0800 | [diff] [blame] | 375 | |
Marin Shalamanov | e8a663d | 2020-11-24 17:48:00 +0100 | [diff] [blame] | 376 | lr.desiredRefreshRate = Fps(90.0f); |
Ady Abraham | 8a82ba6 | 2020-01-17 12:43:17 -0800 | [diff] [blame] | 377 | lr.vote = LayerVoteType::Heuristic; |
Ady Abraham | 4ccdcb4 | 2020-02-11 17:34:34 -0800 | [diff] [blame] | 378 | lr.name = "90Hz Heuristic"; |
Ady Abraham | abc2760 | 2020-04-08 17:20:29 -0700 | [diff] [blame] | 379 | EXPECT_EQ(mExpected90Config, |
Ady Abraham | dfd6216 | 2020-06-10 16:11:56 -0700 | [diff] [blame] | 380 | refreshRateConfigs->getBestRefreshRate(layers, {.touch = false, .idle = false})); |
Ady Abraham | 8a82ba6 | 2020-01-17 12:43:17 -0800 | [diff] [blame] | 381 | |
Marin Shalamanov | e8a663d | 2020-11-24 17:48:00 +0100 | [diff] [blame] | 382 | lr.desiredRefreshRate = Fps(60.0f); |
Ady Abraham | 4ccdcb4 | 2020-02-11 17:34:34 -0800 | [diff] [blame] | 383 | lr.name = "60Hz Heuristic"; |
Ady Abraham | abc2760 | 2020-04-08 17:20:29 -0700 | [diff] [blame] | 384 | EXPECT_EQ(mExpected60Config, |
Ady Abraham | dfd6216 | 2020-06-10 16:11:56 -0700 | [diff] [blame] | 385 | refreshRateConfigs->getBestRefreshRate(layers, {.touch = false, .idle = false})); |
Ady Abraham | 8a82ba6 | 2020-01-17 12:43:17 -0800 | [diff] [blame] | 386 | |
Marin Shalamanov | e8a663d | 2020-11-24 17:48:00 +0100 | [diff] [blame] | 387 | lr.desiredRefreshRate = Fps(45.0f); |
Ady Abraham | 4ccdcb4 | 2020-02-11 17:34:34 -0800 | [diff] [blame] | 388 | lr.name = "45Hz Heuristic"; |
Ady Abraham | abc2760 | 2020-04-08 17:20:29 -0700 | [diff] [blame] | 389 | EXPECT_EQ(mExpected90Config, |
Ady Abraham | dfd6216 | 2020-06-10 16:11:56 -0700 | [diff] [blame] | 390 | refreshRateConfigs->getBestRefreshRate(layers, {.touch = false, .idle = false})); |
Ady Abraham | 8a82ba6 | 2020-01-17 12:43:17 -0800 | [diff] [blame] | 391 | |
Marin Shalamanov | e8a663d | 2020-11-24 17:48:00 +0100 | [diff] [blame] | 392 | lr.desiredRefreshRate = Fps(30.0f); |
Ady Abraham | 4ccdcb4 | 2020-02-11 17:34:34 -0800 | [diff] [blame] | 393 | lr.name = "30Hz Heuristic"; |
Ady Abraham | abc2760 | 2020-04-08 17:20:29 -0700 | [diff] [blame] | 394 | EXPECT_EQ(mExpected60Config, |
Ady Abraham | dfd6216 | 2020-06-10 16:11:56 -0700 | [diff] [blame] | 395 | refreshRateConfigs->getBestRefreshRate(layers, {.touch = false, .idle = false})); |
Ady Abraham | 8a82ba6 | 2020-01-17 12:43:17 -0800 | [diff] [blame] | 396 | |
Marin Shalamanov | e8a663d | 2020-11-24 17:48:00 +0100 | [diff] [blame] | 397 | lr.desiredRefreshRate = Fps(24.0f); |
Ady Abraham | 4ccdcb4 | 2020-02-11 17:34:34 -0800 | [diff] [blame] | 398 | lr.name = "24Hz Heuristic"; |
Ady Abraham | abc2760 | 2020-04-08 17:20:29 -0700 | [diff] [blame] | 399 | EXPECT_EQ(mExpected60Config, |
Ady Abraham | dfd6216 | 2020-06-10 16:11:56 -0700 | [diff] [blame] | 400 | refreshRateConfigs->getBestRefreshRate(layers, {.touch = false, .idle = false})); |
Ady Abraham | 8a82ba6 | 2020-01-17 12:43:17 -0800 | [diff] [blame] | 401 | |
Ady Abraham | 4ccdcb4 | 2020-02-11 17:34:34 -0800 | [diff] [blame] | 402 | lr.name = ""; |
Marin Shalamanov | e8a663d | 2020-11-24 17:48:00 +0100 | [diff] [blame] | 403 | ASSERT_GE(refreshRateConfigs->setDisplayManagerPolicy({HWC_CONFIG_ID_60, {Fps(60), Fps(60)}}), |
| 404 | 0); |
Ady Abraham | 8a82ba6 | 2020-01-17 12:43:17 -0800 | [diff] [blame] | 405 | |
| 406 | lr.vote = LayerVoteType::Min; |
Ady Abraham | abc2760 | 2020-04-08 17:20:29 -0700 | [diff] [blame] | 407 | EXPECT_EQ(mExpected60Config, |
Ady Abraham | dfd6216 | 2020-06-10 16:11:56 -0700 | [diff] [blame] | 408 | refreshRateConfigs->getBestRefreshRate(layers, {.touch = false, .idle = false})); |
Ady Abraham | 8a82ba6 | 2020-01-17 12:43:17 -0800 | [diff] [blame] | 409 | |
| 410 | lr.vote = LayerVoteType::Max; |
Ady Abraham | abc2760 | 2020-04-08 17:20:29 -0700 | [diff] [blame] | 411 | EXPECT_EQ(mExpected60Config, |
Ady Abraham | dfd6216 | 2020-06-10 16:11:56 -0700 | [diff] [blame] | 412 | refreshRateConfigs->getBestRefreshRate(layers, {.touch = false, .idle = false})); |
Ady Abraham | 8a82ba6 | 2020-01-17 12:43:17 -0800 | [diff] [blame] | 413 | |
Marin Shalamanov | e8a663d | 2020-11-24 17:48:00 +0100 | [diff] [blame] | 414 | lr.desiredRefreshRate = Fps(90.0f); |
Ady Abraham | 8a82ba6 | 2020-01-17 12:43:17 -0800 | [diff] [blame] | 415 | lr.vote = LayerVoteType::Heuristic; |
Ady Abraham | abc2760 | 2020-04-08 17:20:29 -0700 | [diff] [blame] | 416 | EXPECT_EQ(mExpected60Config, |
Ady Abraham | dfd6216 | 2020-06-10 16:11:56 -0700 | [diff] [blame] | 417 | refreshRateConfigs->getBestRefreshRate(layers, {.touch = false, .idle = false})); |
Ady Abraham | 8a82ba6 | 2020-01-17 12:43:17 -0800 | [diff] [blame] | 418 | |
Marin Shalamanov | e8a663d | 2020-11-24 17:48:00 +0100 | [diff] [blame] | 419 | lr.desiredRefreshRate = Fps(60.0f); |
Ady Abraham | abc2760 | 2020-04-08 17:20:29 -0700 | [diff] [blame] | 420 | EXPECT_EQ(mExpected60Config, |
Ady Abraham | dfd6216 | 2020-06-10 16:11:56 -0700 | [diff] [blame] | 421 | refreshRateConfigs->getBestRefreshRate(layers, {.touch = false, .idle = false})); |
Ady Abraham | 8a82ba6 | 2020-01-17 12:43:17 -0800 | [diff] [blame] | 422 | |
Marin Shalamanov | e8a663d | 2020-11-24 17:48:00 +0100 | [diff] [blame] | 423 | lr.desiredRefreshRate = Fps(45.0f); |
Ady Abraham | abc2760 | 2020-04-08 17:20:29 -0700 | [diff] [blame] | 424 | EXPECT_EQ(mExpected60Config, |
Ady Abraham | dfd6216 | 2020-06-10 16:11:56 -0700 | [diff] [blame] | 425 | refreshRateConfigs->getBestRefreshRate(layers, {.touch = false, .idle = false})); |
Ady Abraham | 8a82ba6 | 2020-01-17 12:43:17 -0800 | [diff] [blame] | 426 | |
Marin Shalamanov | e8a663d | 2020-11-24 17:48:00 +0100 | [diff] [blame] | 427 | lr.desiredRefreshRate = Fps(30.0f); |
Ady Abraham | abc2760 | 2020-04-08 17:20:29 -0700 | [diff] [blame] | 428 | EXPECT_EQ(mExpected60Config, |
Ady Abraham | dfd6216 | 2020-06-10 16:11:56 -0700 | [diff] [blame] | 429 | refreshRateConfigs->getBestRefreshRate(layers, {.touch = false, .idle = false})); |
Ady Abraham | 8a82ba6 | 2020-01-17 12:43:17 -0800 | [diff] [blame] | 430 | |
Marin Shalamanov | e8a663d | 2020-11-24 17:48:00 +0100 | [diff] [blame] | 431 | lr.desiredRefreshRate = Fps(24.0f); |
Ady Abraham | abc2760 | 2020-04-08 17:20:29 -0700 | [diff] [blame] | 432 | EXPECT_EQ(mExpected60Config, |
Ady Abraham | dfd6216 | 2020-06-10 16:11:56 -0700 | [diff] [blame] | 433 | refreshRateConfigs->getBestRefreshRate(layers, {.touch = false, .idle = false})); |
Ady Abraham | 8a82ba6 | 2020-01-17 12:43:17 -0800 | [diff] [blame] | 434 | |
Marin Shalamanov | e8a663d | 2020-11-24 17:48:00 +0100 | [diff] [blame] | 435 | ASSERT_GE(refreshRateConfigs->setDisplayManagerPolicy( |
| 436 | {HWC_CONFIG_ID_90, {Fps(90.0f), Fps(90.0f)}}), |
| 437 | 0); |
Ady Abraham | 8a82ba6 | 2020-01-17 12:43:17 -0800 | [diff] [blame] | 438 | |
| 439 | lr.vote = LayerVoteType::Min; |
Ady Abraham | abc2760 | 2020-04-08 17:20:29 -0700 | [diff] [blame] | 440 | EXPECT_EQ(mExpected90Config, |
Ady Abraham | dfd6216 | 2020-06-10 16:11:56 -0700 | [diff] [blame] | 441 | refreshRateConfigs->getBestRefreshRate(layers, {.touch = false, .idle = false})); |
Ady Abraham | 8a82ba6 | 2020-01-17 12:43:17 -0800 | [diff] [blame] | 442 | |
| 443 | lr.vote = LayerVoteType::Max; |
Ady Abraham | abc2760 | 2020-04-08 17:20:29 -0700 | [diff] [blame] | 444 | EXPECT_EQ(mExpected90Config, |
Ady Abraham | dfd6216 | 2020-06-10 16:11:56 -0700 | [diff] [blame] | 445 | refreshRateConfigs->getBestRefreshRate(layers, {.touch = false, .idle = false})); |
Ady Abraham | 8a82ba6 | 2020-01-17 12:43:17 -0800 | [diff] [blame] | 446 | |
Marin Shalamanov | e8a663d | 2020-11-24 17:48:00 +0100 | [diff] [blame] | 447 | lr.desiredRefreshRate = Fps(90.0f); |
Ady Abraham | 8a82ba6 | 2020-01-17 12:43:17 -0800 | [diff] [blame] | 448 | lr.vote = LayerVoteType::Heuristic; |
Ady Abraham | abc2760 | 2020-04-08 17:20:29 -0700 | [diff] [blame] | 449 | EXPECT_EQ(mExpected90Config, |
Ady Abraham | dfd6216 | 2020-06-10 16:11:56 -0700 | [diff] [blame] | 450 | refreshRateConfigs->getBestRefreshRate(layers, {.touch = false, .idle = false})); |
Ady Abraham | 8a82ba6 | 2020-01-17 12:43:17 -0800 | [diff] [blame] | 451 | |
Marin Shalamanov | e8a663d | 2020-11-24 17:48:00 +0100 | [diff] [blame] | 452 | lr.desiredRefreshRate = Fps(60.0f); |
Ady Abraham | abc2760 | 2020-04-08 17:20:29 -0700 | [diff] [blame] | 453 | EXPECT_EQ(mExpected90Config, |
Ady Abraham | dfd6216 | 2020-06-10 16:11:56 -0700 | [diff] [blame] | 454 | refreshRateConfigs->getBestRefreshRate(layers, {.touch = false, .idle = false})); |
Ady Abraham | 8a82ba6 | 2020-01-17 12:43:17 -0800 | [diff] [blame] | 455 | |
Marin Shalamanov | e8a663d | 2020-11-24 17:48:00 +0100 | [diff] [blame] | 456 | lr.desiredRefreshRate = Fps(45.0f); |
Ady Abraham | abc2760 | 2020-04-08 17:20:29 -0700 | [diff] [blame] | 457 | EXPECT_EQ(mExpected90Config, |
Ady Abraham | dfd6216 | 2020-06-10 16:11:56 -0700 | [diff] [blame] | 458 | refreshRateConfigs->getBestRefreshRate(layers, {.touch = false, .idle = false})); |
Ady Abraham | 8a82ba6 | 2020-01-17 12:43:17 -0800 | [diff] [blame] | 459 | |
Marin Shalamanov | e8a663d | 2020-11-24 17:48:00 +0100 | [diff] [blame] | 460 | lr.desiredRefreshRate = Fps(30.0f); |
Ady Abraham | abc2760 | 2020-04-08 17:20:29 -0700 | [diff] [blame] | 461 | EXPECT_EQ(mExpected90Config, |
Ady Abraham | dfd6216 | 2020-06-10 16:11:56 -0700 | [diff] [blame] | 462 | refreshRateConfigs->getBestRefreshRate(layers, {.touch = false, .idle = false})); |
Ady Abraham | 8a82ba6 | 2020-01-17 12:43:17 -0800 | [diff] [blame] | 463 | |
Marin Shalamanov | e8a663d | 2020-11-24 17:48:00 +0100 | [diff] [blame] | 464 | lr.desiredRefreshRate = Fps(24.0f); |
Ady Abraham | abc2760 | 2020-04-08 17:20:29 -0700 | [diff] [blame] | 465 | EXPECT_EQ(mExpected90Config, |
Ady Abraham | dfd6216 | 2020-06-10 16:11:56 -0700 | [diff] [blame] | 466 | refreshRateConfigs->getBestRefreshRate(layers, {.touch = false, .idle = false})); |
Ady Abraham | 8a82ba6 | 2020-01-17 12:43:17 -0800 | [diff] [blame] | 467 | |
Marin Shalamanov | e8a663d | 2020-11-24 17:48:00 +0100 | [diff] [blame] | 468 | ASSERT_GE(refreshRateConfigs->setDisplayManagerPolicy( |
| 469 | {HWC_CONFIG_ID_60, {Fps(0.0f), Fps(120.0f)}}), |
| 470 | 0); |
Ady Abraham | 8a82ba6 | 2020-01-17 12:43:17 -0800 | [diff] [blame] | 471 | lr.vote = LayerVoteType::Min; |
Ady Abraham | abc2760 | 2020-04-08 17:20:29 -0700 | [diff] [blame] | 472 | EXPECT_EQ(mExpected60Config, |
Ady Abraham | dfd6216 | 2020-06-10 16:11:56 -0700 | [diff] [blame] | 473 | refreshRateConfigs->getBestRefreshRate(layers, {.touch = false, .idle = false})); |
Ady Abraham | 8a82ba6 | 2020-01-17 12:43:17 -0800 | [diff] [blame] | 474 | |
| 475 | lr.vote = LayerVoteType::Max; |
Ady Abraham | abc2760 | 2020-04-08 17:20:29 -0700 | [diff] [blame] | 476 | EXPECT_EQ(mExpected90Config, |
Ady Abraham | dfd6216 | 2020-06-10 16:11:56 -0700 | [diff] [blame] | 477 | refreshRateConfigs->getBestRefreshRate(layers, {.touch = false, .idle = false})); |
Ady Abraham | 8a82ba6 | 2020-01-17 12:43:17 -0800 | [diff] [blame] | 478 | |
Marin Shalamanov | e8a663d | 2020-11-24 17:48:00 +0100 | [diff] [blame] | 479 | lr.desiredRefreshRate = Fps(90.0f); |
Ady Abraham | 8a82ba6 | 2020-01-17 12:43:17 -0800 | [diff] [blame] | 480 | lr.vote = LayerVoteType::Heuristic; |
Ady Abraham | abc2760 | 2020-04-08 17:20:29 -0700 | [diff] [blame] | 481 | EXPECT_EQ(mExpected90Config, |
Ady Abraham | dfd6216 | 2020-06-10 16:11:56 -0700 | [diff] [blame] | 482 | refreshRateConfigs->getBestRefreshRate(layers, {.touch = false, .idle = false})); |
Ady Abraham | 8a82ba6 | 2020-01-17 12:43:17 -0800 | [diff] [blame] | 483 | |
Marin Shalamanov | e8a663d | 2020-11-24 17:48:00 +0100 | [diff] [blame] | 484 | lr.desiredRefreshRate = Fps(60.0f); |
Ady Abraham | abc2760 | 2020-04-08 17:20:29 -0700 | [diff] [blame] | 485 | EXPECT_EQ(mExpected60Config, |
Ady Abraham | dfd6216 | 2020-06-10 16:11:56 -0700 | [diff] [blame] | 486 | refreshRateConfigs->getBestRefreshRate(layers, {.touch = false, .idle = false})); |
Ady Abraham | 8a82ba6 | 2020-01-17 12:43:17 -0800 | [diff] [blame] | 487 | |
Marin Shalamanov | e8a663d | 2020-11-24 17:48:00 +0100 | [diff] [blame] | 488 | lr.desiredRefreshRate = Fps(45.0f); |
Ady Abraham | abc2760 | 2020-04-08 17:20:29 -0700 | [diff] [blame] | 489 | EXPECT_EQ(mExpected90Config, |
Ady Abraham | dfd6216 | 2020-06-10 16:11:56 -0700 | [diff] [blame] | 490 | refreshRateConfigs->getBestRefreshRate(layers, {.touch = false, .idle = false})); |
Ady Abraham | 8a82ba6 | 2020-01-17 12:43:17 -0800 | [diff] [blame] | 491 | |
Marin Shalamanov | e8a663d | 2020-11-24 17:48:00 +0100 | [diff] [blame] | 492 | lr.desiredRefreshRate = Fps(30.0f); |
Ady Abraham | abc2760 | 2020-04-08 17:20:29 -0700 | [diff] [blame] | 493 | EXPECT_EQ(mExpected60Config, |
Ady Abraham | dfd6216 | 2020-06-10 16:11:56 -0700 | [diff] [blame] | 494 | refreshRateConfigs->getBestRefreshRate(layers, {.touch = false, .idle = false})); |
Ady Abraham | 8a82ba6 | 2020-01-17 12:43:17 -0800 | [diff] [blame] | 495 | |
Marin Shalamanov | e8a663d | 2020-11-24 17:48:00 +0100 | [diff] [blame] | 496 | lr.desiredRefreshRate = Fps(24.0f); |
Ady Abraham | abc2760 | 2020-04-08 17:20:29 -0700 | [diff] [blame] | 497 | EXPECT_EQ(mExpected60Config, |
Ady Abraham | dfd6216 | 2020-06-10 16:11:56 -0700 | [diff] [blame] | 498 | refreshRateConfigs->getBestRefreshRate(layers, {.touch = false, .idle = false})); |
Ady Abraham | 8a82ba6 | 2020-01-17 12:43:17 -0800 | [diff] [blame] | 499 | } |
| 500 | |
rnlee | 3bd61066 | 2021-06-23 16:27:57 -0700 | [diff] [blame] | 501 | TEST_F(RefreshRateConfigsTest, getBestRefreshRate_multipleThreshold_60_90) { |
| 502 | RefreshRateConfigs::Config config = {.frameRateMultipleThreshold = 90}; |
| 503 | auto refreshRateConfigs = |
| 504 | std::make_unique<RefreshRateConfigs>(m60_90Device, |
| 505 | /*currentConfigId=*/HWC_CONFIG_ID_60, config); |
| 506 | |
| 507 | auto layers = std::vector<LayerRequirement>{LayerRequirement{.weight = 1.0f}}; |
| 508 | auto& lr = layers[0]; |
| 509 | |
| 510 | lr.vote = LayerVoteType::Min; |
| 511 | lr.name = "Min"; |
| 512 | EXPECT_EQ(mExpected60Config, |
| 513 | refreshRateConfigs->getBestRefreshRate(layers, {.touch = false, .idle = false})); |
| 514 | |
| 515 | lr.vote = LayerVoteType::Max; |
| 516 | lr.name = "Max"; |
| 517 | EXPECT_EQ(mExpected90Config, |
| 518 | refreshRateConfigs->getBestRefreshRate(layers, {.touch = false, .idle = false})); |
| 519 | |
| 520 | lr.desiredRefreshRate = Fps(90.0f); |
| 521 | lr.vote = LayerVoteType::Heuristic; |
| 522 | lr.name = "90Hz Heuristic"; |
| 523 | EXPECT_EQ(mExpected90Config, |
| 524 | refreshRateConfigs->getBestRefreshRate(layers, {.touch = false, .idle = false})); |
| 525 | |
| 526 | lr.desiredRefreshRate = Fps(60.0f); |
| 527 | lr.name = "60Hz Heuristic"; |
| 528 | EXPECT_EQ(mExpected60Config, |
| 529 | refreshRateConfigs->getBestRefreshRate(layers, {.touch = false, .idle = false})); |
| 530 | |
| 531 | lr.desiredRefreshRate = Fps(45.0f); |
| 532 | lr.name = "45Hz Heuristic"; |
| 533 | EXPECT_EQ(mExpected90Config, |
| 534 | refreshRateConfigs->getBestRefreshRate(layers, {.touch = false, .idle = false})); |
| 535 | |
| 536 | lr.desiredRefreshRate = Fps(30.0f); |
| 537 | lr.name = "30Hz Heuristic"; |
| 538 | EXPECT_EQ(mExpected60Config, |
| 539 | refreshRateConfigs->getBestRefreshRate(layers, {.touch = false, .idle = false})); |
| 540 | |
| 541 | lr.desiredRefreshRate = Fps(24.0f); |
| 542 | lr.name = "24Hz Heuristic"; |
| 543 | EXPECT_EQ(mExpected60Config, |
| 544 | refreshRateConfigs->getBestRefreshRate(layers, {.touch = false, .idle = false})); |
| 545 | } |
| 546 | |
Steven Thomas | bb37432 | 2020-04-28 22:47:16 -0700 | [diff] [blame] | 547 | TEST_F(RefreshRateConfigsTest, getBestRefreshRate_60_72_90) { |
Ady Abraham | 8a82ba6 | 2020-01-17 12:43:17 -0800 | [diff] [blame] | 548 | auto refreshRateConfigs = |
Ady Abraham | abc2760 | 2020-04-08 17:20:29 -0700 | [diff] [blame] | 549 | std::make_unique<RefreshRateConfigs>(m60_72_90Device, |
| 550 | /*currentConfigId=*/HWC_CONFIG_ID_60); |
Ady Abraham | 8a82ba6 | 2020-01-17 12:43:17 -0800 | [diff] [blame] | 551 | |
| 552 | auto layers = std::vector<LayerRequirement>{LayerRequirement{.weight = 1.0f}}; |
| 553 | auto& lr = layers[0]; |
| 554 | |
| 555 | lr.vote = LayerVoteType::Min; |
Ady Abraham | abc2760 | 2020-04-08 17:20:29 -0700 | [diff] [blame] | 556 | EXPECT_EQ(mExpected60Config, |
Ady Abraham | dfd6216 | 2020-06-10 16:11:56 -0700 | [diff] [blame] | 557 | refreshRateConfigs->getBestRefreshRate(layers, {.touch = false, .idle = false})); |
Ady Abraham | 8a82ba6 | 2020-01-17 12:43:17 -0800 | [diff] [blame] | 558 | |
| 559 | lr.vote = LayerVoteType::Max; |
Ady Abraham | abc2760 | 2020-04-08 17:20:29 -0700 | [diff] [blame] | 560 | EXPECT_EQ(mExpected90Config, |
Ady Abraham | dfd6216 | 2020-06-10 16:11:56 -0700 | [diff] [blame] | 561 | refreshRateConfigs->getBestRefreshRate(layers, {.touch = false, .idle = false})); |
Ady Abraham | 8a82ba6 | 2020-01-17 12:43:17 -0800 | [diff] [blame] | 562 | |
Marin Shalamanov | e8a663d | 2020-11-24 17:48:00 +0100 | [diff] [blame] | 563 | lr.desiredRefreshRate = Fps(90.0f); |
Ady Abraham | 8a82ba6 | 2020-01-17 12:43:17 -0800 | [diff] [blame] | 564 | lr.vote = LayerVoteType::Heuristic; |
Ady Abraham | abc2760 | 2020-04-08 17:20:29 -0700 | [diff] [blame] | 565 | EXPECT_EQ(mExpected90Config, |
Ady Abraham | dfd6216 | 2020-06-10 16:11:56 -0700 | [diff] [blame] | 566 | refreshRateConfigs->getBestRefreshRate(layers, {.touch = false, .idle = false})); |
Ady Abraham | 8a82ba6 | 2020-01-17 12:43:17 -0800 | [diff] [blame] | 567 | |
Marin Shalamanov | e8a663d | 2020-11-24 17:48:00 +0100 | [diff] [blame] | 568 | lr.desiredRefreshRate = Fps(60.0f); |
Ady Abraham | abc2760 | 2020-04-08 17:20:29 -0700 | [diff] [blame] | 569 | EXPECT_EQ(mExpected60Config, |
Ady Abraham | dfd6216 | 2020-06-10 16:11:56 -0700 | [diff] [blame] | 570 | refreshRateConfigs->getBestRefreshRate(layers, {.touch = false, .idle = false})); |
Ady Abraham | 8a82ba6 | 2020-01-17 12:43:17 -0800 | [diff] [blame] | 571 | |
Marin Shalamanov | e8a663d | 2020-11-24 17:48:00 +0100 | [diff] [blame] | 572 | lr.desiredRefreshRate = Fps(45.0f); |
Ady Abraham | abc2760 | 2020-04-08 17:20:29 -0700 | [diff] [blame] | 573 | EXPECT_EQ(mExpected90Config, |
Ady Abraham | dfd6216 | 2020-06-10 16:11:56 -0700 | [diff] [blame] | 574 | refreshRateConfigs->getBestRefreshRate(layers, {.touch = false, .idle = false})); |
Ady Abraham | 8a82ba6 | 2020-01-17 12:43:17 -0800 | [diff] [blame] | 575 | |
Marin Shalamanov | e8a663d | 2020-11-24 17:48:00 +0100 | [diff] [blame] | 576 | lr.desiredRefreshRate = Fps(30.0f); |
Ady Abraham | abc2760 | 2020-04-08 17:20:29 -0700 | [diff] [blame] | 577 | EXPECT_EQ(mExpected60Config, |
Ady Abraham | dfd6216 | 2020-06-10 16:11:56 -0700 | [diff] [blame] | 578 | refreshRateConfigs->getBestRefreshRate(layers, {.touch = false, .idle = false})); |
Ady Abraham | 8a82ba6 | 2020-01-17 12:43:17 -0800 | [diff] [blame] | 579 | |
Marin Shalamanov | e8a663d | 2020-11-24 17:48:00 +0100 | [diff] [blame] | 580 | lr.desiredRefreshRate = Fps(24.0f); |
Ady Abraham | abc2760 | 2020-04-08 17:20:29 -0700 | [diff] [blame] | 581 | EXPECT_EQ(mExpected72Config, |
Ady Abraham | dfd6216 | 2020-06-10 16:11:56 -0700 | [diff] [blame] | 582 | refreshRateConfigs->getBestRefreshRate(layers, {.touch = false, .idle = false})); |
Ady Abraham | 8a82ba6 | 2020-01-17 12:43:17 -0800 | [diff] [blame] | 583 | } |
| 584 | |
Steven Thomas | bb37432 | 2020-04-28 22:47:16 -0700 | [diff] [blame] | 585 | TEST_F(RefreshRateConfigsTest, getBestRefreshRate_30_60_72_90_120) { |
Ady Abraham | 8a82ba6 | 2020-01-17 12:43:17 -0800 | [diff] [blame] | 586 | auto refreshRateConfigs = |
Ady Abraham | abc2760 | 2020-04-08 17:20:29 -0700 | [diff] [blame] | 587 | std::make_unique<RefreshRateConfigs>(m30_60_72_90_120Device, |
| 588 | /*currentConfigId=*/HWC_CONFIG_ID_60); |
Ady Abraham | 8a82ba6 | 2020-01-17 12:43:17 -0800 | [diff] [blame] | 589 | |
| 590 | auto layers = std::vector<LayerRequirement>{LayerRequirement{.weight = 1.0f}, |
| 591 | LayerRequirement{.weight = 1.0f}}; |
| 592 | auto& lr1 = layers[0]; |
| 593 | auto& lr2 = layers[1]; |
| 594 | |
Marin Shalamanov | e8a663d | 2020-11-24 17:48:00 +0100 | [diff] [blame] | 595 | lr1.desiredRefreshRate = Fps(24.0f); |
Ady Abraham | 8a82ba6 | 2020-01-17 12:43:17 -0800 | [diff] [blame] | 596 | lr1.vote = LayerVoteType::Heuristic; |
Marin Shalamanov | e8a663d | 2020-11-24 17:48:00 +0100 | [diff] [blame] | 597 | lr2.desiredRefreshRate = Fps(60.0f); |
Ady Abraham | 8a82ba6 | 2020-01-17 12:43:17 -0800 | [diff] [blame] | 598 | lr2.vote = LayerVoteType::Heuristic; |
Ady Abraham | abc2760 | 2020-04-08 17:20:29 -0700 | [diff] [blame] | 599 | EXPECT_EQ(mExpected120Config, |
Ady Abraham | dfd6216 | 2020-06-10 16:11:56 -0700 | [diff] [blame] | 600 | refreshRateConfigs->getBestRefreshRate(layers, {.touch = false, .idle = false})); |
Ady Abraham | 8a82ba6 | 2020-01-17 12:43:17 -0800 | [diff] [blame] | 601 | |
Marin Shalamanov | e8a663d | 2020-11-24 17:48:00 +0100 | [diff] [blame] | 602 | lr1.desiredRefreshRate = Fps(24.0f); |
Ady Abraham | 8a82ba6 | 2020-01-17 12:43:17 -0800 | [diff] [blame] | 603 | lr1.vote = LayerVoteType::Heuristic; |
Marin Shalamanov | e8a663d | 2020-11-24 17:48:00 +0100 | [diff] [blame] | 604 | lr2.desiredRefreshRate = Fps(48.0f); |
Ady Abraham | 8a82ba6 | 2020-01-17 12:43:17 -0800 | [diff] [blame] | 605 | lr2.vote = LayerVoteType::Heuristic; |
Ady Abraham | abc2760 | 2020-04-08 17:20:29 -0700 | [diff] [blame] | 606 | EXPECT_EQ(mExpected72Config, |
Ady Abraham | dfd6216 | 2020-06-10 16:11:56 -0700 | [diff] [blame] | 607 | refreshRateConfigs->getBestRefreshRate(layers, {.touch = false, .idle = false})); |
Ady Abraham | 8a82ba6 | 2020-01-17 12:43:17 -0800 | [diff] [blame] | 608 | |
Marin Shalamanov | e8a663d | 2020-11-24 17:48:00 +0100 | [diff] [blame] | 609 | lr1.desiredRefreshRate = Fps(24.0f); |
Ady Abraham | 8a82ba6 | 2020-01-17 12:43:17 -0800 | [diff] [blame] | 610 | lr1.vote = LayerVoteType::Heuristic; |
Marin Shalamanov | e8a663d | 2020-11-24 17:48:00 +0100 | [diff] [blame] | 611 | lr2.desiredRefreshRate = Fps(48.0f); |
Ady Abraham | 8a82ba6 | 2020-01-17 12:43:17 -0800 | [diff] [blame] | 612 | lr2.vote = LayerVoteType::Heuristic; |
Ady Abraham | abc2760 | 2020-04-08 17:20:29 -0700 | [diff] [blame] | 613 | EXPECT_EQ(mExpected72Config, |
Ady Abraham | dfd6216 | 2020-06-10 16:11:56 -0700 | [diff] [blame] | 614 | refreshRateConfigs->getBestRefreshRate(layers, {.touch = false, .idle = false})); |
Ady Abraham | 8a82ba6 | 2020-01-17 12:43:17 -0800 | [diff] [blame] | 615 | } |
| 616 | |
Steven Thomas | bb37432 | 2020-04-28 22:47:16 -0700 | [diff] [blame] | 617 | TEST_F(RefreshRateConfigsTest, getBestRefreshRate_30_60_90_120_DifferentTypes) { |
Ady Abraham | 71c437d | 2020-01-31 15:56:57 -0800 | [diff] [blame] | 618 | auto refreshRateConfigs = |
Ady Abraham | abc2760 | 2020-04-08 17:20:29 -0700 | [diff] [blame] | 619 | std::make_unique<RefreshRateConfigs>(m30_60_72_90_120Device, |
| 620 | /*currentConfigId=*/HWC_CONFIG_ID_60); |
Ady Abraham | 71c437d | 2020-01-31 15:56:57 -0800 | [diff] [blame] | 621 | |
| 622 | auto layers = std::vector<LayerRequirement>{LayerRequirement{.weight = 1.0f}, |
| 623 | LayerRequirement{.weight = 1.0f}}; |
| 624 | auto& lr1 = layers[0]; |
| 625 | auto& lr2 = layers[1]; |
| 626 | |
Marin Shalamanov | e8a663d | 2020-11-24 17:48:00 +0100 | [diff] [blame] | 627 | lr1.desiredRefreshRate = Fps(24.0f); |
Ady Abraham | 71c437d | 2020-01-31 15:56:57 -0800 | [diff] [blame] | 628 | lr1.vote = LayerVoteType::ExplicitDefault; |
Ady Abraham | 4ccdcb4 | 2020-02-11 17:34:34 -0800 | [diff] [blame] | 629 | lr1.name = "24Hz ExplicitDefault"; |
Marin Shalamanov | e8a663d | 2020-11-24 17:48:00 +0100 | [diff] [blame] | 630 | lr2.desiredRefreshRate = Fps(60.0f); |
Ady Abraham | 71c437d | 2020-01-31 15:56:57 -0800 | [diff] [blame] | 631 | lr2.vote = LayerVoteType::Heuristic; |
Ady Abraham | 4ccdcb4 | 2020-02-11 17:34:34 -0800 | [diff] [blame] | 632 | lr2.name = "60Hz Heuristic"; |
Ady Abraham | abc2760 | 2020-04-08 17:20:29 -0700 | [diff] [blame] | 633 | EXPECT_EQ(mExpected120Config, |
Ady Abraham | dfd6216 | 2020-06-10 16:11:56 -0700 | [diff] [blame] | 634 | refreshRateConfigs->getBestRefreshRate(layers, {.touch = false, .idle = false})); |
Ady Abraham | 71c437d | 2020-01-31 15:56:57 -0800 | [diff] [blame] | 635 | |
Marin Shalamanov | e8a663d | 2020-11-24 17:48:00 +0100 | [diff] [blame] | 636 | lr1.desiredRefreshRate = Fps(24.0f); |
Ady Abraham | 71c437d | 2020-01-31 15:56:57 -0800 | [diff] [blame] | 637 | lr1.vote = LayerVoteType::ExplicitExactOrMultiple; |
Ady Abraham | 4ccdcb4 | 2020-02-11 17:34:34 -0800 | [diff] [blame] | 638 | lr1.name = "24Hz ExplicitExactOrMultiple"; |
Marin Shalamanov | e8a663d | 2020-11-24 17:48:00 +0100 | [diff] [blame] | 639 | lr2.desiredRefreshRate = Fps(60.0f); |
Ady Abraham | 71c437d | 2020-01-31 15:56:57 -0800 | [diff] [blame] | 640 | lr2.vote = LayerVoteType::Heuristic; |
Ady Abraham | 4ccdcb4 | 2020-02-11 17:34:34 -0800 | [diff] [blame] | 641 | lr2.name = "60Hz Heuristic"; |
Ady Abraham | abc2760 | 2020-04-08 17:20:29 -0700 | [diff] [blame] | 642 | EXPECT_EQ(mExpected120Config, |
Ady Abraham | dfd6216 | 2020-06-10 16:11:56 -0700 | [diff] [blame] | 643 | refreshRateConfigs->getBestRefreshRate(layers, {.touch = false, .idle = false})); |
Ady Abraham | 71c437d | 2020-01-31 15:56:57 -0800 | [diff] [blame] | 644 | |
Marin Shalamanov | e8a663d | 2020-11-24 17:48:00 +0100 | [diff] [blame] | 645 | lr1.desiredRefreshRate = Fps(24.0f); |
Ady Abraham | 71c437d | 2020-01-31 15:56:57 -0800 | [diff] [blame] | 646 | lr1.vote = LayerVoteType::ExplicitExactOrMultiple; |
Ady Abraham | 4ccdcb4 | 2020-02-11 17:34:34 -0800 | [diff] [blame] | 647 | lr1.name = "24Hz ExplicitExactOrMultiple"; |
Marin Shalamanov | e8a663d | 2020-11-24 17:48:00 +0100 | [diff] [blame] | 648 | lr2.desiredRefreshRate = Fps(60.0f); |
Ady Abraham | 71c437d | 2020-01-31 15:56:57 -0800 | [diff] [blame] | 649 | lr2.vote = LayerVoteType::ExplicitDefault; |
Ady Abraham | 4ccdcb4 | 2020-02-11 17:34:34 -0800 | [diff] [blame] | 650 | lr2.name = "60Hz ExplicitDefault"; |
Ady Abraham | abc2760 | 2020-04-08 17:20:29 -0700 | [diff] [blame] | 651 | EXPECT_EQ(mExpected120Config, |
Ady Abraham | dfd6216 | 2020-06-10 16:11:56 -0700 | [diff] [blame] | 652 | refreshRateConfigs->getBestRefreshRate(layers, {.touch = false, .idle = false})); |
Ady Abraham | 71c437d | 2020-01-31 15:56:57 -0800 | [diff] [blame] | 653 | |
Marin Shalamanov | e8a663d | 2020-11-24 17:48:00 +0100 | [diff] [blame] | 654 | lr1.desiredRefreshRate = Fps(24.0f); |
Ady Abraham | 71c437d | 2020-01-31 15:56:57 -0800 | [diff] [blame] | 655 | lr1.vote = LayerVoteType::ExplicitExactOrMultiple; |
Ady Abraham | 4ccdcb4 | 2020-02-11 17:34:34 -0800 | [diff] [blame] | 656 | lr1.name = "24Hz ExplicitExactOrMultiple"; |
Marin Shalamanov | e8a663d | 2020-11-24 17:48:00 +0100 | [diff] [blame] | 657 | lr2.desiredRefreshRate = Fps(90.0f); |
Ady Abraham | 71c437d | 2020-01-31 15:56:57 -0800 | [diff] [blame] | 658 | lr2.vote = LayerVoteType::Heuristic; |
Ady Abraham | 4ccdcb4 | 2020-02-11 17:34:34 -0800 | [diff] [blame] | 659 | lr2.name = "90Hz Heuristic"; |
Ady Abraham | abc2760 | 2020-04-08 17:20:29 -0700 | [diff] [blame] | 660 | EXPECT_EQ(mExpected90Config, |
Ady Abraham | dfd6216 | 2020-06-10 16:11:56 -0700 | [diff] [blame] | 661 | refreshRateConfigs->getBestRefreshRate(layers, {.touch = false, .idle = false})); |
Ady Abraham | 4ccdcb4 | 2020-02-11 17:34:34 -0800 | [diff] [blame] | 662 | |
Marin Shalamanov | e8a663d | 2020-11-24 17:48:00 +0100 | [diff] [blame] | 663 | lr1.desiredRefreshRate = Fps(24.0f); |
Ady Abraham | 4ccdcb4 | 2020-02-11 17:34:34 -0800 | [diff] [blame] | 664 | lr1.vote = LayerVoteType::ExplicitExactOrMultiple; |
| 665 | lr1.name = "24Hz ExplicitExactOrMultiple"; |
Marin Shalamanov | e8a663d | 2020-11-24 17:48:00 +0100 | [diff] [blame] | 666 | lr2.desiredRefreshRate = Fps(90.0f); |
Ady Abraham | 4ccdcb4 | 2020-02-11 17:34:34 -0800 | [diff] [blame] | 667 | lr2.vote = LayerVoteType::ExplicitDefault; |
| 668 | lr2.name = "90Hz Heuristic"; |
Ady Abraham | abc2760 | 2020-04-08 17:20:29 -0700 | [diff] [blame] | 669 | EXPECT_EQ(mExpected72Config, |
Ady Abraham | dfd6216 | 2020-06-10 16:11:56 -0700 | [diff] [blame] | 670 | refreshRateConfigs->getBestRefreshRate(layers, {.touch = false, .idle = false})); |
Ady Abraham | 71c437d | 2020-01-31 15:56:57 -0800 | [diff] [blame] | 671 | |
Marin Shalamanov | e8a663d | 2020-11-24 17:48:00 +0100 | [diff] [blame] | 672 | lr1.desiredRefreshRate = Fps(24.0f); |
Ady Abraham | 71c437d | 2020-01-31 15:56:57 -0800 | [diff] [blame] | 673 | lr1.vote = LayerVoteType::ExplicitDefault; |
Ady Abraham | 4ccdcb4 | 2020-02-11 17:34:34 -0800 | [diff] [blame] | 674 | lr1.name = "24Hz ExplicitDefault"; |
Marin Shalamanov | e8a663d | 2020-11-24 17:48:00 +0100 | [diff] [blame] | 675 | lr2.desiredRefreshRate = Fps(90.0f); |
Ady Abraham | 71c437d | 2020-01-31 15:56:57 -0800 | [diff] [blame] | 676 | lr2.vote = LayerVoteType::Heuristic; |
Ady Abraham | 4ccdcb4 | 2020-02-11 17:34:34 -0800 | [diff] [blame] | 677 | lr2.name = "90Hz Heuristic"; |
Ady Abraham | abc2760 | 2020-04-08 17:20:29 -0700 | [diff] [blame] | 678 | EXPECT_EQ(mExpected90Config, |
Ady Abraham | dfd6216 | 2020-06-10 16:11:56 -0700 | [diff] [blame] | 679 | refreshRateConfigs->getBestRefreshRate(layers, {.touch = false, .idle = false})); |
Ady Abraham | 71c437d | 2020-01-31 15:56:57 -0800 | [diff] [blame] | 680 | |
Marin Shalamanov | e8a663d | 2020-11-24 17:48:00 +0100 | [diff] [blame] | 681 | lr1.desiredRefreshRate = Fps(24.0f); |
Ady Abraham | 71c437d | 2020-01-31 15:56:57 -0800 | [diff] [blame] | 682 | lr1.vote = LayerVoteType::Heuristic; |
Ady Abraham | 4ccdcb4 | 2020-02-11 17:34:34 -0800 | [diff] [blame] | 683 | lr1.name = "24Hz Heuristic"; |
Marin Shalamanov | e8a663d | 2020-11-24 17:48:00 +0100 | [diff] [blame] | 684 | lr2.desiredRefreshRate = Fps(90.0f); |
Ady Abraham | 71c437d | 2020-01-31 15:56:57 -0800 | [diff] [blame] | 685 | lr2.vote = LayerVoteType::ExplicitDefault; |
Ady Abraham | 4ccdcb4 | 2020-02-11 17:34:34 -0800 | [diff] [blame] | 686 | lr2.name = "90Hz ExplicitDefault"; |
Ady Abraham | abc2760 | 2020-04-08 17:20:29 -0700 | [diff] [blame] | 687 | EXPECT_EQ(mExpected72Config, |
Ady Abraham | dfd6216 | 2020-06-10 16:11:56 -0700 | [diff] [blame] | 688 | refreshRateConfigs->getBestRefreshRate(layers, {.touch = false, .idle = false})); |
Ady Abraham | 71c437d | 2020-01-31 15:56:57 -0800 | [diff] [blame] | 689 | |
Marin Shalamanov | e8a663d | 2020-11-24 17:48:00 +0100 | [diff] [blame] | 690 | lr1.desiredRefreshRate = Fps(24.0f); |
Ady Abraham | 71c437d | 2020-01-31 15:56:57 -0800 | [diff] [blame] | 691 | lr1.vote = LayerVoteType::ExplicitExactOrMultiple; |
Ady Abraham | 4ccdcb4 | 2020-02-11 17:34:34 -0800 | [diff] [blame] | 692 | lr1.name = "24Hz ExplicitExactOrMultiple"; |
Marin Shalamanov | e8a663d | 2020-11-24 17:48:00 +0100 | [diff] [blame] | 693 | lr2.desiredRefreshRate = Fps(90.0f); |
Ady Abraham | 71c437d | 2020-01-31 15:56:57 -0800 | [diff] [blame] | 694 | lr2.vote = LayerVoteType::ExplicitDefault; |
Ady Abraham | 4ccdcb4 | 2020-02-11 17:34:34 -0800 | [diff] [blame] | 695 | lr2.name = "90Hz ExplicitDefault"; |
Ady Abraham | abc2760 | 2020-04-08 17:20:29 -0700 | [diff] [blame] | 696 | EXPECT_EQ(mExpected72Config, |
Ady Abraham | dfd6216 | 2020-06-10 16:11:56 -0700 | [diff] [blame] | 697 | refreshRateConfigs->getBestRefreshRate(layers, {.touch = false, .idle = false})); |
Ady Abraham | 71c437d | 2020-01-31 15:56:57 -0800 | [diff] [blame] | 698 | |
Marin Shalamanov | e8a663d | 2020-11-24 17:48:00 +0100 | [diff] [blame] | 699 | lr1.desiredRefreshRate = Fps(24.0f); |
Ady Abraham | 71c437d | 2020-01-31 15:56:57 -0800 | [diff] [blame] | 700 | lr1.vote = LayerVoteType::ExplicitDefault; |
Ady Abraham | 4ccdcb4 | 2020-02-11 17:34:34 -0800 | [diff] [blame] | 701 | lr1.name = "24Hz ExplicitDefault"; |
Marin Shalamanov | e8a663d | 2020-11-24 17:48:00 +0100 | [diff] [blame] | 702 | lr2.desiredRefreshRate = Fps(90.0f); |
Ady Abraham | 71c437d | 2020-01-31 15:56:57 -0800 | [diff] [blame] | 703 | lr2.vote = LayerVoteType::ExplicitExactOrMultiple; |
Ady Abraham | 4ccdcb4 | 2020-02-11 17:34:34 -0800 | [diff] [blame] | 704 | lr2.name = "90Hz ExplicitExactOrMultiple"; |
Ady Abraham | abc2760 | 2020-04-08 17:20:29 -0700 | [diff] [blame] | 705 | EXPECT_EQ(mExpected90Config, |
Ady Abraham | dfd6216 | 2020-06-10 16:11:56 -0700 | [diff] [blame] | 706 | refreshRateConfigs->getBestRefreshRate(layers, {.touch = false, .idle = false})); |
Ady Abraham | 71c437d | 2020-01-31 15:56:57 -0800 | [diff] [blame] | 707 | } |
| 708 | |
rnlee | 3bd61066 | 2021-06-23 16:27:57 -0700 | [diff] [blame] | 709 | TEST_F(RefreshRateConfigsTest, getBestRefreshRate_30_60_90_120_DifferentTypes_multipleThreshold) { |
| 710 | RefreshRateConfigs::Config config = {.frameRateMultipleThreshold = 120}; |
| 711 | auto refreshRateConfigs = |
| 712 | std::make_unique<RefreshRateConfigs>(m30_60_72_90_120Device, |
| 713 | /*currentConfigId=*/HWC_CONFIG_ID_60, config); |
| 714 | |
| 715 | auto layers = std::vector<LayerRequirement>{LayerRequirement{.weight = 1.0f}, |
| 716 | LayerRequirement{.weight = 1.0f}}; |
| 717 | auto& lr1 = layers[0]; |
| 718 | auto& lr2 = layers[1]; |
| 719 | |
| 720 | lr1.desiredRefreshRate = Fps(24.0f); |
| 721 | lr1.vote = LayerVoteType::ExplicitDefault; |
| 722 | lr1.name = "24Hz ExplicitDefault"; |
| 723 | lr2.desiredRefreshRate = Fps(60.0f); |
| 724 | lr2.vote = LayerVoteType::Heuristic; |
| 725 | lr2.name = "60Hz Heuristic"; |
| 726 | EXPECT_EQ(mExpected120Config, |
| 727 | refreshRateConfigs->getBestRefreshRate(layers, {.touch = false, .idle = false})); |
| 728 | |
| 729 | lr1.desiredRefreshRate = Fps(24.0f); |
| 730 | lr1.vote = LayerVoteType::ExplicitExactOrMultiple; |
| 731 | lr1.name = "24Hz ExplicitExactOrMultiple"; |
| 732 | lr2.desiredRefreshRate = Fps(60.0f); |
| 733 | lr2.vote = LayerVoteType::Heuristic; |
| 734 | lr2.name = "60Hz Heuristic"; |
| 735 | EXPECT_EQ(mExpected60Config, |
| 736 | refreshRateConfigs->getBestRefreshRate(layers, {.touch = false, .idle = false})); |
| 737 | |
| 738 | lr1.desiredRefreshRate = Fps(24.0f); |
| 739 | lr1.vote = LayerVoteType::ExplicitExactOrMultiple; |
| 740 | lr1.name = "24Hz ExplicitExactOrMultiple"; |
| 741 | lr2.desiredRefreshRate = Fps(60.0f); |
| 742 | lr2.vote = LayerVoteType::ExplicitDefault; |
| 743 | lr2.name = "60Hz ExplicitDefault"; |
| 744 | EXPECT_EQ(mExpected72Config, |
| 745 | refreshRateConfigs->getBestRefreshRate(layers, {.touch = false, .idle = false})); |
| 746 | |
| 747 | lr1.desiredRefreshRate = Fps(24.0f); |
| 748 | lr1.vote = LayerVoteType::ExplicitExactOrMultiple; |
| 749 | lr1.name = "24Hz ExplicitExactOrMultiple"; |
| 750 | lr2.desiredRefreshRate = Fps(90.0f); |
| 751 | lr2.vote = LayerVoteType::Heuristic; |
| 752 | lr2.name = "90Hz Heuristic"; |
| 753 | EXPECT_EQ(mExpected90Config, |
| 754 | refreshRateConfigs->getBestRefreshRate(layers, {.touch = false, .idle = false})); |
| 755 | |
| 756 | lr1.desiredRefreshRate = Fps(24.0f); |
| 757 | lr1.vote = LayerVoteType::ExplicitExactOrMultiple; |
| 758 | lr1.name = "24Hz ExplicitExactOrMultiple"; |
| 759 | lr2.desiredRefreshRate = Fps(90.0f); |
| 760 | lr2.vote = LayerVoteType::ExplicitDefault; |
| 761 | lr2.name = "90Hz Heuristic"; |
| 762 | EXPECT_EQ(mExpected72Config, |
| 763 | refreshRateConfigs->getBestRefreshRate(layers, {.touch = false, .idle = false})); |
| 764 | |
| 765 | lr1.desiredRefreshRate = Fps(24.0f); |
| 766 | lr1.vote = LayerVoteType::ExplicitDefault; |
| 767 | lr1.name = "24Hz ExplicitDefault"; |
| 768 | lr2.desiredRefreshRate = Fps(90.0f); |
| 769 | lr2.vote = LayerVoteType::Heuristic; |
| 770 | lr2.name = "90Hz Heuristic"; |
| 771 | EXPECT_EQ(mExpected90Config, |
| 772 | refreshRateConfigs->getBestRefreshRate(layers, {.touch = false, .idle = false})); |
| 773 | |
| 774 | lr1.desiredRefreshRate = Fps(24.0f); |
| 775 | lr1.vote = LayerVoteType::Heuristic; |
| 776 | lr1.name = "24Hz Heuristic"; |
| 777 | lr2.desiredRefreshRate = Fps(90.0f); |
| 778 | lr2.vote = LayerVoteType::ExplicitDefault; |
| 779 | lr2.name = "90Hz ExplicitDefault"; |
| 780 | EXPECT_EQ(mExpected72Config, |
| 781 | refreshRateConfigs->getBestRefreshRate(layers, {.touch = false, .idle = false})); |
| 782 | |
| 783 | lr1.desiredRefreshRate = Fps(24.0f); |
| 784 | lr1.vote = LayerVoteType::ExplicitExactOrMultiple; |
| 785 | lr1.name = "24Hz ExplicitExactOrMultiple"; |
| 786 | lr2.desiredRefreshRate = Fps(90.0f); |
| 787 | lr2.vote = LayerVoteType::ExplicitDefault; |
| 788 | lr2.name = "90Hz ExplicitDefault"; |
| 789 | EXPECT_EQ(mExpected72Config, |
| 790 | refreshRateConfigs->getBestRefreshRate(layers, {.touch = false, .idle = false})); |
| 791 | |
| 792 | lr1.desiredRefreshRate = Fps(24.0f); |
| 793 | lr1.vote = LayerVoteType::ExplicitDefault; |
| 794 | lr1.name = "24Hz ExplicitDefault"; |
| 795 | lr2.desiredRefreshRate = Fps(90.0f); |
| 796 | lr2.vote = LayerVoteType::ExplicitExactOrMultiple; |
| 797 | lr2.name = "90Hz ExplicitExactOrMultiple"; |
| 798 | EXPECT_EQ(mExpected90Config, |
| 799 | refreshRateConfigs->getBestRefreshRate(layers, {.touch = false, .idle = false})); |
| 800 | } |
| 801 | |
Steven Thomas | bb37432 | 2020-04-28 22:47:16 -0700 | [diff] [blame] | 802 | TEST_F(RefreshRateConfigsTest, getBestRefreshRate_30_60) { |
Ady Abraham | 8a82ba6 | 2020-01-17 12:43:17 -0800 | [diff] [blame] | 803 | auto refreshRateConfigs = |
Ady Abraham | abc2760 | 2020-04-08 17:20:29 -0700 | [diff] [blame] | 804 | std::make_unique<RefreshRateConfigs>(m30_60Device, |
| 805 | /*currentConfigId=*/HWC_CONFIG_ID_60); |
Ady Abraham | 8a82ba6 | 2020-01-17 12:43:17 -0800 | [diff] [blame] | 806 | |
| 807 | auto layers = std::vector<LayerRequirement>{LayerRequirement{.weight = 1.0f}}; |
| 808 | auto& lr = layers[0]; |
| 809 | |
| 810 | lr.vote = LayerVoteType::Min; |
Ady Abraham | abc2760 | 2020-04-08 17:20:29 -0700 | [diff] [blame] | 811 | EXPECT_EQ(mExpected30Config, |
Ady Abraham | dfd6216 | 2020-06-10 16:11:56 -0700 | [diff] [blame] | 812 | refreshRateConfigs->getBestRefreshRate(layers, {.touch = false, .idle = false})); |
Ady Abraham | 8a82ba6 | 2020-01-17 12:43:17 -0800 | [diff] [blame] | 813 | |
| 814 | lr.vote = LayerVoteType::Max; |
Ady Abraham | abc2760 | 2020-04-08 17:20:29 -0700 | [diff] [blame] | 815 | EXPECT_EQ(mExpected60Config, |
Ady Abraham | dfd6216 | 2020-06-10 16:11:56 -0700 | [diff] [blame] | 816 | refreshRateConfigs->getBestRefreshRate(layers, {.touch = false, .idle = false})); |
Ady Abraham | 8a82ba6 | 2020-01-17 12:43:17 -0800 | [diff] [blame] | 817 | |
Marin Shalamanov | e8a663d | 2020-11-24 17:48:00 +0100 | [diff] [blame] | 818 | lr.desiredRefreshRate = Fps(90.0f); |
Ady Abraham | 8a82ba6 | 2020-01-17 12:43:17 -0800 | [diff] [blame] | 819 | lr.vote = LayerVoteType::Heuristic; |
Ady Abraham | abc2760 | 2020-04-08 17:20:29 -0700 | [diff] [blame] | 820 | EXPECT_EQ(mExpected60Config, |
Ady Abraham | dfd6216 | 2020-06-10 16:11:56 -0700 | [diff] [blame] | 821 | refreshRateConfigs->getBestRefreshRate(layers, {.touch = false, .idle = false})); |
Ady Abraham | 8a82ba6 | 2020-01-17 12:43:17 -0800 | [diff] [blame] | 822 | |
Marin Shalamanov | e8a663d | 2020-11-24 17:48:00 +0100 | [diff] [blame] | 823 | lr.desiredRefreshRate = Fps(60.0f); |
Ady Abraham | abc2760 | 2020-04-08 17:20:29 -0700 | [diff] [blame] | 824 | EXPECT_EQ(mExpected60Config, |
Ady Abraham | dfd6216 | 2020-06-10 16:11:56 -0700 | [diff] [blame] | 825 | refreshRateConfigs->getBestRefreshRate(layers, {.touch = false, .idle = false})); |
Ady Abraham | 8a82ba6 | 2020-01-17 12:43:17 -0800 | [diff] [blame] | 826 | |
Marin Shalamanov | e8a663d | 2020-11-24 17:48:00 +0100 | [diff] [blame] | 827 | lr.desiredRefreshRate = Fps(45.0f); |
Ady Abraham | abc2760 | 2020-04-08 17:20:29 -0700 | [diff] [blame] | 828 | EXPECT_EQ(mExpected60Config, |
Ady Abraham | dfd6216 | 2020-06-10 16:11:56 -0700 | [diff] [blame] | 829 | refreshRateConfigs->getBestRefreshRate(layers, {.touch = false, .idle = false})); |
Ady Abraham | 8a82ba6 | 2020-01-17 12:43:17 -0800 | [diff] [blame] | 830 | |
Marin Shalamanov | e8a663d | 2020-11-24 17:48:00 +0100 | [diff] [blame] | 831 | lr.desiredRefreshRate = Fps(30.0f); |
Ady Abraham | abc2760 | 2020-04-08 17:20:29 -0700 | [diff] [blame] | 832 | EXPECT_EQ(mExpected30Config, |
Ady Abraham | dfd6216 | 2020-06-10 16:11:56 -0700 | [diff] [blame] | 833 | refreshRateConfigs->getBestRefreshRate(layers, {.touch = false, .idle = false})); |
Ady Abraham | 8a82ba6 | 2020-01-17 12:43:17 -0800 | [diff] [blame] | 834 | |
Marin Shalamanov | e8a663d | 2020-11-24 17:48:00 +0100 | [diff] [blame] | 835 | lr.desiredRefreshRate = Fps(24.0f); |
Ady Abraham | abc2760 | 2020-04-08 17:20:29 -0700 | [diff] [blame] | 836 | EXPECT_EQ(mExpected60Config, |
Ady Abraham | dfd6216 | 2020-06-10 16:11:56 -0700 | [diff] [blame] | 837 | refreshRateConfigs->getBestRefreshRate(layers, {.touch = false, .idle = false})); |
Ady Abraham | 8a82ba6 | 2020-01-17 12:43:17 -0800 | [diff] [blame] | 838 | } |
| 839 | |
Steven Thomas | bb37432 | 2020-04-28 22:47:16 -0700 | [diff] [blame] | 840 | TEST_F(RefreshRateConfigsTest, getBestRefreshRate_30_60_72_90) { |
Ady Abraham | 8a82ba6 | 2020-01-17 12:43:17 -0800 | [diff] [blame] | 841 | auto refreshRateConfigs = |
Ady Abraham | abc2760 | 2020-04-08 17:20:29 -0700 | [diff] [blame] | 842 | std::make_unique<RefreshRateConfigs>(m30_60_72_90Device, |
| 843 | /*currentConfigId=*/HWC_CONFIG_ID_60); |
Ady Abraham | 8a82ba6 | 2020-01-17 12:43:17 -0800 | [diff] [blame] | 844 | |
| 845 | auto layers = std::vector<LayerRequirement>{LayerRequirement{.weight = 1.0f}}; |
| 846 | auto& lr = layers[0]; |
| 847 | |
| 848 | lr.vote = LayerVoteType::Min; |
Ady Abraham | 4ccdcb4 | 2020-02-11 17:34:34 -0800 | [diff] [blame] | 849 | lr.name = "Min"; |
Ady Abraham | abc2760 | 2020-04-08 17:20:29 -0700 | [diff] [blame] | 850 | EXPECT_EQ(mExpected30Config, |
Ady Abraham | dfd6216 | 2020-06-10 16:11:56 -0700 | [diff] [blame] | 851 | refreshRateConfigs->getBestRefreshRate(layers, {.touch = false, .idle = false})); |
Ady Abraham | 8a82ba6 | 2020-01-17 12:43:17 -0800 | [diff] [blame] | 852 | |
| 853 | lr.vote = LayerVoteType::Max; |
Ady Abraham | 4ccdcb4 | 2020-02-11 17:34:34 -0800 | [diff] [blame] | 854 | lr.name = "Max"; |
Ady Abraham | abc2760 | 2020-04-08 17:20:29 -0700 | [diff] [blame] | 855 | EXPECT_EQ(mExpected90Config, |
Ady Abraham | dfd6216 | 2020-06-10 16:11:56 -0700 | [diff] [blame] | 856 | refreshRateConfigs->getBestRefreshRate(layers, {.touch = false, .idle = false})); |
Ady Abraham | 8a82ba6 | 2020-01-17 12:43:17 -0800 | [diff] [blame] | 857 | |
Marin Shalamanov | e8a663d | 2020-11-24 17:48:00 +0100 | [diff] [blame] | 858 | lr.desiredRefreshRate = Fps(90.0f); |
Ady Abraham | 8a82ba6 | 2020-01-17 12:43:17 -0800 | [diff] [blame] | 859 | lr.vote = LayerVoteType::Heuristic; |
Ady Abraham | 4ccdcb4 | 2020-02-11 17:34:34 -0800 | [diff] [blame] | 860 | lr.name = "90Hz Heuristic"; |
Ady Abraham | abc2760 | 2020-04-08 17:20:29 -0700 | [diff] [blame] | 861 | EXPECT_EQ(mExpected90Config, |
Ady Abraham | dfd6216 | 2020-06-10 16:11:56 -0700 | [diff] [blame] | 862 | refreshRateConfigs->getBestRefreshRate(layers, {.touch = false, .idle = false})); |
Ady Abraham | 8a82ba6 | 2020-01-17 12:43:17 -0800 | [diff] [blame] | 863 | |
Marin Shalamanov | e8a663d | 2020-11-24 17:48:00 +0100 | [diff] [blame] | 864 | lr.desiredRefreshRate = Fps(60.0f); |
Ady Abraham | 4ccdcb4 | 2020-02-11 17:34:34 -0800 | [diff] [blame] | 865 | lr.name = "60Hz Heuristic"; |
Ady Abraham | abc2760 | 2020-04-08 17:20:29 -0700 | [diff] [blame] | 866 | EXPECT_EQ(mExpected60Config, |
Ady Abraham | dfd6216 | 2020-06-10 16:11:56 -0700 | [diff] [blame] | 867 | refreshRateConfigs->getBestRefreshRate(layers, {.touch = false, .idle = false})); |
Ady Abraham | abc2760 | 2020-04-08 17:20:29 -0700 | [diff] [blame] | 868 | EXPECT_EQ(mExpected90Config, |
Ady Abraham | dfd6216 | 2020-06-10 16:11:56 -0700 | [diff] [blame] | 869 | refreshRateConfigs->getBestRefreshRate(layers, {.touch = true, .idle = false})); |
Ady Abraham | 8a82ba6 | 2020-01-17 12:43:17 -0800 | [diff] [blame] | 870 | |
Marin Shalamanov | e8a663d | 2020-11-24 17:48:00 +0100 | [diff] [blame] | 871 | lr.desiredRefreshRate = Fps(45.0f); |
Ady Abraham | 4ccdcb4 | 2020-02-11 17:34:34 -0800 | [diff] [blame] | 872 | lr.name = "45Hz Heuristic"; |
Ady Abraham | abc2760 | 2020-04-08 17:20:29 -0700 | [diff] [blame] | 873 | EXPECT_EQ(mExpected90Config, |
Ady Abraham | dfd6216 | 2020-06-10 16:11:56 -0700 | [diff] [blame] | 874 | refreshRateConfigs->getBestRefreshRate(layers, {.touch = false, .idle = false})); |
Ady Abraham | abc2760 | 2020-04-08 17:20:29 -0700 | [diff] [blame] | 875 | EXPECT_EQ(mExpected90Config, |
Ady Abraham | dfd6216 | 2020-06-10 16:11:56 -0700 | [diff] [blame] | 876 | refreshRateConfigs->getBestRefreshRate(layers, {.touch = true, .idle = false})); |
Ady Abraham | 8a82ba6 | 2020-01-17 12:43:17 -0800 | [diff] [blame] | 877 | |
Marin Shalamanov | e8a663d | 2020-11-24 17:48:00 +0100 | [diff] [blame] | 878 | lr.desiredRefreshRate = Fps(30.0f); |
Ady Abraham | 4ccdcb4 | 2020-02-11 17:34:34 -0800 | [diff] [blame] | 879 | lr.name = "30Hz Heuristic"; |
Ady Abraham | abc2760 | 2020-04-08 17:20:29 -0700 | [diff] [blame] | 880 | EXPECT_EQ(mExpected30Config, |
Ady Abraham | dfd6216 | 2020-06-10 16:11:56 -0700 | [diff] [blame] | 881 | refreshRateConfigs->getBestRefreshRate(layers, {.touch = false, .idle = false})); |
Ady Abraham | abc2760 | 2020-04-08 17:20:29 -0700 | [diff] [blame] | 882 | EXPECT_EQ(mExpected90Config, |
Ady Abraham | dfd6216 | 2020-06-10 16:11:56 -0700 | [diff] [blame] | 883 | refreshRateConfigs->getBestRefreshRate(layers, {.touch = true, .idle = false})); |
Ady Abraham | 8a82ba6 | 2020-01-17 12:43:17 -0800 | [diff] [blame] | 884 | |
Marin Shalamanov | e8a663d | 2020-11-24 17:48:00 +0100 | [diff] [blame] | 885 | lr.desiredRefreshRate = Fps(24.0f); |
Ady Abraham | 4ccdcb4 | 2020-02-11 17:34:34 -0800 | [diff] [blame] | 886 | lr.name = "24Hz Heuristic"; |
Ady Abraham | abc2760 | 2020-04-08 17:20:29 -0700 | [diff] [blame] | 887 | EXPECT_EQ(mExpected72Config, |
Ady Abraham | dfd6216 | 2020-06-10 16:11:56 -0700 | [diff] [blame] | 888 | refreshRateConfigs->getBestRefreshRate(layers, {.touch = false, .idle = false})); |
Ady Abraham | abc2760 | 2020-04-08 17:20:29 -0700 | [diff] [blame] | 889 | EXPECT_EQ(mExpected90Config, |
Ady Abraham | dfd6216 | 2020-06-10 16:11:56 -0700 | [diff] [blame] | 890 | refreshRateConfigs->getBestRefreshRate(layers, {.touch = true, .idle = false})); |
Ady Abraham | 4ccdcb4 | 2020-02-11 17:34:34 -0800 | [diff] [blame] | 891 | |
Marin Shalamanov | e8a663d | 2020-11-24 17:48:00 +0100 | [diff] [blame] | 892 | lr.desiredRefreshRate = Fps(24.0f); |
Ady Abraham | 4ccdcb4 | 2020-02-11 17:34:34 -0800 | [diff] [blame] | 893 | lr.vote = LayerVoteType::ExplicitExactOrMultiple; |
| 894 | lr.name = "24Hz ExplicitExactOrMultiple"; |
Ady Abraham | abc2760 | 2020-04-08 17:20:29 -0700 | [diff] [blame] | 895 | EXPECT_EQ(mExpected72Config, |
Ady Abraham | dfd6216 | 2020-06-10 16:11:56 -0700 | [diff] [blame] | 896 | refreshRateConfigs->getBestRefreshRate(layers, {.touch = false, .idle = false})); |
Ady Abraham | abc2760 | 2020-04-08 17:20:29 -0700 | [diff] [blame] | 897 | EXPECT_EQ(mExpected90Config, |
Ady Abraham | dfd6216 | 2020-06-10 16:11:56 -0700 | [diff] [blame] | 898 | refreshRateConfigs->getBestRefreshRate(layers, {.touch = true, .idle = false})); |
Ady Abraham | 8a82ba6 | 2020-01-17 12:43:17 -0800 | [diff] [blame] | 899 | } |
| 900 | |
Steven Thomas | bb37432 | 2020-04-28 22:47:16 -0700 | [diff] [blame] | 901 | TEST_F(RefreshRateConfigsTest, getBestRefreshRate_PriorityTest) { |
Ady Abraham | 8a82ba6 | 2020-01-17 12:43:17 -0800 | [diff] [blame] | 902 | auto refreshRateConfigs = |
Ady Abraham | abc2760 | 2020-04-08 17:20:29 -0700 | [diff] [blame] | 903 | std::make_unique<RefreshRateConfigs>(m30_60_90Device, |
| 904 | /*currentConfigId=*/HWC_CONFIG_ID_60); |
Ady Abraham | 8a82ba6 | 2020-01-17 12:43:17 -0800 | [diff] [blame] | 905 | |
| 906 | auto layers = std::vector<LayerRequirement>{LayerRequirement{.weight = 1.0f}, |
| 907 | LayerRequirement{.weight = 1.0f}}; |
| 908 | auto& lr1 = layers[0]; |
| 909 | auto& lr2 = layers[1]; |
| 910 | |
| 911 | lr1.vote = LayerVoteType::Min; |
| 912 | lr2.vote = LayerVoteType::Max; |
Ady Abraham | abc2760 | 2020-04-08 17:20:29 -0700 | [diff] [blame] | 913 | EXPECT_EQ(mExpected90Config, |
Ady Abraham | dfd6216 | 2020-06-10 16:11:56 -0700 | [diff] [blame] | 914 | refreshRateConfigs->getBestRefreshRate(layers, {.touch = false, .idle = false})); |
Ady Abraham | 8a82ba6 | 2020-01-17 12:43:17 -0800 | [diff] [blame] | 915 | |
| 916 | lr1.vote = LayerVoteType::Min; |
| 917 | lr2.vote = LayerVoteType::Heuristic; |
Marin Shalamanov | e8a663d | 2020-11-24 17:48:00 +0100 | [diff] [blame] | 918 | lr2.desiredRefreshRate = Fps(24.0f); |
Ady Abraham | abc2760 | 2020-04-08 17:20:29 -0700 | [diff] [blame] | 919 | EXPECT_EQ(mExpected60Config, |
Ady Abraham | dfd6216 | 2020-06-10 16:11:56 -0700 | [diff] [blame] | 920 | refreshRateConfigs->getBestRefreshRate(layers, {.touch = false, .idle = false})); |
Ady Abraham | 8a82ba6 | 2020-01-17 12:43:17 -0800 | [diff] [blame] | 921 | |
| 922 | lr1.vote = LayerVoteType::Min; |
Ady Abraham | 71c437d | 2020-01-31 15:56:57 -0800 | [diff] [blame] | 923 | lr2.vote = LayerVoteType::ExplicitExactOrMultiple; |
Marin Shalamanov | e8a663d | 2020-11-24 17:48:00 +0100 | [diff] [blame] | 924 | lr2.desiredRefreshRate = Fps(24.0f); |
Ady Abraham | abc2760 | 2020-04-08 17:20:29 -0700 | [diff] [blame] | 925 | EXPECT_EQ(mExpected60Config, |
Ady Abraham | dfd6216 | 2020-06-10 16:11:56 -0700 | [diff] [blame] | 926 | refreshRateConfigs->getBestRefreshRate(layers, {.touch = false, .idle = false})); |
Ady Abraham | 8a82ba6 | 2020-01-17 12:43:17 -0800 | [diff] [blame] | 927 | |
| 928 | lr1.vote = LayerVoteType::Max; |
| 929 | lr2.vote = LayerVoteType::Heuristic; |
Marin Shalamanov | e8a663d | 2020-11-24 17:48:00 +0100 | [diff] [blame] | 930 | lr2.desiredRefreshRate = Fps(60.0f); |
Ady Abraham | abc2760 | 2020-04-08 17:20:29 -0700 | [diff] [blame] | 931 | EXPECT_EQ(mExpected90Config, |
Ady Abraham | dfd6216 | 2020-06-10 16:11:56 -0700 | [diff] [blame] | 932 | refreshRateConfigs->getBestRefreshRate(layers, {.touch = false, .idle = false})); |
Ady Abraham | 8a82ba6 | 2020-01-17 12:43:17 -0800 | [diff] [blame] | 933 | |
| 934 | lr1.vote = LayerVoteType::Max; |
Ady Abraham | 71c437d | 2020-01-31 15:56:57 -0800 | [diff] [blame] | 935 | lr2.vote = LayerVoteType::ExplicitExactOrMultiple; |
Marin Shalamanov | e8a663d | 2020-11-24 17:48:00 +0100 | [diff] [blame] | 936 | lr2.desiredRefreshRate = Fps(60.0f); |
Ady Abraham | abc2760 | 2020-04-08 17:20:29 -0700 | [diff] [blame] | 937 | EXPECT_EQ(mExpected90Config, |
Ady Abraham | dfd6216 | 2020-06-10 16:11:56 -0700 | [diff] [blame] | 938 | refreshRateConfigs->getBestRefreshRate(layers, {.touch = false, .idle = false})); |
Ady Abraham | 8a82ba6 | 2020-01-17 12:43:17 -0800 | [diff] [blame] | 939 | |
| 940 | lr1.vote = LayerVoteType::Heuristic; |
Marin Shalamanov | e8a663d | 2020-11-24 17:48:00 +0100 | [diff] [blame] | 941 | lr1.desiredRefreshRate = Fps(15.0f); |
Ady Abraham | 8a82ba6 | 2020-01-17 12:43:17 -0800 | [diff] [blame] | 942 | lr2.vote = LayerVoteType::Heuristic; |
Marin Shalamanov | e8a663d | 2020-11-24 17:48:00 +0100 | [diff] [blame] | 943 | lr2.desiredRefreshRate = Fps(45.0f); |
Ady Abraham | abc2760 | 2020-04-08 17:20:29 -0700 | [diff] [blame] | 944 | EXPECT_EQ(mExpected90Config, |
Ady Abraham | dfd6216 | 2020-06-10 16:11:56 -0700 | [diff] [blame] | 945 | refreshRateConfigs->getBestRefreshRate(layers, {.touch = false, .idle = false})); |
Ady Abraham | 8a82ba6 | 2020-01-17 12:43:17 -0800 | [diff] [blame] | 946 | |
| 947 | lr1.vote = LayerVoteType::Heuristic; |
Marin Shalamanov | e8a663d | 2020-11-24 17:48:00 +0100 | [diff] [blame] | 948 | lr1.desiredRefreshRate = Fps(30.0f); |
Ady Abraham | 71c437d | 2020-01-31 15:56:57 -0800 | [diff] [blame] | 949 | lr2.vote = LayerVoteType::ExplicitExactOrMultiple; |
Marin Shalamanov | e8a663d | 2020-11-24 17:48:00 +0100 | [diff] [blame] | 950 | lr2.desiredRefreshRate = Fps(45.0f); |
Ady Abraham | abc2760 | 2020-04-08 17:20:29 -0700 | [diff] [blame] | 951 | EXPECT_EQ(mExpected90Config, |
Ady Abraham | dfd6216 | 2020-06-10 16:11:56 -0700 | [diff] [blame] | 952 | refreshRateConfigs->getBestRefreshRate(layers, {.touch = false, .idle = false})); |
Ady Abraham | 8a82ba6 | 2020-01-17 12:43:17 -0800 | [diff] [blame] | 953 | } |
| 954 | |
Steven Thomas | bb37432 | 2020-04-28 22:47:16 -0700 | [diff] [blame] | 955 | TEST_F(RefreshRateConfigsTest, getBestRefreshRate_24FpsVideo) { |
Ady Abraham | 8a82ba6 | 2020-01-17 12:43:17 -0800 | [diff] [blame] | 956 | auto refreshRateConfigs = |
Ady Abraham | abc2760 | 2020-04-08 17:20:29 -0700 | [diff] [blame] | 957 | std::make_unique<RefreshRateConfigs>(m60_90Device, |
| 958 | /*currentConfigId=*/HWC_CONFIG_ID_60); |
Ady Abraham | 8a82ba6 | 2020-01-17 12:43:17 -0800 | [diff] [blame] | 959 | |
| 960 | auto layers = std::vector<LayerRequirement>{LayerRequirement{.weight = 1.0f}}; |
| 961 | auto& lr = layers[0]; |
| 962 | |
Ady Abraham | 71c437d | 2020-01-31 15:56:57 -0800 | [diff] [blame] | 963 | lr.vote = LayerVoteType::ExplicitExactOrMultiple; |
Ady Abraham | 8a82ba6 | 2020-01-17 12:43:17 -0800 | [diff] [blame] | 964 | for (float fps = 23.0f; fps < 25.0f; fps += 0.1f) { |
Marin Shalamanov | e8a663d | 2020-11-24 17:48:00 +0100 | [diff] [blame] | 965 | lr.desiredRefreshRate = Fps(fps); |
Ady Abraham | 4ccdcb4 | 2020-02-11 17:34:34 -0800 | [diff] [blame] | 966 | const auto& refreshRate = |
Ady Abraham | dfd6216 | 2020-06-10 16:11:56 -0700 | [diff] [blame] | 967 | refreshRateConfigs->getBestRefreshRate(layers, {.touch = false, .idle = false}); |
Ady Abraham | b1b9d41 | 2020-06-01 19:53:52 -0700 | [diff] [blame] | 968 | EXPECT_EQ(mExpected60Config, refreshRate) << fps << "Hz chooses " << refreshRate.getName(); |
Ady Abraham | 8a82ba6 | 2020-01-17 12:43:17 -0800 | [diff] [blame] | 969 | } |
| 970 | } |
| 971 | |
rnlee | 3bd61066 | 2021-06-23 16:27:57 -0700 | [diff] [blame] | 972 | TEST_F(RefreshRateConfigsTest, getBestRefreshRate_24FpsVideo_multipleThreshold_60_120) { |
| 973 | RefreshRateConfigs::Config config = {.frameRateMultipleThreshold = 120}; |
| 974 | auto refreshRateConfigs = |
| 975 | std::make_unique<RefreshRateConfigs>(m60_120Device, |
| 976 | /*currentConfigId=*/HWC_CONFIG_ID_60, config); |
| 977 | |
| 978 | auto layers = std::vector<LayerRequirement>{LayerRequirement{.weight = 1.0f}}; |
| 979 | auto& lr = layers[0]; |
| 980 | |
| 981 | lr.vote = LayerVoteType::ExplicitExactOrMultiple; |
| 982 | for (float fps = 23.0f; fps < 25.0f; fps += 0.1f) { |
| 983 | lr.desiredRefreshRate = Fps(fps); |
| 984 | const auto& refreshRate = |
| 985 | refreshRateConfigs->getBestRefreshRate(layers, {.touch = false, .idle = false}); |
| 986 | EXPECT_EQ(mExpected60Config, refreshRate) << fps << "Hz chooses " << refreshRate.getName(); |
| 987 | } |
| 988 | } |
| 989 | |
Steven Thomas | bb37432 | 2020-04-28 22:47:16 -0700 | [diff] [blame] | 990 | TEST_F(RefreshRateConfigsTest, twoDeviceConfigs_getBestRefreshRate_Explicit) { |
Ady Abraham | 8a82ba6 | 2020-01-17 12:43:17 -0800 | [diff] [blame] | 991 | auto refreshRateConfigs = |
Ady Abraham | abc2760 | 2020-04-08 17:20:29 -0700 | [diff] [blame] | 992 | std::make_unique<RefreshRateConfigs>(m60_90Device, |
| 993 | /*currentConfigId=*/HWC_CONFIG_ID_60); |
Ady Abraham | 8a82ba6 | 2020-01-17 12:43:17 -0800 | [diff] [blame] | 994 | |
| 995 | auto layers = std::vector<LayerRequirement>{LayerRequirement{.weight = 1.0f}, |
| 996 | LayerRequirement{.weight = 1.0f}}; |
| 997 | auto& lr1 = layers[0]; |
| 998 | auto& lr2 = layers[1]; |
| 999 | |
| 1000 | lr1.vote = LayerVoteType::Heuristic; |
Marin Shalamanov | e8a663d | 2020-11-24 17:48:00 +0100 | [diff] [blame] | 1001 | lr1.desiredRefreshRate = Fps(60.0f); |
Ady Abraham | 71c437d | 2020-01-31 15:56:57 -0800 | [diff] [blame] | 1002 | lr2.vote = LayerVoteType::ExplicitExactOrMultiple; |
Marin Shalamanov | e8a663d | 2020-11-24 17:48:00 +0100 | [diff] [blame] | 1003 | lr2.desiredRefreshRate = Fps(90.0f); |
Ady Abraham | abc2760 | 2020-04-08 17:20:29 -0700 | [diff] [blame] | 1004 | EXPECT_EQ(mExpected90Config, |
Ady Abraham | dfd6216 | 2020-06-10 16:11:56 -0700 | [diff] [blame] | 1005 | refreshRateConfigs->getBestRefreshRate(layers, {.touch = false, .idle = false})); |
Ady Abraham | 4ccdcb4 | 2020-02-11 17:34:34 -0800 | [diff] [blame] | 1006 | |
| 1007 | lr1.vote = LayerVoteType::ExplicitDefault; |
Marin Shalamanov | e8a663d | 2020-11-24 17:48:00 +0100 | [diff] [blame] | 1008 | lr1.desiredRefreshRate = Fps(90.0f); |
Ady Abraham | 4ccdcb4 | 2020-02-11 17:34:34 -0800 | [diff] [blame] | 1009 | lr2.vote = LayerVoteType::ExplicitExactOrMultiple; |
Marin Shalamanov | e8a663d | 2020-11-24 17:48:00 +0100 | [diff] [blame] | 1010 | lr2.desiredRefreshRate = Fps(60.0f); |
Ady Abraham | abc2760 | 2020-04-08 17:20:29 -0700 | [diff] [blame] | 1011 | EXPECT_EQ(mExpected60Config, |
Ady Abraham | dfd6216 | 2020-06-10 16:11:56 -0700 | [diff] [blame] | 1012 | refreshRateConfigs->getBestRefreshRate(layers, {.touch = false, .idle = false})); |
Ady Abraham | 8a82ba6 | 2020-01-17 12:43:17 -0800 | [diff] [blame] | 1013 | |
| 1014 | lr1.vote = LayerVoteType::Heuristic; |
Marin Shalamanov | e8a663d | 2020-11-24 17:48:00 +0100 | [diff] [blame] | 1015 | lr1.desiredRefreshRate = Fps(90.0f); |
Ady Abraham | 71c437d | 2020-01-31 15:56:57 -0800 | [diff] [blame] | 1016 | lr2.vote = LayerVoteType::ExplicitExactOrMultiple; |
Marin Shalamanov | e8a663d | 2020-11-24 17:48:00 +0100 | [diff] [blame] | 1017 | lr2.desiredRefreshRate = Fps(60.0f); |
Ady Abraham | abc2760 | 2020-04-08 17:20:29 -0700 | [diff] [blame] | 1018 | EXPECT_EQ(mExpected90Config, |
Ady Abraham | dfd6216 | 2020-06-10 16:11:56 -0700 | [diff] [blame] | 1019 | refreshRateConfigs->getBestRefreshRate(layers, {.touch = false, .idle = false})); |
Ady Abraham | 2139f73 | 2019-11-13 18:56:40 -0800 | [diff] [blame] | 1020 | } |
| 1021 | |
Ana Krulec | 72f0d6e | 2020-01-06 15:24:47 -0800 | [diff] [blame] | 1022 | TEST_F(RefreshRateConfigsTest, testInPolicy) { |
Marin Shalamanov | e8a663d | 2020-11-24 17:48:00 +0100 | [diff] [blame] | 1023 | ASSERT_TRUE(mExpectedAlmost60Config.inPolicy(Fps(60.000004f), Fps(60.000004f))); |
| 1024 | ASSERT_TRUE(mExpectedAlmost60Config.inPolicy(Fps(59.0f), Fps(60.1f))); |
| 1025 | ASSERT_FALSE(mExpectedAlmost60Config.inPolicy(Fps(75.0f), Fps(90.0f))); |
| 1026 | ASSERT_FALSE(mExpectedAlmost60Config.inPolicy(Fps(60.0011f), Fps(90.0f))); |
| 1027 | ASSERT_FALSE(mExpectedAlmost60Config.inPolicy(Fps(50.0f), Fps(59.998f))); |
Ana Krulec | 72f0d6e | 2020-01-06 15:24:47 -0800 | [diff] [blame] | 1028 | } |
| 1029 | |
Steven Thomas | bb37432 | 2020-04-28 22:47:16 -0700 | [diff] [blame] | 1030 | TEST_F(RefreshRateConfigsTest, getBestRefreshRate_75HzContent) { |
Ady Abraham | f6b7707 | 2020-01-30 14:22:54 -0800 | [diff] [blame] | 1031 | auto refreshRateConfigs = |
Ady Abraham | abc2760 | 2020-04-08 17:20:29 -0700 | [diff] [blame] | 1032 | std::make_unique<RefreshRateConfigs>(m60_90Device, |
| 1033 | /*currentConfigId=*/HWC_CONFIG_ID_60); |
Ady Abraham | f6b7707 | 2020-01-30 14:22:54 -0800 | [diff] [blame] | 1034 | |
| 1035 | auto layers = std::vector<LayerRequirement>{LayerRequirement{.weight = 1.0f}}; |
| 1036 | auto& lr = layers[0]; |
| 1037 | |
Ady Abraham | 71c437d | 2020-01-31 15:56:57 -0800 | [diff] [blame] | 1038 | lr.vote = LayerVoteType::ExplicitExactOrMultiple; |
Ady Abraham | f6b7707 | 2020-01-30 14:22:54 -0800 | [diff] [blame] | 1039 | for (float fps = 75.0f; fps < 100.0f; fps += 0.1f) { |
Marin Shalamanov | e8a663d | 2020-11-24 17:48:00 +0100 | [diff] [blame] | 1040 | lr.desiredRefreshRate = Fps(fps); |
Ady Abraham | 4ccdcb4 | 2020-02-11 17:34:34 -0800 | [diff] [blame] | 1041 | const auto& refreshRate = |
Ady Abraham | dfd6216 | 2020-06-10 16:11:56 -0700 | [diff] [blame] | 1042 | refreshRateConfigs->getBestRefreshRate(layers, {.touch = false, .idle = false}); |
Ady Abraham | b1b9d41 | 2020-06-01 19:53:52 -0700 | [diff] [blame] | 1043 | EXPECT_EQ(mExpected90Config, refreshRate) << fps << "Hz chooses " << refreshRate.getName(); |
Ady Abraham | f6b7707 | 2020-01-30 14:22:54 -0800 | [diff] [blame] | 1044 | } |
| 1045 | } |
| 1046 | |
Steven Thomas | bb37432 | 2020-04-28 22:47:16 -0700 | [diff] [blame] | 1047 | TEST_F(RefreshRateConfigsTest, getBestRefreshRate_Multiples) { |
Ady Abraham | 3470210 | 2020-02-10 14:12:05 -0800 | [diff] [blame] | 1048 | auto refreshRateConfigs = |
Ady Abraham | abc2760 | 2020-04-08 17:20:29 -0700 | [diff] [blame] | 1049 | std::make_unique<RefreshRateConfigs>(m60_90Device, |
| 1050 | /*currentConfigId=*/HWC_CONFIG_ID_60); |
Ady Abraham | 3470210 | 2020-02-10 14:12:05 -0800 | [diff] [blame] | 1051 | |
| 1052 | auto layers = std::vector<LayerRequirement>{LayerRequirement{.weight = 1.0f}, |
| 1053 | LayerRequirement{.weight = 1.0f}}; |
| 1054 | auto& lr1 = layers[0]; |
| 1055 | auto& lr2 = layers[1]; |
| 1056 | |
| 1057 | lr1.vote = LayerVoteType::ExplicitExactOrMultiple; |
Marin Shalamanov | e8a663d | 2020-11-24 17:48:00 +0100 | [diff] [blame] | 1058 | lr1.desiredRefreshRate = Fps(60.0f); |
Ady Abraham | 4ccdcb4 | 2020-02-11 17:34:34 -0800 | [diff] [blame] | 1059 | lr1.name = "60Hz ExplicitExactOrMultiple"; |
Ady Abraham | 3470210 | 2020-02-10 14:12:05 -0800 | [diff] [blame] | 1060 | lr2.vote = LayerVoteType::Heuristic; |
Marin Shalamanov | e8a663d | 2020-11-24 17:48:00 +0100 | [diff] [blame] | 1061 | lr2.desiredRefreshRate = Fps(90.0f); |
Ady Abraham | 4ccdcb4 | 2020-02-11 17:34:34 -0800 | [diff] [blame] | 1062 | lr2.name = "90Hz Heuristic"; |
Ady Abraham | abc2760 | 2020-04-08 17:20:29 -0700 | [diff] [blame] | 1063 | EXPECT_EQ(mExpected90Config, |
Ady Abraham | dfd6216 | 2020-06-10 16:11:56 -0700 | [diff] [blame] | 1064 | refreshRateConfigs->getBestRefreshRate(layers, {.touch = false, .idle = false})); |
Ady Abraham | 3470210 | 2020-02-10 14:12:05 -0800 | [diff] [blame] | 1065 | |
| 1066 | lr1.vote = LayerVoteType::ExplicitExactOrMultiple; |
Marin Shalamanov | e8a663d | 2020-11-24 17:48:00 +0100 | [diff] [blame] | 1067 | lr1.desiredRefreshRate = Fps(60.0f); |
Ady Abraham | 4ccdcb4 | 2020-02-11 17:34:34 -0800 | [diff] [blame] | 1068 | lr1.name = "60Hz ExplicitExactOrMultiple"; |
| 1069 | lr2.vote = LayerVoteType::ExplicitDefault; |
Marin Shalamanov | e8a663d | 2020-11-24 17:48:00 +0100 | [diff] [blame] | 1070 | lr2.desiredRefreshRate = Fps(90.0f); |
Ady Abraham | 4ccdcb4 | 2020-02-11 17:34:34 -0800 | [diff] [blame] | 1071 | lr2.name = "90Hz ExplicitDefault"; |
Ady Abraham | abc2760 | 2020-04-08 17:20:29 -0700 | [diff] [blame] | 1072 | EXPECT_EQ(mExpected60Config, |
Ady Abraham | dfd6216 | 2020-06-10 16:11:56 -0700 | [diff] [blame] | 1073 | refreshRateConfigs->getBestRefreshRate(layers, {.touch = false, .idle = false})); |
Ady Abraham | 4ccdcb4 | 2020-02-11 17:34:34 -0800 | [diff] [blame] | 1074 | |
| 1075 | lr1.vote = LayerVoteType::ExplicitExactOrMultiple; |
Marin Shalamanov | e8a663d | 2020-11-24 17:48:00 +0100 | [diff] [blame] | 1076 | lr1.desiredRefreshRate = Fps(60.0f); |
Ady Abraham | 4ccdcb4 | 2020-02-11 17:34:34 -0800 | [diff] [blame] | 1077 | lr1.name = "60Hz ExplicitExactOrMultiple"; |
Ady Abraham | 3470210 | 2020-02-10 14:12:05 -0800 | [diff] [blame] | 1078 | lr2.vote = LayerVoteType::Max; |
Ady Abraham | 4ccdcb4 | 2020-02-11 17:34:34 -0800 | [diff] [blame] | 1079 | lr2.name = "Max"; |
Ady Abraham | abc2760 | 2020-04-08 17:20:29 -0700 | [diff] [blame] | 1080 | EXPECT_EQ(mExpected90Config, |
Ady Abraham | dfd6216 | 2020-06-10 16:11:56 -0700 | [diff] [blame] | 1081 | refreshRateConfigs->getBestRefreshRate(layers, {.touch = false, .idle = false})); |
Ady Abraham | 3470210 | 2020-02-10 14:12:05 -0800 | [diff] [blame] | 1082 | |
| 1083 | lr1.vote = LayerVoteType::ExplicitExactOrMultiple; |
Marin Shalamanov | e8a663d | 2020-11-24 17:48:00 +0100 | [diff] [blame] | 1084 | lr1.desiredRefreshRate = Fps(30.0f); |
Ady Abraham | 4ccdcb4 | 2020-02-11 17:34:34 -0800 | [diff] [blame] | 1085 | lr1.name = "30Hz ExplicitExactOrMultiple"; |
Ady Abraham | 3470210 | 2020-02-10 14:12:05 -0800 | [diff] [blame] | 1086 | lr2.vote = LayerVoteType::Heuristic; |
Marin Shalamanov | e8a663d | 2020-11-24 17:48:00 +0100 | [diff] [blame] | 1087 | lr2.desiredRefreshRate = Fps(90.0f); |
Ady Abraham | 4ccdcb4 | 2020-02-11 17:34:34 -0800 | [diff] [blame] | 1088 | lr2.name = "90Hz Heuristic"; |
Ady Abraham | abc2760 | 2020-04-08 17:20:29 -0700 | [diff] [blame] | 1089 | EXPECT_EQ(mExpected90Config, |
Ady Abraham | dfd6216 | 2020-06-10 16:11:56 -0700 | [diff] [blame] | 1090 | refreshRateConfigs->getBestRefreshRate(layers, {.touch = false, .idle = false})); |
Ady Abraham | 3470210 | 2020-02-10 14:12:05 -0800 | [diff] [blame] | 1091 | |
| 1092 | lr1.vote = LayerVoteType::ExplicitExactOrMultiple; |
Marin Shalamanov | e8a663d | 2020-11-24 17:48:00 +0100 | [diff] [blame] | 1093 | lr1.desiredRefreshRate = Fps(30.0f); |
Ady Abraham | 4ccdcb4 | 2020-02-11 17:34:34 -0800 | [diff] [blame] | 1094 | lr1.name = "30Hz ExplicitExactOrMultiple"; |
Ady Abraham | 3470210 | 2020-02-10 14:12:05 -0800 | [diff] [blame] | 1095 | lr2.vote = LayerVoteType::Max; |
Ady Abraham | 4ccdcb4 | 2020-02-11 17:34:34 -0800 | [diff] [blame] | 1096 | lr2.name = "Max"; |
Ady Abraham | abc2760 | 2020-04-08 17:20:29 -0700 | [diff] [blame] | 1097 | EXPECT_EQ(mExpected90Config, |
Ady Abraham | dfd6216 | 2020-06-10 16:11:56 -0700 | [diff] [blame] | 1098 | refreshRateConfigs->getBestRefreshRate(layers, {.touch = false, .idle = false})); |
Ady Abraham | 4ccdcb4 | 2020-02-11 17:34:34 -0800 | [diff] [blame] | 1099 | } |
| 1100 | |
| 1101 | TEST_F(RefreshRateConfigsTest, scrollWhileWatching60fps_60_90) { |
Ady Abraham | 4ccdcb4 | 2020-02-11 17:34:34 -0800 | [diff] [blame] | 1102 | auto refreshRateConfigs = |
Ady Abraham | abc2760 | 2020-04-08 17:20:29 -0700 | [diff] [blame] | 1103 | std::make_unique<RefreshRateConfigs>(m60_90Device, |
| 1104 | /*currentConfigId=*/HWC_CONFIG_ID_60); |
Ady Abraham | 4ccdcb4 | 2020-02-11 17:34:34 -0800 | [diff] [blame] | 1105 | |
| 1106 | auto layers = std::vector<LayerRequirement>{LayerRequirement{.weight = 1.0f}, |
| 1107 | LayerRequirement{.weight = 1.0f}}; |
| 1108 | auto& lr1 = layers[0]; |
| 1109 | auto& lr2 = layers[1]; |
| 1110 | |
| 1111 | lr1.vote = LayerVoteType::ExplicitExactOrMultiple; |
Marin Shalamanov | e8a663d | 2020-11-24 17:48:00 +0100 | [diff] [blame] | 1112 | lr1.desiredRefreshRate = Fps(60.0f); |
Ady Abraham | 4ccdcb4 | 2020-02-11 17:34:34 -0800 | [diff] [blame] | 1113 | lr1.name = "60Hz ExplicitExactOrMultiple"; |
| 1114 | lr2.vote = LayerVoteType::NoVote; |
| 1115 | lr2.name = "NoVote"; |
Ady Abraham | abc2760 | 2020-04-08 17:20:29 -0700 | [diff] [blame] | 1116 | EXPECT_EQ(mExpected60Config, |
Ady Abraham | dfd6216 | 2020-06-10 16:11:56 -0700 | [diff] [blame] | 1117 | refreshRateConfigs->getBestRefreshRate(layers, {.touch = false, .idle = false})); |
Ady Abraham | 4ccdcb4 | 2020-02-11 17:34:34 -0800 | [diff] [blame] | 1118 | |
| 1119 | lr1.vote = LayerVoteType::ExplicitExactOrMultiple; |
Marin Shalamanov | e8a663d | 2020-11-24 17:48:00 +0100 | [diff] [blame] | 1120 | lr1.desiredRefreshRate = Fps(60.0f); |
Ady Abraham | 4ccdcb4 | 2020-02-11 17:34:34 -0800 | [diff] [blame] | 1121 | lr1.name = "60Hz ExplicitExactOrMultiple"; |
| 1122 | lr2.vote = LayerVoteType::NoVote; |
| 1123 | lr2.name = "NoVote"; |
Ady Abraham | abc2760 | 2020-04-08 17:20:29 -0700 | [diff] [blame] | 1124 | EXPECT_EQ(mExpected90Config, |
Ady Abraham | dfd6216 | 2020-06-10 16:11:56 -0700 | [diff] [blame] | 1125 | refreshRateConfigs->getBestRefreshRate(layers, {.touch = true, .idle = false})); |
Ady Abraham | 4ccdcb4 | 2020-02-11 17:34:34 -0800 | [diff] [blame] | 1126 | |
| 1127 | lr1.vote = LayerVoteType::ExplicitExactOrMultiple; |
Marin Shalamanov | e8a663d | 2020-11-24 17:48:00 +0100 | [diff] [blame] | 1128 | lr1.desiredRefreshRate = Fps(60.0f); |
Ady Abraham | 4ccdcb4 | 2020-02-11 17:34:34 -0800 | [diff] [blame] | 1129 | lr1.name = "60Hz ExplicitExactOrMultiple"; |
| 1130 | lr2.vote = LayerVoteType::Max; |
| 1131 | lr2.name = "Max"; |
Ady Abraham | abc2760 | 2020-04-08 17:20:29 -0700 | [diff] [blame] | 1132 | EXPECT_EQ(mExpected90Config, |
Ady Abraham | dfd6216 | 2020-06-10 16:11:56 -0700 | [diff] [blame] | 1133 | refreshRateConfigs->getBestRefreshRate(layers, {.touch = true, .idle = false})); |
Ady Abraham | 4ccdcb4 | 2020-02-11 17:34:34 -0800 | [diff] [blame] | 1134 | |
| 1135 | lr1.vote = LayerVoteType::ExplicitExactOrMultiple; |
Marin Shalamanov | e8a663d | 2020-11-24 17:48:00 +0100 | [diff] [blame] | 1136 | lr1.desiredRefreshRate = Fps(60.0f); |
Ady Abraham | 4ccdcb4 | 2020-02-11 17:34:34 -0800 | [diff] [blame] | 1137 | lr1.name = "60Hz ExplicitExactOrMultiple"; |
| 1138 | lr2.vote = LayerVoteType::Max; |
| 1139 | lr2.name = "Max"; |
Ady Abraham | abc2760 | 2020-04-08 17:20:29 -0700 | [diff] [blame] | 1140 | EXPECT_EQ(mExpected90Config, |
Ady Abraham | dfd6216 | 2020-06-10 16:11:56 -0700 | [diff] [blame] | 1141 | refreshRateConfigs->getBestRefreshRate(layers, {.touch = false, .idle = false})); |
Ady Abraham | 4ccdcb4 | 2020-02-11 17:34:34 -0800 | [diff] [blame] | 1142 | |
| 1143 | // The other layer starts to provide buffers |
| 1144 | lr1.vote = LayerVoteType::ExplicitExactOrMultiple; |
Marin Shalamanov | e8a663d | 2020-11-24 17:48:00 +0100 | [diff] [blame] | 1145 | lr1.desiredRefreshRate = Fps(60.0f); |
Ady Abraham | 4ccdcb4 | 2020-02-11 17:34:34 -0800 | [diff] [blame] | 1146 | lr1.name = "60Hz ExplicitExactOrMultiple"; |
| 1147 | lr2.vote = LayerVoteType::Heuristic; |
Marin Shalamanov | e8a663d | 2020-11-24 17:48:00 +0100 | [diff] [blame] | 1148 | lr2.desiredRefreshRate = Fps(90.0f); |
Ady Abraham | 4ccdcb4 | 2020-02-11 17:34:34 -0800 | [diff] [blame] | 1149 | lr2.name = "90Hz Heuristic"; |
Ady Abraham | abc2760 | 2020-04-08 17:20:29 -0700 | [diff] [blame] | 1150 | EXPECT_EQ(mExpected90Config, |
Ady Abraham | dfd6216 | 2020-06-10 16:11:56 -0700 | [diff] [blame] | 1151 | refreshRateConfigs->getBestRefreshRate(layers, {.touch = false, .idle = false})); |
Ady Abraham | 6fb599b | 2020-03-05 13:48:22 -0800 | [diff] [blame] | 1152 | } |
| 1153 | |
| 1154 | TEST_F(RefreshRateConfigsTest, touchConsidered) { |
Ady Abraham | dfd6216 | 2020-06-10 16:11:56 -0700 | [diff] [blame] | 1155 | RefreshRateConfigs::GlobalSignals consideredSignals; |
Ady Abraham | 6fb599b | 2020-03-05 13:48:22 -0800 | [diff] [blame] | 1156 | auto refreshRateConfigs = |
Ady Abraham | abc2760 | 2020-04-08 17:20:29 -0700 | [diff] [blame] | 1157 | std::make_unique<RefreshRateConfigs>(m60_90Device, |
| 1158 | /*currentConfigId=*/HWC_CONFIG_ID_60); |
Ady Abraham | 6fb599b | 2020-03-05 13:48:22 -0800 | [diff] [blame] | 1159 | |
Ady Abraham | dfd6216 | 2020-06-10 16:11:56 -0700 | [diff] [blame] | 1160 | refreshRateConfigs->getBestRefreshRate({}, {.touch = false, .idle = false}, &consideredSignals); |
| 1161 | EXPECT_EQ(false, consideredSignals.touch); |
Ady Abraham | 6fb599b | 2020-03-05 13:48:22 -0800 | [diff] [blame] | 1162 | |
Ady Abraham | dfd6216 | 2020-06-10 16:11:56 -0700 | [diff] [blame] | 1163 | refreshRateConfigs->getBestRefreshRate({}, {.touch = true, .idle = false}, &consideredSignals); |
| 1164 | EXPECT_EQ(true, consideredSignals.touch); |
Ady Abraham | 6fb599b | 2020-03-05 13:48:22 -0800 | [diff] [blame] | 1165 | |
| 1166 | auto layers = std::vector<LayerRequirement>{LayerRequirement{.weight = 1.0f}, |
| 1167 | LayerRequirement{.weight = 1.0f}}; |
| 1168 | auto& lr1 = layers[0]; |
| 1169 | auto& lr2 = layers[1]; |
| 1170 | |
| 1171 | lr1.vote = LayerVoteType::ExplicitExactOrMultiple; |
Marin Shalamanov | e8a663d | 2020-11-24 17:48:00 +0100 | [diff] [blame] | 1172 | lr1.desiredRefreshRate = Fps(60.0f); |
Ady Abraham | 6fb599b | 2020-03-05 13:48:22 -0800 | [diff] [blame] | 1173 | lr1.name = "60Hz ExplicitExactOrMultiple"; |
| 1174 | lr2.vote = LayerVoteType::Heuristic; |
Marin Shalamanov | e8a663d | 2020-11-24 17:48:00 +0100 | [diff] [blame] | 1175 | lr2.desiredRefreshRate = Fps(60.0f); |
Steven Thomas | f734df4 | 2020-04-13 21:09:28 -0700 | [diff] [blame] | 1176 | lr2.name = "60Hz Heuristic"; |
Ady Abraham | dfd6216 | 2020-06-10 16:11:56 -0700 | [diff] [blame] | 1177 | refreshRateConfigs->getBestRefreshRate(layers, {.touch = true, .idle = false}, |
| 1178 | &consideredSignals); |
| 1179 | EXPECT_EQ(true, consideredSignals.touch); |
Ady Abraham | 6fb599b | 2020-03-05 13:48:22 -0800 | [diff] [blame] | 1180 | |
| 1181 | lr1.vote = LayerVoteType::ExplicitDefault; |
Marin Shalamanov | e8a663d | 2020-11-24 17:48:00 +0100 | [diff] [blame] | 1182 | lr1.desiredRefreshRate = Fps(60.0f); |
Ady Abraham | 6fb599b | 2020-03-05 13:48:22 -0800 | [diff] [blame] | 1183 | lr1.name = "60Hz ExplicitExactOrMultiple"; |
| 1184 | lr2.vote = LayerVoteType::Heuristic; |
Marin Shalamanov | e8a663d | 2020-11-24 17:48:00 +0100 | [diff] [blame] | 1185 | lr2.desiredRefreshRate = Fps(60.0f); |
Steven Thomas | f734df4 | 2020-04-13 21:09:28 -0700 | [diff] [blame] | 1186 | lr2.name = "60Hz Heuristic"; |
Ady Abraham | dfd6216 | 2020-06-10 16:11:56 -0700 | [diff] [blame] | 1187 | refreshRateConfigs->getBestRefreshRate(layers, {.touch = true, .idle = false}, |
| 1188 | &consideredSignals); |
| 1189 | EXPECT_EQ(false, consideredSignals.touch); |
Ady Abraham | 6fb599b | 2020-03-05 13:48:22 -0800 | [diff] [blame] | 1190 | |
| 1191 | lr1.vote = LayerVoteType::ExplicitExactOrMultiple; |
Marin Shalamanov | e8a663d | 2020-11-24 17:48:00 +0100 | [diff] [blame] | 1192 | lr1.desiredRefreshRate = Fps(60.0f); |
Ady Abraham | 6fb599b | 2020-03-05 13:48:22 -0800 | [diff] [blame] | 1193 | lr1.name = "60Hz ExplicitExactOrMultiple"; |
| 1194 | lr2.vote = LayerVoteType::Heuristic; |
Marin Shalamanov | e8a663d | 2020-11-24 17:48:00 +0100 | [diff] [blame] | 1195 | lr2.desiredRefreshRate = Fps(60.0f); |
Steven Thomas | f734df4 | 2020-04-13 21:09:28 -0700 | [diff] [blame] | 1196 | lr2.name = "60Hz Heuristic"; |
Ady Abraham | dfd6216 | 2020-06-10 16:11:56 -0700 | [diff] [blame] | 1197 | refreshRateConfigs->getBestRefreshRate(layers, {.touch = true, .idle = false}, |
| 1198 | &consideredSignals); |
| 1199 | EXPECT_EQ(true, consideredSignals.touch); |
Ady Abraham | 6fb599b | 2020-03-05 13:48:22 -0800 | [diff] [blame] | 1200 | |
| 1201 | lr1.vote = LayerVoteType::ExplicitDefault; |
Marin Shalamanov | e8a663d | 2020-11-24 17:48:00 +0100 | [diff] [blame] | 1202 | lr1.desiredRefreshRate = Fps(60.0f); |
Steven Thomas | f734df4 | 2020-04-13 21:09:28 -0700 | [diff] [blame] | 1203 | lr1.name = "60Hz ExplicitExactOrMultiple"; |
Ady Abraham | 6fb599b | 2020-03-05 13:48:22 -0800 | [diff] [blame] | 1204 | lr2.vote = LayerVoteType::Heuristic; |
Marin Shalamanov | e8a663d | 2020-11-24 17:48:00 +0100 | [diff] [blame] | 1205 | lr2.desiredRefreshRate = Fps(60.0f); |
Steven Thomas | f734df4 | 2020-04-13 21:09:28 -0700 | [diff] [blame] | 1206 | lr2.name = "60Hz Heuristic"; |
Ady Abraham | dfd6216 | 2020-06-10 16:11:56 -0700 | [diff] [blame] | 1207 | refreshRateConfigs->getBestRefreshRate(layers, {.touch = true, .idle = false}, |
| 1208 | &consideredSignals); |
| 1209 | EXPECT_EQ(false, consideredSignals.touch); |
Ady Abraham | 3470210 | 2020-02-10 14:12:05 -0800 | [diff] [blame] | 1210 | } |
| 1211 | |
Steven Thomas | bb37432 | 2020-04-28 22:47:16 -0700 | [diff] [blame] | 1212 | TEST_F(RefreshRateConfigsTest, getBestRefreshRate_ExplicitDefault) { |
Ady Abraham | abc2760 | 2020-04-08 17:20:29 -0700 | [diff] [blame] | 1213 | auto refreshRateConfigs = |
| 1214 | std::make_unique<RefreshRateConfigs>(m60_90_72_120Device, /*currentConfigId=*/ |
| 1215 | HWC_CONFIG_ID_60); |
Ady Abraham | 5b8afb5a | 2020-03-06 14:57:26 -0800 | [diff] [blame] | 1216 | |
| 1217 | auto layers = std::vector<LayerRequirement>{LayerRequirement{.weight = 1.0f}}; |
| 1218 | auto& lr = layers[0]; |
| 1219 | |
| 1220 | // Prepare a table with the vote and the expected refresh rate |
| 1221 | const std::vector<std::pair<float, float>> testCases = { |
| 1222 | {130, 120}, {120, 120}, {119, 120}, {110, 120}, |
| 1223 | |
| 1224 | {100, 90}, {90, 90}, {89, 90}, |
| 1225 | |
| 1226 | {80, 72}, {73, 72}, {72, 72}, {71, 72}, {70, 72}, |
| 1227 | |
| 1228 | {65, 60}, {60, 60}, {59, 60}, {58, 60}, |
| 1229 | |
| 1230 | {55, 90}, {50, 90}, {45, 90}, |
| 1231 | |
| 1232 | {42, 120}, {40, 120}, {39, 120}, |
| 1233 | |
| 1234 | {37, 72}, {36, 72}, {35, 72}, |
| 1235 | |
| 1236 | {30, 60}, |
| 1237 | }; |
| 1238 | |
| 1239 | for (const auto& test : testCases) { |
| 1240 | lr.vote = LayerVoteType::ExplicitDefault; |
Marin Shalamanov | e8a663d | 2020-11-24 17:48:00 +0100 | [diff] [blame] | 1241 | lr.desiredRefreshRate = Fps(test.first); |
Ady Abraham | 5b8afb5a | 2020-03-06 14:57:26 -0800 | [diff] [blame] | 1242 | |
| 1243 | std::stringstream ss; |
| 1244 | ss << "ExplicitDefault " << test.first << " fps"; |
| 1245 | lr.name = ss.str(); |
| 1246 | |
| 1247 | const auto& refreshRate = |
Ady Abraham | dfd6216 | 2020-06-10 16:11:56 -0700 | [diff] [blame] | 1248 | refreshRateConfigs->getBestRefreshRate(layers, {.touch = false, .idle = false}); |
Marin Shalamanov | e8a663d | 2020-11-24 17:48:00 +0100 | [diff] [blame] | 1249 | EXPECT_TRUE(refreshRate.getFps().equalsWithMargin(Fps(test.second))) |
Marin Shalamanov | 15a0fc6 | 2021-08-16 18:20:21 +0200 | [diff] [blame^] | 1250 | << "Expecting " << test.first << "fps => " << test.second << "Hz" |
| 1251 | << " but it was " << refreshRate.getFps(); |
| 1252 | } |
| 1253 | } |
| 1254 | |
| 1255 | TEST_F(RefreshRateConfigsTest, |
| 1256 | getBestRefreshRate_ExplicitExactOrMultiple_WithFractionalRefreshRates) { |
| 1257 | auto layers = std::vector<LayerRequirement>{LayerRequirement{.weight = 1.0f}}; |
| 1258 | auto& lr = layers[0]; |
| 1259 | |
| 1260 | // Test that 23.976 will choose 24 if 23.976 is not supported |
| 1261 | { |
| 1262 | android::DisplayModes modes = {mConfig24, mConfig25, mConfig30, |
| 1263 | mConfig30Frac, mConfig60, mConfig60Frac}; |
| 1264 | auto refreshRateConfigs = |
| 1265 | std::make_unique<RefreshRateConfigs>(modes, /*currentConfigId=*/HWC_CONFIG_ID_60); |
| 1266 | |
| 1267 | lr.vote = LayerVoteType::ExplicitExactOrMultiple; |
| 1268 | lr.desiredRefreshRate = Fps(23.976f); |
| 1269 | lr.name = "ExplicitExactOrMultiple 23.976 fps"; |
| 1270 | EXPECT_EQ(HWC_CONFIG_ID_24, |
| 1271 | refreshRateConfigs->getBestRefreshRate(layers, {.touch = false, .idle = false}) |
| 1272 | .getModeId()); |
| 1273 | } |
| 1274 | |
| 1275 | // Test that 24 will choose 23.976 if 24 is not supported |
| 1276 | { |
| 1277 | android::DisplayModes modes = {mConfig24Frac, mConfig25, mConfig30, |
| 1278 | mConfig30Frac, mConfig60, mConfig60Frac}; |
| 1279 | auto refreshRateConfigs = |
| 1280 | std::make_unique<RefreshRateConfigs>(modes, /*currentConfigId=*/HWC_CONFIG_ID_60); |
| 1281 | lr.desiredRefreshRate = Fps(24.f); |
| 1282 | lr.name = "ExplicitExactOrMultiple 24 fps"; |
| 1283 | EXPECT_EQ(HWC_CONFIG_ID_24_FRAC, |
| 1284 | refreshRateConfigs->getBestRefreshRate(layers, {.touch = false, .idle = false}) |
| 1285 | .getModeId()); |
| 1286 | } |
| 1287 | |
| 1288 | // Test that 29.97 will prefer 59.94 over 60 and 30 |
| 1289 | { |
| 1290 | android::DisplayModes modes = {mConfig24, mConfig24Frac, mConfig25, |
| 1291 | mConfig30, mConfig60, mConfig60Frac}; |
| 1292 | auto refreshRateConfigs = |
| 1293 | std::make_unique<RefreshRateConfigs>(modes, /*currentConfigId=*/HWC_CONFIG_ID_60); |
| 1294 | lr.desiredRefreshRate = Fps(29.97f); |
| 1295 | lr.name = "ExplicitExactOrMultiple 29.97f fps"; |
| 1296 | EXPECT_EQ(HWC_CONFIG_ID_60_FRAC, |
| 1297 | refreshRateConfigs->getBestRefreshRate(layers, {.touch = false, .idle = false}) |
| 1298 | .getModeId()); |
| 1299 | } |
| 1300 | } |
| 1301 | |
| 1302 | TEST_F(RefreshRateConfigsTest, getBestRefreshRate_ExplicitExact_WithFractionalRefreshRates) { |
| 1303 | auto layers = std::vector<LayerRequirement>{LayerRequirement{.weight = 1.0f}}; |
| 1304 | auto& lr = layers[0]; |
| 1305 | |
| 1306 | // Test that voting for supported refresh rate will select this refresh rate |
| 1307 | { |
| 1308 | auto refreshRateConfigs = |
| 1309 | std::make_unique<RefreshRateConfigs>(m24_25_30_50_60WithFracDevice, |
| 1310 | /*currentConfigId=*/HWC_CONFIG_ID_60); |
| 1311 | |
| 1312 | for (auto desiredRefreshRate : {23.976f, 24.f, 25.f, 29.97f, 30.f, 50.f, 59.94f, 60.f}) { |
| 1313 | lr.vote = LayerVoteType::ExplicitExact; |
| 1314 | lr.desiredRefreshRate = Fps(desiredRefreshRate); |
| 1315 | std::stringstream ss; |
| 1316 | ss << "ExplicitExact " << desiredRefreshRate << " fps"; |
| 1317 | lr.name = ss.str(); |
| 1318 | |
| 1319 | auto selecteRefreshRate = |
| 1320 | refreshRateConfigs->getBestRefreshRate(layers, {.touch = false, .idle = false}); |
| 1321 | |
| 1322 | EXPECT_TRUE(selecteRefreshRate.getFps().equalsWithMargin(lr.desiredRefreshRate)) |
| 1323 | << "Expecting " << lr.desiredRefreshRate << " but it was " |
| 1324 | << selecteRefreshRate.getFps(); |
| 1325 | } |
| 1326 | } |
| 1327 | |
| 1328 | // Test that 23.976 will choose 24 if 23.976 is not supported |
| 1329 | { |
| 1330 | android::DisplayModes modes = {mConfig24, mConfig25, mConfig30, |
| 1331 | mConfig30Frac, mConfig60, mConfig60Frac}; |
| 1332 | auto refreshRateConfigs = |
| 1333 | std::make_unique<RefreshRateConfigs>(modes, /*currentConfigId=*/HWC_CONFIG_ID_60); |
| 1334 | lr.vote = LayerVoteType::ExplicitExact; |
| 1335 | lr.desiredRefreshRate = Fps(23.976f); |
| 1336 | lr.name = "ExplicitExact 23.976 fps"; |
| 1337 | EXPECT_EQ(HWC_CONFIG_ID_24, |
| 1338 | refreshRateConfigs->getBestRefreshRate(layers, {.touch = false, .idle = false}) |
| 1339 | .getModeId()); |
| 1340 | } |
| 1341 | |
| 1342 | // Test that 24 will choose 23.976 if 24 is not supported |
| 1343 | { |
| 1344 | android::DisplayModes modes = {mConfig24Frac, mConfig25, mConfig30, |
| 1345 | mConfig30Frac, mConfig60, mConfig60Frac}; |
| 1346 | auto refreshRateConfigs = |
| 1347 | std::make_unique<RefreshRateConfigs>(modes, /*currentConfigId=*/HWC_CONFIG_ID_60); |
| 1348 | lr.desiredRefreshRate = Fps(24.f); |
| 1349 | lr.name = "ExplicitExact 24 fps"; |
| 1350 | EXPECT_EQ(HWC_CONFIG_ID_24_FRAC, |
| 1351 | refreshRateConfigs->getBestRefreshRate(layers, {.touch = false, .idle = false}) |
| 1352 | .getModeId()); |
Ady Abraham | 5b8afb5a | 2020-03-06 14:57:26 -0800 | [diff] [blame] | 1353 | } |
Alec Mouri | 0a1cc96 | 2019-03-14 12:33:02 -0700 | [diff] [blame] | 1354 | } |
| 1355 | |
Alec Mouri | 11232a2 | 2020-05-14 18:06:25 -0700 | [diff] [blame] | 1356 | TEST_F(RefreshRateConfigsTest, |
| 1357 | getBestRefreshRate_withDisplayManagerRequestingSingleRate_ignoresTouchFlag) { |
| 1358 | auto refreshRateConfigs = |
| 1359 | std::make_unique<RefreshRateConfigs>(m60_90Device, |
| 1360 | /*currentConfigId=*/HWC_CONFIG_ID_90); |
| 1361 | |
| 1362 | ASSERT_GE(refreshRateConfigs->setDisplayManagerPolicy( |
Marin Shalamanov | e8a663d | 2020-11-24 17:48:00 +0100 | [diff] [blame] | 1363 | {HWC_CONFIG_ID_90, {Fps(90.f), Fps(90.f)}, {Fps(60.f), Fps(90.f)}}), |
Alec Mouri | 11232a2 | 2020-05-14 18:06:25 -0700 | [diff] [blame] | 1364 | 0); |
| 1365 | |
| 1366 | auto layers = std::vector<LayerRequirement>{LayerRequirement{.weight = 1.0f}}; |
| 1367 | auto& lr = layers[0]; |
| 1368 | |
Ady Abraham | dfd6216 | 2020-06-10 16:11:56 -0700 | [diff] [blame] | 1369 | RefreshRateConfigs::GlobalSignals consideredSignals; |
Alec Mouri | 11232a2 | 2020-05-14 18:06:25 -0700 | [diff] [blame] | 1370 | lr.vote = LayerVoteType::ExplicitDefault; |
Marin Shalamanov | e8a663d | 2020-11-24 17:48:00 +0100 | [diff] [blame] | 1371 | lr.desiredRefreshRate = Fps(60.0f); |
Alec Mouri | 11232a2 | 2020-05-14 18:06:25 -0700 | [diff] [blame] | 1372 | lr.name = "60Hz ExplicitDefault"; |
Ady Abraham | aae5ed5 | 2020-06-26 09:32:43 -0700 | [diff] [blame] | 1373 | lr.focused = true; |
Alec Mouri | 11232a2 | 2020-05-14 18:06:25 -0700 | [diff] [blame] | 1374 | EXPECT_EQ(mExpected60Config, |
Ady Abraham | dfd6216 | 2020-06-10 16:11:56 -0700 | [diff] [blame] | 1375 | refreshRateConfigs->getBestRefreshRate(layers, {.touch = true, .idle = true}, |
| 1376 | &consideredSignals)); |
| 1377 | EXPECT_EQ(false, consideredSignals.touch); |
Alec Mouri | 11232a2 | 2020-05-14 18:06:25 -0700 | [diff] [blame] | 1378 | } |
| 1379 | |
| 1380 | TEST_F(RefreshRateConfigsTest, |
| 1381 | getBestRefreshRate_withDisplayManagerRequestingSingleRate_ignoresIdleFlag) { |
| 1382 | auto refreshRateConfigs = |
| 1383 | std::make_unique<RefreshRateConfigs>(m60_90Device, |
| 1384 | /*currentConfigId=*/HWC_CONFIG_ID_60); |
| 1385 | |
| 1386 | ASSERT_GE(refreshRateConfigs->setDisplayManagerPolicy( |
Marin Shalamanov | e8a663d | 2020-11-24 17:48:00 +0100 | [diff] [blame] | 1387 | {HWC_CONFIG_ID_60, {Fps(60.f), Fps(60.f)}, {Fps(60.f), Fps(90.f)}}), |
Alec Mouri | 11232a2 | 2020-05-14 18:06:25 -0700 | [diff] [blame] | 1388 | 0); |
| 1389 | |
| 1390 | auto layers = std::vector<LayerRequirement>{LayerRequirement{.weight = 1.0f}}; |
| 1391 | auto& lr = layers[0]; |
| 1392 | |
Alec Mouri | 11232a2 | 2020-05-14 18:06:25 -0700 | [diff] [blame] | 1393 | lr.vote = LayerVoteType::ExplicitDefault; |
Marin Shalamanov | e8a663d | 2020-11-24 17:48:00 +0100 | [diff] [blame] | 1394 | lr.desiredRefreshRate = Fps(90.0f); |
Alec Mouri | 11232a2 | 2020-05-14 18:06:25 -0700 | [diff] [blame] | 1395 | lr.name = "90Hz ExplicitDefault"; |
Ady Abraham | aae5ed5 | 2020-06-26 09:32:43 -0700 | [diff] [blame] | 1396 | lr.focused = true; |
Alec Mouri | 11232a2 | 2020-05-14 18:06:25 -0700 | [diff] [blame] | 1397 | EXPECT_EQ(mExpected90Config, |
Ady Abraham | dfd6216 | 2020-06-10 16:11:56 -0700 | [diff] [blame] | 1398 | refreshRateConfigs->getBestRefreshRate(layers, {.touch = false, .idle = true})); |
Alec Mouri | 11232a2 | 2020-05-14 18:06:25 -0700 | [diff] [blame] | 1399 | } |
| 1400 | |
| 1401 | TEST_F(RefreshRateConfigsTest, |
Ady Abraham | aae5ed5 | 2020-06-26 09:32:43 -0700 | [diff] [blame] | 1402 | getBestRefreshRate_withDisplayManagerRequestingSingleRate_onlySwitchesRatesForExplicitFocusedLayers) { |
Alec Mouri | 11232a2 | 2020-05-14 18:06:25 -0700 | [diff] [blame] | 1403 | auto refreshRateConfigs = |
| 1404 | std::make_unique<RefreshRateConfigs>(m60_90Device, |
| 1405 | /*currentConfigId=*/HWC_CONFIG_ID_90); |
| 1406 | |
| 1407 | ASSERT_GE(refreshRateConfigs->setDisplayManagerPolicy( |
Marin Shalamanov | e8a663d | 2020-11-24 17:48:00 +0100 | [diff] [blame] | 1408 | {HWC_CONFIG_ID_90, {Fps(90.f), Fps(90.f)}, {Fps(60.f), Fps(90.f)}}), |
Alec Mouri | 11232a2 | 2020-05-14 18:06:25 -0700 | [diff] [blame] | 1409 | 0); |
| 1410 | |
Ady Abraham | dfd6216 | 2020-06-10 16:11:56 -0700 | [diff] [blame] | 1411 | RefreshRateConfigs::GlobalSignals consideredSignals; |
Alec Mouri | 11232a2 | 2020-05-14 18:06:25 -0700 | [diff] [blame] | 1412 | EXPECT_EQ(mExpected90Config, |
Ady Abraham | dfd6216 | 2020-06-10 16:11:56 -0700 | [diff] [blame] | 1413 | refreshRateConfigs->getBestRefreshRate({}, {.touch = false, .idle = false}, |
| 1414 | &consideredSignals)); |
| 1415 | EXPECT_EQ(false, consideredSignals.touch); |
Alec Mouri | 11232a2 | 2020-05-14 18:06:25 -0700 | [diff] [blame] | 1416 | |
| 1417 | auto layers = std::vector<LayerRequirement>{LayerRequirement{.weight = 1.0f}}; |
| 1418 | auto& lr = layers[0]; |
| 1419 | |
| 1420 | lr.vote = LayerVoteType::ExplicitExactOrMultiple; |
Marin Shalamanov | e8a663d | 2020-11-24 17:48:00 +0100 | [diff] [blame] | 1421 | lr.desiredRefreshRate = Fps(60.0f); |
Alec Mouri | 11232a2 | 2020-05-14 18:06:25 -0700 | [diff] [blame] | 1422 | lr.name = "60Hz ExplicitExactOrMultiple"; |
Ady Abraham | aae5ed5 | 2020-06-26 09:32:43 -0700 | [diff] [blame] | 1423 | lr.focused = false; |
| 1424 | EXPECT_EQ(mExpected90Config, |
| 1425 | refreshRateConfigs->getBestRefreshRate(layers, {.touch = false, .idle = false})); |
| 1426 | |
| 1427 | lr.focused = true; |
Ady Abraham | 20c029c | 2020-07-06 12:58:05 -0700 | [diff] [blame] | 1428 | EXPECT_EQ(mExpected90Config, |
Ady Abraham | dfd6216 | 2020-06-10 16:11:56 -0700 | [diff] [blame] | 1429 | refreshRateConfigs->getBestRefreshRate(layers, {.touch = false, .idle = false})); |
Alec Mouri | 11232a2 | 2020-05-14 18:06:25 -0700 | [diff] [blame] | 1430 | |
| 1431 | lr.vote = LayerVoteType::ExplicitDefault; |
Marin Shalamanov | e8a663d | 2020-11-24 17:48:00 +0100 | [diff] [blame] | 1432 | lr.desiredRefreshRate = Fps(60.0f); |
Alec Mouri | 11232a2 | 2020-05-14 18:06:25 -0700 | [diff] [blame] | 1433 | lr.name = "60Hz ExplicitDefault"; |
Ady Abraham | aae5ed5 | 2020-06-26 09:32:43 -0700 | [diff] [blame] | 1434 | lr.focused = false; |
| 1435 | EXPECT_EQ(mExpected90Config, |
| 1436 | refreshRateConfigs->getBestRefreshRate(layers, {.touch = false, .idle = false})); |
| 1437 | |
| 1438 | lr.focused = true; |
Alec Mouri | 11232a2 | 2020-05-14 18:06:25 -0700 | [diff] [blame] | 1439 | EXPECT_EQ(mExpected60Config, |
Ady Abraham | dfd6216 | 2020-06-10 16:11:56 -0700 | [diff] [blame] | 1440 | refreshRateConfigs->getBestRefreshRate(layers, {.touch = false, .idle = false})); |
Alec Mouri | 11232a2 | 2020-05-14 18:06:25 -0700 | [diff] [blame] | 1441 | |
| 1442 | lr.vote = LayerVoteType::Heuristic; |
Marin Shalamanov | e8a663d | 2020-11-24 17:48:00 +0100 | [diff] [blame] | 1443 | lr.desiredRefreshRate = Fps(60.0f); |
Alec Mouri | 11232a2 | 2020-05-14 18:06:25 -0700 | [diff] [blame] | 1444 | lr.name = "60Hz Heuristic"; |
Ady Abraham | aae5ed5 | 2020-06-26 09:32:43 -0700 | [diff] [blame] | 1445 | lr.focused = false; |
| 1446 | EXPECT_EQ(mExpected90Config, |
| 1447 | refreshRateConfigs->getBestRefreshRate(layers, {.touch = false, .idle = false})); |
| 1448 | |
| 1449 | lr.focused = true; |
Alec Mouri | 11232a2 | 2020-05-14 18:06:25 -0700 | [diff] [blame] | 1450 | EXPECT_EQ(mExpected90Config, |
Ady Abraham | dfd6216 | 2020-06-10 16:11:56 -0700 | [diff] [blame] | 1451 | refreshRateConfigs->getBestRefreshRate(layers, {.touch = false, .idle = false})); |
Alec Mouri | 11232a2 | 2020-05-14 18:06:25 -0700 | [diff] [blame] | 1452 | |
| 1453 | lr.vote = LayerVoteType::Max; |
Marin Shalamanov | e8a663d | 2020-11-24 17:48:00 +0100 | [diff] [blame] | 1454 | lr.desiredRefreshRate = Fps(60.0f); |
Alec Mouri | 11232a2 | 2020-05-14 18:06:25 -0700 | [diff] [blame] | 1455 | lr.name = "60Hz Max"; |
Ady Abraham | aae5ed5 | 2020-06-26 09:32:43 -0700 | [diff] [blame] | 1456 | lr.focused = false; |
| 1457 | EXPECT_EQ(mExpected90Config, |
| 1458 | refreshRateConfigs->getBestRefreshRate(layers, {.touch = false, .idle = false})); |
| 1459 | |
| 1460 | lr.focused = true; |
Alec Mouri | 11232a2 | 2020-05-14 18:06:25 -0700 | [diff] [blame] | 1461 | EXPECT_EQ(mExpected90Config, |
Ady Abraham | dfd6216 | 2020-06-10 16:11:56 -0700 | [diff] [blame] | 1462 | refreshRateConfigs->getBestRefreshRate(layers, {.touch = false, .idle = false})); |
Alec Mouri | 11232a2 | 2020-05-14 18:06:25 -0700 | [diff] [blame] | 1463 | |
| 1464 | lr.vote = LayerVoteType::Min; |
Marin Shalamanov | e8a663d | 2020-11-24 17:48:00 +0100 | [diff] [blame] | 1465 | lr.desiredRefreshRate = Fps(60.0f); |
Alec Mouri | 11232a2 | 2020-05-14 18:06:25 -0700 | [diff] [blame] | 1466 | lr.name = "60Hz Min"; |
Ady Abraham | aae5ed5 | 2020-06-26 09:32:43 -0700 | [diff] [blame] | 1467 | lr.focused = false; |
| 1468 | EXPECT_EQ(mExpected90Config, |
| 1469 | refreshRateConfigs->getBestRefreshRate(layers, {.touch = false, .idle = false})); |
| 1470 | |
| 1471 | lr.focused = true; |
Alec Mouri | 11232a2 | 2020-05-14 18:06:25 -0700 | [diff] [blame] | 1472 | EXPECT_EQ(mExpected90Config, |
Ady Abraham | dfd6216 | 2020-06-10 16:11:56 -0700 | [diff] [blame] | 1473 | refreshRateConfigs->getBestRefreshRate(layers, {.touch = false, .idle = false})); |
Alec Mouri | 11232a2 | 2020-05-14 18:06:25 -0700 | [diff] [blame] | 1474 | } |
| 1475 | |
Marin Shalamanov | bb65d05 | 2021-03-23 19:21:52 +0100 | [diff] [blame] | 1476 | TEST_F(RefreshRateConfigsTest, groupSwitchingNotAllowed) { |
Steven Thomas | d407190 | 2020-03-24 16:02:53 -0700 | [diff] [blame] | 1477 | auto refreshRateConfigs = |
Ady Abraham | abc2760 | 2020-04-08 17:20:29 -0700 | [diff] [blame] | 1478 | std::make_unique<RefreshRateConfigs>(m60_90DeviceWithDifferentGroups, |
| 1479 | /*currentConfigId=*/HWC_CONFIG_ID_60); |
Steven Thomas | d407190 | 2020-03-24 16:02:53 -0700 | [diff] [blame] | 1480 | |
Marin Shalamanov | bb65d05 | 2021-03-23 19:21:52 +0100 | [diff] [blame] | 1481 | // The default policy doesn't allow group switching. Verify that no |
| 1482 | // group switches are performed. |
Steven Thomas | d407190 | 2020-03-24 16:02:53 -0700 | [diff] [blame] | 1483 | auto layers = std::vector<LayerRequirement>{LayerRequirement{.weight = 1.0f}}; |
| 1484 | auto& layer = layers[0]; |
| 1485 | layer.vote = LayerVoteType::ExplicitDefault; |
Marin Shalamanov | e8a663d | 2020-11-24 17:48:00 +0100 | [diff] [blame] | 1486 | layer.desiredRefreshRate = Fps(90.0f); |
Marin Shalamanov | 53fc11d | 2020-11-20 14:00:13 +0100 | [diff] [blame] | 1487 | layer.seamlessness = Seamlessness::SeamedAndSeamless; |
Steven Thomas | d407190 | 2020-03-24 16:02:53 -0700 | [diff] [blame] | 1488 | layer.name = "90Hz ExplicitDefault"; |
Marin Shalamanov | 4608442 | 2020-10-13 12:33:42 +0200 | [diff] [blame] | 1489 | layer.focused = true; |
Steven Thomas | d407190 | 2020-03-24 16:02:53 -0700 | [diff] [blame] | 1490 | |
Steven Thomas | d407190 | 2020-03-24 16:02:53 -0700 | [diff] [blame] | 1491 | ASSERT_EQ(HWC_CONFIG_ID_60, |
Ady Abraham | dfd6216 | 2020-06-10 16:11:56 -0700 | [diff] [blame] | 1492 | refreshRateConfigs->getBestRefreshRate(layers, {.touch = false, .idle = false}) |
Marin Shalamanov | a7fe304 | 2021-01-29 21:02:08 +0100 | [diff] [blame] | 1493 | .getModeId()); |
Marin Shalamanov | bb65d05 | 2021-03-23 19:21:52 +0100 | [diff] [blame] | 1494 | } |
Steven Thomas | d407190 | 2020-03-24 16:02:53 -0700 | [diff] [blame] | 1495 | |
Marin Shalamanov | bb65d05 | 2021-03-23 19:21:52 +0100 | [diff] [blame] | 1496 | TEST_F(RefreshRateConfigsTest, groupSwitchingWithOneLayer) { |
| 1497 | auto refreshRateConfigs = |
| 1498 | std::make_unique<RefreshRateConfigs>(m60_90DeviceWithDifferentGroups, |
| 1499 | /*currentConfigId=*/HWC_CONFIG_ID_60); |
Steven Thomas | d407190 | 2020-03-24 16:02:53 -0700 | [diff] [blame] | 1500 | RefreshRateConfigs::Policy policy; |
Marin Shalamanov | a7fe304 | 2021-01-29 21:02:08 +0100 | [diff] [blame] | 1501 | policy.defaultMode = refreshRateConfigs->getCurrentPolicy().defaultMode; |
Steven Thomas | d407190 | 2020-03-24 16:02:53 -0700 | [diff] [blame] | 1502 | policy.allowGroupSwitching = true; |
| 1503 | ASSERT_GE(refreshRateConfigs->setDisplayManagerPolicy(policy), 0); |
Marin Shalamanov | bb65d05 | 2021-03-23 19:21:52 +0100 | [diff] [blame] | 1504 | |
| 1505 | auto layers = std::vector<LayerRequirement>{LayerRequirement{.weight = 1.0f}}; |
| 1506 | auto& layer = layers[0]; |
| 1507 | layer.vote = LayerVoteType::ExplicitDefault; |
| 1508 | layer.desiredRefreshRate = Fps(90.0f); |
| 1509 | layer.seamlessness = Seamlessness::SeamedAndSeamless; |
| 1510 | layer.name = "90Hz ExplicitDefault"; |
| 1511 | layer.focused = true; |
Steven Thomas | d407190 | 2020-03-24 16:02:53 -0700 | [diff] [blame] | 1512 | ASSERT_EQ(HWC_CONFIG_ID_90, |
Ady Abraham | dfd6216 | 2020-06-10 16:11:56 -0700 | [diff] [blame] | 1513 | refreshRateConfigs->getBestRefreshRate(layers, {.touch = false, .idle = false}) |
Marin Shalamanov | a7fe304 | 2021-01-29 21:02:08 +0100 | [diff] [blame] | 1514 | .getModeId()); |
Marin Shalamanov | bb65d05 | 2021-03-23 19:21:52 +0100 | [diff] [blame] | 1515 | } |
| 1516 | |
| 1517 | TEST_F(RefreshRateConfigsTest, groupSwitchingWithOneLayerOnlySeamless) { |
| 1518 | auto refreshRateConfigs = |
| 1519 | std::make_unique<RefreshRateConfigs>(m60_90DeviceWithDifferentGroups, |
| 1520 | /*currentConfigId=*/HWC_CONFIG_ID_60); |
| 1521 | RefreshRateConfigs::Policy policy; |
| 1522 | policy.defaultMode = refreshRateConfigs->getCurrentPolicy().defaultMode; |
| 1523 | policy.allowGroupSwitching = true; |
| 1524 | ASSERT_GE(refreshRateConfigs->setDisplayManagerPolicy(policy), 0); |
Marin Shalamanov | 4608442 | 2020-10-13 12:33:42 +0200 | [diff] [blame] | 1525 | |
| 1526 | // Verify that we won't change the group if seamless switch is required. |
Marin Shalamanov | bb65d05 | 2021-03-23 19:21:52 +0100 | [diff] [blame] | 1527 | auto layers = std::vector<LayerRequirement>{LayerRequirement{.weight = 1.0f}}; |
| 1528 | auto& layer = layers[0]; |
| 1529 | layer.vote = LayerVoteType::ExplicitDefault; |
| 1530 | layer.desiredRefreshRate = Fps(90.0f); |
Marin Shalamanov | 53fc11d | 2020-11-20 14:00:13 +0100 | [diff] [blame] | 1531 | layer.seamlessness = Seamlessness::OnlySeamless; |
Marin Shalamanov | bb65d05 | 2021-03-23 19:21:52 +0100 | [diff] [blame] | 1532 | layer.name = "90Hz ExplicitDefault"; |
| 1533 | layer.focused = true; |
Marin Shalamanov | 4608442 | 2020-10-13 12:33:42 +0200 | [diff] [blame] | 1534 | ASSERT_EQ(HWC_CONFIG_ID_60, |
| 1535 | refreshRateConfigs->getBestRefreshRate(layers, {.touch = false, .idle = false}) |
Marin Shalamanov | a7fe304 | 2021-01-29 21:02:08 +0100 | [diff] [blame] | 1536 | .getModeId()); |
Marin Shalamanov | bb65d05 | 2021-03-23 19:21:52 +0100 | [diff] [blame] | 1537 | } |
| 1538 | |
| 1539 | TEST_F(RefreshRateConfigsTest, groupSwitchingWithOneLayerOnlySeamlessDefaultFps) { |
| 1540 | auto refreshRateConfigs = |
| 1541 | std::make_unique<RefreshRateConfigs>(m60_90DeviceWithDifferentGroups, |
| 1542 | /*currentConfigId=*/HWC_CONFIG_ID_60); |
| 1543 | RefreshRateConfigs::Policy policy; |
| 1544 | policy.defaultMode = refreshRateConfigs->getCurrentPolicy().defaultMode; |
| 1545 | policy.allowGroupSwitching = true; |
| 1546 | ASSERT_GE(refreshRateConfigs->setDisplayManagerPolicy(policy), 0); |
| 1547 | |
| 1548 | refreshRateConfigs->setCurrentModeId(HWC_CONFIG_ID_90); |
Marin Shalamanov | 4608442 | 2020-10-13 12:33:42 +0200 | [diff] [blame] | 1549 | |
Marin Shalamanov | 53fc11d | 2020-11-20 14:00:13 +0100 | [diff] [blame] | 1550 | // Verify that we won't do a seamless switch if we request the same mode as the default |
Marin Shalamanov | bb65d05 | 2021-03-23 19:21:52 +0100 | [diff] [blame] | 1551 | auto layers = std::vector<LayerRequirement>{LayerRequirement{.weight = 1.0f}}; |
| 1552 | auto& layer = layers[0]; |
| 1553 | layer.vote = LayerVoteType::ExplicitDefault; |
Marin Shalamanov | e8a663d | 2020-11-24 17:48:00 +0100 | [diff] [blame] | 1554 | layer.desiredRefreshRate = Fps(60.0f); |
Marin Shalamanov | 53fc11d | 2020-11-20 14:00:13 +0100 | [diff] [blame] | 1555 | layer.seamlessness = Seamlessness::OnlySeamless; |
Marin Shalamanov | bb65d05 | 2021-03-23 19:21:52 +0100 | [diff] [blame] | 1556 | layer.name = "60Hz ExplicitDefault"; |
| 1557 | layer.focused = true; |
Marin Shalamanov | 53fc11d | 2020-11-20 14:00:13 +0100 | [diff] [blame] | 1558 | ASSERT_EQ(HWC_CONFIG_ID_90, |
| 1559 | refreshRateConfigs->getBestRefreshRate(layers, {.touch = false, .idle = false}) |
Marin Shalamanov | a7fe304 | 2021-01-29 21:02:08 +0100 | [diff] [blame] | 1560 | .getModeId()); |
Marin Shalamanov | bb65d05 | 2021-03-23 19:21:52 +0100 | [diff] [blame] | 1561 | } |
| 1562 | |
| 1563 | TEST_F(RefreshRateConfigsTest, groupSwitchingWithOneLayerDefaultSeamlessness) { |
| 1564 | auto refreshRateConfigs = |
| 1565 | std::make_unique<RefreshRateConfigs>(m60_90DeviceWithDifferentGroups, |
| 1566 | /*currentConfigId=*/HWC_CONFIG_ID_60); |
| 1567 | RefreshRateConfigs::Policy policy; |
| 1568 | policy.defaultMode = refreshRateConfigs->getCurrentPolicy().defaultMode; |
| 1569 | policy.allowGroupSwitching = true; |
| 1570 | ASSERT_GE(refreshRateConfigs->setDisplayManagerPolicy(policy), 0); |
| 1571 | |
| 1572 | refreshRateConfigs->setCurrentModeId(HWC_CONFIG_ID_90); |
Marin Shalamanov | 53fc11d | 2020-11-20 14:00:13 +0100 | [diff] [blame] | 1573 | |
| 1574 | // Verify that if the current config is in another group and there are no layers with |
| 1575 | // seamlessness=SeamedAndSeamless we'll go back to the default group. |
Marin Shalamanov | bb65d05 | 2021-03-23 19:21:52 +0100 | [diff] [blame] | 1576 | |
| 1577 | auto layers = std::vector<LayerRequirement>{LayerRequirement{.weight = 1.0f}}; |
| 1578 | auto& layer = layers[0]; |
| 1579 | layer.vote = LayerVoteType::ExplicitDefault; |
Marin Shalamanov | e8a663d | 2020-11-24 17:48:00 +0100 | [diff] [blame] | 1580 | layer.desiredRefreshRate = Fps(60.0f); |
Marin Shalamanov | 53fc11d | 2020-11-20 14:00:13 +0100 | [diff] [blame] | 1581 | layer.seamlessness = Seamlessness::Default; |
Marin Shalamanov | bb65d05 | 2021-03-23 19:21:52 +0100 | [diff] [blame] | 1582 | layer.name = "60Hz ExplicitDefault"; |
| 1583 | layer.focused = true; |
| 1584 | |
Marin Shalamanov | 4608442 | 2020-10-13 12:33:42 +0200 | [diff] [blame] | 1585 | ASSERT_EQ(HWC_CONFIG_ID_60, |
| 1586 | refreshRateConfigs->getBestRefreshRate(layers, {.touch = false, .idle = false}) |
Marin Shalamanov | a7fe304 | 2021-01-29 21:02:08 +0100 | [diff] [blame] | 1587 | .getModeId()); |
Marin Shalamanov | bb65d05 | 2021-03-23 19:21:52 +0100 | [diff] [blame] | 1588 | } |
| 1589 | |
| 1590 | TEST_F(RefreshRateConfigsTest, groupSwitchingWithTwoLayersOnlySeamlessAndSeamed) { |
| 1591 | auto refreshRateConfigs = |
| 1592 | std::make_unique<RefreshRateConfigs>(m60_90DeviceWithDifferentGroups, |
| 1593 | /*currentConfigId=*/HWC_CONFIG_ID_60); |
| 1594 | RefreshRateConfigs::Policy policy; |
| 1595 | policy.defaultMode = refreshRateConfigs->getCurrentPolicy().defaultMode; |
| 1596 | policy.allowGroupSwitching = true; |
| 1597 | ASSERT_GE(refreshRateConfigs->setDisplayManagerPolicy(policy), 0); |
| 1598 | |
| 1599 | refreshRateConfigs->setCurrentModeId(HWC_CONFIG_ID_90); |
Marin Shalamanov | 4608442 | 2020-10-13 12:33:42 +0200 | [diff] [blame] | 1600 | |
Marin Shalamanov | 53fc11d | 2020-11-20 14:00:13 +0100 | [diff] [blame] | 1601 | // If there's a layer with seamlessness=SeamedAndSeamless, another layer with |
Marin Shalamanov | a7fe304 | 2021-01-29 21:02:08 +0100 | [diff] [blame] | 1602 | // seamlessness=OnlySeamless can't change the mode group. |
Marin Shalamanov | bb65d05 | 2021-03-23 19:21:52 +0100 | [diff] [blame] | 1603 | auto layers = std::vector<LayerRequirement>{LayerRequirement{.weight = 1.0f}}; |
| 1604 | layers[0].vote = LayerVoteType::ExplicitDefault; |
| 1605 | layers[0].desiredRefreshRate = Fps(60.0f); |
| 1606 | layers[0].seamlessness = Seamlessness::OnlySeamless; |
| 1607 | layers[0].name = "60Hz ExplicitDefault"; |
| 1608 | layers[0].focused = true; |
Marin Shalamanov | 53fc11d | 2020-11-20 14:00:13 +0100 | [diff] [blame] | 1609 | |
| 1610 | layers.push_back(LayerRequirement{.weight = 0.5f}); |
Marin Shalamanov | bb65d05 | 2021-03-23 19:21:52 +0100 | [diff] [blame] | 1611 | layers[1].vote = LayerVoteType::ExplicitDefault; |
| 1612 | layers[1].seamlessness = Seamlessness::SeamedAndSeamless; |
| 1613 | layers[1].desiredRefreshRate = Fps(90.0f); |
| 1614 | layers[1].name = "90Hz ExplicitDefault"; |
| 1615 | layers[1].focused = false; |
Marin Shalamanov | 53fc11d | 2020-11-20 14:00:13 +0100 | [diff] [blame] | 1616 | |
| 1617 | ASSERT_EQ(HWC_CONFIG_ID_90, |
| 1618 | refreshRateConfigs->getBestRefreshRate(layers, {.touch = false, .idle = false}) |
Marin Shalamanov | a7fe304 | 2021-01-29 21:02:08 +0100 | [diff] [blame] | 1619 | .getModeId()); |
Marin Shalamanov | bb65d05 | 2021-03-23 19:21:52 +0100 | [diff] [blame] | 1620 | } |
Marin Shalamanov | 53fc11d | 2020-11-20 14:00:13 +0100 | [diff] [blame] | 1621 | |
Marin Shalamanov | ae0b535 | 2021-03-24 12:56:08 +0100 | [diff] [blame] | 1622 | TEST_F(RefreshRateConfigsTest, groupSwitchingWithTwoLayersDefaultFocusedAndSeamed) { |
Marin Shalamanov | bb65d05 | 2021-03-23 19:21:52 +0100 | [diff] [blame] | 1623 | auto refreshRateConfigs = |
| 1624 | std::make_unique<RefreshRateConfigs>(m60_90DeviceWithDifferentGroups, |
| 1625 | /*currentConfigId=*/HWC_CONFIG_ID_60); |
| 1626 | RefreshRateConfigs::Policy policy; |
| 1627 | policy.defaultMode = refreshRateConfigs->getCurrentPolicy().defaultMode; |
| 1628 | policy.allowGroupSwitching = true; |
| 1629 | ASSERT_GE(refreshRateConfigs->setDisplayManagerPolicy(policy), 0); |
| 1630 | |
| 1631 | refreshRateConfigs->setCurrentModeId(HWC_CONFIG_ID_90); |
Marin Shalamanov | 53fc11d | 2020-11-20 14:00:13 +0100 | [diff] [blame] | 1632 | |
Marin Shalamanov | ae0b535 | 2021-03-24 12:56:08 +0100 | [diff] [blame] | 1633 | // If there's a focused layer with seamlessness=SeamedAndSeamless, another layer with |
| 1634 | // seamlessness=Default can't change the mode group back to the group of the default |
| 1635 | // mode. |
| 1636 | // For example, this may happen when a video playback requests and gets a seamed switch, |
| 1637 | // but another layer (with default seamlessness) starts animating. The animating layer |
| 1638 | // should not cause a seamed switch. |
Marin Shalamanov | bb65d05 | 2021-03-23 19:21:52 +0100 | [diff] [blame] | 1639 | auto layers = std::vector<LayerRequirement>{LayerRequirement{.weight = 1.0f}}; |
Marin Shalamanov | 53fc11d | 2020-11-20 14:00:13 +0100 | [diff] [blame] | 1640 | layers[0].seamlessness = Seamlessness::Default; |
Marin Shalamanov | bb65d05 | 2021-03-23 19:21:52 +0100 | [diff] [blame] | 1641 | layers[0].desiredRefreshRate = Fps(60.0f); |
| 1642 | layers[0].focused = true; |
| 1643 | layers[0].vote = LayerVoteType::ExplicitDefault; |
| 1644 | layers[0].name = "60Hz ExplicitDefault"; |
| 1645 | |
Marin Shalamanov | ae0b535 | 2021-03-24 12:56:08 +0100 | [diff] [blame] | 1646 | layers.push_back(LayerRequirement{.weight = 0.1f}); |
| 1647 | layers[1].seamlessness = Seamlessness::SeamedAndSeamless; |
| 1648 | layers[1].desiredRefreshRate = Fps(90.0f); |
| 1649 | layers[1].focused = true; |
| 1650 | layers[1].vote = LayerVoteType::ExplicitDefault; |
| 1651 | layers[1].name = "90Hz ExplicitDefault"; |
| 1652 | |
Marin Shalamanov | 4608442 | 2020-10-13 12:33:42 +0200 | [diff] [blame] | 1653 | ASSERT_EQ(HWC_CONFIG_ID_90, |
| 1654 | refreshRateConfigs->getBestRefreshRate(layers, {.touch = false, .idle = false}) |
Marin Shalamanov | a7fe304 | 2021-01-29 21:02:08 +0100 | [diff] [blame] | 1655 | .getModeId()); |
Marin Shalamanov | 4608442 | 2020-10-13 12:33:42 +0200 | [diff] [blame] | 1656 | } |
| 1657 | |
Marin Shalamanov | ae0b535 | 2021-03-24 12:56:08 +0100 | [diff] [blame] | 1658 | TEST_F(RefreshRateConfigsTest, groupSwitchingWithTwoLayersDefaultNotFocusedAndSeamed) { |
| 1659 | auto refreshRateConfigs = |
| 1660 | std::make_unique<RefreshRateConfigs>(m60_90DeviceWithDifferentGroups, |
| 1661 | /*currentConfigId=*/HWC_CONFIG_ID_60); |
| 1662 | RefreshRateConfigs::Policy policy; |
| 1663 | policy.defaultMode = refreshRateConfigs->getCurrentPolicy().defaultMode; |
| 1664 | policy.allowGroupSwitching = true; |
| 1665 | ASSERT_GE(refreshRateConfigs->setDisplayManagerPolicy(policy), 0); |
| 1666 | |
| 1667 | refreshRateConfigs->setCurrentModeId(HWC_CONFIG_ID_90); |
| 1668 | |
| 1669 | // Layer with seamlessness=Default can change the mode group if there's a not |
| 1670 | // focused layer with seamlessness=SeamedAndSeamless. This happens for example, |
| 1671 | // when in split screen mode the user switches between the two visible applications. |
| 1672 | auto layers = std::vector<LayerRequirement>{LayerRequirement{.weight = 1.0f}}; |
| 1673 | layers[0].seamlessness = Seamlessness::Default; |
| 1674 | layers[0].desiredRefreshRate = Fps(60.0f); |
| 1675 | layers[0].focused = true; |
| 1676 | layers[0].vote = LayerVoteType::ExplicitDefault; |
| 1677 | layers[0].name = "60Hz ExplicitDefault"; |
| 1678 | |
| 1679 | layers.push_back(LayerRequirement{.weight = 0.7f}); |
Marin Shalamanov | bb65d05 | 2021-03-23 19:21:52 +0100 | [diff] [blame] | 1680 | layers[1].seamlessness = Seamlessness::SeamedAndSeamless; |
| 1681 | layers[1].desiredRefreshRate = Fps(90.0f); |
| 1682 | layers[1].focused = false; |
| 1683 | layers[1].vote = LayerVoteType::ExplicitDefault; |
| 1684 | layers[1].name = "90Hz ExplicitDefault"; |
| 1685 | |
Marin Shalamanov | ae0b535 | 2021-03-24 12:56:08 +0100 | [diff] [blame] | 1686 | ASSERT_EQ(HWC_CONFIG_ID_60, |
Marin Shalamanov | 4608442 | 2020-10-13 12:33:42 +0200 | [diff] [blame] | 1687 | refreshRateConfigs->getBestRefreshRate(layers, {.touch = false, .idle = false}) |
| 1688 | .getModeId()); |
| 1689 | } |
| 1690 | |
| 1691 | TEST_F(RefreshRateConfigsTest, nonSeamlessVotePrefersSeamlessSwitches) { |
| 1692 | auto refreshRateConfigs = |
| 1693 | std::make_unique<RefreshRateConfigs>(m30_60Device, |
| 1694 | /*currentConfigId=*/HWC_CONFIG_ID_60); |
| 1695 | |
| 1696 | // Allow group switching. |
| 1697 | RefreshRateConfigs::Policy policy; |
Marin Shalamanov | a7fe304 | 2021-01-29 21:02:08 +0100 | [diff] [blame] | 1698 | policy.defaultMode = refreshRateConfigs->getCurrentPolicy().defaultMode; |
Marin Shalamanov | 4608442 | 2020-10-13 12:33:42 +0200 | [diff] [blame] | 1699 | policy.allowGroupSwitching = true; |
| 1700 | ASSERT_GE(refreshRateConfigs->setDisplayManagerPolicy(policy), 0); |
| 1701 | |
| 1702 | auto layers = std::vector<LayerRequirement>{LayerRequirement{.weight = 1.0f}}; |
| 1703 | auto& layer = layers[0]; |
| 1704 | layer.vote = LayerVoteType::ExplicitExactOrMultiple; |
Marin Shalamanov | e8a663d | 2020-11-24 17:48:00 +0100 | [diff] [blame] | 1705 | layer.desiredRefreshRate = Fps(60.0f); |
Marin Shalamanov | 53fc11d | 2020-11-20 14:00:13 +0100 | [diff] [blame] | 1706 | layer.seamlessness = Seamlessness::SeamedAndSeamless; |
Marin Shalamanov | 4608442 | 2020-10-13 12:33:42 +0200 | [diff] [blame] | 1707 | layer.name = "60Hz ExplicitExactOrMultiple"; |
| 1708 | layer.focused = true; |
| 1709 | |
| 1710 | ASSERT_EQ(HWC_CONFIG_ID_60, |
| 1711 | refreshRateConfigs->getBestRefreshRate(layers, {.touch = false, .idle = false}) |
Marin Shalamanov | a7fe304 | 2021-01-29 21:02:08 +0100 | [diff] [blame] | 1712 | .getModeId()); |
Marin Shalamanov | 4608442 | 2020-10-13 12:33:42 +0200 | [diff] [blame] | 1713 | |
Marin Shalamanov | a7fe304 | 2021-01-29 21:02:08 +0100 | [diff] [blame] | 1714 | refreshRateConfigs->setCurrentModeId(HWC_CONFIG_ID_120); |
Marin Shalamanov | 4608442 | 2020-10-13 12:33:42 +0200 | [diff] [blame] | 1715 | ASSERT_EQ(HWC_CONFIG_ID_120, |
| 1716 | refreshRateConfigs->getBestRefreshRate(layers, {.touch = false, .idle = false}) |
Marin Shalamanov | a7fe304 | 2021-01-29 21:02:08 +0100 | [diff] [blame] | 1717 | .getModeId()); |
Marin Shalamanov | 4608442 | 2020-10-13 12:33:42 +0200 | [diff] [blame] | 1718 | } |
| 1719 | |
| 1720 | TEST_F(RefreshRateConfigsTest, nonSeamlessExactAndSeamlessMultipleLayers) { |
| 1721 | auto refreshRateConfigs = |
| 1722 | std::make_unique<RefreshRateConfigs>(m25_30_50_60Device, |
| 1723 | /*currentConfigId=*/HWC_CONFIG_ID_60); |
| 1724 | |
| 1725 | // Allow group switching. |
| 1726 | RefreshRateConfigs::Policy policy; |
Marin Shalamanov | a7fe304 | 2021-01-29 21:02:08 +0100 | [diff] [blame] | 1727 | policy.defaultMode = refreshRateConfigs->getCurrentPolicy().defaultMode; |
Marin Shalamanov | 4608442 | 2020-10-13 12:33:42 +0200 | [diff] [blame] | 1728 | policy.allowGroupSwitching = true; |
| 1729 | ASSERT_GE(refreshRateConfigs->setDisplayManagerPolicy(policy), 0); |
| 1730 | |
| 1731 | auto layers = std::vector< |
| 1732 | LayerRequirement>{LayerRequirement{.name = "60Hz ExplicitDefault", |
| 1733 | .vote = LayerVoteType::ExplicitDefault, |
Marin Shalamanov | e8a663d | 2020-11-24 17:48:00 +0100 | [diff] [blame] | 1734 | .desiredRefreshRate = Fps(60.0f), |
Marin Shalamanov | 53fc11d | 2020-11-20 14:00:13 +0100 | [diff] [blame] | 1735 | .seamlessness = Seamlessness::SeamedAndSeamless, |
Marin Shalamanov | 4608442 | 2020-10-13 12:33:42 +0200 | [diff] [blame] | 1736 | .weight = 0.5f, |
| 1737 | .focused = false}, |
| 1738 | LayerRequirement{.name = "25Hz ExplicitExactOrMultiple", |
| 1739 | .vote = LayerVoteType::ExplicitExactOrMultiple, |
Marin Shalamanov | e8a663d | 2020-11-24 17:48:00 +0100 | [diff] [blame] | 1740 | .desiredRefreshRate = Fps(25.0f), |
Marin Shalamanov | 53fc11d | 2020-11-20 14:00:13 +0100 | [diff] [blame] | 1741 | .seamlessness = Seamlessness::OnlySeamless, |
Marin Shalamanov | 4608442 | 2020-10-13 12:33:42 +0200 | [diff] [blame] | 1742 | .weight = 1.0f, |
| 1743 | .focused = true}}; |
Marin Shalamanov | 4608442 | 2020-10-13 12:33:42 +0200 | [diff] [blame] | 1744 | |
| 1745 | ASSERT_EQ(HWC_CONFIG_ID_50, |
| 1746 | refreshRateConfigs->getBestRefreshRate(layers, {.touch = false, .idle = false}) |
Marin Shalamanov | a7fe304 | 2021-01-29 21:02:08 +0100 | [diff] [blame] | 1747 | .getModeId()); |
Marin Shalamanov | 4608442 | 2020-10-13 12:33:42 +0200 | [diff] [blame] | 1748 | |
Marin Shalamanov | e7aadcc | 2021-04-09 18:58:38 +0200 | [diff] [blame] | 1749 | auto& seamedLayer = layers[0]; |
Marin Shalamanov | e8a663d | 2020-11-24 17:48:00 +0100 | [diff] [blame] | 1750 | seamedLayer.name = "30Hz ExplicitDefault", seamedLayer.desiredRefreshRate = Fps(30.0f); |
Marin Shalamanov | a7fe304 | 2021-01-29 21:02:08 +0100 | [diff] [blame] | 1751 | refreshRateConfigs->setCurrentModeId(HWC_CONFIG_ID_30); |
Marin Shalamanov | 4608442 | 2020-10-13 12:33:42 +0200 | [diff] [blame] | 1752 | |
| 1753 | ASSERT_EQ(HWC_CONFIG_ID_25, |
| 1754 | refreshRateConfigs->getBestRefreshRate(layers, {.touch = false, .idle = false}) |
Marin Shalamanov | a7fe304 | 2021-01-29 21:02:08 +0100 | [diff] [blame] | 1755 | .getModeId()); |
Steven Thomas | d407190 | 2020-03-24 16:02:53 -0700 | [diff] [blame] | 1756 | } |
| 1757 | |
Marin Shalamanov | e7aadcc | 2021-04-09 18:58:38 +0200 | [diff] [blame] | 1758 | TEST_F(RefreshRateConfigsTest, minLayersDontTrigerSeamedSwitch) { |
| 1759 | auto refreshRateConfigs = |
| 1760 | std::make_unique<RefreshRateConfigs>(m60_90DeviceWithDifferentGroups, |
| 1761 | /*currentConfigId=*/HWC_CONFIG_ID_90); |
| 1762 | |
| 1763 | // Allow group switching. |
| 1764 | RefreshRateConfigs::Policy policy; |
| 1765 | policy.defaultMode = refreshRateConfigs->getCurrentPolicy().defaultMode; |
| 1766 | policy.allowGroupSwitching = true; |
| 1767 | ASSERT_GE(refreshRateConfigs->setDisplayManagerPolicy(policy), 0); |
| 1768 | |
| 1769 | auto layers = std::vector<LayerRequirement>{LayerRequirement{.name = "Min", |
| 1770 | .vote = LayerVoteType::Min, |
| 1771 | .weight = 1.f, |
| 1772 | .focused = true}}; |
| 1773 | |
| 1774 | ASSERT_EQ(HWC_CONFIG_ID_90, |
| 1775 | refreshRateConfigs->getBestRefreshRate(layers, {.touch = false, .idle = false}) |
| 1776 | .getModeId()); |
| 1777 | } |
| 1778 | |
Steven Thomas | f734df4 | 2020-04-13 21:09:28 -0700 | [diff] [blame] | 1779 | TEST_F(RefreshRateConfigsTest, primaryVsAppRequestPolicy) { |
| 1780 | auto refreshRateConfigs = |
Alec Mouri | 11232a2 | 2020-05-14 18:06:25 -0700 | [diff] [blame] | 1781 | std::make_unique<RefreshRateConfigs>(m30_60_90Device, |
Steven Thomas | f734df4 | 2020-04-13 21:09:28 -0700 | [diff] [blame] | 1782 | /*currentConfigId=*/HWC_CONFIG_ID_60); |
| 1783 | |
| 1784 | auto layers = std::vector<LayerRequirement>{LayerRequirement{.weight = 1.0f}}; |
| 1785 | layers[0].name = "Test layer"; |
| 1786 | |
Steven Thomas | bb37432 | 2020-04-28 22:47:16 -0700 | [diff] [blame] | 1787 | // Return the config ID from calling getBestRefreshRate() for a single layer with the |
Steven Thomas | f734df4 | 2020-04-13 21:09:28 -0700 | [diff] [blame] | 1788 | // given voteType and fps. |
Marin Shalamanov | e8a663d | 2020-11-24 17:48:00 +0100 | [diff] [blame] | 1789 | auto getFrameRate = [&](LayerVoteType voteType, Fps fps, bool touchActive = false, |
Marin Shalamanov | 23c4420 | 2020-12-22 19:09:20 +0100 | [diff] [blame] | 1790 | bool focused = true) -> DisplayModeId { |
Steven Thomas | f734df4 | 2020-04-13 21:09:28 -0700 | [diff] [blame] | 1791 | layers[0].vote = voteType; |
| 1792 | layers[0].desiredRefreshRate = fps; |
Ady Abraham | aae5ed5 | 2020-06-26 09:32:43 -0700 | [diff] [blame] | 1793 | layers[0].focused = focused; |
Ady Abraham | dfd6216 | 2020-06-10 16:11:56 -0700 | [diff] [blame] | 1794 | return refreshRateConfigs->getBestRefreshRate(layers, {.touch = touchActive, .idle = false}) |
Marin Shalamanov | a7fe304 | 2021-01-29 21:02:08 +0100 | [diff] [blame] | 1795 | .getModeId(); |
Steven Thomas | f734df4 | 2020-04-13 21:09:28 -0700 | [diff] [blame] | 1796 | }; |
| 1797 | |
| 1798 | ASSERT_GE(refreshRateConfigs->setDisplayManagerPolicy( |
Marin Shalamanov | e8a663d | 2020-11-24 17:48:00 +0100 | [diff] [blame] | 1799 | {HWC_CONFIG_ID_60, {Fps(30.f), Fps(60.f)}, {Fps(30.f), Fps(90.f)}}), |
Steven Thomas | f734df4 | 2020-04-13 21:09:28 -0700 | [diff] [blame] | 1800 | 0); |
Steven Thomas | f734df4 | 2020-04-13 21:09:28 -0700 | [diff] [blame] | 1801 | EXPECT_EQ(HWC_CONFIG_ID_60, |
Ady Abraham | dfd6216 | 2020-06-10 16:11:56 -0700 | [diff] [blame] | 1802 | refreshRateConfigs->getBestRefreshRate({}, {.touch = false, .idle = false}) |
Marin Shalamanov | a7fe304 | 2021-01-29 21:02:08 +0100 | [diff] [blame] | 1803 | .getModeId()); |
Marin Shalamanov | e8a663d | 2020-11-24 17:48:00 +0100 | [diff] [blame] | 1804 | EXPECT_EQ(HWC_CONFIG_ID_60, getFrameRate(LayerVoteType::NoVote, Fps(90.f))); |
| 1805 | EXPECT_EQ(HWC_CONFIG_ID_30, getFrameRate(LayerVoteType::Min, Fps(90.f))); |
| 1806 | EXPECT_EQ(HWC_CONFIG_ID_60, getFrameRate(LayerVoteType::Max, Fps(90.f))); |
| 1807 | EXPECT_EQ(HWC_CONFIG_ID_60, getFrameRate(LayerVoteType::Heuristic, Fps(90.f))); |
| 1808 | EXPECT_EQ(HWC_CONFIG_ID_90, getFrameRate(LayerVoteType::ExplicitDefault, Fps(90.f))); |
| 1809 | EXPECT_EQ(HWC_CONFIG_ID_60, getFrameRate(LayerVoteType::ExplicitExactOrMultiple, Fps(90.f))); |
Steven Thomas | f734df4 | 2020-04-13 21:09:28 -0700 | [diff] [blame] | 1810 | |
Ady Abraham | aae5ed5 | 2020-06-26 09:32:43 -0700 | [diff] [blame] | 1811 | // Layers not focused are not allowed to override primary config |
| 1812 | EXPECT_EQ(HWC_CONFIG_ID_60, |
Marin Shalamanov | e8a663d | 2020-11-24 17:48:00 +0100 | [diff] [blame] | 1813 | getFrameRate(LayerVoteType::ExplicitDefault, Fps(90.f), /*touch=*/false, |
Ady Abraham | aae5ed5 | 2020-06-26 09:32:43 -0700 | [diff] [blame] | 1814 | /*focused=*/false)); |
| 1815 | EXPECT_EQ(HWC_CONFIG_ID_60, |
Marin Shalamanov | e8a663d | 2020-11-24 17:48:00 +0100 | [diff] [blame] | 1816 | getFrameRate(LayerVoteType::ExplicitExactOrMultiple, Fps(90.f), /*touch=*/false, |
Ady Abraham | aae5ed5 | 2020-06-26 09:32:43 -0700 | [diff] [blame] | 1817 | /*focused=*/false)); |
| 1818 | |
Steven Thomas | f734df4 | 2020-04-13 21:09:28 -0700 | [diff] [blame] | 1819 | // Touch boost should be restricted to the primary range. |
Marin Shalamanov | e8a663d | 2020-11-24 17:48:00 +0100 | [diff] [blame] | 1820 | EXPECT_EQ(HWC_CONFIG_ID_60, getFrameRate(LayerVoteType::Max, Fps(90.f), /*touch=*/true)); |
Steven Thomas | f734df4 | 2020-04-13 21:09:28 -0700 | [diff] [blame] | 1821 | // When we're higher than the primary range max due to a layer frame rate setting, touch boost |
| 1822 | // shouldn't drag us back down to the primary range max. |
Marin Shalamanov | e8a663d | 2020-11-24 17:48:00 +0100 | [diff] [blame] | 1823 | EXPECT_EQ(HWC_CONFIG_ID_90, |
| 1824 | getFrameRate(LayerVoteType::ExplicitDefault, Fps(90.f), /*touch=*/true)); |
Ady Abraham | 20c029c | 2020-07-06 12:58:05 -0700 | [diff] [blame] | 1825 | EXPECT_EQ(HWC_CONFIG_ID_60, |
Marin Shalamanov | e8a663d | 2020-11-24 17:48:00 +0100 | [diff] [blame] | 1826 | getFrameRate(LayerVoteType::ExplicitExactOrMultiple, Fps(90.f), /*touch=*/true)); |
Steven Thomas | f734df4 | 2020-04-13 21:09:28 -0700 | [diff] [blame] | 1827 | |
| 1828 | ASSERT_GE(refreshRateConfigs->setDisplayManagerPolicy( |
Marin Shalamanov | e8a663d | 2020-11-24 17:48:00 +0100 | [diff] [blame] | 1829 | {HWC_CONFIG_ID_60, {Fps(60.f), Fps(60.f)}, {Fps(60.f), Fps(60.f)}}), |
Steven Thomas | f734df4 | 2020-04-13 21:09:28 -0700 | [diff] [blame] | 1830 | 0); |
Marin Shalamanov | e8a663d | 2020-11-24 17:48:00 +0100 | [diff] [blame] | 1831 | EXPECT_EQ(HWC_CONFIG_ID_60, getFrameRate(LayerVoteType::NoVote, Fps(90.f))); |
| 1832 | EXPECT_EQ(HWC_CONFIG_ID_60, getFrameRate(LayerVoteType::Min, Fps(90.f))); |
| 1833 | EXPECT_EQ(HWC_CONFIG_ID_60, getFrameRate(LayerVoteType::Max, Fps(90.f))); |
| 1834 | EXPECT_EQ(HWC_CONFIG_ID_60, getFrameRate(LayerVoteType::Heuristic, Fps(90.f))); |
| 1835 | EXPECT_EQ(HWC_CONFIG_ID_60, getFrameRate(LayerVoteType::ExplicitDefault, Fps(90.f))); |
| 1836 | EXPECT_EQ(HWC_CONFIG_ID_60, getFrameRate(LayerVoteType::ExplicitExactOrMultiple, Fps(90.f))); |
Steven Thomas | f734df4 | 2020-04-13 21:09:28 -0700 | [diff] [blame] | 1837 | } |
| 1838 | |
Steven Thomas | bb37432 | 2020-04-28 22:47:16 -0700 | [diff] [blame] | 1839 | TEST_F(RefreshRateConfigsTest, idle) { |
| 1840 | auto refreshRateConfigs = |
| 1841 | std::make_unique<RefreshRateConfigs>(m60_90Device, |
| 1842 | /*currentConfigId=*/HWC_CONFIG_ID_60); |
| 1843 | |
| 1844 | auto layers = std::vector<LayerRequirement>{LayerRequirement{.weight = 1.0f}}; |
| 1845 | layers[0].name = "Test layer"; |
| 1846 | |
Marin Shalamanov | 23c4420 | 2020-12-22 19:09:20 +0100 | [diff] [blame] | 1847 | const auto getIdleFrameRate = [&](LayerVoteType voteType, bool touchActive) -> DisplayModeId { |
Steven Thomas | bb37432 | 2020-04-28 22:47:16 -0700 | [diff] [blame] | 1848 | layers[0].vote = voteType; |
Marin Shalamanov | e8a663d | 2020-11-24 17:48:00 +0100 | [diff] [blame] | 1849 | layers[0].desiredRefreshRate = Fps(90.f); |
Ady Abraham | dfd6216 | 2020-06-10 16:11:56 -0700 | [diff] [blame] | 1850 | RefreshRateConfigs::GlobalSignals consideredSignals; |
| 1851 | const auto configId = |
| 1852 | refreshRateConfigs |
| 1853 | ->getBestRefreshRate(layers, {.touch = touchActive, .idle = true}, |
| 1854 | &consideredSignals) |
Marin Shalamanov | a7fe304 | 2021-01-29 21:02:08 +0100 | [diff] [blame] | 1855 | .getModeId(); |
Ady Abraham | dfd6216 | 2020-06-10 16:11:56 -0700 | [diff] [blame] | 1856 | // Refresh rate will be chosen by either touch state or idle state |
| 1857 | EXPECT_EQ(!touchActive, consideredSignals.idle); |
| 1858 | return configId; |
Steven Thomas | bb37432 | 2020-04-28 22:47:16 -0700 | [diff] [blame] | 1859 | }; |
| 1860 | |
| 1861 | ASSERT_GE(refreshRateConfigs->setDisplayManagerPolicy( |
Marin Shalamanov | e8a663d | 2020-11-24 17:48:00 +0100 | [diff] [blame] | 1862 | {HWC_CONFIG_ID_60, {Fps(60.f), Fps(90.f)}, {Fps(60.f), Fps(90.f)}}), |
Steven Thomas | bb37432 | 2020-04-28 22:47:16 -0700 | [diff] [blame] | 1863 | 0); |
| 1864 | |
| 1865 | // Idle should be lower priority than touch boost. |
Ady Abraham | dfd6216 | 2020-06-10 16:11:56 -0700 | [diff] [blame] | 1866 | EXPECT_EQ(HWC_CONFIG_ID_90, getIdleFrameRate(LayerVoteType::NoVote, /*touchActive=*/true)); |
| 1867 | EXPECT_EQ(HWC_CONFIG_ID_90, getIdleFrameRate(LayerVoteType::Min, /*touchActive=*/true)); |
| 1868 | EXPECT_EQ(HWC_CONFIG_ID_90, getIdleFrameRate(LayerVoteType::Max, /*touchActive=*/true)); |
| 1869 | EXPECT_EQ(HWC_CONFIG_ID_90, getIdleFrameRate(LayerVoteType::Heuristic, /*touchActive=*/true)); |
| 1870 | EXPECT_EQ(HWC_CONFIG_ID_90, |
| 1871 | getIdleFrameRate(LayerVoteType::ExplicitDefault, /*touchActive=*/true)); |
| 1872 | EXPECT_EQ(HWC_CONFIG_ID_90, |
| 1873 | getIdleFrameRate(LayerVoteType::ExplicitExactOrMultiple, /*touchActive=*/true)); |
Steven Thomas | bb37432 | 2020-04-28 22:47:16 -0700 | [diff] [blame] | 1874 | |
| 1875 | // With no layers, idle should still be lower priority than touch boost. |
Steven Thomas | bb37432 | 2020-04-28 22:47:16 -0700 | [diff] [blame] | 1876 | EXPECT_EQ(HWC_CONFIG_ID_90, |
Ady Abraham | dfd6216 | 2020-06-10 16:11:56 -0700 | [diff] [blame] | 1877 | refreshRateConfigs->getBestRefreshRate({}, {.touch = true, .idle = true}) |
Marin Shalamanov | a7fe304 | 2021-01-29 21:02:08 +0100 | [diff] [blame] | 1878 | .getModeId()); |
Steven Thomas | bb37432 | 2020-04-28 22:47:16 -0700 | [diff] [blame] | 1879 | |
| 1880 | // Idle should be higher precedence than other layer frame rate considerations. |
Marin Shalamanov | a7fe304 | 2021-01-29 21:02:08 +0100 | [diff] [blame] | 1881 | refreshRateConfigs->setCurrentModeId(HWC_CONFIG_ID_90); |
Ady Abraham | dfd6216 | 2020-06-10 16:11:56 -0700 | [diff] [blame] | 1882 | EXPECT_EQ(HWC_CONFIG_ID_60, getIdleFrameRate(LayerVoteType::NoVote, /*touchActive=*/false)); |
| 1883 | EXPECT_EQ(HWC_CONFIG_ID_60, getIdleFrameRate(LayerVoteType::Min, /*touchActive=*/false)); |
| 1884 | EXPECT_EQ(HWC_CONFIG_ID_60, getIdleFrameRate(LayerVoteType::Max, /*touchActive=*/false)); |
| 1885 | EXPECT_EQ(HWC_CONFIG_ID_60, getIdleFrameRate(LayerVoteType::Heuristic, /*touchActive=*/false)); |
| 1886 | EXPECT_EQ(HWC_CONFIG_ID_60, |
| 1887 | getIdleFrameRate(LayerVoteType::ExplicitDefault, /*touchActive=*/false)); |
| 1888 | EXPECT_EQ(HWC_CONFIG_ID_60, |
| 1889 | getIdleFrameRate(LayerVoteType::ExplicitExactOrMultiple, /*touchActive=*/false)); |
Steven Thomas | bb37432 | 2020-04-28 22:47:16 -0700 | [diff] [blame] | 1890 | |
| 1891 | // Idle should be applied rather than the current config when there are no layers. |
| 1892 | EXPECT_EQ(HWC_CONFIG_ID_60, |
Ady Abraham | dfd6216 | 2020-06-10 16:11:56 -0700 | [diff] [blame] | 1893 | refreshRateConfigs->getBestRefreshRate({}, {.touch = false, .idle = true}) |
Marin Shalamanov | a7fe304 | 2021-01-29 21:02:08 +0100 | [diff] [blame] | 1894 | .getModeId()); |
Steven Thomas | bb37432 | 2020-04-28 22:47:16 -0700 | [diff] [blame] | 1895 | } |
| 1896 | |
Ady Abraham | b1b9d41 | 2020-06-01 19:53:52 -0700 | [diff] [blame] | 1897 | TEST_F(RefreshRateConfigsTest, findClosestKnownFrameRate) { |
| 1898 | auto refreshRateConfigs = |
| 1899 | std::make_unique<RefreshRateConfigs>(m60_90Device, |
| 1900 | /*currentConfigId=*/HWC_CONFIG_ID_60); |
| 1901 | |
| 1902 | for (float fps = 1.0f; fps <= 120.0f; fps += 0.1f) { |
Marin Shalamanov | e8a663d | 2020-11-24 17:48:00 +0100 | [diff] [blame] | 1903 | const auto knownFrameRate = findClosestKnownFrameRate(*refreshRateConfigs, Fps(fps)); |
| 1904 | Fps expectedFrameRate; |
Ady Abraham | b1b9d41 | 2020-06-01 19:53:52 -0700 | [diff] [blame] | 1905 | if (fps < 26.91f) { |
Marin Shalamanov | e8a663d | 2020-11-24 17:48:00 +0100 | [diff] [blame] | 1906 | expectedFrameRate = Fps(24.0f); |
Ady Abraham | b1b9d41 | 2020-06-01 19:53:52 -0700 | [diff] [blame] | 1907 | } else if (fps < 37.51f) { |
Marin Shalamanov | e8a663d | 2020-11-24 17:48:00 +0100 | [diff] [blame] | 1908 | expectedFrameRate = Fps(30.0f); |
Ady Abraham | b1b9d41 | 2020-06-01 19:53:52 -0700 | [diff] [blame] | 1909 | } else if (fps < 52.51f) { |
Marin Shalamanov | e8a663d | 2020-11-24 17:48:00 +0100 | [diff] [blame] | 1910 | expectedFrameRate = Fps(45.0f); |
Ady Abraham | b1b9d41 | 2020-06-01 19:53:52 -0700 | [diff] [blame] | 1911 | } else if (fps < 66.01f) { |
Marin Shalamanov | e8a663d | 2020-11-24 17:48:00 +0100 | [diff] [blame] | 1912 | expectedFrameRate = Fps(60.0f); |
Ady Abraham | b1b9d41 | 2020-06-01 19:53:52 -0700 | [diff] [blame] | 1913 | } else if (fps < 81.01f) { |
Marin Shalamanov | e8a663d | 2020-11-24 17:48:00 +0100 | [diff] [blame] | 1914 | expectedFrameRate = Fps(72.0f); |
Ady Abraham | b1b9d41 | 2020-06-01 19:53:52 -0700 | [diff] [blame] | 1915 | } else { |
Marin Shalamanov | e8a663d | 2020-11-24 17:48:00 +0100 | [diff] [blame] | 1916 | expectedFrameRate = Fps(90.0f); |
Ady Abraham | b1b9d41 | 2020-06-01 19:53:52 -0700 | [diff] [blame] | 1917 | } |
Marin Shalamanov | e8a663d | 2020-11-24 17:48:00 +0100 | [diff] [blame] | 1918 | EXPECT_TRUE(expectedFrameRate.equalsWithMargin(knownFrameRate)) |
Ady Abraham | b1b9d41 | 2020-06-01 19:53:52 -0700 | [diff] [blame] | 1919 | << "findClosestKnownFrameRate(" << fps << ") = " << knownFrameRate; |
| 1920 | } |
| 1921 | } |
| 1922 | |
| 1923 | TEST_F(RefreshRateConfigsTest, getBestRefreshRate_KnownFrameRate) { |
Ady Abraham | b1b9d41 | 2020-06-01 19:53:52 -0700 | [diff] [blame] | 1924 | auto refreshRateConfigs = |
| 1925 | std::make_unique<RefreshRateConfigs>(m60_90Device, |
| 1926 | /*currentConfigId=*/HWC_CONFIG_ID_60); |
| 1927 | |
| 1928 | struct ExpectedRate { |
Marin Shalamanov | e8a663d | 2020-11-24 17:48:00 +0100 | [diff] [blame] | 1929 | Fps rate; |
Ady Abraham | b1b9d41 | 2020-06-01 19:53:52 -0700 | [diff] [blame] | 1930 | const RefreshRate& expected; |
| 1931 | }; |
| 1932 | |
| 1933 | /* clang-format off */ |
| 1934 | std::vector<ExpectedRate> knownFrameRatesExpectations = { |
Marin Shalamanov | e8a663d | 2020-11-24 17:48:00 +0100 | [diff] [blame] | 1935 | {Fps(24.0f), mExpected60Config}, |
| 1936 | {Fps(30.0f), mExpected60Config}, |
| 1937 | {Fps(45.0f), mExpected90Config}, |
| 1938 | {Fps(60.0f), mExpected60Config}, |
| 1939 | {Fps(72.0f), mExpected90Config}, |
| 1940 | {Fps(90.0f), mExpected90Config}, |
Ady Abraham | b1b9d41 | 2020-06-01 19:53:52 -0700 | [diff] [blame] | 1941 | }; |
| 1942 | /* clang-format on */ |
| 1943 | |
| 1944 | // Make sure the test tests all the known frame rate |
| 1945 | const auto knownFrameRateList = getKnownFrameRate(*refreshRateConfigs); |
Marin Shalamanov | e8a663d | 2020-11-24 17:48:00 +0100 | [diff] [blame] | 1946 | const auto equal = |
| 1947 | std::equal(knownFrameRateList.begin(), knownFrameRateList.end(), |
| 1948 | knownFrameRatesExpectations.begin(), |
| 1949 | [](Fps a, const ExpectedRate& b) { return a.equalsWithMargin(b.rate); }); |
Ady Abraham | b1b9d41 | 2020-06-01 19:53:52 -0700 | [diff] [blame] | 1950 | EXPECT_TRUE(equal); |
| 1951 | |
| 1952 | auto layers = std::vector<LayerRequirement>{LayerRequirement{.weight = 1.0f}}; |
| 1953 | auto& layer = layers[0]; |
| 1954 | layer.vote = LayerVoteType::Heuristic; |
| 1955 | for (const auto& expectedRate : knownFrameRatesExpectations) { |
| 1956 | layer.desiredRefreshRate = expectedRate.rate; |
Ady Abraham | dfd6216 | 2020-06-10 16:11:56 -0700 | [diff] [blame] | 1957 | const auto& refreshRate = |
| 1958 | refreshRateConfigs->getBestRefreshRate(layers, {.touch = false, .idle = false}); |
Ady Abraham | b1b9d41 | 2020-06-01 19:53:52 -0700 | [diff] [blame] | 1959 | EXPECT_EQ(expectedRate.expected, refreshRate); |
| 1960 | } |
| 1961 | } |
| 1962 | |
Ady Abraham | dd5bfa9 | 2021-01-07 17:56:08 -0800 | [diff] [blame] | 1963 | TEST_F(RefreshRateConfigsTest, getBestRefreshRate_ExplicitExact) { |
| 1964 | auto refreshRateConfigs = |
| 1965 | std::make_unique<RefreshRateConfigs>(m30_60_72_90_120Device, |
| 1966 | /*currentConfigId=*/HWC_CONFIG_ID_60); |
| 1967 | |
| 1968 | auto layers = std::vector<LayerRequirement>{LayerRequirement{.weight = 1.0f}, |
| 1969 | LayerRequirement{.weight = 0.5f}}; |
| 1970 | auto& explicitExactLayer = layers[0]; |
| 1971 | auto& explicitExactOrMultipleLayer = layers[1]; |
| 1972 | |
| 1973 | explicitExactOrMultipleLayer.vote = LayerVoteType::ExplicitExactOrMultiple; |
| 1974 | explicitExactOrMultipleLayer.name = "ExplicitExactOrMultiple"; |
| 1975 | explicitExactOrMultipleLayer.desiredRefreshRate = Fps(60); |
| 1976 | |
| 1977 | explicitExactLayer.vote = LayerVoteType::ExplicitExact; |
| 1978 | explicitExactLayer.name = "ExplicitExact"; |
| 1979 | explicitExactLayer.desiredRefreshRate = Fps(30); |
| 1980 | |
| 1981 | EXPECT_EQ(mExpected30Config, |
| 1982 | refreshRateConfigs->getBestRefreshRate(layers, {.touch = false, .idle = false})); |
| 1983 | EXPECT_EQ(mExpected30Config, |
| 1984 | refreshRateConfigs->getBestRefreshRate(layers, {.touch = true, .idle = false})); |
| 1985 | |
| 1986 | explicitExactOrMultipleLayer.desiredRefreshRate = Fps(120); |
| 1987 | explicitExactLayer.desiredRefreshRate = Fps(60); |
| 1988 | EXPECT_EQ(mExpected60Config, |
| 1989 | refreshRateConfigs->getBestRefreshRate(layers, {.touch = false, .idle = false})); |
| 1990 | |
| 1991 | explicitExactLayer.desiredRefreshRate = Fps(72); |
| 1992 | EXPECT_EQ(mExpected72Config, |
| 1993 | refreshRateConfigs->getBestRefreshRate(layers, {.touch = false, .idle = false})); |
| 1994 | |
| 1995 | explicitExactLayer.desiredRefreshRate = Fps(90); |
| 1996 | EXPECT_EQ(mExpected90Config, |
| 1997 | refreshRateConfigs->getBestRefreshRate(layers, {.touch = false, .idle = false})); |
| 1998 | |
| 1999 | explicitExactLayer.desiredRefreshRate = Fps(120); |
| 2000 | EXPECT_EQ(mExpected120Config, |
| 2001 | refreshRateConfigs->getBestRefreshRate(layers, {.touch = false, .idle = false})); |
| 2002 | } |
| 2003 | |
| 2004 | TEST_F(RefreshRateConfigsTest, getBestRefreshRate_ExplicitExactEnableFrameRateOverride) { |
rnlee | 3bd61066 | 2021-06-23 16:27:57 -0700 | [diff] [blame] | 2005 | RefreshRateConfigs::Config config = {.enableFrameRateOverride = true}; |
Ady Abraham | dd5bfa9 | 2021-01-07 17:56:08 -0800 | [diff] [blame] | 2006 | auto refreshRateConfigs = |
| 2007 | std::make_unique<RefreshRateConfigs>(m30_60_72_90_120Device, |
rnlee | 3bd61066 | 2021-06-23 16:27:57 -0700 | [diff] [blame] | 2008 | /*currentConfigId=*/HWC_CONFIG_ID_60, config); |
Ady Abraham | dd5bfa9 | 2021-01-07 17:56:08 -0800 | [diff] [blame] | 2009 | |
| 2010 | auto layers = std::vector<LayerRequirement>{LayerRequirement{.weight = 1.0f}, |
| 2011 | LayerRequirement{.weight = 0.5f}}; |
| 2012 | auto& explicitExactLayer = layers[0]; |
| 2013 | auto& explicitExactOrMultipleLayer = layers[1]; |
| 2014 | |
| 2015 | explicitExactOrMultipleLayer.vote = LayerVoteType::ExplicitExactOrMultiple; |
| 2016 | explicitExactOrMultipleLayer.name = "ExplicitExactOrMultiple"; |
| 2017 | explicitExactOrMultipleLayer.desiredRefreshRate = Fps(60); |
| 2018 | |
| 2019 | explicitExactLayer.vote = LayerVoteType::ExplicitExact; |
| 2020 | explicitExactLayer.name = "ExplicitExact"; |
| 2021 | explicitExactLayer.desiredRefreshRate = Fps(30); |
| 2022 | |
| 2023 | EXPECT_EQ(mExpected60Config, |
| 2024 | refreshRateConfigs->getBestRefreshRate(layers, {.touch = false, .idle = false})); |
| 2025 | EXPECT_EQ(mExpected120Config, |
| 2026 | refreshRateConfigs->getBestRefreshRate(layers, {.touch = true, .idle = false})); |
| 2027 | |
| 2028 | explicitExactOrMultipleLayer.desiredRefreshRate = Fps(120); |
| 2029 | explicitExactLayer.desiredRefreshRate = Fps(60); |
| 2030 | EXPECT_EQ(mExpected120Config, |
| 2031 | refreshRateConfigs->getBestRefreshRate(layers, {.touch = false, .idle = false})); |
| 2032 | |
| 2033 | explicitExactLayer.desiredRefreshRate = Fps(72); |
| 2034 | EXPECT_EQ(mExpected72Config, |
| 2035 | refreshRateConfigs->getBestRefreshRate(layers, {.touch = false, .idle = false})); |
| 2036 | |
| 2037 | explicitExactLayer.desiredRefreshRate = Fps(90); |
| 2038 | EXPECT_EQ(mExpected90Config, |
| 2039 | refreshRateConfigs->getBestRefreshRate(layers, {.touch = false, .idle = false})); |
| 2040 | |
| 2041 | explicitExactLayer.desiredRefreshRate = Fps(120); |
| 2042 | EXPECT_EQ(mExpected120Config, |
| 2043 | refreshRateConfigs->getBestRefreshRate(layers, {.touch = false, .idle = false})); |
| 2044 | } |
| 2045 | |
Marin Shalamanov | 4c7831e | 2021-06-08 20:44:06 +0200 | [diff] [blame] | 2046 | TEST_F(RefreshRateConfigsTest, getBestRefreshRate_ReadsCached) { |
| 2047 | using GlobalSignals = RefreshRateConfigs::GlobalSignals; |
| 2048 | |
| 2049 | auto refreshRateConfigs = |
| 2050 | std::make_unique<RefreshRateConfigs>(m30_60_72_90_120Device, |
| 2051 | /*currentConfigId=*/HWC_CONFIG_ID_60); |
| 2052 | |
| 2053 | setLastBestRefreshRateInvocation(*refreshRateConfigs, |
| 2054 | GetBestRefreshRateInvocation{.layerRequirements = std::vector< |
| 2055 | LayerRequirement>(), |
| 2056 | .globalSignals = {.touch = true, |
| 2057 | .idle = true}, |
| 2058 | .outSignalsConsidered = |
| 2059 | {.touch = true, |
| 2060 | .idle = false}, |
| 2061 | .resultingBestRefreshRate = |
| 2062 | createRefreshRate( |
| 2063 | mConfig90)}); |
| 2064 | |
| 2065 | EXPECT_EQ(createRefreshRate(mConfig90), |
| 2066 | refreshRateConfigs->getBestRefreshRate(std::vector<LayerRequirement>(), |
| 2067 | {.touch = true, .idle = true})); |
| 2068 | |
| 2069 | const GlobalSignals cachedSignalsConsidered{.touch = true, .idle = false}; |
| 2070 | setLastBestRefreshRateInvocation(*refreshRateConfigs, |
| 2071 | GetBestRefreshRateInvocation{.layerRequirements = std::vector< |
| 2072 | LayerRequirement>(), |
| 2073 | .globalSignals = {.touch = true, |
| 2074 | .idle = true}, |
| 2075 | .outSignalsConsidered = |
| 2076 | cachedSignalsConsidered, |
| 2077 | .resultingBestRefreshRate = |
| 2078 | createRefreshRate( |
| 2079 | mConfig30)}); |
| 2080 | |
| 2081 | GlobalSignals signalsConsidered; |
| 2082 | EXPECT_EQ(createRefreshRate(mConfig30), |
| 2083 | refreshRateConfigs->getBestRefreshRate(std::vector<LayerRequirement>(), |
| 2084 | {.touch = true, .idle = true}, |
| 2085 | &signalsConsidered)); |
| 2086 | |
| 2087 | EXPECT_EQ(cachedSignalsConsidered, signalsConsidered); |
| 2088 | } |
| 2089 | |
| 2090 | TEST_F(RefreshRateConfigsTest, getBestRefreshRate_WritesCache) { |
| 2091 | using GlobalSignals = RefreshRateConfigs::GlobalSignals; |
| 2092 | |
| 2093 | auto refreshRateConfigs = |
| 2094 | std::make_unique<RefreshRateConfigs>(m30_60_72_90_120Device, |
| 2095 | /*currentConfigId=*/HWC_CONFIG_ID_60); |
| 2096 | ASSERT_FALSE(getLastBestRefreshRateInvocation(*refreshRateConfigs).has_value()); |
| 2097 | |
| 2098 | GlobalSignals globalSignals{.touch = true, .idle = true}; |
| 2099 | auto layers = std::vector<LayerRequirement>{LayerRequirement{.weight = 1.0f}, |
| 2100 | LayerRequirement{.weight = 0.5f}}; |
| 2101 | const auto lastResult = |
| 2102 | refreshRateConfigs->getBestRefreshRate(layers, globalSignals, |
| 2103 | /* outSignalsConsidered */ nullptr); |
| 2104 | |
| 2105 | const auto lastInvocation = getLastBestRefreshRateInvocation(*refreshRateConfigs); |
| 2106 | |
| 2107 | ASSERT_TRUE(lastInvocation.has_value()); |
| 2108 | ASSERT_EQ(layers, lastInvocation->layerRequirements); |
| 2109 | ASSERT_EQ(globalSignals, lastInvocation->globalSignals); |
| 2110 | ASSERT_EQ(lastResult, lastInvocation->resultingBestRefreshRate); |
| 2111 | |
| 2112 | // outSignalsConsidered needs to be populated even tho earlier we gave nullptr |
| 2113 | // to getBestRefreshRate() |
| 2114 | GlobalSignals detaultSignals; |
| 2115 | ASSERT_FALSE(detaultSignals == lastInvocation->outSignalsConsidered); |
| 2116 | } |
| 2117 | |
Ady Abraham | 5e4e983 | 2021-06-14 13:40:56 -0700 | [diff] [blame] | 2118 | TEST_F(RefreshRateConfigsTest, getBestRefreshRate_ExplicitExactTouchBoost) { |
rnlee | 3bd61066 | 2021-06-23 16:27:57 -0700 | [diff] [blame] | 2119 | RefreshRateConfigs::Config config = {.enableFrameRateOverride = true}; |
Ady Abraham | 5e4e983 | 2021-06-14 13:40:56 -0700 | [diff] [blame] | 2120 | auto refreshRateConfigs = |
| 2121 | std::make_unique<RefreshRateConfigs>(m60_120Device, |
rnlee | 3bd61066 | 2021-06-23 16:27:57 -0700 | [diff] [blame] | 2122 | /*currentConfigId=*/HWC_CONFIG_ID_60, config); |
Ady Abraham | 5e4e983 | 2021-06-14 13:40:56 -0700 | [diff] [blame] | 2123 | |
| 2124 | auto layers = std::vector<LayerRequirement>{LayerRequirement{.weight = 1.0f}, |
| 2125 | LayerRequirement{.weight = 0.5f}}; |
| 2126 | auto& explicitExactLayer = layers[0]; |
| 2127 | auto& explicitExactOrMultipleLayer = layers[1]; |
| 2128 | |
| 2129 | explicitExactOrMultipleLayer.vote = LayerVoteType::ExplicitExactOrMultiple; |
| 2130 | explicitExactOrMultipleLayer.name = "ExplicitExactOrMultiple"; |
| 2131 | explicitExactOrMultipleLayer.desiredRefreshRate = Fps(60); |
| 2132 | |
| 2133 | explicitExactLayer.vote = LayerVoteType::ExplicitExact; |
| 2134 | explicitExactLayer.name = "ExplicitExact"; |
| 2135 | explicitExactLayer.desiredRefreshRate = Fps(30); |
| 2136 | |
| 2137 | EXPECT_EQ(mExpected60Config, |
| 2138 | refreshRateConfigs->getBestRefreshRate(layers, {.touch = false, .idle = false})); |
| 2139 | EXPECT_EQ(mExpected120Config, |
| 2140 | refreshRateConfigs->getBestRefreshRate(layers, {.touch = true, .idle = false})); |
| 2141 | |
| 2142 | explicitExactOrMultipleLayer.vote = LayerVoteType::NoVote; |
| 2143 | |
| 2144 | EXPECT_EQ(mExpected60Config, |
| 2145 | refreshRateConfigs->getBestRefreshRate(layers, {.touch = false, .idle = false})); |
| 2146 | EXPECT_EQ(mExpected60Config, |
| 2147 | refreshRateConfigs->getBestRefreshRate(layers, {.touch = true, .idle = false})); |
| 2148 | } |
| 2149 | |
Marin Shalamanov | 15a0fc6 | 2021-08-16 18:20:21 +0200 | [diff] [blame^] | 2150 | TEST_F(RefreshRateConfigsTest, getBestRefreshRate_FractionalRefreshRates_ExactAndDefault) { |
| 2151 | RefreshRateConfigs::Config config = {.enableFrameRateOverride = true}; |
| 2152 | auto refreshRateConfigs = |
| 2153 | std::make_unique<RefreshRateConfigs>(m24_25_30_50_60WithFracDevice, |
| 2154 | /*currentConfigId=*/HWC_CONFIG_ID_60, config); |
| 2155 | |
| 2156 | auto layers = std::vector<LayerRequirement>{LayerRequirement{.weight = 0.5f}, |
| 2157 | LayerRequirement{.weight = 0.5f}}; |
| 2158 | auto& explicitDefaultLayer = layers[0]; |
| 2159 | auto& explicitExactOrMultipleLayer = layers[1]; |
| 2160 | |
| 2161 | explicitExactOrMultipleLayer.vote = LayerVoteType::ExplicitExactOrMultiple; |
| 2162 | explicitExactOrMultipleLayer.name = "ExplicitExactOrMultiple"; |
| 2163 | explicitExactOrMultipleLayer.desiredRefreshRate = Fps(60); |
| 2164 | |
| 2165 | explicitDefaultLayer.vote = LayerVoteType::ExplicitDefault; |
| 2166 | explicitDefaultLayer.name = "ExplicitDefault"; |
| 2167 | explicitDefaultLayer.desiredRefreshRate = Fps(59.94f); |
| 2168 | |
| 2169 | EXPECT_EQ(mExpected60Config, |
| 2170 | refreshRateConfigs->getBestRefreshRate(layers, {.touch = false, .idle = false})); |
| 2171 | } |
| 2172 | |
Ana Krulec | b9afd79 | 2020-06-11 13:16:15 -0700 | [diff] [blame] | 2173 | TEST_F(RefreshRateConfigsTest, testComparisonOperator) { |
| 2174 | EXPECT_TRUE(mExpected60Config < mExpected90Config); |
| 2175 | EXPECT_FALSE(mExpected60Config < mExpected60Config); |
| 2176 | EXPECT_FALSE(mExpected90Config < mExpected90Config); |
| 2177 | } |
| 2178 | |
| 2179 | TEST_F(RefreshRateConfigsTest, testKernelIdleTimerAction) { |
| 2180 | using KernelIdleTimerAction = scheduler::RefreshRateConfigs::KernelIdleTimerAction; |
| 2181 | |
| 2182 | auto refreshRateConfigs = |
| 2183 | std::make_unique<RefreshRateConfigs>(m60_90Device, |
| 2184 | /*currentConfigId=*/HWC_CONFIG_ID_90); |
| 2185 | // SetPolicy(60, 90), current 90Hz => TurnOn. |
| 2186 | EXPECT_EQ(KernelIdleTimerAction::TurnOn, refreshRateConfigs->getIdleTimerAction()); |
| 2187 | |
| 2188 | // SetPolicy(60, 90), current 60Hz => TurnOn. |
Marin Shalamanov | e8a663d | 2020-11-24 17:48:00 +0100 | [diff] [blame] | 2189 | ASSERT_GE(refreshRateConfigs->setDisplayManagerPolicy({HWC_CONFIG_ID_60, {Fps(60), Fps(90)}}), |
| 2190 | 0); |
Ana Krulec | b9afd79 | 2020-06-11 13:16:15 -0700 | [diff] [blame] | 2191 | EXPECT_EQ(KernelIdleTimerAction::TurnOn, refreshRateConfigs->getIdleTimerAction()); |
| 2192 | |
Ady Abraham | a91605e | 2021-06-18 11:41:47 -0700 | [diff] [blame] | 2193 | // SetPolicy(60, 60), current 60Hz => TurnOff |
Marin Shalamanov | e8a663d | 2020-11-24 17:48:00 +0100 | [diff] [blame] | 2194 | ASSERT_GE(refreshRateConfigs->setDisplayManagerPolicy({HWC_CONFIG_ID_60, {Fps(60), Fps(60)}}), |
| 2195 | 0); |
Ady Abraham | a91605e | 2021-06-18 11:41:47 -0700 | [diff] [blame] | 2196 | EXPECT_EQ(KernelIdleTimerAction::TurnOff, refreshRateConfigs->getIdleTimerAction()); |
Ana Krulec | b9afd79 | 2020-06-11 13:16:15 -0700 | [diff] [blame] | 2197 | |
| 2198 | // SetPolicy(90, 90), current 90Hz => TurnOff. |
Marin Shalamanov | e8a663d | 2020-11-24 17:48:00 +0100 | [diff] [blame] | 2199 | ASSERT_GE(refreshRateConfigs->setDisplayManagerPolicy({HWC_CONFIG_ID_90, {Fps(90), Fps(90)}}), |
| 2200 | 0); |
Ana Krulec | b9afd79 | 2020-06-11 13:16:15 -0700 | [diff] [blame] | 2201 | EXPECT_EQ(KernelIdleTimerAction::TurnOff, refreshRateConfigs->getIdleTimerAction()); |
| 2202 | } |
| 2203 | |
TreeHugger Robot | 758ab61 | 2021-06-22 19:17:29 +0000 | [diff] [blame] | 2204 | TEST_F(RefreshRateConfigsTest, testKernelIdleTimerActionFor120Hz) { |
| 2205 | using KernelIdleTimerAction = scheduler::RefreshRateConfigs::KernelIdleTimerAction; |
| 2206 | |
| 2207 | // Tests with 120Hz |
| 2208 | auto refreshRateConfigs = |
| 2209 | std::make_unique<RefreshRateConfigs>(m60_120Device, |
| 2210 | /*currentConfigId=*/HWC_CONFIG_ID_120); |
| 2211 | // SetPolicy(0, 60), current 60Hz => TurnOn. |
| 2212 | ASSERT_GE(refreshRateConfigs->setDisplayManagerPolicy({HWC_CONFIG_ID_60, {Fps(0), Fps(60)}}), |
| 2213 | 0); |
| 2214 | EXPECT_EQ(KernelIdleTimerAction::TurnOn, refreshRateConfigs->getIdleTimerAction()); |
| 2215 | |
| 2216 | // SetPolicy(60, 60), current 60Hz => TurnOff. |
| 2217 | ASSERT_GE(refreshRateConfigs->setDisplayManagerPolicy({HWC_CONFIG_ID_60, {Fps(60), Fps(60)}}), |
| 2218 | 0); |
| 2219 | EXPECT_EQ(KernelIdleTimerAction::TurnOff, refreshRateConfigs->getIdleTimerAction()); |
| 2220 | |
| 2221 | // SetPolicy(60, 120), current 60Hz => TurnOn. |
| 2222 | ASSERT_GE(refreshRateConfigs->setDisplayManagerPolicy({HWC_CONFIG_ID_60, {Fps(60), Fps(120)}}), |
| 2223 | 0); |
| 2224 | EXPECT_EQ(KernelIdleTimerAction::TurnOn, refreshRateConfigs->getIdleTimerAction()); |
| 2225 | |
| 2226 | // SetPolicy(120, 120), current 120Hz => TurnOff. |
| 2227 | ASSERT_GE(refreshRateConfigs->setDisplayManagerPolicy( |
| 2228 | {HWC_CONFIG_ID_120, {Fps(120), Fps(120)}}), |
| 2229 | 0); |
| 2230 | EXPECT_EQ(KernelIdleTimerAction::TurnOff, refreshRateConfigs->getIdleTimerAction()); |
| 2231 | } |
| 2232 | |
Ady Abraham | 5cc2e26 | 2021-03-25 13:09:17 -0700 | [diff] [blame] | 2233 | TEST_F(RefreshRateConfigsTest, getFrameRateDivider) { |
Ady Abraham | 0bb6a47 | 2020-10-12 10:22:13 -0700 | [diff] [blame] | 2234 | auto refreshRateConfigs = |
| 2235 | std::make_unique<RefreshRateConfigs>(m30_60_72_90_120Device, |
| 2236 | /*currentConfigId=*/HWC_CONFIG_ID_30); |
Ady Abraham | 62a0be2 | 2020-12-08 16:54:10 -0800 | [diff] [blame] | 2237 | |
| 2238 | const auto frameRate = Fps(30.f); |
Ady Abraham | 5cc2e26 | 2021-03-25 13:09:17 -0700 | [diff] [blame] | 2239 | Fps displayRefreshRate = refreshRateConfigs->getCurrentRefreshRate().getFps(); |
| 2240 | EXPECT_EQ(1, RefreshRateConfigs::getFrameRateDivider(displayRefreshRate, frameRate)); |
Ady Abraham | 0bb6a47 | 2020-10-12 10:22:13 -0700 | [diff] [blame] | 2241 | |
Marin Shalamanov | a7fe304 | 2021-01-29 21:02:08 +0100 | [diff] [blame] | 2242 | refreshRateConfigs->setCurrentModeId(HWC_CONFIG_ID_60); |
Ady Abraham | 5cc2e26 | 2021-03-25 13:09:17 -0700 | [diff] [blame] | 2243 | displayRefreshRate = refreshRateConfigs->getCurrentRefreshRate().getFps(); |
| 2244 | EXPECT_EQ(2, RefreshRateConfigs::getFrameRateDivider(displayRefreshRate, frameRate)); |
Ady Abraham | 0bb6a47 | 2020-10-12 10:22:13 -0700 | [diff] [blame] | 2245 | |
Marin Shalamanov | a7fe304 | 2021-01-29 21:02:08 +0100 | [diff] [blame] | 2246 | refreshRateConfigs->setCurrentModeId(HWC_CONFIG_ID_72); |
Ady Abraham | 5cc2e26 | 2021-03-25 13:09:17 -0700 | [diff] [blame] | 2247 | displayRefreshRate = refreshRateConfigs->getCurrentRefreshRate().getFps(); |
| 2248 | EXPECT_EQ(0, RefreshRateConfigs::getFrameRateDivider(displayRefreshRate, frameRate)); |
Ady Abraham | 0bb6a47 | 2020-10-12 10:22:13 -0700 | [diff] [blame] | 2249 | |
Marin Shalamanov | a7fe304 | 2021-01-29 21:02:08 +0100 | [diff] [blame] | 2250 | refreshRateConfigs->setCurrentModeId(HWC_CONFIG_ID_90); |
Ady Abraham | 5cc2e26 | 2021-03-25 13:09:17 -0700 | [diff] [blame] | 2251 | displayRefreshRate = refreshRateConfigs->getCurrentRefreshRate().getFps(); |
| 2252 | EXPECT_EQ(3, RefreshRateConfigs::getFrameRateDivider(displayRefreshRate, frameRate)); |
Ady Abraham | 0bb6a47 | 2020-10-12 10:22:13 -0700 | [diff] [blame] | 2253 | |
Marin Shalamanov | a7fe304 | 2021-01-29 21:02:08 +0100 | [diff] [blame] | 2254 | refreshRateConfigs->setCurrentModeId(HWC_CONFIG_ID_120); |
Ady Abraham | 5cc2e26 | 2021-03-25 13:09:17 -0700 | [diff] [blame] | 2255 | displayRefreshRate = refreshRateConfigs->getCurrentRefreshRate().getFps(); |
| 2256 | EXPECT_EQ(4, RefreshRateConfigs::getFrameRateDivider(displayRefreshRate, frameRate)); |
Ady Abraham | 62f216c | 2020-10-13 19:07:23 -0700 | [diff] [blame] | 2257 | |
Marin Shalamanov | a7fe304 | 2021-01-29 21:02:08 +0100 | [diff] [blame] | 2258 | refreshRateConfigs->setCurrentModeId(HWC_CONFIG_ID_90); |
Ady Abraham | 5cc2e26 | 2021-03-25 13:09:17 -0700 | [diff] [blame] | 2259 | displayRefreshRate = refreshRateConfigs->getCurrentRefreshRate().getFps(); |
| 2260 | EXPECT_EQ(4, RefreshRateConfigs::getFrameRateDivider(displayRefreshRate, Fps(22.5f))); |
Marin Shalamanov | 15a0fc6 | 2021-08-16 18:20:21 +0200 | [diff] [blame^] | 2261 | |
| 2262 | EXPECT_EQ(0, RefreshRateConfigs::getFrameRateDivider(Fps(24.f), Fps(25.f))); |
| 2263 | EXPECT_EQ(0, RefreshRateConfigs::getFrameRateDivider(Fps(24.f), Fps(23.976f))); |
| 2264 | EXPECT_EQ(0, RefreshRateConfigs::getFrameRateDivider(Fps(30.f), Fps(29.97f))); |
| 2265 | EXPECT_EQ(0, RefreshRateConfigs::getFrameRateDivider(Fps(60.f), Fps(59.94f))); |
| 2266 | } |
| 2267 | |
| 2268 | TEST_F(RefreshRateConfigsTest, isFractionalPairOrMultiple) { |
| 2269 | EXPECT_TRUE(RefreshRateConfigs::isFractionalPairOrMultiple(Fps(23.976f), Fps(24.f))); |
| 2270 | EXPECT_TRUE(RefreshRateConfigs::isFractionalPairOrMultiple(Fps(24.f), Fps(23.976f))); |
| 2271 | |
| 2272 | EXPECT_TRUE(RefreshRateConfigs::isFractionalPairOrMultiple(Fps(29.97f), Fps(30.f))); |
| 2273 | EXPECT_TRUE(RefreshRateConfigs::isFractionalPairOrMultiple(Fps(30.f), Fps(29.97f))); |
| 2274 | |
| 2275 | EXPECT_TRUE(RefreshRateConfigs::isFractionalPairOrMultiple(Fps(59.94f), Fps(60.f))); |
| 2276 | EXPECT_TRUE(RefreshRateConfigs::isFractionalPairOrMultiple(Fps(60.f), Fps(59.94f))); |
| 2277 | |
| 2278 | EXPECT_TRUE(RefreshRateConfigs::isFractionalPairOrMultiple(Fps(29.97f), Fps(60.f))); |
| 2279 | EXPECT_TRUE(RefreshRateConfigs::isFractionalPairOrMultiple(Fps(60.f), Fps(29.97f))); |
| 2280 | |
| 2281 | EXPECT_TRUE(RefreshRateConfigs::isFractionalPairOrMultiple(Fps(59.94f), Fps(30.f))); |
| 2282 | EXPECT_TRUE(RefreshRateConfigs::isFractionalPairOrMultiple(Fps(30.f), Fps(59.94f))); |
| 2283 | |
| 2284 | const std::vector<float> refreshRates = {23.976f, 24.f, 25.f, 29.97f, 30.f, 50.f, 59.94f, 60.f}; |
| 2285 | for (auto refreshRate : refreshRates) { |
| 2286 | EXPECT_FALSE( |
| 2287 | RefreshRateConfigs::isFractionalPairOrMultiple(Fps(refreshRate), Fps(refreshRate))); |
| 2288 | } |
| 2289 | |
| 2290 | EXPECT_FALSE(RefreshRateConfigs::isFractionalPairOrMultiple(Fps(24.f), Fps(25.f))); |
| 2291 | EXPECT_FALSE(RefreshRateConfigs::isFractionalPairOrMultiple(Fps(23.978f), Fps(25.f))); |
| 2292 | EXPECT_FALSE(RefreshRateConfigs::isFractionalPairOrMultiple(Fps(29.97f), Fps(59.94f))); |
Ady Abraham | 62a0be2 | 2020-12-08 16:54:10 -0800 | [diff] [blame] | 2293 | } |
| 2294 | |
Ady Abraham | dd5bfa9 | 2021-01-07 17:56:08 -0800 | [diff] [blame] | 2295 | TEST_F(RefreshRateConfigsTest, getFrameRateOverrides_noLayers) { |
Ady Abraham | 62a0be2 | 2020-12-08 16:54:10 -0800 | [diff] [blame] | 2296 | auto refreshRateConfigs = |
| 2297 | std::make_unique<RefreshRateConfigs>(m30_60_72_90_120Device, /*currentConfigId=*/ |
| 2298 | HWC_CONFIG_ID_120); |
| 2299 | |
| 2300 | auto layers = std::vector<LayerRequirement>{}; |
Ady Abraham | dd5bfa9 | 2021-01-07 17:56:08 -0800 | [diff] [blame] | 2301 | ASSERT_TRUE(refreshRateConfigs->getFrameRateOverrides(layers, Fps(120.0f), /*touch=*/false) |
| 2302 | .empty()); |
Ady Abraham | 62a0be2 | 2020-12-08 16:54:10 -0800 | [diff] [blame] | 2303 | } |
| 2304 | |
| 2305 | TEST_F(RefreshRateConfigsTest, getFrameRateOverrides_60on120) { |
rnlee | 3bd61066 | 2021-06-23 16:27:57 -0700 | [diff] [blame] | 2306 | RefreshRateConfigs::Config config = {.enableFrameRateOverride = true}; |
Ady Abraham | 62a0be2 | 2020-12-08 16:54:10 -0800 | [diff] [blame] | 2307 | auto refreshRateConfigs = |
| 2308 | std::make_unique<RefreshRateConfigs>(m30_60_72_90_120Device, /*currentConfigId=*/ |
rnlee | 3bd61066 | 2021-06-23 16:27:57 -0700 | [diff] [blame] | 2309 | HWC_CONFIG_ID_120, config); |
Ady Abraham | 62a0be2 | 2020-12-08 16:54:10 -0800 | [diff] [blame] | 2310 | |
| 2311 | auto layers = std::vector<LayerRequirement>{LayerRequirement{.weight = 1.0f}}; |
| 2312 | layers[0].name = "Test layer"; |
| 2313 | layers[0].ownerUid = 1234; |
| 2314 | layers[0].desiredRefreshRate = Fps(60.0f); |
| 2315 | layers[0].vote = LayerVoteType::ExplicitDefault; |
Ady Abraham | dd5bfa9 | 2021-01-07 17:56:08 -0800 | [diff] [blame] | 2316 | auto frameRateOverrides = |
| 2317 | refreshRateConfigs->getFrameRateOverrides(layers, Fps(120.0f), /*touch=*/false); |
Ady Abraham | 62a0be2 | 2020-12-08 16:54:10 -0800 | [diff] [blame] | 2318 | ASSERT_EQ(1, frameRateOverrides.size()); |
| 2319 | ASSERT_EQ(1, frameRateOverrides.count(1234)); |
| 2320 | ASSERT_EQ(60.0f, frameRateOverrides.at(1234).getValue()); |
| 2321 | |
| 2322 | layers[0].vote = LayerVoteType::ExplicitExactOrMultiple; |
Ady Abraham | dd5bfa9 | 2021-01-07 17:56:08 -0800 | [diff] [blame] | 2323 | frameRateOverrides = |
| 2324 | refreshRateConfigs->getFrameRateOverrides(layers, Fps(120.0f), /*touch=*/false); |
Ady Abraham | 62a0be2 | 2020-12-08 16:54:10 -0800 | [diff] [blame] | 2325 | ASSERT_EQ(1, frameRateOverrides.size()); |
| 2326 | ASSERT_EQ(1, frameRateOverrides.count(1234)); |
| 2327 | ASSERT_EQ(60.0f, frameRateOverrides.at(1234).getValue()); |
| 2328 | |
| 2329 | layers[0].vote = LayerVoteType::NoVote; |
Ady Abraham | dd5bfa9 | 2021-01-07 17:56:08 -0800 | [diff] [blame] | 2330 | frameRateOverrides = |
| 2331 | refreshRateConfigs->getFrameRateOverrides(layers, Fps(120.0f), /*touch=*/false); |
Ady Abraham | 62a0be2 | 2020-12-08 16:54:10 -0800 | [diff] [blame] | 2332 | ASSERT_TRUE(frameRateOverrides.empty()); |
| 2333 | |
| 2334 | layers[0].vote = LayerVoteType::Min; |
Ady Abraham | dd5bfa9 | 2021-01-07 17:56:08 -0800 | [diff] [blame] | 2335 | frameRateOverrides = |
| 2336 | refreshRateConfigs->getFrameRateOverrides(layers, Fps(120.0f), /*touch=*/false); |
Ady Abraham | 62a0be2 | 2020-12-08 16:54:10 -0800 | [diff] [blame] | 2337 | ASSERT_TRUE(frameRateOverrides.empty()); |
| 2338 | |
| 2339 | layers[0].vote = LayerVoteType::Max; |
Ady Abraham | dd5bfa9 | 2021-01-07 17:56:08 -0800 | [diff] [blame] | 2340 | frameRateOverrides = |
| 2341 | refreshRateConfigs->getFrameRateOverrides(layers, Fps(120.0f), /*touch=*/false); |
Ady Abraham | 62a0be2 | 2020-12-08 16:54:10 -0800 | [diff] [blame] | 2342 | ASSERT_TRUE(frameRateOverrides.empty()); |
| 2343 | |
| 2344 | layers[0].vote = LayerVoteType::Heuristic; |
Ady Abraham | dd5bfa9 | 2021-01-07 17:56:08 -0800 | [diff] [blame] | 2345 | frameRateOverrides = |
| 2346 | refreshRateConfigs->getFrameRateOverrides(layers, Fps(120.0f), /*touch=*/false); |
Ady Abraham | 62a0be2 | 2020-12-08 16:54:10 -0800 | [diff] [blame] | 2347 | ASSERT_TRUE(frameRateOverrides.empty()); |
| 2348 | } |
| 2349 | |
Ady Abraham | dd5bfa9 | 2021-01-07 17:56:08 -0800 | [diff] [blame] | 2350 | TEST_F(RefreshRateConfigsTest, getFrameRateOverrides_twoUids) { |
rnlee | 3bd61066 | 2021-06-23 16:27:57 -0700 | [diff] [blame] | 2351 | RefreshRateConfigs::Config config = {.enableFrameRateOverride = true}; |
Ady Abraham | 62a0be2 | 2020-12-08 16:54:10 -0800 | [diff] [blame] | 2352 | auto refreshRateConfigs = |
| 2353 | std::make_unique<RefreshRateConfigs>(m30_60_72_90_120Device, /*currentConfigId=*/ |
rnlee | 3bd61066 | 2021-06-23 16:27:57 -0700 | [diff] [blame] | 2354 | HWC_CONFIG_ID_120, config); |
Ady Abraham | 62a0be2 | 2020-12-08 16:54:10 -0800 | [diff] [blame] | 2355 | |
| 2356 | auto layers = std::vector<LayerRequirement>{ |
| 2357 | LayerRequirement{.ownerUid = 1234, .weight = 1.0f}, |
| 2358 | LayerRequirement{.ownerUid = 5678, .weight = 1.0f}, |
| 2359 | }; |
| 2360 | |
| 2361 | layers[0].name = "Test layer 1234"; |
| 2362 | layers[0].desiredRefreshRate = Fps(60.0f); |
| 2363 | layers[0].vote = LayerVoteType::ExplicitDefault; |
| 2364 | |
| 2365 | layers[1].name = "Test layer 5678"; |
| 2366 | layers[1].desiredRefreshRate = Fps(30.0f); |
| 2367 | layers[1].vote = LayerVoteType::ExplicitDefault; |
Ady Abraham | dd5bfa9 | 2021-01-07 17:56:08 -0800 | [diff] [blame] | 2368 | auto frameRateOverrides = |
| 2369 | refreshRateConfigs->getFrameRateOverrides(layers, Fps(120.0f), /*touch=*/false); |
Ady Abraham | 62a0be2 | 2020-12-08 16:54:10 -0800 | [diff] [blame] | 2370 | |
| 2371 | ASSERT_EQ(2, frameRateOverrides.size()); |
| 2372 | ASSERT_EQ(1, frameRateOverrides.count(1234)); |
| 2373 | ASSERT_EQ(60.0f, frameRateOverrides.at(1234).getValue()); |
| 2374 | ASSERT_EQ(1, frameRateOverrides.count(5678)); |
| 2375 | ASSERT_EQ(30.0f, frameRateOverrides.at(5678).getValue()); |
| 2376 | |
| 2377 | layers[1].vote = LayerVoteType::Heuristic; |
Ady Abraham | dd5bfa9 | 2021-01-07 17:56:08 -0800 | [diff] [blame] | 2378 | frameRateOverrides = |
| 2379 | refreshRateConfigs->getFrameRateOverrides(layers, Fps(120.0f), /*touch=*/false); |
Ady Abraham | 62a0be2 | 2020-12-08 16:54:10 -0800 | [diff] [blame] | 2380 | ASSERT_EQ(1, frameRateOverrides.size()); |
| 2381 | ASSERT_EQ(1, frameRateOverrides.count(1234)); |
| 2382 | ASSERT_EQ(60.0f, frameRateOverrides.at(1234).getValue()); |
| 2383 | |
| 2384 | layers[1].ownerUid = 1234; |
Ady Abraham | dd5bfa9 | 2021-01-07 17:56:08 -0800 | [diff] [blame] | 2385 | frameRateOverrides = |
| 2386 | refreshRateConfigs->getFrameRateOverrides(layers, Fps(120.0f), /*touch=*/false); |
| 2387 | ASSERT_TRUE(frameRateOverrides.empty()); |
| 2388 | } |
| 2389 | |
| 2390 | TEST_F(RefreshRateConfigsTest, getFrameRateOverrides_touch) { |
rnlee | 3bd61066 | 2021-06-23 16:27:57 -0700 | [diff] [blame] | 2391 | RefreshRateConfigs::Config config = {.enableFrameRateOverride = true}; |
Ady Abraham | dd5bfa9 | 2021-01-07 17:56:08 -0800 | [diff] [blame] | 2392 | auto refreshRateConfigs = |
| 2393 | std::make_unique<RefreshRateConfigs>(m30_60_72_90_120Device, /*currentConfigId=*/ |
rnlee | 3bd61066 | 2021-06-23 16:27:57 -0700 | [diff] [blame] | 2394 | HWC_CONFIG_ID_120, config); |
Ady Abraham | dd5bfa9 | 2021-01-07 17:56:08 -0800 | [diff] [blame] | 2395 | |
| 2396 | auto layers = std::vector<LayerRequirement>{ |
| 2397 | LayerRequirement{.ownerUid = 1234, .weight = 1.0f}, |
| 2398 | }; |
| 2399 | |
| 2400 | layers[0].name = "Test layer"; |
| 2401 | layers[0].desiredRefreshRate = Fps(60.0f); |
| 2402 | layers[0].vote = LayerVoteType::ExplicitDefault; |
| 2403 | |
| 2404 | auto frameRateOverrides = |
| 2405 | refreshRateConfigs->getFrameRateOverrides(layers, Fps(120.0f), /*touch=*/false); |
| 2406 | ASSERT_EQ(1, frameRateOverrides.size()); |
| 2407 | ASSERT_EQ(1, frameRateOverrides.count(1234)); |
| 2408 | ASSERT_EQ(60.0f, frameRateOverrides.at(1234).getValue()); |
| 2409 | |
| 2410 | frameRateOverrides = |
| 2411 | refreshRateConfigs->getFrameRateOverrides(layers, Fps(120.0f), /*touch=*/true); |
| 2412 | ASSERT_EQ(1, frameRateOverrides.size()); |
| 2413 | ASSERT_EQ(1, frameRateOverrides.count(1234)); |
| 2414 | ASSERT_EQ(60.0f, frameRateOverrides.at(1234).getValue()); |
| 2415 | |
| 2416 | layers[0].vote = LayerVoteType::ExplicitExact; |
| 2417 | frameRateOverrides = |
| 2418 | refreshRateConfigs->getFrameRateOverrides(layers, Fps(120.0f), /*touch=*/false); |
| 2419 | ASSERT_EQ(1, frameRateOverrides.size()); |
| 2420 | ASSERT_EQ(1, frameRateOverrides.count(1234)); |
| 2421 | ASSERT_EQ(60.0f, frameRateOverrides.at(1234).getValue()); |
| 2422 | |
| 2423 | frameRateOverrides = |
| 2424 | refreshRateConfigs->getFrameRateOverrides(layers, Fps(120.0f), /*touch=*/true); |
| 2425 | ASSERT_EQ(1, frameRateOverrides.size()); |
| 2426 | ASSERT_EQ(1, frameRateOverrides.count(1234)); |
| 2427 | ASSERT_EQ(60.0f, frameRateOverrides.at(1234).getValue()); |
| 2428 | |
| 2429 | layers[0].vote = LayerVoteType::ExplicitExactOrMultiple; |
| 2430 | frameRateOverrides = |
| 2431 | refreshRateConfigs->getFrameRateOverrides(layers, Fps(120.0f), /*touch=*/false); |
| 2432 | ASSERT_EQ(1, frameRateOverrides.size()); |
| 2433 | ASSERT_EQ(1, frameRateOverrides.count(1234)); |
| 2434 | ASSERT_EQ(60.0f, frameRateOverrides.at(1234).getValue()); |
| 2435 | |
| 2436 | frameRateOverrides = |
| 2437 | refreshRateConfigs->getFrameRateOverrides(layers, Fps(120.0f), /*touch=*/true); |
Ady Abraham | 62a0be2 | 2020-12-08 16:54:10 -0800 | [diff] [blame] | 2438 | ASSERT_TRUE(frameRateOverrides.empty()); |
Ady Abraham | 0bb6a47 | 2020-10-12 10:22:13 -0700 | [diff] [blame] | 2439 | } |
| 2440 | |
Alec Mouri | 0a1cc96 | 2019-03-14 12:33:02 -0700 | [diff] [blame] | 2441 | } // namespace |
| 2442 | } // namespace scheduler |
| 2443 | } // namespace android |
Marin Shalamanov | bed7fd3 | 2020-12-21 20:02:20 +0100 | [diff] [blame] | 2444 | |
| 2445 | // TODO(b/129481165): remove the #pragma below and fix conversion issues |
| 2446 | #pragma clang diagnostic pop // ignored "-Wextra" |