Adithya Srinivasan | f279e04 | 2020-08-17 14:56:27 -0700 | [diff] [blame] | 1 | /* |
| 2 | * Copyright 2020 The Android Open Source Project |
| 3 | * |
| 4 | * Licensed under the Apache License, Version 2.0 (the "License"); |
| 5 | * you may not use this file except in compliance with the License. |
| 6 | * You may obtain a copy of the License at |
| 7 | * |
| 8 | * http://www.apache.org/licenses/LICENSE-2.0 |
| 9 | * |
| 10 | * Unless required by applicable law or agreed to in writing, software |
| 11 | * distributed under the License is distributed on an "AS IS" BASIS, |
| 12 | * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. |
| 13 | * See the License for the specific language governing permissions and |
| 14 | * limitations under the License. |
| 15 | */ |
| 16 | |
| 17 | #undef LOG_TAG |
| 18 | #define LOG_TAG "FrameTimeline" |
| 19 | #define ATRACE_TAG ATRACE_TAG_GRAPHICS |
| 20 | |
| 21 | #include "FrameTimeline.h" |
Alec Mouri | adebf5c | 2021-01-05 12:57:36 -0800 | [diff] [blame] | 22 | |
Adithya Srinivasan | f279e04 | 2020-08-17 14:56:27 -0700 | [diff] [blame] | 23 | #include <android-base/stringprintf.h> |
Sally Qi | f572125 | 2023-11-17 11:14:53 -0800 | [diff] [blame] | 24 | #include <common/FlagManager.h> |
Vishnu Nair | be0ad90 | 2024-06-27 23:38:43 +0000 | [diff] [blame] | 25 | #include <common/trace.h> |
Ady Abraham | 7f8a1e6 | 2020-09-28 16:09:35 -0700 | [diff] [blame] | 26 | #include <utils/Log.h> |
Alec Mouri | adebf5c | 2021-01-05 12:57:36 -0800 | [diff] [blame] | 27 | |
Adithya Srinivasan | 8fc601d | 2020-09-25 13:51:09 -0700 | [diff] [blame] | 28 | #include <chrono> |
Adithya Srinivasan | f279e04 | 2020-08-17 14:56:27 -0700 | [diff] [blame] | 29 | #include <cinttypes> |
Adithya Srinivasan | 8fc601d | 2020-09-25 13:51:09 -0700 | [diff] [blame] | 30 | #include <numeric> |
Alec Mouri | adebf5c | 2021-01-05 12:57:36 -0800 | [diff] [blame] | 31 | #include <unordered_set> |
Adithya Srinivasan | f279e04 | 2020-08-17 14:56:27 -0700 | [diff] [blame] | 32 | |
Pascal Mütschard | d56514e | 2024-05-24 17:37:13 +0200 | [diff] [blame] | 33 | #include "../Jank/JankTracker.h" |
| 34 | |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 35 | namespace android::frametimeline { |
Adithya Srinivasan | f279e04 | 2020-08-17 14:56:27 -0700 | [diff] [blame] | 36 | |
| 37 | using base::StringAppendF; |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 38 | using FrameTimelineEvent = perfetto::protos::pbzero::FrameTimelineEvent; |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 39 | using FrameTimelineDataSource = impl::FrameTimeline::FrameTimelineDataSource; |
Adithya Srinivasan | f279e04 | 2020-08-17 14:56:27 -0700 | [diff] [blame] | 40 | |
Adithya Srinivasan | 8fc601d | 2020-09-25 13:51:09 -0700 | [diff] [blame] | 41 | void dumpTable(std::string& result, TimelineItem predictions, TimelineItem actuals, |
| 42 | const std::string& indent, PredictionState predictionState, nsecs_t baseTime) { |
| 43 | StringAppendF(&result, "%s", indent.c_str()); |
| 44 | StringAppendF(&result, "\t\t"); |
| 45 | StringAppendF(&result, " Start time\t\t|"); |
| 46 | StringAppendF(&result, " End time\t\t|"); |
| 47 | StringAppendF(&result, " Present time\n"); |
| 48 | if (predictionState == PredictionState::Valid) { |
| 49 | // Dump the Predictions only if they are valid |
| 50 | StringAppendF(&result, "%s", indent.c_str()); |
| 51 | StringAppendF(&result, "Expected\t|"); |
| 52 | std::chrono::nanoseconds startTime(predictions.startTime - baseTime); |
| 53 | std::chrono::nanoseconds endTime(predictions.endTime - baseTime); |
| 54 | std::chrono::nanoseconds presentTime(predictions.presentTime - baseTime); |
| 55 | StringAppendF(&result, "\t%10.2f\t|\t%10.2f\t|\t%10.2f\n", |
| 56 | std::chrono::duration<double, std::milli>(startTime).count(), |
| 57 | std::chrono::duration<double, std::milli>(endTime).count(), |
| 58 | std::chrono::duration<double, std::milli>(presentTime).count()); |
| 59 | } |
| 60 | StringAppendF(&result, "%s", indent.c_str()); |
| 61 | StringAppendF(&result, "Actual \t|"); |
| 62 | |
| 63 | if (actuals.startTime == 0) { |
| 64 | StringAppendF(&result, "\t\tN/A\t|"); |
| 65 | } else { |
| 66 | std::chrono::nanoseconds startTime(std::max<nsecs_t>(0, actuals.startTime - baseTime)); |
| 67 | StringAppendF(&result, "\t%10.2f\t|", |
| 68 | std::chrono::duration<double, std::milli>(startTime).count()); |
| 69 | } |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 70 | if (actuals.endTime <= 0) { |
| 71 | // Animation leashes can send the endTime as -1 |
Adithya Srinivasan | 8fc601d | 2020-09-25 13:51:09 -0700 | [diff] [blame] | 72 | StringAppendF(&result, "\t\tN/A\t|"); |
| 73 | } else { |
| 74 | std::chrono::nanoseconds endTime(actuals.endTime - baseTime); |
| 75 | StringAppendF(&result, "\t%10.2f\t|", |
| 76 | std::chrono::duration<double, std::milli>(endTime).count()); |
| 77 | } |
| 78 | if (actuals.presentTime == 0) { |
| 79 | StringAppendF(&result, "\t\tN/A\n"); |
| 80 | } else { |
| 81 | std::chrono::nanoseconds presentTime(std::max<nsecs_t>(0, actuals.presentTime - baseTime)); |
| 82 | StringAppendF(&result, "\t%10.2f\n", |
| 83 | std::chrono::duration<double, std::milli>(presentTime).count()); |
| 84 | } |
| 85 | |
| 86 | StringAppendF(&result, "%s", indent.c_str()); |
| 87 | StringAppendF(&result, "----------------------"); |
| 88 | StringAppendF(&result, "----------------------"); |
| 89 | StringAppendF(&result, "----------------------"); |
| 90 | StringAppendF(&result, "----------------------\n"); |
| 91 | } |
| 92 | |
| 93 | std::string toString(PredictionState predictionState) { |
| 94 | switch (predictionState) { |
| 95 | case PredictionState::Valid: |
| 96 | return "Valid"; |
| 97 | case PredictionState::Expired: |
| 98 | return "Expired"; |
| 99 | case PredictionState::None: |
Adithya Srinivasan | 8fc601d | 2020-09-25 13:51:09 -0700 | [diff] [blame] | 100 | return "None"; |
| 101 | } |
| 102 | } |
| 103 | |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 104 | std::string jankTypeBitmaskToString(int32_t jankType) { |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 105 | if (jankType == JankType::None) { |
Adithya Srinivasan | 8fc601d | 2020-09-25 13:51:09 -0700 | [diff] [blame] | 106 | return "None"; |
| 107 | } |
Adithya Srinivasan | 552e2a7 | 2021-01-15 03:21:53 +0000 | [diff] [blame] | 108 | |
| 109 | std::vector<std::string> janks; |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 110 | if (jankType & JankType::DisplayHAL) { |
| 111 | janks.emplace_back("Display HAL"); |
Adithya Srinivasan | 552e2a7 | 2021-01-15 03:21:53 +0000 | [diff] [blame] | 112 | jankType &= ~JankType::DisplayHAL; |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 113 | } |
| 114 | if (jankType & JankType::SurfaceFlingerCpuDeadlineMissed) { |
Rachel Lee | 94917b3 | 2022-03-18 17:52:09 -0700 | [diff] [blame] | 115 | janks.emplace_back("SurfaceFlinger deadline missed (while in HWC)"); |
Adithya Srinivasan | 552e2a7 | 2021-01-15 03:21:53 +0000 | [diff] [blame] | 116 | jankType &= ~JankType::SurfaceFlingerCpuDeadlineMissed; |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 117 | } |
| 118 | if (jankType & JankType::SurfaceFlingerGpuDeadlineMissed) { |
Rachel Lee | 94917b3 | 2022-03-18 17:52:09 -0700 | [diff] [blame] | 119 | janks.emplace_back("SurfaceFlinger deadline missed (while in GPU comp)"); |
Adithya Srinivasan | 552e2a7 | 2021-01-15 03:21:53 +0000 | [diff] [blame] | 120 | jankType &= ~JankType::SurfaceFlingerGpuDeadlineMissed; |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 121 | } |
| 122 | if (jankType & JankType::AppDeadlineMissed) { |
| 123 | janks.emplace_back("App Deadline Missed"); |
Adithya Srinivasan | 552e2a7 | 2021-01-15 03:21:53 +0000 | [diff] [blame] | 124 | jankType &= ~JankType::AppDeadlineMissed; |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 125 | } |
| 126 | if (jankType & JankType::PredictionError) { |
| 127 | janks.emplace_back("Prediction Error"); |
Adithya Srinivasan | 552e2a7 | 2021-01-15 03:21:53 +0000 | [diff] [blame] | 128 | jankType &= ~JankType::PredictionError; |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 129 | } |
| 130 | if (jankType & JankType::SurfaceFlingerScheduling) { |
| 131 | janks.emplace_back("SurfaceFlinger Scheduling"); |
Adithya Srinivasan | 552e2a7 | 2021-01-15 03:21:53 +0000 | [diff] [blame] | 132 | jankType &= ~JankType::SurfaceFlingerScheduling; |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 133 | } |
| 134 | if (jankType & JankType::BufferStuffing) { |
| 135 | janks.emplace_back("Buffer Stuffing"); |
Adithya Srinivasan | 552e2a7 | 2021-01-15 03:21:53 +0000 | [diff] [blame] | 136 | jankType &= ~JankType::BufferStuffing; |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 137 | } |
| 138 | if (jankType & JankType::Unknown) { |
| 139 | janks.emplace_back("Unknown jank"); |
Adithya Srinivasan | 552e2a7 | 2021-01-15 03:21:53 +0000 | [diff] [blame] | 140 | jankType &= ~JankType::Unknown; |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 141 | } |
Adithya Srinivasan | 2045ddf | 2021-05-27 17:38:10 +0000 | [diff] [blame] | 142 | if (jankType & JankType::SurfaceFlingerStuffing) { |
| 143 | janks.emplace_back("SurfaceFlinger Stuffing"); |
| 144 | jankType &= ~JankType::SurfaceFlingerStuffing; |
| 145 | } |
Edgar Arriaga | 631e425 | 2023-03-02 02:11:24 +0000 | [diff] [blame] | 146 | if (jankType & JankType::Dropped) { |
| 147 | janks.emplace_back("Dropped Frame"); |
| 148 | jankType &= ~JankType::Dropped; |
| 149 | } |
Adithya Srinivasan | 552e2a7 | 2021-01-15 03:21:53 +0000 | [diff] [blame] | 150 | |
| 151 | // jankType should be 0 if all types of jank were checked for. |
| 152 | LOG_ALWAYS_FATAL_IF(jankType != 0, "Unrecognized jank type value 0x%x", jankType); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 153 | return std::accumulate(janks.begin(), janks.end(), std::string(), |
Adithya Srinivasan | 8fc601d | 2020-09-25 13:51:09 -0700 | [diff] [blame] | 154 | [](const std::string& l, const std::string& r) { |
| 155 | return l.empty() ? r : l + ", " + r; |
| 156 | }); |
| 157 | } |
| 158 | |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 159 | std::string toString(FramePresentMetadata presentMetadata) { |
| 160 | switch (presentMetadata) { |
| 161 | case FramePresentMetadata::OnTimePresent: |
| 162 | return "On Time Present"; |
| 163 | case FramePresentMetadata::LatePresent: |
| 164 | return "Late Present"; |
| 165 | case FramePresentMetadata::EarlyPresent: |
| 166 | return "Early Present"; |
| 167 | case FramePresentMetadata::UnknownPresent: |
| 168 | return "Unknown Present"; |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 169 | } |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 170 | } |
| 171 | |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 172 | std::string toString(FrameReadyMetadata finishMetadata) { |
| 173 | switch (finishMetadata) { |
| 174 | case FrameReadyMetadata::OnTimeFinish: |
| 175 | return "On Time Finish"; |
| 176 | case FrameReadyMetadata::LateFinish: |
| 177 | return "Late Finish"; |
| 178 | case FrameReadyMetadata::UnknownFinish: |
| 179 | return "Unknown Finish"; |
| 180 | } |
| 181 | } |
| 182 | |
| 183 | std::string toString(FrameStartMetadata startMetadata) { |
| 184 | switch (startMetadata) { |
| 185 | case FrameStartMetadata::OnTimeStart: |
| 186 | return "On Time Start"; |
| 187 | case FrameStartMetadata::LateStart: |
| 188 | return "Late Start"; |
| 189 | case FrameStartMetadata::EarlyStart: |
| 190 | return "Early Start"; |
| 191 | case FrameStartMetadata::UnknownStart: |
| 192 | return "Unknown Start"; |
| 193 | } |
| 194 | } |
| 195 | |
| 196 | std::string toString(SurfaceFrame::PresentState presentState) { |
| 197 | using PresentState = SurfaceFrame::PresentState; |
| 198 | switch (presentState) { |
| 199 | case PresentState::Presented: |
| 200 | return "Presented"; |
| 201 | case PresentState::Dropped: |
| 202 | return "Dropped"; |
| 203 | case PresentState::Unknown: |
| 204 | return "Unknown"; |
| 205 | } |
| 206 | } |
| 207 | |
| 208 | FrameTimelineEvent::PresentType toProto(FramePresentMetadata presentMetadata) { |
| 209 | switch (presentMetadata) { |
| 210 | case FramePresentMetadata::EarlyPresent: |
| 211 | return FrameTimelineEvent::PRESENT_EARLY; |
| 212 | case FramePresentMetadata::LatePresent: |
| 213 | return FrameTimelineEvent::PRESENT_LATE; |
| 214 | case FramePresentMetadata::OnTimePresent: |
| 215 | return FrameTimelineEvent::PRESENT_ON_TIME; |
| 216 | case FramePresentMetadata::UnknownPresent: |
| 217 | return FrameTimelineEvent::PRESENT_UNSPECIFIED; |
| 218 | } |
| 219 | } |
| 220 | |
Adithya Srinivasan | 78e58af | 2021-02-25 00:08:08 +0000 | [diff] [blame] | 221 | FrameTimelineEvent::PredictionType toProto(PredictionState predictionState) { |
| 222 | switch (predictionState) { |
| 223 | case PredictionState::Valid: |
| 224 | return FrameTimelineEvent::PREDICTION_VALID; |
| 225 | case PredictionState::Expired: |
| 226 | return FrameTimelineEvent::PREDICTION_EXPIRED; |
| 227 | case PredictionState::None: |
| 228 | return FrameTimelineEvent::PREDICTION_UNKNOWN; |
| 229 | } |
| 230 | } |
| 231 | |
Adithya Srinivasan | 552e2a7 | 2021-01-15 03:21:53 +0000 | [diff] [blame] | 232 | int32_t jankTypeBitmaskToProto(int32_t jankType) { |
| 233 | if (jankType == JankType::None) { |
| 234 | return FrameTimelineEvent::JANK_NONE; |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 235 | } |
Adithya Srinivasan | 552e2a7 | 2021-01-15 03:21:53 +0000 | [diff] [blame] | 236 | |
| 237 | int32_t protoJank = 0; |
| 238 | if (jankType & JankType::DisplayHAL) { |
| 239 | protoJank |= FrameTimelineEvent::JANK_DISPLAY_HAL; |
| 240 | jankType &= ~JankType::DisplayHAL; |
| 241 | } |
| 242 | if (jankType & JankType::SurfaceFlingerCpuDeadlineMissed) { |
| 243 | protoJank |= FrameTimelineEvent::JANK_SF_CPU_DEADLINE_MISSED; |
| 244 | jankType &= ~JankType::SurfaceFlingerCpuDeadlineMissed; |
| 245 | } |
| 246 | if (jankType & JankType::SurfaceFlingerGpuDeadlineMissed) { |
| 247 | protoJank |= FrameTimelineEvent::JANK_SF_GPU_DEADLINE_MISSED; |
| 248 | jankType &= ~JankType::SurfaceFlingerGpuDeadlineMissed; |
| 249 | } |
| 250 | if (jankType & JankType::AppDeadlineMissed) { |
| 251 | protoJank |= FrameTimelineEvent::JANK_APP_DEADLINE_MISSED; |
| 252 | jankType &= ~JankType::AppDeadlineMissed; |
| 253 | } |
| 254 | if (jankType & JankType::PredictionError) { |
| 255 | protoJank |= FrameTimelineEvent::JANK_PREDICTION_ERROR; |
| 256 | jankType &= ~JankType::PredictionError; |
| 257 | } |
| 258 | if (jankType & JankType::SurfaceFlingerScheduling) { |
| 259 | protoJank |= FrameTimelineEvent::JANK_SF_SCHEDULING; |
| 260 | jankType &= ~JankType::SurfaceFlingerScheduling; |
| 261 | } |
| 262 | if (jankType & JankType::BufferStuffing) { |
| 263 | protoJank |= FrameTimelineEvent::JANK_BUFFER_STUFFING; |
| 264 | jankType &= ~JankType::BufferStuffing; |
| 265 | } |
| 266 | if (jankType & JankType::Unknown) { |
| 267 | protoJank |= FrameTimelineEvent::JANK_UNKNOWN; |
| 268 | jankType &= ~JankType::Unknown; |
| 269 | } |
Adithya Srinivasan | 57dc81d | 2021-04-14 17:31:41 +0000 | [diff] [blame] | 270 | if (jankType & JankType::SurfaceFlingerStuffing) { |
| 271 | protoJank |= FrameTimelineEvent::JANK_SF_STUFFING; |
| 272 | jankType &= ~JankType::SurfaceFlingerStuffing; |
| 273 | } |
Edgar Arriaga | 631e425 | 2023-03-02 02:11:24 +0000 | [diff] [blame] | 274 | if (jankType & JankType::Dropped) { |
| 275 | // Jank dropped does not append to other janks, it fully overrides. |
| 276 | protoJank |= FrameTimelineEvent::JANK_DROPPED; |
| 277 | jankType &= ~JankType::Dropped; |
| 278 | } |
Adithya Srinivasan | 552e2a7 | 2021-01-15 03:21:53 +0000 | [diff] [blame] | 279 | |
| 280 | // jankType should be 0 if all types of jank were checked for. |
| 281 | LOG_ALWAYS_FATAL_IF(jankType != 0, "Unrecognized jank type value 0x%x", jankType); |
| 282 | return protoJank; |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 283 | } |
| 284 | |
Ying Wei | 96eb535 | 2023-11-21 17:37:21 +0000 | [diff] [blame] | 285 | FrameTimelineEvent::JankSeverityType toProto(JankSeverityType jankSeverityType) { |
| 286 | switch (jankSeverityType) { |
| 287 | case JankSeverityType::Unknown: |
| 288 | return FrameTimelineEvent::SEVERITY_UNKNOWN; |
| 289 | case JankSeverityType::None: |
| 290 | return FrameTimelineEvent::SEVERITY_NONE; |
| 291 | case JankSeverityType::Partial: |
| 292 | return FrameTimelineEvent::SEVERITY_PARTIAL; |
| 293 | case JankSeverityType::Full: |
| 294 | return FrameTimelineEvent::SEVERITY_FULL; |
| 295 | } |
| 296 | } |
| 297 | |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 298 | // Returns the smallest timestamp from the set of predictions and actuals. |
| 299 | nsecs_t getMinTime(PredictionState predictionState, TimelineItem predictions, |
| 300 | TimelineItem actuals) { |
| 301 | nsecs_t minTime = std::numeric_limits<nsecs_t>::max(); |
| 302 | if (predictionState == PredictionState::Valid) { |
| 303 | // Checking start time for predictions is enough because start time is always lesser than |
| 304 | // endTime and presentTime. |
| 305 | minTime = std::min(minTime, predictions.startTime); |
Adithya Srinivasan | f279e04 | 2020-08-17 14:56:27 -0700 | [diff] [blame] | 306 | } |
Adithya Srinivasan | f279e04 | 2020-08-17 14:56:27 -0700 | [diff] [blame] | 307 | |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 308 | // Need to check startTime, endTime and presentTime for actuals because some frames might not |
| 309 | // have them set. |
| 310 | if (actuals.startTime != 0) { |
| 311 | minTime = std::min(minTime, actuals.startTime); |
Adithya Srinivasan | f279e04 | 2020-08-17 14:56:27 -0700 | [diff] [blame] | 312 | } |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 313 | if (actuals.endTime != 0) { |
| 314 | minTime = std::min(minTime, actuals.endTime); |
| 315 | } |
| 316 | if (actuals.presentTime != 0) { |
ramindani | ea2bb82 | 2022-06-27 19:52:10 +0000 | [diff] [blame] | 317 | minTime = std::min(minTime, actuals.presentTime); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 318 | } |
| 319 | return minTime; |
Adithya Srinivasan | f279e04 | 2020-08-17 14:56:27 -0700 | [diff] [blame] | 320 | } |
| 321 | |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 322 | int64_t TraceCookieCounter::getCookieForTracing() { |
| 323 | return ++mTraceCookie; |
| 324 | } |
| 325 | |
Siarhei Vishniakou | fc434ac | 2021-01-13 10:28:00 -1000 | [diff] [blame] | 326 | SurfaceFrame::SurfaceFrame(const FrameTimelineInfo& frameTimelineInfo, pid_t ownerPid, |
Alec Mouri | adebf5c | 2021-01-05 12:57:36 -0800 | [diff] [blame] | 327 | uid_t ownerUid, int32_t layerId, std::string layerName, |
| 328 | std::string debugName, PredictionState predictionState, |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 329 | frametimeline::TimelineItem&& predictions, |
| 330 | std::shared_ptr<TimeStats> timeStats, |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 331 | JankClassificationThresholds thresholds, |
Dominik Laskowski | f5d0ea5 | 2021-09-26 17:27:01 -0700 | [diff] [blame] | 332 | TraceCookieCounter* traceCookieCounter, bool isBuffer, GameMode gameMode) |
Siarhei Vishniakou | fc434ac | 2021-01-13 10:28:00 -1000 | [diff] [blame] | 333 | : mToken(frameTimelineInfo.vsyncId), |
| 334 | mInputEventId(frameTimelineInfo.inputEventId), |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 335 | mOwnerPid(ownerPid), |
Adithya Srinivasan | 9febda8 | 2020-10-19 10:49:41 -0700 | [diff] [blame] | 336 | mOwnerUid(ownerUid), |
Alec Mouri | 9a29e67 | 2020-09-14 12:39:14 -0700 | [diff] [blame] | 337 | mLayerName(std::move(layerName)), |
| 338 | mDebugName(std::move(debugName)), |
Alec Mouri | adebf5c | 2021-01-05 12:57:36 -0800 | [diff] [blame] | 339 | mLayerId(layerId), |
Adithya Srinivasan | f279e04 | 2020-08-17 14:56:27 -0700 | [diff] [blame] | 340 | mPresentState(PresentState::Unknown), |
| 341 | mPredictionState(predictionState), |
| 342 | mPredictions(predictions), |
| 343 | mActuals({0, 0, 0}), |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 344 | mTimeStats(timeStats), |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 345 | mJankClassificationThresholds(thresholds), |
Adithya Srinivasan | 785addd | 2021-03-09 00:38:00 +0000 | [diff] [blame] | 346 | mTraceCookieCounter(*traceCookieCounter), |
Adithya Srinivasan | 58069dc | 2021-06-04 20:37:02 +0000 | [diff] [blame] | 347 | mIsBuffer(isBuffer), |
| 348 | mGameMode(gameMode) {} |
Adithya Srinivasan | f279e04 | 2020-08-17 14:56:27 -0700 | [diff] [blame] | 349 | |
Adithya Srinivasan | 5f683cf | 2020-09-15 14:21:04 -0700 | [diff] [blame] | 350 | void SurfaceFrame::setActualStartTime(nsecs_t actualStartTime) { |
Siarhei Vishniakou | fc434ac | 2021-01-13 10:28:00 -1000 | [diff] [blame] | 351 | std::scoped_lock lock(mMutex); |
Adithya Srinivasan | 5f683cf | 2020-09-15 14:21:04 -0700 | [diff] [blame] | 352 | mActuals.startTime = actualStartTime; |
| 353 | } |
| 354 | |
| 355 | void SurfaceFrame::setActualQueueTime(nsecs_t actualQueueTime) { |
Siarhei Vishniakou | fc434ac | 2021-01-13 10:28:00 -1000 | [diff] [blame] | 356 | std::scoped_lock lock(mMutex); |
Adithya Srinivasan | 5f683cf | 2020-09-15 14:21:04 -0700 | [diff] [blame] | 357 | mActualQueueTime = actualQueueTime; |
| 358 | } |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 359 | |
Ady Abraham | 7f8a1e6 | 2020-09-28 16:09:35 -0700 | [diff] [blame] | 360 | void SurfaceFrame::setAcquireFenceTime(nsecs_t acquireFenceTime) { |
Siarhei Vishniakou | fc434ac | 2021-01-13 10:28:00 -1000 | [diff] [blame] | 361 | std::scoped_lock lock(mMutex); |
Vishnu Nair | bd7d07e | 2024-07-08 13:37:11 -0700 | [diff] [blame] | 362 | if (CC_UNLIKELY(acquireFenceTime == Fence::SIGNAL_TIME_PENDING)) { |
| 363 | mActuals.endTime = mActualQueueTime; |
| 364 | } else { |
| 365 | mActuals.endTime = std::max(acquireFenceTime, mActualQueueTime); |
| 366 | } |
Adithya Srinivasan | 5f683cf | 2020-09-15 14:21:04 -0700 | [diff] [blame] | 367 | } |
| 368 | |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 369 | void SurfaceFrame::setDropTime(nsecs_t dropTime) { |
| 370 | std::scoped_lock lock(mMutex); |
| 371 | mDropTime = dropTime; |
| 372 | } |
| 373 | |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 374 | void SurfaceFrame::setPresentState(PresentState presentState, nsecs_t lastLatchTime) { |
Siarhei Vishniakou | fc434ac | 2021-01-13 10:28:00 -1000 | [diff] [blame] | 375 | std::scoped_lock lock(mMutex); |
Adithya Srinivasan | b9a7dab | 2021-01-14 23:49:46 +0000 | [diff] [blame] | 376 | LOG_ALWAYS_FATAL_IF(mPresentState != PresentState::Unknown, |
| 377 | "setPresentState called on a SurfaceFrame from Layer - %s, that has a " |
| 378 | "PresentState - %s set already.", |
| 379 | mDebugName.c_str(), toString(mPresentState).c_str()); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 380 | mPresentState = presentState; |
| 381 | mLastLatchTime = lastLatchTime; |
Adithya Srinivasan | f279e04 | 2020-08-17 14:56:27 -0700 | [diff] [blame] | 382 | } |
| 383 | |
Alec Mouri | 7d436ec | 2021-01-27 20:40:50 -0800 | [diff] [blame] | 384 | void SurfaceFrame::setRenderRate(Fps renderRate) { |
| 385 | std::lock_guard<std::mutex> lock(mMutex); |
| 386 | mRenderRate = renderRate; |
| 387 | } |
| 388 | |
Pascal Muetschard | ac7bcd9 | 2023-10-03 15:05:36 +0200 | [diff] [blame] | 389 | Fps SurfaceFrame::getRenderRate() const { |
| 390 | std::lock_guard<std::mutex> lock(mMutex); |
| 391 | return mRenderRate ? *mRenderRate : mDisplayFrameRenderRate; |
| 392 | } |
| 393 | |
Adithya Srinivasan | b6a2fa1 | 2021-03-13 00:23:09 +0000 | [diff] [blame] | 394 | void SurfaceFrame::setGpuComposition() { |
| 395 | std::scoped_lock lock(mMutex); |
| 396 | mGpuComposition = true; |
| 397 | } |
| 398 | |
Sally Qi | 438eb7d | 2023-12-05 18:59:32 -0800 | [diff] [blame] | 399 | // TODO(b/316171339): migrate from perfetto side |
| 400 | bool SurfaceFrame::isSelfJanky() const { |
| 401 | int32_t jankType = getJankType().value_or(JankType::None); |
| 402 | |
| 403 | if (jankType == JankType::None) { |
| 404 | return false; |
| 405 | } |
| 406 | |
| 407 | int32_t jankBitmask = JankType::AppDeadlineMissed | JankType::Unknown; |
| 408 | if (jankType & jankBitmask) { |
| 409 | return true; |
| 410 | } |
| 411 | |
| 412 | return false; |
| 413 | } |
| 414 | |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 415 | std::optional<int32_t> SurfaceFrame::getJankType() const { |
Siarhei Vishniakou | fc434ac | 2021-01-13 10:28:00 -1000 | [diff] [blame] | 416 | std::scoped_lock lock(mMutex); |
Adithya Srinivasan | 9561943 | 2021-02-08 21:52:51 +0000 | [diff] [blame] | 417 | if (mPresentState == PresentState::Dropped) { |
Edgar Arriaga | 631e425 | 2023-03-02 02:11:24 +0000 | [diff] [blame] | 418 | return JankType::Dropped; |
Adithya Srinivasan | 9561943 | 2021-02-08 21:52:51 +0000 | [diff] [blame] | 419 | } |
Jorim Jaggi | 9c03b50 | 2020-11-24 23:51:31 +0100 | [diff] [blame] | 420 | if (mActuals.presentTime == 0) { |
Adithya Srinivasan | 9561943 | 2021-02-08 21:52:51 +0000 | [diff] [blame] | 421 | // Frame hasn't been presented yet. |
Jorim Jaggi | 9c03b50 | 2020-11-24 23:51:31 +0100 | [diff] [blame] | 422 | return std::nullopt; |
| 423 | } |
Adithya Srinivasan | 8fc601d | 2020-09-25 13:51:09 -0700 | [diff] [blame] | 424 | return mJankType; |
| 425 | } |
| 426 | |
Ying Wei | 96eb535 | 2023-11-21 17:37:21 +0000 | [diff] [blame] | 427 | std::optional<JankSeverityType> SurfaceFrame::getJankSeverityType() const { |
| 428 | std::scoped_lock lock(mMutex); |
| 429 | if (mActuals.presentTime == 0) { |
| 430 | // Frame hasn't been presented yet. |
| 431 | return std::nullopt; |
| 432 | } |
| 433 | return mJankSeverityType; |
| 434 | } |
| 435 | |
Adithya Srinivasan | 8fc601d | 2020-09-25 13:51:09 -0700 | [diff] [blame] | 436 | nsecs_t SurfaceFrame::getBaseTime() const { |
Siarhei Vishniakou | fc434ac | 2021-01-13 10:28:00 -1000 | [diff] [blame] | 437 | std::scoped_lock lock(mMutex); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 438 | return getMinTime(mPredictionState, mPredictions, mActuals); |
Adithya Srinivasan | 8fc601d | 2020-09-25 13:51:09 -0700 | [diff] [blame] | 439 | } |
| 440 | |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 441 | TimelineItem SurfaceFrame::getActuals() const { |
Siarhei Vishniakou | fc434ac | 2021-01-13 10:28:00 -1000 | [diff] [blame] | 442 | std::scoped_lock lock(mMutex); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 443 | return mActuals; |
Adithya Srinivasan | 8fc601d | 2020-09-25 13:51:09 -0700 | [diff] [blame] | 444 | } |
| 445 | |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 446 | PredictionState SurfaceFrame::getPredictionState() const { |
| 447 | std::scoped_lock lock(mMutex); |
| 448 | return mPredictionState; |
| 449 | } |
| 450 | |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 451 | SurfaceFrame::PresentState SurfaceFrame::getPresentState() const { |
Siarhei Vishniakou | fc434ac | 2021-01-13 10:28:00 -1000 | [diff] [blame] | 452 | std::scoped_lock lock(mMutex); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 453 | return mPresentState; |
| 454 | } |
| 455 | |
| 456 | FramePresentMetadata SurfaceFrame::getFramePresentMetadata() const { |
Siarhei Vishniakou | fc434ac | 2021-01-13 10:28:00 -1000 | [diff] [blame] | 457 | std::scoped_lock lock(mMutex); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 458 | return mFramePresentMetadata; |
| 459 | } |
| 460 | |
| 461 | FrameReadyMetadata SurfaceFrame::getFrameReadyMetadata() const { |
Siarhei Vishniakou | fc434ac | 2021-01-13 10:28:00 -1000 | [diff] [blame] | 462 | std::scoped_lock lock(mMutex); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 463 | return mFrameReadyMetadata; |
| 464 | } |
| 465 | |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 466 | nsecs_t SurfaceFrame::getDropTime() const { |
| 467 | std::scoped_lock lock(mMutex); |
| 468 | return mDropTime; |
| 469 | } |
| 470 | |
Adithya Srinivasan | 785addd | 2021-03-09 00:38:00 +0000 | [diff] [blame] | 471 | void SurfaceFrame::promoteToBuffer() { |
| 472 | std::scoped_lock lock(mMutex); |
| 473 | LOG_ALWAYS_FATAL_IF(mIsBuffer == true, |
| 474 | "Trying to promote an already promoted BufferSurfaceFrame from layer %s " |
| 475 | "with token %" PRId64 "", |
| 476 | mDebugName.c_str(), mToken); |
| 477 | mIsBuffer = true; |
| 478 | } |
| 479 | |
| 480 | bool SurfaceFrame::getIsBuffer() const { |
| 481 | std::scoped_lock lock(mMutex); |
| 482 | return mIsBuffer; |
| 483 | } |
| 484 | |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 485 | void SurfaceFrame::dump(std::string& result, const std::string& indent, nsecs_t baseTime) const { |
Siarhei Vishniakou | fc434ac | 2021-01-13 10:28:00 -1000 | [diff] [blame] | 486 | std::scoped_lock lock(mMutex); |
Adithya Srinivasan | 8fc601d | 2020-09-25 13:51:09 -0700 | [diff] [blame] | 487 | StringAppendF(&result, "%s", indent.c_str()); |
Alec Mouri | 9a29e67 | 2020-09-14 12:39:14 -0700 | [diff] [blame] | 488 | StringAppendF(&result, "Layer - %s", mDebugName.c_str()); |
Jorim Jaggi | 5814ab8 | 2020-12-03 20:45:58 +0100 | [diff] [blame] | 489 | if (mJankType != JankType::None) { |
Adithya Srinivasan | 8fc601d | 2020-09-25 13:51:09 -0700 | [diff] [blame] | 490 | // Easily identify a janky Surface Frame in the dump |
| 491 | StringAppendF(&result, " [*] "); |
| 492 | } |
| 493 | StringAppendF(&result, "\n"); |
| 494 | StringAppendF(&result, "%s", indent.c_str()); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 495 | StringAppendF(&result, "Token: %" PRId64 "\n", mToken); |
| 496 | StringAppendF(&result, "%s", indent.c_str()); |
Adithya Srinivasan | 785addd | 2021-03-09 00:38:00 +0000 | [diff] [blame] | 497 | StringAppendF(&result, "Is Buffer?: %d\n", mIsBuffer); |
| 498 | StringAppendF(&result, "%s", indent.c_str()); |
Adithya Srinivasan | 9febda8 | 2020-10-19 10:49:41 -0700 | [diff] [blame] | 499 | StringAppendF(&result, "Owner Pid : %d\n", mOwnerPid); |
| 500 | StringAppendF(&result, "%s", indent.c_str()); |
Alec Mouri | 7d436ec | 2021-01-27 20:40:50 -0800 | [diff] [blame] | 501 | StringAppendF(&result, "Scheduled rendering rate: %d fps\n", |
| 502 | mRenderRate ? mRenderRate->getIntValue() : 0); |
| 503 | StringAppendF(&result, "%s", indent.c_str()); |
Alec Mouri | adebf5c | 2021-01-05 12:57:36 -0800 | [diff] [blame] | 504 | StringAppendF(&result, "Layer ID : %d\n", mLayerId); |
| 505 | StringAppendF(&result, "%s", indent.c_str()); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 506 | StringAppendF(&result, "Present State : %s\n", toString(mPresentState).c_str()); |
Adithya Srinivasan | 8fc601d | 2020-09-25 13:51:09 -0700 | [diff] [blame] | 507 | StringAppendF(&result, "%s", indent.c_str()); |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 508 | if (mPresentState == PresentState::Dropped) { |
| 509 | std::chrono::nanoseconds dropTime(mDropTime - baseTime); |
| 510 | StringAppendF(&result, "Drop time : %10f\n", |
| 511 | std::chrono::duration<double, std::milli>(dropTime).count()); |
| 512 | StringAppendF(&result, "%s", indent.c_str()); |
| 513 | } |
Adithya Srinivasan | 8fc601d | 2020-09-25 13:51:09 -0700 | [diff] [blame] | 514 | StringAppendF(&result, "Prediction State : %s\n", toString(mPredictionState).c_str()); |
| 515 | StringAppendF(&result, "%s", indent.c_str()); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 516 | StringAppendF(&result, "Jank Type : %s\n", jankTypeBitmaskToString(mJankType).c_str()); |
Adithya Srinivasan | 8fc601d | 2020-09-25 13:51:09 -0700 | [diff] [blame] | 517 | StringAppendF(&result, "%s", indent.c_str()); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 518 | StringAppendF(&result, "Present Metadata : %s\n", toString(mFramePresentMetadata).c_str()); |
| 519 | StringAppendF(&result, "%s", indent.c_str()); |
| 520 | StringAppendF(&result, "Finish Metadata: %s\n", toString(mFrameReadyMetadata).c_str()); |
| 521 | std::chrono::nanoseconds latchTime( |
| 522 | std::max(static_cast<int64_t>(0), mLastLatchTime - baseTime)); |
| 523 | StringAppendF(&result, "%s", indent.c_str()); |
| 524 | StringAppendF(&result, "Last latch time: %10f\n", |
| 525 | std::chrono::duration<double, std::milli>(latchTime).count()); |
| 526 | if (mPredictionState == PredictionState::Valid) { |
| 527 | nsecs_t presentDelta = mActuals.presentTime - mPredictions.presentTime; |
| 528 | std::chrono::nanoseconds presentDeltaNs(std::abs(presentDelta)); |
| 529 | StringAppendF(&result, "%s", indent.c_str()); |
| 530 | StringAppendF(&result, "Present delta: %10f\n", |
| 531 | std::chrono::duration<double, std::milli>(presentDeltaNs).count()); |
| 532 | } |
Adithya Srinivasan | 8fc601d | 2020-09-25 13:51:09 -0700 | [diff] [blame] | 533 | dumpTable(result, mPredictions, mActuals, indent, mPredictionState, baseTime); |
Adithya Srinivasan | f279e04 | 2020-08-17 14:56:27 -0700 | [diff] [blame] | 534 | } |
| 535 | |
Adithya Srinivasan | 785addd | 2021-03-09 00:38:00 +0000 | [diff] [blame] | 536 | std::string SurfaceFrame::miniDump() const { |
| 537 | std::scoped_lock lock(mMutex); |
| 538 | std::string result; |
| 539 | StringAppendF(&result, "Layer - %s\n", mDebugName.c_str()); |
| 540 | StringAppendF(&result, "Token: %" PRId64 "\n", mToken); |
| 541 | StringAppendF(&result, "Is Buffer?: %d\n", mIsBuffer); |
| 542 | StringAppendF(&result, "Present State : %s\n", toString(mPresentState).c_str()); |
| 543 | StringAppendF(&result, "Prediction State : %s\n", toString(mPredictionState).c_str()); |
| 544 | StringAppendF(&result, "Jank Type : %s\n", jankTypeBitmaskToString(mJankType).c_str()); |
| 545 | StringAppendF(&result, "Present Metadata : %s\n", toString(mFramePresentMetadata).c_str()); |
| 546 | StringAppendF(&result, "Finish Metadata: %s\n", toString(mFrameReadyMetadata).c_str()); |
| 547 | StringAppendF(&result, "Present time: %" PRId64 "", mActuals.presentTime); |
| 548 | return result; |
| 549 | } |
| 550 | |
Adithya Srinivasan | 7c4ac7a | 2021-03-08 23:48:03 +0000 | [diff] [blame] | 551 | void SurfaceFrame::classifyJankLocked(int32_t displayFrameJankType, const Fps& refreshRate, |
Ady Abraham | e96e79f | 2024-05-20 18:00:39 +0000 | [diff] [blame] | 552 | Fps displayFrameRenderRate, nsecs_t* outDeadlineDelta) { |
Ady Abraham | e43ff72 | 2022-02-15 14:44:25 -0800 | [diff] [blame] | 553 | if (mActuals.presentTime == Fence::SIGNAL_TIME_INVALID) { |
Adithya Srinivasan | 7c4ac7a | 2021-03-08 23:48:03 +0000 | [diff] [blame] | 554 | // Cannot do any classification for invalid present time. |
Adithya Srinivasan | 7c4ac7a | 2021-03-08 23:48:03 +0000 | [diff] [blame] | 555 | mJankType = JankType::Unknown; |
Ying Wei | 96eb535 | 2023-11-21 17:37:21 +0000 | [diff] [blame] | 556 | mJankSeverityType = JankSeverityType::Unknown; |
Ady Abraham | e96e79f | 2024-05-20 18:00:39 +0000 | [diff] [blame] | 557 | if (outDeadlineDelta) { |
| 558 | *outDeadlineDelta = -1; |
| 559 | } |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 560 | return; |
| 561 | } |
| 562 | |
Ady Abraham | e43ff72 | 2022-02-15 14:44:25 -0800 | [diff] [blame] | 563 | if (mPredictionState == PredictionState::Expired) { |
| 564 | // We classify prediction expired as AppDeadlineMissed as the |
| 565 | // TokenManager::kMaxTokens we store is large enough to account for a |
| 566 | // reasonable app, so prediction expire would mean a huge scheduling delay. |
Edgar Arriaga | 631e425 | 2023-03-02 02:11:24 +0000 | [diff] [blame] | 567 | mJankType = mPresentState != PresentState::Presented ? JankType::Dropped |
| 568 | : JankType::AppDeadlineMissed; |
Ying Wei | 96eb535 | 2023-11-21 17:37:21 +0000 | [diff] [blame] | 569 | mJankSeverityType = JankSeverityType::Unknown; |
Ady Abraham | e96e79f | 2024-05-20 18:00:39 +0000 | [diff] [blame] | 570 | if (outDeadlineDelta) { |
| 571 | *outDeadlineDelta = -1; |
| 572 | } |
Ady Abraham | e43ff72 | 2022-02-15 14:44:25 -0800 | [diff] [blame] | 573 | return; |
| 574 | } |
| 575 | |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 576 | if (mPredictionState == PredictionState::None) { |
| 577 | // Cannot do jank classification on frames that don't have a token. |
| 578 | return; |
| 579 | } |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 580 | |
| 581 | const nsecs_t presentDelta = mActuals.presentTime - mPredictions.presentTime; |
Alec Mouri | adebf5c | 2021-01-05 12:57:36 -0800 | [diff] [blame] | 582 | const nsecs_t deltaToVsync = refreshRate.getPeriodNsecs() > 0 |
| 583 | ? std::abs(presentDelta) % refreshRate.getPeriodNsecs() |
| 584 | : 0; |
Ady Abraham | e96e79f | 2024-05-20 18:00:39 +0000 | [diff] [blame] | 585 | const nsecs_t deadlineDelta = mActuals.endTime - mPredictions.endTime; |
| 586 | if (outDeadlineDelta) { |
| 587 | *outDeadlineDelta = deadlineDelta; |
| 588 | } |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 589 | |
| 590 | if (deadlineDelta > mJankClassificationThresholds.deadlineThreshold) { |
| 591 | mFrameReadyMetadata = FrameReadyMetadata::LateFinish; |
| 592 | } else { |
| 593 | mFrameReadyMetadata = FrameReadyMetadata::OnTimeFinish; |
| 594 | } |
| 595 | |
| 596 | if (std::abs(presentDelta) > mJankClassificationThresholds.presentThreshold) { |
| 597 | mFramePresentMetadata = presentDelta > 0 ? FramePresentMetadata::LatePresent |
| 598 | : FramePresentMetadata::EarlyPresent; |
Ying Wei | 96eb535 | 2023-11-21 17:37:21 +0000 | [diff] [blame] | 599 | // Jank that is missing by less than the render rate period is classified as partial jank, |
| 600 | // otherwise it is a full jank. |
| 601 | mJankSeverityType = std::abs(presentDelta) < displayFrameRenderRate.getPeriodNsecs() |
| 602 | ? JankSeverityType::Partial |
| 603 | : JankSeverityType::Full; |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 604 | } else { |
| 605 | mFramePresentMetadata = FramePresentMetadata::OnTimePresent; |
| 606 | } |
| 607 | |
| 608 | if (mFramePresentMetadata == FramePresentMetadata::OnTimePresent) { |
| 609 | // Frames presented on time are not janky. |
| 610 | mJankType = JankType::None; |
| 611 | } else if (mFramePresentMetadata == FramePresentMetadata::EarlyPresent) { |
| 612 | if (mFrameReadyMetadata == FrameReadyMetadata::OnTimeFinish) { |
| 613 | // Finish on time, Present early |
| 614 | if (deltaToVsync < mJankClassificationThresholds.presentThreshold || |
Alec Mouri | 7d436ec | 2021-01-27 20:40:50 -0800 | [diff] [blame] | 615 | deltaToVsync >= refreshRate.getPeriodNsecs() - |
| 616 | mJankClassificationThresholds.presentThreshold) { |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 617 | // Delta factor of vsync |
| 618 | mJankType = JankType::SurfaceFlingerScheduling; |
| 619 | } else { |
| 620 | // Delta not a factor of vsync |
| 621 | mJankType = JankType::PredictionError; |
| 622 | } |
| 623 | } else if (mFrameReadyMetadata == FrameReadyMetadata::LateFinish) { |
| 624 | // Finish late, Present early |
| 625 | mJankType = JankType::Unknown; |
| 626 | } |
| 627 | } else { |
| 628 | if (mLastLatchTime != 0 && mPredictions.endTime <= mLastLatchTime) { |
| 629 | // Buffer Stuffing. |
| 630 | mJankType |= JankType::BufferStuffing; |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 631 | // In a stuffed state, the frame could be stuck on a dequeue wait for quite some time. |
| 632 | // Because of this dequeue wait, it can be hard to tell if a frame was genuinely late. |
| 633 | // We try to do this by moving the deadline. Since the queue could be stuffed by more |
| 634 | // than one buffer, we take the last latch time as reference and give one vsync |
| 635 | // worth of time for the frame to be ready. |
| 636 | nsecs_t adjustedDeadline = mLastLatchTime + refreshRate.getPeriodNsecs(); |
| 637 | if (adjustedDeadline > mActuals.endTime) { |
| 638 | mFrameReadyMetadata = FrameReadyMetadata::OnTimeFinish; |
| 639 | } else { |
| 640 | mFrameReadyMetadata = FrameReadyMetadata::LateFinish; |
| 641 | } |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 642 | } |
| 643 | if (mFrameReadyMetadata == FrameReadyMetadata::OnTimeFinish) { |
| 644 | // Finish on time, Present late |
| 645 | if (displayFrameJankType != JankType::None) { |
| 646 | // Propagate displayFrame's jank if it exists |
| 647 | mJankType |= displayFrameJankType; |
| 648 | } else { |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 649 | if (!(mJankType & JankType::BufferStuffing)) { |
| 650 | // In a stuffed state, if the app finishes on time and there is no display frame |
| 651 | // jank, only buffer stuffing is the root cause of the jank. |
| 652 | if (deltaToVsync < mJankClassificationThresholds.presentThreshold || |
| 653 | deltaToVsync >= refreshRate.getPeriodNsecs() - |
| 654 | mJankClassificationThresholds.presentThreshold) { |
| 655 | // Delta factor of vsync |
| 656 | mJankType |= JankType::SurfaceFlingerScheduling; |
| 657 | } else { |
| 658 | // Delta not a factor of vsync |
| 659 | mJankType |= JankType::PredictionError; |
| 660 | } |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 661 | } |
| 662 | } |
| 663 | } else if (mFrameReadyMetadata == FrameReadyMetadata::LateFinish) { |
| 664 | // Finish late, Present late |
Adithya Srinivasan | 8a94550 | 2021-03-19 19:12:32 +0000 | [diff] [blame] | 665 | mJankType |= JankType::AppDeadlineMissed; |
| 666 | // Propagate DisplayFrame's jankType if it is janky |
| 667 | mJankType |= displayFrameJankType; |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 668 | } |
| 669 | } |
Edgar Arriaga | 631e425 | 2023-03-02 02:11:24 +0000 | [diff] [blame] | 670 | if (mPresentState != PresentState::Presented) { |
| 671 | mJankType = JankType::Dropped; |
| 672 | // Since frame was not presented, lets drop any present value |
| 673 | mActuals.presentTime = 0; |
Ying Wei | 96eb535 | 2023-11-21 17:37:21 +0000 | [diff] [blame] | 674 | mJankSeverityType = JankSeverityType::Unknown; |
Edgar Arriaga | 631e425 | 2023-03-02 02:11:24 +0000 | [diff] [blame] | 675 | } |
Adithya Srinivasan | 7c4ac7a | 2021-03-08 23:48:03 +0000 | [diff] [blame] | 676 | } |
| 677 | |
| 678 | void SurfaceFrame::onPresent(nsecs_t presentTime, int32_t displayFrameJankType, Fps refreshRate, |
Pascal Muetschard | ac7bcd9 | 2023-10-03 15:05:36 +0200 | [diff] [blame] | 679 | Fps displayFrameRenderRate, nsecs_t displayDeadlineDelta, |
| 680 | nsecs_t displayPresentDelta) { |
Adithya Srinivasan | 7c4ac7a | 2021-03-08 23:48:03 +0000 | [diff] [blame] | 681 | std::scoped_lock lock(mMutex); |
| 682 | |
Pascal Muetschard | ac7bcd9 | 2023-10-03 15:05:36 +0200 | [diff] [blame] | 683 | mDisplayFrameRenderRate = displayFrameRenderRate; |
Adithya Srinivasan | 7c4ac7a | 2021-03-08 23:48:03 +0000 | [diff] [blame] | 684 | mActuals.presentTime = presentTime; |
| 685 | nsecs_t deadlineDelta = 0; |
| 686 | |
Ady Abraham | e96e79f | 2024-05-20 18:00:39 +0000 | [diff] [blame] | 687 | classifyJankLocked(displayFrameJankType, refreshRate, displayFrameRenderRate, &deadlineDelta); |
Adithya Srinivasan | 7c4ac7a | 2021-03-08 23:48:03 +0000 | [diff] [blame] | 688 | |
| 689 | if (mPredictionState != PredictionState::None) { |
| 690 | // Only update janky frames if the app used vsync predictions |
| 691 | mTimeStats->incrementJankyFrames({refreshRate, mRenderRate, mOwnerUid, mLayerName, |
Adithya Srinivasan | 58069dc | 2021-06-04 20:37:02 +0000 | [diff] [blame] | 692 | mGameMode, mJankType, displayDeadlineDelta, |
| 693 | displayPresentDelta, deadlineDelta}); |
Pascal Mütschard | d56514e | 2024-05-24 17:37:13 +0200 | [diff] [blame] | 694 | |
| 695 | gui::JankData jd; |
| 696 | jd.frameVsyncId = mToken; |
| 697 | jd.jankType = mJankType; |
| 698 | jd.frameIntervalNs = |
| 699 | (mRenderRate ? *mRenderRate : mDisplayFrameRenderRate).getPeriodNsecs(); |
Pascal Mütschard | 0e8452b | 2024-09-03 11:02:11 +0200 | [diff] [blame^] | 700 | |
| 701 | if (mPredictionState == PredictionState::Valid) { |
| 702 | jd.scheduledAppFrameTimeNs = mPredictions.endTime - mPredictions.startTime; |
| 703 | |
| 704 | // Using expected start, rather than actual, to measure the entire frame time. That is |
| 705 | // if the application starts the frame later than scheduled, include that delay in the |
| 706 | // frame time, as it usually means main thread being busy with non-rendering work. |
| 707 | if (mPresentState == PresentState::Dropped) { |
| 708 | jd.actualAppFrameTimeNs = mDropTime - mPredictions.startTime; |
| 709 | } else { |
| 710 | jd.actualAppFrameTimeNs = mActuals.endTime - mPredictions.startTime; |
| 711 | } |
| 712 | } else { |
| 713 | jd.scheduledAppFrameTimeNs = 0; |
| 714 | jd.actualAppFrameTimeNs = 0; |
| 715 | } |
| 716 | |
Pascal Mütschard | d56514e | 2024-05-24 17:37:13 +0200 | [diff] [blame] | 717 | JankTracker::onJankData(mLayerId, jd); |
Adithya Srinivasan | 7c4ac7a | 2021-03-08 23:48:03 +0000 | [diff] [blame] | 718 | } |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 719 | } |
| 720 | |
Ady Abraham | 14beed7 | 2024-05-15 17:16:45 -0700 | [diff] [blame] | 721 | void SurfaceFrame::onCommitNotComposited(Fps refreshRate, Fps displayFrameRenderRate) { |
| 722 | std::scoped_lock lock(mMutex); |
| 723 | |
| 724 | mDisplayFrameRenderRate = displayFrameRenderRate; |
| 725 | mActuals.presentTime = mPredictions.presentTime; |
Ady Abraham | e96e79f | 2024-05-20 18:00:39 +0000 | [diff] [blame] | 726 | classifyJankLocked(JankType::None, refreshRate, displayFrameRenderRate, nullptr); |
Ady Abraham | 14beed7 | 2024-05-15 17:16:45 -0700 | [diff] [blame] | 727 | } |
| 728 | |
Ady Abraham | 57f8e18 | 2022-03-08 15:54:33 -0800 | [diff] [blame] | 729 | void SurfaceFrame::tracePredictions(int64_t displayFrameToken, nsecs_t monoBootOffset) const { |
Adithya Srinivasan | 8667850 | 2021-01-19 21:50:38 +0000 | [diff] [blame] | 730 | int64_t expectedTimelineCookie = mTraceCookieCounter.getCookieForTracing(); |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 731 | |
Adithya Srinivasan | 8667850 | 2021-01-19 21:50:38 +0000 | [diff] [blame] | 732 | // Expected timeline start |
| 733 | FrameTimelineDataSource::Trace([&](FrameTimelineDataSource::TraceContext ctx) { |
Siarhei Vishniakou | fc434ac | 2021-01-13 10:28:00 -1000 | [diff] [blame] | 734 | std::scoped_lock lock(mMutex); |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 735 | auto packet = ctx.NewTracePacket(); |
Ady Abraham | 57f8e18 | 2022-03-08 15:54:33 -0800 | [diff] [blame] | 736 | packet->set_timestamp_clock_id(perfetto::protos::pbzero::BUILTIN_CLOCK_BOOTTIME); |
| 737 | packet->set_timestamp(static_cast<uint64_t>(mPredictions.startTime + monoBootOffset)); |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 738 | |
| 739 | auto* event = packet->set_frame_timeline_event(); |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 740 | auto* expectedSurfaceFrameStartEvent = event->set_expected_surface_frame_start(); |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 741 | |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 742 | expectedSurfaceFrameStartEvent->set_cookie(expectedTimelineCookie); |
| 743 | |
| 744 | expectedSurfaceFrameStartEvent->set_token(mToken); |
| 745 | expectedSurfaceFrameStartEvent->set_display_frame_token(displayFrameToken); |
| 746 | |
| 747 | expectedSurfaceFrameStartEvent->set_pid(mOwnerPid); |
| 748 | expectedSurfaceFrameStartEvent->set_layer_name(mDebugName); |
| 749 | }); |
Adithya Srinivasan | 8667850 | 2021-01-19 21:50:38 +0000 | [diff] [blame] | 750 | |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 751 | // Expected timeline end |
| 752 | FrameTimelineDataSource::Trace([&](FrameTimelineDataSource::TraceContext ctx) { |
Siarhei Vishniakou | fc434ac | 2021-01-13 10:28:00 -1000 | [diff] [blame] | 753 | std::scoped_lock lock(mMutex); |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 754 | auto packet = ctx.NewTracePacket(); |
Ady Abraham | 57f8e18 | 2022-03-08 15:54:33 -0800 | [diff] [blame] | 755 | packet->set_timestamp_clock_id(perfetto::protos::pbzero::BUILTIN_CLOCK_BOOTTIME); |
| 756 | packet->set_timestamp(static_cast<uint64_t>(mPredictions.endTime + monoBootOffset)); |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 757 | |
| 758 | auto* event = packet->set_frame_timeline_event(); |
| 759 | auto* expectedSurfaceFrameEndEvent = event->set_frame_end(); |
| 760 | |
| 761 | expectedSurfaceFrameEndEvent->set_cookie(expectedTimelineCookie); |
| 762 | }); |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 763 | } |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 764 | |
Ady Abraham | 57f8e18 | 2022-03-08 15:54:33 -0800 | [diff] [blame] | 765 | void SurfaceFrame::traceActuals(int64_t displayFrameToken, nsecs_t monoBootOffset) const { |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 766 | int64_t actualTimelineCookie = mTraceCookieCounter.getCookieForTracing(); |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 767 | |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 768 | // Actual timeline start |
| 769 | FrameTimelineDataSource::Trace([&](FrameTimelineDataSource::TraceContext ctx) { |
Siarhei Vishniakou | fc434ac | 2021-01-13 10:28:00 -1000 | [diff] [blame] | 770 | std::scoped_lock lock(mMutex); |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 771 | auto packet = ctx.NewTracePacket(); |
Ady Abraham | 57f8e18 | 2022-03-08 15:54:33 -0800 | [diff] [blame] | 772 | packet->set_timestamp_clock_id(perfetto::protos::pbzero::BUILTIN_CLOCK_BOOTTIME); |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 773 | // Actual start time is not yet available, so use expected start instead |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 774 | if (mPredictionState == PredictionState::Expired) { |
| 775 | // If prediction is expired, we can't use the predicted start time. Instead, just use a |
| 776 | // start time a little earlier than the end time so that we have some info about this |
| 777 | // frame in the trace. |
Adithya Srinivasan | b2283c3 | 2021-04-21 21:31:56 +0000 | [diff] [blame] | 778 | nsecs_t endTime = |
| 779 | (mPresentState == PresentState::Dropped ? mDropTime : mActuals.endTime); |
Ady Abraham | dee2232 | 2022-03-18 10:58:39 -0700 | [diff] [blame] | 780 | const auto timestamp = endTime - kPredictionExpiredStartTimeDelta; |
| 781 | packet->set_timestamp(static_cast<uint64_t>(timestamp + monoBootOffset)); |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 782 | } else { |
Ady Abraham | dee2232 | 2022-03-18 10:58:39 -0700 | [diff] [blame] | 783 | const auto timestamp = |
| 784 | mActuals.startTime == 0 ? mPredictions.startTime : mActuals.startTime; |
| 785 | packet->set_timestamp(static_cast<uint64_t>(timestamp + monoBootOffset)); |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 786 | } |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 787 | |
| 788 | auto* event = packet->set_frame_timeline_event(); |
| 789 | auto* actualSurfaceFrameStartEvent = event->set_actual_surface_frame_start(); |
| 790 | |
| 791 | actualSurfaceFrameStartEvent->set_cookie(actualTimelineCookie); |
| 792 | |
| 793 | actualSurfaceFrameStartEvent->set_token(mToken); |
| 794 | actualSurfaceFrameStartEvent->set_display_frame_token(displayFrameToken); |
| 795 | |
| 796 | actualSurfaceFrameStartEvent->set_pid(mOwnerPid); |
| 797 | actualSurfaceFrameStartEvent->set_layer_name(mDebugName); |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 798 | |
| 799 | if (mPresentState == PresentState::Dropped) { |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 800 | actualSurfaceFrameStartEvent->set_present_type(FrameTimelineEvent::PRESENT_DROPPED); |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 801 | } else if (mPresentState == PresentState::Unknown) { |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 802 | actualSurfaceFrameStartEvent->set_present_type(FrameTimelineEvent::PRESENT_UNSPECIFIED); |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 803 | } else { |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 804 | actualSurfaceFrameStartEvent->set_present_type(toProto(mFramePresentMetadata)); |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 805 | } |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 806 | actualSurfaceFrameStartEvent->set_on_time_finish(mFrameReadyMetadata == |
| 807 | FrameReadyMetadata::OnTimeFinish); |
| 808 | actualSurfaceFrameStartEvent->set_gpu_composition(mGpuComposition); |
| 809 | actualSurfaceFrameStartEvent->set_jank_type(jankTypeBitmaskToProto(mJankType)); |
Adithya Srinivasan | 78e58af | 2021-02-25 00:08:08 +0000 | [diff] [blame] | 810 | actualSurfaceFrameStartEvent->set_prediction_type(toProto(mPredictionState)); |
Adithya Srinivasan | 1f9450c | 2021-06-10 22:39:19 +0000 | [diff] [blame] | 811 | actualSurfaceFrameStartEvent->set_is_buffer(mIsBuffer); |
Ying Wei | 96eb535 | 2023-11-21 17:37:21 +0000 | [diff] [blame] | 812 | actualSurfaceFrameStartEvent->set_jank_severity_type(toProto(mJankSeverityType)); |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 813 | }); |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 814 | |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 815 | // Actual timeline end |
| 816 | FrameTimelineDataSource::Trace([&](FrameTimelineDataSource::TraceContext ctx) { |
Siarhei Vishniakou | fc434ac | 2021-01-13 10:28:00 -1000 | [diff] [blame] | 817 | std::scoped_lock lock(mMutex); |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 818 | auto packet = ctx.NewTracePacket(); |
Ady Abraham | 57f8e18 | 2022-03-08 15:54:33 -0800 | [diff] [blame] | 819 | packet->set_timestamp_clock_id(perfetto::protos::pbzero::BUILTIN_CLOCK_BOOTTIME); |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 820 | if (mPresentState == PresentState::Dropped) { |
Ady Abraham | 57f8e18 | 2022-03-08 15:54:33 -0800 | [diff] [blame] | 821 | packet->set_timestamp(static_cast<uint64_t>(mDropTime + monoBootOffset)); |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 822 | } else { |
Ady Abraham | 57f8e18 | 2022-03-08 15:54:33 -0800 | [diff] [blame] | 823 | packet->set_timestamp(static_cast<uint64_t>(mActuals.endTime + monoBootOffset)); |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 824 | } |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 825 | |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 826 | auto* event = packet->set_frame_timeline_event(); |
| 827 | auto* actualSurfaceFrameEndEvent = event->set_frame_end(); |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 828 | |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 829 | actualSurfaceFrameEndEvent->set_cookie(actualTimelineCookie); |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 830 | }); |
| 831 | } |
| 832 | |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 833 | /** |
| 834 | * TODO(b/178637512): add inputEventId to the perfetto trace. |
| 835 | */ |
Ady Abraham | 57f8e18 | 2022-03-08 15:54:33 -0800 | [diff] [blame] | 836 | void SurfaceFrame::trace(int64_t displayFrameToken, nsecs_t monoBootOffset) const { |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 837 | if (mToken == FrameTimelineInfo::INVALID_VSYNC_ID || |
| 838 | displayFrameToken == FrameTimelineInfo::INVALID_VSYNC_ID) { |
| 839 | // No packets can be traced with a missing token. |
| 840 | return; |
| 841 | } |
| 842 | if (getPredictionState() != PredictionState::Expired) { |
| 843 | // Expired predictions have zeroed timestamps. This cannot be used in any meaningful way in |
| 844 | // a trace. |
Ady Abraham | 57f8e18 | 2022-03-08 15:54:33 -0800 | [diff] [blame] | 845 | tracePredictions(displayFrameToken, monoBootOffset); |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 846 | } |
Ady Abraham | 57f8e18 | 2022-03-08 15:54:33 -0800 | [diff] [blame] | 847 | traceActuals(displayFrameToken, monoBootOffset); |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 848 | } |
| 849 | |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 850 | namespace impl { |
| 851 | |
| 852 | int64_t TokenManager::generateTokenForPredictions(TimelineItem&& predictions) { |
Vishnu Nair | be0ad90 | 2024-06-27 23:38:43 +0000 | [diff] [blame] | 853 | SFTRACE_CALL(); |
Siarhei Vishniakou | fc434ac | 2021-01-13 10:28:00 -1000 | [diff] [blame] | 854 | std::scoped_lock lock(mMutex); |
Adithya Srinivasan | bed4c4f | 2021-05-03 20:24:46 +0000 | [diff] [blame] | 855 | while (mPredictions.size() >= kMaxTokens) { |
| 856 | mPredictions.erase(mPredictions.begin()); |
| 857 | } |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 858 | const int64_t assignedToken = mCurrentToken++; |
Adithya Srinivasan | bed4c4f | 2021-05-03 20:24:46 +0000 | [diff] [blame] | 859 | mPredictions[assignedToken] = predictions; |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 860 | return assignedToken; |
| 861 | } |
| 862 | |
| 863 | std::optional<TimelineItem> TokenManager::getPredictionsForToken(int64_t token) const { |
Siarhei Vishniakou | fc434ac | 2021-01-13 10:28:00 -1000 | [diff] [blame] | 864 | std::scoped_lock lock(mMutex); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 865 | auto predictionsIterator = mPredictions.find(token); |
| 866 | if (predictionsIterator != mPredictions.end()) { |
Adithya Srinivasan | bed4c4f | 2021-05-03 20:24:46 +0000 | [diff] [blame] | 867 | return predictionsIterator->second; |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 868 | } |
| 869 | return {}; |
| 870 | } |
| 871 | |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 872 | FrameTimeline::FrameTimeline(std::shared_ptr<TimeStats> timeStats, pid_t surfaceFlingerPid, |
Ady Abraham | 57f8e18 | 2022-03-08 15:54:33 -0800 | [diff] [blame] | 873 | JankClassificationThresholds thresholds, bool useBootTimeClock) |
| 874 | : mUseBootTimeClock(useBootTimeClock), |
| 875 | mMaxDisplayFrames(kDefaultMaxDisplayFrames), |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 876 | mTimeStats(std::move(timeStats)), |
| 877 | mSurfaceFlingerPid(surfaceFlingerPid), |
Adithya Srinivasan | 82eef32 | 2021-04-10 00:06:04 +0000 | [diff] [blame] | 878 | mJankClassificationThresholds(thresholds) { |
| 879 | mCurrentDisplayFrame = |
| 880 | std::make_shared<DisplayFrame>(mTimeStats, thresholds, &mTraceCookieCounter); |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 881 | } |
Adithya Srinivasan | f279e04 | 2020-08-17 14:56:27 -0700 | [diff] [blame] | 882 | |
Adithya Srinivasan | 0118967 | 2020-10-20 14:23:05 -0700 | [diff] [blame] | 883 | void FrameTimeline::onBootFinished() { |
| 884 | perfetto::TracingInitArgs args; |
| 885 | args.backends = perfetto::kSystemBackend; |
| 886 | perfetto::Tracing::Initialize(args); |
| 887 | registerDataSource(); |
| 888 | } |
| 889 | |
| 890 | void FrameTimeline::registerDataSource() { |
| 891 | perfetto::DataSourceDescriptor dsd; |
| 892 | dsd.set_name(kFrameTimelineDataSource); |
| 893 | FrameTimelineDataSource::Register(dsd); |
| 894 | } |
| 895 | |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 896 | std::shared_ptr<SurfaceFrame> FrameTimeline::createSurfaceFrameForToken( |
Alec Mouri | adebf5c | 2021-01-05 12:57:36 -0800 | [diff] [blame] | 897 | const FrameTimelineInfo& frameTimelineInfo, pid_t ownerPid, uid_t ownerUid, int32_t layerId, |
Dominik Laskowski | f5d0ea5 | 2021-09-26 17:27:01 -0700 | [diff] [blame] | 898 | std::string layerName, std::string debugName, bool isBuffer, GameMode gameMode) { |
Vishnu Nair | be0ad90 | 2024-06-27 23:38:43 +0000 | [diff] [blame] | 899 | SFTRACE_CALL(); |
Siarhei Vishniakou | fc434ac | 2021-01-13 10:28:00 -1000 | [diff] [blame] | 900 | if (frameTimelineInfo.vsyncId == FrameTimelineInfo::INVALID_VSYNC_ID) { |
Alec Mouri | adebf5c | 2021-01-05 12:57:36 -0800 | [diff] [blame] | 901 | return std::make_shared<SurfaceFrame>(frameTimelineInfo, ownerPid, ownerUid, layerId, |
Siarhei Vishniakou | fc434ac | 2021-01-13 10:28:00 -1000 | [diff] [blame] | 902 | std::move(layerName), std::move(debugName), |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 903 | PredictionState::None, TimelineItem(), mTimeStats, |
Adithya Srinivasan | 785addd | 2021-03-09 00:38:00 +0000 | [diff] [blame] | 904 | mJankClassificationThresholds, &mTraceCookieCounter, |
Adithya Srinivasan | 58069dc | 2021-06-04 20:37:02 +0000 | [diff] [blame] | 905 | isBuffer, gameMode); |
Adithya Srinivasan | f279e04 | 2020-08-17 14:56:27 -0700 | [diff] [blame] | 906 | } |
Siarhei Vishniakou | fc434ac | 2021-01-13 10:28:00 -1000 | [diff] [blame] | 907 | std::optional<TimelineItem> predictions = |
| 908 | mTokenManager.getPredictionsForToken(frameTimelineInfo.vsyncId); |
Adithya Srinivasan | f279e04 | 2020-08-17 14:56:27 -0700 | [diff] [blame] | 909 | if (predictions) { |
Alec Mouri | adebf5c | 2021-01-05 12:57:36 -0800 | [diff] [blame] | 910 | return std::make_shared<SurfaceFrame>(frameTimelineInfo, ownerPid, ownerUid, layerId, |
Siarhei Vishniakou | fc434ac | 2021-01-13 10:28:00 -1000 | [diff] [blame] | 911 | std::move(layerName), std::move(debugName), |
| 912 | PredictionState::Valid, std::move(*predictions), |
| 913 | mTimeStats, mJankClassificationThresholds, |
Adithya Srinivasan | 58069dc | 2021-06-04 20:37:02 +0000 | [diff] [blame] | 914 | &mTraceCookieCounter, isBuffer, gameMode); |
Adithya Srinivasan | f279e04 | 2020-08-17 14:56:27 -0700 | [diff] [blame] | 915 | } |
Alec Mouri | adebf5c | 2021-01-05 12:57:36 -0800 | [diff] [blame] | 916 | return std::make_shared<SurfaceFrame>(frameTimelineInfo, ownerPid, ownerUid, layerId, |
Siarhei Vishniakou | fc434ac | 2021-01-13 10:28:00 -1000 | [diff] [blame] | 917 | std::move(layerName), std::move(debugName), |
| 918 | PredictionState::Expired, TimelineItem(), mTimeStats, |
Adithya Srinivasan | 785addd | 2021-03-09 00:38:00 +0000 | [diff] [blame] | 919 | mJankClassificationThresholds, &mTraceCookieCounter, |
Adithya Srinivasan | 58069dc | 2021-06-04 20:37:02 +0000 | [diff] [blame] | 920 | isBuffer, gameMode); |
Adithya Srinivasan | f279e04 | 2020-08-17 14:56:27 -0700 | [diff] [blame] | 921 | } |
| 922 | |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 923 | FrameTimeline::DisplayFrame::DisplayFrame(std::shared_ptr<TimeStats> timeStats, |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 924 | JankClassificationThresholds thresholds, |
| 925 | TraceCookieCounter* traceCookieCounter) |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 926 | : mSurfaceFlingerPredictions(TimelineItem()), |
| 927 | mSurfaceFlingerActuals(TimelineItem()), |
| 928 | mTimeStats(timeStats), |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 929 | mJankClassificationThresholds(thresholds), |
| 930 | mTraceCookieCounter(*traceCookieCounter) { |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 931 | mSurfaceFrames.reserve(kNumSurfaceFramesInitial); |
Adithya Srinivasan | f279e04 | 2020-08-17 14:56:27 -0700 | [diff] [blame] | 932 | } |
| 933 | |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 934 | void FrameTimeline::addSurfaceFrame(std::shared_ptr<SurfaceFrame> surfaceFrame) { |
Vishnu Nair | be0ad90 | 2024-06-27 23:38:43 +0000 | [diff] [blame] | 935 | SFTRACE_CALL(); |
Siarhei Vishniakou | fc434ac | 2021-01-13 10:28:00 -1000 | [diff] [blame] | 936 | std::scoped_lock lock(mMutex); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 937 | mCurrentDisplayFrame->addSurfaceFrame(surfaceFrame); |
| 938 | } |
| 939 | |
Pascal Muetschard | ac7bcd9 | 2023-10-03 15:05:36 +0200 | [diff] [blame] | 940 | void FrameTimeline::setSfWakeUp(int64_t token, nsecs_t wakeUpTime, Fps refreshRate, |
| 941 | Fps renderRate) { |
Vishnu Nair | be0ad90 | 2024-06-27 23:38:43 +0000 | [diff] [blame] | 942 | SFTRACE_CALL(); |
Siarhei Vishniakou | fc434ac | 2021-01-13 10:28:00 -1000 | [diff] [blame] | 943 | std::scoped_lock lock(mMutex); |
Pascal Muetschard | ac7bcd9 | 2023-10-03 15:05:36 +0200 | [diff] [blame] | 944 | mCurrentDisplayFrame->onSfWakeUp(token, refreshRate, renderRate, |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 945 | mTokenManager.getPredictionsForToken(token), wakeUpTime); |
Adithya Srinivasan | f279e04 | 2020-08-17 14:56:27 -0700 | [diff] [blame] | 946 | } |
| 947 | |
| 948 | void FrameTimeline::setSfPresent(nsecs_t sfPresentTime, |
Adithya Srinivasan | b6a2fa1 | 2021-03-13 00:23:09 +0000 | [diff] [blame] | 949 | const std::shared_ptr<FenceTime>& presentFence, |
Adithya Srinivasan | 36b01af | 2021-04-07 22:29:47 +0000 | [diff] [blame] | 950 | const std::shared_ptr<FenceTime>& gpuFence) { |
Vishnu Nair | be0ad90 | 2024-06-27 23:38:43 +0000 | [diff] [blame] | 951 | SFTRACE_CALL(); |
Siarhei Vishniakou | fc434ac | 2021-01-13 10:28:00 -1000 | [diff] [blame] | 952 | std::scoped_lock lock(mMutex); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 953 | mCurrentDisplayFrame->setActualEndTime(sfPresentTime); |
Adithya Srinivasan | 36b01af | 2021-04-07 22:29:47 +0000 | [diff] [blame] | 954 | mCurrentDisplayFrame->setGpuFence(gpuFence); |
Adithya Srinivasan | f279e04 | 2020-08-17 14:56:27 -0700 | [diff] [blame] | 955 | mPendingPresentFences.emplace_back(std::make_pair(presentFence, mCurrentDisplayFrame)); |
| 956 | flushPendingPresentFences(); |
| 957 | finalizeCurrentDisplayFrame(); |
| 958 | } |
| 959 | |
Ady Abraham | 14beed7 | 2024-05-15 17:16:45 -0700 | [diff] [blame] | 960 | void FrameTimeline::onCommitNotComposited() { |
Vishnu Nair | be0ad90 | 2024-06-27 23:38:43 +0000 | [diff] [blame] | 961 | SFTRACE_CALL(); |
Ady Abraham | 14beed7 | 2024-05-15 17:16:45 -0700 | [diff] [blame] | 962 | std::scoped_lock lock(mMutex); |
| 963 | mCurrentDisplayFrame->onCommitNotComposited(); |
| 964 | mCurrentDisplayFrame.reset(); |
| 965 | mCurrentDisplayFrame = std::make_shared<DisplayFrame>(mTimeStats, mJankClassificationThresholds, |
| 966 | &mTraceCookieCounter); |
| 967 | } |
| 968 | |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 969 | void FrameTimeline::DisplayFrame::addSurfaceFrame(std::shared_ptr<SurfaceFrame> surfaceFrame) { |
| 970 | mSurfaceFrames.push_back(surfaceFrame); |
| 971 | } |
| 972 | |
Pascal Muetschard | ac7bcd9 | 2023-10-03 15:05:36 +0200 | [diff] [blame] | 973 | void FrameTimeline::DisplayFrame::onSfWakeUp(int64_t token, Fps refreshRate, Fps renderRate, |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 974 | std::optional<TimelineItem> predictions, |
| 975 | nsecs_t wakeUpTime) { |
| 976 | mToken = token; |
Alec Mouri | 7d436ec | 2021-01-27 20:40:50 -0800 | [diff] [blame] | 977 | mRefreshRate = refreshRate; |
Pascal Muetschard | ac7bcd9 | 2023-10-03 15:05:36 +0200 | [diff] [blame] | 978 | mRenderRate = renderRate; |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 979 | if (!predictions) { |
| 980 | mPredictionState = PredictionState::Expired; |
| 981 | } else { |
| 982 | mPredictionState = PredictionState::Valid; |
| 983 | mSurfaceFlingerPredictions = *predictions; |
| 984 | } |
| 985 | mSurfaceFlingerActuals.startTime = wakeUpTime; |
| 986 | } |
| 987 | |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 988 | void FrameTimeline::DisplayFrame::setPredictions(PredictionState predictionState, |
| 989 | TimelineItem predictions) { |
| 990 | mPredictionState = predictionState; |
| 991 | mSurfaceFlingerPredictions = predictions; |
| 992 | } |
| 993 | |
| 994 | void FrameTimeline::DisplayFrame::setActualStartTime(nsecs_t actualStartTime) { |
| 995 | mSurfaceFlingerActuals.startTime = actualStartTime; |
| 996 | } |
| 997 | |
| 998 | void FrameTimeline::DisplayFrame::setActualEndTime(nsecs_t actualEndTime) { |
| 999 | mSurfaceFlingerActuals.endTime = actualEndTime; |
| 1000 | } |
| 1001 | |
Adithya Srinivasan | 36b01af | 2021-04-07 22:29:47 +0000 | [diff] [blame] | 1002 | void FrameTimeline::DisplayFrame::setGpuFence(const std::shared_ptr<FenceTime>& gpuFence) { |
| 1003 | mGpuFence = gpuFence; |
Adithya Srinivasan | b6a2fa1 | 2021-03-13 00:23:09 +0000 | [diff] [blame] | 1004 | } |
| 1005 | |
Adithya Srinivasan | 57dc81d | 2021-04-14 17:31:41 +0000 | [diff] [blame] | 1006 | void FrameTimeline::DisplayFrame::classifyJank(nsecs_t& deadlineDelta, nsecs_t& deltaToVsync, |
| 1007 | nsecs_t previousPresentTime) { |
Ady Abraham | b1e10d1 | 2023-03-13 15:23:54 -0700 | [diff] [blame] | 1008 | const bool presentTimeValid = |
| 1009 | mSurfaceFlingerActuals.presentTime >= mSurfaceFlingerActuals.startTime; |
| 1010 | if (mPredictionState == PredictionState::Expired || !presentTimeValid) { |
Adithya Srinivasan | de27245 | 2021-04-10 00:21:00 +0000 | [diff] [blame] | 1011 | // Cannot do jank classification with expired predictions or invalid signal times. Set the |
| 1012 | // deltas to 0 as both negative and positive deltas are used as real values. |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 1013 | mJankType = JankType::Unknown; |
Ying Wei | 96eb535 | 2023-11-21 17:37:21 +0000 | [diff] [blame] | 1014 | mJankSeverityType = JankSeverityType::Unknown; |
Adithya Srinivasan | de27245 | 2021-04-10 00:21:00 +0000 | [diff] [blame] | 1015 | deadlineDelta = 0; |
| 1016 | deltaToVsync = 0; |
Ady Abraham | b1e10d1 | 2023-03-13 15:23:54 -0700 | [diff] [blame] | 1017 | if (!presentTimeValid) { |
Ady Abraham | fcb1686 | 2022-10-10 14:35:21 -0700 | [diff] [blame] | 1018 | mSurfaceFlingerActuals.presentTime = mSurfaceFlingerActuals.endTime; |
Ady Abraham | b1e10d1 | 2023-03-13 15:23:54 -0700 | [diff] [blame] | 1019 | mJankType |= JankType::DisplayHAL; |
Ady Abraham | fcb1686 | 2022-10-10 14:35:21 -0700 | [diff] [blame] | 1020 | } |
| 1021 | |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 1022 | return; |
| 1023 | } |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1024 | |
| 1025 | // Delta between the expected present and the actual present |
| 1026 | const nsecs_t presentDelta = |
| 1027 | mSurfaceFlingerActuals.presentTime - mSurfaceFlingerPredictions.presentTime; |
Adithya Srinivasan | 36b01af | 2021-04-07 22:29:47 +0000 | [diff] [blame] | 1028 | // Sf actual end time represents the CPU end time. In case of HWC, SF's end time would have |
| 1029 | // included the time for composition. However, for GPU composition, the final end time is max(sf |
| 1030 | // end time, gpu fence time). |
| 1031 | nsecs_t combinedEndTime = mSurfaceFlingerActuals.endTime; |
| 1032 | if (mGpuFence != FenceTime::NO_FENCE) { |
| 1033 | combinedEndTime = std::max(combinedEndTime, mGpuFence->getSignalTime()); |
| 1034 | } |
| 1035 | deadlineDelta = combinedEndTime - mSurfaceFlingerPredictions.endTime; |
Alec Mouri | 363faf0 | 2021-01-29 16:34:55 -0800 | [diff] [blame] | 1036 | |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1037 | // How far off was the presentDelta when compared to the vsyncPeriod. Used in checking if there |
| 1038 | // was a prediction error or not. |
Adithya Srinivasan | 115ac69 | 2021-03-06 01:21:30 +0000 | [diff] [blame] | 1039 | deltaToVsync = mRefreshRate.getPeriodNsecs() > 0 |
Alec Mouri | adebf5c | 2021-01-05 12:57:36 -0800 | [diff] [blame] | 1040 | ? std::abs(presentDelta) % mRefreshRate.getPeriodNsecs() |
| 1041 | : 0; |
Adithya Srinivasan | 115ac69 | 2021-03-06 01:21:30 +0000 | [diff] [blame] | 1042 | |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1043 | if (std::abs(presentDelta) > mJankClassificationThresholds.presentThreshold) { |
| 1044 | mFramePresentMetadata = presentDelta > 0 ? FramePresentMetadata::LatePresent |
| 1045 | : FramePresentMetadata::EarlyPresent; |
Ying Wei | 96eb535 | 2023-11-21 17:37:21 +0000 | [diff] [blame] | 1046 | // Jank that is missing by less than the render rate period is classified as partial jank, |
| 1047 | // otherwise it is a full jank. |
| 1048 | mJankSeverityType = std::abs(presentDelta) < mRenderRate.getPeriodNsecs() |
| 1049 | ? JankSeverityType::Partial |
| 1050 | : JankSeverityType::Full; |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1051 | } else { |
| 1052 | mFramePresentMetadata = FramePresentMetadata::OnTimePresent; |
| 1053 | } |
| 1054 | |
Adithya Srinivasan | 36b01af | 2021-04-07 22:29:47 +0000 | [diff] [blame] | 1055 | if (combinedEndTime > mSurfaceFlingerPredictions.endTime) { |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1056 | mFrameReadyMetadata = FrameReadyMetadata::LateFinish; |
| 1057 | } else { |
| 1058 | mFrameReadyMetadata = FrameReadyMetadata::OnTimeFinish; |
| 1059 | } |
| 1060 | |
| 1061 | if (std::abs(mSurfaceFlingerActuals.startTime - mSurfaceFlingerPredictions.startTime) > |
| 1062 | mJankClassificationThresholds.startThreshold) { |
| 1063 | mFrameStartMetadata = |
| 1064 | mSurfaceFlingerActuals.startTime > mSurfaceFlingerPredictions.startTime |
| 1065 | ? FrameStartMetadata::LateStart |
| 1066 | : FrameStartMetadata::EarlyStart; |
| 1067 | } |
| 1068 | |
| 1069 | if (mFramePresentMetadata != FramePresentMetadata::OnTimePresent) { |
| 1070 | // Do jank classification only if present is not on time |
| 1071 | if (mFramePresentMetadata == FramePresentMetadata::EarlyPresent) { |
| 1072 | if (mFrameReadyMetadata == FrameReadyMetadata::OnTimeFinish) { |
| 1073 | // Finish on time, Present early |
| 1074 | if (deltaToVsync < mJankClassificationThresholds.presentThreshold || |
Alec Mouri | 7d436ec | 2021-01-27 20:40:50 -0800 | [diff] [blame] | 1075 | deltaToVsync >= (mRefreshRate.getPeriodNsecs() - |
| 1076 | mJankClassificationThresholds.presentThreshold)) { |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1077 | // Delta is a factor of vsync if its within the presentTheshold on either side |
| 1078 | // of the vsyncPeriod. Example: 0-2ms and 9-11ms are both within the threshold |
| 1079 | // of the vsyncPeriod if the threshold was 2ms and the vsyncPeriod was 11ms. |
| 1080 | mJankType = JankType::SurfaceFlingerScheduling; |
| 1081 | } else { |
| 1082 | // Delta is not a factor of vsync, |
| 1083 | mJankType = JankType::PredictionError; |
| 1084 | } |
| 1085 | } else if (mFrameReadyMetadata == FrameReadyMetadata::LateFinish) { |
| 1086 | // Finish late, Present early |
| 1087 | mJankType = JankType::SurfaceFlingerScheduling; |
| 1088 | } else { |
| 1089 | // Finish time unknown |
| 1090 | mJankType = JankType::Unknown; |
| 1091 | } |
| 1092 | } else if (mFramePresentMetadata == FramePresentMetadata::LatePresent) { |
Adithya Srinivasan | 57dc81d | 2021-04-14 17:31:41 +0000 | [diff] [blame] | 1093 | if (std::abs(mSurfaceFlingerPredictions.presentTime - previousPresentTime) <= |
| 1094 | mJankClassificationThresholds.presentThreshold || |
| 1095 | previousPresentTime > mSurfaceFlingerPredictions.presentTime) { |
| 1096 | // The previous frame was either presented in the current frame's expected vsync or |
| 1097 | // it was presented even later than the current frame's expected vsync. |
| 1098 | mJankType = JankType::SurfaceFlingerStuffing; |
| 1099 | } |
| 1100 | if (mFrameReadyMetadata == FrameReadyMetadata::OnTimeFinish && |
| 1101 | !(mJankType & JankType::SurfaceFlingerStuffing)) { |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1102 | // Finish on time, Present late |
| 1103 | if (deltaToVsync < mJankClassificationThresholds.presentThreshold || |
Alec Mouri | 7d436ec | 2021-01-27 20:40:50 -0800 | [diff] [blame] | 1104 | deltaToVsync >= (mRefreshRate.getPeriodNsecs() - |
| 1105 | mJankClassificationThresholds.presentThreshold)) { |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1106 | // Delta is a factor of vsync if its within the presentTheshold on either side |
| 1107 | // of the vsyncPeriod. Example: 0-2ms and 9-11ms are both within the threshold |
| 1108 | // of the vsyncPeriod if the threshold was 2ms and the vsyncPeriod was 11ms. |
| 1109 | mJankType = JankType::DisplayHAL; |
| 1110 | } else { |
| 1111 | // Delta is not a factor of vsync |
| 1112 | mJankType = JankType::PredictionError; |
| 1113 | } |
| 1114 | } else if (mFrameReadyMetadata == FrameReadyMetadata::LateFinish) { |
Adithya Srinivasan | 57dc81d | 2021-04-14 17:31:41 +0000 | [diff] [blame] | 1115 | if (!(mJankType & JankType::SurfaceFlingerStuffing) || |
| 1116 | mSurfaceFlingerActuals.presentTime - previousPresentTime > |
| 1117 | mRefreshRate.getPeriodNsecs() + |
| 1118 | mJankClassificationThresholds.presentThreshold) { |
| 1119 | // Classify CPU vs GPU if SF wasn't stuffed or if SF was stuffed but this frame |
| 1120 | // was presented more than a vsync late. |
Rachel Lee | 94917b3 | 2022-03-18 17:52:09 -0700 | [diff] [blame] | 1121 | if (mGpuFence != FenceTime::NO_FENCE) { |
| 1122 | // If SF was in GPU composition, classify it as GPU deadline missed. |
Adithya Srinivasan | 36b01af | 2021-04-07 22:29:47 +0000 | [diff] [blame] | 1123 | mJankType = JankType::SurfaceFlingerGpuDeadlineMissed; |
| 1124 | } else { |
| 1125 | mJankType = JankType::SurfaceFlingerCpuDeadlineMissed; |
| 1126 | } |
Adithya Srinivasan | 939cd4d | 2021-02-23 06:18:13 +0000 | [diff] [blame] | 1127 | } |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1128 | } else { |
| 1129 | // Finish time unknown |
| 1130 | mJankType = JankType::Unknown; |
| 1131 | } |
| 1132 | } else { |
| 1133 | // Present unknown |
| 1134 | mJankType = JankType::Unknown; |
| 1135 | } |
| 1136 | } |
Adithya Srinivasan | 115ac69 | 2021-03-06 01:21:30 +0000 | [diff] [blame] | 1137 | } |
| 1138 | |
Adithya Srinivasan | 57dc81d | 2021-04-14 17:31:41 +0000 | [diff] [blame] | 1139 | void FrameTimeline::DisplayFrame::onPresent(nsecs_t signalTime, nsecs_t previousPresentTime) { |
Adithya Srinivasan | 115ac69 | 2021-03-06 01:21:30 +0000 | [diff] [blame] | 1140 | mSurfaceFlingerActuals.presentTime = signalTime; |
| 1141 | nsecs_t deadlineDelta = 0; |
| 1142 | nsecs_t deltaToVsync = 0; |
Adithya Srinivasan | 57dc81d | 2021-04-14 17:31:41 +0000 | [diff] [blame] | 1143 | classifyJank(deadlineDelta, deltaToVsync, previousPresentTime); |
Adithya Srinivasan | 115ac69 | 2021-03-06 01:21:30 +0000 | [diff] [blame] | 1144 | |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1145 | for (auto& surfaceFrame : mSurfaceFrames) { |
Pascal Muetschard | ac7bcd9 | 2023-10-03 15:05:36 +0200 | [diff] [blame] | 1146 | surfaceFrame->onPresent(signalTime, mJankType, mRefreshRate, mRenderRate, deadlineDelta, |
| 1147 | deltaToVsync); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1148 | } |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1149 | } |
| 1150 | |
Ady Abraham | 14beed7 | 2024-05-15 17:16:45 -0700 | [diff] [blame] | 1151 | void FrameTimeline::DisplayFrame::onCommitNotComposited() { |
| 1152 | for (auto& surfaceFrame : mSurfaceFrames) { |
| 1153 | surfaceFrame->onCommitNotComposited(mRefreshRate, mRenderRate); |
| 1154 | } |
| 1155 | } |
| 1156 | |
Ady Abraham | 57f8e18 | 2022-03-08 15:54:33 -0800 | [diff] [blame] | 1157 | void FrameTimeline::DisplayFrame::tracePredictions(pid_t surfaceFlingerPid, |
| 1158 | nsecs_t monoBootOffset) const { |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 1159 | int64_t expectedTimelineCookie = mTraceCookieCounter.getCookieForTracing(); |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 1160 | |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 1161 | // Expected timeline start |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1162 | FrameTimelineDataSource::Trace([&](FrameTimelineDataSource::TraceContext ctx) { |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1163 | auto packet = ctx.NewTracePacket(); |
Ady Abraham | 57f8e18 | 2022-03-08 15:54:33 -0800 | [diff] [blame] | 1164 | packet->set_timestamp_clock_id(perfetto::protos::pbzero::BUILTIN_CLOCK_BOOTTIME); |
| 1165 | packet->set_timestamp( |
| 1166 | static_cast<uint64_t>(mSurfaceFlingerPredictions.startTime + monoBootOffset)); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1167 | |
| 1168 | auto* event = packet->set_frame_timeline_event(); |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 1169 | auto* expectedDisplayFrameStartEvent = event->set_expected_display_frame_start(); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1170 | |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 1171 | expectedDisplayFrameStartEvent->set_cookie(expectedTimelineCookie); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1172 | |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 1173 | expectedDisplayFrameStartEvent->set_token(mToken); |
| 1174 | expectedDisplayFrameStartEvent->set_pid(surfaceFlingerPid); |
| 1175 | }); |
Adithya Srinivasan | 8667850 | 2021-01-19 21:50:38 +0000 | [diff] [blame] | 1176 | |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 1177 | // Expected timeline end |
| 1178 | FrameTimelineDataSource::Trace([&](FrameTimelineDataSource::TraceContext ctx) { |
| 1179 | auto packet = ctx.NewTracePacket(); |
Ady Abraham | 57f8e18 | 2022-03-08 15:54:33 -0800 | [diff] [blame] | 1180 | packet->set_timestamp_clock_id(perfetto::protos::pbzero::BUILTIN_CLOCK_BOOTTIME); |
| 1181 | packet->set_timestamp( |
| 1182 | static_cast<uint64_t>(mSurfaceFlingerPredictions.endTime + monoBootOffset)); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1183 | |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 1184 | auto* event = packet->set_frame_timeline_event(); |
| 1185 | auto* expectedDisplayFrameEndEvent = event->set_frame_end(); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1186 | |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 1187 | expectedDisplayFrameEndEvent->set_cookie(expectedTimelineCookie); |
| 1188 | }); |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 1189 | } |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 1190 | |
Sally Qi | aa10774 | 2023-09-29 14:53:14 -0700 | [diff] [blame] | 1191 | void FrameTimeline::DisplayFrame::addSkippedFrame(pid_t surfaceFlingerPid, nsecs_t monoBootOffset, |
Sally Qi | 438eb7d | 2023-12-05 18:59:32 -0800 | [diff] [blame] | 1192 | nsecs_t previousPredictionPresentTime) const { |
Sally Qi | aa10774 | 2023-09-29 14:53:14 -0700 | [diff] [blame] | 1193 | nsecs_t skippedFrameStartTime = 0, skippedFramePresentTime = 0; |
| 1194 | const constexpr float kThresh = 0.5f; |
| 1195 | const constexpr float kRange = 1.5f; |
| 1196 | for (auto& surfaceFrame : mSurfaceFrames) { |
Sally Qi | 438eb7d | 2023-12-05 18:59:32 -0800 | [diff] [blame] | 1197 | if (previousPredictionPresentTime != 0 && |
| 1198 | static_cast<float>(mSurfaceFlingerPredictions.presentTime - |
| 1199 | previousPredictionPresentTime) >= |
Sally Qi | aa10774 | 2023-09-29 14:53:14 -0700 | [diff] [blame] | 1200 | static_cast<float>(mRenderRate.getPeriodNsecs()) * kRange && |
| 1201 | static_cast<float>(surfaceFrame->getPredictions().presentTime) <= |
Sally Qi | 438eb7d | 2023-12-05 18:59:32 -0800 | [diff] [blame] | 1202 | (static_cast<float>(mSurfaceFlingerPredictions.presentTime) - |
Sally Qi | aa10774 | 2023-09-29 14:53:14 -0700 | [diff] [blame] | 1203 | kThresh * static_cast<float>(mRenderRate.getPeriodNsecs())) && |
| 1204 | static_cast<float>(surfaceFrame->getPredictions().presentTime) >= |
Sally Qi | 2269a69 | 2024-05-17 18:02:28 -0700 | [diff] [blame] | 1205 | (static_cast<float>(previousPredictionPresentTime) + |
Sally Qi | 438eb7d | 2023-12-05 18:59:32 -0800 | [diff] [blame] | 1206 | kThresh * static_cast<float>(mRenderRate.getPeriodNsecs())) && |
| 1207 | // sf skipped frame is not considered if app is self janked |
| 1208 | !surfaceFrame->isSelfJanky()) { |
Sally Qi | aa10774 | 2023-09-29 14:53:14 -0700 | [diff] [blame] | 1209 | skippedFrameStartTime = surfaceFrame->getPredictions().endTime; |
| 1210 | skippedFramePresentTime = surfaceFrame->getPredictions().presentTime; |
| 1211 | break; |
| 1212 | } |
| 1213 | } |
| 1214 | |
| 1215 | // add slice |
| 1216 | if (skippedFrameStartTime != 0 && skippedFramePresentTime != 0) { |
| 1217 | int64_t actualTimelineCookie = mTraceCookieCounter.getCookieForTracing(); |
| 1218 | |
| 1219 | // Actual timeline start |
| 1220 | FrameTimelineDataSource::Trace([&](FrameTimelineDataSource::TraceContext ctx) { |
| 1221 | auto packet = ctx.NewTracePacket(); |
| 1222 | packet->set_timestamp_clock_id(perfetto::protos::pbzero::BUILTIN_CLOCK_BOOTTIME); |
| 1223 | packet->set_timestamp(static_cast<uint64_t>(skippedFrameStartTime + monoBootOffset)); |
| 1224 | |
| 1225 | auto* event = packet->set_frame_timeline_event(); |
| 1226 | auto* actualDisplayFrameStartEvent = event->set_actual_display_frame_start(); |
| 1227 | |
| 1228 | actualDisplayFrameStartEvent->set_cookie(actualTimelineCookie); |
| 1229 | |
| 1230 | actualDisplayFrameStartEvent->set_token(0); |
| 1231 | actualDisplayFrameStartEvent->set_pid(surfaceFlingerPid); |
| 1232 | actualDisplayFrameStartEvent->set_on_time_finish(mFrameReadyMetadata == |
| 1233 | FrameReadyMetadata::OnTimeFinish); |
| 1234 | actualDisplayFrameStartEvent->set_gpu_composition(false); |
| 1235 | actualDisplayFrameStartEvent->set_prediction_type(toProto(PredictionState::Valid)); |
| 1236 | actualDisplayFrameStartEvent->set_present_type(FrameTimelineEvent::PRESENT_DROPPED); |
| 1237 | actualDisplayFrameStartEvent->set_jank_type(jankTypeBitmaskToProto(JankType::Dropped)); |
Ying Wei | 96eb535 | 2023-11-21 17:37:21 +0000 | [diff] [blame] | 1238 | actualDisplayFrameStartEvent->set_jank_severity_type(toProto(JankSeverityType::None)); |
Sally Qi | aa10774 | 2023-09-29 14:53:14 -0700 | [diff] [blame] | 1239 | }); |
| 1240 | |
| 1241 | // Actual timeline end |
| 1242 | FrameTimelineDataSource::Trace([&](FrameTimelineDataSource::TraceContext ctx) { |
| 1243 | auto packet = ctx.NewTracePacket(); |
| 1244 | packet->set_timestamp_clock_id(perfetto::protos::pbzero::BUILTIN_CLOCK_BOOTTIME); |
| 1245 | packet->set_timestamp(static_cast<uint64_t>(skippedFramePresentTime + monoBootOffset)); |
| 1246 | |
| 1247 | auto* event = packet->set_frame_timeline_event(); |
| 1248 | auto* actualDisplayFrameEndEvent = event->set_frame_end(); |
| 1249 | |
| 1250 | actualDisplayFrameEndEvent->set_cookie(actualTimelineCookie); |
| 1251 | }); |
| 1252 | } |
| 1253 | } |
| 1254 | |
Ady Abraham | 57f8e18 | 2022-03-08 15:54:33 -0800 | [diff] [blame] | 1255 | void FrameTimeline::DisplayFrame::traceActuals(pid_t surfaceFlingerPid, |
| 1256 | nsecs_t monoBootOffset) const { |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 1257 | int64_t actualTimelineCookie = mTraceCookieCounter.getCookieForTracing(); |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 1258 | |
| 1259 | // Actual timeline start |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 1260 | FrameTimelineDataSource::Trace([&](FrameTimelineDataSource::TraceContext ctx) { |
| 1261 | auto packet = ctx.NewTracePacket(); |
Ady Abraham | 57f8e18 | 2022-03-08 15:54:33 -0800 | [diff] [blame] | 1262 | packet->set_timestamp_clock_id(perfetto::protos::pbzero::BUILTIN_CLOCK_BOOTTIME); |
| 1263 | packet->set_timestamp( |
| 1264 | static_cast<uint64_t>(mSurfaceFlingerActuals.startTime + monoBootOffset)); |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 1265 | |
| 1266 | auto* event = packet->set_frame_timeline_event(); |
| 1267 | auto* actualDisplayFrameStartEvent = event->set_actual_display_frame_start(); |
| 1268 | |
| 1269 | actualDisplayFrameStartEvent->set_cookie(actualTimelineCookie); |
| 1270 | |
| 1271 | actualDisplayFrameStartEvent->set_token(mToken); |
| 1272 | actualDisplayFrameStartEvent->set_pid(surfaceFlingerPid); |
| 1273 | |
| 1274 | actualDisplayFrameStartEvent->set_present_type(toProto(mFramePresentMetadata)); |
| 1275 | actualDisplayFrameStartEvent->set_on_time_finish(mFrameReadyMetadata == |
| 1276 | FrameReadyMetadata::OnTimeFinish); |
Adithya Srinivasan | 36b01af | 2021-04-07 22:29:47 +0000 | [diff] [blame] | 1277 | actualDisplayFrameStartEvent->set_gpu_composition(mGpuFence != FenceTime::NO_FENCE); |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 1278 | actualDisplayFrameStartEvent->set_jank_type(jankTypeBitmaskToProto(mJankType)); |
Adithya Srinivasan | 78e58af | 2021-02-25 00:08:08 +0000 | [diff] [blame] | 1279 | actualDisplayFrameStartEvent->set_prediction_type(toProto(mPredictionState)); |
Ying Wei | 96eb535 | 2023-11-21 17:37:21 +0000 | [diff] [blame] | 1280 | actualDisplayFrameStartEvent->set_jank_severity_type(toProto(mJankSeverityType)); |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 1281 | }); |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 1282 | |
| 1283 | // Actual timeline end |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 1284 | FrameTimelineDataSource::Trace([&](FrameTimelineDataSource::TraceContext ctx) { |
| 1285 | auto packet = ctx.NewTracePacket(); |
Ady Abraham | 57f8e18 | 2022-03-08 15:54:33 -0800 | [diff] [blame] | 1286 | packet->set_timestamp_clock_id(perfetto::protos::pbzero::BUILTIN_CLOCK_BOOTTIME); |
| 1287 | packet->set_timestamp( |
| 1288 | static_cast<uint64_t>(mSurfaceFlingerActuals.presentTime + monoBootOffset)); |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 1289 | |
| 1290 | auto* event = packet->set_frame_timeline_event(); |
| 1291 | auto* actualDisplayFrameEndEvent = event->set_frame_end(); |
| 1292 | |
| 1293 | actualDisplayFrameEndEvent->set_cookie(actualTimelineCookie); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1294 | }); |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 1295 | } |
| 1296 | |
Sally Qi | 438eb7d | 2023-12-05 18:59:32 -0800 | [diff] [blame] | 1297 | nsecs_t FrameTimeline::DisplayFrame::trace(pid_t surfaceFlingerPid, nsecs_t monoBootOffset, |
| 1298 | nsecs_t previousPredictionPresentTime) const { |
Ady Abraham | 57a8ab4 | 2023-01-26 15:28:19 -0800 | [diff] [blame] | 1299 | if (mSurfaceFrames.empty()) { |
| 1300 | // We don't want to trace display frames without any surface frames updates as this cannot |
| 1301 | // be janky |
Sally Qi | 438eb7d | 2023-12-05 18:59:32 -0800 | [diff] [blame] | 1302 | return previousPredictionPresentTime; |
Ady Abraham | 57a8ab4 | 2023-01-26 15:28:19 -0800 | [diff] [blame] | 1303 | } |
| 1304 | |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 1305 | if (mToken == FrameTimelineInfo::INVALID_VSYNC_ID) { |
| 1306 | // DisplayFrame should not have an invalid token. |
| 1307 | ALOGE("Cannot trace DisplayFrame with invalid token"); |
Sally Qi | 438eb7d | 2023-12-05 18:59:32 -0800 | [diff] [blame] | 1308 | return previousPredictionPresentTime; |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 1309 | } |
| 1310 | |
| 1311 | if (mPredictionState == PredictionState::Valid) { |
| 1312 | // Expired and unknown predictions have zeroed timestamps. This cannot be used in any |
| 1313 | // meaningful way in a trace. |
Ady Abraham | 57f8e18 | 2022-03-08 15:54:33 -0800 | [diff] [blame] | 1314 | tracePredictions(surfaceFlingerPid, monoBootOffset); |
Adithya Srinivasan | 061c14c | 2021-02-11 01:19:47 +0000 | [diff] [blame] | 1315 | } |
Ady Abraham | 57f8e18 | 2022-03-08 15:54:33 -0800 | [diff] [blame] | 1316 | traceActuals(surfaceFlingerPid, monoBootOffset); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1317 | |
| 1318 | for (auto& surfaceFrame : mSurfaceFrames) { |
Ady Abraham | 57f8e18 | 2022-03-08 15:54:33 -0800 | [diff] [blame] | 1319 | surfaceFrame->trace(mToken, monoBootOffset); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1320 | } |
Sally Qi | aa10774 | 2023-09-29 14:53:14 -0700 | [diff] [blame] | 1321 | |
Sally Qi | f572125 | 2023-11-17 11:14:53 -0800 | [diff] [blame] | 1322 | if (FlagManager::getInstance().add_sf_skipped_frames_to_trace()) { |
Sally Qi | 438eb7d | 2023-12-05 18:59:32 -0800 | [diff] [blame] | 1323 | addSkippedFrame(surfaceFlingerPid, monoBootOffset, previousPredictionPresentTime); |
Sally Qi | f572125 | 2023-11-17 11:14:53 -0800 | [diff] [blame] | 1324 | } |
Sally Qi | 438eb7d | 2023-12-05 18:59:32 -0800 | [diff] [blame] | 1325 | return mSurfaceFlingerPredictions.presentTime; |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1326 | } |
| 1327 | |
Alec Mouri | adebf5c | 2021-01-05 12:57:36 -0800 | [diff] [blame] | 1328 | float FrameTimeline::computeFps(const std::unordered_set<int32_t>& layerIds) { |
| 1329 | if (layerIds.empty()) { |
| 1330 | return 0.0f; |
| 1331 | } |
| 1332 | |
| 1333 | std::vector<nsecs_t> presentTimes; |
| 1334 | { |
| 1335 | std::scoped_lock lock(mMutex); |
| 1336 | presentTimes.reserve(mDisplayFrames.size()); |
| 1337 | for (size_t i = 0; i < mDisplayFrames.size(); i++) { |
| 1338 | const auto& displayFrame = mDisplayFrames[i]; |
| 1339 | if (displayFrame->getActuals().presentTime <= 0) { |
| 1340 | continue; |
| 1341 | } |
| 1342 | for (const auto& surfaceFrame : displayFrame->getSurfaceFrames()) { |
| 1343 | if (surfaceFrame->getPresentState() == SurfaceFrame::PresentState::Presented && |
| 1344 | layerIds.count(surfaceFrame->getLayerId()) > 0) { |
| 1345 | // We're looking for DisplayFrames that presents at least one layer from |
| 1346 | // layerIds, so push the present time and skip looking through the rest of the |
| 1347 | // SurfaceFrames. |
| 1348 | presentTimes.push_back(displayFrame->getActuals().presentTime); |
| 1349 | break; |
| 1350 | } |
| 1351 | } |
| 1352 | } |
| 1353 | } |
| 1354 | |
| 1355 | // FPS can't be computed when there's fewer than 2 presented frames. |
| 1356 | if (presentTimes.size() <= 1) { |
| 1357 | return 0.0f; |
| 1358 | } |
| 1359 | |
| 1360 | nsecs_t priorPresentTime = -1; |
| 1361 | nsecs_t totalPresentToPresentWalls = 0; |
| 1362 | |
| 1363 | for (const nsecs_t presentTime : presentTimes) { |
| 1364 | if (priorPresentTime == -1) { |
| 1365 | priorPresentTime = presentTime; |
| 1366 | continue; |
| 1367 | } |
| 1368 | |
| 1369 | totalPresentToPresentWalls += (presentTime - priorPresentTime); |
| 1370 | priorPresentTime = presentTime; |
| 1371 | } |
| 1372 | |
| 1373 | if (CC_UNLIKELY(totalPresentToPresentWalls <= 0)) { |
| 1374 | ALOGW("Invalid total present-to-present duration when computing fps: %" PRId64, |
| 1375 | totalPresentToPresentWalls); |
| 1376 | return 0.0f; |
| 1377 | } |
| 1378 | |
| 1379 | const constexpr nsecs_t kOneSecond = |
| 1380 | std::chrono::duration_cast<std::chrono::nanoseconds>(1s).count(); |
| 1381 | // (10^9 nanoseconds / second) * (N present deltas) / (total nanoseconds in N present deltas) = |
| 1382 | // M frames / second |
| 1383 | return kOneSecond * static_cast<nsecs_t>((presentTimes.size() - 1)) / |
| 1384 | static_cast<float>(totalPresentToPresentWalls); |
| 1385 | } |
| 1386 | |
Ady Abraham | fcb1686 | 2022-10-10 14:35:21 -0700 | [diff] [blame] | 1387 | std::optional<size_t> FrameTimeline::getFirstSignalFenceIndex() const { |
| 1388 | for (size_t i = 0; i < mPendingPresentFences.size(); i++) { |
| 1389 | const auto& [fence, _] = mPendingPresentFences[i]; |
Theodore Dubois | 205c6dd | 2022-11-23 15:06:33 -0800 | [diff] [blame] | 1390 | if (fence && fence->getSignalTime() != Fence::SIGNAL_TIME_PENDING) { |
Ady Abraham | fcb1686 | 2022-10-10 14:35:21 -0700 | [diff] [blame] | 1391 | return i; |
| 1392 | } |
| 1393 | } |
| 1394 | |
| 1395 | return {}; |
| 1396 | } |
| 1397 | |
Adithya Srinivasan | f279e04 | 2020-08-17 14:56:27 -0700 | [diff] [blame] | 1398 | void FrameTimeline::flushPendingPresentFences() { |
Ady Abraham | fcb1686 | 2022-10-10 14:35:21 -0700 | [diff] [blame] | 1399 | const auto firstSignaledFence = getFirstSignalFenceIndex(); |
| 1400 | if (!firstSignaledFence.has_value()) { |
| 1401 | return; |
| 1402 | } |
| 1403 | |
Ady Abraham | 57f8e18 | 2022-03-08 15:54:33 -0800 | [diff] [blame] | 1404 | // Perfetto is using boottime clock to void drifts when the device goes |
| 1405 | // to suspend. |
| 1406 | const auto monoBootOffset = mUseBootTimeClock |
| 1407 | ? (systemTime(SYSTEM_TIME_BOOTTIME) - systemTime(SYSTEM_TIME_MONOTONIC)) |
| 1408 | : 0; |
| 1409 | |
Ady Abraham | fcb1686 | 2022-10-10 14:35:21 -0700 | [diff] [blame] | 1410 | // Present fences are expected to be signaled in order. Mark all the previous |
| 1411 | // pending fences as errors. |
| 1412 | for (size_t i = 0; i < firstSignaledFence.value(); i++) { |
| 1413 | const auto& pendingPresentFence = *mPendingPresentFences.begin(); |
| 1414 | const nsecs_t signalTime = Fence::SIGNAL_TIME_INVALID; |
| 1415 | auto& displayFrame = pendingPresentFence.second; |
Sally Qi | 438eb7d | 2023-12-05 18:59:32 -0800 | [diff] [blame] | 1416 | displayFrame->onPresent(signalTime, mPreviousActualPresentTime); |
| 1417 | mPreviousPredictionPresentTime = displayFrame->trace(mSurfaceFlingerPid, monoBootOffset, |
| 1418 | mPreviousPredictionPresentTime); |
Ady Abraham | fcb1686 | 2022-10-10 14:35:21 -0700 | [diff] [blame] | 1419 | mPendingPresentFences.erase(mPendingPresentFences.begin()); |
| 1420 | } |
| 1421 | |
Adithya Srinivasan | f279e04 | 2020-08-17 14:56:27 -0700 | [diff] [blame] | 1422 | for (size_t i = 0; i < mPendingPresentFences.size(); i++) { |
| 1423 | const auto& pendingPresentFence = mPendingPresentFences[i]; |
| 1424 | nsecs_t signalTime = Fence::SIGNAL_TIME_INVALID; |
| 1425 | if (pendingPresentFence.first && pendingPresentFence.first->isValid()) { |
| 1426 | signalTime = pendingPresentFence.first->getSignalTime(); |
| 1427 | if (signalTime == Fence::SIGNAL_TIME_PENDING) { |
Ady Abraham | fcb1686 | 2022-10-10 14:35:21 -0700 | [diff] [blame] | 1428 | break; |
Adithya Srinivasan | f279e04 | 2020-08-17 14:56:27 -0700 | [diff] [blame] | 1429 | } |
| 1430 | } |
Ady Abraham | fcb1686 | 2022-10-10 14:35:21 -0700 | [diff] [blame] | 1431 | |
Adithya Srinivasan | 7c4ac7a | 2021-03-08 23:48:03 +0000 | [diff] [blame] | 1432 | auto& displayFrame = pendingPresentFence.second; |
Sally Qi | 438eb7d | 2023-12-05 18:59:32 -0800 | [diff] [blame] | 1433 | displayFrame->onPresent(signalTime, mPreviousActualPresentTime); |
| 1434 | mPreviousPredictionPresentTime = displayFrame->trace(mSurfaceFlingerPid, monoBootOffset, |
| 1435 | mPreviousPredictionPresentTime); |
| 1436 | mPreviousActualPresentTime = signalTime; |
Adithya Srinivasan | f279e04 | 2020-08-17 14:56:27 -0700 | [diff] [blame] | 1437 | |
| 1438 | mPendingPresentFences.erase(mPendingPresentFences.begin() + static_cast<int>(i)); |
| 1439 | --i; |
| 1440 | } |
| 1441 | } |
| 1442 | |
| 1443 | void FrameTimeline::finalizeCurrentDisplayFrame() { |
Adithya Srinivasan | 2d73632 | 2020-10-01 16:53:48 -0700 | [diff] [blame] | 1444 | while (mDisplayFrames.size() >= mMaxDisplayFrames) { |
Adithya Srinivasan | f279e04 | 2020-08-17 14:56:27 -0700 | [diff] [blame] | 1445 | // We maintain only a fixed number of frames' data. Pop older frames |
| 1446 | mDisplayFrames.pop_front(); |
| 1447 | } |
| 1448 | mDisplayFrames.push_back(mCurrentDisplayFrame); |
| 1449 | mCurrentDisplayFrame.reset(); |
Adithya Srinivasan | 05bd2d1 | 2021-01-11 18:49:58 +0000 | [diff] [blame] | 1450 | mCurrentDisplayFrame = std::make_shared<DisplayFrame>(mTimeStats, mJankClassificationThresholds, |
Adithya Srinivasan | 82eef32 | 2021-04-10 00:06:04 +0000 | [diff] [blame] | 1451 | &mTraceCookieCounter); |
Adithya Srinivasan | f279e04 | 2020-08-17 14:56:27 -0700 | [diff] [blame] | 1452 | } |
| 1453 | |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1454 | nsecs_t FrameTimeline::DisplayFrame::getBaseTime() const { |
| 1455 | nsecs_t baseTime = |
| 1456 | getMinTime(mPredictionState, mSurfaceFlingerPredictions, mSurfaceFlingerActuals); |
| 1457 | for (const auto& surfaceFrame : mSurfaceFrames) { |
Adithya Srinivasan | 8fc601d | 2020-09-25 13:51:09 -0700 | [diff] [blame] | 1458 | nsecs_t surfaceFrameBaseTime = surfaceFrame->getBaseTime(); |
| 1459 | if (surfaceFrameBaseTime != 0) { |
| 1460 | baseTime = std::min(baseTime, surfaceFrameBaseTime); |
| 1461 | } |
| 1462 | } |
| 1463 | return baseTime; |
| 1464 | } |
| 1465 | |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1466 | void FrameTimeline::DisplayFrame::dumpJank(std::string& result, nsecs_t baseTime, |
| 1467 | int displayFrameCount) const { |
| 1468 | if (mJankType == JankType::None) { |
| 1469 | // Check if any Surface Frame has been janky |
| 1470 | bool isJanky = false; |
| 1471 | for (const auto& surfaceFrame : mSurfaceFrames) { |
| 1472 | if (surfaceFrame->getJankType() != JankType::None) { |
| 1473 | isJanky = true; |
| 1474 | break; |
| 1475 | } |
| 1476 | } |
| 1477 | if (!isJanky) { |
| 1478 | return; |
| 1479 | } |
| 1480 | } |
| 1481 | StringAppendF(&result, "Display Frame %d", displayFrameCount); |
| 1482 | dump(result, baseTime); |
| 1483 | } |
| 1484 | |
| 1485 | void FrameTimeline::DisplayFrame::dumpAll(std::string& result, nsecs_t baseTime) const { |
| 1486 | dump(result, baseTime); |
| 1487 | } |
| 1488 | |
| 1489 | void FrameTimeline::DisplayFrame::dump(std::string& result, nsecs_t baseTime) const { |
| 1490 | if (mJankType != JankType::None) { |
Adithya Srinivasan | 8fc601d | 2020-09-25 13:51:09 -0700 | [diff] [blame] | 1491 | // Easily identify a janky Display Frame in the dump |
| 1492 | StringAppendF(&result, " [*] "); |
| 1493 | } |
| 1494 | StringAppendF(&result, "\n"); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1495 | StringAppendF(&result, "Prediction State : %s\n", toString(mPredictionState).c_str()); |
| 1496 | StringAppendF(&result, "Jank Type : %s\n", jankTypeBitmaskToString(mJankType).c_str()); |
| 1497 | StringAppendF(&result, "Present Metadata : %s\n", toString(mFramePresentMetadata).c_str()); |
| 1498 | StringAppendF(&result, "Finish Metadata: %s\n", toString(mFrameReadyMetadata).c_str()); |
| 1499 | StringAppendF(&result, "Start Metadata: %s\n", toString(mFrameStartMetadata).c_str()); |
Alec Mouri | 7d436ec | 2021-01-27 20:40:50 -0800 | [diff] [blame] | 1500 | std::chrono::nanoseconds vsyncPeriod(mRefreshRate.getPeriodNsecs()); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1501 | StringAppendF(&result, "Vsync Period: %10f\n", |
| 1502 | std::chrono::duration<double, std::milli>(vsyncPeriod).count()); |
| 1503 | nsecs_t presentDelta = |
| 1504 | mSurfaceFlingerActuals.presentTime - mSurfaceFlingerPredictions.presentTime; |
| 1505 | std::chrono::nanoseconds presentDeltaNs(std::abs(presentDelta)); |
| 1506 | StringAppendF(&result, "Present delta: %10f\n", |
| 1507 | std::chrono::duration<double, std::milli>(presentDeltaNs).count()); |
Alec Mouri | 7d436ec | 2021-01-27 20:40:50 -0800 | [diff] [blame] | 1508 | std::chrono::nanoseconds deltaToVsync(std::abs(presentDelta) % mRefreshRate.getPeriodNsecs()); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1509 | StringAppendF(&result, "Present delta %% refreshrate: %10f\n", |
| 1510 | std::chrono::duration<double, std::milli>(deltaToVsync).count()); |
| 1511 | dumpTable(result, mSurfaceFlingerPredictions, mSurfaceFlingerActuals, "", mPredictionState, |
| 1512 | baseTime); |
Adithya Srinivasan | 8fc601d | 2020-09-25 13:51:09 -0700 | [diff] [blame] | 1513 | StringAppendF(&result, "\n"); |
| 1514 | std::string indent = " "; // 4 spaces |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1515 | for (const auto& surfaceFrame : mSurfaceFrames) { |
Adithya Srinivasan | 8fc601d | 2020-09-25 13:51:09 -0700 | [diff] [blame] | 1516 | surfaceFrame->dump(result, indent, baseTime); |
| 1517 | } |
| 1518 | StringAppendF(&result, "\n"); |
| 1519 | } |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1520 | |
Adithya Srinivasan | 8fc601d | 2020-09-25 13:51:09 -0700 | [diff] [blame] | 1521 | void FrameTimeline::dumpAll(std::string& result) { |
Siarhei Vishniakou | fc434ac | 2021-01-13 10:28:00 -1000 | [diff] [blame] | 1522 | std::scoped_lock lock(mMutex); |
Adithya Srinivasan | f279e04 | 2020-08-17 14:56:27 -0700 | [diff] [blame] | 1523 | StringAppendF(&result, "Number of display frames : %d\n", (int)mDisplayFrames.size()); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1524 | nsecs_t baseTime = (mDisplayFrames.empty()) ? 0 : mDisplayFrames[0]->getBaseTime(); |
Adithya Srinivasan | 8fc601d | 2020-09-25 13:51:09 -0700 | [diff] [blame] | 1525 | for (size_t i = 0; i < mDisplayFrames.size(); i++) { |
| 1526 | StringAppendF(&result, "Display Frame %d", static_cast<int>(i)); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1527 | mDisplayFrames[i]->dumpAll(result, baseTime); |
Adithya Srinivasan | 8fc601d | 2020-09-25 13:51:09 -0700 | [diff] [blame] | 1528 | } |
| 1529 | } |
| 1530 | |
| 1531 | void FrameTimeline::dumpJank(std::string& result) { |
Siarhei Vishniakou | fc434ac | 2021-01-13 10:28:00 -1000 | [diff] [blame] | 1532 | std::scoped_lock lock(mMutex); |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1533 | nsecs_t baseTime = (mDisplayFrames.empty()) ? 0 : mDisplayFrames[0]->getBaseTime(); |
Adithya Srinivasan | 8fc601d | 2020-09-25 13:51:09 -0700 | [diff] [blame] | 1534 | for (size_t i = 0; i < mDisplayFrames.size(); i++) { |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1535 | mDisplayFrames[i]->dumpJank(result, baseTime, static_cast<int>(i)); |
Adithya Srinivasan | 8fc601d | 2020-09-25 13:51:09 -0700 | [diff] [blame] | 1536 | } |
| 1537 | } |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1538 | |
Adithya Srinivasan | 8fc601d | 2020-09-25 13:51:09 -0700 | [diff] [blame] | 1539 | void FrameTimeline::parseArgs(const Vector<String16>& args, std::string& result) { |
Vishnu Nair | be0ad90 | 2024-06-27 23:38:43 +0000 | [diff] [blame] | 1540 | SFTRACE_CALL(); |
Adithya Srinivasan | 8fc601d | 2020-09-25 13:51:09 -0700 | [diff] [blame] | 1541 | std::unordered_map<std::string, bool> argsMap; |
| 1542 | for (size_t i = 0; i < args.size(); i++) { |
| 1543 | argsMap[std::string(String8(args[i]).c_str())] = true; |
| 1544 | } |
| 1545 | if (argsMap.count("-jank")) { |
| 1546 | dumpJank(result); |
| 1547 | } |
| 1548 | if (argsMap.count("-all")) { |
| 1549 | dumpAll(result); |
Adithya Srinivasan | f279e04 | 2020-08-17 14:56:27 -0700 | [diff] [blame] | 1550 | } |
| 1551 | } |
| 1552 | |
Adithya Srinivasan | 2d73632 | 2020-10-01 16:53:48 -0700 | [diff] [blame] | 1553 | void FrameTimeline::setMaxDisplayFrames(uint32_t size) { |
Siarhei Vishniakou | fc434ac | 2021-01-13 10:28:00 -1000 | [diff] [blame] | 1554 | std::scoped_lock lock(mMutex); |
Adithya Srinivasan | 2d73632 | 2020-10-01 16:53:48 -0700 | [diff] [blame] | 1555 | |
| 1556 | // The size can either increase or decrease, clear everything, to be consistent |
| 1557 | mDisplayFrames.clear(); |
| 1558 | mPendingPresentFences.clear(); |
| 1559 | mMaxDisplayFrames = size; |
| 1560 | } |
| 1561 | |
| 1562 | void FrameTimeline::reset() { |
| 1563 | setMaxDisplayFrames(kDefaultMaxDisplayFrames); |
| 1564 | } |
| 1565 | |
Adithya Srinivasan | 9b2ca3e | 2020-11-10 10:14:17 -0800 | [diff] [blame] | 1566 | } // namespace impl |
| 1567 | } // namespace android::frametimeline |