Colin Cross | 72bb363 | 2017-07-13 16:23:21 -0700 | [diff] [blame] | 1 | // Copyright 2017 Google Inc. All rights reserved. |
| 2 | // |
| 3 | // Licensed under the Apache License, Version 2.0 (the "License"); |
| 4 | // you may not use this file except in compliance with the License. |
| 5 | // You may obtain a copy of the License at |
| 6 | // |
| 7 | // http://www.apache.org/licenses/LICENSE-2.0 |
| 8 | // |
| 9 | // Unless required by applicable law or agreed to in writing, software |
| 10 | // distributed under the License is distributed on an "AS IS" BASIS, |
| 11 | // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. |
| 12 | // See the License for the specific language governing permissions and |
| 13 | // limitations under the License. |
| 14 | |
| 15 | package java |
| 16 | |
| 17 | import ( |
Paul Duffin | 1a39332 | 2020-11-18 16:36:47 +0000 | [diff] [blame] | 18 | "fmt" |
Colin Cross | 72bb363 | 2017-07-13 16:23:21 -0700 | [diff] [blame] | 19 | "os" |
| 20 | "path/filepath" |
Colin Cross | c080617 | 2019-06-14 18:51:47 -0700 | [diff] [blame] | 21 | "reflect" |
Colin Cross | f8d9c49 | 2021-01-26 11:01:43 -0800 | [diff] [blame] | 22 | "runtime" |
Nan Zhang | 61eaedb | 2017-11-02 13:28:15 -0700 | [diff] [blame] | 23 | "strconv" |
Colin Cross | 72bb363 | 2017-07-13 16:23:21 -0700 | [diff] [blame] | 24 | "strings" |
| 25 | "testing" |
Colin Cross | 86a60ae | 2018-05-29 14:44:55 -0700 | [diff] [blame] | 26 | |
Jeongik Cha | 28df257 | 2019-11-11 10:46:36 +0900 | [diff] [blame] | 27 | "github.com/google/blueprint/proptools" |
| 28 | |
Jihoon Kang | 84b2589 | 2023-12-01 22:01:06 +0000 | [diff] [blame] | 29 | "android/soong/aconfig" |
Colin Cross | a4f0881 | 2018-10-02 22:03:40 -0700 | [diff] [blame] | 30 | "android/soong/android" |
| 31 | "android/soong/cc" |
Colin Cross | c28bb0b | 2019-02-25 14:20:47 -0800 | [diff] [blame] | 32 | "android/soong/dexpreopt" |
Colin Cross | 1661aff | 2021-03-12 17:56:51 -0800 | [diff] [blame] | 33 | "android/soong/genrule" |
Colin Cross | 72bb363 | 2017-07-13 16:23:21 -0700 | [diff] [blame] | 34 | ) |
| 35 | |
Paul Duffin | 70d3bee | 2021-03-21 11:26:05 +0000 | [diff] [blame] | 36 | // Legacy preparer used for running tests within the java package. |
| 37 | // |
| 38 | // This includes everything that was needed to run any test in the java package prior to the |
| 39 | // introduction of the test fixtures. Tests that are being converted to use fixtures directly |
| 40 | // rather than through the testJava...() methods should avoid using this and instead use the |
| 41 | // various preparers directly, using android.GroupFixturePreparers(...) to group them when |
| 42 | // necessary. |
| 43 | // |
| 44 | // deprecated |
| 45 | var prepareForJavaTest = android.GroupFixturePreparers( |
Paul Duffin | 95bdab4 | 2021-03-08 21:48:46 +0000 | [diff] [blame] | 46 | genrule.PrepareForTestWithGenRuleBuildComponents, |
| 47 | // Get the CC build components but not default modules. |
| 48 | cc.PrepareForTestWithCcBuildComponents, |
| 49 | // Include all the default java modules. |
Jiakai Zhang | b95998b | 2023-05-11 16:39:27 +0100 | [diff] [blame] | 50 | PrepareForTestWithDexpreopt, |
Jihoon Kang | 84b2589 | 2023-12-01 22:01:06 +0000 | [diff] [blame] | 51 | // Include aconfig modules. |
| 52 | aconfig.PrepareForTestWithAconfigBuildComponents, |
Paul Duffin | 95bdab4 | 2021-03-08 21:48:46 +0000 | [diff] [blame] | 53 | ) |
| 54 | |
Colin Cross | 72bb363 | 2017-07-13 16:23:21 -0700 | [diff] [blame] | 55 | func TestMain(m *testing.M) { |
Paul Duffin | d6339af | 2021-03-22 18:05:04 +0000 | [diff] [blame] | 56 | os.Exit(m.Run()) |
Colin Cross | 527012a | 2017-11-30 22:56:16 -0800 | [diff] [blame] | 57 | } |
| 58 | |
Paul Duffin | 95bdab4 | 2021-03-08 21:48:46 +0000 | [diff] [blame] | 59 | // testJavaError is a legacy way of running tests of java modules that expect errors. |
| 60 | // |
| 61 | // See testJava for an explanation as to how to stop using this deprecated method. |
| 62 | // |
| 63 | // deprecated |
Jeongik Cha | 2cc570d | 2019-10-29 15:44:45 +0900 | [diff] [blame] | 64 | func testJavaError(t *testing.T, pattern string, bp string) (*android.TestContext, android.Config) { |
Jeongik Cha | 538c0d0 | 2019-07-11 15:54:27 +0900 | [diff] [blame] | 65 | t.Helper() |
Paul Duffin | 71ae594 | 2021-03-22 15:36:52 +0000 | [diff] [blame] | 66 | result := android.GroupFixturePreparers( |
Paul Duffin | 9fc9f53 | 2021-03-23 15:41:11 +0000 | [diff] [blame] | 67 | prepareForJavaTest, dexpreopt.PrepareForTestByEnablingDexpreopt). |
Paul Duffin | 6bac49c | 2021-03-12 21:28:15 +0000 | [diff] [blame] | 68 | ExtendWithErrorHandler(android.FixtureExpectsAtLeastOneErrorMatchingPattern(pattern)). |
| 69 | RunTestWithBp(t, bp) |
| 70 | return result.TestContext, result.Config |
Jeongik Cha | 2cc570d | 2019-10-29 15:44:45 +0900 | [diff] [blame] | 71 | } |
| 72 | |
Paul Duffin | 71ae594 | 2021-03-22 15:36:52 +0000 | [diff] [blame] | 73 | // testJavaWithFS runs tests using the prepareForJavaTest |
Paul Duffin | 95bdab4 | 2021-03-08 21:48:46 +0000 | [diff] [blame] | 74 | // |
| 75 | // See testJava for an explanation as to how to stop using this deprecated method. |
| 76 | // |
| 77 | // deprecated |
| 78 | func testJavaWithFS(t *testing.T, bp string, fs android.MockFS) (*android.TestContext, android.Config) { |
Colin Cross | 238c1f3 | 2020-06-07 16:58:18 -0700 | [diff] [blame] | 79 | t.Helper() |
Paul Duffin | 71ae594 | 2021-03-22 15:36:52 +0000 | [diff] [blame] | 80 | result := android.GroupFixturePreparers( |
| 81 | prepareForJavaTest, fs.AddToFixture()).RunTestWithBp(t, bp) |
Paul Duffin | 95bdab4 | 2021-03-08 21:48:46 +0000 | [diff] [blame] | 82 | return result.TestContext, result.Config |
Colin Cross | 238c1f3 | 2020-06-07 16:58:18 -0700 | [diff] [blame] | 83 | } |
| 84 | |
Paul Duffin | 71ae594 | 2021-03-22 15:36:52 +0000 | [diff] [blame] | 85 | // testJava runs tests using the prepareForJavaTest |
Paul Duffin | 95bdab4 | 2021-03-08 21:48:46 +0000 | [diff] [blame] | 86 | // |
Paul Duffin | 71ae594 | 2021-03-22 15:36:52 +0000 | [diff] [blame] | 87 | // Do not add any new usages of this, instead use the prepareForJavaTest directly as it makes it |
Paul Duffin | 95bdab4 | 2021-03-08 21:48:46 +0000 | [diff] [blame] | 88 | // much easier to customize the test behavior. |
| 89 | // |
| 90 | // If it is necessary to customize the behavior of an existing test that uses this then please first |
Paul Duffin | 71ae594 | 2021-03-22 15:36:52 +0000 | [diff] [blame] | 91 | // convert the test to using prepareForJavaTest first and then in a following change add the |
Paul Duffin | 95bdab4 | 2021-03-08 21:48:46 +0000 | [diff] [blame] | 92 | // appropriate fixture preparers. Keeping the conversion change separate makes it easy to verify |
| 93 | // that it did not change the test behavior unexpectedly. |
| 94 | // |
| 95 | // deprecated |
Jaewoong Jung | f9a0443 | 2019-07-17 11:15:09 -0700 | [diff] [blame] | 96 | func testJava(t *testing.T, bp string) (*android.TestContext, android.Config) { |
Colin Cross | 6b4a32d | 2017-12-05 13:42:45 -0800 | [diff] [blame] | 97 | t.Helper() |
Paul Duffin | 71ae594 | 2021-03-22 15:36:52 +0000 | [diff] [blame] | 98 | result := prepareForJavaTest.RunTestWithBp(t, bp) |
Paul Duffin | 95bdab4 | 2021-03-08 21:48:46 +0000 | [diff] [blame] | 99 | return result.TestContext, result.Config |
Jeongik Cha | 2cc570d | 2019-10-29 15:44:45 +0900 | [diff] [blame] | 100 | } |
| 101 | |
Paul Duffin | 95bdab4 | 2021-03-08 21:48:46 +0000 | [diff] [blame] | 102 | // defaultModuleToPath constructs a path to the turbine generate jar for a default test module that |
| 103 | // is defined in PrepareForIntegrationTestWithJava |
| 104 | func defaultModuleToPath(name string) string { |
Paul Duffin | 76101fa | 2021-03-13 09:55:25 +0000 | [diff] [blame] | 105 | switch { |
| 106 | case name == `""`: |
| 107 | return name |
| 108 | case strings.HasSuffix(name, ".jar"): |
| 109 | return name |
| 110 | default: |
Paul Duffin | 414ea5e | 2021-03-22 17:31:52 +0000 | [diff] [blame] | 111 | return filepath.Join("out", "soong", ".intermediates", defaultJavaDir, name, "android_common", "turbine-combined", name+".jar") |
Paul Duffin | 76101fa | 2021-03-13 09:55:25 +0000 | [diff] [blame] | 112 | } |
Paul Duffin | 95bdab4 | 2021-03-08 21:48:46 +0000 | [diff] [blame] | 113 | } |
| 114 | |
Paul Duffin | 76e5c8a | 2021-03-20 14:19:46 +0000 | [diff] [blame] | 115 | // Test that the PrepareForTestWithJavaDefaultModules provides all the files that it uses by |
| 116 | // running it in a fixture that requires all source files to exist. |
| 117 | func TestPrepareForTestWithJavaDefaultModules(t *testing.T) { |
| 118 | android.GroupFixturePreparers( |
| 119 | PrepareForTestWithJavaDefaultModules, |
| 120 | android.PrepareForTestDisallowNonExistentPaths, |
| 121 | ).RunTest(t) |
| 122 | } |
| 123 | |
Jeongik Cha | e403e9e | 2019-12-07 00:16:24 +0900 | [diff] [blame] | 124 | func TestJavaLinkType(t *testing.T) { |
| 125 | testJava(t, ` |
| 126 | java_library { |
| 127 | name: "foo", |
| 128 | srcs: ["a.java"], |
| 129 | libs: ["bar"], |
| 130 | static_libs: ["baz"], |
| 131 | } |
| 132 | |
| 133 | java_library { |
| 134 | name: "bar", |
| 135 | sdk_version: "current", |
| 136 | srcs: ["b.java"], |
| 137 | } |
| 138 | |
| 139 | java_library { |
| 140 | name: "baz", |
| 141 | sdk_version: "system_current", |
| 142 | srcs: ["c.java"], |
| 143 | } |
| 144 | `) |
| 145 | |
Steven Moreland | 0029898 | 2020-11-17 21:44:36 +0000 | [diff] [blame] | 146 | testJavaError(t, "consider adjusting sdk_version: OR platform_apis:", ` |
Jeongik Cha | e403e9e | 2019-12-07 00:16:24 +0900 | [diff] [blame] | 147 | java_library { |
| 148 | name: "foo", |
| 149 | srcs: ["a.java"], |
| 150 | libs: ["bar"], |
| 151 | sdk_version: "current", |
| 152 | static_libs: ["baz"], |
| 153 | } |
| 154 | |
| 155 | java_library { |
| 156 | name: "bar", |
| 157 | sdk_version: "current", |
| 158 | srcs: ["b.java"], |
| 159 | } |
| 160 | |
| 161 | java_library { |
| 162 | name: "baz", |
| 163 | sdk_version: "system_current", |
| 164 | srcs: ["c.java"], |
| 165 | } |
| 166 | `) |
| 167 | |
| 168 | testJava(t, ` |
| 169 | java_library { |
| 170 | name: "foo", |
| 171 | srcs: ["a.java"], |
| 172 | libs: ["bar"], |
| 173 | sdk_version: "system_current", |
| 174 | static_libs: ["baz"], |
| 175 | } |
| 176 | |
| 177 | java_library { |
| 178 | name: "bar", |
| 179 | sdk_version: "current", |
| 180 | srcs: ["b.java"], |
| 181 | } |
| 182 | |
| 183 | java_library { |
| 184 | name: "baz", |
| 185 | sdk_version: "system_current", |
| 186 | srcs: ["c.java"], |
| 187 | } |
| 188 | `) |
| 189 | |
Steven Moreland | 0029898 | 2020-11-17 21:44:36 +0000 | [diff] [blame] | 190 | testJavaError(t, "consider adjusting sdk_version: OR platform_apis:", ` |
Jeongik Cha | e403e9e | 2019-12-07 00:16:24 +0900 | [diff] [blame] | 191 | java_library { |
| 192 | name: "foo", |
| 193 | srcs: ["a.java"], |
| 194 | libs: ["bar"], |
| 195 | sdk_version: "system_current", |
| 196 | static_libs: ["baz"], |
| 197 | } |
| 198 | |
| 199 | java_library { |
| 200 | name: "bar", |
| 201 | sdk_version: "current", |
| 202 | srcs: ["b.java"], |
| 203 | } |
| 204 | |
| 205 | java_library { |
| 206 | name: "baz", |
| 207 | srcs: ["c.java"], |
| 208 | } |
| 209 | `) |
| 210 | } |
| 211 | |
Colin Cross | 72bb363 | 2017-07-13 16:23:21 -0700 | [diff] [blame] | 212 | func TestSimple(t *testing.T) { |
Jaewoong Jung | f9a0443 | 2019-07-17 11:15:09 -0700 | [diff] [blame] | 213 | ctx, _ := testJava(t, ` |
Colin Cross | 72bb363 | 2017-07-13 16:23:21 -0700 | [diff] [blame] | 214 | java_library { |
| 215 | name: "foo", |
| 216 | srcs: ["a.java"], |
Colin Cross | e8dc34a | 2017-07-19 11:22:16 -0700 | [diff] [blame] | 217 | libs: ["bar"], |
| 218 | static_libs: ["baz"], |
Colin Cross | 72bb363 | 2017-07-13 16:23:21 -0700 | [diff] [blame] | 219 | } |
| 220 | |
| 221 | java_library { |
| 222 | name: "bar", |
| 223 | srcs: ["b.java"], |
| 224 | } |
| 225 | |
| 226 | java_library { |
| 227 | name: "baz", |
| 228 | srcs: ["c.java"], |
| 229 | } |
Colin Cross | d5934c8 | 2017-10-02 13:55:26 -0700 | [diff] [blame] | 230 | `) |
Colin Cross | 72bb363 | 2017-07-13 16:23:21 -0700 | [diff] [blame] | 231 | |
Paul Duffin | a71a67a | 2021-03-29 00:42:57 +0100 | [diff] [blame] | 232 | javac := ctx.ModuleForTests("foo", "android_common").Rule("javac") |
Nan Zhang | ed19fc3 | 2017-10-19 13:06:22 -0700 | [diff] [blame] | 233 | combineJar := ctx.ModuleForTests("foo", "android_common").Description("for javac") |
Colin Cross | 72bb363 | 2017-07-13 16:23:21 -0700 | [diff] [blame] | 234 | |
| 235 | if len(javac.Inputs) != 1 || javac.Inputs[0].String() != "a.java" { |
| 236 | t.Errorf(`foo inputs %v != ["a.java"]`, javac.Inputs) |
| 237 | } |
| 238 | |
Colin Cross | 1ee2317 | 2017-10-18 14:44:18 -0700 | [diff] [blame] | 239 | baz := ctx.ModuleForTests("baz", "android_common").Rule("javac").Output.String() |
Paul Duffin | 414ea5e | 2021-03-22 17:31:52 +0000 | [diff] [blame] | 240 | barTurbine := filepath.Join("out", "soong", ".intermediates", "bar", "android_common", "turbine-combined", "bar.jar") |
| 241 | bazTurbine := filepath.Join("out", "soong", ".intermediates", "baz", "android_common", "turbine-combined", "baz.jar") |
Colin Cross | 0a6e007 | 2017-08-30 14:24:55 -0700 | [diff] [blame] | 242 | |
Paul Duffin | 22b77cd | 2021-03-12 19:15:01 +0000 | [diff] [blame] | 243 | android.AssertStringDoesContain(t, "foo classpath", javac.Args["classpath"], barTurbine) |
Colin Cross | 72bb363 | 2017-07-13 16:23:21 -0700 | [diff] [blame] | 244 | |
Paul Duffin | 22b77cd | 2021-03-12 19:15:01 +0000 | [diff] [blame] | 245 | android.AssertStringDoesContain(t, "foo classpath", javac.Args["classpath"], bazTurbine) |
Colin Cross | 0a6e007 | 2017-08-30 14:24:55 -0700 | [diff] [blame] | 246 | |
| 247 | if len(combineJar.Inputs) != 2 || combineJar.Inputs[1].String() != baz { |
| 248 | t.Errorf("foo combineJar inputs %v does not contain %q", combineJar.Inputs, baz) |
Colin Cross | 72bb363 | 2017-07-13 16:23:21 -0700 | [diff] [blame] | 249 | } |
| 250 | } |
| 251 | |
Artur Satayev | 9cf4669 | 2019-11-26 18:08:34 +0000 | [diff] [blame] | 252 | func TestExportedPlugins(t *testing.T) { |
| 253 | type Result struct { |
Colin Cross | c9fe10f | 2020-11-19 18:06:03 -0800 | [diff] [blame] | 254 | library string |
| 255 | processors string |
| 256 | disableTurbine bool |
Artur Satayev | 9cf4669 | 2019-11-26 18:08:34 +0000 | [diff] [blame] | 257 | } |
| 258 | var tests = []struct { |
| 259 | name string |
| 260 | extra string |
| 261 | results []Result |
| 262 | }{ |
| 263 | { |
| 264 | name: "Exported plugin is not a direct plugin", |
| 265 | extra: `java_library { name: "exports", srcs: ["a.java"], exported_plugins: ["plugin"] }`, |
| 266 | results: []Result{{library: "exports", processors: "-proc:none"}}, |
| 267 | }, |
| 268 | { |
| 269 | name: "Exports plugin to dependee", |
| 270 | extra: ` |
| 271 | java_library{name: "exports", exported_plugins: ["plugin"]} |
| 272 | java_library{name: "foo", srcs: ["a.java"], libs: ["exports"]} |
| 273 | java_library{name: "bar", srcs: ["a.java"], static_libs: ["exports"]} |
| 274 | `, |
| 275 | results: []Result{ |
| 276 | {library: "foo", processors: "-processor com.android.TestPlugin"}, |
| 277 | {library: "bar", processors: "-processor com.android.TestPlugin"}, |
| 278 | }, |
| 279 | }, |
| 280 | { |
| 281 | name: "Exports plugin to android_library", |
| 282 | extra: ` |
| 283 | java_library{name: "exports", exported_plugins: ["plugin"]} |
| 284 | android_library{name: "foo", srcs: ["a.java"], libs: ["exports"]} |
| 285 | android_library{name: "bar", srcs: ["a.java"], static_libs: ["exports"]} |
| 286 | `, |
| 287 | results: []Result{ |
| 288 | {library: "foo", processors: "-processor com.android.TestPlugin"}, |
| 289 | {library: "bar", processors: "-processor com.android.TestPlugin"}, |
| 290 | }, |
| 291 | }, |
| 292 | { |
| 293 | name: "Exports plugin is not propagated via transitive deps", |
| 294 | extra: ` |
| 295 | java_library{name: "exports", exported_plugins: ["plugin"]} |
| 296 | java_library{name: "foo", srcs: ["a.java"], libs: ["exports"]} |
| 297 | java_library{name: "bar", srcs: ["a.java"], static_libs: ["foo"]} |
| 298 | `, |
| 299 | results: []Result{ |
| 300 | {library: "foo", processors: "-processor com.android.TestPlugin"}, |
| 301 | {library: "bar", processors: "-proc:none"}, |
| 302 | }, |
| 303 | }, |
| 304 | { |
| 305 | name: "Exports plugin appends to plugins", |
| 306 | extra: ` |
| 307 | java_plugin{name: "plugin2", processor_class: "com.android.TestPlugin2"} |
| 308 | java_library{name: "exports", exported_plugins: ["plugin"]} |
| 309 | java_library{name: "foo", srcs: ["a.java"], libs: ["exports"], plugins: ["plugin2"]} |
| 310 | `, |
| 311 | results: []Result{ |
| 312 | {library: "foo", processors: "-processor com.android.TestPlugin,com.android.TestPlugin2"}, |
| 313 | }, |
| 314 | }, |
Colin Cross | c9fe10f | 2020-11-19 18:06:03 -0800 | [diff] [blame] | 315 | { |
| 316 | name: "Exports plugin to with generates_api to dependee", |
| 317 | extra: ` |
| 318 | java_library{name: "exports", exported_plugins: ["plugin_generates_api"]} |
| 319 | java_library{name: "foo", srcs: ["a.java"], libs: ["exports"]} |
| 320 | java_library{name: "bar", srcs: ["a.java"], static_libs: ["exports"]} |
| 321 | `, |
| 322 | results: []Result{ |
| 323 | {library: "foo", processors: "-processor com.android.TestPlugin", disableTurbine: true}, |
| 324 | {library: "bar", processors: "-processor com.android.TestPlugin", disableTurbine: true}, |
| 325 | }, |
| 326 | }, |
Artur Satayev | 9cf4669 | 2019-11-26 18:08:34 +0000 | [diff] [blame] | 327 | } |
| 328 | |
| 329 | for _, test := range tests { |
| 330 | t.Run(test.name, func(t *testing.T) { |
| 331 | ctx, _ := testJava(t, ` |
| 332 | java_plugin { |
| 333 | name: "plugin", |
| 334 | processor_class: "com.android.TestPlugin", |
| 335 | } |
Colin Cross | c9fe10f | 2020-11-19 18:06:03 -0800 | [diff] [blame] | 336 | java_plugin { |
| 337 | name: "plugin_generates_api", |
| 338 | generates_api: true, |
| 339 | processor_class: "com.android.TestPlugin", |
| 340 | } |
Artur Satayev | 9cf4669 | 2019-11-26 18:08:34 +0000 | [diff] [blame] | 341 | `+test.extra) |
| 342 | |
| 343 | for _, want := range test.results { |
| 344 | javac := ctx.ModuleForTests(want.library, "android_common").Rule("javac") |
| 345 | if javac.Args["processor"] != want.processors { |
| 346 | t.Errorf("For library %v, expected %v, found %v", want.library, want.processors, javac.Args["processor"]) |
| 347 | } |
Colin Cross | c9fe10f | 2020-11-19 18:06:03 -0800 | [diff] [blame] | 348 | turbine := ctx.ModuleForTests(want.library, "android_common").MaybeRule("turbine") |
| 349 | disableTurbine := turbine.BuildParams.Rule == nil |
| 350 | if disableTurbine != want.disableTurbine { |
| 351 | t.Errorf("For library %v, expected disableTurbine %v, found %v", want.library, want.disableTurbine, disableTurbine) |
| 352 | } |
Artur Satayev | 9cf4669 | 2019-11-26 18:08:34 +0000 | [diff] [blame] | 353 | } |
| 354 | }) |
| 355 | } |
| 356 | } |
| 357 | |
Jeongik Cha | 2cc570d | 2019-10-29 15:44:45 +0900 | [diff] [blame] | 358 | func TestSdkVersionByPartition(t *testing.T) { |
| 359 | testJavaError(t, "sdk_version must have a value when the module is located at vendor or product", ` |
Jeongik Cha | 6bd33c1 | 2019-06-25 16:26:18 +0900 | [diff] [blame] | 360 | java_library { |
| 361 | name: "foo", |
| 362 | srcs: ["a.java"], |
| 363 | vendor: true, |
| 364 | } |
Jeongik Cha | 2cc570d | 2019-10-29 15:44:45 +0900 | [diff] [blame] | 365 | `) |
Jeongik Cha | 6bd33c1 | 2019-06-25 16:26:18 +0900 | [diff] [blame] | 366 | |
Jeongik Cha | 2cc570d | 2019-10-29 15:44:45 +0900 | [diff] [blame] | 367 | testJava(t, ` |
Jeongik Cha | 6bd33c1 | 2019-06-25 16:26:18 +0900 | [diff] [blame] | 368 | java_library { |
| 369 | name: "bar", |
| 370 | srcs: ["b.java"], |
| 371 | } |
| 372 | `) |
| 373 | |
Jeongik Cha | 2cc570d | 2019-10-29 15:44:45 +0900 | [diff] [blame] | 374 | for _, enforce := range []bool{true, false} { |
Jeongik Cha | 2cc570d | 2019-10-29 15:44:45 +0900 | [diff] [blame] | 375 | bp := ` |
| 376 | java_library { |
| 377 | name: "foo", |
| 378 | srcs: ["a.java"], |
| 379 | product_specific: true, |
| 380 | } |
| 381 | ` |
Colin Cross | 98be1bb | 2019-12-13 20:41:13 -0800 | [diff] [blame] | 382 | |
Paul Duffin | 414ea5e | 2021-03-22 17:31:52 +0000 | [diff] [blame] | 383 | errorHandler := android.FixtureExpectsNoErrors |
Jeongik Cha | 2cc570d | 2019-10-29 15:44:45 +0900 | [diff] [blame] | 384 | if enforce { |
Paul Duffin | 414ea5e | 2021-03-22 17:31:52 +0000 | [diff] [blame] | 385 | errorHandler = android.FixtureExpectsAtLeastOneErrorMatchingPattern("sdk_version must have a value when the module is located at vendor or product") |
Jeongik Cha | 2cc570d | 2019-10-29 15:44:45 +0900 | [diff] [blame] | 386 | } |
Paul Duffin | 414ea5e | 2021-03-22 17:31:52 +0000 | [diff] [blame] | 387 | |
| 388 | android.GroupFixturePreparers( |
| 389 | PrepareForTestWithJavaDefaultModules, |
| 390 | android.FixtureModifyProductVariables(func(variables android.FixtureProductVariables) { |
| 391 | variables.EnforceProductPartitionInterface = proptools.BoolPtr(enforce) |
| 392 | }), |
| 393 | ). |
| 394 | ExtendWithErrorHandler(errorHandler). |
| 395 | RunTestWithBp(t, bp) |
Jeongik Cha | 6bd33c1 | 2019-06-25 16:26:18 +0900 | [diff] [blame] | 396 | } |
| 397 | } |
| 398 | |
Colin Cross | d5934c8 | 2017-10-02 13:55:26 -0700 | [diff] [blame] | 399 | func TestArchSpecific(t *testing.T) { |
Jaewoong Jung | f9a0443 | 2019-07-17 11:15:09 -0700 | [diff] [blame] | 400 | ctx, _ := testJava(t, ` |
Colin Cross | d5934c8 | 2017-10-02 13:55:26 -0700 | [diff] [blame] | 401 | java_library { |
| 402 | name: "foo", |
| 403 | srcs: ["a.java"], |
| 404 | target: { |
| 405 | android: { |
| 406 | srcs: ["b.java"], |
| 407 | }, |
| 408 | }, |
| 409 | } |
| 410 | `) |
| 411 | |
| 412 | javac := ctx.ModuleForTests("foo", "android_common").Rule("javac") |
| 413 | if len(javac.Inputs) != 2 || javac.Inputs[0].String() != "a.java" || javac.Inputs[1].String() != "b.java" { |
| 414 | t.Errorf(`foo inputs %v != ["a.java", "b.java"]`, javac.Inputs) |
| 415 | } |
| 416 | } |
| 417 | |
Colin Cross | 6b4a32d | 2017-12-05 13:42:45 -0800 | [diff] [blame] | 418 | func TestBinary(t *testing.T) { |
Jaewoong Jung | f9a0443 | 2019-07-17 11:15:09 -0700 | [diff] [blame] | 419 | ctx, _ := testJava(t, ` |
Colin Cross | 6b4a32d | 2017-12-05 13:42:45 -0800 | [diff] [blame] | 420 | java_library_host { |
| 421 | name: "foo", |
| 422 | srcs: ["a.java"], |
| 423 | } |
| 424 | |
| 425 | java_binary_host { |
| 426 | name: "bar", |
| 427 | srcs: ["b.java"], |
| 428 | static_libs: ["foo"], |
Colin Cross | 89226d9 | 2020-10-09 19:00:54 -0700 | [diff] [blame] | 429 | jni_libs: ["libjni"], |
| 430 | } |
| 431 | |
| 432 | cc_library_shared { |
| 433 | name: "libjni", |
| 434 | host_supported: true, |
| 435 | device_supported: false, |
| 436 | stl: "none", |
Colin Cross | 6b4a32d | 2017-12-05 13:42:45 -0800 | [diff] [blame] | 437 | } |
| 438 | `) |
| 439 | |
Colin Cross | 0c66bc6 | 2021-07-20 09:47:41 -0700 | [diff] [blame] | 440 | buildOS := ctx.Config().BuildOS.String() |
Colin Cross | 6b4a32d | 2017-12-05 13:42:45 -0800 | [diff] [blame] | 441 | |
| 442 | bar := ctx.ModuleForTests("bar", buildOS+"_common") |
| 443 | barJar := bar.Output("bar.jar").Output.String() |
| 444 | barWrapper := ctx.ModuleForTests("bar", buildOS+"_x86_64") |
| 445 | barWrapperDeps := barWrapper.Output("bar").Implicits.Strings() |
| 446 | |
Colin Cross | 89226d9 | 2020-10-09 19:00:54 -0700 | [diff] [blame] | 447 | libjni := ctx.ModuleForTests("libjni", buildOS+"_x86_64_shared") |
| 448 | libjniSO := libjni.Rule("Cp").Output.String() |
| 449 | |
Colin Cross | 6b4a32d | 2017-12-05 13:42:45 -0800 | [diff] [blame] | 450 | // Test that the install binary wrapper depends on the installed jar file |
Colin Cross | c179ea6 | 2020-10-09 10:54:15 -0700 | [diff] [blame] | 451 | if g, w := barWrapperDeps, barJar; !android.InList(w, g) { |
| 452 | t.Errorf("expected binary wrapper implicits to contain %q, got %q", w, g) |
Colin Cross | 6b4a32d | 2017-12-05 13:42:45 -0800 | [diff] [blame] | 453 | } |
Colin Cross | 89226d9 | 2020-10-09 19:00:54 -0700 | [diff] [blame] | 454 | |
| 455 | // Test that the install binary wrapper depends on the installed JNI libraries |
| 456 | if g, w := barWrapperDeps, libjniSO; !android.InList(w, g) { |
| 457 | t.Errorf("expected binary wrapper implicits to contain %q, got %q", w, g) |
Colin Cross | 6b4a32d | 2017-12-05 13:42:45 -0800 | [diff] [blame] | 458 | } |
Alex Humesky | 2070e32 | 2020-06-09 20:23:08 -0400 | [diff] [blame] | 459 | } |
Colin Cross | 6b4a32d | 2017-12-05 13:42:45 -0800 | [diff] [blame] | 460 | |
Colin Cross | f8d9c49 | 2021-01-26 11:01:43 -0800 | [diff] [blame] | 461 | func TestTest(t *testing.T) { |
| 462 | ctx, _ := testJava(t, ` |
| 463 | java_test_host { |
| 464 | name: "foo", |
| 465 | srcs: ["a.java"], |
| 466 | jni_libs: ["libjni"], |
| 467 | } |
| 468 | |
| 469 | cc_library_shared { |
| 470 | name: "libjni", |
| 471 | host_supported: true, |
| 472 | device_supported: false, |
| 473 | stl: "none", |
| 474 | } |
| 475 | `) |
| 476 | |
Colin Cross | 0c66bc6 | 2021-07-20 09:47:41 -0700 | [diff] [blame] | 477 | buildOS := ctx.Config().BuildOS.String() |
Colin Cross | f8d9c49 | 2021-01-26 11:01:43 -0800 | [diff] [blame] | 478 | |
| 479 | foo := ctx.ModuleForTests("foo", buildOS+"_common").Module().(*TestHost) |
| 480 | |
| 481 | expected := "lib64/libjni.so" |
| 482 | if runtime.GOOS == "darwin" { |
| 483 | expected = "lib64/libjni.dylib" |
| 484 | } |
| 485 | |
| 486 | fooTestData := foo.data |
| 487 | if len(fooTestData) != 1 || fooTestData[0].Rel() != expected { |
| 488 | t.Errorf(`expected foo test data relative path [%q], got %q`, |
| 489 | expected, fooTestData.Strings()) |
| 490 | } |
| 491 | } |
| 492 | |
Alex Humesky | 2070e32 | 2020-06-09 20:23:08 -0400 | [diff] [blame] | 493 | func TestHostBinaryNoJavaDebugInfoOverride(t *testing.T) { |
| 494 | bp := ` |
| 495 | java_library { |
| 496 | name: "target_library", |
| 497 | srcs: ["a.java"], |
| 498 | } |
| 499 | |
| 500 | java_binary_host { |
| 501 | name: "host_binary", |
| 502 | srcs: ["b.java"], |
| 503 | } |
| 504 | ` |
Alex Humesky | 2070e32 | 2020-06-09 20:23:08 -0400 | [diff] [blame] | 505 | |
Paul Duffin | 414ea5e | 2021-03-22 17:31:52 +0000 | [diff] [blame] | 506 | result := android.GroupFixturePreparers( |
| 507 | PrepareForTestWithJavaDefaultModules, |
| 508 | android.FixtureModifyProductVariables(func(variables android.FixtureProductVariables) { |
| 509 | variables.MinimizeJavaDebugInfo = proptools.BoolPtr(true) |
| 510 | }), |
| 511 | ).RunTestWithBp(t, bp) |
Alex Humesky | 2070e32 | 2020-06-09 20:23:08 -0400 | [diff] [blame] | 512 | |
Liz Kammer | 7941b30 | 2020-07-28 13:27:34 -0700 | [diff] [blame] | 513 | // first, check that the -g flag is added to target modules |
Paul Duffin | 414ea5e | 2021-03-22 17:31:52 +0000 | [diff] [blame] | 514 | targetLibrary := result.ModuleForTests("target_library", "android_common") |
Alex Humesky | 2070e32 | 2020-06-09 20:23:08 -0400 | [diff] [blame] | 515 | targetJavaFlags := targetLibrary.Module().VariablesForTests()["javacFlags"] |
| 516 | if !strings.Contains(targetJavaFlags, "-g:source,lines") { |
| 517 | t.Errorf("target library javac flags %v should contain "+ |
| 518 | "-g:source,lines override with MinimizeJavaDebugInfo", targetJavaFlags) |
| 519 | } |
| 520 | |
| 521 | // check that -g is not overridden for host modules |
Colin Cross | 0c66bc6 | 2021-07-20 09:47:41 -0700 | [diff] [blame] | 522 | buildOS := result.Config.BuildOS.String() |
Paul Duffin | 414ea5e | 2021-03-22 17:31:52 +0000 | [diff] [blame] | 523 | hostBinary := result.ModuleForTests("host_binary", buildOS+"_common") |
Alex Humesky | 2070e32 | 2020-06-09 20:23:08 -0400 | [diff] [blame] | 524 | hostJavaFlags := hostBinary.Module().VariablesForTests()["javacFlags"] |
| 525 | if strings.Contains(hostJavaFlags, "-g:source,lines") { |
| 526 | t.Errorf("java_binary_host javac flags %v should not have "+ |
| 527 | "-g:source,lines override with MinimizeJavaDebugInfo", hostJavaFlags) |
| 528 | } |
Colin Cross | 6b4a32d | 2017-12-05 13:42:45 -0800 | [diff] [blame] | 529 | } |
| 530 | |
Colin Cross | 72bb363 | 2017-07-13 16:23:21 -0700 | [diff] [blame] | 531 | func TestPrebuilts(t *testing.T) { |
Jaewoong Jung | f9a0443 | 2019-07-17 11:15:09 -0700 | [diff] [blame] | 532 | ctx, _ := testJava(t, ` |
Colin Cross | 72bb363 | 2017-07-13 16:23:21 -0700 | [diff] [blame] | 533 | java_library { |
| 534 | name: "foo", |
Paul Duffin | 9154718 | 2019-11-12 19:39:36 +0000 | [diff] [blame] | 535 | srcs: ["a.java", ":stubs-source"], |
Paul Duffin | fcfd791 | 2020-01-31 17:54:30 +0000 | [diff] [blame] | 536 | libs: ["bar", "sdklib"], |
Colin Cross | e8dc34a | 2017-07-19 11:22:16 -0700 | [diff] [blame] | 537 | static_libs: ["baz"], |
Colin Cross | 72bb363 | 2017-07-13 16:23:21 -0700 | [diff] [blame] | 538 | } |
| 539 | |
Colin Cross | 74d73e2 | 2017-08-02 11:05:49 -0700 | [diff] [blame] | 540 | java_import { |
Colin Cross | 72bb363 | 2017-07-13 16:23:21 -0700 | [diff] [blame] | 541 | name: "bar", |
Colin Cross | 74d73e2 | 2017-08-02 11:05:49 -0700 | [diff] [blame] | 542 | jars: ["a.jar"], |
Colin Cross | 72bb363 | 2017-07-13 16:23:21 -0700 | [diff] [blame] | 543 | } |
| 544 | |
Colin Cross | 74d73e2 | 2017-08-02 11:05:49 -0700 | [diff] [blame] | 545 | java_import { |
Colin Cross | 72bb363 | 2017-07-13 16:23:21 -0700 | [diff] [blame] | 546 | name: "baz", |
Colin Cross | 74d73e2 | 2017-08-02 11:05:49 -0700 | [diff] [blame] | 547 | jars: ["b.jar"], |
Liz Kammer | d6c31d2 | 2020-08-05 15:40:41 -0700 | [diff] [blame] | 548 | sdk_version: "current", |
| 549 | compile_dex: true, |
Colin Cross | 72bb363 | 2017-07-13 16:23:21 -0700 | [diff] [blame] | 550 | } |
Colin Cross | 42be761 | 2019-02-21 18:12:14 -0800 | [diff] [blame] | 551 | |
| 552 | dex_import { |
| 553 | name: "qux", |
| 554 | jars: ["b.jar"], |
| 555 | } |
Colin Cross | 79c7c26 | 2019-04-17 11:11:46 -0700 | [diff] [blame] | 556 | |
| 557 | java_sdk_library_import { |
Paul Duffin | 56d4490 | 2020-01-31 13:36:25 +0000 | [diff] [blame] | 558 | name: "sdklib", |
| 559 | public: { |
| 560 | jars: ["c.jar"], |
| 561 | }, |
| 562 | } |
| 563 | |
Paul Duffin | 9154718 | 2019-11-12 19:39:36 +0000 | [diff] [blame] | 564 | prebuilt_stubs_sources { |
| 565 | name: "stubs-source", |
Paul Duffin | 9b478b0 | 2019-12-10 13:41:51 +0000 | [diff] [blame] | 566 | srcs: ["stubs/sources"], |
Paul Duffin | 9154718 | 2019-11-12 19:39:36 +0000 | [diff] [blame] | 567 | } |
Paul Duffin | 1b82e6a | 2019-12-03 18:06:47 +0000 | [diff] [blame] | 568 | |
| 569 | java_test_import { |
| 570 | name: "test", |
| 571 | jars: ["a.jar"], |
| 572 | test_suites: ["cts"], |
| 573 | test_config: "AndroidTest.xml", |
| 574 | } |
Colin Cross | 72bb363 | 2017-07-13 16:23:21 -0700 | [diff] [blame] | 575 | `) |
| 576 | |
Paul Duffin | 9b478b0 | 2019-12-10 13:41:51 +0000 | [diff] [blame] | 577 | fooModule := ctx.ModuleForTests("foo", "android_common") |
| 578 | javac := fooModule.Rule("javac") |
Nan Zhang | ed19fc3 | 2017-10-19 13:06:22 -0700 | [diff] [blame] | 579 | combineJar := ctx.ModuleForTests("foo", "android_common").Description("for javac") |
Liz Kammer | d6c31d2 | 2020-08-05 15:40:41 -0700 | [diff] [blame] | 580 | barModule := ctx.ModuleForTests("bar", "android_common") |
| 581 | barJar := barModule.Rule("combineJar").Output |
| 582 | bazModule := ctx.ModuleForTests("baz", "android_common") |
| 583 | bazJar := bazModule.Rule("combineJar").Output |
Colin Cross | 79c7c26 | 2019-04-17 11:11:46 -0700 | [diff] [blame] | 584 | sdklibStubsJar := ctx.ModuleForTests("sdklib.stubs", "android_common").Rule("combineJar").Output |
Colin Cross | 72bb363 | 2017-07-13 16:23:21 -0700 | [diff] [blame] | 585 | |
Paul Duffin | 9b478b0 | 2019-12-10 13:41:51 +0000 | [diff] [blame] | 586 | fooLibrary := fooModule.Module().(*Library) |
Chaohui Wang | dcbe33c | 2022-10-11 11:13:30 +0800 | [diff] [blame] | 587 | assertDeepEquals(t, "foo unique sources incorrect", |
| 588 | []string{"a.java"}, fooLibrary.uniqueSrcFiles.Strings()) |
Paul Duffin | 9154718 | 2019-11-12 19:39:36 +0000 | [diff] [blame] | 589 | |
Paul Duffin | 9b478b0 | 2019-12-10 13:41:51 +0000 | [diff] [blame] | 590 | assertDeepEquals(t, "foo java source jars incorrect", |
| 591 | []string{".intermediates/stubs-source/android_common/stubs-source-stubs.srcjar"}, |
| 592 | android.NormalizePathsForTesting(fooLibrary.compiledSrcJars)) |
Paul Duffin | 9154718 | 2019-11-12 19:39:36 +0000 | [diff] [blame] | 593 | |
Colin Cross | 37f6d79 | 2018-07-12 12:28:41 -0700 | [diff] [blame] | 594 | if !strings.Contains(javac.Args["classpath"], barJar.String()) { |
| 595 | t.Errorf("foo classpath %v does not contain %q", javac.Args["classpath"], barJar.String()) |
Colin Cross | 72bb363 | 2017-07-13 16:23:21 -0700 | [diff] [blame] | 596 | } |
| 597 | |
Liz Kammer | d6c31d2 | 2020-08-05 15:40:41 -0700 | [diff] [blame] | 598 | barDexJar := barModule.Module().(*Import).DexJarBuildPath() |
Martin Stjernholm | 8be1e6d | 2021-09-15 03:34:04 +0100 | [diff] [blame] | 599 | if barDexJar.IsSet() { |
| 600 | t.Errorf("bar dex jar build path expected to be set, got %s", barDexJar) |
Liz Kammer | d6c31d2 | 2020-08-05 15:40:41 -0700 | [diff] [blame] | 601 | } |
| 602 | |
Colin Cross | 79c7c26 | 2019-04-17 11:11:46 -0700 | [diff] [blame] | 603 | if !strings.Contains(javac.Args["classpath"], sdklibStubsJar.String()) { |
| 604 | t.Errorf("foo classpath %v does not contain %q", javac.Args["classpath"], sdklibStubsJar.String()) |
| 605 | } |
| 606 | |
Colin Cross | 37f6d79 | 2018-07-12 12:28:41 -0700 | [diff] [blame] | 607 | if len(combineJar.Inputs) != 2 || combineJar.Inputs[1].String() != bazJar.String() { |
| 608 | t.Errorf("foo combineJar inputs %v does not contain %q", combineJar.Inputs, bazJar.String()) |
Colin Cross | 72bb363 | 2017-07-13 16:23:21 -0700 | [diff] [blame] | 609 | } |
Colin Cross | 42be761 | 2019-02-21 18:12:14 -0800 | [diff] [blame] | 610 | |
Martin Stjernholm | 8be1e6d | 2021-09-15 03:34:04 +0100 | [diff] [blame] | 611 | bazDexJar := bazModule.Module().(*Import).DexJarBuildPath().Path() |
Paul Duffin | 414ea5e | 2021-03-22 17:31:52 +0000 | [diff] [blame] | 612 | expectedDexJar := "out/soong/.intermediates/baz/android_common/dex/baz.jar" |
| 613 | android.AssertPathRelativeToTopEquals(t, "baz dex jar build path", expectedDexJar, bazDexJar) |
Liz Kammer | d6c31d2 | 2020-08-05 15:40:41 -0700 | [diff] [blame] | 614 | |
Colin Cross | 42be761 | 2019-02-21 18:12:14 -0800 | [diff] [blame] | 615 | ctx.ModuleForTests("qux", "android_common").Rule("Cp") |
Wei Li | 598f92d | 2023-01-04 17:12:24 -0800 | [diff] [blame] | 616 | |
| 617 | entries := android.AndroidMkEntriesForTest(t, ctx, fooModule.Module())[0] |
| 618 | android.AssertStringEquals(t, "unexpected LOCAL_SOONG_MODULE_TYPE", "java_library", entries.EntryMap["LOCAL_SOONG_MODULE_TYPE"][0]) |
| 619 | entries = android.AndroidMkEntriesForTest(t, ctx, barModule.Module())[0] |
| 620 | android.AssertStringEquals(t, "unexpected LOCAL_SOONG_MODULE_TYPE", "java_import", entries.EntryMap["LOCAL_SOONG_MODULE_TYPE"][0]) |
| 621 | entries = android.AndroidMkEntriesForTest(t, ctx, ctx.ModuleForTests("sdklib", "android_common").Module())[0] |
| 622 | android.AssertStringEquals(t, "unexpected LOCAL_SOONG_MODULE_TYPE", "java_sdk_library_import", entries.EntryMap["LOCAL_SOONG_MODULE_TYPE"][0]) |
Colin Cross | 72bb363 | 2017-07-13 16:23:21 -0700 | [diff] [blame] | 623 | } |
| 624 | |
Paul Duffin | 9b478b0 | 2019-12-10 13:41:51 +0000 | [diff] [blame] | 625 | func assertDeepEquals(t *testing.T, message string, expected interface{}, actual interface{}) { |
| 626 | if !reflect.DeepEqual(expected, actual) { |
| 627 | t.Errorf("%s: expected %q, found %q", message, expected, actual) |
| 628 | } |
| 629 | } |
| 630 | |
Paul Duffin | 1a39332 | 2020-11-18 16:36:47 +0000 | [diff] [blame] | 631 | func TestPrebuiltStubsSources(t *testing.T) { |
| 632 | test := func(t *testing.T, sourcesPath string, expectedInputs []string) { |
| 633 | ctx, _ := testJavaWithFS(t, fmt.Sprintf(` |
| 634 | prebuilt_stubs_sources { |
| 635 | name: "stubs-source", |
| 636 | srcs: ["%s"], |
| 637 | }`, sourcesPath), map[string][]byte{ |
| 638 | "stubs/sources/pkg/A.java": nil, |
| 639 | "stubs/sources/pkg/B.java": nil, |
| 640 | }) |
| 641 | |
| 642 | zipSrc := ctx.ModuleForTests("stubs-source", "android_common").Rule("zip_src") |
| 643 | if expected, actual := expectedInputs, zipSrc.Inputs.Strings(); !reflect.DeepEqual(expected, actual) { |
| 644 | t.Errorf("mismatch of inputs to soong_zip: expected %q, actual %q", expected, actual) |
| 645 | } |
| 646 | } |
| 647 | |
| 648 | t.Run("empty/missing directory", func(t *testing.T) { |
Colin Cross | ce3a51d | 2021-03-19 16:22:12 -0700 | [diff] [blame] | 649 | test(t, "empty-directory", nil) |
Paul Duffin | 1a39332 | 2020-11-18 16:36:47 +0000 | [diff] [blame] | 650 | }) |
| 651 | |
| 652 | t.Run("non-empty set of sources", func(t *testing.T) { |
| 653 | test(t, "stubs/sources", []string{ |
| 654 | "stubs/sources/pkg/A.java", |
| 655 | "stubs/sources/pkg/B.java", |
| 656 | }) |
| 657 | }) |
| 658 | } |
| 659 | |
Colin Cross | 89536d4 | 2017-07-07 14:35:50 -0700 | [diff] [blame] | 660 | func TestDefaults(t *testing.T) { |
Jaewoong Jung | f9a0443 | 2019-07-17 11:15:09 -0700 | [diff] [blame] | 661 | ctx, _ := testJava(t, ` |
Colin Cross | 89536d4 | 2017-07-07 14:35:50 -0700 | [diff] [blame] | 662 | java_defaults { |
| 663 | name: "defaults", |
| 664 | srcs: ["a.java"], |
| 665 | libs: ["bar"], |
| 666 | static_libs: ["baz"], |
Sasha Smundak | 2057f82 | 2019-04-16 17:16:58 -0700 | [diff] [blame] | 667 | optimize: {enabled: false}, |
Colin Cross | 89536d4 | 2017-07-07 14:35:50 -0700 | [diff] [blame] | 668 | } |
| 669 | |
| 670 | java_library { |
| 671 | name: "foo", |
| 672 | defaults: ["defaults"], |
| 673 | } |
| 674 | |
| 675 | java_library { |
| 676 | name: "bar", |
| 677 | srcs: ["b.java"], |
| 678 | } |
| 679 | |
| 680 | java_library { |
| 681 | name: "baz", |
| 682 | srcs: ["c.java"], |
| 683 | } |
Sasha Smundak | 2057f82 | 2019-04-16 17:16:58 -0700 | [diff] [blame] | 684 | |
| 685 | android_test { |
| 686 | name: "atestOptimize", |
| 687 | defaults: ["defaults"], |
| 688 | optimize: {enabled: true}, |
| 689 | } |
| 690 | |
| 691 | android_test { |
| 692 | name: "atestNoOptimize", |
| 693 | defaults: ["defaults"], |
| 694 | } |
| 695 | |
| 696 | android_test { |
| 697 | name: "atestDefault", |
| 698 | srcs: ["a.java"], |
| 699 | } |
Colin Cross | 89536d4 | 2017-07-07 14:35:50 -0700 | [diff] [blame] | 700 | `) |
| 701 | |
Paul Duffin | a71a67a | 2021-03-29 00:42:57 +0100 | [diff] [blame] | 702 | javac := ctx.ModuleForTests("foo", "android_common").Rule("javac") |
Nan Zhang | ed19fc3 | 2017-10-19 13:06:22 -0700 | [diff] [blame] | 703 | combineJar := ctx.ModuleForTests("foo", "android_common").Description("for javac") |
Colin Cross | 89536d4 | 2017-07-07 14:35:50 -0700 | [diff] [blame] | 704 | |
| 705 | if len(javac.Inputs) != 1 || javac.Inputs[0].String() != "a.java" { |
| 706 | t.Errorf(`foo inputs %v != ["a.java"]`, javac.Inputs) |
| 707 | } |
| 708 | |
Paul Duffin | 414ea5e | 2021-03-22 17:31:52 +0000 | [diff] [blame] | 709 | barTurbine := filepath.Join("out", "soong", ".intermediates", "bar", "android_common", "turbine-combined", "bar.jar") |
Nan Zhang | ed19fc3 | 2017-10-19 13:06:22 -0700 | [diff] [blame] | 710 | if !strings.Contains(javac.Args["classpath"], barTurbine) { |
| 711 | t.Errorf("foo classpath %v does not contain %q", javac.Args["classpath"], barTurbine) |
Colin Cross | 89536d4 | 2017-07-07 14:35:50 -0700 | [diff] [blame] | 712 | } |
| 713 | |
Colin Cross | 1ee2317 | 2017-10-18 14:44:18 -0700 | [diff] [blame] | 714 | baz := ctx.ModuleForTests("baz", "android_common").Rule("javac").Output.String() |
Colin Cross | 0a6e007 | 2017-08-30 14:24:55 -0700 | [diff] [blame] | 715 | if len(combineJar.Inputs) != 2 || combineJar.Inputs[1].String() != baz { |
| 716 | t.Errorf("foo combineJar inputs %v does not contain %q", combineJar.Inputs, baz) |
Colin Cross | 89536d4 | 2017-07-07 14:35:50 -0700 | [diff] [blame] | 717 | } |
Sasha Smundak | 2057f82 | 2019-04-16 17:16:58 -0700 | [diff] [blame] | 718 | |
| 719 | atestOptimize := ctx.ModuleForTests("atestOptimize", "android_common").MaybeRule("r8") |
| 720 | if atestOptimize.Output == nil { |
| 721 | t.Errorf("atestOptimize should optimize APK") |
| 722 | } |
| 723 | |
| 724 | atestNoOptimize := ctx.ModuleForTests("atestNoOptimize", "android_common").MaybeRule("d8") |
| 725 | if atestNoOptimize.Output == nil { |
| 726 | t.Errorf("atestNoOptimize should not optimize APK") |
| 727 | } |
| 728 | |
Jared Duke | 63a3da9 | 2022-06-02 19:11:14 +0000 | [diff] [blame] | 729 | atestDefault := ctx.ModuleForTests("atestDefault", "android_common").MaybeRule("d8") |
Sasha Smundak | 2057f82 | 2019-04-16 17:16:58 -0700 | [diff] [blame] | 730 | if atestDefault.Output == nil { |
Jared Duke | 63a3da9 | 2022-06-02 19:11:14 +0000 | [diff] [blame] | 731 | t.Errorf("atestDefault should not optimize APK") |
Sasha Smundak | 2057f82 | 2019-04-16 17:16:58 -0700 | [diff] [blame] | 732 | } |
Colin Cross | 89536d4 | 2017-07-07 14:35:50 -0700 | [diff] [blame] | 733 | } |
| 734 | |
Colin Cross | 0f37af0 | 2017-09-27 17:42:05 -0700 | [diff] [blame] | 735 | func TestResources(t *testing.T) { |
| 736 | var table = []struct { |
| 737 | name string |
| 738 | prop string |
| 739 | extra string |
| 740 | args string |
| 741 | }{ |
| 742 | { |
Colin Cross | af9c55b | 2017-10-03 14:50:08 -0700 | [diff] [blame] | 743 | // Test that a module with java_resource_dirs includes the files |
Colin Cross | 0f37af0 | 2017-09-27 17:42:05 -0700 | [diff] [blame] | 744 | name: "resource dirs", |
Colin Cross | 824bee3 | 2017-11-22 17:27:51 -0800 | [diff] [blame] | 745 | prop: `java_resource_dirs: ["java-res"]`, |
Colin Cross | 0ead1d7 | 2018-04-10 13:07:42 -0700 | [diff] [blame] | 746 | args: "-C java-res -f java-res/a/a -f java-res/b/b", |
Colin Cross | 0f37af0 | 2017-09-27 17:42:05 -0700 | [diff] [blame] | 747 | }, |
| 748 | { |
| 749 | // Test that a module with java_resources includes the files |
| 750 | name: "resource files", |
Colin Cross | 0ead1d7 | 2018-04-10 13:07:42 -0700 | [diff] [blame] | 751 | prop: `java_resources: ["java-res/a/a", "java-res/b/b"]`, |
| 752 | args: "-C . -f java-res/a/a -f java-res/b/b", |
Colin Cross | 0f37af0 | 2017-09-27 17:42:05 -0700 | [diff] [blame] | 753 | }, |
| 754 | { |
| 755 | // Test that a module with a filegroup in java_resources includes the files with the |
| 756 | // path prefix |
| 757 | name: "resource filegroup", |
| 758 | prop: `java_resources: [":foo-res"]`, |
| 759 | extra: ` |
| 760 | filegroup { |
| 761 | name: "foo-res", |
Colin Cross | 824bee3 | 2017-11-22 17:27:51 -0800 | [diff] [blame] | 762 | path: "java-res", |
Colin Cross | 0ead1d7 | 2018-04-10 13:07:42 -0700 | [diff] [blame] | 763 | srcs: ["java-res/a/a", "java-res/b/b"], |
Colin Cross | 0f37af0 | 2017-09-27 17:42:05 -0700 | [diff] [blame] | 764 | }`, |
Colin Cross | 0ead1d7 | 2018-04-10 13:07:42 -0700 | [diff] [blame] | 765 | args: "-C java-res -f java-res/a/a -f java-res/b/b", |
Colin Cross | 0f37af0 | 2017-09-27 17:42:05 -0700 | [diff] [blame] | 766 | }, |
| 767 | { |
Colin Cross | 0ead1d7 | 2018-04-10 13:07:42 -0700 | [diff] [blame] | 768 | // Test that a module with wildcards in java_resource_dirs has the correct path prefixes |
| 769 | name: "wildcard dirs", |
| 770 | prop: `java_resource_dirs: ["java-res/*"]`, |
| 771 | args: "-C java-res/a -f java-res/a/a -C java-res/b -f java-res/b/b", |
| 772 | }, |
| 773 | { |
| 774 | // Test that a module exclude_java_resource_dirs excludes the files |
| 775 | name: "wildcard dirs", |
| 776 | prop: `java_resource_dirs: ["java-res/*"], exclude_java_resource_dirs: ["java-res/b"]`, |
| 777 | args: "-C java-res/a -f java-res/a/a", |
| 778 | }, |
Colin Cross | cedd476 | 2018-09-13 11:26:19 -0700 | [diff] [blame] | 779 | { |
| 780 | // Test wildcards in java_resources |
| 781 | name: "wildcard files", |
| 782 | prop: `java_resources: ["java-res/**/*"]`, |
| 783 | args: "-C . -f java-res/a/a -f java-res/b/b", |
| 784 | }, |
| 785 | { |
| 786 | // Test exclude_java_resources with java_resources |
| 787 | name: "wildcard files with exclude", |
| 788 | prop: `java_resources: ["java-res/**/*"], exclude_java_resources: ["java-res/b/*"]`, |
| 789 | args: "-C . -f java-res/a/a", |
| 790 | }, |
| 791 | { |
| 792 | // Test exclude_java_resources with java_resource_dirs |
| 793 | name: "resource dirs with exclude files", |
| 794 | prop: `java_resource_dirs: ["java-res"], exclude_java_resources: ["java-res/b/b"]`, |
| 795 | args: "-C java-res -f java-res/a/a", |
| 796 | }, |
| 797 | { |
| 798 | // Test exclude_java_resource_dirs with java_resource_dirs |
| 799 | name: "resource dirs with exclude files", |
| 800 | prop: `java_resource_dirs: ["java-res", "java-res2"], exclude_java_resource_dirs: ["java-res2"]`, |
| 801 | args: "-C java-res -f java-res/a/a -f java-res/b/b", |
| 802 | }, |
Colin Cross | 0f37af0 | 2017-09-27 17:42:05 -0700 | [diff] [blame] | 803 | } |
| 804 | |
| 805 | for _, test := range table { |
| 806 | t.Run(test.name, func(t *testing.T) { |
Colin Cross | 238c1f3 | 2020-06-07 16:58:18 -0700 | [diff] [blame] | 807 | ctx, _ := testJavaWithFS(t, ` |
Colin Cross | 0f37af0 | 2017-09-27 17:42:05 -0700 | [diff] [blame] | 808 | java_library { |
| 809 | name: "foo", |
| 810 | srcs: [ |
| 811 | "a.java", |
| 812 | "b.java", |
| 813 | "c.java", |
| 814 | ], |
| 815 | `+test.prop+`, |
| 816 | } |
Colin Cross | 238c1f3 | 2020-06-07 16:58:18 -0700 | [diff] [blame] | 817 | `+test.extra, |
| 818 | map[string][]byte{ |
| 819 | "java-res/a/a": nil, |
| 820 | "java-res/b/b": nil, |
| 821 | "java-res2/a": nil, |
| 822 | }, |
| 823 | ) |
Colin Cross | 0f37af0 | 2017-09-27 17:42:05 -0700 | [diff] [blame] | 824 | |
Colin Cross | 331a121 | 2018-08-15 20:40:52 -0700 | [diff] [blame] | 825 | foo := ctx.ModuleForTests("foo", "android_common").Output("withres/foo.jar") |
Colin Cross | 1ee2317 | 2017-10-18 14:44:18 -0700 | [diff] [blame] | 826 | fooRes := ctx.ModuleForTests("foo", "android_common").Output("res/foo.jar") |
Colin Cross | 0f37af0 | 2017-09-27 17:42:05 -0700 | [diff] [blame] | 827 | |
| 828 | if !inList(fooRes.Output.String(), foo.Inputs.Strings()) { |
| 829 | t.Errorf("foo combined jars %v does not contain %q", |
| 830 | foo.Inputs.Strings(), fooRes.Output.String()) |
| 831 | } |
| 832 | |
Colin Cross | af9c55b | 2017-10-03 14:50:08 -0700 | [diff] [blame] | 833 | if fooRes.Args["jarArgs"] != test.args { |
| 834 | t.Errorf("foo resource jar args %q is not %q", |
Colin Cross | 0f37af0 | 2017-09-27 17:42:05 -0700 | [diff] [blame] | 835 | fooRes.Args["jarArgs"], test.args) |
| 836 | } |
| 837 | }) |
| 838 | } |
| 839 | } |
| 840 | |
Colin Cross | 0c4ce21 | 2019-05-03 15:28:19 -0700 | [diff] [blame] | 841 | func TestIncludeSrcs(t *testing.T) { |
Colin Cross | 238c1f3 | 2020-06-07 16:58:18 -0700 | [diff] [blame] | 842 | ctx, _ := testJavaWithFS(t, ` |
Colin Cross | 0c4ce21 | 2019-05-03 15:28:19 -0700 | [diff] [blame] | 843 | java_library { |
| 844 | name: "foo", |
| 845 | srcs: [ |
| 846 | "a.java", |
| 847 | "b.java", |
| 848 | "c.java", |
| 849 | ], |
| 850 | include_srcs: true, |
| 851 | } |
| 852 | |
| 853 | java_library { |
| 854 | name: "bar", |
| 855 | srcs: [ |
| 856 | "a.java", |
| 857 | "b.java", |
| 858 | "c.java", |
| 859 | ], |
| 860 | java_resource_dirs: ["java-res"], |
| 861 | include_srcs: true, |
| 862 | } |
Colin Cross | 238c1f3 | 2020-06-07 16:58:18 -0700 | [diff] [blame] | 863 | `, map[string][]byte{ |
| 864 | "java-res/a/a": nil, |
| 865 | "java-res/b/b": nil, |
| 866 | "java-res2/a": nil, |
| 867 | }) |
Colin Cross | 0c4ce21 | 2019-05-03 15:28:19 -0700 | [diff] [blame] | 868 | |
| 869 | // Test a library with include_srcs: true |
| 870 | foo := ctx.ModuleForTests("foo", "android_common").Output("withres/foo.jar") |
| 871 | fooSrcJar := ctx.ModuleForTests("foo", "android_common").Output("foo.srcjar") |
| 872 | |
| 873 | if g, w := fooSrcJar.Output.String(), foo.Inputs.Strings(); !inList(g, w) { |
| 874 | t.Errorf("foo combined jars %v does not contain %q", w, g) |
| 875 | } |
| 876 | |
| 877 | if g, w := fooSrcJar.Args["jarArgs"], "-C . -f a.java -f b.java -f c.java"; g != w { |
| 878 | t.Errorf("foo source jar args %q is not %q", w, g) |
| 879 | } |
| 880 | |
| 881 | // Test a library with include_srcs: true and resources |
| 882 | bar := ctx.ModuleForTests("bar", "android_common").Output("withres/bar.jar") |
| 883 | barResCombined := ctx.ModuleForTests("bar", "android_common").Output("res-combined/bar.jar") |
| 884 | barRes := ctx.ModuleForTests("bar", "android_common").Output("res/bar.jar") |
| 885 | barSrcJar := ctx.ModuleForTests("bar", "android_common").Output("bar.srcjar") |
| 886 | |
| 887 | if g, w := barSrcJar.Output.String(), barResCombined.Inputs.Strings(); !inList(g, w) { |
| 888 | t.Errorf("bar combined resource jars %v does not contain %q", w, g) |
| 889 | } |
| 890 | |
| 891 | if g, w := barRes.Output.String(), barResCombined.Inputs.Strings(); !inList(g, w) { |
| 892 | t.Errorf("bar combined resource jars %v does not contain %q", w, g) |
| 893 | } |
| 894 | |
| 895 | if g, w := barResCombined.Output.String(), bar.Inputs.Strings(); !inList(g, w) { |
| 896 | t.Errorf("bar combined jars %v does not contain %q", w, g) |
| 897 | } |
| 898 | |
| 899 | if g, w := barSrcJar.Args["jarArgs"], "-C . -f a.java -f b.java -f c.java"; g != w { |
| 900 | t.Errorf("bar source jar args %q is not %q", w, g) |
| 901 | } |
| 902 | |
| 903 | if g, w := barRes.Args["jarArgs"], "-C java-res -f java-res/a/a -f java-res/b/b"; g != w { |
| 904 | t.Errorf("bar resource jar args %q is not %q", w, g) |
| 905 | } |
| 906 | } |
| 907 | |
Colin Cross | 54190b3 | 2017-10-09 15:34:10 -0700 | [diff] [blame] | 908 | func TestGeneratedSources(t *testing.T) { |
Colin Cross | 238c1f3 | 2020-06-07 16:58:18 -0700 | [diff] [blame] | 909 | ctx, _ := testJavaWithFS(t, ` |
Colin Cross | 54190b3 | 2017-10-09 15:34:10 -0700 | [diff] [blame] | 910 | java_library { |
| 911 | name: "foo", |
| 912 | srcs: [ |
| 913 | "a*.java", |
| 914 | ":gen", |
| 915 | "b*.java", |
| 916 | ], |
| 917 | } |
| 918 | |
| 919 | genrule { |
| 920 | name: "gen", |
Colin Cross | 824bee3 | 2017-11-22 17:27:51 -0800 | [diff] [blame] | 921 | tool_files: ["java-res/a"], |
Colin Cross | 54190b3 | 2017-10-09 15:34:10 -0700 | [diff] [blame] | 922 | out: ["gen.java"], |
| 923 | } |
Colin Cross | 238c1f3 | 2020-06-07 16:58:18 -0700 | [diff] [blame] | 924 | `, map[string][]byte{ |
| 925 | "a.java": nil, |
| 926 | "b.java": nil, |
| 927 | }) |
Colin Cross | 54190b3 | 2017-10-09 15:34:10 -0700 | [diff] [blame] | 928 | |
| 929 | javac := ctx.ModuleForTests("foo", "android_common").Rule("javac") |
| 930 | genrule := ctx.ModuleForTests("gen", "").Rule("generator") |
| 931 | |
Colin Cross | 15e86d9 | 2017-10-20 15:07:08 -0700 | [diff] [blame] | 932 | if filepath.Base(genrule.Output.String()) != "gen.java" { |
| 933 | t.Fatalf(`gen output file %v is not ".../gen.java"`, genrule.Output.String()) |
Colin Cross | 54190b3 | 2017-10-09 15:34:10 -0700 | [diff] [blame] | 934 | } |
| 935 | |
| 936 | if len(javac.Inputs) != 3 || |
| 937 | javac.Inputs[0].String() != "a.java" || |
Colin Cross | 15e86d9 | 2017-10-20 15:07:08 -0700 | [diff] [blame] | 938 | javac.Inputs[1].String() != genrule.Output.String() || |
Colin Cross | 54190b3 | 2017-10-09 15:34:10 -0700 | [diff] [blame] | 939 | javac.Inputs[2].String() != "b.java" { |
| 940 | t.Errorf(`foo inputs %v != ["a.java", ".../gen.java", "b.java"]`, javac.Inputs) |
| 941 | } |
| 942 | } |
| 943 | |
Nan Zhang | 61eaedb | 2017-11-02 13:28:15 -0700 | [diff] [blame] | 944 | func TestTurbine(t *testing.T) { |
Paul Duffin | 71ae594 | 2021-03-22 15:36:52 +0000 | [diff] [blame] | 945 | result := android.GroupFixturePreparers( |
| 946 | prepareForJavaTest, FixtureWithPrebuiltApis(map[string][]string{"14": {"foo"}})). |
Paul Duffin | 3d9f268 | 2021-03-13 09:47:16 +0000 | [diff] [blame] | 947 | RunTestWithBp(t, ` |
Nan Zhang | 61eaedb | 2017-11-02 13:28:15 -0700 | [diff] [blame] | 948 | java_library { |
| 949 | name: "foo", |
| 950 | srcs: ["a.java"], |
Jiyong Park | 2d49294 | 2018-03-05 17:44:10 +0900 | [diff] [blame] | 951 | sdk_version: "14", |
Nan Zhang | 61eaedb | 2017-11-02 13:28:15 -0700 | [diff] [blame] | 952 | } |
| 953 | |
| 954 | java_library { |
| 955 | name: "bar", |
Colin Cross | 9bc4343 | 2017-12-15 20:20:39 -0800 | [diff] [blame] | 956 | srcs: ["b.java"], |
Nan Zhang | 61eaedb | 2017-11-02 13:28:15 -0700 | [diff] [blame] | 957 | static_libs: ["foo"], |
Jiyong Park | 2d49294 | 2018-03-05 17:44:10 +0900 | [diff] [blame] | 958 | sdk_version: "14", |
Nan Zhang | 61eaedb | 2017-11-02 13:28:15 -0700 | [diff] [blame] | 959 | } |
| 960 | |
| 961 | java_library { |
| 962 | name: "baz", |
| 963 | srcs: ["c.java"], |
| 964 | libs: ["bar"], |
| 965 | sdk_version: "14", |
| 966 | } |
| 967 | `) |
| 968 | |
Paul Duffin | a71a67a | 2021-03-29 00:42:57 +0100 | [diff] [blame] | 969 | fooTurbine := result.ModuleForTests("foo", "android_common").Rule("turbine") |
| 970 | barTurbine := result.ModuleForTests("bar", "android_common").Rule("turbine") |
| 971 | barJavac := result.ModuleForTests("bar", "android_common").Rule("javac") |
| 972 | barTurbineCombined := result.ModuleForTests("bar", "android_common").Description("for turbine") |
| 973 | bazJavac := result.ModuleForTests("baz", "android_common").Rule("javac") |
Nan Zhang | 61eaedb | 2017-11-02 13:28:15 -0700 | [diff] [blame] | 974 | |
Paul Duffin | 414ea5e | 2021-03-22 17:31:52 +0000 | [diff] [blame] | 975 | android.AssertPathsRelativeToTopEquals(t, "foo inputs", []string{"a.java"}, fooTurbine.Inputs) |
Nan Zhang | 61eaedb | 2017-11-02 13:28:15 -0700 | [diff] [blame] | 976 | |
Paul Duffin | 414ea5e | 2021-03-22 17:31:52 +0000 | [diff] [blame] | 977 | fooHeaderJar := filepath.Join("out", "soong", ".intermediates", "foo", "android_common", "turbine-combined", "foo.jar") |
| 978 | barTurbineJar := filepath.Join("out", "soong", ".intermediates", "bar", "android_common", "turbine", "bar.jar") |
Colin Cross | f61766e | 2022-03-16 18:06:48 -0700 | [diff] [blame] | 979 | android.AssertStringDoesContain(t, "bar turbine classpath", barTurbine.Args["turbineFlags"], fooHeaderJar) |
Paul Duffin | 3d9f268 | 2021-03-13 09:47:16 +0000 | [diff] [blame] | 980 | android.AssertStringDoesContain(t, "bar javac classpath", barJavac.Args["classpath"], fooHeaderJar) |
Paul Duffin | 414ea5e | 2021-03-22 17:31:52 +0000 | [diff] [blame] | 981 | android.AssertPathsRelativeToTopEquals(t, "bar turbine combineJar", []string{barTurbineJar, fooHeaderJar}, barTurbineCombined.Inputs) |
Paul Duffin | 3d9f268 | 2021-03-13 09:47:16 +0000 | [diff] [blame] | 982 | android.AssertStringDoesContain(t, "baz javac classpath", bazJavac.Args["classpath"], "prebuilts/sdk/14/public/android.jar") |
Nan Zhang | 61eaedb | 2017-11-02 13:28:15 -0700 | [diff] [blame] | 983 | } |
| 984 | |
| 985 | func TestSharding(t *testing.T) { |
Jaewoong Jung | f9a0443 | 2019-07-17 11:15:09 -0700 | [diff] [blame] | 986 | ctx, _ := testJava(t, ` |
Nan Zhang | 61eaedb | 2017-11-02 13:28:15 -0700 | [diff] [blame] | 987 | java_library { |
| 988 | name: "bar", |
| 989 | srcs: ["a.java","b.java","c.java"], |
| 990 | javac_shard_size: 1 |
| 991 | } |
| 992 | `) |
| 993 | |
Colin Cross | 3d56ed5 | 2021-11-18 22:23:12 -0800 | [diff] [blame] | 994 | barHeaderJar := filepath.Join("out", "soong", ".intermediates", "bar", "android_common", "turbine", "bar.jar") |
Nan Zhang | 61eaedb | 2017-11-02 13:28:15 -0700 | [diff] [blame] | 995 | for i := 0; i < 3; i++ { |
Paul Duffin | a71a67a | 2021-03-29 00:42:57 +0100 | [diff] [blame] | 996 | barJavac := ctx.ModuleForTests("bar", "android_common").Description("javac" + strconv.Itoa(i)) |
Colin Cross | 3d56ed5 | 2021-11-18 22:23:12 -0800 | [diff] [blame] | 997 | if !strings.HasPrefix(barJavac.Args["classpath"], "-classpath "+barHeaderJar+":") { |
| 998 | t.Errorf("bar javac classpath %v does start with %q", barJavac.Args["classpath"], barHeaderJar) |
Nan Zhang | 61eaedb | 2017-11-02 13:28:15 -0700 | [diff] [blame] | 999 | } |
| 1000 | } |
| 1001 | } |
| 1002 | |
Nan Zhang | 27e284d | 2018-02-09 21:03:53 +0000 | [diff] [blame] | 1003 | func TestExcludeFileGroupInSrcs(t *testing.T) { |
Jaewoong Jung | f9a0443 | 2019-07-17 11:15:09 -0700 | [diff] [blame] | 1004 | ctx, _ := testJava(t, ` |
Nan Zhang | 27e284d | 2018-02-09 21:03:53 +0000 | [diff] [blame] | 1005 | java_library { |
| 1006 | name: "foo", |
| 1007 | srcs: ["a.java", ":foo-srcs"], |
| 1008 | exclude_srcs: ["a.java", ":foo-excludes"], |
| 1009 | } |
| 1010 | |
| 1011 | filegroup { |
| 1012 | name: "foo-srcs", |
| 1013 | srcs: ["java-fg/a.java", "java-fg/b.java", "java-fg/c.java"], |
| 1014 | } |
| 1015 | |
| 1016 | filegroup { |
| 1017 | name: "foo-excludes", |
| 1018 | srcs: ["java-fg/a.java", "java-fg/b.java"], |
| 1019 | } |
| 1020 | `) |
| 1021 | |
| 1022 | javac := ctx.ModuleForTests("foo", "android_common").Rule("javac") |
| 1023 | |
| 1024 | if len(javac.Inputs) != 1 || javac.Inputs[0].String() != "java-fg/c.java" { |
| 1025 | t.Errorf(`foo inputs %v != ["java-fg/c.java"]`, javac.Inputs) |
| 1026 | } |
| 1027 | } |
Jiyong Park | c678ad3 | 2018-04-10 13:07:10 +0900 | [diff] [blame] | 1028 | |
Paul Duffin | 52d398a | 2019-06-11 12:31:14 +0100 | [diff] [blame] | 1029 | func TestJavaLibrary(t *testing.T) { |
Paul Duffin | 414ea5e | 2021-03-22 17:31:52 +0000 | [diff] [blame] | 1030 | testJavaWithFS(t, "", map[string][]byte{ |
Paul Duffin | 52d398a | 2019-06-11 12:31:14 +0100 | [diff] [blame] | 1031 | "libcore/Android.bp": []byte(` |
| 1032 | java_library { |
| 1033 | name: "core", |
| 1034 | sdk_version: "none", |
| 1035 | system_modules: "none", |
Paul Duffin | aa55f74 | 2020-10-06 17:20:13 +0100 | [diff] [blame] | 1036 | } |
| 1037 | |
| 1038 | filegroup { |
| 1039 | name: "core-jar", |
| 1040 | srcs: [":core{.jar}"], |
| 1041 | } |
Paul Duffin | 414ea5e | 2021-03-22 17:31:52 +0000 | [diff] [blame] | 1042 | `), |
Paul Duffin | aa55f74 | 2020-10-06 17:20:13 +0100 | [diff] [blame] | 1043 | }) |
Paul Duffin | aa55f74 | 2020-10-06 17:20:13 +0100 | [diff] [blame] | 1044 | } |
| 1045 | |
| 1046 | func TestJavaImport(t *testing.T) { |
Paul Duffin | 414ea5e | 2021-03-22 17:31:52 +0000 | [diff] [blame] | 1047 | testJavaWithFS(t, "", map[string][]byte{ |
Paul Duffin | aa55f74 | 2020-10-06 17:20:13 +0100 | [diff] [blame] | 1048 | "libcore/Android.bp": []byte(` |
| 1049 | java_import { |
| 1050 | name: "core", |
| 1051 | sdk_version: "none", |
| 1052 | } |
| 1053 | |
| 1054 | filegroup { |
| 1055 | name: "core-jar", |
| 1056 | srcs: [":core{.jar}"], |
| 1057 | } |
Paul Duffin | 414ea5e | 2021-03-22 17:31:52 +0000 | [diff] [blame] | 1058 | `), |
Paul Duffin | 52d398a | 2019-06-11 12:31:14 +0100 | [diff] [blame] | 1059 | }) |
Paul Duffin | 52d398a | 2019-06-11 12:31:14 +0100 | [diff] [blame] | 1060 | } |
| 1061 | |
Zoran Jovanovic | 8736ce2 | 2018-08-21 17:10:29 +0200 | [diff] [blame] | 1062 | var compilerFlagsTestCases = []struct { |
| 1063 | in string |
| 1064 | out bool |
| 1065 | }{ |
| 1066 | { |
| 1067 | in: "a", |
| 1068 | out: false, |
| 1069 | }, |
| 1070 | { |
| 1071 | in: "-a", |
| 1072 | out: true, |
| 1073 | }, |
| 1074 | { |
| 1075 | in: "-no-jdk", |
| 1076 | out: false, |
| 1077 | }, |
| 1078 | { |
| 1079 | in: "-no-stdlib", |
| 1080 | out: false, |
| 1081 | }, |
| 1082 | { |
| 1083 | in: "-kotlin-home", |
| 1084 | out: false, |
| 1085 | }, |
| 1086 | { |
| 1087 | in: "-kotlin-home /some/path", |
| 1088 | out: false, |
| 1089 | }, |
| 1090 | { |
| 1091 | in: "-include-runtime", |
| 1092 | out: false, |
| 1093 | }, |
| 1094 | { |
| 1095 | in: "-Xintellij-plugin-root", |
| 1096 | out: false, |
| 1097 | }, |
| 1098 | } |
| 1099 | |
| 1100 | type mockContext struct { |
| 1101 | android.ModuleContext |
| 1102 | result bool |
| 1103 | } |
| 1104 | |
| 1105 | func (ctx *mockContext) PropertyErrorf(property, format string, args ...interface{}) { |
| 1106 | // CheckBadCompilerFlags calls this function when the flag should be rejected |
| 1107 | ctx.result = false |
| 1108 | } |
| 1109 | |
| 1110 | func TestCompilerFlags(t *testing.T) { |
| 1111 | for _, testCase := range compilerFlagsTestCases { |
| 1112 | ctx := &mockContext{result: true} |
| 1113 | CheckKotlincFlags(ctx, []string{testCase.in}) |
| 1114 | if ctx.result != testCase.out { |
| 1115 | t.Errorf("incorrect output:") |
| 1116 | t.Errorf(" input: %#v", testCase.in) |
| 1117 | t.Errorf(" expected: %#v", testCase.out) |
| 1118 | t.Errorf(" got: %#v", ctx.result) |
| 1119 | } |
| 1120 | } |
| 1121 | } |
Jaewoong Jung | 38e4fb2 | 2018-12-12 09:01:34 -0800 | [diff] [blame] | 1122 | |
| 1123 | // TODO(jungjw): Consider making this more robust by ignoring path order. |
| 1124 | func checkPatchModuleFlag(t *testing.T, ctx *android.TestContext, moduleName string, expected string) { |
Paul Duffin | 414ea5e | 2021-03-22 17:31:52 +0000 | [diff] [blame] | 1125 | variables := ctx.ModuleForTests(moduleName, "android_common").VariablesForTestsRelativeToTop() |
Jaewoong Jung | 38e4fb2 | 2018-12-12 09:01:34 -0800 | [diff] [blame] | 1126 | flags := strings.Split(variables["javacFlags"], " ") |
| 1127 | got := "" |
| 1128 | for _, flag := range flags { |
| 1129 | keyEnd := strings.Index(flag, "=") |
| 1130 | if keyEnd > -1 && flag[:keyEnd] == "--patch-module" { |
| 1131 | got = flag[keyEnd+1:] |
| 1132 | break |
| 1133 | } |
| 1134 | } |
Lukacs T. Berki | 9f6c24a | 2021-08-26 15:07:24 +0200 | [diff] [blame] | 1135 | if expected != android.StringPathRelativeToTop(ctx.Config().SoongOutDir(), got) { |
Jaewoong Jung | 38e4fb2 | 2018-12-12 09:01:34 -0800 | [diff] [blame] | 1136 | t.Errorf("Unexpected patch-module flag for module %q - expected %q, but got %q", moduleName, expected, got) |
| 1137 | } |
| 1138 | } |
| 1139 | |
| 1140 | func TestPatchModule(t *testing.T) { |
Pete Gillin | 0c2143e | 2019-05-02 15:32:11 +0100 | [diff] [blame] | 1141 | t.Run("Java language level 8", func(t *testing.T) { |
Pete Gillin | 1b3370f | 2019-10-01 13:57:31 +0100 | [diff] [blame] | 1142 | // Test with legacy javac -source 1.8 -target 1.8 |
Pete Gillin | bdf5d71 | 2019-10-21 14:29:58 +0100 | [diff] [blame] | 1143 | bp := ` |
| 1144 | java_library { |
| 1145 | name: "foo", |
| 1146 | srcs: ["a.java"], |
| 1147 | java_version: "1.8", |
| 1148 | } |
| 1149 | |
| 1150 | java_library { |
| 1151 | name: "bar", |
| 1152 | srcs: ["b.java"], |
| 1153 | sdk_version: "none", |
| 1154 | system_modules: "none", |
| 1155 | patch_module: "java.base", |
| 1156 | java_version: "1.8", |
| 1157 | } |
| 1158 | |
| 1159 | java_library { |
| 1160 | name: "baz", |
| 1161 | srcs: ["c.java"], |
| 1162 | patch_module: "java.base", |
| 1163 | java_version: "1.8", |
| 1164 | } |
| 1165 | ` |
| 1166 | ctx, _ := testJava(t, bp) |
Jaewoong Jung | 38e4fb2 | 2018-12-12 09:01:34 -0800 | [diff] [blame] | 1167 | |
| 1168 | checkPatchModuleFlag(t, ctx, "foo", "") |
| 1169 | checkPatchModuleFlag(t, ctx, "bar", "") |
| 1170 | checkPatchModuleFlag(t, ctx, "baz", "") |
| 1171 | }) |
| 1172 | |
Pete Gillin | 0c2143e | 2019-05-02 15:32:11 +0100 | [diff] [blame] | 1173 | t.Run("Java language level 9", func(t *testing.T) { |
Pete Gillin | 1b3370f | 2019-10-01 13:57:31 +0100 | [diff] [blame] | 1174 | // Test with default javac -source 9 -target 9 |
Pete Gillin | bdf5d71 | 2019-10-21 14:29:58 +0100 | [diff] [blame] | 1175 | bp := ` |
| 1176 | java_library { |
| 1177 | name: "foo", |
| 1178 | srcs: ["a.java"], |
| 1179 | } |
| 1180 | |
| 1181 | java_library { |
| 1182 | name: "bar", |
| 1183 | srcs: ["b.java"], |
| 1184 | sdk_version: "none", |
| 1185 | system_modules: "none", |
| 1186 | patch_module: "java.base", |
| 1187 | } |
| 1188 | |
| 1189 | java_library { |
| 1190 | name: "baz", |
Jingwen Chen | 5136a6e | 2020-10-30 01:01:35 -0400 | [diff] [blame] | 1191 | srcs: [ |
| 1192 | "c.java", |
| 1193 | // Tests for b/150878007 |
| 1194 | "dir/d.java", |
| 1195 | "dir2/e.java", |
| 1196 | "dir2/f.java", |
| 1197 | "nested/dir/g.java" |
| 1198 | ], |
Pete Gillin | bdf5d71 | 2019-10-21 14:29:58 +0100 | [diff] [blame] | 1199 | patch_module: "java.base", |
| 1200 | } |
| 1201 | ` |
Pete Gillin | 1b3370f | 2019-10-01 13:57:31 +0100 | [diff] [blame] | 1202 | ctx, _ := testJava(t, bp) |
Jaewoong Jung | 38e4fb2 | 2018-12-12 09:01:34 -0800 | [diff] [blame] | 1203 | |
| 1204 | checkPatchModuleFlag(t, ctx, "foo", "") |
Paul Duffin | 414ea5e | 2021-03-22 17:31:52 +0000 | [diff] [blame] | 1205 | expected := "java.base=.:out/soong" |
Jaewoong Jung | 38e4fb2 | 2018-12-12 09:01:34 -0800 | [diff] [blame] | 1206 | checkPatchModuleFlag(t, ctx, "bar", expected) |
Jingwen Chen | 5136a6e | 2020-10-30 01:01:35 -0400 | [diff] [blame] | 1207 | expected = "java.base=" + strings.Join([]string{ |
Colin Cross | 8ff1058 | 2023-12-07 13:10:56 -0800 | [diff] [blame] | 1208 | ".", "out/soong", defaultModuleToPath("ext"), defaultModuleToPath("framework")}, ":") |
Jaewoong Jung | 38e4fb2 | 2018-12-12 09:01:34 -0800 | [diff] [blame] | 1209 | checkPatchModuleFlag(t, ctx, "baz", expected) |
| 1210 | }) |
| 1211 | } |
Paul Duffin | a7b9f42 | 2020-01-10 17:12:18 +0000 | [diff] [blame] | 1212 | |
Paul Duffin | 83a2d96 | 2019-11-19 19:44:10 +0000 | [diff] [blame] | 1213 | func TestJavaLibraryWithSystemModules(t *testing.T) { |
| 1214 | ctx, _ := testJava(t, ` |
| 1215 | java_library { |
| 1216 | name: "lib-with-source-system-modules", |
| 1217 | srcs: [ |
| 1218 | "a.java", |
| 1219 | ], |
| 1220 | sdk_version: "none", |
| 1221 | system_modules: "source-system-modules", |
| 1222 | } |
| 1223 | |
| 1224 | java_library { |
| 1225 | name: "source-jar", |
| 1226 | srcs: [ |
| 1227 | "a.java", |
| 1228 | ], |
| 1229 | } |
| 1230 | |
| 1231 | java_system_modules { |
| 1232 | name: "source-system-modules", |
| 1233 | libs: ["source-jar"], |
| 1234 | } |
| 1235 | |
| 1236 | java_library { |
| 1237 | name: "lib-with-prebuilt-system-modules", |
| 1238 | srcs: [ |
| 1239 | "a.java", |
| 1240 | ], |
| 1241 | sdk_version: "none", |
| 1242 | system_modules: "prebuilt-system-modules", |
| 1243 | } |
| 1244 | |
| 1245 | java_import { |
| 1246 | name: "prebuilt-jar", |
| 1247 | jars: ["a.jar"], |
| 1248 | } |
| 1249 | |
| 1250 | java_system_modules_import { |
| 1251 | name: "prebuilt-system-modules", |
| 1252 | libs: ["prebuilt-jar"], |
| 1253 | } |
| 1254 | `) |
| 1255 | |
| 1256 | checkBootClasspathForSystemModule(t, ctx, "lib-with-source-system-modules", "/source-jar.jar") |
| 1257 | |
| 1258 | checkBootClasspathForSystemModule(t, ctx, "lib-with-prebuilt-system-modules", "/prebuilt-jar.jar") |
| 1259 | } |
| 1260 | |
| 1261 | func checkBootClasspathForSystemModule(t *testing.T, ctx *android.TestContext, moduleName string, expectedSuffix string) { |
| 1262 | javacRule := ctx.ModuleForTests(moduleName, "android_common").Rule("javac") |
| 1263 | bootClasspath := javacRule.Args["bootClasspath"] |
| 1264 | if strings.HasPrefix(bootClasspath, "--system ") && strings.HasSuffix(bootClasspath, expectedSuffix) { |
| 1265 | t.Errorf("bootclasspath of %q must start with --system and end with %q, but was %#v.", moduleName, expectedSuffix, bootClasspath) |
| 1266 | } |
| 1267 | } |
Jiyong Park | 19604de | 2020-03-24 16:44:11 +0900 | [diff] [blame] | 1268 | |
| 1269 | func TestAidlExportIncludeDirsFromImports(t *testing.T) { |
| 1270 | ctx, _ := testJava(t, ` |
| 1271 | java_library { |
| 1272 | name: "foo", |
| 1273 | srcs: ["aidl/foo/IFoo.aidl"], |
| 1274 | libs: ["bar"], |
| 1275 | } |
| 1276 | |
| 1277 | java_import { |
| 1278 | name: "bar", |
| 1279 | jars: ["a.jar"], |
| 1280 | aidl: { |
| 1281 | export_include_dirs: ["aidl/bar"], |
| 1282 | }, |
| 1283 | } |
| 1284 | `) |
| 1285 | |
| 1286 | aidlCommand := ctx.ModuleForTests("foo", "android_common").Rule("aidl").RuleParams.Command |
| 1287 | expectedAidlFlag := "-Iaidl/bar" |
| 1288 | if !strings.Contains(aidlCommand, expectedAidlFlag) { |
| 1289 | t.Errorf("aidl command %q does not contain %q", aidlCommand, expectedAidlFlag) |
| 1290 | } |
| 1291 | } |
Liz Kammer | dd849a8 | 2020-06-12 16:38:45 -0700 | [diff] [blame] | 1292 | |
Jooyung Han | e197d8b | 2021-01-05 10:33:16 +0900 | [diff] [blame] | 1293 | func TestAidlFlagsArePassedToTheAidlCompiler(t *testing.T) { |
| 1294 | ctx, _ := testJava(t, ` |
| 1295 | java_library { |
| 1296 | name: "foo", |
| 1297 | srcs: ["aidl/foo/IFoo.aidl"], |
| 1298 | aidl: { flags: ["-Werror"], }, |
| 1299 | } |
| 1300 | `) |
| 1301 | |
| 1302 | aidlCommand := ctx.ModuleForTests("foo", "android_common").Rule("aidl").RuleParams.Command |
| 1303 | expectedAidlFlag := "-Werror" |
| 1304 | if !strings.Contains(aidlCommand, expectedAidlFlag) { |
| 1305 | t.Errorf("aidl command %q does not contain %q", aidlCommand, expectedAidlFlag) |
| 1306 | } |
| 1307 | } |
| 1308 | |
Jooyung Han | 07f70c0 | 2021-11-06 07:08:45 +0900 | [diff] [blame] | 1309 | func TestAidlFlagsWithMinSdkVersion(t *testing.T) { |
| 1310 | fixture := android.GroupFixturePreparers( |
| 1311 | prepareForJavaTest, FixtureWithPrebuiltApis(map[string][]string{"14": {"foo"}})) |
| 1312 | |
| 1313 | for _, tc := range []struct { |
| 1314 | name string |
| 1315 | sdkVersion string |
| 1316 | expected string |
| 1317 | }{ |
| 1318 | {"default is current", "", "current"}, |
| 1319 | {"use sdk_version", `sdk_version: "14"`, "14"}, |
| 1320 | {"system_current", `sdk_version: "system_current"`, "current"}, |
| 1321 | } { |
| 1322 | t.Run(tc.name, func(t *testing.T) { |
| 1323 | ctx := fixture.RunTestWithBp(t, ` |
| 1324 | java_library { |
| 1325 | name: "foo", |
| 1326 | srcs: ["aidl/foo/IFoo.aidl"], |
| 1327 | `+tc.sdkVersion+` |
| 1328 | } |
| 1329 | `) |
| 1330 | aidlCommand := ctx.ModuleForTests("foo", "android_common").Rule("aidl").RuleParams.Command |
| 1331 | expectedAidlFlag := "--min_sdk_version=" + tc.expected |
| 1332 | if !strings.Contains(aidlCommand, expectedAidlFlag) { |
| 1333 | t.Errorf("aidl command %q does not contain %q", aidlCommand, expectedAidlFlag) |
| 1334 | } |
| 1335 | }) |
| 1336 | } |
| 1337 | } |
| 1338 | |
Spandan Das | 757b666 | 2022-11-17 04:29:59 +0000 | [diff] [blame] | 1339 | func TestAidlFlagsMinSdkVersionDroidstubs(t *testing.T) { |
| 1340 | bpTemplate := ` |
| 1341 | droidstubs { |
| 1342 | name: "foo-stubs", |
| 1343 | srcs: ["foo.aidl"], |
| 1344 | %s |
| 1345 | system_modules: "none", |
| 1346 | } |
| 1347 | ` |
| 1348 | testCases := []struct { |
| 1349 | desc string |
| 1350 | sdkVersionBp string |
| 1351 | minSdkVersionExpected string |
| 1352 | }{ |
| 1353 | { |
| 1354 | desc: "sdk_version not set, module compiles against private platform APIs", |
| 1355 | sdkVersionBp: ``, |
| 1356 | minSdkVersionExpected: "10000", |
| 1357 | }, |
| 1358 | { |
| 1359 | desc: "sdk_version set to none, module does not build against an SDK", |
| 1360 | sdkVersionBp: `sdk_version: "none",`, |
| 1361 | minSdkVersionExpected: "10000", |
| 1362 | }, |
| 1363 | } |
| 1364 | for _, tc := range testCases { |
| 1365 | ctx := prepareForJavaTest.RunTestWithBp(t, fmt.Sprintf(bpTemplate, tc.sdkVersionBp)) |
| 1366 | aidlCmd := ctx.ModuleForTests("foo-stubs", "android_common").Rule("aidl").RuleParams.Command |
| 1367 | expected := "--min_sdk_version=" + tc.minSdkVersionExpected |
| 1368 | android.AssertStringDoesContain(t, "aidl command conatins incorrect min_sdk_version for testCse: "+tc.desc, aidlCmd, expected) |
| 1369 | } |
| 1370 | } |
| 1371 | |
Thiébaud Weksteen | de8417c | 2022-02-10 15:41:46 +1100 | [diff] [blame] | 1372 | func TestAidlEnforcePermissions(t *testing.T) { |
| 1373 | ctx, _ := testJava(t, ` |
| 1374 | java_library { |
| 1375 | name: "foo", |
| 1376 | srcs: ["aidl/foo/IFoo.aidl"], |
| 1377 | aidl: { enforce_permissions: true }, |
| 1378 | } |
| 1379 | `) |
| 1380 | |
| 1381 | aidlCommand := ctx.ModuleForTests("foo", "android_common").Rule("aidl").RuleParams.Command |
| 1382 | expectedAidlFlag := "-Wmissing-permission-annotation -Werror" |
| 1383 | if !strings.Contains(aidlCommand, expectedAidlFlag) { |
| 1384 | t.Errorf("aidl command %q does not contain %q", aidlCommand, expectedAidlFlag) |
| 1385 | } |
| 1386 | } |
| 1387 | |
| 1388 | func TestAidlEnforcePermissionsException(t *testing.T) { |
| 1389 | ctx, _ := testJava(t, ` |
| 1390 | java_library { |
| 1391 | name: "foo", |
| 1392 | srcs: ["aidl/foo/IFoo.aidl", "aidl/foo/IFoo2.aidl"], |
| 1393 | aidl: { enforce_permissions: true, enforce_permissions_exceptions: ["aidl/foo/IFoo2.aidl"] }, |
| 1394 | } |
| 1395 | `) |
| 1396 | |
| 1397 | aidlCommand := ctx.ModuleForTests("foo", "android_common").Rule("aidl").RuleParams.Command |
| 1398 | expectedAidlFlag := "$$FLAGS -Wmissing-permission-annotation -Werror aidl/foo/IFoo.aidl" |
| 1399 | if !strings.Contains(aidlCommand, expectedAidlFlag) { |
| 1400 | t.Errorf("aidl command %q does not contain %q", aidlCommand, expectedAidlFlag) |
| 1401 | } |
| 1402 | expectedAidlFlag = "$$FLAGS aidl/foo/IFoo2.aidl" |
| 1403 | if !strings.Contains(aidlCommand, expectedAidlFlag) { |
| 1404 | t.Errorf("aidl command %q does not contain %q", aidlCommand, expectedAidlFlag) |
| 1405 | } |
| 1406 | } |
| 1407 | |
Liz Kammer | dd849a8 | 2020-06-12 16:38:45 -0700 | [diff] [blame] | 1408 | func TestDataNativeBinaries(t *testing.T) { |
Cole Faust | 5c503d1 | 2023-01-24 11:48:08 -0800 | [diff] [blame] | 1409 | ctx := android.GroupFixturePreparers( |
| 1410 | prepareForJavaTest, |
| 1411 | android.PrepareForTestWithAllowMissingDependencies).RunTestWithBp(t, ` |
Liz Kammer | dd849a8 | 2020-06-12 16:38:45 -0700 | [diff] [blame] | 1412 | java_test_host { |
| 1413 | name: "foo", |
| 1414 | srcs: ["a.java"], |
| 1415 | data_native_bins: ["bin"] |
| 1416 | } |
| 1417 | |
Cole Faust | 5c503d1 | 2023-01-24 11:48:08 -0800 | [diff] [blame] | 1418 | cc_binary_host { |
Liz Kammer | dd849a8 | 2020-06-12 16:38:45 -0700 | [diff] [blame] | 1419 | name: "bin", |
Cole Faust | 5c503d1 | 2023-01-24 11:48:08 -0800 | [diff] [blame] | 1420 | srcs: ["bin.cpp"], |
Liz Kammer | dd849a8 | 2020-06-12 16:38:45 -0700 | [diff] [blame] | 1421 | } |
Cole Faust | 5c503d1 | 2023-01-24 11:48:08 -0800 | [diff] [blame] | 1422 | `).TestContext |
Liz Kammer | dd849a8 | 2020-06-12 16:38:45 -0700 | [diff] [blame] | 1423 | |
Colin Cross | 0c66bc6 | 2021-07-20 09:47:41 -0700 | [diff] [blame] | 1424 | buildOS := ctx.Config().BuildOS.String() |
Liz Kammer | dd849a8 | 2020-06-12 16:38:45 -0700 | [diff] [blame] | 1425 | |
| 1426 | test := ctx.ModuleForTests("foo", buildOS+"_common").Module().(*TestHost) |
Colin Cross | aa25553 | 2020-07-03 13:18:24 -0700 | [diff] [blame] | 1427 | entries := android.AndroidMkEntriesForTest(t, ctx, test)[0] |
Cole Faust | 5c503d1 | 2023-01-24 11:48:08 -0800 | [diff] [blame] | 1428 | expected := []string{"out/soong/.intermediates/bin/" + buildOS + "_x86_64/bin:bin"} |
Liz Kammer | dd849a8 | 2020-06-12 16:38:45 -0700 | [diff] [blame] | 1429 | actual := entries.EntryMap["LOCAL_COMPATIBILITY_SUPPORT_FILES"] |
Paul Duffin | 414ea5e | 2021-03-22 17:31:52 +0000 | [diff] [blame] | 1430 | android.AssertStringPathsRelativeToTopEquals(t, "LOCAL_COMPATIBILITY_SUPPORT_FILES", ctx.Config(), expected, actual) |
Liz Kammer | dd849a8 | 2020-06-12 16:38:45 -0700 | [diff] [blame] | 1431 | } |
Yuexi Ma | 627263f | 2021-03-04 13:47:56 -0800 | [diff] [blame] | 1432 | |
| 1433 | func TestDefaultInstallable(t *testing.T) { |
| 1434 | ctx, _ := testJava(t, ` |
| 1435 | java_test_host { |
| 1436 | name: "foo" |
| 1437 | } |
| 1438 | `) |
| 1439 | |
Colin Cross | 0c66bc6 | 2021-07-20 09:47:41 -0700 | [diff] [blame] | 1440 | buildOS := ctx.Config().BuildOS.String() |
Yuexi Ma | 627263f | 2021-03-04 13:47:56 -0800 | [diff] [blame] | 1441 | module := ctx.ModuleForTests("foo", buildOS+"_common").Module().(*TestHost) |
| 1442 | assertDeepEquals(t, "Default installable value should be true.", proptools.BoolPtr(true), |
| 1443 | module.properties.Installable) |
| 1444 | } |
Cole Faust | 75fffb1 | 2021-06-13 15:23:16 -0700 | [diff] [blame] | 1445 | |
| 1446 | func TestErrorproneEnabled(t *testing.T) { |
| 1447 | ctx, _ := testJava(t, ` |
| 1448 | java_library { |
| 1449 | name: "foo", |
| 1450 | srcs: ["a.java"], |
| 1451 | errorprone: { |
| 1452 | enabled: true, |
| 1453 | }, |
| 1454 | } |
| 1455 | `) |
| 1456 | |
| 1457 | javac := ctx.ModuleForTests("foo", "android_common").Description("javac") |
| 1458 | |
| 1459 | // Test that the errorprone plugins are passed to javac |
| 1460 | expectedSubstring := "-Xplugin:ErrorProne" |
| 1461 | if !strings.Contains(javac.Args["javacFlags"], expectedSubstring) { |
Cole Faust | 2b1536e | 2021-06-18 12:25:54 -0700 | [diff] [blame] | 1462 | t.Errorf("expected javacFlags to contain %q, got %q", expectedSubstring, javac.Args["javacFlags"]) |
Cole Faust | 75fffb1 | 2021-06-13 15:23:16 -0700 | [diff] [blame] | 1463 | } |
| 1464 | |
| 1465 | // Modules with errorprone { enabled: true } will include errorprone checks |
| 1466 | // in the main javac build rule. Only when RUN_ERROR_PRONE is true will |
| 1467 | // the explicit errorprone build rule be created. |
| 1468 | errorprone := ctx.ModuleForTests("foo", "android_common").MaybeDescription("errorprone") |
| 1469 | if errorprone.RuleParams.Description != "" { |
| 1470 | t.Errorf("expected errorprone build rule to not exist, but it did") |
| 1471 | } |
| 1472 | } |
Cole Faust | 2b1536e | 2021-06-18 12:25:54 -0700 | [diff] [blame] | 1473 | |
| 1474 | func TestErrorproneDisabled(t *testing.T) { |
| 1475 | bp := ` |
| 1476 | java_library { |
| 1477 | name: "foo", |
| 1478 | srcs: ["a.java"], |
| 1479 | errorprone: { |
| 1480 | enabled: false, |
| 1481 | }, |
| 1482 | } |
| 1483 | ` |
| 1484 | ctx := android.GroupFixturePreparers( |
| 1485 | PrepareForTestWithJavaDefaultModules, |
| 1486 | android.FixtureMergeEnv(map[string]string{ |
| 1487 | "RUN_ERROR_PRONE": "true", |
| 1488 | }), |
| 1489 | ).RunTestWithBp(t, bp) |
| 1490 | |
| 1491 | javac := ctx.ModuleForTests("foo", "android_common").Description("javac") |
| 1492 | |
| 1493 | // Test that the errorprone plugins are not passed to javac, like they would |
| 1494 | // be if enabled was true. |
| 1495 | expectedSubstring := "-Xplugin:ErrorProne" |
| 1496 | if strings.Contains(javac.Args["javacFlags"], expectedSubstring) { |
| 1497 | t.Errorf("expected javacFlags to not contain %q, got %q", expectedSubstring, javac.Args["javacFlags"]) |
| 1498 | } |
| 1499 | |
| 1500 | // Check that no errorprone build rule is created, like there would be |
| 1501 | // if enabled was unset and RUN_ERROR_PRONE was true. |
| 1502 | errorprone := ctx.ModuleForTests("foo", "android_common").MaybeDescription("errorprone") |
| 1503 | if errorprone.RuleParams.Description != "" { |
| 1504 | t.Errorf("expected errorprone build rule to not exist, but it did") |
| 1505 | } |
| 1506 | } |
| 1507 | |
| 1508 | func TestErrorproneEnabledOnlyByEnvironmentVariable(t *testing.T) { |
| 1509 | bp := ` |
| 1510 | java_library { |
| 1511 | name: "foo", |
| 1512 | srcs: ["a.java"], |
| 1513 | } |
| 1514 | ` |
| 1515 | ctx := android.GroupFixturePreparers( |
| 1516 | PrepareForTestWithJavaDefaultModules, |
| 1517 | android.FixtureMergeEnv(map[string]string{ |
| 1518 | "RUN_ERROR_PRONE": "true", |
| 1519 | }), |
| 1520 | ).RunTestWithBp(t, bp) |
| 1521 | |
| 1522 | javac := ctx.ModuleForTests("foo", "android_common").Description("javac") |
| 1523 | errorprone := ctx.ModuleForTests("foo", "android_common").Description("errorprone") |
| 1524 | |
| 1525 | // Check that the errorprone plugins are not passed to javac, because they |
| 1526 | // will instead be passed to the separate errorprone compilation |
| 1527 | expectedSubstring := "-Xplugin:ErrorProne" |
| 1528 | if strings.Contains(javac.Args["javacFlags"], expectedSubstring) { |
| 1529 | t.Errorf("expected javacFlags to not contain %q, got %q", expectedSubstring, javac.Args["javacFlags"]) |
| 1530 | } |
| 1531 | |
| 1532 | // Check that the errorprone plugin is enabled |
| 1533 | if !strings.Contains(errorprone.Args["javacFlags"], expectedSubstring) { |
| 1534 | t.Errorf("expected errorprone to contain %q, got %q", expectedSubstring, javac.Args["javacFlags"]) |
| 1535 | } |
| 1536 | } |
Sam Delmerico | b3342ce | 2022-01-20 21:10:28 +0000 | [diff] [blame] | 1537 | |
| 1538 | func TestDataDeviceBinsBuildsDeviceBinary(t *testing.T) { |
Sam Delmerico | cc271e2 | 2022-06-01 15:45:02 +0000 | [diff] [blame] | 1539 | testCases := []struct { |
| 1540 | dataDeviceBinType string |
| 1541 | depCompileMultilib string |
| 1542 | variants []string |
| 1543 | expectedError string |
| 1544 | }{ |
| 1545 | { |
| 1546 | dataDeviceBinType: "first", |
| 1547 | depCompileMultilib: "first", |
| 1548 | variants: []string{"android_arm64_armv8-a"}, |
| 1549 | }, |
| 1550 | { |
| 1551 | dataDeviceBinType: "first", |
| 1552 | depCompileMultilib: "both", |
| 1553 | variants: []string{"android_arm64_armv8-a"}, |
| 1554 | }, |
| 1555 | { |
| 1556 | // this is true because our testing framework is set up with |
| 1557 | // Targets ~ [<64bit target>, <32bit target>], where 64bit is "first" |
| 1558 | dataDeviceBinType: "first", |
| 1559 | depCompileMultilib: "32", |
| 1560 | expectedError: `Android.bp:2:3: dependency "bar" of "foo" missing variant`, |
| 1561 | }, |
| 1562 | { |
| 1563 | dataDeviceBinType: "first", |
| 1564 | depCompileMultilib: "64", |
| 1565 | variants: []string{"android_arm64_armv8-a"}, |
| 1566 | }, |
| 1567 | { |
| 1568 | dataDeviceBinType: "both", |
| 1569 | depCompileMultilib: "both", |
| 1570 | variants: []string{ |
| 1571 | "android_arm_armv7-a-neon", |
| 1572 | "android_arm64_armv8-a", |
| 1573 | }, |
| 1574 | }, |
| 1575 | { |
| 1576 | dataDeviceBinType: "both", |
| 1577 | depCompileMultilib: "32", |
| 1578 | expectedError: `Android.bp:2:3: dependency "bar" of "foo" missing variant`, |
| 1579 | }, |
| 1580 | { |
| 1581 | dataDeviceBinType: "both", |
| 1582 | depCompileMultilib: "64", |
| 1583 | expectedError: `Android.bp:2:3: dependency "bar" of "foo" missing variant`, |
| 1584 | }, |
| 1585 | { |
| 1586 | dataDeviceBinType: "both", |
| 1587 | depCompileMultilib: "first", |
| 1588 | expectedError: `Android.bp:2:3: dependency "bar" of "foo" missing variant`, |
| 1589 | }, |
| 1590 | { |
| 1591 | dataDeviceBinType: "32", |
| 1592 | depCompileMultilib: "32", |
| 1593 | variants: []string{"android_arm_armv7-a-neon"}, |
| 1594 | }, |
| 1595 | { |
| 1596 | dataDeviceBinType: "32", |
| 1597 | depCompileMultilib: "first", |
| 1598 | expectedError: `Android.bp:2:3: dependency "bar" of "foo" missing variant`, |
| 1599 | }, |
| 1600 | { |
| 1601 | dataDeviceBinType: "32", |
| 1602 | depCompileMultilib: "both", |
| 1603 | variants: []string{"android_arm_armv7-a-neon"}, |
| 1604 | }, |
| 1605 | { |
| 1606 | dataDeviceBinType: "32", |
| 1607 | depCompileMultilib: "64", |
| 1608 | expectedError: `Android.bp:2:3: dependency "bar" of "foo" missing variant`, |
| 1609 | }, |
| 1610 | { |
| 1611 | dataDeviceBinType: "64", |
| 1612 | depCompileMultilib: "64", |
| 1613 | variants: []string{"android_arm64_armv8-a"}, |
| 1614 | }, |
| 1615 | { |
| 1616 | dataDeviceBinType: "64", |
| 1617 | depCompileMultilib: "both", |
| 1618 | variants: []string{"android_arm64_armv8-a"}, |
| 1619 | }, |
| 1620 | { |
| 1621 | dataDeviceBinType: "64", |
| 1622 | depCompileMultilib: "first", |
| 1623 | variants: []string{"android_arm64_armv8-a"}, |
| 1624 | }, |
| 1625 | { |
| 1626 | dataDeviceBinType: "64", |
| 1627 | depCompileMultilib: "32", |
| 1628 | expectedError: `Android.bp:2:3: dependency "bar" of "foo" missing variant`, |
| 1629 | }, |
| 1630 | { |
| 1631 | dataDeviceBinType: "prefer32", |
| 1632 | depCompileMultilib: "32", |
| 1633 | variants: []string{"android_arm_armv7-a-neon"}, |
| 1634 | }, |
| 1635 | { |
| 1636 | dataDeviceBinType: "prefer32", |
| 1637 | depCompileMultilib: "both", |
| 1638 | variants: []string{"android_arm_armv7-a-neon"}, |
| 1639 | }, |
| 1640 | { |
| 1641 | dataDeviceBinType: "prefer32", |
| 1642 | depCompileMultilib: "first", |
| 1643 | expectedError: `Android.bp:2:3: dependency "bar" of "foo" missing variant`, |
| 1644 | }, |
| 1645 | { |
| 1646 | dataDeviceBinType: "prefer32", |
| 1647 | depCompileMultilib: "64", |
| 1648 | expectedError: `Android.bp:2:3: dependency "bar" of "foo" missing variant`, |
| 1649 | }, |
Sam Delmerico | b3342ce | 2022-01-20 21:10:28 +0000 | [diff] [blame] | 1650 | } |
Sam Delmerico | b3342ce | 2022-01-20 21:10:28 +0000 | [diff] [blame] | 1651 | |
Sam Delmerico | cc271e2 | 2022-06-01 15:45:02 +0000 | [diff] [blame] | 1652 | bpTemplate := ` |
Sam Delmerico | b3342ce | 2022-01-20 21:10:28 +0000 | [diff] [blame] | 1653 | java_test_host { |
| 1654 | name: "foo", |
| 1655 | srcs: ["test.java"], |
Sam Delmerico | cc271e2 | 2022-06-01 15:45:02 +0000 | [diff] [blame] | 1656 | data_device_bins_%s: ["bar"], |
Sam Delmerico | b3342ce | 2022-01-20 21:10:28 +0000 | [diff] [blame] | 1657 | } |
| 1658 | |
| 1659 | cc_binary { |
| 1660 | name: "bar", |
Sam Delmerico | cc271e2 | 2022-06-01 15:45:02 +0000 | [diff] [blame] | 1661 | compile_multilib: "%s", |
Sam Delmerico | b3342ce | 2022-01-20 21:10:28 +0000 | [diff] [blame] | 1662 | } |
| 1663 | ` |
| 1664 | |
Sam Delmerico | cc271e2 | 2022-06-01 15:45:02 +0000 | [diff] [blame] | 1665 | for _, tc := range testCases { |
| 1666 | bp := fmt.Sprintf(bpTemplate, tc.dataDeviceBinType, tc.depCompileMultilib) |
Sam Delmerico | b3342ce | 2022-01-20 21:10:28 +0000 | [diff] [blame] | 1667 | |
Sam Delmerico | cc271e2 | 2022-06-01 15:45:02 +0000 | [diff] [blame] | 1668 | errorHandler := android.FixtureExpectsNoErrors |
| 1669 | if tc.expectedError != "" { |
| 1670 | errorHandler = android.FixtureExpectsAtLeastOneErrorMatchingPattern(tc.expectedError) |
| 1671 | } |
Sam Delmerico | b3342ce | 2022-01-20 21:10:28 +0000 | [diff] [blame] | 1672 | |
Sam Delmerico | cc271e2 | 2022-06-01 15:45:02 +0000 | [diff] [blame] | 1673 | testName := fmt.Sprintf(`data_device_bins_%s with compile_multilib:"%s"`, tc.dataDeviceBinType, tc.depCompileMultilib) |
| 1674 | t.Run(testName, func(t *testing.T) { |
| 1675 | ctx := android.GroupFixturePreparers(PrepareForIntegrationTestWithJava). |
| 1676 | ExtendWithErrorHandler(errorHandler). |
| 1677 | RunTestWithBp(t, bp) |
| 1678 | if tc.expectedError != "" { |
| 1679 | return |
| 1680 | } |
| 1681 | |
| 1682 | buildOS := ctx.Config.BuildOS.String() |
| 1683 | fooVariant := ctx.ModuleForTests("foo", buildOS+"_common") |
| 1684 | fooMod := fooVariant.Module().(*TestHost) |
| 1685 | entries := android.AndroidMkEntriesForTest(t, ctx.TestContext, fooMod)[0] |
| 1686 | |
| 1687 | expectedAutogenConfig := `<option name="push-file" key="bar" value="/data/local/tests/unrestricted/foo/bar" />` |
| 1688 | autogen := fooVariant.Rule("autogen") |
| 1689 | if !strings.Contains(autogen.Args["extraConfigs"], expectedAutogenConfig) { |
| 1690 | t.Errorf("foo extraConfigs %v does not contain %q", autogen.Args["extraConfigs"], expectedAutogenConfig) |
| 1691 | } |
| 1692 | |
| 1693 | expectedData := []string{} |
| 1694 | for _, variant := range tc.variants { |
| 1695 | barVariant := ctx.ModuleForTests("bar", variant) |
| 1696 | relocated := barVariant.Output("bar") |
| 1697 | expectedInput := fmt.Sprintf("out/soong/.intermediates/bar/%s/unstripped/bar", variant) |
| 1698 | android.AssertPathRelativeToTopEquals(t, "relocation input", expectedInput, relocated.Input) |
| 1699 | |
| 1700 | expectedData = append(expectedData, fmt.Sprintf("out/soong/.intermediates/bar/%s/bar:bar", variant)) |
| 1701 | } |
| 1702 | |
| 1703 | actualData := entries.EntryMap["LOCAL_COMPATIBILITY_SUPPORT_FILES"] |
| 1704 | android.AssertStringPathsRelativeToTopEquals(t, "LOCAL_TEST_DATA", ctx.Config, expectedData, actualData) |
| 1705 | }) |
Sam Delmerico | b3342ce | 2022-01-20 21:10:28 +0000 | [diff] [blame] | 1706 | } |
| 1707 | } |
Sam Delmerico | 277795c | 2022-02-25 17:04:37 +0000 | [diff] [blame] | 1708 | |
Zi Wang | ca65b40 | 2022-10-10 13:45:06 -0700 | [diff] [blame] | 1709 | func TestDeviceBinaryWrapperGeneration(t *testing.T) { |
| 1710 | // Scenario 1: java_binary has main_class property in its bp |
| 1711 | ctx, _ := testJava(t, ` |
| 1712 | java_binary { |
| 1713 | name: "foo", |
| 1714 | srcs: ["foo.java"], |
| 1715 | main_class: "foo.bar.jb", |
| 1716 | } |
| 1717 | `) |
| 1718 | wrapperPath := fmt.Sprint(ctx.ModuleForTests("foo", "android_arm64_armv8-a").AllOutputs()) |
| 1719 | if !strings.Contains(wrapperPath, "foo.sh") { |
| 1720 | t.Errorf("wrapper file foo.sh is not generated") |
| 1721 | } |
| 1722 | |
| 1723 | // Scenario 2: java_binary has neither wrapper nor main_class, its build |
| 1724 | // is expected to be failed. |
| 1725 | testJavaError(t, "main_class property is required for device binary if no default wrapper is assigned", ` |
| 1726 | java_binary { |
| 1727 | name: "foo", |
| 1728 | srcs: ["foo.java"], |
| 1729 | }`) |
| 1730 | } |
Jihoon Kang | 0ac87c2 | 2022-11-15 19:06:14 +0000 | [diff] [blame] | 1731 | |
Jihoon Kang | 3198f3c | 2023-01-26 08:08:52 +0000 | [diff] [blame] | 1732 | func TestJavaApiContributionEmptyApiFile(t *testing.T) { |
Jihoon Kang | 063ec00 | 2023-06-28 01:16:23 +0000 | [diff] [blame] | 1733 | android.GroupFixturePreparers( |
| 1734 | prepareForJavaTest, |
| 1735 | android.FixtureMergeEnv( |
| 1736 | map[string]string{ |
| 1737 | "DISABLE_STUB_VALIDATION": "true", |
| 1738 | }, |
| 1739 | ), |
| 1740 | ).ExtendWithErrorHandler(android.FixtureExpectsAtLeastOneErrorMatchingPattern( |
Jihoon Kang | 3198f3c | 2023-01-26 08:08:52 +0000 | [diff] [blame] | 1741 | "Error: foo has an empty api file.", |
Jihoon Kang | 063ec00 | 2023-06-28 01:16:23 +0000 | [diff] [blame] | 1742 | )).RunTestWithBp(t, ` |
| 1743 | java_api_contribution { |
Jihoon Kang | 3198f3c | 2023-01-26 08:08:52 +0000 | [diff] [blame] | 1744 | name: "foo", |
| 1745 | } |
| 1746 | java_api_library { |
| 1747 | name: "bar", |
| 1748 | api_surface: "public", |
| 1749 | api_contributions: ["foo"], |
| 1750 | } |
| 1751 | `) |
| 1752 | } |
| 1753 | |
Jihoon Kang | 0ac87c2 | 2022-11-15 19:06:14 +0000 | [diff] [blame] | 1754 | func TestJavaApiLibraryAndProviderLink(t *testing.T) { |
| 1755 | provider_bp_a := ` |
| 1756 | java_api_contribution { |
| 1757 | name: "foo1", |
Jihoon Kang | 84473f5 | 2023-08-11 22:36:33 +0000 | [diff] [blame] | 1758 | api_file: "current.txt", |
Jihoon Kang | 8fe1982 | 2023-09-14 06:27:36 +0000 | [diff] [blame] | 1759 | api_surface: "public", |
Jihoon Kang | 0ac87c2 | 2022-11-15 19:06:14 +0000 | [diff] [blame] | 1760 | } |
| 1761 | ` |
| 1762 | provider_bp_b := `java_api_contribution { |
| 1763 | name: "foo2", |
Jihoon Kang | 84473f5 | 2023-08-11 22:36:33 +0000 | [diff] [blame] | 1764 | api_file: "current.txt", |
Jihoon Kang | 8fe1982 | 2023-09-14 06:27:36 +0000 | [diff] [blame] | 1765 | api_surface: "public", |
Jihoon Kang | 0ac87c2 | 2022-11-15 19:06:14 +0000 | [diff] [blame] | 1766 | } |
| 1767 | ` |
Jihoon Kang | 063ec00 | 2023-06-28 01:16:23 +0000 | [diff] [blame] | 1768 | ctx := android.GroupFixturePreparers( |
| 1769 | prepareForJavaTest, |
| 1770 | android.FixtureMergeMockFs( |
| 1771 | map[string][]byte{ |
| 1772 | "a/Android.bp": []byte(provider_bp_a), |
| 1773 | "b/Android.bp": []byte(provider_bp_b), |
| 1774 | }, |
| 1775 | ), |
| 1776 | android.FixtureMergeEnv( |
| 1777 | map[string]string{ |
| 1778 | "DISABLE_STUB_VALIDATION": "true", |
| 1779 | }, |
| 1780 | ), |
| 1781 | ).RunTestWithBp(t, ` |
Jihoon Kang | 0ac87c2 | 2022-11-15 19:06:14 +0000 | [diff] [blame] | 1782 | java_api_library { |
| 1783 | name: "bar1", |
| 1784 | api_surface: "public", |
Jihoon Kang | 60d4a09 | 2022-11-17 23:47:43 +0000 | [diff] [blame] | 1785 | api_contributions: ["foo1"], |
Jihoon Kang | 0ac87c2 | 2022-11-15 19:06:14 +0000 | [diff] [blame] | 1786 | } |
| 1787 | |
| 1788 | java_api_library { |
| 1789 | name: "bar2", |
| 1790 | api_surface: "system", |
Jihoon Kang | 60d4a09 | 2022-11-17 23:47:43 +0000 | [diff] [blame] | 1791 | api_contributions: ["foo1", "foo2"], |
Jihoon Kang | 0ac87c2 | 2022-11-15 19:06:14 +0000 | [diff] [blame] | 1792 | } |
Jihoon Kang | 063ec00 | 2023-06-28 01:16:23 +0000 | [diff] [blame] | 1793 | `) |
Jihoon Kang | 0ac87c2 | 2022-11-15 19:06:14 +0000 | [diff] [blame] | 1794 | |
| 1795 | testcases := []struct { |
| 1796 | moduleName string |
| 1797 | sourceTextFileDirs []string |
| 1798 | }{ |
| 1799 | { |
| 1800 | moduleName: "bar1", |
Jihoon Kang | 84473f5 | 2023-08-11 22:36:33 +0000 | [diff] [blame] | 1801 | sourceTextFileDirs: []string{"a/current.txt"}, |
Jihoon Kang | 0ac87c2 | 2022-11-15 19:06:14 +0000 | [diff] [blame] | 1802 | }, |
| 1803 | { |
| 1804 | moduleName: "bar2", |
Jihoon Kang | 6be0f00 | 2023-09-20 23:03:01 +0000 | [diff] [blame] | 1805 | sourceTextFileDirs: []string{"a/current.txt", "b/current.txt"}, |
Jihoon Kang | 0ac87c2 | 2022-11-15 19:06:14 +0000 | [diff] [blame] | 1806 | }, |
| 1807 | } |
| 1808 | for _, c := range testcases { |
| 1809 | m := ctx.ModuleForTests(c.moduleName, "android_common") |
| 1810 | manifest := m.Output("metalava.sbox.textproto") |
Colin Cross | f61d03d | 2023-11-02 16:56:39 -0700 | [diff] [blame] | 1811 | sboxProto := android.RuleBuilderSboxProtoForTests(t, ctx.TestContext, manifest) |
Jihoon Kang | 0ac87c2 | 2022-11-15 19:06:14 +0000 | [diff] [blame] | 1812 | manifestCommand := sboxProto.Commands[0].GetCommand() |
| 1813 | sourceFilesFlag := "--source-files " + strings.Join(c.sourceTextFileDirs, " ") |
| 1814 | android.AssertStringDoesContain(t, "source text files not present", manifestCommand, sourceFilesFlag) |
| 1815 | } |
| 1816 | } |
| 1817 | |
Jihoon Kang | 1c51f50 | 2023-01-09 23:42:40 +0000 | [diff] [blame] | 1818 | func TestJavaApiLibraryAndDefaultsLink(t *testing.T) { |
Jihoon Kang | 362aa9d | 2023-01-20 19:44:07 +0000 | [diff] [blame] | 1819 | provider_bp_a := ` |
| 1820 | java_api_contribution { |
Jihoon Kang | 1c51f50 | 2023-01-09 23:42:40 +0000 | [diff] [blame] | 1821 | name: "foo1", |
Jihoon Kang | 84473f5 | 2023-08-11 22:36:33 +0000 | [diff] [blame] | 1822 | api_file: "current.txt", |
Jihoon Kang | 8fe1982 | 2023-09-14 06:27:36 +0000 | [diff] [blame] | 1823 | api_surface: "public", |
Jihoon Kang | 1c51f50 | 2023-01-09 23:42:40 +0000 | [diff] [blame] | 1824 | } |
| 1825 | ` |
Jihoon Kang | 362aa9d | 2023-01-20 19:44:07 +0000 | [diff] [blame] | 1826 | provider_bp_b := ` |
| 1827 | java_api_contribution { |
Jihoon Kang | 1c51f50 | 2023-01-09 23:42:40 +0000 | [diff] [blame] | 1828 | name: "foo2", |
Jihoon Kang | 84473f5 | 2023-08-11 22:36:33 +0000 | [diff] [blame] | 1829 | api_file: "current.txt", |
Jihoon Kang | 8fe1982 | 2023-09-14 06:27:36 +0000 | [diff] [blame] | 1830 | api_surface: "public", |
Jihoon Kang | 1c51f50 | 2023-01-09 23:42:40 +0000 | [diff] [blame] | 1831 | } |
| 1832 | ` |
Jihoon Kang | 362aa9d | 2023-01-20 19:44:07 +0000 | [diff] [blame] | 1833 | provider_bp_c := ` |
| 1834 | java_api_contribution { |
Jihoon Kang | 1c51f50 | 2023-01-09 23:42:40 +0000 | [diff] [blame] | 1835 | name: "foo3", |
Jihoon Kang | 8fe1982 | 2023-09-14 06:27:36 +0000 | [diff] [blame] | 1836 | api_file: "system-current.txt", |
| 1837 | api_surface: "system", |
Jihoon Kang | 1c51f50 | 2023-01-09 23:42:40 +0000 | [diff] [blame] | 1838 | } |
| 1839 | ` |
Jihoon Kang | 362aa9d | 2023-01-20 19:44:07 +0000 | [diff] [blame] | 1840 | provider_bp_d := ` |
| 1841 | java_api_contribution { |
Jihoon Kang | 1c51f50 | 2023-01-09 23:42:40 +0000 | [diff] [blame] | 1842 | name: "foo4", |
Jihoon Kang | 8fe1982 | 2023-09-14 06:27:36 +0000 | [diff] [blame] | 1843 | api_file: "system-current.txt", |
| 1844 | api_surface: "system", |
Jihoon Kang | 1c51f50 | 2023-01-09 23:42:40 +0000 | [diff] [blame] | 1845 | } |
| 1846 | ` |
Jihoon Kang | 063ec00 | 2023-06-28 01:16:23 +0000 | [diff] [blame] | 1847 | ctx := android.GroupFixturePreparers( |
| 1848 | prepareForJavaTest, |
| 1849 | android.FixtureMergeMockFs( |
| 1850 | map[string][]byte{ |
| 1851 | "a/Android.bp": []byte(provider_bp_a), |
| 1852 | "b/Android.bp": []byte(provider_bp_b), |
| 1853 | "c/Android.bp": []byte(provider_bp_c), |
| 1854 | "d/Android.bp": []byte(provider_bp_d), |
| 1855 | }, |
| 1856 | ), |
| 1857 | android.FixtureMergeEnv( |
| 1858 | map[string]string{ |
| 1859 | "DISABLE_STUB_VALIDATION": "true", |
| 1860 | }, |
| 1861 | ), |
| 1862 | ).RunTestWithBp(t, ` |
Jihoon Kang | 1c51f50 | 2023-01-09 23:42:40 +0000 | [diff] [blame] | 1863 | java_defaults { |
| 1864 | name: "baz1", |
| 1865 | api_surface: "public", |
| 1866 | api_contributions: ["foo1", "foo2"], |
| 1867 | } |
| 1868 | |
| 1869 | java_defaults { |
| 1870 | name: "baz2", |
| 1871 | api_surface: "system", |
| 1872 | api_contributions: ["foo3"], |
| 1873 | } |
| 1874 | |
| 1875 | java_api_library { |
| 1876 | name: "bar1", |
| 1877 | api_surface: "public", |
| 1878 | api_contributions: ["foo1"], |
| 1879 | } |
| 1880 | |
| 1881 | java_api_library { |
| 1882 | name: "bar2", |
| 1883 | api_surface: "public", |
| 1884 | defaults:["baz1"], |
| 1885 | } |
| 1886 | |
| 1887 | java_api_library { |
| 1888 | name: "bar3", |
| 1889 | api_surface: "system", |
| 1890 | defaults:["baz1", "baz2"], |
| 1891 | api_contributions: ["foo4"], |
Jihoon Kang | 1c51f50 | 2023-01-09 23:42:40 +0000 | [diff] [blame] | 1892 | } |
Jihoon Kang | 063ec00 | 2023-06-28 01:16:23 +0000 | [diff] [blame] | 1893 | `) |
Jihoon Kang | 1c51f50 | 2023-01-09 23:42:40 +0000 | [diff] [blame] | 1894 | |
| 1895 | testcases := []struct { |
| 1896 | moduleName string |
| 1897 | sourceTextFileDirs []string |
| 1898 | }{ |
| 1899 | { |
| 1900 | moduleName: "bar1", |
Jihoon Kang | 84473f5 | 2023-08-11 22:36:33 +0000 | [diff] [blame] | 1901 | sourceTextFileDirs: []string{"a/current.txt"}, |
Jihoon Kang | 1c51f50 | 2023-01-09 23:42:40 +0000 | [diff] [blame] | 1902 | }, |
| 1903 | { |
| 1904 | moduleName: "bar2", |
Jihoon Kang | 84473f5 | 2023-08-11 22:36:33 +0000 | [diff] [blame] | 1905 | sourceTextFileDirs: []string{"a/current.txt", "b/current.txt"}, |
Jihoon Kang | 1c51f50 | 2023-01-09 23:42:40 +0000 | [diff] [blame] | 1906 | }, |
| 1907 | { |
Jihoon Kang | 8fe1982 | 2023-09-14 06:27:36 +0000 | [diff] [blame] | 1908 | moduleName: "bar3", |
| 1909 | // API text files need to be sorted from the narrower api scope to the wider api scope |
Jihoon Kang | 6be0f00 | 2023-09-20 23:03:01 +0000 | [diff] [blame] | 1910 | sourceTextFileDirs: []string{"a/current.txt", "b/current.txt", "c/system-current.txt", "d/system-current.txt"}, |
Jihoon Kang | 1c51f50 | 2023-01-09 23:42:40 +0000 | [diff] [blame] | 1911 | }, |
| 1912 | } |
| 1913 | for _, c := range testcases { |
| 1914 | m := ctx.ModuleForTests(c.moduleName, "android_common") |
| 1915 | manifest := m.Output("metalava.sbox.textproto") |
Colin Cross | f61d03d | 2023-11-02 16:56:39 -0700 | [diff] [blame] | 1916 | sboxProto := android.RuleBuilderSboxProtoForTests(t, ctx.TestContext, manifest) |
Jihoon Kang | 1c51f50 | 2023-01-09 23:42:40 +0000 | [diff] [blame] | 1917 | manifestCommand := sboxProto.Commands[0].GetCommand() |
| 1918 | sourceFilesFlag := "--source-files " + strings.Join(c.sourceTextFileDirs, " ") |
| 1919 | android.AssertStringDoesContain(t, "source text files not present", manifestCommand, sourceFilesFlag) |
| 1920 | } |
| 1921 | } |
| 1922 | |
Jihoon Kang | 0ac87c2 | 2022-11-15 19:06:14 +0000 | [diff] [blame] | 1923 | func TestJavaApiLibraryJarGeneration(t *testing.T) { |
| 1924 | provider_bp_a := ` |
| 1925 | java_api_contribution { |
| 1926 | name: "foo1", |
Jihoon Kang | 84473f5 | 2023-08-11 22:36:33 +0000 | [diff] [blame] | 1927 | api_file: "current.txt", |
Jihoon Kang | 8fe1982 | 2023-09-14 06:27:36 +0000 | [diff] [blame] | 1928 | api_surface: "public", |
Jihoon Kang | 0ac87c2 | 2022-11-15 19:06:14 +0000 | [diff] [blame] | 1929 | } |
| 1930 | ` |
Jihoon Kang | 362aa9d | 2023-01-20 19:44:07 +0000 | [diff] [blame] | 1931 | provider_bp_b := ` |
| 1932 | java_api_contribution { |
Jihoon Kang | 0ac87c2 | 2022-11-15 19:06:14 +0000 | [diff] [blame] | 1933 | name: "foo2", |
Jihoon Kang | 84473f5 | 2023-08-11 22:36:33 +0000 | [diff] [blame] | 1934 | api_file: "current.txt", |
Jihoon Kang | 8fe1982 | 2023-09-14 06:27:36 +0000 | [diff] [blame] | 1935 | api_surface: "public", |
Jihoon Kang | 0ac87c2 | 2022-11-15 19:06:14 +0000 | [diff] [blame] | 1936 | } |
| 1937 | ` |
Jihoon Kang | 063ec00 | 2023-06-28 01:16:23 +0000 | [diff] [blame] | 1938 | ctx := android.GroupFixturePreparers( |
| 1939 | prepareForJavaTest, |
| 1940 | android.FixtureMergeMockFs( |
| 1941 | map[string][]byte{ |
| 1942 | "a/Android.bp": []byte(provider_bp_a), |
| 1943 | "b/Android.bp": []byte(provider_bp_b), |
| 1944 | }, |
| 1945 | ), |
| 1946 | android.FixtureMergeEnv( |
| 1947 | map[string]string{ |
| 1948 | "DISABLE_STUB_VALIDATION": "true", |
| 1949 | }, |
| 1950 | ), |
| 1951 | ).RunTestWithBp(t, ` |
Jihoon Kang | 0ac87c2 | 2022-11-15 19:06:14 +0000 | [diff] [blame] | 1952 | java_api_library { |
| 1953 | name: "bar1", |
| 1954 | api_surface: "public", |
Jihoon Kang | 60d4a09 | 2022-11-17 23:47:43 +0000 | [diff] [blame] | 1955 | api_contributions: ["foo1"], |
Jihoon Kang | 0ac87c2 | 2022-11-15 19:06:14 +0000 | [diff] [blame] | 1956 | } |
| 1957 | |
| 1958 | java_api_library { |
| 1959 | name: "bar2", |
| 1960 | api_surface: "system", |
Jihoon Kang | 60d4a09 | 2022-11-17 23:47:43 +0000 | [diff] [blame] | 1961 | api_contributions: ["foo1", "foo2"], |
Jihoon Kang | 0ac87c2 | 2022-11-15 19:06:14 +0000 | [diff] [blame] | 1962 | } |
Jihoon Kang | 063ec00 | 2023-06-28 01:16:23 +0000 | [diff] [blame] | 1963 | `) |
Jihoon Kang | 0ac87c2 | 2022-11-15 19:06:14 +0000 | [diff] [blame] | 1964 | |
| 1965 | testcases := []struct { |
| 1966 | moduleName string |
| 1967 | outputJarName string |
| 1968 | }{ |
| 1969 | { |
| 1970 | moduleName: "bar1", |
Jihoon Kang | 25857f5 | 2023-03-01 00:27:32 +0000 | [diff] [blame] | 1971 | outputJarName: "bar1/bar1.jar", |
Jihoon Kang | 0ac87c2 | 2022-11-15 19:06:14 +0000 | [diff] [blame] | 1972 | }, |
| 1973 | { |
| 1974 | moduleName: "bar2", |
Jihoon Kang | 25857f5 | 2023-03-01 00:27:32 +0000 | [diff] [blame] | 1975 | outputJarName: "bar2/bar2.jar", |
Jihoon Kang | 0ac87c2 | 2022-11-15 19:06:14 +0000 | [diff] [blame] | 1976 | }, |
| 1977 | } |
| 1978 | for _, c := range testcases { |
| 1979 | m := ctx.ModuleForTests(c.moduleName, "android_common") |
| 1980 | outputs := fmt.Sprint(m.AllOutputs()) |
| 1981 | if !strings.Contains(outputs, c.outputJarName) { |
| 1982 | t.Errorf("Module output does not contain expected jar %s", c.outputJarName) |
| 1983 | } |
| 1984 | } |
| 1985 | } |
Cole Faust | 2168054 | 2022-12-07 18:18:37 -0800 | [diff] [blame] | 1986 | |
Jihoon Kang | 362aa9d | 2023-01-20 19:44:07 +0000 | [diff] [blame] | 1987 | func TestJavaApiLibraryLibsLink(t *testing.T) { |
| 1988 | provider_bp_a := ` |
| 1989 | java_api_contribution { |
| 1990 | name: "foo1", |
Jihoon Kang | 84473f5 | 2023-08-11 22:36:33 +0000 | [diff] [blame] | 1991 | api_file: "current.txt", |
Jihoon Kang | 8fe1982 | 2023-09-14 06:27:36 +0000 | [diff] [blame] | 1992 | api_surface: "public", |
Jihoon Kang | 362aa9d | 2023-01-20 19:44:07 +0000 | [diff] [blame] | 1993 | } |
| 1994 | ` |
| 1995 | provider_bp_b := ` |
| 1996 | java_api_contribution { |
| 1997 | name: "foo2", |
Jihoon Kang | 84473f5 | 2023-08-11 22:36:33 +0000 | [diff] [blame] | 1998 | api_file: "current.txt", |
Jihoon Kang | 8fe1982 | 2023-09-14 06:27:36 +0000 | [diff] [blame] | 1999 | api_surface: "public", |
Jihoon Kang | 362aa9d | 2023-01-20 19:44:07 +0000 | [diff] [blame] | 2000 | } |
| 2001 | ` |
| 2002 | lib_bp_a := ` |
| 2003 | java_library { |
| 2004 | name: "lib1", |
| 2005 | srcs: ["Lib.java"], |
| 2006 | } |
| 2007 | ` |
| 2008 | lib_bp_b := ` |
| 2009 | java_library { |
| 2010 | name: "lib2", |
| 2011 | srcs: ["Lib.java"], |
| 2012 | } |
| 2013 | ` |
| 2014 | |
Jihoon Kang | 063ec00 | 2023-06-28 01:16:23 +0000 | [diff] [blame] | 2015 | ctx := android.GroupFixturePreparers( |
| 2016 | prepareForJavaTest, |
| 2017 | android.FixtureMergeMockFs( |
| 2018 | map[string][]byte{ |
| 2019 | "a/Android.bp": []byte(provider_bp_a), |
| 2020 | "b/Android.bp": []byte(provider_bp_b), |
| 2021 | "c/Android.bp": []byte(lib_bp_a), |
| 2022 | "c/Lib.java": {}, |
| 2023 | "d/Android.bp": []byte(lib_bp_b), |
| 2024 | "d/Lib.java": {}, |
| 2025 | }, |
| 2026 | ), |
| 2027 | android.FixtureMergeEnv( |
| 2028 | map[string]string{ |
| 2029 | "DISABLE_STUB_VALIDATION": "true", |
| 2030 | }, |
| 2031 | ), |
| 2032 | ).RunTestWithBp(t, ` |
Jihoon Kang | 362aa9d | 2023-01-20 19:44:07 +0000 | [diff] [blame] | 2033 | java_api_library { |
| 2034 | name: "bar1", |
| 2035 | api_surface: "public", |
| 2036 | api_contributions: ["foo1"], |
| 2037 | libs: ["lib1"], |
| 2038 | } |
| 2039 | |
| 2040 | java_api_library { |
| 2041 | name: "bar2", |
| 2042 | api_surface: "system", |
| 2043 | api_contributions: ["foo1", "foo2"], |
| 2044 | libs: ["lib1", "lib2", "bar1"], |
| 2045 | } |
Jihoon Kang | 063ec00 | 2023-06-28 01:16:23 +0000 | [diff] [blame] | 2046 | `) |
Jihoon Kang | 362aa9d | 2023-01-20 19:44:07 +0000 | [diff] [blame] | 2047 | |
| 2048 | testcases := []struct { |
| 2049 | moduleName string |
| 2050 | classPathJarNames []string |
| 2051 | }{ |
| 2052 | { |
| 2053 | moduleName: "bar1", |
| 2054 | classPathJarNames: []string{"lib1.jar"}, |
| 2055 | }, |
| 2056 | { |
| 2057 | moduleName: "bar2", |
Jihoon Kang | 25857f5 | 2023-03-01 00:27:32 +0000 | [diff] [blame] | 2058 | classPathJarNames: []string{"lib1.jar", "lib2.jar", "bar1/bar1.jar"}, |
Jihoon Kang | 362aa9d | 2023-01-20 19:44:07 +0000 | [diff] [blame] | 2059 | }, |
| 2060 | } |
| 2061 | for _, c := range testcases { |
| 2062 | m := ctx.ModuleForTests(c.moduleName, "android_common") |
| 2063 | javacRules := m.Rule("javac") |
| 2064 | classPathArgs := javacRules.Args["classpath"] |
| 2065 | for _, jarName := range c.classPathJarNames { |
| 2066 | if !strings.Contains(classPathArgs, jarName) { |
| 2067 | t.Errorf("Module output does not contain expected jar %s", jarName) |
| 2068 | } |
| 2069 | } |
| 2070 | } |
| 2071 | } |
| 2072 | |
Jihoon Kang | e30fff0 | 2023-02-14 20:18:20 +0000 | [diff] [blame] | 2073 | func TestJavaApiLibraryStaticLibsLink(t *testing.T) { |
| 2074 | provider_bp_a := ` |
| 2075 | java_api_contribution { |
| 2076 | name: "foo1", |
Jihoon Kang | 84473f5 | 2023-08-11 22:36:33 +0000 | [diff] [blame] | 2077 | api_file: "current.txt", |
Jihoon Kang | 8fe1982 | 2023-09-14 06:27:36 +0000 | [diff] [blame] | 2078 | api_surface: "public", |
Jihoon Kang | e30fff0 | 2023-02-14 20:18:20 +0000 | [diff] [blame] | 2079 | } |
| 2080 | ` |
| 2081 | provider_bp_b := ` |
| 2082 | java_api_contribution { |
| 2083 | name: "foo2", |
Jihoon Kang | 84473f5 | 2023-08-11 22:36:33 +0000 | [diff] [blame] | 2084 | api_file: "current.txt", |
Jihoon Kang | 8fe1982 | 2023-09-14 06:27:36 +0000 | [diff] [blame] | 2085 | api_surface: "public", |
Jihoon Kang | e30fff0 | 2023-02-14 20:18:20 +0000 | [diff] [blame] | 2086 | } |
| 2087 | ` |
| 2088 | lib_bp_a := ` |
| 2089 | java_library { |
| 2090 | name: "lib1", |
| 2091 | srcs: ["Lib.java"], |
| 2092 | } |
| 2093 | ` |
| 2094 | lib_bp_b := ` |
| 2095 | java_library { |
| 2096 | name: "lib2", |
| 2097 | srcs: ["Lib.java"], |
| 2098 | } |
| 2099 | ` |
| 2100 | |
Jihoon Kang | 063ec00 | 2023-06-28 01:16:23 +0000 | [diff] [blame] | 2101 | ctx := android.GroupFixturePreparers( |
| 2102 | prepareForJavaTest, |
| 2103 | android.FixtureMergeMockFs( |
| 2104 | map[string][]byte{ |
| 2105 | "a/Android.bp": []byte(provider_bp_a), |
| 2106 | "b/Android.bp": []byte(provider_bp_b), |
| 2107 | "c/Android.bp": []byte(lib_bp_a), |
| 2108 | "c/Lib.java": {}, |
| 2109 | "d/Android.bp": []byte(lib_bp_b), |
| 2110 | "d/Lib.java": {}, |
| 2111 | }, |
| 2112 | ), |
| 2113 | android.FixtureMergeEnv( |
| 2114 | map[string]string{ |
| 2115 | "DISABLE_STUB_VALIDATION": "true", |
| 2116 | }, |
| 2117 | ), |
| 2118 | ).RunTestWithBp(t, ` |
Jihoon Kang | e30fff0 | 2023-02-14 20:18:20 +0000 | [diff] [blame] | 2119 | java_api_library { |
| 2120 | name: "bar1", |
| 2121 | api_surface: "public", |
| 2122 | api_contributions: ["foo1"], |
| 2123 | static_libs: ["lib1"], |
| 2124 | } |
| 2125 | |
| 2126 | java_api_library { |
| 2127 | name: "bar2", |
| 2128 | api_surface: "system", |
| 2129 | api_contributions: ["foo1", "foo2"], |
| 2130 | static_libs: ["lib1", "lib2", "bar1"], |
| 2131 | } |
Jihoon Kang | 063ec00 | 2023-06-28 01:16:23 +0000 | [diff] [blame] | 2132 | `) |
Jihoon Kang | e30fff0 | 2023-02-14 20:18:20 +0000 | [diff] [blame] | 2133 | |
| 2134 | testcases := []struct { |
| 2135 | moduleName string |
| 2136 | staticLibJarNames []string |
| 2137 | }{ |
| 2138 | { |
| 2139 | moduleName: "bar1", |
| 2140 | staticLibJarNames: []string{"lib1.jar"}, |
| 2141 | }, |
| 2142 | { |
| 2143 | moduleName: "bar2", |
Jihoon Kang | 25857f5 | 2023-03-01 00:27:32 +0000 | [diff] [blame] | 2144 | staticLibJarNames: []string{"lib1.jar", "lib2.jar", "bar1/bar1.jar"}, |
Jihoon Kang | e30fff0 | 2023-02-14 20:18:20 +0000 | [diff] [blame] | 2145 | }, |
| 2146 | } |
| 2147 | for _, c := range testcases { |
| 2148 | m := ctx.ModuleForTests(c.moduleName, "android_common") |
| 2149 | mergeZipsCommand := m.Rule("merge_zips").RuleParams.Command |
| 2150 | for _, jarName := range c.staticLibJarNames { |
| 2151 | if !strings.Contains(mergeZipsCommand, jarName) { |
| 2152 | t.Errorf("merge_zips command does not contain expected jar %s", jarName) |
| 2153 | } |
| 2154 | } |
| 2155 | } |
| 2156 | } |
| 2157 | |
Jihoon Kang | ca198c2 | 2023-06-22 23:13:51 +0000 | [diff] [blame] | 2158 | func TestJavaApiLibraryFullApiSurfaceStub(t *testing.T) { |
Jihoon Kang | 01e522c | 2023-03-14 01:09:34 +0000 | [diff] [blame] | 2159 | provider_bp_a := ` |
| 2160 | java_api_contribution { |
| 2161 | name: "foo1", |
Jihoon Kang | 84473f5 | 2023-08-11 22:36:33 +0000 | [diff] [blame] | 2162 | api_file: "current.txt", |
Jihoon Kang | 8fe1982 | 2023-09-14 06:27:36 +0000 | [diff] [blame] | 2163 | api_surface: "public", |
Jihoon Kang | 01e522c | 2023-03-14 01:09:34 +0000 | [diff] [blame] | 2164 | } |
| 2165 | ` |
| 2166 | provider_bp_b := ` |
| 2167 | java_api_contribution { |
| 2168 | name: "foo2", |
Jihoon Kang | 84473f5 | 2023-08-11 22:36:33 +0000 | [diff] [blame] | 2169 | api_file: "current.txt", |
Jihoon Kang | 8fe1982 | 2023-09-14 06:27:36 +0000 | [diff] [blame] | 2170 | api_surface: "public", |
Jihoon Kang | 01e522c | 2023-03-14 01:09:34 +0000 | [diff] [blame] | 2171 | } |
| 2172 | ` |
| 2173 | lib_bp_a := ` |
| 2174 | java_api_library { |
| 2175 | name: "lib1", |
| 2176 | api_surface: "public", |
| 2177 | api_contributions: ["foo1", "foo2"], |
| 2178 | } |
| 2179 | ` |
| 2180 | |
Jihoon Kang | 063ec00 | 2023-06-28 01:16:23 +0000 | [diff] [blame] | 2181 | ctx := android.GroupFixturePreparers( |
| 2182 | prepareForJavaTest, |
| 2183 | android.FixtureMergeMockFs( |
| 2184 | map[string][]byte{ |
| 2185 | "a/Android.bp": []byte(provider_bp_a), |
| 2186 | "b/Android.bp": []byte(provider_bp_b), |
| 2187 | "c/Android.bp": []byte(lib_bp_a), |
| 2188 | }, |
| 2189 | ), |
| 2190 | android.FixtureMergeEnv( |
| 2191 | map[string]string{ |
| 2192 | "DISABLE_STUB_VALIDATION": "true", |
| 2193 | }, |
| 2194 | ), |
| 2195 | ).RunTestWithBp(t, ` |
Jihoon Kang | 01e522c | 2023-03-14 01:09:34 +0000 | [diff] [blame] | 2196 | java_api_library { |
| 2197 | name: "bar1", |
| 2198 | api_surface: "public", |
| 2199 | api_contributions: ["foo1"], |
Jihoon Kang | ca198c2 | 2023-06-22 23:13:51 +0000 | [diff] [blame] | 2200 | full_api_surface_stub: "lib1", |
Jihoon Kang | 01e522c | 2023-03-14 01:09:34 +0000 | [diff] [blame] | 2201 | } |
Jihoon Kang | 063ec00 | 2023-06-28 01:16:23 +0000 | [diff] [blame] | 2202 | `) |
Jihoon Kang | 01e522c | 2023-03-14 01:09:34 +0000 | [diff] [blame] | 2203 | |
| 2204 | m := ctx.ModuleForTests("bar1", "android_common") |
| 2205 | manifest := m.Output("metalava.sbox.textproto") |
Colin Cross | f61d03d | 2023-11-02 16:56:39 -0700 | [diff] [blame] | 2206 | sboxProto := android.RuleBuilderSboxProtoForTests(t, ctx.TestContext, manifest) |
Jihoon Kang | 01e522c | 2023-03-14 01:09:34 +0000 | [diff] [blame] | 2207 | manifestCommand := sboxProto.Commands[0].GetCommand() |
Jihoon Kang | ca198c2 | 2023-06-22 23:13:51 +0000 | [diff] [blame] | 2208 | android.AssertStringDoesContain(t, "Command expected to contain full_api_surface_stub output jar", manifestCommand, "lib1.jar") |
Jihoon Kang | 01e522c | 2023-03-14 01:09:34 +0000 | [diff] [blame] | 2209 | } |
| 2210 | |
Anton Hansson | 0e73f9e | 2023-09-20 13:39:57 +0000 | [diff] [blame] | 2211 | func TestTransitiveSrcFiles(t *testing.T) { |
| 2212 | ctx, _ := testJava(t, ` |
| 2213 | java_library { |
| 2214 | name: "a", |
| 2215 | srcs: ["a.java"], |
| 2216 | } |
| 2217 | java_library { |
| 2218 | name: "b", |
| 2219 | srcs: ["b.java"], |
| 2220 | } |
| 2221 | java_library { |
| 2222 | name: "c", |
| 2223 | srcs: ["c.java"], |
| 2224 | libs: ["a"], |
| 2225 | static_libs: ["b"], |
| 2226 | } |
| 2227 | `) |
| 2228 | c := ctx.ModuleForTests("c", "android_common").Module() |
| 2229 | transitiveSrcFiles := android.Paths(ctx.ModuleProvider(c, JavaInfoProvider).(JavaInfo).TransitiveSrcFiles.ToList()) |
| 2230 | android.AssertArrayString(t, "unexpected jar deps", []string{"b.java", "c.java"}, transitiveSrcFiles.Strings()) |
| 2231 | } |
| 2232 | |
Cole Faust | 2168054 | 2022-12-07 18:18:37 -0800 | [diff] [blame] | 2233 | func TestTradefedOptions(t *testing.T) { |
| 2234 | result := PrepareForTestWithJavaBuildComponents.RunTestWithBp(t, ` |
| 2235 | java_test_host { |
| 2236 | name: "foo", |
| 2237 | test_options: { |
| 2238 | tradefed_options: [ |
| 2239 | { |
| 2240 | name: "exclude-path", |
| 2241 | value: "org/apache" |
| 2242 | } |
| 2243 | ] |
| 2244 | } |
| 2245 | } |
| 2246 | `) |
| 2247 | |
| 2248 | buildOS := result.Config.BuildOS.String() |
| 2249 | args := result.ModuleForTests("foo", buildOS+"_common"). |
| 2250 | Output("out/soong/.intermediates/foo/" + buildOS + "_common/foo.config").Args |
| 2251 | expected := proptools.NinjaAndShellEscape("<option name=\"exclude-path\" value=\"org/apache\" />") |
| 2252 | if args["extraConfigs"] != expected { |
| 2253 | t.Errorf("Expected args[\"extraConfigs\"] to equal %q, was %q", expected, args["extraConfigs"]) |
| 2254 | } |
| 2255 | } |
Dan Shi | ec73143 | 2023-05-26 04:21:44 +0000 | [diff] [blame] | 2256 | |
| 2257 | func TestTestRunnerOptions(t *testing.T) { |
| 2258 | result := PrepareForTestWithJavaBuildComponents.RunTestWithBp(t, ` |
| 2259 | java_test_host { |
| 2260 | name: "foo", |
| 2261 | test_options: { |
| 2262 | test_runner_options: [ |
| 2263 | { |
| 2264 | name: "test-timeout", |
| 2265 | value: "10m" |
| 2266 | } |
| 2267 | ] |
| 2268 | } |
| 2269 | } |
| 2270 | `) |
| 2271 | |
| 2272 | buildOS := result.Config.BuildOS.String() |
| 2273 | args := result.ModuleForTests("foo", buildOS+"_common"). |
| 2274 | Output("out/soong/.intermediates/foo/" + buildOS + "_common/foo.config").Args |
| 2275 | expected := proptools.NinjaAndShellEscape("<option name=\"test-timeout\" value=\"10m\" />\\n ") |
| 2276 | if args["extraTestRunnerConfigs"] != expected { |
| 2277 | t.Errorf("Expected args[\"extraTestRunnerConfigs\"] to equal %q, was %q", expected, args["extraTestRunnerConfigs"]) |
| 2278 | } |
| 2279 | } |
Jihoon Kang | 381c2fa | 2023-06-01 22:17:32 +0000 | [diff] [blame] | 2280 | |
| 2281 | func TestJavaExcludeStaticLib(t *testing.T) { |
| 2282 | ctx, _ := testJava(t, ` |
| 2283 | java_library { |
| 2284 | name: "bar", |
| 2285 | } |
| 2286 | java_library { |
| 2287 | name: "foo", |
| 2288 | } |
| 2289 | java_library { |
| 2290 | name: "baz", |
| 2291 | static_libs: [ |
| 2292 | "foo", |
| 2293 | "bar", |
| 2294 | ], |
| 2295 | exclude_static_libs: [ |
| 2296 | "bar", |
| 2297 | ], |
| 2298 | } |
| 2299 | `) |
| 2300 | |
| 2301 | // "bar" not included as dependency of "baz" |
| 2302 | CheckModuleDependencies(t, ctx, "baz", "android_common", []string{ |
| 2303 | `core-lambda-stubs`, |
| 2304 | `ext`, |
| 2305 | `foo`, |
| 2306 | `framework`, |
| 2307 | `stable-core-platform-api-stubs-system-modules`, |
| 2308 | `stable.core.platform.api.stubs`, |
| 2309 | }) |
| 2310 | } |
Jihoon Kang | 1bfb6f2 | 2023-07-01 00:13:47 +0000 | [diff] [blame] | 2311 | |
| 2312 | func TestJavaLibraryWithResourcesStem(t *testing.T) { |
| 2313 | ctx, _ := testJavaWithFS(t, ` |
| 2314 | java_library { |
| 2315 | name: "foo", |
| 2316 | java_resource_dirs: ["test-jar"], |
| 2317 | stem: "test", |
| 2318 | } |
| 2319 | `, |
| 2320 | map[string][]byte{ |
| 2321 | "test-jar/test/resource.txt": nil, |
| 2322 | }) |
| 2323 | |
| 2324 | m := ctx.ModuleForTests("foo", "android_common") |
| 2325 | outputs := fmt.Sprint(m.AllOutputs()) |
| 2326 | if !strings.Contains(outputs, "test.jar") { |
| 2327 | t.Errorf("Module output does not contain expected jar %s", "test.jar") |
| 2328 | } |
| 2329 | } |
Mark White | a15790a | 2023-08-22 21:28:11 +0000 | [diff] [blame] | 2330 | |
| 2331 | func TestHeadersOnly(t *testing.T) { |
| 2332 | ctx, _ := testJava(t, ` |
| 2333 | java_library { |
| 2334 | name: "foo", |
| 2335 | srcs: ["a.java"], |
| 2336 | headers_only: true, |
| 2337 | } |
| 2338 | `) |
| 2339 | |
| 2340 | turbine := ctx.ModuleForTests("foo", "android_common").Rule("turbine") |
| 2341 | if len(turbine.Inputs) != 1 || turbine.Inputs[0].String() != "a.java" { |
| 2342 | t.Errorf(`foo inputs %v != ["a.java"]`, turbine.Inputs) |
| 2343 | } |
| 2344 | |
| 2345 | javac := ctx.ModuleForTests("foo", "android_common").MaybeRule("javac") |
| 2346 | android.AssertDeepEquals(t, "javac rule", nil, javac.Rule) |
| 2347 | } |
Jihoon Kang | fdf3236 | 2023-09-12 00:36:43 +0000 | [diff] [blame] | 2348 | |
| 2349 | func TestJavaApiContributionImport(t *testing.T) { |
Jihoon Kang | 063ec00 | 2023-06-28 01:16:23 +0000 | [diff] [blame] | 2350 | ctx := android.GroupFixturePreparers( |
| 2351 | prepareForJavaTest, |
| 2352 | android.FixtureMergeEnv( |
| 2353 | map[string]string{ |
| 2354 | "DISABLE_STUB_VALIDATION": "true", |
| 2355 | }, |
| 2356 | ), |
| 2357 | ).RunTestWithBp(t, ` |
Jihoon Kang | fdf3236 | 2023-09-12 00:36:43 +0000 | [diff] [blame] | 2358 | java_api_library { |
| 2359 | name: "foo", |
| 2360 | api_contributions: ["bar"], |
| 2361 | } |
| 2362 | java_api_contribution_import { |
| 2363 | name: "bar", |
| 2364 | api_file: "current.txt", |
Jihoon Kang | 8fe1982 | 2023-09-14 06:27:36 +0000 | [diff] [blame] | 2365 | api_surface: "public", |
Jihoon Kang | fdf3236 | 2023-09-12 00:36:43 +0000 | [diff] [blame] | 2366 | } |
| 2367 | `) |
| 2368 | m := ctx.ModuleForTests("foo", "android_common") |
| 2369 | manifest := m.Output("metalava.sbox.textproto") |
Colin Cross | f61d03d | 2023-11-02 16:56:39 -0700 | [diff] [blame] | 2370 | sboxProto := android.RuleBuilderSboxProtoForTests(t, ctx.TestContext, manifest) |
Jihoon Kang | fdf3236 | 2023-09-12 00:36:43 +0000 | [diff] [blame] | 2371 | manifestCommand := sboxProto.Commands[0].GetCommand() |
| 2372 | sourceFilesFlag := "--source-files current.txt" |
| 2373 | android.AssertStringDoesContain(t, "source text files not present", manifestCommand, sourceFilesFlag) |
| 2374 | } |
Jihoon Kang | a96a7b1 | 2023-09-20 23:43:32 +0000 | [diff] [blame] | 2375 | |
| 2376 | func TestJavaApiLibraryApiFilesSorting(t *testing.T) { |
| 2377 | ctx, _ := testJava(t, ` |
| 2378 | java_api_library { |
| 2379 | name: "foo", |
| 2380 | api_contributions: [ |
| 2381 | "system-server-api-stubs-docs-non-updatable.api.contribution", |
| 2382 | "test-api-stubs-docs-non-updatable.api.contribution", |
| 2383 | "system-api-stubs-docs-non-updatable.api.contribution", |
| 2384 | "module-lib-api-stubs-docs-non-updatable.api.contribution", |
| 2385 | "api-stubs-docs-non-updatable.api.contribution", |
| 2386 | ], |
| 2387 | } |
| 2388 | `) |
| 2389 | m := ctx.ModuleForTests("foo", "android_common") |
| 2390 | manifest := m.Output("metalava.sbox.textproto") |
Colin Cross | f61d03d | 2023-11-02 16:56:39 -0700 | [diff] [blame] | 2391 | sboxProto := android.RuleBuilderSboxProtoForTests(t, ctx, manifest) |
Jihoon Kang | a96a7b1 | 2023-09-20 23:43:32 +0000 | [diff] [blame] | 2392 | manifestCommand := sboxProto.Commands[0].GetCommand() |
| 2393 | |
| 2394 | // Api files are sorted from the narrowest api scope to the widest api scope. |
| 2395 | // test api and module lib api surface do not have subset/superset relationship, |
| 2396 | // but they will never be passed as inputs at the same time. |
| 2397 | sourceFilesFlag := "--source-files default/java/api/current.txt " + |
| 2398 | "default/java/api/system-current.txt default/java/api/test-current.txt " + |
| 2399 | "default/java/api/module-lib-current.txt default/java/api/system-server-current.txt" |
| 2400 | android.AssertStringDoesContain(t, "source text files not in api scope order", manifestCommand, sourceFilesFlag) |
| 2401 | } |
Jihoon Kang | 4ec2487 | 2023-10-05 17:26:09 +0000 | [diff] [blame] | 2402 | |
| 2403 | func TestSdkLibraryProvidesSystemModulesToApiLibrary(t *testing.T) { |
| 2404 | result := android.GroupFixturePreparers( |
| 2405 | prepareForJavaTest, |
| 2406 | PrepareForTestWithJavaSdkLibraryFiles, |
| 2407 | FixtureWithLastReleaseApis("foo"), |
| 2408 | android.FixtureModifyConfig(func(config android.Config) { |
| 2409 | config.SetApiLibraries([]string{"foo"}) |
| 2410 | }), |
| 2411 | android.FixtureMergeMockFs( |
| 2412 | map[string][]byte{ |
| 2413 | "A.java": nil, |
| 2414 | }, |
| 2415 | ), |
| 2416 | ).RunTestWithBp(t, ` |
| 2417 | java_library { |
| 2418 | name: "bar", |
| 2419 | srcs: ["a.java"], |
| 2420 | } |
| 2421 | java_system_modules { |
| 2422 | name: "baz", |
| 2423 | libs: ["bar"], |
| 2424 | } |
| 2425 | java_sdk_library { |
| 2426 | name: "foo", |
| 2427 | srcs: ["A.java"], |
| 2428 | system_modules: "baz", |
| 2429 | } |
| 2430 | `) |
| 2431 | m := result.ModuleForTests(apiScopePublic.apiLibraryModuleName("foo"), "android_common") |
| 2432 | manifest := m.Output("metalava.sbox.textproto") |
Colin Cross | f61d03d | 2023-11-02 16:56:39 -0700 | [diff] [blame] | 2433 | sboxProto := android.RuleBuilderSboxProtoForTests(t, result.TestContext, manifest) |
Jihoon Kang | 4ec2487 | 2023-10-05 17:26:09 +0000 | [diff] [blame] | 2434 | manifestCommand := sboxProto.Commands[0].GetCommand() |
Cole Faust | e8561c6 | 2023-11-30 17:26:37 -0800 | [diff] [blame^] | 2435 | classPathFlag := "--classpath __SBOX_SANDBOX_DIR__/out/soong/.intermediates/bar/android_common/turbine-combined/bar.jar" |
Jihoon Kang | 4ec2487 | 2023-10-05 17:26:09 +0000 | [diff] [blame] | 2436 | android.AssertStringDoesContain(t, "command expected to contain classpath flag", manifestCommand, classPathFlag) |
| 2437 | } |
Jihoon Kang | 063ec00 | 2023-06-28 01:16:23 +0000 | [diff] [blame] | 2438 | |
| 2439 | func TestApiLibraryDroidstubsDependency(t *testing.T) { |
| 2440 | result := android.GroupFixturePreparers( |
| 2441 | prepareForJavaTest, |
| 2442 | PrepareForTestWithJavaSdkLibraryFiles, |
| 2443 | FixtureWithLastReleaseApis("foo"), |
| 2444 | android.FixtureModifyConfig(func(config android.Config) { |
| 2445 | config.SetApiLibraries([]string{"foo"}) |
| 2446 | }), |
| 2447 | android.FixtureMergeMockFs( |
| 2448 | map[string][]byte{ |
| 2449 | "A.java": nil, |
| 2450 | }, |
| 2451 | ), |
| 2452 | ).RunTestWithBp(t, ` |
| 2453 | java_api_library { |
| 2454 | name: "foo", |
| 2455 | api_contributions: [ |
| 2456 | "api-stubs-docs-non-updatable.api.contribution", |
| 2457 | ], |
| 2458 | enable_validation: true, |
| 2459 | } |
| 2460 | java_api_library { |
| 2461 | name: "bar", |
| 2462 | api_contributions: [ |
| 2463 | "api-stubs-docs-non-updatable.api.contribution", |
| 2464 | ], |
| 2465 | enable_validation: false, |
| 2466 | } |
| 2467 | `) |
| 2468 | |
| 2469 | currentApiTimestampPath := "api-stubs-docs-non-updatable/android_common/metalava/check_current_api.timestamp" |
| 2470 | foo := result.ModuleForTests("foo", "android_common").Module().(*ApiLibrary) |
| 2471 | fooValidationPathsString := strings.Join(foo.validationPaths.Strings(), " ") |
| 2472 | bar := result.ModuleForTests("bar", "android_common").Module().(*ApiLibrary) |
| 2473 | barValidationPathsString := strings.Join(bar.validationPaths.Strings(), " ") |
| 2474 | android.AssertStringDoesContain(t, |
| 2475 | "Module expected to have validation", |
| 2476 | fooValidationPathsString, |
| 2477 | currentApiTimestampPath, |
| 2478 | ) |
| 2479 | android.AssertStringDoesNotContain(t, |
| 2480 | "Module expected to not have validation", |
| 2481 | barValidationPathsString, |
| 2482 | currentApiTimestampPath, |
| 2483 | ) |
| 2484 | } |
Jihoon Kang | 1975d3e | 2023-10-16 23:24:11 +0000 | [diff] [blame] | 2485 | |
| 2486 | func TestDisableFromTextStubForCoverageBuild(t *testing.T) { |
| 2487 | result := android.GroupFixturePreparers( |
| 2488 | prepareForJavaTest, |
| 2489 | PrepareForTestWithJavaSdkLibraryFiles, |
| 2490 | PrepareForTestWithJacocoInstrumentation, |
| 2491 | FixtureWithLastReleaseApis("foo"), |
| 2492 | android.FixtureModifyConfig(func(config android.Config) { |
| 2493 | config.SetApiLibraries([]string{"foo"}) |
| 2494 | config.SetBuildFromTextStub(true) |
| 2495 | }), |
| 2496 | android.FixtureModifyEnv(func(env map[string]string) { |
| 2497 | env["EMMA_INSTRUMENT"] = "true" |
| 2498 | }), |
| 2499 | ).RunTestWithBp(t, ` |
| 2500 | java_sdk_library { |
| 2501 | name: "foo", |
| 2502 | srcs: ["A.java"], |
| 2503 | } |
| 2504 | `) |
| 2505 | android.AssertBoolEquals(t, "stub module expected to depend on from-source stub", |
| 2506 | true, CheckModuleHasDependency(t, result.TestContext, |
| 2507 | apiScopePublic.stubsLibraryModuleName("foo"), "android_common", |
| 2508 | apiScopePublic.sourceStubLibraryModuleName("foo"))) |
| 2509 | |
| 2510 | android.AssertBoolEquals(t, "stub module expected to not depend on from-text stub", |
| 2511 | false, CheckModuleHasDependency(t, result.TestContext, |
| 2512 | apiScopePublic.stubsLibraryModuleName("foo"), "android_common", |
| 2513 | apiScopePublic.apiLibraryModuleName("foo"))) |
| 2514 | } |