blob: 0e2d01a45dacb42477034b423e03976832f05069 [file] [log] [blame]
Colin Cross16b23492016-01-06 14:41:07 -08001// Copyright 2016 Google Inc. All rights reserved.
2//
3// Licensed under the Apache License, Version 2.0 (the "License");
4// you may not use this file except in compliance with the License.
5// You may obtain a copy of the License at
6//
7// http://www.apache.org/licenses/LICENSE-2.0
8//
9// Unless required by applicable law or agreed to in writing, software
10// distributed under the License is distributed on an "AS IS" BASIS,
11// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
12// See the License for the specific language governing permissions and
13// limitations under the License.
14
15package cc
16
17import (
18 "fmt"
Jeff Gaston72765392017-11-28 16:37:53 -080019 "sort"
Colin Cross16b23492016-01-06 14:41:07 -080020 "strings"
Vishwath Mohane7128792017-11-17 11:08:10 -080021 "sync"
Colin Cross16b23492016-01-06 14:41:07 -080022
Colin Cross6b753602018-06-21 13:03:07 -070023 "github.com/google/blueprint"
24
Colin Cross635c3b02016-05-18 15:37:25 -070025 "android/soong/android"
Evgenii Stepanovaf36db12016-08-15 14:18:24 -070026 "android/soong/cc/config"
Colin Cross16b23492016-01-06 14:41:07 -080027)
28
Jayant Chowdhary9677e8c2017-06-15 14:45:18 -070029var (
30 // Any C flags added by sanitizer which libTooling tools may not
31 // understand also need to be added to ClangLibToolingUnknownCflags in
32 // cc/config/clang.go
Vishwath Mohanf3918d32017-02-14 07:59:33 -080033
Yi Kong20233a42019-08-21 01:38:40 -070034 asanCflags = []string{
35 "-fno-omit-frame-pointer",
36 "-fno-experimental-new-pass-manager",
37 }
Jayant Chowdhary9677e8c2017-06-15 14:45:18 -070038 asanLdflags = []string{"-Wl,-u,__asan_preinit"}
Jayant Chowdhary9677e8c2017-06-15 14:45:18 -070039
Peter Collingbourne967511a2019-03-19 21:39:54 -070040 hwasanCflags = []string{"-fno-omit-frame-pointer", "-Wno-frame-larger-than=",
Evgenii Stepanov96fa3dd2020-03-27 19:38:42 +000041 "-fsanitize-hwaddress-abi=platform",
42 "-fno-experimental-new-pass-manager",
Evgenii Stepanov64bee4d2019-11-22 18:37:10 -080043 // The following improves debug location information
44 // availability at the cost of its accuracy. It increases
45 // the likelihood of a stack variable's frame offset
46 // to be recorded in the debug info, which is important
47 // for the quality of hwasan reports. The downside is a
48 // higher number of "optimized out" stack variables.
49 // b/112437883.
50 "-mllvm", "-instcombine-lower-dbg-declare=0",
Mitch Phillipsb1c574f2020-06-22 13:28:23 -070051 // TODO(b/159343917): HWASan and GlobalISel don't play nicely, and
52 // GlobalISel is the default at -O0 on aarch64.
53 "-mllvm", "--aarch64-enable-global-isel-at-O=-1",
54 "-mllvm", "-fast-isel=false",
Evgenii Stepanov64bee4d2019-11-22 18:37:10 -080055 }
Evgenii Stepanovd97a6e92018-08-02 16:19:13 -070056
Vishwath Mohanb743e9c2017-11-01 09:20:21 +000057 cfiCflags = []string{"-flto", "-fsanitize-cfi-cross-dso",
Pirama Arumuga Nainareb8d4032020-07-27 11:22:35 -070058 "-fsanitize-blacklist=external/compiler-rt/lib/cfi/cfi_blocklist.txt"}
Evgenii Stepanovdbf1d4f2018-08-31 12:54:33 -070059 // -flto and -fvisibility are required by clang when -fsanitize=cfi is
60 // used, but have no effect on assembly files
61 cfiAsflags = []string{"-flto", "-fvisibility=default"}
Jayant Chowdhary9677e8c2017-06-15 14:45:18 -070062 cfiLdflags = []string{"-flto", "-fsanitize-cfi-cross-dso", "-fsanitize=cfi",
Pirama Arumuga Nainarbdb17f02017-08-28 21:50:17 -070063 "-Wl,-plugin-opt,O1"}
Inseob Kim74d25562020-08-04 00:41:38 +090064 cfiExportsMapPath = "build/soong/cc/config/cfi_exports.map"
Ivan Lozano0c3a1ef2017-06-28 09:10:48 -070065
Pirama Arumuga Nainareb8d4032020-07-27 11:22:35 -070066 intOverflowCflags = []string{"-fsanitize-blacklist=build/soong/cc/config/integer_overflow_blocklist.txt"}
Peter Collingbourne8c7e6e22018-11-19 16:03:58 -080067
Peter Collingbournebd19db02019-03-06 10:38:48 -080068 minimalRuntimeFlags = []string{"-fsanitize-minimal-runtime", "-fno-sanitize-trap=integer,undefined",
Ivan Lozanoae6ae1d2018-10-08 09:29:39 -070069 "-fno-sanitize-recover=integer,undefined"}
Evgenii Stepanov2c6484e2019-05-15 12:49:54 -070070 hwasanGlobalOptions = []string{"heap_history_size=1023", "stack_history_size=512",
71 "export_memory_stats=0", "max_malloc_fill_size=0"}
Dan Willemsencbceaab2016-10-13 16:44:07 -070072)
73
Colin Cross16b23492016-01-06 14:41:07 -080074type sanitizerType int
75
Evgenii Stepanovfcfe56d2016-07-07 10:54:07 -070076func boolPtr(v bool) *bool {
77 if v {
78 return &v
79 } else {
80 return nil
81 }
82}
83
Colin Cross16b23492016-01-06 14:41:07 -080084const (
85 asan sanitizerType = iota + 1
Evgenii Stepanovd97a6e92018-08-02 16:19:13 -070086 hwasan
Colin Cross16b23492016-01-06 14:41:07 -080087 tsan
Ivan Lozano0c3a1ef2017-06-28 09:10:48 -070088 intOverflow
Vishwath Mohanb743e9c2017-11-01 09:20:21 +000089 cfi
Peter Collingbourne8c7e6e22018-11-19 16:03:58 -080090 scs
Mitch Phillips5a6ea6c2019-05-01 14:42:05 -070091 fuzzer
Colin Cross16b23492016-01-06 14:41:07 -080092)
93
Jiyong Park82226632019-02-01 10:50:50 +090094// Name of the sanitizer variation for this sanitizer type
95func (t sanitizerType) variationName() string {
Colin Cross16b23492016-01-06 14:41:07 -080096 switch t {
97 case asan:
98 return "asan"
Evgenii Stepanovd97a6e92018-08-02 16:19:13 -070099 case hwasan:
100 return "hwasan"
Colin Cross16b23492016-01-06 14:41:07 -0800101 case tsan:
102 return "tsan"
Ivan Lozano0c3a1ef2017-06-28 09:10:48 -0700103 case intOverflow:
104 return "intOverflow"
Vishwath Mohanb743e9c2017-11-01 09:20:21 +0000105 case cfi:
106 return "cfi"
Peter Collingbourne8c7e6e22018-11-19 16:03:58 -0800107 case scs:
108 return "scs"
Mitch Phillips5a6ea6c2019-05-01 14:42:05 -0700109 case fuzzer:
110 return "fuzzer"
Colin Cross16b23492016-01-06 14:41:07 -0800111 default:
112 panic(fmt.Errorf("unknown sanitizerType %d", t))
113 }
114}
115
Jiyong Park82226632019-02-01 10:50:50 +0900116// This is the sanitizer names in SANITIZE_[TARGET|HOST]
117func (t sanitizerType) name() string {
118 switch t {
119 case asan:
120 return "address"
121 case hwasan:
122 return "hwaddress"
123 case tsan:
124 return "thread"
125 case intOverflow:
126 return "integer_overflow"
127 case cfi:
128 return "cfi"
129 case scs:
130 return "shadow-call-stack"
Mitch Phillips5a6ea6c2019-05-01 14:42:05 -0700131 case fuzzer:
132 return "fuzzer"
Jiyong Park82226632019-02-01 10:50:50 +0900133 default:
134 panic(fmt.Errorf("unknown sanitizerType %d", t))
135 }
136}
137
Jiyong Park1d1119f2019-07-29 21:27:18 +0900138func (t sanitizerType) incompatibleWithCfi() bool {
139 return t == asan || t == fuzzer || t == hwasan
140}
141
Martin Stjernholmb0249572020-09-15 02:32:35 +0100142type SanitizeUserProps struct {
143 Never *bool `android:"arch_variant"`
Colin Cross16b23492016-01-06 14:41:07 -0800144
Martin Stjernholmb0249572020-09-15 02:32:35 +0100145 // main sanitizers
146 Address *bool `android:"arch_variant"`
147 Thread *bool `android:"arch_variant"`
148 Hwaddress *bool `android:"arch_variant"`
Colin Cross16b23492016-01-06 14:41:07 -0800149
Martin Stjernholmb0249572020-09-15 02:32:35 +0100150 // local sanitizers
151 Undefined *bool `android:"arch_variant"`
152 All_undefined *bool `android:"arch_variant"`
153 Misc_undefined []string `android:"arch_variant"`
154 Fuzzer *bool `android:"arch_variant"`
155 Safestack *bool `android:"arch_variant"`
156 Cfi *bool `android:"arch_variant"`
157 Integer_overflow *bool `android:"arch_variant"`
158 Scudo *bool `android:"arch_variant"`
159 Scs *bool `android:"arch_variant"`
160
161 // A modifier for ASAN and HWASAN for write only instrumentation
162 Writeonly *bool `android:"arch_variant"`
163
164 // Sanitizers to run in the diagnostic mode (as opposed to the release mode).
165 // Replaces abort() on error with a human-readable error message.
166 // Address and Thread sanitizers always run in diagnostic mode.
167 Diag struct {
Ivan Lozano0c3a1ef2017-06-28 09:10:48 -0700168 Undefined *bool `android:"arch_variant"`
Ivan Lozano0c3a1ef2017-06-28 09:10:48 -0700169 Cfi *bool `android:"arch_variant"`
170 Integer_overflow *bool `android:"arch_variant"`
Martin Stjernholmb0249572020-09-15 02:32:35 +0100171 Misc_undefined []string `android:"arch_variant"`
Cindy Zhoud3fe4922020-12-01 11:14:30 -0800172 No_recover []string `android:"arch_variant"`
173 } `android:"arch_variant"`
Colin Cross16b23492016-01-06 14:41:07 -0800174
Cindy Zhou8cd45de2020-11-16 08:41:00 -0800175 // Sanitizers to run with flag configuration specified
176 Config struct {
177 // Enables CFI support flags for assembly-heavy libraries
178 Cfi_assembly_support *bool `android:"arch_variant"`
Cindy Zhoud3fe4922020-12-01 11:14:30 -0800179 } `android:"arch_variant"`
Cindy Zhou8cd45de2020-11-16 08:41:00 -0800180
Martin Stjernholmb0249572020-09-15 02:32:35 +0100181 // value to pass to -fsanitize-recover=
182 Recover []string
Jasraj Bedibb4511d2020-07-23 22:58:17 +0000183
Martin Stjernholmb0249572020-09-15 02:32:35 +0100184 // value to pass to -fsanitize-blacklist
185 Blocklist *string
186}
Evgenii Stepanov1e405e12016-08-16 15:39:54 -0700187
Martin Stjernholmb0249572020-09-15 02:32:35 +0100188type SanitizeProperties struct {
189 // Enable AddressSanitizer, ThreadSanitizer, UndefinedBehaviorSanitizer, and
190 // others. Please see SanitizerUserProps in build/soong/cc/sanitize.go for
191 // details.
192 Sanitize SanitizeUserProps `android:"arch_variant"`
193 SanitizerEnabled bool `blueprint:"mutated"`
194 SanitizeDep bool `blueprint:"mutated"`
195 MinimalRuntimeDep bool `blueprint:"mutated"`
196 BuiltinsDep bool `blueprint:"mutated"`
197 UbsanRuntimeDep bool `blueprint:"mutated"`
198 InSanitizerDir bool `blueprint:"mutated"`
199 Sanitizers []string `blueprint:"mutated"`
200 DiagSanitizers []string `blueprint:"mutated"`
Colin Cross16b23492016-01-06 14:41:07 -0800201}
202
203type sanitize struct {
204 Properties SanitizeProperties
205}
206
Cindy Zhou18417cb2020-12-10 07:12:38 -0800207// Mark this tag with a check to see if apex dependency check should be skipped
208func (t libraryDependencyTag) SkipApexAllowedDependenciesCheck() bool {
209 return t.skipApexAllowedDependenciesCheck
210}
211
212var _ android.SkipApexAllowedDependenciesCheck = (*libraryDependencyTag)(nil)
213
Vishwath Mohane7128792017-11-17 11:08:10 -0800214func init() {
215 android.RegisterMakeVarsProvider(pctx, cfiMakeVarsProvider)
Evgenii Stepanovd97a6e92018-08-02 16:19:13 -0700216 android.RegisterMakeVarsProvider(pctx, hwasanMakeVarsProvider)
Vishwath Mohane7128792017-11-17 11:08:10 -0800217}
218
Colin Cross16b23492016-01-06 14:41:07 -0800219func (sanitize *sanitize) props() []interface{} {
220 return []interface{}{&sanitize.Properties}
221}
222
223func (sanitize *sanitize) begin(ctx BaseModuleContext) {
Evgenii Stepanovfcfe56d2016-07-07 10:54:07 -0700224 s := &sanitize.Properties.Sanitize
225
Colin Cross16b23492016-01-06 14:41:07 -0800226 // Don't apply sanitizers to NDK code.
Jeff Gastonaf3cc2d2017-09-27 17:01:44 -0700227 if ctx.useSdk() {
Nan Zhang0007d812017-11-07 10:57:05 -0800228 s.Never = BoolPtr(true)
Colin Cross16b23492016-01-06 14:41:07 -0800229 }
230
Doug Hornc32c6b02019-01-17 14:44:05 -0800231 // Sanitizers do not work on Fuchsia yet.
232 if ctx.Fuchsia() {
233 s.Never = BoolPtr(true)
234 }
235
Colin Cross16b23492016-01-06 14:41:07 -0800236 // Never always wins.
Nan Zhang0007d812017-11-07 10:57:05 -0800237 if Bool(s.Never) {
Colin Cross16b23492016-01-06 14:41:07 -0800238 return
239 }
240
Colin Cross16b23492016-01-06 14:41:07 -0800241 var globalSanitizers []string
Ivan Lozano0c3a1ef2017-06-28 09:10:48 -0700242 var globalSanitizersDiag []string
243
Dan Willemsen8536d6b2018-10-07 20:54:34 -0700244 if ctx.Host() {
245 if !ctx.Windows() {
246 globalSanitizers = ctx.Config().SanitizeHost()
247 }
248 } else {
249 arches := ctx.Config().SanitizeDeviceArch()
250 if len(arches) == 0 || inList(ctx.Arch().ArchType.Name, arches) {
251 globalSanitizers = ctx.Config().SanitizeDevice()
252 globalSanitizersDiag = ctx.Config().SanitizeDeviceDiag()
Colin Cross16b23492016-01-06 14:41:07 -0800253 }
254 }
255
Colin Cross16b23492016-01-06 14:41:07 -0800256 if len(globalSanitizers) > 0 {
Evgenii Stepanov05bafd32016-07-07 17:38:41 +0000257 var found bool
Evgenii Stepanovfcfe56d2016-07-07 10:54:07 -0700258 if found, globalSanitizers = removeFromList("undefined", globalSanitizers); found && s.All_undefined == nil {
259 s.All_undefined = boolPtr(true)
Evgenii Stepanov05bafd32016-07-07 17:38:41 +0000260 }
Colin Cross16b23492016-01-06 14:41:07 -0800261
Evgenii Stepanovfcfe56d2016-07-07 10:54:07 -0700262 if found, globalSanitizers = removeFromList("default-ub", globalSanitizers); found && s.Undefined == nil {
263 s.Undefined = boolPtr(true)
Evgenii Stepanov05bafd32016-07-07 17:38:41 +0000264 }
265
Mitch Phillips5a6ea6c2019-05-01 14:42:05 -0700266 if found, globalSanitizers = removeFromList("address", globalSanitizers); found && s.Address == nil {
267 s.Address = boolPtr(true)
Evgenii Stepanov05bafd32016-07-07 17:38:41 +0000268 }
269
Evgenii Stepanovfcfe56d2016-07-07 10:54:07 -0700270 if found, globalSanitizers = removeFromList("thread", globalSanitizers); found && s.Thread == nil {
271 s.Thread = boolPtr(true)
Evgenii Stepanov05bafd32016-07-07 17:38:41 +0000272 }
273
Mitch Phillips5a6ea6c2019-05-01 14:42:05 -0700274 if found, globalSanitizers = removeFromList("fuzzer", globalSanitizers); found && s.Fuzzer == nil {
275 s.Fuzzer = boolPtr(true)
Evgenii Stepanovfcfe56d2016-07-07 10:54:07 -0700276 }
277
278 if found, globalSanitizers = removeFromList("safe-stack", globalSanitizers); found && s.Safestack == nil {
279 s.Safestack = boolPtr(true)
Evgenii Stepanov05bafd32016-07-07 17:38:41 +0000280 }
281
Evgenii Stepanov1e405e12016-08-16 15:39:54 -0700282 if found, globalSanitizers = removeFromList("cfi", globalSanitizers); found && s.Cfi == nil {
Colin Cross6510f912017-11-29 00:27:14 -0800283 if !ctx.Config().CFIDisabledForPath(ctx.ModuleDir()) {
Vishwath Mohan1fa3ac52017-10-31 02:26:14 -0700284 s.Cfi = boolPtr(true)
285 }
Evgenii Stepanov1e405e12016-08-16 15:39:54 -0700286 }
287
Ivan Lozanoa9255a82018-03-13 10:41:07 -0700288 // Global integer_overflow builds do not support static libraries.
Ivan Lozano0c3a1ef2017-06-28 09:10:48 -0700289 if found, globalSanitizers = removeFromList("integer_overflow", globalSanitizers); found && s.Integer_overflow == nil {
Ivan Lozanoa9255a82018-03-13 10:41:07 -0700290 if !ctx.Config().IntegerOverflowDisabledForPath(ctx.ModuleDir()) && !ctx.static() {
Ivan Lozano5f595532017-07-13 14:46:05 -0700291 s.Integer_overflow = boolPtr(true)
292 }
Ivan Lozano0c3a1ef2017-06-28 09:10:48 -0700293 }
294
Kostya Kortchinskyd18ae5c2018-06-12 14:46:54 -0700295 if found, globalSanitizers = removeFromList("scudo", globalSanitizers); found && s.Scudo == nil {
296 s.Scudo = boolPtr(true)
297 }
298
Evgenii Stepanovd97a6e92018-08-02 16:19:13 -0700299 if found, globalSanitizers = removeFromList("hwaddress", globalSanitizers); found && s.Hwaddress == nil {
300 s.Hwaddress = boolPtr(true)
301 }
302
Jasraj Bedibb4511d2020-07-23 22:58:17 +0000303 if found, globalSanitizers = removeFromList("writeonly", globalSanitizers); found && s.Writeonly == nil {
304 // Hwaddress and Address are set before, so we can check them here
305 // If they aren't explicitly set in the blueprint/SANITIZE_(HOST|TARGET), they would be nil instead of false
306 if s.Address == nil && s.Hwaddress == nil {
307 ctx.ModuleErrorf("writeonly modifier cannot be used without 'address' or 'hwaddress'")
308 }
309 s.Writeonly = boolPtr(true)
310 }
311
Evgenii Stepanov05bafd32016-07-07 17:38:41 +0000312 if len(globalSanitizers) > 0 {
313 ctx.ModuleErrorf("unknown global sanitizer option %s", globalSanitizers[0])
314 }
Ivan Lozano0c3a1ef2017-06-28 09:10:48 -0700315
Ivan Lozanoa9255a82018-03-13 10:41:07 -0700316 // Global integer_overflow builds do not support static library diagnostics.
Ivan Lozano0c3a1ef2017-06-28 09:10:48 -0700317 if found, globalSanitizersDiag = removeFromList("integer_overflow", globalSanitizersDiag); found &&
Ivan Lozanoa9255a82018-03-13 10:41:07 -0700318 s.Diag.Integer_overflow == nil && Bool(s.Integer_overflow) && !ctx.static() {
Ivan Lozano0c3a1ef2017-06-28 09:10:48 -0700319 s.Diag.Integer_overflow = boolPtr(true)
320 }
321
Vishwath Mohan1fa3ac52017-10-31 02:26:14 -0700322 if found, globalSanitizersDiag = removeFromList("cfi", globalSanitizersDiag); found &&
323 s.Diag.Cfi == nil && Bool(s.Cfi) {
324 s.Diag.Cfi = boolPtr(true)
325 }
326
Ivan Lozano0c3a1ef2017-06-28 09:10:48 -0700327 if len(globalSanitizersDiag) > 0 {
328 ctx.ModuleErrorf("unknown global sanitizer diagnostics option %s", globalSanitizersDiag[0])
329 }
Evgenii Stepanovfcfe56d2016-07-07 10:54:07 -0700330 }
Colin Cross3c344ef2016-07-18 15:44:56 -0700331
Vishwath Mohan1c54f662018-05-24 18:36:18 -0700332 // Enable CFI for all components in the include paths (for Aarch64 only)
333 if s.Cfi == nil && ctx.Config().CFIEnabledForPath(ctx.ModuleDir()) && ctx.Arch().ArchType == android.Arm64 {
Vishwath Mohan3af8ee02018-03-30 02:55:23 +0000334 s.Cfi = boolPtr(true)
335 if inList("cfi", ctx.Config().SanitizeDeviceDiag()) {
336 s.Diag.Cfi = boolPtr(true)
Vishwath Mohan1fa3ac52017-10-31 02:26:14 -0700337 }
338 }
339
Elliott Hughesda3a0712020-03-06 16:55:28 -0800340 // Is CFI actually enabled?
341 if !ctx.Config().EnableCFI() {
Inseob Kimc42f2f22020-07-29 20:32:10 +0900342 s.Cfi = boolPtr(false)
343 s.Diag.Cfi = boolPtr(false)
Vishwath Mohan1b017a72017-01-19 13:54:55 -0800344 }
345
Vishwath Mohan6d67e6e2017-02-07 20:31:41 -0800346 // Also disable CFI for arm32 until b/35157333 is fixed.
347 if ctx.Arch().ArchType == android.Arm {
Inseob Kimc42f2f22020-07-29 20:32:10 +0900348 s.Cfi = boolPtr(false)
349 s.Diag.Cfi = boolPtr(false)
Vishwath Mohan6d67e6e2017-02-07 20:31:41 -0800350 }
351
Evgenii Stepanovd97a6e92018-08-02 16:19:13 -0700352 // HWASan requires AArch64 hardware feature (top-byte-ignore).
353 if ctx.Arch().ArchType != android.Arm64 {
354 s.Hwaddress = nil
355 }
356
Peter Collingbourne8c7e6e22018-11-19 16:03:58 -0800357 // SCS is only implemented on AArch64.
Peter Collingbournebd19db02019-03-06 10:38:48 -0800358 if ctx.Arch().ArchType != android.Arm64 {
Peter Collingbourne8c7e6e22018-11-19 16:03:58 -0800359 s.Scs = nil
360 }
361
Vishwath Mohan8f4fdd82017-04-20 07:42:52 -0700362 // Also disable CFI if ASAN is enabled.
Evgenii Stepanovd97a6e92018-08-02 16:19:13 -0700363 if Bool(s.Address) || Bool(s.Hwaddress) {
Inseob Kimc42f2f22020-07-29 20:32:10 +0900364 s.Cfi = boolPtr(false)
365 s.Diag.Cfi = boolPtr(false)
Vishwath Mohan8f4fdd82017-04-20 07:42:52 -0700366 }
367
Ivan Lozano9ac32c72020-02-19 15:24:02 -0500368 // Disable sanitizers that depend on the UBSan runtime for windows/darwin builds.
369 if !ctx.Os().Linux() {
Inseob Kimc42f2f22020-07-29 20:32:10 +0900370 s.Cfi = boolPtr(false)
371 s.Diag.Cfi = boolPtr(false)
Ivan Lozanoa9255a82018-03-13 10:41:07 -0700372 s.Misc_undefined = nil
373 s.Undefined = nil
374 s.All_undefined = nil
375 s.Integer_overflow = nil
Vishwath Mohane7128792017-11-17 11:08:10 -0800376 }
377
Vishwath Mohan9ccbba02018-05-28 13:54:48 -0700378 // Also disable CFI for VNDK variants of components
379 if ctx.isVndk() && ctx.useVndk() {
Inseob Kimc42f2f22020-07-29 20:32:10 +0900380 if ctx.static() {
381 // Cfi variant for static vndk should be captured as vendor snapshot,
382 // so don't strictly disable Cfi.
383 s.Cfi = nil
384 s.Diag.Cfi = nil
385 } else {
386 s.Cfi = boolPtr(false)
387 s.Diag.Cfi = boolPtr(false)
388 }
Inseob Kimeec88e12020-01-22 11:11:29 +0900389 }
390
Evgenii Stepanovd97a6e92018-08-02 16:19:13 -0700391 // HWASan ramdisk (which is built from recovery) goes over some bootloader limit.
Yifan Hong60e0cfb2020-10-21 15:17:56 -0700392 // Keep libc instrumented so that ramdisk / vendor_ramdisk / recovery can run hwasan-instrumented code if necessary.
393 if (ctx.inRamdisk() || ctx.inVendorRamdisk() || ctx.inRecovery()) && !strings.HasPrefix(ctx.ModuleDir(), "bionic/libc") {
Evgenii Stepanovd97a6e92018-08-02 16:19:13 -0700394 s.Hwaddress = nil
395 }
396
Colin Cross3c344ef2016-07-18 15:44:56 -0700397 if ctx.staticBinary() {
398 s.Address = nil
Mitch Phillips5a6ea6c2019-05-01 14:42:05 -0700399 s.Fuzzer = nil
Colin Cross3c344ef2016-07-18 15:44:56 -0700400 s.Thread = nil
Colin Cross16b23492016-01-06 14:41:07 -0800401 }
402
Evgenii Stepanovfcfe56d2016-07-07 10:54:07 -0700403 if Bool(s.All_undefined) {
404 s.Undefined = nil
405 }
406
Evgenii Stepanov0a8a0d02016-05-12 13:54:53 -0700407 if !ctx.toolchain().Is64Bit() {
408 // TSAN and SafeStack are not supported on 32-bit architectures
Evgenii Stepanovfcfe56d2016-07-07 10:54:07 -0700409 s.Thread = nil
410 s.Safestack = nil
Colin Cross16b23492016-01-06 14:41:07 -0800411 // TODO(ccross): error for compile_multilib = "32"?
412 }
413
Evgenii Stepanov76cee232017-01-27 15:44:44 -0800414 if ctx.Os() != android.Windows && (Bool(s.All_undefined) || Bool(s.Undefined) || Bool(s.Address) || Bool(s.Thread) ||
Mitch Phillips5a6ea6c2019-05-01 14:42:05 -0700415 Bool(s.Fuzzer) || Bool(s.Safestack) || Bool(s.Cfi) || Bool(s.Integer_overflow) || len(s.Misc_undefined) > 0 ||
Peter Collingbourne8c7e6e22018-11-19 16:03:58 -0800416 Bool(s.Scudo) || Bool(s.Hwaddress) || Bool(s.Scs)) {
Colin Cross3c344ef2016-07-18 15:44:56 -0700417 sanitize.Properties.SanitizerEnabled = true
418 }
419
Kostya Kortchinskyd5275c82019-02-01 08:42:56 -0800420 // Disable Scudo if ASan or TSan is enabled, or if it's disabled globally.
421 if Bool(s.Address) || Bool(s.Thread) || Bool(s.Hwaddress) || ctx.Config().DisableScudo() {
Kostya Kortchinskyd18ae5c2018-06-12 14:46:54 -0700422 s.Scudo = nil
423 }
424
Evgenii Stepanovd97a6e92018-08-02 16:19:13 -0700425 if Bool(s.Hwaddress) {
426 s.Address = nil
427 s.Thread = nil
428 }
429
Mitch Phillips5a6ea6c2019-05-01 14:42:05 -0700430 // TODO(b/131771163): CFI transiently depends on LTO, and thus Fuzzer is
431 // mutually incompatible.
432 if Bool(s.Fuzzer) {
Inseob Kimc42f2f22020-07-29 20:32:10 +0900433 s.Cfi = boolPtr(false)
Colin Cross16b23492016-01-06 14:41:07 -0800434 }
435}
436
437func (sanitize *sanitize) deps(ctx BaseModuleContext, deps Deps) Deps {
438 if !sanitize.Properties.SanitizerEnabled { // || c.static() {
439 return deps
440 }
441
Colin Cross16b23492016-01-06 14:41:07 -0800442 return deps
443}
444
Chih-Hung Hsieh3567e622018-11-15 14:01:36 -0800445func toDisableImplicitIntegerChange(flags []string) bool {
446 // Returns true if any flag is fsanitize*integer, and there is
447 // no explicit flag about sanitize=implicit-integer-sign-change.
448 for _, f := range flags {
449 if strings.Contains(f, "sanitize=implicit-integer-sign-change") {
450 return false
451 }
452 }
453 for _, f := range flags {
454 if strings.HasPrefix(f, "-fsanitize") && strings.Contains(f, "integer") {
455 return true
456 }
457 }
458 return false
459}
460
Colin Cross16b23492016-01-06 14:41:07 -0800461func (sanitize *sanitize) flags(ctx ModuleContext, flags Flags) Flags {
Ivan Lozano59fdea22018-05-10 14:17:22 -0700462 minimalRuntimeLib := config.UndefinedBehaviorSanitizerMinimalRuntimeLibrary(ctx.toolchain()) + ".a"
463 minimalRuntimePath := "${config.ClangAsanLibDir}/" + minimalRuntimeLib
Ivan Lozano9ac32c72020-02-19 15:24:02 -0500464 builtinsRuntimeLib := config.BuiltinsRuntimeLibrary(ctx.toolchain()) + ".a"
465 builtinsRuntimePath := "${config.ClangAsanLibDir}/" + builtinsRuntimeLib
Ivan Lozano30c5db22018-02-21 15:49:20 -0800466
Ivan Lozano9ac32c72020-02-19 15:24:02 -0500467 if sanitize.Properties.MinimalRuntimeDep {
Colin Cross4af21ed2019-11-04 09:37:55 -0800468 flags.Local.LdFlags = append(flags.Local.LdFlags,
469 minimalRuntimePath,
470 "-Wl,--exclude-libs,"+minimalRuntimeLib)
Ivan Lozano30c5db22018-02-21 15:49:20 -0800471 }
Ivan Lozano9ac32c72020-02-19 15:24:02 -0500472
473 if sanitize.Properties.BuiltinsDep {
474 flags.libFlags = append([]string{builtinsRuntimePath}, flags.libFlags...)
475 }
476
Ivan Lozanoa9255a82018-03-13 10:41:07 -0700477 if !sanitize.Properties.SanitizerEnabled && !sanitize.Properties.UbsanRuntimeDep {
Colin Cross16b23492016-01-06 14:41:07 -0800478 return flags
479 }
480
Evgenii Stepanovfcfe56d2016-07-07 10:54:07 -0700481 if Bool(sanitize.Properties.Sanitize.Address) {
Colin Cross635c3b02016-05-18 15:37:25 -0700482 if ctx.Arch().ArchType == android.Arm {
Colin Cross16b23492016-01-06 14:41:07 -0800483 // Frame pointer based unwinder in ASan requires ARM frame setup.
484 // TODO: put in flags?
485 flags.RequiredInstructionSet = "arm"
486 }
Colin Cross4af21ed2019-11-04 09:37:55 -0800487 flags.Local.CFlags = append(flags.Local.CFlags, asanCflags...)
488 flags.Local.LdFlags = append(flags.Local.LdFlags, asanLdflags...)
Colin Cross16b23492016-01-06 14:41:07 -0800489
Jasraj Bedibb4511d2020-07-23 22:58:17 +0000490 if Bool(sanitize.Properties.Sanitize.Writeonly) {
491 flags.Local.CFlags = append(flags.Local.CFlags, "-mllvm", "-asan-instrument-reads=0")
492 }
493
Colin Cross16b23492016-01-06 14:41:07 -0800494 if ctx.Host() {
495 // -nodefaultlibs (provided with libc++) prevents the driver from linking
496 // libraries needed with -fsanitize=address. http://b/18650275 (WAI)
Colin Cross4af21ed2019-11-04 09:37:55 -0800497 flags.Local.LdFlags = append(flags.Local.LdFlags, "-Wl,--no-as-needed")
Colin Cross16b23492016-01-06 14:41:07 -0800498 } else {
Colin Cross4af21ed2019-11-04 09:37:55 -0800499 flags.Local.CFlags = append(flags.Local.CFlags, "-mllvm", "-asan-globals=0")
Jiyong Parka2aca282019-02-02 13:13:38 +0900500 if ctx.bootstrap() {
501 flags.DynamicLinker = "/system/bin/bootstrap/linker_asan"
502 } else {
503 flags.DynamicLinker = "/system/bin/linker_asan"
504 }
Colin Cross16b23492016-01-06 14:41:07 -0800505 if flags.Toolchain.Is64Bit() {
506 flags.DynamicLinker += "64"
507 }
508 }
Colin Cross16b23492016-01-06 14:41:07 -0800509 }
510
Evgenii Stepanovd97a6e92018-08-02 16:19:13 -0700511 if Bool(sanitize.Properties.Sanitize.Hwaddress) {
Colin Cross4af21ed2019-11-04 09:37:55 -0800512 flags.Local.CFlags = append(flags.Local.CFlags, hwasanCflags...)
Jasraj Bedibb4511d2020-07-23 22:58:17 +0000513 if Bool(sanitize.Properties.Sanitize.Writeonly) {
514 flags.Local.CFlags = append(flags.Local.CFlags, "-mllvm", "-hwasan-instrument-reads=0")
515 }
Yabin Cui6be405e2017-10-19 15:52:11 -0700516 }
517
Mitch Phillips5a6ea6c2019-05-01 14:42:05 -0700518 if Bool(sanitize.Properties.Sanitize.Fuzzer) {
Colin Cross4af21ed2019-11-04 09:37:55 -0800519 flags.Local.CFlags = append(flags.Local.CFlags, "-fsanitize=fuzzer-no-link")
Mitch Phillips5a6ea6c2019-05-01 14:42:05 -0700520
521 // TODO(b/131771163): LTO and Fuzzer support is mutually incompatible.
Colin Cross4af21ed2019-11-04 09:37:55 -0800522 _, flags.Local.LdFlags = removeFromList("-flto", flags.Local.LdFlags)
523 _, flags.Local.CFlags = removeFromList("-flto", flags.Local.CFlags)
524 flags.Local.LdFlags = append(flags.Local.LdFlags, "-fno-lto")
525 flags.Local.CFlags = append(flags.Local.CFlags, "-fno-lto")
Mitch Phillips74384752019-06-17 10:33:52 -0700526
Mitch Phillipsb8e593d2019-10-09 17:18:59 -0700527 // TODO(b/142430592): Upstream linker scripts for sanitizer runtime libraries
528 // discard the sancov_lowest_stack symbol, because it's emulated TLS (and thus
529 // doesn't match the linker script due to the "__emutls_v." prefix).
Colin Cross4af21ed2019-11-04 09:37:55 -0800530 flags.Local.LdFlags = append(flags.Local.LdFlags, "-fno-sanitize-coverage=stack-depth")
531 flags.Local.CFlags = append(flags.Local.CFlags, "-fno-sanitize-coverage=stack-depth")
Mitch Phillipsb8e593d2019-10-09 17:18:59 -0700532
Mitch Phillips74384752019-06-17 10:33:52 -0700533 // TODO(b/133876586): Experimental PM breaks sanitizer coverage.
Colin Cross4af21ed2019-11-04 09:37:55 -0800534 flags.Local.CFlags = append(flags.Local.CFlags, "-fno-experimental-new-pass-manager")
Mitch Phillipsb9b3e792019-08-28 12:41:07 -0700535
536 // Disable fortify for fuzzing builds. Generally, we'll be building with
537 // UBSan or ASan here and the fortify checks pollute the stack traces.
Colin Cross4af21ed2019-11-04 09:37:55 -0800538 flags.Local.CFlags = append(flags.Local.CFlags, "-U_FORTIFY_SOURCE")
Mitch Phillips734b4cb2019-12-10 08:44:52 -0800539
540 // Build fuzzer-sanitized libraries with an $ORIGIN DT_RUNPATH. Android's
541 // linker uses DT_RUNPATH, not DT_RPATH. When we deploy cc_fuzz targets and
542 // their libraries to /data/fuzz/<arch>/lib, any transient shared library gets
543 // the DT_RUNPATH from the shared library above it, and not the executable,
544 // meaning that the lookup falls back to the system. Adding the $ORIGIN to the
545 // DT_RUNPATH here means that transient shared libraries can be found
546 // colocated with their parents.
547 flags.Local.LdFlags = append(flags.Local.LdFlags, `-Wl,-rpath,\$$ORIGIN`)
Colin Cross16b23492016-01-06 14:41:07 -0800548 }
549
Evgenii Stepanov1e405e12016-08-16 15:39:54 -0700550 if Bool(sanitize.Properties.Sanitize.Cfi) {
Evgenii Stepanov7ebf9fa2017-01-20 14:13:06 -0800551 if ctx.Arch().ArchType == android.Arm {
552 // __cfi_check needs to be built as Thumb (see the code in linker_cfi.cpp). LLVM is not set up
553 // to do this on a function basis, so force Thumb on the entire module.
554 flags.RequiredInstructionSet = "thumb"
555 }
Vishwath Mohanb743e9c2017-11-01 09:20:21 +0000556
Colin Cross4af21ed2019-11-04 09:37:55 -0800557 flags.Local.CFlags = append(flags.Local.CFlags, cfiCflags...)
558 flags.Local.AsFlags = append(flags.Local.AsFlags, cfiAsflags...)
Cindy Zhou8cd45de2020-11-16 08:41:00 -0800559 if Bool(sanitize.Properties.Sanitize.Config.Cfi_assembly_support) {
560 flags.Local.CFlags = append(flags.Local.CFlags, "-fno-sanitize-cfi-canonical-jump-tables")
561 }
Vishwath Mohanb743e9c2017-11-01 09:20:21 +0000562 // Only append the default visibility flag if -fvisibility has not already been set
563 // to hidden.
Colin Cross4af21ed2019-11-04 09:37:55 -0800564 if !inList("-fvisibility=hidden", flags.Local.CFlags) {
565 flags.Local.CFlags = append(flags.Local.CFlags, "-fvisibility=default")
Vishwath Mohanb743e9c2017-11-01 09:20:21 +0000566 }
Colin Cross4af21ed2019-11-04 09:37:55 -0800567 flags.Local.LdFlags = append(flags.Local.LdFlags, cfiLdflags...)
Vishwath Mohanb743e9c2017-11-01 09:20:21 +0000568
569 if ctx.staticBinary() {
Colin Cross4af21ed2019-11-04 09:37:55 -0800570 _, flags.Local.CFlags = removeFromList("-fsanitize-cfi-cross-dso", flags.Local.CFlags)
571 _, flags.Local.LdFlags = removeFromList("-fsanitize-cfi-cross-dso", flags.Local.LdFlags)
Vishwath Mohanb743e9c2017-11-01 09:20:21 +0000572 }
Evgenii Stepanov1e405e12016-08-16 15:39:54 -0700573 }
574
Ivan Lozano0c3a1ef2017-06-28 09:10:48 -0700575 if Bool(sanitize.Properties.Sanitize.Integer_overflow) {
Colin Cross4af21ed2019-11-04 09:37:55 -0800576 flags.Local.CFlags = append(flags.Local.CFlags, intOverflowCflags...)
Ivan Lozano0c3a1ef2017-06-28 09:10:48 -0700577 }
578
Jiyong Park379de2f2018-12-19 02:47:14 +0900579 if len(sanitize.Properties.Sanitizers) > 0 {
580 sanitizeArg := "-fsanitize=" + strings.Join(sanitize.Properties.Sanitizers, ",")
Ivan Lozano30c5db22018-02-21 15:49:20 -0800581
Colin Cross4af21ed2019-11-04 09:37:55 -0800582 flags.Local.CFlags = append(flags.Local.CFlags, sanitizeArg)
583 flags.Local.AsFlags = append(flags.Local.AsFlags, sanitizeArg)
Colin Cross16b23492016-01-06 14:41:07 -0800584 if ctx.Host() {
Evgenii Stepanov76cee232017-01-27 15:44:44 -0800585 // Host sanitizers only link symbols in the final executable, so
586 // there will always be undefined symbols in intermediate libraries.
Colin Cross4af21ed2019-11-04 09:37:55 -0800587 _, flags.Global.LdFlags = removeFromList("-Wl,--no-undefined", flags.Global.LdFlags)
588 flags.Local.LdFlags = append(flags.Local.LdFlags, sanitizeArg)
Ivan Lozano9ac32c72020-02-19 15:24:02 -0500589
590 // non-Bionic toolchain prebuilts are missing UBSan's vptr and function sanitizers
591 if !ctx.toolchain().Bionic() {
592 flags.Local.CFlags = append(flags.Local.CFlags, "-fno-sanitize=vptr,function")
593 }
594 }
595
596 if enableMinimalRuntime(sanitize) {
597 flags.Local.CFlags = append(flags.Local.CFlags, strings.Join(minimalRuntimeFlags, " "))
598 flags.libFlags = append([]string{minimalRuntimePath}, flags.libFlags...)
599 flags.Local.LdFlags = append(flags.Local.LdFlags, "-Wl,--exclude-libs,"+minimalRuntimeLib)
600 if !ctx.toolchain().Bionic() {
601 flags.libFlags = append([]string{builtinsRuntimePath}, flags.libFlags...)
Ivan Lozano30c5db22018-02-21 15:49:20 -0800602 }
Colin Cross16b23492016-01-06 14:41:07 -0800603 }
Mitch Phillips5a6ea6c2019-05-01 14:42:05 -0700604
605 if Bool(sanitize.Properties.Sanitize.Fuzzer) {
606 // When fuzzing, we wish to crash with diagnostics on any bug.
Colin Cross4af21ed2019-11-04 09:37:55 -0800607 flags.Local.CFlags = append(flags.Local.CFlags, "-fno-sanitize-trap=all", "-fno-sanitize-recover=all")
Mitch Phillips5a6ea6c2019-05-01 14:42:05 -0700608 } else if ctx.Host() {
Colin Cross4af21ed2019-11-04 09:37:55 -0800609 flags.Local.CFlags = append(flags.Local.CFlags, "-fno-sanitize-recover=all")
Mitch Phillips5a6ea6c2019-05-01 14:42:05 -0700610 } else {
Colin Cross4af21ed2019-11-04 09:37:55 -0800611 flags.Local.CFlags = append(flags.Local.CFlags, "-fsanitize-trap=all", "-ftrap-function=abort")
Mitch Phillips5a6ea6c2019-05-01 14:42:05 -0700612 }
Chih-Hung Hsieh3567e622018-11-15 14:01:36 -0800613 // http://b/119329758, Android core does not boot up with this sanitizer yet.
Colin Cross4af21ed2019-11-04 09:37:55 -0800614 if toDisableImplicitIntegerChange(flags.Local.CFlags) {
615 flags.Local.CFlags = append(flags.Local.CFlags, "-fno-sanitize=implicit-integer-sign-change")
Chih-Hung Hsieh3567e622018-11-15 14:01:36 -0800616 }
Colin Cross16b23492016-01-06 14:41:07 -0800617 }
618
Jiyong Park379de2f2018-12-19 02:47:14 +0900619 if len(sanitize.Properties.DiagSanitizers) > 0 {
Colin Cross4af21ed2019-11-04 09:37:55 -0800620 flags.Local.CFlags = append(flags.Local.CFlags, "-fno-sanitize-trap="+strings.Join(sanitize.Properties.DiagSanitizers, ","))
Evgenii Stepanov1e405e12016-08-16 15:39:54 -0700621 }
622 // FIXME: enable RTTI if diag + (cfi or vptr)
623
Andreas Gampe97071162017-05-08 13:15:23 -0700624 if sanitize.Properties.Sanitize.Recover != nil {
Colin Cross4af21ed2019-11-04 09:37:55 -0800625 flags.Local.CFlags = append(flags.Local.CFlags, "-fsanitize-recover="+
Andreas Gampe97071162017-05-08 13:15:23 -0700626 strings.Join(sanitize.Properties.Sanitize.Recover, ","))
627 }
628
Ivan Lozano7929bba2018-12-12 09:36:31 -0800629 if sanitize.Properties.Sanitize.Diag.No_recover != nil {
Colin Cross4af21ed2019-11-04 09:37:55 -0800630 flags.Local.CFlags = append(flags.Local.CFlags, "-fno-sanitize-recover="+
Ivan Lozano7929bba2018-12-12 09:36:31 -0800631 strings.Join(sanitize.Properties.Sanitize.Diag.No_recover, ","))
632 }
633
Pirama Arumuga Nainar6c4ccca2020-07-27 11:49:51 -0700634 blocklist := android.OptionalPathForModuleSrc(ctx, sanitize.Properties.Sanitize.Blocklist)
635 if blocklist.Valid() {
636 flags.Local.CFlags = append(flags.Local.CFlags, "-fsanitize-blacklist="+blocklist.String())
637 flags.CFlagsDeps = append(flags.CFlagsDeps, blocklist.Path())
638 }
639
Colin Cross16b23492016-01-06 14:41:07 -0800640 return flags
641}
642
Colin Crossd80cbca2020-02-24 12:01:37 -0800643func (sanitize *sanitize) AndroidMkEntries(ctx AndroidMkContext, entries *android.AndroidMkEntries) {
Jiyong Park1d1119f2019-07-29 21:27:18 +0900644 // Add a suffix for cfi/hwasan/scs-enabled static/header libraries to allow surfacing
645 // both the sanitized and non-sanitized variants to make without a name conflict.
Colin Crossd80cbca2020-02-24 12:01:37 -0800646 if entries.Class == "STATIC_LIBRARIES" || entries.Class == "HEADER_LIBRARIES" {
Jiyong Park1d1119f2019-07-29 21:27:18 +0900647 if Bool(sanitize.Properties.Sanitize.Cfi) {
Colin Crossd80cbca2020-02-24 12:01:37 -0800648 entries.SubName += ".cfi"
Jiyong Park1d1119f2019-07-29 21:27:18 +0900649 }
650 if Bool(sanitize.Properties.Sanitize.Hwaddress) {
Colin Crossd80cbca2020-02-24 12:01:37 -0800651 entries.SubName += ".hwasan"
Jiyong Park1d1119f2019-07-29 21:27:18 +0900652 }
653 if Bool(sanitize.Properties.Sanitize.Scs) {
Colin Crossd80cbca2020-02-24 12:01:37 -0800654 entries.SubName += ".scs"
Jiyong Park1d1119f2019-07-29 21:27:18 +0900655 }
Peter Collingbourne8c7e6e22018-11-19 16:03:58 -0800656 }
Colin Cross8ff9ef42017-05-08 13:44:11 -0700657}
658
Vishwath Mohan1dd88392017-03-29 22:00:18 -0700659func (sanitize *sanitize) inSanitizerDir() bool {
660 return sanitize.Properties.InSanitizerDir
Colin Cross30d5f512016-05-03 18:02:42 -0700661}
662
Vishwath Mohanb743e9c2017-11-01 09:20:21 +0000663func (sanitize *sanitize) getSanitizerBoolPtr(t sanitizerType) *bool {
Vishwath Mohan95229302017-08-11 00:53:16 +0000664 switch t {
665 case asan:
Vishwath Mohanb743e9c2017-11-01 09:20:21 +0000666 return sanitize.Properties.Sanitize.Address
Evgenii Stepanovd97a6e92018-08-02 16:19:13 -0700667 case hwasan:
668 return sanitize.Properties.Sanitize.Hwaddress
Vishwath Mohan95229302017-08-11 00:53:16 +0000669 case tsan:
Vishwath Mohanb743e9c2017-11-01 09:20:21 +0000670 return sanitize.Properties.Sanitize.Thread
Vishwath Mohan95229302017-08-11 00:53:16 +0000671 case intOverflow:
Vishwath Mohanb743e9c2017-11-01 09:20:21 +0000672 return sanitize.Properties.Sanitize.Integer_overflow
673 case cfi:
674 return sanitize.Properties.Sanitize.Cfi
Peter Collingbourne8c7e6e22018-11-19 16:03:58 -0800675 case scs:
676 return sanitize.Properties.Sanitize.Scs
Mitch Phillips5a6ea6c2019-05-01 14:42:05 -0700677 case fuzzer:
678 return sanitize.Properties.Sanitize.Fuzzer
Vishwath Mohan95229302017-08-11 00:53:16 +0000679 default:
680 panic(fmt.Errorf("unknown sanitizerType %d", t))
681 }
682}
683
Dan Albert7d1eecf2018-01-19 12:30:45 -0800684func (sanitize *sanitize) isUnsanitizedVariant() bool {
685 return !sanitize.isSanitizerEnabled(asan) &&
Evgenii Stepanovd97a6e92018-08-02 16:19:13 -0700686 !sanitize.isSanitizerEnabled(hwasan) &&
Dan Albert7d1eecf2018-01-19 12:30:45 -0800687 !sanitize.isSanitizerEnabled(tsan) &&
Peter Collingbourne8c7e6e22018-11-19 16:03:58 -0800688 !sanitize.isSanitizerEnabled(cfi) &&
Mitch Phillips5a6ea6c2019-05-01 14:42:05 -0700689 !sanitize.isSanitizerEnabled(scs) &&
690 !sanitize.isSanitizerEnabled(fuzzer)
Dan Albert7d1eecf2018-01-19 12:30:45 -0800691}
692
Jayant Chowdharyb7e08ca2018-05-10 15:29:24 -0700693func (sanitize *sanitize) isVariantOnProductionDevice() bool {
694 return !sanitize.isSanitizerEnabled(asan) &&
Evgenii Stepanovd97a6e92018-08-02 16:19:13 -0700695 !sanitize.isSanitizerEnabled(hwasan) &&
Mitch Phillips5a6ea6c2019-05-01 14:42:05 -0700696 !sanitize.isSanitizerEnabled(tsan) &&
697 !sanitize.isSanitizerEnabled(fuzzer)
Jayant Chowdharyb7e08ca2018-05-10 15:29:24 -0700698}
699
Colin Cross16b23492016-01-06 14:41:07 -0800700func (sanitize *sanitize) SetSanitizer(t sanitizerType, b bool) {
701 switch t {
702 case asan:
Evgenii Stepanovfcfe56d2016-07-07 10:54:07 -0700703 sanitize.Properties.Sanitize.Address = boolPtr(b)
Evgenii Stepanovd97a6e92018-08-02 16:19:13 -0700704 case hwasan:
705 sanitize.Properties.Sanitize.Hwaddress = boolPtr(b)
Colin Cross16b23492016-01-06 14:41:07 -0800706 case tsan:
Evgenii Stepanovfcfe56d2016-07-07 10:54:07 -0700707 sanitize.Properties.Sanitize.Thread = boolPtr(b)
Ivan Lozano0c3a1ef2017-06-28 09:10:48 -0700708 case intOverflow:
709 sanitize.Properties.Sanitize.Integer_overflow = boolPtr(b)
Vishwath Mohanb743e9c2017-11-01 09:20:21 +0000710 case cfi:
711 sanitize.Properties.Sanitize.Cfi = boolPtr(b)
Peter Collingbourne8c7e6e22018-11-19 16:03:58 -0800712 case scs:
713 sanitize.Properties.Sanitize.Scs = boolPtr(b)
Mitch Phillips5a6ea6c2019-05-01 14:42:05 -0700714 case fuzzer:
715 sanitize.Properties.Sanitize.Fuzzer = boolPtr(b)
Colin Cross16b23492016-01-06 14:41:07 -0800716 default:
717 panic(fmt.Errorf("unknown sanitizerType %d", t))
718 }
719 if b {
720 sanitize.Properties.SanitizerEnabled = true
721 }
722}
723
Vishwath Mohanb743e9c2017-11-01 09:20:21 +0000724// Check if the sanitizer is explicitly disabled (as opposed to nil by
725// virtue of not being set).
726func (sanitize *sanitize) isSanitizerExplicitlyDisabled(t sanitizerType) bool {
727 if sanitize == nil {
728 return false
729 }
730
731 sanitizerVal := sanitize.getSanitizerBoolPtr(t)
732 return sanitizerVal != nil && *sanitizerVal == false
733}
734
735// There isn't an analog of the method above (ie:isSanitizerExplicitlyEnabled)
736// because enabling a sanitizer either directly (via the blueprint) or
737// indirectly (via a mutator) sets the bool ptr to true, and you can't
738// distinguish between the cases. It isn't needed though - both cases can be
739// treated identically.
740func (sanitize *sanitize) isSanitizerEnabled(t sanitizerType) bool {
741 if sanitize == nil {
742 return false
743 }
744
745 sanitizerVal := sanitize.getSanitizerBoolPtr(t)
746 return sanitizerVal != nil && *sanitizerVal == true
747}
748
Colin Cross6b753602018-06-21 13:03:07 -0700749func isSanitizableDependencyTag(tag blueprint.DependencyTag) bool {
Colin Cross6e511a92020-07-27 21:26:48 -0700750 switch t := tag.(type) {
751 case dependencyTag:
752 return t == reuseObjTag || t == objDepTag
753 case libraryDependencyTag:
754 return true
755 default:
756 return false
757 }
Colin Cross6b753602018-06-21 13:03:07 -0700758}
759
Inseob Kimc42f2f22020-07-29 20:32:10 +0900760// Determines if the current module is a static library going to be captured
761// as vendor snapshot. Such modules must create both cfi and non-cfi variants,
762// except for ones which explicitly disable cfi.
763func needsCfiForVendorSnapshot(mctx android.TopDownMutatorContext) bool {
Bill Peckham945441c2020-08-31 16:07:58 -0700764 if isVendorProprietaryModule(mctx) {
Inseob Kimc42f2f22020-07-29 20:32:10 +0900765 return false
766 }
767
768 c := mctx.Module().(*Module)
769
770 if !c.inVendor() {
771 return false
772 }
773
774 if !c.static() {
775 return false
776 }
777
778 if c.Prebuilt() != nil {
779 return false
780 }
781
782 return c.sanitize != nil &&
783 !Bool(c.sanitize.Properties.Sanitize.Never) &&
784 !c.sanitize.isSanitizerExplicitlyDisabled(cfi)
785}
786
Evgenii Stepanovd97a6e92018-08-02 16:19:13 -0700787// Propagate sanitizer requirements down from binaries
Colin Cross635c3b02016-05-18 15:37:25 -0700788func sanitizerDepsMutator(t sanitizerType) func(android.TopDownMutatorContext) {
789 return func(mctx android.TopDownMutatorContext) {
Inseob Kimc42f2f22020-07-29 20:32:10 +0900790 if c, ok := mctx.Module().(*Module); ok {
791 enabled := c.sanitize.isSanitizerEnabled(t)
792 if t == cfi && needsCfiForVendorSnapshot(mctx) {
793 // We shouldn't change the result of isSanitizerEnabled(cfi) to correctly
794 // determine defaultVariation in sanitizerMutator below.
795 // Instead, just mark SanitizeDep to forcefully create cfi variant.
796 enabled = true
797 c.sanitize.Properties.SanitizeDep = true
798 }
799 if enabled {
800 mctx.WalkDeps(func(child, parent android.Module) bool {
801 if !isSanitizableDependencyTag(mctx.OtherModuleDependencyTag(child)) {
802 return false
803 }
804 if d, ok := child.(*Module); ok && d.sanitize != nil &&
805 !Bool(d.sanitize.Properties.Sanitize.Never) &&
806 !d.sanitize.isSanitizerExplicitlyDisabled(t) {
807 if t == cfi || t == hwasan || t == scs {
808 if d.static() {
809 d.sanitize.Properties.SanitizeDep = true
810 }
811 } else {
Evgenii Stepanovd97a6e92018-08-02 16:19:13 -0700812 d.sanitize.Properties.SanitizeDep = true
813 }
Vishwath Mohanb743e9c2017-11-01 09:20:21 +0000814 }
Inseob Kimc42f2f22020-07-29 20:32:10 +0900815 return true
816 })
817 }
Jiyong Parkf97782b2019-02-13 20:28:58 +0900818 } else if sanitizeable, ok := mctx.Module().(Sanitizeable); ok {
819 // If an APEX module includes a lib which is enabled for a sanitizer T, then
820 // the APEX module is also enabled for the same sanitizer type.
821 mctx.VisitDirectDeps(func(child android.Module) {
822 if c, ok := child.(*Module); ok && c.sanitize.isSanitizerEnabled(t) {
823 sanitizeable.EnableSanitizer(t.name())
824 }
825 })
Colin Cross16b23492016-01-06 14:41:07 -0800826 }
827 }
828}
829
Ivan Lozano30c5db22018-02-21 15:49:20 -0800830// Propagate the ubsan minimal runtime dependency when there are integer overflow sanitized static dependencies.
Colin Cross6b753602018-06-21 13:03:07 -0700831func sanitizerRuntimeDepsMutator(mctx android.TopDownMutatorContext) {
832 if c, ok := mctx.Module().(*Module); ok && c.sanitize != nil {
833 mctx.WalkDeps(func(child, parent android.Module) bool {
834 if !isSanitizableDependencyTag(mctx.OtherModuleDependencyTag(child)) {
835 return false
836 }
Ivan Lozano30c5db22018-02-21 15:49:20 -0800837
Inseob Kimeec88e12020-01-22 11:11:29 +0900838 d, ok := child.(*Module)
839 if !ok || !d.static() {
840 return false
841 }
842 if d.sanitize != nil {
Colin Cross6b753602018-06-21 13:03:07 -0700843 if enableMinimalRuntime(d.sanitize) {
844 // If a static dependency is built with the minimal runtime,
845 // make sure we include the ubsan minimal runtime.
846 c.sanitize.Properties.MinimalRuntimeDep = true
Inseob Kim8471cda2019-11-15 09:59:12 +0900847 } else if enableUbsanRuntime(d.sanitize) {
Colin Cross6b753602018-06-21 13:03:07 -0700848 // If a static dependency runs with full ubsan diagnostics,
849 // make sure we include the ubsan runtime.
850 c.sanitize.Properties.UbsanRuntimeDep = true
Ivan Lozano30c5db22018-02-21 15:49:20 -0800851 }
Colin Cross0b908332019-06-19 23:00:20 -0700852
853 if c.sanitize.Properties.MinimalRuntimeDep &&
854 c.sanitize.Properties.UbsanRuntimeDep {
855 // both flags that this mutator might set are true, so don't bother recursing
856 return false
857 }
858
Ivan Lozano9ac32c72020-02-19 15:24:02 -0500859 if c.Os() == android.Linux {
860 c.sanitize.Properties.BuiltinsDep = true
861 }
862
Colin Cross0b908332019-06-19 23:00:20 -0700863 return true
Colin Cross6b753602018-06-21 13:03:07 -0700864 }
Inseob Kimeec88e12020-01-22 11:11:29 +0900865
Jose Galmesf7294582020-11-13 12:07:36 -0800866 if p, ok := d.linker.(*snapshotLibraryDecorator); ok {
Inseob Kimeec88e12020-01-22 11:11:29 +0900867 if Bool(p.properties.Sanitize_minimal_dep) {
868 c.sanitize.Properties.MinimalRuntimeDep = true
869 }
870 if Bool(p.properties.Sanitize_ubsan_dep) {
871 c.sanitize.Properties.UbsanRuntimeDep = true
872 }
873 }
874
875 return false
Colin Cross6b753602018-06-21 13:03:07 -0700876 })
Ivan Lozano30c5db22018-02-21 15:49:20 -0800877 }
878}
879
Jiyong Park379de2f2018-12-19 02:47:14 +0900880// Add the dependency to the runtime library for each of the sanitizer variants
881func sanitizerRuntimeMutator(mctx android.BottomUpMutatorContext) {
Jiyong Park379de2f2018-12-19 02:47:14 +0900882 if c, ok := mctx.Module().(*Module); ok && c.sanitize != nil {
Pirama Arumuga Nainar6aa21022019-01-25 00:20:35 +0000883 if !c.Enabled() {
884 return
885 }
Jiyong Park379de2f2018-12-19 02:47:14 +0900886 var sanitizers []string
887 var diagSanitizers []string
888
889 if Bool(c.sanitize.Properties.Sanitize.All_undefined) {
890 sanitizers = append(sanitizers, "undefined")
891 } else {
892 if Bool(c.sanitize.Properties.Sanitize.Undefined) {
893 sanitizers = append(sanitizers,
894 "bool",
895 "integer-divide-by-zero",
896 "return",
897 "returns-nonnull-attribute",
898 "shift-exponent",
899 "unreachable",
900 "vla-bound",
901 // TODO(danalbert): The following checks currently have compiler performance issues.
902 //"alignment",
903 //"bounds",
904 //"enum",
905 //"float-cast-overflow",
906 //"float-divide-by-zero",
907 //"nonnull-attribute",
908 //"null",
909 //"shift-base",
910 //"signed-integer-overflow",
911 // TODO(danalbert): Fix UB in libc++'s __tree so we can turn this on.
912 // https://llvm.org/PR19302
913 // http://reviews.llvm.org/D6974
914 // "object-size",
915 )
916 }
917 sanitizers = append(sanitizers, c.sanitize.Properties.Sanitize.Misc_undefined...)
918 }
919
920 if Bool(c.sanitize.Properties.Sanitize.Diag.Undefined) {
921 diagSanitizers = append(diagSanitizers, "undefined")
922 }
923
924 diagSanitizers = append(diagSanitizers, c.sanitize.Properties.Sanitize.Diag.Misc_undefined...)
925
926 if Bool(c.sanitize.Properties.Sanitize.Address) {
927 sanitizers = append(sanitizers, "address")
928 diagSanitizers = append(diagSanitizers, "address")
929 }
930
931 if Bool(c.sanitize.Properties.Sanitize.Hwaddress) {
932 sanitizers = append(sanitizers, "hwaddress")
933 }
934
935 if Bool(c.sanitize.Properties.Sanitize.Thread) {
936 sanitizers = append(sanitizers, "thread")
937 }
938
939 if Bool(c.sanitize.Properties.Sanitize.Safestack) {
940 sanitizers = append(sanitizers, "safe-stack")
941 }
942
943 if Bool(c.sanitize.Properties.Sanitize.Cfi) {
944 sanitizers = append(sanitizers, "cfi")
945
946 if Bool(c.sanitize.Properties.Sanitize.Diag.Cfi) {
947 diagSanitizers = append(diagSanitizers, "cfi")
948 }
949 }
950
951 if Bool(c.sanitize.Properties.Sanitize.Integer_overflow) {
952 sanitizers = append(sanitizers, "unsigned-integer-overflow")
953 sanitizers = append(sanitizers, "signed-integer-overflow")
954 if Bool(c.sanitize.Properties.Sanitize.Diag.Integer_overflow) {
955 diagSanitizers = append(diagSanitizers, "unsigned-integer-overflow")
956 diagSanitizers = append(diagSanitizers, "signed-integer-overflow")
957 }
958 }
959
960 if Bool(c.sanitize.Properties.Sanitize.Scudo) {
961 sanitizers = append(sanitizers, "scudo")
962 }
963
964 if Bool(c.sanitize.Properties.Sanitize.Scs) {
965 sanitizers = append(sanitizers, "shadow-call-stack")
966 }
967
Mitch Phillips5a6ea6c2019-05-01 14:42:05 -0700968 if Bool(c.sanitize.Properties.Sanitize.Fuzzer) {
969 sanitizers = append(sanitizers, "fuzzer-no-link")
970 }
971
Jiyong Park379de2f2018-12-19 02:47:14 +0900972 // Save the list of sanitizers. These will be used again when generating
973 // the build rules (for Cflags, etc.)
974 c.sanitize.Properties.Sanitizers = sanitizers
975 c.sanitize.Properties.DiagSanitizers = diagSanitizers
976
Ivan Lozanof3b190f2020-03-06 12:01:21 -0500977 // TODO(b/150822854) Hosts have a different default behavior and assume the runtime library is used.
978 if c.Host() {
979 diagSanitizers = sanitizers
980 }
981
Jiyong Park379de2f2018-12-19 02:47:14 +0900982 // Determine the runtime library required
983 runtimeLibrary := ""
Ryan Prichardb49fe1b2019-10-11 15:03:34 -0700984 var extraStaticDeps []string
Jiyong Park379de2f2018-12-19 02:47:14 +0900985 toolchain := c.toolchain(mctx)
986 if Bool(c.sanitize.Properties.Sanitize.Address) {
987 runtimeLibrary = config.AddressSanitizerRuntimeLibrary(toolchain)
988 } else if Bool(c.sanitize.Properties.Sanitize.Hwaddress) {
989 if c.staticBinary() {
990 runtimeLibrary = config.HWAddressSanitizerStaticLibrary(toolchain)
Ryan Prichardb49fe1b2019-10-11 15:03:34 -0700991 extraStaticDeps = []string{"libdl"}
Jiyong Park379de2f2018-12-19 02:47:14 +0900992 } else {
993 runtimeLibrary = config.HWAddressSanitizerRuntimeLibrary(toolchain)
994 }
995 } else if Bool(c.sanitize.Properties.Sanitize.Thread) {
996 runtimeLibrary = config.ThreadSanitizerRuntimeLibrary(toolchain)
997 } else if Bool(c.sanitize.Properties.Sanitize.Scudo) {
998 if len(diagSanitizers) == 0 && !c.sanitize.Properties.UbsanRuntimeDep {
999 runtimeLibrary = config.ScudoMinimalRuntimeLibrary(toolchain)
1000 } else {
1001 runtimeLibrary = config.ScudoRuntimeLibrary(toolchain)
1002 }
Mitch Phillipsb8e593d2019-10-09 17:18:59 -07001003 } else if len(diagSanitizers) > 0 || c.sanitize.Properties.UbsanRuntimeDep ||
Ivan Lozano9ac32c72020-02-19 15:24:02 -05001004 Bool(c.sanitize.Properties.Sanitize.Fuzzer) ||
1005 Bool(c.sanitize.Properties.Sanitize.Undefined) ||
1006 Bool(c.sanitize.Properties.Sanitize.All_undefined) {
Jiyong Park379de2f2018-12-19 02:47:14 +09001007 runtimeLibrary = config.UndefinedBehaviorSanitizerRuntimeLibrary(toolchain)
1008 }
1009
Ivan Lozano9ac32c72020-02-19 15:24:02 -05001010 if runtimeLibrary != "" && (toolchain.Bionic() || c.sanitize.Properties.UbsanRuntimeDep) {
1011 // UBSan is supported on non-bionic linux host builds as well
Jiyong Park379de2f2018-12-19 02:47:14 +09001012
1013 // Adding dependency to the runtime library. We are using *FarVariation*
1014 // because the runtime libraries themselves are not mutated by sanitizer
1015 // mutators and thus don't have sanitizer variants whereas this module
1016 // has been already mutated.
1017 //
1018 // Note that by adding dependency with {static|shared}DepTag, the lib is
1019 // added to libFlags and LOCAL_SHARED_LIBRARIES by cc.Module
1020 if c.staticBinary() {
Inseob Kimeec88e12020-01-22 11:11:29 +09001021 deps := append(extraStaticDeps, runtimeLibrary)
1022 // If we're using snapshots and in vendor, redirect to snapshot whenever possible
1023 if c.VndkVersion() == mctx.DeviceConfig().VndkVersion() {
1024 snapshots := vendorSnapshotStaticLibs(mctx.Config())
1025 for idx, dep := range deps {
1026 if lib, ok := snapshots.get(dep, mctx.Arch().ArchType); ok {
1027 deps[idx] = lib
1028 }
1029 }
1030 }
1031
Jiyong Park379de2f2018-12-19 02:47:14 +09001032 // static executable gets static runtime libs
Colin Cross6e511a92020-07-27 21:26:48 -07001033 depTag := libraryDependencyTag{Kind: staticLibraryDependency}
Colin Cross42507332020-08-21 16:15:23 -07001034 variations := append(mctx.Target().Variations(),
1035 blueprint.Variation{Mutator: "link", Variation: "static"})
1036 if c.Device() {
1037 variations = append(variations, c.ImageVariation())
1038 }
1039 mctx.AddFarVariationDependencies(variations, depTag, deps...)
Jiyong Park1d1119f2019-07-29 21:27:18 +09001040 } else if !c.static() && !c.header() {
Inseob Kimeec88e12020-01-22 11:11:29 +09001041 // If we're using snapshots and in vendor, redirect to snapshot whenever possible
1042 if c.VndkVersion() == mctx.DeviceConfig().VndkVersion() {
1043 snapshots := vendorSnapshotSharedLibs(mctx.Config())
1044 if lib, ok := snapshots.get(runtimeLibrary, mctx.Arch().ArchType); ok {
1045 runtimeLibrary = lib
1046 }
1047 }
Cindy Zhou18417cb2020-12-10 07:12:38 -08001048 // Skip apex dependency check for sharedLibraryDependency
1049 // when sanitizer diags are enabled. Skipping the check will allow
1050 // building with diag libraries without having to list the
1051 // dependency in Apex's allowed_deps file.
1052 diagEnabled := len(diagSanitizers) > 0
Jiyong Park3b1746a2019-01-29 11:15:04 +09001053 // dynamic executable and shared libs get shared runtime libs
Cindy Zhou18417cb2020-12-10 07:12:38 -08001054 depTag := libraryDependencyTag{
1055 Kind: sharedLibraryDependency,
1056 Order: earlyLibraryDependency,
1057
1058 skipApexAllowedDependenciesCheck: diagEnabled,
1059 }
Colin Cross42507332020-08-21 16:15:23 -07001060 variations := append(mctx.Target().Variations(),
1061 blueprint.Variation{Mutator: "link", Variation: "shared"})
1062 if c.Device() {
1063 variations = append(variations, c.ImageVariation())
1064 }
Colin Crosse7257d22020-09-24 09:56:18 -07001065 c.addSharedLibDependenciesWithVersions(mctx, variations, depTag, runtimeLibrary, "", true)
Jiyong Park379de2f2018-12-19 02:47:14 +09001066 }
1067 // static lib does not have dependency to the runtime library. The
1068 // dependency will be added to the executables or shared libs using
1069 // the static lib.
1070 }
1071 }
1072}
1073
1074type Sanitizeable interface {
1075 android.Module
Jiyong Park388ef3f2019-01-28 19:47:32 +09001076 IsSanitizerEnabled(ctx android.BaseModuleContext, sanitizerName string) bool
Jiyong Parkf97782b2019-02-13 20:28:58 +09001077 EnableSanitizer(sanitizerName string)
Jooyung Han8ce8db92020-05-15 19:05:05 +09001078 AddSanitizerDependencies(ctx android.BottomUpMutatorContext, sanitizerName string)
Jiyong Park379de2f2018-12-19 02:47:14 +09001079}
1080
Vishwath Mohanb743e9c2017-11-01 09:20:21 +00001081// Create sanitized variants for modules that need them
Colin Cross635c3b02016-05-18 15:37:25 -07001082func sanitizerMutator(t sanitizerType) func(android.BottomUpMutatorContext) {
1083 return func(mctx android.BottomUpMutatorContext) {
Vishwath Mohane6153452017-08-11 00:52:44 +00001084 if c, ok := mctx.Module().(*Module); ok && c.sanitize != nil {
Vishwath Mohanb743e9c2017-11-01 09:20:21 +00001085 if c.isDependencyRoot() && c.sanitize.isSanitizerEnabled(t) {
Jiyong Park82226632019-02-01 10:50:50 +09001086 modules := mctx.CreateVariations(t.variationName())
Colin Cross30d5f512016-05-03 18:02:42 -07001087 modules[0].(*Module).sanitize.SetSanitizer(t, true)
Vishwath Mohanb743e9c2017-11-01 09:20:21 +00001088 } else if c.sanitize.isSanitizerEnabled(t) || c.sanitize.Properties.SanitizeDep {
Vishwath Mohanb743e9c2017-11-01 09:20:21 +00001089 isSanitizerEnabled := c.sanitize.isSanitizerEnabled(t)
Jiyong Park1d1119f2019-07-29 21:27:18 +09001090 if c.static() || c.header() || t == asan || t == fuzzer {
1091 // Static and header libs are split into non-sanitized and sanitized variants.
1092 // Shared libs are not split. However, for asan and fuzzer, we split even for shared
1093 // libs because a library sanitized for asan/fuzzer can't be linked from a library
1094 // that isn't sanitized for asan/fuzzer.
1095 //
1096 // Note for defaultVariation: since we don't split for shared libs but for static/header
1097 // libs, it is possible for the sanitized variant of a static/header lib to depend
1098 // on non-sanitized variant of a shared lib. Such unfulfilled variation causes an
1099 // error when the module is split. defaultVariation is the name of the variation that
1100 // will be used when such a dangling dependency occurs during the split of the current
1101 // module. By setting it to the name of the sanitized variation, the dangling dependency
1102 // is redirected to the sanitized variant of the dependent module.
1103 defaultVariation := t.variationName()
1104 mctx.SetDefaultDependencyVariation(&defaultVariation)
1105 modules := mctx.CreateVariations("", t.variationName())
1106 modules[0].(*Module).sanitize.SetSanitizer(t, false)
1107 modules[1].(*Module).sanitize.SetSanitizer(t, true)
1108 modules[0].(*Module).sanitize.Properties.SanitizeDep = false
1109 modules[1].(*Module).sanitize.Properties.SanitizeDep = false
Vishwath Mohanb743e9c2017-11-01 09:20:21 +00001110
Ivan Lozano4774a812020-03-10 16:23:57 -04001111 if mctx.Device() && t.incompatibleWithCfi() {
1112 // TODO: Make sure that cfi mutator runs "after" any of the sanitizers that
1113 // are incompatible with cfi
1114 modules[1].(*Module).sanitize.SetSanitizer(cfi, false)
1115 }
1116
Jiyong Park1d1119f2019-07-29 21:27:18 +09001117 // For cfi/scs/hwasan, we can export both sanitized and un-sanitized variants
1118 // to Make, because the sanitized version has a different suffix in name.
1119 // For other types of sanitizers, suppress the variation that is disabled.
1120 if t != cfi && t != scs && t != hwasan {
1121 if isSanitizerEnabled {
1122 modules[0].(*Module).Properties.PreventInstall = true
1123 modules[0].(*Module).Properties.HideFromMake = true
1124 } else {
1125 modules[1].(*Module).Properties.PreventInstall = true
1126 modules[1].(*Module).Properties.HideFromMake = true
1127 }
1128 }
Vishwath Mohanb743e9c2017-11-01 09:20:21 +00001129
Jiyong Park1d1119f2019-07-29 21:27:18 +09001130 // Export the static lib name to make
Dan Willemsenb5b2aba2020-05-03 21:28:32 -07001131 if c.static() && c.ExportedToMake() {
Jiyong Park1d1119f2019-07-29 21:27:18 +09001132 if t == cfi {
Inseob Kim74d25562020-08-04 00:41:38 +09001133 cfiStaticLibs(mctx.Config()).add(c, c.Name())
Jiyong Park1d1119f2019-07-29 21:27:18 +09001134 } else if t == hwasan {
Inseob Kim74d25562020-08-04 00:41:38 +09001135 hwasanStaticLibs(mctx.Config()).add(c, c.Name())
Jiyong Park1d1119f2019-07-29 21:27:18 +09001136 }
1137 }
1138 } else {
1139 // Shared libs are not split. Only the sanitized variant is created.
1140 modules := mctx.CreateVariations(t.variationName())
1141 modules[0].(*Module).sanitize.SetSanitizer(t, true)
1142 modules[0].(*Module).sanitize.Properties.SanitizeDep = false
Vishwath Mohane7128792017-11-17 11:08:10 -08001143
Jiyong Park1d1119f2019-07-29 21:27:18 +09001144 // locate the asan libraries under /data/asan
1145 if mctx.Device() && t == asan && isSanitizerEnabled {
1146 modules[0].(*Module).sanitize.Properties.InSanitizerDir = true
Evgenii Stepanovd97a6e92018-08-02 16:19:13 -07001147 }
Ivan Lozano4774a812020-03-10 16:23:57 -04001148
1149 if mctx.Device() && t.incompatibleWithCfi() {
1150 // TODO: Make sure that cfi mutator runs "after" any of the sanitizers that
1151 // are incompatible with cfi
1152 modules[0].(*Module).sanitize.SetSanitizer(cfi, false)
1153 }
Vishwath Mohane21fe422017-11-01 19:42:45 -07001154 }
Colin Cross16b23492016-01-06 14:41:07 -08001155 }
1156 c.sanitize.Properties.SanitizeDep = false
Jiyong Park82226632019-02-01 10:50:50 +09001157 } else if sanitizeable, ok := mctx.Module().(Sanitizeable); ok && sanitizeable.IsSanitizerEnabled(mctx, t.name()) {
Jiyong Park379de2f2018-12-19 02:47:14 +09001158 // APEX modules fall here
Jooyung Han8ce8db92020-05-15 19:05:05 +09001159 sanitizeable.AddSanitizerDependencies(mctx, t.name())
Jiyong Park82226632019-02-01 10:50:50 +09001160 mctx.CreateVariations(t.variationName())
Inseob Kimc42f2f22020-07-29 20:32:10 +09001161 } else if c, ok := mctx.Module().(*Module); ok {
1162 // Check if it's a snapshot module supporting sanitizer
1163 if s, ok := c.linker.(snapshotSanitizer); ok && s.isSanitizerEnabled(t) {
1164 // Set default variation as above.
1165 defaultVariation := t.variationName()
1166 mctx.SetDefaultDependencyVariation(&defaultVariation)
1167 modules := mctx.CreateVariations("", t.variationName())
1168 modules[0].(*Module).linker.(snapshotSanitizer).setSanitizerVariation(t, false)
1169 modules[1].(*Module).linker.(snapshotSanitizer).setSanitizerVariation(t, true)
1170
1171 // Export the static lib name to make
1172 if c.static() && c.ExportedToMake() {
1173 if t == cfi {
1174 // use BaseModuleName which is the name for Make.
1175 cfiStaticLibs(mctx.Config()).add(c, c.BaseModuleName())
1176 }
1177 }
1178 }
Colin Cross16b23492016-01-06 14:41:07 -08001179 }
1180 }
1181}
Vishwath Mohane7128792017-11-17 11:08:10 -08001182
Inseob Kim74d25562020-08-04 00:41:38 +09001183type sanitizerStaticLibsMap struct {
1184 // libsMap contains one list of modules per each image and each arch.
1185 // e.g. libs[vendor]["arm"] contains arm modules installed to vendor
1186 libsMap map[imageVariantType]map[string][]string
1187 libsMapLock sync.Mutex
1188 sanitizerType sanitizerType
1189}
1190
1191func newSanitizerStaticLibsMap(t sanitizerType) *sanitizerStaticLibsMap {
1192 return &sanitizerStaticLibsMap{
1193 sanitizerType: t,
1194 libsMap: make(map[imageVariantType]map[string][]string),
1195 }
1196}
1197
1198// Add the current module to sanitizer static libs maps
1199// Each module should pass its exported name as names of Make and Soong can differ.
1200func (s *sanitizerStaticLibsMap) add(c *Module, name string) {
1201 image := c.getImageVariantType()
1202 arch := c.Arch().ArchType.String()
1203
1204 s.libsMapLock.Lock()
1205 defer s.libsMapLock.Unlock()
1206
1207 if _, ok := s.libsMap[image]; !ok {
1208 s.libsMap[image] = make(map[string][]string)
1209 }
1210
1211 s.libsMap[image][arch] = append(s.libsMap[image][arch], name)
1212}
1213
1214// Exports makefile variables in the following format:
1215// SOONG_{sanitizer}_{image}_{arch}_STATIC_LIBRARIES
1216// e.g. SOONG_cfi_core_x86_STATIC_LIBRARIES
1217// These are to be used by use_soong_sanitized_static_libraries.
1218// See build/make/core/binary.mk for more details.
1219func (s *sanitizerStaticLibsMap) exportToMake(ctx android.MakeVarsContext) {
1220 for _, image := range android.SortedStringKeys(s.libsMap) {
1221 archMap := s.libsMap[imageVariantType(image)]
1222 for _, arch := range android.SortedStringKeys(archMap) {
1223 libs := archMap[arch]
1224 sort.Strings(libs)
1225
1226 key := fmt.Sprintf(
1227 "SOONG_%s_%s_%s_STATIC_LIBRARIES",
1228 s.sanitizerType.variationName(),
1229 image, // already upper
1230 arch)
1231
1232 ctx.Strict(key, strings.Join(libs, " "))
1233 }
1234 }
1235}
1236
Colin Cross571cccf2019-02-04 11:22:08 -08001237var cfiStaticLibsKey = android.NewOnceKey("cfiStaticLibs")
1238
Inseob Kim74d25562020-08-04 00:41:38 +09001239func cfiStaticLibs(config android.Config) *sanitizerStaticLibsMap {
Colin Cross571cccf2019-02-04 11:22:08 -08001240 return config.Once(cfiStaticLibsKey, func() interface{} {
Inseob Kim74d25562020-08-04 00:41:38 +09001241 return newSanitizerStaticLibsMap(cfi)
1242 }).(*sanitizerStaticLibsMap)
Vishwath Mohane7128792017-11-17 11:08:10 -08001243}
1244
Colin Cross571cccf2019-02-04 11:22:08 -08001245var hwasanStaticLibsKey = android.NewOnceKey("hwasanStaticLibs")
1246
Inseob Kim74d25562020-08-04 00:41:38 +09001247func hwasanStaticLibs(config android.Config) *sanitizerStaticLibsMap {
Colin Cross571cccf2019-02-04 11:22:08 -08001248 return config.Once(hwasanStaticLibsKey, func() interface{} {
Inseob Kim74d25562020-08-04 00:41:38 +09001249 return newSanitizerStaticLibsMap(hwasan)
1250 }).(*sanitizerStaticLibsMap)
Jiyong Park1d1119f2019-07-29 21:27:18 +09001251}
1252
Ivan Lozano30c5db22018-02-21 15:49:20 -08001253func enableMinimalRuntime(sanitize *sanitize) bool {
1254 if !Bool(sanitize.Properties.Sanitize.Address) &&
Evgenii Stepanovd97a6e92018-08-02 16:19:13 -07001255 !Bool(sanitize.Properties.Sanitize.Hwaddress) &&
Mitch Phillips5a6ea6c2019-05-01 14:42:05 -07001256 !Bool(sanitize.Properties.Sanitize.Fuzzer) &&
Ivan Lozano9ac32c72020-02-19 15:24:02 -05001257
Ivan Lozano30c5db22018-02-21 15:49:20 -08001258 (Bool(sanitize.Properties.Sanitize.Integer_overflow) ||
Ivan Lozano9ac32c72020-02-19 15:24:02 -05001259 len(sanitize.Properties.Sanitize.Misc_undefined) > 0 ||
1260 Bool(sanitize.Properties.Sanitize.Undefined) ||
1261 Bool(sanitize.Properties.Sanitize.All_undefined)) &&
1262
Ivan Lozano30c5db22018-02-21 15:49:20 -08001263 !(Bool(sanitize.Properties.Sanitize.Diag.Integer_overflow) ||
1264 Bool(sanitize.Properties.Sanitize.Diag.Cfi) ||
Ivan Lozano9ac32c72020-02-19 15:24:02 -05001265 Bool(sanitize.Properties.Sanitize.Diag.Undefined) ||
Ivan Lozano30c5db22018-02-21 15:49:20 -08001266 len(sanitize.Properties.Sanitize.Diag.Misc_undefined) > 0) {
Ivan Lozano9ac32c72020-02-19 15:24:02 -05001267
Ivan Lozano30c5db22018-02-21 15:49:20 -08001268 return true
1269 }
1270 return false
1271}
1272
Inseob Kim8471cda2019-11-15 09:59:12 +09001273func enableUbsanRuntime(sanitize *sanitize) bool {
1274 return Bool(sanitize.Properties.Sanitize.Diag.Integer_overflow) ||
Ivan Lozano9ac32c72020-02-19 15:24:02 -05001275 Bool(sanitize.Properties.Sanitize.Diag.Undefined) ||
Inseob Kim8471cda2019-11-15 09:59:12 +09001276 len(sanitize.Properties.Sanitize.Diag.Misc_undefined) > 0
1277}
1278
Vishwath Mohane7128792017-11-17 11:08:10 -08001279func cfiMakeVarsProvider(ctx android.MakeVarsContext) {
Inseob Kim74d25562020-08-04 00:41:38 +09001280 cfiStaticLibs(ctx.Config()).exportToMake(ctx)
Vishwath Mohane7128792017-11-17 11:08:10 -08001281}
Evgenii Stepanovd97a6e92018-08-02 16:19:13 -07001282
1283func hwasanMakeVarsProvider(ctx android.MakeVarsContext) {
Inseob Kim74d25562020-08-04 00:41:38 +09001284 hwasanStaticLibs(ctx.Config()).exportToMake(ctx)
Evgenii Stepanovd97a6e92018-08-02 16:19:13 -07001285}