blob: 25dcafe52ae6df74d0e118a1c6315b3df2cf28f7 [file] [log] [blame]
Colin Cross16b23492016-01-06 14:41:07 -08001// Copyright 2016 Google Inc. All rights reserved.
2//
3// Licensed under the Apache License, Version 2.0 (the "License");
4// you may not use this file except in compliance with the License.
5// You may obtain a copy of the License at
6//
7// http://www.apache.org/licenses/LICENSE-2.0
8//
9// Unless required by applicable law or agreed to in writing, software
10// distributed under the License is distributed on an "AS IS" BASIS,
11// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
12// See the License for the specific language governing permissions and
13// limitations under the License.
14
15package cc
16
17import (
18 "fmt"
Jeff Gaston72765392017-11-28 16:37:53 -080019 "sort"
Colin Cross16b23492016-01-06 14:41:07 -080020 "strings"
Vishwath Mohane7128792017-11-17 11:08:10 -080021 "sync"
Colin Cross16b23492016-01-06 14:41:07 -080022
Colin Cross6b753602018-06-21 13:03:07 -070023 "github.com/google/blueprint"
24
Colin Cross635c3b02016-05-18 15:37:25 -070025 "android/soong/android"
Evgenii Stepanovaf36db12016-08-15 14:18:24 -070026 "android/soong/cc/config"
Colin Cross16b23492016-01-06 14:41:07 -080027)
28
Jayant Chowdhary9677e8c2017-06-15 14:45:18 -070029var (
30 // Any C flags added by sanitizer which libTooling tools may not
31 // understand also need to be added to ClangLibToolingUnknownCflags in
32 // cc/config/clang.go
Vishwath Mohanf3918d32017-02-14 07:59:33 -080033
Yi Kong20233a42019-08-21 01:38:40 -070034 asanCflags = []string{
35 "-fno-omit-frame-pointer",
36 "-fno-experimental-new-pass-manager",
37 }
Jayant Chowdhary9677e8c2017-06-15 14:45:18 -070038 asanLdflags = []string{"-Wl,-u,__asan_preinit"}
Jayant Chowdhary9677e8c2017-06-15 14:45:18 -070039
Peter Collingbourne967511a2019-03-19 21:39:54 -070040 hwasanCflags = []string{"-fno-omit-frame-pointer", "-Wno-frame-larger-than=",
Evgenii Stepanov1c69e832019-06-14 18:37:33 -070041 "-fsanitize-hwaddress-abi=platform",
Evgenii Stepanov64bee4d2019-11-22 18:37:10 -080042 "-fno-experimental-new-pass-manager",
43 // The following improves debug location information
44 // availability at the cost of its accuracy. It increases
45 // the likelihood of a stack variable's frame offset
46 // to be recorded in the debug info, which is important
47 // for the quality of hwasan reports. The downside is a
48 // higher number of "optimized out" stack variables.
49 // b/112437883.
50 "-mllvm", "-instcombine-lower-dbg-declare=0",
51 }
Evgenii Stepanovd97a6e92018-08-02 16:19:13 -070052
Vishwath Mohanb743e9c2017-11-01 09:20:21 +000053 cfiCflags = []string{"-flto", "-fsanitize-cfi-cross-dso",
Jayant Chowdhary9677e8c2017-06-15 14:45:18 -070054 "-fsanitize-blacklist=external/compiler-rt/lib/cfi/cfi_blacklist.txt"}
Evgenii Stepanovdbf1d4f2018-08-31 12:54:33 -070055 // -flto and -fvisibility are required by clang when -fsanitize=cfi is
56 // used, but have no effect on assembly files
57 cfiAsflags = []string{"-flto", "-fvisibility=default"}
Jayant Chowdhary9677e8c2017-06-15 14:45:18 -070058 cfiLdflags = []string{"-flto", "-fsanitize-cfi-cross-dso", "-fsanitize=cfi",
Pirama Arumuga Nainarbdb17f02017-08-28 21:50:17 -070059 "-Wl,-plugin-opt,O1"}
Evgenii Stepanovd97a6e92018-08-02 16:19:13 -070060 cfiExportsMapPath = "build/soong/cc/config/cfi_exports.map"
61 cfiStaticLibsMutex sync.Mutex
62 hwasanStaticLibsMutex sync.Mutex
Ivan Lozano0c3a1ef2017-06-28 09:10:48 -070063
Evgenii Stepanov98f5b062018-11-29 15:12:51 -080064 intOverflowCflags = []string{"-fsanitize-blacklist=build/soong/cc/config/integer_overflow_blacklist.txt"}
Peter Collingbourne8c7e6e22018-11-19 16:03:58 -080065
Peter Collingbournebd19db02019-03-06 10:38:48 -080066 minimalRuntimeFlags = []string{"-fsanitize-minimal-runtime", "-fno-sanitize-trap=integer,undefined",
Ivan Lozanoae6ae1d2018-10-08 09:29:39 -070067 "-fno-sanitize-recover=integer,undefined"}
Evgenii Stepanov2c6484e2019-05-15 12:49:54 -070068 hwasanGlobalOptions = []string{"heap_history_size=1023", "stack_history_size=512",
69 "export_memory_stats=0", "max_malloc_fill_size=0"}
Dan Willemsencbceaab2016-10-13 16:44:07 -070070)
71
Colin Cross16b23492016-01-06 14:41:07 -080072type sanitizerType int
73
Evgenii Stepanovfcfe56d2016-07-07 10:54:07 -070074func boolPtr(v bool) *bool {
75 if v {
76 return &v
77 } else {
78 return nil
79 }
80}
81
Colin Cross16b23492016-01-06 14:41:07 -080082const (
83 asan sanitizerType = iota + 1
Evgenii Stepanovd97a6e92018-08-02 16:19:13 -070084 hwasan
Colin Cross16b23492016-01-06 14:41:07 -080085 tsan
Ivan Lozano0c3a1ef2017-06-28 09:10:48 -070086 intOverflow
Vishwath Mohanb743e9c2017-11-01 09:20:21 +000087 cfi
Peter Collingbourne8c7e6e22018-11-19 16:03:58 -080088 scs
Mitch Phillips5a6ea6c2019-05-01 14:42:05 -070089 fuzzer
Colin Cross16b23492016-01-06 14:41:07 -080090)
91
Jiyong Park82226632019-02-01 10:50:50 +090092// Name of the sanitizer variation for this sanitizer type
93func (t sanitizerType) variationName() string {
Colin Cross16b23492016-01-06 14:41:07 -080094 switch t {
95 case asan:
96 return "asan"
Evgenii Stepanovd97a6e92018-08-02 16:19:13 -070097 case hwasan:
98 return "hwasan"
Colin Cross16b23492016-01-06 14:41:07 -080099 case tsan:
100 return "tsan"
Ivan Lozano0c3a1ef2017-06-28 09:10:48 -0700101 case intOverflow:
102 return "intOverflow"
Vishwath Mohanb743e9c2017-11-01 09:20:21 +0000103 case cfi:
104 return "cfi"
Peter Collingbourne8c7e6e22018-11-19 16:03:58 -0800105 case scs:
106 return "scs"
Mitch Phillips5a6ea6c2019-05-01 14:42:05 -0700107 case fuzzer:
108 return "fuzzer"
Colin Cross16b23492016-01-06 14:41:07 -0800109 default:
110 panic(fmt.Errorf("unknown sanitizerType %d", t))
111 }
112}
113
Jiyong Park82226632019-02-01 10:50:50 +0900114// This is the sanitizer names in SANITIZE_[TARGET|HOST]
115func (t sanitizerType) name() string {
116 switch t {
117 case asan:
118 return "address"
119 case hwasan:
120 return "hwaddress"
121 case tsan:
122 return "thread"
123 case intOverflow:
124 return "integer_overflow"
125 case cfi:
126 return "cfi"
127 case scs:
128 return "shadow-call-stack"
Mitch Phillips5a6ea6c2019-05-01 14:42:05 -0700129 case fuzzer:
130 return "fuzzer"
Jiyong Park82226632019-02-01 10:50:50 +0900131 default:
132 panic(fmt.Errorf("unknown sanitizerType %d", t))
133 }
134}
135
Jiyong Park1d1119f2019-07-29 21:27:18 +0900136func (t sanitizerType) incompatibleWithCfi() bool {
137 return t == asan || t == fuzzer || t == hwasan
138}
139
Colin Cross16b23492016-01-06 14:41:07 -0800140type SanitizeProperties struct {
141 // enable AddressSanitizer, ThreadSanitizer, or UndefinedBehaviorSanitizer
142 Sanitize struct {
Nan Zhang0007d812017-11-07 10:57:05 -0800143 Never *bool `android:"arch_variant"`
Colin Cross16b23492016-01-06 14:41:07 -0800144
145 // main sanitizers
Evgenii Stepanovd97a6e92018-08-02 16:19:13 -0700146 Address *bool `android:"arch_variant"`
147 Thread *bool `android:"arch_variant"`
148 Hwaddress *bool `android:"arch_variant"`
Colin Cross16b23492016-01-06 14:41:07 -0800149
150 // local sanitizers
Ivan Lozano0c3a1ef2017-06-28 09:10:48 -0700151 Undefined *bool `android:"arch_variant"`
152 All_undefined *bool `android:"arch_variant"`
153 Misc_undefined []string `android:"arch_variant"`
Mitch Phillips5a6ea6c2019-05-01 14:42:05 -0700154 Fuzzer *bool `android:"arch_variant"`
Ivan Lozano0c3a1ef2017-06-28 09:10:48 -0700155 Safestack *bool `android:"arch_variant"`
156 Cfi *bool `android:"arch_variant"`
157 Integer_overflow *bool `android:"arch_variant"`
Kostya Kortchinskyd18ae5c2018-06-12 14:46:54 -0700158 Scudo *bool `android:"arch_variant"`
Peter Collingbourne8c7e6e22018-11-19 16:03:58 -0800159 Scs *bool `android:"arch_variant"`
Colin Cross16b23492016-01-06 14:41:07 -0800160
Evgenii Stepanov1e405e12016-08-16 15:39:54 -0700161 // Sanitizers to run in the diagnostic mode (as opposed to the release mode).
162 // Replaces abort() on error with a human-readable error message.
163 // Address and Thread sanitizers always run in diagnostic mode.
164 Diag struct {
Ivan Lozano0c3a1ef2017-06-28 09:10:48 -0700165 Undefined *bool `android:"arch_variant"`
166 Cfi *bool `android:"arch_variant"`
167 Integer_overflow *bool `android:"arch_variant"`
168 Misc_undefined []string `android:"arch_variant"`
Ivan Lozano7929bba2018-12-12 09:36:31 -0800169 No_recover []string
Evgenii Stepanov1e405e12016-08-16 15:39:54 -0700170 }
171
172 // value to pass to -fsanitize-recover=
Colin Cross16b23492016-01-06 14:41:07 -0800173 Recover []string
174
175 // value to pass to -fsanitize-blacklist
176 Blacklist *string
177 } `android:"arch_variant"`
178
Jiyong Park379de2f2018-12-19 02:47:14 +0900179 SanitizerEnabled bool `blueprint:"mutated"`
180 SanitizeDep bool `blueprint:"mutated"`
181 MinimalRuntimeDep bool `blueprint:"mutated"`
182 UbsanRuntimeDep bool `blueprint:"mutated"`
183 InSanitizerDir bool `blueprint:"mutated"`
184 Sanitizers []string `blueprint:"mutated"`
185 DiagSanitizers []string `blueprint:"mutated"`
Colin Cross16b23492016-01-06 14:41:07 -0800186}
187
188type sanitize struct {
189 Properties SanitizeProperties
190}
191
Vishwath Mohane7128792017-11-17 11:08:10 -0800192func init() {
193 android.RegisterMakeVarsProvider(pctx, cfiMakeVarsProvider)
Evgenii Stepanovd97a6e92018-08-02 16:19:13 -0700194 android.RegisterMakeVarsProvider(pctx, hwasanMakeVarsProvider)
Vishwath Mohane7128792017-11-17 11:08:10 -0800195}
196
Colin Cross16b23492016-01-06 14:41:07 -0800197func (sanitize *sanitize) props() []interface{} {
198 return []interface{}{&sanitize.Properties}
199}
200
201func (sanitize *sanitize) begin(ctx BaseModuleContext) {
Evgenii Stepanovfcfe56d2016-07-07 10:54:07 -0700202 s := &sanitize.Properties.Sanitize
203
Colin Cross16b23492016-01-06 14:41:07 -0800204 // Don't apply sanitizers to NDK code.
Jeff Gastonaf3cc2d2017-09-27 17:01:44 -0700205 if ctx.useSdk() {
Nan Zhang0007d812017-11-07 10:57:05 -0800206 s.Never = BoolPtr(true)
Colin Cross16b23492016-01-06 14:41:07 -0800207 }
208
Doug Hornc32c6b02019-01-17 14:44:05 -0800209 // Sanitizers do not work on Fuchsia yet.
210 if ctx.Fuchsia() {
211 s.Never = BoolPtr(true)
212 }
213
Colin Cross16b23492016-01-06 14:41:07 -0800214 // Never always wins.
Nan Zhang0007d812017-11-07 10:57:05 -0800215 if Bool(s.Never) {
Colin Cross16b23492016-01-06 14:41:07 -0800216 return
217 }
218
Colin Cross16b23492016-01-06 14:41:07 -0800219 var globalSanitizers []string
Ivan Lozano0c3a1ef2017-06-28 09:10:48 -0700220 var globalSanitizersDiag []string
221
Dan Willemsen8536d6b2018-10-07 20:54:34 -0700222 if ctx.Host() {
223 if !ctx.Windows() {
224 globalSanitizers = ctx.Config().SanitizeHost()
225 }
226 } else {
227 arches := ctx.Config().SanitizeDeviceArch()
228 if len(arches) == 0 || inList(ctx.Arch().ArchType.Name, arches) {
229 globalSanitizers = ctx.Config().SanitizeDevice()
230 globalSanitizersDiag = ctx.Config().SanitizeDeviceDiag()
Colin Cross16b23492016-01-06 14:41:07 -0800231 }
232 }
233
Colin Cross16b23492016-01-06 14:41:07 -0800234 if len(globalSanitizers) > 0 {
Evgenii Stepanov05bafd32016-07-07 17:38:41 +0000235 var found bool
Evgenii Stepanovfcfe56d2016-07-07 10:54:07 -0700236 if found, globalSanitizers = removeFromList("undefined", globalSanitizers); found && s.All_undefined == nil {
237 s.All_undefined = boolPtr(true)
Evgenii Stepanov05bafd32016-07-07 17:38:41 +0000238 }
Colin Cross16b23492016-01-06 14:41:07 -0800239
Evgenii Stepanovfcfe56d2016-07-07 10:54:07 -0700240 if found, globalSanitizers = removeFromList("default-ub", globalSanitizers); found && s.Undefined == nil {
241 s.Undefined = boolPtr(true)
Evgenii Stepanov05bafd32016-07-07 17:38:41 +0000242 }
243
Mitch Phillips5a6ea6c2019-05-01 14:42:05 -0700244 if found, globalSanitizers = removeFromList("address", globalSanitizers); found && s.Address == nil {
245 s.Address = boolPtr(true)
Evgenii Stepanov05bafd32016-07-07 17:38:41 +0000246 }
247
Evgenii Stepanovfcfe56d2016-07-07 10:54:07 -0700248 if found, globalSanitizers = removeFromList("thread", globalSanitizers); found && s.Thread == nil {
249 s.Thread = boolPtr(true)
Evgenii Stepanov05bafd32016-07-07 17:38:41 +0000250 }
251
Mitch Phillips5a6ea6c2019-05-01 14:42:05 -0700252 if found, globalSanitizers = removeFromList("fuzzer", globalSanitizers); found && s.Fuzzer == nil {
253 s.Fuzzer = boolPtr(true)
Evgenii Stepanovfcfe56d2016-07-07 10:54:07 -0700254 }
255
256 if found, globalSanitizers = removeFromList("safe-stack", globalSanitizers); found && s.Safestack == nil {
257 s.Safestack = boolPtr(true)
Evgenii Stepanov05bafd32016-07-07 17:38:41 +0000258 }
259
Evgenii Stepanov1e405e12016-08-16 15:39:54 -0700260 if found, globalSanitizers = removeFromList("cfi", globalSanitizers); found && s.Cfi == nil {
Colin Cross6510f912017-11-29 00:27:14 -0800261 if !ctx.Config().CFIDisabledForPath(ctx.ModuleDir()) {
Vishwath Mohan1fa3ac52017-10-31 02:26:14 -0700262 s.Cfi = boolPtr(true)
263 }
Evgenii Stepanov1e405e12016-08-16 15:39:54 -0700264 }
265
Ivan Lozanoa9255a82018-03-13 10:41:07 -0700266 // Global integer_overflow builds do not support static libraries.
Ivan Lozano0c3a1ef2017-06-28 09:10:48 -0700267 if found, globalSanitizers = removeFromList("integer_overflow", globalSanitizers); found && s.Integer_overflow == nil {
Ivan Lozanoa9255a82018-03-13 10:41:07 -0700268 if !ctx.Config().IntegerOverflowDisabledForPath(ctx.ModuleDir()) && !ctx.static() {
Ivan Lozano5f595532017-07-13 14:46:05 -0700269 s.Integer_overflow = boolPtr(true)
270 }
Ivan Lozano0c3a1ef2017-06-28 09:10:48 -0700271 }
272
Kostya Kortchinskyd18ae5c2018-06-12 14:46:54 -0700273 if found, globalSanitizers = removeFromList("scudo", globalSanitizers); found && s.Scudo == nil {
274 s.Scudo = boolPtr(true)
275 }
276
Evgenii Stepanovd97a6e92018-08-02 16:19:13 -0700277 if found, globalSanitizers = removeFromList("hwaddress", globalSanitizers); found && s.Hwaddress == nil {
278 s.Hwaddress = boolPtr(true)
279 }
280
Evgenii Stepanov05bafd32016-07-07 17:38:41 +0000281 if len(globalSanitizers) > 0 {
282 ctx.ModuleErrorf("unknown global sanitizer option %s", globalSanitizers[0])
283 }
Ivan Lozano0c3a1ef2017-06-28 09:10:48 -0700284
Ivan Lozanoa9255a82018-03-13 10:41:07 -0700285 // Global integer_overflow builds do not support static library diagnostics.
Ivan Lozano0c3a1ef2017-06-28 09:10:48 -0700286 if found, globalSanitizersDiag = removeFromList("integer_overflow", globalSanitizersDiag); found &&
Ivan Lozanoa9255a82018-03-13 10:41:07 -0700287 s.Diag.Integer_overflow == nil && Bool(s.Integer_overflow) && !ctx.static() {
Ivan Lozano0c3a1ef2017-06-28 09:10:48 -0700288 s.Diag.Integer_overflow = boolPtr(true)
289 }
290
Vishwath Mohan1fa3ac52017-10-31 02:26:14 -0700291 if found, globalSanitizersDiag = removeFromList("cfi", globalSanitizersDiag); found &&
292 s.Diag.Cfi == nil && Bool(s.Cfi) {
293 s.Diag.Cfi = boolPtr(true)
294 }
295
Ivan Lozano0c3a1ef2017-06-28 09:10:48 -0700296 if len(globalSanitizersDiag) > 0 {
297 ctx.ModuleErrorf("unknown global sanitizer diagnostics option %s", globalSanitizersDiag[0])
298 }
Evgenii Stepanovfcfe56d2016-07-07 10:54:07 -0700299 }
Colin Cross3c344ef2016-07-18 15:44:56 -0700300
Vishwath Mohan1c54f662018-05-24 18:36:18 -0700301 // Enable CFI for all components in the include paths (for Aarch64 only)
302 if s.Cfi == nil && ctx.Config().CFIEnabledForPath(ctx.ModuleDir()) && ctx.Arch().ArchType == android.Arm64 {
Vishwath Mohan3af8ee02018-03-30 02:55:23 +0000303 s.Cfi = boolPtr(true)
304 if inList("cfi", ctx.Config().SanitizeDeviceDiag()) {
305 s.Diag.Cfi = boolPtr(true)
Vishwath Mohan1fa3ac52017-10-31 02:26:14 -0700306 }
307 }
308
Evgenii Stepanova83fdac2017-01-31 18:37:30 -0800309 // CFI needs gold linker, and mips toolchain does not have one.
Colin Cross6510f912017-11-29 00:27:14 -0800310 if !ctx.Config().EnableCFI() || ctx.Arch().ArchType == android.Mips || ctx.Arch().ArchType == android.Mips64 {
Vishwath Mohan1b017a72017-01-19 13:54:55 -0800311 s.Cfi = nil
312 s.Diag.Cfi = nil
313 }
314
Vishwath Mohan6d67e6e2017-02-07 20:31:41 -0800315 // Also disable CFI for arm32 until b/35157333 is fixed.
316 if ctx.Arch().ArchType == android.Arm {
317 s.Cfi = nil
318 s.Diag.Cfi = nil
319 }
320
Evgenii Stepanovd97a6e92018-08-02 16:19:13 -0700321 // HWASan requires AArch64 hardware feature (top-byte-ignore).
322 if ctx.Arch().ArchType != android.Arm64 {
323 s.Hwaddress = nil
324 }
325
Peter Collingbourne8c7e6e22018-11-19 16:03:58 -0800326 // SCS is only implemented on AArch64.
Peter Collingbournebd19db02019-03-06 10:38:48 -0800327 if ctx.Arch().ArchType != android.Arm64 {
Peter Collingbourne8c7e6e22018-11-19 16:03:58 -0800328 s.Scs = nil
329 }
330
Vishwath Mohan8f4fdd82017-04-20 07:42:52 -0700331 // Also disable CFI if ASAN is enabled.
Evgenii Stepanovd97a6e92018-08-02 16:19:13 -0700332 if Bool(s.Address) || Bool(s.Hwaddress) {
Vishwath Mohan8f4fdd82017-04-20 07:42:52 -0700333 s.Cfi = nil
334 s.Diag.Cfi = nil
335 }
336
Ivan Lozanoa9255a82018-03-13 10:41:07 -0700337 // Disable sanitizers that depend on the UBSan runtime for host builds.
Vishwath Mohane7128792017-11-17 11:08:10 -0800338 if ctx.Host() {
339 s.Cfi = nil
340 s.Diag.Cfi = nil
Ivan Lozanoa9255a82018-03-13 10:41:07 -0700341 s.Misc_undefined = nil
342 s.Undefined = nil
343 s.All_undefined = nil
344 s.Integer_overflow = nil
Vishwath Mohane7128792017-11-17 11:08:10 -0800345 }
346
Vishwath Mohan9ccbba02018-05-28 13:54:48 -0700347 // Also disable CFI for VNDK variants of components
348 if ctx.isVndk() && ctx.useVndk() {
Vishwath Mohan7589c822018-05-23 19:29:55 -0700349 s.Cfi = nil
350 s.Diag.Cfi = nil
351 }
352
Evgenii Stepanovd97a6e92018-08-02 16:19:13 -0700353 // HWASan ramdisk (which is built from recovery) goes over some bootloader limit.
Evgenii Stepanov1e798442018-11-15 17:34:18 -0800354 // Keep libc instrumented so that recovery can run hwasan-instrumented code if necessary.
355 if ctx.inRecovery() && !strings.HasPrefix(ctx.ModuleDir(), "bionic/libc") {
Evgenii Stepanovd97a6e92018-08-02 16:19:13 -0700356 s.Hwaddress = nil
357 }
358
Colin Cross3c344ef2016-07-18 15:44:56 -0700359 if ctx.staticBinary() {
360 s.Address = nil
Mitch Phillips5a6ea6c2019-05-01 14:42:05 -0700361 s.Fuzzer = nil
Colin Cross3c344ef2016-07-18 15:44:56 -0700362 s.Thread = nil
Colin Cross16b23492016-01-06 14:41:07 -0800363 }
364
Evgenii Stepanovfcfe56d2016-07-07 10:54:07 -0700365 if Bool(s.All_undefined) {
366 s.Undefined = nil
367 }
368
Evgenii Stepanov0a8a0d02016-05-12 13:54:53 -0700369 if !ctx.toolchain().Is64Bit() {
370 // TSAN and SafeStack are not supported on 32-bit architectures
Evgenii Stepanovfcfe56d2016-07-07 10:54:07 -0700371 s.Thread = nil
372 s.Safestack = nil
Colin Cross16b23492016-01-06 14:41:07 -0800373 // TODO(ccross): error for compile_multilib = "32"?
374 }
375
Evgenii Stepanov76cee232017-01-27 15:44:44 -0800376 if ctx.Os() != android.Windows && (Bool(s.All_undefined) || Bool(s.Undefined) || Bool(s.Address) || Bool(s.Thread) ||
Mitch Phillips5a6ea6c2019-05-01 14:42:05 -0700377 Bool(s.Fuzzer) || Bool(s.Safestack) || Bool(s.Cfi) || Bool(s.Integer_overflow) || len(s.Misc_undefined) > 0 ||
Peter Collingbourne8c7e6e22018-11-19 16:03:58 -0800378 Bool(s.Scudo) || Bool(s.Hwaddress) || Bool(s.Scs)) {
Colin Cross3c344ef2016-07-18 15:44:56 -0700379 sanitize.Properties.SanitizerEnabled = true
380 }
381
Kostya Kortchinskyd5275c82019-02-01 08:42:56 -0800382 // Disable Scudo if ASan or TSan is enabled, or if it's disabled globally.
383 if Bool(s.Address) || Bool(s.Thread) || Bool(s.Hwaddress) || ctx.Config().DisableScudo() {
Kostya Kortchinskyd18ae5c2018-06-12 14:46:54 -0700384 s.Scudo = nil
385 }
386
Evgenii Stepanovd97a6e92018-08-02 16:19:13 -0700387 if Bool(s.Hwaddress) {
388 s.Address = nil
389 s.Thread = nil
390 }
391
Mitch Phillips5a6ea6c2019-05-01 14:42:05 -0700392 // TODO(b/131771163): CFI transiently depends on LTO, and thus Fuzzer is
393 // mutually incompatible.
394 if Bool(s.Fuzzer) {
395 s.Cfi = nil
Colin Cross16b23492016-01-06 14:41:07 -0800396 }
397}
398
399func (sanitize *sanitize) deps(ctx BaseModuleContext, deps Deps) Deps {
400 if !sanitize.Properties.SanitizerEnabled { // || c.static() {
401 return deps
402 }
403
404 if ctx.Device() {
Evgenii Stepanovfcfe56d2016-07-07 10:54:07 -0700405 if Bool(sanitize.Properties.Sanitize.Address) {
Christopher Ferris753d4a62019-05-09 13:27:02 -0700406 // Compiling asan and having libc_scudo in the same
407 // executable will cause the executable to crash.
408 // Remove libc_scudo since it is only used to override
409 // allocation functions which asan already overrides.
410 _, deps.SharedLibs = removeFromList("libc_scudo", deps.SharedLibs)
Colin Cross16b23492016-01-06 14:41:07 -0800411 }
412 }
413
414 return deps
415}
416
Chih-Hung Hsieh3567e622018-11-15 14:01:36 -0800417func toDisableImplicitIntegerChange(flags []string) bool {
418 // Returns true if any flag is fsanitize*integer, and there is
419 // no explicit flag about sanitize=implicit-integer-sign-change.
420 for _, f := range flags {
421 if strings.Contains(f, "sanitize=implicit-integer-sign-change") {
422 return false
423 }
424 }
425 for _, f := range flags {
426 if strings.HasPrefix(f, "-fsanitize") && strings.Contains(f, "integer") {
427 return true
428 }
429 }
430 return false
431}
432
Colin Cross16b23492016-01-06 14:41:07 -0800433func (sanitize *sanitize) flags(ctx ModuleContext, flags Flags) Flags {
Ivan Lozano59fdea22018-05-10 14:17:22 -0700434 minimalRuntimeLib := config.UndefinedBehaviorSanitizerMinimalRuntimeLibrary(ctx.toolchain()) + ".a"
435 minimalRuntimePath := "${config.ClangAsanLibDir}/" + minimalRuntimeLib
Ivan Lozano30c5db22018-02-21 15:49:20 -0800436
437 if ctx.Device() && sanitize.Properties.MinimalRuntimeDep {
Colin Cross4af21ed2019-11-04 09:37:55 -0800438 flags.Local.LdFlags = append(flags.Local.LdFlags,
439 minimalRuntimePath,
440 "-Wl,--exclude-libs,"+minimalRuntimeLib)
Ivan Lozano30c5db22018-02-21 15:49:20 -0800441 }
Ivan Lozanoa9255a82018-03-13 10:41:07 -0700442 if !sanitize.Properties.SanitizerEnabled && !sanitize.Properties.UbsanRuntimeDep {
Colin Cross16b23492016-01-06 14:41:07 -0800443 return flags
444 }
445
Evgenii Stepanovfcfe56d2016-07-07 10:54:07 -0700446 if Bool(sanitize.Properties.Sanitize.Address) {
Colin Cross635c3b02016-05-18 15:37:25 -0700447 if ctx.Arch().ArchType == android.Arm {
Colin Cross16b23492016-01-06 14:41:07 -0800448 // Frame pointer based unwinder in ASan requires ARM frame setup.
449 // TODO: put in flags?
450 flags.RequiredInstructionSet = "arm"
451 }
Colin Cross4af21ed2019-11-04 09:37:55 -0800452 flags.Local.CFlags = append(flags.Local.CFlags, asanCflags...)
453 flags.Local.LdFlags = append(flags.Local.LdFlags, asanLdflags...)
Colin Cross16b23492016-01-06 14:41:07 -0800454
Colin Cross16b23492016-01-06 14:41:07 -0800455 if ctx.Host() {
456 // -nodefaultlibs (provided with libc++) prevents the driver from linking
457 // libraries needed with -fsanitize=address. http://b/18650275 (WAI)
Colin Cross4af21ed2019-11-04 09:37:55 -0800458 flags.Local.LdFlags = append(flags.Local.LdFlags, "-Wl,--no-as-needed")
Colin Cross16b23492016-01-06 14:41:07 -0800459 } else {
Colin Cross4af21ed2019-11-04 09:37:55 -0800460 flags.Local.CFlags = append(flags.Local.CFlags, "-mllvm", "-asan-globals=0")
Jiyong Parka2aca282019-02-02 13:13:38 +0900461 if ctx.bootstrap() {
462 flags.DynamicLinker = "/system/bin/bootstrap/linker_asan"
463 } else {
464 flags.DynamicLinker = "/system/bin/linker_asan"
465 }
Colin Cross16b23492016-01-06 14:41:07 -0800466 if flags.Toolchain.Is64Bit() {
467 flags.DynamicLinker += "64"
468 }
469 }
Colin Cross16b23492016-01-06 14:41:07 -0800470 }
471
Evgenii Stepanovd97a6e92018-08-02 16:19:13 -0700472 if Bool(sanitize.Properties.Sanitize.Hwaddress) {
Colin Cross4af21ed2019-11-04 09:37:55 -0800473 flags.Local.CFlags = append(flags.Local.CFlags, hwasanCflags...)
Yabin Cui6be405e2017-10-19 15:52:11 -0700474 }
475
Mitch Phillips5a6ea6c2019-05-01 14:42:05 -0700476 if Bool(sanitize.Properties.Sanitize.Fuzzer) {
Colin Cross4af21ed2019-11-04 09:37:55 -0800477 flags.Local.CFlags = append(flags.Local.CFlags, "-fsanitize=fuzzer-no-link")
Mitch Phillips5a6ea6c2019-05-01 14:42:05 -0700478
479 // TODO(b/131771163): LTO and Fuzzer support is mutually incompatible.
Colin Cross4af21ed2019-11-04 09:37:55 -0800480 _, flags.Local.LdFlags = removeFromList("-flto", flags.Local.LdFlags)
481 _, flags.Local.CFlags = removeFromList("-flto", flags.Local.CFlags)
482 flags.Local.LdFlags = append(flags.Local.LdFlags, "-fno-lto")
483 flags.Local.CFlags = append(flags.Local.CFlags, "-fno-lto")
Mitch Phillips74384752019-06-17 10:33:52 -0700484
Mitch Phillipsb8e593d2019-10-09 17:18:59 -0700485 // TODO(b/142430592): Upstream linker scripts for sanitizer runtime libraries
486 // discard the sancov_lowest_stack symbol, because it's emulated TLS (and thus
487 // doesn't match the linker script due to the "__emutls_v." prefix).
Colin Cross4af21ed2019-11-04 09:37:55 -0800488 flags.Local.LdFlags = append(flags.Local.LdFlags, "-fno-sanitize-coverage=stack-depth")
489 flags.Local.CFlags = append(flags.Local.CFlags, "-fno-sanitize-coverage=stack-depth")
Mitch Phillipsb8e593d2019-10-09 17:18:59 -0700490
Mitch Phillips74384752019-06-17 10:33:52 -0700491 // TODO(b/133876586): Experimental PM breaks sanitizer coverage.
Colin Cross4af21ed2019-11-04 09:37:55 -0800492 flags.Local.CFlags = append(flags.Local.CFlags, "-fno-experimental-new-pass-manager")
Mitch Phillipsb9b3e792019-08-28 12:41:07 -0700493
494 // Disable fortify for fuzzing builds. Generally, we'll be building with
495 // UBSan or ASan here and the fortify checks pollute the stack traces.
Colin Cross4af21ed2019-11-04 09:37:55 -0800496 flags.Local.CFlags = append(flags.Local.CFlags, "-U_FORTIFY_SOURCE")
Colin Cross16b23492016-01-06 14:41:07 -0800497 }
498
Evgenii Stepanov1e405e12016-08-16 15:39:54 -0700499 if Bool(sanitize.Properties.Sanitize.Cfi) {
Evgenii Stepanov7ebf9fa2017-01-20 14:13:06 -0800500 if ctx.Arch().ArchType == android.Arm {
501 // __cfi_check needs to be built as Thumb (see the code in linker_cfi.cpp). LLVM is not set up
502 // to do this on a function basis, so force Thumb on the entire module.
503 flags.RequiredInstructionSet = "thumb"
504 }
Vishwath Mohanb743e9c2017-11-01 09:20:21 +0000505
Colin Cross4af21ed2019-11-04 09:37:55 -0800506 flags.Local.CFlags = append(flags.Local.CFlags, cfiCflags...)
507 flags.Local.AsFlags = append(flags.Local.AsFlags, cfiAsflags...)
Vishwath Mohanb743e9c2017-11-01 09:20:21 +0000508 // Only append the default visibility flag if -fvisibility has not already been set
509 // to hidden.
Colin Cross4af21ed2019-11-04 09:37:55 -0800510 if !inList("-fvisibility=hidden", flags.Local.CFlags) {
511 flags.Local.CFlags = append(flags.Local.CFlags, "-fvisibility=default")
Vishwath Mohanb743e9c2017-11-01 09:20:21 +0000512 }
Colin Cross4af21ed2019-11-04 09:37:55 -0800513 flags.Local.LdFlags = append(flags.Local.LdFlags, cfiLdflags...)
Vishwath Mohanb743e9c2017-11-01 09:20:21 +0000514
515 if ctx.staticBinary() {
Colin Cross4af21ed2019-11-04 09:37:55 -0800516 _, flags.Local.CFlags = removeFromList("-fsanitize-cfi-cross-dso", flags.Local.CFlags)
517 _, flags.Local.LdFlags = removeFromList("-fsanitize-cfi-cross-dso", flags.Local.LdFlags)
Vishwath Mohanb743e9c2017-11-01 09:20:21 +0000518 }
Evgenii Stepanov1e405e12016-08-16 15:39:54 -0700519 }
520
Ivan Lozano0c3a1ef2017-06-28 09:10:48 -0700521 if Bool(sanitize.Properties.Sanitize.Integer_overflow) {
Colin Cross4af21ed2019-11-04 09:37:55 -0800522 flags.Local.CFlags = append(flags.Local.CFlags, intOverflowCflags...)
Ivan Lozano0c3a1ef2017-06-28 09:10:48 -0700523 }
524
Jiyong Park379de2f2018-12-19 02:47:14 +0900525 if len(sanitize.Properties.Sanitizers) > 0 {
526 sanitizeArg := "-fsanitize=" + strings.Join(sanitize.Properties.Sanitizers, ",")
Ivan Lozano30c5db22018-02-21 15:49:20 -0800527
Colin Cross4af21ed2019-11-04 09:37:55 -0800528 flags.Local.CFlags = append(flags.Local.CFlags, sanitizeArg)
529 flags.Local.AsFlags = append(flags.Local.AsFlags, sanitizeArg)
Colin Cross16b23492016-01-06 14:41:07 -0800530 if ctx.Host() {
Evgenii Stepanov76cee232017-01-27 15:44:44 -0800531 // Host sanitizers only link symbols in the final executable, so
532 // there will always be undefined symbols in intermediate libraries.
Colin Cross4af21ed2019-11-04 09:37:55 -0800533 _, flags.Global.LdFlags = removeFromList("-Wl,--no-undefined", flags.Global.LdFlags)
534 flags.Local.LdFlags = append(flags.Local.LdFlags, sanitizeArg)
Colin Cross16b23492016-01-06 14:41:07 -0800535 } else {
Ivan Lozano30c5db22018-02-21 15:49:20 -0800536 if enableMinimalRuntime(sanitize) {
Colin Cross4af21ed2019-11-04 09:37:55 -0800537 flags.Local.CFlags = append(flags.Local.CFlags, strings.Join(minimalRuntimeFlags, " "))
Ivan Lozano30c5db22018-02-21 15:49:20 -0800538 flags.libFlags = append([]string{minimalRuntimePath}, flags.libFlags...)
Colin Cross4af21ed2019-11-04 09:37:55 -0800539 flags.Local.LdFlags = append(flags.Local.LdFlags, "-Wl,--exclude-libs,"+minimalRuntimeLib)
Ivan Lozano30c5db22018-02-21 15:49:20 -0800540 }
Colin Cross16b23492016-01-06 14:41:07 -0800541 }
Mitch Phillips5a6ea6c2019-05-01 14:42:05 -0700542
543 if Bool(sanitize.Properties.Sanitize.Fuzzer) {
544 // When fuzzing, we wish to crash with diagnostics on any bug.
Colin Cross4af21ed2019-11-04 09:37:55 -0800545 flags.Local.CFlags = append(flags.Local.CFlags, "-fno-sanitize-trap=all", "-fno-sanitize-recover=all")
Mitch Phillips5a6ea6c2019-05-01 14:42:05 -0700546 } else if ctx.Host() {
Colin Cross4af21ed2019-11-04 09:37:55 -0800547 flags.Local.CFlags = append(flags.Local.CFlags, "-fno-sanitize-recover=all")
Mitch Phillips5a6ea6c2019-05-01 14:42:05 -0700548 } else {
Colin Cross4af21ed2019-11-04 09:37:55 -0800549 flags.Local.CFlags = append(flags.Local.CFlags, "-fsanitize-trap=all", "-ftrap-function=abort")
Mitch Phillips5a6ea6c2019-05-01 14:42:05 -0700550 }
Chih-Hung Hsieh3567e622018-11-15 14:01:36 -0800551 // http://b/119329758, Android core does not boot up with this sanitizer yet.
Colin Cross4af21ed2019-11-04 09:37:55 -0800552 if toDisableImplicitIntegerChange(flags.Local.CFlags) {
553 flags.Local.CFlags = append(flags.Local.CFlags, "-fno-sanitize=implicit-integer-sign-change")
Chih-Hung Hsieh3567e622018-11-15 14:01:36 -0800554 }
Colin Cross16b23492016-01-06 14:41:07 -0800555 }
556
Jiyong Park379de2f2018-12-19 02:47:14 +0900557 if len(sanitize.Properties.DiagSanitizers) > 0 {
Colin Cross4af21ed2019-11-04 09:37:55 -0800558 flags.Local.CFlags = append(flags.Local.CFlags, "-fno-sanitize-trap="+strings.Join(sanitize.Properties.DiagSanitizers, ","))
Evgenii Stepanov1e405e12016-08-16 15:39:54 -0700559 }
560 // FIXME: enable RTTI if diag + (cfi or vptr)
561
Andreas Gampe97071162017-05-08 13:15:23 -0700562 if sanitize.Properties.Sanitize.Recover != nil {
Colin Cross4af21ed2019-11-04 09:37:55 -0800563 flags.Local.CFlags = append(flags.Local.CFlags, "-fsanitize-recover="+
Andreas Gampe97071162017-05-08 13:15:23 -0700564 strings.Join(sanitize.Properties.Sanitize.Recover, ","))
565 }
566
Ivan Lozano7929bba2018-12-12 09:36:31 -0800567 if sanitize.Properties.Sanitize.Diag.No_recover != nil {
Colin Cross4af21ed2019-11-04 09:37:55 -0800568 flags.Local.CFlags = append(flags.Local.CFlags, "-fno-sanitize-recover="+
Ivan Lozano7929bba2018-12-12 09:36:31 -0800569 strings.Join(sanitize.Properties.Sanitize.Diag.No_recover, ","))
570 }
571
Colin Cross635c3b02016-05-18 15:37:25 -0700572 blacklist := android.OptionalPathForModuleSrc(ctx, sanitize.Properties.Sanitize.Blacklist)
Colin Cross16b23492016-01-06 14:41:07 -0800573 if blacklist.Valid() {
Colin Cross4af21ed2019-11-04 09:37:55 -0800574 flags.Local.CFlags = append(flags.Local.CFlags, "-fsanitize-blacklist="+blacklist.String())
Colin Cross16b23492016-01-06 14:41:07 -0800575 flags.CFlagsDeps = append(flags.CFlagsDeps, blacklist.Path())
576 }
577
578 return flags
579}
580
Colin Cross8ff9ef42017-05-08 13:44:11 -0700581func (sanitize *sanitize) AndroidMk(ctx AndroidMkContext, ret *android.AndroidMkData) {
Jiyong Park1d1119f2019-07-29 21:27:18 +0900582 // Add a suffix for cfi/hwasan/scs-enabled static/header libraries to allow surfacing
583 // both the sanitized and non-sanitized variants to make without a name conflict.
584 if ret.Class == "STATIC_LIBRARIES" || ret.Class == "HEADER_LIBRARIES" {
585 if Bool(sanitize.Properties.Sanitize.Cfi) {
586 ret.SubName += ".cfi"
587 }
588 if Bool(sanitize.Properties.Sanitize.Hwaddress) {
589 ret.SubName += ".hwasan"
590 }
591 if Bool(sanitize.Properties.Sanitize.Scs) {
592 ret.SubName += ".scs"
593 }
Peter Collingbourne8c7e6e22018-11-19 16:03:58 -0800594 }
Colin Cross8ff9ef42017-05-08 13:44:11 -0700595}
596
Vishwath Mohan1dd88392017-03-29 22:00:18 -0700597func (sanitize *sanitize) inSanitizerDir() bool {
598 return sanitize.Properties.InSanitizerDir
Colin Cross30d5f512016-05-03 18:02:42 -0700599}
600
Vishwath Mohanb743e9c2017-11-01 09:20:21 +0000601func (sanitize *sanitize) getSanitizerBoolPtr(t sanitizerType) *bool {
Vishwath Mohan95229302017-08-11 00:53:16 +0000602 switch t {
603 case asan:
Vishwath Mohanb743e9c2017-11-01 09:20:21 +0000604 return sanitize.Properties.Sanitize.Address
Evgenii Stepanovd97a6e92018-08-02 16:19:13 -0700605 case hwasan:
606 return sanitize.Properties.Sanitize.Hwaddress
Vishwath Mohan95229302017-08-11 00:53:16 +0000607 case tsan:
Vishwath Mohanb743e9c2017-11-01 09:20:21 +0000608 return sanitize.Properties.Sanitize.Thread
Vishwath Mohan95229302017-08-11 00:53:16 +0000609 case intOverflow:
Vishwath Mohanb743e9c2017-11-01 09:20:21 +0000610 return sanitize.Properties.Sanitize.Integer_overflow
611 case cfi:
612 return sanitize.Properties.Sanitize.Cfi
Peter Collingbourne8c7e6e22018-11-19 16:03:58 -0800613 case scs:
614 return sanitize.Properties.Sanitize.Scs
Mitch Phillips5a6ea6c2019-05-01 14:42:05 -0700615 case fuzzer:
616 return sanitize.Properties.Sanitize.Fuzzer
Vishwath Mohan95229302017-08-11 00:53:16 +0000617 default:
618 panic(fmt.Errorf("unknown sanitizerType %d", t))
619 }
620}
621
Dan Albert7d1eecf2018-01-19 12:30:45 -0800622func (sanitize *sanitize) isUnsanitizedVariant() bool {
623 return !sanitize.isSanitizerEnabled(asan) &&
Evgenii Stepanovd97a6e92018-08-02 16:19:13 -0700624 !sanitize.isSanitizerEnabled(hwasan) &&
Dan Albert7d1eecf2018-01-19 12:30:45 -0800625 !sanitize.isSanitizerEnabled(tsan) &&
Peter Collingbourne8c7e6e22018-11-19 16:03:58 -0800626 !sanitize.isSanitizerEnabled(cfi) &&
Mitch Phillips5a6ea6c2019-05-01 14:42:05 -0700627 !sanitize.isSanitizerEnabled(scs) &&
628 !sanitize.isSanitizerEnabled(fuzzer)
Dan Albert7d1eecf2018-01-19 12:30:45 -0800629}
630
Jayant Chowdharyb7e08ca2018-05-10 15:29:24 -0700631func (sanitize *sanitize) isVariantOnProductionDevice() bool {
632 return !sanitize.isSanitizerEnabled(asan) &&
Evgenii Stepanovd97a6e92018-08-02 16:19:13 -0700633 !sanitize.isSanitizerEnabled(hwasan) &&
Mitch Phillips5a6ea6c2019-05-01 14:42:05 -0700634 !sanitize.isSanitizerEnabled(tsan) &&
635 !sanitize.isSanitizerEnabled(fuzzer)
Jayant Chowdharyb7e08ca2018-05-10 15:29:24 -0700636}
637
Colin Cross16b23492016-01-06 14:41:07 -0800638func (sanitize *sanitize) SetSanitizer(t sanitizerType, b bool) {
639 switch t {
640 case asan:
Evgenii Stepanovfcfe56d2016-07-07 10:54:07 -0700641 sanitize.Properties.Sanitize.Address = boolPtr(b)
Evgenii Stepanovd97a6e92018-08-02 16:19:13 -0700642 case hwasan:
643 sanitize.Properties.Sanitize.Hwaddress = boolPtr(b)
Colin Cross16b23492016-01-06 14:41:07 -0800644 case tsan:
Evgenii Stepanovfcfe56d2016-07-07 10:54:07 -0700645 sanitize.Properties.Sanitize.Thread = boolPtr(b)
Ivan Lozano0c3a1ef2017-06-28 09:10:48 -0700646 case intOverflow:
647 sanitize.Properties.Sanitize.Integer_overflow = boolPtr(b)
Vishwath Mohanb743e9c2017-11-01 09:20:21 +0000648 case cfi:
649 sanitize.Properties.Sanitize.Cfi = boolPtr(b)
Peter Collingbourne8c7e6e22018-11-19 16:03:58 -0800650 case scs:
651 sanitize.Properties.Sanitize.Scs = boolPtr(b)
Mitch Phillips5a6ea6c2019-05-01 14:42:05 -0700652 case fuzzer:
653 sanitize.Properties.Sanitize.Fuzzer = boolPtr(b)
Colin Cross16b23492016-01-06 14:41:07 -0800654 default:
655 panic(fmt.Errorf("unknown sanitizerType %d", t))
656 }
657 if b {
658 sanitize.Properties.SanitizerEnabled = true
659 }
660}
661
Vishwath Mohanb743e9c2017-11-01 09:20:21 +0000662// Check if the sanitizer is explicitly disabled (as opposed to nil by
663// virtue of not being set).
664func (sanitize *sanitize) isSanitizerExplicitlyDisabled(t sanitizerType) bool {
665 if sanitize == nil {
666 return false
667 }
668
669 sanitizerVal := sanitize.getSanitizerBoolPtr(t)
670 return sanitizerVal != nil && *sanitizerVal == false
671}
672
673// There isn't an analog of the method above (ie:isSanitizerExplicitlyEnabled)
674// because enabling a sanitizer either directly (via the blueprint) or
675// indirectly (via a mutator) sets the bool ptr to true, and you can't
676// distinguish between the cases. It isn't needed though - both cases can be
677// treated identically.
678func (sanitize *sanitize) isSanitizerEnabled(t sanitizerType) bool {
679 if sanitize == nil {
680 return false
681 }
682
683 sanitizerVal := sanitize.getSanitizerBoolPtr(t)
684 return sanitizerVal != nil && *sanitizerVal == true
685}
686
Colin Cross6b753602018-06-21 13:03:07 -0700687func isSanitizableDependencyTag(tag blueprint.DependencyTag) bool {
Ivan Lozano183a3212019-10-18 14:18:45 -0700688 t, ok := tag.(DependencyTag)
689 return ok && t.Library || t == reuseObjTag || t == objDepTag
Colin Cross6b753602018-06-21 13:03:07 -0700690}
691
Evgenii Stepanovd97a6e92018-08-02 16:19:13 -0700692// Propagate sanitizer requirements down from binaries
Colin Cross635c3b02016-05-18 15:37:25 -0700693func sanitizerDepsMutator(t sanitizerType) func(android.TopDownMutatorContext) {
694 return func(mctx android.TopDownMutatorContext) {
Vishwath Mohanb743e9c2017-11-01 09:20:21 +0000695 if c, ok := mctx.Module().(*Module); ok && c.sanitize.isSanitizerEnabled(t) {
Colin Cross6b753602018-06-21 13:03:07 -0700696 mctx.WalkDeps(func(child, parent android.Module) bool {
697 if !isSanitizableDependencyTag(mctx.OtherModuleDependencyTag(child)) {
698 return false
699 }
700 if d, ok := child.(*Module); ok && d.sanitize != nil &&
Nan Zhang0007d812017-11-07 10:57:05 -0800701 !Bool(d.sanitize.Properties.Sanitize.Never) &&
Vishwath Mohanb743e9c2017-11-01 09:20:21 +0000702 !d.sanitize.isSanitizerExplicitlyDisabled(t) {
Peter Collingbourne8c7e6e22018-11-19 16:03:58 -0800703 if t == cfi || t == hwasan || t == scs {
Evgenii Stepanovd97a6e92018-08-02 16:19:13 -0700704 if d.static() {
705 d.sanitize.Properties.SanitizeDep = true
706 }
707 } else {
Vishwath Mohanb743e9c2017-11-01 09:20:21 +0000708 d.sanitize.Properties.SanitizeDep = true
709 }
Colin Cross16b23492016-01-06 14:41:07 -0800710 }
Colin Cross6b753602018-06-21 13:03:07 -0700711 return true
Colin Cross16b23492016-01-06 14:41:07 -0800712 })
Jiyong Parkf97782b2019-02-13 20:28:58 +0900713 } else if sanitizeable, ok := mctx.Module().(Sanitizeable); ok {
714 // If an APEX module includes a lib which is enabled for a sanitizer T, then
715 // the APEX module is also enabled for the same sanitizer type.
716 mctx.VisitDirectDeps(func(child android.Module) {
717 if c, ok := child.(*Module); ok && c.sanitize.isSanitizerEnabled(t) {
718 sanitizeable.EnableSanitizer(t.name())
719 }
720 })
Colin Cross16b23492016-01-06 14:41:07 -0800721 }
722 }
723}
724
Ivan Lozano30c5db22018-02-21 15:49:20 -0800725// Propagate the ubsan minimal runtime dependency when there are integer overflow sanitized static dependencies.
Colin Cross6b753602018-06-21 13:03:07 -0700726func sanitizerRuntimeDepsMutator(mctx android.TopDownMutatorContext) {
727 if c, ok := mctx.Module().(*Module); ok && c.sanitize != nil {
728 mctx.WalkDeps(func(child, parent android.Module) bool {
729 if !isSanitizableDependencyTag(mctx.OtherModuleDependencyTag(child)) {
730 return false
731 }
Ivan Lozano30c5db22018-02-21 15:49:20 -0800732
Colin Cross0b908332019-06-19 23:00:20 -0700733 if d, ok := child.(*Module); ok && d.static() && d.sanitize != nil {
Colin Cross6b753602018-06-21 13:03:07 -0700734 if enableMinimalRuntime(d.sanitize) {
735 // If a static dependency is built with the minimal runtime,
736 // make sure we include the ubsan minimal runtime.
737 c.sanitize.Properties.MinimalRuntimeDep = true
738 } else if Bool(d.sanitize.Properties.Sanitize.Diag.Integer_overflow) ||
739 len(d.sanitize.Properties.Sanitize.Diag.Misc_undefined) > 0 {
740 // If a static dependency runs with full ubsan diagnostics,
741 // make sure we include the ubsan runtime.
742 c.sanitize.Properties.UbsanRuntimeDep = true
Ivan Lozano30c5db22018-02-21 15:49:20 -0800743 }
Colin Cross0b908332019-06-19 23:00:20 -0700744
745 if c.sanitize.Properties.MinimalRuntimeDep &&
746 c.sanitize.Properties.UbsanRuntimeDep {
747 // both flags that this mutator might set are true, so don't bother recursing
748 return false
749 }
750
751 return true
752 } else {
753 return false
Colin Cross6b753602018-06-21 13:03:07 -0700754 }
Colin Cross6b753602018-06-21 13:03:07 -0700755 })
Ivan Lozano30c5db22018-02-21 15:49:20 -0800756 }
757}
758
Jiyong Park379de2f2018-12-19 02:47:14 +0900759// Add the dependency to the runtime library for each of the sanitizer variants
760func sanitizerRuntimeMutator(mctx android.BottomUpMutatorContext) {
Jiyong Park379de2f2018-12-19 02:47:14 +0900761 if c, ok := mctx.Module().(*Module); ok && c.sanitize != nil {
Pirama Arumuga Nainar6aa21022019-01-25 00:20:35 +0000762 if !c.Enabled() {
763 return
764 }
Jiyong Park379de2f2018-12-19 02:47:14 +0900765 var sanitizers []string
766 var diagSanitizers []string
767
768 if Bool(c.sanitize.Properties.Sanitize.All_undefined) {
769 sanitizers = append(sanitizers, "undefined")
770 } else {
771 if Bool(c.sanitize.Properties.Sanitize.Undefined) {
772 sanitizers = append(sanitizers,
773 "bool",
774 "integer-divide-by-zero",
775 "return",
776 "returns-nonnull-attribute",
777 "shift-exponent",
778 "unreachable",
779 "vla-bound",
780 // TODO(danalbert): The following checks currently have compiler performance issues.
781 //"alignment",
782 //"bounds",
783 //"enum",
784 //"float-cast-overflow",
785 //"float-divide-by-zero",
786 //"nonnull-attribute",
787 //"null",
788 //"shift-base",
789 //"signed-integer-overflow",
790 // TODO(danalbert): Fix UB in libc++'s __tree so we can turn this on.
791 // https://llvm.org/PR19302
792 // http://reviews.llvm.org/D6974
793 // "object-size",
794 )
795 }
796 sanitizers = append(sanitizers, c.sanitize.Properties.Sanitize.Misc_undefined...)
797 }
798
799 if Bool(c.sanitize.Properties.Sanitize.Diag.Undefined) {
800 diagSanitizers = append(diagSanitizers, "undefined")
801 }
802
803 diagSanitizers = append(diagSanitizers, c.sanitize.Properties.Sanitize.Diag.Misc_undefined...)
804
805 if Bool(c.sanitize.Properties.Sanitize.Address) {
806 sanitizers = append(sanitizers, "address")
807 diagSanitizers = append(diagSanitizers, "address")
808 }
809
810 if Bool(c.sanitize.Properties.Sanitize.Hwaddress) {
811 sanitizers = append(sanitizers, "hwaddress")
812 }
813
814 if Bool(c.sanitize.Properties.Sanitize.Thread) {
815 sanitizers = append(sanitizers, "thread")
816 }
817
818 if Bool(c.sanitize.Properties.Sanitize.Safestack) {
819 sanitizers = append(sanitizers, "safe-stack")
820 }
821
822 if Bool(c.sanitize.Properties.Sanitize.Cfi) {
823 sanitizers = append(sanitizers, "cfi")
824
825 if Bool(c.sanitize.Properties.Sanitize.Diag.Cfi) {
826 diagSanitizers = append(diagSanitizers, "cfi")
827 }
828 }
829
830 if Bool(c.sanitize.Properties.Sanitize.Integer_overflow) {
831 sanitizers = append(sanitizers, "unsigned-integer-overflow")
832 sanitizers = append(sanitizers, "signed-integer-overflow")
833 if Bool(c.sanitize.Properties.Sanitize.Diag.Integer_overflow) {
834 diagSanitizers = append(diagSanitizers, "unsigned-integer-overflow")
835 diagSanitizers = append(diagSanitizers, "signed-integer-overflow")
836 }
837 }
838
839 if Bool(c.sanitize.Properties.Sanitize.Scudo) {
840 sanitizers = append(sanitizers, "scudo")
841 }
842
843 if Bool(c.sanitize.Properties.Sanitize.Scs) {
844 sanitizers = append(sanitizers, "shadow-call-stack")
845 }
846
Mitch Phillips5a6ea6c2019-05-01 14:42:05 -0700847 if Bool(c.sanitize.Properties.Sanitize.Fuzzer) {
848 sanitizers = append(sanitizers, "fuzzer-no-link")
849 }
850
Jiyong Park379de2f2018-12-19 02:47:14 +0900851 // Save the list of sanitizers. These will be used again when generating
852 // the build rules (for Cflags, etc.)
853 c.sanitize.Properties.Sanitizers = sanitizers
854 c.sanitize.Properties.DiagSanitizers = diagSanitizers
855
856 // Determine the runtime library required
857 runtimeLibrary := ""
Ryan Prichardb49fe1b2019-10-11 15:03:34 -0700858 var extraStaticDeps []string
Jiyong Park379de2f2018-12-19 02:47:14 +0900859 toolchain := c.toolchain(mctx)
860 if Bool(c.sanitize.Properties.Sanitize.Address) {
861 runtimeLibrary = config.AddressSanitizerRuntimeLibrary(toolchain)
862 } else if Bool(c.sanitize.Properties.Sanitize.Hwaddress) {
863 if c.staticBinary() {
864 runtimeLibrary = config.HWAddressSanitizerStaticLibrary(toolchain)
Ryan Prichardb49fe1b2019-10-11 15:03:34 -0700865 extraStaticDeps = []string{"libdl"}
Jiyong Park379de2f2018-12-19 02:47:14 +0900866 } else {
867 runtimeLibrary = config.HWAddressSanitizerRuntimeLibrary(toolchain)
868 }
869 } else if Bool(c.sanitize.Properties.Sanitize.Thread) {
870 runtimeLibrary = config.ThreadSanitizerRuntimeLibrary(toolchain)
871 } else if Bool(c.sanitize.Properties.Sanitize.Scudo) {
872 if len(diagSanitizers) == 0 && !c.sanitize.Properties.UbsanRuntimeDep {
873 runtimeLibrary = config.ScudoMinimalRuntimeLibrary(toolchain)
874 } else {
875 runtimeLibrary = config.ScudoRuntimeLibrary(toolchain)
876 }
Mitch Phillipsb8e593d2019-10-09 17:18:59 -0700877 } else if len(diagSanitizers) > 0 || c.sanitize.Properties.UbsanRuntimeDep ||
878 Bool(c.sanitize.Properties.Sanitize.Fuzzer) {
Jiyong Park379de2f2018-12-19 02:47:14 +0900879 runtimeLibrary = config.UndefinedBehaviorSanitizerRuntimeLibrary(toolchain)
880 }
881
882 if mctx.Device() && runtimeLibrary != "" {
Jooyung Han0302a842019-10-30 18:43:49 +0900883 if isLlndkLibrary(runtimeLibrary, mctx.Config()) && !c.static() && c.UseVndk() {
Jiyong Park379de2f2018-12-19 02:47:14 +0900884 runtimeLibrary = runtimeLibrary + llndkLibrarySuffix
885 }
886
887 // Adding dependency to the runtime library. We are using *FarVariation*
888 // because the runtime libraries themselves are not mutated by sanitizer
889 // mutators and thus don't have sanitizer variants whereas this module
890 // has been already mutated.
891 //
892 // Note that by adding dependency with {static|shared}DepTag, the lib is
893 // added to libFlags and LOCAL_SHARED_LIBRARIES by cc.Module
894 if c.staticBinary() {
895 // static executable gets static runtime libs
Colin Cross0f7d2ef2019-10-16 11:03:10 -0700896 mctx.AddFarVariationDependencies(append(mctx.Target().Variations(), []blueprint.Variation{
Jiyong Park379de2f2018-12-19 02:47:14 +0900897 {Mutator: "link", Variation: "static"},
Jiyong Park3b1746a2019-01-29 11:15:04 +0900898 {Mutator: "image", Variation: c.imageVariation()},
Ivan Lozano183a3212019-10-18 14:18:45 -0700899 }...), StaticDepTag, append([]string{runtimeLibrary}, extraStaticDeps...)...)
Jiyong Park1d1119f2019-07-29 21:27:18 +0900900 } else if !c.static() && !c.header() {
Jiyong Park3b1746a2019-01-29 11:15:04 +0900901 // dynamic executable and shared libs get shared runtime libs
Colin Cross0f7d2ef2019-10-16 11:03:10 -0700902 mctx.AddFarVariationDependencies(append(mctx.Target().Variations(), []blueprint.Variation{
Jiyong Park379de2f2018-12-19 02:47:14 +0900903 {Mutator: "link", Variation: "shared"},
Jiyong Park3b1746a2019-01-29 11:15:04 +0900904 {Mutator: "image", Variation: c.imageVariation()},
Colin Cross0f7d2ef2019-10-16 11:03:10 -0700905 }...), earlySharedDepTag, runtimeLibrary)
Jiyong Park379de2f2018-12-19 02:47:14 +0900906 }
907 // static lib does not have dependency to the runtime library. The
908 // dependency will be added to the executables or shared libs using
909 // the static lib.
910 }
911 }
912}
913
914type Sanitizeable interface {
915 android.Module
Jiyong Park388ef3f2019-01-28 19:47:32 +0900916 IsSanitizerEnabled(ctx android.BaseModuleContext, sanitizerName string) bool
Jiyong Parkf97782b2019-02-13 20:28:58 +0900917 EnableSanitizer(sanitizerName string)
Jiyong Park379de2f2018-12-19 02:47:14 +0900918}
919
Vishwath Mohanb743e9c2017-11-01 09:20:21 +0000920// Create sanitized variants for modules that need them
Colin Cross635c3b02016-05-18 15:37:25 -0700921func sanitizerMutator(t sanitizerType) func(android.BottomUpMutatorContext) {
922 return func(mctx android.BottomUpMutatorContext) {
Vishwath Mohane6153452017-08-11 00:52:44 +0000923 if c, ok := mctx.Module().(*Module); ok && c.sanitize != nil {
Vishwath Mohanb743e9c2017-11-01 09:20:21 +0000924 if c.isDependencyRoot() && c.sanitize.isSanitizerEnabled(t) {
Jiyong Park82226632019-02-01 10:50:50 +0900925 modules := mctx.CreateVariations(t.variationName())
Colin Cross30d5f512016-05-03 18:02:42 -0700926 modules[0].(*Module).sanitize.SetSanitizer(t, true)
Vishwath Mohanb743e9c2017-11-01 09:20:21 +0000927 } else if c.sanitize.isSanitizerEnabled(t) || c.sanitize.Properties.SanitizeDep {
Vishwath Mohanb743e9c2017-11-01 09:20:21 +0000928 isSanitizerEnabled := c.sanitize.isSanitizerEnabled(t)
Jiyong Park1d1119f2019-07-29 21:27:18 +0900929 if mctx.Device() && t.incompatibleWithCfi() {
930 // TODO: Make sure that cfi mutator runs "after" any of the sanitizers that
931 // are incompatible with cfi
932 c.sanitize.SetSanitizer(cfi, false)
933 }
934 if c.static() || c.header() || t == asan || t == fuzzer {
935 // Static and header libs are split into non-sanitized and sanitized variants.
936 // Shared libs are not split. However, for asan and fuzzer, we split even for shared
937 // libs because a library sanitized for asan/fuzzer can't be linked from a library
938 // that isn't sanitized for asan/fuzzer.
939 //
940 // Note for defaultVariation: since we don't split for shared libs but for static/header
941 // libs, it is possible for the sanitized variant of a static/header lib to depend
942 // on non-sanitized variant of a shared lib. Such unfulfilled variation causes an
943 // error when the module is split. defaultVariation is the name of the variation that
944 // will be used when such a dangling dependency occurs during the split of the current
945 // module. By setting it to the name of the sanitized variation, the dangling dependency
946 // is redirected to the sanitized variant of the dependent module.
947 defaultVariation := t.variationName()
948 mctx.SetDefaultDependencyVariation(&defaultVariation)
949 modules := mctx.CreateVariations("", t.variationName())
950 modules[0].(*Module).sanitize.SetSanitizer(t, false)
951 modules[1].(*Module).sanitize.SetSanitizer(t, true)
952 modules[0].(*Module).sanitize.Properties.SanitizeDep = false
953 modules[1].(*Module).sanitize.Properties.SanitizeDep = false
Vishwath Mohanb743e9c2017-11-01 09:20:21 +0000954
Jiyong Park1d1119f2019-07-29 21:27:18 +0900955 // For cfi/scs/hwasan, we can export both sanitized and un-sanitized variants
956 // to Make, because the sanitized version has a different suffix in name.
957 // For other types of sanitizers, suppress the variation that is disabled.
958 if t != cfi && t != scs && t != hwasan {
959 if isSanitizerEnabled {
960 modules[0].(*Module).Properties.PreventInstall = true
961 modules[0].(*Module).Properties.HideFromMake = true
962 } else {
963 modules[1].(*Module).Properties.PreventInstall = true
964 modules[1].(*Module).Properties.HideFromMake = true
965 }
966 }
Vishwath Mohanb743e9c2017-11-01 09:20:21 +0000967
Jiyong Park1d1119f2019-07-29 21:27:18 +0900968 // Export the static lib name to make
Vishwath Mohane7128792017-11-17 11:08:10 -0800969 if c.static() {
Jiyong Park1d1119f2019-07-29 21:27:18 +0900970 if t == cfi {
971 appendStringSync(c.Name(), cfiStaticLibs(mctx.Config()), &cfiStaticLibsMutex)
972 } else if t == hwasan {
Ivan Lozano52767be2019-10-18 14:49:46 -0700973 if c.UseVndk() {
Jiyong Park1d1119f2019-07-29 21:27:18 +0900974 appendStringSync(c.Name(), hwasanVendorStaticLibs(mctx.Config()),
975 &hwasanStaticLibsMutex)
Vishwath Mohane7128792017-11-17 11:08:10 -0800976 } else {
Jiyong Park1d1119f2019-07-29 21:27:18 +0900977 appendStringSync(c.Name(), hwasanStaticLibs(mctx.Config()),
978 &hwasanStaticLibsMutex)
Vishwath Mohane7128792017-11-17 11:08:10 -0800979 }
Jiyong Park1d1119f2019-07-29 21:27:18 +0900980 }
981 }
982 } else {
983 // Shared libs are not split. Only the sanitized variant is created.
984 modules := mctx.CreateVariations(t.variationName())
985 modules[0].(*Module).sanitize.SetSanitizer(t, true)
986 modules[0].(*Module).sanitize.Properties.SanitizeDep = false
Vishwath Mohane7128792017-11-17 11:08:10 -0800987
Jiyong Park1d1119f2019-07-29 21:27:18 +0900988 // locate the asan libraries under /data/asan
989 if mctx.Device() && t == asan && isSanitizerEnabled {
990 modules[0].(*Module).sanitize.Properties.InSanitizerDir = true
Evgenii Stepanovd97a6e92018-08-02 16:19:13 -0700991 }
Vishwath Mohane21fe422017-11-01 19:42:45 -0700992 }
Colin Cross16b23492016-01-06 14:41:07 -0800993 }
994 c.sanitize.Properties.SanitizeDep = false
Jiyong Park82226632019-02-01 10:50:50 +0900995 } else if sanitizeable, ok := mctx.Module().(Sanitizeable); ok && sanitizeable.IsSanitizerEnabled(mctx, t.name()) {
Jiyong Park379de2f2018-12-19 02:47:14 +0900996 // APEX modules fall here
Jiyong Park82226632019-02-01 10:50:50 +0900997 mctx.CreateVariations(t.variationName())
Colin Cross16b23492016-01-06 14:41:07 -0800998 }
999 }
1000}
Vishwath Mohane7128792017-11-17 11:08:10 -08001001
Colin Cross571cccf2019-02-04 11:22:08 -08001002var cfiStaticLibsKey = android.NewOnceKey("cfiStaticLibs")
1003
Vishwath Mohane7128792017-11-17 11:08:10 -08001004func cfiStaticLibs(config android.Config) *[]string {
Colin Cross571cccf2019-02-04 11:22:08 -08001005 return config.Once(cfiStaticLibsKey, func() interface{} {
Vishwath Mohane7128792017-11-17 11:08:10 -08001006 return &[]string{}
1007 }).(*[]string)
1008}
1009
Colin Cross571cccf2019-02-04 11:22:08 -08001010var hwasanStaticLibsKey = android.NewOnceKey("hwasanStaticLibs")
1011
Evgenii Stepanovd97a6e92018-08-02 16:19:13 -07001012func hwasanStaticLibs(config android.Config) *[]string {
Colin Cross571cccf2019-02-04 11:22:08 -08001013 return config.Once(hwasanStaticLibsKey, func() interface{} {
Evgenii Stepanovd97a6e92018-08-02 16:19:13 -07001014 return &[]string{}
1015 }).(*[]string)
1016}
1017
Colin Cross571cccf2019-02-04 11:22:08 -08001018var hwasanVendorStaticLibsKey = android.NewOnceKey("hwasanVendorStaticLibs")
1019
Evgenii Stepanovd97a6e92018-08-02 16:19:13 -07001020func hwasanVendorStaticLibs(config android.Config) *[]string {
Colin Cross571cccf2019-02-04 11:22:08 -08001021 return config.Once(hwasanVendorStaticLibsKey, func() interface{} {
Evgenii Stepanovd97a6e92018-08-02 16:19:13 -07001022 return &[]string{}
1023 }).(*[]string)
1024}
1025
Jiyong Park1d1119f2019-07-29 21:27:18 +09001026func appendStringSync(item string, list *[]string, mutex *sync.Mutex) {
1027 mutex.Lock()
1028 *list = append(*list, item)
1029 mutex.Unlock()
1030}
1031
Ivan Lozano30c5db22018-02-21 15:49:20 -08001032func enableMinimalRuntime(sanitize *sanitize) bool {
1033 if !Bool(sanitize.Properties.Sanitize.Address) &&
Evgenii Stepanovd97a6e92018-08-02 16:19:13 -07001034 !Bool(sanitize.Properties.Sanitize.Hwaddress) &&
Mitch Phillips5a6ea6c2019-05-01 14:42:05 -07001035 !Bool(sanitize.Properties.Sanitize.Fuzzer) &&
Ivan Lozano30c5db22018-02-21 15:49:20 -08001036 (Bool(sanitize.Properties.Sanitize.Integer_overflow) ||
1037 len(sanitize.Properties.Sanitize.Misc_undefined) > 0) &&
1038 !(Bool(sanitize.Properties.Sanitize.Diag.Integer_overflow) ||
1039 Bool(sanitize.Properties.Sanitize.Diag.Cfi) ||
1040 len(sanitize.Properties.Sanitize.Diag.Misc_undefined) > 0) {
1041 return true
1042 }
1043 return false
1044}
1045
Vishwath Mohane7128792017-11-17 11:08:10 -08001046func cfiMakeVarsProvider(ctx android.MakeVarsContext) {
1047 cfiStaticLibs := cfiStaticLibs(ctx.Config())
Jeff Gaston72765392017-11-28 16:37:53 -08001048 sort.Strings(*cfiStaticLibs)
Vishwath Mohane7128792017-11-17 11:08:10 -08001049 ctx.Strict("SOONG_CFI_STATIC_LIBRARIES", strings.Join(*cfiStaticLibs, " "))
1050}
Evgenii Stepanovd97a6e92018-08-02 16:19:13 -07001051
1052func hwasanMakeVarsProvider(ctx android.MakeVarsContext) {
1053 hwasanStaticLibs := hwasanStaticLibs(ctx.Config())
1054 sort.Strings(*hwasanStaticLibs)
1055 ctx.Strict("SOONG_HWASAN_STATIC_LIBRARIES", strings.Join(*hwasanStaticLibs, " "))
1056
1057 hwasanVendorStaticLibs := hwasanVendorStaticLibs(ctx.Config())
1058 sort.Strings(*hwasanVendorStaticLibs)
1059 ctx.Strict("SOONG_HWASAN_VENDOR_STATIC_LIBRARIES", strings.Join(*hwasanVendorStaticLibs, " "))
1060}