Colin Cross | 16b2349 | 2016-01-06 14:41:07 -0800 | [diff] [blame] | 1 | // Copyright 2016 Google Inc. All rights reserved. |
| 2 | // |
| 3 | // Licensed under the Apache License, Version 2.0 (the "License"); |
| 4 | // you may not use this file except in compliance with the License. |
| 5 | // You may obtain a copy of the License at |
| 6 | // |
| 7 | // http://www.apache.org/licenses/LICENSE-2.0 |
| 8 | // |
| 9 | // Unless required by applicable law or agreed to in writing, software |
| 10 | // distributed under the License is distributed on an "AS IS" BASIS, |
| 11 | // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. |
| 12 | // See the License for the specific language governing permissions and |
| 13 | // limitations under the License. |
| 14 | |
| 15 | package cc |
| 16 | |
| 17 | import ( |
| 18 | "fmt" |
Colin Cross | 8ff9ef4 | 2017-05-08 13:44:11 -0700 | [diff] [blame] | 19 | "io" |
Jeff Gaston | 7276539 | 2017-11-28 16:37:53 -0800 | [diff] [blame] | 20 | "sort" |
Colin Cross | 16b2349 | 2016-01-06 14:41:07 -0800 | [diff] [blame] | 21 | "strings" |
Vishwath Mohan | e712879 | 2017-11-17 11:08:10 -0800 | [diff] [blame] | 22 | "sync" |
Colin Cross | 16b2349 | 2016-01-06 14:41:07 -0800 | [diff] [blame] | 23 | |
Colin Cross | 6b75360 | 2018-06-21 13:03:07 -0700 | [diff] [blame] | 24 | "github.com/google/blueprint" |
| 25 | |
Colin Cross | 635c3b0 | 2016-05-18 15:37:25 -0700 | [diff] [blame] | 26 | "android/soong/android" |
Evgenii Stepanov | af36db1 | 2016-08-15 14:18:24 -0700 | [diff] [blame] | 27 | "android/soong/cc/config" |
Colin Cross | 16b2349 | 2016-01-06 14:41:07 -0800 | [diff] [blame] | 28 | ) |
| 29 | |
Jayant Chowdhary | 9677e8c | 2017-06-15 14:45:18 -0700 | [diff] [blame] | 30 | var ( |
| 31 | // Any C flags added by sanitizer which libTooling tools may not |
| 32 | // understand also need to be added to ClangLibToolingUnknownCflags in |
| 33 | // cc/config/clang.go |
Vishwath Mohan | f3918d3 | 2017-02-14 07:59:33 -0800 | [diff] [blame] | 34 | |
Jayant Chowdhary | 9677e8c | 2017-06-15 14:45:18 -0700 | [diff] [blame] | 35 | asanCflags = []string{"-fno-omit-frame-pointer"} |
| 36 | asanLdflags = []string{"-Wl,-u,__asan_preinit"} |
| 37 | asanLibs = []string{"libasan"} |
| 38 | |
Evgenii Stepanov | 0a87b66 | 2018-12-07 15:33:24 -0800 | [diff] [blame] | 39 | hwasanCflags = []string{"-mllvm", "-hwasan-with-ifunc=0", "-fno-omit-frame-pointer", "-Wno-frame-larger-than=", "-mllvm", "-hwasan-create-frame-descriptions=0"} |
Evgenii Stepanov | d97a6e9 | 2018-08-02 16:19:13 -0700 | [diff] [blame] | 40 | |
Vishwath Mohan | b743e9c | 2017-11-01 09:20:21 +0000 | [diff] [blame] | 41 | cfiCflags = []string{"-flto", "-fsanitize-cfi-cross-dso", |
Jayant Chowdhary | 9677e8c | 2017-06-15 14:45:18 -0700 | [diff] [blame] | 42 | "-fsanitize-blacklist=external/compiler-rt/lib/cfi/cfi_blacklist.txt"} |
Evgenii Stepanov | dbf1d4f | 2018-08-31 12:54:33 -0700 | [diff] [blame] | 43 | // -flto and -fvisibility are required by clang when -fsanitize=cfi is |
| 44 | // used, but have no effect on assembly files |
| 45 | cfiAsflags = []string{"-flto", "-fvisibility=default"} |
Jayant Chowdhary | 9677e8c | 2017-06-15 14:45:18 -0700 | [diff] [blame] | 46 | cfiLdflags = []string{"-flto", "-fsanitize-cfi-cross-dso", "-fsanitize=cfi", |
Pirama Arumuga Nainar | bdb17f0 | 2017-08-28 21:50:17 -0700 | [diff] [blame] | 47 | "-Wl,-plugin-opt,O1"} |
Evgenii Stepanov | d97a6e9 | 2018-08-02 16:19:13 -0700 | [diff] [blame] | 48 | cfiExportsMapPath = "build/soong/cc/config/cfi_exports.map" |
| 49 | cfiStaticLibsMutex sync.Mutex |
| 50 | hwasanStaticLibsMutex sync.Mutex |
Ivan Lozano | 0c3a1ef | 2017-06-28 09:10:48 -0700 | [diff] [blame] | 51 | |
Evgenii Stepanov | 98f5b06 | 2018-11-29 15:12:51 -0800 | [diff] [blame] | 52 | intOverflowCflags = []string{"-fsanitize-blacklist=build/soong/cc/config/integer_overflow_blacklist.txt"} |
Peter Collingbourne | 8c7e6e2 | 2018-11-19 16:03:58 -0800 | [diff] [blame] | 53 | |
| 54 | // Pass -Xclang before -fsanitize-minimal-runtime to work around a driver |
| 55 | // check which rejects -fsanitize-minimal-runtime together with |
| 56 | // -fsanitize=shadow-call-stack even though this combination of flags |
| 57 | // is valid. |
| 58 | // TODO(pcc): Remove the -Xclang once LLVM r346526 is rolled into the compiler. |
| 59 | minimalRuntimeFlags = []string{"-Xclang", "-fsanitize-minimal-runtime", "-fno-sanitize-trap=integer,undefined", |
Ivan Lozano | ae6ae1d | 2018-10-08 09:29:39 -0700 | [diff] [blame] | 60 | "-fno-sanitize-recover=integer,undefined"} |
Evgenii Stepanov | 109029f | 2018-10-03 18:22:57 -0700 | [diff] [blame] | 61 | hwasanGlobalOptions = []string{"heap_history_size=4095"} |
Dan Willemsen | cbceaab | 2016-10-13 16:44:07 -0700 | [diff] [blame] | 62 | ) |
| 63 | |
Colin Cross | 16b2349 | 2016-01-06 14:41:07 -0800 | [diff] [blame] | 64 | type sanitizerType int |
| 65 | |
Evgenii Stepanov | fcfe56d | 2016-07-07 10:54:07 -0700 | [diff] [blame] | 66 | func boolPtr(v bool) *bool { |
| 67 | if v { |
| 68 | return &v |
| 69 | } else { |
| 70 | return nil |
| 71 | } |
| 72 | } |
| 73 | |
Colin Cross | 16b2349 | 2016-01-06 14:41:07 -0800 | [diff] [blame] | 74 | const ( |
| 75 | asan sanitizerType = iota + 1 |
Evgenii Stepanov | d97a6e9 | 2018-08-02 16:19:13 -0700 | [diff] [blame] | 76 | hwasan |
Colin Cross | 16b2349 | 2016-01-06 14:41:07 -0800 | [diff] [blame] | 77 | tsan |
Ivan Lozano | 0c3a1ef | 2017-06-28 09:10:48 -0700 | [diff] [blame] | 78 | intOverflow |
Vishwath Mohan | b743e9c | 2017-11-01 09:20:21 +0000 | [diff] [blame] | 79 | cfi |
Peter Collingbourne | 8c7e6e2 | 2018-11-19 16:03:58 -0800 | [diff] [blame] | 80 | scs |
Colin Cross | 16b2349 | 2016-01-06 14:41:07 -0800 | [diff] [blame] | 81 | ) |
| 82 | |
| 83 | func (t sanitizerType) String() string { |
| 84 | switch t { |
| 85 | case asan: |
| 86 | return "asan" |
Evgenii Stepanov | d97a6e9 | 2018-08-02 16:19:13 -0700 | [diff] [blame] | 87 | case hwasan: |
| 88 | return "hwasan" |
Colin Cross | 16b2349 | 2016-01-06 14:41:07 -0800 | [diff] [blame] | 89 | case tsan: |
| 90 | return "tsan" |
Ivan Lozano | 0c3a1ef | 2017-06-28 09:10:48 -0700 | [diff] [blame] | 91 | case intOverflow: |
| 92 | return "intOverflow" |
Vishwath Mohan | b743e9c | 2017-11-01 09:20:21 +0000 | [diff] [blame] | 93 | case cfi: |
| 94 | return "cfi" |
Peter Collingbourne | 8c7e6e2 | 2018-11-19 16:03:58 -0800 | [diff] [blame] | 95 | case scs: |
| 96 | return "scs" |
Colin Cross | 16b2349 | 2016-01-06 14:41:07 -0800 | [diff] [blame] | 97 | default: |
| 98 | panic(fmt.Errorf("unknown sanitizerType %d", t)) |
| 99 | } |
| 100 | } |
| 101 | |
| 102 | type SanitizeProperties struct { |
| 103 | // enable AddressSanitizer, ThreadSanitizer, or UndefinedBehaviorSanitizer |
| 104 | Sanitize struct { |
Nan Zhang | 0007d81 | 2017-11-07 10:57:05 -0800 | [diff] [blame] | 105 | Never *bool `android:"arch_variant"` |
Colin Cross | 16b2349 | 2016-01-06 14:41:07 -0800 | [diff] [blame] | 106 | |
| 107 | // main sanitizers |
Evgenii Stepanov | d97a6e9 | 2018-08-02 16:19:13 -0700 | [diff] [blame] | 108 | Address *bool `android:"arch_variant"` |
| 109 | Thread *bool `android:"arch_variant"` |
| 110 | Hwaddress *bool `android:"arch_variant"` |
Colin Cross | 16b2349 | 2016-01-06 14:41:07 -0800 | [diff] [blame] | 111 | |
| 112 | // local sanitizers |
Ivan Lozano | 0c3a1ef | 2017-06-28 09:10:48 -0700 | [diff] [blame] | 113 | Undefined *bool `android:"arch_variant"` |
| 114 | All_undefined *bool `android:"arch_variant"` |
| 115 | Misc_undefined []string `android:"arch_variant"` |
| 116 | Coverage *bool `android:"arch_variant"` |
| 117 | Safestack *bool `android:"arch_variant"` |
| 118 | Cfi *bool `android:"arch_variant"` |
| 119 | Integer_overflow *bool `android:"arch_variant"` |
Kostya Kortchinsky | d18ae5c | 2018-06-12 14:46:54 -0700 | [diff] [blame] | 120 | Scudo *bool `android:"arch_variant"` |
Peter Collingbourne | 8c7e6e2 | 2018-11-19 16:03:58 -0800 | [diff] [blame] | 121 | Scs *bool `android:"arch_variant"` |
Colin Cross | 16b2349 | 2016-01-06 14:41:07 -0800 | [diff] [blame] | 122 | |
Evgenii Stepanov | 1e405e1 | 2016-08-16 15:39:54 -0700 | [diff] [blame] | 123 | // Sanitizers to run in the diagnostic mode (as opposed to the release mode). |
| 124 | // Replaces abort() on error with a human-readable error message. |
| 125 | // Address and Thread sanitizers always run in diagnostic mode. |
| 126 | Diag struct { |
Ivan Lozano | 0c3a1ef | 2017-06-28 09:10:48 -0700 | [diff] [blame] | 127 | Undefined *bool `android:"arch_variant"` |
| 128 | Cfi *bool `android:"arch_variant"` |
| 129 | Integer_overflow *bool `android:"arch_variant"` |
| 130 | Misc_undefined []string `android:"arch_variant"` |
Ivan Lozano | 7929bba | 2018-12-12 09:36:31 -0800 | [diff] [blame^] | 131 | No_recover []string |
Evgenii Stepanov | 1e405e1 | 2016-08-16 15:39:54 -0700 | [diff] [blame] | 132 | } |
| 133 | |
| 134 | // value to pass to -fsanitize-recover= |
Colin Cross | 16b2349 | 2016-01-06 14:41:07 -0800 | [diff] [blame] | 135 | Recover []string |
| 136 | |
| 137 | // value to pass to -fsanitize-blacklist |
| 138 | Blacklist *string |
| 139 | } `android:"arch_variant"` |
| 140 | |
Ivan Lozano | 30c5db2 | 2018-02-21 15:49:20 -0800 | [diff] [blame] | 141 | SanitizerEnabled bool `blueprint:"mutated"` |
| 142 | SanitizeDep bool `blueprint:"mutated"` |
| 143 | MinimalRuntimeDep bool `blueprint:"mutated"` |
Ivan Lozano | a9255a8 | 2018-03-13 10:41:07 -0700 | [diff] [blame] | 144 | UbsanRuntimeDep bool `blueprint:"mutated"` |
Ivan Lozano | 30c5db2 | 2018-02-21 15:49:20 -0800 | [diff] [blame] | 145 | InSanitizerDir bool `blueprint:"mutated"` |
Colin Cross | 16b2349 | 2016-01-06 14:41:07 -0800 | [diff] [blame] | 146 | } |
| 147 | |
| 148 | type sanitize struct { |
| 149 | Properties SanitizeProperties |
Colin Cross | 8ff9ef4 | 2017-05-08 13:44:11 -0700 | [diff] [blame] | 150 | |
Jiyong Park | 27b188b | 2017-07-18 13:23:39 +0900 | [diff] [blame] | 151 | runtimeLibrary string |
| 152 | androidMkRuntimeLibrary string |
Colin Cross | 16b2349 | 2016-01-06 14:41:07 -0800 | [diff] [blame] | 153 | } |
| 154 | |
Vishwath Mohan | e712879 | 2017-11-17 11:08:10 -0800 | [diff] [blame] | 155 | func init() { |
| 156 | android.RegisterMakeVarsProvider(pctx, cfiMakeVarsProvider) |
Evgenii Stepanov | d97a6e9 | 2018-08-02 16:19:13 -0700 | [diff] [blame] | 157 | android.RegisterMakeVarsProvider(pctx, hwasanMakeVarsProvider) |
Vishwath Mohan | e712879 | 2017-11-17 11:08:10 -0800 | [diff] [blame] | 158 | } |
| 159 | |
Colin Cross | 16b2349 | 2016-01-06 14:41:07 -0800 | [diff] [blame] | 160 | func (sanitize *sanitize) props() []interface{} { |
| 161 | return []interface{}{&sanitize.Properties} |
| 162 | } |
| 163 | |
| 164 | func (sanitize *sanitize) begin(ctx BaseModuleContext) { |
Evgenii Stepanov | fcfe56d | 2016-07-07 10:54:07 -0700 | [diff] [blame] | 165 | s := &sanitize.Properties.Sanitize |
| 166 | |
Colin Cross | 16b2349 | 2016-01-06 14:41:07 -0800 | [diff] [blame] | 167 | // Don't apply sanitizers to NDK code. |
Jeff Gaston | af3cc2d | 2017-09-27 17:01:44 -0700 | [diff] [blame] | 168 | if ctx.useSdk() { |
Nan Zhang | 0007d81 | 2017-11-07 10:57:05 -0800 | [diff] [blame] | 169 | s.Never = BoolPtr(true) |
Colin Cross | 16b2349 | 2016-01-06 14:41:07 -0800 | [diff] [blame] | 170 | } |
| 171 | |
| 172 | // Never always wins. |
Nan Zhang | 0007d81 | 2017-11-07 10:57:05 -0800 | [diff] [blame] | 173 | if Bool(s.Never) { |
Colin Cross | 16b2349 | 2016-01-06 14:41:07 -0800 | [diff] [blame] | 174 | return |
| 175 | } |
| 176 | |
Colin Cross | 16b2349 | 2016-01-06 14:41:07 -0800 | [diff] [blame] | 177 | var globalSanitizers []string |
Ivan Lozano | 0c3a1ef | 2017-06-28 09:10:48 -0700 | [diff] [blame] | 178 | var globalSanitizersDiag []string |
| 179 | |
Dan Willemsen | 8536d6b | 2018-10-07 20:54:34 -0700 | [diff] [blame] | 180 | if ctx.Host() { |
| 181 | if !ctx.Windows() { |
| 182 | globalSanitizers = ctx.Config().SanitizeHost() |
| 183 | } |
| 184 | } else { |
| 185 | arches := ctx.Config().SanitizeDeviceArch() |
| 186 | if len(arches) == 0 || inList(ctx.Arch().ArchType.Name, arches) { |
| 187 | globalSanitizers = ctx.Config().SanitizeDevice() |
| 188 | globalSanitizersDiag = ctx.Config().SanitizeDeviceDiag() |
Colin Cross | 16b2349 | 2016-01-06 14:41:07 -0800 | [diff] [blame] | 189 | } |
| 190 | } |
| 191 | |
Colin Cross | 16b2349 | 2016-01-06 14:41:07 -0800 | [diff] [blame] | 192 | if len(globalSanitizers) > 0 { |
Evgenii Stepanov | 05bafd3 | 2016-07-07 17:38:41 +0000 | [diff] [blame] | 193 | var found bool |
Evgenii Stepanov | fcfe56d | 2016-07-07 10:54:07 -0700 | [diff] [blame] | 194 | if found, globalSanitizers = removeFromList("undefined", globalSanitizers); found && s.All_undefined == nil { |
| 195 | s.All_undefined = boolPtr(true) |
Evgenii Stepanov | 05bafd3 | 2016-07-07 17:38:41 +0000 | [diff] [blame] | 196 | } |
Colin Cross | 16b2349 | 2016-01-06 14:41:07 -0800 | [diff] [blame] | 197 | |
Evgenii Stepanov | fcfe56d | 2016-07-07 10:54:07 -0700 | [diff] [blame] | 198 | if found, globalSanitizers = removeFromList("default-ub", globalSanitizers); found && s.Undefined == nil { |
| 199 | s.Undefined = boolPtr(true) |
Evgenii Stepanov | 05bafd3 | 2016-07-07 17:38:41 +0000 | [diff] [blame] | 200 | } |
| 201 | |
Evgenii Stepanov | 774cb81 | 2016-12-28 15:52:54 -0800 | [diff] [blame] | 202 | if found, globalSanitizers = removeFromList("address", globalSanitizers); found { |
| 203 | if s.Address == nil { |
| 204 | s.Address = boolPtr(true) |
| 205 | } else if *s.Address == false { |
| 206 | // Coverage w/o address is an error. If globalSanitizers includes both, and the module |
| 207 | // disables address, then disable coverage as well. |
| 208 | _, globalSanitizers = removeFromList("coverage", globalSanitizers) |
| 209 | } |
Evgenii Stepanov | 05bafd3 | 2016-07-07 17:38:41 +0000 | [diff] [blame] | 210 | } |
| 211 | |
Evgenii Stepanov | fcfe56d | 2016-07-07 10:54:07 -0700 | [diff] [blame] | 212 | if found, globalSanitizers = removeFromList("thread", globalSanitizers); found && s.Thread == nil { |
| 213 | s.Thread = boolPtr(true) |
Evgenii Stepanov | 05bafd3 | 2016-07-07 17:38:41 +0000 | [diff] [blame] | 214 | } |
| 215 | |
Evgenii Stepanov | fcfe56d | 2016-07-07 10:54:07 -0700 | [diff] [blame] | 216 | if found, globalSanitizers = removeFromList("coverage", globalSanitizers); found && s.Coverage == nil { |
| 217 | s.Coverage = boolPtr(true) |
| 218 | } |
| 219 | |
| 220 | if found, globalSanitizers = removeFromList("safe-stack", globalSanitizers); found && s.Safestack == nil { |
| 221 | s.Safestack = boolPtr(true) |
Evgenii Stepanov | 05bafd3 | 2016-07-07 17:38:41 +0000 | [diff] [blame] | 222 | } |
| 223 | |
Evgenii Stepanov | 1e405e1 | 2016-08-16 15:39:54 -0700 | [diff] [blame] | 224 | if found, globalSanitizers = removeFromList("cfi", globalSanitizers); found && s.Cfi == nil { |
Colin Cross | 6510f91 | 2017-11-29 00:27:14 -0800 | [diff] [blame] | 225 | if !ctx.Config().CFIDisabledForPath(ctx.ModuleDir()) { |
Vishwath Mohan | 1fa3ac5 | 2017-10-31 02:26:14 -0700 | [diff] [blame] | 226 | s.Cfi = boolPtr(true) |
| 227 | } |
Evgenii Stepanov | 1e405e1 | 2016-08-16 15:39:54 -0700 | [diff] [blame] | 228 | } |
| 229 | |
Ivan Lozano | a9255a8 | 2018-03-13 10:41:07 -0700 | [diff] [blame] | 230 | // Global integer_overflow builds do not support static libraries. |
Ivan Lozano | 0c3a1ef | 2017-06-28 09:10:48 -0700 | [diff] [blame] | 231 | if found, globalSanitizers = removeFromList("integer_overflow", globalSanitizers); found && s.Integer_overflow == nil { |
Ivan Lozano | a9255a8 | 2018-03-13 10:41:07 -0700 | [diff] [blame] | 232 | if !ctx.Config().IntegerOverflowDisabledForPath(ctx.ModuleDir()) && !ctx.static() { |
Ivan Lozano | 5f59553 | 2017-07-13 14:46:05 -0700 | [diff] [blame] | 233 | s.Integer_overflow = boolPtr(true) |
| 234 | } |
Ivan Lozano | 0c3a1ef | 2017-06-28 09:10:48 -0700 | [diff] [blame] | 235 | } |
| 236 | |
Kostya Kortchinsky | d18ae5c | 2018-06-12 14:46:54 -0700 | [diff] [blame] | 237 | if found, globalSanitizers = removeFromList("scudo", globalSanitizers); found && s.Scudo == nil { |
| 238 | s.Scudo = boolPtr(true) |
| 239 | } |
| 240 | |
Evgenii Stepanov | d97a6e9 | 2018-08-02 16:19:13 -0700 | [diff] [blame] | 241 | if found, globalSanitizers = removeFromList("hwaddress", globalSanitizers); found && s.Hwaddress == nil { |
| 242 | s.Hwaddress = boolPtr(true) |
| 243 | } |
| 244 | |
Evgenii Stepanov | 05bafd3 | 2016-07-07 17:38:41 +0000 | [diff] [blame] | 245 | if len(globalSanitizers) > 0 { |
| 246 | ctx.ModuleErrorf("unknown global sanitizer option %s", globalSanitizers[0]) |
| 247 | } |
Ivan Lozano | 0c3a1ef | 2017-06-28 09:10:48 -0700 | [diff] [blame] | 248 | |
Ivan Lozano | a9255a8 | 2018-03-13 10:41:07 -0700 | [diff] [blame] | 249 | // Global integer_overflow builds do not support static library diagnostics. |
Ivan Lozano | 0c3a1ef | 2017-06-28 09:10:48 -0700 | [diff] [blame] | 250 | if found, globalSanitizersDiag = removeFromList("integer_overflow", globalSanitizersDiag); found && |
Ivan Lozano | a9255a8 | 2018-03-13 10:41:07 -0700 | [diff] [blame] | 251 | s.Diag.Integer_overflow == nil && Bool(s.Integer_overflow) && !ctx.static() { |
Ivan Lozano | 0c3a1ef | 2017-06-28 09:10:48 -0700 | [diff] [blame] | 252 | s.Diag.Integer_overflow = boolPtr(true) |
| 253 | } |
| 254 | |
Vishwath Mohan | 1fa3ac5 | 2017-10-31 02:26:14 -0700 | [diff] [blame] | 255 | if found, globalSanitizersDiag = removeFromList("cfi", globalSanitizersDiag); found && |
| 256 | s.Diag.Cfi == nil && Bool(s.Cfi) { |
| 257 | s.Diag.Cfi = boolPtr(true) |
| 258 | } |
| 259 | |
Ivan Lozano | 0c3a1ef | 2017-06-28 09:10:48 -0700 | [diff] [blame] | 260 | if len(globalSanitizersDiag) > 0 { |
| 261 | ctx.ModuleErrorf("unknown global sanitizer diagnostics option %s", globalSanitizersDiag[0]) |
| 262 | } |
Evgenii Stepanov | fcfe56d | 2016-07-07 10:54:07 -0700 | [diff] [blame] | 263 | } |
Colin Cross | 3c344ef | 2016-07-18 15:44:56 -0700 | [diff] [blame] | 264 | |
Vishwath Mohan | 1c54f66 | 2018-05-24 18:36:18 -0700 | [diff] [blame] | 265 | // Enable CFI for all components in the include paths (for Aarch64 only) |
| 266 | if s.Cfi == nil && ctx.Config().CFIEnabledForPath(ctx.ModuleDir()) && ctx.Arch().ArchType == android.Arm64 { |
Vishwath Mohan | 3af8ee0 | 2018-03-30 02:55:23 +0000 | [diff] [blame] | 267 | s.Cfi = boolPtr(true) |
| 268 | if inList("cfi", ctx.Config().SanitizeDeviceDiag()) { |
| 269 | s.Diag.Cfi = boolPtr(true) |
Vishwath Mohan | 1fa3ac5 | 2017-10-31 02:26:14 -0700 | [diff] [blame] | 270 | } |
| 271 | } |
| 272 | |
Evgenii Stepanov | a83fdac | 2017-01-31 18:37:30 -0800 | [diff] [blame] | 273 | // CFI needs gold linker, and mips toolchain does not have one. |
Colin Cross | 6510f91 | 2017-11-29 00:27:14 -0800 | [diff] [blame] | 274 | if !ctx.Config().EnableCFI() || ctx.Arch().ArchType == android.Mips || ctx.Arch().ArchType == android.Mips64 { |
Vishwath Mohan | 1b017a7 | 2017-01-19 13:54:55 -0800 | [diff] [blame] | 275 | s.Cfi = nil |
| 276 | s.Diag.Cfi = nil |
| 277 | } |
| 278 | |
Vishwath Mohan | 6d67e6e | 2017-02-07 20:31:41 -0800 | [diff] [blame] | 279 | // Also disable CFI for arm32 until b/35157333 is fixed. |
| 280 | if ctx.Arch().ArchType == android.Arm { |
| 281 | s.Cfi = nil |
| 282 | s.Diag.Cfi = nil |
| 283 | } |
| 284 | |
Evgenii Stepanov | d97a6e9 | 2018-08-02 16:19:13 -0700 | [diff] [blame] | 285 | // HWASan requires AArch64 hardware feature (top-byte-ignore). |
| 286 | if ctx.Arch().ArchType != android.Arm64 { |
| 287 | s.Hwaddress = nil |
| 288 | } |
| 289 | |
Peter Collingbourne | 8c7e6e2 | 2018-11-19 16:03:58 -0800 | [diff] [blame] | 290 | // SCS is only implemented on AArch64. |
| 291 | // We also disable SCS if ASAN, TSAN or HWASAN are enabled because Clang considers |
| 292 | // them to be incompatible, although they are in fact compatible. |
| 293 | // TODO(pcc): Remove these checks once r347282 is rolled into the compiler. |
| 294 | if ctx.Arch().ArchType != android.Arm64 || Bool(s.Address) || Bool(s.Thread) || Bool(s.Hwaddress) { |
| 295 | s.Scs = nil |
| 296 | } |
| 297 | |
Vishwath Mohan | 8f4fdd8 | 2017-04-20 07:42:52 -0700 | [diff] [blame] | 298 | // Also disable CFI if ASAN is enabled. |
Evgenii Stepanov | d97a6e9 | 2018-08-02 16:19:13 -0700 | [diff] [blame] | 299 | if Bool(s.Address) || Bool(s.Hwaddress) { |
Vishwath Mohan | 8f4fdd8 | 2017-04-20 07:42:52 -0700 | [diff] [blame] | 300 | s.Cfi = nil |
| 301 | s.Diag.Cfi = nil |
| 302 | } |
| 303 | |
Ivan Lozano | a9255a8 | 2018-03-13 10:41:07 -0700 | [diff] [blame] | 304 | // Disable sanitizers that depend on the UBSan runtime for host builds. |
Vishwath Mohan | e712879 | 2017-11-17 11:08:10 -0800 | [diff] [blame] | 305 | if ctx.Host() { |
| 306 | s.Cfi = nil |
| 307 | s.Diag.Cfi = nil |
Ivan Lozano | a9255a8 | 2018-03-13 10:41:07 -0700 | [diff] [blame] | 308 | s.Misc_undefined = nil |
| 309 | s.Undefined = nil |
| 310 | s.All_undefined = nil |
| 311 | s.Integer_overflow = nil |
Vishwath Mohan | e712879 | 2017-11-17 11:08:10 -0800 | [diff] [blame] | 312 | } |
| 313 | |
Vishwath Mohan | 9ccbba0 | 2018-05-28 13:54:48 -0700 | [diff] [blame] | 314 | // Also disable CFI for VNDK variants of components |
| 315 | if ctx.isVndk() && ctx.useVndk() { |
Vishwath Mohan | 7589c82 | 2018-05-23 19:29:55 -0700 | [diff] [blame] | 316 | s.Cfi = nil |
| 317 | s.Diag.Cfi = nil |
| 318 | } |
| 319 | |
Evgenii Stepanov | d97a6e9 | 2018-08-02 16:19:13 -0700 | [diff] [blame] | 320 | // HWASan ramdisk (which is built from recovery) goes over some bootloader limit. |
Evgenii Stepanov | 1e79844 | 2018-11-15 17:34:18 -0800 | [diff] [blame] | 321 | // Keep libc instrumented so that recovery can run hwasan-instrumented code if necessary. |
| 322 | if ctx.inRecovery() && !strings.HasPrefix(ctx.ModuleDir(), "bionic/libc") { |
Evgenii Stepanov | d97a6e9 | 2018-08-02 16:19:13 -0700 | [diff] [blame] | 323 | s.Hwaddress = nil |
| 324 | } |
| 325 | |
Colin Cross | 3c344ef | 2016-07-18 15:44:56 -0700 | [diff] [blame] | 326 | if ctx.staticBinary() { |
| 327 | s.Address = nil |
Colin Cross | 91169fe | 2016-08-11 15:54:20 -0700 | [diff] [blame] | 328 | s.Coverage = nil |
Colin Cross | 3c344ef | 2016-07-18 15:44:56 -0700 | [diff] [blame] | 329 | s.Thread = nil |
Colin Cross | 16b2349 | 2016-01-06 14:41:07 -0800 | [diff] [blame] | 330 | } |
| 331 | |
Evgenii Stepanov | fcfe56d | 2016-07-07 10:54:07 -0700 | [diff] [blame] | 332 | if Bool(s.All_undefined) { |
| 333 | s.Undefined = nil |
| 334 | } |
| 335 | |
Evgenii Stepanov | 0a8a0d0 | 2016-05-12 13:54:53 -0700 | [diff] [blame] | 336 | if !ctx.toolchain().Is64Bit() { |
| 337 | // TSAN and SafeStack are not supported on 32-bit architectures |
Evgenii Stepanov | fcfe56d | 2016-07-07 10:54:07 -0700 | [diff] [blame] | 338 | s.Thread = nil |
| 339 | s.Safestack = nil |
Colin Cross | 16b2349 | 2016-01-06 14:41:07 -0800 | [diff] [blame] | 340 | // TODO(ccross): error for compile_multilib = "32"? |
| 341 | } |
| 342 | |
Evgenii Stepanov | 76cee23 | 2017-01-27 15:44:44 -0800 | [diff] [blame] | 343 | if ctx.Os() != android.Windows && (Bool(s.All_undefined) || Bool(s.Undefined) || Bool(s.Address) || Bool(s.Thread) || |
Kostya Kortchinsky | d18ae5c | 2018-06-12 14:46:54 -0700 | [diff] [blame] | 344 | Bool(s.Coverage) || Bool(s.Safestack) || Bool(s.Cfi) || Bool(s.Integer_overflow) || len(s.Misc_undefined) > 0 || |
Peter Collingbourne | 8c7e6e2 | 2018-11-19 16:03:58 -0800 | [diff] [blame] | 345 | Bool(s.Scudo) || Bool(s.Hwaddress) || Bool(s.Scs)) { |
Colin Cross | 3c344ef | 2016-07-18 15:44:56 -0700 | [diff] [blame] | 346 | sanitize.Properties.SanitizerEnabled = true |
| 347 | } |
| 348 | |
Kostya Kortchinsky | d18ae5c | 2018-06-12 14:46:54 -0700 | [diff] [blame] | 349 | // Disable Scudo if ASan or TSan is enabled. |
Evgenii Stepanov | d97a6e9 | 2018-08-02 16:19:13 -0700 | [diff] [blame] | 350 | if Bool(s.Address) || Bool(s.Thread) || Bool(s.Hwaddress) { |
Kostya Kortchinsky | d18ae5c | 2018-06-12 14:46:54 -0700 | [diff] [blame] | 351 | s.Scudo = nil |
| 352 | } |
| 353 | |
Evgenii Stepanov | d97a6e9 | 2018-08-02 16:19:13 -0700 | [diff] [blame] | 354 | if Bool(s.Hwaddress) { |
| 355 | s.Address = nil |
| 356 | s.Thread = nil |
| 357 | } |
| 358 | |
Evgenii Stepanov | fcfe56d | 2016-07-07 10:54:07 -0700 | [diff] [blame] | 359 | if Bool(s.Coverage) { |
| 360 | if !Bool(s.Address) { |
Colin Cross | 16b2349 | 2016-01-06 14:41:07 -0800 | [diff] [blame] | 361 | ctx.ModuleErrorf(`Use of "coverage" also requires "address"`) |
| 362 | } |
| 363 | } |
| 364 | } |
| 365 | |
| 366 | func (sanitize *sanitize) deps(ctx BaseModuleContext, deps Deps) Deps { |
| 367 | if !sanitize.Properties.SanitizerEnabled { // || c.static() { |
| 368 | return deps |
| 369 | } |
| 370 | |
| 371 | if ctx.Device() { |
Evgenii Stepanov | fcfe56d | 2016-07-07 10:54:07 -0700 | [diff] [blame] | 372 | if Bool(sanitize.Properties.Sanitize.Address) { |
Jayant Chowdhary | 9677e8c | 2017-06-15 14:45:18 -0700 | [diff] [blame] | 373 | deps.StaticLibs = append(deps.StaticLibs, asanLibs...) |
Colin Cross | 16b2349 | 2016-01-06 14:41:07 -0800 | [diff] [blame] | 374 | } |
| 375 | } |
| 376 | |
| 377 | return deps |
| 378 | } |
| 379 | |
Chih-Hung Hsieh | 3567e62 | 2018-11-15 14:01:36 -0800 | [diff] [blame] | 380 | func toDisableImplicitIntegerChange(flags []string) bool { |
| 381 | // Returns true if any flag is fsanitize*integer, and there is |
| 382 | // no explicit flag about sanitize=implicit-integer-sign-change. |
| 383 | for _, f := range flags { |
| 384 | if strings.Contains(f, "sanitize=implicit-integer-sign-change") { |
| 385 | return false |
| 386 | } |
| 387 | } |
| 388 | for _, f := range flags { |
| 389 | if strings.HasPrefix(f, "-fsanitize") && strings.Contains(f, "integer") { |
| 390 | return true |
| 391 | } |
| 392 | } |
| 393 | return false |
| 394 | } |
| 395 | |
Colin Cross | 16b2349 | 2016-01-06 14:41:07 -0800 | [diff] [blame] | 396 | func (sanitize *sanitize) flags(ctx ModuleContext, flags Flags) Flags { |
Ivan Lozano | 59fdea2 | 2018-05-10 14:17:22 -0700 | [diff] [blame] | 397 | minimalRuntimeLib := config.UndefinedBehaviorSanitizerMinimalRuntimeLibrary(ctx.toolchain()) + ".a" |
| 398 | minimalRuntimePath := "${config.ClangAsanLibDir}/" + minimalRuntimeLib |
Ivan Lozano | 30c5db2 | 2018-02-21 15:49:20 -0800 | [diff] [blame] | 399 | |
| 400 | if ctx.Device() && sanitize.Properties.MinimalRuntimeDep { |
| 401 | flags.LdFlags = append(flags.LdFlags, minimalRuntimePath) |
Ivan Lozano | 59fdea2 | 2018-05-10 14:17:22 -0700 | [diff] [blame] | 402 | flags.LdFlags = append(flags.LdFlags, "-Wl,--exclude-libs,"+minimalRuntimeLib) |
Ivan Lozano | 30c5db2 | 2018-02-21 15:49:20 -0800 | [diff] [blame] | 403 | } |
Ivan Lozano | a9255a8 | 2018-03-13 10:41:07 -0700 | [diff] [blame] | 404 | if !sanitize.Properties.SanitizerEnabled && !sanitize.Properties.UbsanRuntimeDep { |
Colin Cross | 16b2349 | 2016-01-06 14:41:07 -0800 | [diff] [blame] | 405 | return flags |
| 406 | } |
| 407 | |
Colin Cross | 16b2349 | 2016-01-06 14:41:07 -0800 | [diff] [blame] | 408 | var sanitizers []string |
Evgenii Stepanov | 1e405e1 | 2016-08-16 15:39:54 -0700 | [diff] [blame] | 409 | var diagSanitizers []string |
Colin Cross | 16b2349 | 2016-01-06 14:41:07 -0800 | [diff] [blame] | 410 | |
Evgenii Stepanov | fcfe56d | 2016-07-07 10:54:07 -0700 | [diff] [blame] | 411 | if Bool(sanitize.Properties.Sanitize.All_undefined) { |
Colin Cross | 16b2349 | 2016-01-06 14:41:07 -0800 | [diff] [blame] | 412 | sanitizers = append(sanitizers, "undefined") |
Colin Cross | 16b2349 | 2016-01-06 14:41:07 -0800 | [diff] [blame] | 413 | } else { |
Evgenii Stepanov | fcfe56d | 2016-07-07 10:54:07 -0700 | [diff] [blame] | 414 | if Bool(sanitize.Properties.Sanitize.Undefined) { |
Colin Cross | 16b2349 | 2016-01-06 14:41:07 -0800 | [diff] [blame] | 415 | sanitizers = append(sanitizers, |
| 416 | "bool", |
| 417 | "integer-divide-by-zero", |
| 418 | "return", |
| 419 | "returns-nonnull-attribute", |
| 420 | "shift-exponent", |
| 421 | "unreachable", |
| 422 | "vla-bound", |
| 423 | // TODO(danalbert): The following checks currently have compiler performance issues. |
| 424 | //"alignment", |
| 425 | //"bounds", |
| 426 | //"enum", |
| 427 | //"float-cast-overflow", |
| 428 | //"float-divide-by-zero", |
| 429 | //"nonnull-attribute", |
| 430 | //"null", |
| 431 | //"shift-base", |
| 432 | //"signed-integer-overflow", |
| 433 | // TODO(danalbert): Fix UB in libc++'s __tree so we can turn this on. |
| 434 | // https://llvm.org/PR19302 |
| 435 | // http://reviews.llvm.org/D6974 |
| 436 | // "object-size", |
| 437 | ) |
| 438 | } |
| 439 | sanitizers = append(sanitizers, sanitize.Properties.Sanitize.Misc_undefined...) |
| 440 | } |
| 441 | |
Ivan Lozano | 651275b | 2017-06-13 10:24:34 -0700 | [diff] [blame] | 442 | if Bool(sanitize.Properties.Sanitize.Diag.Undefined) { |
Evgenii Stepanov | 1e405e1 | 2016-08-16 15:39:54 -0700 | [diff] [blame] | 443 | diagSanitizers = append(diagSanitizers, "undefined") |
| 444 | } |
| 445 | |
Ivan Lozano | 651275b | 2017-06-13 10:24:34 -0700 | [diff] [blame] | 446 | diagSanitizers = append(diagSanitizers, sanitize.Properties.Sanitize.Diag.Misc_undefined...) |
| 447 | |
Evgenii Stepanov | fcfe56d | 2016-07-07 10:54:07 -0700 | [diff] [blame] | 448 | if Bool(sanitize.Properties.Sanitize.Address) { |
Colin Cross | 635c3b0 | 2016-05-18 15:37:25 -0700 | [diff] [blame] | 449 | if ctx.Arch().ArchType == android.Arm { |
Colin Cross | 16b2349 | 2016-01-06 14:41:07 -0800 | [diff] [blame] | 450 | // Frame pointer based unwinder in ASan requires ARM frame setup. |
| 451 | // TODO: put in flags? |
| 452 | flags.RequiredInstructionSet = "arm" |
| 453 | } |
Jayant Chowdhary | 9677e8c | 2017-06-15 14:45:18 -0700 | [diff] [blame] | 454 | flags.CFlags = append(flags.CFlags, asanCflags...) |
| 455 | flags.LdFlags = append(flags.LdFlags, asanLdflags...) |
Colin Cross | 16b2349 | 2016-01-06 14:41:07 -0800 | [diff] [blame] | 456 | |
Colin Cross | 16b2349 | 2016-01-06 14:41:07 -0800 | [diff] [blame] | 457 | if ctx.Host() { |
| 458 | // -nodefaultlibs (provided with libc++) prevents the driver from linking |
| 459 | // libraries needed with -fsanitize=address. http://b/18650275 (WAI) |
Colin Cross | 16b2349 | 2016-01-06 14:41:07 -0800 | [diff] [blame] | 460 | flags.LdFlags = append(flags.LdFlags, "-Wl,--no-as-needed") |
| 461 | } else { |
| 462 | flags.CFlags = append(flags.CFlags, "-mllvm", "-asan-globals=0") |
| 463 | flags.DynamicLinker = "/system/bin/linker_asan" |
| 464 | if flags.Toolchain.Is64Bit() { |
| 465 | flags.DynamicLinker += "64" |
| 466 | } |
| 467 | } |
| 468 | sanitizers = append(sanitizers, "address") |
Evgenii Stepanov | 1e405e1 | 2016-08-16 15:39:54 -0700 | [diff] [blame] | 469 | diagSanitizers = append(diagSanitizers, "address") |
Colin Cross | 16b2349 | 2016-01-06 14:41:07 -0800 | [diff] [blame] | 470 | } |
| 471 | |
Evgenii Stepanov | d97a6e9 | 2018-08-02 16:19:13 -0700 | [diff] [blame] | 472 | if Bool(sanitize.Properties.Sanitize.Hwaddress) { |
| 473 | flags.CFlags = append(flags.CFlags, hwasanCflags...) |
| 474 | sanitizers = append(sanitizers, "hwaddress") |
| 475 | } |
| 476 | |
Yabin Cui | 6be405e | 2017-10-19 15:52:11 -0700 | [diff] [blame] | 477 | if Bool(sanitize.Properties.Sanitize.Thread) { |
| 478 | sanitizers = append(sanitizers, "thread") |
| 479 | } |
| 480 | |
Evgenii Stepanov | fcfe56d | 2016-07-07 10:54:07 -0700 | [diff] [blame] | 481 | if Bool(sanitize.Properties.Sanitize.Coverage) { |
Zach Riggle | 06bbd89 | 2017-08-21 17:12:32 -0400 | [diff] [blame] | 482 | flags.CFlags = append(flags.CFlags, "-fsanitize-coverage=trace-pc-guard,indirect-calls,trace-cmp") |
Colin Cross | 16b2349 | 2016-01-06 14:41:07 -0800 | [diff] [blame] | 483 | } |
| 484 | |
Evgenii Stepanov | fcfe56d | 2016-07-07 10:54:07 -0700 | [diff] [blame] | 485 | if Bool(sanitize.Properties.Sanitize.Safestack) { |
Evgenii Stepanov | 0a8a0d0 | 2016-05-12 13:54:53 -0700 | [diff] [blame] | 486 | sanitizers = append(sanitizers, "safe-stack") |
| 487 | } |
| 488 | |
Evgenii Stepanov | 1e405e1 | 2016-08-16 15:39:54 -0700 | [diff] [blame] | 489 | if Bool(sanitize.Properties.Sanitize.Cfi) { |
Evgenii Stepanov | 7ebf9fa | 2017-01-20 14:13:06 -0800 | [diff] [blame] | 490 | if ctx.Arch().ArchType == android.Arm { |
| 491 | // __cfi_check needs to be built as Thumb (see the code in linker_cfi.cpp). LLVM is not set up |
| 492 | // to do this on a function basis, so force Thumb on the entire module. |
| 493 | flags.RequiredInstructionSet = "thumb" |
| 494 | } |
Evgenii Stepanov | 1e405e1 | 2016-08-16 15:39:54 -0700 | [diff] [blame] | 495 | sanitizers = append(sanitizers, "cfi") |
Vishwath Mohan | b743e9c | 2017-11-01 09:20:21 +0000 | [diff] [blame] | 496 | |
Jayant Chowdhary | 9677e8c | 2017-06-15 14:45:18 -0700 | [diff] [blame] | 497 | flags.CFlags = append(flags.CFlags, cfiCflags...) |
Evgenii Stepanov | dbf1d4f | 2018-08-31 12:54:33 -0700 | [diff] [blame] | 498 | flags.AsFlags = append(flags.AsFlags, cfiAsflags...) |
Vishwath Mohan | b743e9c | 2017-11-01 09:20:21 +0000 | [diff] [blame] | 499 | // Only append the default visibility flag if -fvisibility has not already been set |
| 500 | // to hidden. |
| 501 | if !inList("-fvisibility=hidden", flags.CFlags) { |
| 502 | flags.CFlags = append(flags.CFlags, "-fvisibility=default") |
| 503 | } |
Jayant Chowdhary | 9677e8c | 2017-06-15 14:45:18 -0700 | [diff] [blame] | 504 | flags.LdFlags = append(flags.LdFlags, cfiLdflags...) |
Evgenii Stepanov | 1e405e1 | 2016-08-16 15:39:54 -0700 | [diff] [blame] | 505 | if Bool(sanitize.Properties.Sanitize.Diag.Cfi) { |
| 506 | diagSanitizers = append(diagSanitizers, "cfi") |
| 507 | } |
Vishwath Mohan | b743e9c | 2017-11-01 09:20:21 +0000 | [diff] [blame] | 508 | |
| 509 | if ctx.staticBinary() { |
| 510 | _, flags.CFlags = removeFromList("-fsanitize-cfi-cross-dso", flags.CFlags) |
| 511 | _, flags.LdFlags = removeFromList("-fsanitize-cfi-cross-dso", flags.LdFlags) |
| 512 | } |
Evgenii Stepanov | 1e405e1 | 2016-08-16 15:39:54 -0700 | [diff] [blame] | 513 | } |
| 514 | |
Ivan Lozano | 0c3a1ef | 2017-06-28 09:10:48 -0700 | [diff] [blame] | 515 | if Bool(sanitize.Properties.Sanitize.Integer_overflow) { |
Ivan Lozano | a9255a8 | 2018-03-13 10:41:07 -0700 | [diff] [blame] | 516 | sanitizers = append(sanitizers, "unsigned-integer-overflow") |
| 517 | sanitizers = append(sanitizers, "signed-integer-overflow") |
| 518 | flags.CFlags = append(flags.CFlags, intOverflowCflags...) |
| 519 | if Bool(sanitize.Properties.Sanitize.Diag.Integer_overflow) { |
| 520 | diagSanitizers = append(diagSanitizers, "unsigned-integer-overflow") |
| 521 | diagSanitizers = append(diagSanitizers, "signed-integer-overflow") |
Ivan Lozano | 0c3a1ef | 2017-06-28 09:10:48 -0700 | [diff] [blame] | 522 | } |
| 523 | } |
| 524 | |
Kostya Kortchinsky | d18ae5c | 2018-06-12 14:46:54 -0700 | [diff] [blame] | 525 | if Bool(sanitize.Properties.Sanitize.Scudo) { |
| 526 | sanitizers = append(sanitizers, "scudo") |
| 527 | } |
| 528 | |
Peter Collingbourne | 8c7e6e2 | 2018-11-19 16:03:58 -0800 | [diff] [blame] | 529 | if Bool(sanitize.Properties.Sanitize.Scs) { |
| 530 | sanitizers = append(sanitizers, "shadow-call-stack") |
| 531 | } |
| 532 | |
Colin Cross | 16b2349 | 2016-01-06 14:41:07 -0800 | [diff] [blame] | 533 | if len(sanitizers) > 0 { |
| 534 | sanitizeArg := "-fsanitize=" + strings.Join(sanitizers, ",") |
Ivan Lozano | 30c5db2 | 2018-02-21 15:49:20 -0800 | [diff] [blame] | 535 | |
Colin Cross | 16b2349 | 2016-01-06 14:41:07 -0800 | [diff] [blame] | 536 | flags.CFlags = append(flags.CFlags, sanitizeArg) |
Evgenii Stepanov | dbf1d4f | 2018-08-31 12:54:33 -0700 | [diff] [blame] | 537 | flags.AsFlags = append(flags.AsFlags, sanitizeArg) |
Colin Cross | 16b2349 | 2016-01-06 14:41:07 -0800 | [diff] [blame] | 538 | if ctx.Host() { |
| 539 | flags.CFlags = append(flags.CFlags, "-fno-sanitize-recover=all") |
| 540 | flags.LdFlags = append(flags.LdFlags, sanitizeArg) |
Evgenii Stepanov | 76cee23 | 2017-01-27 15:44:44 -0800 | [diff] [blame] | 541 | // Host sanitizers only link symbols in the final executable, so |
| 542 | // there will always be undefined symbols in intermediate libraries. |
| 543 | _, flags.LdFlags = removeFromList("-Wl,--no-undefined", flags.LdFlags) |
Colin Cross | 16b2349 | 2016-01-06 14:41:07 -0800 | [diff] [blame] | 544 | } else { |
Colin Cross | 263abbd | 2016-07-15 13:10:48 -0700 | [diff] [blame] | 545 | flags.CFlags = append(flags.CFlags, "-fsanitize-trap=all", "-ftrap-function=abort") |
Ivan Lozano | 30c5db2 | 2018-02-21 15:49:20 -0800 | [diff] [blame] | 546 | |
| 547 | if enableMinimalRuntime(sanitize) { |
| 548 | flags.CFlags = append(flags.CFlags, strings.Join(minimalRuntimeFlags, " ")) |
| 549 | flags.libFlags = append([]string{minimalRuntimePath}, flags.libFlags...) |
Ivan Lozano | 59fdea2 | 2018-05-10 14:17:22 -0700 | [diff] [blame] | 550 | flags.LdFlags = append(flags.LdFlags, "-Wl,--exclude-libs,"+minimalRuntimeLib) |
Ivan Lozano | 30c5db2 | 2018-02-21 15:49:20 -0800 | [diff] [blame] | 551 | } |
Colin Cross | 16b2349 | 2016-01-06 14:41:07 -0800 | [diff] [blame] | 552 | } |
Chih-Hung Hsieh | 3567e62 | 2018-11-15 14:01:36 -0800 | [diff] [blame] | 553 | // http://b/119329758, Android core does not boot up with this sanitizer yet. |
| 554 | if toDisableImplicitIntegerChange(flags.CFlags) { |
| 555 | flags.CFlags = append(flags.CFlags, "-fno-sanitize=implicit-integer-sign-change") |
| 556 | } |
Colin Cross | 16b2349 | 2016-01-06 14:41:07 -0800 | [diff] [blame] | 557 | } |
| 558 | |
Evgenii Stepanov | 1e405e1 | 2016-08-16 15:39:54 -0700 | [diff] [blame] | 559 | if len(diagSanitizers) > 0 { |
Ivan Lozano | b7d0f52 | 2018-01-20 01:44:38 +0000 | [diff] [blame] | 560 | flags.CFlags = append(flags.CFlags, "-fno-sanitize-trap="+strings.Join(diagSanitizers, ",")) |
Evgenii Stepanov | 1e405e1 | 2016-08-16 15:39:54 -0700 | [diff] [blame] | 561 | } |
| 562 | // FIXME: enable RTTI if diag + (cfi or vptr) |
| 563 | |
Andreas Gampe | 9707116 | 2017-05-08 13:15:23 -0700 | [diff] [blame] | 564 | if sanitize.Properties.Sanitize.Recover != nil { |
| 565 | flags.CFlags = append(flags.CFlags, "-fsanitize-recover="+ |
| 566 | strings.Join(sanitize.Properties.Sanitize.Recover, ",")) |
| 567 | } |
| 568 | |
Ivan Lozano | 7929bba | 2018-12-12 09:36:31 -0800 | [diff] [blame^] | 569 | if sanitize.Properties.Sanitize.Diag.No_recover != nil { |
| 570 | flags.CFlags = append(flags.CFlags, "-fno-sanitize-recover="+ |
| 571 | strings.Join(sanitize.Properties.Sanitize.Diag.No_recover, ",")) |
| 572 | } |
| 573 | |
Evgenii Stepanov | 1e405e1 | 2016-08-16 15:39:54 -0700 | [diff] [blame] | 574 | // Link a runtime library if needed. |
| 575 | runtimeLibrary := "" |
| 576 | if Bool(sanitize.Properties.Sanitize.Address) { |
| 577 | runtimeLibrary = config.AddressSanitizerRuntimeLibrary(ctx.toolchain()) |
Evgenii Stepanov | d97a6e9 | 2018-08-02 16:19:13 -0700 | [diff] [blame] | 578 | } else if Bool(sanitize.Properties.Sanitize.Hwaddress) { |
| 579 | runtimeLibrary = config.HWAddressSanitizerRuntimeLibrary(ctx.toolchain()) |
Yabin Cui | 6be405e | 2017-10-19 15:52:11 -0700 | [diff] [blame] | 580 | } else if Bool(sanitize.Properties.Sanitize.Thread) { |
| 581 | runtimeLibrary = config.ThreadSanitizerRuntimeLibrary(ctx.toolchain()) |
Kostya Kortchinsky | d18ae5c | 2018-06-12 14:46:54 -0700 | [diff] [blame] | 582 | } else if Bool(sanitize.Properties.Sanitize.Scudo) { |
Kostya Kortchinsky | ad73b2e | 2018-10-11 08:38:39 -0700 | [diff] [blame] | 583 | if len(diagSanitizers) == 0 && !sanitize.Properties.UbsanRuntimeDep { |
| 584 | runtimeLibrary = config.ScudoMinimalRuntimeLibrary(ctx.toolchain()) |
| 585 | } else { |
| 586 | runtimeLibrary = config.ScudoRuntimeLibrary(ctx.toolchain()) |
| 587 | } |
Ivan Lozano | a9255a8 | 2018-03-13 10:41:07 -0700 | [diff] [blame] | 588 | } else if len(diagSanitizers) > 0 || sanitize.Properties.UbsanRuntimeDep { |
Evgenii Stepanov | 1e405e1 | 2016-08-16 15:39:54 -0700 | [diff] [blame] | 589 | runtimeLibrary = config.UndefinedBehaviorSanitizerRuntimeLibrary(ctx.toolchain()) |
| 590 | } |
| 591 | |
Evgenii Stepanov | 1e405e1 | 2016-08-16 15:39:54 -0700 | [diff] [blame] | 592 | if runtimeLibrary != "" { |
Ivan Lozano | a9255a8 | 2018-03-13 10:41:07 -0700 | [diff] [blame] | 593 | runtimeLibraryPath := "${config.ClangAsanLibDir}/" + runtimeLibrary |
| 594 | if !ctx.static() { |
| 595 | runtimeLibraryPath = runtimeLibraryPath + ctx.toolchain().ShlibSuffix() |
| 596 | } else { |
| 597 | runtimeLibraryPath = runtimeLibraryPath + ".a" |
| 598 | } |
| 599 | |
Jiyong Park | 27b188b | 2017-07-18 13:23:39 +0900 | [diff] [blame] | 600 | // ASan runtime library must be the first in the link order. |
Ivan Lozano | a9255a8 | 2018-03-13 10:41:07 -0700 | [diff] [blame] | 601 | flags.libFlags = append([]string{runtimeLibraryPath}, flags.libFlags...) |
Colin Cross | 8ff9ef4 | 2017-05-08 13:44:11 -0700 | [diff] [blame] | 602 | sanitize.runtimeLibrary = runtimeLibrary |
Jiyong Park | 27b188b | 2017-07-18 13:23:39 +0900 | [diff] [blame] | 603 | |
| 604 | // When linking against VNDK, use the vendor variant of the runtime lib |
Jeff Gaston | af3cc2d | 2017-09-27 17:01:44 -0700 | [diff] [blame] | 605 | if ctx.useVndk() { |
Jiyong Park | 27b188b | 2017-07-18 13:23:39 +0900 | [diff] [blame] | 606 | sanitize.androidMkRuntimeLibrary = sanitize.runtimeLibrary + vendorSuffix |
Evgenii Stepanov | 98f5b06 | 2018-11-29 15:12:51 -0800 | [diff] [blame] | 607 | } else if ctx.inRecovery() { |
| 608 | sanitize.androidMkRuntimeLibrary = sanitize.runtimeLibrary + recoverySuffix |
| 609 | } else { |
| 610 | sanitize.androidMkRuntimeLibrary = sanitize.runtimeLibrary |
Jiyong Park | 27b188b | 2017-07-18 13:23:39 +0900 | [diff] [blame] | 611 | } |
Evgenii Stepanov | 1e405e1 | 2016-08-16 15:39:54 -0700 | [diff] [blame] | 612 | } |
| 613 | |
Colin Cross | 635c3b0 | 2016-05-18 15:37:25 -0700 | [diff] [blame] | 614 | blacklist := android.OptionalPathForModuleSrc(ctx, sanitize.Properties.Sanitize.Blacklist) |
Colin Cross | 16b2349 | 2016-01-06 14:41:07 -0800 | [diff] [blame] | 615 | if blacklist.Valid() { |
| 616 | flags.CFlags = append(flags.CFlags, "-fsanitize-blacklist="+blacklist.String()) |
| 617 | flags.CFlagsDeps = append(flags.CFlagsDeps, blacklist.Path()) |
| 618 | } |
| 619 | |
| 620 | return flags |
| 621 | } |
| 622 | |
Colin Cross | 8ff9ef4 | 2017-05-08 13:44:11 -0700 | [diff] [blame] | 623 | func (sanitize *sanitize) AndroidMk(ctx AndroidMkContext, ret *android.AndroidMkData) { |
Colin Cross | 27a4b05 | 2017-08-10 16:32:23 -0700 | [diff] [blame] | 624 | ret.Extra = append(ret.Extra, func(w io.Writer, outputFile android.Path) { |
Jiyong Park | 27b188b | 2017-07-18 13:23:39 +0900 | [diff] [blame] | 625 | if sanitize.androidMkRuntimeLibrary != "" { |
| 626 | fmt.Fprintln(w, "LOCAL_SHARED_LIBRARIES += "+sanitize.androidMkRuntimeLibrary) |
Colin Cross | 8ff9ef4 | 2017-05-08 13:44:11 -0700 | [diff] [blame] | 627 | } |
Colin Cross | 8ff9ef4 | 2017-05-08 13:44:11 -0700 | [diff] [blame] | 628 | }) |
Vishwath Mohan | e712879 | 2017-11-17 11:08:10 -0800 | [diff] [blame] | 629 | |
| 630 | // Add a suffix for CFI-enabled static libraries to allow surfacing both to make without a |
| 631 | // name conflict. |
| 632 | if ret.Class == "STATIC_LIBRARIES" && Bool(sanitize.Properties.Sanitize.Cfi) { |
| 633 | ret.SubName += ".cfi" |
Vishwath Mohan | b743e9c | 2017-11-01 09:20:21 +0000 | [diff] [blame] | 634 | } |
Evgenii Stepanov | d97a6e9 | 2018-08-02 16:19:13 -0700 | [diff] [blame] | 635 | if ret.Class == "STATIC_LIBRARIES" && Bool(sanitize.Properties.Sanitize.Hwaddress) { |
| 636 | ret.SubName += ".hwasan" |
| 637 | } |
Peter Collingbourne | 8c7e6e2 | 2018-11-19 16:03:58 -0800 | [diff] [blame] | 638 | if ret.Class == "STATIC_LIBRARIES" && Bool(sanitize.Properties.Sanitize.Scs) { |
| 639 | ret.SubName += ".scs" |
| 640 | } |
Colin Cross | 8ff9ef4 | 2017-05-08 13:44:11 -0700 | [diff] [blame] | 641 | } |
| 642 | |
Vishwath Mohan | 1dd8839 | 2017-03-29 22:00:18 -0700 | [diff] [blame] | 643 | func (sanitize *sanitize) inSanitizerDir() bool { |
| 644 | return sanitize.Properties.InSanitizerDir |
Colin Cross | 30d5f51 | 2016-05-03 18:02:42 -0700 | [diff] [blame] | 645 | } |
| 646 | |
Vishwath Mohan | b743e9c | 2017-11-01 09:20:21 +0000 | [diff] [blame] | 647 | func (sanitize *sanitize) getSanitizerBoolPtr(t sanitizerType) *bool { |
Vishwath Mohan | 9522930 | 2017-08-11 00:53:16 +0000 | [diff] [blame] | 648 | switch t { |
| 649 | case asan: |
Vishwath Mohan | b743e9c | 2017-11-01 09:20:21 +0000 | [diff] [blame] | 650 | return sanitize.Properties.Sanitize.Address |
Evgenii Stepanov | d97a6e9 | 2018-08-02 16:19:13 -0700 | [diff] [blame] | 651 | case hwasan: |
| 652 | return sanitize.Properties.Sanitize.Hwaddress |
Vishwath Mohan | 9522930 | 2017-08-11 00:53:16 +0000 | [diff] [blame] | 653 | case tsan: |
Vishwath Mohan | b743e9c | 2017-11-01 09:20:21 +0000 | [diff] [blame] | 654 | return sanitize.Properties.Sanitize.Thread |
Vishwath Mohan | 9522930 | 2017-08-11 00:53:16 +0000 | [diff] [blame] | 655 | case intOverflow: |
Vishwath Mohan | b743e9c | 2017-11-01 09:20:21 +0000 | [diff] [blame] | 656 | return sanitize.Properties.Sanitize.Integer_overflow |
| 657 | case cfi: |
| 658 | return sanitize.Properties.Sanitize.Cfi |
Peter Collingbourne | 8c7e6e2 | 2018-11-19 16:03:58 -0800 | [diff] [blame] | 659 | case scs: |
| 660 | return sanitize.Properties.Sanitize.Scs |
Vishwath Mohan | 9522930 | 2017-08-11 00:53:16 +0000 | [diff] [blame] | 661 | default: |
| 662 | panic(fmt.Errorf("unknown sanitizerType %d", t)) |
| 663 | } |
| 664 | } |
| 665 | |
Dan Albert | 7d1eecf | 2018-01-19 12:30:45 -0800 | [diff] [blame] | 666 | func (sanitize *sanitize) isUnsanitizedVariant() bool { |
| 667 | return !sanitize.isSanitizerEnabled(asan) && |
Evgenii Stepanov | d97a6e9 | 2018-08-02 16:19:13 -0700 | [diff] [blame] | 668 | !sanitize.isSanitizerEnabled(hwasan) && |
Dan Albert | 7d1eecf | 2018-01-19 12:30:45 -0800 | [diff] [blame] | 669 | !sanitize.isSanitizerEnabled(tsan) && |
Peter Collingbourne | 8c7e6e2 | 2018-11-19 16:03:58 -0800 | [diff] [blame] | 670 | !sanitize.isSanitizerEnabled(cfi) && |
| 671 | !sanitize.isSanitizerEnabled(scs) |
Dan Albert | 7d1eecf | 2018-01-19 12:30:45 -0800 | [diff] [blame] | 672 | } |
| 673 | |
Jayant Chowdhary | b7e08ca | 2018-05-10 15:29:24 -0700 | [diff] [blame] | 674 | func (sanitize *sanitize) isVariantOnProductionDevice() bool { |
| 675 | return !sanitize.isSanitizerEnabled(asan) && |
Evgenii Stepanov | d97a6e9 | 2018-08-02 16:19:13 -0700 | [diff] [blame] | 676 | !sanitize.isSanitizerEnabled(hwasan) && |
Jayant Chowdhary | b7e08ca | 2018-05-10 15:29:24 -0700 | [diff] [blame] | 677 | !sanitize.isSanitizerEnabled(tsan) |
| 678 | } |
| 679 | |
Colin Cross | 16b2349 | 2016-01-06 14:41:07 -0800 | [diff] [blame] | 680 | func (sanitize *sanitize) SetSanitizer(t sanitizerType, b bool) { |
| 681 | switch t { |
| 682 | case asan: |
Evgenii Stepanov | fcfe56d | 2016-07-07 10:54:07 -0700 | [diff] [blame] | 683 | sanitize.Properties.Sanitize.Address = boolPtr(b) |
Colin Cross | 91169fe | 2016-08-11 15:54:20 -0700 | [diff] [blame] | 684 | if !b { |
| 685 | sanitize.Properties.Sanitize.Coverage = nil |
| 686 | } |
Evgenii Stepanov | d97a6e9 | 2018-08-02 16:19:13 -0700 | [diff] [blame] | 687 | case hwasan: |
| 688 | sanitize.Properties.Sanitize.Hwaddress = boolPtr(b) |
Colin Cross | 16b2349 | 2016-01-06 14:41:07 -0800 | [diff] [blame] | 689 | case tsan: |
Evgenii Stepanov | fcfe56d | 2016-07-07 10:54:07 -0700 | [diff] [blame] | 690 | sanitize.Properties.Sanitize.Thread = boolPtr(b) |
Ivan Lozano | 0c3a1ef | 2017-06-28 09:10:48 -0700 | [diff] [blame] | 691 | case intOverflow: |
| 692 | sanitize.Properties.Sanitize.Integer_overflow = boolPtr(b) |
Vishwath Mohan | b743e9c | 2017-11-01 09:20:21 +0000 | [diff] [blame] | 693 | case cfi: |
| 694 | sanitize.Properties.Sanitize.Cfi = boolPtr(b) |
Peter Collingbourne | 8c7e6e2 | 2018-11-19 16:03:58 -0800 | [diff] [blame] | 695 | case scs: |
| 696 | sanitize.Properties.Sanitize.Scs = boolPtr(b) |
Colin Cross | 16b2349 | 2016-01-06 14:41:07 -0800 | [diff] [blame] | 697 | default: |
| 698 | panic(fmt.Errorf("unknown sanitizerType %d", t)) |
| 699 | } |
| 700 | if b { |
| 701 | sanitize.Properties.SanitizerEnabled = true |
| 702 | } |
| 703 | } |
| 704 | |
Vishwath Mohan | b743e9c | 2017-11-01 09:20:21 +0000 | [diff] [blame] | 705 | // Check if the sanitizer is explicitly disabled (as opposed to nil by |
| 706 | // virtue of not being set). |
| 707 | func (sanitize *sanitize) isSanitizerExplicitlyDisabled(t sanitizerType) bool { |
| 708 | if sanitize == nil { |
| 709 | return false |
| 710 | } |
| 711 | |
| 712 | sanitizerVal := sanitize.getSanitizerBoolPtr(t) |
| 713 | return sanitizerVal != nil && *sanitizerVal == false |
| 714 | } |
| 715 | |
| 716 | // There isn't an analog of the method above (ie:isSanitizerExplicitlyEnabled) |
| 717 | // because enabling a sanitizer either directly (via the blueprint) or |
| 718 | // indirectly (via a mutator) sets the bool ptr to true, and you can't |
| 719 | // distinguish between the cases. It isn't needed though - both cases can be |
| 720 | // treated identically. |
| 721 | func (sanitize *sanitize) isSanitizerEnabled(t sanitizerType) bool { |
| 722 | if sanitize == nil { |
| 723 | return false |
| 724 | } |
| 725 | |
| 726 | sanitizerVal := sanitize.getSanitizerBoolPtr(t) |
| 727 | return sanitizerVal != nil && *sanitizerVal == true |
| 728 | } |
| 729 | |
Colin Cross | 6b75360 | 2018-06-21 13:03:07 -0700 | [diff] [blame] | 730 | func isSanitizableDependencyTag(tag blueprint.DependencyTag) bool { |
| 731 | t, ok := tag.(dependencyTag) |
| 732 | return ok && t.library || t == reuseObjTag |
| 733 | } |
| 734 | |
Evgenii Stepanov | d97a6e9 | 2018-08-02 16:19:13 -0700 | [diff] [blame] | 735 | // Propagate sanitizer requirements down from binaries |
Colin Cross | 635c3b0 | 2016-05-18 15:37:25 -0700 | [diff] [blame] | 736 | func sanitizerDepsMutator(t sanitizerType) func(android.TopDownMutatorContext) { |
| 737 | return func(mctx android.TopDownMutatorContext) { |
Vishwath Mohan | b743e9c | 2017-11-01 09:20:21 +0000 | [diff] [blame] | 738 | if c, ok := mctx.Module().(*Module); ok && c.sanitize.isSanitizerEnabled(t) { |
Colin Cross | 6b75360 | 2018-06-21 13:03:07 -0700 | [diff] [blame] | 739 | mctx.WalkDeps(func(child, parent android.Module) bool { |
| 740 | if !isSanitizableDependencyTag(mctx.OtherModuleDependencyTag(child)) { |
| 741 | return false |
| 742 | } |
| 743 | if d, ok := child.(*Module); ok && d.sanitize != nil && |
Nan Zhang | 0007d81 | 2017-11-07 10:57:05 -0800 | [diff] [blame] | 744 | !Bool(d.sanitize.Properties.Sanitize.Never) && |
Vishwath Mohan | b743e9c | 2017-11-01 09:20:21 +0000 | [diff] [blame] | 745 | !d.sanitize.isSanitizerExplicitlyDisabled(t) { |
Peter Collingbourne | 8c7e6e2 | 2018-11-19 16:03:58 -0800 | [diff] [blame] | 746 | if t == cfi || t == hwasan || t == scs { |
Evgenii Stepanov | d97a6e9 | 2018-08-02 16:19:13 -0700 | [diff] [blame] | 747 | if d.static() { |
| 748 | d.sanitize.Properties.SanitizeDep = true |
| 749 | } |
| 750 | } else { |
Vishwath Mohan | b743e9c | 2017-11-01 09:20:21 +0000 | [diff] [blame] | 751 | d.sanitize.Properties.SanitizeDep = true |
| 752 | } |
Colin Cross | 16b2349 | 2016-01-06 14:41:07 -0800 | [diff] [blame] | 753 | } |
Colin Cross | 6b75360 | 2018-06-21 13:03:07 -0700 | [diff] [blame] | 754 | return true |
Colin Cross | 16b2349 | 2016-01-06 14:41:07 -0800 | [diff] [blame] | 755 | }) |
| 756 | } |
| 757 | } |
| 758 | } |
| 759 | |
Ivan Lozano | 30c5db2 | 2018-02-21 15:49:20 -0800 | [diff] [blame] | 760 | // Propagate the ubsan minimal runtime dependency when there are integer overflow sanitized static dependencies. |
Colin Cross | 6b75360 | 2018-06-21 13:03:07 -0700 | [diff] [blame] | 761 | func sanitizerRuntimeDepsMutator(mctx android.TopDownMutatorContext) { |
| 762 | if c, ok := mctx.Module().(*Module); ok && c.sanitize != nil { |
| 763 | mctx.WalkDeps(func(child, parent android.Module) bool { |
| 764 | if !isSanitizableDependencyTag(mctx.OtherModuleDependencyTag(child)) { |
| 765 | return false |
| 766 | } |
| 767 | if d, ok := child.(*Module); ok && d.static() && d.sanitize != nil { |
Ivan Lozano | 30c5db2 | 2018-02-21 15:49:20 -0800 | [diff] [blame] | 768 | |
Colin Cross | 6b75360 | 2018-06-21 13:03:07 -0700 | [diff] [blame] | 769 | if enableMinimalRuntime(d.sanitize) { |
| 770 | // If a static dependency is built with the minimal runtime, |
| 771 | // make sure we include the ubsan minimal runtime. |
| 772 | c.sanitize.Properties.MinimalRuntimeDep = true |
| 773 | } else if Bool(d.sanitize.Properties.Sanitize.Diag.Integer_overflow) || |
| 774 | len(d.sanitize.Properties.Sanitize.Diag.Misc_undefined) > 0 { |
| 775 | // If a static dependency runs with full ubsan diagnostics, |
| 776 | // make sure we include the ubsan runtime. |
| 777 | c.sanitize.Properties.UbsanRuntimeDep = true |
Ivan Lozano | 30c5db2 | 2018-02-21 15:49:20 -0800 | [diff] [blame] | 778 | } |
Colin Cross | 6b75360 | 2018-06-21 13:03:07 -0700 | [diff] [blame] | 779 | } |
| 780 | return true |
| 781 | }) |
Ivan Lozano | 30c5db2 | 2018-02-21 15:49:20 -0800 | [diff] [blame] | 782 | } |
| 783 | } |
| 784 | |
Vishwath Mohan | b743e9c | 2017-11-01 09:20:21 +0000 | [diff] [blame] | 785 | // Create sanitized variants for modules that need them |
Colin Cross | 635c3b0 | 2016-05-18 15:37:25 -0700 | [diff] [blame] | 786 | func sanitizerMutator(t sanitizerType) func(android.BottomUpMutatorContext) { |
| 787 | return func(mctx android.BottomUpMutatorContext) { |
Vishwath Mohan | e615345 | 2017-08-11 00:52:44 +0000 | [diff] [blame] | 788 | if c, ok := mctx.Module().(*Module); ok && c.sanitize != nil { |
Vishwath Mohan | b743e9c | 2017-11-01 09:20:21 +0000 | [diff] [blame] | 789 | if c.isDependencyRoot() && c.sanitize.isSanitizerEnabled(t) { |
Colin Cross | 30d5f51 | 2016-05-03 18:02:42 -0700 | [diff] [blame] | 790 | modules := mctx.CreateVariations(t.String()) |
| 791 | modules[0].(*Module).sanitize.SetSanitizer(t, true) |
Vishwath Mohan | b743e9c | 2017-11-01 09:20:21 +0000 | [diff] [blame] | 792 | } else if c.sanitize.isSanitizerEnabled(t) || c.sanitize.Properties.SanitizeDep { |
| 793 | // Save original sanitizer status before we assign values to variant |
| 794 | // 0 as that overwrites the original. |
| 795 | isSanitizerEnabled := c.sanitize.isSanitizerEnabled(t) |
| 796 | |
Colin Cross | b0f2895 | 2016-09-19 16:46:53 -0700 | [diff] [blame] | 797 | modules := mctx.CreateVariations("", t.String()) |
| 798 | modules[0].(*Module).sanitize.SetSanitizer(t, false) |
| 799 | modules[1].(*Module).sanitize.SetSanitizer(t, true) |
Vishwath Mohan | b743e9c | 2017-11-01 09:20:21 +0000 | [diff] [blame] | 800 | |
Colin Cross | b0f2895 | 2016-09-19 16:46:53 -0700 | [diff] [blame] | 801 | modules[0].(*Module).sanitize.Properties.SanitizeDep = false |
| 802 | modules[1].(*Module).sanitize.Properties.SanitizeDep = false |
Vishwath Mohan | e712879 | 2017-11-17 11:08:10 -0800 | [diff] [blame] | 803 | |
| 804 | // We don't need both variants active for anything but CFI-enabled |
| 805 | // target static libraries, so suppress the appropriate variant in |
| 806 | // all other cases. |
| 807 | if t == cfi { |
| 808 | if c.static() { |
| 809 | if !mctx.Device() { |
| 810 | if isSanitizerEnabled { |
| 811 | modules[0].(*Module).Properties.PreventInstall = true |
| 812 | modules[0].(*Module).Properties.HideFromMake = true |
| 813 | } else { |
| 814 | modules[1].(*Module).Properties.PreventInstall = true |
| 815 | modules[1].(*Module).Properties.HideFromMake = true |
| 816 | } |
| 817 | } else { |
Colin Cross | 6510f91 | 2017-11-29 00:27:14 -0800 | [diff] [blame] | 818 | cfiStaticLibs := cfiStaticLibs(mctx.Config()) |
Vishwath Mohan | e712879 | 2017-11-17 11:08:10 -0800 | [diff] [blame] | 819 | |
| 820 | cfiStaticLibsMutex.Lock() |
| 821 | *cfiStaticLibs = append(*cfiStaticLibs, c.Name()) |
| 822 | cfiStaticLibsMutex.Unlock() |
| 823 | } |
| 824 | } else { |
| 825 | modules[0].(*Module).Properties.PreventInstall = true |
| 826 | modules[0].(*Module).Properties.HideFromMake = true |
| 827 | } |
| 828 | } else if t == asan { |
| 829 | if mctx.Device() { |
| 830 | // CFI and ASAN are currently mutually exclusive so disable |
| 831 | // CFI if this is an ASAN variant. |
Vishwath Mohan | b743e9c | 2017-11-01 09:20:21 +0000 | [diff] [blame] | 832 | modules[1].(*Module).sanitize.Properties.InSanitizerDir = true |
| 833 | modules[1].(*Module).sanitize.SetSanitizer(cfi, false) |
| 834 | } |
Vishwath Mohan | e21fe42 | 2017-11-01 19:42:45 -0700 | [diff] [blame] | 835 | if isSanitizerEnabled { |
| 836 | modules[0].(*Module).Properties.PreventInstall = true |
Vishwath Mohan | e712879 | 2017-11-17 11:08:10 -0800 | [diff] [blame] | 837 | modules[0].(*Module).Properties.HideFromMake = true |
Vishwath Mohan | e21fe42 | 2017-11-01 19:42:45 -0700 | [diff] [blame] | 838 | } else { |
| 839 | modules[1].(*Module).Properties.PreventInstall = true |
Vishwath Mohan | e712879 | 2017-11-17 11:08:10 -0800 | [diff] [blame] | 840 | modules[1].(*Module).Properties.HideFromMake = true |
Vishwath Mohan | e21fe42 | 2017-11-01 19:42:45 -0700 | [diff] [blame] | 841 | } |
Peter Collingbourne | 8c7e6e2 | 2018-11-19 16:03:58 -0800 | [diff] [blame] | 842 | } else if t == scs { |
| 843 | // We don't currently link any static libraries built with make into |
| 844 | // libraries built with SCS, so we don't need logic for propagating |
| 845 | // SCSness of dependencies into make. |
| 846 | if !c.static() { |
| 847 | if isSanitizerEnabled { |
| 848 | modules[0].(*Module).Properties.PreventInstall = true |
| 849 | modules[0].(*Module).Properties.HideFromMake = true |
| 850 | } else { |
| 851 | modules[1].(*Module).Properties.PreventInstall = true |
| 852 | modules[1].(*Module).Properties.HideFromMake = true |
| 853 | } |
| 854 | } |
Evgenii Stepanov | d97a6e9 | 2018-08-02 16:19:13 -0700 | [diff] [blame] | 855 | } else if t == hwasan { |
| 856 | if mctx.Device() { |
| 857 | // CFI and HWASAN are currently mutually exclusive so disable |
| 858 | // CFI if this is an HWASAN variant. |
| 859 | modules[1].(*Module).sanitize.SetSanitizer(cfi, false) |
| 860 | } |
| 861 | |
| 862 | if c.static() { |
| 863 | if c.useVndk() { |
| 864 | hwasanVendorStaticLibs := hwasanVendorStaticLibs(mctx.Config()) |
| 865 | hwasanStaticLibsMutex.Lock() |
| 866 | *hwasanVendorStaticLibs = append(*hwasanVendorStaticLibs, c.Name()) |
| 867 | hwasanStaticLibsMutex.Unlock() |
| 868 | } else { |
| 869 | hwasanStaticLibs := hwasanStaticLibs(mctx.Config()) |
| 870 | hwasanStaticLibsMutex.Lock() |
| 871 | *hwasanStaticLibs = append(*hwasanStaticLibs, c.Name()) |
| 872 | hwasanStaticLibsMutex.Unlock() |
| 873 | } |
| 874 | } else { |
| 875 | if isSanitizerEnabled { |
| 876 | modules[0].(*Module).Properties.PreventInstall = true |
| 877 | modules[0].(*Module).Properties.HideFromMake = true |
| 878 | } else { |
| 879 | modules[1].(*Module).Properties.PreventInstall = true |
| 880 | modules[1].(*Module).Properties.HideFromMake = true |
| 881 | } |
| 882 | } |
Vishwath Mohan | e21fe42 | 2017-11-01 19:42:45 -0700 | [diff] [blame] | 883 | } |
Colin Cross | 16b2349 | 2016-01-06 14:41:07 -0800 | [diff] [blame] | 884 | } |
| 885 | c.sanitize.Properties.SanitizeDep = false |
| 886 | } |
| 887 | } |
| 888 | } |
Vishwath Mohan | e712879 | 2017-11-17 11:08:10 -0800 | [diff] [blame] | 889 | |
| 890 | func cfiStaticLibs(config android.Config) *[]string { |
| 891 | return config.Once("cfiStaticLibs", func() interface{} { |
| 892 | return &[]string{} |
| 893 | }).(*[]string) |
| 894 | } |
| 895 | |
Evgenii Stepanov | d97a6e9 | 2018-08-02 16:19:13 -0700 | [diff] [blame] | 896 | func hwasanStaticLibs(config android.Config) *[]string { |
| 897 | return config.Once("hwasanStaticLibs", func() interface{} { |
| 898 | return &[]string{} |
| 899 | }).(*[]string) |
| 900 | } |
| 901 | |
| 902 | func hwasanVendorStaticLibs(config android.Config) *[]string { |
| 903 | return config.Once("hwasanVendorStaticLibs", func() interface{} { |
| 904 | return &[]string{} |
| 905 | }).(*[]string) |
| 906 | } |
| 907 | |
Ivan Lozano | 30c5db2 | 2018-02-21 15:49:20 -0800 | [diff] [blame] | 908 | func enableMinimalRuntime(sanitize *sanitize) bool { |
| 909 | if !Bool(sanitize.Properties.Sanitize.Address) && |
Evgenii Stepanov | d97a6e9 | 2018-08-02 16:19:13 -0700 | [diff] [blame] | 910 | !Bool(sanitize.Properties.Sanitize.Hwaddress) && |
Ivan Lozano | 30c5db2 | 2018-02-21 15:49:20 -0800 | [diff] [blame] | 911 | (Bool(sanitize.Properties.Sanitize.Integer_overflow) || |
| 912 | len(sanitize.Properties.Sanitize.Misc_undefined) > 0) && |
| 913 | !(Bool(sanitize.Properties.Sanitize.Diag.Integer_overflow) || |
| 914 | Bool(sanitize.Properties.Sanitize.Diag.Cfi) || |
| 915 | len(sanitize.Properties.Sanitize.Diag.Misc_undefined) > 0) { |
| 916 | return true |
| 917 | } |
| 918 | return false |
| 919 | } |
| 920 | |
Vishwath Mohan | e712879 | 2017-11-17 11:08:10 -0800 | [diff] [blame] | 921 | func cfiMakeVarsProvider(ctx android.MakeVarsContext) { |
| 922 | cfiStaticLibs := cfiStaticLibs(ctx.Config()) |
Jeff Gaston | 7276539 | 2017-11-28 16:37:53 -0800 | [diff] [blame] | 923 | sort.Strings(*cfiStaticLibs) |
Vishwath Mohan | e712879 | 2017-11-17 11:08:10 -0800 | [diff] [blame] | 924 | ctx.Strict("SOONG_CFI_STATIC_LIBRARIES", strings.Join(*cfiStaticLibs, " ")) |
| 925 | } |
Evgenii Stepanov | d97a6e9 | 2018-08-02 16:19:13 -0700 | [diff] [blame] | 926 | |
| 927 | func hwasanMakeVarsProvider(ctx android.MakeVarsContext) { |
| 928 | hwasanStaticLibs := hwasanStaticLibs(ctx.Config()) |
| 929 | sort.Strings(*hwasanStaticLibs) |
| 930 | ctx.Strict("SOONG_HWASAN_STATIC_LIBRARIES", strings.Join(*hwasanStaticLibs, " ")) |
| 931 | |
| 932 | hwasanVendorStaticLibs := hwasanVendorStaticLibs(ctx.Config()) |
| 933 | sort.Strings(*hwasanVendorStaticLibs) |
| 934 | ctx.Strict("SOONG_HWASAN_VENDOR_STATIC_LIBRARIES", strings.Join(*hwasanVendorStaticLibs, " ")) |
| 935 | } |