Colin Cross | 16b2349 | 2016-01-06 14:41:07 -0800 | [diff] [blame] | 1 | // Copyright 2016 Google Inc. All rights reserved. |
| 2 | // |
| 3 | // Licensed under the Apache License, Version 2.0 (the "License"); |
| 4 | // you may not use this file except in compliance with the License. |
| 5 | // You may obtain a copy of the License at |
| 6 | // |
| 7 | // http://www.apache.org/licenses/LICENSE-2.0 |
| 8 | // |
| 9 | // Unless required by applicable law or agreed to in writing, software |
| 10 | // distributed under the License is distributed on an "AS IS" BASIS, |
| 11 | // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. |
| 12 | // See the License for the specific language governing permissions and |
| 13 | // limitations under the License. |
| 14 | |
| 15 | package cc |
| 16 | |
| 17 | import ( |
| 18 | "fmt" |
Jeff Gaston | 7276539 | 2017-11-28 16:37:53 -0800 | [diff] [blame] | 19 | "sort" |
Colin Cross | 16b2349 | 2016-01-06 14:41:07 -0800 | [diff] [blame] | 20 | "strings" |
Vishwath Mohan | e712879 | 2017-11-17 11:08:10 -0800 | [diff] [blame] | 21 | "sync" |
Colin Cross | 16b2349 | 2016-01-06 14:41:07 -0800 | [diff] [blame] | 22 | |
Colin Cross | 6b75360 | 2018-06-21 13:03:07 -0700 | [diff] [blame] | 23 | "github.com/google/blueprint" |
Liz Kammer | b2fc470 | 2021-06-25 14:53:40 -0400 | [diff] [blame] | 24 | "github.com/google/blueprint/proptools" |
Colin Cross | 6b75360 | 2018-06-21 13:03:07 -0700 | [diff] [blame] | 25 | |
Colin Cross | 635c3b0 | 2016-05-18 15:37:25 -0700 | [diff] [blame] | 26 | "android/soong/android" |
Evgenii Stepanov | af36db1 | 2016-08-15 14:18:24 -0700 | [diff] [blame] | 27 | "android/soong/cc/config" |
Kiyoung Kim | 48f3778 | 2021-07-07 12:42:39 +0900 | [diff] [blame] | 28 | "android/soong/snapshot" |
Colin Cross | 16b2349 | 2016-01-06 14:41:07 -0800 | [diff] [blame] | 29 | ) |
| 30 | |
Jayant Chowdhary | 9677e8c | 2017-06-15 14:45:18 -0700 | [diff] [blame] | 31 | var ( |
| 32 | // Any C flags added by sanitizer which libTooling tools may not |
| 33 | // understand also need to be added to ClangLibToolingUnknownCflags in |
| 34 | // cc/config/clang.go |
Vishwath Mohan | f3918d3 | 2017-02-14 07:59:33 -0800 | [diff] [blame] | 35 | |
Yi Kong | 20233a4 | 2019-08-21 01:38:40 -0700 | [diff] [blame] | 36 | asanCflags = []string{ |
| 37 | "-fno-omit-frame-pointer", |
Yi Kong | 20233a4 | 2019-08-21 01:38:40 -0700 | [diff] [blame] | 38 | } |
Jayant Chowdhary | 9677e8c | 2017-06-15 14:45:18 -0700 | [diff] [blame] | 39 | asanLdflags = []string{"-Wl,-u,__asan_preinit"} |
Jayant Chowdhary | 9677e8c | 2017-06-15 14:45:18 -0700 | [diff] [blame] | 40 | |
Yi Kong | 286abc6 | 2021-11-04 16:14:14 +0800 | [diff] [blame] | 41 | hwasanCflags = []string{ |
| 42 | "-fno-omit-frame-pointer", |
| 43 | "-Wno-frame-larger-than=", |
Evgenii Stepanov | 96fa3dd | 2020-03-27 19:38:42 +0000 | [diff] [blame] | 44 | "-fsanitize-hwaddress-abi=platform", |
Florian Mayer | 0b981f5 | 2022-02-16 23:46:53 +0000 | [diff] [blame] | 45 | "-mllvm", "-hwasan-use-after-scope=1", |
Yi Kong | 286abc6 | 2021-11-04 16:14:14 +0800 | [diff] [blame] | 46 | } |
| 47 | |
| 48 | // ThinLTO performs codegen during link time, thus these flags need to |
| 49 | // passed to both CFLAGS and LDFLAGS. |
| 50 | hwasanCommonflags = []string{ |
Evgenii Stepanov | 64bee4d | 2019-11-22 18:37:10 -0800 | [diff] [blame] | 51 | // The following improves debug location information |
| 52 | // availability at the cost of its accuracy. It increases |
| 53 | // the likelihood of a stack variable's frame offset |
| 54 | // to be recorded in the debug info, which is important |
| 55 | // for the quality of hwasan reports. The downside is a |
| 56 | // higher number of "optimized out" stack variables. |
| 57 | // b/112437883. |
Yi Kong | 286abc6 | 2021-11-04 16:14:14 +0800 | [diff] [blame] | 58 | "-instcombine-lower-dbg-declare=0", |
Mitch Phillips | b1c574f | 2020-06-22 13:28:23 -0700 | [diff] [blame] | 59 | // TODO(b/159343917): HWASan and GlobalISel don't play nicely, and |
| 60 | // GlobalISel is the default at -O0 on aarch64. |
Yi Kong | 286abc6 | 2021-11-04 16:14:14 +0800 | [diff] [blame] | 61 | "--aarch64-enable-global-isel-at-O=-1", |
| 62 | "-fast-isel=false", |
Evgenii Stepanov | 64bee4d | 2019-11-22 18:37:10 -0800 | [diff] [blame] | 63 | } |
Evgenii Stepanov | d97a6e9 | 2018-08-02 16:19:13 -0700 | [diff] [blame] | 64 | |
Trevor Radcliffe | 391a25d | 2023-03-22 20:22:27 +0000 | [diff] [blame^] | 65 | cfiBlocklistPath = "external/compiler-rt/lib/cfi" |
| 66 | cfiBlocklistFilename = "cfi_blocklist.txt" |
| 67 | cfiCflags = []string{"-flto", "-fsanitize-cfi-cross-dso", |
| 68 | "-fsanitize-ignorelist=" + cfiBlocklistPath + "/" + cfiBlocklistFilename} |
Evgenii Stepanov | dbf1d4f | 2018-08-31 12:54:33 -0700 | [diff] [blame] | 69 | // -flto and -fvisibility are required by clang when -fsanitize=cfi is |
| 70 | // used, but have no effect on assembly files |
| 71 | cfiAsflags = []string{"-flto", "-fvisibility=default"} |
Jayant Chowdhary | 9677e8c | 2017-06-15 14:45:18 -0700 | [diff] [blame] | 72 | cfiLdflags = []string{"-flto", "-fsanitize-cfi-cross-dso", "-fsanitize=cfi", |
Pirama Arumuga Nainar | bdb17f0 | 2017-08-28 21:50:17 -0700 | [diff] [blame] | 73 | "-Wl,-plugin-opt,O1"} |
Trevor Radcliffe | 391a25d | 2023-03-22 20:22:27 +0000 | [diff] [blame^] | 74 | cfiExportsMapPath = "build/soong/cc/config" |
| 75 | cfiExportsMapFilename = "cfi_exports.map" |
| 76 | cfiAssemblySupportFlag = "-fno-sanitize-cfi-canonical-jump-tables" |
Ivan Lozano | 0c3a1ef | 2017-06-28 09:10:48 -0700 | [diff] [blame] | 77 | |
Pirama Arumuga Nainar | 582fc2d | 2021-08-27 15:12:56 -0700 | [diff] [blame] | 78 | intOverflowCflags = []string{"-fsanitize-ignorelist=build/soong/cc/config/integer_overflow_blocklist.txt"} |
Peter Collingbourne | 8c7e6e2 | 2018-11-19 16:03:58 -0800 | [diff] [blame] | 79 | |
Peter Collingbourne | bd19db0 | 2019-03-06 10:38:48 -0800 | [diff] [blame] | 80 | minimalRuntimeFlags = []string{"-fsanitize-minimal-runtime", "-fno-sanitize-trap=integer,undefined", |
Ivan Lozano | ae6ae1d | 2018-10-08 09:29:39 -0700 | [diff] [blame] | 81 | "-fno-sanitize-recover=integer,undefined"} |
Evgenii Stepanov | 2c6484e | 2019-05-15 12:49:54 -0700 | [diff] [blame] | 82 | hwasanGlobalOptions = []string{"heap_history_size=1023", "stack_history_size=512", |
Christopher Ferris | 2fc8e03 | 2023-01-26 14:19:27 -0800 | [diff] [blame] | 83 | "export_memory_stats=0", "max_malloc_fill_size=131072", "malloc_fill_byte=0"} |
Florian Mayer | 1866bbe | 2023-03-11 01:07:40 +0000 | [diff] [blame] | 84 | memtagStackCommonFlags = []string{"-march=armv8-a+memtag", "-mllvm", "-dom-tree-reachability-max-bbs-to-explore=128"} |
Trevor Radcliffe | 4f95ee9 | 2023-01-19 16:02:47 +0000 | [diff] [blame] | 85 | |
| 86 | hostOnlySanitizeFlags = []string{"-fno-sanitize-recover=all"} |
| 87 | deviceOnlySanitizeFlags = []string{"-fsanitize-trap=all", "-ftrap-function=abort"} |
Dan Willemsen | cbceaab | 2016-10-13 16:44:07 -0700 | [diff] [blame] | 88 | ) |
| 89 | |
Ivan Lozano | 3968d8f | 2020-12-14 11:27:52 -0500 | [diff] [blame] | 90 | type SanitizerType int |
Colin Cross | 16b2349 | 2016-01-06 14:41:07 -0800 | [diff] [blame] | 91 | |
Colin Cross | 16b2349 | 2016-01-06 14:41:07 -0800 | [diff] [blame] | 92 | const ( |
Ivan Lozano | 3968d8f | 2020-12-14 11:27:52 -0500 | [diff] [blame] | 93 | Asan SanitizerType = iota + 1 |
Tri Vo | 6eafc36 | 2021-04-01 11:29:09 -0700 | [diff] [blame] | 94 | Hwasan |
Colin Cross | 16b2349 | 2016-01-06 14:41:07 -0800 | [diff] [blame] | 95 | tsan |
Ivan Lozano | 0c3a1ef | 2017-06-28 09:10:48 -0700 | [diff] [blame] | 96 | intOverflow |
Peter Collingbourne | 8c7e6e2 | 2018-11-19 16:03:58 -0800 | [diff] [blame] | 97 | scs |
Ivan Lozano | 3968d8f | 2020-12-14 11:27:52 -0500 | [diff] [blame] | 98 | Fuzzer |
Ivan Lozano | 62cd038 | 2021-11-01 10:27:54 -0400 | [diff] [blame] | 99 | Memtag_heap |
Florian Mayer | d8434a4 | 2022-08-31 20:57:03 +0000 | [diff] [blame] | 100 | Memtag_stack |
Liz Kammer | 75db931 | 2021-07-07 16:41:50 -0400 | [diff] [blame] | 101 | cfi // cfi is last to prevent it running before incompatible mutators |
Colin Cross | 16b2349 | 2016-01-06 14:41:07 -0800 | [diff] [blame] | 102 | ) |
| 103 | |
Liz Kammer | 75db931 | 2021-07-07 16:41:50 -0400 | [diff] [blame] | 104 | var Sanitizers = []SanitizerType{ |
| 105 | Asan, |
| 106 | Hwasan, |
| 107 | tsan, |
| 108 | intOverflow, |
| 109 | scs, |
| 110 | Fuzzer, |
Ivan Lozano | 62cd038 | 2021-11-01 10:27:54 -0400 | [diff] [blame] | 111 | Memtag_heap, |
Florian Mayer | d8434a4 | 2022-08-31 20:57:03 +0000 | [diff] [blame] | 112 | Memtag_stack, |
Liz Kammer | 75db931 | 2021-07-07 16:41:50 -0400 | [diff] [blame] | 113 | cfi, // cfi is last to prevent it running before incompatible mutators |
| 114 | } |
| 115 | |
Jiyong Park | 8222663 | 2019-02-01 10:50:50 +0900 | [diff] [blame] | 116 | // Name of the sanitizer variation for this sanitizer type |
Ivan Lozano | 3968d8f | 2020-12-14 11:27:52 -0500 | [diff] [blame] | 117 | func (t SanitizerType) variationName() string { |
Colin Cross | 16b2349 | 2016-01-06 14:41:07 -0800 | [diff] [blame] | 118 | switch t { |
Ivan Lozano | 3968d8f | 2020-12-14 11:27:52 -0500 | [diff] [blame] | 119 | case Asan: |
Colin Cross | 16b2349 | 2016-01-06 14:41:07 -0800 | [diff] [blame] | 120 | return "asan" |
Tri Vo | 6eafc36 | 2021-04-01 11:29:09 -0700 | [diff] [blame] | 121 | case Hwasan: |
Evgenii Stepanov | d97a6e9 | 2018-08-02 16:19:13 -0700 | [diff] [blame] | 122 | return "hwasan" |
Colin Cross | 16b2349 | 2016-01-06 14:41:07 -0800 | [diff] [blame] | 123 | case tsan: |
| 124 | return "tsan" |
Ivan Lozano | 0c3a1ef | 2017-06-28 09:10:48 -0700 | [diff] [blame] | 125 | case intOverflow: |
| 126 | return "intOverflow" |
Vishwath Mohan | b743e9c | 2017-11-01 09:20:21 +0000 | [diff] [blame] | 127 | case cfi: |
| 128 | return "cfi" |
Peter Collingbourne | 8c7e6e2 | 2018-11-19 16:03:58 -0800 | [diff] [blame] | 129 | case scs: |
| 130 | return "scs" |
Ivan Lozano | 62cd038 | 2021-11-01 10:27:54 -0400 | [diff] [blame] | 131 | case Memtag_heap: |
Evgenii Stepanov | 193ac2e | 2020-04-28 15:09:12 -0700 | [diff] [blame] | 132 | return "memtag_heap" |
Florian Mayer | d8434a4 | 2022-08-31 20:57:03 +0000 | [diff] [blame] | 133 | case Memtag_stack: |
| 134 | return "memtag_stack" |
Ivan Lozano | 3968d8f | 2020-12-14 11:27:52 -0500 | [diff] [blame] | 135 | case Fuzzer: |
Mitch Phillips | 5a6ea6c | 2019-05-01 14:42:05 -0700 | [diff] [blame] | 136 | return "fuzzer" |
Colin Cross | 16b2349 | 2016-01-06 14:41:07 -0800 | [diff] [blame] | 137 | default: |
Ivan Lozano | 3968d8f | 2020-12-14 11:27:52 -0500 | [diff] [blame] | 138 | panic(fmt.Errorf("unknown SanitizerType %d", t)) |
Colin Cross | 16b2349 | 2016-01-06 14:41:07 -0800 | [diff] [blame] | 139 | } |
| 140 | } |
| 141 | |
Jiyong Park | 8222663 | 2019-02-01 10:50:50 +0900 | [diff] [blame] | 142 | // This is the sanitizer names in SANITIZE_[TARGET|HOST] |
Ivan Lozano | 3968d8f | 2020-12-14 11:27:52 -0500 | [diff] [blame] | 143 | func (t SanitizerType) name() string { |
Jiyong Park | 8222663 | 2019-02-01 10:50:50 +0900 | [diff] [blame] | 144 | switch t { |
Ivan Lozano | 3968d8f | 2020-12-14 11:27:52 -0500 | [diff] [blame] | 145 | case Asan: |
Jiyong Park | 8222663 | 2019-02-01 10:50:50 +0900 | [diff] [blame] | 146 | return "address" |
Tri Vo | 6eafc36 | 2021-04-01 11:29:09 -0700 | [diff] [blame] | 147 | case Hwasan: |
Jiyong Park | 8222663 | 2019-02-01 10:50:50 +0900 | [diff] [blame] | 148 | return "hwaddress" |
Ivan Lozano | 62cd038 | 2021-11-01 10:27:54 -0400 | [diff] [blame] | 149 | case Memtag_heap: |
Evgenii Stepanov | 193ac2e | 2020-04-28 15:09:12 -0700 | [diff] [blame] | 150 | return "memtag_heap" |
Florian Mayer | d8434a4 | 2022-08-31 20:57:03 +0000 | [diff] [blame] | 151 | case Memtag_stack: |
| 152 | return "memtag_stack" |
Jiyong Park | 8222663 | 2019-02-01 10:50:50 +0900 | [diff] [blame] | 153 | case tsan: |
| 154 | return "thread" |
| 155 | case intOverflow: |
| 156 | return "integer_overflow" |
| 157 | case cfi: |
| 158 | return "cfi" |
| 159 | case scs: |
| 160 | return "shadow-call-stack" |
Ivan Lozano | 3968d8f | 2020-12-14 11:27:52 -0500 | [diff] [blame] | 161 | case Fuzzer: |
Mitch Phillips | 5a6ea6c | 2019-05-01 14:42:05 -0700 | [diff] [blame] | 162 | return "fuzzer" |
Jiyong Park | 8222663 | 2019-02-01 10:50:50 +0900 | [diff] [blame] | 163 | default: |
Ivan Lozano | 3968d8f | 2020-12-14 11:27:52 -0500 | [diff] [blame] | 164 | panic(fmt.Errorf("unknown SanitizerType %d", t)) |
Jiyong Park | 8222663 | 2019-02-01 10:50:50 +0900 | [diff] [blame] | 165 | } |
| 166 | } |
| 167 | |
Liz Kammer | 75db931 | 2021-07-07 16:41:50 -0400 | [diff] [blame] | 168 | func (t SanitizerType) registerMutators(ctx android.RegisterMutatorsContext) { |
| 169 | switch t { |
Lukacs T. Berki | 6c71676 | 2022-06-13 20:50:39 +0200 | [diff] [blame] | 170 | case cfi, Hwasan, Asan, tsan, Fuzzer, scs: |
| 171 | sanitizer := &sanitizerSplitMutator{t} |
| 172 | ctx.TopDown(t.variationName()+"_markapexes", sanitizer.markSanitizableApexesMutator) |
| 173 | ctx.Transition(t.variationName(), sanitizer) |
Florian Mayer | d8434a4 | 2022-08-31 20:57:03 +0000 | [diff] [blame] | 174 | case Memtag_heap, Memtag_stack, intOverflow: |
Liz Kammer | 75db931 | 2021-07-07 16:41:50 -0400 | [diff] [blame] | 175 | // do nothing |
| 176 | default: |
| 177 | panic(fmt.Errorf("unknown SanitizerType %d", t)) |
| 178 | } |
| 179 | } |
| 180 | |
Liz Kammer | fd8a49f | 2022-10-31 10:31:11 -0400 | [diff] [blame] | 181 | // shouldPropagateToSharedLibraryDeps returns whether a sanitizer type should propagate to share |
| 182 | // dependencies. In most cases, sanitizers only propagate to static dependencies; however, some |
| 183 | // sanitizers also must be enabled for shared libraries for linking. |
| 184 | func (t SanitizerType) shouldPropagateToSharedLibraryDeps() bool { |
| 185 | switch t { |
| 186 | case Fuzzer: |
| 187 | // Typically, shared libs are not split. However, for fuzzer, we split even for shared libs |
| 188 | // because a library sanitized for fuzzer can't be linked from a library that isn't sanitized |
| 189 | // for fuzzer. |
| 190 | return true |
| 191 | default: |
| 192 | return false |
| 193 | } |
| 194 | } |
Ivan Lozano | 3968d8f | 2020-12-14 11:27:52 -0500 | [diff] [blame] | 195 | func (*Module) SanitizerSupported(t SanitizerType) bool { |
| 196 | switch t { |
| 197 | case Asan: |
| 198 | return true |
Tri Vo | 6eafc36 | 2021-04-01 11:29:09 -0700 | [diff] [blame] | 199 | case Hwasan: |
Ivan Lozano | 3968d8f | 2020-12-14 11:27:52 -0500 | [diff] [blame] | 200 | return true |
| 201 | case tsan: |
| 202 | return true |
| 203 | case intOverflow: |
| 204 | return true |
| 205 | case cfi: |
| 206 | return true |
| 207 | case scs: |
| 208 | return true |
| 209 | case Fuzzer: |
| 210 | return true |
Ivan Lozano | 62cd038 | 2021-11-01 10:27:54 -0400 | [diff] [blame] | 211 | case Memtag_heap: |
| 212 | return true |
Florian Mayer | d8434a4 | 2022-08-31 20:57:03 +0000 | [diff] [blame] | 213 | case Memtag_stack: |
| 214 | return true |
Ivan Lozano | 3968d8f | 2020-12-14 11:27:52 -0500 | [diff] [blame] | 215 | default: |
| 216 | return false |
| 217 | } |
| 218 | } |
| 219 | |
| 220 | // incompatibleWithCfi returns true if a sanitizer is incompatible with CFI. |
| 221 | func (t SanitizerType) incompatibleWithCfi() bool { |
Tri Vo | 6eafc36 | 2021-04-01 11:29:09 -0700 | [diff] [blame] | 222 | return t == Asan || t == Fuzzer || t == Hwasan |
Jiyong Park | 1d1119f | 2019-07-29 21:27:18 +0900 | [diff] [blame] | 223 | } |
| 224 | |
Martin Stjernholm | b024957 | 2020-09-15 02:32:35 +0100 | [diff] [blame] | 225 | type SanitizeUserProps struct { |
Liz Kammer | 75b9b40 | 2021-06-25 15:19:27 -0400 | [diff] [blame] | 226 | // Prevent use of any sanitizers on this module |
Martin Stjernholm | b024957 | 2020-09-15 02:32:35 +0100 | [diff] [blame] | 227 | Never *bool `android:"arch_variant"` |
Colin Cross | 16b2349 | 2016-01-06 14:41:07 -0800 | [diff] [blame] | 228 | |
Liz Kammer | 75b9b40 | 2021-06-25 15:19:27 -0400 | [diff] [blame] | 229 | // ASan (Address sanitizer), incompatible with static binaries. |
| 230 | // Always runs in a diagnostic mode. |
| 231 | // Use of address sanitizer disables cfi sanitizer. |
| 232 | // Hwaddress sanitizer takes precedence over this sanitizer. |
| 233 | Address *bool `android:"arch_variant"` |
| 234 | // TSan (Thread sanitizer), incompatible with static binaries and 32 bit architectures. |
| 235 | // Always runs in a diagnostic mode. |
| 236 | // Use of thread sanitizer disables cfi and scudo sanitizers. |
| 237 | // Hwaddress sanitizer takes precedence over this sanitizer. |
| 238 | Thread *bool `android:"arch_variant"` |
| 239 | // HWASan (Hardware Address sanitizer). |
| 240 | // Use of hwasan sanitizer disables cfi, address, thread, and scudo sanitizers. |
Martin Stjernholm | b024957 | 2020-09-15 02:32:35 +0100 | [diff] [blame] | 241 | Hwaddress *bool `android:"arch_variant"` |
Colin Cross | 16b2349 | 2016-01-06 14:41:07 -0800 | [diff] [blame] | 242 | |
Liz Kammer | 75b9b40 | 2021-06-25 15:19:27 -0400 | [diff] [blame] | 243 | // Undefined behavior sanitizer |
| 244 | All_undefined *bool `android:"arch_variant"` |
| 245 | // Subset of undefined behavior sanitizer |
| 246 | Undefined *bool `android:"arch_variant"` |
| 247 | // List of specific undefined behavior sanitizers to enable |
| 248 | Misc_undefined []string `android:"arch_variant"` |
| 249 | // Fuzzer, incompatible with static binaries. |
| 250 | Fuzzer *bool `android:"arch_variant"` |
| 251 | // safe-stack sanitizer, incompatible with 32-bit architectures. |
| 252 | Safestack *bool `android:"arch_variant"` |
| 253 | // cfi sanitizer, incompatible with asan, hwasan, fuzzer, or Darwin |
| 254 | Cfi *bool `android:"arch_variant"` |
| 255 | // signed/unsigned integer overflow sanitizer, incompatible with Darwin. |
| 256 | Integer_overflow *bool `android:"arch_variant"` |
| 257 | // scudo sanitizer, incompatible with asan, hwasan, tsan |
| 258 | // This should not be used in Android 11+ : https://source.android.com/devices/tech/debug/scudo |
| 259 | // deprecated |
| 260 | Scudo *bool `android:"arch_variant"` |
Elliott Hughes | e4793bc | 2023-02-09 21:15:47 +0000 | [diff] [blame] | 261 | // shadow-call-stack sanitizer, only available on arm64/riscv64. |
Liz Kammer | 75b9b40 | 2021-06-25 15:19:27 -0400 | [diff] [blame] | 262 | Scs *bool `android:"arch_variant"` |
| 263 | // Memory-tagging, only available on arm64 |
| 264 | // if diag.memtag unset or false, enables async memory tagging |
Florian Mayer | 00ab5cf | 2022-08-31 18:30:18 +0000 | [diff] [blame] | 265 | Memtag_heap *bool `android:"arch_variant"` |
Florian Mayer | d8434a4 | 2022-08-31 20:57:03 +0000 | [diff] [blame] | 266 | // Memory-tagging stack instrumentation, only available on arm64 |
| 267 | // Adds instrumentation to detect stack buffer overflows and use-after-scope using MTE. |
| 268 | Memtag_stack *bool `android:"arch_variant"` |
Martin Stjernholm | b024957 | 2020-09-15 02:32:35 +0100 | [diff] [blame] | 269 | |
| 270 | // A modifier for ASAN and HWASAN for write only instrumentation |
| 271 | Writeonly *bool `android:"arch_variant"` |
| 272 | |
| 273 | // Sanitizers to run in the diagnostic mode (as opposed to the release mode). |
| 274 | // Replaces abort() on error with a human-readable error message. |
| 275 | // Address and Thread sanitizers always run in diagnostic mode. |
| 276 | Diag struct { |
Liz Kammer | 75b9b40 | 2021-06-25 15:19:27 -0400 | [diff] [blame] | 277 | // Undefined behavior sanitizer, diagnostic mode |
| 278 | Undefined *bool `android:"arch_variant"` |
| 279 | // cfi sanitizer, diagnostic mode, incompatible with asan, hwasan, fuzzer, or Darwin |
| 280 | Cfi *bool `android:"arch_variant"` |
| 281 | // signed/unsigned integer overflow sanitizer, diagnostic mode, incompatible with Darwin. |
| 282 | Integer_overflow *bool `android:"arch_variant"` |
| 283 | // Memory-tagging, only available on arm64 |
| 284 | // requires sanitizer.memtag: true |
| 285 | // if set, enables sync memory tagging |
| 286 | Memtag_heap *bool `android:"arch_variant"` |
| 287 | // List of specific undefined behavior sanitizers to enable in diagnostic mode |
| 288 | Misc_undefined []string `android:"arch_variant"` |
| 289 | // List of sanitizers to pass to -fno-sanitize-recover |
| 290 | // results in only the first detected error for these sanitizers being reported and program then |
| 291 | // exits with a non-zero exit code. |
| 292 | No_recover []string `android:"arch_variant"` |
Cindy Zhou | d3fe492 | 2020-12-01 11:14:30 -0800 | [diff] [blame] | 293 | } `android:"arch_variant"` |
Colin Cross | 16b2349 | 2016-01-06 14:41:07 -0800 | [diff] [blame] | 294 | |
Cindy Zhou | 8cd45de | 2020-11-16 08:41:00 -0800 | [diff] [blame] | 295 | // Sanitizers to run with flag configuration specified |
| 296 | Config struct { |
| 297 | // Enables CFI support flags for assembly-heavy libraries |
| 298 | Cfi_assembly_support *bool `android:"arch_variant"` |
Cindy Zhou | d3fe492 | 2020-12-01 11:14:30 -0800 | [diff] [blame] | 299 | } `android:"arch_variant"` |
Cindy Zhou | 8cd45de | 2020-11-16 08:41:00 -0800 | [diff] [blame] | 300 | |
Liz Kammer | 75b9b40 | 2021-06-25 15:19:27 -0400 | [diff] [blame] | 301 | // List of sanitizers to pass to -fsanitize-recover |
| 302 | // allows execution to continue for these sanitizers to detect multiple errors rather than only |
| 303 | // the first one |
Martin Stjernholm | b024957 | 2020-09-15 02:32:35 +0100 | [diff] [blame] | 304 | Recover []string |
Jasraj Bedi | bb4511d | 2020-07-23 22:58:17 +0000 | [diff] [blame] | 305 | |
Pirama Arumuga Nainar | 582fc2d | 2021-08-27 15:12:56 -0700 | [diff] [blame] | 306 | // value to pass to -fsanitize-ignorelist |
Martin Stjernholm | b024957 | 2020-09-15 02:32:35 +0100 | [diff] [blame] | 307 | Blocklist *string |
| 308 | } |
Evgenii Stepanov | 1e405e1 | 2016-08-16 15:39:54 -0700 | [diff] [blame] | 309 | |
Liz Kammer | 2c1d6aa | 2022-10-03 15:07:37 -0400 | [diff] [blame] | 310 | type sanitizeMutatedProperties struct { |
| 311 | // Whether sanitizers can be enabled on this module |
| 312 | Never *bool `blueprint:"mutated"` |
| 313 | |
| 314 | // Whether ASan (Address sanitizer) is enabled for this module. |
| 315 | // Hwaddress sanitizer takes precedence over this sanitizer. |
| 316 | Address *bool `blueprint:"mutated"` |
| 317 | // Whether TSan (Thread sanitizer) is enabled for this module |
| 318 | Thread *bool `blueprint:"mutated"` |
| 319 | // Whether HWASan (Hardware Address sanitizer) is enabled for this module |
| 320 | Hwaddress *bool `blueprint:"mutated"` |
| 321 | |
| 322 | // Whether Undefined behavior sanitizer is enabled for this module |
| 323 | All_undefined *bool `blueprint:"mutated"` |
| 324 | // Whether undefined behavior sanitizer subset is enabled for this module |
| 325 | Undefined *bool `blueprint:"mutated"` |
| 326 | // List of specific undefined behavior sanitizers enabled for this module |
| 327 | Misc_undefined []string `blueprint:"mutated"` |
| 328 | // Whether Fuzzeris enabled for this module |
| 329 | Fuzzer *bool `blueprint:"mutated"` |
| 330 | // whether safe-stack sanitizer is enabled for this module |
| 331 | Safestack *bool `blueprint:"mutated"` |
| 332 | // Whether cfi sanitizer is enabled for this module |
| 333 | Cfi *bool `blueprint:"mutated"` |
| 334 | // Whether signed/unsigned integer overflow sanitizer is enabled for this module |
| 335 | Integer_overflow *bool `blueprint:"mutated"` |
| 336 | // Whether scudo sanitizer is enabled for this module |
| 337 | Scudo *bool `blueprint:"mutated"` |
| 338 | // Whether shadow-call-stack sanitizer is enabled for this module. |
| 339 | Scs *bool `blueprint:"mutated"` |
| 340 | // Whether Memory-tagging is enabled for this module |
| 341 | Memtag_heap *bool `blueprint:"mutated"` |
| 342 | // Whether Memory-tagging stack instrumentation is enabled for this module |
| 343 | Memtag_stack *bool `blueprint:"mutated"` |
| 344 | |
| 345 | // Whether a modifier for ASAN and HWASAN for write only instrumentation is enabled for this |
| 346 | // module |
| 347 | Writeonly *bool `blueprint:"mutated"` |
| 348 | |
| 349 | // Sanitizers to run in the diagnostic mode (as opposed to the release mode). |
| 350 | Diag struct { |
| 351 | // Whether Undefined behavior sanitizer, diagnostic mode is enabled for this module |
| 352 | Undefined *bool `blueprint:"mutated"` |
| 353 | // Whether cfi sanitizer, diagnostic mode is enabled for this module |
| 354 | Cfi *bool `blueprint:"mutated"` |
| 355 | // Whether signed/unsigned integer overflow sanitizer, diagnostic mode is enabled for this |
| 356 | // module |
| 357 | Integer_overflow *bool `blueprint:"mutated"` |
| 358 | // Whether Memory-tagging, diagnostic mode is enabled for this module |
| 359 | Memtag_heap *bool `blueprint:"mutated"` |
| 360 | // List of specific undefined behavior sanitizers enabled in diagnostic mode |
| 361 | Misc_undefined []string `blueprint:"mutated"` |
| 362 | } `blueprint:"mutated"` |
| 363 | } |
| 364 | |
Martin Stjernholm | b024957 | 2020-09-15 02:32:35 +0100 | [diff] [blame] | 365 | type SanitizeProperties struct { |
Liz Kammer | 2c1d6aa | 2022-10-03 15:07:37 -0400 | [diff] [blame] | 366 | Sanitize SanitizeUserProps `android:"arch_variant"` |
| 367 | SanitizeMutated sanitizeMutatedProperties `blueprint:"mutated"` |
| 368 | |
| 369 | SanitizerEnabled bool `blueprint:"mutated"` |
| 370 | MinimalRuntimeDep bool `blueprint:"mutated"` |
| 371 | BuiltinsDep bool `blueprint:"mutated"` |
| 372 | UbsanRuntimeDep bool `blueprint:"mutated"` |
| 373 | InSanitizerDir bool `blueprint:"mutated"` |
| 374 | Sanitizers []string `blueprint:"mutated"` |
| 375 | DiagSanitizers []string `blueprint:"mutated"` |
Colin Cross | 16b2349 | 2016-01-06 14:41:07 -0800 | [diff] [blame] | 376 | } |
| 377 | |
| 378 | type sanitize struct { |
| 379 | Properties SanitizeProperties |
| 380 | } |
| 381 | |
Cindy Zhou | 18417cb | 2020-12-10 07:12:38 -0800 | [diff] [blame] | 382 | // Mark this tag with a check to see if apex dependency check should be skipped |
| 383 | func (t libraryDependencyTag) SkipApexAllowedDependenciesCheck() bool { |
| 384 | return t.skipApexAllowedDependenciesCheck |
| 385 | } |
| 386 | |
| 387 | var _ android.SkipApexAllowedDependenciesCheck = (*libraryDependencyTag)(nil) |
| 388 | |
Trevor Radcliffe | 4f95ee9 | 2023-01-19 16:02:47 +0000 | [diff] [blame] | 389 | var exportedVars = android.NewExportedVariables(pctx) |
| 390 | |
Vishwath Mohan | e712879 | 2017-11-17 11:08:10 -0800 | [diff] [blame] | 391 | func init() { |
Trevor Radcliffe | 4f95ee9 | 2023-01-19 16:02:47 +0000 | [diff] [blame] | 392 | exportedVars.ExportStringListStaticVariable("HostOnlySanitizeFlags", hostOnlySanitizeFlags) |
| 393 | exportedVars.ExportStringList("DeviceOnlySanitizeFlags", deviceOnlySanitizeFlags) |
| 394 | |
Trevor Radcliffe | 391a25d | 2023-03-22 20:22:27 +0000 | [diff] [blame^] | 395 | // Leave out "-flto" from the slices exported to bazel, as we will use the |
| 396 | // dedicated LTO feature for this |
| 397 | exportedVars.ExportStringList("CfiCFlags", cfiCflags[1:]) |
| 398 | exportedVars.ExportStringList("CfiAsFlags", cfiAsflags[1:]) |
| 399 | exportedVars.ExportStringList("CfiLdFlags", cfiLdflags[1:]) |
| 400 | |
| 401 | exportedVars.ExportString("CfiBlocklistPath", cfiBlocklistPath) |
| 402 | exportedVars.ExportString("CfiBlocklistFilename", cfiBlocklistFilename) |
| 403 | exportedVars.ExportString("CfiExportsMapPath", cfiExportsMapPath) |
| 404 | exportedVars.ExportString("CfiExportsMapFilename", cfiExportsMapFilename) |
| 405 | exportedVars.ExportString("CfiAssemblySupportFlag", cfiAssemblySupportFlag) |
| 406 | |
Vishwath Mohan | e712879 | 2017-11-17 11:08:10 -0800 | [diff] [blame] | 407 | android.RegisterMakeVarsProvider(pctx, cfiMakeVarsProvider) |
Evgenii Stepanov | d97a6e9 | 2018-08-02 16:19:13 -0700 | [diff] [blame] | 408 | android.RegisterMakeVarsProvider(pctx, hwasanMakeVarsProvider) |
Vishwath Mohan | e712879 | 2017-11-17 11:08:10 -0800 | [diff] [blame] | 409 | } |
| 410 | |
Colin Cross | 16b2349 | 2016-01-06 14:41:07 -0800 | [diff] [blame] | 411 | func (sanitize *sanitize) props() []interface{} { |
| 412 | return []interface{}{&sanitize.Properties} |
| 413 | } |
| 414 | |
Liz Kammer | 2c1d6aa | 2022-10-03 15:07:37 -0400 | [diff] [blame] | 415 | func (p *sanitizeMutatedProperties) copyUserPropertiesToMutated(userProps *SanitizeUserProps) { |
| 416 | p.Never = userProps.Never |
| 417 | p.Address = userProps.Address |
| 418 | p.All_undefined = userProps.All_undefined |
| 419 | p.Cfi = userProps.Cfi |
| 420 | p.Fuzzer = userProps.Fuzzer |
| 421 | p.Hwaddress = userProps.Hwaddress |
| 422 | p.Integer_overflow = userProps.Integer_overflow |
| 423 | p.Memtag_heap = userProps.Memtag_heap |
| 424 | p.Memtag_stack = userProps.Memtag_stack |
| 425 | p.Safestack = userProps.Safestack |
| 426 | p.Scs = userProps.Scs |
| 427 | p.Scudo = userProps.Scudo |
| 428 | p.Thread = userProps.Thread |
| 429 | p.Undefined = userProps.Undefined |
| 430 | p.Writeonly = userProps.Writeonly |
| 431 | |
| 432 | p.Misc_undefined = make([]string, 0, len(userProps.Misc_undefined)) |
| 433 | for _, v := range userProps.Misc_undefined { |
| 434 | p.Misc_undefined = append(p.Misc_undefined, v) |
| 435 | } |
| 436 | |
| 437 | p.Diag.Cfi = userProps.Diag.Cfi |
| 438 | p.Diag.Integer_overflow = userProps.Diag.Integer_overflow |
| 439 | p.Diag.Memtag_heap = userProps.Diag.Memtag_heap |
| 440 | p.Diag.Undefined = userProps.Diag.Undefined |
| 441 | |
| 442 | p.Diag.Misc_undefined = make([]string, 0, len(userProps.Diag.Misc_undefined)) |
| 443 | for _, v := range userProps.Diag.Misc_undefined { |
| 444 | p.Diag.Misc_undefined = append(p.Diag.Misc_undefined, v) |
| 445 | } |
| 446 | } |
| 447 | |
Colin Cross | 16b2349 | 2016-01-06 14:41:07 -0800 | [diff] [blame] | 448 | func (sanitize *sanitize) begin(ctx BaseModuleContext) { |
Liz Kammer | 2c1d6aa | 2022-10-03 15:07:37 -0400 | [diff] [blame] | 449 | s := &sanitize.Properties.SanitizeMutated |
| 450 | s.copyUserPropertiesToMutated(&sanitize.Properties.Sanitize) |
Evgenii Stepanov | fcfe56d | 2016-07-07 10:54:07 -0700 | [diff] [blame] | 451 | |
Colin Cross | 16b2349 | 2016-01-06 14:41:07 -0800 | [diff] [blame] | 452 | // Don't apply sanitizers to NDK code. |
Jeff Gaston | af3cc2d | 2017-09-27 17:01:44 -0700 | [diff] [blame] | 453 | if ctx.useSdk() { |
Nan Zhang | 0007d81 | 2017-11-07 10:57:05 -0800 | [diff] [blame] | 454 | s.Never = BoolPtr(true) |
Colin Cross | 16b2349 | 2016-01-06 14:41:07 -0800 | [diff] [blame] | 455 | } |
| 456 | |
| 457 | // Never always wins. |
Nan Zhang | 0007d81 | 2017-11-07 10:57:05 -0800 | [diff] [blame] | 458 | if Bool(s.Never) { |
Colin Cross | 16b2349 | 2016-01-06 14:41:07 -0800 | [diff] [blame] | 459 | return |
| 460 | } |
| 461 | |
Florian Mayer | d8434a4 | 2022-08-31 20:57:03 +0000 | [diff] [blame] | 462 | // cc_test targets default to SYNC MemTag unless explicitly set to ASYNC (via diag: {memtag_heap: false}). |
Liz Kammer | 7b920b4 | 2021-06-22 16:57:27 -0400 | [diff] [blame] | 463 | if ctx.testBinary() { |
| 464 | if s.Memtag_heap == nil { |
| 465 | s.Memtag_heap = proptools.BoolPtr(true) |
| 466 | } |
| 467 | if s.Diag.Memtag_heap == nil { |
| 468 | s.Diag.Memtag_heap = proptools.BoolPtr(true) |
| 469 | } |
Evgenii Stepanov | 04896ca | 2021-01-12 18:28:33 -0800 | [diff] [blame] | 470 | } |
| 471 | |
Colin Cross | 16b2349 | 2016-01-06 14:41:07 -0800 | [diff] [blame] | 472 | var globalSanitizers []string |
Ivan Lozano | 0c3a1ef | 2017-06-28 09:10:48 -0700 | [diff] [blame] | 473 | var globalSanitizersDiag []string |
| 474 | |
Dan Willemsen | 8536d6b | 2018-10-07 20:54:34 -0700 | [diff] [blame] | 475 | if ctx.Host() { |
| 476 | if !ctx.Windows() { |
| 477 | globalSanitizers = ctx.Config().SanitizeHost() |
| 478 | } |
| 479 | } else { |
| 480 | arches := ctx.Config().SanitizeDeviceArch() |
| 481 | if len(arches) == 0 || inList(ctx.Arch().ArchType.Name, arches) { |
| 482 | globalSanitizers = ctx.Config().SanitizeDevice() |
| 483 | globalSanitizersDiag = ctx.Config().SanitizeDeviceDiag() |
Colin Cross | 16b2349 | 2016-01-06 14:41:07 -0800 | [diff] [blame] | 484 | } |
| 485 | } |
| 486 | |
Colin Cross | 16b2349 | 2016-01-06 14:41:07 -0800 | [diff] [blame] | 487 | if len(globalSanitizers) > 0 { |
Evgenii Stepanov | 05bafd3 | 2016-07-07 17:38:41 +0000 | [diff] [blame] | 488 | var found bool |
Evgenii Stepanov | fcfe56d | 2016-07-07 10:54:07 -0700 | [diff] [blame] | 489 | if found, globalSanitizers = removeFromList("undefined", globalSanitizers); found && s.All_undefined == nil { |
Liz Kammer | b2fc470 | 2021-06-25 14:53:40 -0400 | [diff] [blame] | 490 | s.All_undefined = proptools.BoolPtr(true) |
Evgenii Stepanov | 05bafd3 | 2016-07-07 17:38:41 +0000 | [diff] [blame] | 491 | } |
Colin Cross | 16b2349 | 2016-01-06 14:41:07 -0800 | [diff] [blame] | 492 | |
Evgenii Stepanov | fcfe56d | 2016-07-07 10:54:07 -0700 | [diff] [blame] | 493 | if found, globalSanitizers = removeFromList("default-ub", globalSanitizers); found && s.Undefined == nil { |
Liz Kammer | b2fc470 | 2021-06-25 14:53:40 -0400 | [diff] [blame] | 494 | s.Undefined = proptools.BoolPtr(true) |
Evgenii Stepanov | 05bafd3 | 2016-07-07 17:38:41 +0000 | [diff] [blame] | 495 | } |
| 496 | |
Mitch Phillips | 5a6ea6c | 2019-05-01 14:42:05 -0700 | [diff] [blame] | 497 | if found, globalSanitizers = removeFromList("address", globalSanitizers); found && s.Address == nil { |
Liz Kammer | b2fc470 | 2021-06-25 14:53:40 -0400 | [diff] [blame] | 498 | s.Address = proptools.BoolPtr(true) |
Evgenii Stepanov | 05bafd3 | 2016-07-07 17:38:41 +0000 | [diff] [blame] | 499 | } |
| 500 | |
Evgenii Stepanov | fcfe56d | 2016-07-07 10:54:07 -0700 | [diff] [blame] | 501 | if found, globalSanitizers = removeFromList("thread", globalSanitizers); found && s.Thread == nil { |
Liz Kammer | b2fc470 | 2021-06-25 14:53:40 -0400 | [diff] [blame] | 502 | s.Thread = proptools.BoolPtr(true) |
Evgenii Stepanov | 05bafd3 | 2016-07-07 17:38:41 +0000 | [diff] [blame] | 503 | } |
| 504 | |
Mitch Phillips | 5a6ea6c | 2019-05-01 14:42:05 -0700 | [diff] [blame] | 505 | if found, globalSanitizers = removeFromList("fuzzer", globalSanitizers); found && s.Fuzzer == nil { |
Liz Kammer | b2fc470 | 2021-06-25 14:53:40 -0400 | [diff] [blame] | 506 | s.Fuzzer = proptools.BoolPtr(true) |
Evgenii Stepanov | fcfe56d | 2016-07-07 10:54:07 -0700 | [diff] [blame] | 507 | } |
| 508 | |
| 509 | if found, globalSanitizers = removeFromList("safe-stack", globalSanitizers); found && s.Safestack == nil { |
Liz Kammer | b2fc470 | 2021-06-25 14:53:40 -0400 | [diff] [blame] | 510 | s.Safestack = proptools.BoolPtr(true) |
Evgenii Stepanov | 05bafd3 | 2016-07-07 17:38:41 +0000 | [diff] [blame] | 511 | } |
| 512 | |
Evgenii Stepanov | 1e405e1 | 2016-08-16 15:39:54 -0700 | [diff] [blame] | 513 | if found, globalSanitizers = removeFromList("cfi", globalSanitizers); found && s.Cfi == nil { |
Colin Cross | 6510f91 | 2017-11-29 00:27:14 -0800 | [diff] [blame] | 514 | if !ctx.Config().CFIDisabledForPath(ctx.ModuleDir()) { |
Liz Kammer | b2fc470 | 2021-06-25 14:53:40 -0400 | [diff] [blame] | 515 | s.Cfi = proptools.BoolPtr(true) |
Vishwath Mohan | 1fa3ac5 | 2017-10-31 02:26:14 -0700 | [diff] [blame] | 516 | } |
Evgenii Stepanov | 1e405e1 | 2016-08-16 15:39:54 -0700 | [diff] [blame] | 517 | } |
| 518 | |
Ivan Lozano | a9255a8 | 2018-03-13 10:41:07 -0700 | [diff] [blame] | 519 | // Global integer_overflow builds do not support static libraries. |
Ivan Lozano | 0c3a1ef | 2017-06-28 09:10:48 -0700 | [diff] [blame] | 520 | if found, globalSanitizers = removeFromList("integer_overflow", globalSanitizers); found && s.Integer_overflow == nil { |
Ivan Lozano | a9255a8 | 2018-03-13 10:41:07 -0700 | [diff] [blame] | 521 | if !ctx.Config().IntegerOverflowDisabledForPath(ctx.ModuleDir()) && !ctx.static() { |
Liz Kammer | b2fc470 | 2021-06-25 14:53:40 -0400 | [diff] [blame] | 522 | s.Integer_overflow = proptools.BoolPtr(true) |
Ivan Lozano | 5f59553 | 2017-07-13 14:46:05 -0700 | [diff] [blame] | 523 | } |
Ivan Lozano | 0c3a1ef | 2017-06-28 09:10:48 -0700 | [diff] [blame] | 524 | } |
| 525 | |
Kostya Kortchinsky | d18ae5c | 2018-06-12 14:46:54 -0700 | [diff] [blame] | 526 | if found, globalSanitizers = removeFromList("scudo", globalSanitizers); found && s.Scudo == nil { |
Liz Kammer | b2fc470 | 2021-06-25 14:53:40 -0400 | [diff] [blame] | 527 | s.Scudo = proptools.BoolPtr(true) |
Kostya Kortchinsky | d18ae5c | 2018-06-12 14:46:54 -0700 | [diff] [blame] | 528 | } |
| 529 | |
Evgenii Stepanov | d97a6e9 | 2018-08-02 16:19:13 -0700 | [diff] [blame] | 530 | if found, globalSanitizers = removeFromList("hwaddress", globalSanitizers); found && s.Hwaddress == nil { |
Liz Kammer | b2fc470 | 2021-06-25 14:53:40 -0400 | [diff] [blame] | 531 | s.Hwaddress = proptools.BoolPtr(true) |
Evgenii Stepanov | d97a6e9 | 2018-08-02 16:19:13 -0700 | [diff] [blame] | 532 | } |
| 533 | |
Jasraj Bedi | bb4511d | 2020-07-23 22:58:17 +0000 | [diff] [blame] | 534 | if found, globalSanitizers = removeFromList("writeonly", globalSanitizers); found && s.Writeonly == nil { |
| 535 | // Hwaddress and Address are set before, so we can check them here |
| 536 | // If they aren't explicitly set in the blueprint/SANITIZE_(HOST|TARGET), they would be nil instead of false |
| 537 | if s.Address == nil && s.Hwaddress == nil { |
| 538 | ctx.ModuleErrorf("writeonly modifier cannot be used without 'address' or 'hwaddress'") |
| 539 | } |
Liz Kammer | b2fc470 | 2021-06-25 14:53:40 -0400 | [diff] [blame] | 540 | s.Writeonly = proptools.BoolPtr(true) |
Jasraj Bedi | bb4511d | 2020-07-23 22:58:17 +0000 | [diff] [blame] | 541 | } |
Evgenii Stepanov | 193ac2e | 2020-04-28 15:09:12 -0700 | [diff] [blame] | 542 | if found, globalSanitizers = removeFromList("memtag_heap", globalSanitizers); found && s.Memtag_heap == nil { |
Evgenii Stepanov | 4beaa0c | 2021-01-05 16:41:26 -0800 | [diff] [blame] | 543 | if !ctx.Config().MemtagHeapDisabledForPath(ctx.ModuleDir()) { |
Liz Kammer | b2fc470 | 2021-06-25 14:53:40 -0400 | [diff] [blame] | 544 | s.Memtag_heap = proptools.BoolPtr(true) |
Evgenii Stepanov | 4beaa0c | 2021-01-05 16:41:26 -0800 | [diff] [blame] | 545 | } |
Evgenii Stepanov | 193ac2e | 2020-04-28 15:09:12 -0700 | [diff] [blame] | 546 | } |
Jasraj Bedi | bb4511d | 2020-07-23 22:58:17 +0000 | [diff] [blame] | 547 | |
Florian Mayer | d8434a4 | 2022-08-31 20:57:03 +0000 | [diff] [blame] | 548 | if found, globalSanitizers = removeFromList("memtag_stack", globalSanitizers); found && s.Memtag_stack == nil { |
| 549 | s.Memtag_stack = proptools.BoolPtr(true) |
| 550 | } |
| 551 | |
Evgenii Stepanov | 05bafd3 | 2016-07-07 17:38:41 +0000 | [diff] [blame] | 552 | if len(globalSanitizers) > 0 { |
| 553 | ctx.ModuleErrorf("unknown global sanitizer option %s", globalSanitizers[0]) |
| 554 | } |
Ivan Lozano | 0c3a1ef | 2017-06-28 09:10:48 -0700 | [diff] [blame] | 555 | |
Ivan Lozano | a9255a8 | 2018-03-13 10:41:07 -0700 | [diff] [blame] | 556 | // Global integer_overflow builds do not support static library diagnostics. |
Ivan Lozano | 0c3a1ef | 2017-06-28 09:10:48 -0700 | [diff] [blame] | 557 | if found, globalSanitizersDiag = removeFromList("integer_overflow", globalSanitizersDiag); found && |
Ivan Lozano | a9255a8 | 2018-03-13 10:41:07 -0700 | [diff] [blame] | 558 | s.Diag.Integer_overflow == nil && Bool(s.Integer_overflow) && !ctx.static() { |
Liz Kammer | b2fc470 | 2021-06-25 14:53:40 -0400 | [diff] [blame] | 559 | s.Diag.Integer_overflow = proptools.BoolPtr(true) |
Ivan Lozano | 0c3a1ef | 2017-06-28 09:10:48 -0700 | [diff] [blame] | 560 | } |
| 561 | |
Vishwath Mohan | 1fa3ac5 | 2017-10-31 02:26:14 -0700 | [diff] [blame] | 562 | if found, globalSanitizersDiag = removeFromList("cfi", globalSanitizersDiag); found && |
| 563 | s.Diag.Cfi == nil && Bool(s.Cfi) { |
Liz Kammer | b2fc470 | 2021-06-25 14:53:40 -0400 | [diff] [blame] | 564 | s.Diag.Cfi = proptools.BoolPtr(true) |
Vishwath Mohan | 1fa3ac5 | 2017-10-31 02:26:14 -0700 | [diff] [blame] | 565 | } |
| 566 | |
Evgenii Stepanov | 04896ca | 2021-01-12 18:28:33 -0800 | [diff] [blame] | 567 | if found, globalSanitizersDiag = removeFromList("memtag_heap", globalSanitizersDiag); found && |
| 568 | s.Diag.Memtag_heap == nil && Bool(s.Memtag_heap) { |
Liz Kammer | b2fc470 | 2021-06-25 14:53:40 -0400 | [diff] [blame] | 569 | s.Diag.Memtag_heap = proptools.BoolPtr(true) |
Evgenii Stepanov | 04896ca | 2021-01-12 18:28:33 -0800 | [diff] [blame] | 570 | } |
| 571 | |
Ivan Lozano | 0c3a1ef | 2017-06-28 09:10:48 -0700 | [diff] [blame] | 572 | if len(globalSanitizersDiag) > 0 { |
| 573 | ctx.ModuleErrorf("unknown global sanitizer diagnostics option %s", globalSanitizersDiag[0]) |
| 574 | } |
Evgenii Stepanov | fcfe56d | 2016-07-07 10:54:07 -0700 | [diff] [blame] | 575 | } |
Colin Cross | 3c344ef | 2016-07-18 15:44:56 -0700 | [diff] [blame] | 576 | |
Evgenii Stepanov | 4beaa0c | 2021-01-05 16:41:26 -0800 | [diff] [blame] | 577 | // Enable Memtag for all components in the include paths (for Aarch64 only) |
Colin Cross | 88a029f | 2022-06-23 14:51:20 -0700 | [diff] [blame] | 578 | if ctx.Arch().ArchType == android.Arm64 && ctx.toolchain().Bionic() { |
Evgenii Stepanov | 4beaa0c | 2021-01-05 16:41:26 -0800 | [diff] [blame] | 579 | if ctx.Config().MemtagHeapSyncEnabledForPath(ctx.ModuleDir()) { |
Evgenii Stepanov | 04896ca | 2021-01-12 18:28:33 -0800 | [diff] [blame] | 580 | if s.Memtag_heap == nil { |
Liz Kammer | b2fc470 | 2021-06-25 14:53:40 -0400 | [diff] [blame] | 581 | s.Memtag_heap = proptools.BoolPtr(true) |
Evgenii Stepanov | 04896ca | 2021-01-12 18:28:33 -0800 | [diff] [blame] | 582 | } |
| 583 | if s.Diag.Memtag_heap == nil { |
Liz Kammer | b2fc470 | 2021-06-25 14:53:40 -0400 | [diff] [blame] | 584 | s.Diag.Memtag_heap = proptools.BoolPtr(true) |
Evgenii Stepanov | 04896ca | 2021-01-12 18:28:33 -0800 | [diff] [blame] | 585 | } |
Evgenii Stepanov | 4beaa0c | 2021-01-05 16:41:26 -0800 | [diff] [blame] | 586 | } else if ctx.Config().MemtagHeapAsyncEnabledForPath(ctx.ModuleDir()) { |
Evgenii Stepanov | 04896ca | 2021-01-12 18:28:33 -0800 | [diff] [blame] | 587 | if s.Memtag_heap == nil { |
Liz Kammer | b2fc470 | 2021-06-25 14:53:40 -0400 | [diff] [blame] | 588 | s.Memtag_heap = proptools.BoolPtr(true) |
Evgenii Stepanov | 04896ca | 2021-01-12 18:28:33 -0800 | [diff] [blame] | 589 | } |
Evgenii Stepanov | 4beaa0c | 2021-01-05 16:41:26 -0800 | [diff] [blame] | 590 | } |
Evgenii Stepanov | 193ac2e | 2020-04-28 15:09:12 -0700 | [diff] [blame] | 591 | } |
| 592 | |
Elvis Chien | 9c99354 | 2021-06-25 01:15:17 +0800 | [diff] [blame] | 593 | // Enable CFI for non-host components in the include paths |
| 594 | if s.Cfi == nil && ctx.Config().CFIEnabledForPath(ctx.ModuleDir()) && !ctx.Host() { |
Liz Kammer | b2fc470 | 2021-06-25 14:53:40 -0400 | [diff] [blame] | 595 | s.Cfi = proptools.BoolPtr(true) |
Vishwath Mohan | 3af8ee0 | 2018-03-30 02:55:23 +0000 | [diff] [blame] | 596 | if inList("cfi", ctx.Config().SanitizeDeviceDiag()) { |
Liz Kammer | b2fc470 | 2021-06-25 14:53:40 -0400 | [diff] [blame] | 597 | s.Diag.Cfi = proptools.BoolPtr(true) |
Vishwath Mohan | 1fa3ac5 | 2017-10-31 02:26:14 -0700 | [diff] [blame] | 598 | } |
| 599 | } |
| 600 | |
Elliott Hughes | da3a071 | 2020-03-06 16:55:28 -0800 | [diff] [blame] | 601 | // Is CFI actually enabled? |
| 602 | if !ctx.Config().EnableCFI() { |
Liz Kammer | b2fc470 | 2021-06-25 14:53:40 -0400 | [diff] [blame] | 603 | s.Cfi = nil |
| 604 | s.Diag.Cfi = nil |
Vishwath Mohan | 1b017a7 | 2017-01-19 13:54:55 -0800 | [diff] [blame] | 605 | } |
| 606 | |
Evgenii Stepanov | d97a6e9 | 2018-08-02 16:19:13 -0700 | [diff] [blame] | 607 | // HWASan requires AArch64 hardware feature (top-byte-ignore). |
Colin Cross | 88a029f | 2022-06-23 14:51:20 -0700 | [diff] [blame] | 608 | if ctx.Arch().ArchType != android.Arm64 || !ctx.toolchain().Bionic() { |
Evgenii Stepanov | d97a6e9 | 2018-08-02 16:19:13 -0700 | [diff] [blame] | 609 | s.Hwaddress = nil |
| 610 | } |
| 611 | |
Elliott Hughes | e4793bc | 2023-02-09 21:15:47 +0000 | [diff] [blame] | 612 | // SCS is only implemented on AArch64/riscv64. |
| 613 | if (ctx.Arch().ArchType != android.Arm64 && ctx.Arch().ArchType != android.Riscv64) || !ctx.toolchain().Bionic() { |
Peter Collingbourne | 8c7e6e2 | 2018-11-19 16:03:58 -0800 | [diff] [blame] | 614 | s.Scs = nil |
| 615 | } |
| 616 | |
Ivan Lozano | 62cd038 | 2021-11-01 10:27:54 -0400 | [diff] [blame] | 617 | // Memtag_heap is only implemented on AArch64. |
Florian Mayer | d8434a4 | 2022-08-31 20:57:03 +0000 | [diff] [blame] | 618 | // Memtag ABI is Android specific for now, so disable for host. |
| 619 | if ctx.Arch().ArchType != android.Arm64 || !ctx.toolchain().Bionic() || ctx.Host() { |
Evgenii Stepanov | 193ac2e | 2020-04-28 15:09:12 -0700 | [diff] [blame] | 620 | s.Memtag_heap = nil |
Florian Mayer | d8434a4 | 2022-08-31 20:57:03 +0000 | [diff] [blame] | 621 | s.Memtag_stack = nil |
Evgenii Stepanov | 193ac2e | 2020-04-28 15:09:12 -0700 | [diff] [blame] | 622 | } |
| 623 | |
Vishwath Mohan | 8f4fdd8 | 2017-04-20 07:42:52 -0700 | [diff] [blame] | 624 | // Also disable CFI if ASAN is enabled. |
Evgenii Stepanov | d97a6e9 | 2018-08-02 16:19:13 -0700 | [diff] [blame] | 625 | if Bool(s.Address) || Bool(s.Hwaddress) { |
Liz Kammer | b2fc470 | 2021-06-25 14:53:40 -0400 | [diff] [blame] | 626 | s.Cfi = nil |
| 627 | s.Diag.Cfi = nil |
Florian Mayer | d8434a4 | 2022-08-31 20:57:03 +0000 | [diff] [blame] | 628 | // HWASAN and ASAN win against MTE. |
| 629 | s.Memtag_heap = nil |
| 630 | s.Memtag_stack = nil |
Vishwath Mohan | 8f4fdd8 | 2017-04-20 07:42:52 -0700 | [diff] [blame] | 631 | } |
| 632 | |
Colin Cross | ed12a04 | 2022-02-07 13:55:55 -0800 | [diff] [blame] | 633 | // Disable sanitizers that depend on the UBSan runtime for windows/darwin builds. |
| 634 | if !ctx.Os().Linux() { |
Liz Kammer | b2fc470 | 2021-06-25 14:53:40 -0400 | [diff] [blame] | 635 | s.Cfi = nil |
| 636 | s.Diag.Cfi = nil |
Ivan Lozano | a9255a8 | 2018-03-13 10:41:07 -0700 | [diff] [blame] | 637 | s.Misc_undefined = nil |
| 638 | s.Undefined = nil |
| 639 | s.All_undefined = nil |
| 640 | s.Integer_overflow = nil |
Vishwath Mohan | e712879 | 2017-11-17 11:08:10 -0800 | [diff] [blame] | 641 | } |
| 642 | |
Colin Cross | 2c435a0 | 2022-10-20 13:55:53 -0700 | [diff] [blame] | 643 | // TODO(b/254713216): CFI doesn't work for riscv64 yet because LTO doesn't work. |
Colin Cross | ecf4e66 | 2022-10-20 13:59:17 -0700 | [diff] [blame] | 644 | if ctx.Arch().ArchType == android.Riscv64 { |
| 645 | s.Cfi = nil |
| 646 | s.Diag.Cfi = nil |
| 647 | } |
| 648 | |
Colin Cross | ed12a04 | 2022-02-07 13:55:55 -0800 | [diff] [blame] | 649 | // Disable CFI for musl |
| 650 | if ctx.toolchain().Musl() { |
| 651 | s.Cfi = nil |
| 652 | s.Diag.Cfi = nil |
| 653 | } |
| 654 | |
Vishwath Mohan | 9ccbba0 | 2018-05-28 13:54:48 -0700 | [diff] [blame] | 655 | // Also disable CFI for VNDK variants of components |
| 656 | if ctx.isVndk() && ctx.useVndk() { |
Justin Yun | 08270c6 | 2022-12-19 17:01:26 +0900 | [diff] [blame] | 657 | s.Cfi = nil |
| 658 | s.Diag.Cfi = nil |
Inseob Kim | eec88e1 | 2020-01-22 11:11:29 +0900 | [diff] [blame] | 659 | } |
| 660 | |
Evgenii Stepanov | d97a6e9 | 2018-08-02 16:19:13 -0700 | [diff] [blame] | 661 | // HWASan ramdisk (which is built from recovery) goes over some bootloader limit. |
Yifan Hong | 60e0cfb | 2020-10-21 15:17:56 -0700 | [diff] [blame] | 662 | // Keep libc instrumented so that ramdisk / vendor_ramdisk / recovery can run hwasan-instrumented code if necessary. |
| 663 | if (ctx.inRamdisk() || ctx.inVendorRamdisk() || ctx.inRecovery()) && !strings.HasPrefix(ctx.ModuleDir(), "bionic/libc") { |
Evgenii Stepanov | d97a6e9 | 2018-08-02 16:19:13 -0700 | [diff] [blame] | 664 | s.Hwaddress = nil |
| 665 | } |
| 666 | |
Colin Cross | 3c344ef | 2016-07-18 15:44:56 -0700 | [diff] [blame] | 667 | if ctx.staticBinary() { |
| 668 | s.Address = nil |
Mitch Phillips | 5a6ea6c | 2019-05-01 14:42:05 -0700 | [diff] [blame] | 669 | s.Fuzzer = nil |
Colin Cross | 3c344ef | 2016-07-18 15:44:56 -0700 | [diff] [blame] | 670 | s.Thread = nil |
Colin Cross | 16b2349 | 2016-01-06 14:41:07 -0800 | [diff] [blame] | 671 | } |
| 672 | |
Evgenii Stepanov | fcfe56d | 2016-07-07 10:54:07 -0700 | [diff] [blame] | 673 | if Bool(s.All_undefined) { |
| 674 | s.Undefined = nil |
| 675 | } |
| 676 | |
Evgenii Stepanov | 0a8a0d0 | 2016-05-12 13:54:53 -0700 | [diff] [blame] | 677 | if !ctx.toolchain().Is64Bit() { |
| 678 | // TSAN and SafeStack are not supported on 32-bit architectures |
Evgenii Stepanov | fcfe56d | 2016-07-07 10:54:07 -0700 | [diff] [blame] | 679 | s.Thread = nil |
| 680 | s.Safestack = nil |
Colin Cross | 16b2349 | 2016-01-06 14:41:07 -0800 | [diff] [blame] | 681 | // TODO(ccross): error for compile_multilib = "32"? |
| 682 | } |
| 683 | |
Evgenii Stepanov | 76cee23 | 2017-01-27 15:44:44 -0800 | [diff] [blame] | 684 | if ctx.Os() != android.Windows && (Bool(s.All_undefined) || Bool(s.Undefined) || Bool(s.Address) || Bool(s.Thread) || |
Mitch Phillips | 5a6ea6c | 2019-05-01 14:42:05 -0700 | [diff] [blame] | 685 | Bool(s.Fuzzer) || Bool(s.Safestack) || Bool(s.Cfi) || Bool(s.Integer_overflow) || len(s.Misc_undefined) > 0 || |
Florian Mayer | d8434a4 | 2022-08-31 20:57:03 +0000 | [diff] [blame] | 686 | Bool(s.Scudo) || Bool(s.Hwaddress) || Bool(s.Scs) || Bool(s.Memtag_heap) || Bool(s.Memtag_stack)) { |
Colin Cross | 3c344ef | 2016-07-18 15:44:56 -0700 | [diff] [blame] | 687 | sanitize.Properties.SanitizerEnabled = true |
| 688 | } |
| 689 | |
Kostya Kortchinsky | d5275c8 | 2019-02-01 08:42:56 -0800 | [diff] [blame] | 690 | // Disable Scudo if ASan or TSan is enabled, or if it's disabled globally. |
| 691 | if Bool(s.Address) || Bool(s.Thread) || Bool(s.Hwaddress) || ctx.Config().DisableScudo() { |
Kostya Kortchinsky | d18ae5c | 2018-06-12 14:46:54 -0700 | [diff] [blame] | 692 | s.Scudo = nil |
| 693 | } |
| 694 | |
Evgenii Stepanov | d97a6e9 | 2018-08-02 16:19:13 -0700 | [diff] [blame] | 695 | if Bool(s.Hwaddress) { |
| 696 | s.Address = nil |
| 697 | s.Thread = nil |
| 698 | } |
Mitch Phillips | 5007c4a | 2022-03-02 01:25:22 +0000 | [diff] [blame] | 699 | |
| 700 | // TODO(b/131771163): CFI transiently depends on LTO, and thus Fuzzer is |
| 701 | // mutually incompatible. |
| 702 | if Bool(s.Fuzzer) { |
| 703 | s.Cfi = nil |
| 704 | } |
Colin Cross | 16b2349 | 2016-01-06 14:41:07 -0800 | [diff] [blame] | 705 | } |
| 706 | |
Chih-Hung Hsieh | 3567e62 | 2018-11-15 14:01:36 -0800 | [diff] [blame] | 707 | func toDisableImplicitIntegerChange(flags []string) bool { |
| 708 | // Returns true if any flag is fsanitize*integer, and there is |
| 709 | // no explicit flag about sanitize=implicit-integer-sign-change. |
| 710 | for _, f := range flags { |
| 711 | if strings.Contains(f, "sanitize=implicit-integer-sign-change") { |
| 712 | return false |
| 713 | } |
| 714 | } |
| 715 | for _, f := range flags { |
| 716 | if strings.HasPrefix(f, "-fsanitize") && strings.Contains(f, "integer") { |
| 717 | return true |
| 718 | } |
| 719 | } |
| 720 | return false |
| 721 | } |
| 722 | |
Yabin Cui | db7dda8 | 2020-11-30 15:47:45 -0800 | [diff] [blame] | 723 | func toDisableUnsignedShiftBaseChange(flags []string) bool { |
| 724 | // Returns true if any flag is fsanitize*integer, and there is |
| 725 | // no explicit flag about sanitize=unsigned-shift-base. |
| 726 | for _, f := range flags { |
| 727 | if strings.Contains(f, "sanitize=unsigned-shift-base") { |
| 728 | return false |
| 729 | } |
| 730 | } |
| 731 | for _, f := range flags { |
| 732 | if strings.HasPrefix(f, "-fsanitize") && strings.Contains(f, "integer") { |
| 733 | return true |
| 734 | } |
| 735 | } |
| 736 | return false |
| 737 | } |
| 738 | |
Liz Kammer | 2c1d6aa | 2022-10-03 15:07:37 -0400 | [diff] [blame] | 739 | func (s *sanitize) flags(ctx ModuleContext, flags Flags) Flags { |
| 740 | if !s.Properties.SanitizerEnabled && !s.Properties.UbsanRuntimeDep { |
Colin Cross | 16b2349 | 2016-01-06 14:41:07 -0800 | [diff] [blame] | 741 | return flags |
| 742 | } |
Liz Kammer | 2c1d6aa | 2022-10-03 15:07:37 -0400 | [diff] [blame] | 743 | sanProps := &s.Properties.SanitizeMutated |
Colin Cross | 16b2349 | 2016-01-06 14:41:07 -0800 | [diff] [blame] | 744 | |
Liz Kammer | 2c1d6aa | 2022-10-03 15:07:37 -0400 | [diff] [blame] | 745 | if Bool(sanProps.Address) { |
Colin Cross | 635c3b0 | 2016-05-18 15:37:25 -0700 | [diff] [blame] | 746 | if ctx.Arch().ArchType == android.Arm { |
Colin Cross | 16b2349 | 2016-01-06 14:41:07 -0800 | [diff] [blame] | 747 | // Frame pointer based unwinder in ASan requires ARM frame setup. |
| 748 | // TODO: put in flags? |
| 749 | flags.RequiredInstructionSet = "arm" |
| 750 | } |
Colin Cross | 4af21ed | 2019-11-04 09:37:55 -0800 | [diff] [blame] | 751 | flags.Local.CFlags = append(flags.Local.CFlags, asanCflags...) |
| 752 | flags.Local.LdFlags = append(flags.Local.LdFlags, asanLdflags...) |
Colin Cross | 16b2349 | 2016-01-06 14:41:07 -0800 | [diff] [blame] | 753 | |
Liz Kammer | 2c1d6aa | 2022-10-03 15:07:37 -0400 | [diff] [blame] | 754 | if Bool(sanProps.Writeonly) { |
Jasraj Bedi | bb4511d | 2020-07-23 22:58:17 +0000 | [diff] [blame] | 755 | flags.Local.CFlags = append(flags.Local.CFlags, "-mllvm", "-asan-instrument-reads=0") |
| 756 | } |
| 757 | |
Colin Cross | 16b2349 | 2016-01-06 14:41:07 -0800 | [diff] [blame] | 758 | if ctx.Host() { |
| 759 | // -nodefaultlibs (provided with libc++) prevents the driver from linking |
| 760 | // libraries needed with -fsanitize=address. http://b/18650275 (WAI) |
Colin Cross | 4af21ed | 2019-11-04 09:37:55 -0800 | [diff] [blame] | 761 | flags.Local.LdFlags = append(flags.Local.LdFlags, "-Wl,--no-as-needed") |
Colin Cross | 16b2349 | 2016-01-06 14:41:07 -0800 | [diff] [blame] | 762 | } else { |
Colin Cross | 4af21ed | 2019-11-04 09:37:55 -0800 | [diff] [blame] | 763 | flags.Local.CFlags = append(flags.Local.CFlags, "-mllvm", "-asan-globals=0") |
Jiyong Park | a2aca28 | 2019-02-02 13:13:38 +0900 | [diff] [blame] | 764 | if ctx.bootstrap() { |
| 765 | flags.DynamicLinker = "/system/bin/bootstrap/linker_asan" |
| 766 | } else { |
| 767 | flags.DynamicLinker = "/system/bin/linker_asan" |
| 768 | } |
Colin Cross | 16b2349 | 2016-01-06 14:41:07 -0800 | [diff] [blame] | 769 | if flags.Toolchain.Is64Bit() { |
| 770 | flags.DynamicLinker += "64" |
| 771 | } |
| 772 | } |
Colin Cross | 16b2349 | 2016-01-06 14:41:07 -0800 | [diff] [blame] | 773 | } |
| 774 | |
Liz Kammer | 2c1d6aa | 2022-10-03 15:07:37 -0400 | [diff] [blame] | 775 | if Bool(sanProps.Hwaddress) { |
Colin Cross | 4af21ed | 2019-11-04 09:37:55 -0800 | [diff] [blame] | 776 | flags.Local.CFlags = append(flags.Local.CFlags, hwasanCflags...) |
Yi Kong | 286abc6 | 2021-11-04 16:14:14 +0800 | [diff] [blame] | 777 | |
| 778 | for _, flag := range hwasanCommonflags { |
| 779 | flags.Local.CFlags = append(flags.Local.CFlags, "-mllvm", flag) |
| 780 | } |
| 781 | for _, flag := range hwasanCommonflags { |
| 782 | flags.Local.LdFlags = append(flags.Local.LdFlags, "-Wl,-mllvm,"+flag) |
| 783 | } |
| 784 | |
Liz Kammer | 2c1d6aa | 2022-10-03 15:07:37 -0400 | [diff] [blame] | 785 | if Bool(sanProps.Writeonly) { |
Jasraj Bedi | bb4511d | 2020-07-23 22:58:17 +0000 | [diff] [blame] | 786 | flags.Local.CFlags = append(flags.Local.CFlags, "-mllvm", "-hwasan-instrument-reads=0") |
| 787 | } |
Yabin Cui | 6be405e | 2017-10-19 15:52:11 -0700 | [diff] [blame] | 788 | } |
| 789 | |
Liz Kammer | 2c1d6aa | 2022-10-03 15:07:37 -0400 | [diff] [blame] | 790 | if Bool(sanProps.Fuzzer) { |
Colin Cross | 4af21ed | 2019-11-04 09:37:55 -0800 | [diff] [blame] | 791 | flags.Local.CFlags = append(flags.Local.CFlags, "-fsanitize=fuzzer-no-link") |
Mitch Phillips | 5a6ea6c | 2019-05-01 14:42:05 -0700 | [diff] [blame] | 792 | |
Mitch Phillips | 5007c4a | 2022-03-02 01:25:22 +0000 | [diff] [blame] | 793 | // TODO(b/131771163): LTO and Fuzzer support is mutually incompatible. |
| 794 | _, flags.Local.LdFlags = removeFromList("-flto", flags.Local.LdFlags) |
| 795 | _, flags.Local.CFlags = removeFromList("-flto", flags.Local.CFlags) |
| 796 | flags.Local.LdFlags = append(flags.Local.LdFlags, "-fno-lto") |
| 797 | flags.Local.CFlags = append(flags.Local.CFlags, "-fno-lto") |
| 798 | |
Mitch Phillips | b8e593d | 2019-10-09 17:18:59 -0700 | [diff] [blame] | 799 | // TODO(b/142430592): Upstream linker scripts for sanitizer runtime libraries |
| 800 | // discard the sancov_lowest_stack symbol, because it's emulated TLS (and thus |
| 801 | // doesn't match the linker script due to the "__emutls_v." prefix). |
Colin Cross | 4af21ed | 2019-11-04 09:37:55 -0800 | [diff] [blame] | 802 | flags.Local.LdFlags = append(flags.Local.LdFlags, "-fno-sanitize-coverage=stack-depth") |
| 803 | flags.Local.CFlags = append(flags.Local.CFlags, "-fno-sanitize-coverage=stack-depth") |
Mitch Phillips | b8e593d | 2019-10-09 17:18:59 -0700 | [diff] [blame] | 804 | |
Mitch Phillips | b9b3e79 | 2019-08-28 12:41:07 -0700 | [diff] [blame] | 805 | // Disable fortify for fuzzing builds. Generally, we'll be building with |
| 806 | // UBSan or ASan here and the fortify checks pollute the stack traces. |
Colin Cross | 4af21ed | 2019-11-04 09:37:55 -0800 | [diff] [blame] | 807 | flags.Local.CFlags = append(flags.Local.CFlags, "-U_FORTIFY_SOURCE") |
Mitch Phillips | 734b4cb | 2019-12-10 08:44:52 -0800 | [diff] [blame] | 808 | |
| 809 | // Build fuzzer-sanitized libraries with an $ORIGIN DT_RUNPATH. Android's |
| 810 | // linker uses DT_RUNPATH, not DT_RPATH. When we deploy cc_fuzz targets and |
| 811 | // their libraries to /data/fuzz/<arch>/lib, any transient shared library gets |
| 812 | // the DT_RUNPATH from the shared library above it, and not the executable, |
| 813 | // meaning that the lookup falls back to the system. Adding the $ORIGIN to the |
| 814 | // DT_RUNPATH here means that transient shared libraries can be found |
| 815 | // colocated with their parents. |
| 816 | flags.Local.LdFlags = append(flags.Local.LdFlags, `-Wl,-rpath,\$$ORIGIN`) |
Colin Cross | 16b2349 | 2016-01-06 14:41:07 -0800 | [diff] [blame] | 817 | } |
| 818 | |
Liz Kammer | 2c1d6aa | 2022-10-03 15:07:37 -0400 | [diff] [blame] | 819 | if Bool(sanProps.Cfi) { |
Evgenii Stepanov | 7ebf9fa | 2017-01-20 14:13:06 -0800 | [diff] [blame] | 820 | if ctx.Arch().ArchType == android.Arm { |
| 821 | // __cfi_check needs to be built as Thumb (see the code in linker_cfi.cpp). LLVM is not set up |
| 822 | // to do this on a function basis, so force Thumb on the entire module. |
| 823 | flags.RequiredInstructionSet = "thumb" |
| 824 | } |
Vishwath Mohan | b743e9c | 2017-11-01 09:20:21 +0000 | [diff] [blame] | 825 | |
Colin Cross | 4af21ed | 2019-11-04 09:37:55 -0800 | [diff] [blame] | 826 | flags.Local.CFlags = append(flags.Local.CFlags, cfiCflags...) |
| 827 | flags.Local.AsFlags = append(flags.Local.AsFlags, cfiAsflags...) |
Liz Kammer | 2c1d6aa | 2022-10-03 15:07:37 -0400 | [diff] [blame] | 828 | if Bool(s.Properties.Sanitize.Config.Cfi_assembly_support) { |
Trevor Radcliffe | 391a25d | 2023-03-22 20:22:27 +0000 | [diff] [blame^] | 829 | flags.Local.CFlags = append(flags.Local.CFlags, cfiAssemblySupportFlag) |
Cindy Zhou | 8cd45de | 2020-11-16 08:41:00 -0800 | [diff] [blame] | 830 | } |
Vishwath Mohan | b743e9c | 2017-11-01 09:20:21 +0000 | [diff] [blame] | 831 | // Only append the default visibility flag if -fvisibility has not already been set |
| 832 | // to hidden. |
Colin Cross | 4af21ed | 2019-11-04 09:37:55 -0800 | [diff] [blame] | 833 | if !inList("-fvisibility=hidden", flags.Local.CFlags) { |
| 834 | flags.Local.CFlags = append(flags.Local.CFlags, "-fvisibility=default") |
Vishwath Mohan | b743e9c | 2017-11-01 09:20:21 +0000 | [diff] [blame] | 835 | } |
Colin Cross | 4af21ed | 2019-11-04 09:37:55 -0800 | [diff] [blame] | 836 | flags.Local.LdFlags = append(flags.Local.LdFlags, cfiLdflags...) |
Vishwath Mohan | b743e9c | 2017-11-01 09:20:21 +0000 | [diff] [blame] | 837 | |
| 838 | if ctx.staticBinary() { |
Colin Cross | 4af21ed | 2019-11-04 09:37:55 -0800 | [diff] [blame] | 839 | _, flags.Local.CFlags = removeFromList("-fsanitize-cfi-cross-dso", flags.Local.CFlags) |
| 840 | _, flags.Local.LdFlags = removeFromList("-fsanitize-cfi-cross-dso", flags.Local.LdFlags) |
Vishwath Mohan | b743e9c | 2017-11-01 09:20:21 +0000 | [diff] [blame] | 841 | } |
Evgenii Stepanov | 1e405e1 | 2016-08-16 15:39:54 -0700 | [diff] [blame] | 842 | } |
| 843 | |
Liz Kammer | 2c1d6aa | 2022-10-03 15:07:37 -0400 | [diff] [blame] | 844 | if Bool(sanProps.Memtag_stack) { |
Florian Mayer | d8434a4 | 2022-08-31 20:57:03 +0000 | [diff] [blame] | 845 | flags.Local.CFlags = append(flags.Local.CFlags, memtagStackCommonFlags...) |
Florian Mayer | 25cd981 | 2023-03-21 16:13:36 +0000 | [diff] [blame] | 846 | // TODO(fmayer): remove -Wno-error once https://reviews.llvm.org/D127917 is in Android toolchain. |
| 847 | flags.Local.CFlags = append(flags.Local.CFlags, "-Wno-error=frame-larger-than") |
Florian Mayer | d8434a4 | 2022-08-31 20:57:03 +0000 | [diff] [blame] | 848 | flags.Local.AsFlags = append(flags.Local.AsFlags, memtagStackCommonFlags...) |
| 849 | flags.Local.LdFlags = append(flags.Local.LdFlags, memtagStackCommonFlags...) |
Florian Mayer | 25cd981 | 2023-03-21 16:13:36 +0000 | [diff] [blame] | 850 | // This works around LLD complaining about the stack frame size. |
| 851 | // TODO(fmayer): remove once https://reviews.llvm.org/D127917 is in Android toolchain. |
| 852 | flags.Local.LdFlags = append(flags.Local.LdFlags, "-Wl,--no-fatal-warnings") |
Florian Mayer | d8434a4 | 2022-08-31 20:57:03 +0000 | [diff] [blame] | 853 | } |
| 854 | |
Liz Kammer | 2c1d6aa | 2022-10-03 15:07:37 -0400 | [diff] [blame] | 855 | if (Bool(sanProps.Memtag_heap) || Bool(sanProps.Memtag_stack)) && ctx.binary() { |
| 856 | if Bool(sanProps.Diag.Memtag_heap) { |
Florian Mayer | d8434a4 | 2022-08-31 20:57:03 +0000 | [diff] [blame] | 857 | flags.Local.LdFlags = append(flags.Local.LdFlags, "-fsanitize-memtag-mode=sync") |
| 858 | } else { |
| 859 | flags.Local.LdFlags = append(flags.Local.LdFlags, "-fsanitize-memtag-mode=async") |
| 860 | } |
| 861 | } |
| 862 | |
Liz Kammer | 2c1d6aa | 2022-10-03 15:07:37 -0400 | [diff] [blame] | 863 | if Bool(sanProps.Integer_overflow) { |
Colin Cross | 4af21ed | 2019-11-04 09:37:55 -0800 | [diff] [blame] | 864 | flags.Local.CFlags = append(flags.Local.CFlags, intOverflowCflags...) |
Ivan Lozano | 0c3a1ef | 2017-06-28 09:10:48 -0700 | [diff] [blame] | 865 | } |
| 866 | |
Liz Kammer | 2c1d6aa | 2022-10-03 15:07:37 -0400 | [diff] [blame] | 867 | if len(s.Properties.Sanitizers) > 0 { |
| 868 | sanitizeArg := "-fsanitize=" + strings.Join(s.Properties.Sanitizers, ",") |
Colin Cross | 4af21ed | 2019-11-04 09:37:55 -0800 | [diff] [blame] | 869 | flags.Local.CFlags = append(flags.Local.CFlags, sanitizeArg) |
| 870 | flags.Local.AsFlags = append(flags.Local.AsFlags, sanitizeArg) |
Colin Cross | 234b01d | 2022-02-07 13:49:03 -0800 | [diff] [blame] | 871 | flags.Local.LdFlags = append(flags.Local.LdFlags, sanitizeArg) |
| 872 | |
Colin Cross | ed12a04 | 2022-02-07 13:55:55 -0800 | [diff] [blame] | 873 | if ctx.toolchain().Bionic() || ctx.toolchain().Musl() { |
| 874 | // Bionic and musl sanitizer runtimes have already been added as dependencies so that |
| 875 | // the right variant of the runtime will be used (with the "-android" or "-musl" |
| 876 | // suffixes), so don't let clang the runtime library. |
Colin Cross | 234b01d | 2022-02-07 13:49:03 -0800 | [diff] [blame] | 877 | flags.Local.LdFlags = append(flags.Local.LdFlags, "-fno-sanitize-link-runtime") |
| 878 | } else { |
Evgenii Stepanov | 76cee23 | 2017-01-27 15:44:44 -0800 | [diff] [blame] | 879 | // Host sanitizers only link symbols in the final executable, so |
| 880 | // there will always be undefined symbols in intermediate libraries. |
Colin Cross | 4af21ed | 2019-11-04 09:37:55 -0800 | [diff] [blame] | 881 | _, flags.Global.LdFlags = removeFromList("-Wl,--no-undefined", flags.Global.LdFlags) |
Colin Cross | 6c18d00 | 2022-06-02 15:11:50 -0700 | [diff] [blame] | 882 | } |
Ivan Lozano | 9ac32c7 | 2020-02-19 15:24:02 -0500 | [diff] [blame] | 883 | |
Colin Cross | 6c18d00 | 2022-06-02 15:11:50 -0700 | [diff] [blame] | 884 | if !ctx.toolchain().Bionic() { |
| 885 | // non-Bionic toolchain prebuilts are missing UBSan's vptr and function san. |
| 886 | // Musl toolchain prebuilts have vptr and function sanitizers, but enabling them |
| 887 | // implicitly enables RTTI which causes RTTI mismatch issues with dependencies. |
| 888 | |
Colin Cross | 234b01d | 2022-02-07 13:49:03 -0800 | [diff] [blame] | 889 | flags.Local.CFlags = append(flags.Local.CFlags, "-fno-sanitize=vptr,function") |
Ivan Lozano | 9ac32c7 | 2020-02-19 15:24:02 -0500 | [diff] [blame] | 890 | } |
| 891 | |
Liz Kammer | 2c1d6aa | 2022-10-03 15:07:37 -0400 | [diff] [blame] | 892 | if Bool(sanProps.Fuzzer) { |
Mitch Phillips | 5a6ea6c | 2019-05-01 14:42:05 -0700 | [diff] [blame] | 893 | // When fuzzing, we wish to crash with diagnostics on any bug. |
Colin Cross | 4af21ed | 2019-11-04 09:37:55 -0800 | [diff] [blame] | 894 | flags.Local.CFlags = append(flags.Local.CFlags, "-fno-sanitize-trap=all", "-fno-sanitize-recover=all") |
Mitch Phillips | 5a6ea6c | 2019-05-01 14:42:05 -0700 | [diff] [blame] | 895 | } else if ctx.Host() { |
Trevor Radcliffe | 4f95ee9 | 2023-01-19 16:02:47 +0000 | [diff] [blame] | 896 | flags.Local.CFlags = append(flags.Local.CFlags, hostOnlySanitizeFlags...) |
Mitch Phillips | 5a6ea6c | 2019-05-01 14:42:05 -0700 | [diff] [blame] | 897 | } else { |
Trevor Radcliffe | 4f95ee9 | 2023-01-19 16:02:47 +0000 | [diff] [blame] | 898 | flags.Local.CFlags = append(flags.Local.CFlags, deviceOnlySanitizeFlags...) |
Mitch Phillips | 5a6ea6c | 2019-05-01 14:42:05 -0700 | [diff] [blame] | 899 | } |
Evgenii Stepanov | 5901281 | 2022-06-24 11:09:18 -0700 | [diff] [blame] | 900 | |
Liz Kammer | 2c1d6aa | 2022-10-03 15:07:37 -0400 | [diff] [blame] | 901 | if enableMinimalRuntime(s) { |
Evgenii Stepanov | 5901281 | 2022-06-24 11:09:18 -0700 | [diff] [blame] | 902 | flags.Local.CFlags = append(flags.Local.CFlags, strings.Join(minimalRuntimeFlags, " ")) |
| 903 | } |
| 904 | |
Chih-Hung Hsieh | 3567e62 | 2018-11-15 14:01:36 -0800 | [diff] [blame] | 905 | // http://b/119329758, Android core does not boot up with this sanitizer yet. |
Colin Cross | 4af21ed | 2019-11-04 09:37:55 -0800 | [diff] [blame] | 906 | if toDisableImplicitIntegerChange(flags.Local.CFlags) { |
| 907 | flags.Local.CFlags = append(flags.Local.CFlags, "-fno-sanitize=implicit-integer-sign-change") |
Chih-Hung Hsieh | 3567e62 | 2018-11-15 14:01:36 -0800 | [diff] [blame] | 908 | } |
Yabin Cui | db7dda8 | 2020-11-30 15:47:45 -0800 | [diff] [blame] | 909 | // http://b/171275751, Android doesn't build with this sanitizer yet. |
| 910 | if toDisableUnsignedShiftBaseChange(flags.Local.CFlags) { |
| 911 | flags.Local.CFlags = append(flags.Local.CFlags, "-fno-sanitize=unsigned-shift-base") |
| 912 | } |
Colin Cross | 16b2349 | 2016-01-06 14:41:07 -0800 | [diff] [blame] | 913 | } |
| 914 | |
Liz Kammer | 2c1d6aa | 2022-10-03 15:07:37 -0400 | [diff] [blame] | 915 | if len(s.Properties.DiagSanitizers) > 0 { |
| 916 | flags.Local.CFlags = append(flags.Local.CFlags, "-fno-sanitize-trap="+strings.Join(s.Properties.DiagSanitizers, ",")) |
Evgenii Stepanov | 1e405e1 | 2016-08-16 15:39:54 -0700 | [diff] [blame] | 917 | } |
| 918 | // FIXME: enable RTTI if diag + (cfi or vptr) |
| 919 | |
Liz Kammer | 2c1d6aa | 2022-10-03 15:07:37 -0400 | [diff] [blame] | 920 | if s.Properties.Sanitize.Recover != nil { |
Colin Cross | 4af21ed | 2019-11-04 09:37:55 -0800 | [diff] [blame] | 921 | flags.Local.CFlags = append(flags.Local.CFlags, "-fsanitize-recover="+ |
Liz Kammer | 2c1d6aa | 2022-10-03 15:07:37 -0400 | [diff] [blame] | 922 | strings.Join(s.Properties.Sanitize.Recover, ",")) |
Andreas Gampe | 9707116 | 2017-05-08 13:15:23 -0700 | [diff] [blame] | 923 | } |
| 924 | |
Liz Kammer | 2c1d6aa | 2022-10-03 15:07:37 -0400 | [diff] [blame] | 925 | if s.Properties.Sanitize.Diag.No_recover != nil { |
Colin Cross | 4af21ed | 2019-11-04 09:37:55 -0800 | [diff] [blame] | 926 | flags.Local.CFlags = append(flags.Local.CFlags, "-fno-sanitize-recover="+ |
Liz Kammer | 2c1d6aa | 2022-10-03 15:07:37 -0400 | [diff] [blame] | 927 | strings.Join(s.Properties.Sanitize.Diag.No_recover, ",")) |
Ivan Lozano | 7929bba | 2018-12-12 09:36:31 -0800 | [diff] [blame] | 928 | } |
| 929 | |
Liz Kammer | 2c1d6aa | 2022-10-03 15:07:37 -0400 | [diff] [blame] | 930 | blocklist := android.OptionalPathForModuleSrc(ctx, s.Properties.Sanitize.Blocklist) |
Pirama Arumuga Nainar | 6c4ccca | 2020-07-27 11:49:51 -0700 | [diff] [blame] | 931 | if blocklist.Valid() { |
Pirama Arumuga Nainar | 582fc2d | 2021-08-27 15:12:56 -0700 | [diff] [blame] | 932 | flags.Local.CFlags = append(flags.Local.CFlags, "-fsanitize-ignorelist="+blocklist.String()) |
Pirama Arumuga Nainar | 6c4ccca | 2020-07-27 11:49:51 -0700 | [diff] [blame] | 933 | flags.CFlagsDeps = append(flags.CFlagsDeps, blocklist.Path()) |
| 934 | } |
| 935 | |
Colin Cross | 16b2349 | 2016-01-06 14:41:07 -0800 | [diff] [blame] | 936 | return flags |
| 937 | } |
| 938 | |
Liz Kammer | 2c1d6aa | 2022-10-03 15:07:37 -0400 | [diff] [blame] | 939 | func (s *sanitize) AndroidMkEntries(ctx AndroidMkContext, entries *android.AndroidMkEntries) { |
Jiyong Park | 1d1119f | 2019-07-29 21:27:18 +0900 | [diff] [blame] | 940 | // Add a suffix for cfi/hwasan/scs-enabled static/header libraries to allow surfacing |
| 941 | // both the sanitized and non-sanitized variants to make without a name conflict. |
Colin Cross | d80cbca | 2020-02-24 12:01:37 -0800 | [diff] [blame] | 942 | if entries.Class == "STATIC_LIBRARIES" || entries.Class == "HEADER_LIBRARIES" { |
Liz Kammer | 2c1d6aa | 2022-10-03 15:07:37 -0400 | [diff] [blame] | 943 | if Bool(s.Properties.SanitizeMutated.Cfi) { |
Colin Cross | d80cbca | 2020-02-24 12:01:37 -0800 | [diff] [blame] | 944 | entries.SubName += ".cfi" |
Jiyong Park | 1d1119f | 2019-07-29 21:27:18 +0900 | [diff] [blame] | 945 | } |
Liz Kammer | 2c1d6aa | 2022-10-03 15:07:37 -0400 | [diff] [blame] | 946 | if Bool(s.Properties.SanitizeMutated.Hwaddress) { |
Colin Cross | d80cbca | 2020-02-24 12:01:37 -0800 | [diff] [blame] | 947 | entries.SubName += ".hwasan" |
Jiyong Park | 1d1119f | 2019-07-29 21:27:18 +0900 | [diff] [blame] | 948 | } |
Liz Kammer | 2c1d6aa | 2022-10-03 15:07:37 -0400 | [diff] [blame] | 949 | if Bool(s.Properties.SanitizeMutated.Scs) { |
Colin Cross | d80cbca | 2020-02-24 12:01:37 -0800 | [diff] [blame] | 950 | entries.SubName += ".scs" |
Jiyong Park | 1d1119f | 2019-07-29 21:27:18 +0900 | [diff] [blame] | 951 | } |
Peter Collingbourne | 8c7e6e2 | 2018-11-19 16:03:58 -0800 | [diff] [blame] | 952 | } |
Colin Cross | 8ff9ef4 | 2017-05-08 13:44:11 -0700 | [diff] [blame] | 953 | } |
| 954 | |
Liz Kammer | 2c1d6aa | 2022-10-03 15:07:37 -0400 | [diff] [blame] | 955 | func (s *sanitize) inSanitizerDir() bool { |
| 956 | return s.Properties.InSanitizerDir |
Colin Cross | 30d5f51 | 2016-05-03 18:02:42 -0700 | [diff] [blame] | 957 | } |
| 958 | |
Ivan Lozano | 3968d8f | 2020-12-14 11:27:52 -0500 | [diff] [blame] | 959 | // getSanitizerBoolPtr returns the SanitizerTypes associated bool pointer from SanitizeProperties. |
Liz Kammer | 2c1d6aa | 2022-10-03 15:07:37 -0400 | [diff] [blame] | 960 | func (s *sanitize) getSanitizerBoolPtr(t SanitizerType) *bool { |
Vishwath Mohan | 9522930 | 2017-08-11 00:53:16 +0000 | [diff] [blame] | 961 | switch t { |
Ivan Lozano | 3968d8f | 2020-12-14 11:27:52 -0500 | [diff] [blame] | 962 | case Asan: |
Liz Kammer | 2c1d6aa | 2022-10-03 15:07:37 -0400 | [diff] [blame] | 963 | return s.Properties.SanitizeMutated.Address |
Tri Vo | 6eafc36 | 2021-04-01 11:29:09 -0700 | [diff] [blame] | 964 | case Hwasan: |
Liz Kammer | 2c1d6aa | 2022-10-03 15:07:37 -0400 | [diff] [blame] | 965 | return s.Properties.SanitizeMutated.Hwaddress |
Vishwath Mohan | 9522930 | 2017-08-11 00:53:16 +0000 | [diff] [blame] | 966 | case tsan: |
Liz Kammer | 2c1d6aa | 2022-10-03 15:07:37 -0400 | [diff] [blame] | 967 | return s.Properties.SanitizeMutated.Thread |
Vishwath Mohan | 9522930 | 2017-08-11 00:53:16 +0000 | [diff] [blame] | 968 | case intOverflow: |
Liz Kammer | 2c1d6aa | 2022-10-03 15:07:37 -0400 | [diff] [blame] | 969 | return s.Properties.SanitizeMutated.Integer_overflow |
Vishwath Mohan | b743e9c | 2017-11-01 09:20:21 +0000 | [diff] [blame] | 970 | case cfi: |
Liz Kammer | 2c1d6aa | 2022-10-03 15:07:37 -0400 | [diff] [blame] | 971 | return s.Properties.SanitizeMutated.Cfi |
Peter Collingbourne | 8c7e6e2 | 2018-11-19 16:03:58 -0800 | [diff] [blame] | 972 | case scs: |
Liz Kammer | 2c1d6aa | 2022-10-03 15:07:37 -0400 | [diff] [blame] | 973 | return s.Properties.SanitizeMutated.Scs |
Ivan Lozano | 62cd038 | 2021-11-01 10:27:54 -0400 | [diff] [blame] | 974 | case Memtag_heap: |
Liz Kammer | 2c1d6aa | 2022-10-03 15:07:37 -0400 | [diff] [blame] | 975 | return s.Properties.SanitizeMutated.Memtag_heap |
Florian Mayer | d8434a4 | 2022-08-31 20:57:03 +0000 | [diff] [blame] | 976 | case Memtag_stack: |
Liz Kammer | 2c1d6aa | 2022-10-03 15:07:37 -0400 | [diff] [blame] | 977 | return s.Properties.SanitizeMutated.Memtag_stack |
Ivan Lozano | 3968d8f | 2020-12-14 11:27:52 -0500 | [diff] [blame] | 978 | case Fuzzer: |
Liz Kammer | 2c1d6aa | 2022-10-03 15:07:37 -0400 | [diff] [blame] | 979 | return s.Properties.SanitizeMutated.Fuzzer |
Vishwath Mohan | 9522930 | 2017-08-11 00:53:16 +0000 | [diff] [blame] | 980 | default: |
Ivan Lozano | 3968d8f | 2020-12-14 11:27:52 -0500 | [diff] [blame] | 981 | panic(fmt.Errorf("unknown SanitizerType %d", t)) |
Vishwath Mohan | 9522930 | 2017-08-11 00:53:16 +0000 | [diff] [blame] | 982 | } |
| 983 | } |
| 984 | |
Ivan Lozano | 3968d8f | 2020-12-14 11:27:52 -0500 | [diff] [blame] | 985 | // isUnsanitizedVariant returns true if no sanitizers are enabled. |
Dan Albert | 7d1eecf | 2018-01-19 12:30:45 -0800 | [diff] [blame] | 986 | func (sanitize *sanitize) isUnsanitizedVariant() bool { |
Ivan Lozano | 3968d8f | 2020-12-14 11:27:52 -0500 | [diff] [blame] | 987 | return !sanitize.isSanitizerEnabled(Asan) && |
Tri Vo | 6eafc36 | 2021-04-01 11:29:09 -0700 | [diff] [blame] | 988 | !sanitize.isSanitizerEnabled(Hwasan) && |
Dan Albert | 7d1eecf | 2018-01-19 12:30:45 -0800 | [diff] [blame] | 989 | !sanitize.isSanitizerEnabled(tsan) && |
Peter Collingbourne | 8c7e6e2 | 2018-11-19 16:03:58 -0800 | [diff] [blame] | 990 | !sanitize.isSanitizerEnabled(cfi) && |
Mitch Phillips | 5a6ea6c | 2019-05-01 14:42:05 -0700 | [diff] [blame] | 991 | !sanitize.isSanitizerEnabled(scs) && |
Ivan Lozano | 62cd038 | 2021-11-01 10:27:54 -0400 | [diff] [blame] | 992 | !sanitize.isSanitizerEnabled(Memtag_heap) && |
Florian Mayer | d8434a4 | 2022-08-31 20:57:03 +0000 | [diff] [blame] | 993 | !sanitize.isSanitizerEnabled(Memtag_stack) && |
Ivan Lozano | 3968d8f | 2020-12-14 11:27:52 -0500 | [diff] [blame] | 994 | !sanitize.isSanitizerEnabled(Fuzzer) |
Dan Albert | 7d1eecf | 2018-01-19 12:30:45 -0800 | [diff] [blame] | 995 | } |
| 996 | |
Ivan Lozano | 3968d8f | 2020-12-14 11:27:52 -0500 | [diff] [blame] | 997 | // isVariantOnProductionDevice returns true if variant is for production devices (no non-production sanitizers enabled). |
Jayant Chowdhary | b7e08ca | 2018-05-10 15:29:24 -0700 | [diff] [blame] | 998 | func (sanitize *sanitize) isVariantOnProductionDevice() bool { |
Ivan Lozano | 3968d8f | 2020-12-14 11:27:52 -0500 | [diff] [blame] | 999 | return !sanitize.isSanitizerEnabled(Asan) && |
Tri Vo | 6eafc36 | 2021-04-01 11:29:09 -0700 | [diff] [blame] | 1000 | !sanitize.isSanitizerEnabled(Hwasan) && |
Mitch Phillips | 5a6ea6c | 2019-05-01 14:42:05 -0700 | [diff] [blame] | 1001 | !sanitize.isSanitizerEnabled(tsan) && |
Ivan Lozano | 3968d8f | 2020-12-14 11:27:52 -0500 | [diff] [blame] | 1002 | !sanitize.isSanitizerEnabled(Fuzzer) |
Jayant Chowdhary | b7e08ca | 2018-05-10 15:29:24 -0700 | [diff] [blame] | 1003 | } |
| 1004 | |
Ivan Lozano | 3968d8f | 2020-12-14 11:27:52 -0500 | [diff] [blame] | 1005 | func (sanitize *sanitize) SetSanitizer(t SanitizerType, b bool) { |
Liz Kammer | b2fc470 | 2021-06-25 14:53:40 -0400 | [diff] [blame] | 1006 | bPtr := proptools.BoolPtr(b) |
| 1007 | if !b { |
| 1008 | bPtr = nil |
| 1009 | } |
Colin Cross | 16b2349 | 2016-01-06 14:41:07 -0800 | [diff] [blame] | 1010 | switch t { |
Ivan Lozano | 3968d8f | 2020-12-14 11:27:52 -0500 | [diff] [blame] | 1011 | case Asan: |
Liz Kammer | 2c1d6aa | 2022-10-03 15:07:37 -0400 | [diff] [blame] | 1012 | sanitize.Properties.SanitizeMutated.Address = bPtr |
Florian Mayer | 1bda246 | 2022-09-29 15:48:08 -0700 | [diff] [blame] | 1013 | // For ASAN variant, we need to disable Memtag_stack |
Liz Kammer | 2c1d6aa | 2022-10-03 15:07:37 -0400 | [diff] [blame] | 1014 | sanitize.Properties.SanitizeMutated.Memtag_stack = nil |
Tri Vo | 6eafc36 | 2021-04-01 11:29:09 -0700 | [diff] [blame] | 1015 | case Hwasan: |
Liz Kammer | 2c1d6aa | 2022-10-03 15:07:37 -0400 | [diff] [blame] | 1016 | sanitize.Properties.SanitizeMutated.Hwaddress = bPtr |
Florian Mayer | 1bda246 | 2022-09-29 15:48:08 -0700 | [diff] [blame] | 1017 | // For HWAsan variant, we need to disable Memtag_stack |
Liz Kammer | 2c1d6aa | 2022-10-03 15:07:37 -0400 | [diff] [blame] | 1018 | sanitize.Properties.SanitizeMutated.Memtag_stack = nil |
Colin Cross | 16b2349 | 2016-01-06 14:41:07 -0800 | [diff] [blame] | 1019 | case tsan: |
Liz Kammer | 2c1d6aa | 2022-10-03 15:07:37 -0400 | [diff] [blame] | 1020 | sanitize.Properties.SanitizeMutated.Thread = bPtr |
Ivan Lozano | 0c3a1ef | 2017-06-28 09:10:48 -0700 | [diff] [blame] | 1021 | case intOverflow: |
Liz Kammer | 2c1d6aa | 2022-10-03 15:07:37 -0400 | [diff] [blame] | 1022 | sanitize.Properties.SanitizeMutated.Integer_overflow = bPtr |
Vishwath Mohan | b743e9c | 2017-11-01 09:20:21 +0000 | [diff] [blame] | 1023 | case cfi: |
Liz Kammer | 2c1d6aa | 2022-10-03 15:07:37 -0400 | [diff] [blame] | 1024 | sanitize.Properties.SanitizeMutated.Cfi = bPtr |
Peter Collingbourne | 8c7e6e2 | 2018-11-19 16:03:58 -0800 | [diff] [blame] | 1025 | case scs: |
Liz Kammer | 2c1d6aa | 2022-10-03 15:07:37 -0400 | [diff] [blame] | 1026 | sanitize.Properties.SanitizeMutated.Scs = bPtr |
Ivan Lozano | 62cd038 | 2021-11-01 10:27:54 -0400 | [diff] [blame] | 1027 | case Memtag_heap: |
Liz Kammer | 2c1d6aa | 2022-10-03 15:07:37 -0400 | [diff] [blame] | 1028 | sanitize.Properties.SanitizeMutated.Memtag_heap = bPtr |
Florian Mayer | d8434a4 | 2022-08-31 20:57:03 +0000 | [diff] [blame] | 1029 | case Memtag_stack: |
Liz Kammer | 2c1d6aa | 2022-10-03 15:07:37 -0400 | [diff] [blame] | 1030 | sanitize.Properties.SanitizeMutated.Memtag_stack = bPtr |
Florian Mayer | 1bda246 | 2022-09-29 15:48:08 -0700 | [diff] [blame] | 1031 | // We do not need to disable ASAN or HWASan here, as there is no Memtag_stack variant. |
Ivan Lozano | 3968d8f | 2020-12-14 11:27:52 -0500 | [diff] [blame] | 1032 | case Fuzzer: |
Liz Kammer | 2c1d6aa | 2022-10-03 15:07:37 -0400 | [diff] [blame] | 1033 | sanitize.Properties.SanitizeMutated.Fuzzer = bPtr |
Colin Cross | 16b2349 | 2016-01-06 14:41:07 -0800 | [diff] [blame] | 1034 | default: |
Ivan Lozano | 3968d8f | 2020-12-14 11:27:52 -0500 | [diff] [blame] | 1035 | panic(fmt.Errorf("unknown SanitizerType %d", t)) |
Colin Cross | 16b2349 | 2016-01-06 14:41:07 -0800 | [diff] [blame] | 1036 | } |
| 1037 | if b { |
| 1038 | sanitize.Properties.SanitizerEnabled = true |
| 1039 | } |
| 1040 | } |
| 1041 | |
Vishwath Mohan | b743e9c | 2017-11-01 09:20:21 +0000 | [diff] [blame] | 1042 | // Check if the sanitizer is explicitly disabled (as opposed to nil by |
| 1043 | // virtue of not being set). |
Ivan Lozano | 3968d8f | 2020-12-14 11:27:52 -0500 | [diff] [blame] | 1044 | func (sanitize *sanitize) isSanitizerExplicitlyDisabled(t SanitizerType) bool { |
Vishwath Mohan | b743e9c | 2017-11-01 09:20:21 +0000 | [diff] [blame] | 1045 | if sanitize == nil { |
| 1046 | return false |
| 1047 | } |
| 1048 | |
| 1049 | sanitizerVal := sanitize.getSanitizerBoolPtr(t) |
| 1050 | return sanitizerVal != nil && *sanitizerVal == false |
| 1051 | } |
| 1052 | |
| 1053 | // There isn't an analog of the method above (ie:isSanitizerExplicitlyEnabled) |
| 1054 | // because enabling a sanitizer either directly (via the blueprint) or |
| 1055 | // indirectly (via a mutator) sets the bool ptr to true, and you can't |
| 1056 | // distinguish between the cases. It isn't needed though - both cases can be |
| 1057 | // treated identically. |
Ivan Lozano | 3968d8f | 2020-12-14 11:27:52 -0500 | [diff] [blame] | 1058 | func (sanitize *sanitize) isSanitizerEnabled(t SanitizerType) bool { |
Vishwath Mohan | b743e9c | 2017-11-01 09:20:21 +0000 | [diff] [blame] | 1059 | if sanitize == nil { |
| 1060 | return false |
| 1061 | } |
| 1062 | |
| 1063 | sanitizerVal := sanitize.getSanitizerBoolPtr(t) |
| 1064 | return sanitizerVal != nil && *sanitizerVal == true |
| 1065 | } |
| 1066 | |
Ivan Lozano | 3968d8f | 2020-12-14 11:27:52 -0500 | [diff] [blame] | 1067 | // IsSanitizableDependencyTag returns true if the dependency tag is sanitizable. |
| 1068 | func IsSanitizableDependencyTag(tag blueprint.DependencyTag) bool { |
Colin Cross | 6e511a9 | 2020-07-27 21:26:48 -0700 | [diff] [blame] | 1069 | switch t := tag.(type) { |
| 1070 | case dependencyTag: |
| 1071 | return t == reuseObjTag || t == objDepTag |
| 1072 | case libraryDependencyTag: |
| 1073 | return true |
| 1074 | default: |
| 1075 | return false |
| 1076 | } |
Colin Cross | 6b75360 | 2018-06-21 13:03:07 -0700 | [diff] [blame] | 1077 | } |
| 1078 | |
Ivan Lozano | 3968d8f | 2020-12-14 11:27:52 -0500 | [diff] [blame] | 1079 | func (m *Module) SanitizableDepTagChecker() SantizableDependencyTagChecker { |
| 1080 | return IsSanitizableDependencyTag |
| 1081 | } |
| 1082 | |
Inseob Kim | c42f2f2 | 2020-07-29 20:32:10 +0900 | [diff] [blame] | 1083 | // Determines if the current module is a static library going to be captured |
| 1084 | // as vendor snapshot. Such modules must create both cfi and non-cfi variants, |
| 1085 | // except for ones which explicitly disable cfi. |
Lukacs T. Berki | 6c71676 | 2022-06-13 20:50:39 +0200 | [diff] [blame] | 1086 | func needsCfiForVendorSnapshot(mctx android.BaseModuleContext) bool { |
Justin Yun | 8814fc5 | 2022-12-15 21:45:35 +0900 | [diff] [blame] | 1087 | if inList("hwaddress", mctx.Config().SanitizeDevice()) { |
| 1088 | // cfi will not be built if SANITIZE_TARGET=hwaddress is set |
| 1089 | return false |
| 1090 | } |
| 1091 | |
Kiyoung Kim | 48f3778 | 2021-07-07 12:42:39 +0900 | [diff] [blame] | 1092 | if snapshot.IsVendorProprietaryModule(mctx) { |
Inseob Kim | c42f2f2 | 2020-07-29 20:32:10 +0900 | [diff] [blame] | 1093 | return false |
| 1094 | } |
| 1095 | |
Ivan Lozano | 3968d8f | 2020-12-14 11:27:52 -0500 | [diff] [blame] | 1096 | c := mctx.Module().(PlatformSanitizeable) |
Inseob Kim | c42f2f2 | 2020-07-29 20:32:10 +0900 | [diff] [blame] | 1097 | |
Ivan Lozano | 3968d8f | 2020-12-14 11:27:52 -0500 | [diff] [blame] | 1098 | if !c.InVendor() { |
Inseob Kim | c42f2f2 | 2020-07-29 20:32:10 +0900 | [diff] [blame] | 1099 | return false |
| 1100 | } |
| 1101 | |
Ivan Lozano | 3968d8f | 2020-12-14 11:27:52 -0500 | [diff] [blame] | 1102 | if !c.StaticallyLinked() { |
Inseob Kim | c42f2f2 | 2020-07-29 20:32:10 +0900 | [diff] [blame] | 1103 | return false |
| 1104 | } |
| 1105 | |
Ivan Lozano | 3968d8f | 2020-12-14 11:27:52 -0500 | [diff] [blame] | 1106 | if c.IsPrebuilt() { |
Inseob Kim | c42f2f2 | 2020-07-29 20:32:10 +0900 | [diff] [blame] | 1107 | return false |
| 1108 | } |
| 1109 | |
Ivan Lozano | 3968d8f | 2020-12-14 11:27:52 -0500 | [diff] [blame] | 1110 | if !c.SanitizerSupported(cfi) { |
| 1111 | return false |
| 1112 | } |
| 1113 | |
| 1114 | return c.SanitizePropDefined() && |
| 1115 | !c.SanitizeNever() && |
| 1116 | !c.IsSanitizerExplicitlyDisabled(cfi) |
Inseob Kim | c42f2f2 | 2020-07-29 20:32:10 +0900 | [diff] [blame] | 1117 | } |
| 1118 | |
Lukacs T. Berki | 6c71676 | 2022-06-13 20:50:39 +0200 | [diff] [blame] | 1119 | type sanitizerSplitMutator struct { |
| 1120 | sanitizer SanitizerType |
| 1121 | } |
| 1122 | |
| 1123 | // If an APEX is sanitized or not depends on whether it contains at least one |
| 1124 | // sanitized module. Transition mutators cannot propagate information up the |
| 1125 | // dependency graph this way, so we need an auxiliary mutator to do so. |
| 1126 | func (s *sanitizerSplitMutator) markSanitizableApexesMutator(ctx android.TopDownMutatorContext) { |
| 1127 | if sanitizeable, ok := ctx.Module().(Sanitizeable); ok { |
| 1128 | enabled := sanitizeable.IsSanitizerEnabled(ctx.Config(), s.sanitizer.name()) |
| 1129 | ctx.VisitDirectDeps(func(dep android.Module) { |
| 1130 | if c, ok := dep.(*Module); ok && c.sanitize.isSanitizerEnabled(s.sanitizer) { |
Inseob Kim | c42f2f2 | 2020-07-29 20:32:10 +0900 | [diff] [blame] | 1131 | enabled = true |
Inseob Kim | c42f2f2 | 2020-07-29 20:32:10 +0900 | [diff] [blame] | 1132 | } |
Lukacs T. Berki | 6c71676 | 2022-06-13 20:50:39 +0200 | [diff] [blame] | 1133 | }) |
| 1134 | |
| 1135 | if enabled { |
| 1136 | sanitizeable.EnableSanitizer(s.sanitizer.name()) |
| 1137 | } |
| 1138 | } |
| 1139 | } |
| 1140 | |
| 1141 | func (s *sanitizerSplitMutator) Split(ctx android.BaseModuleContext) []string { |
| 1142 | if c, ok := ctx.Module().(PlatformSanitizeable); ok && c.SanitizePropDefined() { |
| 1143 | if s.sanitizer == cfi && needsCfiForVendorSnapshot(ctx) { |
| 1144 | return []string{"", s.sanitizer.variationName()} |
| 1145 | } |
| 1146 | |
| 1147 | // If the given sanitizer is not requested in the .bp file for a module, it |
| 1148 | // won't automatically build the sanitized variation. |
| 1149 | if !c.IsSanitizerEnabled(s.sanitizer) { |
| 1150 | return []string{""} |
| 1151 | } |
| 1152 | |
| 1153 | if c.Binary() { |
| 1154 | // If a sanitizer is enabled for a binary, we do not build the version |
| 1155 | // without the sanitizer |
| 1156 | return []string{s.sanitizer.variationName()} |
| 1157 | } else if c.StaticallyLinked() || c.Header() { |
| 1158 | // For static libraries, we build both versions. Some Make modules |
| 1159 | // apparently depend on this behavior. |
| 1160 | return []string{"", s.sanitizer.variationName()} |
| 1161 | } else { |
| 1162 | // We only build the requested variation of dynamic libraries |
| 1163 | return []string{s.sanitizer.variationName()} |
| 1164 | } |
| 1165 | } |
| 1166 | |
| 1167 | if _, ok := ctx.Module().(JniSanitizeable); ok { |
| 1168 | // TODO: this should call into JniSanitizable.IsSanitizerEnabledForJni but |
| 1169 | // that is short-circuited for now |
| 1170 | return []string{""} |
| 1171 | } |
| 1172 | |
| 1173 | // If an APEX has a sanitized dependency, we build the APEX in the sanitized |
| 1174 | // variation. This is useful because such APEXes require extra dependencies. |
| 1175 | if sanitizeable, ok := ctx.Module().(Sanitizeable); ok { |
| 1176 | enabled := sanitizeable.IsSanitizerEnabled(ctx.Config(), s.sanitizer.name()) |
| 1177 | if enabled { |
| 1178 | return []string{s.sanitizer.variationName()} |
| 1179 | } else { |
| 1180 | return []string{""} |
| 1181 | } |
| 1182 | } |
| 1183 | |
| 1184 | if c, ok := ctx.Module().(*Module); ok { |
| 1185 | //TODO: When Rust modules have vendor support, enable this path for PlatformSanitizeable |
| 1186 | |
| 1187 | // Check if it's a snapshot module supporting sanitizer |
Justin Yun | 08270c6 | 2022-12-19 17:01:26 +0900 | [diff] [blame] | 1188 | if ss, ok := c.linker.(snapshotSanitizer); ok { |
| 1189 | if ss.isSanitizerAvailable(s.sanitizer) { |
| 1190 | return []string{"", s.sanitizer.variationName()} |
| 1191 | } else { |
| 1192 | return []string{""} |
| 1193 | } |
Lukacs T. Berki | 6c71676 | 2022-06-13 20:50:39 +0200 | [diff] [blame] | 1194 | } |
| 1195 | } |
| 1196 | |
| 1197 | return []string{""} |
| 1198 | } |
| 1199 | |
| 1200 | func (s *sanitizerSplitMutator) OutgoingTransition(ctx android.OutgoingTransitionContext, sourceVariation string) string { |
| 1201 | if c, ok := ctx.Module().(PlatformSanitizeable); ok { |
| 1202 | if !c.SanitizableDepTagChecker()(ctx.DepTag()) { |
| 1203 | // If the dependency is through a non-sanitizable tag, use the |
| 1204 | // non-sanitized variation |
| 1205 | return "" |
| 1206 | } |
| 1207 | |
| 1208 | return sourceVariation |
| 1209 | } else if _, ok := ctx.Module().(JniSanitizeable); ok { |
| 1210 | // TODO: this should call into JniSanitizable.IsSanitizerEnabledForJni but |
| 1211 | // that is short-circuited for now |
| 1212 | return "" |
| 1213 | } else { |
| 1214 | // Otherwise, do not rock the boat. |
| 1215 | return sourceVariation |
| 1216 | } |
| 1217 | } |
| 1218 | |
| 1219 | func (s *sanitizerSplitMutator) IncomingTransition(ctx android.IncomingTransitionContext, incomingVariation string) string { |
| 1220 | if d, ok := ctx.Module().(PlatformSanitizeable); ok { |
| 1221 | if dm, ok := ctx.Module().(*Module); ok { |
Justin Yun | 39c3031 | 2022-11-23 16:20:12 +0900 | [diff] [blame] | 1222 | if ss, ok := dm.linker.(snapshotSanitizer); ok && ss.isSanitizerAvailable(s.sanitizer) { |
Lukacs T. Berki | 6c71676 | 2022-06-13 20:50:39 +0200 | [diff] [blame] | 1223 | return incomingVariation |
Inseob Kim | c42f2f2 | 2020-07-29 20:32:10 +0900 | [diff] [blame] | 1224 | } |
Lukacs T. Berki | 6c71676 | 2022-06-13 20:50:39 +0200 | [diff] [blame] | 1225 | } |
| 1226 | |
| 1227 | if !d.SanitizePropDefined() || |
| 1228 | d.SanitizeNever() || |
| 1229 | d.IsSanitizerExplicitlyDisabled(s.sanitizer) || |
| 1230 | !d.SanitizerSupported(s.sanitizer) { |
| 1231 | // If a module opts out of a sanitizer, use its non-sanitized variation |
| 1232 | return "" |
| 1233 | } |
| 1234 | |
| 1235 | // Binaries are always built in the variation they requested. |
| 1236 | if d.Binary() { |
| 1237 | if d.IsSanitizerEnabled(s.sanitizer) { |
| 1238 | return s.sanitizer.variationName() |
| 1239 | } else { |
| 1240 | return "" |
Muhammad Haseeb Ahmad | 7e74405 | 2022-03-25 22:50:53 +0000 | [diff] [blame] | 1241 | } |
Lukacs T. Berki | 6c71676 | 2022-06-13 20:50:39 +0200 | [diff] [blame] | 1242 | } |
| 1243 | |
| 1244 | // If a shared library requests to be sanitized, it will be built for that |
| 1245 | // sanitizer. Otherwise, some sanitizers propagate through shared library |
| 1246 | // dependency edges, some do not. |
| 1247 | if !d.StaticallyLinked() && !d.Header() { |
| 1248 | if d.IsSanitizerEnabled(s.sanitizer) { |
| 1249 | return s.sanitizer.variationName() |
| 1250 | } |
| 1251 | |
Liz Kammer | fd8a49f | 2022-10-31 10:31:11 -0400 | [diff] [blame] | 1252 | // Some sanitizers do not propagate to shared dependencies |
| 1253 | if !s.sanitizer.shouldPropagateToSharedLibraryDeps() { |
Lukacs T. Berki | 6c71676 | 2022-06-13 20:50:39 +0200 | [diff] [blame] | 1254 | return "" |
| 1255 | } |
| 1256 | } |
| 1257 | |
| 1258 | // Static and header libraries inherit whether they are sanitized from the |
| 1259 | // module they are linked into |
| 1260 | return incomingVariation |
| 1261 | } else if d, ok := ctx.Module().(Sanitizeable); ok { |
| 1262 | // If an APEX contains a sanitized module, it will be built in the variation |
| 1263 | // corresponding to that sanitizer. |
| 1264 | enabled := d.IsSanitizerEnabled(ctx.Config(), s.sanitizer.name()) |
| 1265 | if enabled { |
| 1266 | return s.sanitizer.variationName() |
| 1267 | } |
| 1268 | |
| 1269 | return incomingVariation |
| 1270 | } |
| 1271 | |
| 1272 | return "" |
| 1273 | } |
| 1274 | |
| 1275 | func (s *sanitizerSplitMutator) Mutate(mctx android.BottomUpMutatorContext, variationName string) { |
| 1276 | sanitizerVariation := variationName == s.sanitizer.variationName() |
| 1277 | |
| 1278 | if c, ok := mctx.Module().(PlatformSanitizeable); ok && c.SanitizePropDefined() { |
| 1279 | sanitizerEnabled := c.IsSanitizerEnabled(s.sanitizer) |
| 1280 | |
| 1281 | oneMakeVariation := false |
| 1282 | if c.StaticallyLinked() || c.Header() { |
| 1283 | if s.sanitizer != cfi && s.sanitizer != scs && s.sanitizer != Hwasan { |
| 1284 | // These sanitizers export only one variation to Make. For the rest, |
| 1285 | // Make targets can depend on both the sanitized and non-sanitized |
| 1286 | // versions. |
| 1287 | oneMakeVariation = true |
| 1288 | } |
| 1289 | } else if !c.Binary() { |
| 1290 | // Shared library. These are the sanitizers that do propagate through shared |
| 1291 | // library dependencies and therefore can cause multiple variations of a |
| 1292 | // shared library to be built. |
| 1293 | if s.sanitizer != cfi && s.sanitizer != Hwasan && s.sanitizer != scs && s.sanitizer != Asan { |
| 1294 | oneMakeVariation = true |
| 1295 | } |
| 1296 | } |
| 1297 | |
| 1298 | if oneMakeVariation { |
| 1299 | if sanitizerEnabled != sanitizerVariation { |
| 1300 | c.SetPreventInstall() |
| 1301 | c.SetHideFromMake() |
| 1302 | } |
| 1303 | } |
| 1304 | |
| 1305 | if sanitizerVariation { |
| 1306 | c.SetSanitizer(s.sanitizer, true) |
| 1307 | |
| 1308 | // CFI is incompatible with ASAN so disable it in ASAN variations |
| 1309 | if s.sanitizer.incompatibleWithCfi() { |
| 1310 | cfiSupported := mctx.Module().(PlatformSanitizeable).SanitizerSupported(cfi) |
| 1311 | if mctx.Device() && cfiSupported { |
| 1312 | c.SetSanitizer(cfi, false) |
Jiyong Park | f97782b | 2019-02-13 20:28:58 +0900 | [diff] [blame] | 1313 | } |
Lukacs T. Berki | 6c71676 | 2022-06-13 20:50:39 +0200 | [diff] [blame] | 1314 | } |
| 1315 | |
| 1316 | // locate the asan libraries under /data/asan |
| 1317 | if !c.Binary() && !c.StaticallyLinked() && !c.Header() && mctx.Device() && s.sanitizer == Asan && sanitizerEnabled { |
| 1318 | c.SetInSanitizerDir() |
| 1319 | } |
| 1320 | |
| 1321 | if c.StaticallyLinked() && c.ExportedToMake() { |
| 1322 | if s.sanitizer == Hwasan { |
| 1323 | hwasanStaticLibs(mctx.Config()).add(c, c.Module().Name()) |
| 1324 | } else if s.sanitizer == cfi { |
| 1325 | cfiStaticLibs(mctx.Config()).add(c, c.Module().Name()) |
| 1326 | } |
| 1327 | } |
| 1328 | } else if c.IsSanitizerEnabled(s.sanitizer) { |
| 1329 | // Disable the sanitizer for the non-sanitized variation |
| 1330 | c.SetSanitizer(s.sanitizer, false) |
| 1331 | } |
| 1332 | } else if sanitizeable, ok := mctx.Module().(Sanitizeable); ok { |
| 1333 | // If an APEX has sanitized dependencies, it gets a few more dependencies |
| 1334 | if sanitizerVariation { |
| 1335 | sanitizeable.AddSanitizerDependencies(mctx, s.sanitizer.name()) |
| 1336 | } |
| 1337 | } else if c, ok := mctx.Module().(*Module); ok { |
Justin Yun | 39c3031 | 2022-11-23 16:20:12 +0900 | [diff] [blame] | 1338 | if ss, ok := c.linker.(snapshotSanitizer); ok && ss.isSanitizerAvailable(s.sanitizer) { |
| 1339 | if !ss.isUnsanitizedVariant() { |
| 1340 | // Snapshot sanitizer may have only one variantion. |
| 1341 | // Skip exporting the module if it already has a sanitizer variation. |
| 1342 | c.SetPreventInstall() |
| 1343 | c.SetHideFromMake() |
| 1344 | return |
| 1345 | } |
Lukacs T. Berki | 6c71676 | 2022-06-13 20:50:39 +0200 | [diff] [blame] | 1346 | c.linker.(snapshotSanitizer).setSanitizerVariation(s.sanitizer, sanitizerVariation) |
| 1347 | |
| 1348 | // Export the static lib name to make |
| 1349 | if c.static() && c.ExportedToMake() { |
Justin Yun | 39c3031 | 2022-11-23 16:20:12 +0900 | [diff] [blame] | 1350 | // use BaseModuleName which is the name for Make. |
Lukacs T. Berki | 6c71676 | 2022-06-13 20:50:39 +0200 | [diff] [blame] | 1351 | if s.sanitizer == cfi { |
Lukacs T. Berki | 6c71676 | 2022-06-13 20:50:39 +0200 | [diff] [blame] | 1352 | cfiStaticLibs(mctx.Config()).add(c, c.BaseModuleName()) |
Justin Yun | 39c3031 | 2022-11-23 16:20:12 +0900 | [diff] [blame] | 1353 | } else if s.sanitizer == Hwasan { |
| 1354 | hwasanStaticLibs(mctx.Config()).add(c, c.BaseModuleName()) |
Lukacs T. Berki | 6c71676 | 2022-06-13 20:50:39 +0200 | [diff] [blame] | 1355 | } |
| 1356 | } |
Colin Cross | 16b2349 | 2016-01-06 14:41:07 -0800 | [diff] [blame] | 1357 | } |
| 1358 | } |
| 1359 | } |
| 1360 | |
Ivan Lozano | 3968d8f | 2020-12-14 11:27:52 -0500 | [diff] [blame] | 1361 | func (c *Module) SanitizeNever() bool { |
Liz Kammer | 2c1d6aa | 2022-10-03 15:07:37 -0400 | [diff] [blame] | 1362 | return Bool(c.sanitize.Properties.SanitizeMutated.Never) |
Ivan Lozano | 3968d8f | 2020-12-14 11:27:52 -0500 | [diff] [blame] | 1363 | } |
| 1364 | |
| 1365 | func (c *Module) IsSanitizerExplicitlyDisabled(t SanitizerType) bool { |
| 1366 | return c.sanitize.isSanitizerExplicitlyDisabled(t) |
| 1367 | } |
| 1368 | |
Ivan Lozano | 30c5db2 | 2018-02-21 15:49:20 -0800 | [diff] [blame] | 1369 | // Propagate the ubsan minimal runtime dependency when there are integer overflow sanitized static dependencies. |
Colin Cross | 6b75360 | 2018-06-21 13:03:07 -0700 | [diff] [blame] | 1370 | func sanitizerRuntimeDepsMutator(mctx android.TopDownMutatorContext) { |
Ivan Lozano | 3968d8f | 2020-12-14 11:27:52 -0500 | [diff] [blame] | 1371 | // Change this to PlatformSanitizable when/if non-cc modules support ubsan sanitizers. |
Colin Cross | 6b75360 | 2018-06-21 13:03:07 -0700 | [diff] [blame] | 1372 | if c, ok := mctx.Module().(*Module); ok && c.sanitize != nil { |
Ivan Lozano | 3968d8f | 2020-12-14 11:27:52 -0500 | [diff] [blame] | 1373 | isSanitizableDependencyTag := c.SanitizableDepTagChecker() |
Colin Cross | 6b75360 | 2018-06-21 13:03:07 -0700 | [diff] [blame] | 1374 | mctx.WalkDeps(func(child, parent android.Module) bool { |
| 1375 | if !isSanitizableDependencyTag(mctx.OtherModuleDependencyTag(child)) { |
| 1376 | return false |
| 1377 | } |
Ivan Lozano | 30c5db2 | 2018-02-21 15:49:20 -0800 | [diff] [blame] | 1378 | |
Inseob Kim | eec88e1 | 2020-01-22 11:11:29 +0900 | [diff] [blame] | 1379 | d, ok := child.(*Module) |
| 1380 | if !ok || !d.static() { |
| 1381 | return false |
| 1382 | } |
| 1383 | if d.sanitize != nil { |
Colin Cross | 6b75360 | 2018-06-21 13:03:07 -0700 | [diff] [blame] | 1384 | if enableMinimalRuntime(d.sanitize) { |
| 1385 | // If a static dependency is built with the minimal runtime, |
| 1386 | // make sure we include the ubsan minimal runtime. |
| 1387 | c.sanitize.Properties.MinimalRuntimeDep = true |
Inseob Kim | 8471cda | 2019-11-15 09:59:12 +0900 | [diff] [blame] | 1388 | } else if enableUbsanRuntime(d.sanitize) { |
Colin Cross | 6b75360 | 2018-06-21 13:03:07 -0700 | [diff] [blame] | 1389 | // If a static dependency runs with full ubsan diagnostics, |
| 1390 | // make sure we include the ubsan runtime. |
| 1391 | c.sanitize.Properties.UbsanRuntimeDep = true |
Ivan Lozano | 30c5db2 | 2018-02-21 15:49:20 -0800 | [diff] [blame] | 1392 | } |
Colin Cross | 0b90833 | 2019-06-19 23:00:20 -0700 | [diff] [blame] | 1393 | |
| 1394 | if c.sanitize.Properties.MinimalRuntimeDep && |
| 1395 | c.sanitize.Properties.UbsanRuntimeDep { |
| 1396 | // both flags that this mutator might set are true, so don't bother recursing |
| 1397 | return false |
| 1398 | } |
| 1399 | |
Ivan Lozano | 9ac32c7 | 2020-02-19 15:24:02 -0500 | [diff] [blame] | 1400 | if c.Os() == android.Linux { |
| 1401 | c.sanitize.Properties.BuiltinsDep = true |
| 1402 | } |
| 1403 | |
Colin Cross | 0b90833 | 2019-06-19 23:00:20 -0700 | [diff] [blame] | 1404 | return true |
Colin Cross | 6b75360 | 2018-06-21 13:03:07 -0700 | [diff] [blame] | 1405 | } |
Inseob Kim | eec88e1 | 2020-01-22 11:11:29 +0900 | [diff] [blame] | 1406 | |
Jose Galmes | f729458 | 2020-11-13 12:07:36 -0800 | [diff] [blame] | 1407 | if p, ok := d.linker.(*snapshotLibraryDecorator); ok { |
Inseob Kim | eec88e1 | 2020-01-22 11:11:29 +0900 | [diff] [blame] | 1408 | if Bool(p.properties.Sanitize_minimal_dep) { |
| 1409 | c.sanitize.Properties.MinimalRuntimeDep = true |
| 1410 | } |
| 1411 | if Bool(p.properties.Sanitize_ubsan_dep) { |
| 1412 | c.sanitize.Properties.UbsanRuntimeDep = true |
| 1413 | } |
| 1414 | } |
| 1415 | |
| 1416 | return false |
Colin Cross | 6b75360 | 2018-06-21 13:03:07 -0700 | [diff] [blame] | 1417 | }) |
Ivan Lozano | 30c5db2 | 2018-02-21 15:49:20 -0800 | [diff] [blame] | 1418 | } |
| 1419 | } |
| 1420 | |
Jiyong Park | 379de2f | 2018-12-19 02:47:14 +0900 | [diff] [blame] | 1421 | // Add the dependency to the runtime library for each of the sanitizer variants |
| 1422 | func sanitizerRuntimeMutator(mctx android.BottomUpMutatorContext) { |
Jiyong Park | 379de2f | 2018-12-19 02:47:14 +0900 | [diff] [blame] | 1423 | if c, ok := mctx.Module().(*Module); ok && c.sanitize != nil { |
Pirama Arumuga Nainar | 6aa2102 | 2019-01-25 00:20:35 +0000 | [diff] [blame] | 1424 | if !c.Enabled() { |
| 1425 | return |
| 1426 | } |
Jiyong Park | 379de2f | 2018-12-19 02:47:14 +0900 | [diff] [blame] | 1427 | var sanitizers []string |
| 1428 | var diagSanitizers []string |
| 1429 | |
Liz Kammer | 2c1d6aa | 2022-10-03 15:07:37 -0400 | [diff] [blame] | 1430 | sanProps := &c.sanitize.Properties.SanitizeMutated |
| 1431 | |
| 1432 | if Bool(sanProps.All_undefined) { |
Jiyong Park | 379de2f | 2018-12-19 02:47:14 +0900 | [diff] [blame] | 1433 | sanitizers = append(sanitizers, "undefined") |
| 1434 | } else { |
Liz Kammer | 2c1d6aa | 2022-10-03 15:07:37 -0400 | [diff] [blame] | 1435 | if Bool(sanProps.Undefined) { |
Jiyong Park | 379de2f | 2018-12-19 02:47:14 +0900 | [diff] [blame] | 1436 | sanitizers = append(sanitizers, |
| 1437 | "bool", |
| 1438 | "integer-divide-by-zero", |
| 1439 | "return", |
| 1440 | "returns-nonnull-attribute", |
| 1441 | "shift-exponent", |
| 1442 | "unreachable", |
| 1443 | "vla-bound", |
| 1444 | // TODO(danalbert): The following checks currently have compiler performance issues. |
| 1445 | //"alignment", |
| 1446 | //"bounds", |
| 1447 | //"enum", |
| 1448 | //"float-cast-overflow", |
| 1449 | //"float-divide-by-zero", |
| 1450 | //"nonnull-attribute", |
| 1451 | //"null", |
| 1452 | //"shift-base", |
| 1453 | //"signed-integer-overflow", |
| 1454 | // TODO(danalbert): Fix UB in libc++'s __tree so we can turn this on. |
| 1455 | // https://llvm.org/PR19302 |
| 1456 | // http://reviews.llvm.org/D6974 |
| 1457 | // "object-size", |
| 1458 | ) |
| 1459 | } |
Liz Kammer | 2c1d6aa | 2022-10-03 15:07:37 -0400 | [diff] [blame] | 1460 | sanitizers = append(sanitizers, sanProps.Misc_undefined...) |
Jiyong Park | 379de2f | 2018-12-19 02:47:14 +0900 | [diff] [blame] | 1461 | } |
| 1462 | |
Liz Kammer | 2c1d6aa | 2022-10-03 15:07:37 -0400 | [diff] [blame] | 1463 | if Bool(sanProps.Diag.Undefined) { |
Jiyong Park | 379de2f | 2018-12-19 02:47:14 +0900 | [diff] [blame] | 1464 | diagSanitizers = append(diagSanitizers, "undefined") |
| 1465 | } |
| 1466 | |
Liz Kammer | 2c1d6aa | 2022-10-03 15:07:37 -0400 | [diff] [blame] | 1467 | diagSanitizers = append(diagSanitizers, sanProps.Diag.Misc_undefined...) |
Jiyong Park | 379de2f | 2018-12-19 02:47:14 +0900 | [diff] [blame] | 1468 | |
Liz Kammer | 2c1d6aa | 2022-10-03 15:07:37 -0400 | [diff] [blame] | 1469 | if Bool(sanProps.Address) { |
Jiyong Park | 379de2f | 2018-12-19 02:47:14 +0900 | [diff] [blame] | 1470 | sanitizers = append(sanitizers, "address") |
| 1471 | diagSanitizers = append(diagSanitizers, "address") |
| 1472 | } |
| 1473 | |
Liz Kammer | 2c1d6aa | 2022-10-03 15:07:37 -0400 | [diff] [blame] | 1474 | if Bool(sanProps.Hwaddress) { |
Jiyong Park | 379de2f | 2018-12-19 02:47:14 +0900 | [diff] [blame] | 1475 | sanitizers = append(sanitizers, "hwaddress") |
| 1476 | } |
| 1477 | |
Liz Kammer | 2c1d6aa | 2022-10-03 15:07:37 -0400 | [diff] [blame] | 1478 | if Bool(sanProps.Thread) { |
Jiyong Park | 379de2f | 2018-12-19 02:47:14 +0900 | [diff] [blame] | 1479 | sanitizers = append(sanitizers, "thread") |
| 1480 | } |
| 1481 | |
Liz Kammer | 2c1d6aa | 2022-10-03 15:07:37 -0400 | [diff] [blame] | 1482 | if Bool(sanProps.Safestack) { |
Jiyong Park | 379de2f | 2018-12-19 02:47:14 +0900 | [diff] [blame] | 1483 | sanitizers = append(sanitizers, "safe-stack") |
| 1484 | } |
| 1485 | |
Liz Kammer | 2c1d6aa | 2022-10-03 15:07:37 -0400 | [diff] [blame] | 1486 | if Bool(sanProps.Cfi) { |
Jiyong Park | 379de2f | 2018-12-19 02:47:14 +0900 | [diff] [blame] | 1487 | sanitizers = append(sanitizers, "cfi") |
| 1488 | |
Liz Kammer | 2c1d6aa | 2022-10-03 15:07:37 -0400 | [diff] [blame] | 1489 | if Bool(sanProps.Diag.Cfi) { |
Jiyong Park | 379de2f | 2018-12-19 02:47:14 +0900 | [diff] [blame] | 1490 | diagSanitizers = append(diagSanitizers, "cfi") |
| 1491 | } |
| 1492 | } |
| 1493 | |
Liz Kammer | 2c1d6aa | 2022-10-03 15:07:37 -0400 | [diff] [blame] | 1494 | if Bool(sanProps.Integer_overflow) { |
Jiyong Park | 379de2f | 2018-12-19 02:47:14 +0900 | [diff] [blame] | 1495 | sanitizers = append(sanitizers, "unsigned-integer-overflow") |
| 1496 | sanitizers = append(sanitizers, "signed-integer-overflow") |
Liz Kammer | 2c1d6aa | 2022-10-03 15:07:37 -0400 | [diff] [blame] | 1497 | if Bool(sanProps.Diag.Integer_overflow) { |
Jiyong Park | 379de2f | 2018-12-19 02:47:14 +0900 | [diff] [blame] | 1498 | diagSanitizers = append(diagSanitizers, "unsigned-integer-overflow") |
| 1499 | diagSanitizers = append(diagSanitizers, "signed-integer-overflow") |
| 1500 | } |
| 1501 | } |
| 1502 | |
Liz Kammer | 2c1d6aa | 2022-10-03 15:07:37 -0400 | [diff] [blame] | 1503 | if Bool(sanProps.Scudo) { |
Jiyong Park | 379de2f | 2018-12-19 02:47:14 +0900 | [diff] [blame] | 1504 | sanitizers = append(sanitizers, "scudo") |
| 1505 | } |
| 1506 | |
Liz Kammer | 2c1d6aa | 2022-10-03 15:07:37 -0400 | [diff] [blame] | 1507 | if Bool(sanProps.Scs) { |
Jiyong Park | 379de2f | 2018-12-19 02:47:14 +0900 | [diff] [blame] | 1508 | sanitizers = append(sanitizers, "shadow-call-stack") |
| 1509 | } |
| 1510 | |
Liz Kammer | 2c1d6aa | 2022-10-03 15:07:37 -0400 | [diff] [blame] | 1511 | if Bool(sanProps.Memtag_heap) && c.Binary() { |
Florian Mayer | d8434a4 | 2022-08-31 20:57:03 +0000 | [diff] [blame] | 1512 | sanitizers = append(sanitizers, "memtag-heap") |
| 1513 | } |
| 1514 | |
Liz Kammer | 2c1d6aa | 2022-10-03 15:07:37 -0400 | [diff] [blame] | 1515 | if Bool(sanProps.Memtag_stack) { |
Florian Mayer | d8434a4 | 2022-08-31 20:57:03 +0000 | [diff] [blame] | 1516 | sanitizers = append(sanitizers, "memtag-stack") |
Evgenii Stepanov | 193ac2e | 2020-04-28 15:09:12 -0700 | [diff] [blame] | 1517 | } |
| 1518 | |
Liz Kammer | 2c1d6aa | 2022-10-03 15:07:37 -0400 | [diff] [blame] | 1519 | if Bool(sanProps.Fuzzer) { |
Mitch Phillips | 5a6ea6c | 2019-05-01 14:42:05 -0700 | [diff] [blame] | 1520 | sanitizers = append(sanitizers, "fuzzer-no-link") |
| 1521 | } |
| 1522 | |
Jiyong Park | 379de2f | 2018-12-19 02:47:14 +0900 | [diff] [blame] | 1523 | // Save the list of sanitizers. These will be used again when generating |
| 1524 | // the build rules (for Cflags, etc.) |
| 1525 | c.sanitize.Properties.Sanitizers = sanitizers |
| 1526 | c.sanitize.Properties.DiagSanitizers = diagSanitizers |
| 1527 | |
Ivan Lozano | f3b190f | 2020-03-06 12:01:21 -0500 | [diff] [blame] | 1528 | // TODO(b/150822854) Hosts have a different default behavior and assume the runtime library is used. |
| 1529 | if c.Host() { |
| 1530 | diagSanitizers = sanitizers |
| 1531 | } |
| 1532 | |
Jiyong Park | 379de2f | 2018-12-19 02:47:14 +0900 | [diff] [blame] | 1533 | // Determine the runtime library required |
| 1534 | runtimeLibrary := "" |
Colin Cross | e725b4e | 2022-10-19 15:46:53 -0700 | [diff] [blame] | 1535 | alwaysStaticRuntime := false |
Ryan Prichard | b49fe1b | 2019-10-11 15:03:34 -0700 | [diff] [blame] | 1536 | var extraStaticDeps []string |
Jiyong Park | 379de2f | 2018-12-19 02:47:14 +0900 | [diff] [blame] | 1537 | toolchain := c.toolchain(mctx) |
Liz Kammer | 2c1d6aa | 2022-10-03 15:07:37 -0400 | [diff] [blame] | 1538 | if Bool(sanProps.Address) { |
Jiyong Park | 379de2f | 2018-12-19 02:47:14 +0900 | [diff] [blame] | 1539 | runtimeLibrary = config.AddressSanitizerRuntimeLibrary(toolchain) |
Liz Kammer | 2c1d6aa | 2022-10-03 15:07:37 -0400 | [diff] [blame] | 1540 | } else if Bool(sanProps.Hwaddress) { |
Jiyong Park | 379de2f | 2018-12-19 02:47:14 +0900 | [diff] [blame] | 1541 | if c.staticBinary() { |
| 1542 | runtimeLibrary = config.HWAddressSanitizerStaticLibrary(toolchain) |
Ryan Prichard | b49fe1b | 2019-10-11 15:03:34 -0700 | [diff] [blame] | 1543 | extraStaticDeps = []string{"libdl"} |
Jiyong Park | 379de2f | 2018-12-19 02:47:14 +0900 | [diff] [blame] | 1544 | } else { |
| 1545 | runtimeLibrary = config.HWAddressSanitizerRuntimeLibrary(toolchain) |
| 1546 | } |
Liz Kammer | 2c1d6aa | 2022-10-03 15:07:37 -0400 | [diff] [blame] | 1547 | } else if Bool(sanProps.Thread) { |
Jiyong Park | 379de2f | 2018-12-19 02:47:14 +0900 | [diff] [blame] | 1548 | runtimeLibrary = config.ThreadSanitizerRuntimeLibrary(toolchain) |
Liz Kammer | 2c1d6aa | 2022-10-03 15:07:37 -0400 | [diff] [blame] | 1549 | } else if Bool(sanProps.Scudo) { |
Jiyong Park | 379de2f | 2018-12-19 02:47:14 +0900 | [diff] [blame] | 1550 | if len(diagSanitizers) == 0 && !c.sanitize.Properties.UbsanRuntimeDep { |
| 1551 | runtimeLibrary = config.ScudoMinimalRuntimeLibrary(toolchain) |
| 1552 | } else { |
| 1553 | runtimeLibrary = config.ScudoRuntimeLibrary(toolchain) |
| 1554 | } |
Mitch Phillips | b8e593d | 2019-10-09 17:18:59 -0700 | [diff] [blame] | 1555 | } else if len(diagSanitizers) > 0 || c.sanitize.Properties.UbsanRuntimeDep || |
Liz Kammer | 2c1d6aa | 2022-10-03 15:07:37 -0400 | [diff] [blame] | 1556 | Bool(sanProps.Fuzzer) || |
| 1557 | Bool(sanProps.Undefined) || |
| 1558 | Bool(sanProps.All_undefined) { |
Jiyong Park | 379de2f | 2018-12-19 02:47:14 +0900 | [diff] [blame] | 1559 | runtimeLibrary = config.UndefinedBehaviorSanitizerRuntimeLibrary(toolchain) |
Colin Cross | e725b4e | 2022-10-19 15:46:53 -0700 | [diff] [blame] | 1560 | if c.staticBinary() || toolchain.Musl() { |
| 1561 | // Use a static runtime for static binaries. |
| 1562 | // Also use a static runtime for musl to match |
| 1563 | // what clang does for glibc. Otherwise dlopening |
| 1564 | // libraries that depend on libclang_rt.ubsan_standalone.so |
| 1565 | // fails with: |
| 1566 | // Error relocating ...: initial-exec TLS resolves to dynamic definition |
Colin Cross | 32f1de3 | 2021-03-29 13:41:37 -0700 | [diff] [blame] | 1567 | runtimeLibrary += ".static" |
Colin Cross | e725b4e | 2022-10-19 15:46:53 -0700 | [diff] [blame] | 1568 | alwaysStaticRuntime = true |
Colin Cross | 32f1de3 | 2021-03-29 13:41:37 -0700 | [diff] [blame] | 1569 | } |
Jiyong Park | 379de2f | 2018-12-19 02:47:14 +0900 | [diff] [blame] | 1570 | } |
| 1571 | |
Colin Cross | 06c80eb | 2022-02-10 10:34:19 -0800 | [diff] [blame] | 1572 | addStaticDeps := func(deps ...string) { |
| 1573 | // If we're using snapshots, redirect to snapshot whenever possible |
| 1574 | snapshot := mctx.Provider(SnapshotInfoProvider).(SnapshotInfo) |
| 1575 | for idx, dep := range deps { |
| 1576 | if lib, ok := snapshot.StaticLibs[dep]; ok { |
| 1577 | deps[idx] = lib |
| 1578 | } |
| 1579 | } |
| 1580 | |
| 1581 | // static executable gets static runtime libs |
Colin Cross | 3e5e778 | 2022-06-17 22:17:05 +0000 | [diff] [blame] | 1582 | depTag := libraryDependencyTag{Kind: staticLibraryDependency, unexportedSymbols: true} |
Colin Cross | 06c80eb | 2022-02-10 10:34:19 -0800 | [diff] [blame] | 1583 | variations := append(mctx.Target().Variations(), |
| 1584 | blueprint.Variation{Mutator: "link", Variation: "static"}) |
| 1585 | if c.Device() { |
| 1586 | variations = append(variations, c.ImageVariation()) |
| 1587 | } |
| 1588 | if c.UseSdk() { |
| 1589 | variations = append(variations, |
| 1590 | blueprint.Variation{Mutator: "sdk", Variation: "sdk"}) |
| 1591 | } |
| 1592 | mctx.AddFarVariationDependencies(variations, depTag, deps...) |
| 1593 | |
| 1594 | } |
| 1595 | if enableMinimalRuntime(c.sanitize) || c.sanitize.Properties.MinimalRuntimeDep { |
| 1596 | addStaticDeps(config.UndefinedBehaviorSanitizerMinimalRuntimeLibrary(toolchain)) |
| 1597 | } |
| 1598 | if c.sanitize.Properties.BuiltinsDep { |
| 1599 | addStaticDeps(config.BuiltinsRuntimeLibrary(toolchain)) |
| 1600 | } |
| 1601 | |
Colin Cross | ed12a04 | 2022-02-07 13:55:55 -0800 | [diff] [blame] | 1602 | if runtimeLibrary != "" && (toolchain.Bionic() || toolchain.Musl() || c.sanitize.Properties.UbsanRuntimeDep) { |
Ivan Lozano | 9ac32c7 | 2020-02-19 15:24:02 -0500 | [diff] [blame] | 1603 | // UBSan is supported on non-bionic linux host builds as well |
Jiyong Park | 379de2f | 2018-12-19 02:47:14 +0900 | [diff] [blame] | 1604 | |
| 1605 | // Adding dependency to the runtime library. We are using *FarVariation* |
| 1606 | // because the runtime libraries themselves are not mutated by sanitizer |
| 1607 | // mutators and thus don't have sanitizer variants whereas this module |
| 1608 | // has been already mutated. |
| 1609 | // |
| 1610 | // Note that by adding dependency with {static|shared}DepTag, the lib is |
| 1611 | // added to libFlags and LOCAL_SHARED_LIBRARIES by cc.Module |
Colin Cross | e725b4e | 2022-10-19 15:46:53 -0700 | [diff] [blame] | 1612 | if c.staticBinary() || alwaysStaticRuntime { |
Colin Cross | 06c80eb | 2022-02-10 10:34:19 -0800 | [diff] [blame] | 1613 | addStaticDeps(runtimeLibrary) |
| 1614 | addStaticDeps(extraStaticDeps...) |
Ivan Lozano | 3968d8f | 2020-12-14 11:27:52 -0500 | [diff] [blame] | 1615 | } else if !c.static() && !c.Header() { |
Colin Cross | e0edaf9 | 2021-01-11 17:31:17 -0800 | [diff] [blame] | 1616 | // If we're using snapshots, redirect to snapshot whenever possible |
| 1617 | snapshot := mctx.Provider(SnapshotInfoProvider).(SnapshotInfo) |
| 1618 | if lib, ok := snapshot.SharedLibs[runtimeLibrary]; ok { |
| 1619 | runtimeLibrary = lib |
Inseob Kim | eec88e1 | 2020-01-22 11:11:29 +0900 | [diff] [blame] | 1620 | } |
Colin Cross | e0edaf9 | 2021-01-11 17:31:17 -0800 | [diff] [blame] | 1621 | |
Cindy Zhou | 18417cb | 2020-12-10 07:12:38 -0800 | [diff] [blame] | 1622 | // Skip apex dependency check for sharedLibraryDependency |
| 1623 | // when sanitizer diags are enabled. Skipping the check will allow |
| 1624 | // building with diag libraries without having to list the |
| 1625 | // dependency in Apex's allowed_deps file. |
| 1626 | diagEnabled := len(diagSanitizers) > 0 |
Jiyong Park | 3b1746a | 2019-01-29 11:15:04 +0900 | [diff] [blame] | 1627 | // dynamic executable and shared libs get shared runtime libs |
Cindy Zhou | 18417cb | 2020-12-10 07:12:38 -0800 | [diff] [blame] | 1628 | depTag := libraryDependencyTag{ |
| 1629 | Kind: sharedLibraryDependency, |
| 1630 | Order: earlyLibraryDependency, |
| 1631 | |
| 1632 | skipApexAllowedDependenciesCheck: diagEnabled, |
| 1633 | } |
Colin Cross | 4250733 | 2020-08-21 16:15:23 -0700 | [diff] [blame] | 1634 | variations := append(mctx.Target().Variations(), |
| 1635 | blueprint.Variation{Mutator: "link", Variation: "shared"}) |
| 1636 | if c.Device() { |
| 1637 | variations = append(variations, c.ImageVariation()) |
| 1638 | } |
Colin Cross | 06c80eb | 2022-02-10 10:34:19 -0800 | [diff] [blame] | 1639 | if c.UseSdk() { |
| 1640 | variations = append(variations, |
| 1641 | blueprint.Variation{Mutator: "sdk", Variation: "sdk"}) |
| 1642 | } |
Ivan Lozano | d67a6b0 | 2021-05-20 13:01:32 -0400 | [diff] [blame] | 1643 | AddSharedLibDependenciesWithVersions(mctx, c, variations, depTag, runtimeLibrary, "", true) |
Jiyong Park | 379de2f | 2018-12-19 02:47:14 +0900 | [diff] [blame] | 1644 | } |
| 1645 | // static lib does not have dependency to the runtime library. The |
| 1646 | // dependency will be added to the executables or shared libs using |
| 1647 | // the static lib. |
| 1648 | } |
| 1649 | } |
| 1650 | } |
| 1651 | |
| 1652 | type Sanitizeable interface { |
| 1653 | android.Module |
Lukacs T. Berki | 01a648a | 2022-06-17 08:59:37 +0200 | [diff] [blame] | 1654 | IsSanitizerEnabled(config android.Config, sanitizerName string) bool |
Jiyong Park | f97782b | 2019-02-13 20:28:58 +0900 | [diff] [blame] | 1655 | EnableSanitizer(sanitizerName string) |
Jooyung Han | 8ce8db9 | 2020-05-15 19:05:05 +0900 | [diff] [blame] | 1656 | AddSanitizerDependencies(ctx android.BottomUpMutatorContext, sanitizerName string) |
Jiyong Park | 379de2f | 2018-12-19 02:47:14 +0900 | [diff] [blame] | 1657 | } |
| 1658 | |
Muhammad Haseeb Ahmad | 7e74405 | 2022-03-25 22:50:53 +0000 | [diff] [blame] | 1659 | type JniSanitizeable interface { |
| 1660 | android.Module |
| 1661 | IsSanitizerEnabledForJni(ctx android.BaseModuleContext, sanitizerName string) bool |
| 1662 | } |
| 1663 | |
Ivan Lozano | d7586b6 | 2021-04-01 09:49:36 -0400 | [diff] [blame] | 1664 | func (c *Module) MinimalRuntimeDep() bool { |
| 1665 | return c.sanitize.Properties.MinimalRuntimeDep |
| 1666 | } |
| 1667 | |
| 1668 | func (c *Module) UbsanRuntimeDep() bool { |
| 1669 | return c.sanitize.Properties.UbsanRuntimeDep |
| 1670 | } |
| 1671 | |
Ivan Lozano | 3968d8f | 2020-12-14 11:27:52 -0500 | [diff] [blame] | 1672 | func (c *Module) SanitizePropDefined() bool { |
| 1673 | return c.sanitize != nil |
| 1674 | } |
| 1675 | |
| 1676 | func (c *Module) IsSanitizerEnabled(t SanitizerType) bool { |
| 1677 | return c.sanitize.isSanitizerEnabled(t) |
| 1678 | } |
| 1679 | |
Ivan Lozano | 3968d8f | 2020-12-14 11:27:52 -0500 | [diff] [blame] | 1680 | func (c *Module) StaticallyLinked() bool { |
| 1681 | return c.static() |
| 1682 | } |
| 1683 | |
| 1684 | func (c *Module) SetInSanitizerDir() { |
| 1685 | if c.sanitize != nil { |
| 1686 | c.sanitize.Properties.InSanitizerDir = true |
| 1687 | } |
| 1688 | } |
| 1689 | |
| 1690 | func (c *Module) SetSanitizer(t SanitizerType, b bool) { |
| 1691 | if c.sanitize != nil { |
| 1692 | c.sanitize.SetSanitizer(t, b) |
| 1693 | } |
| 1694 | } |
| 1695 | |
Ivan Lozano | 3968d8f | 2020-12-14 11:27:52 -0500 | [diff] [blame] | 1696 | var _ PlatformSanitizeable = (*Module)(nil) |
| 1697 | |
Inseob Kim | 74d2556 | 2020-08-04 00:41:38 +0900 | [diff] [blame] | 1698 | type sanitizerStaticLibsMap struct { |
| 1699 | // libsMap contains one list of modules per each image and each arch. |
| 1700 | // e.g. libs[vendor]["arm"] contains arm modules installed to vendor |
Ivan Lozano | 3968d8f | 2020-12-14 11:27:52 -0500 | [diff] [blame] | 1701 | libsMap map[ImageVariantType]map[string][]string |
Inseob Kim | 74d2556 | 2020-08-04 00:41:38 +0900 | [diff] [blame] | 1702 | libsMapLock sync.Mutex |
Ivan Lozano | 3968d8f | 2020-12-14 11:27:52 -0500 | [diff] [blame] | 1703 | sanitizerType SanitizerType |
Inseob Kim | 74d2556 | 2020-08-04 00:41:38 +0900 | [diff] [blame] | 1704 | } |
| 1705 | |
Ivan Lozano | 3968d8f | 2020-12-14 11:27:52 -0500 | [diff] [blame] | 1706 | func newSanitizerStaticLibsMap(t SanitizerType) *sanitizerStaticLibsMap { |
Inseob Kim | 74d2556 | 2020-08-04 00:41:38 +0900 | [diff] [blame] | 1707 | return &sanitizerStaticLibsMap{ |
| 1708 | sanitizerType: t, |
Ivan Lozano | 3968d8f | 2020-12-14 11:27:52 -0500 | [diff] [blame] | 1709 | libsMap: make(map[ImageVariantType]map[string][]string), |
Inseob Kim | 74d2556 | 2020-08-04 00:41:38 +0900 | [diff] [blame] | 1710 | } |
| 1711 | } |
| 1712 | |
| 1713 | // Add the current module to sanitizer static libs maps |
| 1714 | // Each module should pass its exported name as names of Make and Soong can differ. |
Ivan Lozano | 3968d8f | 2020-12-14 11:27:52 -0500 | [diff] [blame] | 1715 | func (s *sanitizerStaticLibsMap) add(c LinkableInterface, name string) { |
| 1716 | image := GetImageVariantType(c) |
| 1717 | arch := c.Module().Target().Arch.ArchType.String() |
Inseob Kim | 74d2556 | 2020-08-04 00:41:38 +0900 | [diff] [blame] | 1718 | |
| 1719 | s.libsMapLock.Lock() |
| 1720 | defer s.libsMapLock.Unlock() |
| 1721 | |
| 1722 | if _, ok := s.libsMap[image]; !ok { |
| 1723 | s.libsMap[image] = make(map[string][]string) |
| 1724 | } |
| 1725 | |
| 1726 | s.libsMap[image][arch] = append(s.libsMap[image][arch], name) |
| 1727 | } |
| 1728 | |
| 1729 | // Exports makefile variables in the following format: |
| 1730 | // SOONG_{sanitizer}_{image}_{arch}_STATIC_LIBRARIES |
| 1731 | // e.g. SOONG_cfi_core_x86_STATIC_LIBRARIES |
| 1732 | // These are to be used by use_soong_sanitized_static_libraries. |
| 1733 | // See build/make/core/binary.mk for more details. |
| 1734 | func (s *sanitizerStaticLibsMap) exportToMake(ctx android.MakeVarsContext) { |
Cole Faust | 18994c7 | 2023-02-28 16:02:16 -0800 | [diff] [blame] | 1735 | for _, image := range android.SortedKeys(s.libsMap) { |
Ivan Lozano | 3968d8f | 2020-12-14 11:27:52 -0500 | [diff] [blame] | 1736 | archMap := s.libsMap[ImageVariantType(image)] |
Cole Faust | 18994c7 | 2023-02-28 16:02:16 -0800 | [diff] [blame] | 1737 | for _, arch := range android.SortedKeys(archMap) { |
Inseob Kim | 74d2556 | 2020-08-04 00:41:38 +0900 | [diff] [blame] | 1738 | libs := archMap[arch] |
| 1739 | sort.Strings(libs) |
| 1740 | |
| 1741 | key := fmt.Sprintf( |
| 1742 | "SOONG_%s_%s_%s_STATIC_LIBRARIES", |
| 1743 | s.sanitizerType.variationName(), |
| 1744 | image, // already upper |
| 1745 | arch) |
| 1746 | |
| 1747 | ctx.Strict(key, strings.Join(libs, " ")) |
| 1748 | } |
| 1749 | } |
| 1750 | } |
| 1751 | |
Colin Cross | 571cccf | 2019-02-04 11:22:08 -0800 | [diff] [blame] | 1752 | var cfiStaticLibsKey = android.NewOnceKey("cfiStaticLibs") |
| 1753 | |
Inseob Kim | 74d2556 | 2020-08-04 00:41:38 +0900 | [diff] [blame] | 1754 | func cfiStaticLibs(config android.Config) *sanitizerStaticLibsMap { |
Colin Cross | 571cccf | 2019-02-04 11:22:08 -0800 | [diff] [blame] | 1755 | return config.Once(cfiStaticLibsKey, func() interface{} { |
Inseob Kim | 74d2556 | 2020-08-04 00:41:38 +0900 | [diff] [blame] | 1756 | return newSanitizerStaticLibsMap(cfi) |
| 1757 | }).(*sanitizerStaticLibsMap) |
Vishwath Mohan | e712879 | 2017-11-17 11:08:10 -0800 | [diff] [blame] | 1758 | } |
| 1759 | |
Colin Cross | 571cccf | 2019-02-04 11:22:08 -0800 | [diff] [blame] | 1760 | var hwasanStaticLibsKey = android.NewOnceKey("hwasanStaticLibs") |
| 1761 | |
Inseob Kim | 74d2556 | 2020-08-04 00:41:38 +0900 | [diff] [blame] | 1762 | func hwasanStaticLibs(config android.Config) *sanitizerStaticLibsMap { |
Colin Cross | 571cccf | 2019-02-04 11:22:08 -0800 | [diff] [blame] | 1763 | return config.Once(hwasanStaticLibsKey, func() interface{} { |
Tri Vo | 6eafc36 | 2021-04-01 11:29:09 -0700 | [diff] [blame] | 1764 | return newSanitizerStaticLibsMap(Hwasan) |
Inseob Kim | 74d2556 | 2020-08-04 00:41:38 +0900 | [diff] [blame] | 1765 | }).(*sanitizerStaticLibsMap) |
Jiyong Park | 1d1119f | 2019-07-29 21:27:18 +0900 | [diff] [blame] | 1766 | } |
| 1767 | |
Ivan Lozano | 30c5db2 | 2018-02-21 15:49:20 -0800 | [diff] [blame] | 1768 | func enableMinimalRuntime(sanitize *sanitize) bool { |
Liz Kammer | 2c1d6aa | 2022-10-03 15:07:37 -0400 | [diff] [blame] | 1769 | if sanitize.isSanitizerEnabled(Asan) { |
| 1770 | return false |
| 1771 | } else if sanitize.isSanitizerEnabled(Hwasan) { |
| 1772 | return false |
| 1773 | } else if sanitize.isSanitizerEnabled(Fuzzer) { |
| 1774 | return false |
Ivan Lozano | 30c5db2 | 2018-02-21 15:49:20 -0800 | [diff] [blame] | 1775 | } |
Liz Kammer | 2c1d6aa | 2022-10-03 15:07:37 -0400 | [diff] [blame] | 1776 | |
| 1777 | if enableUbsanRuntime(sanitize) { |
| 1778 | return false |
| 1779 | } |
| 1780 | |
| 1781 | sanitizeProps := &sanitize.Properties.SanitizeMutated |
| 1782 | if Bool(sanitizeProps.Diag.Cfi) { |
| 1783 | return false |
| 1784 | } |
| 1785 | |
| 1786 | return Bool(sanitizeProps.Integer_overflow) || |
| 1787 | len(sanitizeProps.Misc_undefined) > 0 || |
| 1788 | Bool(sanitizeProps.Undefined) || |
| 1789 | Bool(sanitizeProps.All_undefined) |
Ivan Lozano | 30c5db2 | 2018-02-21 15:49:20 -0800 | [diff] [blame] | 1790 | } |
| 1791 | |
Ivan Lozano | d7586b6 | 2021-04-01 09:49:36 -0400 | [diff] [blame] | 1792 | func (m *Module) UbsanRuntimeNeeded() bool { |
| 1793 | return enableUbsanRuntime(m.sanitize) |
| 1794 | } |
| 1795 | |
| 1796 | func (m *Module) MinimalRuntimeNeeded() bool { |
| 1797 | return enableMinimalRuntime(m.sanitize) |
| 1798 | } |
| 1799 | |
Inseob Kim | 8471cda | 2019-11-15 09:59:12 +0900 | [diff] [blame] | 1800 | func enableUbsanRuntime(sanitize *sanitize) bool { |
Liz Kammer | 2c1d6aa | 2022-10-03 15:07:37 -0400 | [diff] [blame] | 1801 | sanitizeProps := &sanitize.Properties.SanitizeMutated |
| 1802 | return Bool(sanitizeProps.Diag.Integer_overflow) || |
| 1803 | Bool(sanitizeProps.Diag.Undefined) || |
| 1804 | len(sanitizeProps.Diag.Misc_undefined) > 0 |
Inseob Kim | 8471cda | 2019-11-15 09:59:12 +0900 | [diff] [blame] | 1805 | } |
| 1806 | |
Vishwath Mohan | e712879 | 2017-11-17 11:08:10 -0800 | [diff] [blame] | 1807 | func cfiMakeVarsProvider(ctx android.MakeVarsContext) { |
Inseob Kim | 74d2556 | 2020-08-04 00:41:38 +0900 | [diff] [blame] | 1808 | cfiStaticLibs(ctx.Config()).exportToMake(ctx) |
Vishwath Mohan | e712879 | 2017-11-17 11:08:10 -0800 | [diff] [blame] | 1809 | } |
Evgenii Stepanov | d97a6e9 | 2018-08-02 16:19:13 -0700 | [diff] [blame] | 1810 | |
| 1811 | func hwasanMakeVarsProvider(ctx android.MakeVarsContext) { |
Inseob Kim | 74d2556 | 2020-08-04 00:41:38 +0900 | [diff] [blame] | 1812 | hwasanStaticLibs(ctx.Config()).exportToMake(ctx) |
Evgenii Stepanov | d97a6e9 | 2018-08-02 16:19:13 -0700 | [diff] [blame] | 1813 | } |
Trevor Radcliffe | 4f95ee9 | 2023-01-19 16:02:47 +0000 | [diff] [blame] | 1814 | |
| 1815 | func BazelCcSanitizerToolchainVars(config android.Config) string { |
| 1816 | return android.BazelToolchainVars(config, exportedVars) |
| 1817 | } |