blob: 2921c3e82dabcd54818bf700e67cec3625a606df [file] [log] [blame]
Colin Cross2207f872021-03-24 12:39:08 -07001// Copyright 2021 Google Inc. All rights reserved.
2//
3// Licensed under the Apache License, Version 2.0 (the "License");
4// you may not use this file except in compliance with the License.
5// You may obtain a copy of the License at
6//
7// http://www.apache.org/licenses/LICENSE-2.0
8//
9// Unless required by applicable law or agreed to in writing, software
10// distributed under the License is distributed on an "AS IS" BASIS,
11// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
12// See the License for the specific language governing permissions and
13// limitations under the License.
14
15package java
16
17import (
18 "fmt"
Anton Hansson86758ac2021-11-03 14:44:12 +000019 "path/filepath"
Colin Cross2207f872021-03-24 12:39:08 -070020 "strings"
21
22 "github.com/google/blueprint/proptools"
23
24 "android/soong/android"
25 "android/soong/java/config"
26 "android/soong/remoteexec"
27)
28
Pedro Loureirocc203502021-10-04 17:24:00 +000029// The values allowed for Droidstubs' Api_levels_sdk_type
30var allowedApiLevelSdkTypes = []string{"public", "system", "module-lib"}
31
Colin Cross2207f872021-03-24 12:39:08 -070032func init() {
33 RegisterStubsBuildComponents(android.InitRegistrationContext)
34}
35
36func RegisterStubsBuildComponents(ctx android.RegistrationContext) {
37 ctx.RegisterModuleType("stubs_defaults", StubsDefaultsFactory)
38
39 ctx.RegisterModuleType("droidstubs", DroidstubsFactory)
40 ctx.RegisterModuleType("droidstubs_host", DroidstubsHostFactory)
41
42 ctx.RegisterModuleType("prebuilt_stubs_sources", PrebuiltStubsSourcesFactory)
43}
44
45//
46// Droidstubs
47//
48type Droidstubs struct {
49 Javadoc
50 android.SdkBase
51
52 properties DroidstubsProperties
53 apiFile android.WritablePath
54 apiXmlFile android.WritablePath
55 lastReleasedApiXmlFile android.WritablePath
56 privateApiFile android.WritablePath
57 removedApiFile android.WritablePath
Colin Cross2207f872021-03-24 12:39:08 -070058 nullabilityWarningsFile android.WritablePath
59
60 checkCurrentApiTimestamp android.WritablePath
61 updateCurrentApiTimestamp android.WritablePath
62 checkLastReleasedApiTimestamp android.WritablePath
63 apiLintTimestamp android.WritablePath
64 apiLintReport android.WritablePath
65
66 checkNullabilityWarningsTimestamp android.WritablePath
67
68 annotationsZip android.WritablePath
69 apiVersionsXml android.WritablePath
70
71 apiFilePath android.Path
72 removedApiFilePath android.Path
73
74 metadataZip android.WritablePath
75 metadataDir android.WritablePath
76}
77
78type DroidstubsProperties struct {
79 // The generated public API filename by Metalava, defaults to <module>_api.txt
80 Api_filename *string
81
82 // the generated removed API filename by Metalava, defaults to <module>_removed.txt
83 Removed_api_filename *string
84
Colin Cross2207f872021-03-24 12:39:08 -070085 Check_api struct {
86 Last_released ApiToCheck
87
88 Current ApiToCheck
89
90 Api_lint struct {
91 Enabled *bool
92
93 // If set, performs api_lint on any new APIs not found in the given signature file
94 New_since *string `android:"path"`
95
96 // If not blank, path to the baseline txt file for approved API lint violations.
97 Baseline_file *string `android:"path"`
98 }
99 }
100
101 // user can specify the version of previous released API file in order to do compatibility check.
102 Previous_api *string `android:"path"`
103
104 // is set to true, Metalava will allow framework SDK to contain annotations.
105 Annotations_enabled *bool
106
107 // a list of top-level directories containing files to merge qualifier annotations (i.e. those intended to be included in the stubs written) from.
108 Merge_annotations_dirs []string
109
110 // a list of top-level directories containing Java stub files to merge show/hide annotations from.
111 Merge_inclusion_annotations_dirs []string
112
113 // a file containing a list of classes to do nullability validation for.
114 Validate_nullability_from_list *string
115
116 // a file containing expected warnings produced by validation of nullability annotations.
117 Check_nullability_warnings *string
118
119 // if set to true, allow Metalava to generate doc_stubs source files. Defaults to false.
120 Create_doc_stubs *bool
121
122 // if set to true, cause Metalava to output Javadoc comments in the stubs source files. Defaults to false.
123 // Has no effect if create_doc_stubs: true.
124 Output_javadoc_comments *bool
125
126 // if set to false then do not write out stubs. Defaults to true.
127 //
128 // TODO(b/146727827): Remove capability when we do not need to generate stubs and API separately.
129 Generate_stubs *bool
130
131 // if set to true, provides a hint to the build system that this rule uses a lot of memory,
132 // whicih can be used for scheduling purposes
133 High_mem *bool
134
satayev783195c2021-06-23 21:49:57 +0100135 // if set to true, Metalava will allow framework SDK to contain API levels annotations.
Colin Cross2207f872021-03-24 12:39:08 -0700136 Api_levels_annotations_enabled *bool
137
138 // the dirs which Metalava extracts API levels annotations from.
139 Api_levels_annotations_dirs []string
140
Pedro Loureirocc203502021-10-04 17:24:00 +0000141 // the sdk kind which Metalava extracts API levels annotations from. Supports 'public', 'system' and 'module-lib' for now; defaults to public.
satayev783195c2021-06-23 21:49:57 +0100142 Api_levels_sdk_type *string
143
Colin Cross2207f872021-03-24 12:39:08 -0700144 // the filename which Metalava extracts API levels annotations from. Defaults to android.jar.
145 Api_levels_jar_filename *string
146
147 // if set to true, collect the values used by the Dev tools and
148 // write them in files packaged with the SDK. Defaults to false.
149 Write_sdk_values *bool
150}
151
Anton Hansson52609322021-05-05 10:36:05 +0100152// Used by xsd_config
153type ApiFilePath interface {
154 ApiFilePath() android.Path
155}
156
157type ApiStubsSrcProvider interface {
158 StubsSrcJar() android.Path
159}
160
161// Provider of information about API stubs, used by java_sdk_library.
162type ApiStubsProvider interface {
Anton Hanssond78eb762021-09-21 15:25:12 +0100163 AnnotationsZip() android.Path
Anton Hansson52609322021-05-05 10:36:05 +0100164 ApiFilePath
165 RemovedApiFilePath() android.Path
166
167 ApiStubsSrcProvider
168}
169
Colin Cross2207f872021-03-24 12:39:08 -0700170// droidstubs passes sources files through Metalava to generate stub .java files that only contain the API to be
171// documented, filtering out hidden classes and methods. The resulting .java files are intended to be passed to
172// a droiddoc module to generate documentation.
173func DroidstubsFactory() android.Module {
174 module := &Droidstubs{}
175
176 module.AddProperties(&module.properties,
177 &module.Javadoc.properties)
178
179 InitDroiddocModule(module, android.HostAndDeviceSupported)
180 android.InitSdkAwareModule(module)
181 return module
182}
183
184// droidstubs_host passes sources files through Metalava to generate stub .java files that only contain the API
185// to be documented, filtering out hidden classes and methods. The resulting .java files are intended to be
186// passed to a droiddoc_host module to generate documentation. Use a droidstubs_host instead of a droidstubs
187// module when symbols needed by the source files are provided by java_library_host modules.
188func DroidstubsHostFactory() android.Module {
189 module := &Droidstubs{}
190
191 module.AddProperties(&module.properties,
192 &module.Javadoc.properties)
193
194 InitDroiddocModule(module, android.HostSupported)
195 return module
196}
197
198func (d *Droidstubs) OutputFiles(tag string) (android.Paths, error) {
199 switch tag {
200 case "":
201 return android.Paths{d.stubsSrcJar}, nil
202 case ".docs.zip":
203 return android.Paths{d.docZip}, nil
204 case ".api.txt", android.DefaultDistTag:
205 // This is the default dist path for dist properties that have no tag property.
206 return android.Paths{d.apiFilePath}, nil
207 case ".removed-api.txt":
208 return android.Paths{d.removedApiFilePath}, nil
209 case ".annotations.zip":
210 return android.Paths{d.annotationsZip}, nil
211 case ".api_versions.xml":
212 return android.Paths{d.apiVersionsXml}, nil
213 default:
214 return nil, fmt.Errorf("unsupported module reference tag %q", tag)
215 }
216}
217
Anton Hanssond78eb762021-09-21 15:25:12 +0100218func (d *Droidstubs) AnnotationsZip() android.Path {
219 return d.annotationsZip
220}
221
Colin Cross2207f872021-03-24 12:39:08 -0700222func (d *Droidstubs) ApiFilePath() android.Path {
223 return d.apiFilePath
224}
225
226func (d *Droidstubs) RemovedApiFilePath() android.Path {
227 return d.removedApiFilePath
228}
229
230func (d *Droidstubs) StubsSrcJar() android.Path {
231 return d.stubsSrcJar
232}
233
234var metalavaMergeAnnotationsDirTag = dependencyTag{name: "metalava-merge-annotations-dir"}
235var metalavaMergeInclusionAnnotationsDirTag = dependencyTag{name: "metalava-merge-inclusion-annotations-dir"}
236var metalavaAPILevelsAnnotationsDirTag = dependencyTag{name: "metalava-api-levels-annotations-dir"}
237
238func (d *Droidstubs) DepsMutator(ctx android.BottomUpMutatorContext) {
239 d.Javadoc.addDeps(ctx)
240
241 if len(d.properties.Merge_annotations_dirs) != 0 {
242 for _, mergeAnnotationsDir := range d.properties.Merge_annotations_dirs {
243 ctx.AddDependency(ctx.Module(), metalavaMergeAnnotationsDirTag, mergeAnnotationsDir)
244 }
245 }
246
247 if len(d.properties.Merge_inclusion_annotations_dirs) != 0 {
248 for _, mergeInclusionAnnotationsDir := range d.properties.Merge_inclusion_annotations_dirs {
249 ctx.AddDependency(ctx.Module(), metalavaMergeInclusionAnnotationsDirTag, mergeInclusionAnnotationsDir)
250 }
251 }
252
253 if len(d.properties.Api_levels_annotations_dirs) != 0 {
254 for _, apiLevelsAnnotationsDir := range d.properties.Api_levels_annotations_dirs {
255 ctx.AddDependency(ctx.Module(), metalavaAPILevelsAnnotationsDirTag, apiLevelsAnnotationsDir)
256 }
257 }
258}
259
260func (d *Droidstubs) stubsFlags(ctx android.ModuleContext, cmd *android.RuleBuilderCommand, stubsDir android.OptionalPath) {
261 if apiCheckEnabled(ctx, d.properties.Check_api.Current, "current") ||
262 apiCheckEnabled(ctx, d.properties.Check_api.Last_released, "last_released") ||
263 String(d.properties.Api_filename) != "" {
264 filename := proptools.StringDefault(d.properties.Api_filename, ctx.ModuleName()+"_api.txt")
Colin Crosscb77f752021-03-24 12:04:44 -0700265 d.apiFile = android.PathForModuleOut(ctx, "metalava", filename)
Colin Cross2207f872021-03-24 12:39:08 -0700266 cmd.FlagWithOutput("--api ", d.apiFile)
267 d.apiFilePath = d.apiFile
268 } else if sourceApiFile := proptools.String(d.properties.Check_api.Current.Api_file); sourceApiFile != "" {
269 // If check api is disabled then make the source file available for export.
270 d.apiFilePath = android.PathForModuleSrc(ctx, sourceApiFile)
271 }
272
273 if apiCheckEnabled(ctx, d.properties.Check_api.Current, "current") ||
274 apiCheckEnabled(ctx, d.properties.Check_api.Last_released, "last_released") ||
275 String(d.properties.Removed_api_filename) != "" {
276 filename := proptools.StringDefault(d.properties.Removed_api_filename, ctx.ModuleName()+"_removed.txt")
Colin Crosscb77f752021-03-24 12:04:44 -0700277 d.removedApiFile = android.PathForModuleOut(ctx, "metalava", filename)
Colin Cross2207f872021-03-24 12:39:08 -0700278 cmd.FlagWithOutput("--removed-api ", d.removedApiFile)
279 d.removedApiFilePath = d.removedApiFile
280 } else if sourceRemovedApiFile := proptools.String(d.properties.Check_api.Current.Removed_api_file); sourceRemovedApiFile != "" {
281 // If check api is disabled then make the source removed api file available for export.
282 d.removedApiFilePath = android.PathForModuleSrc(ctx, sourceRemovedApiFile)
283 }
284
Colin Cross2207f872021-03-24 12:39:08 -0700285 if Bool(d.properties.Write_sdk_values) {
Colin Crosscb77f752021-03-24 12:04:44 -0700286 d.metadataDir = android.PathForModuleOut(ctx, "metalava", "metadata")
Colin Cross2207f872021-03-24 12:39:08 -0700287 cmd.FlagWithArg("--sdk-values ", d.metadataDir.String())
288 }
289
290 if stubsDir.Valid() {
291 if Bool(d.properties.Create_doc_stubs) {
292 cmd.FlagWithArg("--doc-stubs ", stubsDir.String())
293 } else {
294 cmd.FlagWithArg("--stubs ", stubsDir.String())
295 if !Bool(d.properties.Output_javadoc_comments) {
296 cmd.Flag("--exclude-documentation-from-stubs")
297 }
298 }
299 }
300}
301
302func (d *Droidstubs) annotationsFlags(ctx android.ModuleContext, cmd *android.RuleBuilderCommand) {
303 if Bool(d.properties.Annotations_enabled) {
304 cmd.Flag("--include-annotations")
305
Andrei Onea4985e512021-04-29 16:29:34 +0100306 cmd.FlagWithArg("--exclude-annotation ", "androidx.annotation.RequiresApi")
307
Colin Cross2207f872021-03-24 12:39:08 -0700308 validatingNullability :=
Colin Crossbc139922021-03-25 18:33:16 -0700309 strings.Contains(String(d.Javadoc.properties.Args), "--validate-nullability-from-merged-stubs") ||
Colin Cross2207f872021-03-24 12:39:08 -0700310 String(d.properties.Validate_nullability_from_list) != ""
311
312 migratingNullability := String(d.properties.Previous_api) != ""
313 if migratingNullability {
314 previousApi := android.PathForModuleSrc(ctx, String(d.properties.Previous_api))
315 cmd.FlagWithInput("--migrate-nullness ", previousApi)
316 }
317
318 if s := String(d.properties.Validate_nullability_from_list); s != "" {
319 cmd.FlagWithInput("--validate-nullability-from-list ", android.PathForModuleSrc(ctx, s))
320 }
321
322 if validatingNullability {
Colin Crosscb77f752021-03-24 12:04:44 -0700323 d.nullabilityWarningsFile = android.PathForModuleOut(ctx, "metalava", ctx.ModuleName()+"_nullability_warnings.txt")
Colin Cross2207f872021-03-24 12:39:08 -0700324 cmd.FlagWithOutput("--nullability-warnings-txt ", d.nullabilityWarningsFile)
325 }
326
Colin Crosscb77f752021-03-24 12:04:44 -0700327 d.annotationsZip = android.PathForModuleOut(ctx, "metalava", ctx.ModuleName()+"_annotations.zip")
Colin Cross2207f872021-03-24 12:39:08 -0700328 cmd.FlagWithOutput("--extract-annotations ", d.annotationsZip)
329
330 if len(d.properties.Merge_annotations_dirs) != 0 {
331 d.mergeAnnoDirFlags(ctx, cmd)
332 }
333
334 // TODO(tnorbye): find owners to fix these warnings when annotation was enabled.
335 cmd.FlagWithArg("--hide ", "HiddenTypedefConstant").
336 FlagWithArg("--hide ", "SuperfluousPrefix").
Sam Gilbert049af112022-03-04 16:03:53 -0500337 FlagWithArg("--hide ", "AnnotationExtraction").
338 // b/222738070
Sam Gilbert675f0b42022-03-08 11:24:44 -0500339 FlagWithArg("--hide ", "BannedThrow").
340 // b/223382732
341 FlagWithArg("--hide ", "ChangedDefault")
Colin Cross2207f872021-03-24 12:39:08 -0700342 }
343}
344
345func (d *Droidstubs) mergeAnnoDirFlags(ctx android.ModuleContext, cmd *android.RuleBuilderCommand) {
346 ctx.VisitDirectDepsWithTag(metalavaMergeAnnotationsDirTag, func(m android.Module) {
347 if t, ok := m.(*ExportedDroiddocDir); ok {
348 cmd.FlagWithArg("--merge-qualifier-annotations ", t.dir.String()).Implicits(t.deps)
349 } else {
350 ctx.PropertyErrorf("merge_annotations_dirs",
351 "module %q is not a metalava merge-annotations dir", ctx.OtherModuleName(m))
352 }
353 })
354}
355
356func (d *Droidstubs) inclusionAnnotationsFlags(ctx android.ModuleContext, cmd *android.RuleBuilderCommand) {
357 ctx.VisitDirectDepsWithTag(metalavaMergeInclusionAnnotationsDirTag, func(m android.Module) {
358 if t, ok := m.(*ExportedDroiddocDir); ok {
359 cmd.FlagWithArg("--merge-inclusion-annotations ", t.dir.String()).Implicits(t.deps)
360 } else {
361 ctx.PropertyErrorf("merge_inclusion_annotations_dirs",
362 "module %q is not a metalava merge-annotations dir", ctx.OtherModuleName(m))
363 }
364 })
365}
366
367func (d *Droidstubs) apiLevelsAnnotationsFlags(ctx android.ModuleContext, cmd *android.RuleBuilderCommand) {
368 if !Bool(d.properties.Api_levels_annotations_enabled) {
369 return
370 }
371
Colin Crosscb77f752021-03-24 12:04:44 -0700372 d.apiVersionsXml = android.PathForModuleOut(ctx, "metalava", "api-versions.xml")
Colin Cross2207f872021-03-24 12:39:08 -0700373
374 if len(d.properties.Api_levels_annotations_dirs) == 0 {
375 ctx.PropertyErrorf("api_levels_annotations_dirs",
376 "has to be non-empty if api levels annotations was enabled!")
377 }
378
379 cmd.FlagWithOutput("--generate-api-levels ", d.apiVersionsXml)
380 cmd.FlagWithInput("--apply-api-levels ", d.apiVersionsXml)
381 cmd.FlagWithArg("--current-version ", ctx.Config().PlatformSdkVersion().String())
382 cmd.FlagWithArg("--current-codename ", ctx.Config().PlatformSdkCodename())
383
384 filename := proptools.StringDefault(d.properties.Api_levels_jar_filename, "android.jar")
385
satayev783195c2021-06-23 21:49:57 +0100386 var dirs []string
Colin Cross2207f872021-03-24 12:39:08 -0700387 ctx.VisitDirectDepsWithTag(metalavaAPILevelsAnnotationsDirTag, func(m android.Module) {
388 if t, ok := m.(*ExportedDroiddocDir); ok {
389 for _, dep := range t.deps {
Colin Cross5f6ffc72021-03-29 21:54:45 -0700390 if dep.Base() == filename {
391 cmd.Implicit(dep)
392 }
393 if filename != "android.jar" && dep.Base() == "android.jar" {
394 // Metalava implicitly searches these patterns:
395 // prebuilts/tools/common/api-versions/android-%/android.jar
396 // prebuilts/sdk/%/public/android.jar
397 // Add android.jar files from the api_levels_annotations_dirs directories to try
398 // to satisfy these patterns. If Metalava can't find a match for an API level
399 // between 1 and 28 in at least one pattern it will fail.
Colin Cross2207f872021-03-24 12:39:08 -0700400 cmd.Implicit(dep)
401 }
402 }
satayev783195c2021-06-23 21:49:57 +0100403
404 dirs = append(dirs, t.dir.String())
Colin Cross2207f872021-03-24 12:39:08 -0700405 } else {
406 ctx.PropertyErrorf("api_levels_annotations_dirs",
407 "module %q is not a metalava api-levels-annotations dir", ctx.OtherModuleName(m))
408 }
409 })
satayev783195c2021-06-23 21:49:57 +0100410
411 // Add all relevant --android-jar-pattern patterns for Metalava.
412 // When parsing a stub jar for a specific version, Metalava picks the first pattern that defines
413 // an actual file present on disk (in the order the patterns were passed). For system APIs for
414 // privileged apps that are only defined since API level 21 (Lollipop), fallback to public stubs
Pedro Loureirocc203502021-10-04 17:24:00 +0000415 // for older releases. Similarly, module-lib falls back to system API.
416 var sdkDirs []string
417 switch proptools.StringDefault(d.properties.Api_levels_sdk_type, "public") {
418 case "module-lib":
419 sdkDirs = []string{"module-lib", "system", "public"}
420 case "system":
421 sdkDirs = []string{"system", "public"}
422 case "public":
423 sdkDirs = []string{"public"}
424 default:
425 ctx.PropertyErrorf("api_levels_sdk_type", "needs to be one of %v", allowedApiLevelSdkTypes)
426 return
satayev783195c2021-06-23 21:49:57 +0100427 }
Pedro Loureirocc203502021-10-04 17:24:00 +0000428
429 for _, sdkDir := range sdkDirs {
430 for _, dir := range dirs {
431 cmd.FlagWithArg("--android-jar-pattern ", fmt.Sprintf("%s/%%/%s/%s", dir, sdkDir, filename))
432 }
satayev783195c2021-06-23 21:49:57 +0100433 }
Colin Cross2207f872021-03-24 12:39:08 -0700434}
435
436func metalavaCmd(ctx android.ModuleContext, rule *android.RuleBuilder, javaVersion javaVersion, srcs android.Paths,
Anton Hansson556e8142021-06-04 16:20:25 +0100437 srcJarList android.Path, bootclasspath, classpath classpath, homeDir android.WritablePath) *android.RuleBuilderCommand {
Colin Cross2207f872021-03-24 12:39:08 -0700438 rule.Command().Text("rm -rf").Flag(homeDir.String())
439 rule.Command().Text("mkdir -p").Flag(homeDir.String())
440
Anton Hansson556e8142021-06-04 16:20:25 +0100441 cmd := rule.Command()
Colin Cross2207f872021-03-24 12:39:08 -0700442 cmd.FlagWithArg("ANDROID_PREFS_ROOT=", homeDir.String())
443
444 if ctx.Config().UseRBE() && ctx.Config().IsEnvTrue("RBE_METALAVA") {
445 rule.Remoteable(android.RemoteRuleSupports{RBE: true})
Colin Cross8095c292021-03-30 16:40:48 -0700446 execStrategy := ctx.Config().GetenvWithDefault("RBE_METALAVA_EXEC_STRATEGY", remoteexec.LocalExecStrategy)
447 labels := map[string]string{"type": "tool", "name": "metalava"}
448 // TODO: metalava pool rejects these jobs
449 pool := ctx.Config().GetenvWithDefault("RBE_METALAVA_POOL", "java16")
450 rule.Rewrapper(&remoteexec.REParams{
451 Labels: labels,
452 ExecStrategy: execStrategy,
453 ToolchainInputs: []string{config.JavaCmd(ctx).String()},
454 Platform: map[string]string{remoteexec.PoolKey: pool},
455 })
Colin Cross2207f872021-03-24 12:39:08 -0700456 }
457
Colin Cross6aa5c402021-03-24 12:28:50 -0700458 cmd.BuiltTool("metalava").ImplicitTool(ctx.Config().HostJavaToolPath(ctx, "metalava.jar")).
Colin Cross2207f872021-03-24 12:39:08 -0700459 Flag(config.JavacVmFlags).
460 Flag("-J--add-opens=java.base/java.util=ALL-UNNAMED").
461 FlagWithArg("-encoding ", "UTF-8").
462 FlagWithArg("-source ", javaVersion.String()).
463 FlagWithRspFileInputList("@", android.PathForModuleOut(ctx, "metalava.rsp"), srcs).
464 FlagWithInput("@", srcJarList)
465
Colin Cross2207f872021-03-24 12:39:08 -0700466 if len(bootclasspath) > 0 {
467 cmd.FlagWithInputList("-bootclasspath ", bootclasspath.Paths(), ":")
468 }
469
470 if len(classpath) > 0 {
471 cmd.FlagWithInputList("-classpath ", classpath.Paths(), ":")
472 }
473
Colin Cross2207f872021-03-24 12:39:08 -0700474 cmd.Flag("--no-banner").
475 Flag("--color").
476 Flag("--quiet").
477 Flag("--format=v2").
478 FlagWithArg("--repeat-errors-max ", "10").
Sam Gilbert09cb5db2021-10-06 11:28:28 -0400479 FlagWithArg("--hide ", "UnresolvedImport").
Sam Gilbert28e41282022-03-09 15:24:48 +0000480 FlagWithArg("--hide ", "InvalidNullability").
481 // b/223382732
482 FlagWithArg("--hide ", "ChangedDefault")
Colin Cross2207f872021-03-24 12:39:08 -0700483
484 return cmd
485}
486
487func (d *Droidstubs) GenerateAndroidBuildActions(ctx android.ModuleContext) {
488 deps := d.Javadoc.collectDeps(ctx)
489
Jiyong Parkf1691d22021-03-29 20:11:58 +0900490 javaVersion := getJavaVersion(ctx, String(d.Javadoc.properties.Java_version), android.SdkContext(d))
Colin Cross2207f872021-03-24 12:39:08 -0700491
492 // Create rule for metalava
493
Colin Crosscb77f752021-03-24 12:04:44 -0700494 srcJarDir := android.PathForModuleOut(ctx, "metalava", "srcjars")
Colin Cross2207f872021-03-24 12:39:08 -0700495
496 rule := android.NewRuleBuilder(pctx, ctx)
497
Colin Cross8095c292021-03-30 16:40:48 -0700498 rule.Sbox(android.PathForModuleOut(ctx, "metalava"),
499 android.PathForModuleOut(ctx, "metalava.sbox.textproto")).
500 SandboxInputs()
Colin Cross6aa5c402021-03-24 12:28:50 -0700501
Colin Cross2207f872021-03-24 12:39:08 -0700502 if BoolDefault(d.properties.High_mem, false) {
503 // This metalava run uses lots of memory, restrict the number of metalava jobs that can run in parallel.
504 rule.HighMem()
505 }
506
507 generateStubs := BoolDefault(d.properties.Generate_stubs, true)
508 var stubsDir android.OptionalPath
509 if generateStubs {
Colin Crosscb77f752021-03-24 12:04:44 -0700510 d.Javadoc.stubsSrcJar = android.PathForModuleOut(ctx, "metalava", ctx.ModuleName()+"-"+"stubs.srcjar")
511 stubsDir = android.OptionalPathForPath(android.PathForModuleOut(ctx, "metalava", "stubsDir"))
Colin Cross2207f872021-03-24 12:39:08 -0700512 rule.Command().Text("rm -rf").Text(stubsDir.String())
513 rule.Command().Text("mkdir -p").Text(stubsDir.String())
514 }
515
516 srcJarList := zipSyncCmd(ctx, rule, srcJarDir, d.Javadoc.srcJars)
517
Colin Crosscb77f752021-03-24 12:04:44 -0700518 homeDir := android.PathForModuleOut(ctx, "metalava", "home")
Colin Cross2207f872021-03-24 12:39:08 -0700519 cmd := metalavaCmd(ctx, rule, javaVersion, d.Javadoc.srcFiles, srcJarList,
Anton Hansson556e8142021-06-04 16:20:25 +0100520 deps.bootClasspath, deps.classpath, homeDir)
Colin Cross2207f872021-03-24 12:39:08 -0700521 cmd.Implicits(d.Javadoc.implicits)
522
523 d.stubsFlags(ctx, cmd, stubsDir)
524
525 d.annotationsFlags(ctx, cmd)
526 d.inclusionAnnotationsFlags(ctx, cmd)
527 d.apiLevelsAnnotationsFlags(ctx, cmd)
528
Colin Crossbc139922021-03-25 18:33:16 -0700529 d.expandArgs(ctx, cmd)
Colin Cross2207f872021-03-24 12:39:08 -0700530
Colin Cross2207f872021-03-24 12:39:08 -0700531 for _, o := range d.Javadoc.properties.Out {
532 cmd.ImplicitOutput(android.PathForModuleGen(ctx, o))
533 }
534
535 // Add options for the other optional tasks: API-lint and check-released.
536 // We generate separate timestamp files for them.
537
538 doApiLint := false
539 doCheckReleased := false
540
541 // Add API lint options.
542
543 if BoolDefault(d.properties.Check_api.Api_lint.Enabled, false) {
544 doApiLint = true
545
546 newSince := android.OptionalPathForModuleSrc(ctx, d.properties.Check_api.Api_lint.New_since)
547 if newSince.Valid() {
548 cmd.FlagWithInput("--api-lint ", newSince.Path())
549 } else {
550 cmd.Flag("--api-lint")
551 }
Colin Crosscb77f752021-03-24 12:04:44 -0700552 d.apiLintReport = android.PathForModuleOut(ctx, "metalava", "api_lint_report.txt")
Colin Cross2207f872021-03-24 12:39:08 -0700553 cmd.FlagWithOutput("--report-even-if-suppressed ", d.apiLintReport) // TODO: Change to ":api-lint"
554
Colin Cross0d532412021-03-25 09:38:45 -0700555 // TODO(b/154317059): Clean up this allowlist by baselining and/or checking in last-released.
Colin Cross2207f872021-03-24 12:39:08 -0700556 if d.Name() != "android.car-system-stubs-docs" &&
557 d.Name() != "android.car-stubs-docs" {
558 cmd.Flag("--lints-as-errors")
559 cmd.Flag("--warnings-as-errors") // Most lints are actually warnings.
560 }
561
562 baselineFile := android.OptionalPathForModuleSrc(ctx, d.properties.Check_api.Api_lint.Baseline_file)
Colin Crosscb77f752021-03-24 12:04:44 -0700563 updatedBaselineOutput := android.PathForModuleOut(ctx, "metalava", "api_lint_baseline.txt")
564 d.apiLintTimestamp = android.PathForModuleOut(ctx, "metalava", "api_lint.timestamp")
Colin Cross2207f872021-03-24 12:39:08 -0700565
566 // Note this string includes a special shell quote $' ... ', which decodes the "\n"s.
Colin Cross2207f872021-03-24 12:39:08 -0700567 //
568 // TODO: metalava also has a slightly different message hardcoded. Should we unify this
569 // message and metalava's one?
570 msg := `$'` + // Enclose with $' ... '
571 `************************************************************\n` +
572 `Your API changes are triggering API Lint warnings or errors.\n` +
573 `To make these errors go away, fix the code according to the\n` +
574 `error and/or warning messages above.\n` +
575 `\n` +
576 `If it is not possible to do so, there are workarounds:\n` +
577 `\n` +
Aurimas Liutikasb23b7452021-05-24 18:00:37 +0000578 `1. You can suppress the errors with @SuppressLint("<id>")\n` +
579 ` where the <id> is given in brackets in the error message above.\n`
Colin Cross2207f872021-03-24 12:39:08 -0700580
581 if baselineFile.Valid() {
582 cmd.FlagWithInput("--baseline:api-lint ", baselineFile.Path())
583 cmd.FlagWithOutput("--update-baseline:api-lint ", updatedBaselineOutput)
584
585 msg += fmt.Sprintf(``+
586 `2. You can update the baseline by executing the following\n`+
587 ` command:\n`+
Colin Cross63eeda02021-04-15 19:01:57 -0700588 ` (cd $ANDROID_BUILD_TOP && cp \\\n`+
589 ` "%s" \\\n`+
590 ` "%s")\n`+
Colin Cross2207f872021-03-24 12:39:08 -0700591 ` To submit the revised baseline.txt to the main Android\n`+
592 ` repository, you will need approval.\n`, updatedBaselineOutput, baselineFile.Path())
593 } else {
594 msg += fmt.Sprintf(``+
595 `2. You can add a baseline file of existing lint failures\n`+
596 ` to the build rule of %s.\n`, d.Name())
597 }
598 // Note the message ends with a ' (single quote), to close the $' ... ' .
599 msg += `************************************************************\n'`
600
601 cmd.FlagWithArg("--error-message:api-lint ", msg)
602 }
603
604 // Add "check released" options. (Detect incompatible API changes from the last public release)
605
606 if apiCheckEnabled(ctx, d.properties.Check_api.Last_released, "last_released") {
607 doCheckReleased = true
608
609 if len(d.Javadoc.properties.Out) > 0 {
610 ctx.PropertyErrorf("out", "out property may not be combined with check_api")
611 }
612
613 apiFile := android.PathForModuleSrc(ctx, String(d.properties.Check_api.Last_released.Api_file))
614 removedApiFile := android.PathForModuleSrc(ctx, String(d.properties.Check_api.Last_released.Removed_api_file))
615 baselineFile := android.OptionalPathForModuleSrc(ctx, d.properties.Check_api.Last_released.Baseline_file)
Colin Crosscb77f752021-03-24 12:04:44 -0700616 updatedBaselineOutput := android.PathForModuleOut(ctx, "metalava", "last_released_baseline.txt")
Colin Cross2207f872021-03-24 12:39:08 -0700617
Colin Crosscb77f752021-03-24 12:04:44 -0700618 d.checkLastReleasedApiTimestamp = android.PathForModuleOut(ctx, "metalava", "check_last_released_api.timestamp")
Colin Cross2207f872021-03-24 12:39:08 -0700619
620 cmd.FlagWithInput("--check-compatibility:api:released ", apiFile)
621 cmd.FlagWithInput("--check-compatibility:removed:released ", removedApiFile)
622
623 if baselineFile.Valid() {
624 cmd.FlagWithInput("--baseline:compatibility:released ", baselineFile.Path())
625 cmd.FlagWithOutput("--update-baseline:compatibility:released ", updatedBaselineOutput)
626 }
627
628 // Note this string includes quote ($' ... '), which decodes the "\n"s.
629 msg := `$'\n******************************\n` +
630 `You have tried to change the API from what has been previously released in\n` +
631 `an SDK. Please fix the errors listed above.\n` +
632 `******************************\n'`
633
634 cmd.FlagWithArg("--error-message:compatibility:released ", msg)
635 }
636
Colin Cross2207f872021-03-24 12:39:08 -0700637 if generateStubs {
638 rule.Command().
639 BuiltTool("soong_zip").
640 Flag("-write_if_changed").
641 Flag("-jar").
642 FlagWithOutput("-o ", d.Javadoc.stubsSrcJar).
643 FlagWithArg("-C ", stubsDir.String()).
644 FlagWithArg("-D ", stubsDir.String())
645 }
646
647 if Bool(d.properties.Write_sdk_values) {
Colin Crosscb77f752021-03-24 12:04:44 -0700648 d.metadataZip = android.PathForModuleOut(ctx, "metalava", ctx.ModuleName()+"-metadata.zip")
Colin Cross2207f872021-03-24 12:39:08 -0700649 rule.Command().
650 BuiltTool("soong_zip").
651 Flag("-write_if_changed").
652 Flag("-d").
653 FlagWithOutput("-o ", d.metadataZip).
654 FlagWithArg("-C ", d.metadataDir.String()).
655 FlagWithArg("-D ", d.metadataDir.String())
656 }
657
658 // TODO: We don't really need two separate API files, but this is a reminiscence of how
659 // we used to run metalava separately for API lint and the "last_released" check. Unify them.
660 if doApiLint {
661 rule.Command().Text("touch").Output(d.apiLintTimestamp)
662 }
663 if doCheckReleased {
664 rule.Command().Text("touch").Output(d.checkLastReleasedApiTimestamp)
665 }
666
Colin Cross6aa5c402021-03-24 12:28:50 -0700667 // TODO(b/183630617): rewrapper doesn't support restat rules
Colin Cross8095c292021-03-30 16:40:48 -0700668 // rule.Restat()
Colin Cross2207f872021-03-24 12:39:08 -0700669
670 zipSyncCleanupCmd(rule, srcJarDir)
671
672 rule.Build("metalava", "metalava merged")
673
674 if apiCheckEnabled(ctx, d.properties.Check_api.Current, "current") {
675
676 if len(d.Javadoc.properties.Out) > 0 {
677 ctx.PropertyErrorf("out", "out property may not be combined with check_api")
678 }
679
680 apiFile := android.PathForModuleSrc(ctx, String(d.properties.Check_api.Current.Api_file))
681 removedApiFile := android.PathForModuleSrc(ctx, String(d.properties.Check_api.Current.Removed_api_file))
682 baselineFile := android.OptionalPathForModuleSrc(ctx, d.properties.Check_api.Current.Baseline_file)
683
684 if baselineFile.Valid() {
685 ctx.PropertyErrorf("baseline_file", "current API check can't have a baseline file. (module %s)", ctx.ModuleName())
686 }
687
Colin Crosscb77f752021-03-24 12:04:44 -0700688 d.checkCurrentApiTimestamp = android.PathForModuleOut(ctx, "metalava", "check_current_api.timestamp")
Colin Cross2207f872021-03-24 12:39:08 -0700689
690 rule := android.NewRuleBuilder(pctx, ctx)
691
692 // Diff command line.
693 // -F matches the closest "opening" line, such as "package android {"
694 // and " public class Intent {".
695 diff := `diff -u -F '{ *$'`
696
697 rule.Command().Text("( true")
698 rule.Command().
699 Text(diff).
700 Input(apiFile).Input(d.apiFile)
701
702 rule.Command().
703 Text(diff).
704 Input(removedApiFile).Input(d.removedApiFile)
705
706 msg := fmt.Sprintf(`\n******************************\n`+
707 `You have tried to change the API from what has been previously approved.\n\n`+
708 `To make these errors go away, you have two choices:\n`+
709 ` 1. You can add '@hide' javadoc comments (and remove @SystemApi/@TestApi/etc)\n`+
710 ` to the new methods, etc. shown in the above diff.\n\n`+
711 ` 2. You can update current.txt and/or removed.txt by executing the following command:\n`+
712 ` m %s-update-current-api\n\n`+
713 ` To submit the revised current.txt to the main Android repository,\n`+
714 ` you will need approval.\n`+
715 `******************************\n`, ctx.ModuleName())
716
717 rule.Command().
718 Text("touch").Output(d.checkCurrentApiTimestamp).
719 Text(") || (").
720 Text("echo").Flag("-e").Flag(`"` + msg + `"`).
721 Text("; exit 38").
722 Text(")")
723
724 rule.Build("metalavaCurrentApiCheck", "check current API")
725
Colin Crosscb77f752021-03-24 12:04:44 -0700726 d.updateCurrentApiTimestamp = android.PathForModuleOut(ctx, "metalava", "update_current_api.timestamp")
Colin Cross2207f872021-03-24 12:39:08 -0700727
728 // update API rule
729 rule = android.NewRuleBuilder(pctx, ctx)
730
731 rule.Command().Text("( true")
732
733 rule.Command().
734 Text("cp").Flag("-f").
735 Input(d.apiFile).Flag(apiFile.String())
736
737 rule.Command().
738 Text("cp").Flag("-f").
739 Input(d.removedApiFile).Flag(removedApiFile.String())
740
741 msg = "failed to update public API"
742
743 rule.Command().
744 Text("touch").Output(d.updateCurrentApiTimestamp).
745 Text(") || (").
746 Text("echo").Flag("-e").Flag(`"` + msg + `"`).
747 Text("; exit 38").
748 Text(")")
749
750 rule.Build("metalavaCurrentApiUpdate", "update current API")
751 }
752
753 if String(d.properties.Check_nullability_warnings) != "" {
754 if d.nullabilityWarningsFile == nil {
755 ctx.PropertyErrorf("check_nullability_warnings",
756 "Cannot specify check_nullability_warnings unless validating nullability")
757 }
758
759 checkNullabilityWarnings := android.PathForModuleSrc(ctx, String(d.properties.Check_nullability_warnings))
760
Colin Crosscb77f752021-03-24 12:04:44 -0700761 d.checkNullabilityWarningsTimestamp = android.PathForModuleOut(ctx, "metalava", "check_nullability_warnings.timestamp")
Colin Cross2207f872021-03-24 12:39:08 -0700762
763 msg := fmt.Sprintf(`\n******************************\n`+
764 `The warnings encountered during nullability annotation validation did\n`+
765 `not match the checked in file of expected warnings. The diffs are shown\n`+
766 `above. You have two options:\n`+
767 ` 1. Resolve the differences by editing the nullability annotations.\n`+
768 ` 2. Update the file of expected warnings by running:\n`+
769 ` cp %s %s\n`+
770 ` and submitting the updated file as part of your change.`,
771 d.nullabilityWarningsFile, checkNullabilityWarnings)
772
773 rule := android.NewRuleBuilder(pctx, ctx)
774
775 rule.Command().
776 Text("(").
777 Text("diff").Input(checkNullabilityWarnings).Input(d.nullabilityWarningsFile).
778 Text("&&").
779 Text("touch").Output(d.checkNullabilityWarningsTimestamp).
780 Text(") || (").
781 Text("echo").Flag("-e").Flag(`"` + msg + `"`).
782 Text("; exit 38").
783 Text(")")
784
785 rule.Build("nullabilityWarningsCheck", "nullability warnings check")
786 }
787}
788
789func StubsDefaultsFactory() android.Module {
790 module := &DocDefaults{}
791
792 module.AddProperties(
793 &JavadocProperties{},
794 &DroidstubsProperties{},
795 )
796
797 android.InitDefaultsModule(module)
798
799 return module
800}
801
802var _ android.PrebuiltInterface = (*PrebuiltStubsSources)(nil)
803
804type PrebuiltStubsSourcesProperties struct {
805 Srcs []string `android:"path"`
806}
807
808type PrebuiltStubsSources struct {
809 android.ModuleBase
810 android.DefaultableModuleBase
811 prebuilt android.Prebuilt
812 android.SdkBase
813
814 properties PrebuiltStubsSourcesProperties
815
kgui67007242022-01-25 13:50:25 +0800816 stubsSrcJar android.Path
Colin Cross2207f872021-03-24 12:39:08 -0700817}
818
819func (p *PrebuiltStubsSources) OutputFiles(tag string) (android.Paths, error) {
820 switch tag {
821 case "":
822 return android.Paths{p.stubsSrcJar}, nil
823 default:
824 return nil, fmt.Errorf("unsupported module reference tag %q", tag)
825 }
826}
827
828func (d *PrebuiltStubsSources) StubsSrcJar() android.Path {
829 return d.stubsSrcJar
830}
831
832func (p *PrebuiltStubsSources) GenerateAndroidBuildActions(ctx android.ModuleContext) {
Colin Cross2207f872021-03-24 12:39:08 -0700833 if len(p.properties.Srcs) != 1 {
Anton Hansson86758ac2021-11-03 14:44:12 +0000834 ctx.PropertyErrorf("srcs", "must only specify one directory path or srcjar, contains %d paths", len(p.properties.Srcs))
Colin Cross2207f872021-03-24 12:39:08 -0700835 return
836 }
837
Anton Hansson86758ac2021-11-03 14:44:12 +0000838 src := p.properties.Srcs[0]
839 if filepath.Ext(src) == ".srcjar" {
840 // This is a srcjar. We can use it directly.
841 p.stubsSrcJar = android.PathForModuleSrc(ctx, src)
842 } else {
843 outPath := android.PathForModuleOut(ctx, ctx.ModuleName()+"-"+"stubs.srcjar")
Colin Cross2207f872021-03-24 12:39:08 -0700844
Anton Hansson86758ac2021-11-03 14:44:12 +0000845 // This is a directory. Glob the contents just in case the directory does not exist.
846 srcGlob := src + "/**/*"
847 srcPaths := android.PathsForModuleSrc(ctx, []string{srcGlob})
Colin Cross2207f872021-03-24 12:39:08 -0700848
Anton Hansson86758ac2021-11-03 14:44:12 +0000849 // Although PathForModuleSrc can return nil if either the path doesn't exist or
850 // the path components are invalid it won't in this case because no components
851 // are specified and the module directory must exist in order to get this far.
852 srcDir := android.PathForModuleSrc(ctx).(android.SourcePath).Join(ctx, src)
Colin Cross2207f872021-03-24 12:39:08 -0700853
Anton Hansson86758ac2021-11-03 14:44:12 +0000854 rule := android.NewRuleBuilder(pctx, ctx)
855 rule.Command().
856 BuiltTool("soong_zip").
857 Flag("-write_if_changed").
858 Flag("-jar").
859 FlagWithOutput("-o ", outPath).
860 FlagWithArg("-C ", srcDir.String()).
861 FlagWithRspFileInputList("-r ", outPath.ReplaceExtension(ctx, "rsp"), srcPaths)
862 rule.Restat()
863 rule.Build("zip src", "Create srcjar from prebuilt source")
864 p.stubsSrcJar = outPath
865 }
Colin Cross2207f872021-03-24 12:39:08 -0700866}
867
868func (p *PrebuiltStubsSources) Prebuilt() *android.Prebuilt {
869 return &p.prebuilt
870}
871
872func (p *PrebuiltStubsSources) Name() string {
873 return p.prebuilt.Name(p.ModuleBase.Name())
874}
875
876// prebuilt_stubs_sources imports a set of java source files as if they were
877// generated by droidstubs.
878//
879// By default, a prebuilt_stubs_sources has a single variant that expects a
880// set of `.java` files generated by droidstubs.
881//
882// Specifying `host_supported: true` will produce two variants, one for use as a dependency of device modules and one
883// for host modules.
884//
885// Intended only for use by sdk snapshots.
886func PrebuiltStubsSourcesFactory() android.Module {
887 module := &PrebuiltStubsSources{}
888
889 module.AddProperties(&module.properties)
890
891 android.InitPrebuiltModule(module, &module.properties.Srcs)
892 android.InitSdkAwareModule(module)
893 InitDroiddocModule(module, android.HostAndDeviceSupported)
894 return module
895}