blob: 93d4b4c547231898e8c25c3471989d4fb0886aeb [file] [log] [blame]
Colin Cross16b23492016-01-06 14:41:07 -08001// Copyright 2016 Google Inc. All rights reserved.
2//
3// Licensed under the Apache License, Version 2.0 (the "License");
4// you may not use this file except in compliance with the License.
5// You may obtain a copy of the License at
6//
7// http://www.apache.org/licenses/LICENSE-2.0
8//
9// Unless required by applicable law or agreed to in writing, software
10// distributed under the License is distributed on an "AS IS" BASIS,
11// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
12// See the License for the specific language governing permissions and
13// limitations under the License.
14
15package cc
16
17import (
18 "fmt"
Jeff Gaston72765392017-11-28 16:37:53 -080019 "sort"
Colin Cross16b23492016-01-06 14:41:07 -080020 "strings"
Vishwath Mohane7128792017-11-17 11:08:10 -080021 "sync"
Colin Cross16b23492016-01-06 14:41:07 -080022
Colin Cross6b753602018-06-21 13:03:07 -070023 "github.com/google/blueprint"
Liz Kammerb2fc4702021-06-25 14:53:40 -040024 "github.com/google/blueprint/proptools"
Colin Cross6b753602018-06-21 13:03:07 -070025
Colin Cross635c3b02016-05-18 15:37:25 -070026 "android/soong/android"
Evgenii Stepanovaf36db12016-08-15 14:18:24 -070027 "android/soong/cc/config"
Kiyoung Kim48f37782021-07-07 12:42:39 +090028 "android/soong/snapshot"
Colin Cross16b23492016-01-06 14:41:07 -080029)
30
Jayant Chowdhary9677e8c2017-06-15 14:45:18 -070031var (
32 // Any C flags added by sanitizer which libTooling tools may not
33 // understand also need to be added to ClangLibToolingUnknownCflags in
34 // cc/config/clang.go
Vishwath Mohanf3918d32017-02-14 07:59:33 -080035
Yi Kong20233a42019-08-21 01:38:40 -070036 asanCflags = []string{
37 "-fno-omit-frame-pointer",
38 "-fno-experimental-new-pass-manager",
39 }
Jayant Chowdhary9677e8c2017-06-15 14:45:18 -070040 asanLdflags = []string{"-Wl,-u,__asan_preinit"}
Jayant Chowdhary9677e8c2017-06-15 14:45:18 -070041
Yi Kong286abc62021-11-04 16:14:14 +080042 hwasanCflags = []string{
43 "-fno-omit-frame-pointer",
44 "-Wno-frame-larger-than=",
Evgenii Stepanov96fa3dd2020-03-27 19:38:42 +000045 "-fsanitize-hwaddress-abi=platform",
Yi Kong286abc62021-11-04 16:14:14 +080046 }
47
48 // ThinLTO performs codegen during link time, thus these flags need to
49 // passed to both CFLAGS and LDFLAGS.
50 hwasanCommonflags = []string{
Evgenii Stepanov64bee4d2019-11-22 18:37:10 -080051 // The following improves debug location information
52 // availability at the cost of its accuracy. It increases
53 // the likelihood of a stack variable's frame offset
54 // to be recorded in the debug info, which is important
55 // for the quality of hwasan reports. The downside is a
56 // higher number of "optimized out" stack variables.
57 // b/112437883.
Yi Kong286abc62021-11-04 16:14:14 +080058 "-instcombine-lower-dbg-declare=0",
Mitch Phillipsb1c574f2020-06-22 13:28:23 -070059 // TODO(b/159343917): HWASan and GlobalISel don't play nicely, and
60 // GlobalISel is the default at -O0 on aarch64.
Yi Kong286abc62021-11-04 16:14:14 +080061 "--aarch64-enable-global-isel-at-O=-1",
62 "-fast-isel=false",
Evgenii Stepanov64bee4d2019-11-22 18:37:10 -080063 }
Evgenii Stepanovd97a6e92018-08-02 16:19:13 -070064
Vishwath Mohanb743e9c2017-11-01 09:20:21 +000065 cfiCflags = []string{"-flto", "-fsanitize-cfi-cross-dso",
Pirama Arumuga Nainar582fc2d2021-08-27 15:12:56 -070066 "-fsanitize-ignorelist=external/compiler-rt/lib/cfi/cfi_blocklist.txt"}
Evgenii Stepanovdbf1d4f2018-08-31 12:54:33 -070067 // -flto and -fvisibility are required by clang when -fsanitize=cfi is
68 // used, but have no effect on assembly files
69 cfiAsflags = []string{"-flto", "-fvisibility=default"}
Jayant Chowdhary9677e8c2017-06-15 14:45:18 -070070 cfiLdflags = []string{"-flto", "-fsanitize-cfi-cross-dso", "-fsanitize=cfi",
Pirama Arumuga Nainarbdb17f02017-08-28 21:50:17 -070071 "-Wl,-plugin-opt,O1"}
Inseob Kim74d25562020-08-04 00:41:38 +090072 cfiExportsMapPath = "build/soong/cc/config/cfi_exports.map"
Ivan Lozano0c3a1ef2017-06-28 09:10:48 -070073
Pirama Arumuga Nainar582fc2d2021-08-27 15:12:56 -070074 intOverflowCflags = []string{"-fsanitize-ignorelist=build/soong/cc/config/integer_overflow_blocklist.txt"}
Peter Collingbourne8c7e6e22018-11-19 16:03:58 -080075
Peter Collingbournebd19db02019-03-06 10:38:48 -080076 minimalRuntimeFlags = []string{"-fsanitize-minimal-runtime", "-fno-sanitize-trap=integer,undefined",
Ivan Lozanoae6ae1d2018-10-08 09:29:39 -070077 "-fno-sanitize-recover=integer,undefined"}
Evgenii Stepanov2c6484e2019-05-15 12:49:54 -070078 hwasanGlobalOptions = []string{"heap_history_size=1023", "stack_history_size=512",
79 "export_memory_stats=0", "max_malloc_fill_size=0"}
Dan Willemsencbceaab2016-10-13 16:44:07 -070080)
81
Ivan Lozano3968d8f2020-12-14 11:27:52 -050082type SanitizerType int
Colin Cross16b23492016-01-06 14:41:07 -080083
Colin Cross16b23492016-01-06 14:41:07 -080084const (
Ivan Lozano3968d8f2020-12-14 11:27:52 -050085 Asan SanitizerType = iota + 1
Tri Vo6eafc362021-04-01 11:29:09 -070086 Hwasan
Colin Cross16b23492016-01-06 14:41:07 -080087 tsan
Ivan Lozano0c3a1ef2017-06-28 09:10:48 -070088 intOverflow
Peter Collingbourne8c7e6e22018-11-19 16:03:58 -080089 scs
Ivan Lozano3968d8f2020-12-14 11:27:52 -050090 Fuzzer
Ivan Lozano62cd0382021-11-01 10:27:54 -040091 Memtag_heap
Liz Kammer75db9312021-07-07 16:41:50 -040092 cfi // cfi is last to prevent it running before incompatible mutators
Colin Cross16b23492016-01-06 14:41:07 -080093)
94
Liz Kammer75db9312021-07-07 16:41:50 -040095var Sanitizers = []SanitizerType{
96 Asan,
97 Hwasan,
98 tsan,
99 intOverflow,
100 scs,
101 Fuzzer,
Ivan Lozano62cd0382021-11-01 10:27:54 -0400102 Memtag_heap,
Liz Kammer75db9312021-07-07 16:41:50 -0400103 cfi, // cfi is last to prevent it running before incompatible mutators
104}
105
Jiyong Park82226632019-02-01 10:50:50 +0900106// Name of the sanitizer variation for this sanitizer type
Ivan Lozano3968d8f2020-12-14 11:27:52 -0500107func (t SanitizerType) variationName() string {
Colin Cross16b23492016-01-06 14:41:07 -0800108 switch t {
Ivan Lozano3968d8f2020-12-14 11:27:52 -0500109 case Asan:
Colin Cross16b23492016-01-06 14:41:07 -0800110 return "asan"
Tri Vo6eafc362021-04-01 11:29:09 -0700111 case Hwasan:
Evgenii Stepanovd97a6e92018-08-02 16:19:13 -0700112 return "hwasan"
Colin Cross16b23492016-01-06 14:41:07 -0800113 case tsan:
114 return "tsan"
Ivan Lozano0c3a1ef2017-06-28 09:10:48 -0700115 case intOverflow:
116 return "intOverflow"
Vishwath Mohanb743e9c2017-11-01 09:20:21 +0000117 case cfi:
118 return "cfi"
Peter Collingbourne8c7e6e22018-11-19 16:03:58 -0800119 case scs:
120 return "scs"
Ivan Lozano62cd0382021-11-01 10:27:54 -0400121 case Memtag_heap:
Evgenii Stepanov193ac2e2020-04-28 15:09:12 -0700122 return "memtag_heap"
Ivan Lozano3968d8f2020-12-14 11:27:52 -0500123 case Fuzzer:
Mitch Phillips5a6ea6c2019-05-01 14:42:05 -0700124 return "fuzzer"
Colin Cross16b23492016-01-06 14:41:07 -0800125 default:
Ivan Lozano3968d8f2020-12-14 11:27:52 -0500126 panic(fmt.Errorf("unknown SanitizerType %d", t))
Colin Cross16b23492016-01-06 14:41:07 -0800127 }
128}
129
Jiyong Park82226632019-02-01 10:50:50 +0900130// This is the sanitizer names in SANITIZE_[TARGET|HOST]
Ivan Lozano3968d8f2020-12-14 11:27:52 -0500131func (t SanitizerType) name() string {
Jiyong Park82226632019-02-01 10:50:50 +0900132 switch t {
Ivan Lozano3968d8f2020-12-14 11:27:52 -0500133 case Asan:
Jiyong Park82226632019-02-01 10:50:50 +0900134 return "address"
Tri Vo6eafc362021-04-01 11:29:09 -0700135 case Hwasan:
Jiyong Park82226632019-02-01 10:50:50 +0900136 return "hwaddress"
Ivan Lozano62cd0382021-11-01 10:27:54 -0400137 case Memtag_heap:
Evgenii Stepanov193ac2e2020-04-28 15:09:12 -0700138 return "memtag_heap"
Jiyong Park82226632019-02-01 10:50:50 +0900139 case tsan:
140 return "thread"
141 case intOverflow:
142 return "integer_overflow"
143 case cfi:
144 return "cfi"
145 case scs:
146 return "shadow-call-stack"
Ivan Lozano3968d8f2020-12-14 11:27:52 -0500147 case Fuzzer:
Mitch Phillips5a6ea6c2019-05-01 14:42:05 -0700148 return "fuzzer"
Jiyong Park82226632019-02-01 10:50:50 +0900149 default:
Ivan Lozano3968d8f2020-12-14 11:27:52 -0500150 panic(fmt.Errorf("unknown SanitizerType %d", t))
Jiyong Park82226632019-02-01 10:50:50 +0900151 }
152}
153
Liz Kammer75db9312021-07-07 16:41:50 -0400154func (t SanitizerType) registerMutators(ctx android.RegisterMutatorsContext) {
155 switch t {
156 case Asan, Hwasan, Fuzzer, scs, tsan, cfi:
157 ctx.TopDown(t.variationName()+"_deps", sanitizerDepsMutator(t))
158 ctx.BottomUp(t.variationName(), sanitizerMutator(t))
Ivan Lozano62cd0382021-11-01 10:27:54 -0400159 case Memtag_heap, intOverflow:
Liz Kammer75db9312021-07-07 16:41:50 -0400160 // do nothing
161 default:
162 panic(fmt.Errorf("unknown SanitizerType %d", t))
163 }
164}
165
Ivan Lozano3968d8f2020-12-14 11:27:52 -0500166func (*Module) SanitizerSupported(t SanitizerType) bool {
167 switch t {
168 case Asan:
169 return true
Tri Vo6eafc362021-04-01 11:29:09 -0700170 case Hwasan:
Ivan Lozano3968d8f2020-12-14 11:27:52 -0500171 return true
172 case tsan:
173 return true
174 case intOverflow:
175 return true
176 case cfi:
177 return true
178 case scs:
179 return true
180 case Fuzzer:
181 return true
Ivan Lozano62cd0382021-11-01 10:27:54 -0400182 case Memtag_heap:
183 return true
Ivan Lozano3968d8f2020-12-14 11:27:52 -0500184 default:
185 return false
186 }
187}
188
189// incompatibleWithCfi returns true if a sanitizer is incompatible with CFI.
190func (t SanitizerType) incompatibleWithCfi() bool {
Tri Vo6eafc362021-04-01 11:29:09 -0700191 return t == Asan || t == Fuzzer || t == Hwasan
Jiyong Park1d1119f2019-07-29 21:27:18 +0900192}
193
Martin Stjernholmb0249572020-09-15 02:32:35 +0100194type SanitizeUserProps struct {
Liz Kammer75b9b402021-06-25 15:19:27 -0400195 // Prevent use of any sanitizers on this module
Martin Stjernholmb0249572020-09-15 02:32:35 +0100196 Never *bool `android:"arch_variant"`
Colin Cross16b23492016-01-06 14:41:07 -0800197
Liz Kammer75b9b402021-06-25 15:19:27 -0400198 // ASan (Address sanitizer), incompatible with static binaries.
199 // Always runs in a diagnostic mode.
200 // Use of address sanitizer disables cfi sanitizer.
201 // Hwaddress sanitizer takes precedence over this sanitizer.
202 Address *bool `android:"arch_variant"`
203 // TSan (Thread sanitizer), incompatible with static binaries and 32 bit architectures.
204 // Always runs in a diagnostic mode.
205 // Use of thread sanitizer disables cfi and scudo sanitizers.
206 // Hwaddress sanitizer takes precedence over this sanitizer.
207 Thread *bool `android:"arch_variant"`
208 // HWASan (Hardware Address sanitizer).
209 // Use of hwasan sanitizer disables cfi, address, thread, and scudo sanitizers.
Martin Stjernholmb0249572020-09-15 02:32:35 +0100210 Hwaddress *bool `android:"arch_variant"`
Colin Cross16b23492016-01-06 14:41:07 -0800211
Liz Kammer75b9b402021-06-25 15:19:27 -0400212 // Undefined behavior sanitizer
213 All_undefined *bool `android:"arch_variant"`
214 // Subset of undefined behavior sanitizer
215 Undefined *bool `android:"arch_variant"`
216 // List of specific undefined behavior sanitizers to enable
217 Misc_undefined []string `android:"arch_variant"`
218 // Fuzzer, incompatible with static binaries.
219 Fuzzer *bool `android:"arch_variant"`
220 // safe-stack sanitizer, incompatible with 32-bit architectures.
221 Safestack *bool `android:"arch_variant"`
222 // cfi sanitizer, incompatible with asan, hwasan, fuzzer, or Darwin
223 Cfi *bool `android:"arch_variant"`
224 // signed/unsigned integer overflow sanitizer, incompatible with Darwin.
225 Integer_overflow *bool `android:"arch_variant"`
226 // scudo sanitizer, incompatible with asan, hwasan, tsan
227 // This should not be used in Android 11+ : https://source.android.com/devices/tech/debug/scudo
228 // deprecated
229 Scudo *bool `android:"arch_variant"`
230 // shadow-call-stack sanitizer, only available on arm64
231 Scs *bool `android:"arch_variant"`
232 // Memory-tagging, only available on arm64
233 // if diag.memtag unset or false, enables async memory tagging
234 Memtag_heap *bool `android:"arch_variant"`
Martin Stjernholmb0249572020-09-15 02:32:35 +0100235
236 // A modifier for ASAN and HWASAN for write only instrumentation
237 Writeonly *bool `android:"arch_variant"`
238
239 // Sanitizers to run in the diagnostic mode (as opposed to the release mode).
240 // Replaces abort() on error with a human-readable error message.
241 // Address and Thread sanitizers always run in diagnostic mode.
242 Diag struct {
Liz Kammer75b9b402021-06-25 15:19:27 -0400243 // Undefined behavior sanitizer, diagnostic mode
244 Undefined *bool `android:"arch_variant"`
245 // cfi sanitizer, diagnostic mode, incompatible with asan, hwasan, fuzzer, or Darwin
246 Cfi *bool `android:"arch_variant"`
247 // signed/unsigned integer overflow sanitizer, diagnostic mode, incompatible with Darwin.
248 Integer_overflow *bool `android:"arch_variant"`
249 // Memory-tagging, only available on arm64
250 // requires sanitizer.memtag: true
251 // if set, enables sync memory tagging
252 Memtag_heap *bool `android:"arch_variant"`
253 // List of specific undefined behavior sanitizers to enable in diagnostic mode
254 Misc_undefined []string `android:"arch_variant"`
255 // List of sanitizers to pass to -fno-sanitize-recover
256 // results in only the first detected error for these sanitizers being reported and program then
257 // exits with a non-zero exit code.
258 No_recover []string `android:"arch_variant"`
Cindy Zhoud3fe4922020-12-01 11:14:30 -0800259 } `android:"arch_variant"`
Colin Cross16b23492016-01-06 14:41:07 -0800260
Cindy Zhou8cd45de2020-11-16 08:41:00 -0800261 // Sanitizers to run with flag configuration specified
262 Config struct {
263 // Enables CFI support flags for assembly-heavy libraries
264 Cfi_assembly_support *bool `android:"arch_variant"`
Cindy Zhoud3fe4922020-12-01 11:14:30 -0800265 } `android:"arch_variant"`
Cindy Zhou8cd45de2020-11-16 08:41:00 -0800266
Liz Kammer75b9b402021-06-25 15:19:27 -0400267 // List of sanitizers to pass to -fsanitize-recover
268 // allows execution to continue for these sanitizers to detect multiple errors rather than only
269 // the first one
Martin Stjernholmb0249572020-09-15 02:32:35 +0100270 Recover []string
Jasraj Bedibb4511d2020-07-23 22:58:17 +0000271
Pirama Arumuga Nainar582fc2d2021-08-27 15:12:56 -0700272 // value to pass to -fsanitize-ignorelist
Martin Stjernholmb0249572020-09-15 02:32:35 +0100273 Blocklist *string
274}
Evgenii Stepanov1e405e12016-08-16 15:39:54 -0700275
Martin Stjernholmb0249572020-09-15 02:32:35 +0100276type SanitizeProperties struct {
Martin Stjernholmb0249572020-09-15 02:32:35 +0100277 Sanitize SanitizeUserProps `android:"arch_variant"`
278 SanitizerEnabled bool `blueprint:"mutated"`
279 SanitizeDep bool `blueprint:"mutated"`
280 MinimalRuntimeDep bool `blueprint:"mutated"`
281 BuiltinsDep bool `blueprint:"mutated"`
282 UbsanRuntimeDep bool `blueprint:"mutated"`
283 InSanitizerDir bool `blueprint:"mutated"`
284 Sanitizers []string `blueprint:"mutated"`
285 DiagSanitizers []string `blueprint:"mutated"`
Colin Cross16b23492016-01-06 14:41:07 -0800286}
287
288type sanitize struct {
289 Properties SanitizeProperties
290}
291
Cindy Zhou18417cb2020-12-10 07:12:38 -0800292// Mark this tag with a check to see if apex dependency check should be skipped
293func (t libraryDependencyTag) SkipApexAllowedDependenciesCheck() bool {
294 return t.skipApexAllowedDependenciesCheck
295}
296
297var _ android.SkipApexAllowedDependenciesCheck = (*libraryDependencyTag)(nil)
298
Vishwath Mohane7128792017-11-17 11:08:10 -0800299func init() {
300 android.RegisterMakeVarsProvider(pctx, cfiMakeVarsProvider)
Evgenii Stepanovd97a6e92018-08-02 16:19:13 -0700301 android.RegisterMakeVarsProvider(pctx, hwasanMakeVarsProvider)
Vishwath Mohane7128792017-11-17 11:08:10 -0800302}
303
Colin Cross16b23492016-01-06 14:41:07 -0800304func (sanitize *sanitize) props() []interface{} {
305 return []interface{}{&sanitize.Properties}
306}
307
308func (sanitize *sanitize) begin(ctx BaseModuleContext) {
Evgenii Stepanovfcfe56d2016-07-07 10:54:07 -0700309 s := &sanitize.Properties.Sanitize
310
Colin Cross16b23492016-01-06 14:41:07 -0800311 // Don't apply sanitizers to NDK code.
Jeff Gastonaf3cc2d2017-09-27 17:01:44 -0700312 if ctx.useSdk() {
Nan Zhang0007d812017-11-07 10:57:05 -0800313 s.Never = BoolPtr(true)
Colin Cross16b23492016-01-06 14:41:07 -0800314 }
315
316 // Never always wins.
Nan Zhang0007d812017-11-07 10:57:05 -0800317 if Bool(s.Never) {
Colin Cross16b23492016-01-06 14:41:07 -0800318 return
319 }
320
Evgenii Stepanov04896ca2021-01-12 18:28:33 -0800321 // cc_test targets default to SYNC MemTag unless explicitly set to ASYNC (via diag: {memtag_heap}).
Liz Kammer7b920b42021-06-22 16:57:27 -0400322 if ctx.testBinary() {
323 if s.Memtag_heap == nil {
324 s.Memtag_heap = proptools.BoolPtr(true)
325 }
326 if s.Diag.Memtag_heap == nil {
327 s.Diag.Memtag_heap = proptools.BoolPtr(true)
328 }
Evgenii Stepanov04896ca2021-01-12 18:28:33 -0800329 }
330
Colin Cross16b23492016-01-06 14:41:07 -0800331 var globalSanitizers []string
Ivan Lozano0c3a1ef2017-06-28 09:10:48 -0700332 var globalSanitizersDiag []string
333
Dan Willemsen8536d6b2018-10-07 20:54:34 -0700334 if ctx.Host() {
335 if !ctx.Windows() {
336 globalSanitizers = ctx.Config().SanitizeHost()
337 }
338 } else {
339 arches := ctx.Config().SanitizeDeviceArch()
340 if len(arches) == 0 || inList(ctx.Arch().ArchType.Name, arches) {
341 globalSanitizers = ctx.Config().SanitizeDevice()
342 globalSanitizersDiag = ctx.Config().SanitizeDeviceDiag()
Colin Cross16b23492016-01-06 14:41:07 -0800343 }
344 }
345
Colin Cross16b23492016-01-06 14:41:07 -0800346 if len(globalSanitizers) > 0 {
Evgenii Stepanov05bafd32016-07-07 17:38:41 +0000347 var found bool
Evgenii Stepanovfcfe56d2016-07-07 10:54:07 -0700348 if found, globalSanitizers = removeFromList("undefined", globalSanitizers); found && s.All_undefined == nil {
Liz Kammerb2fc4702021-06-25 14:53:40 -0400349 s.All_undefined = proptools.BoolPtr(true)
Evgenii Stepanov05bafd32016-07-07 17:38:41 +0000350 }
Colin Cross16b23492016-01-06 14:41:07 -0800351
Evgenii Stepanovfcfe56d2016-07-07 10:54:07 -0700352 if found, globalSanitizers = removeFromList("default-ub", globalSanitizers); found && s.Undefined == nil {
Liz Kammerb2fc4702021-06-25 14:53:40 -0400353 s.Undefined = proptools.BoolPtr(true)
Evgenii Stepanov05bafd32016-07-07 17:38:41 +0000354 }
355
Mitch Phillips5a6ea6c2019-05-01 14:42:05 -0700356 if found, globalSanitizers = removeFromList("address", globalSanitizers); found && s.Address == nil {
Liz Kammerb2fc4702021-06-25 14:53:40 -0400357 s.Address = proptools.BoolPtr(true)
Evgenii Stepanov05bafd32016-07-07 17:38:41 +0000358 }
359
Evgenii Stepanovfcfe56d2016-07-07 10:54:07 -0700360 if found, globalSanitizers = removeFromList("thread", globalSanitizers); found && s.Thread == nil {
Liz Kammerb2fc4702021-06-25 14:53:40 -0400361 s.Thread = proptools.BoolPtr(true)
Evgenii Stepanov05bafd32016-07-07 17:38:41 +0000362 }
363
Mitch Phillips5a6ea6c2019-05-01 14:42:05 -0700364 if found, globalSanitizers = removeFromList("fuzzer", globalSanitizers); found && s.Fuzzer == nil {
Liz Kammerb2fc4702021-06-25 14:53:40 -0400365 s.Fuzzer = proptools.BoolPtr(true)
Evgenii Stepanovfcfe56d2016-07-07 10:54:07 -0700366 }
367
368 if found, globalSanitizers = removeFromList("safe-stack", globalSanitizers); found && s.Safestack == nil {
Liz Kammerb2fc4702021-06-25 14:53:40 -0400369 s.Safestack = proptools.BoolPtr(true)
Evgenii Stepanov05bafd32016-07-07 17:38:41 +0000370 }
371
Evgenii Stepanov1e405e12016-08-16 15:39:54 -0700372 if found, globalSanitizers = removeFromList("cfi", globalSanitizers); found && s.Cfi == nil {
Colin Cross6510f912017-11-29 00:27:14 -0800373 if !ctx.Config().CFIDisabledForPath(ctx.ModuleDir()) {
Liz Kammerb2fc4702021-06-25 14:53:40 -0400374 s.Cfi = proptools.BoolPtr(true)
Vishwath Mohan1fa3ac52017-10-31 02:26:14 -0700375 }
Evgenii Stepanov1e405e12016-08-16 15:39:54 -0700376 }
377
Ivan Lozanoa9255a82018-03-13 10:41:07 -0700378 // Global integer_overflow builds do not support static libraries.
Ivan Lozano0c3a1ef2017-06-28 09:10:48 -0700379 if found, globalSanitizers = removeFromList("integer_overflow", globalSanitizers); found && s.Integer_overflow == nil {
Ivan Lozanoa9255a82018-03-13 10:41:07 -0700380 if !ctx.Config().IntegerOverflowDisabledForPath(ctx.ModuleDir()) && !ctx.static() {
Liz Kammerb2fc4702021-06-25 14:53:40 -0400381 s.Integer_overflow = proptools.BoolPtr(true)
Ivan Lozano5f595532017-07-13 14:46:05 -0700382 }
Ivan Lozano0c3a1ef2017-06-28 09:10:48 -0700383 }
384
Kostya Kortchinskyd18ae5c2018-06-12 14:46:54 -0700385 if found, globalSanitizers = removeFromList("scudo", globalSanitizers); found && s.Scudo == nil {
Liz Kammerb2fc4702021-06-25 14:53:40 -0400386 s.Scudo = proptools.BoolPtr(true)
Kostya Kortchinskyd18ae5c2018-06-12 14:46:54 -0700387 }
388
Evgenii Stepanovd97a6e92018-08-02 16:19:13 -0700389 if found, globalSanitizers = removeFromList("hwaddress", globalSanitizers); found && s.Hwaddress == nil {
Liz Kammerb2fc4702021-06-25 14:53:40 -0400390 s.Hwaddress = proptools.BoolPtr(true)
Evgenii Stepanovd97a6e92018-08-02 16:19:13 -0700391 }
392
Jasraj Bedibb4511d2020-07-23 22:58:17 +0000393 if found, globalSanitizers = removeFromList("writeonly", globalSanitizers); found && s.Writeonly == nil {
394 // Hwaddress and Address are set before, so we can check them here
395 // If they aren't explicitly set in the blueprint/SANITIZE_(HOST|TARGET), they would be nil instead of false
396 if s.Address == nil && s.Hwaddress == nil {
397 ctx.ModuleErrorf("writeonly modifier cannot be used without 'address' or 'hwaddress'")
398 }
Liz Kammerb2fc4702021-06-25 14:53:40 -0400399 s.Writeonly = proptools.BoolPtr(true)
Jasraj Bedibb4511d2020-07-23 22:58:17 +0000400 }
Evgenii Stepanov193ac2e2020-04-28 15:09:12 -0700401 if found, globalSanitizers = removeFromList("memtag_heap", globalSanitizers); found && s.Memtag_heap == nil {
Evgenii Stepanov4beaa0c2021-01-05 16:41:26 -0800402 if !ctx.Config().MemtagHeapDisabledForPath(ctx.ModuleDir()) {
Liz Kammerb2fc4702021-06-25 14:53:40 -0400403 s.Memtag_heap = proptools.BoolPtr(true)
Evgenii Stepanov4beaa0c2021-01-05 16:41:26 -0800404 }
Evgenii Stepanov193ac2e2020-04-28 15:09:12 -0700405 }
Jasraj Bedibb4511d2020-07-23 22:58:17 +0000406
Evgenii Stepanov05bafd32016-07-07 17:38:41 +0000407 if len(globalSanitizers) > 0 {
408 ctx.ModuleErrorf("unknown global sanitizer option %s", globalSanitizers[0])
409 }
Ivan Lozano0c3a1ef2017-06-28 09:10:48 -0700410
Ivan Lozanoa9255a82018-03-13 10:41:07 -0700411 // Global integer_overflow builds do not support static library diagnostics.
Ivan Lozano0c3a1ef2017-06-28 09:10:48 -0700412 if found, globalSanitizersDiag = removeFromList("integer_overflow", globalSanitizersDiag); found &&
Ivan Lozanoa9255a82018-03-13 10:41:07 -0700413 s.Diag.Integer_overflow == nil && Bool(s.Integer_overflow) && !ctx.static() {
Liz Kammerb2fc4702021-06-25 14:53:40 -0400414 s.Diag.Integer_overflow = proptools.BoolPtr(true)
Ivan Lozano0c3a1ef2017-06-28 09:10:48 -0700415 }
416
Vishwath Mohan1fa3ac52017-10-31 02:26:14 -0700417 if found, globalSanitizersDiag = removeFromList("cfi", globalSanitizersDiag); found &&
418 s.Diag.Cfi == nil && Bool(s.Cfi) {
Liz Kammerb2fc4702021-06-25 14:53:40 -0400419 s.Diag.Cfi = proptools.BoolPtr(true)
Vishwath Mohan1fa3ac52017-10-31 02:26:14 -0700420 }
421
Evgenii Stepanov04896ca2021-01-12 18:28:33 -0800422 if found, globalSanitizersDiag = removeFromList("memtag_heap", globalSanitizersDiag); found &&
423 s.Diag.Memtag_heap == nil && Bool(s.Memtag_heap) {
Liz Kammerb2fc4702021-06-25 14:53:40 -0400424 s.Diag.Memtag_heap = proptools.BoolPtr(true)
Evgenii Stepanov04896ca2021-01-12 18:28:33 -0800425 }
426
Ivan Lozano0c3a1ef2017-06-28 09:10:48 -0700427 if len(globalSanitizersDiag) > 0 {
428 ctx.ModuleErrorf("unknown global sanitizer diagnostics option %s", globalSanitizersDiag[0])
429 }
Evgenii Stepanovfcfe56d2016-07-07 10:54:07 -0700430 }
Colin Cross3c344ef2016-07-18 15:44:56 -0700431
Evgenii Stepanov4beaa0c2021-01-05 16:41:26 -0800432 // Enable Memtag for all components in the include paths (for Aarch64 only)
Evgenii Stepanov04896ca2021-01-12 18:28:33 -0800433 if ctx.Arch().ArchType == android.Arm64 {
Evgenii Stepanov4beaa0c2021-01-05 16:41:26 -0800434 if ctx.Config().MemtagHeapSyncEnabledForPath(ctx.ModuleDir()) {
Evgenii Stepanov04896ca2021-01-12 18:28:33 -0800435 if s.Memtag_heap == nil {
Liz Kammerb2fc4702021-06-25 14:53:40 -0400436 s.Memtag_heap = proptools.BoolPtr(true)
Evgenii Stepanov04896ca2021-01-12 18:28:33 -0800437 }
438 if s.Diag.Memtag_heap == nil {
Liz Kammerb2fc4702021-06-25 14:53:40 -0400439 s.Diag.Memtag_heap = proptools.BoolPtr(true)
Evgenii Stepanov04896ca2021-01-12 18:28:33 -0800440 }
Evgenii Stepanov4beaa0c2021-01-05 16:41:26 -0800441 } else if ctx.Config().MemtagHeapAsyncEnabledForPath(ctx.ModuleDir()) {
Evgenii Stepanov04896ca2021-01-12 18:28:33 -0800442 if s.Memtag_heap == nil {
Liz Kammerb2fc4702021-06-25 14:53:40 -0400443 s.Memtag_heap = proptools.BoolPtr(true)
Evgenii Stepanov04896ca2021-01-12 18:28:33 -0800444 }
Evgenii Stepanov4beaa0c2021-01-05 16:41:26 -0800445 }
Evgenii Stepanov193ac2e2020-04-28 15:09:12 -0700446 }
447
Elvis Chien9c993542021-06-25 01:15:17 +0800448 // Enable CFI for non-host components in the include paths
449 if s.Cfi == nil && ctx.Config().CFIEnabledForPath(ctx.ModuleDir()) && !ctx.Host() {
Liz Kammerb2fc4702021-06-25 14:53:40 -0400450 s.Cfi = proptools.BoolPtr(true)
Vishwath Mohan3af8ee02018-03-30 02:55:23 +0000451 if inList("cfi", ctx.Config().SanitizeDeviceDiag()) {
Liz Kammerb2fc4702021-06-25 14:53:40 -0400452 s.Diag.Cfi = proptools.BoolPtr(true)
Vishwath Mohan1fa3ac52017-10-31 02:26:14 -0700453 }
454 }
455
Elliott Hughesda3a0712020-03-06 16:55:28 -0800456 // Is CFI actually enabled?
457 if !ctx.Config().EnableCFI() {
Liz Kammerb2fc4702021-06-25 14:53:40 -0400458 s.Cfi = nil
459 s.Diag.Cfi = nil
Vishwath Mohan1b017a72017-01-19 13:54:55 -0800460 }
461
Evgenii Stepanovd97a6e92018-08-02 16:19:13 -0700462 // HWASan requires AArch64 hardware feature (top-byte-ignore).
463 if ctx.Arch().ArchType != android.Arm64 {
464 s.Hwaddress = nil
465 }
466
Peter Collingbourne8c7e6e22018-11-19 16:03:58 -0800467 // SCS is only implemented on AArch64.
Peter Collingbournebd19db02019-03-06 10:38:48 -0800468 if ctx.Arch().ArchType != android.Arm64 {
Peter Collingbourne8c7e6e22018-11-19 16:03:58 -0800469 s.Scs = nil
470 }
471
Ivan Lozano62cd0382021-11-01 10:27:54 -0400472 // Memtag_heap is only implemented on AArch64.
Evgenii Stepanov193ac2e2020-04-28 15:09:12 -0700473 if ctx.Arch().ArchType != android.Arm64 {
474 s.Memtag_heap = nil
475 }
476
Vishwath Mohan8f4fdd82017-04-20 07:42:52 -0700477 // Also disable CFI if ASAN is enabled.
Evgenii Stepanovd97a6e92018-08-02 16:19:13 -0700478 if Bool(s.Address) || Bool(s.Hwaddress) {
Liz Kammerb2fc4702021-06-25 14:53:40 -0400479 s.Cfi = nil
480 s.Diag.Cfi = nil
Vishwath Mohan8f4fdd82017-04-20 07:42:52 -0700481 }
482
Colin Cross528d67e2021-07-23 22:23:07 +0000483 // Disable sanitizers that depend on the UBSan runtime for windows/darwin/musl builds.
484 if !ctx.Os().Linux() || ctx.Os() == android.LinuxMusl {
Liz Kammerb2fc4702021-06-25 14:53:40 -0400485 s.Cfi = nil
486 s.Diag.Cfi = nil
Ivan Lozanoa9255a82018-03-13 10:41:07 -0700487 s.Misc_undefined = nil
488 s.Undefined = nil
489 s.All_undefined = nil
490 s.Integer_overflow = nil
Vishwath Mohane7128792017-11-17 11:08:10 -0800491 }
492
Vishwath Mohan9ccbba02018-05-28 13:54:48 -0700493 // Also disable CFI for VNDK variants of components
494 if ctx.isVndk() && ctx.useVndk() {
Inseob Kimc42f2f22020-07-29 20:32:10 +0900495 if ctx.static() {
496 // Cfi variant for static vndk should be captured as vendor snapshot,
497 // so don't strictly disable Cfi.
498 s.Cfi = nil
499 s.Diag.Cfi = nil
500 } else {
Liz Kammerb2fc4702021-06-25 14:53:40 -0400501 s.Cfi = nil
502 s.Diag.Cfi = nil
Inseob Kimc42f2f22020-07-29 20:32:10 +0900503 }
Inseob Kimeec88e12020-01-22 11:11:29 +0900504 }
505
Evgenii Stepanovd97a6e92018-08-02 16:19:13 -0700506 // HWASan ramdisk (which is built from recovery) goes over some bootloader limit.
Yifan Hong60e0cfb2020-10-21 15:17:56 -0700507 // Keep libc instrumented so that ramdisk / vendor_ramdisk / recovery can run hwasan-instrumented code if necessary.
508 if (ctx.inRamdisk() || ctx.inVendorRamdisk() || ctx.inRecovery()) && !strings.HasPrefix(ctx.ModuleDir(), "bionic/libc") {
Evgenii Stepanovd97a6e92018-08-02 16:19:13 -0700509 s.Hwaddress = nil
510 }
511
Colin Cross3c344ef2016-07-18 15:44:56 -0700512 if ctx.staticBinary() {
513 s.Address = nil
Mitch Phillips5a6ea6c2019-05-01 14:42:05 -0700514 s.Fuzzer = nil
Colin Cross3c344ef2016-07-18 15:44:56 -0700515 s.Thread = nil
Colin Cross16b23492016-01-06 14:41:07 -0800516 }
517
Evgenii Stepanovfcfe56d2016-07-07 10:54:07 -0700518 if Bool(s.All_undefined) {
519 s.Undefined = nil
520 }
521
Evgenii Stepanov0a8a0d02016-05-12 13:54:53 -0700522 if !ctx.toolchain().Is64Bit() {
523 // TSAN and SafeStack are not supported on 32-bit architectures
Evgenii Stepanovfcfe56d2016-07-07 10:54:07 -0700524 s.Thread = nil
525 s.Safestack = nil
Colin Cross16b23492016-01-06 14:41:07 -0800526 // TODO(ccross): error for compile_multilib = "32"?
527 }
528
Evgenii Stepanov76cee232017-01-27 15:44:44 -0800529 if ctx.Os() != android.Windows && (Bool(s.All_undefined) || Bool(s.Undefined) || Bool(s.Address) || Bool(s.Thread) ||
Mitch Phillips5a6ea6c2019-05-01 14:42:05 -0700530 Bool(s.Fuzzer) || Bool(s.Safestack) || Bool(s.Cfi) || Bool(s.Integer_overflow) || len(s.Misc_undefined) > 0 ||
Evgenii Stepanov193ac2e2020-04-28 15:09:12 -0700531 Bool(s.Scudo) || Bool(s.Hwaddress) || Bool(s.Scs) || Bool(s.Memtag_heap)) {
Colin Cross3c344ef2016-07-18 15:44:56 -0700532 sanitize.Properties.SanitizerEnabled = true
533 }
534
Kostya Kortchinskyd5275c82019-02-01 08:42:56 -0800535 // Disable Scudo if ASan or TSan is enabled, or if it's disabled globally.
536 if Bool(s.Address) || Bool(s.Thread) || Bool(s.Hwaddress) || ctx.Config().DisableScudo() {
Kostya Kortchinskyd18ae5c2018-06-12 14:46:54 -0700537 s.Scudo = nil
538 }
539
Evgenii Stepanovd97a6e92018-08-02 16:19:13 -0700540 if Bool(s.Hwaddress) {
541 s.Address = nil
542 s.Thread = nil
Evgenii Stepanovb15a5642021-06-23 12:30:55 -0700543 // Disable ubsan diagnosic as a workaround for a compiler bug.
544 // TODO(b/191808836): re-enable.
545 s.Diag.Undefined = nil
546 s.Diag.Integer_overflow = nil
547 s.Diag.Misc_undefined = nil
Evgenii Stepanovd97a6e92018-08-02 16:19:13 -0700548 }
549
Mitch Phillips5a6ea6c2019-05-01 14:42:05 -0700550 // TODO(b/131771163): CFI transiently depends on LTO, and thus Fuzzer is
551 // mutually incompatible.
552 if Bool(s.Fuzzer) {
Liz Kammerb2fc4702021-06-25 14:53:40 -0400553 s.Cfi = nil
Colin Cross16b23492016-01-06 14:41:07 -0800554 }
555}
556
Chih-Hung Hsieh3567e622018-11-15 14:01:36 -0800557func toDisableImplicitIntegerChange(flags []string) bool {
558 // Returns true if any flag is fsanitize*integer, and there is
559 // no explicit flag about sanitize=implicit-integer-sign-change.
560 for _, f := range flags {
561 if strings.Contains(f, "sanitize=implicit-integer-sign-change") {
562 return false
563 }
564 }
565 for _, f := range flags {
566 if strings.HasPrefix(f, "-fsanitize") && strings.Contains(f, "integer") {
567 return true
568 }
569 }
570 return false
571}
572
Yabin Cuidb7dda82020-11-30 15:47:45 -0800573func toDisableUnsignedShiftBaseChange(flags []string) bool {
574 // Returns true if any flag is fsanitize*integer, and there is
575 // no explicit flag about sanitize=unsigned-shift-base.
576 for _, f := range flags {
577 if strings.Contains(f, "sanitize=unsigned-shift-base") {
578 return false
579 }
580 }
581 for _, f := range flags {
582 if strings.HasPrefix(f, "-fsanitize") && strings.Contains(f, "integer") {
583 return true
584 }
585 }
586 return false
587}
588
Colin Cross16b23492016-01-06 14:41:07 -0800589func (sanitize *sanitize) flags(ctx ModuleContext, flags Flags) Flags {
Ivan Lozano59fdea22018-05-10 14:17:22 -0700590 minimalRuntimeLib := config.UndefinedBehaviorSanitizerMinimalRuntimeLibrary(ctx.toolchain()) + ".a"
591 minimalRuntimePath := "${config.ClangAsanLibDir}/" + minimalRuntimeLib
Ivan Lozano9ac32c72020-02-19 15:24:02 -0500592 builtinsRuntimeLib := config.BuiltinsRuntimeLibrary(ctx.toolchain()) + ".a"
593 builtinsRuntimePath := "${config.ClangAsanLibDir}/" + builtinsRuntimeLib
Ivan Lozano30c5db22018-02-21 15:49:20 -0800594
Ivan Lozano9ac32c72020-02-19 15:24:02 -0500595 if sanitize.Properties.MinimalRuntimeDep {
Colin Cross4af21ed2019-11-04 09:37:55 -0800596 flags.Local.LdFlags = append(flags.Local.LdFlags,
597 minimalRuntimePath,
598 "-Wl,--exclude-libs,"+minimalRuntimeLib)
Ivan Lozano30c5db22018-02-21 15:49:20 -0800599 }
Ivan Lozano9ac32c72020-02-19 15:24:02 -0500600
601 if sanitize.Properties.BuiltinsDep {
602 flags.libFlags = append([]string{builtinsRuntimePath}, flags.libFlags...)
603 }
604
Ivan Lozanoa9255a82018-03-13 10:41:07 -0700605 if !sanitize.Properties.SanitizerEnabled && !sanitize.Properties.UbsanRuntimeDep {
Colin Cross16b23492016-01-06 14:41:07 -0800606 return flags
607 }
608
Evgenii Stepanovfcfe56d2016-07-07 10:54:07 -0700609 if Bool(sanitize.Properties.Sanitize.Address) {
Colin Cross635c3b02016-05-18 15:37:25 -0700610 if ctx.Arch().ArchType == android.Arm {
Colin Cross16b23492016-01-06 14:41:07 -0800611 // Frame pointer based unwinder in ASan requires ARM frame setup.
612 // TODO: put in flags?
613 flags.RequiredInstructionSet = "arm"
614 }
Colin Cross4af21ed2019-11-04 09:37:55 -0800615 flags.Local.CFlags = append(flags.Local.CFlags, asanCflags...)
616 flags.Local.LdFlags = append(flags.Local.LdFlags, asanLdflags...)
Colin Cross16b23492016-01-06 14:41:07 -0800617
Jasraj Bedibb4511d2020-07-23 22:58:17 +0000618 if Bool(sanitize.Properties.Sanitize.Writeonly) {
619 flags.Local.CFlags = append(flags.Local.CFlags, "-mllvm", "-asan-instrument-reads=0")
620 }
621
Colin Cross16b23492016-01-06 14:41:07 -0800622 if ctx.Host() {
623 // -nodefaultlibs (provided with libc++) prevents the driver from linking
624 // libraries needed with -fsanitize=address. http://b/18650275 (WAI)
Colin Cross4af21ed2019-11-04 09:37:55 -0800625 flags.Local.LdFlags = append(flags.Local.LdFlags, "-Wl,--no-as-needed")
Colin Cross16b23492016-01-06 14:41:07 -0800626 } else {
Colin Cross4af21ed2019-11-04 09:37:55 -0800627 flags.Local.CFlags = append(flags.Local.CFlags, "-mllvm", "-asan-globals=0")
Jiyong Parka2aca282019-02-02 13:13:38 +0900628 if ctx.bootstrap() {
629 flags.DynamicLinker = "/system/bin/bootstrap/linker_asan"
630 } else {
631 flags.DynamicLinker = "/system/bin/linker_asan"
632 }
Colin Cross16b23492016-01-06 14:41:07 -0800633 if flags.Toolchain.Is64Bit() {
634 flags.DynamicLinker += "64"
635 }
636 }
Colin Cross16b23492016-01-06 14:41:07 -0800637 }
638
Evgenii Stepanovd97a6e92018-08-02 16:19:13 -0700639 if Bool(sanitize.Properties.Sanitize.Hwaddress) {
Colin Cross4af21ed2019-11-04 09:37:55 -0800640 flags.Local.CFlags = append(flags.Local.CFlags, hwasanCflags...)
Yi Kong286abc62021-11-04 16:14:14 +0800641
642 for _, flag := range hwasanCommonflags {
643 flags.Local.CFlags = append(flags.Local.CFlags, "-mllvm", flag)
644 }
645 for _, flag := range hwasanCommonflags {
646 flags.Local.LdFlags = append(flags.Local.LdFlags, "-Wl,-mllvm,"+flag)
647 }
648
Jasraj Bedibb4511d2020-07-23 22:58:17 +0000649 if Bool(sanitize.Properties.Sanitize.Writeonly) {
650 flags.Local.CFlags = append(flags.Local.CFlags, "-mllvm", "-hwasan-instrument-reads=0")
651 }
Yabin Cui6be405e2017-10-19 15:52:11 -0700652 }
653
Mitch Phillips5a6ea6c2019-05-01 14:42:05 -0700654 if Bool(sanitize.Properties.Sanitize.Fuzzer) {
Colin Cross4af21ed2019-11-04 09:37:55 -0800655 flags.Local.CFlags = append(flags.Local.CFlags, "-fsanitize=fuzzer-no-link")
Mitch Phillips5a6ea6c2019-05-01 14:42:05 -0700656
657 // TODO(b/131771163): LTO and Fuzzer support is mutually incompatible.
Colin Cross4af21ed2019-11-04 09:37:55 -0800658 _, flags.Local.LdFlags = removeFromList("-flto", flags.Local.LdFlags)
659 _, flags.Local.CFlags = removeFromList("-flto", flags.Local.CFlags)
660 flags.Local.LdFlags = append(flags.Local.LdFlags, "-fno-lto")
661 flags.Local.CFlags = append(flags.Local.CFlags, "-fno-lto")
Mitch Phillips74384752019-06-17 10:33:52 -0700662
Mitch Phillipsb8e593d2019-10-09 17:18:59 -0700663 // TODO(b/142430592): Upstream linker scripts for sanitizer runtime libraries
664 // discard the sancov_lowest_stack symbol, because it's emulated TLS (and thus
665 // doesn't match the linker script due to the "__emutls_v." prefix).
Colin Cross4af21ed2019-11-04 09:37:55 -0800666 flags.Local.LdFlags = append(flags.Local.LdFlags, "-fno-sanitize-coverage=stack-depth")
667 flags.Local.CFlags = append(flags.Local.CFlags, "-fno-sanitize-coverage=stack-depth")
Mitch Phillipsb8e593d2019-10-09 17:18:59 -0700668
Mitch Phillips74384752019-06-17 10:33:52 -0700669 // TODO(b/133876586): Experimental PM breaks sanitizer coverage.
Colin Cross4af21ed2019-11-04 09:37:55 -0800670 flags.Local.CFlags = append(flags.Local.CFlags, "-fno-experimental-new-pass-manager")
Mitch Phillipsb9b3e792019-08-28 12:41:07 -0700671
672 // Disable fortify for fuzzing builds. Generally, we'll be building with
673 // UBSan or ASan here and the fortify checks pollute the stack traces.
Colin Cross4af21ed2019-11-04 09:37:55 -0800674 flags.Local.CFlags = append(flags.Local.CFlags, "-U_FORTIFY_SOURCE")
Mitch Phillips734b4cb2019-12-10 08:44:52 -0800675
676 // Build fuzzer-sanitized libraries with an $ORIGIN DT_RUNPATH. Android's
677 // linker uses DT_RUNPATH, not DT_RPATH. When we deploy cc_fuzz targets and
678 // their libraries to /data/fuzz/<arch>/lib, any transient shared library gets
679 // the DT_RUNPATH from the shared library above it, and not the executable,
680 // meaning that the lookup falls back to the system. Adding the $ORIGIN to the
681 // DT_RUNPATH here means that transient shared libraries can be found
682 // colocated with their parents.
683 flags.Local.LdFlags = append(flags.Local.LdFlags, `-Wl,-rpath,\$$ORIGIN`)
Colin Cross16b23492016-01-06 14:41:07 -0800684 }
685
Evgenii Stepanov1e405e12016-08-16 15:39:54 -0700686 if Bool(sanitize.Properties.Sanitize.Cfi) {
Evgenii Stepanov7ebf9fa2017-01-20 14:13:06 -0800687 if ctx.Arch().ArchType == android.Arm {
688 // __cfi_check needs to be built as Thumb (see the code in linker_cfi.cpp). LLVM is not set up
689 // to do this on a function basis, so force Thumb on the entire module.
690 flags.RequiredInstructionSet = "thumb"
691 }
Vishwath Mohanb743e9c2017-11-01 09:20:21 +0000692
Colin Cross4af21ed2019-11-04 09:37:55 -0800693 flags.Local.CFlags = append(flags.Local.CFlags, cfiCflags...)
694 flags.Local.AsFlags = append(flags.Local.AsFlags, cfiAsflags...)
Cindy Zhou8cd45de2020-11-16 08:41:00 -0800695 if Bool(sanitize.Properties.Sanitize.Config.Cfi_assembly_support) {
696 flags.Local.CFlags = append(flags.Local.CFlags, "-fno-sanitize-cfi-canonical-jump-tables")
697 }
Vishwath Mohanb743e9c2017-11-01 09:20:21 +0000698 // Only append the default visibility flag if -fvisibility has not already been set
699 // to hidden.
Colin Cross4af21ed2019-11-04 09:37:55 -0800700 if !inList("-fvisibility=hidden", flags.Local.CFlags) {
701 flags.Local.CFlags = append(flags.Local.CFlags, "-fvisibility=default")
Vishwath Mohanb743e9c2017-11-01 09:20:21 +0000702 }
Colin Cross4af21ed2019-11-04 09:37:55 -0800703 flags.Local.LdFlags = append(flags.Local.LdFlags, cfiLdflags...)
Vishwath Mohanb743e9c2017-11-01 09:20:21 +0000704
705 if ctx.staticBinary() {
Colin Cross4af21ed2019-11-04 09:37:55 -0800706 _, flags.Local.CFlags = removeFromList("-fsanitize-cfi-cross-dso", flags.Local.CFlags)
707 _, flags.Local.LdFlags = removeFromList("-fsanitize-cfi-cross-dso", flags.Local.LdFlags)
Vishwath Mohanb743e9c2017-11-01 09:20:21 +0000708 }
Evgenii Stepanov1e405e12016-08-16 15:39:54 -0700709 }
710
Ivan Lozano0c3a1ef2017-06-28 09:10:48 -0700711 if Bool(sanitize.Properties.Sanitize.Integer_overflow) {
Colin Cross4af21ed2019-11-04 09:37:55 -0800712 flags.Local.CFlags = append(flags.Local.CFlags, intOverflowCflags...)
Ivan Lozano0c3a1ef2017-06-28 09:10:48 -0700713 }
714
Jiyong Park379de2f2018-12-19 02:47:14 +0900715 if len(sanitize.Properties.Sanitizers) > 0 {
716 sanitizeArg := "-fsanitize=" + strings.Join(sanitize.Properties.Sanitizers, ",")
Ivan Lozano30c5db22018-02-21 15:49:20 -0800717
Colin Cross4af21ed2019-11-04 09:37:55 -0800718 flags.Local.CFlags = append(flags.Local.CFlags, sanitizeArg)
719 flags.Local.AsFlags = append(flags.Local.AsFlags, sanitizeArg)
Colin Cross16b23492016-01-06 14:41:07 -0800720 if ctx.Host() {
Evgenii Stepanov76cee232017-01-27 15:44:44 -0800721 // Host sanitizers only link symbols in the final executable, so
722 // there will always be undefined symbols in intermediate libraries.
Colin Cross4af21ed2019-11-04 09:37:55 -0800723 _, flags.Global.LdFlags = removeFromList("-Wl,--no-undefined", flags.Global.LdFlags)
724 flags.Local.LdFlags = append(flags.Local.LdFlags, sanitizeArg)
Ivan Lozano9ac32c72020-02-19 15:24:02 -0500725
726 // non-Bionic toolchain prebuilts are missing UBSan's vptr and function sanitizers
727 if !ctx.toolchain().Bionic() {
728 flags.Local.CFlags = append(flags.Local.CFlags, "-fno-sanitize=vptr,function")
729 }
730 }
731
732 if enableMinimalRuntime(sanitize) {
733 flags.Local.CFlags = append(flags.Local.CFlags, strings.Join(minimalRuntimeFlags, " "))
734 flags.libFlags = append([]string{minimalRuntimePath}, flags.libFlags...)
735 flags.Local.LdFlags = append(flags.Local.LdFlags, "-Wl,--exclude-libs,"+minimalRuntimeLib)
736 if !ctx.toolchain().Bionic() {
737 flags.libFlags = append([]string{builtinsRuntimePath}, flags.libFlags...)
Ivan Lozano30c5db22018-02-21 15:49:20 -0800738 }
Colin Cross16b23492016-01-06 14:41:07 -0800739 }
Mitch Phillips5a6ea6c2019-05-01 14:42:05 -0700740
741 if Bool(sanitize.Properties.Sanitize.Fuzzer) {
742 // When fuzzing, we wish to crash with diagnostics on any bug.
Colin Cross4af21ed2019-11-04 09:37:55 -0800743 flags.Local.CFlags = append(flags.Local.CFlags, "-fno-sanitize-trap=all", "-fno-sanitize-recover=all")
Mitch Phillips5a6ea6c2019-05-01 14:42:05 -0700744 } else if ctx.Host() {
Colin Cross4af21ed2019-11-04 09:37:55 -0800745 flags.Local.CFlags = append(flags.Local.CFlags, "-fno-sanitize-recover=all")
Mitch Phillips5a6ea6c2019-05-01 14:42:05 -0700746 } else {
Colin Cross4af21ed2019-11-04 09:37:55 -0800747 flags.Local.CFlags = append(flags.Local.CFlags, "-fsanitize-trap=all", "-ftrap-function=abort")
Mitch Phillips5a6ea6c2019-05-01 14:42:05 -0700748 }
Chih-Hung Hsieh3567e622018-11-15 14:01:36 -0800749 // http://b/119329758, Android core does not boot up with this sanitizer yet.
Colin Cross4af21ed2019-11-04 09:37:55 -0800750 if toDisableImplicitIntegerChange(flags.Local.CFlags) {
751 flags.Local.CFlags = append(flags.Local.CFlags, "-fno-sanitize=implicit-integer-sign-change")
Chih-Hung Hsieh3567e622018-11-15 14:01:36 -0800752 }
Yabin Cuidb7dda82020-11-30 15:47:45 -0800753 // http://b/171275751, Android doesn't build with this sanitizer yet.
754 if toDisableUnsignedShiftBaseChange(flags.Local.CFlags) {
755 flags.Local.CFlags = append(flags.Local.CFlags, "-fno-sanitize=unsigned-shift-base")
756 }
Colin Cross16b23492016-01-06 14:41:07 -0800757 }
758
Jiyong Park379de2f2018-12-19 02:47:14 +0900759 if len(sanitize.Properties.DiagSanitizers) > 0 {
Colin Cross4af21ed2019-11-04 09:37:55 -0800760 flags.Local.CFlags = append(flags.Local.CFlags, "-fno-sanitize-trap="+strings.Join(sanitize.Properties.DiagSanitizers, ","))
Evgenii Stepanov1e405e12016-08-16 15:39:54 -0700761 }
762 // FIXME: enable RTTI if diag + (cfi or vptr)
763
Andreas Gampe97071162017-05-08 13:15:23 -0700764 if sanitize.Properties.Sanitize.Recover != nil {
Colin Cross4af21ed2019-11-04 09:37:55 -0800765 flags.Local.CFlags = append(flags.Local.CFlags, "-fsanitize-recover="+
Andreas Gampe97071162017-05-08 13:15:23 -0700766 strings.Join(sanitize.Properties.Sanitize.Recover, ","))
767 }
768
Ivan Lozano7929bba2018-12-12 09:36:31 -0800769 if sanitize.Properties.Sanitize.Diag.No_recover != nil {
Colin Cross4af21ed2019-11-04 09:37:55 -0800770 flags.Local.CFlags = append(flags.Local.CFlags, "-fno-sanitize-recover="+
Ivan Lozano7929bba2018-12-12 09:36:31 -0800771 strings.Join(sanitize.Properties.Sanitize.Diag.No_recover, ","))
772 }
773
Pirama Arumuga Nainar6c4ccca2020-07-27 11:49:51 -0700774 blocklist := android.OptionalPathForModuleSrc(ctx, sanitize.Properties.Sanitize.Blocklist)
775 if blocklist.Valid() {
Pirama Arumuga Nainar582fc2d2021-08-27 15:12:56 -0700776 flags.Local.CFlags = append(flags.Local.CFlags, "-fsanitize-ignorelist="+blocklist.String())
Pirama Arumuga Nainar6c4ccca2020-07-27 11:49:51 -0700777 flags.CFlagsDeps = append(flags.CFlagsDeps, blocklist.Path())
778 }
779
Colin Cross16b23492016-01-06 14:41:07 -0800780 return flags
781}
782
Colin Crossd80cbca2020-02-24 12:01:37 -0800783func (sanitize *sanitize) AndroidMkEntries(ctx AndroidMkContext, entries *android.AndroidMkEntries) {
Jiyong Park1d1119f2019-07-29 21:27:18 +0900784 // Add a suffix for cfi/hwasan/scs-enabled static/header libraries to allow surfacing
785 // both the sanitized and non-sanitized variants to make without a name conflict.
Colin Crossd80cbca2020-02-24 12:01:37 -0800786 if entries.Class == "STATIC_LIBRARIES" || entries.Class == "HEADER_LIBRARIES" {
Jiyong Park1d1119f2019-07-29 21:27:18 +0900787 if Bool(sanitize.Properties.Sanitize.Cfi) {
Colin Crossd80cbca2020-02-24 12:01:37 -0800788 entries.SubName += ".cfi"
Jiyong Park1d1119f2019-07-29 21:27:18 +0900789 }
790 if Bool(sanitize.Properties.Sanitize.Hwaddress) {
Colin Crossd80cbca2020-02-24 12:01:37 -0800791 entries.SubName += ".hwasan"
Jiyong Park1d1119f2019-07-29 21:27:18 +0900792 }
793 if Bool(sanitize.Properties.Sanitize.Scs) {
Colin Crossd80cbca2020-02-24 12:01:37 -0800794 entries.SubName += ".scs"
Jiyong Park1d1119f2019-07-29 21:27:18 +0900795 }
Peter Collingbourne8c7e6e22018-11-19 16:03:58 -0800796 }
Colin Cross8ff9ef42017-05-08 13:44:11 -0700797}
798
Vishwath Mohan1dd88392017-03-29 22:00:18 -0700799func (sanitize *sanitize) inSanitizerDir() bool {
800 return sanitize.Properties.InSanitizerDir
Colin Cross30d5f512016-05-03 18:02:42 -0700801}
802
Ivan Lozano3968d8f2020-12-14 11:27:52 -0500803// getSanitizerBoolPtr returns the SanitizerTypes associated bool pointer from SanitizeProperties.
804func (sanitize *sanitize) getSanitizerBoolPtr(t SanitizerType) *bool {
Vishwath Mohan95229302017-08-11 00:53:16 +0000805 switch t {
Ivan Lozano3968d8f2020-12-14 11:27:52 -0500806 case Asan:
Vishwath Mohanb743e9c2017-11-01 09:20:21 +0000807 return sanitize.Properties.Sanitize.Address
Tri Vo6eafc362021-04-01 11:29:09 -0700808 case Hwasan:
Evgenii Stepanovd97a6e92018-08-02 16:19:13 -0700809 return sanitize.Properties.Sanitize.Hwaddress
Vishwath Mohan95229302017-08-11 00:53:16 +0000810 case tsan:
Vishwath Mohanb743e9c2017-11-01 09:20:21 +0000811 return sanitize.Properties.Sanitize.Thread
Vishwath Mohan95229302017-08-11 00:53:16 +0000812 case intOverflow:
Vishwath Mohanb743e9c2017-11-01 09:20:21 +0000813 return sanitize.Properties.Sanitize.Integer_overflow
814 case cfi:
815 return sanitize.Properties.Sanitize.Cfi
Peter Collingbourne8c7e6e22018-11-19 16:03:58 -0800816 case scs:
817 return sanitize.Properties.Sanitize.Scs
Ivan Lozano62cd0382021-11-01 10:27:54 -0400818 case Memtag_heap:
Evgenii Stepanov193ac2e2020-04-28 15:09:12 -0700819 return sanitize.Properties.Sanitize.Memtag_heap
Ivan Lozano3968d8f2020-12-14 11:27:52 -0500820 case Fuzzer:
Mitch Phillips5a6ea6c2019-05-01 14:42:05 -0700821 return sanitize.Properties.Sanitize.Fuzzer
Vishwath Mohan95229302017-08-11 00:53:16 +0000822 default:
Ivan Lozano3968d8f2020-12-14 11:27:52 -0500823 panic(fmt.Errorf("unknown SanitizerType %d", t))
Vishwath Mohan95229302017-08-11 00:53:16 +0000824 }
825}
826
Ivan Lozano3968d8f2020-12-14 11:27:52 -0500827// isUnsanitizedVariant returns true if no sanitizers are enabled.
Dan Albert7d1eecf2018-01-19 12:30:45 -0800828func (sanitize *sanitize) isUnsanitizedVariant() bool {
Ivan Lozano3968d8f2020-12-14 11:27:52 -0500829 return !sanitize.isSanitizerEnabled(Asan) &&
Tri Vo6eafc362021-04-01 11:29:09 -0700830 !sanitize.isSanitizerEnabled(Hwasan) &&
Dan Albert7d1eecf2018-01-19 12:30:45 -0800831 !sanitize.isSanitizerEnabled(tsan) &&
Peter Collingbourne8c7e6e22018-11-19 16:03:58 -0800832 !sanitize.isSanitizerEnabled(cfi) &&
Mitch Phillips5a6ea6c2019-05-01 14:42:05 -0700833 !sanitize.isSanitizerEnabled(scs) &&
Ivan Lozano62cd0382021-11-01 10:27:54 -0400834 !sanitize.isSanitizerEnabled(Memtag_heap) &&
Ivan Lozano3968d8f2020-12-14 11:27:52 -0500835 !sanitize.isSanitizerEnabled(Fuzzer)
Dan Albert7d1eecf2018-01-19 12:30:45 -0800836}
837
Ivan Lozano3968d8f2020-12-14 11:27:52 -0500838// isVariantOnProductionDevice returns true if variant is for production devices (no non-production sanitizers enabled).
Jayant Chowdharyb7e08ca2018-05-10 15:29:24 -0700839func (sanitize *sanitize) isVariantOnProductionDevice() bool {
Ivan Lozano3968d8f2020-12-14 11:27:52 -0500840 return !sanitize.isSanitizerEnabled(Asan) &&
Tri Vo6eafc362021-04-01 11:29:09 -0700841 !sanitize.isSanitizerEnabled(Hwasan) &&
Mitch Phillips5a6ea6c2019-05-01 14:42:05 -0700842 !sanitize.isSanitizerEnabled(tsan) &&
Ivan Lozano3968d8f2020-12-14 11:27:52 -0500843 !sanitize.isSanitizerEnabled(Fuzzer)
Jayant Chowdharyb7e08ca2018-05-10 15:29:24 -0700844}
845
Ivan Lozano3968d8f2020-12-14 11:27:52 -0500846func (sanitize *sanitize) SetSanitizer(t SanitizerType, b bool) {
Liz Kammerb2fc4702021-06-25 14:53:40 -0400847 bPtr := proptools.BoolPtr(b)
848 if !b {
849 bPtr = nil
850 }
Colin Cross16b23492016-01-06 14:41:07 -0800851 switch t {
Ivan Lozano3968d8f2020-12-14 11:27:52 -0500852 case Asan:
Liz Kammerb2fc4702021-06-25 14:53:40 -0400853 sanitize.Properties.Sanitize.Address = bPtr
Tri Vo6eafc362021-04-01 11:29:09 -0700854 case Hwasan:
Liz Kammerb2fc4702021-06-25 14:53:40 -0400855 sanitize.Properties.Sanitize.Hwaddress = bPtr
Colin Cross16b23492016-01-06 14:41:07 -0800856 case tsan:
Liz Kammerb2fc4702021-06-25 14:53:40 -0400857 sanitize.Properties.Sanitize.Thread = bPtr
Ivan Lozano0c3a1ef2017-06-28 09:10:48 -0700858 case intOverflow:
Liz Kammerb2fc4702021-06-25 14:53:40 -0400859 sanitize.Properties.Sanitize.Integer_overflow = bPtr
Vishwath Mohanb743e9c2017-11-01 09:20:21 +0000860 case cfi:
Liz Kammerb2fc4702021-06-25 14:53:40 -0400861 sanitize.Properties.Sanitize.Cfi = bPtr
Peter Collingbourne8c7e6e22018-11-19 16:03:58 -0800862 case scs:
Liz Kammerb2fc4702021-06-25 14:53:40 -0400863 sanitize.Properties.Sanitize.Scs = bPtr
Ivan Lozano62cd0382021-11-01 10:27:54 -0400864 case Memtag_heap:
Liz Kammerb2fc4702021-06-25 14:53:40 -0400865 sanitize.Properties.Sanitize.Memtag_heap = bPtr
Ivan Lozano3968d8f2020-12-14 11:27:52 -0500866 case Fuzzer:
Liz Kammerb2fc4702021-06-25 14:53:40 -0400867 sanitize.Properties.Sanitize.Fuzzer = bPtr
Colin Cross16b23492016-01-06 14:41:07 -0800868 default:
Ivan Lozano3968d8f2020-12-14 11:27:52 -0500869 panic(fmt.Errorf("unknown SanitizerType %d", t))
Colin Cross16b23492016-01-06 14:41:07 -0800870 }
871 if b {
872 sanitize.Properties.SanitizerEnabled = true
873 }
874}
875
Vishwath Mohanb743e9c2017-11-01 09:20:21 +0000876// Check if the sanitizer is explicitly disabled (as opposed to nil by
877// virtue of not being set).
Ivan Lozano3968d8f2020-12-14 11:27:52 -0500878func (sanitize *sanitize) isSanitizerExplicitlyDisabled(t SanitizerType) bool {
Vishwath Mohanb743e9c2017-11-01 09:20:21 +0000879 if sanitize == nil {
880 return false
881 }
882
883 sanitizerVal := sanitize.getSanitizerBoolPtr(t)
884 return sanitizerVal != nil && *sanitizerVal == false
885}
886
887// There isn't an analog of the method above (ie:isSanitizerExplicitlyEnabled)
888// because enabling a sanitizer either directly (via the blueprint) or
889// indirectly (via a mutator) sets the bool ptr to true, and you can't
890// distinguish between the cases. It isn't needed though - both cases can be
891// treated identically.
Ivan Lozano3968d8f2020-12-14 11:27:52 -0500892func (sanitize *sanitize) isSanitizerEnabled(t SanitizerType) bool {
Vishwath Mohanb743e9c2017-11-01 09:20:21 +0000893 if sanitize == nil {
894 return false
895 }
896
897 sanitizerVal := sanitize.getSanitizerBoolPtr(t)
898 return sanitizerVal != nil && *sanitizerVal == true
899}
900
Ivan Lozano3968d8f2020-12-14 11:27:52 -0500901// IsSanitizableDependencyTag returns true if the dependency tag is sanitizable.
902func IsSanitizableDependencyTag(tag blueprint.DependencyTag) bool {
Colin Cross6e511a92020-07-27 21:26:48 -0700903 switch t := tag.(type) {
904 case dependencyTag:
905 return t == reuseObjTag || t == objDepTag
906 case libraryDependencyTag:
907 return true
908 default:
909 return false
910 }
Colin Cross6b753602018-06-21 13:03:07 -0700911}
912
Ivan Lozano3968d8f2020-12-14 11:27:52 -0500913func (m *Module) SanitizableDepTagChecker() SantizableDependencyTagChecker {
914 return IsSanitizableDependencyTag
915}
916
Inseob Kimc42f2f22020-07-29 20:32:10 +0900917// Determines if the current module is a static library going to be captured
918// as vendor snapshot. Such modules must create both cfi and non-cfi variants,
919// except for ones which explicitly disable cfi.
920func needsCfiForVendorSnapshot(mctx android.TopDownMutatorContext) bool {
Kiyoung Kim48f37782021-07-07 12:42:39 +0900921 if snapshot.IsVendorProprietaryModule(mctx) {
Inseob Kimc42f2f22020-07-29 20:32:10 +0900922 return false
923 }
924
Ivan Lozano3968d8f2020-12-14 11:27:52 -0500925 c := mctx.Module().(PlatformSanitizeable)
Inseob Kimc42f2f22020-07-29 20:32:10 +0900926
Ivan Lozano3968d8f2020-12-14 11:27:52 -0500927 if !c.InVendor() {
Inseob Kimc42f2f22020-07-29 20:32:10 +0900928 return false
929 }
930
Ivan Lozano3968d8f2020-12-14 11:27:52 -0500931 if !c.StaticallyLinked() {
Inseob Kimc42f2f22020-07-29 20:32:10 +0900932 return false
933 }
934
Ivan Lozano3968d8f2020-12-14 11:27:52 -0500935 if c.IsPrebuilt() {
Inseob Kimc42f2f22020-07-29 20:32:10 +0900936 return false
937 }
938
Ivan Lozano3968d8f2020-12-14 11:27:52 -0500939 if !c.SanitizerSupported(cfi) {
940 return false
941 }
942
943 return c.SanitizePropDefined() &&
944 !c.SanitizeNever() &&
945 !c.IsSanitizerExplicitlyDisabled(cfi)
Inseob Kimc42f2f22020-07-29 20:32:10 +0900946}
947
Evgenii Stepanovd97a6e92018-08-02 16:19:13 -0700948// Propagate sanitizer requirements down from binaries
Ivan Lozano3968d8f2020-12-14 11:27:52 -0500949func sanitizerDepsMutator(t SanitizerType) func(android.TopDownMutatorContext) {
Colin Cross635c3b02016-05-18 15:37:25 -0700950 return func(mctx android.TopDownMutatorContext) {
Ivan Lozano3968d8f2020-12-14 11:27:52 -0500951 if c, ok := mctx.Module().(PlatformSanitizeable); ok {
952 enabled := c.IsSanitizerEnabled(t)
Inseob Kimc42f2f22020-07-29 20:32:10 +0900953 if t == cfi && needsCfiForVendorSnapshot(mctx) {
954 // We shouldn't change the result of isSanitizerEnabled(cfi) to correctly
955 // determine defaultVariation in sanitizerMutator below.
956 // Instead, just mark SanitizeDep to forcefully create cfi variant.
957 enabled = true
Ivan Lozano3968d8f2020-12-14 11:27:52 -0500958 c.SetSanitizeDep(true)
Inseob Kimc42f2f22020-07-29 20:32:10 +0900959 }
960 if enabled {
Ivan Lozano3968d8f2020-12-14 11:27:52 -0500961 isSanitizableDependencyTag := c.SanitizableDepTagChecker()
Inseob Kimc42f2f22020-07-29 20:32:10 +0900962 mctx.WalkDeps(func(child, parent android.Module) bool {
963 if !isSanitizableDependencyTag(mctx.OtherModuleDependencyTag(child)) {
964 return false
965 }
Ivan Lozano3968d8f2020-12-14 11:27:52 -0500966 if d, ok := child.(PlatformSanitizeable); ok && d.SanitizePropDefined() &&
967 !d.SanitizeNever() &&
968 !d.IsSanitizerExplicitlyDisabled(t) {
Colin Crossaf98f582021-05-12 17:27:32 -0700969 if t == cfi || t == Hwasan || t == scs || t == Asan {
Ivan Lozano3968d8f2020-12-14 11:27:52 -0500970 if d.StaticallyLinked() && d.SanitizerSupported(t) {
971 // Rust does not support some of these sanitizers, so we need to check if it's
972 // supported before setting this true.
973 d.SetSanitizeDep(true)
Inseob Kimc42f2f22020-07-29 20:32:10 +0900974 }
975 } else {
Ivan Lozano3968d8f2020-12-14 11:27:52 -0500976 d.SetSanitizeDep(true)
Evgenii Stepanovd97a6e92018-08-02 16:19:13 -0700977 }
Vishwath Mohanb743e9c2017-11-01 09:20:21 +0000978 }
Inseob Kimc42f2f22020-07-29 20:32:10 +0900979 return true
980 })
981 }
Jiyong Parkf97782b2019-02-13 20:28:58 +0900982 } else if sanitizeable, ok := mctx.Module().(Sanitizeable); ok {
983 // If an APEX module includes a lib which is enabled for a sanitizer T, then
984 // the APEX module is also enabled for the same sanitizer type.
985 mctx.VisitDirectDeps(func(child android.Module) {
986 if c, ok := child.(*Module); ok && c.sanitize.isSanitizerEnabled(t) {
987 sanitizeable.EnableSanitizer(t.name())
988 }
989 })
Colin Cross16b23492016-01-06 14:41:07 -0800990 }
991 }
992}
993
Ivan Lozano3968d8f2020-12-14 11:27:52 -0500994func (c *Module) SanitizeNever() bool {
995 return Bool(c.sanitize.Properties.Sanitize.Never)
996}
997
998func (c *Module) IsSanitizerExplicitlyDisabled(t SanitizerType) bool {
999 return c.sanitize.isSanitizerExplicitlyDisabled(t)
1000}
1001
Ivan Lozano30c5db22018-02-21 15:49:20 -08001002// Propagate the ubsan minimal runtime dependency when there are integer overflow sanitized static dependencies.
Colin Cross6b753602018-06-21 13:03:07 -07001003func sanitizerRuntimeDepsMutator(mctx android.TopDownMutatorContext) {
Ivan Lozano3968d8f2020-12-14 11:27:52 -05001004 // Change this to PlatformSanitizable when/if non-cc modules support ubsan sanitizers.
Colin Cross6b753602018-06-21 13:03:07 -07001005 if c, ok := mctx.Module().(*Module); ok && c.sanitize != nil {
Ivan Lozano3968d8f2020-12-14 11:27:52 -05001006 isSanitizableDependencyTag := c.SanitizableDepTagChecker()
Colin Cross6b753602018-06-21 13:03:07 -07001007 mctx.WalkDeps(func(child, parent android.Module) bool {
1008 if !isSanitizableDependencyTag(mctx.OtherModuleDependencyTag(child)) {
1009 return false
1010 }
Ivan Lozano30c5db22018-02-21 15:49:20 -08001011
Inseob Kimeec88e12020-01-22 11:11:29 +09001012 d, ok := child.(*Module)
1013 if !ok || !d.static() {
1014 return false
1015 }
1016 if d.sanitize != nil {
Colin Cross6b753602018-06-21 13:03:07 -07001017 if enableMinimalRuntime(d.sanitize) {
1018 // If a static dependency is built with the minimal runtime,
1019 // make sure we include the ubsan minimal runtime.
1020 c.sanitize.Properties.MinimalRuntimeDep = true
Inseob Kim8471cda2019-11-15 09:59:12 +09001021 } else if enableUbsanRuntime(d.sanitize) {
Colin Cross6b753602018-06-21 13:03:07 -07001022 // If a static dependency runs with full ubsan diagnostics,
1023 // make sure we include the ubsan runtime.
1024 c.sanitize.Properties.UbsanRuntimeDep = true
Ivan Lozano30c5db22018-02-21 15:49:20 -08001025 }
Colin Cross0b908332019-06-19 23:00:20 -07001026
1027 if c.sanitize.Properties.MinimalRuntimeDep &&
1028 c.sanitize.Properties.UbsanRuntimeDep {
1029 // both flags that this mutator might set are true, so don't bother recursing
1030 return false
1031 }
1032
Ivan Lozano9ac32c72020-02-19 15:24:02 -05001033 if c.Os() == android.Linux {
1034 c.sanitize.Properties.BuiltinsDep = true
1035 }
1036
Colin Cross0b908332019-06-19 23:00:20 -07001037 return true
Colin Cross6b753602018-06-21 13:03:07 -07001038 }
Inseob Kimeec88e12020-01-22 11:11:29 +09001039
Jose Galmesf7294582020-11-13 12:07:36 -08001040 if p, ok := d.linker.(*snapshotLibraryDecorator); ok {
Inseob Kimeec88e12020-01-22 11:11:29 +09001041 if Bool(p.properties.Sanitize_minimal_dep) {
1042 c.sanitize.Properties.MinimalRuntimeDep = true
1043 }
1044 if Bool(p.properties.Sanitize_ubsan_dep) {
1045 c.sanitize.Properties.UbsanRuntimeDep = true
1046 }
1047 }
1048
1049 return false
Colin Cross6b753602018-06-21 13:03:07 -07001050 })
Ivan Lozano30c5db22018-02-21 15:49:20 -08001051 }
1052}
1053
Jiyong Park379de2f2018-12-19 02:47:14 +09001054// Add the dependency to the runtime library for each of the sanitizer variants
1055func sanitizerRuntimeMutator(mctx android.BottomUpMutatorContext) {
Jiyong Park379de2f2018-12-19 02:47:14 +09001056 if c, ok := mctx.Module().(*Module); ok && c.sanitize != nil {
Pirama Arumuga Nainar6aa21022019-01-25 00:20:35 +00001057 if !c.Enabled() {
1058 return
1059 }
Jiyong Park379de2f2018-12-19 02:47:14 +09001060 var sanitizers []string
1061 var diagSanitizers []string
1062
1063 if Bool(c.sanitize.Properties.Sanitize.All_undefined) {
1064 sanitizers = append(sanitizers, "undefined")
1065 } else {
1066 if Bool(c.sanitize.Properties.Sanitize.Undefined) {
1067 sanitizers = append(sanitizers,
1068 "bool",
1069 "integer-divide-by-zero",
1070 "return",
1071 "returns-nonnull-attribute",
1072 "shift-exponent",
1073 "unreachable",
1074 "vla-bound",
1075 // TODO(danalbert): The following checks currently have compiler performance issues.
1076 //"alignment",
1077 //"bounds",
1078 //"enum",
1079 //"float-cast-overflow",
1080 //"float-divide-by-zero",
1081 //"nonnull-attribute",
1082 //"null",
1083 //"shift-base",
1084 //"signed-integer-overflow",
1085 // TODO(danalbert): Fix UB in libc++'s __tree so we can turn this on.
1086 // https://llvm.org/PR19302
1087 // http://reviews.llvm.org/D6974
1088 // "object-size",
1089 )
1090 }
1091 sanitizers = append(sanitizers, c.sanitize.Properties.Sanitize.Misc_undefined...)
1092 }
1093
1094 if Bool(c.sanitize.Properties.Sanitize.Diag.Undefined) {
1095 diagSanitizers = append(diagSanitizers, "undefined")
1096 }
1097
1098 diagSanitizers = append(diagSanitizers, c.sanitize.Properties.Sanitize.Diag.Misc_undefined...)
1099
1100 if Bool(c.sanitize.Properties.Sanitize.Address) {
1101 sanitizers = append(sanitizers, "address")
1102 diagSanitizers = append(diagSanitizers, "address")
1103 }
1104
1105 if Bool(c.sanitize.Properties.Sanitize.Hwaddress) {
1106 sanitizers = append(sanitizers, "hwaddress")
1107 }
1108
1109 if Bool(c.sanitize.Properties.Sanitize.Thread) {
1110 sanitizers = append(sanitizers, "thread")
1111 }
1112
1113 if Bool(c.sanitize.Properties.Sanitize.Safestack) {
1114 sanitizers = append(sanitizers, "safe-stack")
1115 }
1116
1117 if Bool(c.sanitize.Properties.Sanitize.Cfi) {
1118 sanitizers = append(sanitizers, "cfi")
1119
1120 if Bool(c.sanitize.Properties.Sanitize.Diag.Cfi) {
1121 diagSanitizers = append(diagSanitizers, "cfi")
1122 }
1123 }
1124
1125 if Bool(c.sanitize.Properties.Sanitize.Integer_overflow) {
1126 sanitizers = append(sanitizers, "unsigned-integer-overflow")
1127 sanitizers = append(sanitizers, "signed-integer-overflow")
1128 if Bool(c.sanitize.Properties.Sanitize.Diag.Integer_overflow) {
1129 diagSanitizers = append(diagSanitizers, "unsigned-integer-overflow")
1130 diagSanitizers = append(diagSanitizers, "signed-integer-overflow")
1131 }
1132 }
1133
1134 if Bool(c.sanitize.Properties.Sanitize.Scudo) {
1135 sanitizers = append(sanitizers, "scudo")
1136 }
1137
1138 if Bool(c.sanitize.Properties.Sanitize.Scs) {
1139 sanitizers = append(sanitizers, "shadow-call-stack")
1140 }
1141
Ivan Lozanod7586b62021-04-01 09:49:36 -04001142 if Bool(c.sanitize.Properties.Sanitize.Memtag_heap) && c.Binary() {
Evgenii Stepanov193ac2e2020-04-28 15:09:12 -07001143 noteDep := "note_memtag_heap_async"
1144 if Bool(c.sanitize.Properties.Sanitize.Diag.Memtag_heap) {
1145 noteDep = "note_memtag_heap_sync"
1146 }
Inseob Kim253f5212021-04-08 17:10:31 +09001147 // If we're using snapshots, redirect to snapshot whenever possible
1148 // TODO(b/178470649): clean manual snapshot redirections
1149 snapshot := mctx.Provider(SnapshotInfoProvider).(SnapshotInfo)
1150 if lib, ok := snapshot.StaticLibs[noteDep]; ok {
1151 noteDep = lib
1152 }
Ivan Lozano62cd0382021-11-01 10:27:54 -04001153 depTag := StaticDepTag(true)
Evgenii Stepanov193ac2e2020-04-28 15:09:12 -07001154 variations := append(mctx.Target().Variations(),
1155 blueprint.Variation{Mutator: "link", Variation: "static"})
1156 if c.Device() {
1157 variations = append(variations, c.ImageVariation())
1158 }
1159 mctx.AddFarVariationDependencies(variations, depTag, noteDep)
1160 }
1161
Mitch Phillips5a6ea6c2019-05-01 14:42:05 -07001162 if Bool(c.sanitize.Properties.Sanitize.Fuzzer) {
1163 sanitizers = append(sanitizers, "fuzzer-no-link")
1164 }
1165
Jiyong Park379de2f2018-12-19 02:47:14 +09001166 // Save the list of sanitizers. These will be used again when generating
1167 // the build rules (for Cflags, etc.)
1168 c.sanitize.Properties.Sanitizers = sanitizers
1169 c.sanitize.Properties.DiagSanitizers = diagSanitizers
1170
Ivan Lozanof3b190f2020-03-06 12:01:21 -05001171 // TODO(b/150822854) Hosts have a different default behavior and assume the runtime library is used.
1172 if c.Host() {
1173 diagSanitizers = sanitizers
1174 }
1175
Jiyong Park379de2f2018-12-19 02:47:14 +09001176 // Determine the runtime library required
1177 runtimeLibrary := ""
Ryan Prichardb49fe1b2019-10-11 15:03:34 -07001178 var extraStaticDeps []string
Jiyong Park379de2f2018-12-19 02:47:14 +09001179 toolchain := c.toolchain(mctx)
1180 if Bool(c.sanitize.Properties.Sanitize.Address) {
1181 runtimeLibrary = config.AddressSanitizerRuntimeLibrary(toolchain)
1182 } else if Bool(c.sanitize.Properties.Sanitize.Hwaddress) {
1183 if c.staticBinary() {
1184 runtimeLibrary = config.HWAddressSanitizerStaticLibrary(toolchain)
Ryan Prichardb49fe1b2019-10-11 15:03:34 -07001185 extraStaticDeps = []string{"libdl"}
Jiyong Park379de2f2018-12-19 02:47:14 +09001186 } else {
1187 runtimeLibrary = config.HWAddressSanitizerRuntimeLibrary(toolchain)
1188 }
1189 } else if Bool(c.sanitize.Properties.Sanitize.Thread) {
1190 runtimeLibrary = config.ThreadSanitizerRuntimeLibrary(toolchain)
1191 } else if Bool(c.sanitize.Properties.Sanitize.Scudo) {
1192 if len(diagSanitizers) == 0 && !c.sanitize.Properties.UbsanRuntimeDep {
1193 runtimeLibrary = config.ScudoMinimalRuntimeLibrary(toolchain)
1194 } else {
1195 runtimeLibrary = config.ScudoRuntimeLibrary(toolchain)
1196 }
Mitch Phillipsb8e593d2019-10-09 17:18:59 -07001197 } else if len(diagSanitizers) > 0 || c.sanitize.Properties.UbsanRuntimeDep ||
Ivan Lozano9ac32c72020-02-19 15:24:02 -05001198 Bool(c.sanitize.Properties.Sanitize.Fuzzer) ||
1199 Bool(c.sanitize.Properties.Sanitize.Undefined) ||
1200 Bool(c.sanitize.Properties.Sanitize.All_undefined) {
Jiyong Park379de2f2018-12-19 02:47:14 +09001201 runtimeLibrary = config.UndefinedBehaviorSanitizerRuntimeLibrary(toolchain)
Colin Cross32f1de32021-03-29 13:41:37 -07001202 if c.staticBinary() {
1203 runtimeLibrary += ".static"
1204 }
Jiyong Park379de2f2018-12-19 02:47:14 +09001205 }
1206
Ivan Lozano9ac32c72020-02-19 15:24:02 -05001207 if runtimeLibrary != "" && (toolchain.Bionic() || c.sanitize.Properties.UbsanRuntimeDep) {
1208 // UBSan is supported on non-bionic linux host builds as well
Jiyong Park379de2f2018-12-19 02:47:14 +09001209
1210 // Adding dependency to the runtime library. We are using *FarVariation*
1211 // because the runtime libraries themselves are not mutated by sanitizer
1212 // mutators and thus don't have sanitizer variants whereas this module
1213 // has been already mutated.
1214 //
1215 // Note that by adding dependency with {static|shared}DepTag, the lib is
1216 // added to libFlags and LOCAL_SHARED_LIBRARIES by cc.Module
1217 if c.staticBinary() {
Inseob Kimeec88e12020-01-22 11:11:29 +09001218 deps := append(extraStaticDeps, runtimeLibrary)
Colin Crosse0edaf92021-01-11 17:31:17 -08001219 // If we're using snapshots, redirect to snapshot whenever possible
1220 snapshot := mctx.Provider(SnapshotInfoProvider).(SnapshotInfo)
1221 for idx, dep := range deps {
1222 if lib, ok := snapshot.StaticLibs[dep]; ok {
1223 deps[idx] = lib
Inseob Kimeec88e12020-01-22 11:11:29 +09001224 }
1225 }
1226
Jiyong Park379de2f2018-12-19 02:47:14 +09001227 // static executable gets static runtime libs
Colin Cross6e511a92020-07-27 21:26:48 -07001228 depTag := libraryDependencyTag{Kind: staticLibraryDependency}
Colin Cross42507332020-08-21 16:15:23 -07001229 variations := append(mctx.Target().Variations(),
1230 blueprint.Variation{Mutator: "link", Variation: "static"})
1231 if c.Device() {
1232 variations = append(variations, c.ImageVariation())
1233 }
1234 mctx.AddFarVariationDependencies(variations, depTag, deps...)
Ivan Lozano3968d8f2020-12-14 11:27:52 -05001235 } else if !c.static() && !c.Header() {
Colin Crosse0edaf92021-01-11 17:31:17 -08001236 // If we're using snapshots, redirect to snapshot whenever possible
1237 snapshot := mctx.Provider(SnapshotInfoProvider).(SnapshotInfo)
1238 if lib, ok := snapshot.SharedLibs[runtimeLibrary]; ok {
1239 runtimeLibrary = lib
Inseob Kimeec88e12020-01-22 11:11:29 +09001240 }
Colin Crosse0edaf92021-01-11 17:31:17 -08001241
Cindy Zhou18417cb2020-12-10 07:12:38 -08001242 // Skip apex dependency check for sharedLibraryDependency
1243 // when sanitizer diags are enabled. Skipping the check will allow
1244 // building with diag libraries without having to list the
1245 // dependency in Apex's allowed_deps file.
1246 diagEnabled := len(diagSanitizers) > 0
Jiyong Park3b1746a2019-01-29 11:15:04 +09001247 // dynamic executable and shared libs get shared runtime libs
Cindy Zhou18417cb2020-12-10 07:12:38 -08001248 depTag := libraryDependencyTag{
1249 Kind: sharedLibraryDependency,
1250 Order: earlyLibraryDependency,
1251
1252 skipApexAllowedDependenciesCheck: diagEnabled,
1253 }
Colin Cross42507332020-08-21 16:15:23 -07001254 variations := append(mctx.Target().Variations(),
1255 blueprint.Variation{Mutator: "link", Variation: "shared"})
1256 if c.Device() {
1257 variations = append(variations, c.ImageVariation())
1258 }
Ivan Lozanod67a6b02021-05-20 13:01:32 -04001259 AddSharedLibDependenciesWithVersions(mctx, c, variations, depTag, runtimeLibrary, "", true)
Jiyong Park379de2f2018-12-19 02:47:14 +09001260 }
1261 // static lib does not have dependency to the runtime library. The
1262 // dependency will be added to the executables or shared libs using
1263 // the static lib.
1264 }
1265 }
1266}
1267
1268type Sanitizeable interface {
1269 android.Module
Jiyong Park388ef3f2019-01-28 19:47:32 +09001270 IsSanitizerEnabled(ctx android.BaseModuleContext, sanitizerName string) bool
Jiyong Parkf97782b2019-02-13 20:28:58 +09001271 EnableSanitizer(sanitizerName string)
Jooyung Han8ce8db92020-05-15 19:05:05 +09001272 AddSanitizerDependencies(ctx android.BottomUpMutatorContext, sanitizerName string)
Jiyong Park379de2f2018-12-19 02:47:14 +09001273}
1274
Ivan Lozanod7586b62021-04-01 09:49:36 -04001275func (c *Module) MinimalRuntimeDep() bool {
1276 return c.sanitize.Properties.MinimalRuntimeDep
1277}
1278
1279func (c *Module) UbsanRuntimeDep() bool {
1280 return c.sanitize.Properties.UbsanRuntimeDep
1281}
1282
Ivan Lozano3968d8f2020-12-14 11:27:52 -05001283func (c *Module) SanitizePropDefined() bool {
1284 return c.sanitize != nil
1285}
1286
1287func (c *Module) IsSanitizerEnabled(t SanitizerType) bool {
1288 return c.sanitize.isSanitizerEnabled(t)
1289}
1290
1291func (c *Module) SanitizeDep() bool {
1292 return c.sanitize.Properties.SanitizeDep
1293}
1294
1295func (c *Module) StaticallyLinked() bool {
1296 return c.static()
1297}
1298
1299func (c *Module) SetInSanitizerDir() {
1300 if c.sanitize != nil {
1301 c.sanitize.Properties.InSanitizerDir = true
1302 }
1303}
1304
1305func (c *Module) SetSanitizer(t SanitizerType, b bool) {
1306 if c.sanitize != nil {
1307 c.sanitize.SetSanitizer(t, b)
1308 }
1309}
1310
1311func (c *Module) SetSanitizeDep(b bool) {
1312 if c.sanitize != nil {
1313 c.sanitize.Properties.SanitizeDep = b
1314 }
1315}
1316
1317var _ PlatformSanitizeable = (*Module)(nil)
1318
Vishwath Mohanb743e9c2017-11-01 09:20:21 +00001319// Create sanitized variants for modules that need them
Ivan Lozano3968d8f2020-12-14 11:27:52 -05001320func sanitizerMutator(t SanitizerType) func(android.BottomUpMutatorContext) {
Colin Cross635c3b02016-05-18 15:37:25 -07001321 return func(mctx android.BottomUpMutatorContext) {
Ivan Lozano3968d8f2020-12-14 11:27:52 -05001322 if c, ok := mctx.Module().(PlatformSanitizeable); ok && c.SanitizePropDefined() {
Ivan Lozano5482d6a2021-11-01 10:13:25 -04001323
1324 // Make sure we're not setting CFI to any value if it's not supported.
1325 cfiSupported := mctx.Module().(PlatformSanitizeable).SanitizerSupported(cfi)
1326
Liz Kammer187d5442021-06-25 14:50:12 -04001327 if c.Binary() && c.IsSanitizerEnabled(t) {
Jiyong Park82226632019-02-01 10:50:50 +09001328 modules := mctx.CreateVariations(t.variationName())
Ivan Lozano3968d8f2020-12-14 11:27:52 -05001329 modules[0].(PlatformSanitizeable).SetSanitizer(t, true)
1330 } else if c.IsSanitizerEnabled(t) || c.SanitizeDep() {
1331 isSanitizerEnabled := c.IsSanitizerEnabled(t)
Colin Crossaf98f582021-05-12 17:27:32 -07001332 if c.StaticallyLinked() || c.Header() || t == Fuzzer {
Jiyong Park1d1119f2019-07-29 21:27:18 +09001333 // Static and header libs are split into non-sanitized and sanitized variants.
1334 // Shared libs are not split. However, for asan and fuzzer, we split even for shared
1335 // libs because a library sanitized for asan/fuzzer can't be linked from a library
1336 // that isn't sanitized for asan/fuzzer.
1337 //
1338 // Note for defaultVariation: since we don't split for shared libs but for static/header
1339 // libs, it is possible for the sanitized variant of a static/header lib to depend
1340 // on non-sanitized variant of a shared lib. Such unfulfilled variation causes an
1341 // error when the module is split. defaultVariation is the name of the variation that
1342 // will be used when such a dangling dependency occurs during the split of the current
1343 // module. By setting it to the name of the sanitized variation, the dangling dependency
1344 // is redirected to the sanitized variant of the dependent module.
1345 defaultVariation := t.variationName()
Ivan Lozano3968d8f2020-12-14 11:27:52 -05001346 // Not all PlatformSanitizeable modules support the CFI sanitizer
Jiyong Park1d1119f2019-07-29 21:27:18 +09001347 mctx.SetDefaultDependencyVariation(&defaultVariation)
Vishwath Mohanb743e9c2017-11-01 09:20:21 +00001348
Ivan Lozano3968d8f2020-12-14 11:27:52 -05001349 modules := mctx.CreateVariations("", t.variationName())
1350 modules[0].(PlatformSanitizeable).SetSanitizer(t, false)
1351 modules[1].(PlatformSanitizeable).SetSanitizer(t, true)
1352 modules[0].(PlatformSanitizeable).SetSanitizeDep(false)
1353 modules[1].(PlatformSanitizeable).SetSanitizeDep(false)
1354
1355 if mctx.Device() && t.incompatibleWithCfi() && cfiSupported {
Ivan Lozano4774a812020-03-10 16:23:57 -04001356 // TODO: Make sure that cfi mutator runs "after" any of the sanitizers that
1357 // are incompatible with cfi
Ivan Lozano3968d8f2020-12-14 11:27:52 -05001358 modules[1].(PlatformSanitizeable).SetSanitizer(cfi, false)
Ivan Lozano4774a812020-03-10 16:23:57 -04001359 }
1360
Jiyong Park1d1119f2019-07-29 21:27:18 +09001361 // For cfi/scs/hwasan, we can export both sanitized and un-sanitized variants
1362 // to Make, because the sanitized version has a different suffix in name.
1363 // For other types of sanitizers, suppress the variation that is disabled.
Tri Vo6eafc362021-04-01 11:29:09 -07001364 if t != cfi && t != scs && t != Hwasan {
Jiyong Park1d1119f2019-07-29 21:27:18 +09001365 if isSanitizerEnabled {
Ivan Lozano3968d8f2020-12-14 11:27:52 -05001366 modules[0].(PlatformSanitizeable).SetPreventInstall()
1367 modules[0].(PlatformSanitizeable).SetHideFromMake()
Jiyong Park1d1119f2019-07-29 21:27:18 +09001368 } else {
Ivan Lozano3968d8f2020-12-14 11:27:52 -05001369 modules[1].(PlatformSanitizeable).SetPreventInstall()
1370 modules[1].(PlatformSanitizeable).SetHideFromMake()
Jiyong Park1d1119f2019-07-29 21:27:18 +09001371 }
1372 }
Vishwath Mohanb743e9c2017-11-01 09:20:21 +00001373
Jiyong Park1d1119f2019-07-29 21:27:18 +09001374 // Export the static lib name to make
Ivan Lozano3968d8f2020-12-14 11:27:52 -05001375 if c.StaticallyLinked() && c.ExportedToMake() {
Jiyong Park1d1119f2019-07-29 21:27:18 +09001376 if t == cfi {
Ivan Lozano3968d8f2020-12-14 11:27:52 -05001377 cfiStaticLibs(mctx.Config()).add(c, c.Module().Name())
Tri Vo6eafc362021-04-01 11:29:09 -07001378 } else if t == Hwasan {
Ivan Lozano3968d8f2020-12-14 11:27:52 -05001379 hwasanStaticLibs(mctx.Config()).add(c, c.Module().Name())
Jiyong Park1d1119f2019-07-29 21:27:18 +09001380 }
1381 }
1382 } else {
1383 // Shared libs are not split. Only the sanitized variant is created.
1384 modules := mctx.CreateVariations(t.variationName())
Ivan Lozano3968d8f2020-12-14 11:27:52 -05001385 modules[0].(PlatformSanitizeable).SetSanitizer(t, true)
1386 modules[0].(PlatformSanitizeable).SetSanitizeDep(false)
Vishwath Mohane7128792017-11-17 11:08:10 -08001387
Jiyong Park1d1119f2019-07-29 21:27:18 +09001388 // locate the asan libraries under /data/asan
Ivan Lozano3968d8f2020-12-14 11:27:52 -05001389 if mctx.Device() && t == Asan && isSanitizerEnabled {
1390 modules[0].(PlatformSanitizeable).SetInSanitizerDir()
Evgenii Stepanovd97a6e92018-08-02 16:19:13 -07001391 }
Ivan Lozano4774a812020-03-10 16:23:57 -04001392
Ivan Lozano5482d6a2021-11-01 10:13:25 -04001393 if mctx.Device() && t.incompatibleWithCfi() && cfiSupported {
Ivan Lozano4774a812020-03-10 16:23:57 -04001394 // TODO: Make sure that cfi mutator runs "after" any of the sanitizers that
1395 // are incompatible with cfi
Ivan Lozano3968d8f2020-12-14 11:27:52 -05001396 modules[0].(PlatformSanitizeable).SetSanitizer(cfi, false)
Ivan Lozano4774a812020-03-10 16:23:57 -04001397 }
Vishwath Mohane21fe422017-11-01 19:42:45 -07001398 }
Colin Cross16b23492016-01-06 14:41:07 -08001399 }
Ivan Lozano3968d8f2020-12-14 11:27:52 -05001400 c.SetSanitizeDep(false)
Jiyong Park82226632019-02-01 10:50:50 +09001401 } else if sanitizeable, ok := mctx.Module().(Sanitizeable); ok && sanitizeable.IsSanitizerEnabled(mctx, t.name()) {
Jiyong Park379de2f2018-12-19 02:47:14 +09001402 // APEX modules fall here
Jooyung Han8ce8db92020-05-15 19:05:05 +09001403 sanitizeable.AddSanitizerDependencies(mctx, t.name())
Jiyong Park82226632019-02-01 10:50:50 +09001404 mctx.CreateVariations(t.variationName())
Inseob Kimc42f2f22020-07-29 20:32:10 +09001405 } else if c, ok := mctx.Module().(*Module); ok {
Ivan Lozano3968d8f2020-12-14 11:27:52 -05001406 //TODO: When Rust modules have vendor support, enable this path for PlatformSanitizeable
1407
Inseob Kimc42f2f22020-07-29 20:32:10 +09001408 // Check if it's a snapshot module supporting sanitizer
1409 if s, ok := c.linker.(snapshotSanitizer); ok && s.isSanitizerEnabled(t) {
1410 // Set default variation as above.
1411 defaultVariation := t.variationName()
1412 mctx.SetDefaultDependencyVariation(&defaultVariation)
1413 modules := mctx.CreateVariations("", t.variationName())
1414 modules[0].(*Module).linker.(snapshotSanitizer).setSanitizerVariation(t, false)
1415 modules[1].(*Module).linker.(snapshotSanitizer).setSanitizerVariation(t, true)
1416
1417 // Export the static lib name to make
1418 if c.static() && c.ExportedToMake() {
1419 if t == cfi {
1420 // use BaseModuleName which is the name for Make.
1421 cfiStaticLibs(mctx.Config()).add(c, c.BaseModuleName())
1422 }
1423 }
1424 }
Colin Cross16b23492016-01-06 14:41:07 -08001425 }
1426 }
1427}
Vishwath Mohane7128792017-11-17 11:08:10 -08001428
Inseob Kim74d25562020-08-04 00:41:38 +09001429type sanitizerStaticLibsMap struct {
1430 // libsMap contains one list of modules per each image and each arch.
1431 // e.g. libs[vendor]["arm"] contains arm modules installed to vendor
Ivan Lozano3968d8f2020-12-14 11:27:52 -05001432 libsMap map[ImageVariantType]map[string][]string
Inseob Kim74d25562020-08-04 00:41:38 +09001433 libsMapLock sync.Mutex
Ivan Lozano3968d8f2020-12-14 11:27:52 -05001434 sanitizerType SanitizerType
Inseob Kim74d25562020-08-04 00:41:38 +09001435}
1436
Ivan Lozano3968d8f2020-12-14 11:27:52 -05001437func newSanitizerStaticLibsMap(t SanitizerType) *sanitizerStaticLibsMap {
Inseob Kim74d25562020-08-04 00:41:38 +09001438 return &sanitizerStaticLibsMap{
1439 sanitizerType: t,
Ivan Lozano3968d8f2020-12-14 11:27:52 -05001440 libsMap: make(map[ImageVariantType]map[string][]string),
Inseob Kim74d25562020-08-04 00:41:38 +09001441 }
1442}
1443
1444// Add the current module to sanitizer static libs maps
1445// Each module should pass its exported name as names of Make and Soong can differ.
Ivan Lozano3968d8f2020-12-14 11:27:52 -05001446func (s *sanitizerStaticLibsMap) add(c LinkableInterface, name string) {
1447 image := GetImageVariantType(c)
1448 arch := c.Module().Target().Arch.ArchType.String()
Inseob Kim74d25562020-08-04 00:41:38 +09001449
1450 s.libsMapLock.Lock()
1451 defer s.libsMapLock.Unlock()
1452
1453 if _, ok := s.libsMap[image]; !ok {
1454 s.libsMap[image] = make(map[string][]string)
1455 }
1456
1457 s.libsMap[image][arch] = append(s.libsMap[image][arch], name)
1458}
1459
1460// Exports makefile variables in the following format:
1461// SOONG_{sanitizer}_{image}_{arch}_STATIC_LIBRARIES
1462// e.g. SOONG_cfi_core_x86_STATIC_LIBRARIES
1463// These are to be used by use_soong_sanitized_static_libraries.
1464// See build/make/core/binary.mk for more details.
1465func (s *sanitizerStaticLibsMap) exportToMake(ctx android.MakeVarsContext) {
1466 for _, image := range android.SortedStringKeys(s.libsMap) {
Ivan Lozano3968d8f2020-12-14 11:27:52 -05001467 archMap := s.libsMap[ImageVariantType(image)]
Inseob Kim74d25562020-08-04 00:41:38 +09001468 for _, arch := range android.SortedStringKeys(archMap) {
1469 libs := archMap[arch]
1470 sort.Strings(libs)
1471
1472 key := fmt.Sprintf(
1473 "SOONG_%s_%s_%s_STATIC_LIBRARIES",
1474 s.sanitizerType.variationName(),
1475 image, // already upper
1476 arch)
1477
1478 ctx.Strict(key, strings.Join(libs, " "))
1479 }
1480 }
1481}
1482
Colin Cross571cccf2019-02-04 11:22:08 -08001483var cfiStaticLibsKey = android.NewOnceKey("cfiStaticLibs")
1484
Inseob Kim74d25562020-08-04 00:41:38 +09001485func cfiStaticLibs(config android.Config) *sanitizerStaticLibsMap {
Colin Cross571cccf2019-02-04 11:22:08 -08001486 return config.Once(cfiStaticLibsKey, func() interface{} {
Inseob Kim74d25562020-08-04 00:41:38 +09001487 return newSanitizerStaticLibsMap(cfi)
1488 }).(*sanitizerStaticLibsMap)
Vishwath Mohane7128792017-11-17 11:08:10 -08001489}
1490
Colin Cross571cccf2019-02-04 11:22:08 -08001491var hwasanStaticLibsKey = android.NewOnceKey("hwasanStaticLibs")
1492
Inseob Kim74d25562020-08-04 00:41:38 +09001493func hwasanStaticLibs(config android.Config) *sanitizerStaticLibsMap {
Colin Cross571cccf2019-02-04 11:22:08 -08001494 return config.Once(hwasanStaticLibsKey, func() interface{} {
Tri Vo6eafc362021-04-01 11:29:09 -07001495 return newSanitizerStaticLibsMap(Hwasan)
Inseob Kim74d25562020-08-04 00:41:38 +09001496 }).(*sanitizerStaticLibsMap)
Jiyong Park1d1119f2019-07-29 21:27:18 +09001497}
1498
Ivan Lozano30c5db22018-02-21 15:49:20 -08001499func enableMinimalRuntime(sanitize *sanitize) bool {
1500 if !Bool(sanitize.Properties.Sanitize.Address) &&
Evgenii Stepanovd97a6e92018-08-02 16:19:13 -07001501 !Bool(sanitize.Properties.Sanitize.Hwaddress) &&
Mitch Phillips5a6ea6c2019-05-01 14:42:05 -07001502 !Bool(sanitize.Properties.Sanitize.Fuzzer) &&
Ivan Lozano9ac32c72020-02-19 15:24:02 -05001503
Ivan Lozano30c5db22018-02-21 15:49:20 -08001504 (Bool(sanitize.Properties.Sanitize.Integer_overflow) ||
Ivan Lozano9ac32c72020-02-19 15:24:02 -05001505 len(sanitize.Properties.Sanitize.Misc_undefined) > 0 ||
1506 Bool(sanitize.Properties.Sanitize.Undefined) ||
1507 Bool(sanitize.Properties.Sanitize.All_undefined)) &&
1508
Ivan Lozano30c5db22018-02-21 15:49:20 -08001509 !(Bool(sanitize.Properties.Sanitize.Diag.Integer_overflow) ||
1510 Bool(sanitize.Properties.Sanitize.Diag.Cfi) ||
Ivan Lozano9ac32c72020-02-19 15:24:02 -05001511 Bool(sanitize.Properties.Sanitize.Diag.Undefined) ||
Ivan Lozano30c5db22018-02-21 15:49:20 -08001512 len(sanitize.Properties.Sanitize.Diag.Misc_undefined) > 0) {
Ivan Lozano9ac32c72020-02-19 15:24:02 -05001513
Ivan Lozano30c5db22018-02-21 15:49:20 -08001514 return true
1515 }
1516 return false
1517}
1518
Ivan Lozanod7586b62021-04-01 09:49:36 -04001519func (m *Module) UbsanRuntimeNeeded() bool {
1520 return enableUbsanRuntime(m.sanitize)
1521}
1522
1523func (m *Module) MinimalRuntimeNeeded() bool {
1524 return enableMinimalRuntime(m.sanitize)
1525}
1526
Inseob Kim8471cda2019-11-15 09:59:12 +09001527func enableUbsanRuntime(sanitize *sanitize) bool {
1528 return Bool(sanitize.Properties.Sanitize.Diag.Integer_overflow) ||
Ivan Lozano9ac32c72020-02-19 15:24:02 -05001529 Bool(sanitize.Properties.Sanitize.Diag.Undefined) ||
Inseob Kim8471cda2019-11-15 09:59:12 +09001530 len(sanitize.Properties.Sanitize.Diag.Misc_undefined) > 0
1531}
1532
Vishwath Mohane7128792017-11-17 11:08:10 -08001533func cfiMakeVarsProvider(ctx android.MakeVarsContext) {
Inseob Kim74d25562020-08-04 00:41:38 +09001534 cfiStaticLibs(ctx.Config()).exportToMake(ctx)
Vishwath Mohane7128792017-11-17 11:08:10 -08001535}
Evgenii Stepanovd97a6e92018-08-02 16:19:13 -07001536
1537func hwasanMakeVarsProvider(ctx android.MakeVarsContext) {
Inseob Kim74d25562020-08-04 00:41:38 +09001538 hwasanStaticLibs(ctx.Config()).exportToMake(ctx)
Evgenii Stepanovd97a6e92018-08-02 16:19:13 -07001539}