blob: e530de465babf610779f0b3d08681f19c390b3a1 [file] [log] [blame]
Alex Deymoaea4c1c2015-08-19 20:24:43 -07001//
2// Copyright (C) 2012 The Android Open Source Project
3//
4// Licensed under the Apache License, Version 2.0 (the "License");
5// you may not use this file except in compliance with the License.
6// You may obtain a copy of the License at
7//
8// http://www.apache.org/licenses/LICENSE-2.0
9//
10// Unless required by applicable law or agreed to in writing, software
11// distributed under the License is distributed on an "AS IS" BASIS,
12// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
13// See the License for the specific language governing permissions and
14// limitations under the License.
15//
Darin Petkov6a5b3222010-07-13 14:55:28 -070016
Alex Deymo8427b4a2014-11-05 14:00:32 -080017#include "update_engine/omaha_request_action.h"
18
Ben Chan9abb7632014-08-07 00:10:53 -070019#include <stdint.h>
20
Zentaro Kavanagh0ef9a2f2018-07-02 12:05:07 -070021#include <limits>
Ben Chanab5a0af2017-10-12 14:57:50 -070022#include <memory>
Darin Petkov6a5b3222010-07-13 14:55:28 -070023#include <string>
Zentaro Kavanagh1f899d52018-02-27 15:02:47 -080024#include <utility>
Darin Petkov6a5b3222010-07-13 14:55:28 -070025#include <vector>
Darin Petkov0dc8e9a2010-07-14 14:51:57 -070026
Alex Deymo60ca1a72015-06-18 18:19:15 -070027#include <base/bind.h>
Alex Deymo110e0302015-10-19 20:35:21 -070028#include <base/files/file_util.h>
Sen Jiang297e5832016-03-17 14:45:51 -070029#include <base/files/scoped_temp_dir.h>
Ben Chan5c02c132017-06-27 07:10:36 -070030#include <base/memory/ptr_util.h>
Alex Deymo8e18f932015-03-27 16:16:59 -070031#include <base/strings/string_number_conversions.h>
Alex Vakulenko75039d72014-03-25 12:36:28 -070032#include <base/strings/string_util.h>
33#include <base/strings/stringprintf.h>
34#include <base/time/time.h>
Alex Vakulenko3f39d5c2015-10-13 09:27:13 -070035#include <brillo/message_loops/fake_message_loop.h>
36#include <brillo/message_loops/message_loop.h>
37#include <brillo/message_loops/message_loop_utils.h>
Andrewe045aef2020-01-08 16:29:22 -080038#include <expat.h>
Alex Deymoe1e3afe2014-10-30 13:02:49 -070039#include <gtest/gtest.h>
Zentaro Kavanagh1f899d52018-02-27 15:02:47 -080040#include <policy/libpolicy.h>
41#include <policy/mock_libpolicy.h>
Jay Srinivasand29695d2013-04-08 15:08:05 -070042
Alex Deymo39910dc2015-11-09 17:04:30 -080043#include "update_engine/common/action_pipe.h"
44#include "update_engine/common/constants.h"
45#include "update_engine/common/fake_prefs.h"
46#include "update_engine/common/hash_calculator.h"
47#include "update_engine/common/mock_http_fetcher.h"
48#include "update_engine/common/platform_constants.h"
49#include "update_engine/common/prefs.h"
50#include "update_engine/common/test_utils.h"
Alex Deymoc1c17b42015-11-23 03:53:15 -030051#include "update_engine/fake_system_state.h"
Tianjie Xu282aa1f2017-09-05 13:42:45 -070052#include "update_engine/metrics_reporter_interface.h"
Chris Sosa77f79e82014-06-02 18:16:24 -070053#include "update_engine/mock_connection_manager.h"
Gilad Arnold74b5f552014-10-07 08:17:16 -070054#include "update_engine/mock_payload_state.h"
Amin Hassani7fca2862019-03-28 16:09:22 -070055#include "update_engine/omaha_request_builder_xml.h"
Darin Petkova4a8a8c2010-07-15 22:21:12 -070056#include "update_engine/omaha_request_params.h"
Jae Hoon Kim051627a2019-09-03 12:56:32 -070057#include "update_engine/omaha_utils.h"
Zentaro Kavanagh1f899d52018-02-27 15:02:47 -080058#include "update_engine/update_manager/rollback_prefs.h"
Darin Petkov6a5b3222010-07-13 14:55:28 -070059
Darin Petkov1cbd78f2010-07-29 12:38:34 -070060using base::Time;
61using base::TimeDelta;
Zentaro Kavanagh1f899d52018-02-27 15:02:47 -080062using chromeos_update_manager::kRollforwardInfinity;
Zentaro Kavanagh0ef9a2f2018-07-02 12:05:07 -070063using std::pair;
Darin Petkov6a5b3222010-07-13 14:55:28 -070064using std::string;
65using std::vector;
Amin Hassani7cc8bb02019-01-14 16:29:47 -080066using testing::_;
Darin Petkov1cbd78f2010-07-29 12:38:34 -070067using testing::AllOf;
Alex Deymof329b932014-10-30 01:37:48 -070068using testing::AnyNumber;
Jay Srinivasan34b5d862012-07-23 11:43:22 -070069using testing::DoAll;
Darin Petkov1cbd78f2010-07-29 12:38:34 -070070using testing::Ge;
71using testing::Le;
Darin Petkov9c096d62010-11-17 14:49:04 -080072using testing::NiceMock;
Darin Petkov1cbd78f2010-07-29 12:38:34 -070073using testing::Return;
Gilad Arnold74b5f552014-10-07 08:17:16 -070074using testing::ReturnPointee;
Amin Hassani7cc8bb02019-01-14 16:29:47 -080075using testing::ReturnRef;
Gilad Arnold74b5f552014-10-07 08:17:16 -070076using testing::SaveArg;
Ben Chan672c1f52017-10-23 15:41:39 -070077using testing::SetArgPointee;
Darin Petkov6a5b3222010-07-13 14:55:28 -070078
Alex Deymo8e18f932015-03-27 16:16:59 -070079namespace {
80
Zentaro Kavanagh1f899d52018-02-27 15:02:47 -080081static_assert(kRollforwardInfinity == 0xfffffffe,
82 "Don't change the value of kRollforward infinity unless its "
83 "size has been changed in firmware.");
84
Xiaochu Liu6310be62018-10-11 15:09:03 -070085const char kCurrentVersion[] = "0.1.0.0";
Alex Deymo85616652015-10-15 18:48:31 -070086const char kTestAppId[] = "test-app-id";
Aaron Wood7dcdedf2017-09-06 17:17:41 -070087const char kTestAppId2[] = "test-app2-id";
Xiaochu Liu6310be62018-10-11 15:09:03 -070088const char kTestAppIdSkipUpdatecheck[] = "test-app-id-skip-updatecheck";
Jae Hoon Kim5e9cd712020-02-12 15:28:28 -080089const char kDlcId1[] = "dlc-id-1";
90const char kDlcId2[] = "dlc-id-2";
Alex Deymo85616652015-10-15 18:48:31 -070091
Alex Deymo8e18f932015-03-27 16:16:59 -070092// This is a helper struct to allow unit tests build an update response with the
93// values they care about.
94struct FakeUpdateResponse {
Zentaro Kavanagh0ff621c2018-07-13 13:06:56 -070095 string GetRollbackVersionAttributes() const {
Zentaro Kavanagh0ef9a2f2018-07-02 12:05:07 -070096 string num_milestones;
Zentaro Kavanagh0ef9a2f2018-07-02 12:05:07 -070097 num_milestones = base::NumberToString(rollback_allowed_milestones);
Zentaro Kavanagh0ef9a2f2018-07-02 12:05:07 -070098 const string rollback_version =
99 " _firmware_version_" + num_milestones + "=\"" +
100 past_rollback_key_version.first + "\"" + " _kernel_version_" +
101 num_milestones + "=\"" + past_rollback_key_version.second + "\"";
102
103 return (rollback ? " _rollback=\"true\"" : "") + rollback_version +
Zentaro Kavanagh0ff621c2018-07-13 13:06:56 -0700104 (!rollback_firmware_version.empty()
105 ? " _firmware_version=\"" + rollback_firmware_version + "\""
106 : "") +
107 (!rollback_kernel_version.empty()
108 ? " _kernel_version=\"" + rollback_kernel_version + "\""
109 : "");
110 }
111
Alex Deymo8e18f932015-03-27 16:16:59 -0700112 string GetNoUpdateResponse() const {
113 string entity_str;
114 if (include_entity)
115 entity_str = "<!DOCTYPE response [<!ENTITY CrOS \"ChromeOS\">]>";
Sen Jiang81259682017-03-30 15:11:30 -0700116 return "<?xml version=\"1.0\" encoding=\"UTF-8\"?>" + entity_str +
117 "<response protocol=\"3.0\">"
118 "<daystart elapsed_seconds=\"100\"/>"
119 "<app appid=\"" +
120 app_id + "\" " +
121 (include_cohorts
122 ? "cohort=\"" + cohort + "\" cohorthint=\"" + cohorthint +
123 "\" cohortname=\"" + cohortname + "\" "
124 : "") +
125 " status=\"ok\">"
126 "<ping status=\"ok\"/>"
127 "<updatecheck status=\"noupdate\"/></app>" +
128 (multi_app_no_update
Aaron Wood7dcdedf2017-09-06 17:17:41 -0700129 ? "<app appid=\"" + app_id2 +
130 "\"><updatecheck status=\"noupdate\"/></app>"
Sen Jiang81259682017-03-30 15:11:30 -0700131 : "") +
132 "</response>";
Alex Deymo8e18f932015-03-27 16:16:59 -0700133 }
134
135 string GetUpdateResponse() const {
Jae Hoon Kim5e9cd712020-02-12 15:28:28 -0800136 chromeos_update_engine::OmahaRequestParams request_params{nullptr};
137 request_params.set_app_id(app_id);
Sen Jiang2703ef42017-03-16 13:36:21 -0700138 return "<?xml version=\"1.0\" encoding=\"UTF-8\"?><response "
139 "protocol=\"3.0\">"
140 "<daystart elapsed_seconds=\"100\"" +
141 (elapsed_days.empty() ? ""
142 : (" elapsed_days=\"" + elapsed_days + "\"")) +
143 "/>"
144 "<app appid=\"" +
145 app_id + "\" " +
146 (include_cohorts
147 ? "cohort=\"" + cohort + "\" cohorthint=\"" + cohorthint +
148 "\" cohortname=\"" + cohortname + "\" "
149 : "") +
150 " status=\"ok\">"
Zentaro Kavanagh0ff621c2018-07-13 13:06:56 -0700151 "<ping status=\"ok\"/><updatecheck status=\"ok\"" +
152 GetRollbackVersionAttributes() + ">" + "<urls><url codebase=\"" +
Sen Jiang2703ef42017-03-16 13:36:21 -0700153 codebase +
154 "\"/></urls>"
155 "<manifest version=\"" +
156 version +
157 "\">"
158 "<packages><package hash=\"not-used\" name=\"" +
Qijiang Fan0b6501c2020-05-21 05:19:12 +0900159 filename + "\" size=\"" + base::NumberToString(size) +
Sen Jiang0affc2c2017-02-10 15:55:05 -0800160 "\" hash_sha256=\"" + hash + "\"/>" +
161 (multi_package ? "<package name=\"package2\" size=\"222\" "
162 "hash_sha256=\"hash2\"/>"
163 : "") +
164 "</packages>"
Sen Jiang81259682017-03-30 15:11:30 -0700165 "<actions><action event=\"postinstall\" MetadataSize=\"11" +
Amin Hassanic482bbd2018-09-21 16:07:20 -0700166 (multi_package ? ":22" : "") + "\" MoreInfo=\"" + more_info_url +
167 "\" Prompt=\"" + prompt +
Sen Jiang2703ef42017-03-16 13:36:21 -0700168 "\" "
Sen Jiangcdd52062017-05-18 15:33:10 -0700169 "IsDeltaPayload=\"true" +
170 (multi_package ? ":false" : "") +
171 "\" "
Sen Jiang2703ef42017-03-16 13:36:21 -0700172 "MaxDaysToScatter=\"" +
173 max_days_to_scatter +
174 "\" "
Amin Hassanic482bbd2018-09-21 16:07:20 -0700175 "sha256=\"not-used\" " +
Sen Jiang2703ef42017-03-16 13:36:21 -0700176 (deadline.empty() ? "" : ("deadline=\"" + deadline + "\" ")) +
177 (disable_p2p_for_downloading ? "DisableP2PForDownloading=\"true\" "
178 : "") +
179 (disable_p2p_for_sharing ? "DisableP2PForSharing=\"true\" " : "") +
Sen Jiangfe284402018-03-21 14:03:50 -0700180 (powerwash ? "Powerwash=\"true\" " : "") +
Sen Jiang81259682017-03-30 15:11:30 -0700181 "/></actions></manifest></updatecheck></app>" +
182 (multi_app
Sen Jiangb1e063a2017-09-15 17:44:31 -0700183 ? "<app appid=\"" + app_id2 + "\"" +
184 (include_cohorts ? " cohort=\"cohort2\"" : "") +
185 "><updatecheck status=\"ok\"><urls><url codebase=\"" +
Aaron Wood7dcdedf2017-09-06 17:17:41 -0700186 codebase2 + "\"/></urls><manifest version=\"" + version2 +
187 "\"><packages>"
Sen Jiang81259682017-03-30 15:11:30 -0700188 "<package name=\"package3\" size=\"333\" "
189 "hash_sha256=\"hash3\"/></packages>"
Sen Jiang00adf7b2017-06-26 15:57:29 -0700190 "<actions><action event=\"postinstall\" " +
191 (multi_app_self_update
192 ? "noupdate=\"true\" IsDeltaPayload=\"true\" "
193 : "IsDeltaPayload=\"false\" ") +
194 "MetadataSize=\"33\"/></actions>"
Sen Jiang81259682017-03-30 15:11:30 -0700195 "</manifest></updatecheck></app>"
196 : "") +
197 (multi_app_no_update
198 ? "<app><updatecheck status=\"noupdate\"/></app>"
199 : "") +
Xiaochu Liu6310be62018-10-11 15:09:03 -0700200 (multi_app_skip_updatecheck
201 ? "<app appid=\"" + app_id_skip_updatecheck + "\"></app>"
202 : "") +
Jae Hoon Kim5e9cd712020-02-12 15:28:28 -0800203 (dlc_app_update
204 ? "<app appid=\"" + request_params.GetDlcAppId(kDlcId1) +
205 "\" status=\"ok\">"
206 "<updatecheck status=\"ok\"><urls><url codebase=\"" +
207 codebase + "\"/></urls><manifest version=\"" + version +
208 "\"><packages><package name=\"package3\" size=\"333\" "
209 "hash_sha256=\"hash3\"/></packages><actions>"
210 "<action event=\"install\" run=\".signed\"/>"
211 "<action event=\"postinstall\" MetadataSize=\"33\"/>"
212 "</actions></manifest></updatecheck></app>"
213 : "") +
214 (dlc_app_no_update
215 ? "<app appid=\"" + request_params.GetDlcAppId(kDlcId2) +
216 "\"><updatecheck status=\"noupdate\"/></app>"
217 : "") +
Sen Jiang81259682017-03-30 15:11:30 -0700218 "</response>";
Alex Deymo8e18f932015-03-27 16:16:59 -0700219 }
220
221 // Return the payload URL, which is split in two fields in the XML response.
Amin Hassani7cc8bb02019-01-14 16:29:47 -0800222 string GetPayloadUrl() { return codebase + filename; }
Alex Deymo8e18f932015-03-27 16:16:59 -0700223
Alex Deymo85616652015-10-15 18:48:31 -0700224 string app_id = kTestAppId;
Aaron Wood7dcdedf2017-09-06 17:17:41 -0700225 string app_id2 = kTestAppId2;
Xiaochu Liu6310be62018-10-11 15:09:03 -0700226 string app_id_skip_updatecheck = kTestAppIdSkipUpdatecheck;
227 string current_version = kCurrentVersion;
Alex Deymo8e18f932015-03-27 16:16:59 -0700228 string version = "1.2.3.4";
Aaron Wood7dcdedf2017-09-06 17:17:41 -0700229 string version2 = "2.3.4.5";
Alex Deymo8e18f932015-03-27 16:16:59 -0700230 string more_info_url = "http://more/info";
231 string prompt = "true";
232 string codebase = "http://code/base/";
Sen Jiang81259682017-03-30 15:11:30 -0700233 string codebase2 = "http://code/base/2/";
Alex Deymo8e18f932015-03-27 16:16:59 -0700234 string filename = "file.signed";
Sen Jiang2703ef42017-03-16 13:36:21 -0700235 string hash = "4841534831323334";
Sen Jiang0affc2c2017-02-10 15:55:05 -0800236 uint64_t size = 123;
Alex Deymo8e18f932015-03-27 16:16:59 -0700237 string deadline = "";
238 string max_days_to_scatter = "7";
239 string elapsed_days = "42";
240
241 // P2P setting defaults to allowed.
242 bool disable_p2p_for_downloading = false;
243 bool disable_p2p_for_sharing = false;
244
Sen Jiangfe284402018-03-21 14:03:50 -0700245 bool powerwash = false;
246
Alex Deymo8e18f932015-03-27 16:16:59 -0700247 // Omaha cohorts settings.
248 bool include_cohorts = false;
249 string cohort = "";
250 string cohorthint = "";
251 string cohortname = "";
252
253 // Whether to include the CrOS <!ENTITY> in the XML response.
254 bool include_entity = false;
Sen Jiang0affc2c2017-02-10 15:55:05 -0800255
Sen Jiang81259682017-03-30 15:11:30 -0700256 // Whether to include more than one app.
257 bool multi_app = false;
Sen Jiang00adf7b2017-06-26 15:57:29 -0700258 // Whether to include an app with noupdate="true".
259 bool multi_app_self_update = false;
260 // Whether to include an additional app with status="noupdate".
Sen Jiang81259682017-03-30 15:11:30 -0700261 bool multi_app_no_update = false;
Xiaochu Liu6310be62018-10-11 15:09:03 -0700262 // Whether to include an additional app with no updatecheck tag.
263 bool multi_app_skip_updatecheck = false;
Sen Jiang81259682017-03-30 15:11:30 -0700264 // Whether to include more than one package in an app.
Sen Jiang0affc2c2017-02-10 15:55:05 -0800265 bool multi_package = false;
Jae Hoon Kim5e9cd712020-02-12 15:28:28 -0800266 // Whether to include a DLC app with updatecheck tag.
267 bool dlc_app_update = false;
268 // Whether to include a DLC app with no updatecheck tag.
269 bool dlc_app_no_update = false;
Zentaro Kavanagh0ff621c2018-07-13 13:06:56 -0700270
271 // Whether the payload is a rollback.
272 bool rollback = false;
273 // The verified boot firmware key version for the rollback image.
274 string rollback_firmware_version = "";
275 // The verified boot kernel key version for the rollback image.
276 string rollback_kernel_version = "";
Zentaro Kavanagh0ef9a2f2018-07-02 12:05:07 -0700277 // The number of milestones back that the verified boot key version has been
278 // supplied.
279 uint32_t rollback_allowed_milestones = 0;
280 // The verified boot key version for the
281 // |current - rollback_allowed_milestones| most recent release.
282 // The pair contains <firmware_key_version, kernel_key_version> each
283 // of which is in the form "key_version.version".
284 pair<string, string> past_rollback_key_version;
Alex Deymo8e18f932015-03-27 16:16:59 -0700285};
286
287} // namespace
288
Darin Petkov6a5b3222010-07-13 14:55:28 -0700289namespace chromeos_update_engine {
290
Amin Hassanid3f4bea2018-04-30 14:52:40 -0700291class OmahaRequestActionTestProcessorDelegate : public ActionProcessorDelegate {
292 public:
293 OmahaRequestActionTestProcessorDelegate()
294 : expected_code_(ErrorCode::kSuccess),
295 interactive_(false),
296 test_http_fetcher_headers_(false) {}
297 ~OmahaRequestActionTestProcessorDelegate() override = default;
298
299 void ProcessingDone(const ActionProcessor* processor,
300 ErrorCode code) override {
301 brillo::MessageLoop::current()->BreakLoop();
302 }
303
304 void ActionCompleted(ActionProcessor* processor,
305 AbstractAction* action,
306 ErrorCode code) override {
307 // Make sure actions always succeed.
308 if (action->Type() == OmahaRequestAction::StaticType()) {
309 EXPECT_EQ(expected_code_, code);
310 // Check that the headers were set in the fetcher during the action. Note
311 // that we set this request as "interactive".
312 auto fetcher = static_cast<const MockHttpFetcher*>(
313 static_cast<OmahaRequestAction*>(action)->http_fetcher_.get());
314
315 if (test_http_fetcher_headers_) {
316 EXPECT_EQ(interactive_ ? "fg" : "bg",
317 fetcher->GetHeader("X-Goog-Update-Interactivity"));
318 EXPECT_EQ(kTestAppId, fetcher->GetHeader("X-Goog-Update-AppId"));
319 EXPECT_NE("", fetcher->GetHeader("X-Goog-Update-Updater"));
320 }
321 post_data_ = fetcher->post_data();
322 } else if (action->Type() ==
323 ObjectCollectorAction<OmahaResponse>::StaticType()) {
324 EXPECT_EQ(ErrorCode::kSuccess, code);
325 auto collector_action =
326 static_cast<ObjectCollectorAction<OmahaResponse>*>(action);
327 omaha_response_.reset(new OmahaResponse(collector_action->object()));
328 EXPECT_TRUE(omaha_response_);
329 } else {
330 EXPECT_EQ(ErrorCode::kSuccess, code);
331 }
332 }
333 ErrorCode expected_code_;
334 brillo::Blob post_data_;
335 bool interactive_;
336 bool test_http_fetcher_headers_;
337 std::unique_ptr<OmahaResponse> omaha_response_;
338};
339
Amin Hassani41ac04b2019-03-29 11:31:03 -0700340struct TestUpdateCheckParams {
341 string http_response;
342 int fail_http_response_code;
343 bool ping_only;
344 bool is_consumer_device;
345 int rollback_allowed_milestones;
346 bool is_policy_loaded;
347 ErrorCode expected_code;
348 metrics::CheckResult expected_check_result;
349 metrics::CheckReaction expected_check_reaction;
350 metrics::DownloadErrorCode expected_download_error_code;
Jae Hoon Kimedb65502019-06-14 11:52:17 -0700351 string session_id;
Amin Hassani41ac04b2019-03-29 11:31:03 -0700352};
353
Alex Deymoe1e3afe2014-10-30 13:02:49 -0700354class OmahaRequestActionTest : public ::testing::Test {
355 protected:
Alex Deymo610277e2014-11-11 21:18:11 -0800356 void SetUp() override {
Marton Hunyady2abda312018-04-24 18:21:49 +0200357 request_params_.set_os_sp("service_pack");
358 request_params_.set_os_board("x86-generic");
359 request_params_.set_app_id(kTestAppId);
Xiaochu Liu6310be62018-10-11 15:09:03 -0700360 request_params_.set_app_version(kCurrentVersion);
Marton Hunyady2abda312018-04-24 18:21:49 +0200361 request_params_.set_app_lang("en-US");
362 request_params_.set_current_channel("unittest");
363 request_params_.set_target_channel("unittest");
364 request_params_.set_hwid("OEM MODEL 09235 7471");
365 request_params_.set_fw_version("ChromeOSFirmware.1.0");
366 request_params_.set_ec_version("0X0A1");
367 request_params_.set_delta_okay(true);
368 request_params_.set_interactive(false);
369 request_params_.set_update_url("http://url");
370 request_params_.set_target_version_prefix("");
Marton Hunyadyba51c3f2018-04-25 15:18:10 +0200371 request_params_.set_rollback_allowed(false);
Marton Hunyady2abda312018-04-24 18:21:49 +0200372 request_params_.set_is_powerwash_allowed(false);
Xiaochu Liu6310be62018-10-11 15:09:03 -0700373 request_params_.set_is_install(false);
Andrewe045aef2020-01-08 16:29:22 -0800374 request_params_.set_dlc_apps_params({});
Marton Hunyady2abda312018-04-24 18:21:49 +0200375
Alex Deymoe1e3afe2014-10-30 13:02:49 -0700376 fake_system_state_.set_request_params(&request_params_);
377 fake_system_state_.set_prefs(&fake_prefs_);
Amin Hassani41ac04b2019-03-29 11:31:03 -0700378
379 // Setting the default update check params. Lookup |TestUpdateCheck()|.
380 tuc_params_ = {
381 .http_response = "",
382 .fail_http_response_code = -1,
383 .ping_only = false,
384 .is_consumer_device = true,
385 .rollback_allowed_milestones = 0,
386 .is_policy_loaded = false,
387 .expected_code = ErrorCode::kSuccess,
388 .expected_check_result = metrics::CheckResult::kUpdateAvailable,
389 .expected_check_reaction = metrics::CheckReaction::kUpdating,
390 .expected_download_error_code = metrics::DownloadErrorCode::kUnset,
391 };
Alex Deymoe1e3afe2014-10-30 13:02:49 -0700392 }
393
Andrewe045aef2020-01-08 16:29:22 -0800394 // This function uses the parameters in |tuc_params_| to do an update check.
395 // It will fill out |post_str| with the result data and |response| with
Amin Hassani41ac04b2019-03-29 11:31:03 -0700396 // |OmahaResponse|. Returns true iff an output response was obtained from the
397 // |OmahaRequestAction|. If |fail_http_response_code| is non-negative, the
398 // transfer will fail with that code. |ping_only| is passed through to the
399 // |OmahaRequestAction| constructor.
Alex Deymoe1e3afe2014-10-30 13:02:49 -0700400 //
401 // The |expected_check_result|, |expected_check_reaction| and
Amin Hassani41ac04b2019-03-29 11:31:03 -0700402 // |expected_error_code| parameters are for checking expectations about
403 // reporting UpdateEngine.Check.{Result,Reaction,DownloadError} UMA
404 // statistics. Use the appropriate ::kUnset value to specify that the given
405 // metric should not be reported.
406 bool TestUpdateCheck();
Alex Deymoe1e3afe2014-10-30 13:02:49 -0700407
Amin Hassani41ac04b2019-03-29 11:31:03 -0700408 // Tests events using |event| and |https_response|. It will fill up |post_str|
409 // with the result data.
410 void TestEvent(OmahaEvent* event, const string& http_response);
Amin Hassanid3f4bea2018-04-30 14:52:40 -0700411
Alex Vakulenkof68bbbc2015-02-09 12:53:18 -0800412 // Runs and checks a ping test. |ping_only| indicates whether it should send
Alex Deymoe1e3afe2014-10-30 13:02:49 -0700413 // only a ping or also an updatecheck.
414 void PingTest(bool ping_only);
415
416 // InstallDate test helper function.
Amin Hassani7cc8bb02019-01-14 16:29:47 -0800417 bool InstallDateParseHelper(const string& elapsed_days,
418 OmahaResponse* response);
Alex Deymoe1e3afe2014-10-30 13:02:49 -0700419
420 // P2P test helper function.
Amin Hassani7cc8bb02019-01-14 16:29:47 -0800421 void P2PTest(bool initial_allow_p2p_for_downloading,
422 bool initial_allow_p2p_for_sharing,
423 bool omaha_disable_p2p_for_downloading,
424 bool omaha_disable_p2p_for_sharing,
425 bool payload_state_allow_p2p_attempt,
426 bool expect_p2p_client_lookup,
427 const string& p2p_client_result_url,
428 bool expected_allow_p2p_for_downloading,
429 bool expected_allow_p2p_for_sharing,
430 const string& expected_p2p_url);
Alex Deymoe1e3afe2014-10-30 13:02:49 -0700431
432 FakeSystemState fake_system_state_;
Alex Deymo8e18f932015-03-27 16:16:59 -0700433 FakeUpdateResponse fake_update_response_;
Marton Hunyady2abda312018-04-24 18:21:49 +0200434 // Used by all tests.
435 OmahaRequestParams request_params_{&fake_system_state_};
Alex Deymoe1e3afe2014-10-30 13:02:49 -0700436
437 FakePrefs fake_prefs_;
Darin Petkov6a5b3222010-07-13 14:55:28 -0700438
Amin Hassanid3f4bea2018-04-30 14:52:40 -0700439 OmahaRequestActionTestProcessorDelegate delegate_;
Darin Petkov6a5b3222010-07-13 14:55:28 -0700440
Amin Hassanid3f4bea2018-04-30 14:52:40 -0700441 bool test_http_fetcher_headers_{false};
Amin Hassani41ac04b2019-03-29 11:31:03 -0700442
443 TestUpdateCheckParams tuc_params_;
444
445 // TODO(ahassani): Add trailing _ to these two variables.
446 OmahaResponse response;
447 string post_str;
Darin Petkov6a5b3222010-07-13 14:55:28 -0700448};
449
Andrew065d78d2020-04-07 15:43:07 -0700450class OmahaRequestActionDlcPingTest : public OmahaRequestActionTest {
451 protected:
452 void SetUp() override {
453 OmahaRequestActionTest::SetUp();
454 dlc_id_ = "dlc0";
455 active_key_ = PrefsInterface::CreateSubKey(
Jae Hoon Kimc1f36922020-05-11 18:20:18 -0700456 {kDlcPrefsSubDir, dlc_id_, kPrefsPingActive});
Andrew065d78d2020-04-07 15:43:07 -0700457 last_active_key_ = PrefsInterface::CreateSubKey(
Jae Hoon Kimc1f36922020-05-11 18:20:18 -0700458 {kDlcPrefsSubDir, dlc_id_, kPrefsPingLastActive});
Andrew065d78d2020-04-07 15:43:07 -0700459 last_rollcall_key_ = PrefsInterface::CreateSubKey(
Jae Hoon Kimc1f36922020-05-11 18:20:18 -0700460 {kDlcPrefsSubDir, dlc_id_, kPrefsPingLastRollcall});
Andrew065d78d2020-04-07 15:43:07 -0700461
462 tuc_params_.http_response =
463 "<?xml version=\"1.0\" encoding=\"UTF-8\"?><response "
464 "protocol=\"3.0\"><daystart elapsed_days=\"4763\" "
465 "elapsed_seconds=\"36540\"/><app appid=\"test-app-id\" status=\"ok\">\""
466 "<updatecheck status=\"noupdate\"/></app><app "
467 "appid=\"test-app-id_dlc0\" "
468 "status=\"ok\"><ping status=\"ok\"/><updatecheck status=\"noupdate\"/>"
469 "</app></response>";
470 tuc_params_.expected_check_result =
471 metrics::CheckResult::kNoUpdateAvailable;
472 tuc_params_.expected_check_reaction = metrics::CheckReaction::kUnset;
473 }
474
475 std::string dlc_id_;
476 std::string active_key_;
477 std::string last_active_key_;
478 std::string last_rollcall_key_;
479};
Amin Hassani41ac04b2019-03-29 11:31:03 -0700480bool OmahaRequestActionTest::TestUpdateCheck() {
Alex Vakulenko3f39d5c2015-10-13 09:27:13 -0700481 brillo::FakeMessageLoop loop(nullptr);
Alex Deymo60ca1a72015-06-18 18:19:15 -0700482 loop.SetAsCurrent();
Amin Hassani41ac04b2019-03-29 11:31:03 -0700483 auto fetcher =
484 std::make_unique<MockHttpFetcher>(tuc_params_.http_response.data(),
485 tuc_params_.http_response.size(),
486 nullptr);
487 if (tuc_params_.fail_http_response_code >= 0) {
488 fetcher->FailTransfer(tuc_params_.fail_http_response_code);
Darin Petkovedc522e2010-11-05 09:35:17 -0700489 }
Marton Hunyady2abda312018-04-24 18:21:49 +0200490 // This ensures the tests didn't forget to update fake_system_state_ if they
491 // are not using the default request_params_.
492 EXPECT_EQ(&request_params_, fake_system_state_.request_params());
493
Jae Hoon Kimedb65502019-06-14 11:52:17 -0700494 auto omaha_request_action =
495 std::make_unique<OmahaRequestAction>(&fake_system_state_,
496 nullptr,
497 std::move(fetcher),
498 tuc_params_.ping_only,
499 tuc_params_.session_id);
Amin Hassanid3f4bea2018-04-30 14:52:40 -0700500
Zentaro Kavanagh1f899d52018-02-27 15:02:47 -0800501 auto mock_policy_provider =
502 std::make_unique<NiceMock<policy::MockPolicyProvider>>();
503 EXPECT_CALL(*mock_policy_provider, IsConsumerDevice())
Amin Hassani41ac04b2019-03-29 11:31:03 -0700504 .WillRepeatedly(Return(tuc_params_.is_consumer_device));
Zentaro Kavanagh1f899d52018-02-27 15:02:47 -0800505
506 EXPECT_CALL(*mock_policy_provider, device_policy_is_loaded())
Amin Hassani41ac04b2019-03-29 11:31:03 -0700507 .WillRepeatedly(Return(tuc_params_.is_policy_loaded));
Zentaro Kavanagh1f899d52018-02-27 15:02:47 -0800508
509 const policy::MockDevicePolicy device_policy;
Amin Hassani41ac04b2019-03-29 11:31:03 -0700510 const bool get_allowed_milestone_succeeds =
511 tuc_params_.rollback_allowed_milestones >= 0;
Zentaro Kavanagh1f899d52018-02-27 15:02:47 -0800512 EXPECT_CALL(device_policy, GetRollbackAllowedMilestones(_))
Amin Hassani41ac04b2019-03-29 11:31:03 -0700513 .WillRepeatedly(
514 DoAll(SetArgPointee<0>(tuc_params_.rollback_allowed_milestones),
515 Return(get_allowed_milestone_succeeds)));
Zentaro Kavanagh1f899d52018-02-27 15:02:47 -0800516
517 EXPECT_CALL(*mock_policy_provider, GetDevicePolicy())
518 .WillRepeatedly(ReturnRef(device_policy));
Amin Hassanid3f4bea2018-04-30 14:52:40 -0700519 omaha_request_action->policy_provider_ = std::move(mock_policy_provider);
Zentaro Kavanagh1f899d52018-02-27 15:02:47 -0800520
Amin Hassani41ac04b2019-03-29 11:31:03 -0700521 delegate_.expected_code_ = tuc_params_.expected_code;
Amin Hassanid3f4bea2018-04-30 14:52:40 -0700522 delegate_.interactive_ = request_params_.interactive();
523 delegate_.test_http_fetcher_headers_ = test_http_fetcher_headers_;
Darin Petkov6a5b3222010-07-13 14:55:28 -0700524 ActionProcessor processor;
Amin Hassanid3f4bea2018-04-30 14:52:40 -0700525 processor.set_delegate(&delegate_);
Darin Petkov6a5b3222010-07-13 14:55:28 -0700526
Amin Hassanid3f4bea2018-04-30 14:52:40 -0700527 auto collector_action =
528 std::make_unique<ObjectCollectorAction<OmahaResponse>>();
529 BondActions(omaha_request_action.get(), collector_action.get());
530 processor.EnqueueAction(std::move(omaha_request_action));
531 processor.EnqueueAction(std::move(collector_action));
Darin Petkov6a5b3222010-07-13 14:55:28 -0700532
Tianjie Xu282aa1f2017-09-05 13:42:45 -0700533 EXPECT_CALL(*fake_system_state_.mock_metrics_reporter(),
534 ReportUpdateCheckMetrics(_, _, _, _))
David Zeuthen33bae492014-02-25 16:16:18 -0800535 .Times(AnyNumber());
Tianjie Xu282aa1f2017-09-05 13:42:45 -0700536
Amin Hassani41ac04b2019-03-29 11:31:03 -0700537 EXPECT_CALL(
538 *fake_system_state_.mock_metrics_reporter(),
539 ReportUpdateCheckMetrics(_,
540 tuc_params_.expected_check_result,
541 tuc_params_.expected_check_reaction,
542 tuc_params_.expected_download_error_code))
543 .Times(tuc_params_.ping_only ? 0 : 1);
David Zeuthen33bae492014-02-25 16:16:18 -0800544
Luis Hector Chavezf1cf3482016-07-19 14:29:19 -0700545 loop.PostTask(base::Bind(
546 [](ActionProcessor* processor) { processor->StartProcessing(); },
547 base::Unretained(&processor)));
Alex Deymo60ca1a72015-06-18 18:19:15 -0700548 loop.Run();
Alex Deymo60ca1a72015-06-18 18:19:15 -0700549 EXPECT_FALSE(loop.PendingTasks());
Amin Hassani41ac04b2019-03-29 11:31:03 -0700550 if (delegate_.omaha_response_)
551 response = *delegate_.omaha_response_;
552 post_str = string(delegate_.post_data_.begin(), delegate_.post_data_.end());
Amin Hassanid3f4bea2018-04-30 14:52:40 -0700553 return delegate_.omaha_response_ != nullptr;
Darin Petkov6a5b3222010-07-13 14:55:28 -0700554}
555
Amin Hassanid3f4bea2018-04-30 14:52:40 -0700556// Tests Event requests -- they should always succeed. |out_post_data| may be
557// null; if non-null, the post-data received by the mock HttpFetcher is
558// returned.
559void OmahaRequestActionTest::TestEvent(OmahaEvent* event,
Amin Hassani41ac04b2019-03-29 11:31:03 -0700560 const string& http_response) {
Alex Vakulenko3f39d5c2015-10-13 09:27:13 -0700561 brillo::FakeMessageLoop loop(nullptr);
Alex Deymo60ca1a72015-06-18 18:19:15 -0700562 loop.SetAsCurrent();
Amin Hassanid3f4bea2018-04-30 14:52:40 -0700563
564 auto action = std::make_unique<OmahaRequestAction>(
565 &fake_system_state_,
566 event,
567 std::make_unique<MockHttpFetcher>(
568 http_response.data(), http_response.size(), nullptr),
Jae Hoon Kimedb65502019-06-14 11:52:17 -0700569 false,
570 "");
Darin Petkov0dc8e9a2010-07-14 14:51:57 -0700571 ActionProcessor processor;
Amin Hassanid3f4bea2018-04-30 14:52:40 -0700572 processor.set_delegate(&delegate_);
573 processor.EnqueueAction(std::move(action));
Darin Petkov0dc8e9a2010-07-14 14:51:57 -0700574
Luis Hector Chavezf1cf3482016-07-19 14:29:19 -0700575 loop.PostTask(base::Bind(
576 [](ActionProcessor* processor) { processor->StartProcessing(); },
577 base::Unretained(&processor)));
Alex Deymo60ca1a72015-06-18 18:19:15 -0700578 loop.Run();
Alex Deymo72a25672016-03-23 15:44:39 -0700579 EXPECT_FALSE(loop.PendingTasks());
Alex Deymo60ca1a72015-06-18 18:19:15 -0700580
Amin Hassani41ac04b2019-03-29 11:31:03 -0700581 post_str = string(delegate_.post_data_.begin(), delegate_.post_data_.end());
Darin Petkov0dc8e9a2010-07-14 14:51:57 -0700582}
583
Alex Deymoe1e3afe2014-10-30 13:02:49 -0700584TEST_F(OmahaRequestActionTest, RejectEntities) {
Alex Deymo8e18f932015-03-27 16:16:59 -0700585 fake_update_response_.include_entity = true;
Amin Hassani41ac04b2019-03-29 11:31:03 -0700586 tuc_params_.http_response = fake_update_response_.GetNoUpdateResponse();
587 tuc_params_.expected_code = ErrorCode::kOmahaRequestXMLHasEntityDecl;
588 tuc_params_.expected_check_result = metrics::CheckResult::kParsingError;
589 tuc_params_.expected_check_reaction = metrics::CheckReaction::kUnset;
590
591 ASSERT_FALSE(TestUpdateCheck());
David Zeuthenf3e28012014-08-26 18:23:52 -0400592 EXPECT_FALSE(response.update_exists);
593}
594
Alex Deymoe1e3afe2014-10-30 13:02:49 -0700595TEST_F(OmahaRequestActionTest, NoUpdateTest) {
Amin Hassani41ac04b2019-03-29 11:31:03 -0700596 tuc_params_.http_response = fake_update_response_.GetNoUpdateResponse();
597 tuc_params_.expected_check_result = metrics::CheckResult::kNoUpdateAvailable;
598 tuc_params_.expected_check_reaction = metrics::CheckReaction::kUnset;
599
600 ASSERT_TRUE(TestUpdateCheck());
Darin Petkov6a5b3222010-07-13 14:55:28 -0700601 EXPECT_FALSE(response.update_exists);
602}
603
Sen Jiang81259682017-03-30 15:11:30 -0700604TEST_F(OmahaRequestActionTest, MultiAppNoUpdateTest) {
Sen Jiang81259682017-03-30 15:11:30 -0700605 fake_update_response_.multi_app_no_update = true;
Amin Hassani41ac04b2019-03-29 11:31:03 -0700606 tuc_params_.http_response = fake_update_response_.GetNoUpdateResponse();
607 tuc_params_.expected_check_result = metrics::CheckResult::kNoUpdateAvailable;
608 tuc_params_.expected_check_reaction = metrics::CheckReaction::kUnset;
609
610 ASSERT_TRUE(TestUpdateCheck());
Sen Jiang81259682017-03-30 15:11:30 -0700611 EXPECT_FALSE(response.update_exists);
612}
613
Sen Jiang00adf7b2017-06-26 15:57:29 -0700614TEST_F(OmahaRequestActionTest, MultiAppNoPartialUpdateTest) {
Sen Jiang00adf7b2017-06-26 15:57:29 -0700615 fake_update_response_.multi_app_no_update = true;
Amin Hassani41ac04b2019-03-29 11:31:03 -0700616 tuc_params_.http_response = fake_update_response_.GetUpdateResponse();
617 tuc_params_.expected_check_result = metrics::CheckResult::kNoUpdateAvailable;
618 tuc_params_.expected_check_reaction = metrics::CheckReaction::kUnset;
619
620 ASSERT_TRUE(TestUpdateCheck());
Sen Jiang00adf7b2017-06-26 15:57:29 -0700621 EXPECT_FALSE(response.update_exists);
622}
623
624TEST_F(OmahaRequestActionTest, NoSelfUpdateTest) {
Amin Hassani41ac04b2019-03-29 11:31:03 -0700625 tuc_params_.http_response =
Sen Jiang00adf7b2017-06-26 15:57:29 -0700626 "<response><app><updatecheck status=\"ok\"><manifest><actions><action "
627 "event=\"postinstall\" noupdate=\"true\"/></actions>"
Amin Hassani41ac04b2019-03-29 11:31:03 -0700628 "</manifest></updatecheck></app></response>";
629 tuc_params_.expected_check_result = metrics::CheckResult::kNoUpdateAvailable;
630 tuc_params_.expected_check_reaction = metrics::CheckReaction::kUnset;
631
632 ASSERT_TRUE(TestUpdateCheck());
Sen Jiang00adf7b2017-06-26 15:57:29 -0700633 EXPECT_FALSE(response.update_exists);
634}
635
Alex Deymo8e18f932015-03-27 16:16:59 -0700636// Test that all the values in the response are parsed in a normal update
637// response.
Alex Deymoe1e3afe2014-10-30 13:02:49 -0700638TEST_F(OmahaRequestActionTest, ValidUpdateTest) {
Alex Deymo8e18f932015-03-27 16:16:59 -0700639 fake_update_response_.deadline = "20101020";
Amin Hassani41ac04b2019-03-29 11:31:03 -0700640 tuc_params_.http_response = fake_update_response_.GetUpdateResponse();
641
642 ASSERT_TRUE(TestUpdateCheck());
643
Darin Petkov6a5b3222010-07-13 14:55:28 -0700644 EXPECT_TRUE(response.update_exists);
Alex Deymo8e18f932015-03-27 16:16:59 -0700645 EXPECT_EQ(fake_update_response_.version, response.version);
Aaron Wood7dcdedf2017-09-06 17:17:41 -0700646 EXPECT_EQ("", response.system_version);
Sen Jiang0affc2c2017-02-10 15:55:05 -0800647 EXPECT_EQ(fake_update_response_.GetPayloadUrl(),
648 response.packages[0].payload_urls[0]);
Alex Deymo8e18f932015-03-27 16:16:59 -0700649 EXPECT_EQ(fake_update_response_.more_info_url, response.more_info_url);
Sen Jiang0affc2c2017-02-10 15:55:05 -0800650 EXPECT_EQ(fake_update_response_.hash, response.packages[0].hash);
651 EXPECT_EQ(fake_update_response_.size, response.packages[0].size);
Sen Jiangcdd52062017-05-18 15:33:10 -0700652 EXPECT_EQ(true, response.packages[0].is_delta);
Alex Deymo8e18f932015-03-27 16:16:59 -0700653 EXPECT_EQ(fake_update_response_.prompt == "true", response.prompt);
654 EXPECT_EQ(fake_update_response_.deadline, response.deadline);
Sen Jiangfe284402018-03-21 14:03:50 -0700655 EXPECT_FALSE(response.powerwash_required);
Aaron Wood7dcdedf2017-09-06 17:17:41 -0700656 // Omaha cohort attributes are not set in the response, so they should not be
Alex Deymo8e18f932015-03-27 16:16:59 -0700657 // persisted.
658 EXPECT_FALSE(fake_prefs_.Exists(kPrefsOmahaCohort));
659 EXPECT_FALSE(fake_prefs_.Exists(kPrefsOmahaCohortHint));
660 EXPECT_FALSE(fake_prefs_.Exists(kPrefsOmahaCohortName));
Darin Petkov6a5b3222010-07-13 14:55:28 -0700661}
662
Sen Jiang0affc2c2017-02-10 15:55:05 -0800663TEST_F(OmahaRequestActionTest, MultiPackageUpdateTest) {
Sen Jiang0affc2c2017-02-10 15:55:05 -0800664 fake_update_response_.multi_package = true;
Amin Hassani41ac04b2019-03-29 11:31:03 -0700665 tuc_params_.http_response = fake_update_response_.GetUpdateResponse();
666
667 ASSERT_TRUE(TestUpdateCheck());
668
Sen Jiang0affc2c2017-02-10 15:55:05 -0800669 EXPECT_TRUE(response.update_exists);
670 EXPECT_EQ(fake_update_response_.version, response.version);
671 EXPECT_EQ(fake_update_response_.GetPayloadUrl(),
672 response.packages[0].payload_urls[0]);
673 EXPECT_EQ(fake_update_response_.codebase + "package2",
674 response.packages[1].payload_urls[0]);
675 EXPECT_EQ(fake_update_response_.hash, response.packages[0].hash);
676 EXPECT_EQ(fake_update_response_.size, response.packages[0].size);
Sen Jiangcdd52062017-05-18 15:33:10 -0700677 EXPECT_EQ(true, response.packages[0].is_delta);
Sen Jiang81259682017-03-30 15:11:30 -0700678 EXPECT_EQ(11u, response.packages[0].metadata_size);
Sen Jiang0affc2c2017-02-10 15:55:05 -0800679 ASSERT_EQ(2u, response.packages.size());
Sen Jiang81259682017-03-30 15:11:30 -0700680 EXPECT_EQ(string("hash2"), response.packages[1].hash);
Sen Jiang0affc2c2017-02-10 15:55:05 -0800681 EXPECT_EQ(222u, response.packages[1].size);
Sen Jiang81259682017-03-30 15:11:30 -0700682 EXPECT_EQ(22u, response.packages[1].metadata_size);
Sen Jiangcdd52062017-05-18 15:33:10 -0700683 EXPECT_EQ(false, response.packages[1].is_delta);
Sen Jiang81259682017-03-30 15:11:30 -0700684}
685
686TEST_F(OmahaRequestActionTest, MultiAppUpdateTest) {
Sen Jiang81259682017-03-30 15:11:30 -0700687 fake_update_response_.multi_app = true;
Amin Hassani41ac04b2019-03-29 11:31:03 -0700688 tuc_params_.http_response = fake_update_response_.GetUpdateResponse();
689
690 ASSERT_TRUE(TestUpdateCheck());
691
Sen Jiang81259682017-03-30 15:11:30 -0700692 EXPECT_TRUE(response.update_exists);
693 EXPECT_EQ(fake_update_response_.version, response.version);
694 EXPECT_EQ(fake_update_response_.GetPayloadUrl(),
695 response.packages[0].payload_urls[0]);
696 EXPECT_EQ(fake_update_response_.codebase2 + "package3",
697 response.packages[1].payload_urls[0]);
698 EXPECT_EQ(fake_update_response_.hash, response.packages[0].hash);
699 EXPECT_EQ(fake_update_response_.size, response.packages[0].size);
700 EXPECT_EQ(11u, response.packages[0].metadata_size);
Sen Jiangcdd52062017-05-18 15:33:10 -0700701 EXPECT_EQ(true, response.packages[0].is_delta);
Sen Jiang81259682017-03-30 15:11:30 -0700702 ASSERT_EQ(2u, response.packages.size());
703 EXPECT_EQ(string("hash3"), response.packages[1].hash);
704 EXPECT_EQ(333u, response.packages[1].size);
705 EXPECT_EQ(33u, response.packages[1].metadata_size);
Sen Jiangcdd52062017-05-18 15:33:10 -0700706 EXPECT_EQ(false, response.packages[1].is_delta);
Sen Jiang81259682017-03-30 15:11:30 -0700707}
708
Aaron Wood7dcdedf2017-09-06 17:17:41 -0700709TEST_F(OmahaRequestActionTest, MultiAppAndSystemUpdateTest) {
Aaron Wood7dcdedf2017-09-06 17:17:41 -0700710 fake_update_response_.multi_app = true;
Amin Hassani41ac04b2019-03-29 11:31:03 -0700711 // Trigger the lining up of the app and system versions.
Aaron Wood7dcdedf2017-09-06 17:17:41 -0700712 request_params_.set_system_app_id(fake_update_response_.app_id2);
Amin Hassani41ac04b2019-03-29 11:31:03 -0700713 tuc_params_.http_response = fake_update_response_.GetUpdateResponse();
Aaron Wood7dcdedf2017-09-06 17:17:41 -0700714
Amin Hassani41ac04b2019-03-29 11:31:03 -0700715 ASSERT_TRUE(TestUpdateCheck());
716
Aaron Wood7dcdedf2017-09-06 17:17:41 -0700717 EXPECT_TRUE(response.update_exists);
718 EXPECT_EQ(fake_update_response_.version, response.version);
719 EXPECT_EQ(fake_update_response_.version2, response.system_version);
720 EXPECT_EQ(fake_update_response_.GetPayloadUrl(),
721 response.packages[0].payload_urls[0]);
722 EXPECT_EQ(fake_update_response_.codebase2 + "package3",
723 response.packages[1].payload_urls[0]);
724 EXPECT_EQ(fake_update_response_.hash, response.packages[0].hash);
725 EXPECT_EQ(fake_update_response_.size, response.packages[0].size);
726 EXPECT_EQ(11u, response.packages[0].metadata_size);
727 EXPECT_EQ(true, response.packages[0].is_delta);
728 ASSERT_EQ(2u, response.packages.size());
729 EXPECT_EQ(string("hash3"), response.packages[1].hash);
730 EXPECT_EQ(333u, response.packages[1].size);
731 EXPECT_EQ(33u, response.packages[1].metadata_size);
732 EXPECT_EQ(false, response.packages[1].is_delta);
733}
734
Sen Jiang81259682017-03-30 15:11:30 -0700735TEST_F(OmahaRequestActionTest, MultiAppPartialUpdateTest) {
Sen Jiang00adf7b2017-06-26 15:57:29 -0700736 fake_update_response_.multi_app = true;
737 fake_update_response_.multi_app_self_update = true;
Amin Hassani41ac04b2019-03-29 11:31:03 -0700738 tuc_params_.http_response = fake_update_response_.GetUpdateResponse();
739
740 ASSERT_TRUE(TestUpdateCheck());
741
Sen Jiang81259682017-03-30 15:11:30 -0700742 EXPECT_TRUE(response.update_exists);
743 EXPECT_EQ(fake_update_response_.version, response.version);
Aaron Wood7dcdedf2017-09-06 17:17:41 -0700744 EXPECT_EQ("", response.system_version);
Sen Jiang81259682017-03-30 15:11:30 -0700745 EXPECT_EQ(fake_update_response_.GetPayloadUrl(),
746 response.packages[0].payload_urls[0]);
747 EXPECT_EQ(fake_update_response_.hash, response.packages[0].hash);
748 EXPECT_EQ(fake_update_response_.size, response.packages[0].size);
749 EXPECT_EQ(11u, response.packages[0].metadata_size);
Sen Jiang00adf7b2017-06-26 15:57:29 -0700750 ASSERT_EQ(2u, response.packages.size());
751 EXPECT_EQ(string("hash3"), response.packages[1].hash);
752 EXPECT_EQ(333u, response.packages[1].size);
753 EXPECT_EQ(33u, response.packages[1].metadata_size);
754 EXPECT_EQ(true, response.packages[1].is_delta);
Sen Jiang81259682017-03-30 15:11:30 -0700755}
756
757TEST_F(OmahaRequestActionTest, MultiAppMultiPackageUpdateTest) {
Sen Jiang81259682017-03-30 15:11:30 -0700758 fake_update_response_.multi_app = true;
759 fake_update_response_.multi_package = true;
Amin Hassani41ac04b2019-03-29 11:31:03 -0700760 tuc_params_.http_response = fake_update_response_.GetUpdateResponse();
761
762 ASSERT_TRUE(TestUpdateCheck());
763
Sen Jiang81259682017-03-30 15:11:30 -0700764 EXPECT_TRUE(response.update_exists);
765 EXPECT_EQ(fake_update_response_.version, response.version);
Aaron Wood7dcdedf2017-09-06 17:17:41 -0700766 EXPECT_EQ("", response.system_version);
Sen Jiang81259682017-03-30 15:11:30 -0700767 EXPECT_EQ(fake_update_response_.GetPayloadUrl(),
768 response.packages[0].payload_urls[0]);
769 EXPECT_EQ(fake_update_response_.codebase + "package2",
770 response.packages[1].payload_urls[0]);
771 EXPECT_EQ(fake_update_response_.codebase2 + "package3",
772 response.packages[2].payload_urls[0]);
773 EXPECT_EQ(fake_update_response_.hash, response.packages[0].hash);
774 EXPECT_EQ(fake_update_response_.size, response.packages[0].size);
775 EXPECT_EQ(11u, response.packages[0].metadata_size);
Sen Jiangcdd52062017-05-18 15:33:10 -0700776 EXPECT_EQ(true, response.packages[0].is_delta);
Sen Jiang81259682017-03-30 15:11:30 -0700777 ASSERT_EQ(3u, response.packages.size());
778 EXPECT_EQ(string("hash2"), response.packages[1].hash);
779 EXPECT_EQ(222u, response.packages[1].size);
780 EXPECT_EQ(22u, response.packages[1].metadata_size);
Sen Jiangcdd52062017-05-18 15:33:10 -0700781 EXPECT_EQ(false, response.packages[1].is_delta);
Sen Jiang81259682017-03-30 15:11:30 -0700782 EXPECT_EQ(string("hash3"), response.packages[2].hash);
783 EXPECT_EQ(333u, response.packages[2].size);
784 EXPECT_EQ(33u, response.packages[2].metadata_size);
Sen Jiangcdd52062017-05-18 15:33:10 -0700785 EXPECT_EQ(false, response.packages[2].is_delta);
Sen Jiang0affc2c2017-02-10 15:55:05 -0800786}
787
Sen Jiangfe284402018-03-21 14:03:50 -0700788TEST_F(OmahaRequestActionTest, PowerwashTest) {
Sen Jiangfe284402018-03-21 14:03:50 -0700789 fake_update_response_.powerwash = true;
Amin Hassani41ac04b2019-03-29 11:31:03 -0700790 tuc_params_.http_response = fake_update_response_.GetUpdateResponse();
791
792 ASSERT_TRUE(TestUpdateCheck());
793
Sen Jiangfe284402018-03-21 14:03:50 -0700794 EXPECT_TRUE(response.update_exists);
795 EXPECT_TRUE(response.powerwash_required);
796}
797
Amin Hassanid3f4bea2018-04-30 14:52:40 -0700798TEST_F(OmahaRequestActionTest, ExtraHeadersSentInteractiveTest) {
Alex Deymo14ad88e2016-06-29 12:30:14 -0700799 request_params_.set_interactive(true);
Amin Hassanid3f4bea2018-04-30 14:52:40 -0700800 test_http_fetcher_headers_ = true;
Amin Hassani41ac04b2019-03-29 11:31:03 -0700801 tuc_params_.http_response = "invalid xml>";
802 tuc_params_.expected_code = ErrorCode::kOmahaRequestXMLParseError;
803 tuc_params_.expected_check_result = metrics::CheckResult::kParsingError;
804 tuc_params_.expected_check_reaction = metrics::CheckReaction::kUnset;
805
806 ASSERT_FALSE(TestUpdateCheck());
807
Amin Hassanid3f4bea2018-04-30 14:52:40 -0700808 EXPECT_FALSE(response.update_exists);
809}
Alex Deymo14ad88e2016-06-29 12:30:14 -0700810
Amin Hassanid3f4bea2018-04-30 14:52:40 -0700811TEST_F(OmahaRequestActionTest, ExtraHeadersSentNoInteractiveTest) {
Amin Hassanid3f4bea2018-04-30 14:52:40 -0700812 request_params_.set_interactive(false);
813 test_http_fetcher_headers_ = true;
Amin Hassani41ac04b2019-03-29 11:31:03 -0700814 tuc_params_.http_response = "invalid xml>";
815 tuc_params_.expected_code = ErrorCode::kOmahaRequestXMLParseError;
816 tuc_params_.expected_check_result = metrics::CheckResult::kParsingError;
817 tuc_params_.expected_check_reaction = metrics::CheckReaction::kUnset;
818
819 ASSERT_FALSE(TestUpdateCheck());
820
Amin Hassanid3f4bea2018-04-30 14:52:40 -0700821 EXPECT_FALSE(response.update_exists);
Alex Deymo14ad88e2016-06-29 12:30:14 -0700822}
823
Alex Deymoe1e3afe2014-10-30 13:02:49 -0700824TEST_F(OmahaRequestActionTest, ValidUpdateBlockedByConnection) {
Chris Sosa77f79e82014-06-02 18:16:24 -0700825 // Set up a connection manager that doesn't allow a valid update over
826 // the current ethernet connection.
Alex Deymof6ee0162015-07-31 12:35:22 -0700827 MockConnectionManager mock_cm;
Alex Deymoe1e3afe2014-10-30 13:02:49 -0700828 fake_system_state_.set_connection_manager(&mock_cm);
829
Alex Deymo30534502015-07-20 15:06:33 -0700830 EXPECT_CALL(mock_cm, GetConnectionProperties(_, _))
Amin Hassani7cc8bb02019-01-14 16:29:47 -0800831 .WillRepeatedly(DoAll(SetArgPointee<0>(ConnectionType::kEthernet),
832 SetArgPointee<1>(ConnectionTethering::kUnknown),
833 Return(true)));
Sen Jiang255e22b2016-05-20 16:15:29 -0700834 EXPECT_CALL(mock_cm, IsUpdateAllowedOver(ConnectionType::kEthernet, _))
835 .WillRepeatedly(Return(false));
Chris Sosa77f79e82014-06-02 18:16:24 -0700836
Amin Hassani41ac04b2019-03-29 11:31:03 -0700837 tuc_params_.http_response = fake_update_response_.GetUpdateResponse();
838 tuc_params_.expected_code = ErrorCode::kOmahaUpdateIgnoredPerPolicy;
839 tuc_params_.expected_check_reaction = metrics::CheckReaction::kIgnored;
840
841 ASSERT_FALSE(TestUpdateCheck());
842
Chris Sosa77f79e82014-06-02 18:16:24 -0700843 EXPECT_FALSE(response.update_exists);
844}
845
Weidong Guo421ff332017-04-17 10:08:38 -0700846TEST_F(OmahaRequestActionTest, ValidUpdateOverCellularAllowedByDevicePolicy) {
847 // This test tests that update over cellular is allowed as device policy
848 // says yes.
Weidong Guo421ff332017-04-17 10:08:38 -0700849 MockConnectionManager mock_cm;
Weidong Guo421ff332017-04-17 10:08:38 -0700850 fake_system_state_.set_connection_manager(&mock_cm);
851
852 EXPECT_CALL(mock_cm, GetConnectionProperties(_, _))
853 .WillRepeatedly(DoAll(SetArgPointee<0>(ConnectionType::kCellular),
854 SetArgPointee<1>(ConnectionTethering::kUnknown),
855 Return(true)));
856 EXPECT_CALL(mock_cm, IsAllowedConnectionTypesForUpdateSet())
857 .WillRepeatedly(Return(true));
858 EXPECT_CALL(mock_cm, IsUpdateAllowedOver(ConnectionType::kCellular, _))
859 .WillRepeatedly(Return(true));
860
Amin Hassani41ac04b2019-03-29 11:31:03 -0700861 tuc_params_.http_response = fake_update_response_.GetUpdateResponse();
862
863 ASSERT_TRUE(TestUpdateCheck());
864
Weidong Guo421ff332017-04-17 10:08:38 -0700865 EXPECT_TRUE(response.update_exists);
866}
867
868TEST_F(OmahaRequestActionTest, ValidUpdateOverCellularBlockedByDevicePolicy) {
869 // This test tests that update over cellular is blocked as device policy
870 // says no.
Weidong Guo421ff332017-04-17 10:08:38 -0700871 MockConnectionManager mock_cm;
Weidong Guo421ff332017-04-17 10:08:38 -0700872 fake_system_state_.set_connection_manager(&mock_cm);
873
874 EXPECT_CALL(mock_cm, GetConnectionProperties(_, _))
875 .WillRepeatedly(DoAll(SetArgPointee<0>(ConnectionType::kCellular),
876 SetArgPointee<1>(ConnectionTethering::kUnknown),
877 Return(true)));
878 EXPECT_CALL(mock_cm, IsAllowedConnectionTypesForUpdateSet())
879 .WillRepeatedly(Return(true));
880 EXPECT_CALL(mock_cm, IsUpdateAllowedOver(ConnectionType::kCellular, _))
881 .WillRepeatedly(Return(false));
882
Amin Hassani41ac04b2019-03-29 11:31:03 -0700883 tuc_params_.http_response = fake_update_response_.GetUpdateResponse();
884 tuc_params_.expected_code = ErrorCode::kOmahaUpdateIgnoredPerPolicy;
885 tuc_params_.expected_check_reaction = metrics::CheckReaction::kIgnored;
886
887 ASSERT_FALSE(TestUpdateCheck());
888
Weidong Guo421ff332017-04-17 10:08:38 -0700889 EXPECT_FALSE(response.update_exists);
890}
891
892TEST_F(OmahaRequestActionTest,
893 ValidUpdateOverCellularAllowedByUserPermissionTrue) {
894 // This test tests that, when device policy is not set, update over cellular
895 // is allowed as permission for update over cellular is set to true.
Weidong Guo421ff332017-04-17 10:08:38 -0700896 MockConnectionManager mock_cm;
Weidong Guo421ff332017-04-17 10:08:38 -0700897 fake_prefs_.SetBoolean(kPrefsUpdateOverCellularPermission, true);
898 fake_system_state_.set_connection_manager(&mock_cm);
899
900 EXPECT_CALL(mock_cm, GetConnectionProperties(_, _))
901 .WillRepeatedly(DoAll(SetArgPointee<0>(ConnectionType::kCellular),
902 SetArgPointee<1>(ConnectionTethering::kUnknown),
903 Return(true)));
904 EXPECT_CALL(mock_cm, IsAllowedConnectionTypesForUpdateSet())
905 .WillRepeatedly(Return(false));
906 EXPECT_CALL(mock_cm, IsUpdateAllowedOver(ConnectionType::kCellular, _))
907 .WillRepeatedly(Return(true));
908
Amin Hassani41ac04b2019-03-29 11:31:03 -0700909 tuc_params_.http_response = fake_update_response_.GetUpdateResponse();
910
911 ASSERT_TRUE(TestUpdateCheck());
912
Weidong Guo421ff332017-04-17 10:08:38 -0700913 EXPECT_TRUE(response.update_exists);
914}
915
916TEST_F(OmahaRequestActionTest,
917 ValidUpdateOverCellularBlockedByUpdateTargetNotMatch) {
918 // This test tests that, when device policy is not set and permission for
919 // update over cellular is set to false or does not exist, update over
920 // cellular is blocked as update target does not match the omaha response.
Weidong Guo421ff332017-04-17 10:08:38 -0700921 MockConnectionManager mock_cm;
922 // A version different from the version in omaha response.
923 string diff_version = "99.99.99";
924 // A size different from the size in omaha response.
925 int64_t diff_size = 999;
926
927 fake_prefs_.SetString(kPrefsUpdateOverCellularTargetVersion, diff_version);
928 fake_prefs_.SetInt64(kPrefsUpdateOverCellularTargetSize, diff_size);
929 // This test tests cellular (3G) being the only connection type being allowed.
930 fake_system_state_.set_connection_manager(&mock_cm);
931
932 EXPECT_CALL(mock_cm, GetConnectionProperties(_, _))
933 .WillRepeatedly(DoAll(SetArgPointee<0>(ConnectionType::kCellular),
934 SetArgPointee<1>(ConnectionTethering::kUnknown),
935 Return(true)));
936 EXPECT_CALL(mock_cm, IsAllowedConnectionTypesForUpdateSet())
937 .WillRepeatedly(Return(false));
938 EXPECT_CALL(mock_cm, IsUpdateAllowedOver(ConnectionType::kCellular, _))
939 .WillRepeatedly(Return(true));
940
Amin Hassani41ac04b2019-03-29 11:31:03 -0700941 tuc_params_.http_response = fake_update_response_.GetUpdateResponse();
942 tuc_params_.expected_code = ErrorCode::kOmahaUpdateIgnoredOverCellular;
943 tuc_params_.expected_check_reaction = metrics::CheckReaction::kIgnored;
944
945 ASSERT_FALSE(TestUpdateCheck());
946
Weidong Guo421ff332017-04-17 10:08:38 -0700947 EXPECT_FALSE(response.update_exists);
948}
949
950TEST_F(OmahaRequestActionTest,
951 ValidUpdateOverCellularAllowedByUpdateTargetMatch) {
952 // This test tests that, when device policy is not set and permission for
953 // update over cellular is set to false or does not exist, update over
954 // cellular is allowed as update target matches the omaha response.
Weidong Guo421ff332017-04-17 10:08:38 -0700955 MockConnectionManager mock_cm;
956 // A version same as the version in omaha response.
957 string new_version = fake_update_response_.version;
958 // A size same as the size in omaha response.
959 int64_t new_size = fake_update_response_.size;
960
961 fake_prefs_.SetString(kPrefsUpdateOverCellularTargetVersion, new_version);
962 fake_prefs_.SetInt64(kPrefsUpdateOverCellularTargetSize, new_size);
963 fake_system_state_.set_connection_manager(&mock_cm);
964
965 EXPECT_CALL(mock_cm, GetConnectionProperties(_, _))
966 .WillRepeatedly(DoAll(SetArgPointee<0>(ConnectionType::kCellular),
967 SetArgPointee<1>(ConnectionTethering::kUnknown),
968 Return(true)));
969 EXPECT_CALL(mock_cm, IsAllowedConnectionTypesForUpdateSet())
970 .WillRepeatedly(Return(false));
971 EXPECT_CALL(mock_cm, IsUpdateAllowedOver(ConnectionType::kCellular, _))
972 .WillRepeatedly(Return(true));
973
Amin Hassani41ac04b2019-03-29 11:31:03 -0700974 tuc_params_.http_response = fake_update_response_.GetUpdateResponse();
975
976 ASSERT_TRUE(TestUpdateCheck());
977
Weidong Guo421ff332017-04-17 10:08:38 -0700978 EXPECT_TRUE(response.update_exists);
979}
980
Alex Deymoe1e3afe2014-10-30 13:02:49 -0700981TEST_F(OmahaRequestActionTest, ValidUpdateBlockedByRollback) {
Chris Sosa77f79e82014-06-02 18:16:24 -0700982 string rollback_version = "1234.0.0";
Chris Sosa77f79e82014-06-02 18:16:24 -0700983 MockPayloadState mock_payload_state;
Alex Deymoe1e3afe2014-10-30 13:02:49 -0700984 fake_system_state_.set_payload_state(&mock_payload_state);
Amin Hassani41ac04b2019-03-29 11:31:03 -0700985 fake_update_response_.version = rollback_version;
986 tuc_params_.http_response = fake_update_response_.GetUpdateResponse();
987 tuc_params_.expected_code = ErrorCode::kOmahaUpdateIgnoredPerPolicy;
988 tuc_params_.expected_check_reaction = metrics::CheckReaction::kIgnored;
Alex Deymoe1e3afe2014-10-30 13:02:49 -0700989
Chris Sosa77f79e82014-06-02 18:16:24 -0700990 EXPECT_CALL(mock_payload_state, GetRollbackVersion())
Amin Hassani7cc8bb02019-01-14 16:29:47 -0800991 .WillRepeatedly(Return(rollback_version));
Chris Sosa77f79e82014-06-02 18:16:24 -0700992
Amin Hassani41ac04b2019-03-29 11:31:03 -0700993 ASSERT_FALSE(TestUpdateCheck());
994
Chris Sosa77f79e82014-06-02 18:16:24 -0700995 EXPECT_FALSE(response.update_exists);
996}
997
Marton Hunyadyc2882062018-05-14 17:28:25 +0200998// Verify that update checks called during OOBE will not try to download an
999// update if the response doesn't include the deadline field.
Kevin Cernekee2494e282016-03-29 18:03:53 -07001000TEST_F(OmahaRequestActionTest, SkipNonCriticalUpdatesBeforeOOBE) {
Marton Hunyadyc2882062018-05-14 17:28:25 +02001001 fake_system_state_.fake_hardware()->UnsetIsOOBEComplete();
Amin Hassani41ac04b2019-03-29 11:31:03 -07001002 tuc_params_.http_response = fake_update_response_.GetUpdateResponse();
1003 tuc_params_.expected_code = ErrorCode::kNonCriticalUpdateInOOBE;
1004 tuc_params_.expected_check_result = metrics::CheckResult::kParsingError;
1005 tuc_params_.expected_check_reaction = metrics::CheckReaction::kUnset;
Kevin Cernekee2494e282016-03-29 18:03:53 -07001006
Sen Jiang8cd42342018-01-31 12:06:59 -08001007 // TODO(senj): set better default value for metrics::checkresult in
Tianjie Xu282aa1f2017-09-05 13:42:45 -07001008 // OmahaRequestAction::ActionCompleted.
Amin Hassani41ac04b2019-03-29 11:31:03 -07001009 ASSERT_FALSE(TestUpdateCheck());
1010
Kevin Cernekee2494e282016-03-29 18:03:53 -07001011 EXPECT_FALSE(response.update_exists);
Marton Hunyadyc2882062018-05-14 17:28:25 +02001012}
Kevin Cernekee2494e282016-03-29 18:03:53 -07001013
Marton Hunyadyc2882062018-05-14 17:28:25 +02001014// Verify that the IsOOBEComplete() value is ignored when the OOBE flow is not
1015// enabled.
1016TEST_F(OmahaRequestActionTest, SkipNonCriticalUpdatesBeforeOOBEDisabled) {
Marton Hunyadyc2882062018-05-14 17:28:25 +02001017 fake_system_state_.fake_hardware()->UnsetIsOOBEComplete();
Alex Deymo46a9aae2016-05-04 20:20:11 -07001018 fake_system_state_.fake_hardware()->SetIsOOBEEnabled(false);
Amin Hassani41ac04b2019-03-29 11:31:03 -07001019 tuc_params_.http_response = fake_update_response_.GetUpdateResponse();
Alex Deymo46a9aae2016-05-04 20:20:11 -07001020
Amin Hassani41ac04b2019-03-29 11:31:03 -07001021 ASSERT_TRUE(TestUpdateCheck());
1022
Kevin Cernekee2494e282016-03-29 18:03:53 -07001023 EXPECT_TRUE(response.update_exists);
1024}
1025
Marton Hunyadyc2882062018-05-14 17:28:25 +02001026// Verify that update checks called during OOBE will still try to download an
1027// update if the response includes the deadline field.
1028TEST_F(OmahaRequestActionTest, SkipNonCriticalUpdatesBeforeOOBEDeadlineSet) {
Marton Hunyadyc2882062018-05-14 17:28:25 +02001029 fake_system_state_.fake_hardware()->UnsetIsOOBEComplete();
1030 fake_update_response_.deadline = "20101020";
Amin Hassani41ac04b2019-03-29 11:31:03 -07001031 tuc_params_.http_response = fake_update_response_.GetUpdateResponse();
Marton Hunyadyc2882062018-05-14 17:28:25 +02001032
Amin Hassani41ac04b2019-03-29 11:31:03 -07001033 ASSERT_TRUE(TestUpdateCheck());
1034
Marton Hunyadyc2882062018-05-14 17:28:25 +02001035 EXPECT_TRUE(response.update_exists);
1036}
1037
1038// Verify that update checks called during OOBE will not try to download an
1039// update if a rollback happened, even when the response includes the deadline
1040// field.
1041TEST_F(OmahaRequestActionTest, SkipNonCriticalUpdatesBeforeOOBERollback) {
Marton Hunyadyc2882062018-05-14 17:28:25 +02001042 fake_system_state_.fake_hardware()->UnsetIsOOBEComplete();
1043 fake_update_response_.deadline = "20101020";
Amin Hassani41ac04b2019-03-29 11:31:03 -07001044 tuc_params_.http_response = fake_update_response_.GetUpdateResponse();
1045 tuc_params_.expected_code = ErrorCode::kNonCriticalUpdateInOOBE;
1046 tuc_params_.expected_check_result = metrics::CheckResult::kParsingError;
1047 tuc_params_.expected_check_reaction = metrics::CheckReaction::kUnset;
1048
Marton Hunyadyc2882062018-05-14 17:28:25 +02001049 EXPECT_CALL(*(fake_system_state_.mock_payload_state()), GetRollbackHappened())
1050 .WillOnce(Return(true));
1051
Amin Hassani41ac04b2019-03-29 11:31:03 -07001052 ASSERT_FALSE(TestUpdateCheck());
1053
Marton Hunyadyc2882062018-05-14 17:28:25 +02001054 EXPECT_FALSE(response.update_exists);
1055}
1056
Toni Barzic61544e62018-10-11 14:37:30 -07001057// Verify that non-critical updates are skipped by reporting the
1058// kNonCriticalUpdateInOOBE error code when attempted over cellular network -
1059// i.e. when the update would need user permission. Note that reporting
1060// kOmahaUpdateIgnoredOverCellular error in this case might cause undesired UX
1061// in OOBE (warning the user about an update that will be skipped).
1062TEST_F(OmahaRequestActionTest, SkipNonCriticalUpdatesInOOBEOverCellular) {
Toni Barzic61544e62018-10-11 14:37:30 -07001063 fake_system_state_.fake_hardware()->UnsetIsOOBEComplete();
1064
1065 MockConnectionManager mock_cm;
1066 fake_system_state_.set_connection_manager(&mock_cm);
Amin Hassani41ac04b2019-03-29 11:31:03 -07001067 tuc_params_.http_response = fake_update_response_.GetUpdateResponse();
1068 tuc_params_.expected_code = ErrorCode::kNonCriticalUpdateInOOBE;
1069 tuc_params_.expected_check_result = metrics::CheckResult::kParsingError;
1070 tuc_params_.expected_check_reaction = metrics::CheckReaction::kUnset;
Toni Barzic61544e62018-10-11 14:37:30 -07001071
1072 EXPECT_CALL(mock_cm, GetConnectionProperties(_, _))
1073 .WillRepeatedly(DoAll(SetArgPointee<0>(ConnectionType::kCellular),
1074 SetArgPointee<1>(ConnectionTethering::kUnknown),
1075 Return(true)));
1076 EXPECT_CALL(mock_cm, IsAllowedConnectionTypesForUpdateSet())
1077 .WillRepeatedly(Return(false));
1078
Amin Hassani41ac04b2019-03-29 11:31:03 -07001079 ASSERT_FALSE(TestUpdateCheck());
1080
Toni Barzic61544e62018-10-11 14:37:30 -07001081 EXPECT_FALSE(response.update_exists);
1082}
1083
Alex Deymoe1e3afe2014-10-30 13:02:49 -07001084TEST_F(OmahaRequestActionTest, WallClockBasedWaitAloneCausesScattering) {
Marton Hunyady2abda312018-04-24 18:21:49 +02001085 request_params_.set_wall_clock_based_wait_enabled(true);
1086 request_params_.set_update_check_count_wait_enabled(false);
1087 request_params_.set_waiting_period(TimeDelta::FromDays(2));
May Lippert60aa3ca2018-08-15 16:55:29 -07001088 fake_system_state_.fake_clock()->SetWallclockTime(Time::Now());
Amin Hassani41ac04b2019-03-29 11:31:03 -07001089 tuc_params_.http_response = fake_update_response_.GetUpdateResponse();
1090 tuc_params_.expected_code = ErrorCode::kOmahaUpdateDeferredPerPolicy;
1091 tuc_params_.expected_check_reaction = metrics::CheckReaction::kDeferring;
May Lippert60aa3ca2018-08-15 16:55:29 -07001092
Amin Hassani41ac04b2019-03-29 11:31:03 -07001093 ASSERT_FALSE(TestUpdateCheck());
1094
Jay Srinivasan480ddfa2012-06-01 19:15:26 -07001095 EXPECT_FALSE(response.update_exists);
Amin Hassani41ac04b2019-03-29 11:31:03 -07001096}
1097
1098TEST_F(OmahaRequestActionTest,
1099 WallClockBasedWaitAloneCausesScatteringInteractive) {
1100 request_params_.set_wall_clock_based_wait_enabled(true);
1101 request_params_.set_update_check_count_wait_enabled(false);
1102 request_params_.set_waiting_period(TimeDelta::FromDays(2));
1103 request_params_.set_interactive(true);
1104 fake_system_state_.fake_clock()->SetWallclockTime(Time::Now());
1105 tuc_params_.http_response = fake_update_response_.GetUpdateResponse();
Chris Sosa968d0572013-08-23 14:46:02 -07001106
1107 // Verify if we are interactive check we don't defer.
Amin Hassani41ac04b2019-03-29 11:31:03 -07001108 ASSERT_TRUE(TestUpdateCheck());
1109
Chris Sosa968d0572013-08-23 14:46:02 -07001110 EXPECT_TRUE(response.update_exists);
Jay Srinivasan480ddfa2012-06-01 19:15:26 -07001111}
1112
Alex Deymoe1e3afe2014-10-30 13:02:49 -07001113TEST_F(OmahaRequestActionTest, NoWallClockBasedWaitCausesNoScattering) {
Marton Hunyady2abda312018-04-24 18:21:49 +02001114 request_params_.set_wall_clock_based_wait_enabled(false);
1115 request_params_.set_waiting_period(TimeDelta::FromDays(2));
1116 request_params_.set_update_check_count_wait_enabled(true);
1117 request_params_.set_min_update_checks_needed(1);
1118 request_params_.set_max_update_checks_allowed(8);
Amin Hassani41ac04b2019-03-29 11:31:03 -07001119 tuc_params_.http_response = fake_update_response_.GetUpdateResponse();
Jay Srinivasan480ddfa2012-06-01 19:15:26 -07001120
Amin Hassani41ac04b2019-03-29 11:31:03 -07001121 ASSERT_TRUE(TestUpdateCheck());
1122
Jay Srinivasan480ddfa2012-06-01 19:15:26 -07001123 EXPECT_TRUE(response.update_exists);
1124}
1125
Alex Deymoe1e3afe2014-10-30 13:02:49 -07001126TEST_F(OmahaRequestActionTest, ZeroMaxDaysToScatterCausesNoScattering) {
Marton Hunyady2abda312018-04-24 18:21:49 +02001127 request_params_.set_wall_clock_based_wait_enabled(true);
1128 request_params_.set_waiting_period(TimeDelta::FromDays(2));
1129 request_params_.set_update_check_count_wait_enabled(true);
1130 request_params_.set_min_update_checks_needed(1);
1131 request_params_.set_max_update_checks_allowed(8);
Alex Deymo8e18f932015-03-27 16:16:59 -07001132 fake_update_response_.max_days_to_scatter = "0";
Amin Hassani41ac04b2019-03-29 11:31:03 -07001133 tuc_params_.http_response = fake_update_response_.GetUpdateResponse();
1134
1135 ASSERT_TRUE(TestUpdateCheck());
1136
Jay Srinivasan480ddfa2012-06-01 19:15:26 -07001137 EXPECT_TRUE(response.update_exists);
1138}
1139
Alex Deymoe1e3afe2014-10-30 13:02:49 -07001140TEST_F(OmahaRequestActionTest, ZeroUpdateCheckCountCausesNoScattering) {
Marton Hunyady2abda312018-04-24 18:21:49 +02001141 request_params_.set_wall_clock_based_wait_enabled(true);
1142 request_params_.set_waiting_period(TimeDelta());
1143 request_params_.set_update_check_count_wait_enabled(true);
1144 request_params_.set_min_update_checks_needed(0);
1145 request_params_.set_max_update_checks_allowed(0);
May Lippert60aa3ca2018-08-15 16:55:29 -07001146 fake_system_state_.fake_clock()->SetWallclockTime(Time::Now());
Amin Hassani41ac04b2019-03-29 11:31:03 -07001147 tuc_params_.http_response = fake_update_response_.GetUpdateResponse();
May Lippert60aa3ca2018-08-15 16:55:29 -07001148
Amin Hassani41ac04b2019-03-29 11:31:03 -07001149 ASSERT_TRUE(TestUpdateCheck());
Jay Srinivasan480ddfa2012-06-01 19:15:26 -07001150
Ben Chan9abb7632014-08-07 00:10:53 -07001151 int64_t count;
Alex Deymoe1e3afe2014-10-30 13:02:49 -07001152 ASSERT_TRUE(fake_prefs_.GetInt64(kPrefsUpdateCheckCount, &count));
Alex Vakulenkod2779df2014-06-16 13:19:00 -07001153 ASSERT_EQ(count, 0);
Jay Srinivasan480ddfa2012-06-01 19:15:26 -07001154 EXPECT_TRUE(response.update_exists);
1155}
1156
Alex Deymoe1e3afe2014-10-30 13:02:49 -07001157TEST_F(OmahaRequestActionTest, NonZeroUpdateCheckCountCausesScattering) {
Marton Hunyady2abda312018-04-24 18:21:49 +02001158 request_params_.set_wall_clock_based_wait_enabled(true);
1159 request_params_.set_waiting_period(TimeDelta());
1160 request_params_.set_update_check_count_wait_enabled(true);
1161 request_params_.set_min_update_checks_needed(1);
1162 request_params_.set_max_update_checks_allowed(8);
May Lippert60aa3ca2018-08-15 16:55:29 -07001163 fake_system_state_.fake_clock()->SetWallclockTime(Time::Now());
Amin Hassani41ac04b2019-03-29 11:31:03 -07001164 tuc_params_.http_response = fake_update_response_.GetUpdateResponse();
1165 tuc_params_.expected_code = ErrorCode::kOmahaUpdateDeferredPerPolicy;
1166 tuc_params_.expected_check_reaction = metrics::CheckReaction::kDeferring;
May Lippert60aa3ca2018-08-15 16:55:29 -07001167
Amin Hassani41ac04b2019-03-29 11:31:03 -07001168 ASSERT_FALSE(TestUpdateCheck());
Jay Srinivasan480ddfa2012-06-01 19:15:26 -07001169
Ben Chan9abb7632014-08-07 00:10:53 -07001170 int64_t count;
Alex Deymoe1e3afe2014-10-30 13:02:49 -07001171 ASSERT_TRUE(fake_prefs_.GetInt64(kPrefsUpdateCheckCount, &count));
Alex Vakulenkod2779df2014-06-16 13:19:00 -07001172 ASSERT_GT(count, 0);
Jay Srinivasan480ddfa2012-06-01 19:15:26 -07001173 EXPECT_FALSE(response.update_exists);
1174}
1175
Amin Hassani41ac04b2019-03-29 11:31:03 -07001176TEST_F(OmahaRequestActionTest,
1177 NonZeroUpdateCheckCountCausesScatteringInteractive) {
Marton Hunyady2abda312018-04-24 18:21:49 +02001178 request_params_.set_wall_clock_based_wait_enabled(true);
1179 request_params_.set_waiting_period(TimeDelta());
1180 request_params_.set_update_check_count_wait_enabled(true);
1181 request_params_.set_min_update_checks_needed(1);
1182 request_params_.set_max_update_checks_allowed(8);
Amin Hassani41ac04b2019-03-29 11:31:03 -07001183 request_params_.set_interactive(true);
May Lippert60aa3ca2018-08-15 16:55:29 -07001184 fake_system_state_.fake_clock()->SetWallclockTime(Time::Now());
Amin Hassani41ac04b2019-03-29 11:31:03 -07001185 tuc_params_.http_response = fake_update_response_.GetUpdateResponse();
1186
1187 // Verify if we are interactive check we don't defer.
1188 ASSERT_TRUE(TestUpdateCheck());
1189
1190 EXPECT_TRUE(response.update_exists);
1191}
1192
1193TEST_F(OmahaRequestActionTest, ExistingUpdateCheckCountCausesScattering) {
1194 request_params_.set_wall_clock_based_wait_enabled(true);
1195 request_params_.set_waiting_period(TimeDelta());
1196 request_params_.set_update_check_count_wait_enabled(true);
1197 request_params_.set_min_update_checks_needed(1);
1198 request_params_.set_max_update_checks_allowed(8);
1199 fake_system_state_.fake_clock()->SetWallclockTime(Time::Now());
1200 tuc_params_.http_response = fake_update_response_.GetUpdateResponse();
1201 tuc_params_.expected_code = ErrorCode::kOmahaUpdateDeferredPerPolicy;
1202 tuc_params_.expected_check_reaction = metrics::CheckReaction::kDeferring;
May Lippert60aa3ca2018-08-15 16:55:29 -07001203
Alex Deymoe1e3afe2014-10-30 13:02:49 -07001204 ASSERT_TRUE(fake_prefs_.SetInt64(kPrefsUpdateCheckCount, 5));
Amin Hassani41ac04b2019-03-29 11:31:03 -07001205 ASSERT_FALSE(TestUpdateCheck());
Jay Srinivasan480ddfa2012-06-01 19:15:26 -07001206
Ben Chan9abb7632014-08-07 00:10:53 -07001207 int64_t count;
Alex Deymoe1e3afe2014-10-30 13:02:49 -07001208 ASSERT_TRUE(fake_prefs_.GetInt64(kPrefsUpdateCheckCount, &count));
Amin Hassani41ac04b2019-03-29 11:31:03 -07001209 // |count| remains the same, as the decrementing happens in update_attempter
Jay Srinivasan480ddfa2012-06-01 19:15:26 -07001210 // which this test doesn't exercise.
Alex Vakulenkod2779df2014-06-16 13:19:00 -07001211 ASSERT_EQ(count, 5);
Jay Srinivasan480ddfa2012-06-01 19:15:26 -07001212 EXPECT_FALSE(response.update_exists);
Amin Hassani41ac04b2019-03-29 11:31:03 -07001213}
1214
1215TEST_F(OmahaRequestActionTest,
1216 ExistingUpdateCheckCountCausesScatteringInteractive) {
1217 request_params_.set_wall_clock_based_wait_enabled(true);
1218 request_params_.set_waiting_period(TimeDelta());
1219 request_params_.set_update_check_count_wait_enabled(true);
1220 request_params_.set_min_update_checks_needed(1);
1221 request_params_.set_max_update_checks_allowed(8);
1222 request_params_.set_interactive(true);
1223 fake_system_state_.fake_clock()->SetWallclockTime(Time::Now());
1224 tuc_params_.http_response = fake_update_response_.GetUpdateResponse();
1225
1226 ASSERT_TRUE(fake_prefs_.SetInt64(kPrefsUpdateCheckCount, 5));
Chris Sosa968d0572013-08-23 14:46:02 -07001227
1228 // Verify if we are interactive check we don't defer.
Amin Hassani41ac04b2019-03-29 11:31:03 -07001229 ASSERT_TRUE(TestUpdateCheck());
Chris Sosa968d0572013-08-23 14:46:02 -07001230 EXPECT_TRUE(response.update_exists);
Jay Srinivasan480ddfa2012-06-01 19:15:26 -07001231}
Jay Srinivasan0a708742012-03-20 11:26:12 -07001232
Adolfo Victoria497044c2018-07-18 07:51:42 -07001233TEST_F(OmahaRequestActionTest, StagingTurnedOnCausesScattering) {
1234 // If staging is on, the value for max days to scatter should be ignored, and
1235 // staging's scatter value should be used.
Adolfo Victoria497044c2018-07-18 07:51:42 -07001236 request_params_.set_wall_clock_based_wait_enabled(true);
1237 request_params_.set_waiting_period(TimeDelta::FromDays(6));
1238 request_params_.set_update_check_count_wait_enabled(false);
May Lippert60aa3ca2018-08-15 16:55:29 -07001239 fake_system_state_.fake_clock()->SetWallclockTime(Time::Now());
1240
Adolfo Victoria497044c2018-07-18 07:51:42 -07001241 ASSERT_TRUE(fake_prefs_.SetInt64(kPrefsWallClockStagingWaitPeriod, 6));
1242 // This should not prevent scattering due to staging.
1243 fake_update_response_.max_days_to_scatter = "0";
Amin Hassani41ac04b2019-03-29 11:31:03 -07001244 tuc_params_.http_response = fake_update_response_.GetUpdateResponse();
1245 tuc_params_.expected_code = ErrorCode::kOmahaUpdateDeferredPerPolicy;
1246 tuc_params_.expected_check_reaction = metrics::CheckReaction::kDeferring;
1247
1248 ASSERT_FALSE(TestUpdateCheck());
1249
Adolfo Victoria497044c2018-07-18 07:51:42 -07001250 EXPECT_FALSE(response.update_exists);
1251
1252 // Interactive updates should not be affected.
1253 request_params_.set_interactive(true);
Amin Hassani41ac04b2019-03-29 11:31:03 -07001254 tuc_params_.expected_code = ErrorCode::kSuccess;
1255 tuc_params_.expected_check_reaction = metrics::CheckReaction::kUpdating;
1256
1257 ASSERT_TRUE(TestUpdateCheck());
1258
Adolfo Victoria497044c2018-07-18 07:51:42 -07001259 EXPECT_TRUE(response.update_exists);
1260}
1261
Alex Deymo8e18f932015-03-27 16:16:59 -07001262TEST_F(OmahaRequestActionTest, CohortsArePersisted) {
Alex Deymo8e18f932015-03-27 16:16:59 -07001263 fake_update_response_.include_cohorts = true;
1264 fake_update_response_.cohort = "s/154454/8479665";
1265 fake_update_response_.cohorthint = "please-put-me-on-beta";
1266 fake_update_response_.cohortname = "stable";
Amin Hassani41ac04b2019-03-29 11:31:03 -07001267 tuc_params_.http_response = fake_update_response_.GetUpdateResponse();
Alex Deymo8e18f932015-03-27 16:16:59 -07001268
Amin Hassani41ac04b2019-03-29 11:31:03 -07001269 ASSERT_TRUE(TestUpdateCheck());
Alex Deymo8e18f932015-03-27 16:16:59 -07001270
1271 string value;
1272 EXPECT_TRUE(fake_prefs_.GetString(kPrefsOmahaCohort, &value));
1273 EXPECT_EQ(fake_update_response_.cohort, value);
1274
1275 EXPECT_TRUE(fake_prefs_.GetString(kPrefsOmahaCohortHint, &value));
1276 EXPECT_EQ(fake_update_response_.cohorthint, value);
1277
1278 EXPECT_TRUE(fake_prefs_.GetString(kPrefsOmahaCohortName, &value));
1279 EXPECT_EQ(fake_update_response_.cohortname, value);
1280}
1281
1282TEST_F(OmahaRequestActionTest, CohortsAreUpdated) {
Alex Deymo8e18f932015-03-27 16:16:59 -07001283 EXPECT_TRUE(fake_prefs_.SetString(kPrefsOmahaCohort, "old_value"));
1284 EXPECT_TRUE(fake_prefs_.SetString(kPrefsOmahaCohortHint, "old_hint"));
1285 EXPECT_TRUE(fake_prefs_.SetString(kPrefsOmahaCohortName, "old_name"));
1286 fake_update_response_.include_cohorts = true;
1287 fake_update_response_.cohort = "s/154454/8479665";
1288 fake_update_response_.cohorthint = "please-put-me-on-beta";
1289 fake_update_response_.cohortname = "";
Amin Hassani41ac04b2019-03-29 11:31:03 -07001290 tuc_params_.http_response = fake_update_response_.GetUpdateResponse();
Alex Deymo8e18f932015-03-27 16:16:59 -07001291
Amin Hassani41ac04b2019-03-29 11:31:03 -07001292 ASSERT_TRUE(TestUpdateCheck());
Alex Deymo8e18f932015-03-27 16:16:59 -07001293
1294 string value;
1295 EXPECT_TRUE(fake_prefs_.GetString(kPrefsOmahaCohort, &value));
1296 EXPECT_EQ(fake_update_response_.cohort, value);
1297
1298 EXPECT_TRUE(fake_prefs_.GetString(kPrefsOmahaCohortHint, &value));
1299 EXPECT_EQ(fake_update_response_.cohorthint, value);
1300
1301 EXPECT_FALSE(fake_prefs_.GetString(kPrefsOmahaCohortName, &value));
1302}
1303
1304TEST_F(OmahaRequestActionTest, CohortsAreNotModifiedWhenMissing) {
Amin Hassani41ac04b2019-03-29 11:31:03 -07001305 tuc_params_.http_response = fake_update_response_.GetUpdateResponse();
Alex Deymo8e18f932015-03-27 16:16:59 -07001306
Amin Hassani41ac04b2019-03-29 11:31:03 -07001307 EXPECT_TRUE(fake_prefs_.SetString(kPrefsOmahaCohort, "old_value"));
1308 ASSERT_TRUE(TestUpdateCheck());
Alex Deymo8e18f932015-03-27 16:16:59 -07001309
1310 string value;
1311 EXPECT_TRUE(fake_prefs_.GetString(kPrefsOmahaCohort, &value));
1312 EXPECT_EQ("old_value", value);
1313
1314 EXPECT_FALSE(fake_prefs_.GetString(kPrefsOmahaCohortHint, &value));
1315 EXPECT_FALSE(fake_prefs_.GetString(kPrefsOmahaCohortName, &value));
1316}
1317
Alex Deymo00d79ac2015-06-29 15:41:49 -07001318TEST_F(OmahaRequestActionTest, CohortsArePersistedWhenNoUpdate) {
Alex Deymo00d79ac2015-06-29 15:41:49 -07001319 fake_update_response_.include_cohorts = true;
1320 fake_update_response_.cohort = "s/154454/8479665";
1321 fake_update_response_.cohorthint = "please-put-me-on-beta";
1322 fake_update_response_.cohortname = "stable";
Amin Hassani41ac04b2019-03-29 11:31:03 -07001323 tuc_params_.http_response = fake_update_response_.GetNoUpdateResponse();
1324 tuc_params_.expected_check_result = metrics::CheckResult::kNoUpdateAvailable;
1325 tuc_params_.expected_check_reaction = metrics::CheckReaction::kUnset;
Alex Deymo00d79ac2015-06-29 15:41:49 -07001326
Amin Hassani41ac04b2019-03-29 11:31:03 -07001327 ASSERT_TRUE(TestUpdateCheck());
Alex Deymo00d79ac2015-06-29 15:41:49 -07001328
1329 string value;
1330 EXPECT_TRUE(fake_prefs_.GetString(kPrefsOmahaCohort, &value));
1331 EXPECT_EQ(fake_update_response_.cohort, value);
1332
1333 EXPECT_TRUE(fake_prefs_.GetString(kPrefsOmahaCohortHint, &value));
1334 EXPECT_EQ(fake_update_response_.cohorthint, value);
1335
1336 EXPECT_TRUE(fake_prefs_.GetString(kPrefsOmahaCohortName, &value));
1337 EXPECT_EQ(fake_update_response_.cohortname, value);
1338}
1339
Sen Jiangb1e063a2017-09-15 17:44:31 -07001340TEST_F(OmahaRequestActionTest, MultiAppCohortTest) {
Sen Jiangb1e063a2017-09-15 17:44:31 -07001341 fake_update_response_.multi_app = true;
1342 fake_update_response_.include_cohorts = true;
1343 fake_update_response_.cohort = "s/154454/8479665";
1344 fake_update_response_.cohorthint = "please-put-me-on-beta";
1345 fake_update_response_.cohortname = "stable";
Amin Hassani41ac04b2019-03-29 11:31:03 -07001346 tuc_params_.http_response = fake_update_response_.GetUpdateResponse();
Sen Jiangb1e063a2017-09-15 17:44:31 -07001347
Amin Hassani41ac04b2019-03-29 11:31:03 -07001348 ASSERT_TRUE(TestUpdateCheck());
Sen Jiangb1e063a2017-09-15 17:44:31 -07001349
1350 string value;
1351 EXPECT_TRUE(fake_prefs_.GetString(kPrefsOmahaCohort, &value));
1352 EXPECT_EQ(fake_update_response_.cohort, value);
1353
1354 EXPECT_TRUE(fake_prefs_.GetString(kPrefsOmahaCohortHint, &value));
1355 EXPECT_EQ(fake_update_response_.cohorthint, value);
1356
1357 EXPECT_TRUE(fake_prefs_.GetString(kPrefsOmahaCohortName, &value));
1358 EXPECT_EQ(fake_update_response_.cohortname, value);
1359}
1360
Alex Deymoe1e3afe2014-10-30 13:02:49 -07001361TEST_F(OmahaRequestActionTest, NoOutputPipeTest) {
Alex Deymo8e18f932015-03-27 16:16:59 -07001362 const string http_response(fake_update_response_.GetNoUpdateResponse());
Alex Vakulenko3f39d5c2015-10-13 09:27:13 -07001363 brillo::FakeMessageLoop loop(nullptr);
Alex Deymo60ca1a72015-06-18 18:19:15 -07001364 loop.SetAsCurrent();
Darin Petkov6a5b3222010-07-13 14:55:28 -07001365
Amin Hassanid3f4bea2018-04-30 14:52:40 -07001366 auto action = std::make_unique<OmahaRequestAction>(
Ben Chan5c02c132017-06-27 07:10:36 -07001367 &fake_system_state_,
1368 nullptr,
Amin Hassanid3f4bea2018-04-30 14:52:40 -07001369 std::make_unique<MockHttpFetcher>(
1370 http_response.data(), http_response.size(), nullptr),
Jae Hoon Kimedb65502019-06-14 11:52:17 -07001371 false,
1372 "");
Darin Petkov6a5b3222010-07-13 14:55:28 -07001373 ActionProcessor processor;
Amin Hassanid3f4bea2018-04-30 14:52:40 -07001374 processor.set_delegate(&delegate_);
1375 processor.EnqueueAction(std::move(action));
Darin Petkov6a5b3222010-07-13 14:55:28 -07001376
Luis Hector Chavezf1cf3482016-07-19 14:29:19 -07001377 loop.PostTask(base::Bind(
1378 [](ActionProcessor* processor) { processor->StartProcessing(); },
1379 base::Unretained(&processor)));
Alex Deymo60ca1a72015-06-18 18:19:15 -07001380 loop.Run();
1381 EXPECT_FALSE(loop.PendingTasks());
Darin Petkov6a5b3222010-07-13 14:55:28 -07001382 EXPECT_FALSE(processor.IsRunning());
1383}
1384
Alex Deymoe1e3afe2014-10-30 13:02:49 -07001385TEST_F(OmahaRequestActionTest, InvalidXmlTest) {
Amin Hassani41ac04b2019-03-29 11:31:03 -07001386 tuc_params_.http_response = "invalid xml>";
1387 tuc_params_.expected_code = ErrorCode::kOmahaRequestXMLParseError;
1388 tuc_params_.expected_check_result = metrics::CheckResult::kParsingError;
1389 tuc_params_.expected_check_reaction = metrics::CheckReaction::kUnset;
1390
1391 ASSERT_FALSE(TestUpdateCheck());
Darin Petkovedc522e2010-11-05 09:35:17 -07001392 EXPECT_FALSE(response.update_exists);
1393}
1394
Alex Deymoe1e3afe2014-10-30 13:02:49 -07001395TEST_F(OmahaRequestActionTest, EmptyResponseTest) {
Amin Hassani41ac04b2019-03-29 11:31:03 -07001396 tuc_params_.expected_code = ErrorCode::kOmahaRequestEmptyResponseError;
1397 tuc_params_.expected_check_result = metrics::CheckResult::kParsingError;
1398 tuc_params_.expected_check_reaction = metrics::CheckReaction::kUnset;
1399
1400 ASSERT_FALSE(TestUpdateCheck());
Darin Petkov6a5b3222010-07-13 14:55:28 -07001401 EXPECT_FALSE(response.update_exists);
1402}
1403
Alex Deymoe1e3afe2014-10-30 13:02:49 -07001404TEST_F(OmahaRequestActionTest, MissingStatusTest) {
Amin Hassani41ac04b2019-03-29 11:31:03 -07001405 tuc_params_.http_response =
Jay Srinivasan23b92a52012-10-27 02:00:21 -07001406 "<?xml version=\"1.0\" encoding=\"UTF-8\"?><response protocol=\"3.0\">"
1407 "<daystart elapsed_seconds=\"100\"/>"
1408 "<app appid=\"foo\" status=\"ok\">"
1409 "<ping status=\"ok\"/>"
Amin Hassani41ac04b2019-03-29 11:31:03 -07001410 "<updatecheck/></app></response>";
1411 tuc_params_.expected_code = ErrorCode::kOmahaResponseInvalid;
1412 tuc_params_.expected_check_result = metrics::CheckResult::kParsingError;
1413 tuc_params_.expected_check_reaction = metrics::CheckReaction::kUnset;
1414
1415 ASSERT_FALSE(TestUpdateCheck());
Darin Petkov6a5b3222010-07-13 14:55:28 -07001416 EXPECT_FALSE(response.update_exists);
1417}
1418
Alex Deymoe1e3afe2014-10-30 13:02:49 -07001419TEST_F(OmahaRequestActionTest, InvalidStatusTest) {
Amin Hassani41ac04b2019-03-29 11:31:03 -07001420 tuc_params_.http_response =
Jay Srinivasan23b92a52012-10-27 02:00:21 -07001421 "<?xml version=\"1.0\" encoding=\"UTF-8\"?><response protocol=\"3.0\">"
1422 "<daystart elapsed_seconds=\"100\"/>"
1423 "<app appid=\"foo\" status=\"ok\">"
1424 "<ping status=\"ok\"/>"
Amin Hassani41ac04b2019-03-29 11:31:03 -07001425 "<updatecheck status=\"InvalidStatusTest\"/></app></response>";
1426 tuc_params_.expected_code = ErrorCode::kOmahaResponseInvalid;
1427 tuc_params_.expected_check_result = metrics::CheckResult::kParsingError;
1428 tuc_params_.expected_check_reaction = metrics::CheckReaction::kUnset;
1429
1430 ASSERT_FALSE(TestUpdateCheck());
Darin Petkov6a5b3222010-07-13 14:55:28 -07001431 EXPECT_FALSE(response.update_exists);
1432}
1433
Alex Deymoe1e3afe2014-10-30 13:02:49 -07001434TEST_F(OmahaRequestActionTest, MissingNodesetTest) {
Amin Hassani41ac04b2019-03-29 11:31:03 -07001435 tuc_params_.http_response =
Jay Srinivasan23b92a52012-10-27 02:00:21 -07001436 "<?xml version=\"1.0\" encoding=\"UTF-8\"?><response protocol=\"3.0\">"
1437 "<daystart elapsed_seconds=\"100\"/>"
1438 "<app appid=\"foo\" status=\"ok\">"
1439 "<ping status=\"ok\"/>"
Amin Hassani41ac04b2019-03-29 11:31:03 -07001440 "</app></response>";
1441 tuc_params_.expected_code = ErrorCode::kOmahaResponseInvalid;
1442 tuc_params_.expected_check_result = metrics::CheckResult::kParsingError;
1443 tuc_params_.expected_check_reaction = metrics::CheckReaction::kUnset;
1444
1445 ASSERT_FALSE(TestUpdateCheck());
Darin Petkov6a5b3222010-07-13 14:55:28 -07001446 EXPECT_FALSE(response.update_exists);
1447}
1448
Alex Deymoe1e3afe2014-10-30 13:02:49 -07001449TEST_F(OmahaRequestActionTest, MissingFieldTest) {
Amin Hassani41ac04b2019-03-29 11:31:03 -07001450 tuc_params_.http_response =
Jay Srinivasan23b92a52012-10-27 02:00:21 -07001451 "<?xml version=\"1.0\" encoding=\"UTF-8\"?><response protocol=\"3.0\">"
1452 "<daystart elapsed_seconds=\"100\"/>"
Aaron Wood7dcdedf2017-09-06 17:17:41 -07001453 // the appid needs to match that in the request params
1454 "<app appid=\"" +
1455 fake_update_response_.app_id +
1456 "\" status=\"ok\">"
Jay Srinivasan23b92a52012-10-27 02:00:21 -07001457 "<updatecheck status=\"ok\">"
1458 "<urls><url codebase=\"http://missing/field/test/\"/></urls>"
Chris Sosa3b748432013-06-20 16:42:59 -07001459 "<manifest version=\"10.2.3.4\">"
Jay Srinivasan23b92a52012-10-27 02:00:21 -07001460 "<packages><package hash=\"not-used\" name=\"f\" "
Sen Jiang2703ef42017-03-16 13:36:21 -07001461 "size=\"587\" hash_sha256=\"lkq34j5345\"/></packages>"
Jay Srinivasan23b92a52012-10-27 02:00:21 -07001462 "<actions><action event=\"postinstall\" "
Jay Srinivasan23b92a52012-10-27 02:00:21 -07001463 "Prompt=\"false\" "
Jay Srinivasand671e972013-01-11 17:17:19 -08001464 "IsDeltaPayload=\"false\" "
Sen Jiang2703ef42017-03-16 13:36:21 -07001465 "sha256=\"not-used\" "
Jay Srinivasan23b92a52012-10-27 02:00:21 -07001466 "/></actions></manifest></updatecheck></app></response>";
Jay Srinivasan23b92a52012-10-27 02:00:21 -07001467
Amin Hassani41ac04b2019-03-29 11:31:03 -07001468 ASSERT_TRUE(TestUpdateCheck());
1469
Darin Petkov6a5b3222010-07-13 14:55:28 -07001470 EXPECT_TRUE(response.update_exists);
Chris Sosa3b748432013-06-20 16:42:59 -07001471 EXPECT_EQ("10.2.3.4", response.version);
Sen Jiang0affc2c2017-02-10 15:55:05 -08001472 EXPECT_EQ("http://missing/field/test/f",
1473 response.packages[0].payload_urls[0]);
Darin Petkov6a5b3222010-07-13 14:55:28 -07001474 EXPECT_EQ("", response.more_info_url);
Sen Jiang0affc2c2017-02-10 15:55:05 -08001475 EXPECT_EQ("lkq34j5345", response.packages[0].hash);
1476 EXPECT_EQ(587u, response.packages[0].size);
Darin Petkov6a5b3222010-07-13 14:55:28 -07001477 EXPECT_FALSE(response.prompt);
Darin Petkov6c118642010-10-21 12:06:30 -07001478 EXPECT_TRUE(response.deadline.empty());
Darin Petkov6a5b3222010-07-13 14:55:28 -07001479}
1480
1481namespace {
1482class TerminateEarlyTestProcessorDelegate : public ActionProcessorDelegate {
1483 public:
1484 void ProcessingStopped(const ActionProcessor* processor) {
Alex Vakulenko3f39d5c2015-10-13 09:27:13 -07001485 brillo::MessageLoop::current()->BreakLoop();
Darin Petkov6a5b3222010-07-13 14:55:28 -07001486 }
Darin Petkov6a5b3222010-07-13 14:55:28 -07001487};
1488
Alex Deymo60ca1a72015-06-18 18:19:15 -07001489void TerminateTransferTestStarter(ActionProcessor* processor) {
Darin Petkov6a5b3222010-07-13 14:55:28 -07001490 processor->StartProcessing();
1491 CHECK(processor->IsRunning());
1492 processor->StopProcessing();
Darin Petkov6a5b3222010-07-13 14:55:28 -07001493}
Alex Vakulenkod2779df2014-06-16 13:19:00 -07001494} // namespace
Darin Petkov6a5b3222010-07-13 14:55:28 -07001495
Alex Deymoe1e3afe2014-10-30 13:02:49 -07001496TEST_F(OmahaRequestActionTest, TerminateTransferTest) {
Alex Vakulenko3f39d5c2015-10-13 09:27:13 -07001497 brillo::FakeMessageLoop loop(nullptr);
Alex Deymo60ca1a72015-06-18 18:19:15 -07001498 loop.SetAsCurrent();
Darin Petkov6a5b3222010-07-13 14:55:28 -07001499
Alex Deymo60ca1a72015-06-18 18:19:15 -07001500 string http_response("doesn't matter");
Amin Hassanid3f4bea2018-04-30 14:52:40 -07001501 auto action = std::make_unique<OmahaRequestAction>(
Ben Chan5c02c132017-06-27 07:10:36 -07001502 &fake_system_state_,
1503 nullptr,
Amin Hassanid3f4bea2018-04-30 14:52:40 -07001504 std::make_unique<MockHttpFetcher>(
1505 http_response.data(), http_response.size(), nullptr),
Jae Hoon Kimedb65502019-06-14 11:52:17 -07001506 false,
1507 "");
Darin Petkov6a5b3222010-07-13 14:55:28 -07001508 TerminateEarlyTestProcessorDelegate delegate;
Darin Petkov6a5b3222010-07-13 14:55:28 -07001509 ActionProcessor processor;
1510 processor.set_delegate(&delegate);
Amin Hassanid3f4bea2018-04-30 14:52:40 -07001511 processor.EnqueueAction(std::move(action));
Darin Petkov6a5b3222010-07-13 14:55:28 -07001512
Alex Deymo60ca1a72015-06-18 18:19:15 -07001513 loop.PostTask(base::Bind(&TerminateTransferTestStarter, &processor));
1514 loop.Run();
1515 EXPECT_FALSE(loop.PendingTasks());
Darin Petkov6a5b3222010-07-13 14:55:28 -07001516}
1517
Alex Deymob0d74eb2015-03-30 17:59:17 -07001518TEST_F(OmahaRequestActionTest, XmlEncodeIsUsedForParams) {
Amin Hassani41ac04b2019-03-29 11:31:03 -07001519 // Make sure XML Encode is being called on the params.
Marton Hunyady2abda312018-04-24 18:21:49 +02001520 request_params_.set_os_sp("testtheservice_pack>");
1521 request_params_.set_os_board("x86 generic<id");
1522 request_params_.set_current_channel("unittest_track&lt;");
1523 request_params_.set_target_channel("unittest_track&lt;");
1524 request_params_.set_hwid("<OEM MODEL>");
Alex Deymo8e18f932015-03-27 16:16:59 -07001525 fake_prefs_.SetString(kPrefsOmahaCohort, "evil\nstring");
1526 fake_prefs_.SetString(kPrefsOmahaCohortHint, "evil&string\\");
Amin Hassani7cc8bb02019-01-14 16:29:47 -08001527 fake_prefs_.SetString(
1528 kPrefsOmahaCohortName,
1529 base::JoinString(vector<string>(100, "My spoon is too big."), " "));
Amin Hassani41ac04b2019-03-29 11:31:03 -07001530 tuc_params_.http_response = "invalid xml>";
1531 tuc_params_.expected_code = ErrorCode::kOmahaRequestXMLParseError;
1532 tuc_params_.expected_check_result = metrics::CheckResult::kParsingError;
1533 tuc_params_.expected_check_reaction = metrics::CheckReaction::kUnset;
1534
1535 ASSERT_FALSE(TestUpdateCheck());
1536
Alex Deymo8e18f932015-03-27 16:16:59 -07001537 EXPECT_NE(string::npos, post_str.find("testtheservice_pack&gt;"));
1538 EXPECT_EQ(string::npos, post_str.find("testtheservice_pack>"));
1539 EXPECT_NE(string::npos, post_str.find("x86 generic&lt;id"));
1540 EXPECT_EQ(string::npos, post_str.find("x86 generic<id"));
1541 EXPECT_NE(string::npos, post_str.find("unittest_track&amp;lt;"));
1542 EXPECT_EQ(string::npos, post_str.find("unittest_track&lt;"));
1543 EXPECT_NE(string::npos, post_str.find("&lt;OEM MODEL&gt;"));
1544 EXPECT_EQ(string::npos, post_str.find("<OEM MODEL>"));
1545 EXPECT_NE(string::npos, post_str.find("cohort=\"evil\nstring\""));
1546 EXPECT_EQ(string::npos, post_str.find("cohorthint=\"evil&string\\\""));
1547 EXPECT_NE(string::npos, post_str.find("cohorthint=\"evil&amp;string\\\""));
1548 // Values from Prefs that are too big are removed from the XML instead of
1549 // encoded.
1550 EXPECT_EQ(string::npos, post_str.find("cohortname="));
Darin Petkov6a5b3222010-07-13 14:55:28 -07001551}
1552
Alex Deymoe1e3afe2014-10-30 13:02:49 -07001553TEST_F(OmahaRequestActionTest, XmlDecodeTest) {
Alex Deymo8e18f932015-03-27 16:16:59 -07001554 fake_update_response_.deadline = "&lt;20110101";
1555 fake_update_response_.more_info_url = "testthe&lt;url";
1556 fake_update_response_.codebase = "testthe&amp;codebase/";
Amin Hassani41ac04b2019-03-29 11:31:03 -07001557 tuc_params_.http_response = fake_update_response_.GetUpdateResponse();
1558
1559 ASSERT_TRUE(TestUpdateCheck());
Darin Petkov6a5b3222010-07-13 14:55:28 -07001560
Sen Jiang0affc2c2017-02-10 15:55:05 -08001561 EXPECT_EQ("testthe<url", response.more_info_url);
1562 EXPECT_EQ("testthe&codebase/file.signed",
1563 response.packages[0].payload_urls[0]);
1564 EXPECT_EQ("<20110101", response.deadline);
Darin Petkov6a5b3222010-07-13 14:55:28 -07001565}
1566
Alex Deymoe1e3afe2014-10-30 13:02:49 -07001567TEST_F(OmahaRequestActionTest, ParseIntTest) {
Alex Deymo8e18f932015-03-27 16:16:59 -07001568 // overflows int32_t:
Sen Jiang0affc2c2017-02-10 15:55:05 -08001569 fake_update_response_.size = 123123123123123ull;
Amin Hassani41ac04b2019-03-29 11:31:03 -07001570 tuc_params_.http_response = fake_update_response_.GetUpdateResponse();
Darin Petkov6a5b3222010-07-13 14:55:28 -07001571
Amin Hassani41ac04b2019-03-29 11:31:03 -07001572 ASSERT_TRUE(TestUpdateCheck());
Sen Jiang0affc2c2017-02-10 15:55:05 -08001573 EXPECT_EQ(fake_update_response_.size, response.packages[0].size);
Darin Petkov6a5b3222010-07-13 14:55:28 -07001574}
1575
Alex Deymoe1e3afe2014-10-30 13:02:49 -07001576TEST_F(OmahaRequestActionTest, FormatUpdateCheckOutputTest) {
Alex Deymo8427b4a2014-11-05 14:00:32 -08001577 NiceMock<MockPrefs> prefs;
Alex Deymoe1e3afe2014-10-30 13:02:49 -07001578 fake_system_state_.set_prefs(&prefs);
Amin Hassani41ac04b2019-03-29 11:31:03 -07001579 tuc_params_.http_response = "invalid xml>";
1580 tuc_params_.expected_code = ErrorCode::kOmahaRequestXMLParseError;
1581 tuc_params_.expected_check_result = metrics::CheckResult::kParsingError;
1582 tuc_params_.expected_check_reaction = metrics::CheckReaction::kUnset;
Alex Deymoe1e3afe2014-10-30 13:02:49 -07001583
Darin Petkov95508da2011-01-05 12:42:29 -08001584 EXPECT_CALL(prefs, GetString(kPrefsPreviousVersion, _))
Ben Chan672c1f52017-10-23 15:41:39 -07001585 .WillOnce(DoAll(SetArgPointee<1>(string("")), Return(true)));
Alex Deymoefb9d832015-11-02 18:39:02 -08001586 // An existing but empty previous version means that we didn't reboot to a new
1587 // update, therefore, no need to update the previous version.
1588 EXPECT_CALL(prefs, SetString(kPrefsPreviousVersion, _)).Times(0);
Amin Hassani41ac04b2019-03-29 11:31:03 -07001589 ASSERT_FALSE(TestUpdateCheck());
1590
Marton Hunyadyba51c3f2018-04-25 15:18:10 +02001591 EXPECT_NE(
1592 post_str.find(" <ping active=\"1\" a=\"-1\" r=\"-1\"></ping>\n"
1593 " <updatecheck></updatecheck>\n"),
Jay Srinivasan0a708742012-03-20 11:26:12 -07001594 string::npos);
Darin Petkovfbb40092010-07-29 17:05:50 -07001595 EXPECT_NE(post_str.find("hardware_class=\"OEM MODEL 09235 7471\""),
1596 string::npos);
Amin Hassani7cc8bb02019-01-14 16:29:47 -08001597 EXPECT_NE(post_str.find("fw_version=\"ChromeOSFirmware.1.0\""), string::npos);
1598 EXPECT_NE(post_str.find("ec_version=\"0X0A1\""), string::npos);
Alex Deymoefb9d832015-11-02 18:39:02 -08001599 // No <event> tag should be sent if we didn't reboot to an update.
1600 EXPECT_EQ(post_str.find("<event"), string::npos);
Darin Petkov0dc8e9a2010-07-14 14:51:57 -07001601}
1602
Alex Deymoe1e3afe2014-10-30 13:02:49 -07001603TEST_F(OmahaRequestActionTest, FormatSuccessEventOutputTest) {
Marton Hunyady2abda312018-04-24 18:21:49 +02001604 TestEvent(new OmahaEvent(OmahaEvent::kTypeUpdateDownloadStarted),
Amin Hassani41ac04b2019-03-29 11:31:03 -07001605 "invalid xml>");
1606
Alex Vakulenko75039d72014-03-25 12:36:28 -07001607 string expected_event = base::StringPrintf(
Jay Srinivasan23b92a52012-10-27 02:00:21 -07001608 " <event eventtype=\"%d\" eventresult=\"%d\"></event>\n",
Darin Petkove17f86b2010-07-20 09:12:01 -07001609 OmahaEvent::kTypeUpdateDownloadStarted,
1610 OmahaEvent::kResultSuccess);
1611 EXPECT_NE(post_str.find(expected_event), string::npos);
Jay Srinivasan23b92a52012-10-27 02:00:21 -07001612 EXPECT_EQ(post_str.find("ping"), string::npos);
1613 EXPECT_EQ(post_str.find("updatecheck"), string::npos);
Darin Petkove17f86b2010-07-20 09:12:01 -07001614}
1615
Alex Deymoe1e3afe2014-10-30 13:02:49 -07001616TEST_F(OmahaRequestActionTest, FormatErrorEventOutputTest) {
Marton Hunyady2abda312018-04-24 18:21:49 +02001617 TestEvent(new OmahaEvent(OmahaEvent::kTypeDownloadComplete,
Darin Petkove17f86b2010-07-20 09:12:01 -07001618 OmahaEvent::kResultError,
Gilad Arnoldd1c4d2d2014-06-05 14:07:53 -07001619 ErrorCode::kError),
Amin Hassani41ac04b2019-03-29 11:31:03 -07001620 "invalid xml>");
1621
Alex Vakulenko75039d72014-03-25 12:36:28 -07001622 string expected_event = base::StringPrintf(
Jay Srinivasan23b92a52012-10-27 02:00:21 -07001623 " <event eventtype=\"%d\" eventresult=\"%d\" "
1624 "errorcode=\"%d\"></event>\n",
Darin Petkove17f86b2010-07-20 09:12:01 -07001625 OmahaEvent::kTypeDownloadComplete,
1626 OmahaEvent::kResultError,
Gilad Arnoldd1c4d2d2014-06-05 14:07:53 -07001627 static_cast<int>(ErrorCode::kError));
Darin Petkov0dc8e9a2010-07-14 14:51:57 -07001628 EXPECT_NE(post_str.find(expected_event), string::npos);
Jay Srinivasan23b92a52012-10-27 02:00:21 -07001629 EXPECT_EQ(post_str.find("updatecheck"), string::npos);
Darin Petkov0dc8e9a2010-07-14 14:51:57 -07001630}
1631
Alex Deymoe1e3afe2014-10-30 13:02:49 -07001632TEST_F(OmahaRequestActionTest, IsEventTest) {
Darin Petkov0dc8e9a2010-07-14 14:51:57 -07001633 string http_response("doesn't matter");
Darin Petkov0dc8e9a2010-07-14 14:51:57 -07001634 OmahaRequestAction update_check_action(
Alex Deymoe1e3afe2014-10-30 13:02:49 -07001635 &fake_system_state_,
Alex Vakulenko88b591f2014-08-28 16:48:57 -07001636 nullptr,
Amin Hassani7cc8bb02019-01-14 16:29:47 -08001637 std::make_unique<MockHttpFetcher>(
1638 http_response.data(), http_response.size(), nullptr),
Jae Hoon Kimedb65502019-06-14 11:52:17 -07001639 false,
1640 "");
Darin Petkov0dc8e9a2010-07-14 14:51:57 -07001641 EXPECT_FALSE(update_check_action.IsEvent());
1642
1643 OmahaRequestAction event_action(
Alex Deymoe1e3afe2014-10-30 13:02:49 -07001644 &fake_system_state_,
Darin Petkove17f86b2010-07-20 09:12:01 -07001645 new OmahaEvent(OmahaEvent::kTypeUpdateComplete),
Amin Hassani7cc8bb02019-01-14 16:29:47 -08001646 std::make_unique<MockHttpFetcher>(
1647 http_response.data(), http_response.size(), nullptr),
Jae Hoon Kimedb65502019-06-14 11:52:17 -07001648 false,
1649 "");
Darin Petkov0dc8e9a2010-07-14 14:51:57 -07001650 EXPECT_TRUE(event_action.IsEvent());
1651}
1652
Alex Deymoe1e3afe2014-10-30 13:02:49 -07001653TEST_F(OmahaRequestActionTest, FormatDeltaOkayOutputTest) {
Amin Hassani41ac04b2019-03-29 11:31:03 -07001654 tuc_params_.http_response = "invalid xml>";
1655 tuc_params_.expected_code = ErrorCode::kOmahaRequestXMLParseError;
1656 tuc_params_.expected_check_result = metrics::CheckResult::kParsingError;
1657 tuc_params_.expected_check_reaction = metrics::CheckReaction::kUnset;
1658
Andrew de los Reyes3f0303a2010-07-15 22:35:35 -07001659 for (int i = 0; i < 2; i++) {
1660 bool delta_okay = i == 1;
1661 const char* delta_okay_str = delta_okay ? "true" : "false";
Marton Hunyady2abda312018-04-24 18:21:49 +02001662 request_params_.set_delta_okay(delta_okay);
1663
Amin Hassani41ac04b2019-03-29 11:31:03 -07001664 ASSERT_FALSE(TestUpdateCheck());
Amin Hassani7cc8bb02019-01-14 16:29:47 -08001665 EXPECT_NE(
1666 post_str.find(base::StringPrintf(" delta_okay=\"%s\"", delta_okay_str)),
1667 string::npos)
Andrew de los Reyes3f0303a2010-07-15 22:35:35 -07001668 << "i = " << i;
1669 }
1670}
1671
Alex Deymoe1e3afe2014-10-30 13:02:49 -07001672TEST_F(OmahaRequestActionTest, FormatInteractiveOutputTest) {
Amin Hassani41ac04b2019-03-29 11:31:03 -07001673 tuc_params_.http_response = "invalid xml>";
1674 tuc_params_.expected_code = ErrorCode::kOmahaRequestXMLParseError;
1675 tuc_params_.expected_check_result = metrics::CheckResult::kParsingError;
1676 tuc_params_.expected_check_reaction = metrics::CheckReaction::kUnset;
1677
Gilad Arnoldbbdd4902013-01-10 16:06:30 -08001678 for (int i = 0; i < 2; i++) {
1679 bool interactive = i == 1;
Gilad Arnold8a659d82013-01-24 11:26:00 -08001680 const char* interactive_str = interactive ? "ondemandupdate" : "scheduler";
Marton Hunyady2abda312018-04-24 18:21:49 +02001681 request_params_.set_interactive(interactive);
1682
Amin Hassani41ac04b2019-03-29 11:31:03 -07001683 ASSERT_FALSE(TestUpdateCheck());
Marton Hunyadyba51c3f2018-04-25 15:18:10 +02001684 EXPECT_NE(post_str.find(
1685 base::StringPrintf("installsource=\"%s\"", interactive_str)),
Gilad Arnoldbbdd4902013-01-10 16:06:30 -08001686 string::npos)
1687 << "i = " << i;
1688 }
1689}
1690
Marton Hunyadyba51c3f2018-04-25 15:18:10 +02001691TEST_F(OmahaRequestActionTest, FormatTargetVersionPrefixOutputTest) {
Amin Hassani41ac04b2019-03-29 11:31:03 -07001692 tuc_params_.http_response = "invalid xml>";
1693 tuc_params_.expected_code = ErrorCode::kOmahaRequestXMLParseError;
1694 tuc_params_.expected_check_result = metrics::CheckResult::kParsingError;
1695 tuc_params_.expected_check_reaction = metrics::CheckReaction::kUnset;
1696
Marton Hunyadyba51c3f2018-04-25 15:18:10 +02001697 for (int i = 0; i < 2; i++) {
1698 bool target_version_set = i == 1;
1699 const char* target_version_prefix = target_version_set ? "10032." : "";
Marton Hunyadyba51c3f2018-04-25 15:18:10 +02001700 request_params_.set_target_version_prefix(target_version_prefix);
1701
Amin Hassani41ac04b2019-03-29 11:31:03 -07001702 ASSERT_FALSE(TestUpdateCheck());
Marton Hunyadyba51c3f2018-04-25 15:18:10 +02001703 if (target_version_set) {
1704 EXPECT_NE(post_str.find("<updatecheck targetversionprefix=\"10032.\">"),
1705 string::npos)
1706 << "i = " << i;
1707 } else {
1708 EXPECT_EQ(post_str.find("targetversionprefix"), string::npos)
1709 << "i = " << i;
1710 }
1711 }
1712}
1713
1714TEST_F(OmahaRequestActionTest, FormatRollbackAllowedOutputTest) {
Amin Hassani41ac04b2019-03-29 11:31:03 -07001715 tuc_params_.http_response = "invalid xml>";
1716 tuc_params_.expected_code = ErrorCode::kOmahaRequestXMLParseError;
1717 tuc_params_.expected_check_result = metrics::CheckResult::kParsingError;
1718 tuc_params_.expected_check_reaction = metrics::CheckReaction::kUnset;
1719
Marton Hunyadyba51c3f2018-04-25 15:18:10 +02001720 for (int i = 0; i < 4; i++) {
1721 bool rollback_allowed = i / 2 == 0;
1722 bool target_version_set = i % 2 == 0;
Marton Hunyadyba51c3f2018-04-25 15:18:10 +02001723 request_params_.set_target_version_prefix(target_version_set ? "10032."
1724 : "");
1725 request_params_.set_rollback_allowed(rollback_allowed);
1726
Amin Hassani41ac04b2019-03-29 11:31:03 -07001727 ASSERT_FALSE(TestUpdateCheck());
Marton Hunyadyba51c3f2018-04-25 15:18:10 +02001728 if (rollback_allowed && target_version_set) {
1729 EXPECT_NE(post_str.find("rollback_allowed=\"true\""), string::npos)
1730 << "i = " << i;
1731 } else {
1732 EXPECT_EQ(post_str.find("rollback_allowed"), string::npos) << "i = " << i;
1733 }
1734 }
1735}
1736
Alex Deymoe1e3afe2014-10-30 13:02:49 -07001737TEST_F(OmahaRequestActionTest, OmahaEventTest) {
Darin Petkove17f86b2010-07-20 09:12:01 -07001738 OmahaEvent default_event;
1739 EXPECT_EQ(OmahaEvent::kTypeUnknown, default_event.type);
1740 EXPECT_EQ(OmahaEvent::kResultError, default_event.result);
Gilad Arnoldd1c4d2d2014-06-05 14:07:53 -07001741 EXPECT_EQ(ErrorCode::kError, default_event.error_code);
Darin Petkove17f86b2010-07-20 09:12:01 -07001742
1743 OmahaEvent success_event(OmahaEvent::kTypeUpdateDownloadStarted);
1744 EXPECT_EQ(OmahaEvent::kTypeUpdateDownloadStarted, success_event.type);
1745 EXPECT_EQ(OmahaEvent::kResultSuccess, success_event.result);
Gilad Arnoldd1c4d2d2014-06-05 14:07:53 -07001746 EXPECT_EQ(ErrorCode::kSuccess, success_event.error_code);
Darin Petkove17f86b2010-07-20 09:12:01 -07001747
1748 OmahaEvent error_event(OmahaEvent::kTypeUpdateDownloadFinished,
1749 OmahaEvent::kResultError,
Gilad Arnoldd1c4d2d2014-06-05 14:07:53 -07001750 ErrorCode::kError);
Darin Petkove17f86b2010-07-20 09:12:01 -07001751 EXPECT_EQ(OmahaEvent::kTypeUpdateDownloadFinished, error_event.type);
1752 EXPECT_EQ(OmahaEvent::kResultError, error_event.result);
Gilad Arnoldd1c4d2d2014-06-05 14:07:53 -07001753 EXPECT_EQ(ErrorCode::kError, error_event.error_code);
Darin Petkove17f86b2010-07-20 09:12:01 -07001754}
1755
Askar Aitzhan570ca872019-04-24 11:16:12 +02001756TEST_F(OmahaRequestActionTest, DeviceQuickFixBuildTokenIsSetTest) {
Askar Aitzhan18fff842019-06-21 23:24:37 +02001757 // If DeviceQuickFixBuildToken value is set it takes precedence over pref
1758 // value.
1759 constexpr char autoupdate_token[] = "autoupdate_token>";
1760 constexpr char xml_encoded_autoupdate_token[] = "autoupdate_token&gt;";
1761 constexpr char omaha_cohort_hint[] = "cohort_hint";
Askar Aitzhan570ca872019-04-24 11:16:12 +02001762
1763 tuc_params_.http_response = fake_update_response_.GetNoUpdateResponse();
1764 tuc_params_.expected_check_result = metrics::CheckResult::kNoUpdateAvailable;
1765 tuc_params_.expected_check_reaction = metrics::CheckReaction::kUnset;
1766 request_params_.set_autoupdate_token(autoupdate_token);
Askar Aitzhan18fff842019-06-21 23:24:37 +02001767 fake_prefs_.SetString(kPrefsOmahaCohortHint, omaha_cohort_hint);
Askar Aitzhan570ca872019-04-24 11:16:12 +02001768
1769 ASSERT_TRUE(TestUpdateCheck());
1770
Askar Aitzhan18fff842019-06-21 23:24:37 +02001771 EXPECT_NE(string::npos,
1772 post_str.find("cohorthint=\"" +
1773 string(xml_encoded_autoupdate_token) + "\""));
1774 EXPECT_EQ(string::npos, post_str.find(autoupdate_token));
1775 EXPECT_EQ(string::npos, post_str.find(omaha_cohort_hint));
1776}
1777
1778TEST_F(OmahaRequestActionTest, DeviceQuickFixBuildTokenIsNotSetTest) {
1779 // If DeviceQuickFixBuildToken is not set, pref value will be provided in
1780 // cohorthint attribute.
1781 constexpr char omaha_cohort_hint[] = "evil_string>";
1782 constexpr char xml_encoded_cohort_hint[] = "evil_string&gt;";
1783
1784 tuc_params_.http_response = fake_update_response_.GetNoUpdateResponse();
1785 tuc_params_.expected_check_result = metrics::CheckResult::kNoUpdateAvailable;
1786 tuc_params_.expected_check_reaction = metrics::CheckReaction::kUnset;
1787 fake_prefs_.SetString(kPrefsOmahaCohortHint, omaha_cohort_hint);
1788
1789 ASSERT_TRUE(TestUpdateCheck());
1790
1791 EXPECT_NE(
1792 string::npos,
1793 post_str.find("cohorthint=\"" + string(xml_encoded_cohort_hint) + "\""));
1794 EXPECT_EQ(string::npos, post_str.find(omaha_cohort_hint));
Askar Aitzhan570ca872019-04-24 11:16:12 +02001795}
1796
Alex Deymoe1e3afe2014-10-30 13:02:49 -07001797void OmahaRequestActionTest::PingTest(bool ping_only) {
Alex Deymo8427b4a2014-11-05 14:00:32 -08001798 NiceMock<MockPrefs> prefs;
Alex Deymoe1e3afe2014-10-30 13:02:49 -07001799 fake_system_state_.set_prefs(&prefs);
1800 EXPECT_CALL(prefs, GetInt64(kPrefsMetricsCheckLastReportingTime, _))
Amin Hassani7cc8bb02019-01-14 16:29:47 -08001801 .Times(AnyNumber());
Alex Deymoe1e3afe2014-10-30 13:02:49 -07001802 EXPECT_CALL(prefs, SetInt64(_, _)).Times(AnyNumber());
1803 // Add a few hours to the day difference to test no rounding, etc.
1804 int64_t five_days_ago =
1805 (Time::Now() - TimeDelta::FromHours(5 * 24 + 13)).ToInternalValue();
1806 int64_t six_days_ago =
1807 (Time::Now() - TimeDelta::FromHours(6 * 24 + 11)).ToInternalValue();
1808 EXPECT_CALL(prefs, GetInt64(kPrefsInstallDateDays, _))
Ben Chan672c1f52017-10-23 15:41:39 -07001809 .WillOnce(DoAll(SetArgPointee<1>(0), Return(true)));
Alex Deymoe1e3afe2014-10-30 13:02:49 -07001810 EXPECT_CALL(prefs, GetInt64(kPrefsLastActivePingDay, _))
Ben Chan672c1f52017-10-23 15:41:39 -07001811 .WillOnce(DoAll(SetArgPointee<1>(six_days_ago), Return(true)));
Alex Deymoe1e3afe2014-10-30 13:02:49 -07001812 EXPECT_CALL(prefs, GetInt64(kPrefsLastRollCallPingDay, _))
Ben Chan672c1f52017-10-23 15:41:39 -07001813 .WillOnce(DoAll(SetArgPointee<1>(five_days_ago), Return(true)));
Amin Hassani41ac04b2019-03-29 11:31:03 -07001814
1815 tuc_params_.http_response = fake_update_response_.GetNoUpdateResponse();
1816 tuc_params_.ping_only = ping_only;
1817 tuc_params_.expected_check_result = metrics::CheckResult::kNoUpdateAvailable;
1818 tuc_params_.expected_check_reaction = metrics::CheckReaction::kUnset;
1819
1820 ASSERT_TRUE(TestUpdateCheck());
1821
Alex Deymoe1e3afe2014-10-30 13:02:49 -07001822 EXPECT_NE(post_str.find("<ping active=\"1\" a=\"6\" r=\"5\"></ping>"),
1823 string::npos);
1824 if (ping_only) {
1825 EXPECT_EQ(post_str.find("updatecheck"), string::npos);
1826 EXPECT_EQ(post_str.find("previousversion"), string::npos);
1827 } else {
1828 EXPECT_NE(post_str.find("updatecheck"), string::npos);
1829 EXPECT_NE(post_str.find("previousversion"), string::npos);
Darin Petkov265f2902011-05-09 15:17:40 -07001830 }
Darin Petkov1cbd78f2010-07-29 12:38:34 -07001831}
1832
Alex Deymoe1e3afe2014-10-30 13:02:49 -07001833TEST_F(OmahaRequestActionTest, PingTestSendOnlyAPing) {
Amin Hassani7cc8bb02019-01-14 16:29:47 -08001834 PingTest(true /* ping_only */);
Alex Deymoe1e3afe2014-10-30 13:02:49 -07001835}
1836
1837TEST_F(OmahaRequestActionTest, PingTestSendAlsoAnUpdateCheck) {
Amin Hassani7cc8bb02019-01-14 16:29:47 -08001838 PingTest(false /* ping_only */);
Alex Deymoe1e3afe2014-10-30 13:02:49 -07001839}
1840
1841TEST_F(OmahaRequestActionTest, ActivePingTest) {
Alex Deymo8427b4a2014-11-05 14:00:32 -08001842 NiceMock<MockPrefs> prefs;
Alex Deymoe1e3afe2014-10-30 13:02:49 -07001843 fake_system_state_.set_prefs(&prefs);
David Zeuthen33bae492014-02-25 16:16:18 -08001844 EXPECT_CALL(prefs, GetInt64(kPrefsMetricsCheckLastReportingTime, _))
Amin Hassani7cc8bb02019-01-14 16:29:47 -08001845 .Times(AnyNumber());
David Zeuthen33bae492014-02-25 16:16:18 -08001846 EXPECT_CALL(prefs, SetInt64(_, _)).Times(AnyNumber());
Darin Petkov1cbd78f2010-07-29 12:38:34 -07001847 int64_t three_days_ago =
1848 (Time::Now() - TimeDelta::FromHours(3 * 24 + 12)).ToInternalValue();
1849 int64_t now = Time::Now().ToInternalValue();
David Zeuthen639aa362014-02-03 16:23:44 -08001850 EXPECT_CALL(prefs, GetInt64(kPrefsInstallDateDays, _))
Ben Chan672c1f52017-10-23 15:41:39 -07001851 .WillOnce(DoAll(SetArgPointee<1>(0), Return(true)));
Darin Petkov1cbd78f2010-07-29 12:38:34 -07001852 EXPECT_CALL(prefs, GetInt64(kPrefsLastActivePingDay, _))
Ben Chan672c1f52017-10-23 15:41:39 -07001853 .WillOnce(DoAll(SetArgPointee<1>(three_days_ago), Return(true)));
Darin Petkov1cbd78f2010-07-29 12:38:34 -07001854 EXPECT_CALL(prefs, GetInt64(kPrefsLastRollCallPingDay, _))
Ben Chan672c1f52017-10-23 15:41:39 -07001855 .WillOnce(DoAll(SetArgPointee<1>(now), Return(true)));
Amin Hassani41ac04b2019-03-29 11:31:03 -07001856
1857 tuc_params_.http_response = fake_update_response_.GetNoUpdateResponse();
1858 tuc_params_.expected_check_result = metrics::CheckResult::kNoUpdateAvailable;
1859 tuc_params_.expected_check_reaction = metrics::CheckReaction::kUnset;
1860
1861 ASSERT_TRUE(TestUpdateCheck());
1862
Amin Hassani7cc8bb02019-01-14 16:29:47 -08001863 EXPECT_NE(post_str.find("<ping active=\"1\" a=\"3\"></ping>"), string::npos);
Darin Petkov1cbd78f2010-07-29 12:38:34 -07001864}
1865
Alex Deymoe1e3afe2014-10-30 13:02:49 -07001866TEST_F(OmahaRequestActionTest, RollCallPingTest) {
Alex Deymo8427b4a2014-11-05 14:00:32 -08001867 NiceMock<MockPrefs> prefs;
Alex Deymoe1e3afe2014-10-30 13:02:49 -07001868 fake_system_state_.set_prefs(&prefs);
David Zeuthen33bae492014-02-25 16:16:18 -08001869 EXPECT_CALL(prefs, GetInt64(kPrefsMetricsCheckLastReportingTime, _))
Amin Hassani7cc8bb02019-01-14 16:29:47 -08001870 .Times(AnyNumber());
David Zeuthen33bae492014-02-25 16:16:18 -08001871 EXPECT_CALL(prefs, SetInt64(_, _)).Times(AnyNumber());
Darin Petkov1cbd78f2010-07-29 12:38:34 -07001872 int64_t four_days_ago =
1873 (Time::Now() - TimeDelta::FromHours(4 * 24)).ToInternalValue();
1874 int64_t now = Time::Now().ToInternalValue();
David Zeuthen639aa362014-02-03 16:23:44 -08001875 EXPECT_CALL(prefs, GetInt64(kPrefsInstallDateDays, _))
Ben Chan672c1f52017-10-23 15:41:39 -07001876 .WillOnce(DoAll(SetArgPointee<1>(0), Return(true)));
Darin Petkov1cbd78f2010-07-29 12:38:34 -07001877 EXPECT_CALL(prefs, GetInt64(kPrefsLastActivePingDay, _))
Ben Chan672c1f52017-10-23 15:41:39 -07001878 .WillOnce(DoAll(SetArgPointee<1>(now), Return(true)));
Darin Petkov1cbd78f2010-07-29 12:38:34 -07001879 EXPECT_CALL(prefs, GetInt64(kPrefsLastRollCallPingDay, _))
Ben Chan672c1f52017-10-23 15:41:39 -07001880 .WillOnce(DoAll(SetArgPointee<1>(four_days_ago), Return(true)));
Amin Hassani41ac04b2019-03-29 11:31:03 -07001881
1882 tuc_params_.http_response = fake_update_response_.GetNoUpdateResponse();
1883 tuc_params_.expected_check_result = metrics::CheckResult::kNoUpdateAvailable;
1884 tuc_params_.expected_check_reaction = metrics::CheckReaction::kUnset;
1885
1886 ASSERT_TRUE(TestUpdateCheck());
1887
Jay Srinivasan23b92a52012-10-27 02:00:21 -07001888 EXPECT_NE(post_str.find("<ping active=\"1\" r=\"4\"></ping>\n"),
Thieu Le116fda32011-04-19 11:01:54 -07001889 string::npos);
Darin Petkov1cbd78f2010-07-29 12:38:34 -07001890}
1891
Alex Deymoe1e3afe2014-10-30 13:02:49 -07001892TEST_F(OmahaRequestActionTest, NoPingTest) {
Alex Deymo8427b4a2014-11-05 14:00:32 -08001893 NiceMock<MockPrefs> prefs;
Alex Deymoe1e3afe2014-10-30 13:02:49 -07001894 fake_system_state_.set_prefs(&prefs);
David Zeuthen33bae492014-02-25 16:16:18 -08001895 EXPECT_CALL(prefs, GetInt64(kPrefsMetricsCheckLastReportingTime, _))
Amin Hassani7cc8bb02019-01-14 16:29:47 -08001896 .Times(AnyNumber());
David Zeuthen33bae492014-02-25 16:16:18 -08001897 EXPECT_CALL(prefs, SetInt64(_, _)).Times(AnyNumber());
Darin Petkov1cbd78f2010-07-29 12:38:34 -07001898 int64_t one_hour_ago =
1899 (Time::Now() - TimeDelta::FromHours(1)).ToInternalValue();
David Zeuthen639aa362014-02-03 16:23:44 -08001900 EXPECT_CALL(prefs, GetInt64(kPrefsInstallDateDays, _))
Ben Chan672c1f52017-10-23 15:41:39 -07001901 .WillOnce(DoAll(SetArgPointee<1>(0), Return(true)));
Darin Petkov1cbd78f2010-07-29 12:38:34 -07001902 EXPECT_CALL(prefs, GetInt64(kPrefsLastActivePingDay, _))
Ben Chan672c1f52017-10-23 15:41:39 -07001903 .WillOnce(DoAll(SetArgPointee<1>(one_hour_ago), Return(true)));
Darin Petkov1cbd78f2010-07-29 12:38:34 -07001904 EXPECT_CALL(prefs, GetInt64(kPrefsLastRollCallPingDay, _))
Ben Chan672c1f52017-10-23 15:41:39 -07001905 .WillOnce(DoAll(SetArgPointee<1>(one_hour_ago), Return(true)));
Alex Deymoebbe7ef2014-10-30 13:02:49 -07001906 // LastActivePingDay and PrefsLastRollCallPingDay are set even if we didn't
1907 // send a ping.
1908 EXPECT_CALL(prefs, SetInt64(kPrefsLastActivePingDay, _))
1909 .WillOnce(Return(true));
1910 EXPECT_CALL(prefs, SetInt64(kPrefsLastRollCallPingDay, _))
1911 .WillOnce(Return(true));
Amin Hassani41ac04b2019-03-29 11:31:03 -07001912
1913 tuc_params_.http_response = fake_update_response_.GetNoUpdateResponse();
1914 tuc_params_.expected_check_result = metrics::CheckResult::kNoUpdateAvailable;
1915 tuc_params_.expected_check_reaction = metrics::CheckReaction::kUnset;
1916
1917 ASSERT_TRUE(TestUpdateCheck());
1918
Jay Srinivasan23b92a52012-10-27 02:00:21 -07001919 EXPECT_EQ(post_str.find("ping"), string::npos);
Darin Petkov1cbd78f2010-07-29 12:38:34 -07001920}
1921
Alex Deymoe1e3afe2014-10-30 13:02:49 -07001922TEST_F(OmahaRequestActionTest, IgnoreEmptyPingTest) {
Thieu Leb44e9e82011-06-06 14:34:04 -07001923 // This test ensures that we ignore empty ping only requests.
Alex Deymo8427b4a2014-11-05 14:00:32 -08001924 NiceMock<MockPrefs> prefs;
Alex Deymoe1e3afe2014-10-30 13:02:49 -07001925 fake_system_state_.set_prefs(&prefs);
Thieu Leb44e9e82011-06-06 14:34:04 -07001926 int64_t now = Time::Now().ToInternalValue();
1927 EXPECT_CALL(prefs, GetInt64(kPrefsLastActivePingDay, _))
Ben Chan672c1f52017-10-23 15:41:39 -07001928 .WillOnce(DoAll(SetArgPointee<1>(now), Return(true)));
Thieu Leb44e9e82011-06-06 14:34:04 -07001929 EXPECT_CALL(prefs, GetInt64(kPrefsLastRollCallPingDay, _))
Ben Chan672c1f52017-10-23 15:41:39 -07001930 .WillOnce(DoAll(SetArgPointee<1>(now), Return(true)));
Thieu Leb44e9e82011-06-06 14:34:04 -07001931 EXPECT_CALL(prefs, SetInt64(kPrefsLastActivePingDay, _)).Times(0);
1932 EXPECT_CALL(prefs, SetInt64(kPrefsLastRollCallPingDay, _)).Times(0);
Amin Hassani41ac04b2019-03-29 11:31:03 -07001933
1934 tuc_params_.http_response = fake_update_response_.GetNoUpdateResponse();
1935 tuc_params_.ping_only = true;
1936 tuc_params_.expected_check_result = metrics::CheckResult::kUnset;
1937 tuc_params_.expected_check_reaction = metrics::CheckReaction::kUnset;
1938
1939 EXPECT_TRUE(TestUpdateCheck());
1940 EXPECT_TRUE(post_str.empty());
Thieu Leb44e9e82011-06-06 14:34:04 -07001941}
1942
Alex Deymoe1e3afe2014-10-30 13:02:49 -07001943TEST_F(OmahaRequestActionTest, BackInTimePingTest) {
Alex Deymo8427b4a2014-11-05 14:00:32 -08001944 NiceMock<MockPrefs> prefs;
Alex Deymoe1e3afe2014-10-30 13:02:49 -07001945 fake_system_state_.set_prefs(&prefs);
David Zeuthen33bae492014-02-25 16:16:18 -08001946 EXPECT_CALL(prefs, GetInt64(kPrefsMetricsCheckLastReportingTime, _))
Amin Hassani7cc8bb02019-01-14 16:29:47 -08001947 .Times(AnyNumber());
David Zeuthen33bae492014-02-25 16:16:18 -08001948 EXPECT_CALL(prefs, SetInt64(_, _)).Times(AnyNumber());
Darin Petkov1cbd78f2010-07-29 12:38:34 -07001949 int64_t future =
1950 (Time::Now() + TimeDelta::FromHours(3 * 24 + 4)).ToInternalValue();
David Zeuthen639aa362014-02-03 16:23:44 -08001951 EXPECT_CALL(prefs, GetInt64(kPrefsInstallDateDays, _))
Ben Chan672c1f52017-10-23 15:41:39 -07001952 .WillOnce(DoAll(SetArgPointee<1>(0), Return(true)));
Darin Petkov1cbd78f2010-07-29 12:38:34 -07001953 EXPECT_CALL(prefs, GetInt64(kPrefsLastActivePingDay, _))
Ben Chan672c1f52017-10-23 15:41:39 -07001954 .WillOnce(DoAll(SetArgPointee<1>(future), Return(true)));
Darin Petkov1cbd78f2010-07-29 12:38:34 -07001955 EXPECT_CALL(prefs, GetInt64(kPrefsLastRollCallPingDay, _))
Ben Chan672c1f52017-10-23 15:41:39 -07001956 .WillOnce(DoAll(SetArgPointee<1>(future), Return(true)));
Darin Petkov1cbd78f2010-07-29 12:38:34 -07001957 EXPECT_CALL(prefs, SetInt64(kPrefsLastActivePingDay, _))
1958 .WillOnce(Return(true));
1959 EXPECT_CALL(prefs, SetInt64(kPrefsLastRollCallPingDay, _))
1960 .WillOnce(Return(true));
Amin Hassani41ac04b2019-03-29 11:31:03 -07001961
1962 tuc_params_.http_response =
1963 "<?xml version=\"1.0\" encoding=\"UTF-8\"?><response "
1964 "protocol=\"3.0\"><daystart elapsed_seconds=\"100\"/>"
1965 "<app appid=\"foo\" status=\"ok\"><ping status=\"ok\"/>"
1966 "<updatecheck status=\"noupdate\"/></app></response>";
1967 tuc_params_.expected_check_result = metrics::CheckResult::kNoUpdateAvailable;
1968 tuc_params_.expected_check_reaction = metrics::CheckReaction::kUnset;
1969
1970 ASSERT_TRUE(TestUpdateCheck());
Jay Srinivasan23b92a52012-10-27 02:00:21 -07001971 EXPECT_EQ(post_str.find("ping"), string::npos);
Darin Petkov1cbd78f2010-07-29 12:38:34 -07001972}
1973
Alex Deymoe1e3afe2014-10-30 13:02:49 -07001974TEST_F(OmahaRequestActionTest, LastPingDayUpdateTest) {
Darin Petkov1cbd78f2010-07-29 12:38:34 -07001975 // This test checks that the action updates the last ping day to now
Darin Petkov84c763c2010-07-29 16:27:58 -07001976 // minus 200 seconds with a slack of 5 seconds. Therefore, the test
Darin Petkov1cbd78f2010-07-29 12:38:34 -07001977 // may fail if it runs for longer than 5 seconds. It shouldn't run
1978 // that long though.
1979 int64_t midnight =
1980 (Time::Now() - TimeDelta::FromSeconds(200)).ToInternalValue();
1981 int64_t midnight_slack =
1982 (Time::Now() - TimeDelta::FromSeconds(195)).ToInternalValue();
Alex Deymo8427b4a2014-11-05 14:00:32 -08001983 NiceMock<MockPrefs> prefs;
Alex Deymoe1e3afe2014-10-30 13:02:49 -07001984 fake_system_state_.set_prefs(&prefs);
David Zeuthen33bae492014-02-25 16:16:18 -08001985 EXPECT_CALL(prefs, GetInt64(_, _)).Times(AnyNumber());
1986 EXPECT_CALL(prefs, SetInt64(_, _)).Times(AnyNumber());
Amin Hassani7cc8bb02019-01-14 16:29:47 -08001987 EXPECT_CALL(prefs,
1988 SetInt64(kPrefsLastActivePingDay,
1989 AllOf(Ge(midnight), Le(midnight_slack))))
Darin Petkov1cbd78f2010-07-29 12:38:34 -07001990 .WillOnce(Return(true));
Amin Hassani7cc8bb02019-01-14 16:29:47 -08001991 EXPECT_CALL(prefs,
1992 SetInt64(kPrefsLastRollCallPingDay,
1993 AllOf(Ge(midnight), Le(midnight_slack))))
Darin Petkov1cbd78f2010-07-29 12:38:34 -07001994 .WillOnce(Return(true));
Amin Hassani41ac04b2019-03-29 11:31:03 -07001995
1996 tuc_params_.http_response =
1997 "<?xml version=\"1.0\" encoding=\"UTF-8\"?><response "
1998 "protocol=\"3.0\"><daystart elapsed_seconds=\"200\"/>"
1999 "<app appid=\"foo\" status=\"ok\"><ping status=\"ok\"/>"
2000 "<updatecheck status=\"noupdate\"/></app></response>";
2001 tuc_params_.expected_check_result = metrics::CheckResult::kNoUpdateAvailable;
2002 tuc_params_.expected_check_reaction = metrics::CheckReaction::kUnset;
2003
2004 ASSERT_TRUE(TestUpdateCheck());
Darin Petkov1cbd78f2010-07-29 12:38:34 -07002005}
2006
Alex Deymoe1e3afe2014-10-30 13:02:49 -07002007TEST_F(OmahaRequestActionTest, NoElapsedSecondsTest) {
Alex Deymo8427b4a2014-11-05 14:00:32 -08002008 NiceMock<MockPrefs> prefs;
Alex Deymoe1e3afe2014-10-30 13:02:49 -07002009 fake_system_state_.set_prefs(&prefs);
David Zeuthen33bae492014-02-25 16:16:18 -08002010 EXPECT_CALL(prefs, GetInt64(_, _)).Times(AnyNumber());
2011 EXPECT_CALL(prefs, SetInt64(_, _)).Times(AnyNumber());
Darin Petkov1cbd78f2010-07-29 12:38:34 -07002012 EXPECT_CALL(prefs, SetInt64(kPrefsLastActivePingDay, _)).Times(0);
2013 EXPECT_CALL(prefs, SetInt64(kPrefsLastRollCallPingDay, _)).Times(0);
Amin Hassani41ac04b2019-03-29 11:31:03 -07002014
2015 tuc_params_.http_response =
2016 "<?xml version=\"1.0\" encoding=\"UTF-8\"?><response "
2017 "protocol=\"3.0\"><daystart blah=\"200\"/>"
2018 "<app appid=\"foo\" status=\"ok\"><ping status=\"ok\"/>"
2019 "<updatecheck status=\"noupdate\"/></app></response>";
2020 tuc_params_.expected_check_result = metrics::CheckResult::kNoUpdateAvailable;
2021 tuc_params_.expected_check_reaction = metrics::CheckReaction::kUnset;
2022
2023 ASSERT_TRUE(TestUpdateCheck());
Darin Petkov1cbd78f2010-07-29 12:38:34 -07002024}
2025
Alex Deymoe1e3afe2014-10-30 13:02:49 -07002026TEST_F(OmahaRequestActionTest, BadElapsedSecondsTest) {
Alex Deymo8427b4a2014-11-05 14:00:32 -08002027 NiceMock<MockPrefs> prefs;
Alex Deymoe1e3afe2014-10-30 13:02:49 -07002028 fake_system_state_.set_prefs(&prefs);
David Zeuthen33bae492014-02-25 16:16:18 -08002029 EXPECT_CALL(prefs, GetInt64(_, _)).Times(AnyNumber());
2030 EXPECT_CALL(prefs, SetInt64(_, _)).Times(AnyNumber());
Darin Petkov1cbd78f2010-07-29 12:38:34 -07002031 EXPECT_CALL(prefs, SetInt64(kPrefsLastActivePingDay, _)).Times(0);
2032 EXPECT_CALL(prefs, SetInt64(kPrefsLastRollCallPingDay, _)).Times(0);
Amin Hassani41ac04b2019-03-29 11:31:03 -07002033
2034 tuc_params_.http_response =
2035 "<?xml version=\"1.0\" encoding=\"UTF-8\"?><response "
2036 "protocol=\"3.0\"><daystart elapsed_seconds=\"x\"/>"
2037 "<app appid=\"foo\" status=\"ok\"><ping status=\"ok\"/>"
2038 "<updatecheck status=\"noupdate\"/></app></response>";
2039 tuc_params_.expected_check_result = metrics::CheckResult::kNoUpdateAvailable;
2040 tuc_params_.expected_check_reaction = metrics::CheckReaction::kUnset;
2041
2042 ASSERT_TRUE(TestUpdateCheck());
Darin Petkov1cbd78f2010-07-29 12:38:34 -07002043}
2044
Alex Deymoe1e3afe2014-10-30 13:02:49 -07002045TEST_F(OmahaRequestActionTest, NoUniqueIDTest) {
Amin Hassani41ac04b2019-03-29 11:31:03 -07002046 tuc_params_.http_response = "invalid xml>";
2047 tuc_params_.expected_code = ErrorCode::kOmahaRequestXMLParseError;
2048 tuc_params_.expected_check_result = metrics::CheckResult::kParsingError;
2049 tuc_params_.expected_check_reaction = metrics::CheckReaction::kUnset;
2050
2051 ASSERT_FALSE(TestUpdateCheck());
2052
Darin Petkov84c763c2010-07-29 16:27:58 -07002053 EXPECT_EQ(post_str.find("machineid="), string::npos);
2054 EXPECT_EQ(post_str.find("userid="), string::npos);
2055}
2056
Alex Deymoe1e3afe2014-10-30 13:02:49 -07002057TEST_F(OmahaRequestActionTest, NetworkFailureTest) {
Gilad Arnoldd1c4d2d2014-06-05 14:07:53 -07002058 const int http_error_code =
2059 static_cast<int>(ErrorCode::kOmahaRequestHTTPResponseBase) + 501;
Amin Hassani41ac04b2019-03-29 11:31:03 -07002060 tuc_params_.fail_http_response_code = 501;
2061 tuc_params_.expected_code = static_cast<ErrorCode>(http_error_code);
2062 tuc_params_.expected_check_result = metrics::CheckResult::kDownloadError;
2063 tuc_params_.expected_check_reaction = metrics::CheckReaction::kUnset;
2064 tuc_params_.expected_download_error_code =
2065 static_cast<metrics::DownloadErrorCode>(501);
2066
2067 ASSERT_FALSE(TestUpdateCheck());
2068
Darin Petkovedc522e2010-11-05 09:35:17 -07002069 EXPECT_FALSE(response.update_exists);
2070}
2071
Alex Deymoe1e3afe2014-10-30 13:02:49 -07002072TEST_F(OmahaRequestActionTest, NetworkFailureBadHTTPCodeTest) {
Gilad Arnoldd1c4d2d2014-06-05 14:07:53 -07002073 const int http_error_code =
2074 static_cast<int>(ErrorCode::kOmahaRequestHTTPResponseBase) + 999;
Amin Hassani41ac04b2019-03-29 11:31:03 -07002075
2076 tuc_params_.fail_http_response_code = 1500;
2077 tuc_params_.expected_code = static_cast<ErrorCode>(http_error_code);
2078 tuc_params_.expected_check_result = metrics::CheckResult::kDownloadError;
2079 tuc_params_.expected_check_reaction = metrics::CheckReaction::kUnset;
2080 tuc_params_.expected_download_error_code =
2081 metrics::DownloadErrorCode::kHttpStatusOther;
2082
2083 ASSERT_FALSE(TestUpdateCheck());
Darin Petkovedc522e2010-11-05 09:35:17 -07002084 EXPECT_FALSE(response.update_exists);
2085}
2086
Alex Deymoe1e3afe2014-10-30 13:02:49 -07002087TEST_F(OmahaRequestActionTest, TestUpdateFirstSeenAtGetsPersistedFirstTime) {
Marton Hunyady2abda312018-04-24 18:21:49 +02002088 request_params_.set_wall_clock_based_wait_enabled(true);
2089 request_params_.set_waiting_period(TimeDelta().FromDays(1));
2090 request_params_.set_update_check_count_wait_enabled(false);
Jay Srinivasan34b5d862012-07-23 11:43:22 -07002091
Sen Jiang7c1171e2016-06-23 11:35:40 -07002092 Time arbitrary_date;
Eric Caruso761be2c2018-05-22 16:23:33 -07002093 ASSERT_TRUE(Time::FromString("6/4/1989", &arbitrary_date));
Sen Jiang7c1171e2016-06-23 11:35:40 -07002094 fake_system_state_.fake_clock()->SetWallclockTime(arbitrary_date);
Amin Hassani41ac04b2019-03-29 11:31:03 -07002095
2096 tuc_params_.http_response = fake_update_response_.GetUpdateResponse();
2097 tuc_params_.expected_code = ErrorCode::kOmahaUpdateDeferredPerPolicy;
2098 tuc_params_.expected_check_reaction = metrics::CheckReaction::kDeferring;
2099
2100 ASSERT_FALSE(TestUpdateCheck());
Jay Srinivasan34b5d862012-07-23 11:43:22 -07002101
Ben Chan9abb7632014-08-07 00:10:53 -07002102 int64_t timestamp = 0;
Alex Deymoe1e3afe2014-10-30 13:02:49 -07002103 ASSERT_TRUE(fake_prefs_.GetInt64(kPrefsUpdateFirstSeenAt, &timestamp));
Sen Jiang7c1171e2016-06-23 11:35:40 -07002104 EXPECT_EQ(arbitrary_date.ToInternalValue(), timestamp);
Jay Srinivasan34b5d862012-07-23 11:43:22 -07002105 EXPECT_FALSE(response.update_exists);
Chris Sosa968d0572013-08-23 14:46:02 -07002106
2107 // Verify if we are interactive check we don't defer.
Marton Hunyady2abda312018-04-24 18:21:49 +02002108 request_params_.set_interactive(true);
Amin Hassani41ac04b2019-03-29 11:31:03 -07002109 tuc_params_.expected_code = ErrorCode::kSuccess;
2110 tuc_params_.expected_check_reaction = metrics::CheckReaction::kUpdating;
2111
2112 ASSERT_TRUE(TestUpdateCheck());
Chris Sosa968d0572013-08-23 14:46:02 -07002113 EXPECT_TRUE(response.update_exists);
Jay Srinivasan34b5d862012-07-23 11:43:22 -07002114}
2115
Alex Deymoe1e3afe2014-10-30 13:02:49 -07002116TEST_F(OmahaRequestActionTest, TestUpdateFirstSeenAtGetsUsedIfAlreadyPresent) {
Marton Hunyady2abda312018-04-24 18:21:49 +02002117 request_params_.set_wall_clock_based_wait_enabled(true);
2118 request_params_.set_waiting_period(TimeDelta().FromDays(1));
2119 request_params_.set_update_check_count_wait_enabled(false);
Jay Srinivasan34b5d862012-07-23 11:43:22 -07002120
Sen Jiang7c1171e2016-06-23 11:35:40 -07002121 Time t1, t2;
Eric Caruso761be2c2018-05-22 16:23:33 -07002122 ASSERT_TRUE(Time::FromString("1/1/2012", &t1));
2123 ASSERT_TRUE(Time::FromString("1/3/2012", &t2));
Sen Jiang7c1171e2016-06-23 11:35:40 -07002124 ASSERT_TRUE(
2125 fake_prefs_.SetInt64(kPrefsUpdateFirstSeenAt, t1.ToInternalValue()));
2126 fake_system_state_.fake_clock()->SetWallclockTime(t2);
Jay Srinivasan34b5d862012-07-23 11:43:22 -07002127
Amin Hassani41ac04b2019-03-29 11:31:03 -07002128 tuc_params_.http_response = fake_update_response_.GetUpdateResponse();
2129
2130 ASSERT_TRUE(TestUpdateCheck());
Jay Srinivasan34b5d862012-07-23 11:43:22 -07002131 EXPECT_TRUE(response.update_exists);
2132
2133 // Make sure the timestamp t1 is unchanged showing that it was reused.
Ben Chan9abb7632014-08-07 00:10:53 -07002134 int64_t timestamp = 0;
Alex Deymoe1e3afe2014-10-30 13:02:49 -07002135 ASSERT_TRUE(fake_prefs_.GetInt64(kPrefsUpdateFirstSeenAt, &timestamp));
Jay Srinivasan34b5d862012-07-23 11:43:22 -07002136 ASSERT_TRUE(timestamp == t1.ToInternalValue());
2137}
2138
Alex Deymoe1e3afe2014-10-30 13:02:49 -07002139TEST_F(OmahaRequestActionTest, TestChangingToMoreStableChannel) {
Gilad Arnoldeff87cc2013-07-22 18:32:09 -07002140 // Create a uniquely named test directory.
Sen Jiang297e5832016-03-17 14:45:51 -07002141 base::ScopedTempDir tempdir;
2142 ASSERT_TRUE(tempdir.CreateUniqueTempDir());
Gilad Arnoldeff87cc2013-07-22 18:32:09 -07002143
Marton Hunyady2abda312018-04-24 18:21:49 +02002144 request_params_.set_root(tempdir.GetPath().value());
2145 request_params_.set_app_id("{22222222-2222-2222-2222-222222222222}");
2146 request_params_.set_app_version("1.2.3.4");
2147 request_params_.set_product_components("o.bundle=1");
2148 request_params_.set_current_channel("canary-channel");
2149 EXPECT_TRUE(
2150 request_params_.SetTargetChannel("stable-channel", true, nullptr));
2151 request_params_.UpdateDownloadChannel();
2152 EXPECT_TRUE(request_params_.ShouldPowerwash());
Amin Hassani41ac04b2019-03-29 11:31:03 -07002153
2154 tuc_params_.http_response = "invalid xml>";
2155 tuc_params_.expected_code = ErrorCode::kOmahaRequestXMLParseError;
2156 tuc_params_.expected_check_result = metrics::CheckResult::kParsingError;
2157 tuc_params_.expected_check_reaction = metrics::CheckReaction::kUnset;
2158
2159 ASSERT_FALSE(TestUpdateCheck());
2160
Amin Hassani7cc8bb02019-01-14 16:29:47 -08002161 EXPECT_NE(
2162 string::npos,
2163 post_str.find("appid=\"{22222222-2222-2222-2222-222222222222}\" "
2164 "version=\"0.0.0.0\" from_version=\"1.2.3.4\" "
2165 "track=\"stable-channel\" from_track=\"canary-channel\" "));
Sen Jiang8cd42342018-01-31 12:06:59 -08002166 EXPECT_EQ(string::npos, post_str.find("o.bundle"));
Jay Srinivasanae4697c2013-03-18 17:08:08 -07002167}
2168
Alex Deymoe1e3afe2014-10-30 13:02:49 -07002169TEST_F(OmahaRequestActionTest, TestChangingToLessStableChannel) {
Gilad Arnoldeff87cc2013-07-22 18:32:09 -07002170 // Create a uniquely named test directory.
Sen Jiang297e5832016-03-17 14:45:51 -07002171 base::ScopedTempDir tempdir;
2172 ASSERT_TRUE(tempdir.CreateUniqueTempDir());
Gilad Arnoldeff87cc2013-07-22 18:32:09 -07002173
Marton Hunyady2abda312018-04-24 18:21:49 +02002174 request_params_.set_root(tempdir.GetPath().value());
2175 request_params_.set_app_id("{11111111-1111-1111-1111-111111111111}");
2176 request_params_.set_app_version("5.6.7.8");
2177 request_params_.set_product_components("o.bundle=1");
2178 request_params_.set_current_channel("stable-channel");
2179 EXPECT_TRUE(
2180 request_params_.SetTargetChannel("canary-channel", false, nullptr));
2181 request_params_.UpdateDownloadChannel();
2182 EXPECT_FALSE(request_params_.ShouldPowerwash());
Amin Hassani41ac04b2019-03-29 11:31:03 -07002183
2184 tuc_params_.http_response = "invalid xml>";
2185 tuc_params_.expected_code = ErrorCode::kOmahaRequestXMLParseError;
2186 tuc_params_.expected_check_result = metrics::CheckResult::kParsingError;
2187 tuc_params_.expected_check_reaction = metrics::CheckReaction::kUnset;
2188
2189 ASSERT_FALSE(TestUpdateCheck());
2190
Amin Hassani7cc8bb02019-01-14 16:29:47 -08002191 EXPECT_NE(
2192 string::npos,
2193 post_str.find("appid=\"{11111111-1111-1111-1111-111111111111}\" "
2194 "version=\"5.6.7.8\" "
2195 "track=\"canary-channel\" from_track=\"stable-channel\""));
Alex Vakulenkod2779df2014-06-16 13:19:00 -07002196 EXPECT_EQ(string::npos, post_str.find("from_version"));
Sen Jiang8cd42342018-01-31 12:06:59 -08002197 EXPECT_NE(string::npos, post_str.find("o.bundle.version=\"1\""));
Jay Srinivasanae4697c2013-03-18 17:08:08 -07002198}
2199
Alex Deymoebbe7ef2014-10-30 13:02:49 -07002200// Checks that the initial ping with a=-1 r=-1 is not send when the device
2201// was powerwashed.
2202TEST_F(OmahaRequestActionTest, PingWhenPowerwashed) {
2203 fake_prefs_.SetString(kPrefsPreviousVersion, "");
2204
2205 // Flag that the device was powerwashed in the past.
2206 fake_system_state_.fake_hardware()->SetPowerwashCount(1);
Amin Hassani41ac04b2019-03-29 11:31:03 -07002207 tuc_params_.http_response = fake_update_response_.GetNoUpdateResponse();
2208 tuc_params_.expected_check_result = metrics::CheckResult::kNoUpdateAvailable;
2209 tuc_params_.expected_check_reaction = metrics::CheckReaction::kUnset;
Alex Deymoebbe7ef2014-10-30 13:02:49 -07002210
Amin Hassani41ac04b2019-03-29 11:31:03 -07002211 ASSERT_TRUE(TestUpdateCheck());
2212
Alex Deymoebbe7ef2014-10-30 13:02:49 -07002213 // We shouldn't send a ping in this case since powerwash > 0.
Alex Deymoebbe7ef2014-10-30 13:02:49 -07002214 EXPECT_EQ(string::npos, post_str.find("<ping"));
2215}
2216
Amin Hassani1677e812017-06-21 13:36:36 -07002217// Checks that the initial ping with a=-1 r=-1 is not send when the device
2218// first_active_omaha_ping_sent is set.
2219TEST_F(OmahaRequestActionTest, PingWhenFirstActiveOmahaPingIsSent) {
2220 fake_prefs_.SetString(kPrefsPreviousVersion, "");
2221
2222 // Flag that the device was not powerwashed in the past.
2223 fake_system_state_.fake_hardware()->SetPowerwashCount(0);
2224
2225 // Flag that the device has sent first active ping in the past.
2226 fake_system_state_.fake_hardware()->SetFirstActiveOmahaPingSent();
2227
Amin Hassani41ac04b2019-03-29 11:31:03 -07002228 tuc_params_.http_response = fake_update_response_.GetNoUpdateResponse();
2229 tuc_params_.expected_check_result = metrics::CheckResult::kNoUpdateAvailable;
2230 tuc_params_.expected_check_reaction = metrics::CheckReaction::kUnset;
2231
2232 ASSERT_TRUE(TestUpdateCheck());
2233
Amin Hassani1677e812017-06-21 13:36:36 -07002234 // We shouldn't send a ping in this case since
2235 // first_active_omaha_ping_sent=true
Amin Hassani1677e812017-06-21 13:36:36 -07002236 EXPECT_EQ(string::npos, post_str.find("<ping"));
2237}
2238
Alex Deymo9fded1e2015-11-05 12:31:19 -08002239// Checks that the event 54 is sent on a reboot to a new update.
2240TEST_F(OmahaRequestActionTest, RebootAfterUpdateEvent) {
2241 // Flag that the device was updated in a previous boot.
2242 fake_prefs_.SetString(kPrefsPreviousVersion, "1.2.3.4");
2243
Amin Hassani41ac04b2019-03-29 11:31:03 -07002244 tuc_params_.http_response = fake_update_response_.GetNoUpdateResponse();
2245 tuc_params_.expected_check_result = metrics::CheckResult::kNoUpdateAvailable;
2246 tuc_params_.expected_check_reaction = metrics::CheckReaction::kUnset;
2247
2248 ASSERT_TRUE(TestUpdateCheck());
Alex Deymo9fded1e2015-11-05 12:31:19 -08002249
2250 // An event 54 is included and has the right version.
Amin Hassani7cc8bb02019-01-14 16:29:47 -08002251 EXPECT_NE(
2252 string::npos,
2253 post_str.find(base::StringPrintf("<event eventtype=\"%d\"",
2254 OmahaEvent::kTypeRebootedAfterUpdate)));
Alex Deymo9fded1e2015-11-05 12:31:19 -08002255 EXPECT_NE(string::npos,
2256 post_str.find("previousversion=\"1.2.3.4\"></event>"));
2257
2258 // The previous version flag should have been removed.
2259 EXPECT_TRUE(fake_prefs_.Exists(kPrefsPreviousVersion));
2260 string prev_version;
2261 EXPECT_TRUE(fake_prefs_.GetString(kPrefsPreviousVersion, &prev_version));
2262 EXPECT_TRUE(prev_version.empty());
2263}
2264
Amin Hassani7cc8bb02019-01-14 16:29:47 -08002265void OmahaRequestActionTest::P2PTest(bool initial_allow_p2p_for_downloading,
2266 bool initial_allow_p2p_for_sharing,
2267 bool omaha_disable_p2p_for_downloading,
2268 bool omaha_disable_p2p_for_sharing,
2269 bool payload_state_allow_p2p_attempt,
2270 bool expect_p2p_client_lookup,
2271 const string& p2p_client_result_url,
2272 bool expected_allow_p2p_for_downloading,
2273 bool expected_allow_p2p_for_sharing,
2274 const string& expected_p2p_url) {
Gilad Arnold74b5f552014-10-07 08:17:16 -07002275 bool actual_allow_p2p_for_downloading = initial_allow_p2p_for_downloading;
2276 bool actual_allow_p2p_for_sharing = initial_allow_p2p_for_sharing;
2277 string actual_p2p_url;
David Zeuthen8f191b22013-08-06 12:27:50 -07002278
2279 MockPayloadState mock_payload_state;
Alex Deymoe1e3afe2014-10-30 13:02:49 -07002280 fake_system_state_.set_payload_state(&mock_payload_state);
David Zeuthen8f191b22013-08-06 12:27:50 -07002281 EXPECT_CALL(mock_payload_state, P2PAttemptAllowed())
2282 .WillRepeatedly(Return(payload_state_allow_p2p_attempt));
Gilad Arnold74b5f552014-10-07 08:17:16 -07002283 EXPECT_CALL(mock_payload_state, GetUsingP2PForDownloading())
2284 .WillRepeatedly(ReturnPointee(&actual_allow_p2p_for_downloading));
2285 EXPECT_CALL(mock_payload_state, GetUsingP2PForSharing())
2286 .WillRepeatedly(ReturnPointee(&actual_allow_p2p_for_sharing));
2287 EXPECT_CALL(mock_payload_state, SetUsingP2PForDownloading(_))
2288 .WillRepeatedly(SaveArg<0>(&actual_allow_p2p_for_downloading));
2289 EXPECT_CALL(mock_payload_state, SetUsingP2PForSharing(_))
2290 .WillRepeatedly(SaveArg<0>(&actual_allow_p2p_for_sharing));
2291 EXPECT_CALL(mock_payload_state, SetP2PUrl(_))
2292 .WillRepeatedly(SaveArg<0>(&actual_p2p_url));
2293
David Zeuthen8f191b22013-08-06 12:27:50 -07002294 MockP2PManager mock_p2p_manager;
Alex Deymoe1e3afe2014-10-30 13:02:49 -07002295 fake_system_state_.set_p2p_manager(&mock_p2p_manager);
David Zeuthen8f191b22013-08-06 12:27:50 -07002296 mock_p2p_manager.fake().SetLookupUrlForFileResult(p2p_client_result_url);
2297
David Zeuthen4cc5ed22014-01-15 12:35:03 -08002298 TimeDelta timeout = TimeDelta::FromSeconds(kMaxP2PNetworkWaitTimeSeconds);
2299 EXPECT_CALL(mock_p2p_manager, LookupUrlForFile(_, _, timeout, _))
David Zeuthen8f191b22013-08-06 12:27:50 -07002300 .Times(expect_p2p_client_lookup ? 1 : 0);
2301
Alex Deymo8e18f932015-03-27 16:16:59 -07002302 fake_update_response_.disable_p2p_for_downloading =
2303 omaha_disable_p2p_for_downloading;
2304 fake_update_response_.disable_p2p_for_sharing = omaha_disable_p2p_for_sharing;
Amin Hassani41ac04b2019-03-29 11:31:03 -07002305
2306 tuc_params_.http_response = fake_update_response_.GetUpdateResponse();
2307 tuc_params_.expected_check_result = metrics::CheckResult::kUpdateAvailable;
2308
2309 ASSERT_TRUE(TestUpdateCheck());
David Zeuthen8f191b22013-08-06 12:27:50 -07002310 EXPECT_TRUE(response.update_exists);
2311
Gilad Arnold74b5f552014-10-07 08:17:16 -07002312 EXPECT_EQ(omaha_disable_p2p_for_downloading,
2313 response.disable_p2p_for_downloading);
Amin Hassani7cc8bb02019-01-14 16:29:47 -08002314 EXPECT_EQ(omaha_disable_p2p_for_sharing, response.disable_p2p_for_sharing);
David Zeuthen8f191b22013-08-06 12:27:50 -07002315
Gilad Arnold74b5f552014-10-07 08:17:16 -07002316 EXPECT_EQ(expected_allow_p2p_for_downloading,
2317 actual_allow_p2p_for_downloading);
2318 EXPECT_EQ(expected_allow_p2p_for_sharing, actual_allow_p2p_for_sharing);
2319 EXPECT_EQ(expected_p2p_url, actual_p2p_url);
David Zeuthen8f191b22013-08-06 12:27:50 -07002320}
2321
Alex Deymoe1e3afe2014-10-30 13:02:49 -07002322TEST_F(OmahaRequestActionTest, P2PWithPeer) {
Alex Vakulenkod2779df2014-06-16 13:19:00 -07002323 P2PTest(true, // initial_allow_p2p_for_downloading
2324 true, // initial_allow_p2p_for_sharing
2325 false, // omaha_disable_p2p_for_downloading
2326 false, // omaha_disable_p2p_for_sharing
2327 true, // payload_state_allow_p2p_attempt
2328 true, // expect_p2p_client_lookup
2329 "http://1.3.5.7/p2p", // p2p_client_result_url
2330 true, // expected_allow_p2p_for_downloading
2331 true, // expected_allow_p2p_for_sharing
2332 "http://1.3.5.7/p2p"); // expected_p2p_url
David Zeuthen8f191b22013-08-06 12:27:50 -07002333}
2334
Alex Deymoe1e3afe2014-10-30 13:02:49 -07002335TEST_F(OmahaRequestActionTest, P2PWithoutPeer) {
Amin Hassani7cc8bb02019-01-14 16:29:47 -08002336 P2PTest(true, // initial_allow_p2p_for_downloading
2337 true, // initial_allow_p2p_for_sharing
2338 false, // omaha_disable_p2p_for_downloading
2339 false, // omaha_disable_p2p_for_sharing
2340 true, // payload_state_allow_p2p_attempt
2341 true, // expect_p2p_client_lookup
2342 "", // p2p_client_result_url
2343 false, // expected_allow_p2p_for_downloading
2344 true, // expected_allow_p2p_for_sharing
2345 ""); // expected_p2p_url
David Zeuthen8f191b22013-08-06 12:27:50 -07002346}
2347
Alex Deymoe1e3afe2014-10-30 13:02:49 -07002348TEST_F(OmahaRequestActionTest, P2PDownloadNotAllowed) {
Amin Hassani7cc8bb02019-01-14 16:29:47 -08002349 P2PTest(false, // initial_allow_p2p_for_downloading
2350 true, // initial_allow_p2p_for_sharing
2351 false, // omaha_disable_p2p_for_downloading
2352 false, // omaha_disable_p2p_for_sharing
2353 true, // payload_state_allow_p2p_attempt
2354 false, // expect_p2p_client_lookup
2355 "unset", // p2p_client_result_url
2356 false, // expected_allow_p2p_for_downloading
2357 true, // expected_allow_p2p_for_sharing
2358 ""); // expected_p2p_url
David Zeuthen8f191b22013-08-06 12:27:50 -07002359}
2360
Alex Deymoe1e3afe2014-10-30 13:02:49 -07002361TEST_F(OmahaRequestActionTest, P2PWithPeerDownloadDisabledByOmaha) {
Amin Hassani7cc8bb02019-01-14 16:29:47 -08002362 P2PTest(true, // initial_allow_p2p_for_downloading
2363 true, // initial_allow_p2p_for_sharing
2364 true, // omaha_disable_p2p_for_downloading
2365 false, // omaha_disable_p2p_for_sharing
2366 true, // payload_state_allow_p2p_attempt
2367 false, // expect_p2p_client_lookup
2368 "unset", // p2p_client_result_url
2369 false, // expected_allow_p2p_for_downloading
2370 true, // expected_allow_p2p_for_sharing
2371 ""); // expected_p2p_url
David Zeuthen8f191b22013-08-06 12:27:50 -07002372}
2373
Alex Deymoe1e3afe2014-10-30 13:02:49 -07002374TEST_F(OmahaRequestActionTest, P2PWithPeerSharingDisabledByOmaha) {
Alex Vakulenkod2779df2014-06-16 13:19:00 -07002375 P2PTest(true, // initial_allow_p2p_for_downloading
2376 true, // initial_allow_p2p_for_sharing
2377 false, // omaha_disable_p2p_for_downloading
2378 true, // omaha_disable_p2p_for_sharing
2379 true, // payload_state_allow_p2p_attempt
2380 true, // expect_p2p_client_lookup
2381 "http://1.3.5.7/p2p", // p2p_client_result_url
2382 true, // expected_allow_p2p_for_downloading
2383 false, // expected_allow_p2p_for_sharing
2384 "http://1.3.5.7/p2p"); // expected_p2p_url
David Zeuthen8f191b22013-08-06 12:27:50 -07002385}
2386
Alex Deymoe1e3afe2014-10-30 13:02:49 -07002387TEST_F(OmahaRequestActionTest, P2PWithPeerBothDisabledByOmaha) {
Amin Hassani7cc8bb02019-01-14 16:29:47 -08002388 P2PTest(true, // initial_allow_p2p_for_downloading
2389 true, // initial_allow_p2p_for_sharing
2390 true, // omaha_disable_p2p_for_downloading
2391 true, // omaha_disable_p2p_for_sharing
2392 true, // payload_state_allow_p2p_attempt
2393 false, // expect_p2p_client_lookup
2394 "unset", // p2p_client_result_url
2395 false, // expected_allow_p2p_for_downloading
2396 false, // expected_allow_p2p_for_sharing
2397 ""); // expected_p2p_url
David Zeuthen8f191b22013-08-06 12:27:50 -07002398}
2399
Amin Hassani7cc8bb02019-01-14 16:29:47 -08002400bool OmahaRequestActionTest::InstallDateParseHelper(const string& elapsed_days,
2401 OmahaResponse* response) {
Alex Deymo8e18f932015-03-27 16:16:59 -07002402 fake_update_response_.elapsed_days = elapsed_days;
Amin Hassani41ac04b2019-03-29 11:31:03 -07002403 tuc_params_.http_response = fake_update_response_.GetUpdateResponse();
2404
2405 return TestUpdateCheck();
David Zeuthen639aa362014-02-03 16:23:44 -08002406}
2407
Alex Deymoe1e3afe2014-10-30 13:02:49 -07002408TEST_F(OmahaRequestActionTest, ParseInstallDateFromResponse) {
Kevin Cernekee2494e282016-03-29 18:03:53 -07002409 // Simulate a successful update check that happens during OOBE. The
2410 // deadline in the response is needed to force the update attempt to
2411 // occur; responses without a deadline seen during OOBE will normally
2412 // return ErrorCode::kNonCriticalUpdateInOOBE.
2413 fake_system_state_.fake_hardware()->UnsetIsOOBEComplete();
2414 fake_update_response_.deadline = "20101020";
2415
David Zeuthen639aa362014-02-03 16:23:44 -08002416 // Check that we parse elapsed_days in the Omaha Response correctly.
2417 // and that the kPrefsInstallDateDays value is written to.
Alex Deymoe1e3afe2014-10-30 13:02:49 -07002418 EXPECT_FALSE(fake_prefs_.Exists(kPrefsInstallDateDays));
2419 EXPECT_TRUE(InstallDateParseHelper("42", &response));
David Zeuthen639aa362014-02-03 16:23:44 -08002420 EXPECT_TRUE(response.update_exists);
2421 EXPECT_EQ(42, response.install_date_days);
Alex Deymoe1e3afe2014-10-30 13:02:49 -07002422 EXPECT_TRUE(fake_prefs_.Exists(kPrefsInstallDateDays));
David Zeuthen639aa362014-02-03 16:23:44 -08002423 int64_t prefs_days;
Alex Deymoe1e3afe2014-10-30 13:02:49 -07002424 EXPECT_TRUE(fake_prefs_.GetInt64(kPrefsInstallDateDays, &prefs_days));
David Zeuthen639aa362014-02-03 16:23:44 -08002425 EXPECT_EQ(prefs_days, 42);
2426
2427 // If there already is a value set, we shouldn't do anything.
Alex Deymoe1e3afe2014-10-30 13:02:49 -07002428 EXPECT_TRUE(InstallDateParseHelper("7", &response));
David Zeuthen639aa362014-02-03 16:23:44 -08002429 EXPECT_TRUE(response.update_exists);
2430 EXPECT_EQ(7, response.install_date_days);
Alex Deymoe1e3afe2014-10-30 13:02:49 -07002431 EXPECT_TRUE(fake_prefs_.GetInt64(kPrefsInstallDateDays, &prefs_days));
David Zeuthen639aa362014-02-03 16:23:44 -08002432 EXPECT_EQ(prefs_days, 42);
2433
2434 // Note that elapsed_days is not necessarily divisible by 7 so check
2435 // that we round down correctly when populating kPrefsInstallDateDays.
Alex Deymoe1e3afe2014-10-30 13:02:49 -07002436 EXPECT_TRUE(fake_prefs_.Delete(kPrefsInstallDateDays));
2437 EXPECT_TRUE(InstallDateParseHelper("23", &response));
David Zeuthen639aa362014-02-03 16:23:44 -08002438 EXPECT_TRUE(response.update_exists);
2439 EXPECT_EQ(23, response.install_date_days);
Alex Deymoe1e3afe2014-10-30 13:02:49 -07002440 EXPECT_TRUE(fake_prefs_.GetInt64(kPrefsInstallDateDays, &prefs_days));
David Zeuthen639aa362014-02-03 16:23:44 -08002441 EXPECT_EQ(prefs_days, 21);
2442
2443 // Check that we correctly handle elapsed_days not being included in
2444 // the Omaha Response.
Alex Deymoe1e3afe2014-10-30 13:02:49 -07002445 EXPECT_TRUE(InstallDateParseHelper("", &response));
David Zeuthen639aa362014-02-03 16:23:44 -08002446 EXPECT_TRUE(response.update_exists);
2447 EXPECT_EQ(-1, response.install_date_days);
David Zeuthen639aa362014-02-03 16:23:44 -08002448}
2449
Alex Deymoe1e3afe2014-10-30 13:02:49 -07002450// If there is no prefs and OOBE is not complete, we should not
2451// report anything to Omaha.
2452TEST_F(OmahaRequestActionTest, GetInstallDateWhenNoPrefsNorOOBE) {
Kevin Cernekee2494e282016-03-29 18:03:53 -07002453 fake_system_state_.fake_hardware()->UnsetIsOOBEComplete();
Alex Deymoe1e3afe2014-10-30 13:02:49 -07002454 EXPECT_EQ(OmahaRequestAction::GetInstallDate(&fake_system_state_), -1);
2455 EXPECT_FALSE(fake_prefs_.Exists(kPrefsInstallDateDays));
2456}
David Zeuthen639aa362014-02-03 16:23:44 -08002457
Alex Deymoe1e3afe2014-10-30 13:02:49 -07002458// If OOBE is complete and happened on a valid date (e.g. after Jan
2459// 1 2007 0:00 PST), that date should be used and written to
2460// prefs. However, first try with an invalid date and check we do
2461// nothing.
2462TEST_F(OmahaRequestActionTest, GetInstallDateWhenOOBECompletedWithInvalidDate) {
2463 Time oobe_date = Time::FromTimeT(42); // Dec 31, 1969 16:00:42 PST.
2464 fake_system_state_.fake_hardware()->SetIsOOBEComplete(oobe_date);
2465 EXPECT_EQ(OmahaRequestAction::GetInstallDate(&fake_system_state_), -1);
2466 EXPECT_FALSE(fake_prefs_.Exists(kPrefsInstallDateDays));
2467}
David Zeuthen639aa362014-02-03 16:23:44 -08002468
Alex Deymoe1e3afe2014-10-30 13:02:49 -07002469// Then check with a valid date. The date Jan 20, 2007 0:00 PST
2470// should yield an InstallDate of 14.
2471TEST_F(OmahaRequestActionTest, GetInstallDateWhenOOBECompletedWithValidDate) {
2472 Time oobe_date = Time::FromTimeT(1169280000); // Jan 20, 2007 0:00 PST.
2473 fake_system_state_.fake_hardware()->SetIsOOBEComplete(oobe_date);
2474 EXPECT_EQ(OmahaRequestAction::GetInstallDate(&fake_system_state_), 14);
2475 EXPECT_TRUE(fake_prefs_.Exists(kPrefsInstallDateDays));
David Zeuthen639aa362014-02-03 16:23:44 -08002476
Alex Deymoe1e3afe2014-10-30 13:02:49 -07002477 int64_t prefs_days;
2478 EXPECT_TRUE(fake_prefs_.GetInt64(kPrefsInstallDateDays, &prefs_days));
2479 EXPECT_EQ(prefs_days, 14);
2480}
David Zeuthen639aa362014-02-03 16:23:44 -08002481
Alex Deymoe1e3afe2014-10-30 13:02:49 -07002482// Now that we have a valid date in prefs, check that we keep using
2483// that even if OOBE date reports something else. The date Jan 30,
2484// 2007 0:00 PST should yield an InstallDate of 28... but since
2485// there's a prefs file, we should still get 14.
2486TEST_F(OmahaRequestActionTest, GetInstallDateWhenOOBECompletedDateChanges) {
2487 // Set a valid date in the prefs first.
2488 EXPECT_TRUE(fake_prefs_.SetInt64(kPrefsInstallDateDays, 14));
David Zeuthen639aa362014-02-03 16:23:44 -08002489
Alex Deymoe1e3afe2014-10-30 13:02:49 -07002490 Time oobe_date = Time::FromTimeT(1170144000); // Jan 30, 2007 0:00 PST.
2491 fake_system_state_.fake_hardware()->SetIsOOBEComplete(oobe_date);
2492 EXPECT_EQ(OmahaRequestAction::GetInstallDate(&fake_system_state_), 14);
David Zeuthen639aa362014-02-03 16:23:44 -08002493
Alex Deymoe1e3afe2014-10-30 13:02:49 -07002494 int64_t prefs_days;
2495 EXPECT_TRUE(fake_prefs_.GetInt64(kPrefsInstallDateDays, &prefs_days));
2496 EXPECT_EQ(prefs_days, 14);
David Zeuthen639aa362014-02-03 16:23:44 -08002497
Alex Deymoe1e3afe2014-10-30 13:02:49 -07002498 // If we delete the prefs file, we should get 28 days.
2499 EXPECT_TRUE(fake_prefs_.Delete(kPrefsInstallDateDays));
2500 EXPECT_EQ(OmahaRequestAction::GetInstallDate(&fake_system_state_), 28);
2501 EXPECT_TRUE(fake_prefs_.GetInt64(kPrefsInstallDateDays, &prefs_days));
2502 EXPECT_EQ(prefs_days, 28);
David Zeuthen639aa362014-02-03 16:23:44 -08002503}
2504
Zentaro Kavanagh1f899d52018-02-27 15:02:47 -08002505// Verifies that a device with no device policy, and is not a consumer
2506// device sets the max kernel key version to the current version.
2507// ie. the same behavior as if rollback is enabled.
2508TEST_F(OmahaRequestActionTest, NoPolicyEnterpriseDevicesSetMaxRollback) {
2509 FakeHardware* fake_hw = fake_system_state_.fake_hardware();
2510
2511 // Setup and verify some initial default values for the kernel TPM
2512 // values that control verified boot and rollback.
2513 const int min_kernel_version = 4;
2514 fake_hw->SetMinKernelKeyVersion(min_kernel_version);
2515 fake_hw->SetMaxKernelKeyRollforward(kRollforwardInfinity);
2516 EXPECT_EQ(min_kernel_version, fake_hw->GetMinKernelKeyVersion());
2517 EXPECT_EQ(kRollforwardInfinity, fake_hw->GetMaxKernelKeyRollforward());
2518
Marton Hunyadyffbfdfb2018-05-30 13:03:29 +02002519 EXPECT_CALL(
2520 *fake_system_state_.mock_metrics_reporter(),
2521 ReportKeyVersionMetrics(min_kernel_version, min_kernel_version, true))
2522 .Times(1);
2523
Amin Hassani41ac04b2019-03-29 11:31:03 -07002524 fake_update_response_.deadline = "20101020";
2525 tuc_params_.http_response = fake_update_response_.GetUpdateResponse();
2526 tuc_params_.is_consumer_device = false;
2527 tuc_params_.rollback_allowed_milestones = 3;
2528
2529 EXPECT_TRUE(TestUpdateCheck());
2530 EXPECT_TRUE(response.update_exists);
Zentaro Kavanagh1f899d52018-02-27 15:02:47 -08002531
Zentaro Kavanagh5d956152018-05-15 09:40:33 -07002532 // Verify kernel_max_rollforward was set to the current minimum
Zentaro Kavanagh1f899d52018-02-27 15:02:47 -08002533 // kernel key version. This has the effect of freezing roll
2534 // forwards indefinitely. This will hold the rollback window
2535 // open until a future change will be able to move this forward
2536 // relative the configured window.
2537 EXPECT_EQ(min_kernel_version, fake_hw->GetMinKernelKeyVersion());
2538 EXPECT_EQ(min_kernel_version, fake_hw->GetMaxKernelKeyRollforward());
2539}
2540
2541// Verifies that a conmsumer device with no device policy sets the
2542// max kernel key version to the current version. ie. the same
2543// behavior as if rollback is enabled.
2544TEST_F(OmahaRequestActionTest, NoPolicyConsumerDevicesSetMaxRollback) {
2545 FakeHardware* fake_hw = fake_system_state_.fake_hardware();
2546
2547 // Setup and verify some initial default values for the kernel TPM
2548 // values that control verified boot and rollback.
2549 const int min_kernel_version = 3;
2550 fake_hw->SetMinKernelKeyVersion(min_kernel_version);
2551 fake_hw->SetMaxKernelKeyRollforward(kRollforwardInfinity);
2552 EXPECT_EQ(min_kernel_version, fake_hw->GetMinKernelKeyVersion());
2553 EXPECT_EQ(kRollforwardInfinity, fake_hw->GetMaxKernelKeyRollforward());
2554
Marton Hunyadyffbfdfb2018-05-30 13:03:29 +02002555 EXPECT_CALL(
2556 *fake_system_state_.mock_metrics_reporter(),
2557 ReportKeyVersionMetrics(min_kernel_version, kRollforwardInfinity, true))
2558 .Times(1);
2559
Amin Hassani41ac04b2019-03-29 11:31:03 -07002560 fake_update_response_.deadline = "20101020";
2561 tuc_params_.http_response = fake_update_response_.GetUpdateResponse();
2562 tuc_params_.is_consumer_device = true;
2563 tuc_params_.rollback_allowed_milestones = 3;
2564
2565 EXPECT_TRUE(TestUpdateCheck());
2566 EXPECT_TRUE(response.update_exists);
Zentaro Kavanagh1f899d52018-02-27 15:02:47 -08002567
Zentaro Kavanagh5d956152018-05-15 09:40:33 -07002568 // Verify that with rollback disabled that kernel_max_rollforward
Zentaro Kavanagh1f899d52018-02-27 15:02:47 -08002569 // was set to logical infinity. This is the expected behavior for
2570 // consumer devices and matches the existing behavior prior to the
2571 // rollback features.
2572 EXPECT_EQ(min_kernel_version, fake_hw->GetMinKernelKeyVersion());
2573 EXPECT_EQ(kRollforwardInfinity, fake_hw->GetMaxKernelKeyRollforward());
2574}
2575
Zentaro Kavanagh5d956152018-05-15 09:40:33 -07002576// Verifies that a device with rollback enabled sets kernel_max_rollforward
Zentaro Kavanagh1f899d52018-02-27 15:02:47 -08002577// in the TPM to prevent roll forward.
2578TEST_F(OmahaRequestActionTest, RollbackEnabledDevicesSetMaxRollback) {
2579 FakeHardware* fake_hw = fake_system_state_.fake_hardware();
2580
2581 // Setup and verify some initial default values for the kernel TPM
2582 // values that control verified boot and rollback.
2583 const int allowed_milestones = 4;
2584 const int min_kernel_version = 3;
2585 fake_hw->SetMinKernelKeyVersion(min_kernel_version);
2586 fake_hw->SetMaxKernelKeyRollforward(kRollforwardInfinity);
2587 EXPECT_EQ(min_kernel_version, fake_hw->GetMinKernelKeyVersion());
2588 EXPECT_EQ(kRollforwardInfinity, fake_hw->GetMaxKernelKeyRollforward());
2589
Marton Hunyadyffbfdfb2018-05-30 13:03:29 +02002590 EXPECT_CALL(
2591 *fake_system_state_.mock_metrics_reporter(),
2592 ReportKeyVersionMetrics(min_kernel_version, min_kernel_version, true))
2593 .Times(1);
2594
Amin Hassani41ac04b2019-03-29 11:31:03 -07002595 fake_update_response_.deadline = "20101020";
2596 tuc_params_.http_response = fake_update_response_.GetUpdateResponse();
2597 tuc_params_.is_consumer_device = false;
2598 tuc_params_.rollback_allowed_milestones = allowed_milestones;
2599 tuc_params_.is_policy_loaded = true;
2600
2601 EXPECT_TRUE(TestUpdateCheck());
2602 EXPECT_TRUE(response.update_exists);
Zentaro Kavanagh1f899d52018-02-27 15:02:47 -08002603
Zentaro Kavanagh5d956152018-05-15 09:40:33 -07002604 // Verify that with rollback enabled that kernel_max_rollforward
Zentaro Kavanagh1f899d52018-02-27 15:02:47 -08002605 // was set to the current minimum kernel key version. This has
2606 // the effect of freezing roll forwards indefinitely. This will
2607 // hold the rollback window open until a future change will
2608 // be able to move this forward relative the configured window.
2609 EXPECT_EQ(min_kernel_version, fake_hw->GetMinKernelKeyVersion());
2610 EXPECT_EQ(min_kernel_version, fake_hw->GetMaxKernelKeyRollforward());
2611}
2612
Zentaro Kavanagh5d956152018-05-15 09:40:33 -07002613// Verifies that a device with rollback disabled sets kernel_max_rollforward
Zentaro Kavanagh1f899d52018-02-27 15:02:47 -08002614// in the TPM to logical infinity, to allow roll forward.
2615TEST_F(OmahaRequestActionTest, RollbackDisabledDevicesSetMaxRollback) {
2616 FakeHardware* fake_hw = fake_system_state_.fake_hardware();
2617
2618 // Setup and verify some initial default values for the kernel TPM
2619 // values that control verified boot and rollback.
2620 const int allowed_milestones = 0;
2621 const int min_kernel_version = 3;
2622 fake_hw->SetMinKernelKeyVersion(min_kernel_version);
2623 fake_hw->SetMaxKernelKeyRollforward(kRollforwardInfinity);
2624 EXPECT_EQ(min_kernel_version, fake_hw->GetMinKernelKeyVersion());
2625 EXPECT_EQ(kRollforwardInfinity, fake_hw->GetMaxKernelKeyRollforward());
2626
Marton Hunyadyffbfdfb2018-05-30 13:03:29 +02002627 EXPECT_CALL(
2628 *fake_system_state_.mock_metrics_reporter(),
2629 ReportKeyVersionMetrics(min_kernel_version, kRollforwardInfinity, true))
2630 .Times(1);
2631
Amin Hassani41ac04b2019-03-29 11:31:03 -07002632 fake_update_response_.deadline = "20101020";
2633 tuc_params_.http_response = fake_update_response_.GetUpdateResponse();
2634 tuc_params_.is_consumer_device = false;
2635 tuc_params_.rollback_allowed_milestones = allowed_milestones;
2636 tuc_params_.is_policy_loaded = true;
2637
2638 EXPECT_TRUE(TestUpdateCheck());
2639 EXPECT_TRUE(response.update_exists);
Zentaro Kavanagh1f899d52018-02-27 15:02:47 -08002640
Zentaro Kavanagh5d956152018-05-15 09:40:33 -07002641 // Verify that with rollback disabled that kernel_max_rollforward
Zentaro Kavanagh1f899d52018-02-27 15:02:47 -08002642 // was set to logical infinity.
2643 EXPECT_EQ(min_kernel_version, fake_hw->GetMinKernelKeyVersion());
2644 EXPECT_EQ(kRollforwardInfinity, fake_hw->GetMaxKernelKeyRollforward());
2645}
2646
Zentaro Kavanagh0ff621c2018-07-13 13:06:56 -07002647TEST_F(OmahaRequestActionTest, RollbackResponseParsedNoEntries) {
Zentaro Kavanagh0ff621c2018-07-13 13:06:56 -07002648 fake_update_response_.rollback = true;
Amin Hassani41ac04b2019-03-29 11:31:03 -07002649 fake_update_response_.deadline = "20101020";
2650 tuc_params_.http_response = fake_update_response_.GetUpdateResponse();
2651 tuc_params_.is_consumer_device = false;
2652 tuc_params_.rollback_allowed_milestones = 4;
2653 tuc_params_.is_policy_loaded = true;
2654
2655 EXPECT_TRUE(TestUpdateCheck());
2656 EXPECT_TRUE(response.update_exists);
Zentaro Kavanagh0ff621c2018-07-13 13:06:56 -07002657 EXPECT_TRUE(response.is_rollback);
2658}
2659
2660TEST_F(OmahaRequestActionTest, RollbackResponseValidVersionsParsed) {
Zentaro Kavanagh0ff621c2018-07-13 13:06:56 -07002661 fake_update_response_.rollback_firmware_version = "1.2";
2662 fake_update_response_.rollback_kernel_version = "3.4";
2663 fake_update_response_.rollback = true;
Amin Hassani41ac04b2019-03-29 11:31:03 -07002664 fake_update_response_.deadline = "20101020";
2665 tuc_params_.http_response = fake_update_response_.GetUpdateResponse();
2666 tuc_params_.is_consumer_device = false;
2667 tuc_params_.rollback_allowed_milestones = 4;
2668 tuc_params_.is_policy_loaded = true;
2669
2670 EXPECT_TRUE(TestUpdateCheck());
2671 EXPECT_TRUE(response.update_exists);
Zentaro Kavanagh0ff621c2018-07-13 13:06:56 -07002672 EXPECT_TRUE(response.is_rollback);
2673 EXPECT_EQ(1, response.rollback_key_version.firmware_key);
2674 EXPECT_EQ(2, response.rollback_key_version.firmware);
2675 EXPECT_EQ(3, response.rollback_key_version.kernel_key);
2676 EXPECT_EQ(4, response.rollback_key_version.kernel);
2677}
2678
May Lippert60aa3ca2018-08-15 16:55:29 -07002679TEST_F(OmahaRequestActionTest,
2680 TestUpdateFirstSeenAtPrefPersistedIfUpdateExists) {
2681 FakeClock fake_clock;
2682 Time now = Time::Now();
2683 fake_clock.SetWallclockTime(now);
2684 fake_system_state_.set_clock(&fake_clock);
Amin Hassani41ac04b2019-03-29 11:31:03 -07002685 tuc_params_.http_response = fake_update_response_.GetUpdateResponse();
May Lippert60aa3ca2018-08-15 16:55:29 -07002686
Amin Hassani41ac04b2019-03-29 11:31:03 -07002687 ASSERT_TRUE(TestUpdateCheck());
2688
May Lippert60aa3ca2018-08-15 16:55:29 -07002689 EXPECT_TRUE(response.update_exists);
2690 EXPECT_TRUE(fake_prefs_.Exists(kPrefsUpdateFirstSeenAt));
2691
2692 int64_t stored_first_seen_at_time;
2693 EXPECT_TRUE(fake_prefs_.GetInt64(kPrefsUpdateFirstSeenAt,
2694 &stored_first_seen_at_time));
2695 EXPECT_EQ(now.ToInternalValue(), stored_first_seen_at_time);
2696}
2697
2698TEST_F(OmahaRequestActionTest,
2699 TestUpdateFirstSeenAtPrefNotPersistedIfUpdateFails) {
2700 FakeClock fake_clock;
2701 Time now = Time::Now();
2702 fake_clock.SetWallclockTime(now);
2703 fake_system_state_.set_clock(&fake_clock);
2704
Amin Hassani41ac04b2019-03-29 11:31:03 -07002705 tuc_params_.http_response = fake_update_response_.GetNoUpdateResponse();
2706 tuc_params_.expected_check_result = metrics::CheckResult::kNoUpdateAvailable;
2707 tuc_params_.expected_check_reaction = metrics::CheckReaction::kUnset;
2708
2709 ASSERT_TRUE(TestUpdateCheck());
2710
May Lippert60aa3ca2018-08-15 16:55:29 -07002711 EXPECT_FALSE(response.update_exists);
2712 EXPECT_FALSE(fake_prefs_.Exists(kPrefsUpdateFirstSeenAt));
2713}
2714
Xiaochu Liu88d90382018-08-29 16:09:11 -07002715TEST_F(OmahaRequestActionTest, InstallTest) {
Xiaochu Liu6310be62018-10-11 15:09:03 -07002716 request_params_.set_is_install(true);
Andrewe045aef2020-01-08 16:29:22 -08002717 request_params_.set_dlc_apps_params(
2718 {{request_params_.GetDlcAppId("dlc_no_0"), {.name = "dlc_no_0"}},
2719 {request_params_.GetDlcAppId("dlc_no_1"), {.name = "dlc_no_1"}}});
Amin Hassani41ac04b2019-03-29 11:31:03 -07002720 tuc_params_.http_response = fake_update_response_.GetUpdateResponse();
2721
2722 ASSERT_TRUE(TestUpdateCheck());
2723
Andrewe045aef2020-01-08 16:29:22 -08002724 for (const auto& it : request_params_.dlc_apps_params()) {
2725 EXPECT_NE(string::npos, post_str.find("appid=\"" + it.first + "\""));
Xiaochu Liu88d90382018-08-29 16:09:11 -07002726 }
Xiaochu Liu6310be62018-10-11 15:09:03 -07002727 EXPECT_NE(string::npos,
2728 post_str.find("appid=\"" + fake_update_response_.app_id + "\""));
2729
2730 // Count number of updatecheck tag in response.
2731 int updatecheck_count = 0;
2732 size_t pos = 0;
2733 while ((pos = post_str.find("<updatecheck", pos)) != string::npos) {
2734 updatecheck_count++;
2735 pos++;
2736 }
Andrewe045aef2020-01-08 16:29:22 -08002737 EXPECT_EQ(request_params_.dlc_apps_params().size(), updatecheck_count);
Jae Hoon Kim5e9cd712020-02-12 15:28:28 -08002738 EXPECT_TRUE(response.update_exists);
Xiaochu Liu6310be62018-10-11 15:09:03 -07002739}
2740
2741TEST_F(OmahaRequestActionTest, InstallMissingPlatformVersionTest) {
2742 fake_update_response_.multi_app_skip_updatecheck = true;
2743 fake_update_response_.multi_app_no_update = false;
2744 request_params_.set_is_install(true);
Andrewe045aef2020-01-08 16:29:22 -08002745 request_params_.set_dlc_apps_params(
2746 {{request_params_.GetDlcAppId("dlc_no_0"), {.name = "dlc_no_0"}},
2747 {request_params_.GetDlcAppId("dlc_no_1"), {.name = "dlc_no_1"}}});
Xiaochu Liu6310be62018-10-11 15:09:03 -07002748 request_params_.set_app_id(fake_update_response_.app_id_skip_updatecheck);
Amin Hassani41ac04b2019-03-29 11:31:03 -07002749 tuc_params_.http_response = fake_update_response_.GetUpdateResponse();
2750
2751 ASSERT_TRUE(TestUpdateCheck());
2752
Xiaochu Liu6310be62018-10-11 15:09:03 -07002753 EXPECT_TRUE(response.update_exists);
2754 EXPECT_EQ(fake_update_response_.current_version, response.version);
Xiaochu Liu88d90382018-08-29 16:09:11 -07002755}
2756
Jae Hoon Kim5e9cd712020-02-12 15:28:28 -08002757TEST_F(OmahaRequestActionTest, UpdateWithDlcTest) {
2758 request_params_.set_dlc_apps_params(
2759 {{request_params_.GetDlcAppId(kDlcId1), {.name = kDlcId1}}});
2760 fake_update_response_.dlc_app_update = true;
2761 tuc_params_.http_response = fake_update_response_.GetUpdateResponse();
2762 ASSERT_TRUE(TestUpdateCheck());
2763
2764 EXPECT_TRUE(response.update_exists);
2765}
2766
2767TEST_F(OmahaRequestActionTest, UpdateWithDeprecatedDlcTest) {
2768 request_params_.set_dlc_apps_params(
2769 {{request_params_.GetDlcAppId(kDlcId2), {.name = kDlcId2}}});
2770 fake_update_response_.dlc_app_no_update = true;
2771 tuc_params_.http_response = fake_update_response_.GetUpdateResponse();
2772 ASSERT_TRUE(TestUpdateCheck());
2773
2774 EXPECT_TRUE(response.update_exists);
2775}
2776
2777TEST_F(OmahaRequestActionTest, UpdateWithDlcAndDeprecatedDlcTest) {
2778 request_params_.set_dlc_apps_params(
2779 {{request_params_.GetDlcAppId(kDlcId1), {.name = kDlcId1}},
2780 {request_params_.GetDlcAppId(kDlcId2), {.name = kDlcId2}}});
2781 fake_update_response_.dlc_app_update = true;
2782 fake_update_response_.dlc_app_no_update = true;
2783 tuc_params_.http_response = fake_update_response_.GetUpdateResponse();
2784 ASSERT_TRUE(TestUpdateCheck());
2785
2786 EXPECT_TRUE(response.update_exists);
2787}
2788
Zentaro Kavanagh0ef9a2f2018-07-02 12:05:07 -07002789TEST_F(OmahaRequestActionTest, PastRollbackVersionsNoEntries) {
Zentaro Kavanagh0ef9a2f2018-07-02 12:05:07 -07002790 fake_update_response_.rollback = true;
2791 fake_update_response_.rollback_allowed_milestones = 4;
2792 request_params_.set_rollback_allowed_milestones(4);
Amin Hassani41ac04b2019-03-29 11:31:03 -07002793 fake_update_response_.deadline = "20101020";
2794 tuc_params_.http_response = fake_update_response_.GetUpdateResponse();
2795 tuc_params_.is_consumer_device = false;
2796 tuc_params_.rollback_allowed_milestones = 4;
2797 tuc_params_.is_policy_loaded = true;
2798
2799 EXPECT_TRUE(TestUpdateCheck());
2800 EXPECT_TRUE(response.update_exists);
Zentaro Kavanagh0ef9a2f2018-07-02 12:05:07 -07002801 EXPECT_TRUE(response.is_rollback);
2802 EXPECT_EQ(std::numeric_limits<uint16_t>::max(),
2803 response.past_rollback_key_version.firmware_key);
2804 EXPECT_EQ(std::numeric_limits<uint16_t>::max(),
2805 response.past_rollback_key_version.firmware);
2806 EXPECT_EQ(std::numeric_limits<uint16_t>::max(),
2807 response.past_rollback_key_version.kernel_key);
2808 EXPECT_EQ(std::numeric_limits<uint16_t>::max(),
2809 response.past_rollback_key_version.kernel);
2810}
2811
2812TEST_F(OmahaRequestActionTest, PastRollbackVersionsValidEntries) {
Bailey Berrof3ce47f2019-02-25 18:22:17 -08002813 request_params_.set_rollback_allowed_milestones(4);
Zentaro Kavanagh0ef9a2f2018-07-02 12:05:07 -07002814 fake_update_response_.rollback = true;
2815 fake_update_response_.rollback_allowed_milestones = 4;
2816 fake_update_response_.rollback_firmware_version = "4.3";
2817 fake_update_response_.rollback_kernel_version = "2.1";
2818 fake_update_response_.past_rollback_key_version =
2819 std::make_pair("16.15", "14.13");
Amin Hassani41ac04b2019-03-29 11:31:03 -07002820 fake_update_response_.deadline = "20101020";
2821 tuc_params_.http_response = fake_update_response_.GetUpdateResponse();
2822 tuc_params_.is_consumer_device = false;
2823 tuc_params_.rollback_allowed_milestones = 4;
2824 tuc_params_.is_policy_loaded = true;
2825
2826 EXPECT_TRUE(TestUpdateCheck());
2827 EXPECT_TRUE(response.update_exists);
Zentaro Kavanagh0ef9a2f2018-07-02 12:05:07 -07002828 EXPECT_TRUE(response.is_rollback);
2829 EXPECT_EQ(16, response.past_rollback_key_version.firmware_key);
2830 EXPECT_EQ(15, response.past_rollback_key_version.firmware);
2831 EXPECT_EQ(14, response.past_rollback_key_version.kernel_key);
2832 EXPECT_EQ(13, response.past_rollback_key_version.kernel);
2833}
2834
2835TEST_F(OmahaRequestActionTest, MismatchNumberOfVersions) {
Zentaro Kavanagh0ef9a2f2018-07-02 12:05:07 -07002836 fake_update_response_.rollback = true;
2837 fake_update_response_.rollback_allowed_milestones = 2;
Amin Hassani41ac04b2019-03-29 11:31:03 -07002838 fake_update_response_.deadline = "20101020";
Zentaro Kavanagh0ef9a2f2018-07-02 12:05:07 -07002839 request_params_.set_rollback_allowed_milestones(4);
2840
2841 // Since |request_params_.rollback_allowed_milestones| is 4 but the response
2842 // is constructed with |fake_update_response_.rollback_allowed_milestones| set
2843 // to 2, OmahaRequestAction will look for the key values of N-4 version but
2844 // only the N-2 version will exist.
Amin Hassani41ac04b2019-03-29 11:31:03 -07002845 tuc_params_.http_response = fake_update_response_.GetUpdateResponse();
2846 tuc_params_.is_consumer_device = false;
2847 tuc_params_.rollback_allowed_milestones = 2;
2848 tuc_params_.is_policy_loaded = true;
Zentaro Kavanagh0ef9a2f2018-07-02 12:05:07 -07002849
Amin Hassani41ac04b2019-03-29 11:31:03 -07002850 EXPECT_TRUE(TestUpdateCheck());
2851 EXPECT_TRUE(response.update_exists);
Zentaro Kavanagh0ef9a2f2018-07-02 12:05:07 -07002852 EXPECT_TRUE(response.is_rollback);
2853 EXPECT_EQ(std::numeric_limits<uint16_t>::max(),
2854 response.past_rollback_key_version.firmware_key);
2855 EXPECT_EQ(std::numeric_limits<uint16_t>::max(),
2856 response.past_rollback_key_version.firmware);
2857 EXPECT_EQ(std::numeric_limits<uint16_t>::max(),
2858 response.past_rollback_key_version.kernel_key);
2859 EXPECT_EQ(std::numeric_limits<uint16_t>::max(),
2860 response.past_rollback_key_version.kernel);
2861}
2862
Matt Ziegelbaumaa8e1a42019-05-09 21:41:58 -04002863TEST_F(OmahaRequestActionTest, IncludeRequisitionTest) {
2864 request_params_.set_device_requisition("remora");
2865 tuc_params_.http_response = fake_update_response_.GetUpdateResponse();
2866 ASSERT_TRUE(TestUpdateCheck());
2867 EXPECT_NE(string::npos, post_str.find("requisition=\"remora\""));
2868}
2869
2870TEST_F(OmahaRequestActionTest, NoIncludeRequisitionTest) {
2871 request_params_.set_device_requisition("");
2872 tuc_params_.http_response = fake_update_response_.GetUpdateResponse();
2873 ASSERT_TRUE(TestUpdateCheck());
2874 EXPECT_EQ(string::npos, post_str.find("requisition"));
2875}
2876
Amin Hassani2cbb0692019-10-30 13:36:17 -07002877TEST_F(OmahaRequestActionTest, PersistEolDateTest) {
Jae Hoon Kim051627a2019-09-03 12:56:32 -07002878 tuc_params_.http_response =
2879 "<?xml version=\"1.0\" encoding=\"UTF-8\"?><response "
2880 "protocol=\"3.0\"><app appid=\"foo\" status=\"ok\">"
2881 "<ping status=\"ok\"/><updatecheck status=\"noupdate\" "
Amin Hassani2cbb0692019-10-30 13:36:17 -07002882 "_eol_date=\"200\" _foo=\"bar\"/></app></response>";
2883 tuc_params_.expected_check_result = metrics::CheckResult::kNoUpdateAvailable;
2884 tuc_params_.expected_check_reaction = metrics::CheckReaction::kUnset;
2885
2886 ASSERT_TRUE(TestUpdateCheck());
2887
2888 string eol_date;
2889 EXPECT_TRUE(
2890 fake_system_state_.prefs()->GetString(kPrefsOmahaEolDate, &eol_date));
2891 EXPECT_EQ("200", eol_date);
2892}
2893
2894TEST_F(OmahaRequestActionTest, PersistEolMissingDateTest) {
2895 tuc_params_.http_response =
2896 "<?xml version=\"1.0\" encoding=\"UTF-8\"?><response "
2897 "protocol=\"3.0\"><app appid=\"foo\" status=\"ok\">"
2898 "<ping status=\"ok\"/><updatecheck status=\"noupdate\" "
Jae Hoon Kim051627a2019-09-03 12:56:32 -07002899 "_foo=\"bar\"/></app></response>";
2900 tuc_params_.expected_check_result = metrics::CheckResult::kNoUpdateAvailable;
2901 tuc_params_.expected_check_reaction = metrics::CheckReaction::kUnset;
2902
Jae Hoon Kimb3146742019-11-07 13:24:24 -08002903 const string kDate = "123";
2904 fake_system_state_.prefs()->SetString(kPrefsOmahaEolDate, kDate);
2905
Jae Hoon Kim051627a2019-09-03 12:56:32 -07002906 ASSERT_TRUE(TestUpdateCheck());
2907
Amin Hassani2cbb0692019-10-30 13:36:17 -07002908 string eol_date;
Jae Hoon Kimb3146742019-11-07 13:24:24 -08002909 EXPECT_TRUE(
Jae Hoon Kim051627a2019-09-03 12:56:32 -07002910 fake_system_state_.prefs()->GetString(kPrefsOmahaEolDate, &eol_date));
Jae Hoon Kimb3146742019-11-07 13:24:24 -08002911 EXPECT_EQ(kDate, eol_date);
Jae Hoon Kim051627a2019-09-03 12:56:32 -07002912}
2913
Amin Hassani2cbb0692019-10-30 13:36:17 -07002914TEST_F(OmahaRequestActionTest, PersistEolBadDateTest) {
Jae Hoon Kim051627a2019-09-03 12:56:32 -07002915 tuc_params_.http_response =
2916 "<?xml version=\"1.0\" encoding=\"UTF-8\"?><response "
2917 "protocol=\"3.0\"><app appid=\"foo\" status=\"ok\">"
2918 "<ping status=\"ok\"/><updatecheck status=\"noupdate\" "
Amin Hassani2cbb0692019-10-30 13:36:17 -07002919 "_eol_date=\"bad\" foo=\"bar\"/></app></response>";
Jae Hoon Kim051627a2019-09-03 12:56:32 -07002920 tuc_params_.expected_check_result = metrics::CheckResult::kNoUpdateAvailable;
2921 tuc_params_.expected_check_reaction = metrics::CheckReaction::kUnset;
2922
2923 ASSERT_TRUE(TestUpdateCheck());
2924
Amin Hassani2cbb0692019-10-30 13:36:17 -07002925 string eol_date;
Jae Hoon Kim051627a2019-09-03 12:56:32 -07002926 EXPECT_TRUE(
2927 fake_system_state_.prefs()->GetString(kPrefsOmahaEolDate, &eol_date));
2928 EXPECT_EQ(kEolDateInvalid, StringToEolDate(eol_date));
2929}
2930
Andrew065d78d2020-04-07 15:43:07 -07002931TEST_F(OmahaRequestActionDlcPingTest, StorePingReplyNoPing) {
2932 OmahaRequestParams::AppParams app_param = {.name = dlc_id_};
Andrewe045aef2020-01-08 16:29:22 -08002933 request_params_.set_dlc_apps_params(
Andrew065d78d2020-04-07 15:43:07 -07002934 {{request_params_.GetDlcAppId(dlc_id_), app_param}});
Andrewe045aef2020-01-08 16:29:22 -08002935
2936 ASSERT_TRUE(TestUpdateCheck());
Andrew065d78d2020-04-07 15:43:07 -07002937
2938 int64_t temp_int;
Andrewe045aef2020-01-08 16:29:22 -08002939 // If there was no ping, the metadata files shouldn't exist yet.
Andrew065d78d2020-04-07 15:43:07 -07002940 EXPECT_FALSE(fake_prefs_.GetInt64(active_key_, &temp_int));
2941 EXPECT_FALSE(fake_prefs_.GetInt64(last_active_key_, &temp_int));
2942 EXPECT_FALSE(fake_prefs_.GetInt64(last_rollcall_key_, &temp_int));
Andrewe045aef2020-01-08 16:29:22 -08002943}
2944
Andrew065d78d2020-04-07 15:43:07 -07002945TEST_F(OmahaRequestActionDlcPingTest, StorePingReplyActiveTest) {
Andrewe045aef2020-01-08 16:29:22 -08002946 // Create Active value
Andrew065d78d2020-04-07 15:43:07 -07002947 fake_prefs_.SetInt64(active_key_, 0);
Andrewe045aef2020-01-08 16:29:22 -08002948
2949 OmahaRequestParams::AppParams app_param = {
2950 .active_counting_type = OmahaRequestParams::kDateBased,
Andrew065d78d2020-04-07 15:43:07 -07002951 .name = dlc_id_,
Andrewe045aef2020-01-08 16:29:22 -08002952 .ping_active = 1,
2953 .send_ping = true};
2954 request_params_.set_dlc_apps_params(
Andrew065d78d2020-04-07 15:43:07 -07002955 {{request_params_.GetDlcAppId(dlc_id_), app_param}});
Andrewe045aef2020-01-08 16:29:22 -08002956
Andrew065d78d2020-04-07 15:43:07 -07002957 int64_t temp_int;
2958 string temp_str;
Andrewe045aef2020-01-08 16:29:22 -08002959 ASSERT_TRUE(TestUpdateCheck());
Andrew065d78d2020-04-07 15:43:07 -07002960 EXPECT_TRUE(fake_prefs_.GetInt64(active_key_, &temp_int));
Andrewe045aef2020-01-08 16:29:22 -08002961 EXPECT_EQ(temp_int, kPingInactiveValue);
Andrew065d78d2020-04-07 15:43:07 -07002962 EXPECT_TRUE(fake_prefs_.GetString(last_active_key_, &temp_str));
2963 EXPECT_EQ(temp_str, "4763");
2964 EXPECT_TRUE(fake_prefs_.GetString(last_rollcall_key_, &temp_str));
2965 EXPECT_EQ(temp_str, "4763");
Andrewe045aef2020-01-08 16:29:22 -08002966}
2967
Andrew065d78d2020-04-07 15:43:07 -07002968TEST_F(OmahaRequestActionDlcPingTest, StorePingReplyInactiveTest) {
Andrewe045aef2020-01-08 16:29:22 -08002969 // Create Active value
Andrew065d78d2020-04-07 15:43:07 -07002970 fake_prefs_.SetInt64(active_key_, 0);
Andrewe045aef2020-01-08 16:29:22 -08002971
2972 OmahaRequestParams::AppParams app_param = {
2973 .active_counting_type = OmahaRequestParams::kDateBased,
Andrew065d78d2020-04-07 15:43:07 -07002974 .name = dlc_id_,
Andrewe045aef2020-01-08 16:29:22 -08002975 .ping_active = 0,
2976 .send_ping = true};
2977 request_params_.set_dlc_apps_params(
Andrew065d78d2020-04-07 15:43:07 -07002978 {{request_params_.GetDlcAppId(dlc_id_), app_param}});
Andrewe045aef2020-01-08 16:29:22 -08002979
2980 // Set the previous active value to an older value than 4763.
Andrew065d78d2020-04-07 15:43:07 -07002981 fake_prefs_.SetString(last_active_key_, "555");
Andrewe045aef2020-01-08 16:29:22 -08002982
Andrew065d78d2020-04-07 15:43:07 -07002983 int64_t temp_int;
Andrewe045aef2020-01-08 16:29:22 -08002984 ASSERT_TRUE(TestUpdateCheck());
Andrew065d78d2020-04-07 15:43:07 -07002985 EXPECT_TRUE(fake_prefs_.GetInt64(active_key_, &temp_int));
Andrewe045aef2020-01-08 16:29:22 -08002986 EXPECT_EQ(temp_int, kPingInactiveValue);
Andrew065d78d2020-04-07 15:43:07 -07002987 string temp_str;
2988 EXPECT_TRUE(fake_prefs_.GetString(last_active_key_, &temp_str));
2989 EXPECT_EQ(temp_str, "555");
2990 EXPECT_TRUE(fake_prefs_.GetString(last_rollcall_key_, &temp_str));
2991 EXPECT_EQ(temp_str, "4763");
Andrewe045aef2020-01-08 16:29:22 -08002992}
2993
Darin Petkov6a5b3222010-07-13 14:55:28 -07002994} // namespace chromeos_update_engine